Re: Coding guidelines. Useless JavaDoc comments.

2019-08-07 Thread Павлухин Иван
Hi, Denis, thank you for starting this discussion! My opinion here is that having a good javadoc for every class and method is not feasible in the real world. I am quite curious to see a non-trivial project which follows it. Also, all comments and javadocs are prone to become misleading when code

Re: Partition loss event

2019-08-07 Thread Павлухин Иван
Ilya, I am not sure that enabling subset of events will fit all needs. If we would like to do so then it might be good idea to make it clear in API that certain events are enabled by default (e.g. put them into separate class). Also we should be careful with backward compatibility, some kind of e

Re: SecurityTestSuite as a separate test suite at TC

2019-08-07 Thread Павлухин Иван
Denis, Could you please provide more details why do we need to run these tests in forked JVM? Still, having separate security suite on TC sounds not bad. ср, 7 авг. 2019 г. в 09:35, Vyacheslav Daradur : > > Hi Denis. > > I think it is fine to extract security tests in a separate build plan on TC

Re: Coding guidelines. Useless JavaDoc comments.

2019-08-08 Thread Павлухин Иван
tic final long serialVersionUID = 0L; > > > > or > > > > /** */ > > > > @LoggerResource > > > > private IgniteLogger log; > > > > > > > > There are more than 8000 lines of /** */ only at the ignite-core > > module (do > &g

Re: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-08 Thread Павлухин Иван
> What's the scope for this release? Same question. On the other hand an idea of 2.7.6 release attracts me because having a practice of doing frequent minor releases can help us to build reliable and predictable release rails. чт, 8 авг. 2019 г. в 15:09, Ilya Kasnacheev : > > Hello! > > What's t

Re: SQL query timeout: in progress or abandoned

2019-08-08 Thread Павлухин Иван
Just for the protocol. There was an original dev-list discussion [1]. Added a link to the ticket as well. [1] http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-7285-Add-default-query-timeout-td41828.html пт, 9 авг. 2019 г. в 01:22, Denis Magda : > > Hey Saikat, > > Are you still worki

Re: [EXTERNAL] Re: Replace or Put after PutAsync causes Ignite to hang

2019-08-08 Thread Павлухин Иван
Ilya, Pavel, Do we a have a proposal how to fix the root cause of the problem? Should we a have a ticket for it? ср, 7 авг. 2019 г. в 17:48, Ilya Kasnacheev : > > Hello! > > I think we should definitely stop running futures out of striped pool, > while holding any cache logs (stripe thread counts

Re: Coding guidelines. Useless JavaDoc comments.

2019-08-10 Thread Павлухин Иван
nion race. > > > > I'd prefer to leave the current situation with Javadoc as it is and > > just to ask to apply the patch [1][2]. Can you? :-) > > > > [1] https://issues.apache.org/jira/browse/IGNITE-12051 > > [2] https://github.com/apache/ignite/pull/6760 > &

Re: Issue with the TC disk space

2019-08-12 Thread Павлухин Иван
Folks, I asked about TC infrastructure problems before and did not get answers. Does any of you know how to fix problems of that sort? Should not the process be transparent for a community members? пн, 12 авг. 2019 г. в 11:00, Dmitriy Pavlov : > > I also see some issues with 2.7.6 testing. Hopefu

Re: Replacing NodeFilter functionality with label approach

2019-08-12 Thread Павлухин Иван
d on correctness during node start. > > But we still don't have any real examples that require more flexibility > > than labels have. > > > > вт, 6 авг. 2019 г. в 14:46, Павлухин Иван : > > > > > Alexey, > > > > > > It seems that a problem

Re: SecurityTestSuite as a separate test suite at TC

2019-08-12 Thread Павлухин Иван
; >>>> Surefite documentation [1] says: > >>>> If forkCount=0, it's impossible to use the system class loader or a > >>>> plain old Java classpath; we have to use an isolated class loader. > >>>> > >>>> When using

Re: Re[2]: Asynchronous registration of binary metadata

2019-08-14 Thread Павлухин Иван
Denis, Several clarifying questions: 1. Do you have an idea why metadata registration takes so long? So poor disks? So many data to write? A contention with disk writes by other subsystems? 2. Do we need a persistent metadata for in-memory caches? Or is it so accidentally? Generally, I think that

Re: Thin client: transactions support

2019-08-15 Thread Павлухин Иван
h responses dedicated thread is used. > > In a draft implementation of IGNITE-11685 I've used another approach: each > > request thread can read a response (if lock is acquired by this thread > > successfully) and complete a future of its own request or another threads &g

Re: IGNITE-7285 Add default query timeout

2019-08-15 Thread Павлухин Иван
Just to keep history connected. The discussion continued in http://apache-ignite-developers.2346864.n4.nabble.com/SQL-query-timeout-in-progress-or-abandoned-td42964.html вт, 18 июн. 2019 г. в 12:22, Павлухин Иван : > > Hi Saikat, > > Thank you for driving it. I left my comments [1]. &

Re: SQL query timeout: in progress or abandoned

2019-08-15 Thread Павлухин Иван
e/ignite/pull/6490/files > > > > > > I wanted to discuss if it is correct intended usage of Default Query > > > Timeout or should we reconsider? > > > > > > Regards, > > > Saikat > > > > > > > > > > > > On Fr

Re: Re[2]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-15 Thread Павлухин Иван
Please add this BTree corruption fix to the scope: > > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-11953 > > > > > > > > > > > > > > > > > > > > > > Plus, I would upgrade our Spar

Re: Re[4]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-16 Thread Павлухин Иван
gt; > > > : > > >> >> > > > > > > > Hi al,, i also suggest to append [1], cause it could > > >> produce > > >> >> > > > > > > > CorruptedTreeException in some scenario. > >

Re: Re[4]: Apache Ignite 2.7.6 (Time, Scope, and Release manager)

2019-08-16 Thread Павлухин Иван
picked without conflicts, just push it. > > > > If it contains conflicts it is better to push to 2.7.6-based branch and > > start additional run-all, example > > https://github.com/apache/ignite/pull/6781 -it is PR for ignite-9562, > > base: 2.7.6 > > &g

Re: SQL query timeout: in progress or abandoned

2019-08-20 Thread Павлухин Иван
SqlFieldsQuery and >> SqlQuery. >> >> >> Regards, >> >> Saikat >> >> >> >> On Thu, Aug 15, 2019 at 6:13 AM Павлухин Иван >> wrote: >> >>> Saikat, Denis, >>> >>> I left comments in the ticket [1]. >&g

Re: Metastore disappears in Docker on restarts

2019-08-23 Thread Павлухин Иван
Denis, Actually binary metadata is not stored in a metastore (however there were a discussion about moving it). User scenario is valid. A meaningful exception and documentation are good. And also I can think about revisiting a needed configuration for persistence in containerized environments. It

Re: Replacing default work dir from tmp to current dir

2019-08-25 Thread Павлухин Иван
Ilya, 2 points: 1. It is a good point that a directory name "work" in arbitrary place can cause a lot of confusion. 2. As far as I got, default directory is not in e.g. /home/username but in one pointed by "user.dir" system property which is a directory where a java process started (if property wa

Re: Making Ignite Collaboration 100% Open and Transparent

2019-08-28 Thread Павлухин Иван
+ Meeting minutes 2019-08-28 22:29 GMT+11:00, Alexey Zinoviev : > I am totally support the idea with the planned and widely announced Hangout > meeting between commiters and contributers and posting the link to the > dev-list with the special Topic Name and short agenda. Maybe, the recorded > vide

Re: New Сommitter: Maxim Muzafarov

2019-08-28 Thread Павлухин Иван
Maxim, my congratulations! 2019-08-29 7:25 GMT+11:00, Andrey Kuznetsov : > Great news! Congratulations! > > ср, 28 авг. 2019 г., 18:28 Alex Plehanov : > >> Maxim, congratulations! >> >> ср, 28 авг. 2019 г. в 18:13, Nikita Amelchev : >> >> > My congratulations, Maxim! >> > >> > ср, 28 авг. 2019 г.

Re: Non-blocking PME discussion, ASF Slack, September 10, 13.00 (MSK)

2019-09-10 Thread Павлухин Иван
Anton, Thank you very much for performing the discussion! I found it pretty much useful. And I really like such kind of collaboration and hope that we will go forward in that direction. Looking forward for meeting minutes and slides. вт, 10 сент. 2019 г. в 10:24, Alexey Goncharuk : > > Anton, >

Re: Text queries/indexes (GridLuceneIndex, @QueryTextFiled)

2019-09-19 Thread Павлухин Иван
Yuriy, Greatly appreciate your interest. Could you please elaborate a little bit about sorting? What tasks does it help to solve and how? It would be great to provide an example. ср, 18 сент. 2019 г. в 09:39, Alexei Scherbakov : > > Denis, > > I like the idea of throwing an exception for enabled

Re: Non-blocking PME Phase One (Node fail)

2019-09-19 Thread Павлухин Иван
Anton, folks, Out of curiosity. Do we have some measurements of PME execution in an environment similar to some real-world one? In my mind some kind of "profile" showing durations of different PME phases with an indication where we are "blocked" would be ideal. ср, 18 сент. 2019 г. в 13:27, Anton

Re: A question

2019-09-24 Thread Павлухин Иван
Hi Maria, Yes, it should work with your classes. It worth noting, that "lastName" will be accessible in your queries, "SELECT lastName FROM ..." should work. Note that you should use simply "lastName" in SQL but not "general.lastName". By the way, usually it is better to write such questions to I

Re: Text queries/indexes (GridLuceneIndex, @QueryTextFiled)

2019-09-27 Thread Павлухин Иван
r itself should improve the part of issues from above, but > definitely, sorting by document score at least should be implemented along > with limit. > > This is a pretty short commentary if you still have any questions, please > ask, do not hesitate) > > BR, > Yuriy Shuliha > &

Re: Class field ThreadLocal. Why not static?

2018-09-10 Thread Павлухин Иван
Guys, As we know ThreadLocal is an instrument which should be used with great care. And I recently faced with problems related to proper cleanup of ThreadLocal which is not needed anymore. In my opinion the best thing (in ideal world) is to get rid of ThreadLocal where possible, but I guess that i

Re: Class field ThreadLocal. Why not static?

2018-09-11 Thread Павлухин Иван
t; вт, 11 сент. 2018 г. в 9:13, Павлухин Иван : > > > Guys, > > > > As we know ThreadLocal is an instrument which should be used with great > > care. And I recently faced with problems related to proper cleanup of > > ThreadLocal which is not needed anymore. In my

Re: Class field ThreadLocal. Why not static?

2018-09-11 Thread Павлухин Иван
Dmitriy, Could you point to some piece of code implementing described pattern? 2018-09-11 13:02 GMT+03:00 Павлухин Иван : > Alex, > > ThreadLocal subclass is used in IgniteH2Indexing for simple access to H2 > Connection from current thread. Such subclass has a capability to create

Re: Class field ThreadLocal. Why not static?

2018-09-13 Thread Павлухин Иван
0%wal.IgniteWalRecoveryTest0% > > * sys-#148%wal.IgniteWalRecoveryTest1% > > * db-checkpoint-thread-#129%wal.IgniteWalRecoveryTest2% > > Suppose everything would be OK here for `static` and `non-static` case of > > ThreadLocal. > > > > [1] > > > > h

Re: TeamCity Helper shows new failures in PRs

2018-09-14 Thread Павлухин Иван
Hi guys! Webinar sounds as good idea. But could you please shortly describe the main webinar theme? For those who are out of context =) 2018-09-14 10:33 GMT+03:00 Dmitrii Ryabov : > Hi, Dmitriy, > > Webinar is good, but we need a page on the wiki (or "help" in the bot) for > new contributors. Af

Re: TeamCity Helper shows new failures in PRs

2018-09-14 Thread Павлухин Иван
Dmitry, I cannot confirm invitation. Do I need special permissions for dev@ignite.apache.org calendar? 2018-09-14 12:24 GMT+03:00 Dmitriy Pavlov : > Please see the invitation as a separate thread. Could you please also > confirm invitation came? > > пт, 14 сент. 2018 г. в 12:13, П

IgniteEvents for MVCC caches

2018-09-21 Thread Павлухин Иван
Hi Igniters, As you might know MVCC was introduced in Apache Ignite. We started IgniteEvents implementation for MVCC caches and faced some obstacles. I would like to start a discussion about next steps which should be done to deal with current problems. -- Best regards, Ivan Pavlukhin

Re: IgniteEvents for MVCC caches

2018-09-21 Thread Павлухин Иван
Currently I do not see options how to overcome it. Also, I hardly imagine current use cases for cache events. I think that understanding them is the best way for developing working solution for MVCC. I need your opinions. 2018-09-21 12:54 GMT+03:00 Павлухин Иван : > Hi Igniters, > > As

Re: IgniteEvents for MVCC caches

2018-09-24 Thread Павлухин Иван
gt; little value nowadays. Does anyone have something against deprecating > > > them? > > > > > > > > > These events are used in a pure caching or in-memory data grid use > cases > > > where key-value is a primary access pattern. I personally k

Re: [Discussion] revert of commit MVCC, ignite-9320

2018-09-28 Thread Павлухин Иван
Hi guys! By the way, is it practically feasible to revert a single commit without making harm? If I am getting it right in current case reverting commit will lead to compilation errors for commits depending on commit in question. 2018-09-28 14:22 GMT+03:00 Dmitriy Pavlov : > Hi Dmitriy S., > > I

Re: I want to contribute | Help Needed

2018-10-15 Thread Павлухин Иван
Hi Snigdhadeb, Welcome to Apache Ignite Community! Usually each contribution is related to a ticket in Jira https://issues.apache.org/jira/projects/IGNITE. Do you have such ticket already? To start working on a ticket you need to get a contributor rights to assign ticket to yourself. Please share

Re: Apache Ignite 2.7. Last Mile

2018-10-17 Thread Павлухин Иван
Hi NIkolay, Thank you for keeping everybody focused! Regarding to my ticket IGNITE-5935. It is in final stage now. Tests look good. I believe that it will be merged in couple of days (at most). ср, 17 окт. 2018 г. в 11:39, Nikolay Izhikov : > Hello, Igniters. > > 9 tickets to go! > > Alexey Gonc

Re: Applicability of term 'cache' to Apache Ignite

2018-10-18 Thread Павлухин Иван
HI all, +1 for "table" from me. For me "table" has several benefits: 1. It's common and consequently easy to explain and understand. 2. It's quite universal. One can worry that "table" does not describes key-value storage well. I don't see any problem here, because Hash Table data structure co

New TC builds adding process

2018-10-19 Thread Павлухин Иван
Hi Igniters, On Friday I felt a real inconvenience (pain in ass) with running builds for a ticked I worked on [1]. There were two the most frustrating moments: 1. Estimated build completion time was 11 hours after the start. 2. There are newly added suites which are failing constantly in recent ru

Re: [MTCGA]: new failures in builds [2123440] needs to be handled

2018-10-20 Thread Павлухин Иван
Hi Anton, I ran a problematic build against my contribution [1] and it seems to pass fine. Then I ran the build against your PR branch and it hanged [2]. There is nothing surprising that it fired only in master because the build was added to RunAll after your PR runs. Could you please take a look?

Re: New TC builds adding process

2018-10-22 Thread Павлухин Иван
> > > So we don't need to approve any change by discussion, but keeping > community > > member posted seems to be really helpful here. > > > > Currently, I don't know why and which suites were added. > > > > Sincerely, > > Dmitriy Pavlov > >

Re: Abbreviation code-style requirement.

2018-10-22 Thread Павлухин Иван
Hi all, I also think that abbreviations should not be mandatory (point 3). But what I am worrying about is a conflict resolution between a patch submitter and a reviewer. How to come to an agreement when one side is strictly for and another side is strictly against using abbreviations in some conc

Re: Pre-touch for Ignite off-heap memory

2018-10-24 Thread Павлухин Иван
Hi Alex, I wonder what problem you wish to solve. Pre-touching memory looks like a solution. But what is the problem? Am I getting it right that it is desired to avoid OOM (of some kind) in unpredictable moment of Ignite process execution? If so there could be number of ways to tackle it. I am no

Re: Pre-touch for Ignite off-heap memory

2018-10-29 Thread Павлухин Иван
Hi guys, I am not aware that it is possible to run JVM in "allocation-free" fashion. If you know that it is possible please share it. As I know JVM allocates memory out of garbage collectable area for internal purposes like JIT, GC itself. Also native built-it code can request memory allocation fr

Re: Pre-touch for Ignite off-heap memory

2018-10-31 Thread Павлухин Иван
observe JVM OOM-killed. [1] https://github.com/apache/ignite/pull/5220 [2] https://gist.github.com/pavlukhin/e5e6605e9b4366627ba8d1aab42f#file-hs_err_pid5763-log [3] https://gist.github.com/pavlukhin/e5e6605e9b4366627ba8d1aab42f#file-hs_err_pid6411-log вт, 30 окт. 2018 г. в 9:19, Павлухин

Re: Abbreviation code-style requirement.

2018-11-01 Thread Павлухин Иван
Hi Yakov and all, Recently I went through abbreviations list [1] to find items which are not clear for me. After the list was shortened by Yakov and others most of them have gone. But pay attention to "lic -> license". I cannot find usages of it in Ignite codebase? Could it be removed as well? An

Re: Abbreviation code-style requirement.

2018-11-02 Thread Павлухин Иван
Andrey, Yakov, Actually my concert is more about one-time contributions. I imagine the following. Someone finds a bug a decides to contribute a fix. I think it is quite common scenario in Open Source. He creates a PR and awaits a review. I think that a smooth and fast review process will encourage

Re: Abbreviation code-style requirement.

2018-11-02 Thread Павлухин Иван
; > to some project, it's ok to adopt that project rules. Moreover, reviewing > > committer can silently fix minor code style issues himself upon merge. > > > > пт, 2 нояб. 2018 г. в 10:08, Павлухин Иван : > > > > > Andrey, Yakov, > > > > > &

Re: Is it time to move forward to JUnit4 (5)?

2018-11-08 Thread Павлухин Иван
Hi Oleg, Migrating to Junit 4 sounds as great idea. I believe everybody is quite surprised when finds Junit 3 in Ignite. But for me personally it is good to understand what problem we are trying to solve? What benefits will Junit 4 give us? What are the most painful moments with current testing fr

Re: [DISCUSSION] The process of creating an Ignite Enhancement Proposal

2018-11-08 Thread Павлухин Иван
Hi Maxim, Single IEP per a major change looks desirable for me. But I have doubts that it is always feasible. Regarding naming. Could you please provide a couple of examples of inaccurate names and how they might have been improved? чт, 8 нояб. 2018 г. в 21:19, Maxim Muzafarov : > Vladimir, >

Re: Is it time to move forward to JUnit4 (5)?

2018-11-09 Thread Павлухин Иван
se pilot changes will help us estimate with concrete code how much > effort > could be involved in maintaining "twin" classes in sync (you are absolutely > right pointing that this is concerning). If it turns out too complicated to > sync we would probably switch to something l

Re: Is it time to move forward to JUnit4 (5)?

2018-11-11 Thread Павлухин Иван
ldTypeId=IgniteTests24Java8_RunAll пт, 9 нояб. 2018 г. в 17:30, Павлухин Иван : > > Hi Oleg, > > I can outline some motivating ideas. There is no agreed solutions yet, > but junit4 might help us in reusing existing tests for improving MVCC > coverage. Another area is managing RunAll execution time w

Re: Suggestion to improve deadlock detection

2018-11-14 Thread Павлухин Иван
Hi, Next part as promised. A working item for me is a deadlock detector for MVCC transactions [1]. The message is structured in 2 parts. First is an analysis of the current state of affairs and possible options to go. Second is a proposed option. First part is going to be not so short so some migh

Re: Time to remove automated messages from the devlist?

2018-11-15 Thread Павлухин Иван
Hi, In my opinion there should be only development discussions and important notifications on dev list. But I must say that I started to look through Jira and even GitHub notifications from time to time. And I find that it sometimes gives me a useful information like "contributor A is doing B". Bu

Re: Time to remove automated messages from the devlist?

2018-11-16 Thread Павлухин Иван
Oleg, I join to Dmitriy. I found your summary quite interesting. пт, 16 нояб. 2018 г. в 13:12, Dmitriy Pavlov : > > Oleg, > > excellent research! It allows me to avoid bothering community developers > once again. > > Thank you for your efforts and for contributing to this discussion. > > Sincerely

Re: Time to remove automated messages from the devlist?

2018-11-16 Thread Павлухин Иван
C Bot - I'm sure - should never be redirected. Hopefully, it will not > > > generate any alerts. > > > > > > I hardly understand goal: is our target metric - message count to be as > > > less as possible? (extreme - 0 emails, let's not write

Re: Suggestion to improve deadlock detection

2018-11-17 Thread Павлухин Иван
a is already researched throughly enough, so we should > be able to find an answer quickly. > > Vladimir. > > [1] http://www.cse.scu.edu/~jholliday/dd_9_16.htm > [2] https://www.cs.uic.edu/~ajayk/Chapter10.pdf > [3] > https://www.cs.utexas.edu/users/misra/scannedPdf.dir/D

Re: Brainstorm: Make TC Run All faster

2018-11-19 Thread Павлухин Иван
Hi, I would like to understand following. We are going to make TC green. We are going to make TC fast. Are we going to do it in parallel? пн, 19 нояб. 2018 г. в 08:39, Petr Ivanov : > > Concerning current TeamCity compute capacity — I think we should invest into > it’s stability at first: there a

Re: [ANNOUNCE] Welcome Igor Seliverstov as a new committer

2018-11-20 Thread Павлухин Иван
Igor my congratulations! Keep going! 2018-11-20 9:01 GMT+01:00, Vladimir Ozerov : > The Apache Ignite Project Management Committee (PMC) has invited Igor > Seliverstov to become a new committer and are happy to announce that he has > accepted. > > Igor contributed a lot to "Transactional SQL" feat

Re: Time to remove automated messages from the devlist?

2018-11-21 Thread Павлухин Иван
want > >> to receive these emails. > >> This is much more convenient and more flexible than filtering emails from > >> a > >> bot. > >> > >> So, most people ignore JIRA messages, and the ones who want to track new > >> ticket

Re: Ignite web console on kubernetes with ingress

2018-11-21 Thread Павлухин Иван
Hi Vishwas, Are you going to do some contribution related to your question? If not then you could ask the same question on u...@ignite.apache.org User list exists exactly for asking questions related to usability problems and most likely you will get an answer there. ср, 21 нояб. 2018 г. в 10:26,

Re: proposed realization KILL QUERY command

2018-11-22 Thread Павлухин Иван
Hi, May be I am a little bit late with my thoughts about a command syntax. How do I see it is going to be used: 1. A user is able to kill a query by unique id belonging only to this query. 2. A user is able to kill all queries started by a specific node. For killing a single query we must identify

Re: Rename "cache group" to "tablespace"?

2018-11-22 Thread Павлухин Иван
Hi Vladimir, How do you see a default tablespace configuration in the "bright" future? Is it going to be a single file for an Ignite instance? In what cases will be there benefits to explicitly configure additional tablespaces? By the way was the name "tablespace" hand-crafted or it was it borrowe

Re: Brainstorm: Make TC Run All faster

2018-11-23 Thread Павлухин Иван
нояб. 2018 г. в 14:34, Павлухин Иван : > > Hi, > > I would like to understand following. We are going to make TC green. > We are going to make TC fast. Are we going to do it in parallel? > пн, 19 нояб. 2018 г. в 08:39, Petr Ivanov : > > > > Concerning current TeamCity

Re: Suggestion to improve deadlock detection

2018-11-24 Thread Павлухин Иван
bserved. May be something else. > > On Sun, Nov 18, 2018 at 10:21 AM Павлухин Иван wrote: > > > Vladimir, > > > > Thanks for the articles! I studied them and a couple of others. And I > > would like to sh

Re: Historical rebalance

2018-11-26 Thread Павлухин Иван
Igor, Could you please clarify some points? > 1) preserve list of active txs, sorted by the time of their first update > (using WAL ptr of first WAL record in tx) Is this list maintained per transaction or per checkpoint (or per something else)? Why can't we track only oldest active transaction

Re: Suggestion to improve deadlock detection

2018-11-26 Thread Павлухин Иван
request for the given pair (NODE_ID, COUNTER) should be requested at most > once. This way, even if specific deadlock check request is lost due to node > failure, and another deadlock has formed, then some other node will > re-trigger deadlock change request sooner or later, as it's cou

Re: [VOTE] Creation dedicated list for github notifiacations

2018-11-26 Thread Павлухин Иван
+1 вт, 27 нояб. 2018 г. в 09:22, Dmitrii Ryabov : > > 0 > вт, 27 нояб. 2018 г. в 02:33, Alexey Kuznetsov : > > > > +1 > > Do not forget notification from GitBox too! > > > > On Tue, Nov 27, 2018 at 2:20 AM Zhenya wrote: > > > > > +1, already make it by filers. > > > > > > > This was discussed alre

Re: proposed realization KILL QUERY command

2018-11-26 Thread Павлухин Иван
3, 2018 at 9:32 AM Павлухин Иван wrote: > > > Hi, > > > > May be I am a little bit late with my thoughts about a command syntax. > > How do I see it is going to be used: > > 1. A user is able to kill a query by unique id belonging only to this > > query. > &

Re: Brainstorm: Make TC Run All faster

2018-11-27 Thread Павлухин Иван
Roman, Do you have some expectations how faster "correlated" tests elimination will make Run All? Also do you have a vision how can we determine such "correlated" tests, can we do it relatively fast? But all in all, I am not sure that reducing a group of correlated tests to only one test can show

Re: [ANNOUNCE] Welcome Ilya Kasnacheev as a new committer

2018-11-27 Thread Павлухин Иван
Ilya, my congratulations! вт, 27 нояб. 2018 г. в 13:56, Dmitriy Pavlov : > > Dear Igniters, > > > > It is last but not least announce. The Apache Ignite Project Management > Committee (PMC) has invited Ilya Kasnacheev to become a new committer and > are happy to announce that he has accepted. > > >

Re: Historical rebalance

2018-11-28 Thread Павлухин Иван
Hi, Regarding Vladimir's new idea. > We assume that transaction can be represented as a set of independent > operations, which are applied in the same order on both primary and backup > nodes. I have not got why we can assume that reordering is not possible. What have I missed? вт, 27 нояб. 2018

Re: Historical rebalance

2018-11-28 Thread Павлухин Иван
ср, 28 нояб. 2018 г. в 13:26, Павлухин Иван : > > Hi, > > Regarding Vladimir's new idea. > > We assume that transaction can be represented as a set of independent > > operations, which are applied in the same order on both primary and backup > > nodes. &

Re: lost partition recovery with native persistence

2018-11-28 Thread Павлухин Иван
Hi Roman, Also you could check if your problem is mentioned in another discussion related to lost partitions [1]. [1] http://apache-ignite-developers.2346864.n4.nabble.com/Partition-Loss-Policies-issues-td37304.html ср, 28 нояб. 2018 г. в 19:31, novicr : > > Resending this to bubble up to the to

Re: Historical rebalance

2018-11-28 Thread Павлухин Иван
separate facilities providing transactions and durability. And it seems to me that those facilities are in different dimensions. ср, 28 нояб. 2018 г. в 16:26, Павлухин Иван : > > Sorry, if it was stated that a SINGLE transaction updates are applied > in a same order on all replicas then

Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)

2018-11-28 Thread Павлухин Иван
Hi Oleg, I am not ultimately sure that it will not do any harm. Red error highlights are designed to attract attention very well. I can imagine that I will be distracted by every unused import. While usually I rely on "Optimize imports" enabled in the commit dialog in IDEA. But I think that we ca

Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)

2018-11-29 Thread Павлухин Иван
Hi Oleg, First of all I am not against giving it a try. Let's try it. P.S. Did not really get what was the main problem related to IGNITE-10399 [1]. I suppose it should go: simple problem -- fast fix. [1] https://issues.apache.org/jira/browse/IGNITE-10399 чт, 29 нояб. 2018 г. в 16:04, oignatenko

Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)

2018-11-29 Thread Павлухин Иван
Hi Oleg, Thank you for the story. Now I see the concerns better. чт, 29 нояб. 2018 г. в 18:45, oignatenko : > > Hi Ivan, > > > Павлухин Иван wrote > > P.S. Did not really get what was the main problem related to > > IGNITE-10399 [1]. I suppose it should go: simple pr

Re: Partition Loss Policies issues

2018-11-30 Thread Павлухин Иван
Hi Stan, Thank you for revealing (at least for me) one more dark corner in Ignite. As I see from your analysis it looks like a partition loss policy should be taken into account in many places (persistence, different query types, different cache modes). And it seems that with multiple options to c

Re: [VOTE] Apache Ignite 2.7.0 RC1

2018-11-30 Thread Павлухин Иван
+1 (accept Apache Ignite 2.7.0-RC1) пт, 30 нояб. 2018 г. в 13:43, Юрий : > > +1 > > пт, 30 нояб. 2018 г. в 13:25, Anton Vinogradov : > > > +1 > > > > пт, 30 нояб. 2018 г. в 10:05, Seliverstov Igor : > > > > > +1 > > > > > > пт, 30 нояб. 2018 г., 9:59 Nikolay Izhikov nizhi...@apache.org: > > > > > >

Re: [NOTICE] List created: notificati...@ignite.apache.org

2018-11-30 Thread Павлухин Иван
Meanwhile some of us can subscribe for this list. пт, 30 нояб. 2018 г. в 19:09, Denis Magda : > > Yes, the messages have to be redirected. Talk to INFRA please. > > -- > Denis > > On Fri, Nov 30, 2018 at 7:12 AM Dmitriy Pavlov wrote: > > > Hi Eduard, > > > > could you please issue ticket similar t

Re: Historical rebalance

2018-12-02 Thread Павлухин Иван
ay be applied in different order on backup > > nodes. > > >> That's why we need an active tx set > > >> and some sorting by their update times. The idea is to identify a point > > in > > >> time which starting from we may lost some updates. > >

Re: JDBC thin driver: support connection timeout

2018-12-02 Thread Павлухин Иван
Hi Alexander, I have 2 points. 1. According to the jdbc spec [1] setNetworkTimeout method is optional. What user problem we are going to solve by implementing that method? 2. Also I checked another quite popular jdbc driver provided by MariaDB [2]. They ignore an executor argument as well and set

Re: JDBC thin driver: support connection timeout

2018-12-02 Thread Павлухин Иван
Missing ref: [2] https://mvnrepository.com/artifact/org.mariadb.jdbc/mariadb-java-client/2.3.0 2018-12-02 18:31 GMT+03:00, Павлухин Иван : > Hi Alexander, > > I have 2 points. > > 1. According to the jdbc spec [1] setNetworkTimeout method is > optional. What user problem we are

Re: Is it time to move forward to JUnit4 (5)?

2018-12-03 Thread Павлухин Иван
Hi Oleg, I noticed that GridAbstractTest is now capable to run junit4 tests. What are the current recommendations for writing new tests? Can we use junit4 annotation for new tests? пн, 12 нояб. 2018 г. в 19:58, oignatenko : > > Hi Ivan, > > I am currently testing approach you used in pull/5354 in

Re: Default failure handler was changed for tests

2018-12-05 Thread Павлухин Иван
Hi Anton, Could you please summarize what does aforementioned patch made really worse? As I see, the patch added a very good thing -- meaningful failure handler in tests. And I think it is really important. But was is the harm and does it overweight positive result? And why? ср, 5 дек. 2018 г. в

Re: Default failure handler was changed for tests

2018-12-05 Thread Павлухин Иван
do things better, just commit further improvements. And I will > be happy if you contribute some improvements later. > > If you would like to revert by veto, please justify your intent. If you > would discuss it with all community, please feel free to convince me and > others. > >

Re: Default failure handler was changed for tests

2018-12-05 Thread Павлухин Иван
t; > > > On Wed, Dec 5, 2018 at 4:41 PM Anton Vinogradov < > >> a...@apache.org> > >> > > > wrote: > >> > > > > > > > >> > > > > > > > Dmitriy, > >> > > > > > > > > >> > > > > > >

Re: Default failure handler was changed for tests

2018-12-06 Thread Павлухин Иван
enting that idea looks like a cheap refactoring. > > > > > > I don't agree with your term "cheap". > > > Do you think reducing copy paste code not worth it? > > > > > > I see a hundreds issues that bring copypasted code in the product(I

Re: Default failure handler was changed for tests

2018-12-06 Thread Павлухин Иван
's everyone for solution research. > > I'm ok with Nikolay approach in case that's not a final step. > > > > On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван wrote: > > > > > Nikolay, > > > > > > I meant "not expensive" by

Re: java.lang.IllegalAccessError: tried to access field org.h2.util.LocalDateTimeUtils.LOCAL_DATE from class org.apache.ignite.internal.processors.query.h2.H2DatabaseType

2018-12-10 Thread Павлухин Иван
Hi Ken, It looks like you have a dependency to different h2 version in your project. Ignite requires com.h2database:h2 version 1.4.197. пн, 10 дек. 2018 г. в 07:08, kcheng.mvp : > > > There are total 82 unite test for my system. > > this unit test works well in ignite 2.6. > > when I switch to ign

Re: Clean up of our PRs and IEPs before 2019

2018-12-10 Thread Павлухин Иван
Nikolay, I must say that when I first saw 1K+ open PRs my first thought was that something was wrong with a review process. In my mind in not very big project open PR list can reflect very well the real work in progress. For bigger projects things become more complicated. Dmitriy, Do you have so

Re: Clean up of our PRs and IEPs before 2019

2018-12-11 Thread Павлухин Иван
ts > > > > > > Apache Kafka - 533 PR opened. > > > Apache Spark - 484 PR opened. > > > Apache Flink - 430 PR opened. > > > > > > В Вт, 11/12/2018 в 09:24 +0300, Pavel Tupitsyn пишет: > > > > Agree with Dmitriy. > > > >

Re: Is it time to move forward to JUnit4 (5)?

2018-12-11 Thread Павлухин Иван
gt; > >> 2. Add @RunWith(JUnit4.class) annotation on test class. > > >> 3. Add @Before, @After on methods which should run before, after a > > >> test (setUp, tearDown in current approach). > > >> 4. Add your test-class to a suite using suite.addTest(new >

Re: Is it time to move forward to JUnit4 (5)?

2018-12-12 Thread Павлухин Иван
e. > > Every time one annotates @Test or @Ignore gives them a reason to prefer > other JUnit annotations over something else. It works about the same as I > described above for beforeTestsStarted in GridAbstractTest and how it > inhibited use of JUnit 3 methods: after you p

Re: Pre-touch for Ignite off-heap memory

2018-12-12 Thread Павлухин Иван
use > > off-heap as well as heap. > > So, we can implement a similar feature for Ignite – and make sure the users > > can get all the memory pre-touch benefits if they want. > > Of course, it impacts startup time so we should enable it by a > > configuration property (I’

Re: CONTRIBUTING.md first version

2018-12-12 Thread Павлухин Иван
(the link "contributing guidelines" on the screenshot refers to CONTRIBUTING.md) чт, 13 дек. 2018 г. в 08:50, Павлухин Иван : > > Dmitriy, > > Thank you for your efforts! For me it looks exactly what is needed. > Screenshot will tell everything for me (see hint at rig

<    1   2   3   4   >