[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12260 Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is us

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 1: (2 comments) Thanks for comments http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is use

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is use

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 3: (10 comments) Thanks Michael for comments http://gerrit

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/12260/2

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is use

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 1: (1 comment) This all looks good but I have questions.

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is use

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 5: (4 comments) Thanks Michael for comments. I think in gen

[Impala-ASF-CR] IMPALA-8103: In Analyzed Query use /* and */ to delimit hints.

2019-02-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12360 Change subject: IMPALA-8103: In Analyzed Query use /* and */ to delimit hints. .. IMPALA-8103: In Analyzed Query use /* and */ to delim

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is use

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 6: Patch set 6 is just to fix merge conflicts. -- To view,

[Impala-ASF-CR] IMPALA-8103: In Analyzed Query use /* and */ to delimit hints.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12360 ) Change subject: IMPALA-8103: In Analyzed Query use /* and */ to delimit hints. .. IMPALA-8103: In Analyzed Query use /* and */ to delimi

[Impala-ASF-CR] IMPALA-8103: In Analyzed Query use /* and */ to delimit hints.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12360 ) Change subject: IMPALA-8103: In Analyzed Query use /* and */ to delimit hints. .. Patch Set 2: (3 comments) Thanks for the quick rev

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupl

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupl

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. Patch Set 5: (5 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is use

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 6: (10 comments) Thanks Michael http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command

2019-02-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12379 ) Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command .. Patch Set 2: Code-Review+1 (1 comment) LGTM http://gerr

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is use

[Impala-ASF-CR] IMPALA-8183: fix test reportexecstatus retry flakiness

2019-02-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12461 ) Change subject: IMPALA-8183: fix test_reportexecstatus_retry flakiness .. Patch Set 1: Code-Review+1 (2 comments) LGTM http://gerri

[Impala-ASF-CR] IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.

2019-02-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12475 Change subject: IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor. .. IMPALA-8194: wait longer to detect JVM pause in T

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

2019-02-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12478 ) Change subject: IMPALA-8189: Disable flaky scanner test on S3 .. Patch Set 1: Code-Review+1 LGTM -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded

2019-02-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12541 ) Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded .. Patch Set 1: (1 comment) Glad that ranger is

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 1: (3 comments) Change looks

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 1: Oh I see, the service-pool.

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 1: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-03-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 3: Code-Review+1 LGTM -- To

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12672 Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRet

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12680 Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. IMPALA-8279: Revert IMPALA-6658 to avoid ETL p

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12680 ) Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. Patch Set 1: Thanks Csaba for the review -

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12680 ) Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. IMPALA-8279: Revert IMPALA-6658 to avoid ETL pe

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-03-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 1: (1 comment) I will try to get https://gerrit.clouder

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRetr

[Impala-ASF-CR] IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint.

2019-03-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12702 Change subject: IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint. .. IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 ) Change subject: IMPALA-337: Add support for POST to the webserver .. Patch Set 2: Code-Review+1 (2 comments) LGTM http://gerrit.clo

[Impala-ASF-CR] IMPALA-7718: [DOCS] Additional info in the extended EXPLAIN output

2019-03-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12732 ) Change subject: IMPALA-7718: [DOCS] Additional info in the extended EXPLAIN output .. Patch Set 3: Code-Review+1 (1 comment) This l

[Impala-ASF-CR] IMPALA-8325: Leading Unicode comments cause Impala Shell failure.

2019-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12812 Change subject: IMPALA-8325: Leading Unicode comments cause Impala Shell failure. .. IMPALA-8325: Leading Unicode comments cause Impal

[Impala-ASF-CR] IMPALA-8325: Leading Unicode comments cause Impala Shell failure.

2019-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12812 ) Change subject: IMPALA-8325: Leading Unicode comments cause Impala Shell failure. .. IMPALA-8325: Leading Unicode comments cause Impala

[Impala-ASF-CR] IMPALA-8325: Leading Unicode comments cause Impala Shell failure.

2019-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12812 ) Change subject: IMPALA-8325: Leading Unicode comments cause Impala Shell failure. .. Patch Set 1: (4 comments) Thanks Fredy http:/

[Impala-ASF-CR] IMPALA-8332: Remove Impala Shell warnings part 1

2019-03-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12837 Change subject: IMPALA-8332: Remove Impala Shell warnings part 1 .. IMPALA-8332: Remove Impala Shell warnings part 1 In Thrift 0.9.3 t

[Impala-ASF-CR] IMPALA-8332: Remove Impala Shell warnings part 1

2019-03-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12837 ) Change subject: IMPALA-8332: Remove Impala Shell warnings part 1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/128

[Impala-ASF-CR] IMPALA-8332: Remove Impala Shell warnings part 1

2019-03-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12837 ) Change subject: IMPALA-8332: Remove Impala Shell warnings part 1 .. IMPALA-8332: Remove Impala Shell warnings part 1 In Thrift 0.9.3 th

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 8: (5 comments) All I have are nits and

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: (2 comments) Looks good http://gerrit.c

[Impala-ASF-CR] IMPALA-8345 : Add option to set up minicluster to use Hive 3

2019-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12846 ) Change subject: IMPALA-8345 : Add option to set up minicluster to use Hive 3 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRetr

[Impala-ASF-CR] IMPALA-8345 : Add option to set up minicluster to use Hive 3

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12846 ) Change subject: IMPALA-8345 : Add option to set up minicluster to use Hive 3 .. Patch Set 7: Code-Review+1 (5 comments) a few nits b

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRetr

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 3: (4 comments) Thanks for the quick review http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12672/4/be/sr

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRetr

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRetr

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 5: (20 comments) Thanks for the reviews. Please see patch set 7.

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRetr

[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04

2019-03-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 ) Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04 .. Patch Set 1: Code-Review+1 (2 comments) LGTM http://gerr

[Impala-ASF-CR] Improve error handling for validation of unified backend executable

2019-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 1: Code-Review+1 LGTM -- To view,

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 2: Code-Review+1 (2 comments) LGT

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRetr

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 5: (3 comments) Thanks Michael. Please see the upcoming Patch Se

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 8: Reviewers please wait for a future Patch Ste with a simplified

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRetr

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 1: Code-Review+1 LGTM -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRet

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 10: (12 comments) Thanks for the review. See patch set 10. http

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13078 Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: (4 comments) Thanks Tim. I made fixes in p

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: (4 comments) Thanks Bikram, see patch set

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 5: One more fix to remove an 'inline' which ge

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11387 Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. IMPALA-6568 add missing Query Compilation section to

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 1: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 2: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] WIP: IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11387 ) Change subject: WIP: IMPALA-6568 add missing Query Compilation section to profiles. .. WIP: IMPALA-6568 add missing Query Compilation s

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. IMPALA-6568 add missing Query Compilation section to p

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 3: (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 3: (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 3: (5 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 3: (5 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. IMPALA-6568 add missing Query Compilation section to p

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. IMPALA-6568 add missing Query Compilation section to p

[Impala-ASF-CR] IMPALA-589: Add a sql function to return the impalad coordinator hostname for diagnostic purposes.

2018-09-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11459 Change subject: IMPALA-589: Add a sql function to return the impalad coordinator hostname for diagnostic purposes. .. IMPALA-589: Add

[Impala-ASF-CR] IMPALA-7492: Add support for DATE text parser/formatter

2018-09-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11450 ) Change subject: IMPALA-7492: Add support for DATE text parser/formatter .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-7579: use the generic filesystem client to delete and create files in test query profile contains all events.

2018-09-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11461 Change subject: IMPALA-7579: use the generic filesystem_client to delete and create files in test_query_profile_contains_all_events. ..

[Impala-ASF-CR] IMPALA-7579: fix test query profile contains all events on S3

2018-09-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11461 ) Change subject: IMPALA-7579: fix test_query_profile_contains_all_events on S3 .. IMPALA-7579: fix test_query_profile_contains_all_events

[Impala-ASF-CR] IMPALA-7579: fix test query profile contains all events on S3

2018-09-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11461 ) Change subject: IMPALA-7579: fix test_query_profile_contains_all_events on S3 .. Patch Set 1: (5 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-589: Add sql function returning the impalad coordinator hostname.

2018-09-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11459 ) Change subject: IMPALA-589: Add sql function returning the impalad coordinator hostname. .. IMPALA-589: Add sql function returning the

[Impala-ASF-CR] IMPALA-589: Add sql function returning the impalad coordinator hostname.

2018-09-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11459 ) Change subject: IMPALA-589: Add sql function returning the impalad coordinator hostname. .. Patch Set 1: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-589: Add sql function returning the impalad coordinator hostname.

2018-09-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11459 ) Change subject: IMPALA-589: Add sql function returning the impalad coordinator hostname. .. Patch Set 2: (1 comment) Thanks for mak

[Impala-ASF-CR] IMPALA-589: Add sql function returning the impalad coordinator hostname.

2018-09-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11459 ) Change subject: IMPALA-589: Add sql function returning the impalad coordinator hostname. .. IMPALA-589: Add sql function returning the

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11582 Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 1: (5 comments) Another patch should be coming soon

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder b

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11719 Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts t

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts to

  1   2   3   4   5   6   7   >