[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-05-17 Thread Hao Hao (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10217 to look at the new patch set (#6). Change subject: KUDU-2191: HMS Metadata Consistency Check Tool ...

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-17 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#19). Change subject: KUDU-2191: Metadata Upgrade Tool .

[kudu-CR] KUDU-2437 Generate ScanToken from small chunks in tablet

2018-05-17 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/10406 ) Change subject: KUDU-2437 Generate ScanToken from small chunks in tablet .. Patch Set 4: Thank Todd for the question pointed out, we will mod

Re: [kudu-CR] KUDU-2437 Generate ScanToken from small chunks in tablet

2018-05-17 Thread 徐瑶
Hi Todd, Thank you for the question pointed out, we will modify the patch according to your design. Yao 2018-05-18 1:13 GMT+08:00 Todd Lipcon (Code Review) : > Todd Lipcon *posted comments* on this change. > > View Change > > Patch set 4: > > Hi Xu. Thank

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 5: (2 comments) http://gerrit

[kudu-CR] WIP: Kudu Backup/Restore Spark Jobs

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10375 ) Change subject: WIP: Kudu Backup/Restore Spark Jobs .. Patch Set 8: (1 comment) I haven't reviewed the code at all but I wanted to comme

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-17 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#18). Change subject: KUDU-2191: Metadata Upgrade Tool .

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-17 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#17). Change subject: KUDU-2191: Metadata Upgrade Tool .

[kudu-CR] WIP: Kudu Backup/Restore Spark Jobs

2018-05-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10375 ) Change subject: WIP: Kudu Backup/Restore Spark Jobs .. Patch Set 8: (13 comments) I suck at Scala but I did a first pass on this. Overal

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10435 ) Change subject: KUDU-2427: retry more system calls on EINTR .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10435/5//COM

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10435 ) Change subject: KUDU-2427: retry more system calls on EINTR .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10435/5//CO

[kudu-CR] build: only call find package on gperftools if we're going to use it

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10429 ) Change subject: build: only call find_package on gperftools if we're going to use it .. build: only call find_package on gperftoo

[kudu-CR] build: only call find package on gperftools if we're going to use it

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10429 ) Change subject: build: only call find_package on gperftools if we're going to use it .. Patch Set 4: Code-Review+2 Carrying forward Alex

[kudu-CR] KUDU-2427: adjust gold linker detection

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10428 ) Change subject: KUDU-2427: adjust gold linker detection .. KUDU-2427: adjust gold linker detection This patch makes two adjustmen

[kudu-CR] [consensus] KUDU-2443 fix replica replacement of RF=1

2018-05-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10438 ) Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1 .. Patch Set 5: > > The kudu move tool would not work without >

[kudu-CR] [consensus] KUDU-2443 fix replica replacement of RF=1

2018-05-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10438 ) Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1 .. [consensus] KUDU-2443 fix replica replacement of RF=1

[kudu-CR] [consensus] KUDU-2443 fix replica replacement of RF=1

2018-05-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10438 ) Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1 .. Patch Set 4: Code-Review+2 > The kudu move tool would not work w

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-17 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 4: (1 comment) http://gerri

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-17 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10419 to look at the new patch set (#5). Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 4: (1 comment) http://gerrit.

[kudu-CR] [consensus] KUDU-2443 fix replica replacement of RF=1

2018-05-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10438 ) Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1 .. Patch Set 4: > > > LGTM but I think we should add a regressio

[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1

2018-05-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10439 ) Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] [consensus] KUDU-2443 fix replica replacement of RF=1

2018-05-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10438 ) Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1 .. Patch Set 4: > > LGTM but I think we should add a regression ite

[kudu-CR] KUDU-2427: adjust gold linker detection

2018-05-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10428 ) Change subject: KUDU-2427: adjust gold linker detection .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/too

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 16: (9 comments) http://gerrit.cloudera.org:8080/#/c/10075/16/src/kudu/hm

[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1

2018-05-17 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10439 to look at the new patch set (#2). Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1 ..

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10435 ) Change subject: KUDU-2427: retry more system calls on EINTR .. Patch Set 5: Verified+1 (1 comment) Overriding Jenkins, known flaky test.

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10435 ) Change subject: KUDU-2427: retry more system calls on EINTR .. Removed reviewer Kudu Jenkins with the following votes: * Verified

[kudu-CR] build: only call find package on gperftools if we're going to use it

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10429 ) Change subject: build: only call find_package on gperftools if we're going to use it .. Removed reviewer Kudu Jenkins with the fo

[kudu-CR] build: only call find package on gperftools if we're going to use it

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10429 ) Change subject: build: only call find_package on gperftools if we're going to use it .. Patch Set 4: Verified+1 Overriding Jenkins, NTP

[kudu-CR] [consensus] KUDU-2443 fix replica replacement of RF=1

2018-05-17 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10438 to look at the new patch set (#4). Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10435 to look at the new patch set (#5). Change subject: KUDU-2427: retry more system calls on EINTR ..

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10435 ) Change subject: KUDU-2427: retry more system calls on EINTR .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/10435/4/src

[kudu-CR] KUDU-1889: support openssl 1.1

2018-05-17 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Dan Burkert, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10436 to look at the new patch set (#4). Change subject: KUDU-1889: support openssl 1.1 .. KUD

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10435 to look at the new patch set (#4). Change subject: KUDU-2427: retry more system calls on EINTR .. KUDU

[kudu-CR] KUDU-2427: adjust gold linker detection

2018-05-17 Thread Adar Dembo (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10428 to look at the new patch set (#4). Change subject: KUDU-2427: adjust gold linker detection .

[kudu-CR] Fix flaky file cache-test

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9900 ) Change subject: Fix flaky file_cache-test .. Patch Set 3: Code-Review+2 +2, though you might want to fix that one clang-tidy issue. -- T

[kudu-CR] KUDU-2427: adjust gold linker detection

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10428 ) Change subject: KUDU-2427: adjust gold linker detection .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLi

[kudu-CR] [webui] Convert /tablets page to mustache

2018-05-17 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 ) Change subject: [webui] Convert /tablets page to mustache .. Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/10422/1/s

[kudu-CR] [webui] Convert /tablets page to mustache

2018-05-17 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10422 to look at the new patch set (#2). Change subject: [webui] Convert /tablets page to mustache ...

[kudu-CR] WIP: KUDU-1889: support openssl 1.1

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: WIP: KUDU-1889: support openssl 1.1 .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu/se

[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1

2018-05-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10439 ) Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1 .. Patch Set 1: > I don't think tablet copy should fail if the lead

[kudu-CR] WIP: KUDU-1889: support openssl 1.1

2018-05-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: WIP: KUDU-1889: support openssl 1.1 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu

[kudu-CR] [consensus] KUDU-2443 fix replica replacement of RF=1

2018-05-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10438 ) Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1 .. Patch Set 3: > > LGTM but I think we should add a regression

[kudu-CR] [consensus] KUDU-2443 fix replica replacement of RF=1

2018-05-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10438 ) Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1 .. Patch Set 3: > LGTM but I think we should add a regression it

[kudu-CR] [DOCS] Added an info on creating a table in Impala with a custom replication factor

2018-05-17 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10411 ) Change subject: [DOCS] Added an info on creating a table in Impala with a custom replication factor .. [DOCS] Added an info on cr

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-17 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 4: (1 comment) http://gerri

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-17 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10419 to look at the new patch set (#4). Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-17 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10419 to look at the new patch set (#3). Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

[kudu-CR] [kudu CLI] KUDU-2443 fix replica movement for RF=1

2018-05-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10439 ) Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1 .. Patch Set 1: Code-Review+1 I don't think tablet copy should fail if

[kudu-CR] [consensus] KUDU-2443 fix replica replacement of RF=1

2018-05-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10438 ) Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1 .. Patch Set 3: Code-Review+1 LGTM but I think we should add a regr

[kudu-CR] [webui] Add templates for tserver webui

2018-05-17 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. ( http://gerrit.cloudera.org:8080/8307 ) Change subject: [webui] Add templates for tserver webui .. Abandoned I'm doing this as it comes up for specific endpoints. -- To view, visit htt

[kudu-CR] KUDU-2427: adjust gold linker detection

2018-05-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10428 ) Change subject: KUDU-2427: adjust gold linker detection .. Patch Set 3: Code-Review+1 (2 comments) looks good although I'm not sure skip

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-17 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 ) Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[kudu-CR] [DOCS] Added an info on creating a table in Impala with a custom replication factor

2018-05-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10411 ) Change subject: [DOCS] Added an info on creating a table in Impala with a custom replication factor .. Patch Set 2: Code-Review+2 -- To

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-17 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 11: Plz ignore patch 11 -- To view, visit h

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-17 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10332 to look at the new patch set (#12). Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths

[kudu-CR] Fix flaky file cache-test

2018-05-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9900 to look at the new patch set (#3). Change subject: Fix flaky file_cache-test .. Fix flaky file_cache-tes

[kudu-CR] Fix flaky file cache-test

2018-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9900 ) Change subject: Fix flaky file_cache-test .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9900/2/src/kudu/fs/block_mana

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-17 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 11: Fixed conflicts and rebased. -- To view

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-17 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10332 to look at the new patch set (#11). Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 ) Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10435 ) Change subject: KUDU-2427: retry more system calls on EINTR .. Patch Set 3: (1 comment) > Seem like we might be missing a few more: > -

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-17 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 ) Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. Patch Set 1: Would like to run this with dist-test

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-17 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10443 Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebU

[kudu-CR] WIP: KUDU-1889: support openssl 1.1

2018-05-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: WIP: KUDU-1889: support openssl 1.1 .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu/s

[kudu-CR] build: only call find package on gperftools if we're going to use it

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10429 ) Change subject: build: only call find_package on gperftools if we're going to use it .. Patch Set 3: Code-Review+2 Carrying forward Alex

[kudu-CR] Fix flaky file cache-test

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9900 ) Change subject: Fix flaky file_cache-test .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9900/2/src/kudu/fs/block_manag

[kudu-CR] WIP: KUDU-1889: support openssl 1.1

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: WIP: KUDU-1889: support openssl 1.1 .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Ku

[kudu-CR] WIP: KUDU-1889: support openssl 1.1

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: WIP: KUDU-1889: support openssl 1.1 .. Patch Set 3: Verified+1 Overriding Jenkins, another instance of KUDU-2109. -- To

[kudu-CR] KUDU-2427: relax dlsym call to dl iterate phdr

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10434 ) Change subject: KUDU-2427: relax dlsym call to dl_iterate_phdr .. KUDU-2427: relax dlsym call to dl_iterate_phdr When gcc passes

[kudu-CR] KUDU-2427: relax dlsym call to dl iterate phdr

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10434 ) Change subject: KUDU-2427: relax dlsym call to dl_iterate_phdr .. Patch Set 3: Verified+1 Overriding Jenkins, known Java flakes. -- To

[kudu-CR] KUDU-2427: relax dlsym call to dl iterate phdr

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10434 ) Change subject: KUDU-2427: relax dlsym call to dl_iterate_phdr .. Removed reviewer Kudu Jenkins with the following votes: * Verif

[kudu-CR] KUDU-2427: fix glog symbolization in certain ASLR environments

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10431 ) Change subject: KUDU-2427: fix glog symbolization in certain ASLR environments .. KUDU-2427: fix glog symbolization in certain ASL

[kudu-CR] KUDU-2427: only add -fno-sized-deallocation for C++ files

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10430 ) Change subject: KUDU-2427: only add -fno-sized-deallocation for C++ files .. Patch Set 3: Verified+1 NTP failures across the board. --

[kudu-CR] KUDU-2427: only add -fno-sized-deallocation for C++ files

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10430 ) Change subject: KUDU-2427: only add -fno-sized-deallocation for C++ files .. KUDU-2427: only add -fno-sized-deallocation for C++ f

[kudu-CR] KUDU-2427: only add -fno-sized-deallocation for C++ files

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10430 ) Change subject: KUDU-2427: only add -fno-sized-deallocation for C++ files .. Removed reviewer Kudu Jenkins with the following vote

[kudu-CR] build: only call find package on gperftools if we're going to use it

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10429 ) Change subject: build: only call find_package on gperftools if we're going to use it .. Patch Set 3: Verified+1 Failures were a combinat

[kudu-CR] build: only call find package on gperftools if we're going to use it

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10429 ) Change subject: build: only call find_package on gperftools if we're going to use it .. Removed reviewer Kudu Jenkins with the fo

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

2018-05-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/10293/11/

[kudu-CR] Fix flaky file cache-test

2018-05-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9900 to look at the new patch set (#2). Change subject: Fix flaky file_cache-test .. Fix flaky file_cache-tes

[kudu-CR] [webui] Convert /tablets page to mustache

2018-05-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 ) Change subject: [webui] Convert /tablets page to mustache .. Patch Set 1: (3 comments) Hm.. To Alexey's point, maybe we should meet in

[kudu-CR] KUDU-2427: relax dlsym call to dl iterate phdr

2018-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10434 ) Change subject: KUDU-2427: relax dlsym call to dl_iterate_phdr .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10435 ) Change subject: KUDU-2427: retry more system calls on EINTR .. Patch Set 3: Verified+1 Unrelated failure; filed KUDU-2444 for it. -- To

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: KUDU-2427: retry more system calls on EINTR .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10435 To unsubscribe, visit

[kudu-CR] KUDU-2427: fix glog symbolization in certain ASLR environments

2018-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10431 ) Change subject: KUDU-2427: fix glog symbolization in certain ASLR environments .. Patch Set 3: Code-Review+2 -- To view, visit http://g

[kudu-CR] KUDU-2427: only add -fno-sized-deallocation for C++ files

2018-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10430 ) Change subject: KUDU-2427: only add -fno-sized-deallocation for C++ files .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] build: only call find package on gperftools if we're going to use it

2018-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10429 ) Change subject: build: only call find_package on gperftools if we're going to use it .. Patch Set 3: Code-Review+1 -- To view, visit h

[kudu-CR] KUDU-2427: retry more system calls on EINTR

2018-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10435 ) Change subject: KUDU-2427: retry more system calls on EINTR .. Patch Set 3: (1 comment) Seem like we might be missing a few more: - Soc

[kudu-CR] KUDU-2427: update breakpad to latest HEAD

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10427 ) Change subject: KUDU-2427: update breakpad to latest HEAD .. KUDU-2427: update breakpad to latest HEAD It includes a commit that

[kudu-CR] KUDU-2427: adjust gold linker detection

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10428 ) Change subject: KUDU-2427: adjust gold linker detection .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLi

[kudu-CR] KUDU-2427: adjust gold linker detection

2018-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10428 ) Change subject: KUDU-2427: adjust gold linker detection .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLis

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] KUDU-2427: adjust gold linker detection

2018-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10428 ) Change subject: KUDU-2427: adjust gold linker detection .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10428/3/CMakeLi

[kudu-CR] KUDU-2427: adjust gold linker detection

2018-05-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10428 ) Change subject: KUDU-2427: adjust gold linker detection .. Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-17 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 10: Looks like you'll have to rebase on maste

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-17 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 2: Looks pretty good to me.

[kudu-CR] KUDU-2427: update breakpad to latest HEAD

2018-05-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10427 ) Change subject: KUDU-2427: update breakpad to latest HEAD .. Patch Set 2: Code-Review+2 Hopefully, the new version compiles without is

[kudu-CR] [webui] Convert /tablets page to mustache

2018-05-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 ) Change subject: [webui] Convert /tablets page to mustache .. Patch Set 1: (11 comments) Looks pretty good, just some nits. Also, it

  1   2   >