Change in vdsm[ovirt-3.3]: spec: Don't depend on unreleased RPMs.

2013-11-18 Thread danken
Dan Kenigsberg has abandoned this change. Change subject: spec: Don't depend on unreleased RPMs. .. Abandoned -- To view, visit http://gerrit.ovirt.org/21300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Messa

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 7: Ignore the test failure, it is not relevant to this change. -- To view, visit http://gerr

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 7: Code-Review+1 (2 comments) Needs docstring fix and shorter warning may be also nice. +1 si

Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient

2013-11-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient .. xmlrpc: Parsing error logging enhancement - vdsClient Logging enhancement which helps understa

Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http:

Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient .. Patch Set 9: No Builds Executed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4709/

Change in vdsm[master]: lvm: Make the isLVActive() method public.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.o

Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: gluster: adopt xml changes of rebalance and remove-brick status

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: adopt xml changes of rebalance and remove-brick status .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_

Change in vdsm[master]: gluster: interpret and use correct xml elements

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: interpret and use correct xml elements .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4708/ : SUCCE

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_

Change in vdsm[master]: lvm: Make the isLVActive() method public.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4704/ : SUCCESS ht

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_

Change in vdsm[master]: lvm: Make the isLVActive() method public.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4703/ : SUCC

Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4702/ : SUCC

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4701

Change in vdsm[master]: lvm: Make the isLVActive() method public.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4699/ : SUCCESS ht

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_

Change in vdsm[master]: lvm: Make the isLVActive() method public.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4698/ : SUCCESS ht

Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4697/ : SUCC

Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.

2013-11-18 Thread lyarwood
Lee Yarwood has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: (2 comments) > Are all callers updated by this patch? Yes. # git grep refreshLV vdsm/storage/bl

Change in vdsm[master]: ipwrapper: add support for veth NICs

2013-11-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: ipwrapper: add support for veth NICs .. ipwrapper: add support for veth NICs Update ipwrapper to consider veth NICs as FakeNICs in the same way it does

Change in vdsm[master]: ipwrapper: add support for veth NICs

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21381 To unsubscribe, visit http://gerrit.ovirt.org/s

Change in vdsm[master]: autotools: fix make distcheck

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: autotools: fix make distcheck .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4696/ : FAILURE http://

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-18 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp .. Patch Set 9: Code-Review-1 (3 comments) Very minor comments, in general it looks good to me. ..

Change in vdsm[master]: ipwrapper: add support for veth NICs

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21381 To unsubscribe, visit http://gerrit.ovirt.or

Change in vdsm[master]: remove irs_enable configuration attribute

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: remove irs_enable configuration attribute .. Patch Set 3: Code-Review-1 If this patch was a part of a patch series about modularization, i'd take it. But as it

Change in vdsm[master]: ipwrapper: add support for veth NICs

2013-11-18 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21381 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: remove irs_enable configuration attribute

2013-11-18 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: remove irs_enable configuration attribute .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/21141 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: lvm: Make the isLVActive() method public.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 2: (1 comment) Commit Message Line 7: lvm: Make the isL

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 3: (1 comment) Commit Message Line 10: g

Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: (1 comment) Commit Message Line 8: Line 9: T

Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: Answering my questions about refreshing multiple lvs - it works and the manual does not say it sho

Change in vdsm[master]: lvm: deactivate lvs during bootstrap

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lvm: deactivate lvs during bootstrap .. Patch Set 5: (3 comments) File vdsm/storage/lvm.py Line 659: activ

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 3: (2 comments) Looks good, need to check if special lvs are handled in the modified code pat

Change in vdsm[master]: ipwrapper: add support for veth NICs

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4695/ : SUCCESS

Change in vdsm[master]: lvm: deactivate lvs during bootstrap

2013-11-18 Thread abaron
Ayal Baron has posted comments on this change. Change subject: lvm: deactivate lvs during bootstrap .. Patch Set 5: (3 comments) File vdsm/storage/lvm.py Line 657: activ

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4694/ : S

Change in vdsm[master]: lvm: Make the isLVActive() method public.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 2: (1 comment) Commit Message Line 6: Line 7: lvm: Mak

Change in vdsm[ovirt-3.3]: domainMonitor: tag pool monitored domains

2013-11-18 Thread abaron
Ayal Baron has posted comments on this change. Change subject: domainMonitor: tag pool monitored domains .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21357 To unsubscribe, visit http://gerrit.ovirt.o

Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.

2013-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: (1 comment) Looks good except wrong call to new function. Some questions: - Are all callers updat

Change in vdsm[master]: hsm: wait until lvm bootstrap is done before connecting to pool

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: wait until lvm bootstrap is done before connecting to pool .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-18 Thread pbenas
Petr Benas has posted comments on this change. Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp .. Patch Set 8: (1 comment) File tests/functional/networkT

Change in vdsm[master]: hsm: wait until lvm bootstrap is done before connecting to pool

2013-11-18 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: hsm: wait until lvm bootstrap is done before connecting to pool .. hsm: wait until lvm bootstrap is done before connecting to pool When hsm is created, a bootsrap

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread lyarwood
Lee Yarwood has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 3: (1 comment) File vdsm/storage/blockS

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4692

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp .. Patch Set 8: Code-Review-1 (1 comment) File tests/f

Change in vdsm[master]: lvm: Make the isLVActive() method public.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4690/ : SUCCESS ht

Change in vdsm[ovirt-3.3]: vm: prevent faulty volume extensions

2013-11-18 Thread fsimonce
Federico Simoncelli has submitted this change and it was merged. Change subject: vm: prevent faulty volume extensions .. vm: prevent faulty volume extensions Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443 Change-Id

Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop

2013-11-18 Thread fsimonce
Federico Simoncelli has submitted this change and it was merged. Change subject: vm: unify _highWrite and _onAbnormalStop .. vm: unify _highWrite and _onAbnormalStop Both _highWrite and _onAbnormalStop should share the same log

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit

Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.

2013-11-18 Thread lyarwood
Lee Yarwood has uploaded a new change for review. Change subject: blockSD: Ensure active volumes are refreshed before use. .. blockSD: Ensure active volumes are refreshed before use. At present we trust that active LVs represent

Change in vdsm[master]: ipwrapper: add support for veth NICs

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 1: you are using veth devices in your "Add NetworkTest.testSetupNetworksAddDelkDhcp" patch, so this patch sho

Change in vdsm[master]: lvm: Make the isActiveLV() method public.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isActiveLV() method public. .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4688/ : FAIL

Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4687/ : SUCC

Change in vdsm[master]: lvm: Make the isActiveLV() method public.

2013-11-18 Thread lyarwood
Lee Yarwood has uploaded a new change for review. Change subject: lvm: Make the isActiveLV() method public. .. lvm: Make the isActiveLV() method public. This change makes the private isActiveLV() method public for use in the blo

Change in vdsm[ovirt-3.3]: vm: prevent faulty volume extensions

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21383 To unsubscribe, visit http://gerrit.ovirt.or

Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21382 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt

2013-11-18 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Fail pre-start run after configure libvirt .. Patch Set 2: (1 comment) File init/vdsmd_init_common.sh.in Lin

Change in vdsm[master]: spec: Don't depend on unreleased RPMs.

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: spec: Don't depend on unreleased RPMs. .. Patch Set 1: Verified+1 Code-Review+2 (1 comment) verified by Saggi. ...

Change in vdsm[master]: spec: Don't depend on unreleased RPMs.

2013-11-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: Don't depend on unreleased RPMs. .. spec: Don't depend on unreleased RPMs. The requested package is not yet available in RHEL and will only be av

Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt

2013-11-18 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Fail pre-start run after configure libvirt .. Patch Set 2: (1 comment) File init/vdsmd_init_common.sh.in L

Change in vdsm[master]: spec: Don't depend on unreleased RPMs.

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Don't depend on unreleased RPMs. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4686/ : SUCCESS http:

Change in vdsm[master]: spec: Don't depend on unreleased RPMs.

2013-11-18 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: Don't depend on unreleased RPMs. .. Patch Set 1: Saggi - please abandon http://gerrit.ovirt.org/#/c/21300/ . This is not relevant to ovirt-3.3 branch.

Change in vdsm[master]: spec: Don't depend on unreleased RPMs.

2013-11-18 Thread ybronhei
Hello Saggi Mizrahi, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/21385 to review the following change. Change subject: spec: Don't depend on unreleased RPMs. .. spec: Don't depend on unreleased

Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt

2013-11-18 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Fail pre-start run after configure libvirt .. Patch Set 2: (1 comment) File init/vdsmd_init_common.sh.in Lin

Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop

2013-11-18 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 2: Verified+1 Code-Review+1 Replaced "Bug-Url: Bug-Url:" in the commit message with "Bug-Url:" via gerrit.

Change in vdsm[master]: ipwrapper: add support for veth NICs

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4685/ : SUCCESS http://

Change in vdsm[ovirt-3.3]: vm: prevent faulty volume extensions

2013-11-18 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21383 To unsubscribe, visit http://gerrit.ovirt.or

Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt

2013-11-18 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Fail pre-start run after configure libvirt .. Patch Set 2: (1 comment) File init/vdsmd_init_common.sh.in L

Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop

2013-11-18 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21382 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp .. Patch Set 8: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/46

Change in vdsm[ovirt-3.3]: vm: prevent faulty volume extensions

2013-11-18 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 1: Verified+1 Same as upstream. -- To view, visit http://gerrit.ovirt.org/21383 To unsubscribe, visit h

Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop

2013-11-18 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 1: Verified+1 Same as upstream. -- To view, visit http://gerrit.ovirt.org/21382 To unsubscribe, vis

Change in vdsm[ovirt-3.3]: vm: prevent faulty volume extensions

2013-11-18 Thread fsimonce
Hello Ayal Baron, Yeela Kaplan, Sergey Gotliv, Allon Mureinik, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/21383 to review the following change. Change subject: vm: prevent faulty volume extensions .

Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop

2013-11-18 Thread fsimonce
Hello Ayal Baron, Sergey Gotliv, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/21382 to review the following change. Change subject: vm: unify _highWrite and _onAbnormalStop .. vm: unify _highWrit

Change in vdsm[master]: ipwrapper: add support for veth NICs

2013-11-18 Thread pbenas
Petr Benas has uploaded a new change for review. Change subject: ipwrapper: add support for veth NICs .. ipwrapper: add support for veth NICs Update ipwrapper to consider veth NICs as FakeNICs in the same way it does with dummy

Change in vdsm[master]: vm: prevent faulty volume extensions

2013-11-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: prevent faulty volume extensions .. vm: prevent faulty volume extensions Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443 Change-Id: If7

Change in vdsm[master]: vm: prevent faulty volume extensions

2013-11-18 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: -Code-Review (1 comment) File vdsm/vm.py Line 22

Change in vdsm[master]: Add unit tests for unified network persistence

2013-11-18 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Add unit tests for unified network persistence .. Patch Set 6: Verified+1 The test that fails on Jenkins works on my host. -- To view, visit http://gerrit.ovirt

Change in vdsm[master]: Add unit tests for unified network persistence

2013-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add unit tests for unified network persistence .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4683/ :

Change in vdsm[master]: Add unit tests for unified network persistence

2013-11-18 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Add unit tests for unified network persistence .. Patch Set 4: (1 comment) File tests/netconfpersistenceTest

Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient .. Patch Set 8: Code-Review+2 Sorry to have missed the args[1:] issue. -- To view, visit http://gerrit.o

Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient .. Patch Set 8: Code-Review-1 ouch, manual rebase needed. -- To view, visit http://gerrit.ovirt.org/2062

Change in vdsm[master]: lvm: deactivate lvs during bootstrap

2013-11-18 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: lvm: deactivate lvs during bootstrap .. Patch Set 5: Code-Review+1 (3 comments) Few comments. +1 for now, I still have doubts. ..

Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt

2013-11-18 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Fail pre-start run after configure libvirt .. Patch Set 2: (1 comment) File init/vdsmd_init_common.sh.in Lin

Change in vdsm[ovirt-3.3]: domainMonitor: tag pool monitored domains

2013-11-18 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: domainMonitor: tag pool monitored domains .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21357 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[ovirt-3.3]: Report qemu-kvm-rhev if installed

2013-11-18 Thread hchiramm
Humble Devassy Chirammal has posted comments on this change. Change subject: Report qemu-kvm-rhev if installed .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21364 To unsubscribe, visit http://gerrit.o

Change in vdsm[ovirt-3.3]: caps: coarse-grain libvirt.rpm may be missing

2013-11-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21363 To unsubscribe, visit http://gerrit.ov

Change in vdsm[ovirt-3.3]: caps: coarse-grain libvirt.rpm may be missing

2013-11-18 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21363 To unsubscribe, visit h

Change in vdsm[ovirt-3.3]: Report qemu-kvm-rhev if installed

2013-11-18 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: Report qemu-kvm-rhev if installed .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21364 To unsubscribe, visit http://gerrit

Change in vdsm[master]: gluster: new verb to remove host using host UUID

2013-11-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: new verb to remove host using host UUID .. gluster: new verb to remove host using host UUID This patch adds a new verb glusterHostRemoveByUuid

Change in vdsm[ovirt-3.3]: caps: coarse-grain libvirt.rpm may be missing

2013-11-18 Thread danken
Hello Douglas Schilling Landgraf, mooli tayer, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/21363 to review the following change. Change subject: caps: coarse-grain libvirt.rpm may be missing ..

Change in vdsm[ovirt-3.3]: Report qemu-kvm-rhev if installed

2013-11-18 Thread danken
Hello Douglas Schilling Landgraf, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/21364 to review the following change. Change subject: Report qemu-kvm-rhev if installed .. Report qemu-kvm-rhev if i

Change in vdsm[master]: gluster: new verb to remove host using host UUID

2013-11-18 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: new verb to remove host using host UUID .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/20648 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: lvm: deactivate lvs during bootstrap

2013-11-18 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: lvm: deactivate lvs during bootstrap .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21291 To unsubscribe, visit http://gerrit.ovirt.or

Change in vdsm[ovirt-3.3]: spec: Don't depend on unreleased RPMs.

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: spec: Don't depend on unreleased RPMs. .. Patch Set 1: Code-Review-1 We actually want this on "master". It should reach ovirt-3.3 only if (and when) the iscsi

Change in vdsm[master]: vdsm.spec: Add python-inotify as buildrequires dep

2013-11-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm.spec: Add python-inotify as buildrequires dep .. vdsm.spec: Add python-inotify as buildrequires dep This is needed because now the configure step

Change in vdsm[master]: vdsm.spec: Add python-inotify as buildrequires dep

2013-11-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: Add python-inotify as buildrequires dep .. Patch Set 1: Verified+1 Code-Review+2 not really verfied by me. -- To view, visit http://gerrit.ovirt.or

  1   2   >