Dan Kenigsberg has abandoned this change.
Change subject: spec: Don't depend on unreleased RPMs.
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/21300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Messa
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 7:
Ignore the test failure, it is not relevant to this change.
--
To view, visit http://gerr
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 7: Code-Review+1
(2 comments)
Needs docstring fix and shorter warning may be also nice. +1 si
Dan Kenigsberg has submitted this change and it was merged.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
xmlrpc: Parsing error logging enhancement - vdsClient
Logging enhancement which helps understa
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/20627
To unsubscribe, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 9:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4709/
Nir Soffer has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21386
To unsubscribe, visit http://gerrit.ovirt.o
Nir Soffer has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19871
To unsubscribe, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: adopt xml changes of rebalance and remove-brick status
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: interpret and use correct xml elements
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4708/ : SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 7: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4704/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4703/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4702/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4701
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4699/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4698/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4697/ : SUCC
Lee Yarwood has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 7:
(2 comments)
> Are all callers updated by this patch?
Yes.
# git grep refreshLV
vdsm/storage/bl
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ipwrapper: add support for veth NICs
..
ipwrapper: add support for veth NICs
Update ipwrapper to consider veth NICs as FakeNICs in the same
way it does
Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper: add support for veth NICs
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21381
To unsubscribe, visit http://gerrit.ovirt.org/s
oVirt Jenkins CI Server has posted comments on this change.
Change subject: autotools: fix make distcheck
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4696/ : FAILURE
http://
Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 9: Code-Review-1
(3 comments)
Very minor comments, in general it looks good to me.
..
Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper: add support for veth NICs
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21381
To unsubscribe, visit http://gerrit.ovirt.or
Dan Kenigsberg has posted comments on this change.
Change subject: remove irs_enable configuration attribute
..
Patch Set 3: Code-Review-1
If this patch was a part of a patch series about modularization, i'd take it.
But as it
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: add support for veth NICs
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21381
To unsubscribe, visit http://gerrit.
Arik Hadas has posted comments on this change.
Change subject: remove irs_enable configuration attribute
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21141
To unsubscribe, visit http://gerrit.ovirt.org/
Nir Soffer has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 2:
(1 comment)
Commit Message
Line 7: lvm: Make the isL
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
(1 comment)
Commit Message
Line 10: g
Nir Soffer has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 7:
(1 comment)
Commit Message
Line 8:
Line 9: T
Nir Soffer has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 7:
Answering my questions about refreshing multiple lvs - it works and the manual
does not say it sho
Nir Soffer has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5:
(3 comments)
File vdsm/storage/lvm.py
Line 659: activ
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
(2 comments)
Looks good, need to check if special lvs are handled in the modified code pat
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: add support for veth NICs
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4695/ : SUCCESS
Ayal Baron has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5:
(3 comments)
File vdsm/storage/lvm.py
Line 657: activ
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4694/ : S
Nir Soffer has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 2:
(1 comment)
Commit Message
Line 6:
Line 7: lvm: Mak
Ayal Baron has posted comments on this change.
Change subject: domainMonitor: tag pool monitored domains
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21357
To unsubscribe, visit http://gerrit.ovirt.o
Nir Soffer has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 7:
(1 comment)
Looks good except wrong call to new function.
Some questions:
- Are all callers updat
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: wait until lvm bootstrap is done before connecting to pool
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_
Petr Benas has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 8:
(1 comment)
File tests/functional/networkT
Nir Soffer has uploaded a new change for review.
Change subject: hsm: wait until lvm bootstrap is done before connecting to pool
..
hsm: wait until lvm bootstrap is done before connecting to pool
When hsm is created, a bootsrap
Lee Yarwood has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
(1 comment)
File vdsm/storage/blockS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4692
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 8: Code-Review-1
(1 comment)
File tests/f
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4690/ : SUCCESS
ht
Federico Simoncelli has submitted this change and it was merged.
Change subject: vm: prevent faulty volume extensions
..
vm: prevent faulty volume extensions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
Change-Id
Federico Simoncelli has submitted this change and it was merged.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
vm: unify _highWrite and _onAbnormalStop
Both _highWrite and _onAbnormalStop should share the same log
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit
Lee Yarwood has uploaded a new change for review.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
blockSD: Ensure active volumes are refreshed before use.
At present we trust that active LVs represent
Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper: add support for veth NICs
..
Patch Set 1:
you are using veth devices in your "Add
NetworkTest.testSetupNetworksAddDelkDhcp" patch, so this patch sho
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Make the isActiveLV() method public.
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4688/ : FAIL
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4687/ : SUCC
Lee Yarwood has uploaded a new change for review.
Change subject: lvm: Make the isActiveLV() method public.
..
lvm: Make the isActiveLV() method public.
This change makes the private isActiveLV() method public for
use in the blo
Dan Kenigsberg has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21383
To unsubscribe, visit http://gerrit.ovirt.or
Dan Kenigsberg has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21382
To unsubscribe, visit http://gerrit.ovir
Alon Bar-Lev has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 2:
(1 comment)
File init/vdsmd_init_common.sh.in
Lin
Dan Kenigsberg has posted comments on this change.
Change subject: spec: Don't depend on unreleased RPMs.
..
Patch Set 1: Verified+1 Code-Review+2
(1 comment)
verified by Saggi.
...
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: Don't depend on unreleased RPMs.
..
spec: Don't depend on unreleased RPMs.
The requested package is not yet available in RHEL and will only be
av
Yaniv Bronhaim has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 2:
(1 comment)
File init/vdsmd_init_common.sh.in
L
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: Don't depend on unreleased RPMs.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4686/ : SUCCESS
http:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Don't depend on unreleased RPMs.
..
Patch Set 1:
Saggi - please abandon http://gerrit.ovirt.org/#/c/21300/ .
This is not relevant to ovirt-3.3 branch.
Hello Saggi Mizrahi,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21385
to review the following change.
Change subject: spec: Don't depend on unreleased RPMs.
..
spec: Don't depend on unreleased
Alon Bar-Lev has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 2:
(1 comment)
File init/vdsmd_init_common.sh.in
Lin
Allon Mureinik has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
Patch Set 2: Verified+1 Code-Review+1
Replaced "Bug-Url: Bug-Url:" in the commit message with "Bug-Url:" via gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: add support for veth NICs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4685/ : SUCCESS
http://
Allon Mureinik has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21383
To unsubscribe, visit http://gerrit.ovirt.or
Yaniv Bronhaim has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 2:
(1 comment)
File init/vdsmd_init_common.sh.in
L
Allon Mureinik has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21382
To unsubscribe, visit http://gerrit.ovir
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 8: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/46
Federico Simoncelli has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 1: Verified+1
Same as upstream.
--
To view, visit http://gerrit.ovirt.org/21383
To unsubscribe, visit h
Federico Simoncelli has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
Patch Set 1: Verified+1
Same as upstream.
--
To view, visit http://gerrit.ovirt.org/21382
To unsubscribe, vis
Hello Ayal Baron, Yeela Kaplan, Sergey Gotliv, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21383
to review the following change.
Change subject: vm: prevent faulty volume extensions
.
Hello Ayal Baron, Sergey Gotliv,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21382
to review the following change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
vm: unify _highWrit
Petr Benas has uploaded a new change for review.
Change subject: ipwrapper: add support for veth NICs
..
ipwrapper: add support for veth NICs
Update ipwrapper to consider veth NICs as FakeNICs in the same
way it does with dummy
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: prevent faulty volume extensions
..
vm: prevent faulty volume extensions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
Change-Id: If7
Federico Simoncelli has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 3: -Code-Review
(1 comment)
File vdsm/vm.py
Line 22
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 6: Verified+1
The test that fails on Jenkins works on my host.
--
To view, visit http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4683/ :
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 4:
(1 comment)
File tests/netconfpersistenceTest
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 8: Code-Review+2
Sorry to have missed the args[1:] issue.
--
To view, visit http://gerrit.o
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 8: Code-Review-1
ouch, manual rebase needed.
--
To view, visit http://gerrit.ovirt.org/2062
Federico Simoncelli has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5: Code-Review+1
(3 comments)
Few comments. +1 for now, I still have doubts.
..
Alon Bar-Lev has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 2:
(1 comment)
File init/vdsmd_init_common.sh.in
Lin
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: tag pool monitored domains
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21357
To unsubscribe, visit http://gerrit.ovi
Humble Devassy Chirammal has posted comments on this change.
Change subject: Report qemu-kvm-rhev if installed
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21364
To unsubscribe, visit http://gerrit.o
mooli tayer has posted comments on this change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21363
To unsubscribe, visit http://gerrit.ov
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21363
To unsubscribe, visit h
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Report qemu-kvm-rhev if installed
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21364
To unsubscribe, visit http://gerrit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: new verb to remove host using host UUID
..
gluster: new verb to remove host using host UUID
This patch adds a new verb glusterHostRemoveByUuid
Hello Douglas Schilling Landgraf, mooli tayer,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21363
to review the following change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Hello Douglas Schilling Landgraf,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21364
to review the following change.
Change subject: Report qemu-kvm-rhev if installed
..
Report qemu-kvm-rhev if i
Darshan N has posted comments on this change.
Change subject: gluster: new verb to remove host using host UUID
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21291
To unsubscribe, visit http://gerrit.ovirt.or
Dan Kenigsberg has posted comments on this change.
Change subject: spec: Don't depend on unreleased RPMs.
..
Patch Set 1: Code-Review-1
We actually want this on "master". It should reach ovirt-3.3 only if (and when)
the iscsi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm.spec: Add python-inotify as buildrequires dep
..
vdsm.spec: Add python-inotify as buildrequires dep
This is needed because now the configure step
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: Add python-inotify as buildrequires dep
..
Patch Set 1: Verified+1 Code-Review+2
not really verfied by me.
--
To view, visit http://gerrit.ovirt.or
1 - 100 of 135 matches
Mail list logo