Change in vdsm[master]: virt: periodic: reduce NotConnectedError noise

Milan Zamazal has posted comments on this change. Change subject: virt: periodic: reduce NotConnectedError noise .. Patch Set 14: Code-Review-1 (2 comments) Looks fine to me, I'd just suggest to polish typos in the commit mess

Change in vdsm[master]: virt: periodic: factor out common code

Milan Zamazal has posted comments on this change. Change subject: virt: periodic: factor out common code .. Patch Set 20: Code-Review-1 I'd prefer if virdomain.NotConnectedError change remained in a separate patch. It's actual

Change in vdsm[master]: periodic: explicitely track domain availability

Milan Zamazal has posted comments on this change. Change subject: periodic: explicitely track domain availability .. Patch Set 5: (4 comments) I think this change is tricky enough to deserve at least some comment in the sourc

Change in vdsm[master]: virt: periodic: reduce NotConnectedError noise

Milan Zamazal has posted comments on this change. Change subject: virt: periodic: reduce NotConnectedError noise .. Patch Set 16: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44813 To unsubscribe, visit https://ger

Change in vdsm[master]: virt: periodic: factor out periodic operations

Milan Zamazal has posted comments on this change. Change subject: virt: periodic: factor out periodic operations .. Patch Set 23: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44548 To unsubscribe, visit https://ger

Change in vdsm[master]: vmstats: take in account missing bulk stats fields

Milan Zamazal has posted comments on this change. Change subject: vmstats: take in account missing bulk stats fields .. Patch Set 3: Code-Review-1 (2 comments) Fine, just typos in the comment. https://gerrit.ovirt.org/#/c/477

Change in vdsm[master]: vmstats: take in account missing bulk stats fields

Milan Zamazal has posted comments on this change. Change subject: vmstats: take in account missing bulk stats fields .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47760 To unsubscribe, visit https://

Change in vdsm[master]: tests: add tests for sampling.VMBulkSampler

Milan Zamazal has posted comments on this change. Change subject: tests: add tests for sampling.VMBulkSampler .. Patch Set 36: Code-Review-1 (3 comments) The tests take relatively long time to run. It would be nice to make the

Change in vdsm[master]: periodic: explicitely track domain availability

Milan Zamazal has posted comments on this change. Change subject: periodic: explicitely track domain availability .. Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/47246/9/vdsm/virt/periodic.py File vdsm/virt/periodic.

Change in vdsm[master]: periodic: explicitely track domain availability

Milan Zamazal has posted comments on this change. Change subject: periodic: explicitely track domain availability .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47246 To unsubscribe, visit https://ge

Change in vdsm[master]: lib: utils: consolidate Error class in one place

Milan Zamazal has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/47964/1//COMMIT_MSG Commit Message: Line 10: they ra

Change in vdsm[master]: virt: enhance/fix migration.SourceThread.stop()

Milan Zamazal has posted comments on this change. Change subject: virt: enhance/fix migration.SourceThread.stop() .. Patch Set 11: Verified+1 I checked the migration cancellation by starting and canceling migration from engine

Change in vdsm[master]: lib: utils: consolidate Error class in one place

Milan Zamazal has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 3: Fine for me now except the "alogside" typo in the commit message. -- To view, visit https://ge

Change in vdsm[master]: lib: sparsify: use common Error class

Milan Zamazal has posted comments on this change. Change subject: lib: sparsify: use common Error class .. Patch Set 3: (1 comment) OK except for the commit message. https://gerrit.ovirt.org/#/c/47965/3//COMMIT_MSG Commit Mes

Change in vdsm[master]: lib: utils: consolidate Error class in one place

Milan Zamazal has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https://ge

Change in vdsm[master]: sampling: HostStatsThread as periodic operation

Milan Zamazal has posted comments on this change. Change subject: sampling: HostStatsThread as periodic operation .. Patch Set 32: Code-Review-1 (6 comments) https://gerrit.ovirt.org/#/c/40431/32/vdsm/virt/periodic.py File vds

Change in vdsm[master]: gitignore: Missing autogenerated files added

Milan Zamazal has posted comments on this change. Change subject: gitignore: Missing autogenerated files added .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/48328 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: periodic: more cautious return to fast path

Milan Zamazal has posted comments on this change. Change subject: periodic: more cautious return to fast path .. Patch Set 2: Code-Review-1 (6 comments) Looks like a good idea to me. -1 just due to the typos. https://gerrit.o

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48404/1//COMMIT_MSG Commit Message: Line 14: This chan

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: periodic: add executor-compatible naming

Milan Zamazal has posted comments on this change. Change subject: periodic: add executor-compatible naming .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/48193/6//COMMIT_MSG Commit Message: Line 8: Line 9: We want

Change in vdsm[master]: periodic: add executor-compatible naming

Milan Zamazal has posted comments on this change. Change subject: periodic: add executor-compatible naming .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/48193/6/vdsm/virt/periodic.py File vdsm/virt/periodic.py: Li

Change in vdsm[master]: gitignore: Missing autogenerated files added

Milan Zamazal has uploaded a new change for review. Change subject: gitignore: Missing autogenerated files added .. gitignore: Missing autogenerated files added Change-Id: If4a1e9c2607d817ccca2a321060ab4f452422c32 Signed-off-by:

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/48404/3/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Li

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has uploaded a new change for review. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. logging: Don't crash on non-ASCII in SimpleLogAdapter The values and messages passed to SimpleLogAdapte

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/48542/1/tests/utilsTests.py File tests/utilsTest

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 1: (1 comment) We now check for unicodes and convert them to strings. https://gerrit.ovirt.o

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/48542/1/tests/utilsTests.py File tests/utilsTest

Change in vdsm[master]: periodic: add __str__ methods

Milan Zamazal has posted comments on this change. Change subject: periodic: add __str__ methods .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48193 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: vm: more robust support of event strings

Milan Zamazal has posted comments on this change. Change subject: vm: more robust support of event strings .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48517 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: vm: add support for "Crashed" event

Milan Zamazal has posted comments on this change. Change subject: vm: add support for "Crashed" event .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48594 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: virt: vm: Use formatting string to log domxml

Milan Zamazal has uploaded a new change for review. Change subject: virt: vm: Use formatting string to log domxml .. virt: vm: Use formatting string to log domxml Variable data shouldn't be passed to logging as the first (messag

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/48542/2/tests/utilsTests.py File tests/utilsTest

Change in vdsm[master]: virt: vm: Use formatting string to log domxml

Milan Zamazal has abandoned this change. Change subject: virt: vm: Use formatting string to log domxml .. Abandoned SimpleLogAdapter doesn't interpret the first argument as a format string. -- To view, visit https://gerrit.ov

Change in vdsm[ovirt-3.6]: vm: periodic: NumaInfoMonitor doesn't need jobs

Milan Zamazal has posted comments on this change. Change subject: vm: periodic: NumaInfoMonitor doesn't need jobs .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48411 To unsubscribe, visit https://ger

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 3: Let's summarize what we can do about this change: # "Only strings, no unicodes in VDSM int

Change in vdsm[master]: vmstats: reformat to make the code nicer

Milan Zamazal has posted comments on this change. Change subject: vmstats: reformat to make the code nicer .. Patch Set 2: Code-Review+1 It's arguable whether inserting two more lines makes the code nicer or the other way roun

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 4: Verified+1 I verified the patch works by: - Building Engine version ovirt-engine-3.6.0.3 + fbfaf9

Change in vdsm[master]: startup: Change system default encoding to utf8

Milan Zamazal has posted comments on this change. Change subject: startup: Change system default encoding to utf8 .. Patch Set 4: Code-Review+1 (3 comments) I made some checks and it seems this patch indeed solves the string/u

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48542/2/vdsm/logUtils.py File vdsm/logUtils.py:

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 3: > this issue should be fixed by https://gerrit.ovirt.org/48661 Indeed, I think that patch

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 4: (3 comments) Is the test better in patch set 5? https://gerrit.ovirt.org/#/c/48404/4/tests/vmTe

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/48542/3/tests/utilsTests.py File tests/utilsTests

Change in vdsm[ovirt-3.6]: periodic: make VmDispatcher ignore TooManyTasks

Milan Zamazal has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48409 To unsubscribe, visit https://ger

Change in vdsm[ovirt-3.6]: vm: add support for "Crashed" event

Milan Zamazal has posted comments on this change. Change subject: vm: add support for "Crashed" event .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48790 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: virt: devices: initial support for device updates with etree's

Milan Zamazal has posted comments on this change. Change subject: virt: devices: initial support for device updates with etree's .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46525/1/vdsm/virt/domain_descriptor.py F

Change in vdsm[master]: config: Trivial typo fix in option description

Milan Zamazal has uploaded a new change for review. Change subject: config: Trivial typo fix in option description .. config: Trivial typo fix in option description Change-Id: I527f3f64601d1845e5cca2c73b44d69f957df78f Signed-off

Change in vdsm[master]: stomp: Drain pending bytes from SSLConnection

Milan Zamazal has posted comments on this change. Change subject: stomp: Drain pending bytes from SSLConnection .. Patch Set 2: Verified+1 I verified that it fixes https://bugzilla.redhat.com/1274670 for me: - I downloaded the

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has uploaded a new change for review. Change subject: virt: vm: Update time on VM after resume .. virt: vm: Update time on VM after resume When a VM is resumed from suspension and/or migrated, its clock continues f

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/48860/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1200:

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

Milan Zamazal has posted comments on this change. Change subject: debuging: Use __repr__ instead of __str__ .. Patch Set 1: Code-Review+1 I'd suggest documenting __str__ vs. __repr__ usage on http://www.ovirt.org/Vdsm_Coding_G

Change in vdsm[master]: lib: executor: log pool status on discard

Milan Zamazal has posted comments on this change. Change subject: lib: executor: log pool status on discard .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48333/5/lib/vdsm/executor.py File lib/vdsm/executor.py: Line

Change in vdsm[ovirt-3.6]: daemon: ignore cpu affinity on single processor

Milan Zamazal has posted comments on this change. Change subject: daemon: ignore cpu affinity on single processor .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48961 To unsubscribe, visit https://ger

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

Milan Zamazal has posted comments on this change. Change subject: debuging: Use __repr__ instead of __str__ .. Patch Set 1: > do you want to update this page now? OK, I'll do it once we are in confirmed agreement on the method

Change in vdsm[master]: gitignore: Missing autogenerated files added

Milan Zamazal has posted comments on this change. Change subject: gitignore: Missing autogenerated files added .. Patch Set 1: Dan, is it OK to merge this trivial change to get rid of it? -- To view, visit https://gerrit.ovir

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 5: (1 comment) Just renamed a one-char variable in tests. https://gerrit.ovirt.org/#/c/48404/5/tes

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48860/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2808: Lin

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 2: (1 comment) Jenkins happy after rebase. https://gerrit.ovirt.org/#/c/48860/2/vdsm/virt/vm.py File vdsm

Change in vdsm[ovirt-3.6]: vm: reformat _EVENT_STRINGS

Milan Zamazal has posted comments on this change. Change subject: vm: reformat _EVENT_STRINGS .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48789 To unsubscribe, visit https://gerrit.ovirt.org/settin

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 6: Verified+1 It still works, verified in the same way as in Patch Set 4. -- To view, visit https:

Change in vdsm[master]: lib: executor: log pool status on discard

Milan Zamazal has posted comments on this change. Change subject: lib: executor: log pool status on discard .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48333 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/48860/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1190:

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 4: Additionally virdomain.NotConnectedError handled in this patch set. -- To view, visit https://gerrit.o

Change in vdsm[ovirt-3.6]: vmstats: network: avoid ZeroDivisionError

Milan Zamazal has posted comments on this change. Change subject: vmstats: network: avoid ZeroDivisionError .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48478/1/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py: Line

Change in vdsm[ovirt-3.6]: vmstats: network: avoid ZeroDivisionError

Milan Zamazal has posted comments on this change. Change subject: vmstats: network: avoid ZeroDivisionError .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48478/2/tests/vmStatsTests.py File tests/vmStatsTests.py: Li

Change in vdsm[ovirt-3.6]: periodic: add __str__ methods

Milan Zamazal has posted comments on this change. Change subject: periodic: add __str__ methods .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49143 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 6: (5 comments) https://gerrit.ovirt.org/#/c/48404/6//COMMIT_MSG Commit Message: Line 8: Line 9:

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 7: Verified+1 Verified by manually testing it as usually. -- To view, visit https://gerrit.ovirt.o

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/48404/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 156

Change in vdsm[master]: virt: introduce "Async" helper

Milan Zamazal has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: Code-Review-1 (11 comments) I can't get rid of feeling that the implementation is too complicated for the simple

Change in vdsm[master]: startup: Change system default encoding to utf8

Milan Zamazal has posted comments on this change. Change subject: startup: Change system default encoding to utf8 .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48661 To unsubscribe, visit https://ger

Change in vdsm[master]: virt: introduce "Async" helper

Milan Zamazal has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: Martin, I think we can go with Async if we can simplify it. E.g. how about something like the following in do():

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/48404/8/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: virt: vm: Update time on VM after migration

Milan Zamazal has uploaded a new change for review. Change subject: virt: vm: Update time on VM after migration .. virt: vm: Update time on VM after migration When a VM is resumed from suspension and/or migrated, its clock conti

Change in vdsm[master]: virt: enhance/fix migration.SourceThread.stop()

Milan Zamazal has posted comments on this change. Change subject: virt: enhance/fix migration.SourceThread.stop() .. Patch Set 12: Verified+1 With migration working again in master, I rebased and tried to cancel VM migration a

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 8: Verified+1 I verified by: - Building Engine version ovirt-engine-3.6.0.3 + fbfaf94 (vmconsole di

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 4: Verified+1 Verified by: - Suspending a VM (without NTP running) from engine for a while. - Awaking the V

Change in vdsm[master]: tests: proper cleanup in periodic tests

Milan Zamazal has posted comments on this change. Change subject: tests: proper cleanup in periodic tests .. Patch Set 5: Code-Review+1 Just for curiosity: Why unreliable test results -- is it due to extra resource consumption

Change in vdsm[ovirt-3.6]: clientIF: add logs during the recovery

Milan Zamazal has posted comments on this change. Change subject: clientIF: add logs during the recovery .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49140 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: packaging: updating for VDSM 4.17.4 on Debian jessie

Milan Zamazal has posted comments on this change. Change subject: packaging: updating for VDSM 4.17.4 on Debian jessie .. Patch Set 35: Code-Review-1 (10 comments) Current Debian packaging looks like a reasonable start, let's

Change in vdsm[master]: guestagent: Send complete messages

Milan Zamazal has posted comments on this change. Change subject: guestagent: Send complete messages .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49339 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: guestagent: Remove unneeded encoding

Milan Zamazal has posted comments on this change. Change subject: guestagent: Remove unneeded encoding .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49338 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: guestagent: Use %r for logging message

Milan Zamazal has posted comments on this change. Change subject: guestagent: Use %r for logging message .. Patch Set 1: Code-Review+1 Of course, this is going to escape all such characters in the message, but I assume it's a

Change in vdsm[master]: guestagent: Log guest agent life cycle events

Milan Zamazal has posted comments on this change. Change subject: guestagent: Log guest agent life cycle events .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49341 To unsubscribe, visit https://gerri

Change in vdsm[master]: guestagent: Rename connect() to start()

Milan Zamazal has posted comments on this change. Change subject: guestagent: Rename connect() to start() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49342 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: guestagent: Add missing log on disconnect

Milan Zamazal has posted comments on this change. Change subject: guestagent: Add missing log on disconnect .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49343 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

Milan Zamazal has posted comments on this change. Change subject: lib: daemon: autodetect online cpus for affinity .. Patch Set 2: Code-Review-1 (8 comments) Basically fine, just please polish it a bit (especially documentatio

Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

Milan Zamazal has posted comments on this change. Change subject: lib: daemon: autodetect online cpus for affinity .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49402 To unsubscribe, visit https://ge

Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

Milan Zamazal has posted comments on this change. Change subject: lib: daemon: autodetect online cpus for affinity .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49402/4//COMMIT_MSG Commit Message: Line 34: l ... ad

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

Milan Zamazal has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/48672/12/vdsm/v2v.py File vdsm/v2v.py: Line 647: if e.ge

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

Milan Zamazal has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 13: Code-Review+1 (4 comments) Please fix the typos, otherwise fine for me. https://gerrit.ovirt.org/#/c/48672

Change in vdsm[master]: virt: enhance migration.SourceThread.stop()

Milan Zamazal has posted comments on this change. Change subject: virt: enhance migration.SourceThread.stop() .. Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40520 To unsubscribe, visit https://gerrit

Change in vdsm[master]: virt: add run_async helper

Milan Zamazal has posted comments on this change. Change subject: virt: add run_async helper .. Patch Set 1: (2 comments) Looks nice to me. Just docstrings are missing and see my comments on tests. https://gerrit.ovirt.org/#/

Change in vdsm[master]: v2v: add try/except to get_external_vms

Milan Zamazal has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py File vdsm/v2v.py: Line 175:

Change in vdsm[master]: v2v: add try/except to get_external_vms

Milan Zamazal has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py File vdsm/v2v.py: Line 175:

Change in vdsm[master]: v2v: add try/except to get_external_vms

Milan Zamazal has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py File vdsm/v2v.py: Line 154: p

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

Milan Zamazal has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 2: Code-Review-1 I think the corresponding master patch is actually https://gerrit.ovirt.org/49507. Not yet

Change in vdsm[master]: v2v: add try/except to get_external_vms

Milan Zamazal has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py File vdsm/v2v.py: Line 154:

Change in vdsm[master]: virt: add run_async helper

Milan Zamazal has posted comments on this change. Change subject: virt: add run_async helper .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/49570/2/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 121: Line 122:

  1   2   3   4   5   6   7   8   9   >