[chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656
[+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really normal UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last one since it's a crasher): - DownloadManagerTest.TestDownloadFilename - BookmarkCodecTest.PersistIDsTest - BookmarkContextMenuTest.DeleteURL M-A On Wed, Jan 20, 2010 at 5:16 PM, Mike Pinkerton pinker...@chromium.orgwrote: I don't see how these tests could fail with my (effectively) mac-only change. On Wed, Jan 20, 2010 at 5:14 PM, tryser...@chromium.org wrote: http://build.chromium.org/buildbot/try-server/ TRY FAILED *If you think the try slave is broken (it happens!), please REPLY to this email, don't ask on irc, mailing list or IM.* Thanks! http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 win Build 15281http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 'pinkerton: appmode' try job svnkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell/logs/stdio update scripts stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_1/logs/stdio taskkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_2/logs/stdio update patchhttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/patch stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/stdio compile stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/compile/logs/stdio Start Crash Handler stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/Start%20Crash%20Handler/logs/stdio check deps stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/check%20deps/logs/stdio ipc_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ipc_tests/logs/stdio installer_util_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/installer_util_unittests/logs/stdio sync_unit_tests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/sync_unit_tests/logs/stdio unit_tests did not complete failed 2 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/stdio PersistIDsTesthttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/PersistIDsTest TestDownloadFilenamehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/TestDownloadFilename app_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/app_unittests/logs/stdio ui_tests 27 disabled 38 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/stdio FLAKY_LocationReplacehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/FLAKY_LocationReplace test_shell_tests 2 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/test_shell_tests/logs/stdio webkit_unit_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/webkit_unit_tests/logs/stdio base_unittests 1 disabled 2 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/base_unittests/logs/stdio net_unittests 7 disabled 7 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/net_unittests/logs/stdio googleurl_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/googleurl_unittests/logs/stdio media_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/media_unittests/logs/stdio printing_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/printing_unittests/logs/stdio browser_tests 1001 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/stdio FLAKY_Popuphttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/FLAKY_Popup FAQ: http://dev.chromium.org/developers/try-server-usage -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656
Clobber Done. On Thu, Jan 21, 2010 at 9:44 AM, Thomas Van Lenten thoma...@chromium.orgwrote: DownloadFilename is a strings error, the bot needs a clobber. We had this on the main waterfall yesterday morning also and the few that saw it got fixed by a clobber. TVL On Thu, Jan 21, 2010 at 9:36 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: [+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really normal UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last one since it's a crasher): - DownloadManagerTest.TestDownloadFilename - BookmarkCodecTest.PersistIDsTest - BookmarkContextMenuTest.DeleteURL M-A On Wed, Jan 20, 2010 at 5:16 PM, Mike Pinkerton pinker...@chromium.orgwrote: I don't see how these tests could fail with my (effectively) mac-only change. On Wed, Jan 20, 2010 at 5:14 PM, tryser...@chromium.org wrote: http://build.chromium.org/buildbot/try-server/ TRY FAILED *If you think the try slave is broken (it happens!), please REPLY to this email, don't ask on irc, mailing list or IM.* Thanks! http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 win Build 15281http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 'pinkerton: appmode' try job svnkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell/logs/stdio update scripts stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_1/logs/stdio taskkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_2/logs/stdio update patchhttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/patch stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/stdio compile stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/compile/logs/stdio Start Crash Handler stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/Start%20Crash%20Handler/logs/stdio check deps stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/check%20deps/logs/stdio ipc_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ipc_tests/logs/stdio installer_util_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/installer_util_unittests/logs/stdio sync_unit_tests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/sync_unit_tests/logs/stdio unit_tests did not complete failed 2 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/stdio PersistIDsTesthttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/PersistIDsTest TestDownloadFilenamehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/TestDownloadFilename app_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/app_unittests/logs/stdio ui_tests 27 disabled 38 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/stdio FLAKY_LocationReplacehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/FLAKY_LocationReplace test_shell_tests 2 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/test_shell_tests/logs/stdio webkit_unit_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/webkit_unit_tests/logs/stdio base_unittests 1 disabled 2 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/base_unittests/logs/stdio net_unittests 7 disabled 7 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/net_unittests/logs/stdio googleurl_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/googleurl_unittests/logs/stdio media_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/media_unittests/logs/stdio printing_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/printing_unittests/logs/stdio browser_tests 1001 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/stdio FLAKY_Popuphttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/FLAKY_Popup FAQ: http://dev.chromium.org/developers/try-server-usage -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email
Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656
With regards to BookmarkContextMenuTest.DeleteURL, I filed http://crbug.com/32784. Glen, you should make sure this bug is triaged accordingly since flaky crashers can't be tolerated. M-A On Thu, Jan 21, 2010 at 9:45 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: Clobber Done. On Thu, Jan 21, 2010 at 9:44 AM, Thomas Van Lenten thoma...@chromium.orgwrote: DownloadFilename is a strings error, the bot needs a clobber. We had this on the main waterfall yesterday morning also and the few that saw it got fixed by a clobber. TVL On Thu, Jan 21, 2010 at 9:36 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: [+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really normal UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last one since it's a crasher): - DownloadManagerTest.TestDownloadFilename - BookmarkCodecTest.PersistIDsTest - BookmarkContextMenuTest.DeleteURL M-A On Wed, Jan 20, 2010 at 5:16 PM, Mike Pinkerton pinker...@chromium.orgwrote: I don't see how these tests could fail with my (effectively) mac-only change. On Wed, Jan 20, 2010 at 5:14 PM, tryser...@chromium.org wrote: http://build.chromium.org/buildbot/try-server/ TRY FAILED *If you think the try slave is broken (it happens!), please REPLY to this email, don't ask on irc, mailing list or IM.* Thanks! http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 win Build 15281http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 'pinkerton: appmode' try job svnkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell/logs/stdio update scripts stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_1/logs/stdio taskkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_2/logs/stdio update patchhttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/patch stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/stdio compile stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/compile/logs/stdio Start Crash Handler stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/Start%20Crash%20Handler/logs/stdio check deps stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/check%20deps/logs/stdio ipc_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ipc_tests/logs/stdio installer_util_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/installer_util_unittests/logs/stdio sync_unit_tests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/sync_unit_tests/logs/stdio unit_tests did not complete failed 2 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/stdio PersistIDsTesthttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/PersistIDsTest TestDownloadFilenamehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/TestDownloadFilename app_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/app_unittests/logs/stdio ui_tests 27 disabled 38 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/stdio FLAKY_LocationReplacehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/FLAKY_LocationReplace test_shell_tests 2 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/test_shell_tests/logs/stdio webkit_unit_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/webkit_unit_tests/logs/stdio base_unittests 1 disabled 2 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/base_unittests/logs/stdio net_unittests 7 disabled 7 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/net_unittests/logs/stdio googleurl_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/googleurl_unittests/logs/stdio media_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/media_unittests/logs/stdio printing_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/printing_unittests/logs/stdio browser_tests 1001 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/stdio FLAKY_Popuphttp://build.chromium.org/buildbot/try-server/builders
[chromium-dev] Build exceptions
Don't panic with the main waterfal, it's just a hotpatch to fix an exception that ... generated more exceptions. At least, the original exception is fixed. So I'll just restart the master to make sure nothing dangling is left. M-A -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Missing symbols for Chrome 3.0.195.38
FYI, the symbols were added on Dec 30. http://build.chromium.org/buildbot/symbols/3.0.195.38/chrome_dll.pdb http://build.chromium.org/buildbot/symsrv/chrome_dll.pdb/A94BABB37F7A4445A7A2C7BC2B796FD81/chrome_dll.pdb M-A On Tue, Dec 29, 2009 at 10:14 PM, yuhong yuhongbao_...@hotmail.com wrote: BTW, consider compressing symbols to make downloads faster. -- DBGHELP: c:\windows\symbols\chrome_dll.pdb - file not found DBGHELP: c:\windows\symbols\dll\chrome_dll.pdb - file not found DBGHELP: c:\windows\symbols\symbols\dll\chrome_dll.pdb - file not found SYMSRV: c:\downloads\symbols\chrome_dll.pdb \A94BABB37F7A4445A7A2C7BC2B796FD81\chrome_dll.pdb not found SYMSRV: http://msdl.microsoft.com/download/symbols/chrome_dll.pdb/A94BABB37F7A4445A7A2C7BC2B796FD81/chrome_dll.pdb not found SYMSRV: c:\downloads\symbols\chrome_dll.pdb \A94BABB37F7A4445A7A2C7BC2B796FD81\chrome_dll.pdb not found SYMSRV: http://build.chromium.org/buildbot/symsrv/chrome_dll.pdb/A94BABB37F7A4445A7A2C7BC2B796FD81/chrome_dll.pdb not found SYMSRV: c:\downloads\symbols\chrome_dll.pdb \A94BABB37F7A4445A7A2C7BC2B796FD81\chrome_dll.pdb not found SYMSRV: http://symbols.mozilla.org/firefox/chrome_dll.pdb/A94BABB37F7A4445A7A2C7BC2B796FD81/chrome_dll.pdb not found DBGHELP: C:\b\slave\chrome-official-2\build\src\chrome\Release \chrome_dll.pdb - file not found *** ERROR: Symbol file could not be found. Defaulted to export symbols for C:\Users\bob\AppData\Local\Google\Chrome\Application \3.0.195.38\chrome.dll - DBGHELP: chrome_6206 - export symbols DBGHELP: c:\windows\symbols\chrome_exe.pdb - file not found DBGHELP: c:\windows\symbols\exe\chrome_exe.pdb - file not found DBGHELP: c:\windows\symbols\symbols\exe\chrome_exe.pdb - file not found SYMSRV: c:\downloads\symbols\chrome_exe.pdb \E909049038764DE8A2AB75715E30ACB31\chrome_exe.pdb not found SYMSRV: http://msdl.microsoft.com/download/symbols/chrome_exe.pdb/E909049038764DE8A2AB75715E30ACB31/chrome_exe.pdb not found SYMSRV: c:\downloads\symbols\chrome_exe.pdb \E909049038764DE8A2AB75715E30ACB31\chrome_exe.pdb not found SYMSRV: http://build.chromium.org/buildbot/symsrv/chrome_exe.pdb/E909049038764DE8A2AB75715E30ACB31/chrome_exe.pdb not found SYMSRV: c:\downloads\symbols\chrome_exe.pdb \E909049038764DE8A2AB75715E30ACB31\chrome_exe.pdb not found SYMSRV: http://symbols.mozilla.org/firefox/chrome_exe.pdb/E909049038764DE8A2AB75715E30ACB31/chrome_exe.pdb not found DBGHELP: C:\Users\bob\AppData\Local\Google\Chrome\Application \chrome_exe.pdb - file not found DBGHELP: C:\b\slave\chrome-official-2\build\src\chrome\Release \chrome_exe.pdb - file not found *** ERROR: Symbol file could not be found. Defaulted to export symbols for C:\Users\bob\AppData\Local\Google\Chrome\Application \chrome.exe - DBGHELP: chrome - export symbols -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] How to deal with flaky unit tests
http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/scripts/master/log_parser/gtest_command.py?revision=28463view=markup has some logic for that but doesn't seem to work anymore. Nicolas is on vacation, I'll take a look soon: http://crbug.com/30599 M-A On Fri, Dec 18, 2009 at 1:47 AM, Paweł Hajdan, Jr. phajdan...@chromium.orgwrote: Looks like the browser_tests launcher needs to be updated, because its exit code was 1 (that's why the bot went red). On Fri, Dec 18, 2009 at 04:33, Lei Zhang thes...@chromium.org wrote: Does FLAKY_ work on all tests? The test run [1] for my most recent check-in turned a bot red, even though the only test that failed is one marked FLAKY_. [red] browser_tests [browser_tests 896 flaky did not complete crashed or hung] [197 seconds] [/red] and in the log; [2] ... Note: Google Test filter = AutocompleteBrowserTest.YOU HAVE 8 FLAKY TESTS [==] Running 0 tests from 0 test cases. [==] 0 tests from 0 test cases ran. (0 ms total) [ PASSED ] 0 tests. YOU HAVE 8 FLAKY TESTS 113 tests run 1 test failed Failing tests: ExtensionBrowserTest.FLAKY_AutoUpdate program finished with exit code 1 elapsedTime=197.683425 [1] http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(Views%20dbg)/builds/5784 [2] http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(Views%20dbg)/builds/5784/steps/browser_tests/logs/stdio On Tue, Oct 6, 2009 at 4:02 PM, Nicolas Sylvain nsylv...@chromium.org wrote: Hello, We currently have more than 50 unit tests that are disabled. Most of them because they were flaky. Disabling tests is bad because we lose complete coverage on them, so I implemented a way to mark tests as flaky. The same way you disable a test with DISABLED_ at the beginning of its name, you can now mark is as flaky with FLAKY_. The behavior is exactly the same as any other running tests. You will still be able to see when it fails (and why). The only difference is that if only FLAKY_ tests failed, the buildbot/trybots won't consider it as a failure. On the waterfall, it will show the box as orange with the list of all flaky tests that failed (pending one more buildbot restart). On the console view it will stay green. But.. this is not a toy. Flaky tests are bad. We should mark tests flaky only if we really have to, and if you do, please make sure to file a P1 bug. Set the owner of the bug to whoever regressed the test. If you can't find who regressed the test, assign it to the person who originally wrote the test. Once we start tagging the flaky tests, we will monitor the flakiness dashboard and make sure that a test that is no longer flaky has its FLAKY_ tag removed. Let me know if you have questions. Thanks Nicolas --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~--- -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Trybot to run WebKit's LayoutTests?
1. Install VS2005 Pro or better. or 2. Yes there is a wekbit try server but it cannot be triggered outside Google yet. Check your emails. http://build.chromium.org/buildbot/webkit-try/waterfall M-A On Thu, Dec 17, 2009 at 1:09 PM, Dominic Mazzoni dmazz...@google.com wrote: That's what I was afraid of. On Thu, Dec 17, 2009 at 9:58 AM, Dan Kegel d...@kegel.com wrote: I have had problems trying to install both 2005 and 2008, not sure why, probably dueling service packs? On Dec 17, 2009 9:14 AM, Dominic Mazzoni dmazz...@google.com wrote: Is there a WebKit trybot? I'm working on a small WebKit patch (https://bugs.webkit.org/show_bug.cgi?id=32571), but my test requires a small change to DumpRenderTree, so I can't just test it using chromium. I've already run the LayoutTests on the Mac, and I'm working on compiling the GTK port on Linux now, but my Windows box has VS 2008 and it looks like WebKit still only has support for VS 2005. 1. Is there a trybot that will run the WebKit version of the LayoutTests on Windows? 2. Or, is it safe to install VS 2005 express edition after I've already installed the full VS 2008? Has anyone tried it? Will it break anything? 3. Or, is anyone who's already compiled WebKit on Windows willing to help me out and quick test this patch? It's small and should only require a couple of iterations, max. Thanks, Dominic -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] linux_view trybot seems unable to accept any patch
Thanks Lei for fixing everything! M-A On Wed, Dec 16, 2009 at 12:42 AM, Lei Zhang thes...@chromium.org wrote: I also needed to install libpam0g-dev. Linux_view try bots should be happy now. On Tue, Dec 15, 2009 at 7:03 PM, Lei Zhang thes...@chromium.org wrote: It'll reload the try server configuration so try jobs will pull the right deps. I already installed git 1.6 on the linux_view and linux_chromeos try bots. On Tue, Dec 15, 2009 at 6:15 PM, Chris Masone cmas...@google.com wrote: I'm not familiar with the infrastructure...what will that make it do? Also, djmm@ is working on getting install_build_deps.sh to install an appropriate version of git...we should still get that done, right? On Tue, Dec 15, 2009 at 6:13 PM, Lei Zhang thes...@chromium.org wrote: Unless I hear otherwise, I'll restart the try server master tonight at 9 PM PST, and apologize to the people whose try jobs failed as a result. On Tue, Dec 15, 2009 at 4:48 PM, Lei Zhang thes...@chromium.org wrote: Hmm, is the try server master overdue for a reload/restart? The master.cfg is right, but it's still checking out chrome-deps. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] linux_view trybot seems unable to accept any patch
I've been offline most of the day. On Dec 15, 2009 6:46 PM, Mitsuru Oshima osh...@google.com wrote: satorux asked maruel to fix it several hours ago. maruel? - oshima On Tue, Dec 15, 2009 at 3:37 PM, Lei Zhang thes...@chromium.org wrote: It has a custom .gcli... -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] linux_view trybot seems unable to accept any patch
This lame email was a courtesy of Nexus One. So if you have time, good ahead otherwise I'll take care. On Dec 15, 2009 6:46 PM, Mitsuru Oshima osh...@google.com wrote: satorux asked maruel t... - oshima On Tue, Dec 15, 2009 at 3:37 PM, Lei Zhang thes...@chromium.org wrote: It has a custom .gcli... -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Modifying .gyp files
http://code.google.com/p/gyp has some wiki pages.
On Thu, Dec 10, 2009 at 10:49 AM, Igor Gatis igorga...@gmail.com wrote:
Thanks Mark.
BTW, do you guys know of lists or wiki I could get more information
regarding GYP tool?
On Wed, Dec 9, 2009 at 5:40 PM, Mark Mentovai m...@chromium.org wrote:
There's better info in gclient.py, as a comment. Maybe we can just
rip this off and stick it in a web page somewhere on the developer
site.
Hooks
.gclient and DEPS files may optionally contain a list named hooks to
allow custom actions to be performed based on files that have changed in
the
working copy as a result of a sync/update or revert operation.
This
could be prevented by using --nohooks (hooks run by default). Hooks can
also
be forced to run with the runhooks operation. If sync is run with
--force, all known hooks will run regardless of the state of the working
copy.
Each item in a hooks list is a dict, containing these two keys:
pattern The associated value is a string containing a regular
expression. When a file whose pathname matches the
expression
is checked out, updated, or reverted, the hook's action
will
run.
action A list describing a command to run along with its arguments,
if
any. An action command will run at most one time per
gclient
invocation, regardless of how many files matched the
pattern.
The action is executed in the same directory as the .gclient
file. If the first item in the list is the string python,
the current Python interpreter (sys.executable) will be used
to run the command. If the list contains string
$matching_files
it will be removed from the list and the list will be
extended
by the list of matching files.
Example:
hooks = [
{ pattern: \\.(gif|jpe?g|pr0n|png)$,
action: [python, image_indexer.py, --all]},
]
Marc-Antoine Ruel wrote:
Humm, that's a good question. Right now the only doc is gclient help
runhooks which is .. uh .. not really useful.
M-A
On Wed, Dec 9, 2009 at 3:28 PM, Igor Gatis igorga...@gmail.com wrote:
Is there documentation somewhere regarding gclient? I'd like to know
more
about how hooks and other gclient features work.
On Tue, Dec 8, 2009 at 6:27 PM, Mark Mentovai mmento...@google.com
wrote:
Igor Gatis wrote:
When I change a .gyp, do I need to call gyp or the build process
does
that
for me?
When you change it yourself, in your own working copy, you run
gclient runhooks to get new files generated.
When a .gyp change is checked in, you don't need to do this: gclient
will automatically run GYP as needed when you run gclient sync.
Mark
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Embedding Chromium
http://code.google.com/p/chromiumembedded/. Marshall would probably appreciate to have some help. On Thu, Dec 10, 2009 at 12:43 PM, hap 497 hap...@gmail.com wrote: Hi, Is it possible to embed a chromium in my c/c++ application? (just like someone embed a Webkit rendering engine in his application). I understand chromium uses Webkit rendering engine too. But I would like to take advantage Chromium's v8 javascript engine and it 1 process/tab architecture. Thank you. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Thoughts on // NOLINT?
On Thu, Dec 10, 2009 at 2:24 PM, Peter Kasting pkast...@google.com wrote: On Thu, Dec 10, 2009 at 11:20 AM, Jacob Mandelson ja...@mandelson.org wrote: If something extra in an expression is a common case, I've sometimes seen it done like: return DoWork(foo) POSIX_ONLY( DoWork(posix_specific)); where POSIX_ONLY will expand to nothing or its argument. It's ugly, but compact. The Google C++ Style Guide says to avoid macros when there is a non-macro way to do the same thing. Sanity says that too. Scott's technique is the best. If you can't figure out what's happening by glancing at the code, it's not code, it's assembly. M-A (grr) -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Thoughts on // NOLINT?
On Thu, Dec 10, 2009 at 3:02 PM, Shall be Unnamed @google.com wrote: On Thu, Dec 10, 2009 at 2:29 PM, Marc-Antoine Ruel mar...@chromium.orgwrote: On Thu, Dec 10, 2009 at 2:24 PM, Peter Kasting pkast...@google.com wrote: On Thu, Dec 10, 2009 at 11:20 AM, Jacob Mandelson ja...@mandelson.org wrote: If something extra in an expression is a common case, I've sometimes seen it done like: return DoWork(foo) POSIX_ONLY( DoWork(posix_specific)); where POSIX_ONLY will expand to nothing or its argument. It's ugly, but compact. The Google C++ Style Guide says to avoid macros when there is a non-macro way to do the same thing. Sanity says that too. Scott's technique is the best. If you can't figure out what's happening by glancing at the code, it's not code, it's assembly. I'd say: If you can't figure out what's happening by glancing at the code, it's not code, it's template metaprogramming. Assembly is easy! [Makes a face in the general direction of Herb Sutter.] LOL Were you looking at src/base/singleton.h lately? M-A -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Modifying .gyp files
Humm, that's a good question. Right now the only doc is gclient help runhooks which is .. uh .. not really useful. M-A On Wed, Dec 9, 2009 at 3:28 PM, Igor Gatis igorga...@gmail.com wrote: Is there documentation somewhere regarding gclient? I'd like to know more about how hooks and other gclient features work. On Tue, Dec 8, 2009 at 6:27 PM, Mark Mentovai mmento...@google.com wrote: Igor Gatis wrote: When I change a .gyp, do I need to call gyp or the build process does that for me? When you change it yourself, in your own working copy, you run gclient runhooks to get new files generated. When a .gyp change is checked in, you don't need to do this: gclient will automatically run GYP as needed when you run gclient sync. Mark -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Tryconsole
On Tue, Dec 8, 2009 at 4:13 PM, Evan Martin e...@chromium.org wrote: On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson bradnel...@google.com wrote: I've got a prototype summary view of the trybots up at http://tryconsole.appspot.com/ This will let you monitor/find your try jobs without digging through the waterfall. The text prompt lets you search (username / builder / change name). The two summary graphs show load for the day, load for the hour. I'd love suggestions on how to make this more useful. Not sure if it's exactly in this space, but it'd be nice to have the try script dump the URLs of the try servers involved. I would use this when trying a patch from someone else, so I could paste the try server URls into the code review. Will give you one soon. I'd have given it but I just realized it throws an exception server side. M-A -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Tryconsole
I hotpatched the server to fix the exception but without the build steps, it's still not very useful. I'll try to get the build steps this week in. Sample: http://build.chromium.org/buildbot/try-server/json/builders/linux/builds/10906?as_text=1 Remove the ?as_text=1 to receive it as application/json On Tue, Dec 8, 2009 at 4:22 PM, Marc-Antoine Ruel mar...@chromium.org wrote: On Tue, Dec 8, 2009 at 4:13 PM, Evan Martin e...@chromium.org wrote: On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson bradnel...@google.com wrote: I've got a prototype summary view of the trybots up at http://tryconsole.appspot.com/ This will let you monitor/find your try jobs without digging through the waterfall. The text prompt lets you search (username / builder / change name). The two summary graphs show load for the day, load for the hour. I'd love suggestions on how to make this more useful. Not sure if it's exactly in this space, but it'd be nice to have the try script dump the URLs of the try servers involved. I would use this when trying a patch from someone else, so I could paste the try server URls into the code review. Will give you one soon. I'd have given it but I just realized it throws an exception server side. M-A -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Re: Never build chromium by Visual Studio 2008 + SP1
Thanks for the notice but we have good performance regression testing. Also, the official builds don't use /O2. Only the continuous build uses /O2. IIRC, VS2008 RTM cannot be used to build Chromium. M-A On Tue, Dec 1, 2009 at 4:54 AM, avcoder ffm...@gmail.com wrote: Sorry: .I can only get about 34xx score if i built chromium by VS2005, but I get 23xx score if I built with VS2008, the performance difference is huge( 34xx vs 23xx) should be: .I can get about 34xx score if i built chromium by VS2005, but I only get 23xx score if I built with VS2008, the performance difference is huge( 34xx vs 23xx) On Dec 1, 5:49 pm, avcoder ffm...@gmail.com wrote: Dear: Never build chromium by Visual Studio 2008 + SP1, otherwise, you will get huge performance penalty ***Visual Studio 2008 C++ code slower than Visual Studio 2005*** Please check the following link: http://social.msdn.microsoft.com/Forums/en-US/vcgeneral/thread/fb3203... In Visual Studio 2008 SP1 (SP1 not RTM) there is a serious bug with / O2 optimization. One way this bug can be triggered is by upgrading a project from a previous version. Even though the project setting shows the release build is set to /O2, the build can be not optimized at all. To work around it you have to change the setting to no optimization, apply, and then change it back to /O2. The quick way to see if this is needed is to check whether the setting for optimization is in bold or regular - if's it's bold you're OK; if it's regular text you're not. This bug has been reported to Microsoft by many people over the past few months via the Connect feedback site but every case has been closed by them without doing anything and for completely invalid reasons. I benchmarked the latest chromium in release version with same benchmarker tool .I can only get about 34xx score if i built chromium by VS2005, but I get 23xx score if I built with VS2008, the performance difference is huge( 34xx vs 23xx) It seems that one of the following conclusions is true: 1) VS2008 + SP1 is broken on /O2 optimization 2) chromium gyp delivers bad configuration for VS2008(/O2 is ignored) -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Where buildbot outputs the intermediate builds?
I had intention in archiving the intermediate build outputs in a shallow git repo for try server speedup but I have no intention in publishing this repo externally. I would recommend you to checkout the buildbot code and setup a local continuous build yourself. Instructions: http://dev.chromium.org/developers/testing/chromium-build-infrastructure/getting-the-buildbot-source Patches are welcome for the shallow git repo functionality. M-A On Tue, Dec 1, 2009 at 10:27 AM, Roberto robj.pe...@gmail.com wrote: Are the buildbots archiving the intermediate builds before building the final executable? If they do, where are they saving them? are they available to download? If they don't, it would be pretty good if the masters of buildbots could assist in this topic :) As we talked in this thread: http://groups.google.com/group/chromium-dev/browse_thread/thread/301e4963629ce6bb/03e5d21c77d6f9a1#03e5d21c77d6f9a1 It would be quite useful in order to avoid the first big and time- consuming build. I want to give a try to the possibility of incorporating to the first check out the built libraries for each module. If it works, the next point would be to modify gclient in order to automatically checkout this built libraries as well. Thanks :) Roberto. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Compiler version used for official Windows builds?
On Mon, Nov 30, 2009 at 4:48 PM, Ted Mielczarek ted.mielcza...@gmail.comwrote: On Wed, Nov 25, 2009 at 7:42 PM, Wan-Teh Chang w...@google.com wrote: (The official build does whole program optimization and must be done on a 64-bit Windows machine with lots of memory.) Thanks for the info. That's odd, since our PGO builds don't use nearly that much memory. I can build a PGO Firefox on a 32-bit WinXP box with 2GB of ram without any thrashing. The linker tops out at a little over 1GB of memory usage while linking libxul (using VC2005 or VC2010, with VC2009 I run out of memory). I wonder what you're doing differently that requires that much memory usage? Template usage? Maybe we hit a particular case that generates a symbols overflow. M-A -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Compiler version used for official Windows builds?
On Wed, Nov 25, 2009 at 7:42 PM, Wan-Teh Chang w...@google.com wrote: On Wed, Nov 25, 2009 at 4:22 AM, Ted Mielczarek ted.mielcza...@gmail.com wrote: Hi, I couldn't find this info anywhere on the dev site (maybe I just wasn't looking hard enough), but I'm curious as to what version of Visual C++ you're using for the official Chrome builds. It's Visual C++ 2005. (The official build does whole program optimization and must be done on a 64-bit Windows machine with lots of memory.) Lots being relative. The linker just requires the full 4 gigs of address space. Simply using /3GB on a 32 bits OS isn't sufficient. I don't know if we'd seen similar problems with Breakpad symbols. Wan-Teh -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Xcode builds and dependencies
You mean you implemented http://code.google.com/p/gyp/issues/detail?id=42 but for xcode only? On Tue, Nov 24, 2009 at 9:51 AM, Thomas Van Lenten thoma...@chromium.orgwrote: Last week Mark and I talked with someone in Apple's devtools team about some of the dependency problems we've seen in our builds. We have a radar open with some repro steps, but we got a workaround for what we think we're seeing. I just rolled in a GYP change that applies this workaround(*). If you see any new cases where a you have to build twice to get everything rebuilt, please send me an email with what files you edited/changed and the raw build logs/transcripts of the extra builds so I can try to figure out what else might be going wrong and needs extra builds to fix. TVL (*) - The workaround is to move all actions/rules out of targets that compile sources. So you'll see a foo target and foo Support target, where the Support one has the actions/rules and is depended on by the target listed in the GYP file. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] How do I generate an msvs_guid for the GYP file?
AFAIK, you don't need one, it was mainly for the transition period. Brad, can we remove them all? On Tue, Nov 24, 2009 at 3:27 PM, Chris Bentzel cbent...@google.com wrote: In http://codereview.chromium.org/428004, I introduced a new GYP target - but don't have an msvs_guid for it. I'm guessing that I can just use a value from VS Tools Create GUID, but wanted to confirm this since I didn't see any documentation on generating the guids. Chris -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] workflow for cross-platform development
On Sat, Nov 21, 2009 at 1:52 PM, Chris Bentzel cbent...@google.com wrote: Have there been any thoughts about adding gcl patch and unpatch commands which will grab the file diffs as well as duplicate the CL metadata in src/.svn/gcl_info? There's the gcl metadata and the svn metadata. Webkit has a script to apply metadata but we don't. This is what Pawel was referring to. I'll lgtm a gcl patch as long as it has unit tests. Otherwise, you would make John grumpy. :D You can use gclient pack when your changes involves multiple checkout, usually webkit+chromium. M-A Sorry if this is a FAQ - but I couldn't find anything covering this on dev.chromium.org or by searching the chromium-dev group archive. Chris -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)
It's really about the unit tests, not in chromium. I guess we could probably leak the singleton in the unit tests too on each reset. Pawel, what do you think? Note to all the static local makers: you create an implicit atexit() each time... Use a leaky singleton instead. M-A On Sun, Nov 22, 2009 at 7:47 PM, Peter Kasting pkast...@google.com wrote: On Sun, Nov 22, 2009 at 4:28 PM, Mike Belshe mbel...@google.com wrote: I think we should have a list of low-level functionality which we just never cleanup. For the items you listed, I think you should leak them all. Trying to cleanup these items creates complicated code and ultimately won't run any better and possibly slower. +1 for leaking a much as possible on shutdown. We should make sure we shut down anything that can write data to disk, and then just kill the process. Right now I suspect we clean up much more stuff in the browser process than we have to. PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] gcl upload error
Thanks, when I replied to Munjal, I only replied to him by error. So the fix is to run gclient. M-A On Sat, Nov 21, 2009 at 2:56 PM, Munjal Doshi mun...@chromium.org wrote: Just in case anyone else hit this, it was fixed in 32748. -Munjal On Sat, Nov 21, 2009 at 10:04 AM, Evan Martin e...@chromium.org wrote: A guess, but it looks like it's attempting to find your email address out of your SVN authorization data, and that the computer you're on has no SVN auth data. Try something like svn ls --username=mycommitern...@chromium.org svn://... and log in if it prompts you. On Sat, Nov 21, 2009 at 12:46 AM, Munjal Doshi mun...@chromium.org wrote: I get the following error when running gcl upload when it tries to send the job to try server after successfully uploading files: Traceback (most recent call last): File C:\Tools\depot_tools\gcl.py, line 1273, in ? sys.exit(main()) File C:\Tools\depot_tools\gcl.py, line 1244, in main UploadCL(change_info, argv[3:]) File C:\Tools\depot_tools\gcl.py, line 865, in UploadCL TryChange(change_info, trychange_args, swallow_exception=True) File C:\Tools\depot_tools\gcl.py, line 901, in TryChange prog='gcl try') File C:\Tools\depot_tools\trychange.py, line 526, in TryChange options.scm.ProcessOptions() File C:\Tools\depot_tools\trychange.py, line 177, in ProcessOptions self.options.email = scm.SVN.GetEmail(gcl.GetRepositoryRoot()) File C:\Tools\depot_tools\scm.py, line 450, in GetEmail for credfile in os.listdir(auth_dir): WindowsError: [Errno 3] The system cannot find the path specified: 'C:\\Users\\munjal\\AppData\\Roaming\\auth\\svn.simpl e/*.*' Does anyone know what hte problem is? -Munjal -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] gcl upload error
[+chromium-dev] One issue is that even a smoke test wouldn't have caught this problem since as I said, it was windows specific. Maybe it's time to create a try server for depot_tools. :/ M-A On Sat, Nov 21, 2009 at 5:23 PM, Marc-Antoine Ruel mar...@google.com wrote: I totally agree, I fully understand the pain I cause. :) In this particular case for example, the tool was broken on windows only. Since I tested on linux, I didn't see the failure. I also ran pychecker on the scripts last week and found at 2 lingering errors for corner cases. I have a idea in the interim, I'll package a very small script that sends me an IM whenever someone gets an exception in these scripts. This way, the number of affected people should be much lower since I'll be able to trap these faster, at least for exception failures. I'll kick my ass to add a full smoke test this year. When I replied to Munjal, I replied only to him by error. I only realized when Munjal replied to the thread on chromium-dev that I didn't cc chromium-dev. M-A On Sat, Nov 21, 2009 at 3:37 PM, John Abd-El-Malek jabdelma...@google.com wrote: Marc-Antoine: let me preface this by saying I really appreciate all of your work on trybots + gcl, it makes our life better. I just hit this myself as well. I'm wondering if I can ask you to have a a small test case that you do which involves uploading, changing, and committing a change. The reason is I get so many failures, and with the size of the development team now, when the tool is broken it impacts a lot of engineers. Thanks, John On Sat, Nov 21, 2009 at 11:56 AM, Munjal Doshi mun...@chromium.org wrote: Just in case anyone else hit this, it was fixed in 32748. -Munjal On Sat, Nov 21, 2009 at 10:04 AM, Evan Martin e...@chromium.org wrote: A guess, but it looks like it's attempting to find your email address out of your SVN authorization data, and that the computer you're on has no SVN auth data. Try something like svn ls --username=mycommitern...@chromium.org svn://... and log in if it prompts you. On Sat, Nov 21, 2009 at 12:46 AM, Munjal Doshi mun...@chromium.org wrote: I get the following error when running gcl upload when it tries to send the job to try server after successfully uploading files: Traceback (most recent call last): File C:\Tools\depot_tools\gcl.py, line 1273, in ? sys.exit(main()) File C:\Tools\depot_tools\gcl.py, line 1244, in main UploadCL(change_info, argv[3:]) File C:\Tools\depot_tools\gcl.py, line 865, in UploadCL TryChange(change_info, trychange_args, swallow_exception=True) File C:\Tools\depot_tools\gcl.py, line 901, in TryChange prog='gcl try') File C:\Tools\depot_tools\trychange.py, line 526, in TryChange options.scm.ProcessOptions() File C:\Tools\depot_tools\trychange.py, line 177, in ProcessOptions self.options.email = scm.SVN.GetEmail(gcl.GetRepositoryRoot()) File C:\Tools\depot_tools\scm.py, line 450, in GetEmail for credfile in os.listdir(auth_dir): WindowsError: [Errno 3] The system cannot find the path specified: 'C:\\Users\\munjal\\AppData\\Roaming\\auth\\svn.simpl e/*.*' Does anyone know what hte problem is? -Munjal -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] support for WATCHLISTS in git-cl
On Thu, Nov 19, 2009 at 4:46 PM, Evan Martin e...@chromium.org wrote: On Thu, Nov 19, 2009 at 12:56 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: It turns out that WATCHLISTS aren't fully effective because git-cl doesn't support them. It doesn't look very hard to implement the support for git-cl because there is already a watchlists.py file, but then there are some questions: - should the watchlists.py file (from depot_tools) be copied to the git-cl repo or should git-cl try to locate it (upload.py is copied) Can we hook it into the PRESUBMIT script instead? That seems cleaner to me. See my point #3 in my first comment at http://codereview.chromium.org/118432 -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: New Presubmit actions
First, I'd prefer to keep the presubmit checks from having any side-effect. For a) You haven't mentioned which editor you use but if it is a problem for you, maybe you should tweak the editor? VS, emacs, vim can be modified to do it or at least highlight it; I don't know about xcode. Otherwise a very simple python script can do it for you, maybe you could create a new kind of gcl hook. git already has functionality for commit hooks. For b), follow the steps at http://dev.chromium.org/developers/coding-style#TOC-Subversion-properties It's necessary for git usage too. M-A On Wed, Nov 18, 2009 at 4:26 PM, Dave MacLachlan dmacl...@google.com wrote: Hey Marc-Antoine: What would it take to have the presubmit scripts automagically do the following: a) Remove all whitespace at the end of .h, .c, .cc and .mm files? b) Apply 'svn pset svn:eol-style LF' as necessary to .h, .c, .cc and .mm files? This would save me a great deal of time. My editor of choice does not take care of getting rid of the whitespace for me. Cheers, Dave -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] buildbot failure in Chromium on Mac10.5 Tests, revision 32176
Glad to see you back, gatekeeper! chase++ On Tue, Nov 17, 2009 at 12:29 PM, build...@chromium.org wrote: http://build.chromium.org/buildbot/waterfall/ Automatically closing tree for unit_tests on Mac10.5 Tests http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/8528 Revision: 32176 Blame list: miran...@chromium.org Mac10.5 Tests Build 8528http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/8528 update scripts stdiohttp://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/8528/steps/shell/logs/stdio update stdiohttp://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/8528/steps/gclient/logs/stdio extract build stdiohttp://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/8528/steps/extract%20build/logs/stdio ipc_tests stdiohttp://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/8528/steps/ipc_tests/logs/stdio unit_tests did not complete crashed or hung stdiohttp://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/8528/steps/unit_tests/logs/stdio Changed by: *miran...@chromium.org* Changed at: *Tue 17 Nov 2009 09:19:54* Branch: *src* Revision: *32176*http://src.chromium.org/viewvc/chrome?view=revrevision=32176 Changed files: - *chrome/browser/browser.cc* - *chrome/browser/dom_ui/dom_ui_theme_source.cc* - *chrome/browser/dom_ui/new_tab_ui.cc* - *chrome/browser/resources/new_new_tab.css* - *chrome/browser/resources/new_new_tab.js* - *chrome/common/pref_names.cc* - *chrome/common/pref_names.h* Comments: Tweaks and fixes for NTP extension promo. Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG= 27814, 25258, 27815 TEST= see various bugs. Review URL: http://codereview.chromium.org/385135 Properties: -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Linting chrome/ in pre-submit checks
To be clear, it'll be a warning prompt on commit, not an error. You
can say (y)es to continue.
M-A
On Tue, Nov 17, 2009 at 2:16 PM, Elliot Glaysher (Chromium)
e...@chromium.org wrote:
Chromium developers,
I have just submitted a PRESUBMIT.py for chrome/ which will run
cpplint.py on your change as part of the presubmit process. cpplint is
currently run at reduced strictness--cpplint run separately may
generate more errors[1]. Currently, it only runs it at (gcl/git cl)
upload time and only generates warnings. In the future, it should
error at commit time, but I want to put this through a trial period so
please pay attention to the warnings and yell and scream at me if
there are false positives. If I hear nothing, I'll enable errors at
commit time sometime next week.
I've also gone through chrome/ code and fixed most style errors.
Here's a few recurring problems to watch out for:
- There is supposed to be a space between (if|while|for) and the
opening parenthesis. There ISN'T supposed to be a space between a
function name and it's arguments.
- When declaring a class that inherits, the ':' should not just be
hanging on the previous line.
- On that note, please remember that class x : public baseclass and
class x : baseclass may both compile but have different meanings and
that you probably want the first.
- Remember that 'private:', 'public:' and 'protected:' should be
indented one space.
- Don't use tabs.
- Header guards should be of the form CHROME_DIR_DIR_DIR_FILE_H_.
Header files require header guards; don't omit them. (Exception: the
-message.h headers which do multiple include trickery.)
- ';' shouldn't be used in empty loops. Use {} instead.
- If an else has a brace on one side, it should have it on both.
Time permitting, I also hope to have app/ , base/ , and maybe views/
lint clean with presubmit checks in the future. I also hope to make
the linter more strict in the future; this is just a starting point.
-- Elliot
[1] For the curious: currently, the presubmit process runs normal
chrome/ code through --verbose=4 and unit test code through
--verbose=5. In addition, there's a list of tests that we instruct
cpplint.py to not run due either to common false positives or style
violations that are really, really common.
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
Re: [chromium-dev] gclient failed to get the source
I don't know where you put your depot_tools but I'd try to delete depot_tools\python.bat and try again. It seems like downloading the python zip failed. M-A On Sun, Nov 15, 2009 at 11:23 PM, Eduardo Maggio mag...@gmail.com wrote: Well, I'm not sure if it's the right place to post that, but anyway... In order to get the source sync and build the last version of chrome (OS: Windows XP), I tried to follow the steps from the site but it ended with this error message: C:\cd chromiumtrunk C:\chromiumtrunkgclient config http://src.chromium.org/svn/trunk/src Installing subversion ... Installing python ... 'import site' failed; use -v for traceback Traceback (most recent call last): File C:\depot_tools\bootstrap\\..\gclient.py, line 72, in ? import logging File C:\Python26\lib\logging\__init__.py, line 728 finally: ^ SyntaxError: invalid syntax --- Can someone tell me how to fix that? -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] gcl misbehaving
If gcl is misbehaving at home, please run gclient to update your depot_tools; it was broken this morning. M-A -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition
FYI, this compiler are the same as the Team edition IIRC. M-A On Sun, Nov 15, 2009 at 3:08 PM, Dan Kegel d...@kegel.com wrote: I think not. On Sun, Nov 15, 2009 at 12:04 PM, PhistucK phist...@gmail.com wrote: I am using Visual Studio 2005 (Express) and I downloaded the Windows SDK 7 websetup - it mentions there Visual C++ Compilers and in the description, it says Installs the Visual C++ 9.0 Compilers. Do I need it? Besides the fact the it is 200+ MBs, it just seems weird, since 2005 is 8.0. ☆PhistucK On Fri, Nov 13, 2009 at 02:51, Bradley Nelson bradnel...@google.com wrote: Ok that fix is in. You'd need to set GYP_MSVS_VERSION=2008e Let me know how that goes for you. -BradN On Wed, Nov 11, 2009 at 12:50 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Updated http://sites.google.com/a/chromium.org/dev/developers/how-tos/build-instructions-windows to reference your blog entry. I don't want to copy these instructions since it's too lengthy, inefficient and unsupported. I didn't realize one could download WDK 7 without needing a MSDN account. That's cool. M-A On Tue, Nov 10, 2009 at 10:39 PM, Dominic Jodoin dominic.jod...@gmail.com wrote: On Tue, Nov 10, 2009 at 10:25 PM, Peter Kasting pkast...@google.com wrote: What do you mean? Or to be more precise, what would considering your steps a valid setup to contribute concretely result in? PK I'm wondering if using a hacked ATL version 7.1 could lead to bugs given the product is built, I suppose, with ATL coming with Visual Studio 2005 or 2008 which is a different version. But what I meant was that if the steps were to be approved, I thought they could be included on http://dev.chromium.org. -- Dominic. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Getting 'This is a read-only checkout' error from gcl
Fixed, http://src.chromium.org/viewvc/chrome?view=revrevision=31942 On Fri, Nov 13, 2009 at 3:51 PM, Dominic Mazzoni dmazz...@google.com wrote: I got the same error yesterday. Note that I don't have write access, so it's true that I do have a read-only checkout, but before, there was no warning just to create, upload or try. Now I have to use --force in order to do any of those operations. - Dominic On Fri, Nov 13, 2009 at 11:49 AM, Dirk Pranke dpra...@google.com wrote: I started getting this on my mac at home, and haven't taken the time to track it down yet. Is it possible your environment got switched from the svn:// checkout to an https:// read-only checkout? -- Dirk On Fri, Nov 13, 2009 at 10:41 AM, Jens Alfke s...@chromium.org wrote: A few days ago I started getting an error when using gcl to create changelists in my WebKit tree: $ pwd /Volumes/Yttrium/src/third_party/WebKit $ gcl change foo This is a read-only checkout. Retry in a read-write checkout or use -- force to override. I don't get the error if I use gcl in the top-level Chromium directory. I recently upgraded my Mac's svn from the stock 1.4.4 to 1.6.6; but this doesn't explain why gcl would work in one repo but not in another. Any idea? AFAIK I need to use gcl to be able to submit WebKit patches to the try bots... —Jens -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] building without svg
Dean had done one, at least on Windows, I don't recall offhand since it's been a while. On Fri, Nov 13, 2009 at 5:39 PM, Evan Martin e...@chromium.org wrote: We track total binary size here: http://build.chromium.org/buildbot/perf/dashboard/sizes.html I don't know of any place we track per-module sizes. On Fri, Nov 13, 2009 at 2:33 PM, Eric Seidel esei...@chromium.org wrote: Do we have any hard data about where our binary size goes? It seems such data would be very useful. On Fri, Nov 13, 2009 at 2:14 PM, Evan Martin e...@chromium.org wrote: I measured that SVG is nearly a sixth of the binary size of a Chrome debug build. That's not only more compile time, it's also more link time for each incremental link and more time for the debugger to grind it when starting gdb. For my day-to-day debugging I would like to build without SVG (and many other bits, but let's start with SVG). I put on one obvious patch and one patch I'm not sure about at https://bugs.webkit.org/show_bug.cgi?id=31490 Does anyone have thoughts about the right way to disable SVG in the GYP files? Here's the hacky second patch mentioned above: https://bug-31490-attachments.webkit.org/attachment.cgi?id=43196 In particular, I'm not sure of the right way to conditionally build the SVGNames bits. I've seen in some cases files are completely wrapped with #if ENABLE(FOO); do you know when that is appropriate? -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.
Ah, I always close it instinctively. :) /me who is always shocked by people keeping the two useless right-side box on their IDE, the server db and the toolbox. That's totally 16 pixels wasted. M-A On Wed, Nov 11, 2009 at 11:38 PM, Eric Roman ero...@chromium.org wrote: Yuck, I experienced the same gut-wrenchingly slow single stepping problem! The problem was the Autos view. VS 2008 conveniently turns this on by default, but it is crazy slow. Even if it doesn't have focus, it will pause to update it after each step. Go ahead and right click on Autos and select Hide. The evil Autos it is near the Locals tab. It should be as zippy as 2005 now On Thu, Oct 29, 2009 at 7:23 PM, Mike Belshe mbel...@google.com wrote: On Thu, Oct 29, 2009 at 3:34 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Oct 29, 2009 at 3:23 PM, Finnur Thorarinsson fin...@chromium.org wrote: I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step over a line. I couldn't use it anymore and switched back to VS 2005. Isn't the stepping speed affected by things like what you have in your Watch window and what conditional breakpoints you have set, or something? Anyway, you've probably gone through this thought exercise many times... Just thought I'd mention it. This was an apple-to-apple comparison, only a few breakpoints in both, fresh build, both on SSD etc. I don't think it has anything to do with the watch window; it is just unbearable - I'd say about 1-1.5seconds per step. On Thu, Oct 29, 2009 at 14:51, John Abd-El-Malek j...@chromium.org wrote: On Thu, Oct 29, 2009 at 2:38 PM, Mike Belshe mbel...@google.com wrote: I've been using VS2008 on Win7 for the last month or so. I hate it. Problems: 1) Stepping in the debugger is SOOO slow. I am thinking about going back to VS2005. I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step over a line. I couldn't use it anymore and switched back to VS 2005. 2) If you turn on Intellisense, it crashes like crazy very regularly. I've turned off intellisense, but it is a big loss in productivity to do so I strongly recommend against VS2008; do others have these problems? Mike On Thu, Oct 29, 2009 at 2:27 PM, Ben Goodger (Google) b...@chromium.org wrote: FYI. VS2008 builds with /MP by default, and it's well supported, so when present there's no reason for us to not use it by default. Note that you can still force VS2005 by setting GYP_MSVS_VERSION=2005 in your environment. Thanks Brad! -Ben -- Forwarded message -- From: b...@chromium.org Date: Thu, Oct 29, 2009 at 2:26 PM Subject: Re: Switching vs2008 to be preferred when present. To: bradnel...@google.com Cc: gyp-develo...@googlegroups.com LGTM http://codereview.chromium.org/341041 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~--- -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] WebKit Windows try server?
Wouha, let me reply! :) To clarify things, I already made an experimental webkit try server on the same host that the chromium try server master on a different port. The remaining blocking issue is the revert implementation. br...@apple told me he would look at the implementation but he hasn't yet AFAIK. I assure you I'll get it done before errr, the end of the year? We are not resource bound, just engineering bound, e.g. me. M-A On Thu, Nov 12, 2009 at 4:50 PM, Adam Barth aba...@chromium.org wrote: On Thu, Nov 12, 2009 at 1:46 PM, Jeremy Orlow jor...@google.com wrote: Btw, there's a webkit-dev thread out there right now about adding try servers. I don't think anyone's figured out where the hardware will come from though. Currently my plan is to donate machines from my apartment. A lack of hardware is a ridiculous reason to burn engineering resources. Adam -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] WebKit Windows try server?
To be clear, I have ~10 mac minis dying in a closet waiting for jobs. On Thu, Nov 12, 2009 at 4:52 PM, Jeremy Orlow jor...@google.com wrote: On Thu, Nov 12, 2009 at 1:50 PM, Adam Barth aba...@chromium.org wrote: On Thu, Nov 12, 2009 at 1:46 PM, Jeremy Orlow jor...@google.com wrote: Btw, there's a webkit-dev thread out there right now about adding try servers. I don't think anyone's figured out where the hardware will come from though. Currently my plan is to donate machines from my apartment. A lack of hardware is a ridiculous reason to burn engineering resources. I didn't mean to suggest that it's a limiting factor. Hopefully Google would be able to donate some resources, but either way I think it's fine if it's a grass-roots type thing. :-) -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition
Updated http://sites.google.com/a/chromium.org/dev/developers/how-tos/build-instructions-windows to reference your blog entry. I don't want to copy these instructions since it's too lengthy, inefficient and unsupported. I didn't realize one could download WDK 7 without needing a MSDN account. That's cool. M-A On Tue, Nov 10, 2009 at 10:39 PM, Dominic Jodoin dominic.jod...@gmail.com wrote: On Tue, Nov 10, 2009 at 10:25 PM, Peter Kasting pkast...@google.com wrote: What do you mean? Or to be more precise, what would considering your steps a valid setup to contribute concretely result in? PK I'm wondering if using a hacked ATL version 7.1 could lead to bugs given the product is built, I suppose, with ATL coming with Visual Studio 2005 or 2008 which is a different version. But what I meant was that if the steps were to be approved, I thought they could be included on http://dev.chromium.org. -- Dominic. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Re: [gyp-developer] Coping with configurations differences in sources
On Tue, Nov 10, 2009 at 1:52 PM, Gregory Dardyk grego...@google.com wrote: We might build Chrome for 64-bit Windows in the future, but there are several reasons why we would like to avoid porting all Chrome code to 64-bit Windows now: We are now in the process of porting Native Client code that is 64-bit clean on Linux to 64-bit Windows and it requires some effort. We currently plan to use only a minimal subset of functionality in the 64-bit Windows binary, so we would like to keep that binary as small as possible These sentence are dense, can you elaborate? -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Beginning with development
And you can use distcc. On Tue, Nov 10, 2009 at 1:21 PM, Paweł Hajdan jr phajdan...@gmail.com wrote: Note however that you can build specific projects. When working on base or net for example, you can build just base_unittests and net_unittests. When working on webkity things, you can sometimes compile just the test_shell, and not chrome. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.
Here are the fixes for your debugger sluggishness problems: Bind this macro to F7 http://code.google.com/p/chromium/wiki/WindowsVisualStudioMacros?ts=1256870705updated=WindowsVisualStudioMacros#Only_build_startup_project and bind this macro to F5 http://code.google.com/p/chromium/wiki/WindowsVisualStudioMacros?ts=1256870705updated=WindowsVisualStudioMacros#Use_as_your_debugger Now you have a fast debugger! :D And now I can go to sleep. M-A On Thu, Oct 29, 2009 at 6:34 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Oct 29, 2009 at 3:23 PM, Finnur Thorarinsson fin...@chromium.orgwrote: I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step over a line. I couldn't use it anymore and switched back to VS 2005. Isn't the stepping speed affected by things like what you have in your Watch window and what conditional breakpoints you have set, or something? Anyway, you've probably gone through this thought exercise many times... Just thought I'd mention it. This was an apple-to-apple comparison, only a few breakpoints in both, fresh build, both on SSD etc. On Thu, Oct 29, 2009 at 14:51, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Oct 29, 2009 at 2:38 PM, Mike Belshe mbel...@google.com wrote: I've been using VS2008 on Win7 for the last month or so. I hate it. Problems: 1) Stepping in the debugger is SOOO slow. I am thinking about going back to VS2005. I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step over a line. I couldn't use it anymore and switched back to VS 2005. 2) If you turn on Intellisense, it crashes like crazy very regularly. I've turned off intellisense, but it is a big loss in productivity to do so I strongly recommend against VS2008; do others have these problems? Mike On Thu, Oct 29, 2009 at 2:27 PM, Ben Goodger (Google) b...@chromium.org wrote: FYI. VS2008 builds with /MP by default, and it's well supported, so when present there's no reason for us to not use it by default. Note that you can still force VS2005 by setting GYP_MSVS_VERSION=2005 in your environment. Thanks Brad! -Ben -- Forwarded message -- From: b...@chromium.org Date: Thu, Oct 29, 2009 at 2:26 PM Subject: Re: Switching vs2008 to be preferred when present. To: bradnel...@google.com Cc: gyp-develo...@googlegroups.com LGTM http://codereview.chromium.org/341041 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.
After thinking about it, just setting in Debugging properties: Command = c:\program files\Debugging Tools for Windows (x86)\windbg.exe Command Arguments = -o $(TargetPath) is way simpler, then you just use Ctrl-F5 to start debugging your app! M-A On Thu, Oct 29, 2009 at 10:50 PM, Marc-Antoine Ruel mar...@chromium.orgwrote: Here are the fixes for your debugger sluggishness problems: Bind this macro to F7 http://code.google.com/p/chromium/wiki/WindowsVisualStudioMacros?ts=1256870705updated=WindowsVisualStudioMacros#Only_build_startup_project and bind this macro to F5 http://code.google.com/p/chromium/wiki/WindowsVisualStudioMacros?ts=1256870705updated=WindowsVisualStudioMacros#Use_as_your_debugger Now you have a fast debugger! :D And now I can go to sleep. M-A On Thu, Oct 29, 2009 at 6:34 PM, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Oct 29, 2009 at 3:23 PM, Finnur Thorarinsson fin...@chromium.org wrote: I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step over a line. I couldn't use it anymore and switched back to VS 2005. Isn't the stepping speed affected by things like what you have in your Watch window and what conditional breakpoints you have set, or something? Anyway, you've probably gone through this thought exercise many times... Just thought I'd mention it. This was an apple-to-apple comparison, only a few breakpoints in both, fresh build, both on SSD etc. On Thu, Oct 29, 2009 at 14:51, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Oct 29, 2009 at 2:38 PM, Mike Belshe mbel...@google.comwrote: I've been using VS2008 on Win7 for the last month or so. I hate it. Problems: 1) Stepping in the debugger is SOOO slow. I am thinking about going back to VS2005. I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step over a line. I couldn't use it anymore and switched back to VS 2005. 2) If you turn on Intellisense, it crashes like crazy very regularly. I've turned off intellisense, but it is a big loss in productivity to do so I strongly recommend against VS2008; do others have these problems? Mike On Thu, Oct 29, 2009 at 2:27 PM, Ben Goodger (Google) b...@chromium.org wrote: FYI. VS2008 builds with /MP by default, and it's well supported, so when present there's no reason for us to not use it by default. Note that you can still force VS2005 by setting GYP_MSVS_VERSION=2005 in your environment. Thanks Brad! -Ben -- Forwarded message -- From: b...@chromium.org Date: Thu, Oct 29, 2009 at 2:26 PM Subject: Re: Switching vs2008 to be preferred when present. To: bradnel...@google.com Cc: gyp-develo...@googlegroups.com LGTM http://codereview.chromium.org/341041 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is there any plan to support Visual Studio 2010? (Current in Beta 2)
[Subtly setting expectations here] Updated http://crbug.com/25628 accordingly. You have your answer in this feature request and read my comment on it before adding any comment. (as in don't add any please) Feel free to star it though. But as a sane person, well, as sane as I can be, I can only say the IDE is barely usable (sorry Borris, even if you fixed Intellisense) which doesn't help in motivating me to add any kind of support to VS2010 in the short term. Anyway most of the grunt work will be done by either Brad or Steve so it's them you need to convince and they have a lot of other much more needed things to do before. Thanks for your interest, gyp patches to kick start a new msbuild exporter are really welcomed. M-A On Wed, Oct 28, 2009 at 1:05 AM, sam mhsien.t...@gmail.com wrote: I saw this issue, which was accepted, in gyp project. http://code.google.com/p/gyp/issues/detail?id=96q=type%3DEnhancement Good to know this. BR, mht On Wed, Oct 28, 2009 at 12:16 PM, Dan Kegel d...@kegel.com wrote: On Tue, Oct 27, 2009 at 9:00 PM, mht mhsien.t...@gmail.com wrote: Some information about Visual Studio 2010. But question first: Is there any plan (long term / short term) to support it? It would probably be a good idea, eventually. If anyone wants to write an msbuild backend for gyp, have at it! - Dan --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Are we going to use tcmalloc on Mac?
On Wed, Oct 28, 2009 at 1:30 AM, Darin Fisher da...@chromium.org wrote: I'm pretty sure that enabling USE_SYSTEM_MALLOC will also lead to corruption since WebKit is not hermetic (we allocate things externally that we then delete inside WebKit). -Darin Wouha! That really limit our capacity to link wekbit.dll. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Why is Linux Chrome so fast?
An additional note: Most Windows boxes have an AV installed while most linux boxes don't. Never underestimate the sluggishness of AVs. M-A On Wed, Oct 28, 2009 at 11:05 AM, Evan Martin e...@chromium.org wrote: On Tue, Oct 27, 2009 at 9:11 PM, Adam Barth aba...@chromium.org wrote: My three laptops have relatively comparable hardware and run Chrome on Windows, Mac, and Linux respectively. The Linux version of Chrome feels ridiculously faster than Windows and Mac. Do we understand why this is? Can we make Windows and Mac feel that fast too? My first instinct is to say because (1) we're awesome and (2) Linux is awesome, but I'd prefer to have facts back it up. :) There's a perf link on http://build.chromium.org that has builders tracking various metrics. If we get perf tests for the behaviors you care about, we can better compare and improve them. On the other hand, I'm not sure if the hardware lines up between platforms so maybe the comparisons I do below are not valid... General observations: General comments: Linux tends to be lighter which means it does better on older hardware, so depending on what sorts of laptops you're talking about that could be a major factor. Windowses later than 2000 or so need surprising amounts of hardware to run well. (I don't mention Mac below because there hasn't been much performance work there yet.) 1) Scroll performance is extremely good. Even on Gmail, I can only get the mouse to lead the scroll bar by a dozen pixels. On Slashdot, it doesn't even look like I can do that. On plain pages (one scrollbar on the right, no Flash) scrolling is literally shifting the pixels down. On Linux we do this by sending a command to the X server, which is a single process that even has the graphics drivers built in so it talks directly to your graphics card and can in theory do a hardware-accelerated copy. I would expect this to be pretty fast. However, Gmail is a complicated page (the main scrollbar is an iframe) so in that case I guess rendering speed is getting involved. There I'd expect Windows Chrome to be faster because the compiler is better and there have been more people looking at performance (I saw in another thread that tcmalloc, currently only used on Windows, improved the page cycler by 50%?). The page cycler perf graphs are intended to test rendering speed. Do the numbers match your perception? I can't get the right graphs to load right now. It looks like spew from NOTIMPLEMENTED()s may be obscuring the data. 2) Tab creation is very fast. Maybe the zygote is helping here? Can we pre-render the NTP on other platforms? The zygote is paused right at process start, before we've even started a renderer. On the other hand Windows process creation is more expensive. There is a new tab graph that attempts to measure this. The various lines on the graph are tracking how quickly we get to each stage in constructing the page. We hit the first line 20ms faster on Linux than Windows likely due to the zygote and slow Windows process creation, but process startup seems to be a relatively small part of the total time. Linux hits other lines later and Linux and Windows hit the finish line at around the same time. In your case, I wonder if you have more history accumulated on your Windows profile, making the new tab computation more expensive than the equivalent one on the Linux box. I'd expect the faster file system on Linux to eventually be help here. (My experience with git has been you get an order of magnitude slower each step from Linux-Mac-Windows, but that could be git or hardware-specific.) 3) Startup time is faster than calculator. I'm not sure if you're kidding. Do you mean Windows calculator? Maybe there's something wrong with your Windows box -- maybe a virus scanner or disk indexer or some other crap procmon will show is continually thrashing your computer. Or maybe you have a spare Chrome instance on another virtual desktop on your Linux box so clicking the Chrome button is just telling it to show another window. The startup tests are intended to track startup performance, and again the Windows graphs are much better than the Linux ones. However, the difference between the two is milliseconds and my experience as a user is that Chrome rarely starts that fast, so I wonder if these graphs are really measuring what a user perceives (which frequently involves disk). In the limit, I'd expect us to pay a lot more on Linux due to using more libraries, GTK initialization, round trips to the X server, etc. but I don't know much about Windows here. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Reference build has been changed?
FTR, you could have got the same info with: src\chrome\tools\test\reference_build\chromechrome about:version M-A On Wed, Oct 28, 2009 at 12:46 PM, Anton Muhin ant...@chromium.org wrote: Thanks a lot, Tony. yours, anton. On Wed, Oct 28, 2009 at 7:44 PM, Tony Chang t...@chromium.org wrote: From the svn log: r30141 | ch...@chromium.org | 2009-10-26 18:00:16 -0700 (Mon, 26 Oct 2009) | 6 lines Update Windows reference build to r30072. BUG=25200 TEST=ref build runs locally, buildbot tests continue to work Review URL: http://codereview.chromium.org/339015 On Wed, Oct 28, 2009 at 8:14 AM, Anton Muhin ant...@chromium.org wrote: Dear chromerers, Looks like reference build (for buildbots) has been changed recently. Does anybody know exact build which is a reference now? yours, anton. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How can we kill scons?
Have you tried starring http://crbug.com/22044 ? On Wed, Oct 28, 2009 at 3:28 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: If I'm not mistaken, I think like most everyone running on linux is using the make build nowadays, and the make build seems to work well enough for most people. The only time I hear someone mention the scons build, it's in reference to you broke the scons build, or so you developed on make. Did you check it worked on scons? Given that, what's keeping us from killing the scons build completely? My current motivation for asking is that I've been spending the last hour trying to figure out why scons is deciding to insert an -fPIC into my build, whereas make is not. This is on top of my previous motivation (from about 3 days ago) where I spent another few hours making something that worked fine on the make build, scons compatible. I'd rather spend that time killing scons if there was a clear list of what was needed to make that happen. -Albert --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How can we kill scons?
Not that it is effective :) On Wed, Oct 28, 2009 at 3:34 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Have you tried starring http://crbug.com/22044 ? On Wed, Oct 28, 2009 at 3:28 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: If I'm not mistaken, I think like most everyone running on linux is using the make build nowadays, and the make build seems to work well enough for most people. The only time I hear someone mention the scons build, it's in reference to you broke the scons build, or so you developed on make. Did you check it worked on scons? Given that, what's keeping us from killing the scons build completely? My current motivation for asking is that I've been spending the last hour trying to figure out why scons is deciding to insert an -fPIC into my build, whereas make is not. This is on top of my previous motivation (from about 3 days ago) where I spent another few hours making something that worked fine on the make build, scons compatible. I'd rather spend that time killing scons if there was a clear list of what was needed to make that happen. -Albert --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Fun with timers! A horror story
http://crbug.com/22926 You know the funny part? I had hacked that exact thing (in ChromiumCurrentTime.cpp) locally during work on this bug. M-A On Tue, Oct 27, 2009 at 9:53 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: Would a hack like running nm --defined-only on each generated object, and then checking for dups work? You'd have to ignore weak symbols, and probably some others, but sounds doable. -Albert On Tue, Oct 27, 2009 at 6:48 PM, Peter Kasting pkast...@google.com wrote: On Tue, Oct 27, 2009 at 4:40 PM, James Robinson jam...@chromium.org wrote: So what's the problem? WTF::currentTime() is implemented twice, once in JavaScriptCore/wtf/CurrentTime.cpp and once in webkit/api/src/ChromiumCurrentTime.cpp. The latter simply defers to base::Time::Now().ToDoubleT(), the former uses a somewhat different algorithm to try to normalize what the system returns. ThreadTimers.cpp was linking against the JavaScriptCore/wtf/CurrentTime.cpp version and webkitclient_impl.cc was linking against the webkit/api/src/ChromiumCurrentTime.cpp version. Arrrgghh Is there a way we can compile-time detect similar symbol names like this and throw fits (with a whitelist for any we know are OK)? Seems like this is an issue for something with linking that maruel might have looked at long ago. PKJ --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] depot_tools and pymox
Hi I finally checked-in pymox into depot_tools. This mean that if you ever ran the depot_tools unit_tests, you may get this error svn: svn: Failed to add directory 'tests/pymox': a versioned directory of the same name already exists git-svn: error: Untracked working tree file 'tests/pymox/COPYING' would be overwritten by merge. The solution is to rm -rf tests/pymox and sync again. Thanks, M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Please update svn:ignore for gyp changes
I'm doing it, I have a change pending, I was waiting for the tree to reopen... M-A On Fri, Oct 16, 2009 at 3:56 PM, Peter Kasting pkast...@google.com wrote: After a recent sync I now have a large number of .rules/.sln/.vcproj files in chrome_frame/. Someone changed the gyp files in a way that introduced these without adding them to svn:ignore. When you change a gyp file, you should update svn:ignore on the directory in which all your new autogenerated files will live, and add them to the ignore list, so they don't show up as ? foo.vcproj when people do svn/gcl status. It's easy: svn propedit svn:ignore . Then you can commit these. (gcl can do a gcl change containing these, but gcl upload won't upload them, so I'd just commit.) Be careful: if you propedit foo/bar/ and commit, gcl/svn will commit all modified files inside foo/bar/ too. Now, can whoever made the chrome_frame change please fix it? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Please update svn:ignore for gyp changes
... and by the time I synced, it was closed again. :) On Fri, Oct 16, 2009 at 3:58 PM, Marc-Antoine Ruel mar...@chromium.org wrote: I'm doing it, I have a change pending, I was waiting for the tree to reopen... M-A On Fri, Oct 16, 2009 at 3:56 PM, Peter Kasting pkast...@google.com wrote: After a recent sync I now have a large number of .rules/.sln/.vcproj files in chrome_frame/. Someone changed the gyp files in a way that introduced these without adding them to svn:ignore. When you change a gyp file, you should update svn:ignore on the directory in which all your new autogenerated files will live, and add them to the ignore list, so they don't show up as ? foo.vcproj when people do svn/gcl status. It's easy: svn propedit svn:ignore . Then you can commit these. (gcl can do a gcl change containing these, but gcl upload won't upload them, so I'd just commit.) Be careful: if you propedit foo/bar/ and commit, gcl/svn will commit all modified files inside foo/bar/ too. Now, can whoever made the chrome_frame change please fix it? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: weird Visual Studio link error, will clobber fix it?
... more hotfixes for you to install http://dev.chromium.org/developers/how-tos/build-instructions-windows On Fri, Oct 16, 2009 at 3:57 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: I'm consistently getting this error when linking (fails 57 times when compiling the entire chrome.sln): 2shell32.lib(shguid.obj) : fatal error LNK1103: debugging information corrupt; recompile module I'm using Visual Studio 2005, fresh checkout. Should I just try clobber? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Canary bot, now with formatted layout test results
Actually, can you package this so it could be upstreamed to webkit.org?
On Thu, Oct 15, 2009 at 1:09 PM, Glenn Wilson gwil...@chromium.org wrote:
The tool lives in
src/webkit/tools/layout_tests/test_output_formatter{.bat,.sh}, and it can
actually be run against any builder, not just the canaries. Adding better
documentation is on the TODO list :)
(Also, re: adding link to waterfall, I think we can do this -- I'm
investigating now.)
On Thu, Oct 15, 2009 at 10:05 AM, Yaar Schnitman y...@chromium.orgwrote:
Glenn, this tool is amazing! It really helped me yesterday on my 1st
gardening shift.
Re: upstream baselines without running the tool manually
How do I do that?
On Thu, Oct 15, 2009 at 10:01 AM, Jeremy Orlow jor...@chromium.orgwrote:
Christmas came early for anyone working on WebKit! Thanks Glen. :-)
On Thu, Oct 15, 2009 at 9:17 AM, Erik Corry erik.co...@gmail.comwrote:
This makes me very happy!
2009/10/15 Glenn Wilson gwil...@chromium.org:
Hi Webkit gardeners,
The Windows canary bot now generates formatted layout test results on
each
build that had unexpected failing layout tests, which means you can
quickly
see layout test failures, diffs, and upstream baselines without
running the
tool manually. The goal of this output is to help gardeners assess
what may
have changed, and how to best handle the failure.
For example, here are the failures for build 13359:
http://build.chromium.org/buildbot/layout_test_results/webkit-rel-webkit-org/29119/index-13359.html
To see the formatted layout test failures for a specific canary build,
just
click on the layout test results link in the archive webkit test
results
step, then click on the index-.html file.
There's still more work to do, including getting the formatter working
properly on the Mac Linux canaries, adding flakiness data, adding a
link
directly to the waterfall display, and more. Many thanks go to Ojan,
Nicolas and all others who endured my many code reviews, and Eric
Roman and
Dimitri for the original spec and design.
Please let me know what you think, and what changes you'd like to see.
Glenn
--
Erik Corry, Software Engineer
Google Denmark ApS. CVR nr. 28 86 69 84
c/o Philip Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018
Copenhagen K, Denmark.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Building chromium stable
Adding a few potentially interested people. On Fri, Oct 9, 2009 at 6:45 AM, Rozenkraft rozenkr...@gmail.com wrote: As a few of you know, I've been trying to build a stable version of chromium for a month now. The problem is the DEPS file of the 195 branch is outdated so it has wrong dependencies. I could update the dependencies until chromium builds, but I would like to use the exact same version of every dependency than Google, since I chose chromium for my project (an internet kiosk prototype) because it leaks less memory and it's more secure, which are very important things for public computers with long uptimes. So having stable dependencies it's important for us. Anyway, I opened this issue: http://code.google.com/p/chromium/issues/detail?id=23038 and maruel tells me that somebody is working on the alternative solution proposed in one of the comments, so thanks. But given that the you are producing those automated DEPS for the 4.x branches but not for the 3.x stable branch, I'm starting to think that this isn't gonna happen in the current release cycle and I'll have to wait for the 4.x stable release, which again, is understandable cause I'm sure there are pretty solid technical reasons. So I'm wondering, whether in the meantime you could offer some kind of temporal fix for those of us in my same situation. For example, committing to the branch the DEPS used by google as DEPS.internal. That way I can take a look, ignore the google specific stuff and make my own DEPS. I don't think it would take you more than 20 seconds per stable release (if I'm right in my assumptions about the nature of the problem) and it would be very appreciated. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: GYP and cross-compiling
On Thu, Oct 8, 2009 at 12:49 PM, Evan Martin e...@chromium.org wrote: 3- Well, it only works for the make build. The current patch probably breaks the scons one. XCode and MSVS should be mostly unaffected - but won't supposrt this, which I don't think is a big deal. How about 32/64-bit binaries from MSVS? Is that considered cross-compiling? (I know pretty much nothing about the VS toolchain.) I don't think Evan actually cares but FYI... :D MSVS supports the concept of platforms (in its strictest MS-only sense) so you can have a platform(x86/x64/arm/ia64) x target(release/debug) matrix. We just need to make the generator output the necessary .vcproj glue to generate the x64 build platform. That'd be nice but I don't have cycles to work on that. http://code.google.com/p/gyp/issues/detail?id=87 if anyone is interested in that work. M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK
Did you try the right file? On Thu, Oct 8, 2009 at 1:20 PM, yu...@chromium.org yu...@chromium.orgwrote: When trying to install the hotfix on Win7/64 I'm getting following message: The upgrade patch cannot be installed by the Windows Installer service because the program to be upgraded may be missing, or the upgrade patch may update a different version of the program. Verify that the program to be upgraded exists on your computer and that you have the correct upgrade patch. Any ideas how to fix that? Thanks, Yury On Sep 30, 9:39 pm, Stephen White senorbla...@chromium.org wrote: Just in case someone else runs into this: I recently installed MSVC2005 and the Win7 Platform SDK on my win7/64 machine and it gave me this error at link time: shell32.lib(shguid.obj) : fatal error LNK1103: debugging information corrupt; recompile module Installing hotfix 949009 ( https://connect.microsoft.com/VisualStudio/Downloads/DownloadDetails) fixed it. We currently have that hotfix listed in the build instructions as to be confirmed (it's still in beta). Stephen -- All truth passes through three stages. First, it is ridiculed. Second, it is violently opposed. Third, it is accepted as being self-evident. -- Schopenhauer --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Has anyone built successfully on Win7 64bit? I am getting bash.exe errors
For the record, I build on win7 (both x86 and x64) on vs2008 without problem here. M-A On Tue, Oct 6, 2009 at 9:21 PM, vha14 vuh...@gmail.com wrote: Still having the same issue after following John's suggestions. Being forced to use a separate cygwin's bash.exe. On Oct 2, 12:16 am, Abubakar abubak...@gmail.com wrote: cygwin is supposed to be inside the chrome source that u download. Not to be done anything about it separately. On Fri, Oct 2, 2009 at 4:05 AM, Dan Kegel d...@kegel.com wrote: It's not supposed to be that way... maybe we need to check in a new cygwin. On Thu, Oct 1, 2009 at 4:03 PM, vha14 vuh...@gmail.com wrote: So it looks like I need to install Cygwin separately before I can build Chrome? If so this should be added to the Windows build instruction page. On Oct 1, 2:59 pm, Mohamed Mansour m...@chromium.org wrote: I run Cygwin Bash Shell not from Command Prompt: moha...@mohamed-pc ~$ bash -Mohamed On Thu, Oct 1, 2009 at 5:32 PM, vha14 vuh...@gmail.com wrote: Hi Mohamed, can you run bash.exe from cmd? I get the following error: E:\chromium\home\chrome-svn\tarball\chromium\src\third_party\cygwin \binbash 9 [main] bash 8384 _cygtls::handle_exceptions: Exception: STATUS_ACCESS_VIOLATION 9964 [main] bash 8384 open_stackdumpfile: Dumping stack trace to bash.exe.stackdump 211065 [main] bash 8384 _cygtls::handle_exceptions: Exception: STATUS_ACCESS_VIOLATION 229623 [main] bash 8384 _cygtls::handle_exceptions: Error while dumping state (probably corrupted stack) On Oct 1, 2:17 pm, Mohamed Mansour m...@chromium.org wrote: Windows 7 64bit works fine here (using the default settings from dev.chromium.org) Make sure you have access to the folder your writing to. Some folders require admin mode. -Mohamed On Thu, Oct 1, 2009 at 4:10 PM, vha14 vuh...@gmail.com wrote: Detailed error message: 1-- Build started: Project: js2c, Configuration: Debug Win32 -- 1js2c 2-- Build started: Project: cygwin, Configuration: Debug Win32 -- 2setup_mount 1 30 [main] bash 8980 _cygtls::handle_exceptions: Exception: STATUS_ACCESS_VIOLATION 1 3645 [main] bash 8980 open_stackdumpfile: Dumping stack trace to bash.exe.stackdump 2The operation completed successfully. 2The operation completed successfully. 1Project : error PRJ0002 : Error result 35584 returned from 'C: \Windows\SysWow64\cmd.exe'. Content of bash.exe.stackdump: E:\chromium\home\chrome-svn\tarball\chromium\src\chromemore bash.exe.stackdump Exception: STATUS_ACCESS_VIOLATION at eip=0043AE30 eax= ebx= ecx=61106EC8 edx= esi=611021A0 edi=0045A3E0 ebp=0028CBC8 esp=0028C58C program=e:\chromium\home\chrome-svn\tarball \chromium\s rc\third_party\cygwin\bin\bash.exe, pid 8296, thread main cs=0023 ds=002B es=002B fs=0053 gs=002B ss=002B Stack trace: Frame Function Args 0028CBC8 0043AE30 (0003, 02361C00, 02360090, 772F) 0028CD68 610060D8 (, 0028CDA0, 61005450, 0028CDA0) 61005450 61004416 (009C, A02404C7, E8611021, FF48) 431390 [main] bash 8296 _cygtls::handle_exceptions: Exception: STATUS_ACCESS_VI OLATION 509897 [main] bash 8296 _cygtls::handle_exceptions: Error while dumping state ( probably corrupted stack) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: detecting tabs using a lot of CPU?
It's better to be non-animated. Remember,ichrome is using too much CPU already. Second; the user is doing something, he doesn't want to be distracted with information unrelated to his current task. If the user finds himself waiting on his current tab, his eyes will probably see a tab being slightly burnt and will wonder what is happening. :) M-A On Wed, Oct 7, 2009 at 1:13 PM, Darin Fisher da...@chromium.org wrote: http://tinderbox.mozilla.org/1afi003r.gif On Wed, Oct 7, 2009 at 10:10 AM, Glen Murphy g...@chromium.org wrote: Something like yes! Maybe not a dialog, as I use things that peg my CPU (games) somewhat frequently. One idea we toyed with was marking such tabs as 'on fire' (icon or color), so at least there was a visual indication. I think this would be a good starting point before anything more obtrusive like a dialog or bar. On Wed, Oct 7, 2009 at 9:59 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: Just a while before one of my tabs (GMail) started using a lot of CPU time (67% while I was compiling in the background). The browser and the system were responsive at all times, but processing power was wasted. We have a warning dialog for hanged renderers offering to kill them. What do you think about a warning dialog for renderers consistently using a lot of CPU? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Scalability
Yes, Nicolas is working on making webkit.dll. It's painful to do; I know, I tried last year. :) On Mon, Oct 5, 2009 at 11:42 AM, Evan Martin e...@chromium.org wrote: On Fri, Oct 2, 2009 at 8:26 AM, Marc-Antoine Ruel mar...@chromium.org wrote: is linking. To give you an idea, here's a truncated dir list: (...) 10,223,616 dump_cache.exe 10,309,632 fetch_client.exe 10,600,448 net_perftests.exe 12,406,784 sync_unit_tests.exe 14,966,784 net_unittests.exe 22,118,400 mini_installer.exe 55,029,760 tab_switching_test.exe Does anyone (not necessarily you :P) have building a web of .dlls in their plans? I've seen a number of patches from mmoss to get that working on Linux with the intent of using it on buildbots... --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Google Blogoscoped author tries out Chrome app shortcuts
[+chromium-dev] On Mon, Oct 5, 2009 at 12:36 PM, Philipp Lenssen philipp.lens...@gmail.com wrote: Hi Peter and Marc-Antoine! (forwarding my post via email as the Google Groups discussion is moderated) You need to subscribe first to not be moderated, e.g. ignored. I'm glad to see the issues being looked at! The Fixedsys font problem is this: In my CSS, I have the line font-family: fixedsys, consolas, monospace; but Chrome ignores the first font, and jumps to Consolas (Firefox finds Fixedsys fine). It being a system font might be part of the issue, I can also not locate Fixedsys in Chrome's monospace font options dialog. No idea about this one in particular. Since this is on Windows, it may be interesting to take a look at. Can you file a bug at http://new.crbug.com ? He just needs to learn how to create an application shortcut. Copy a chrome shortcut on the desktop, rename it, right click on it, properties, edit the command line to add the arguments wanted. Could you please guide me through the steps, did you try associating files? Just a basic edited shortcut doesn't do the job for me, as Windows (Vista) will set up the file association -- which I need to open files system wide with double click -- with the source exe when picking the shortcut... i.e. with basic Chrome, not Chrome App (dragging the file over the shortcut behaves somewhat better, but I didn't further explore this route as it's not a solution). To clarify, my goal is: - set up Windows (Vista) so that all .foo files (like myfile.foo) will automatically be opened with Chrome App at the location http://example/#path-to-foo-file (e.g. http://example/#C:\somefolder\myfile.foo). My current suboptimal workaround as mentioned is associating my files with a CMD file which reads: C:\Users\...\Chrome\Application\chrome.exe --app=http://example/#%1; Ok I didn't understand what you wanted to do correctly at first. The easiest fix is by editing the registry entry. I made it do a websearch as an example but this is obviously useless as-is. The important part is the type\shell\open\command\@ (default) registry value, by default it uses «-- %1». I just changed this part to use --app and a prebacked url instead. You need to replace %USERPROFILE% by your user profile path. --- CUT HERE --- Windows Registry Editor Version 5.00 [HKEY_CLASSES_ROOT\.foo] @=foo_auto_file [HKEY_CLASSES_ROOT\foo_auto_file] @=Web Search [HKEY_CLASSES_ROOT\foo_auto_file\shell] [HKEY_CLASSES_ROOT\foo_auto_file\shell\open] [HKEY_CLASSES_ROOT\foo_auto_file\shell\open\command] @=\%USERPROFILE%\\AppData\\Local\\Google\\Chrome\\Application\\chrome.exe\ --app \http://www.google.com/search?q=%1\; I don't think Google Chrome should be blamed by someone hooking up weird file association like this. :) M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: build time speed improvement with solid state drive?
Marshall, don't waste money on SSD (especially not MLC SSD). Get 2 standard HD, put the checkout on the secondary drive, get a dual-cpu quad-core ht with 8+ gigs of RAM (or up to the limit you can afford but get at least 8 gigs of RAM and at least one quad core). Core i7 or xeon nehalem *highly* recommended. M-A On Mon, Oct 5, 2009 at 2:21 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Oct 5, 2009 at 11:14 AM, Amanda Walker ama...@chromium.orgwrote: On Mon, Oct 5, 2009 at 2:08 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: I'm putting together a new computer and I'd like to optimize my chromium build times :-) Is anyone currently building chromium using a solid state drive? Have you noticed any compile or link time speed improvements relative to using a second traditional SATA drive? Other people can chime in about windows ssd performance, but I have an SSD in a Mac laptop that I sometimes do builds on. Total build time is only marginally better than a traditional SATA drive (a few percent), but the machine is noticeably less sluggish doing other things during a build (when there's any disk contention happening, the faster seek time and i/o operations per second are a definite win). But for overall build time, I've found that RAM and CPU cores make much more of a difference than the drive. From what I've heard, SVN and searching within a project are faster with a SSD. As for the system getting sluggish during compile: this can also be solved by having a 2nd hard drive that contains all the source + build files. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Google Blogoscoped author tries out Chrome app shortcuts
On Sun, Oct 4, 2009 at 7:13 PM, Peter Kasting pkast...@google.com wrote: With larger textarea content, Chrome’s up and downwards scrolling can show minimal lags. Firefox handles this smoothly. Didn't try to test this one, filed crbug.com/23788 . We can trick things with ScrollWindowEx when we scroll the whole window; see http://google.com/codesearch/p?hl=frsa=Ncd=2ct=rc#h0RrPvyPu-c/chrome/browser/renderer_host/render_widget_host_view_win.ccq=package:src.chromium.org%20scrollwindowex Maybe we could use this more in iframe/textbox/etc scrolling cases and not just full page scroll. Sort of crucial: Chrome won’t accept my system font definition, Fixedsys, while Firefox has no problems with it and loads it fine. Apparently Chrome doesn’t like system fonts, but the TrueType replacements I found for Fixedsys don’t look like the real thing. Anyone knows a solution? I don't understand the problem description well enough to take action here. I'm pretty sure block bitmap fonts. IIRC, this is also an issue with some asian fonts. Maybe I'm wrong since I couldn't find a bug about it. (Maybe only related to printing after all) Not so nice: The batch file to launch Chrome, itself a workaround because I didn’t know how to connect files directly with a Chrome app (and have their source path parameter be passed), briefly shows when you open it. I’m already using things like echo off, the Start command, CLS and EXIT, and a “cmd” instead of a “bat” extension to get it to close quietly (half of these superstition and the other half works?), but the window will still be briefly visible when you double click a file to edit in Netpadd B. Does anyone know how to prevent the batch window from showing, or how to launch a Chrome app directly (and pass the path)? This isn't really a Chrome bug. Seems like there must be a better solution here someone can share with Philipp. He just needs to learn how to create an application shortcut. Copy a chrome shortcut on the desktop, rename it, right click on it, properties, edit the command line to add the arguments wanted. M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Scalability
, Marc-Antoine On Thu, Oct 1, 2009 at 9:37 PM, Marc-Antoine Ruel mar...@chromium.org wrote: [bcc: chromium-dev] As I said in my previous email (which was blocked by the ML) you should have just replied to the email and saved 1600+ people time. That what is written on the try job status email for a reason. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Try server follow up
The windows slaves are really having a hard time to compile, if it fails, just try again :( The command is or s/gcl/git/: gcl try foo --bot win In the short term, I'm disabling debug info on windows so they are at least somewhat useful. I'll probably restart the master in the middle of the day to fix this though. M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Try server follow up
The windows try slaves are now back up with the symbols disabled. A side-effect is that process dump will always be red, since the symbols cannot be found. I'll remove this step soon. M-A On Fri, Oct 2, 2009 at 1:10 PM, Marc-Antoine Ruel mar...@chromium.org wrote: The windows slaves are really having a hard time to compile, if it fails, just try again :( The command is or s/gcl/git/: gcl try foo --bot win In the short term, I'm disabling debug info on windows so they are at least somewhat useful. I'll probably restart the master in the middle of the day to fix this though. M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc
[uninformed question] From a quick search, when you're talking about decommit, you seem to always use MEM_DECOMMIT instead of MEM_RELEASE; I see no MEM_RELEASE in tcmalloc. You do leak the reserved pages or are they first reused? What I am referring to is to a potential virtual address space leak. Is VirtualAlloc bright enough to reuse the reserved pages first? M-A On Thu, Oct 1, 2009 at 9:18 AM, Anton Muhin ant...@chromium.org wrote: And we pay when allocating---blocks need to be committed first. yours, anton. On Thu, Oct 1, 2009 at 5:14 PM, Vitaly Repeshko vita...@chromium.org wrote: On Thu, Oct 1, 2009 at 4:44 PM, Anton Muhin ant...@chromium.org wrote: Guys, just to summarize the discussion. There are several ways we can tweak tcmalloc: 1) decommit everything what is free; 2) keep spans with a mixed state (some pages committed, some not, coalescing nor commit, not decommits)---that should solve main Jim's argument; 3) commit on coalescing, but aggressively purge (like WebKit do, once in 5 secs unless something else has been committed, or in idle pauses. To my knowledge performance-wise 1) is slower (how slower we should learn), 2) is slightly faster than 3) (but it might be just a statistical error). Of course, my benchmark is quite special. Memory-wise I think 2) and 3) with aggressive scavenging should be mostly the same---we could keep higher number of committed pages than in 1), but for short periods of time and I'm not convinced it's a bad thing. Overall I'm pro 2) and 3), but I am definitely biased. What do you think? [...] I'd like to explain in what way decomitting everything (option #1 above) is slow. This hurts us most during garbage collection in V8. When a DOM wrapper is collected the C++ DOM object that it wraps gets deleted and we decommit memory (usually only to commit some of it later). So we add extra low-level memory management cost to garbage collections, which ideally should be as fast as possible to avoid hurting interactivity of the browser. This is one of the reasons to avoid aggressive decomitting. So I think having something like #2 with periodic onidle decommits like #3 should be good both for performance in bechmarks and real apps and for memory usage. -- Vitaly --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: url request failing on unix with os_error = -7
[bcc: chromium-dev] As I said in my previous email (which was blocked by the ML) you should have just replied to the email and saved 1600+ people time. That what is written on the try job status email for a reason. I'll send a follow up email with more information. M-A On Thu, Oct 1, 2009 at 9:10 PM, Jenn Braithwaite (胡慧鋒) je...@google.com wrote: The log output shows ssl_test_util.cc messages indicating the testserver was started successfully. Also, the net_unittests pass, and they use HTTPTestServer. Those run after test_shell_tests. On Thu, Oct 1, 2009 at 5:44 PM, Tim Steele t...@chromium.org wrote: I think those are defined in net_error_list.h and that means timed out? I would have said maybe it was a zombie python process from the test server was lingering around and causing it to fail on subsequent runs, I've seen that happen before. But you have several machines failing with this now... Still possible, I guess. On Thu, Oct 1, 2009 at 4:58 PM, Jenn Braithwaite (胡慧鋒) je...@google.com wrote: Hi, The failure is in a unittest and only fails like this on linux. The windows trybot is happy. The test uses HTTPTestServer (which talks to testserver.py). Can someone tell me what os_error of -7 means on linux? Thanks, Jenn --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK
I have done that last week. You can see the list grew even more. On Wed, Sep 30, 2009 at 1:44 PM, Stephen White senorbla...@chromium.org wrote: I see it's now listed as required for MSVC2005 (thanks to whoever updated the build instructions). On Wed, Sep 30, 2009 at 1:39 PM, Stephen White senorbla...@chromium.org wrote: Just in case someone else runs into this: I recently installed MSVC2005 and the Win7 Platform SDK on my win7/64 machine and it gave me this error at link time: shell32.lib(shguid.obj) : fatal error LNK1103: debugging information corrupt; recompile module Installing hotfix 949009 (https://connect.microsoft.com/VisualStudio/Downloads/DownloadDetails.aspx?DownloadID=18623) fixed it. We currently have that hotfix listed in the build instructions as to be confirmed (it's still in beta). Stephen -- All truth passes through three stages. First, it is ridiculed. Second, it is violently opposed. Third, it is accepted as being self-evident. -- Schopenhauer -- All truth passes through three stages. First, it is ridiculed. Second, it is violently opposed. Third, it is accepted as being self-evident. -- Schopenhauer --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Try-ing WebKit patches (was WebKit Chromium Port Update Sep 29th)
+Dimitri, who is doing that and didn't put Jeremy in the loop. On Tue, Sep 29, 2009 at 4:06 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Sep 29, 2009 at 12:52 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Sep 29, 2009 at 12:05 PM, Eric Seidel esei...@chromium.org wrote: On Tue, Sep 29, 2009 at 11:53 AM, Yaar Schnitman y...@chromium.org wrote: 1. An internal webkit chromium port try bot: Will help test webkit-only patches. At first stage, it will test build failures (saving many of us the need to manually test on 3 platforms), but later will also conduct chromium port layout tests and api unit tests. By internal do you mean that only Googlers can access it? Is there a command I could wire into bugzilla-toll post-diff which would post to this try-bot as well? Could you detail such a command? I believe that only people with @chromium.org accounts can currently use try bots. I'm not aware of any discussion about whether or how we should give access to @webkit.org people. Btw, I think it's fairly clear we should give access to WebKit developers; I just haven't seen/heard any discussions about it. And there might be security concerns that make it impossible to simply allow every WebKit contributor to use them without some additional sign up process. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Green tree task force: How to try upstream Windows layout tests?
If I understand correctly, you're asking for a webkit try server? And in particular a apple windows builder/tester. M-A On Tue, Sep 29, 2009 at 6:18 PM, Peter Kasting pkast...@google.com wrote: I figure this question is most suited for the Green Tree folks. Ojan told me today that he had a patch to fix one of my pet peeve bugs in WebKit, but he hadn't committed it because it would affect the results of the Windows layout tests and he didn't have an easy way to test and rebaseline them. I asked why our trybots didn't work and he reminded me that they run test_shell, which is fine for our downstream tests but doesn't match how the upstream WebKit community runs Windows layout tests (i.e. by using DRT). Ojan said he'd be far more productive if there was an easy way to try a patch and see how it would affect the Windows tests upstream. Anyone have any suggestions, or willing to set something like this up? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Green tree task force: How to try upstream Windows layout tests?
I don't think it'd be very hard, I didn't know this was a wanted feature. M-A On Tue, Sep 29, 2009 at 6:47 PM, Peter Kasting pkast...@google.com wrote: On Tue, Sep 29, 2009 at 3:35 PM, Marc-Antoine Ruel mar...@chromium.org wrote: If I understand correctly, you're asking for a webkit try server? And in particular a apple windows builder/tester. I think so, something that builds the Apple Windows port and runs its layout tests. Or else comments about how to accomplish the same goal with what we have today. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Kiosk Mode for Chrome
I think I'm right to say that a lot of the knobs stated by Mohamed can be achieved with content script. Everything that can be done with javascript for this particular use case should be done as javascript. For example, destroying the window.print prototype. I think you try to block to many things. For example, quitting the browser is probably a no-op, the script managing the browser life-time it should just restart it. It would be required anyway in case of a browser crash. Tabs aren't a big deal either. Can you can hook into tabs with extensions but I don't know if you can block their creation though. If this could be done with almost only pure javascript (in addition to --fullscreen or --app), that would be awesome, especially unit test wise. M-A On Tue, Sep 29, 2009 at 7:45 PM, Jacob Mandelson ja...@mandelson.org wrote: On Tue, Sep 29, 2009 at 04:37:46PM -0700, Jeremy Orlow wrote: On Tue, Sep 29, 2009 at 4:20 PM, Brett Wilson bre...@chromium.org wrote: On Tue, Sep 29, 2009 at 4:15 PM, Jeremy Orlow jor...@chromium.org wrote: I'm guessing different people/companies will have different needs for a kiosk mode. Maybe all of these should be separate flags rather than one kiosk flag? We could then offer recommendations in a Chromium for kiosks Wiki page? I think the reasoning for allowing this feature is that some minority would find it helpful and it wouldn't hurt much. I'm concerned that it is getting much too complicated. I think we shouldn't do it if it is going to be this complicated. Would multiple command line flags rather than one really complicate the design? Mohamed's original patch was just a bunch of if statements keying off of one flag. Seems like the same amount of work to have each if statement key off of a different one. Or am I missing something? If nothing else, it grows the configuration space. Supporting a kiosk mode seems like a good idea. Supporting 2^N different flavors of kiosk mode sounds dicier. -- Jacob --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Skipping reference_build ?
As usual, please file a feature request unless you plan on doing it, otherwise I'll forget. On Fri, Sep 25, 2009 at 3:59 PM, Jeremy Orlow jor...@chromium.org wrote: Sounds like we need a presubmit check. On Fri, Sep 25, 2009 at 6:38 AM, Marc-Antoine Ruel mar...@chromium.org wrote: It's too late for git but not for svn and tarballs. Please move them to DEPS. M-A On Thu, Sep 24, 2009 at 6:26 PM, Evan Martin e...@chromium.org wrote: We have already scolded Alex about this, but it's too late now. Repeat PSA: plz to not be dumping large Windows binaries into the tree. We have DEPS for a reason. On Thu, Sep 24, 2009 at 3:20 PM, Michael michael.monr...@gmail.com wrote: The src/chrome_frame/tools/test/reference_build directory takes ages to svn up, is there a way to skip it? I don't think I really need all those .dll and .exe files on Linux anyway... --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: FYI, project cruft
GYP debugger? On Mon, Sep 28, 2009 at 2:00 PM, Nick Carter n...@chromium.org wrote: I've noticed that the use of the 'direct_dependent_settings' in gyp to propagate #defines and include paths makes it trickier to decipher the actual build-order dependencies. I've had cases where I needed to add a gyp dependency just to get an #include path for a header file that was transitively included by a bona-fide dependent. The pollution obscures the actual dependency structure. A transitive version of 'direct_dependent_settings' that works on indirect dependencies might improve the situation. Another possibility is a lightweight 'mix-in' target type that has no .vcproj associated with it, but that can still impart the side effect of 'direct_dependent_settings' on its dependents. - nick On Sun, Sep 27, 2009 at 6:13 PM, Peter Kasting pkast...@google.com wrote: Thanks Mark-Antoine. It has been a very long time since I fixed the dependencies years ago to not be so crazy. Not surprising that it is once again goofed up. It would be nice to have some of this stuff auto-calculated by GYP if that is feasible... PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Error in using gclient
On Mon, Sep 28, 2009 at 2:09 PM, Dan Kegel d...@kegel.com wrote: On Sat, Sep 26, 2009 at 6:23 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Something disable a trick we use to download a zip file containing svn and uncompressing it. You can do it manually since it's one time process. See for the details: http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/bootstrap/win/win_tools.bat?view=markup Maybe we should add back our checked-in wget as a fallback? No. It's the first report since I switched to this method so there's probably something weird on his machine. The original posted didn't follow the steps I told him. He didn't put a svn.bat file inside his depot_tools directory. M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Error in using gclient
On Mon, Sep 28, 2009 at 2:20 PM, manuj sabharwal manujsabar...@gmail.com wrote: Is it possible company firewall causing the HTTP problem? I did add svn file in depot_tools folder. It created svn_new file too. and svn.bat. But when I try to check out it gives same error. Firewall? You probably mean a proxy. Yes it can cause problems. Here's how you could troubleshoot your issue: D:\src\depot_toolsdir s* Le volume dans le lecteur D n'a pas de nom. Le numéro de série du volume est 1234-5678 Répertoire de D:\src\depot_tools 2009-09-22 16:3167 svn 2009-09-22 16:3178 svn.bat 2009-09-22 16:32REP svn_bin 2 fichier(s) 145 octets On Mon, Sep 28, 2009 at 11:13 AM, Marc-Antoine Ruel mar...@chromium.org wrote: On Mon, Sep 28, 2009 at 2:09 PM, Dan Kegel d...@kegel.com wrote: On Sat, Sep 26, 2009 at 6:23 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Something disable a trick we use to download a zip file containing svn and uncompressing it. You can do it manually since it's one time process. See for the details: http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/bootstrap/win/win_tools.bat?view=markup Maybe we should add back our checked-in wget as a fallback? No. It's the first report since I switched to this method so there's probably something weird on his machine. The original posted didn't follow the steps I told him. He didn't put a svn.bat file inside his depot_tools directory. M-A -- Best Regards, Manuj Sabharwal --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] gclient sync
If you can, please don't sync for the next 15 minutes. Thanks. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: gclient sync
Now fixed as http://chrome-svn/viewvc/chrome?view=revrevision=27386 . Will take a few minutes before it propagates to the proxies. On Mon, Sep 28, 2009 at 2:45 PM, Marc-Antoine Ruel mar...@chromium.org wrote: If you can, please don't sync for the next 15 minutes. Thanks. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: gclient sync
Err, meant http://src.chromium.org/viewvc/chrome?view=revrevision=27386 On Mon, Sep 28, 2009 at 2:57 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Now fixed as http://chrome-svn/viewvc/chrome?view=revrevision=27386 . Will take a few minutes before it propagates to the proxies. On Mon, Sep 28, 2009 at 2:45 PM, Marc-Antoine Ruel mar...@chromium.org wrote: If you can, please don't sync for the next 15 minutes. Thanks. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Error in using gclient
Hi Something disable a trick we use to download a zip file containing svn and uncompressing it. You can do it manually since it's one time process. See for the details: http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/bootstrap/win/win_tools.bat?view=markup If you follow the script, it downloads http://src.chromium.org/svn/trunk/tools/third_party/svn_bin.zip and uncompress it to depot_tools\svn_bin. Then it copies svn.new.bat to depot_tools\svn.bat depot_tools\svn.bat is used as a signal that the previous steps completed successfully. So since you already installed svn, create a svn.bat file in depot_tools that calls your installed svn version. M-A On Sat, Sep 26, 2009 at 7:05 PM, manuj sabharwal manujsabar...@gmail.com wrote: Its still not working. Same HTTP request error. Can there be problem with firewall settings ? I am using Mcafee at my antivirus software. Thanks. Manuj On Sat, Sep 26, 2009 at 3:57 PM, Mohamed Mansour m...@chromium.org wrote: Hello, try running this command (from an Administrator command prompt): netsh interface tcp set global autotuninglevel=disabled See if that works for you, then run gclient sync --force again. -Mohamed On Sat, Sep 26, 2009 at 3:58 PM, Manni manujsabar...@gmail.com wrote: Hi, I am trying to download the chrome source code. I have installed VS 2008 and Microsoft SDK. Later I downloaded the tarball and depot_tools. I updated the path with depot_tools too. But when i run command on vista -Sp2 it gives this error. C:\chromiumtrunk\home\chrome-svn\tarball\chromium\src\chromegclient runhooks -- force Installing subversion ... [-] XMLHTTP 80072ee2: Cannot make HTTP request (The operation timed out ... Failed to checkout svn automatically. Please visit http://subversion.tigris.org to download the latest subversion clie nt before continuing. You can also get the prebacked version used at http://src.chromium.org/svn/tru nk/tools/third_party/ I then downloaded tigris subversion and prebacked version too. But stil have to same problem. Can anyone help in getting started with the development? -- Best Regards, Manuj Sabharwal Joan Crawford - I, Joan Crawford, I believe in the dollar. Everything I earn, I spend. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] FYI, project cruft
Project dependencies went out of control lately. As an example; mini_installer was depending of gtest. :) I started by splitting most constants out of chrome/common into common_constants and fixed 2 projects accordingly. My next target is most of the ui tests series and fetch_* that are linking way too much stuff. I want to warn you that it will probably require splitting some parts of browser, common and renderer into smaller projects but should help reducing the number of 10 megs exe. Then the project-directory relationship will need to be fixed afterward but I already know I won't fix that part. As usual, I'll probably break the build in the process. Thanks and sorry for the inconvenience, M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Build time doubled since May - what gives?
http://code.google.com/p/chromium/issues/detail?id=21266 This is a real problem, I just haven't looked into this one in particular. Sometimes I just feel like renaming the dll... M-A On Thu, Sep 24, 2009 at 10:29 PM, Mohamed Mansour m...@chromium.org wrote: Hey Ben, same here ... I see this additional message today (havn't seen it before) 59LINK : C:\Sandbox\Code\Chrome\src\chrome\Debug\chrome.dll not found or not built by the last incremental link; performing full link Changing one file used to take me 5 minutes to build. But now it takes me ~10-15 minutes. -Mohamed On Thu, Sep 24, 2009 at 10:06 PM, Ben Goodger (Google) b...@chromium.org wrote: I just ran a build here at home on my i7 workstation. It took 14 minutes. This is the same system that would build in 7 minutes when I set it up in May. What gives? We need to figure this out ASAP. -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Build time doubled since May - what gives?
Oh and a lot of warnings appeared recently. It is surprising how much warnings slow down the build, probably due to stdout serialization. http://code.google.com/p/chromium/issues/detail?id=23039 M-A On Fri, Sep 25, 2009 at 9:18 AM, Marc-Antoine Ruel mar...@chromium.org wrote: http://code.google.com/p/chromium/issues/detail?id=21266 This is a real problem, I just haven't looked into this one in particular. Sometimes I just feel like renaming the dll... M-A On Thu, Sep 24, 2009 at 10:29 PM, Mohamed Mansour m...@chromium.org wrote: Hey Ben, same here ... I see this additional message today (havn't seen it before) 59LINK : C:\Sandbox\Code\Chrome\src\chrome\Debug\chrome.dll not found or not built by the last incremental link; performing full link Changing one file used to take me 5 minutes to build. But now it takes me ~10-15 minutes. -Mohamed On Thu, Sep 24, 2009 at 10:06 PM, Ben Goodger (Google) b...@chromium.org wrote: I just ran a build here at home on my i7 workstation. It took 14 minutes. This is the same system that would build in 7 minutes when I set it up in May. What gives? We need to figure this out ASAP. -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Skipping reference_build ?
It's too late for git but not for svn and tarballs. Please move them to DEPS. M-A On Thu, Sep 24, 2009 at 6:26 PM, Evan Martin e...@chromium.org wrote: We have already scolded Alex about this, but it's too late now. Repeat PSA: plz to not be dumping large Windows binaries into the tree. We have DEPS for a reason. On Thu, Sep 24, 2009 at 3:20 PM, Michael michael.monr...@gmail.com wrote: The src/chrome_frame/tools/test/reference_build directory takes ages to svn up, is there a way to skip it? I don't think I really need all those .dll and .exe files on Linux anyway... --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Kiosk Mode for Chrome
Well, Mohamed's patch is *way* simpler and portable. On Fri, Sep 25, 2009 at 12:40 PM, Amit Joshi a...@chromium.org wrote: Sorry for not being clear. What I meant was that you could create your own kiosk shell and embed Chrome Frame as ActiveX control to render the pages you want in it. That way you could customize different features up to your own satisfaction. On Fri, Sep 25, 2009 at 5:30 AM, Mohamed Mansour m...@chromium.org wrote: I tried ChromeFrame it is very good, but it doesn't work if the Kiosk Mode flag is set. If the Kiosk mode is set ( iexplorer.exe -k http://www.google.com ) it renders it as IE Renderer. It renders it fine in a Chrome Frame if its not in Kiosk mode. That must be a bug :) For IE, kiosk mode has a context menu, but people usually apply the registry tweak to remove context menu from IE if they need to. For Chromium, it would be nice if stuff like this would be an extension, an extension should allow us to show/hide various parts of the UI. In the meantime, I quickly compiled a custom Chromium so that my CEO and VP could see the benefits of using Chrome instead of IE on some of our web products. Stuff that would be cool and would be very lightweight to include for kiosk mode would be: - No Status Bar - Full Screen (with no exit, only alt+f4 should work) - No Context Menus (should be an option) - Disable downloading of files. - No tabs - No opening files - many more I would rather that be an extension (but there are currently no way to actually block users to remove extensions, maybe blocking users entering a url would suffice) but not possible currently. -Mohamed On Fri, Sep 25, 2009 at 1:52 AM, Amit Joshi a...@chromium.org wrote: On Thu, Sep 24, 2009 at 10:47 PM, Darin Fisher da...@chromium.org wrote: Chrome Frame is a good option, but you'd still need a way to turn off some features. For example, a kiosk probably doesn't want to have a context menu. Chrome Frame can/will offer control over the context menu. This is exactly the kind of customization Chrome Frame can offer. Too bad we don't have Linux, Mac versions yet, but we are open source now so patches welcome :) -Darin On Thu, Sep 24, 2009 at 10:24 PM, Amit Joshi a...@chromium.org wrote: I think you should really consider embedding chrome frame ActiveX in your own simple shell. That will not only enable the application to be started with desired real estate and get rid of status bubble but allow you to customize it further if needed. On Thu, Sep 24, 2009 at 10:07 PM, Darin Fisher da...@chromium.org wrote: On Thu, Sep 24, 2009 at 11:37 AM, Mohamed Mansour m...@chromium.org wrote: At work today, I talked to the CEO of my company to ship Chrome browser with all our Kiosk's and recommended Chrome to be our default browser for our web products. I bench marked our current web applications with Chrome (ToT) vs IE 7, and our applications run at average 10 times faster. (For windows, Mac speed differed) There are some stuff that he didn't like: Status Bubble: for a cashiering application, it keeps popping up every second since buttons are all over the place. It was distracting him from the main product. Full screen mode always = Kiosk Mode. He wants the web app to stay full screen, in IE, there is kiosk mode command line switch. In FF there is a plugin. JavaScript errors kept appearing intermittently (on the Mac), would work on initial deploy but require a Clear browsing data on subsequent runs. Works great on windows (chrome). I guess we would be using linux/windows for kiosk anyhow. Will there be plans for us to introduce Kiosk Mode in Chrome? It seems the current audience is just targeted towards home users and there is no way to use Google Chrome for other usages. Sure we could compile our own Chromium version, but many people (Chrome forums and elsewhere) would like to use Chrome commercially. In the meantime, I am going to compile a version with no status bar, but I believe it would be nice to include it in future versions. Maybe we could allow extensions to control (hide/show) different areas in chrome. Maybe I'm in the minority, but it doesn't sound that unreasonable to support command line options for disabling the status bubble and starting in full screen mode. We could lump these together into a --kiosk-mode command line flag. This seems like something that could be done in a fairly lightweight manner. Maybe others object? -Darin --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Build time doubled since May - what gives?
A lot of the projects link half-of-the-world when not necessary. I'm working on that right now. M-A On Fri, Sep 25, 2009 at 2:12 PM, Ben Goodger (Google) b...@chromium.org wrote: I would be surprised if it were just the addition of code. Bear in mind the May 7 minute figure includes all of WebKit, and I don't think that's doubled in size since then? So it seems like it must be something more related to the build system itself. I don't think it's incremental linking, since my build was a clean build. -Ben On Fri, Sep 25, 2009 at 11:09 AM, Nick Carter n...@chromium.org wrote: I'll volunteer to fix any build issues created as a result of sync. Building the protobuf compiler (protoc.exe) emits a bunch of warnings -- the bulk are signed/unsigned warnings. I'll put together a change to suppress those. - nick On Fri, Sep 25, 2009 at 6:34 AM, Marc-Antoine Ruel mar...@chromium.org wrote: Oh and a lot of warnings appeared recently. It is surprising how much warnings slow down the build, probably due to stdout serialization. http://code.google.com/p/chromium/issues/detail?id=23039 M-A On Fri, Sep 25, 2009 at 9:18 AM, Marc-Antoine Ruel mar...@chromium.org wrote: http://code.google.com/p/chromium/issues/detail?id=21266 This is a real problem, I just haven't looked into this one in particular. Sometimes I just feel like renaming the dll... M-A On Thu, Sep 24, 2009 at 10:29 PM, Mohamed Mansour m...@chromium.org wrote: Hey Ben, same here ... I see this additional message today (havn't seen it before) 59LINK : C:\Sandbox\Code\Chrome\src\chrome\Debug\chrome.dll not found or not built by the last incremental link; performing full link Changing one file used to take me 5 minutes to build. But now it takes me ~10-15 minutes. -Mohamed On Thu, Sep 24, 2009 at 10:06 PM, Ben Goodger (Google) b...@chromium.org wrote: I just ran a build here at home on my i7 workstation. It took 14 minutes. This is the same system that would build in 7 minutes when I set it up in May. What gives? We need to figure this out ASAP. -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] gclient hang
Your next gclient sync will probably hang. The easiest way to fix it is to: rm -rf src/third_party/WebKit/WebKit/chromium or rd /q /s src\third_party\WebKit\WebKit\chromium before syncing. Sorry for the trouble, M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: gclient hang
Yep, I specified one directory too deep. On Fri, Sep 25, 2009 at 2:50 PM, Mike Pinkerton pinker...@chromium.org wrote: To get mine to work, I had to rm -rf src/third_party/WebKit/WebKit just doing chromium wasn't enough to stop the hangs. On Fri, Sep 25, 2009 at 2:36 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Your next gclient sync will probably hang. The easiest way to fix it is to: rm -rf src/third_party/WebKit/WebKit/chromium or rd /q /s src\third_party\WebKit\WebKit\chromium before syncing. Sorry for the trouble, M-A -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: new values for failures in test_expectations.txt
On Fri, Sep 25, 2009 at 9:12 PM, Dirk Pranke dpra...@chromium.org wrote: Hi all, If you don't run layout_tests or ever need to modify test_expecations.txt, you can ignore this ... As a reminder, every build sheriff needs to be able to modify this. M-A As discussed earlier this week, we've added the ability to indicate whether or not a test is expected to produce incorrect text output (either a bad render tree or bad simplified text output), incorrect images, or both. The keywords in test expectations are 'TEXT', 'IMAGE', and 'IMAGE+TEXT', respectively. Specifying a test expectation as 'FAIL' will continue to indicate any one of the above three choices might be happening. However, we intended to migrate all FAILs to one of the three choices. Once that is complete, we'll flip 'FAIL' to mean 'IMAGE+TEXT', and remove the 'IMAGE+TEXT' option. I expect this'll probably happen in the next week or two. Thanks, and let me know if you see any problems! -- Dirk --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: flaky resource failures
On Thu, Sep 24, 2009 at 3:03 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: We still have problems with resources, examples: [FATAL:tab_renderer.cc(132)] Check failed: waiting_animation_frames-width() % waiting_animation_frames-height() == 0. [FATAL:image_operations.cc(373)] Check failed: rgb.width() == alpha.width(). [FATAL:resource_bundle_win.cc(155)] Check failed: false. unable to find resource: 1495 [FATAL:resource_bundle_win.cc(152)] Check failed: false. unable to find resource: 1500 And of course these are intermittent. :( Can we rebuild the resources always, on Windows? I know it's going to increase the compile time. How much? It would be horrible. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.
That wasn't meant to be snarky at all! Contributions are always appreciated. One thing that is helpful is filing feature request (and assigning them to me) so I can better prioritize the feature request and not forget about them. M-A On Thu, Sep 24, 2009 at 5:25 PM, Drew Wilson atwil...@chromium.org wrote: Why the snark? Is it inappropriate to point out pain points in a proposed process without attaching a patch to my email? As someone who happily spent an hour+ yesterday tracking down an obscure bug in trychange.py, I don't think I'm someone who just sits on the sidelines making work for other people. -atw On Thu, Sep 24, 2009 at 2:20 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Thanks for proposing yourself in improving gcl.py and trychange.py. On Thu, Sep 24, 2009 at 5:18 PM, Drew Wilson atwil...@chromium.org wrote: Before we start enforcing penalties for people who screw this up, we need to do some tools work to make this less error prone/manual-hackery, I think. -atw On Thu, Sep 24, 2009 at 1:56 PM, Steve Vandebogart vand...@chromium.org wrote: On Thu, Sep 24, 2009 at 1:49 PM, Yaar Schnitman y...@chromium.org wrote: Yes. With git: git try -b bot --webkit webkit branch chromium branch With gcl: Manually create a patch by concatenating two (chromium + webkit) patches. Make sure that the webkit patches have the right prefixes by using --src-prefix=src/third_party/WebKit --dst-prefix=src/third_party/WebKit on your diff command. On Thu, Sep 24, 2009 at 1:43 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Sep 22, 2009 at 6:35 PM, Adam Barth aba...@chromium.org wrote: On Tue, Sep 22, 2009 at 6:25 PM, John Abd-El-Malek j...@chromium.org wrote: Is this even possible? i.e. I had uploaded a WebKit patch on codereview but none of the patchsets got run on the try server http://codereview.chromium.org/178030/show It is possible: aba...@zenque:~/svn/kr/src/third_party/WebKit$ gcl try scriptcontext --use_svn --svn_repo=svn://svn.chromium.org/chrome-try/try --bot layout_win,layout_mac,layout_linux --root src/third_party What about 2 sided patches. Is it possible to test those? For gcl, you can also gcl try change -f wekitfile1,webkitfile2,etc. You can also synthesize a change with webkit files by creating a file in .svn/gcl_info/changes and then gcl try chrome_change,webkit_change. -- Steve --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.
On Tue, Sep 22, 2009 at 9:35 PM, Adam Barth aba...@chromium.org wrote: On Tue, Sep 22, 2009 at 6:25 PM, John Abd-El-Malek j...@chromium.org wrote: Is this even possible? i.e. I had uploaded a WebKit patch on codereview but none of the patchsets got run on the try server http://codereview.chromium.org/178030/show It is possible: aba...@zenque:~/svn/kr/src/third_party/WebKit$ gcl try scriptcontext --use_svn --svn_repo=svn://svn.chromium.org/chrome-try/try --bot layout_win,layout_mac,layout_linux --root src/third_party I know the format is not very user friendly but it is definitely possible. You probably can skip --use_svn and --svn_repo or at least use the --http stuff instead, see go/chrometryserver. You could want to use both the layout tests and the normal tests so you can send the patch to all the slaves at the same time, e.g. --bot win,linux,mac,layout_win,layout_mac,layout_linux If the layout tests try slaves get overused, I'll add more slaves. M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Try server moved
The try server moved. There should be no side-effects except that the logs are lost (yet again). If you want to access the old try job logs, the old try server is still running for a few days, so use the continuous buildbot's address with the try server's port. If you don't have access to corp network, ping me. M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Xcode dependency analysis
VS has the same kinds of problem when a project is reusing files generated inside it. The fix is usually splitting the project in two so that generated files by a rule/action aren't reused inside the same project. On Tue, Sep 22, 2009 at 8:30 AM, Thomas Van Lenten thoma...@chromium.org wrote: I've confirmed this with Xcode 3.2; but my suspicion is it also happens with Xcode 3.1.x, just less frequently. In our build process, we run scripts in a few places to generate headers. Those steps are usually done via Actions on targets. We have listed all of the outputs generated so the tool chains can properly track the dependencies and figure out what needs to be rebuilt. It appears that Xcode has some bugs in this space. So it's possible to make changes to the input for one of these scripts (say a GRD files), and on your next build, the script will run to generate the new header, but Xcode appears to be checking the header before the script has run, so it doesn't always rebuild all the sources that include the headers. Most of the time, on the next build, the compiles will happen and your build will be back in a good state. So far my attempts to create a small test case have failed (the exact same setup, just will all the other sources removed, suddenly works). So if you are working on GRDs or localized XIB; and see odds issues with strings, you might have gotten bitten by this, a rebuild should fix it. Failing that, go for a clean build before spending too much time debugging just to make sure you aren't fighting the tool chain. TVL ps-this doesn't seem to be an issue with us missing dependencies for build order, this happens within a single target. I can get it to happen on a 4 core box, so it is not something that only shows with more parallelization. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Important; gclient failure
If you synchronized sources between [26423, 26461[, be sure to sync to 26461 or manually run gclient runhooks. The hooks weren't called anymore, causing stale project files to be used, causing all kind of weird build failures. Sorry for the trouble, M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Linux views trybot
I created a builder for that. It is not in the default pool since I connected only one slave to it. On Wed, Sep 16, 2009 at 1:24 AM, Peter Kasting pkast...@google.com wrote: We need one. I have broken the Linux views build three times in the past three days. This is wasting my time and the sheriffs' both. Is someone working on making this happen? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Need help on how to send data from RenderView to a custom DOMUI instantly
Step 4 is wrong, you don't replace in-place, you do a navigation, like view-source. Random idea; the page's could be duplicated in a hidden iframe with javascript disabled, greatly simplifying the code to generated the print preview pages jpg and making the DOM duplication a 100% javascript issue. I don't know if that can be safely done merely with javascript, that would be awesome. Only caveat, print preview would be disabled when javascript is disabled. We need to find a way to not make the printed pages preview jump to the browser, that would be (slightly) insane. M-A On Sep 15, 2009 10:32 PM, Mohamed Mansour m0.interact...@gmail.com wrote: Hi all, I am having trouble trying to figure out how I could replace the contents of a specific WebFrame while I am in RenderView with a custom DOMUI page that I have created. Here is a scenario: 1. User visits http://www.google.com 2. User waits till page is done loading 3. User selects Options Print Preview 4. The current page will be replaced with a custom PrintPreview DOMUI page (print:http://www.google.com) where I would be passing some Data such as a vector of bytes (image) from RenderView to PrintPreviewDOMUI I have created the DOMUI page and made sure it works, and created the bitmap and encoded it with JPEGEncoder, but I am clueless on how the connection would be from RenderView to DOMUI. Any assistance is appreciated. The reason why I want to replace the current contents is because print preview depends on what is exactly visible at that time. Unless there is a better way. Thanks in advance! - Mohamed Mansour --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
