Re: [DISCUSS] Towards Calcite 1.36.0
+1,thanks,benchao. I am willing to participate in the review of the remaining PRs of 1.36.0. Best, LakeShen Benchao Li 于2023年10月8日周日 11:02写道： > It's been a bit more than 2 months since our last release [1] and > there are currently 90+ new commits in main branch. > > As usual, according to our Jira dashboard [2] and Github [3], there > are many pending issues that could / should be part of the release. > I'd propose to make a collective effort to try to clean up our 1.36 > backlog and merge the PRs which are in a good state. I'd propose to > aim for **end of October** to release 1.36.0, this will give us about > 20 days to clean up pending PRs for next version. What do you think? > > According to [4], the following release managers would be: > - 1.36.0 Benchao Li > - 1.37.0 Sergey Nuyanzin > - 1.38.0 Julian Hyde > > So I'm supposed to be the release manager for 1.36.0 > > And contributors, if you have any work that is in good shape and want > to be included in 1.36.0, please mark the fixVersion to 1.36.0, this > will inform the release manager, and we'll try our best to get it in. > > CALCITE-5990[5] is marked as a blocker since it's introduced by > CALCITE-5843[6], could @Mihai help to double check whether it is a > expected change, and we need to fix it within 1.36.0? > > [1] https://calcite.apache.org/docs/history.html#v1-35-0 > [2] > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > [3] https://github.com/apache/calcite/pulls > [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > [5] https://issues.apache.org/jira/browse/CALCITE-5990 > [6] https://issues.apache.org/jira/browse/CALCITE-5843 > > -- > > Best, > Benchao Li >
RE: [DISCUSS] Towards Calcite 1.36.0
I will take care of https://issues.apache.org/jira/browse/CALCITE-5990 However, it is the first time I notice this issue, I wonder whether I missed some notification. Mihai -Original Message- From: Benchao Li Sent: Sunday, October 8, 2023 12:01 AM To: dev@calcite.apache.org Cc: mbu...@gmail.com Subject: [DISCUSS] Towards Calcite 1.36.0 It's been a bit more than 2 months since our last release [1] and there are currently 90+ new commits in main branch. As usual, according to our Jira dashboard [2] and Github [3], there are many pending issues that could / should be part of the release. I'd propose to make a collective effort to try to clean up our 1.36 backlog and merge the PRs which are in a good state. I'd propose to aim for **end of October** to release 1.36.0, this will give us about 20 days to clean up pending PRs for next version. What do you think? According to [4], the following release managers would be: - 1.36.0 Benchao Li - 1.37.0 Sergey Nuyanzin - 1.38.0 Julian Hyde So I'm supposed to be the release manager for 1.36.0 And contributors, if you have any work that is in good shape and want to be included in 1.36.0, please mark the fixVersion to 1.36.0, this will inform the release manager, and we'll try our best to get it in. CALCITE-5990[5] is marked as a blocker since it's introduced by CALCITE-5843[6], could @Mihai help to double check whether it is a expected change, and we need to fix it within 1.36.0? [1] https://calcite.apache.org/docs/history.html#v1-35-0 [2] https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 [3] https://github.com/apache/calcite/pulls [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk [5] https://issues.apache.org/jira/browse/CALCITE-5990 [6] https://issues.apache.org/jira/browse/CALCITE-5843 -- Best, Benchao Li
Re: [DISCUSS] Towards Calcite 1.36.0
Thanks Benchao for opening this discussion! Maybe we can add https://issues.apache.org/jira/browse/CALCITE-5918 in 1.36.0 ? Currently it needs additional +1 review from the committer. And I am willing to participate in the review of the remaining PRs of 1.36.0 (in familiar modules or sections) either. Best Regards, Ran Tao Benchao Li 于2023年10月8日周日 11:02写道： > It's been a bit more than 2 months since our last release [1] and > there are currently 90+ new commits in main branch. > > As usual, according to our Jira dashboard [2] and Github [3], there > are many pending issues that could / should be part of the release. > I'd propose to make a collective effort to try to clean up our 1.36 > backlog and merge the PRs which are in a good state. I'd propose to > aim for **end of October** to release 1.36.0, this will give us about > 20 days to clean up pending PRs for next version. What do you think? > > According to [4], the following release managers would be: > - 1.36.0 Benchao Li > - 1.37.0 Sergey Nuyanzin > - 1.38.0 Julian Hyde > > So I'm supposed to be the release manager for 1.36.0 > > And contributors, if you have any work that is in good shape and want > to be included in 1.36.0, please mark the fixVersion to 1.36.0, this > will inform the release manager, and we'll try our best to get it in. > > CALCITE-5990[5] is marked as a blocker since it's introduced by > CALCITE-5843[6], could @Mihai help to double check whether it is a > expected change, and we need to fix it within 1.36.0? > > [1] https://calcite.apache.org/docs/history.html#v1-35-0 > [2] > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > [3] https://github.com/apache/calcite/pulls > [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > [5] https://issues.apache.org/jira/browse/CALCITE-5990 > [6] https://issues.apache.org/jira/browse/CALCITE-5843 > > -- > > Best, > Benchao Li >
Re: [DISCUSS] Towards Calcite 1.36.0
Thanks for volunteering, Benchao. Could you log a jira case for 1.36? Then people can cases to it. (As RM, you can remove unlink any cases you think will not be ready in time.) > On Oct 11, 2023, at 3:29 AM, Ran Tao wrote: > > Thanks Benchao for opening this discussion! > > Maybe we can add https://issues.apache.org/jira/browse/CALCITE-5918 in > 1.36.0 ? > Currently it needs additional +1 review from the committer. > > And I am willing to participate in the review of the remaining PRs of > 1.36.0 (in familiar modules or sections) either. > > Best Regards, > Ran Tao > > > Benchao Li 于2023年10月8日周日 11:02写道： > >> It's been a bit more than 2 months since our last release [1] and >> there are currently 90+ new commits in main branch. >> >> As usual, according to our Jira dashboard [2] and Github [3], there >> are many pending issues that could / should be part of the release. >> I'd propose to make a collective effort to try to clean up our 1.36 >> backlog and merge the PRs which are in a good state. I'd propose to >> aim for **end of October** to release 1.36.0, this will give us about >> 20 days to clean up pending PRs for next version. What do you think? >> >> According to [4], the following release managers would be: >> - 1.36.0 Benchao Li >> - 1.37.0 Sergey Nuyanzin >> - 1.38.0 Julian Hyde >> >> So I'm supposed to be the release manager for 1.36.0 >> >> And contributors, if you have any work that is in good shape and want >> to be included in 1.36.0, please mark the fixVersion to 1.36.0, this >> will inform the release manager, and we'll try our best to get it in. >> >> CALCITE-5990[5] is marked as a blocker since it's introduced by >> CALCITE-5843[6], could @Mihai help to double check whether it is a >> expected change, and we need to fix it within 1.36.0? >> >> [1] https://calcite.apache.org/docs/history.html#v1-35-0 >> [2] >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 >> [3] https://github.com/apache/calcite/pulls >> [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk >> [5] https://issues.apache.org/jira/browse/CALCITE-5990 >> [6] https://issues.apache.org/jira/browse/CALCITE-5843 >> >> -- >> >> Best, >> Benchao Li >>
Re: [DISCUSS] Towards Calcite 1.36.0
I've created the https://issues.apache.org/jira/browse/CALCITE-6047 to track the releasing staff. Julian Hyde 于2023年10月12日周四 04:32写道： > > Thanks for volunteering, Benchao. Could you log a jira case for 1.36? Then > people can cases to it. (As RM, you can remove unlink any cases you think > will not be ready in time.) > > > > On Oct 11, 2023, at 3:29 AM, Ran Tao wrote: > > > > Thanks Benchao for opening this discussion! > > > > Maybe we can add https://issues.apache.org/jira/browse/CALCITE-5918 in > > 1.36.0 ? > > Currently it needs additional +1 review from the committer. > > > > And I am willing to participate in the review of the remaining PRs of > > 1.36.0 (in familiar modules or sections) either. > > > > Best Regards, > > Ran Tao > > > > > > Benchao Li 于2023年10月8日周日 11:02写道： > > > >> It's been a bit more than 2 months since our last release [1] and > >> there are currently 90+ new commits in main branch. > >> > >> As usual, according to our Jira dashboard [2] and Github [3], there > >> are many pending issues that could / should be part of the release. > >> I'd propose to make a collective effort to try to clean up our 1.36 > >> backlog and merge the PRs which are in a good state. I'd propose to > >> aim for **end of October** to release 1.36.0, this will give us about > >> 20 days to clean up pending PRs for next version. What do you think? > >> > >> According to [4], the following release managers would be: > >> - 1.36.0 Benchao Li > >> - 1.37.0 Sergey Nuyanzin > >> - 1.38.0 Julian Hyde > >> > >> So I'm supposed to be the release manager for 1.36.0 > >> > >> And contributors, if you have any work that is in good shape and want > >> to be included in 1.36.0, please mark the fixVersion to 1.36.0, this > >> will inform the release manager, and we'll try our best to get it in. > >> > >> CALCITE-5990[5] is marked as a blocker since it's introduced by > >> CALCITE-5843[6], could @Mihai help to double check whether it is a > >> expected change, and we need to fix it within 1.36.0? > >> > >> [1] https://calcite.apache.org/docs/history.html#v1-35-0 > >> [2] > >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > >> [3] https://github.com/apache/calcite/pulls > >> [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > >> [5] https://issues.apache.org/jira/browse/CALCITE-5990 > >> [6] https://issues.apache.org/jira/browse/CALCITE-5843 > >> > >> -- > >> > >> Best, > >> Benchao Li > >> > -- Best, Benchao Li
Re: [DISCUSS] Towards Calcite 1.36.0
I have a fix for the regression 5990, but I have also filed an improved fix for 5921 [1] which is needed to implement the fix for 5990. Both are relatively small so we should be able to get them in for 1.36. Thank you for your patience. Mihai [1] https://github.com/apache/calcite/pull/3471 From: Benchao Li Sent: Saturday, October 7, 2023 8:01 PM To: dev@calcite.apache.org Cc: mbu...@gmail.com Subject: [DISCUSS] Towards Calcite 1.36.0 It's been a bit more than 2 months since our last release [1] and there are currently 90+ new commits in main branch. As usual, according to our Jira dashboard [2] and Github [3], there are many pending issues that could / should be part of the release. I'd propose to make a collective effort to try to clean up our 1.36 backlog and merge the PRs which are in a good state. I'd propose to aim for **end of October** to release 1.36.0, this will give us about 20 days to clean up pending PRs for next version. What do you think? According to [4], the following release managers would be: - 1.36.0 Benchao Li - 1.37.0 Sergey Nuyanzin - 1.38.0 Julian Hyde So I'm supposed to be the release manager for 1.36.0 And contributors, if you have any work that is in good shape and want to be included in 1.36.0, please mark the fixVersion to 1.36.0, this will inform the release manager, and we'll try our best to get it in. CALCITE-5990[5] is marked as a blocker since it's introduced by CALCITE-5843[6], could @Mihai help to double check whether it is a expected change, and we need to fix it within 1.36.0? [1] https://calcite.apache.org/docs/history.html#v1-35-0 [2] https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 [3] https://github.com/apache/calcite/pulls [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk [5] https://issues.apache.org/jira/browse/CALCITE-5990 [6] https://issues.apache.org/jira/browse/CALCITE-5843 -- Best, Benchao Li
Re: [DISCUSS] Towards Calcite 1.36.0
According to the JIRA information to be fixed or supported in 1.36.0, I compiled the PR information that currently requires the committer review or secondary review, so that these PRs could be merged.If the committer has time,could help review these PRs. The PRs are: 1. https://github.com/apache/calcite/pull/3462 2. https://github.com/apache/calcite/pull/3459 3. https://github.com/apache/calcite/pull/3463 4. https://github.com/apache/calcite/pull/3436 5. https://github.com/apache/calcite/pull/3458 6. https://github.com/apache/calcite/pull/3390 7. https://github.com/apache/calcite/pull/3326 8. https://github.com/apache/calcite/pull/3213 9. https://github.com/apache/calcite/pull/3433 10. https://github.com/apache/calcite/pull/3467 11. https://github.com/apache/calcite/pull/3442 12. https://github.com/apache/calcite/pull/3470 13. https://github.com/apache/calcite/pull/3439 14. https://github.com/apache/calcite/pull/3177 Best, LakeShen Mihai Budiu 于2023年10月15日周日 12:32写道： > I have a fix for the regression 5990, but I have also filed an improved > fix for 5921 [1] which is needed to implement the fix for 5990. Both are > relatively small so we should be able to get them in for 1.36. > > Thank you for your patience. > Mihai > > [1] https://github.com/apache/calcite/pull/3471 > > From: Benchao Li > Sent: Saturday, October 7, 2023 8:01 PM > To: dev@calcite.apache.org > Cc: mbu...@gmail.com > Subject: [DISCUSS] Towards Calcite 1.36.0 > > It's been a bit more than 2 months since our last release [1] and > there are currently 90+ new commits in main branch. > > As usual, according to our Jira dashboard [2] and Github [3], there > are many pending issues that could / should be part of the release. > I'd propose to make a collective effort to try to clean up our 1.36 > backlog and merge the PRs which are in a good state. I'd propose to > aim for **end of October** to release 1.36.0, this will give us about > 20 days to clean up pending PRs for next version. What do you think? > > According to [4], the following release managers would be: > - 1.36.0 Benchao Li > - 1.37.0 Sergey Nuyanzin > - 1.38.0 Julian Hyde > > So I'm supposed to be the release manager for 1.36.0 > > And contributors, if you have any work that is in good shape and want > to be included in 1.36.0, please mark the fixVersion to 1.36.0, this > will inform the release manager, and we'll try our best to get it in. > > CALCITE-5990[5] is marked as a blocker since it's introduced by > CALCITE-5843[6], could @Mihai help to double check whether it is a > expected change, and we need to fix it within 1.36.0? > > [1] https://calcite.apache.org/docs/history.html#v1-35-0 > [2] > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > [3] https://github.com/apache/calcite/pulls > [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > [5] https://issues.apache.org/jira/browse/CALCITE-5990 > [6] https://issues.apache.org/jira/browse/CALCITE-5843 > > -- > > Best, > Benchao Li >
Re: [DISCUSS] Towards Calcite 1.36.0
Thanks Benchao for opening the discussion! I'd like to include CALCITE-5923/CALCITE-5825/CALCITE-5826 in 1.36, and they're all in good shape. The first one improves test converage for `SqlOperatorTest`, and can avoid later regressions, so it's valuable. The last two Jiras add two useful Spark/Hive functions, and have already reviewd for one round, and need additional +1 review from the committer. And I am willing to participate in the review of the remaining PRs of 1.36.0. Best Regards, Runkang He LakeShen 于2023年10月15日周日 17:33写道： > According to the JIRA information to be fixed or supported in 1.36.0, I > compiled the PR information that currently requires the committer review or > secondary review, so that these PRs could be merged.If the committer has > time,could help review these PRs. > > The PRs are: > 1. https://github.com/apache/calcite/pull/3462 > 2. https://github.com/apache/calcite/pull/3459 > 3. https://github.com/apache/calcite/pull/3463 > 4. https://github.com/apache/calcite/pull/3436 > 5. https://github.com/apache/calcite/pull/3458 > 6. https://github.com/apache/calcite/pull/3390 > 7. https://github.com/apache/calcite/pull/3326 > 8. https://github.com/apache/calcite/pull/3213 > 9. https://github.com/apache/calcite/pull/3433 > 10. https://github.com/apache/calcite/pull/3467 > 11. https://github.com/apache/calcite/pull/3442 > 12. https://github.com/apache/calcite/pull/3470 > 13. https://github.com/apache/calcite/pull/3439 > 14. https://github.com/apache/calcite/pull/3177 > > > Best, > LakeShen > > Mihai Budiu 于2023年10月15日周日 12:32写道： > > > I have a fix for the regression 5990, but I have also filed an improved > > fix for 5921 [1] which is needed to implement the fix for 5990. Both are > > relatively small so we should be able to get them in for 1.36. > > > > Thank you for your patience. > > Mihai > > > > [1] https://github.com/apache/calcite/pull/3471 > > > > From: Benchao Li > > Sent: Saturday, October 7, 2023 8:01 PM > > To: dev@calcite.apache.org > > Cc: mbu...@gmail.com > > Subject: [DISCUSS] Towards Calcite 1.36.0 > > > > It's been a bit more than 2 months since our last release [1] and > > there are currently 90+ new commits in main branch. > > > > As usual, according to our Jira dashboard [2] and Github [3], there > > are many pending issues that could / should be part of the release. > > I'd propose to make a collective effort to try to clean up our 1.36 > > backlog and merge the PRs which are in a good state. I'd propose to > > aim for **end of October** to release 1.36.0, this will give us about > > 20 days to clean up pending PRs for next version. What do you think? > > > > According to [4], the following release managers would be: > > - 1.36.0 Benchao Li > > - 1.37.0 Sergey Nuyanzin > > - 1.38.0 Julian Hyde > > > > So I'm supposed to be the release manager for 1.36.0 > > > > And contributors, if you have any work that is in good shape and want > > to be included in 1.36.0, please mark the fixVersion to 1.36.0, this > > will inform the release manager, and we'll try our best to get it in. > > > > CALCITE-5990[5] is marked as a blocker since it's introduced by > > CALCITE-5843[6], could @Mihai help to double check whether it is a > > expected change, and we need to fix it within 1.36.0? > > > > [1] https://calcite.apache.org/docs/history.html#v1-35-0 > > [2] > > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > [3] https://github.com/apache/calcite/pulls > > [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > > [5] https://issues.apache.org/jira/browse/CALCITE-5990 > > [6] https://issues.apache.org/jira/browse/CALCITE-5843 > > > > -- > > > > Best, > > Benchao Li > > >
Re: [DISCUSS] Towards Calcite 1.36.0
Hi, community. Recently I reported an issue[1] which revealed that calcite's MAP SubQuery doesn't work, considering this is a feature regression or bug, maybe we can fix it in 1.36. The PR is ready. If someone has time, pls help to review it. many thanks. [1] https://issues.apache.org/jira/browse/CALCITE-6041 Best Regards, Ran Tao Benchao Li 于2023年10月8日周日 11:02写道： > It's been a bit more than 2 months since our last release [1] and > there are currently 90+ new commits in main branch. > > As usual, according to our Jira dashboard [2] and Github [3], there > are many pending issues that could / should be part of the release. > I'd propose to make a collective effort to try to clean up our 1.36 > backlog and merge the PRs which are in a good state. I'd propose to > aim for **end of October** to release 1.36.0, this will give us about > 20 days to clean up pending PRs for next version. What do you think? > > According to [4], the following release managers would be: > - 1.36.0 Benchao Li > - 1.37.0 Sergey Nuyanzin > - 1.38.0 Julian Hyde > > So I'm supposed to be the release manager for 1.36.0 > > And contributors, if you have any work that is in good shape and want > to be included in 1.36.0, please mark the fixVersion to 1.36.0, this > will inform the release manager, and we'll try our best to get it in. > > CALCITE-5990[5] is marked as a blocker since it's introduced by > CALCITE-5843[6], could @Mihai help to double check whether it is a > expected change, and we need to fix it within 1.36.0? > > [1] https://calcite.apache.org/docs/history.html#v1-35-0 > [2] > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > [3] https://github.com/apache/calcite/pulls > [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > [5] https://issues.apache.org/jira/browse/CALCITE-5990 > [6] https://issues.apache.org/jira/browse/CALCITE-5843 > > -- > > Best, > Benchao Li >
Re: [DISCUSS] Towards Calcite 1.36.0
A quick update on the current status for issues targeted 1.36.0 We need more reviewers for #2 and #3 since the end of October is approaching. Please correct me if I'm mistaken, especially for issues in #1. #1. Issues already have reviewers, and seems promising to be merged shortly https://issues.apache.org/jira/browse/CALCITE-5884 https://issues.apache.org/jira/browse/CALCITE-5918 https://issues.apache.org/jira/browse/CALCITE-5860 https://issues.apache.org/jira/browse/CALCITE-6011 https://issues.apache.org/jira/browse/CALCITE-5949 https://issues.apache.org/jira/browse/CALCITE-6041 https://issues.apache.org/jira/browse/CALCITE-6038 #2. Issues has been reviewed, and needs another reviewer https://issues.apache.org/jira/browse/CALCITE-5984 https://issues.apache.org/jira/browse/CALCITE-5825 https://issues.apache.org/jira/browse/CALCITE-5826 https://issues.apache.org/jira/browse/CALCITE-6037 https://issues.apache.org/jira/browse/CALCITE-4455 https://issues.apache.org/jira/browse/CALCITE-6042 #3. PR is ready, no reviewer yet https://issues.apache.org/jira/browse/CALCITE-6052 https://issues.apache.org/jira/browse/CALCITE-129 #4. blocker issues status https://issues.apache.org/jira/browse/CALCITE-5990 is marked blocked by https://issues.apache.org/jira/browse/CALCITE-5921 now. Both issues have a PR, but proposed to have a more thorough solution. I'll keep an eye on them closely. Ran Tao 于2023年10月18日周三 18:37写道： > > Hi, community. > > Recently I reported an issue[1] which revealed that calcite's MAP SubQuery > doesn't work, > considering this is a feature regression or bug, maybe we can fix it in > 1.36. > The PR is ready. If someone has time, pls help to review it. many thanks. > > [1] https://issues.apache.org/jira/browse/CALCITE-6041 > > Best Regards, > Ran Tao > > > Benchao Li 于2023年10月8日周日 11:02写道： > > > It's been a bit more than 2 months since our last release [1] and > > there are currently 90+ new commits in main branch. > > > > As usual, according to our Jira dashboard [2] and Github [3], there > > are many pending issues that could / should be part of the release. > > I'd propose to make a collective effort to try to clean up our 1.36 > > backlog and merge the PRs which are in a good state. I'd propose to > > aim for **end of October** to release 1.36.0, this will give us about > > 20 days to clean up pending PRs for next version. What do you think? > > > > According to [4], the following release managers would be: > > - 1.36.0 Benchao Li > > - 1.37.0 Sergey Nuyanzin > > - 1.38.0 Julian Hyde > > > > So I'm supposed to be the release manager for 1.36.0 > > > > And contributors, if you have any work that is in good shape and want > > to be included in 1.36.0, please mark the fixVersion to 1.36.0, this > > will inform the release manager, and we'll try our best to get it in. > > > > CALCITE-5990[5] is marked as a blocker since it's introduced by > > CALCITE-5843[6], could @Mihai help to double check whether it is a > > expected change, and we need to fix it within 1.36.0? > > > > [1] https://calcite.apache.org/docs/history.html#v1-35-0 > > [2] > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > [3] https://github.com/apache/calcite/pulls > > [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > > [5] https://issues.apache.org/jira/browse/CALCITE-5990 > > [6] https://issues.apache.org/jira/browse/CALCITE-5843 > > > > -- > > > > Best, > > Benchao Li > > -- Best, Benchao Li
Re: [DISCUSS] Towards Calcite 1.36.0
For the blocker issues, I have filed two PRs which should collectively fix them. https://github.com/apache/calcite/pull/3481 fixes https://issues.apache.org/jira/browse/CALCITE-5990, but does not include tests, because the test fixture needs to be fixed as well for the tests to pass. There are tests in the next PR: https://github.com/apache/calcite/pull/3471 fixes https://issues.apache.org/jira/browse/CALCITE-5921, but should be amended to reenable the disabled tests if we merge 3481 first. Mihai From: Benchao Li Sent: Tuesday, October 24, 2023 5:46 AM To: dev@calcite.apache.org Subject: Re: [DISCUSS] Towards Calcite 1.36.0 A quick update on the current status for issues targeted 1.36.0 We need more reviewers for #2 and #3 since the end of October is approaching. Please correct me if I'm mistaken, especially for issues in #1. #1. Issues already have reviewers, and seems promising to be merged shortly https://issues.apache.org/jira/browse/CALCITE-5884 https://issues.apache.org/jira/browse/CALCITE-5918 https://issues.apache.org/jira/browse/CALCITE-5860 https://issues.apache.org/jira/browse/CALCITE-6011 https://issues.apache.org/jira/browse/CALCITE-5949 https://issues.apache.org/jira/browse/CALCITE-6041 https://issues.apache.org/jira/browse/CALCITE-6038 #2. Issues has been reviewed, and needs another reviewer https://issues.apache.org/jira/browse/CALCITE-5984 https://issues.apache.org/jira/browse/CALCITE-5825 https://issues.apache.org/jira/browse/CALCITE-5826 https://issues.apache.org/jira/browse/CALCITE-6037 https://issues.apache.org/jira/browse/CALCITE-4455 https://issues.apache.org/jira/browse/CALCITE-6042 #3. PR is ready, no reviewer yet https://issues.apache.org/jira/browse/CALCITE-6052 https://issues.apache.org/jira/browse/CALCITE-129 #4. blocker issues status https://issues.apache.org/jira/browse/CALCITE-5990 is marked blocked by https://issues.apache.org/jira/browse/CALCITE-5921 now. Both issues have a PR, but proposed to have a more thorough solution. I'll keep an eye on them closely. Ran Tao 于2023年10月18日周三 18:37写道： > > Hi, community. > > Recently I reported an issue[1] which revealed that calcite's MAP SubQuery > doesn't work, > considering this is a feature regression or bug, maybe we can fix it in > 1.36. > The PR is ready. If someone has time, pls help to review it. many thanks. > > [1] https://issues.apache.org/jira/browse/CALCITE-6041 > > Best Regards, > Ran Tao > > > Benchao Li 于2023年10月8日周日 11:02写道： > > > It's been a bit more than 2 months since our last release [1] and > > there are currently 90+ new commits in main branch. > > > > As usual, according to our Jira dashboard [2] and Github [3], there > > are many pending issues that could / should be part of the release. > > I'd propose to make a collective effort to try to clean up our 1.36 > > backlog and merge the PRs which are in a good state. I'd propose to > > aim for **end of October** to release 1.36.0, this will give us about > > 20 days to clean up pending PRs for next version. What do you think? > > > > According to [4], the following release managers would be: > > - 1.36.0 Benchao Li > > - 1.37.0 Sergey Nuyanzin > > - 1.38.0 Julian Hyde > > > > So I'm supposed to be the release manager for 1.36.0 > > > > And contributors, if you have any work that is in good shape and want > > to be included in 1.36.0, please mark the fixVersion to 1.36.0, this > > will inform the release manager, and we'll try our best to get it in. > > > > CALCITE-5990[5] is marked as a blocker since it's introduced by > > CALCITE-5843[6], could @Mihai help to double check whether it is a > > expected change, and we need to fix it within 1.36.0? > > > > [1] https://calcite.apache.org/docs/history.html#v1-35-0 > > [2] > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > [3] https://github.com/apache/calcite/pulls > > [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > > [5] https://issues.apache.org/jira/browse/CALCITE-5990 > > [6] https://issues.apache.org/jira/browse/CALCITE-5843 > > > > -- > > > > Best, > > Benchao Li > > -- Best, Benchao Li
Re: [DISCUSS] Towards Calcite 1.36.0
Thanks Mihai for the quick response, I'll take a look at the PR. Mihai Budiu 于2023年10月25日周三 05:02写道： > > For the blocker issues, I have filed two PRs which should collectively fix > them. > > https://github.com/apache/calcite/pull/3481 fixes > https://issues.apache.org/jira/browse/CALCITE-5990, but does not include > tests, because the test fixture needs to be fixed as well for the tests to > pass. There are tests in the next PR: > https://github.com/apache/calcite/pull/3471 fixes > https://issues.apache.org/jira/browse/CALCITE-5921, but should be amended to > reenable the disabled tests if we merge 3481 first. > > Mihai > > > From: Benchao Li > Sent: Tuesday, October 24, 2023 5:46 AM > To: dev@calcite.apache.org > Subject: Re: [DISCUSS] Towards Calcite 1.36.0 > > A quick update on the current status for issues targeted 1.36.0 > > We need more reviewers for #2 and #3 since the end of October is approaching. > Please correct me if I'm mistaken, especially for issues in #1. > > #1. Issues already have reviewers, and seems promising to be merged shortly > > https://issues.apache.org/jira/browse/CALCITE-5884 > https://issues.apache.org/jira/browse/CALCITE-5918 > https://issues.apache.org/jira/browse/CALCITE-5860 > https://issues.apache.org/jira/browse/CALCITE-6011 > https://issues.apache.org/jira/browse/CALCITE-5949 > https://issues.apache.org/jira/browse/CALCITE-6041 > https://issues.apache.org/jira/browse/CALCITE-6038 > > #2. Issues has been reviewed, and needs another reviewer > > https://issues.apache.org/jira/browse/CALCITE-5984 > https://issues.apache.org/jira/browse/CALCITE-5825 > https://issues.apache.org/jira/browse/CALCITE-5826 > https://issues.apache.org/jira/browse/CALCITE-6037 > https://issues.apache.org/jira/browse/CALCITE-4455 > https://issues.apache.org/jira/browse/CALCITE-6042 > > #3. PR is ready, no reviewer yet > https://issues.apache.org/jira/browse/CALCITE-6052 > https://issues.apache.org/jira/browse/CALCITE-129 > > #4. blocker issues status > https://issues.apache.org/jira/browse/CALCITE-5990 is marked blocked > by https://issues.apache.org/jira/browse/CALCITE-5921 now. > Both issues have a PR, but proposed to have a more thorough solution. > I'll keep an eye on them closely. > > > Ran Tao 于2023年10月18日周三 18:37写道： > > > > Hi, community. > > > > Recently I reported an issue[1] which revealed that calcite's MAP SubQuery > > doesn't work, > > considering this is a feature regression or bug, maybe we can fix it in > > 1.36. > > The PR is ready. If someone has time, pls help to review it. many thanks. > > > > [1] https://issues.apache.org/jira/browse/CALCITE-6041 > > > > Best Regards, > > Ran Tao > > > > > > Benchao Li 于2023年10月8日周日 11:02写道： > > > > > It's been a bit more than 2 months since our last release [1] and > > > there are currently 90+ new commits in main branch. > > > > > > As usual, according to our Jira dashboard [2] and Github [3], there > > > are many pending issues that could / should be part of the release. > > > I'd propose to make a collective effort to try to clean up our 1.36 > > > backlog and merge the PRs which are in a good state. I'd propose to > > > aim for **end of October** to release 1.36.0, this will give us about > > > 20 days to clean up pending PRs for next version. What do you think? > > > > > > According to [4], the following release managers would be: > > > - 1.36.0 Benchao Li > > > - 1.37.0 Sergey Nuyanzin > > > - 1.38.0 Julian Hyde > > > > > > So I'm supposed to be the release manager for 1.36.0 > > > > > > And contributors, if you have any work that is in good shape and want > > > to be included in 1.36.0, please mark the fixVersion to 1.36.0, this > > > will inform the release manager, and we'll try our best to get it in. > > > > > > CALCITE-5990[5] is marked as a blocker since it's introduced by > > > CALCITE-5843[6], could @Mihai help to double check whether it is a > > > expected change, and we need to fix it within 1.36.0? > > > > > > [1] https://calcite.apache.org/docs/history.html#v1-35-0 > > > [2] > > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > > [3] https://github.com/apache/calcite/pulls > > > [4] https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > > > [5] https://issues.apache.org/jira/browse/CALCITE-5990 > > > [6] https://issues.apache.org/jira/browse/CALCITE-5843 > > > > > > -- > > > > > > Best, > > > Benchao Li > > > > > > > -- > > Best, > Benchao Li -- Best, Benchao Li
Re: [DISCUSS] Towards Calcite 1.36.0
Hi, all: We're already very close to 1.36.0, all unresolved issues has been someone reviewed. > https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0 - Some issues are currently being reviewed. That's great! Thank you all for your efforts. - Some issues have not been updated for a long time. If anyone is willing to continue the review, I believe they should be resolved soon. #1.Last update (new comments or commits) within 2 days: https://issues.apache.org/jira/browse/CALCITE-129 https://issues.apache.org/jira/browse/CALCITE-5990 #2. Last update exceeded 2 days https://issues.apache.org/jira/browse/CALCITE-5984 https://issues.apache.org/jira/browse/CALCITE-6052 #3. Last update exceeded 7 days https://issues.apache.org/jira/browse/CALCITE-5884 https://issues.apache.org/jira/browse/CALCITE-6037 #4. Last update exceeded 14 days https://issues.apache.org/jira/browse/CALCITE-4455 https://issues.apache.org/jira/browse/CALCITE-5826 On Wed, 25 Oct 2023 at 11:40, Benchao Li wrote: > Thanks Mihai for the quick response, I'll take a look at the PR. > > Mihai Budiu 于2023年10月25日周三 05:02写道： > > > > For the blocker issues, I have filed two PRs which should collectively > fix them. > > > > https://github.com/apache/calcite/pull/3481 fixes > https://issues.apache.org/jira/browse/CALCITE-5990, but does not include > tests, because the test fixture needs to be fixed as well for the tests to > pass. There are tests in the next PR: > > https://github.com/apache/calcite/pull/3471 fixes > https://issues.apache.org/jira/browse/CALCITE-5921, but should be amended > to reenable the disabled tests if we merge 3481 first. > > > > Mihai > > > > > > From: Benchao Li > > Sent: Tuesday, October 24, 2023 5:46 AM > > To: dev@calcite.apache.org > > Subject: Re: [DISCUSS] Towards Calcite 1.36.0 > > > > A quick update on the current status for issues targeted 1.36.0 > > > > We need more reviewers for #2 and #3 since the end of October is > approaching. > > Please correct me if I'm mistaken, especially for issues in #1. > > > > #1. Issues already have reviewers, and seems promising to be merged > shortly > > > > https://issues.apache.org/jira/browse/CALCITE-5884 > > https://issues.apache.org/jira/browse/CALCITE-5918 > > https://issues.apache.org/jira/browse/CALCITE-5860 > > https://issues.apache.org/jira/browse/CALCITE-6011 > > https://issues.apache.org/jira/browse/CALCITE-5949 > > https://issues.apache.org/jira/browse/CALCITE-6041 > > https://issues.apache.org/jira/browse/CALCITE-6038 > > > > #2. Issues has been reviewed, and needs another reviewer > > > > https://issues.apache.org/jira/browse/CALCITE-5984 > > https://issues.apache.org/jira/browse/CALCITE-5825 > > https://issues.apache.org/jira/browse/CALCITE-5826 > > https://issues.apache.org/jira/browse/CALCITE-6037 > > https://issues.apache.org/jira/browse/CALCITE-4455 > > https://issues.apache.org/jira/browse/CALCITE-6042 > > > > #3. PR is ready, no reviewer yet > > https://issues.apache.org/jira/browse/CALCITE-6052 > > https://issues.apache.org/jira/browse/CALCITE-129 > > > > #4. blocker issues status > > https://issues.apache.org/jira/browse/CALCITE-5990 is marked blocked > > by https://issues.apache.org/jira/browse/CALCITE-5921 now. > > Both issues have a PR, but proposed to have a more thorough solution. > > I'll keep an eye on them closely. > > > > > > Ran Tao 于2023年10月18日周三 18:37写道： > > > > > > Hi, community. > > > > > > Recently I reported an issue[1] which revealed that calcite's MAP > SubQuery > > > doesn't work, > > > considering this is a feature regression or bug, maybe we can fix it in > > > 1.36. > > > The PR is ready. If someone has time, pls help to review it. many > thanks. > > > > > > [1] https://issues.apache.org/jira/browse/CALCITE-6041 > > > > > > Best Regards, > > > Ran Tao > > > > > > > > > Benchao Li 于2023年10月8日周日 11:02写道： > > > > > > > It's been a bit more than 2 months since our last release [1] and > > > > there are currently 90+ new commits in main branch. > > > > > > > > As usual, according to our Jira dashboard [2] and Github [3], there > > > > are many pending issues that could / should be part of the release. > > > > I'd propose to make a collective effort to try to clean up our 1.36 > > > > backlog and merge t
Re: [DISCUSS] Towards Calcite 1.36.0
The expected release time at the end of the month seems to be coming soon. I performed an update on the list compiled by Jiajun. #1.Last update (new comments or commits) within 2 days (almost ready): https://issues.apache.org/jira/browse/CALCITE-129 https://issues.apache.org/jira/browse/CALCITE-5826 #2. Last update exceeded 2 days https://issues.apache.org/jira/browse/CALCITE-5990 https://issues.apache.org/jira/browse/CALCITE-5984 https://issues.apache.org/jira/browse/CALCITE-6052 #3. Last update exceeded 7 days https://issues.apache.org/jira/browse/CALCITE-5884 https://issues.apache.org/jira/browse/CALCITE-4455 Best Regards, Ran Tao Jiajun Xie 于2023年10月28日周六 13:34写道： > Hi, all: > We're already very close to 1.36.0, all unresolved issues has been someone > reviewed. > > > > https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0 > > > - Some issues are currently being reviewed. > That's great! Thank you all for your efforts. > - Some issues have not been updated for a long time. > If anyone is willing to continue the review, I believe they should be > resolved soon. > > > #1.Last update (new comments or commits) within 2 days: > https://issues.apache.org/jira/browse/CALCITE-129 > https://issues.apache.org/jira/browse/CALCITE-5990 > > #2. Last update exceeded 2 days > https://issues.apache.org/jira/browse/CALCITE-5984 > https://issues.apache.org/jira/browse/CALCITE-6052 > > #3. Last update exceeded 7 days > https://issues.apache.org/jira/browse/CALCITE-5884 > https://issues.apache.org/jira/browse/CALCITE-6037 > > #4. Last update exceeded 14 days > https://issues.apache.org/jira/browse/CALCITE-4455 > https://issues.apache.org/jira/browse/CALCITE-5826 > > On Wed, 25 Oct 2023 at 11:40, Benchao Li wrote: > > > Thanks Mihai for the quick response, I'll take a look at the PR. > > > > Mihai Budiu 于2023年10月25日周三 05:02写道： > > > > > > For the blocker issues, I have filed two PRs which should collectively > > fix them. > > > > > > https://github.com/apache/calcite/pull/3481 fixes > > https://issues.apache.org/jira/browse/CALCITE-5990, but does not include > > tests, because the test fixture needs to be fixed as well for the tests > to > > pass. There are tests in the next PR: > > > https://github.com/apache/calcite/pull/3471 fixes > > https://issues.apache.org/jira/browse/CALCITE-5921, but should be > amended > > to reenable the disabled tests if we merge 3481 first. > > > > > > Mihai > > > > > > > > > From: Benchao Li > > > Sent: Tuesday, October 24, 2023 5:46 AM > > > To: dev@calcite.apache.org > > > Subject: Re: [DISCUSS] Towards Calcite 1.36.0 > > > > > > A quick update on the current status for issues targeted 1.36.0 > > > > > > We need more reviewers for #2 and #3 since the end of October is > > approaching. > > > Please correct me if I'm mistaken, especially for issues in #1. > > > > > > #1. Issues already have reviewers, and seems promising to be merged > > shortly > > > > > > https://issues.apache.org/jira/browse/CALCITE-5884 > > > https://issues.apache.org/jira/browse/CALCITE-5918 > > > https://issues.apache.org/jira/browse/CALCITE-5860 > > > https://issues.apache.org/jira/browse/CALCITE-6011 > > > https://issues.apache.org/jira/browse/CALCITE-5949 > > > https://issues.apache.org/jira/browse/CALCITE-6041 > > > https://issues.apache.org/jira/browse/CALCITE-6038 > > > > > > #2. Issues has been reviewed, and needs another reviewer > > > > > > https://issues.apache.org/jira/browse/CALCITE-5984 > > > https://issues.apache.org/jira/browse/CALCITE-5825 > > > https://issues.apache.org/jira/browse/CALCITE-5826 > > > https://issues.apache.org/jira/browse/CALCITE-6037 > > > https://issues.apache.org/jira/browse/CALCITE-4455 > > > https://issues.apache.org/jira/browse/CALCITE-6042 > > > > > > #3. PR is ready, no reviewer yet > > > https://issues.apache.org/jira/browse/CALCITE-6052 > > > https://issues.apache.org/jira/browse/CALCITE-129 > > > > > > #4. blocker issues status > > > https://issues.apache.org/jira/browse/CALCITE-5990 is marked blocked > > > by https://issues.apache.org/jira/browse/CALCITE-5921 now. > > > Both issues have a PR, but proposed to have a more thorough solution. > > > I'll keep an eye on them closely. > > > > > > > > > Ran Tao 于2
Re: [DISCUSS] Towards Calcite 1.36.0
I just merged CALCITE-{129,6052}. Five left.
> On Oct 30, 2023, at 7:22 AM, Ran Tao wrote:
>
> The expected release time at the end of the month seems to be coming soon.
> I performed an update on the list compiled by Jiajun.
>
> #1.Last update (new comments or commits) within 2 days (almost ready):
> https://issues.apache.org/jira/browse/CALCITE-129
> https://issues.apache.org/jira/browse/CALCITE-5826
>
> #2. Last update exceeded 2 days
> https://issues.apache.org/jira/browse/CALCITE-5990
> https://issues.apache.org/jira/browse/CALCITE-5984
> https://issues.apache.org/jira/browse/CALCITE-6052
>
> #3. Last update exceeded 7 days
> https://issues.apache.org/jira/browse/CALCITE-5884
> https://issues.apache.org/jira/browse/CALCITE-4455
>
> Best Regards,
> Ran Tao
>
>
> Jiajun Xie 于2023年10月28日周六 13:34写道：
>
>> Hi, all:
>> We're already very close to 1.36.0, all unresolved issues has been someone
>> reviewed.
>>>
>>
>> https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
>>
>>
>> - Some issues are currently being reviewed.
>> That's great! Thank you all for your efforts.
>> - Some issues have not been updated for a long time.
>> If anyone is willing to continue the review, I believe they should be
>> resolved soon.
>>
>>
>> #1.Last update (new comments or commits) within 2 days:
>> https://issues.apache.org/jira/browse/CALCITE-129
>> https://issues.apache.org/jira/browse/CALCITE-5990
>>
>> #2. Last update exceeded 2 days
>> https://issues.apache.org/jira/browse/CALCITE-5984
>> https://issues.apache.org/jira/browse/CALCITE-6052
>>
>> #3. Last update exceeded 7 days
>> https://issues.apache.org/jira/browse/CALCITE-5884
>> https://issues.apache.org/jira/browse/CALCITE-6037
>>
>> #4. Last update exceeded 14 days
>> https://issues.apache.org/jira/browse/CALCITE-4455
>> https://issues.apache.org/jira/browse/CALCITE-5826
>>
>> On Wed, 25 Oct 2023 at 11:40, Benchao Li wrote:
>>
>>> Thanks Mihai for the quick response, I'll take a look at the PR.
>>>
>>> Mihai Budiu 于2023年10月25日周三 05:02写道：
>>>>
>>>> For the blocker issues, I have filed two PRs which should collectively
>>> fix them.
>>>>
>>>> https://github.com/apache/calcite/pull/3481 fixes
>>> https://issues.apache.org/jira/browse/CALCITE-5990, but does not include
>>> tests, because the test fixture needs to be fixed as well for the tests
>> to
>>> pass. There are tests in the next PR:
>>>> https://github.com/apache/calcite/pull/3471 fixes
>>> https://issues.apache.org/jira/browse/CALCITE-5921, but should be
>> amended
>>> to reenable the disabled tests if we merge 3481 first.
>>>>
>>>> Mihai
>>>>
>>>>
>>>> From: Benchao Li
>>>> Sent: Tuesday, October 24, 2023 5:46 AM
>>>> To: dev@calcite.apache.org
>>>> Subject: Re: [DISCUSS] Towards Calcite 1.36.0
>>>>
>>>> A quick update on the current status for issues targeted 1.36.0
>>>>
>>>> We need more reviewers for #2 and #3 since the end of October is
>>> approaching.
>>>> Please correct me if I'm mistaken, especially for issues in #1.
>>>>
>>>> #1. Issues already have reviewers, and seems promising to be merged
>>> shortly
>>>>
>>>> https://issues.apache.org/jira/browse/CALCITE-5884
>>>> https://issues.apache.org/jira/browse/CALCITE-5918
>>>> https://issues.apache.org/jira/browse/CALCITE-5860
>>>> https://issues.apache.org/jira/browse/CALCITE-6011
>>>> https://issues.apache.org/jira/browse/CALCITE-5949
>>>> https://issues.apache.org/jira/browse/CALCITE-6041
>>>> https://issues.apache.org/jira/browse/CALCITE-6038
>>>>
>>>> #2. Issues has been reviewed, and needs another reviewer
>>>>
>>>> https://issues.apache.org/jira/browse/CALCITE-5984
>>>> https://issues.apache.org/jira/browse/CALCITE-5825
>>>> https://issues.apache.org/jira/browse/CALCITE-5826
>>>> https://issues.apache.org/jira/browse/CALCITE-6037
>>>> https://issues.apache.org/jira/browse/CALCITE-4455
>>>> https://issues.apache.org/jira/browse/CALCITE-6042
>>>>
>>>> #3. PR is ready, no reviewer yet
>>>> https://issues.apache.org/jira/browse/CA
Re: [DISCUSS] Towards Calcite 1.36.0
Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455,
I think we can move it out of 1.36.0 for now. What do you think?
Other three issues look promising to be merged soon, then I'll start
the release process after they are merged.
Julian Hyde 于2023年10月31日周二 02:31写道：
>
> I just merged CALCITE-{129,6052}. Five left.
>
> > On Oct 30, 2023, at 7:22 AM, Ran Tao wrote:
> >
> > The expected release time at the end of the month seems to be coming soon.
> > I performed an update on the list compiled by Jiajun.
> >
> > #1.Last update (new comments or commits) within 2 days (almost ready):
> > https://issues.apache.org/jira/browse/CALCITE-129
> > https://issues.apache.org/jira/browse/CALCITE-5826
> >
> > #2. Last update exceeded 2 days
> > https://issues.apache.org/jira/browse/CALCITE-5990
> > https://issues.apache.org/jira/browse/CALCITE-5984
> > https://issues.apache.org/jira/browse/CALCITE-6052
> >
> > #3. Last update exceeded 7 days
> > https://issues.apache.org/jira/browse/CALCITE-5884
> > https://issues.apache.org/jira/browse/CALCITE-4455
> >
> > Best Regards,
> > Ran Tao
> >
> >
> > Jiajun Xie 于2023年10月28日周六 13:34写道：
> >
> >> Hi, all:
> >> We're already very close to 1.36.0, all unresolved issues has been someone
> >> reviewed.
> >>>
> >>
> >> https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
> >>
> >>
> >> - Some issues are currently being reviewed.
> >> That's great! Thank you all for your efforts.
> >> - Some issues have not been updated for a long time.
> >> If anyone is willing to continue the review, I believe they should be
> >> resolved soon.
> >>
> >>
> >> #1.Last update (new comments or commits) within 2 days:
> >> https://issues.apache.org/jira/browse/CALCITE-129
> >> https://issues.apache.org/jira/browse/CALCITE-5990
> >>
> >> #2. Last update exceeded 2 days
> >> https://issues.apache.org/jira/browse/CALCITE-5984
> >> https://issues.apache.org/jira/browse/CALCITE-6052
> >>
> >> #3. Last update exceeded 7 days
> >> https://issues.apache.org/jira/browse/CALCITE-5884
> >> https://issues.apache.org/jira/browse/CALCITE-6037
> >>
> >> #4. Last update exceeded 14 days
> >> https://issues.apache.org/jira/browse/CALCITE-4455
> >> https://issues.apache.org/jira/browse/CALCITE-5826
> >>
> >> On Wed, 25 Oct 2023 at 11:40, Benchao Li wrote:
> >>
> >>> Thanks Mihai for the quick response, I'll take a look at the PR.
> >>>
> >>> Mihai Budiu 于2023年10月25日周三 05:02写道：
> >>>>
> >>>> For the blocker issues, I have filed two PRs which should collectively
> >>> fix them.
> >>>>
> >>>> https://github.com/apache/calcite/pull/3481 fixes
> >>> https://issues.apache.org/jira/browse/CALCITE-5990, but does not include
> >>> tests, because the test fixture needs to be fixed as well for the tests
> >> to
> >>> pass. There are tests in the next PR:
> >>>> https://github.com/apache/calcite/pull/3471 fixes
> >>> https://issues.apache.org/jira/browse/CALCITE-5921, but should be
> >> amended
> >>> to reenable the disabled tests if we merge 3481 first.
> >>>>
> >>>> Mihai
> >>>>
> >>>>
> >>>> From: Benchao Li
> >>>> Sent: Tuesday, October 24, 2023 5:46 AM
> >>>> To: dev@calcite.apache.org
> >>>> Subject: Re: [DISCUSS] Towards Calcite 1.36.0
> >>>>
> >>>> A quick update on the current status for issues targeted 1.36.0
> >>>>
> >>>> We need more reviewers for #2 and #3 since the end of October is
> >>> approaching.
> >>>> Please correct me if I'm mistaken, especially for issues in #1.
> >>>>
> >>>> #1. Issues already have reviewers, and seems promising to be merged
> >>> shortly
> >>>>
> >>>> https://issues.apache.org/jira/browse/CALCITE-5884
> >>>> https://issues.apache.org/jira/browse/CALCITE-5918
> >>>> https://issues.apache.org/jira/browse/CALCITE-5860
> >>>> https://issues.apache.org/jira/browse/CALCITE-6011
> >>>> https://issues.apache.org/jira/browse/CALCITE-5949
> >>>>
Re: [DISCUSS] Towards Calcite 1.36.0
Hello,
I know it's late in the release process, but maybe we can add
https://github.com/apache/calcite/pull/3325 to this release?
Of course that's OK if it is too late for that.
Thanks,
Itiel
On Tue, Oct 31, 2023 at 3:50 PM Benchao Li wrote:
> Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455,
> I think we can move it out of 1.36.0 for now. What do you think?
>
> Other three issues look promising to be merged soon, then I'll start
> the release process after they are merged.
>
> Julian Hyde 于2023年10月31日周二 02:31写道：
> >
> > I just merged CALCITE-{129,6052}. Five left.
> >
> > > On Oct 30, 2023, at 7:22 AM, Ran Tao wrote:
> > >
> > > The expected release time at the end of the month seems to be coming
> soon.
> > > I performed an update on the list compiled by Jiajun.
> > >
> > > #1.Last update (new comments or commits) within 2 days (almost ready):
> > > https://issues.apache.org/jira/browse/CALCITE-129
> > > https://issues.apache.org/jira/browse/CALCITE-5826
> > >
> > > #2. Last update exceeded 2 days
> > > https://issues.apache.org/jira/browse/CALCITE-5990
> > > https://issues.apache.org/jira/browse/CALCITE-5984
> > > https://issues.apache.org/jira/browse/CALCITE-6052
> > >
> > > #3. Last update exceeded 7 days
> > > https://issues.apache.org/jira/browse/CALCITE-5884
> > > https://issues.apache.org/jira/browse/CALCITE-4455
> > >
> > > Best Regards,
> > > Ran Tao
> > >
> > >
> > > Jiajun Xie 于2023年10月28日周六 13:34写道：
> > >
> > >> Hi, all:
> > >> We're already very close to 1.36.0, all unresolved issues has been
> someone
> > >> reviewed.
> > >>>
> > >>
> > >>
> https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
> > >>
> > >>
> > >> - Some issues are currently being reviewed.
> > >> That's great! Thank you all for your efforts.
> > >> - Some issues have not been updated for a long time.
> > >> If anyone is willing to continue the review, I believe they should be
> > >> resolved soon.
> > >>
> > >>
> > >> #1.Last update (new comments or commits) within 2 days:
> > >> https://issues.apache.org/jira/browse/CALCITE-129
> > >> https://issues.apache.org/jira/browse/CALCITE-5990
> > >>
> > >> #2. Last update exceeded 2 days
> > >> https://issues.apache.org/jira/browse/CALCITE-5984
> > >> https://issues.apache.org/jira/browse/CALCITE-6052
> > >>
> > >> #3. Last update exceeded 7 days
> > >> https://issues.apache.org/jira/browse/CALCITE-5884
> > >> https://issues.apache.org/jira/browse/CALCITE-6037
> > >>
> > >> #4. Last update exceeded 14 days
> > >> https://issues.apache.org/jira/browse/CALCITE-4455
> > >> https://issues.apache.org/jira/browse/CALCITE-5826
> > >>
> > >> On Wed, 25 Oct 2023 at 11:40, Benchao Li
> wrote:
> > >>
> > >>> Thanks Mihai for the quick response, I'll take a look at the PR.
> > >>>
> > >>> Mihai Budiu 于2023年10月25日周三 05:02写道：
> > >>>>
> > >>>> For the blocker issues, I have filed two PRs which should
> collectively
> > >>> fix them.
> > >>>>
> > >>>> https://github.com/apache/calcite/pull/3481 fixes
> > >>> https://issues.apache.org/jira/browse/CALCITE-5990, but does not
> include
> > >>> tests, because the test fixture needs to be fixed as well for the
> tests
> > >> to
> > >>> pass. There are tests in the next PR:
> > >>>> https://github.com/apache/calcite/pull/3471 fixes
> > >>> https://issues.apache.org/jira/browse/CALCITE-5921, but should be
> > >> amended
> > >>> to reenable the disabled tests if we merge 3481 first.
> > >>>>
> > >>>> Mihai
> > >>>>
> > >>>>
> > >>>> From: Benchao Li
> > >>>> Sent: Tuesday, October 24, 2023 5:46 AM
> > >>>> To: dev@calcite.apache.org
> > >>>> Subject: Re: [DISCUSS] Towards Calcite 1.36.0
> > >>>>
> > >>>> A quick update on the current status for issues targeted 1.36.0
> > >>
Re: [DISCUSS] Towards Calcite 1.36.0
5884 is mostly documentation fixes.
I expected it would be easy to get it in.
But we can leave it for later.
Mihai
From: Benchao Li
Sent: Tuesday, October 31, 2023 6:50 AM
To: dev@calcite.apache.org
Subject: Re: [DISCUSS] Towards Calcite 1.36.0
Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455,
I think we can move it out of 1.36.0 for now. What do you think?
Other three issues look promising to be merged soon, then I'll start
the release process after they are merged.
Julian Hyde 于2023年10月31日周二 02:31写道：
>
> I just merged CALCITE-{129,6052}. Five left.
>
> > On Oct 30, 2023, at 7:22 AM, Ran Tao wrote:
> >
> > The expected release time at the end of the month seems to be coming soon.
> > I performed an update on the list compiled by Jiajun.
> >
> > #1.Last update (new comments or commits) within 2 days (almost ready):
> > https://issues.apache.org/jira/browse/CALCITE-129
> > https://issues.apache.org/jira/browse/CALCITE-5826
> >
> > #2. Last update exceeded 2 days
> > https://issues.apache.org/jira/browse/CALCITE-5990
> > https://issues.apache.org/jira/browse/CALCITE-5984
> > https://issues.apache.org/jira/browse/CALCITE-6052
> >
> > #3. Last update exceeded 7 days
> > https://issues.apache.org/jira/browse/CALCITE-5884
> > https://issues.apache.org/jira/browse/CALCITE-4455
> >
> > Best Regards,
> > Ran Tao
> >
> >
> > Jiajun Xie 于2023年10月28日周六 13:34写道：
> >
> >> Hi, all:
> >> We're already very close to 1.36.0, all unresolved issues has been someone
> >> reviewed.
> >>>
> >>
> >> https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
> >>
> >>
> >> - Some issues are currently being reviewed.
> >> That's great! Thank you all for your efforts.
> >> - Some issues have not been updated for a long time.
> >> If anyone is willing to continue the review, I believe they should be
> >> resolved soon.
> >>
> >>
> >> #1.Last update (new comments or commits) within 2 days:
> >> https://issues.apache.org/jira/browse/CALCITE-129
> >> https://issues.apache.org/jira/browse/CALCITE-5990
> >>
> >> #2. Last update exceeded 2 days
> >> https://issues.apache.org/jira/browse/CALCITE-5984
> >> https://issues.apache.org/jira/browse/CALCITE-6052
> >>
> >> #3. Last update exceeded 7 days
> >> https://issues.apache.org/jira/browse/CALCITE-5884
> >> https://issues.apache.org/jira/browse/CALCITE-6037
> >>
> >> #4. Last update exceeded 14 days
> >> https://issues.apache.org/jira/browse/CALCITE-4455
> >> https://issues.apache.org/jira/browse/CALCITE-5826
> >>
> >> On Wed, 25 Oct 2023 at 11:40, Benchao Li wrote:
> >>
> >>> Thanks Mihai for the quick response, I'll take a look at the PR.
> >>>
> >>> Mihai Budiu 于2023年10月25日周三 05:02写道：
> >>>>
> >>>> For the blocker issues, I have filed two PRs which should collectively
> >>> fix them.
> >>>>
> >>>> https://github.com/apache/calcite/pull/3481 fixes
> >>> https://issues.apache.org/jira/browse/CALCITE-5990, but does not include
> >>> tests, because the test fixture needs to be fixed as well for the tests
> >> to
> >>> pass. There are tests in the next PR:
> >>>> https://github.com/apache/calcite/pull/3471 fixes
> >>> https://issues.apache.org/jira/browse/CALCITE-5921, but should be
> >> amended
> >>> to reenable the disabled tests if we merge 3481 first.
> >>>>
> >>>> Mihai
> >>>>
> >>>>
> >>>> From: Benchao Li
> >>>> Sent: Tuesday, October 24, 2023 5:46 AM
> >>>> To: dev@calcite.apache.org
> >>>> Subject: Re: [DISCUSS] Towards Calcite 1.36.0
> >>>>
> >>>> A quick update on the current status for issues targeted 1.36.0
> >>>>
> >>>> We need more reviewers for #2 and #3 since the end of October is
> >>> approaching.
> >>>> Please correct me if I'm mistaken, especially for issues in #1.
> >>>>
> >>>> #1. Issues already have reviewers, and seems promising to be merged
> >>> shortly
> >>>>
> >>>> https://issues.apache.org/jira/browse/CALCITE-5884
> >>>> https://
Re: [DISCUSS] Towards Calcite 1.36.0
Mihai,
I've reviewed 5884, it looks good and I think we can have it in 1.36.0
Itiel,
https://github.com/apache/calcite/pull/3325 has been reviewed and even
with an approval, I'll try to ping in the PR to try to get it merged
in 1.36.0
Mihai Budiu 于2023年11月1日周三 02:42写道：
>
> 5884 is mostly documentation fixes.
> I expected it would be easy to get it in.
> But we can leave it for later.
>
> Mihai
>
>
> From: Benchao Li
> Sent: Tuesday, October 31, 2023 6:50 AM
> To: dev@calcite.apache.org
> Subject: Re: [DISCUSS] Towards Calcite 1.36.0
>
> Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455,
> I think we can move it out of 1.36.0 for now. What do you think?
>
> Other three issues look promising to be merged soon, then I'll start
> the release process after they are merged.
>
> Julian Hyde 于2023年10月31日周二 02:31写道：
> >
> > I just merged CALCITE-{129,6052}. Five left.
> >
> > > On Oct 30, 2023, at 7:22 AM, Ran Tao wrote:
> > >
> > > The expected release time at the end of the month seems to be coming soon.
> > > I performed an update on the list compiled by Jiajun.
> > >
> > > #1.Last update (new comments or commits) within 2 days (almost ready):
> > > https://issues.apache.org/jira/browse/CALCITE-129
> > > https://issues.apache.org/jira/browse/CALCITE-5826
> > >
> > > #2. Last update exceeded 2 days
> > > https://issues.apache.org/jira/browse/CALCITE-5990
> > > https://issues.apache.org/jira/browse/CALCITE-5984
> > > https://issues.apache.org/jira/browse/CALCITE-6052
> > >
> > > #3. Last update exceeded 7 days
> > > https://issues.apache.org/jira/browse/CALCITE-5884
> > > https://issues.apache.org/jira/browse/CALCITE-4455
> > >
> > > Best Regards,
> > > Ran Tao
> > >
> > >
> > > Jiajun Xie 于2023年10月28日周六 13:34写道：
> > >
> > >> Hi, all:
> > >> We're already very close to 1.36.0, all unresolved issues has been
> > >> someone
> > >> reviewed.
> > >>>
> > >>
> > >> https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
> > >>
> > >>
> > >> - Some issues are currently being reviewed.
> > >> That's great! Thank you all for your efforts.
> > >> - Some issues have not been updated for a long time.
> > >> If anyone is willing to continue the review, I believe they should be
> > >> resolved soon.
> > >>
> > >>
> > >> #1.Last update (new comments or commits) within 2 days:
> > >> https://issues.apache.org/jira/browse/CALCITE-129
> > >> https://issues.apache.org/jira/browse/CALCITE-5990
> > >>
> > >> #2. Last update exceeded 2 days
> > >> https://issues.apache.org/jira/browse/CALCITE-5984
> > >> https://issues.apache.org/jira/browse/CALCITE-6052
> > >>
> > >> #3. Last update exceeded 7 days
> > >> https://issues.apache.org/jira/browse/CALCITE-5884
> > >> https://issues.apache.org/jira/browse/CALCITE-6037
> > >>
> > >> #4. Last update exceeded 14 days
> > >> https://issues.apache.org/jira/browse/CALCITE-4455
> > >> https://issues.apache.org/jira/browse/CALCITE-5826
> > >>
> > >> On Wed, 25 Oct 2023 at 11:40, Benchao Li wrote:
> > >>
> > >>> Thanks Mihai for the quick response, I'll take a look at the PR.
> > >>>
> > >>> Mihai Budiu 于2023年10月25日周三 05:02写道：
> > >>>>
> > >>>> For the blocker issues, I have filed two PRs which should collectively
> > >>> fix them.
> > >>>>
> > >>>> https://github.com/apache/calcite/pull/3481 fixes
> > >>> https://issues.apache.org/jira/browse/CALCITE-5990, but does not include
> > >>> tests, because the test fixture needs to be fixed as well for the tests
> > >> to
> > >>> pass. There are tests in the next PR:
> > >>>> https://github.com/apache/calcite/pull/3471 fixes
> > >>> https://issues.apache.org/jira/browse/CALCITE-5921, but should be
> > >> amended
> > >>> to reenable the disabled tests if we merge 3481 first.
> > >>>>
> > >>>> Mihai
> > >>>>
> > >>>>
> > >>&g
Re: [DISCUSS] Towards Calcite 1.36.0
Hi Itiel,
I have reviewd the https://github.com/apache/calcite/pull/3325,and left one
comments
Benchao Li 于2023年11月1日周三 10:17写道：
> Mihai,
> I've reviewed 5884, it looks good and I think we can have it in 1.36.0
>
> Itiel,
> https://github.com/apache/calcite/pull/3325 has been reviewed and even
> with an approval, I'll try to ping in the PR to try to get it merged
> in 1.36.0
>
> Mihai Budiu 于2023年11月1日周三 02:42写道：
> >
> > 5884 is mostly documentation fixes.
> > I expected it would be easy to get it in.
> > But we can leave it for later.
> >
> > Mihai
> >
> >
> > From: Benchao Li
> > Sent: Tuesday, October 31, 2023 6:50 AM
> > To: dev@calcite.apache.org
> > Subject: Re: [DISCUSS] Towards Calcite 1.36.0
> >
> > Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455,
> > I think we can move it out of 1.36.0 for now. What do you think?
> >
> > Other three issues look promising to be merged soon, then I'll start
> > the release process after they are merged.
> >
> > Julian Hyde 于2023年10月31日周二 02:31写道：
> > >
> > > I just merged CALCITE-{129,6052}. Five left.
> > >
> > > > On Oct 30, 2023, at 7:22 AM, Ran Tao wrote:
> > > >
> > > > The expected release time at the end of the month seems to be coming
> soon.
> > > > I performed an update on the list compiled by Jiajun.
> > > >
> > > > #1.Last update (new comments or commits) within 2 days (almost
> ready):
> > > > https://issues.apache.org/jira/browse/CALCITE-129
> > > > https://issues.apache.org/jira/browse/CALCITE-5826
> > > >
> > > > #2. Last update exceeded 2 days
> > > > https://issues.apache.org/jira/browse/CALCITE-5990
> > > > https://issues.apache.org/jira/browse/CALCITE-5984
> > > > https://issues.apache.org/jira/browse/CALCITE-6052
> > > >
> > > > #3. Last update exceeded 7 days
> > > > https://issues.apache.org/jira/browse/CALCITE-5884
> > > > https://issues.apache.org/jira/browse/CALCITE-4455
> > > >
> > > > Best Regards,
> > > > Ran Tao
> > > >
> > > >
> > > > Jiajun Xie 于2023年10月28日周六 13:34写道：
> > > >
> > > >> Hi, all:
> > > >> We're already very close to 1.36.0, all unresolved issues has been
> someone
> > > >> reviewed.
> > > >>>
> > > >>
> > > >>
> https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
> > > >>
> > > >>
> > > >> - Some issues are currently being reviewed.
> > > >> That's great! Thank you all for your efforts.
> > > >> - Some issues have not been updated for a long time.
> > > >> If anyone is willing to continue the review, I believe they should
> be
> > > >> resolved soon.
> > > >>
> > > >>
> > > >> #1.Last update (new comments or commits) within 2 days:
> > > >> https://issues.apache.org/jira/browse/CALCITE-129
> > > >> https://issues.apache.org/jira/browse/CALCITE-5990
> > > >>
> > > >> #2. Last update exceeded 2 days
> > > >> https://issues.apache.org/jira/browse/CALCITE-5984
> > > >> https://issues.apache.org/jira/browse/CALCITE-6052
> > > >>
> > > >> #3. Last update exceeded 7 days
> > > >> https://issues.apache.org/jira/browse/CALCITE-5884
> > > >> https://issues.apache.org/jira/browse/CALCITE-6037
> > > >>
> > > >> #4. Last update exceeded 14 days
> > > >> https://issues.apache.org/jira/browse/CALCITE-4455
> > > >> https://issues.apache.org/jira/browse/CALCITE-5826
> > > >>
> > > >> On Wed, 25 Oct 2023 at 11:40, Benchao Li
> wrote:
> > > >>
> > > >>> Thanks Mihai for the quick response, I'll take a look at the PR.
> > > >>>
> > > >>> Mihai Budiu 于2023年10月25日周三 05:02写道：
> > > >>>>
> > > >>>> For the blocker issues, I have filed two PRs which should
> collectively
> > > >>> fix them.
> > > >>>>
> > > >>>> https://github.com/apache/calcite/pull/3481 fixes
> > > >>> https://issues.apache.org/jira/browse/CALCIT
Re: [DISCUSS] Towards Calcite 1.36.0
@Mihai @Julian The only left issue is 5884 now, can we merge it and
start the releasing process?
LakeShen 于2023年11月1日周三 12:13写道：
>
> Hi Itiel,
>
> I have reviewd the https://github.com/apache/calcite/pull/3325,and left one
> comments
>
> Benchao Li 于2023年11月1日周三 10:17写道：
>
> > Mihai,
> > I've reviewed 5884, it looks good and I think we can have it in 1.36.0
> >
> > Itiel,
> > https://github.com/apache/calcite/pull/3325 has been reviewed and even
> > with an approval, I'll try to ping in the PR to try to get it merged
> > in 1.36.0
> >
> > Mihai Budiu 于2023年11月1日周三 02:42写道：
> > >
> > > 5884 is mostly documentation fixes.
> > > I expected it would be easy to get it in.
> > > But we can leave it for later.
> > >
> > > Mihai
> > >
> > > ____________
> > > From: Benchao Li
> > > Sent: Tuesday, October 31, 2023 6:50 AM
> > > To: dev@calcite.apache.org
> > > Subject: Re: [DISCUSS] Towards Calcite 1.36.0
> > >
> > > Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455,
> > > I think we can move it out of 1.36.0 for now. What do you think?
> > >
> > > Other three issues look promising to be merged soon, then I'll start
> > > the release process after they are merged.
> > >
> > > Julian Hyde 于2023年10月31日周二 02:31写道：
> > > >
> > > > I just merged CALCITE-{129,6052}. Five left.
> > > >
> > > > > On Oct 30, 2023, at 7:22 AM, Ran Tao wrote:
> > > > >
> > > > > The expected release time at the end of the month seems to be coming
> > soon.
> > > > > I performed an update on the list compiled by Jiajun.
> > > > >
> > > > > #1.Last update (new comments or commits) within 2 days (almost
> > ready):
> > > > > https://issues.apache.org/jira/browse/CALCITE-129
> > > > > https://issues.apache.org/jira/browse/CALCITE-5826
> > > > >
> > > > > #2. Last update exceeded 2 days
> > > > > https://issues.apache.org/jira/browse/CALCITE-5990
> > > > > https://issues.apache.org/jira/browse/CALCITE-5984
> > > > > https://issues.apache.org/jira/browse/CALCITE-6052
> > > > >
> > > > > #3. Last update exceeded 7 days
> > > > > https://issues.apache.org/jira/browse/CALCITE-5884
> > > > > https://issues.apache.org/jira/browse/CALCITE-4455
> > > > >
> > > > > Best Regards,
> > > > > Ran Tao
> > > > >
> > > > >
> > > > > Jiajun Xie 于2023年10月28日周六 13:34写道：
> > > > >
> > > > >> Hi, all:
> > > > >> We're already very close to 1.36.0, all unresolved issues has been
> > someone
> > > > >> reviewed.
> > > > >>>
> > > > >>
> > > > >>
> > https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
> > > > >>
> > > > >>
> > > > >> - Some issues are currently being reviewed.
> > > > >> That's great! Thank you all for your efforts.
> > > > >> - Some issues have not been updated for a long time.
> > > > >> If anyone is willing to continue the review, I believe they should
> > be
> > > > >> resolved soon.
> > > > >>
> > > > >>
> > > > >> #1.Last update (new comments or commits) within 2 days:
> > > > >> https://issues.apache.org/jira/browse/CALCITE-129
> > > > >> https://issues.apache.org/jira/browse/CALCITE-5990
> > > > >>
> > > > >> #2. Last update exceeded 2 days
> > > > >> https://issues.apache.org/jira/browse/CALCITE-5984
> > > > >> https://issues.apache.org/jira/browse/CALCITE-6052
> > > > >>
> > > > >> #3. Last update exceeded 7 days
> > > > >> https://issues.apache.org/jira/browse/CALCITE-5884
> > > > >> https://issues.apache.org/jira/browse/CALCITE-6037
> > > > >>
> > > > >> #4. Last update exceeded 14 days
> > > > >> https://issues.apache.org/jira/browse/CALCITE-4455
> > > > >> https://issues.apache.org/jira/browse/CALCITE-5826
> > > > >>
> > > > >> On Wed,
Re: [DISCUSS] Towards Calcite 1.36.0
Hi devs,
All the issues targeted for 1.36.0 have been resolved, I'll start the
release process now. Therefore main branch is in code freeze until
further notice.
Benchao Li 于2023年11月3日周五 10:50写道：
>
> @Mihai @Julian The only left issue is 5884 now, can we merge it and
> start the releasing process?
>
> LakeShen 于2023年11月1日周三 12:13写道：
> >
> > Hi Itiel,
> >
> > I have reviewd the https://github.com/apache/calcite/pull/3325,and left one
> > comments
> >
> > Benchao Li 于2023年11月1日周三 10:17写道：
> >
> > > Mihai,
> > > I've reviewed 5884, it looks good and I think we can have it in 1.36.0
> > >
> > > Itiel,
> > > https://github.com/apache/calcite/pull/3325 has been reviewed and even
> > > with an approval, I'll try to ping in the PR to try to get it merged
> > > in 1.36.0
> > >
> > > Mihai Budiu 于2023年11月1日周三 02:42写道：
> > > >
> > > > 5884 is mostly documentation fixes.
> > > > I expected it would be easy to get it in.
> > > > But we can leave it for later.
> > > >
> > > > Mihai
> > > >
> > > >
> > > > From: Benchao Li
> > > > Sent: Tuesday, October 31, 2023 6:50 AM
> > > > To: dev@calcite.apache.org
> > > > Subject: Re: [DISCUSS] Towards Calcite 1.36.0
> > > >
> > > > Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455,
> > > > I think we can move it out of 1.36.0 for now. What do you think?
> > > >
> > > > Other three issues look promising to be merged soon, then I'll start
> > > > the release process after they are merged.
> > > >
> > > > Julian Hyde 于2023年10月31日周二 02:31写道：
> > > > >
> > > > > I just merged CALCITE-{129,6052}. Five left.
> > > > >
> > > > > > On Oct 30, 2023, at 7:22 AM, Ran Tao wrote:
> > > > > >
> > > > > > The expected release time at the end of the month seems to be coming
> > > soon.
> > > > > > I performed an update on the list compiled by Jiajun.
> > > > > >
> > > > > > #1.Last update (new comments or commits) within 2 days (almost
> > > ready):
> > > > > > https://issues.apache.org/jira/browse/CALCITE-129
> > > > > > https://issues.apache.org/jira/browse/CALCITE-5826
> > > > > >
> > > > > > #2. Last update exceeded 2 days
> > > > > > https://issues.apache.org/jira/browse/CALCITE-5990
> > > > > > https://issues.apache.org/jira/browse/CALCITE-5984
> > > > > > https://issues.apache.org/jira/browse/CALCITE-6052
> > > > > >
> > > > > > #3. Last update exceeded 7 days
> > > > > > https://issues.apache.org/jira/browse/CALCITE-5884
> > > > > > https://issues.apache.org/jira/browse/CALCITE-4455
> > > > > >
> > > > > > Best Regards,
> > > > > > Ran Tao
> > > > > >
> > > > > >
> > > > > > Jiajun Xie 于2023年10月28日周六 13:34写道：
> > > > > >
> > > > > >> Hi, all:
> > > > > >> We're already very close to 1.36.0, all unresolved issues has been
> > > someone
> > > > > >> reviewed.
> > > > > >>>
> > > > > >>
> > > > > >>
> > > https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
> > > > > >>
> > > > > >>
> > > > > >> - Some issues are currently being reviewed.
> > > > > >> That's great! Thank you all for your efforts.
> > > > > >> - Some issues have not been updated for a long time.
> > > > > >> If anyone is willing to continue the review, I believe they should
> > > be
> > > > > >> resolved soon.
> > > > > >>
> > > > > >>
> > > > > >> #1.Last update (new comments or commits) within 2 days:
> > > > > >> https://issues.apache.org/jira/browse/CALCITE-129
> > > > > >> https://issues.apache.org/jira/browse/CALCITE-5990
> > > > > >>
> > > > > >> #2. Last update exceeded 2 days
> > > > > >> https://issues.apache.o
Re: [DISCUSS] Towards Calcite 1.36.0
The release note PR is now available for review:
https://github.com/apache/calcite/pull/3505
Benchao Li 于2023年11月6日周一 12:46写道：
>
> Hi devs,
>
> All the issues targeted for 1.36.0 have been resolved, I'll start the
> release process now. Therefore main branch is in code freeze until
> further notice.
>
> Benchao Li 于2023年11月3日周五 10:50写道：
> >
> > @Mihai @Julian The only left issue is 5884 now, can we merge it and
> > start the releasing process?
> >
> > LakeShen 于2023年11月1日周三 12:13写道：
> > >
> > > Hi Itiel,
> > >
> > > I have reviewd the https://github.com/apache/calcite/pull/3325,and left
> > > one
> > > comments
> > >
> > > Benchao Li 于2023年11月1日周三 10:17写道：
> > >
> > > > Mihai,
> > > > I've reviewed 5884, it looks good and I think we can have it in 1.36.0
> > > >
> > > > Itiel,
> > > > https://github.com/apache/calcite/pull/3325 has been reviewed and even
> > > > with an approval, I'll try to ping in the PR to try to get it merged
> > > > in 1.36.0
> > > >
> > > > Mihai Budiu 于2023年11月1日周三 02:42写道：
> > > > >
> > > > > 5884 is mostly documentation fixes.
> > > > > I expected it would be easy to get it in.
> > > > > But we can leave it for later.
> > > > >
> > > > > Mihai
> > > > >
> > > > >
> > > > > From: Benchao Li
> > > > > Sent: Tuesday, October 31, 2023 6:50 AM
> > > > > To: dev@calcite.apache.org
> > > > > Subject: Re: [DISCUSS] Towards Calcite 1.36.0
> > > > >
> > > > > Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455,
> > > > > I think we can move it out of 1.36.0 for now. What do you think?
> > > > >
> > > > > Other three issues look promising to be merged soon, then I'll start
> > > > > the release process after they are merged.
> > > > >
> > > > > Julian Hyde 于2023年10月31日周二 02:31写道：
> > > > > >
> > > > > > I just merged CALCITE-{129,6052}. Five left.
> > > > > >
> > > > > > > On Oct 30, 2023, at 7:22 AM, Ran Tao
> > > > > > > wrote:
> > > > > > >
> > > > > > > The expected release time at the end of the month seems to be
> > > > > > > coming
> > > > soon.
> > > > > > > I performed an update on the list compiled by Jiajun.
> > > > > > >
> > > > > > > #1.Last update (new comments or commits) within 2 days (almost
> > > > ready):
> > > > > > > https://issues.apache.org/jira/browse/CALCITE-129
> > > > > > > https://issues.apache.org/jira/browse/CALCITE-5826
> > > > > > >
> > > > > > > #2. Last update exceeded 2 days
> > > > > > > https://issues.apache.org/jira/browse/CALCITE-5990
> > > > > > > https://issues.apache.org/jira/browse/CALCITE-5984
> > > > > > > https://issues.apache.org/jira/browse/CALCITE-6052
> > > > > > >
> > > > > > > #3. Last update exceeded 7 days
> > > > > > > https://issues.apache.org/jira/browse/CALCITE-5884
> > > > > > > https://issues.apache.org/jira/browse/CALCITE-4455
> > > > > > >
> > > > > > > Best Regards,
> > > > > > > Ran Tao
> > > > > > >
> > > > > > >
> > > > > > > Jiajun Xie 于2023年10月28日周六 13:34写道：
> > > > > > >
> > > > > > >> Hi, all:
> > > > > > >> We're already very close to 1.36.0, all unresolved issues has
> > > > > > >> been
> > > > someone
> > > > > > >> reviewed.
> > > > > > >>>
> > > > > > >>
> > > > > > >>
> > > > https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
> > > > > > >>
> > > > > > >>
> > > > > > >> - Some issues are currently being reviewed.
> > > > > > >> That's great! Thank you all for your efforts.
> > > > > >
Re: [DISCUSS] Towards Calcite 1.36.0
Hi, Benchao
Is the main branch still frozen?
I found a new commit[1], but 1.36.0 has not been released.
[1]
https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba
On Mon, 6 Nov 2023 at 14:59, Benchao Li wrote:
> The release note PR is now available for review:
> https://github.com/apache/calcite/pull/3505
>
> Benchao Li 于2023年11月6日周一 12:46写道：
> >
> > Hi devs,
> >
> > All the issues targeted for 1.36.0 have been resolved, I'll start the
> > release process now. Therefore main branch is in code freeze until
> > further notice.
> >
> > Benchao Li 于2023年11月3日周五 10:50写道：
> > >
> > > @Mihai @Julian The only left issue is 5884 now, can we merge it and
> > > start the releasing process?
> > >
> > > LakeShen 于2023年11月1日周三 12:13写道：
> > > >
> > > > Hi Itiel,
> > > >
> > > > I have reviewd the https://github.com/apache/calcite/pull/3325,and
> left one
> > > > comments
> > > >
> > > > Benchao Li 于2023年11月1日周三 10:17写道：
> > > >
> > > > > Mihai,
> > > > > I've reviewed 5884, it looks good and I think we can have it in
> 1.36.0
> > > > >
> > > > > Itiel,
> > > > > https://github.com/apache/calcite/pull/3325 has been reviewed and
> even
> > > > > with an approval, I'll try to ping in the PR to try to get it
> merged
> > > > > in 1.36.0
> > > > >
> > > > > Mihai Budiu 于2023年11月1日周三 02:42写道：
> > > > > >
> > > > > > 5884 is mostly documentation fixes.
> > > > > > I expected it would be easy to get it in.
> > > > > > But we can leave it for later.
> > > > > >
> > > > > > Mihai
> > > > > >
> > > > > >
> > > > > > From: Benchao Li
> > > > > > Sent: Tuesday, October 31, 2023 6:50 AM
> > > > > > To: dev@calcite.apache.org
> > > > > > Subject: Re: [DISCUSS] Towards Calcite 1.36.0
> > > > > >
> > > > > > Due to the inactivity of the review for CALCITE-5884 and
> CALCITE-4455,
> > > > > > I think we can move it out of 1.36.0 for now. What do you think?
> > > > > >
> > > > > > Other three issues look promising to be merged soon, then I'll
> start
> > > > > > the release process after they are merged.
> > > > > >
> > > > > > Julian Hyde 于2023年10月31日周二 02:31写道：
> > > > > > >
> > > > > > > I just merged CALCITE-{129,6052}. Five left.
> > > > > > >
> > > > > > > > On Oct 30, 2023, at 7:22 AM, Ran Tao
> wrote:
> > > > > > > >
> > > > > > > > The expected release time at the end of the month seems to
> be coming
> > > > > soon.
> > > > > > > > I performed an update on the list compiled by Jiajun.
> > > > > > > >
> > > > > > > > #1.Last update (new comments or commits) within 2 days
> (almost
> > > > > ready):
> > > > > > > > https://issues.apache.org/jira/browse/CALCITE-129
> > > > > > > > https://issues.apache.org/jira/browse/CALCITE-5826
> > > > > > > >
> > > > > > > > #2. Last update exceeded 2 days
> > > > > > > > https://issues.apache.org/jira/browse/CALCITE-5990
> > > > > > > > https://issues.apache.org/jira/browse/CALCITE-5984
> > > > > > > > https://issues.apache.org/jira/browse/CALCITE-6052
> > > > > > > >
> > > > > > > > #3. Last update exceeded 7 days
> > > > > > > > https://issues.apache.org/jira/browse/CALCITE-5884
> > > > > > > > https://issues.apache.org/jira/browse/CALCITE-4455
> > > > > > > >
> > > > > > > > Best Regards,
> > > > > > > > Ran Tao
> > > > > > > >
> > > > > > > >
> > > > > > > > Jiajun Xie 于2023年10月28日周六
> 13:34写道：
> > > > > > > >
> > > > > > > >> Hi, all:
> > > > > > > >> We're already very close to 1.36.0, all unresolved issues
> has been
> > > > > someone
> >
Re: [DISCUSS] Towards Calcite 1.36.0
I believe the main branch should still be frozen as we're still voting
for 1.36.0.
I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be reverted
and then rebased on to main after 1.36.0 has been released.
Francis
On 8/11/2023 12:58 pm, Jiajun Xie wrote:
Hi, Benchao
Is the main branch still frozen?
I found a new commit[1], but 1.36.0 has not been released.
[1]
https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba
On Mon, 6 Nov 2023 at 14:59, Benchao Li wrote:
The release note PR is now available for review:
https://github.com/apache/calcite/pull/3505
Benchao Li 于2023年11月6日周一 12:46写道：
Hi devs,
All the issues targeted for 1.36.0 have been resolved, I'll start the
release process now. Therefore main branch is in code freeze until
further notice.
Benchao Li 于2023年11月3日周五 10:50写道：
@Mihai @Julian The only left issue is 5884 now, can we merge it and
start the releasing process?
LakeShen 于2023年11月1日周三 12:13写道：
Hi Itiel,
I have reviewd the https://github.com/apache/calcite/pull/3325,and
left one
comments
Benchao Li 于2023年11月1日周三 10:17写道：
Mihai,
I've reviewed 5884, it looks good and I think we can have it in
1.36.0
Itiel,
https://github.com/apache/calcite/pull/3325 has been reviewed and
even
with an approval, I'll try to ping in the PR to try to get it
merged
in 1.36.0
Mihai Budiu 于2023年11月1日周三 02:42写道：
5884 is mostly documentation fixes.
I expected it would be easy to get it in.
But we can leave it for later.
Mihai
From: Benchao Li
Sent: Tuesday, October 31, 2023 6:50 AM
To: dev@calcite.apache.org
Subject: Re: [DISCUSS] Towards Calcite 1.36.0
Due to the inactivity of the review for CALCITE-5884 and
CALCITE-4455,
I think we can move it out of 1.36.0 for now. What do you think?
Other three issues look promising to be merged soon, then I'll
start
the release process after they are merged.
Julian Hyde 于2023年10月31日周二 02:31写道：
I just merged CALCITE-{129,6052}. Five left.
On Oct 30, 2023, at 7:22 AM, Ran Tao
wrote:
The expected release time at the end of the month seems to
be coming
soon.
I performed an update on the list compiled by Jiajun.
#1.Last update (new comments or commits) within 2 days
(almost
ready):
https://issues.apache.org/jira/browse/CALCITE-129
https://issues.apache.org/jira/browse/CALCITE-5826
#2. Last update exceeded 2 days
https://issues.apache.org/jira/browse/CALCITE-5990
https://issues.apache.org/jira/browse/CALCITE-5984
https://issues.apache.org/jira/browse/CALCITE-6052
#3. Last update exceeded 7 days
https://issues.apache.org/jira/browse/CALCITE-5884
https://issues.apache.org/jira/browse/CALCITE-4455
Best Regards,
Ran Tao
Jiajun Xie 于2023年10月28日周六
13:34写道：
Hi, all:
We're already very close to 1.36.0, all unresolved issues
has been
someone
reviewed.
https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
- Some issues are currently being reviewed.
That's great! Thank you all for your efforts.
- Some issues have not been updated for a long time.
If anyone is willing to continue the review, I believe they
should
be
resolved soon.
#1.Last update (new comments or commits) within 2 days:
https://issues.apache.org/jira/browse/CALCITE-129
https://issues.apache.org/jira/browse/CALCITE-5990
#2. Last update exceeded 2 days
https://issues.apache.org/jira/browse/CALCITE-5984
https://issues.apache.org/jira/browse/CALCITE-6052
#3. Last update exceeded 7 days
https://issues.apache.org/jira/browse/CALCITE-5884
https://issues.apache.org/jira/browse/CALCITE-6037
#4. Last update exceeded 14 days
https://issues.apache.org/jira/browse/CALCITE-4455
https://issues.apache.org/jira/browse/CALCITE-5826
On Wed, 25 Oct 2023 at 11:40, Benchao Li <
libenc...@apache.org>
wrote:
Thanks Mihai for the quick response, I'll take a look at
the PR.
Mihai Budiu 于2023年10月25日周三 05:02写道：
For the blocker issues, I have filed two PRs which should
collectively
fix them.
https://github.com/apache/calcite/pull/3481 fixes
https://issues.apache.org/jira/browse/CALCITE-5990, but
does not
include
tests, because the test fixture needs to be fixed as well
for the
tests
to
pass. There are tests in the next PR:
https://github.com/apache/calcite/pull/3471 fixes
https://issues.apache.org/jira/browse/CALCITE-5921, but
should be
amended
to reenable the disabled tests if we merge 3481 first.
Mihai
From: Benchao Li
Sent: Tuesday, October 24, 2023 5:46 AM
To: dev@calcite.apache.org
Subject: Re: [DISCUSS] Towards Calcite 1.36.0
A quick update on the current status for issues targeted
1.36.0
We need more reviewers for #2 and #3 since the end of
October is
approaching.
Please correct me if I'm mistaken, especially for issues
in #1.
#1. Issues already have reviewers,
Re: [DISCUSS] Towards Calcite 1.36.0
I can revert it if that's alright, hope this helps!
Best,
Tanner
On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang
wrote:
> I believe the main branch should still be frozen as we're still voting
> for 1.36.0.
>
> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be reverted
> and then rebased on to main after 1.36.0 has been released.
>
> Francis
>
> On 8/11/2023 12:58 pm, Jiajun Xie wrote:
> > Hi, Benchao
> >
> > Is the main branch still frozen?
> >
> > I found a new commit[1], but 1.36.0 has not been released.
> >
> > [1]
> >
> https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba
> >
> > On Mon, 6 Nov 2023 at 14:59, Benchao Li wrote:
> >
> >> The release note PR is now available for review:
> >> https://github.com/apache/calcite/pull/3505
> >>
> >> Benchao Li 于2023年11月6日周一 12:46写道：
> >>>
> >>> Hi devs,
> >>>
> >>> All the issues targeted for 1.36.0 have been resolved, I'll start the
> >>> release process now. Therefore main branch is in code freeze until
> >>> further notice.
> >>>
> >>> Benchao Li 于2023年11月3日周五 10:50写道：
> >>>>
> >>>> @Mihai @Julian The only left issue is 5884 now, can we merge it and
> >>>> start the releasing process?
> >>>>
> >>>> LakeShen 于2023年11月1日周三 12:13写道：
> >>>>>
> >>>>> Hi Itiel,
> >>>>>
> >>>>> I have reviewd the https://github.com/apache/calcite/pull/3325,and
> >> left one
> >>>>> comments
> >>>>>
> >>>>> Benchao Li 于2023年11月1日周三 10:17写道：
> >>>>>
> >>>>>> Mihai,
> >>>>>> I've reviewed 5884, it looks good and I think we can have it in
> >> 1.36.0
> >>>>>>
> >>>>>> Itiel,
> >>>>>> https://github.com/apache/calcite/pull/3325 has been reviewed and
> >> even
> >>>>>> with an approval, I'll try to ping in the PR to try to get it
> >> merged
> >>>>>> in 1.36.0
> >>>>>>
> >>>>>> Mihai Budiu 于2023年11月1日周三 02:42写道：
> >>>>>>>
> >>>>>>> 5884 is mostly documentation fixes.
> >>>>>>> I expected it would be easy to get it in.
> >>>>>>> But we can leave it for later.
> >>>>>>>
> >>>>>>> Mihai
> >>>>>>>
> >>>>>>>
> >>>>>>> From: Benchao Li
> >>>>>>> Sent: Tuesday, October 31, 2023 6:50 AM
> >>>>>>> To: dev@calcite.apache.org
> >>>>>>> Subject: Re: [DISCUSS] Towards Calcite 1.36.0
> >>>>>>>
> >>>>>>> Due to the inactivity of the review for CALCITE-5884 and
> >> CALCITE-4455,
> >>>>>>> I think we can move it out of 1.36.0 for now. What do you think?
> >>>>>>>
> >>>>>>> Other three issues look promising to be merged soon, then I'll
> >> start
> >>>>>>> the release process after they are merged.
> >>>>>>>
> >>>>>>> Julian Hyde 于2023年10月31日周二 02:31写道：
> >>>>>>>>
> >>>>>>>> I just merged CALCITE-{129,6052}. Five left.
> >>>>>>>>
> >>>>>>>>> On Oct 30, 2023, at 7:22 AM, Ran Tao
> >> wrote:
> >>>>>>>>>
> >>>>>>>>> The expected release time at the end of the month seems to
> >> be coming
> >>>>>> soon.
> >>>>>>>>> I performed an update on the list compiled by Jiajun.
> >>>>>>>>>
> >>>>>>>>> #1.Last update (new comments or commits) within 2 days
> >> (almost
> >>>>>> ready):
> >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-129
> >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5826
> >>>>>>>>>
> >>>>>>>>> #2. Last update exceeded 2 days
> >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5990
> >>>>>>>>> htt
Re: [DISCUSS] Towards Calcite 1.36.0
Yes, it's still frozen until further notice. Thanks Jiajun for
spotting it, and Tanner for volunteering to help revert it.
Tanner Clary 于2023年11月8日周三 10:35写道：
>
> I can revert it if that's alright, hope this helps!
>
> Best,
> Tanner
>
> On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang
> wrote:
>
> > I believe the main branch should still be frozen as we're still voting
> > for 1.36.0.
> >
> > I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be reverted
> > and then rebased on to main after 1.36.0 has been released.
> >
> > Francis
> >
> > On 8/11/2023 12:58 pm, Jiajun Xie wrote:
> > > Hi, Benchao
> > >
> > > Is the main branch still frozen?
> > >
> > > I found a new commit[1], but 1.36.0 has not been released.
> > >
> > > [1]
> > >
> > https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba
> > >
> > > On Mon, 6 Nov 2023 at 14:59, Benchao Li wrote:
> > >
> > >> The release note PR is now available for review:
> > >> https://github.com/apache/calcite/pull/3505
> > >>
> > >> Benchao Li 于2023年11月6日周一 12:46写道：
> > >>>
> > >>> Hi devs,
> > >>>
> > >>> All the issues targeted for 1.36.0 have been resolved, I'll start the
> > >>> release process now. Therefore main branch is in code freeze until
> > >>> further notice.
> > >>>
> > >>> Benchao Li 于2023年11月3日周五 10:50写道：
> > >>>>
> > >>>> @Mihai @Julian The only left issue is 5884 now, can we merge it and
> > >>>> start the releasing process?
> > >>>>
> > >>>> LakeShen 于2023年11月1日周三 12:13写道：
> > >>>>>
> > >>>>> Hi Itiel,
> > >>>>>
> > >>>>> I have reviewd the https://github.com/apache/calcite/pull/3325,and
> > >> left one
> > >>>>> comments
> > >>>>>
> > >>>>> Benchao Li 于2023年11月1日周三 10:17写道：
> > >>>>>
> > >>>>>> Mihai,
> > >>>>>> I've reviewed 5884, it looks good and I think we can have it in
> > >> 1.36.0
> > >>>>>>
> > >>>>>> Itiel,
> > >>>>>> https://github.com/apache/calcite/pull/3325 has been reviewed and
> > >> even
> > >>>>>> with an approval, I'll try to ping in the PR to try to get it
> > >> merged
> > >>>>>> in 1.36.0
> > >>>>>>
> > >>>>>> Mihai Budiu 于2023年11月1日周三 02:42写道：
> > >>>>>>>
> > >>>>>>> 5884 is mostly documentation fixes.
> > >>>>>>> I expected it would be easy to get it in.
> > >>>>>>> But we can leave it for later.
> > >>>>>>>
> > >>>>>>> Mihai
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> From: Benchao Li
> > >>>>>>> Sent: Tuesday, October 31, 2023 6:50 AM
> > >>>>>>> To: dev@calcite.apache.org
> > >>>>>>> Subject: Re: [DISCUSS] Towards Calcite 1.36.0
> > >>>>>>>
> > >>>>>>> Due to the inactivity of the review for CALCITE-5884 and
> > >> CALCITE-4455,
> > >>>>>>> I think we can move it out of 1.36.0 for now. What do you think?
> > >>>>>>>
> > >>>>>>> Other three issues look promising to be merged soon, then I'll
> > >> start
> > >>>>>>> the release process after they are merged.
> > >>>>>>>
> > >>>>>>> Julian Hyde 于2023年10月31日周二 02:31写道：
> > >>>>>>>>
> > >>>>>>>> I just merged CALCITE-{129,6052}. Five left.
> > >>>>>>>>
> > >>>>>>>>> On Oct 30, 2023, at 7:22 AM, Ran Tao
> > >> wrote:
> > >>>>>>>>>
> > >>>>>>>>> The expected release time at the end of the month seems to
> > >> be coming
> > >>>>>> soon.
> > >>>>>>>>> I performed an update on the list compiled by
Re: [DISCUSS] Towards Calcite 1.36.0
The commit reverting 3154708 is here:
https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1
Let me know if I can do anything else to help and thank y'all for handling
the release!
Best,
Tanner
On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary wrote:
> I can revert it if that's alright, hope this helps!
>
> Best,
> Tanner
>
> On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang
> wrote:
>
>> I believe the main branch should still be frozen as we're still voting
>> for 1.36.0.
>>
>> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be reverted
>> and then rebased on to main after 1.36.0 has been released.
>>
>> Francis
>>
>> On 8/11/2023 12:58 pm, Jiajun Xie wrote:
>> > Hi, Benchao
>> >
>> > Is the main branch still frozen?
>> >
>> > I found a new commit[1], but 1.36.0 has not been released.
>> >
>> > [1]
>> >
>> https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba
>> >
>> > On Mon, 6 Nov 2023 at 14:59, Benchao Li wrote:
>> >
>> >> The release note PR is now available for review:
>> >> https://github.com/apache/calcite/pull/3505
>> >>
>> >> Benchao Li 于2023年11月6日周一 12:46写道：
>> >>>
>> >>> Hi devs,
>> >>>
>> >>> All the issues targeted for 1.36.0 have been resolved, I'll start the
>> >>> release process now. Therefore main branch is in code freeze until
>> >>> further notice.
>> >>>
>> >>> Benchao Li 于2023年11月3日周五 10:50写道：
>> >>>>
>> >>>> @Mihai @Julian The only left issue is 5884 now, can we merge it and
>> >>>> start the releasing process?
>> >>>>
>> >>>> LakeShen 于2023年11月1日周三 12:13写道：
>> >>>>>
>> >>>>> Hi Itiel,
>> >>>>>
>> >>>>> I have reviewd the https://github.com/apache/calcite/pull/3325,and
>> >> left one
>> >>>>> comments
>> >>>>>
>> >>>>> Benchao Li 于2023年11月1日周三 10:17写道：
>> >>>>>
>> >>>>>> Mihai,
>> >>>>>> I've reviewed 5884, it looks good and I think we can have it in
>> >> 1.36.0
>> >>>>>>
>> >>>>>> Itiel,
>> >>>>>> https://github.com/apache/calcite/pull/3325 has been reviewed and
>> >> even
>> >>>>>> with an approval, I'll try to ping in the PR to try to get it
>> >> merged
>> >>>>>> in 1.36.0
>> >>>>>>
>> >>>>>> Mihai Budiu 于2023年11月1日周三 02:42写道：
>> >>>>>>>
>> >>>>>>> 5884 is mostly documentation fixes.
>> >>>>>>> I expected it would be easy to get it in.
>> >>>>>>> But we can leave it for later.
>> >>>>>>>
>> >>>>>>> Mihai
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> From: Benchao Li
>> >>>>>>> Sent: Tuesday, October 31, 2023 6:50 AM
>> >>>>>>> To: dev@calcite.apache.org
>> >>>>>>> Subject: Re: [DISCUSS] Towards Calcite 1.36.0
>> >>>>>>>
>> >>>>>>> Due to the inactivity of the review for CALCITE-5884 and
>> >> CALCITE-4455,
>> >>>>>>> I think we can move it out of 1.36.0 for now. What do you think?
>> >>>>>>>
>> >>>>>>> Other three issues look promising to be merged soon, then I'll
>> >> start
>> >>>>>>> the release process after they are merged.
>> >>>>>>>
>> >>>>>>> Julian Hyde 于2023年10月31日周二 02:31写道：
>> >>>>>>>>
>> >>>>>>>> I just merged CALCITE-{129,6052}. Five left.
>> >>>>>>>>
>> >>>>>>>>> On Oct 30, 2023, at 7:22 AM, Ran Tao
>> >> wrote:
>> >>>>>>>>>
>> >>>>>>>>> The expected release time at the end of the month seems to
>> >> be coming
>> >>>>>> soon.
>> >>>>>>>>> I performed an update
Re: [DISCUSS] Towards Calcite 1.36.0
Tanner, By saying "revert", I think we actually mean "reset to earlier commit(https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376), and force push main branch". Because the commit we are voting on is https://github.com/apache/calcite/commit/0be8eaebcf27afae9ecda8ab79db63c214426561, after the voting, I'll push it to main with additional commits preparing for next version, then all the commits after https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 will be invalid. Tanner Clary 于2023年11月8日周三 10:43写道： > > The commit reverting 3154708 is here: > https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 > > Let me know if I can do anything else to help and thank y'all for handling > the release! > > Best, > Tanner > > On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary wrote: > > > I can revert it if that's alright, hope this helps! > > > > Best, > > Tanner > > > > On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang > > wrote: > > > >> I believe the main branch should still be frozen as we're still voting > >> for 1.36.0. > >> > >> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be reverted > >> and then rebased on to main after 1.36.0 has been released. > >> > >> Francis > >> > >> On 8/11/2023 12:58 pm, Jiajun Xie wrote: > >> > Hi, Benchao > >> > > >> > Is the main branch still frozen? > >> > > >> > I found a new commit[1], but 1.36.0 has not been released. > >> > > >> > [1] > >> > > >> https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba > >> > > >> > On Mon, 6 Nov 2023 at 14:59, Benchao Li wrote: > >> > > >> >> The release note PR is now available for review: > >> >> https://github.com/apache/calcite/pull/3505 > >> >> > >> >> Benchao Li 于2023年11月6日周一 12:46写道： > >> >>> > >> >>> Hi devs, > >> >>> > >> >>> All the issues targeted for 1.36.0 have been resolved, I'll start the > >> >>> release process now. Therefore main branch is in code freeze until > >> >>> further notice. > >> >>> > >> >>> Benchao Li 于2023年11月3日周五 10:50写道： > >> >>>> > >> >>>> @Mihai @Julian The only left issue is 5884 now, can we merge it and > >> >>>> start the releasing process? > >> >>>> > >> >>>> LakeShen 于2023年11月1日周三 12:13写道： > >> >>>>> > >> >>>>> Hi Itiel, > >> >>>>> > >> >>>>> I have reviewd the https://github.com/apache/calcite/pull/3325,and > >> >> left one > >> >>>>> comments > >> >>>>> > >> >>>>> Benchao Li 于2023年11月1日周三 10:17写道： > >> >>>>> > >> >>>>>> Mihai, > >> >>>>>> I've reviewed 5884, it looks good and I think we can have it in > >> >> 1.36.0 > >> >>>>>> > >> >>>>>> Itiel, > >> >>>>>> https://github.com/apache/calcite/pull/3325 has been reviewed and > >> >> even > >> >>>>>> with an approval, I'll try to ping in the PR to try to get it > >> >> merged > >> >>>>>> in 1.36.0 > >> >>>>>> > >> >>>>>> Mihai Budiu 于2023年11月1日周三 02:42写道： > >> >>>>>>> > >> >>>>>>> 5884 is mostly documentation fixes. > >> >>>>>>> I expected it would be easy to get it in. > >> >>>>>>> But we can leave it for later. > >> >>>>>>> > >> >>>>>>> Mihai > >> >>>>>>> > >> >>>>>>> > >> >>>>>>> From: Benchao Li > >> >>>>>>> Sent: Tuesday, October 31, 2023 6:50 AM > >> >>>>>>> To: dev@calcite.apache.org > >> >>>>>>> Subject: Re: [DISCUSS] Towards Calcite 1.36.0 > >> >>>>>>> > >> >>>>>>> Due to the inactivity of the review for CALCITE-5884 and > >
Re: [DISCUSS] Towards Calcite 1.36.0
Oops I took revert too literally. I can reset it two commits (the revert commit and the commit I reverted). Sorry for the misunderstanding. Tanner On Tue, Nov 7, 2023 at 6:49 PM Benchao Li wrote: > Tanner, > > By saying "revert", I think we actually mean "reset to earlier > commit( > https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > ), > and force push main branch". Because the commit we are voting on is > > https://github.com/apache/calcite/commit/0be8eaebcf27afae9ecda8ab79db63c214426561 > , > after the voting, I'll push it to main with additional commits > preparing for next version, then all the commits after > > https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > will be invalid. > > Tanner Clary 于2023年11月8日周三 10:43写道： > > > > The commit reverting 3154708 is here: > > > https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 > > > > Let me know if I can do anything else to help and thank y'all for > handling > > the release! > > > > Best, > > Tanner > > > > On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary > wrote: > > > > > I can revert it if that's alright, hope this helps! > > > > > > Best, > > > Tanner > > > > > > On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang < > francischu...@apache.org> > > > wrote: > > > > > >> I believe the main branch should still be frozen as we're still voting > > >> for 1.36.0. > > >> > > >> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be reverted > > >> and then rebased on to main after 1.36.0 has been released. > > >> > > >> Francis > > >> > > >> On 8/11/2023 12:58 pm, Jiajun Xie wrote: > > >> > Hi, Benchao > > >> > > > >> > Is the main branch still frozen? > > >> > > > >> > I found a new commit[1], but 1.36.0 has not been released. > > >> > > > >> > [1] > > >> > > > >> > https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba > > >> > > > >> > On Mon, 6 Nov 2023 at 14:59, Benchao Li > wrote: > > >> > > > >> >> The release note PR is now available for review: > > >> >> https://github.com/apache/calcite/pull/3505 > > >> >> > > >> >> Benchao Li 于2023年11月6日周一 12:46写道： > > >> >>> > > >> >>> Hi devs, > > >> >>> > > >> >>> All the issues targeted for 1.36.0 have been resolved, I'll start > the > > >> >>> release process now. Therefore main branch is in code freeze until > > >> >>> further notice. > > >> >>> > > >> >>> Benchao Li 于2023年11月3日周五 10:50写道： > > >> >>>> > > >> >>>> @Mihai @Julian The only left issue is 5884 now, can we merge it > and > > >> >>>> start the releasing process? > > >> >>>> > > >> >>>> LakeShen 于2023年11月1日周三 12:13写道： > > >> >>>>> > > >> >>>>> Hi Itiel, > > >> >>>>> > > >> >>>>> I have reviewd the > https://github.com/apache/calcite/pull/3325,and > > >> >> left one > > >> >>>>> comments > > >> >>>>> > > >> >>>>> Benchao Li 于2023年11月1日周三 10:17写道： > > >> >>>>> > > >> >>>>>> Mihai, > > >> >>>>>> I've reviewed 5884, it looks good and I think we can have it in > > >> >> 1.36.0 > > >> >>>>>> > > >> >>>>>> Itiel, > > >> >>>>>> https://github.com/apache/calcite/pull/3325 has been reviewed > and > > >> >> even > > >> >>>>>> with an approval, I'll try to ping in the PR to try to get it > > >> >> merged > > >> >>>>>> in 1.36.0 > > >> >>>>>> > > >> >>>>>> Mihai Budiu 于2023年11月1日周三 02:42写道： > > >> >>>>>>> > > >> >>>>>>> 5884 is mostly documentation fixes. > > >> >>>>
Re: [DISCUSS] Towards Calcite 1.36.0
Ok I believe I reset main to https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 . Feel free to take a look at https://github.com/apache/calcite/commits/main and let me know if I've made any mistakes. Sorry for any confusion and thanks for your patience. Best, Tanner On Tue, Nov 7, 2023 at 6:54 PM Tanner Clary wrote: > Oops I took revert too literally. I can reset it two commits (the revert > commit and the commit I reverted). Sorry for the misunderstanding. > > Tanner > > On Tue, Nov 7, 2023 at 6:49 PM Benchao Li wrote: > >> Tanner, >> >> By saying "revert", I think we actually mean "reset to earlier >> commit( >> https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 >> ), >> and force push main branch". Because the commit we are voting on is >> >> https://github.com/apache/calcite/commit/0be8eaebcf27afae9ecda8ab79db63c214426561 >> , >> after the voting, I'll push it to main with additional commits >> preparing for next version, then all the commits after >> >> https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 >> will be invalid. >> >> Tanner Clary 于2023年11月8日周三 10:43写道： >> > >> > The commit reverting 3154708 is here: >> > >> https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 >> > >> > Let me know if I can do anything else to help and thank y'all for >> handling >> > the release! >> > >> > Best, >> > Tanner >> > >> > On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary >> wrote: >> > >> > > I can revert it if that's alright, hope this helps! >> > > >> > > Best, >> > > Tanner >> > > >> > > On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang < >> francischu...@apache.org> >> > > wrote: >> > > >> > >> I believe the main branch should still be frozen as we're still >> voting >> > >> for 1.36.0. >> > >> >> > >> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be reverted >> > >> and then rebased on to main after 1.36.0 has been released. >> > >> >> > >> Francis >> > >> >> > >> On 8/11/2023 12:58 pm, Jiajun Xie wrote: >> > >> > Hi, Benchao >> > >> > >> > >> > Is the main branch still frozen? >> > >> > >> > >> > I found a new commit[1], but 1.36.0 has not been released. >> > >> > >> > >> > [1] >> > >> > >> > >> >> https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba >> > >> > >> > >> > On Mon, 6 Nov 2023 at 14:59, Benchao Li >> wrote: >> > >> > >> > >> >> The release note PR is now available for review: >> > >> >> https://github.com/apache/calcite/pull/3505 >> > >> >> >> > >> >> Benchao Li 于2023年11月6日周一 12:46写道： >> > >> >>> >> > >> >>> Hi devs, >> > >> >>> >> > >> >>> All the issues targeted for 1.36.0 have been resolved, I'll >> start the >> > >> >>> release process now. Therefore main branch is in code freeze >> until >> > >> >>> further notice. >> > >> >>> >> > >> >>> Benchao Li 于2023年11月3日周五 10:50写道： >> > >> >>>> >> > >> >>>> @Mihai @Julian The only left issue is 5884 now, can we merge it >> and >> > >> >>>> start the releasing process? >> > >> >>>> >> > >> >>>> LakeShen 于2023年11月1日周三 12:13写道： >> > >> >>>>> >> > >> >>>>> Hi Itiel, >> > >> >>>>> >> > >> >>>>> I have reviewd the >> https://github.com/apache/calcite/pull/3325,and >> > >> >> left one >> > >> >>>>> comments >> > >> >>>>> >> > >> >>>>> Benchao Li 于2023年11月1日周三 10:17写道： >> > >> >>>>> >> > >> >>>>>> Mihai, >> > >> >>>>>> I've reviewed 5884, it looks good and I think we can have it &g
Re: [DISCUSS] Towards Calcite 1.36.0
Looks great, Tanner!
As the original PR has been merged and cannot be reopened, let's
remember to rebase the commit onto main after 1.36.0 has been released.
On 8/11/2023 1:58 pm, Tanner Clary wrote:
Ok I believe I reset main to
https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376
.
Feel free to take a look at https://github.com/apache/calcite/commits/main
and let me know if I've made any mistakes. Sorry for any confusion and
thanks for your patience.
Best,
Tanner
On Tue, Nov 7, 2023 at 6:54 PM Tanner Clary wrote:
Oops I took revert too literally. I can reset it two commits (the revert
commit and the commit I reverted). Sorry for the misunderstanding.
Tanner
On Tue, Nov 7, 2023 at 6:49 PM Benchao Li wrote:
Tanner,
By saying "revert", I think we actually mean "reset to earlier
commit(
https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376
),
and force push main branch". Because the commit we are voting on is
https://github.com/apache/calcite/commit/0be8eaebcf27afae9ecda8ab79db63c214426561
,
after the voting, I'll push it to main with additional commits
preparing for next version, then all the commits after
https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376
will be invalid.
Tanner Clary 于2023年11月8日周三 10:43写道：
The commit reverting 3154708 is here:
https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1
Let me know if I can do anything else to help and thank y'all for
handling
the release!
Best,
Tanner
On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary
wrote:
I can revert it if that's alright, hope this helps!
Best,
Tanner
On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang <
francischu...@apache.org>
wrote:
I believe the main branch should still be frozen as we're still
voting
for 1.36.0.
I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be reverted
and then rebased on to main after 1.36.0 has been released.
Francis
On 8/11/2023 12:58 pm, Jiajun Xie wrote:
Hi, Benchao
Is the main branch still frozen?
I found a new commit[1], but 1.36.0 has not been released.
[1]
https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba
On Mon, 6 Nov 2023 at 14:59, Benchao Li
wrote:
The release note PR is now available for review:
https://github.com/apache/calcite/pull/3505
Benchao Li 于2023年11月6日周一 12:46写道：
Hi devs,
All the issues targeted for 1.36.0 have been resolved, I'll
start the
release process now. Therefore main branch is in code freeze
until
further notice.
Benchao Li 于2023年11月3日周五 10:50写道：
@Mihai @Julian The only left issue is 5884 now, can we merge it
and
start the releasing process?
LakeShen 于2023年11月1日周三 12:13写道：
Hi Itiel,
I have reviewd the
https://github.com/apache/calcite/pull/3325,and
left one
comments
Benchao Li 于2023年11月1日周三 10:17写道：
Mihai,
I've reviewed 5884, it looks good and I think we can have it
in
1.36.0
Itiel,
https://github.com/apache/calcite/pull/3325 has been
reviewed and
even
with an approval, I'll try to ping in the PR to try to get it
merged
in 1.36.0
Mihai Budiu 于2023年11月1日周三 02:42写道：
5884 is mostly documentation fixes.
I expected it would be easy to get it in.
But we can leave it for later.
Mihai
From: Benchao Li
Sent: Tuesday, October 31, 2023 6:50 AM
To: dev@calcite.apache.org
Subject: Re: [DISCUSS] Towards Calcite 1.36.0
Due to the inactivity of the review for CALCITE-5884 and
CALCITE-4455,
I think we can move it out of 1.36.0 for now. What do you
think?
Other three issues look promising to be merged soon, then
I'll
start
the release process after they are merged.
Julian Hyde 于2023年10月31日周二 02:31写道：
I just merged CALCITE-{129,6052}. Five left.
On Oct 30, 2023, at 7:22 AM, Ran Tao <
chucheng...@gmail.com>
wrote:
The expected release time at the end of the month seems to
be coming
soon.
I performed an update on the list compiled by Jiajun.
#1.Last update (new comments or commits) within 2 days
(almost
ready):
https://issues.apache.org/jira/browse/CALCITE-129
https://issues.apache.org/jira/browse/CALCITE-5826
#2. Last update exceeded 2 days
https://issues.apache.org/jira/browse/CALCITE-5990
https://issues.apache.org/jira/browse/CALCITE-5984
https://issues.apache.org/jira/browse/CALCITE-6052
#3. Last update exceeded 7 days
https://issues.apache.org/jira/browse/CALCITE-5884
https://issues.apache.org/jira/browse/CALCITE-4455
Best Regards,
Ran Tao
Jiajun Xie 于2023年10月28日周六
13:34写道：
Hi, all:
We're already very close to 1.36.0, all unresolved issues
has been
someone
reviewed.
https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
- Some issues are currently being reviewed.
That's great! Thank you all fo
Re: [DISCUSS] Towards Calcite 1.36.0
Sounds good, I'll keep track of that and make sure it gets rebased. On Tue, Nov 7, 2023 at 7:01 PM Francis Chuang wrote: > Looks great, Tanner! > > As the original PR has been merged and cannot be reopened, let's > remember to rebase the commit onto main after 1.36.0 has been released. > > On 8/11/2023 1:58 pm, Tanner Clary wrote: > > Ok I believe I reset main to > > > https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > > . > > Feel free to take a look at > https://github.com/apache/calcite/commits/main > > and let me know if I've made any mistakes. Sorry for any confusion and > > thanks for your patience. > > > > Best, > > Tanner > > > > On Tue, Nov 7, 2023 at 6:54 PM Tanner Clary > wrote: > > > >> Oops I took revert too literally. I can reset it two commits (the revert > >> commit and the commit I reverted). Sorry for the misunderstanding. > >> > >> Tanner > >> > >> On Tue, Nov 7, 2023 at 6:49 PM Benchao Li wrote: > >> > >>> Tanner, > >>> > >>> By saying "revert", I think we actually mean "reset to earlier > >>> commit( > >>> > https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > >>> ), > >>> and force push main branch". Because the commit we are voting on is > >>> > >>> > https://github.com/apache/calcite/commit/0be8eaebcf27afae9ecda8ab79db63c214426561 > >>> , > >>> after the voting, I'll push it to main with additional commits > >>> preparing for next version, then all the commits after > >>> > >>> > https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > >>> will be invalid. > >>> > >>> Tanner Clary 于2023年11月8日周三 10:43写道： > >>>> > >>>> The commit reverting 3154708 is here: > >>>> > >>> > https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 > >>>> > >>>> Let me know if I can do anything else to help and thank y'all for > >>> handling > >>>> the release! > >>>> > >>>> Best, > >>>> Tanner > >>>> > >>>> On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary > >>> wrote: > >>>> > >>>>> I can revert it if that's alright, hope this helps! > >>>>> > >>>>> Best, > >>>>> Tanner > >>>>> > >>>>> On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang < > >>> francischu...@apache.org> > >>>>> wrote: > >>>>> > >>>>>> I believe the main branch should still be frozen as we're still > >>> voting > >>>>>> for 1.36.0. > >>>>>> > >>>>>> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be > reverted > >>>>>> and then rebased on to main after 1.36.0 has been released. > >>>>>> > >>>>>> Francis > >>>>>> > >>>>>> On 8/11/2023 12:58 pm, Jiajun Xie wrote: > >>>>>>> Hi, Benchao > >>>>>>> > >>>>>>> Is the main branch still frozen? > >>>>>>> > >>>>>>> I found a new commit[1], but 1.36.0 has not been released. > >>>>>>> > >>>>>>> [1] > >>>>>>> > >>>>>> > >>> > https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba > >>>>>>> > >>>>>>> On Mon, 6 Nov 2023 at 14:59, Benchao Li > >>> wrote: > >>>>>>> > >>>>>>>> The release note PR is now available for review: > >>>>>>>> https://github.com/apache/calcite/pull/3505 > >>>>>>>> > >>>>>>>> Benchao Li 于2023年11月6日周一 12:46写道： > >>>>>>>>> > >>>>>>>>> Hi devs, > >>>>>>>>> > >>>>>>>>> All the issues targeted for 1.36.0 have been resolved, I'll > >>> start the > >>>>>>>>> release process now. Therefore main branch is in code freeze > >>> until > >>>>>&
Re: [DISCUSS] Towards Calcite 1.36.0
;>> > > >>> > > https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 > > >>>> > > >>>> Let me know if I can do anything else to help and thank y'all for > > >>> handling > > >>>> the release! > > >>>> > > >>>> Best, > > >>>> Tanner > > >>>> > > >>>> On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary > > >>> wrote: > > >>>> > > >>>>> I can revert it if that's alright, hope this helps! > > >>>>> > > >>>>> Best, > > >>>>> Tanner > > >>>>> > > >>>>> On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang < > > >>> francischu...@apache.org> > > >>>>> wrote: > > >>>>> > > >>>>>> I believe the main branch should still be frozen as we're still > > >>> voting > > >>>>>> for 1.36.0. > > >>>>>> > > >>>>>> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be > > reverted > > >>>>>> and then rebased on to main after 1.36.0 has been released. > > >>>>>> > > >>>>>> Francis > > >>>>>> > > >>>>>> On 8/11/2023 12:58 pm, Jiajun Xie wrote: > > >>>>>>> Hi, Benchao > > >>>>>>> > > >>>>>>> Is the main branch still frozen? > > >>>>>>> > > >>>>>>> I found a new commit[1], but 1.36.0 has not been released. > > >>>>>>> > > >>>>>>> [1] > > >>>>>>> > > >>>>>> > > >>> > > https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba > > >>>>>>> > > >>>>>>> On Mon, 6 Nov 2023 at 14:59, Benchao Li > > >>> wrote: > > >>>>>>> > > >>>>>>>> The release note PR is now available for review: > > >>>>>>>> https://github.com/apache/calcite/pull/3505 > > >>>>>>>> > > >>>>>>>> Benchao Li 于2023年11月6日周一 12:46写道： > > >>>>>>>>> > > >>>>>>>>> Hi devs, > > >>>>>>>>> > > >>>>>>>>> All the issues targeted for 1.36.0 have been resolved, I'll > > >>> start the > > >>>>>>>>> release process now. Therefore main branch is in code freeze > > >>> until > > >>>>>>>>> further notice. > > >>>>>>>>> > > >>>>>>>>> Benchao Li 于2023年11月3日周五 10:50写道： > > >>>>>>>>>> > > >>>>>>>>>> @Mihai @Julian The only left issue is 5884 now, can we merge it > > >>> and > > >>>>>>>>>> start the releasing process? > > >>>>>>>>>> > > >>>>>>>>>> LakeShen 于2023年11月1日周三 12:13写道： > > >>>>>>>>>>> > > >>>>>>>>>>> Hi Itiel, > > >>>>>>>>>>> > > >>>>>>>>>>> I have reviewd the > > >>> https://github.com/apache/calcite/pull/3325,and > > >>>>>>>> left one > > >>>>>>>>>>> comments > > >>>>>>>>>>> > > >>>>>>>>>>> Benchao Li 于2023年11月1日周三 10:17写道： > > >>>>>>>>>>> > > >>>>>>>>>>>> Mihai, > > >>>>>>>>>>>> I've reviewed 5884, it looks good and I think we can have it > > >>> in > > >>>>>>>> 1.36.0 > > >>>>>>>>>>>> > > >>>>>>>>>>>> Itiel, > > >>>>>>>>>>>> https://github.com/apache/calcite/pull/3325 has been > > >>> reviewed and > > >>>>>>>> even > > >>>>>>>>>>>> with an
Re: [DISCUSS] Towards Calcite 1.36.0
commit[1], but 1.36.0 has not been released.
[1]
https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba
On Mon, 6 Nov 2023 at 14:59, Benchao Li
wrote:
The release note PR is now available for review:
https://github.com/apache/calcite/pull/3505
Benchao Li 于2023年11月6日周一 12:46写道：
Hi devs,
All the issues targeted for 1.36.0 have been resolved, I'll
start the
release process now. Therefore main branch is in code freeze
until
further notice.
Benchao Li 于2023年11月3日周五 10:50写道：
@Mihai @Julian The only left issue is 5884 now, can we merge it
and
start the releasing process?
LakeShen 于2023年11月1日周三 12:13写道：
Hi Itiel,
I have reviewd the
https://github.com/apache/calcite/pull/3325,and
left one
comments
Benchao Li 于2023年11月1日周三 10:17写道：
Mihai,
I've reviewed 5884, it looks good and I think we can have it
in
1.36.0
Itiel,
https://github.com/apache/calcite/pull/3325 has been
reviewed and
even
with an approval, I'll try to ping in the PR to try to get it
merged
in 1.36.0
Mihai Budiu 于2023年11月1日周三 02:42写道：
5884 is mostly documentation fixes.
I expected it would be easy to get it in.
But we can leave it for later.
Mihai
____________
From: Benchao Li
Sent: Tuesday, October 31, 2023 6:50 AM
To: dev@calcite.apache.org
Subject: Re: [DISCUSS] Towards Calcite 1.36.0
Due to the inactivity of the review for CALCITE-5884 and
CALCITE-4455,
I think we can move it out of 1.36.0 for now. What do you
think?
Other three issues look promising to be merged soon, then
I'll
start
the release process after they are merged.
Julian Hyde 于2023年10月31日周二 02:31写道：
I just merged CALCITE-{129,6052}. Five left.
On Oct 30, 2023, at 7:22 AM, Ran Tao <
chucheng...@gmail.com>
wrote:
The expected release time at the end of the month seems to
be coming
soon.
I performed an update on the list compiled by Jiajun.
#1.Last update (new comments or commits) within 2 days
(almost
ready):
https://issues.apache.org/jira/browse/CALCITE-129
https://issues.apache.org/jira/browse/CALCITE-5826
#2. Last update exceeded 2 days
https://issues.apache.org/jira/browse/CALCITE-5990
https://issues.apache.org/jira/browse/CALCITE-5984
https://issues.apache.org/jira/browse/CALCITE-6052
#3. Last update exceeded 7 days
https://issues.apache.org/jira/browse/CALCITE-5884
https://issues.apache.org/jira/browse/CALCITE-4455
Best Regards,
Ran Tao
Jiajun Xie 于2023年10月28日周六
13:34写道：
Hi, all:
We're already very close to 1.36.0, all unresolved issues
has been
someone
reviewed.
https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
- Some issues are currently being reviewed.
That's great! Thank you all for your efforts.
- Some issues have not been updated for a long time.
If anyone is willing to continue the review, I believe
they
should
be
resolved soon.
#1.Last update (new comments or commits) within 2 days:
https://issues.apache.org/jira/browse/CALCITE-129
https://issues.apache.org/jira/browse/CALCITE-5990
#2. Last update exceeded 2 days
https://issues.apache.org/jira/browse/CALCITE-5984
https://issues.apache.org/jira/browse/CALCITE-6052
#3. Last update exceeded 7 days
https://issues.apache.org/jira/browse/CALCITE-5884
https://issues.apache.org/jira/browse/CALCITE-6037
#4. Last update exceeded 14 days
https://issues.apache.org/jira/browse/CALCITE-4455
https://issues.apache.org/jira/browse/CALCITE-5826
On Wed, 25 Oct 2023 at 11:40, Benchao Li <
libenc...@apache.org>
wrote:
Thanks Mihai for the quick response, I'll take a look at
the PR.
Mihai Budiu 于2023年10月25日周三 05:02写道：
For the blocker issues, I have filed two PRs which
should
collectively
fix them.
https://github.com/apache/calcite/pull/3481 fixes
https://issues.apache.org/jira/browse/CALCITE-5990, but
does not
include
tests, because the test fixture needs to be fixed as well
for the
tests
to
pass. There are tests in the next PR:
https://github.com/apache/calcite/pull/3471 fixes
https://issues.apache.org/jira/browse/CALCITE-5921, but
should be
amended
to reenable the disabled tests if we merge 3481 first.
Mihai
________
From: Benchao Li
Sent: Tuesday, October 24, 2023 5:46 AM
To: dev@calcite.apache.org
Subject: Re: [DISCUSS] Towards Calcite 1.36.0
A quick update on the current status for issues targeted
1.36.0
We need more reviewers for #2 and #3 since the end of
October is
approaching.
Please correct me if I'm mistaken, especially for issues
in #1.
#1. Issues already have reviewers, and seems promising
to
be
merged
shortly
https://issues.apache.org/jira/browse/CALCITE-5884
https://issues.apache.org/jira/browse/CALCITE-5918
https://issues.apache.org/jira/browse/CALCITE-5860
https://issues.apache.org/jira/browse/CALCITE-6011
https://issues.apache.org/jira/browse/CALCIT
Re: [DISCUSS] Towards Calcite 1.36.0
revert > >>>>> commit and the commit I reverted). Sorry for the misunderstanding. > >>>>> > >>>>> Tanner > >>>>> > >>>>> On Tue, Nov 7, 2023 at 6:49 PM Benchao Li wrote: > >>>>> > >>>>>> Tanner, > >>>>>> > >>>>>> By saying "revert", I think we actually mean "reset to earlier > >>>>>> commit( > >>>>>> > >>> https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > >>>>>> ), > >>>>>> and force push main branch". Because the commit we are voting on is > >>>>>> > >>>>>> > >>> https://github.com/apache/calcite/commit/0be8eaebcf27afae9ecda8ab79db63c214426561 > >>>>>> , > >>>>>> after the voting, I'll push it to main with additional commits > >>>>>> preparing for next version, then all the commits after > >>>>>> > >>>>>> > >>> https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > >>>>>> will be invalid. > >>>>>> > >>>>>> Tanner Clary 于2023年11月8日周三 10:43写道： > >>>>>>> > >>>>>>> The commit reverting 3154708 is here: > >>>>>>> > >>>>>> > >>> https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 > >>>>>>> > >>>>>>> Let me know if I can do anything else to help and thank y'all for > >>>>>> handling > >>>>>>> the release! > >>>>>>> > >>>>>>> Best, > >>>>>>> Tanner > >>>>>>> > >>>>>>> On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary > >>>>>> wrote: > >>>>>>> > >>>>>>>> I can revert it if that's alright, hope this helps! > >>>>>>>> > >>>>>>>> Best, > >>>>>>>> Tanner > >>>>>>>> > >>>>>>>> On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang < > >>>>>> francischu...@apache.org> > >>>>>>>> wrote: > >>>>>>>> > >>>>>>>>> I believe the main branch should still be frozen as we're still > >>>>>> voting > >>>>>>>>> for 1.36.0. > >>>>>>>>> > >>>>>>>>> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be > >>> reverted > >>>>>>>>> and then rebased on to main after 1.36.0 has been released. > >>>>>>>>> > >>>>>>>>> Francis > >>>>>>>>> > >>>>>>>>> On 8/11/2023 12:58 pm, Jiajun Xie wrote: > >>>>>>>>>> Hi, Benchao > >>>>>>>>>> > >>>>>>>>>> Is the main branch still frozen? > >>>>>>>>>> > >>>>>>>>>> I found a new commit[1], but 1.36.0 has not been released. > >>>>>>>>>> > >>>>>>>>>> [1] > >>>>>>>>>> > >>>>>>>>> > >>>>>> > >>> https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba > >>>>>>>>>> > >>>>>>>>>> On Mon, 6 Nov 2023 at 14:59, Benchao Li > >>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> The release note PR is now available for review: > >>>>>>>>>>> https://github.com/apache/calcite/pull/3505 > >>>>>>>>>>> > >>>>>>>>>>> Benchao Li 于2023年11月6日周一 12:46写道： > >>>>>>>>>>>> > >>>>>>>>>>>> Hi devs, > >>>>>>>>>>>> > >>>>>>>>>>>> All the issues targeted for 1.36.0 have been resolved, I'll > >>>>>> start the > >>>>>>>>>
Re: [DISCUSS] Towards Calcite 1.36.0
here:
https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1
Let me know if I can do anything else to help and thank y'all for
handling
the release!
Best,
Tanner
On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary
wrote:
I can revert it if that's alright, hope this helps!
Best,
Tanner
On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang <
francischu...@apache.org>
wrote:
I believe the main branch should still be frozen as we're still
voting
for 1.36.0.
I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be
reverted
and then rebased on to main after 1.36.0 has been released.
Francis
On 8/11/2023 12:58 pm, Jiajun Xie wrote:
Hi, Benchao
Is the main branch still frozen?
I found a new commit[1], but 1.36.0 has not been released.
[1]
https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba
On Mon, 6 Nov 2023 at 14:59, Benchao Li
wrote:
The release note PR is now available for review:
https://github.com/apache/calcite/pull/3505
Benchao Li 于2023年11月6日周一 12:46写道：
Hi devs,
All the issues targeted for 1.36.0 have been resolved, I'll
start the
release process now. Therefore main branch is in code freeze
until
further notice.
Benchao Li 于2023年11月3日周五 10:50写道：
@Mihai @Julian The only left issue is 5884 now, can we merge it
and
start the releasing process?
LakeShen 于2023年11月1日周三 12:13写道：
Hi Itiel,
I have reviewd the
https://github.com/apache/calcite/pull/3325,and
left one
comments
Benchao Li 于2023年11月1日周三 10:17写道：
Mihai,
I've reviewed 5884, it looks good and I think we can have it
in
1.36.0
Itiel,
https://github.com/apache/calcite/pull/3325 has been
reviewed and
even
with an approval, I'll try to ping in the PR to try to get it
merged
in 1.36.0
Mihai Budiu 于2023年11月1日周三 02:42写道：
5884 is mostly documentation fixes.
I expected it would be easy to get it in.
But we can leave it for later.
Mihai
____________________
From: Benchao Li
Sent: Tuesday, October 31, 2023 6:50 AM
To: dev@calcite.apache.org
Subject: Re: [DISCUSS] Towards Calcite 1.36.0
Due to the inactivity of the review for CALCITE-5884 and
CALCITE-4455,
I think we can move it out of 1.36.0 for now. What do you
think?
Other three issues look promising to be merged soon, then
I'll
start
the release process after they are merged.
Julian Hyde 于2023年10月31日周二 02:31写道：
I just merged CALCITE-{129,6052}. Five left.
On Oct 30, 2023, at 7:22 AM, Ran Tao <
chucheng...@gmail.com>
wrote:
The expected release time at the end of the month seems to
be coming
soon.
I performed an update on the list compiled by Jiajun.
#1.Last update (new comments or commits) within 2 days
(almost
ready):
https://issues.apache.org/jira/browse/CALCITE-129
https://issues.apache.org/jira/browse/CALCITE-5826
#2. Last update exceeded 2 days
https://issues.apache.org/jira/browse/CALCITE-5990
https://issues.apache.org/jira/browse/CALCITE-5984
https://issues.apache.org/jira/browse/CALCITE-6052
#3. Last update exceeded 7 days
https://issues.apache.org/jira/browse/CALCITE-5884
https://issues.apache.org/jira/browse/CALCITE-4455
Best Regards,
Ran Tao
Jiajun Xie 于2023年10月28日周六
13:34写道：
Hi, all:
We're already very close to 1.36.0, all unresolved issues
has been
someone
reviewed.
https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
- Some issues are currently being reviewed.
That's great! Thank you all for your efforts.
- Some issues have not been updated for a long time.
If anyone is willing to continue the review, I believe
they
should
be
resolved soon.
#1.Last update (new comments or commits) within 2 days:
https://issues.apache.org/jira/browse/CALCITE-129
https://issues.apache.org/jira/browse/CALCITE-5990
#2. Last update exceeded 2 days
https://issues.apache.org/jira/browse/CALCITE-5984
https://issues.apache.org/jira/browse/CALCITE-6052
#3. Last update exceeded 7 days
https://issues.apache.org/jira/browse/CALCITE-5884
https://issues.apache.org/jira/browse/CALCITE-6037
#4. Last update exceeded 14 days
https://issues.apache.org/jira/browse/CALCITE-4455
https://issues.apache.org/jira/browse/CALCITE-5826
On Wed, 25 Oct 2023 at 11:40, Benchao Li <
libenc...@apache.org>
wrote:
Thanks Mihai for the quick response, I'll take a look at
the PR.
Mihai Budiu 于2023年10月25日周三 05:02写道：
For the blocker issues, I have filed two PRs which
should
collectively
fix them.
https://github.com/apache/calcite/pull/3481 fixes
https://issues.apache.org/jira/browse/CALCITE-5990, but
does not
include
tests, because the test fixture needs to be fixed as well
for the
tests
to
pass. There are tests in the next PR:
https://github.com/apache/calcite/pull/3471 fixes
https://issues.apache.org/jira/browse/CALCITE-5921, but
should be
amended
to reenable the disabl
Re: [DISCUSS] Towards Calcite 1.36.0
e > >>> > >>> Tanner Clary 于2023年11月8日周三 11:18写道： > >>>> > >>>> Sounds good, I'll keep track of that and make sure it gets rebased. > >>>> > >>>> On Tue, Nov 7, 2023 at 7:01 PM Francis Chuang > >>>> wrote: > >>>> > >>>>> Looks great, Tanner! > >>>>> > >>>>> As the original PR has been merged and cannot be reopened, let's > >>>>> remember to rebase the commit onto main after 1.36.0 has been released. > >>>>> > >>>>> On 8/11/2023 1:58 pm, Tanner Clary wrote: > >>>>>> Ok I believe I reset main to > >>>>>> > >>>>> https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > >>>>>> . > >>>>>> Feel free to take a look at > >>>>> https://github.com/apache/calcite/commits/main > >>>>>> and let me know if I've made any mistakes. Sorry for any confusion and > >>>>>> thanks for your patience. > >>>>>> > >>>>>> Best, > >>>>>> Tanner > >>>>>> > >>>>>> On Tue, Nov 7, 2023 at 6:54 PM Tanner Clary > >>>>> wrote: > >>>>>> > >>>>>>> Oops I took revert too literally. I can reset it two commits (the > >>>>>>> revert > >>>>>>> commit and the commit I reverted). Sorry for the misunderstanding. > >>>>>>> > >>>>>>> Tanner > >>>>>>> > >>>>>>> On Tue, Nov 7, 2023 at 6:49 PM Benchao Li > >>>>>>> wrote: > >>>>>>> > >>>>>>>> Tanner, > >>>>>>>> > >>>>>>>> By saying "revert", I think we actually mean "reset to earlier > >>>>>>>> commit( > >>>>>>>> > >>>>> https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > >>>>>>>> ), > >>>>>>>> and force push main branch". Because the commit we are voting on is > >>>>>>>> > >>>>>>>> > >>>>> https://github.com/apache/calcite/commit/0be8eaebcf27afae9ecda8ab79db63c214426561 > >>>>>>>> , > >>>>>>>> after the voting, I'll push it to main with additional commits > >>>>>>>> preparing for next version, then all the commits after > >>>>>>>> > >>>>>>>> > >>>>> https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > >>>>>>>> will be invalid. > >>>>>>>> > >>>>>>>> Tanner Clary 于2023年11月8日周三 10:43写道： > >>>>>>>>> > >>>>>>>>> The commit reverting 3154708 is here: > >>>>>>>>> > >>>>>>>> > >>>>> https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 > >>>>>>>>> > >>>>>>>>> Let me know if I can do anything else to help and thank y'all for > >>>>>>>> handling > >>>>>>>>> the release! > >>>>>>>>> > >>>>>>>>> Best, > >>>>>>>>> Tanner > >>>>>>>>> > >>>>>>>>> On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary > >>>>>>>> wrote: > >>>>>>>>> > >>>>>>>>>> I can revert it if that's alright, hope this helps! > >>>>>>>>>> > >>>>>>>>>> Best, > >>>>>>>>>> Tanner > >>>>>>>>>> > >>>>>>>>>> On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang < > >>>>>>>> francischu...@apache.org> > >>>>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> I believe the main branch should still be frozen as we're still > >>>>>>>> voting > >>>>>>>>&
Re: [DISCUSS] Towards Calcite 1.36.0
ng > > >>>>>>>>> the release! > > >>>>>>>>> > > >>>>>>>>> Best, > > >>>>>>>>> Tanner > > >>>>>>>>> > > >>>>>>>>> On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary > > >>>>>>>>> > > >>>>>>>> wrote: > > >>>>>>>>> > > >>>>>>>>>> I can revert it if that's alright, hope this helps! > > >>>>>>>>>> > > >>>>>>>>>> Best, > > >>>>>>>>>> Tanner > > >>>>>>>>>> > > >>>>>>>>>> On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang < > > >>>>>>>> francischu...@apache.org> > > >>>>>>>>>> wrote: > > >>>>>>>>>> > > >>>>>>>>>>> I believe the main branch should still be frozen as we're still > > >>>>>>>> voting > > >>>>>>>>>>> for 1.36.0. > > >>>>>>>>>>> > > >>>>>>>>>>> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be > > >>>>> reverted > > >>>>>>>>>>> and then rebased on to main after 1.36.0 has been released. > > >>>>>>>>>>> > > >>>>>>>>>>> Francis > > >>>>>>>>>>> > > >>>>>>>>>>> On 8/11/2023 12:58 pm, Jiajun Xie wrote: > > >>>>>>>>>>>> Hi, Benchao > > >>>>>>>>>>>> > > >>>>>>>>>>>> Is the main branch still frozen? > > >>>>>>>>>>>> > > >>>>>>>>>>>> I found a new commit[1], but 1.36.0 has not been released. > > >>>>>>>>>>>> > > >>>>>>>>>>>> [1] > > >>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>> > > >>>>> https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba > > >>>>>>>>>>>> > > >>>>>>>>>>>> On Mon, 6 Nov 2023 at 14:59, Benchao Li > > >>>>>>>> wrote: > > >>>>>>>>>>>> > > >>>>>>>>>>>>> The release note PR is now available for review: > > >>>>>>>>>>>>> https://github.com/apache/calcite/pull/3505 > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Benchao Li 于2023年11月6日周一 12:46写道： > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Hi devs, > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> All the issues targeted for 1.36.0 have been resolved, I'll > > >>>>>>>> start the > > >>>>>>>>>>>>>> release process now. Therefore main branch is in code freeze > > >>>>>>>> until > > >>>>>>>>>>>>>> further notice. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Benchao Li 于2023年11月3日周五 10:50写道： > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> @Mihai @Julian The only left issue is 5884 now, can we > > >>>>>>>>>>>>>>> merge it > > >>>>>>>> and > > >>>>>>>>>>>>>>> start the releasing process? > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> LakeShen 于2023年11月1日周三 12:13写道： > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> Hi Itiel, > > >>>>>>
Re: [DISCUSS] Towards Calcite 1.36.0
426561
,
after the voting, I'll push it to main with additional commits
preparing for next version, then all the commits after
https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376
will be invalid.
Tanner Clary 于2023年11月8日周三 10:43写道：
The commit reverting 3154708 is here:
https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1
Let me know if I can do anything else to help and thank y'all for
handling
the release!
Best,
Tanner
On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary
wrote:
I can revert it if that's alright, hope this helps!
Best,
Tanner
On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang <
francischu...@apache.org>
wrote:
I believe the main branch should still be frozen as we're still
voting
for 1.36.0.
I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be
reverted
and then rebased on to main after 1.36.0 has been released.
Francis
On 8/11/2023 12:58 pm, Jiajun Xie wrote:
Hi, Benchao
Is the main branch still frozen?
I found a new commit[1], but 1.36.0 has not been released.
[1]
https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba
On Mon, 6 Nov 2023 at 14:59, Benchao Li
wrote:
The release note PR is now available for review:
https://github.com/apache/calcite/pull/3505
Benchao Li 于2023年11月6日周一 12:46写道：
Hi devs,
All the issues targeted for 1.36.0 have been resolved, I'll
start the
release process now. Therefore main branch is in code freeze
until
further notice.
Benchao Li 于2023年11月3日周五 10:50写道：
@Mihai @Julian The only left issue is 5884 now, can we merge it
and
start the releasing process?
LakeShen 于2023年11月1日周三 12:13写道：
Hi Itiel,
I have reviewd the
https://github.com/apache/calcite/pull/3325,and
left one
comments
Benchao Li 于2023年11月1日周三 10:17写道：
Mihai,
I've reviewed 5884, it looks good and I think we can have it
in
1.36.0
Itiel,
https://github.com/apache/calcite/pull/3325 has been
reviewed and
even
with an approval, I'll try to ping in the PR to try to get it
merged
in 1.36.0
Mihai Budiu 于2023年11月1日周三 02:42写道：
5884 is mostly documentation fixes.
I expected it would be easy to get it in.
But we can leave it for later.
Mihai
________________
From: Benchao Li
Sent: Tuesday, October 31, 2023 6:50 AM
To: dev@calcite.apache.org
Subject: Re: [DISCUSS] Towards Calcite 1.36.0
Due to the inactivity of the review for CALCITE-5884 and
CALCITE-4455,
I think we can move it out of 1.36.0 for now. What do you
think?
Other three issues look promising to be merged soon, then
I'll
start
the release process after they are merged.
Julian Hyde 于2023年10月31日周二 02:31写道：
I just merged CALCITE-{129,6052}. Five left.
On Oct 30, 2023, at 7:22 AM, Ran Tao <
chucheng...@gmail.com>
wrote:
The expected release time at the end of the month seems to
be coming
soon.
I performed an update on the list compiled by Jiajun.
#1.Last update (new comments or commits) within 2 days
(almost
ready):
https://issues.apache.org/jira/browse/CALCITE-129
https://issues.apache.org/jira/browse/CALCITE-5826
#2. Last update exceeded 2 days
https://issues.apache.org/jira/browse/CALCITE-5990
https://issues.apache.org/jira/browse/CALCITE-5984
https://issues.apache.org/jira/browse/CALCITE-6052
#3. Last update exceeded 7 days
https://issues.apache.org/jira/browse/CALCITE-5884
https://issues.apache.org/jira/browse/CALCITE-4455
Best Regards,
Ran Tao
Jiajun Xie 于2023年10月28日周六
13:34写道：
Hi, all:
We're already very close to 1.36.0, all unresolved issues
has been
someone
reviewed.
https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0
- Some issues are currently being reviewed.
That's great! Thank you all for your efforts.
- Some issues have not been updated for a long time.
If anyone is willing to continue the review, I believe
they
should
be
resolved soon.
#1.Last update (new comments or commits) within 2 days:
https://issues.apache.org/jira/browse/CALCITE-129
https://issues.apache.org/jira/browse/CALCITE-5990
#2. Last update exceeded 2 days
https://issues.apache.org/jira/browse/CALCITE-5984
https://issues.apache.org/jira/browse/CALCITE-6052
#3. Last update exceeded 7 days
https://issues.apache.org/jira/browse/CALCITE-5884
https://issues.apache.org/jira/browse/CALCITE-6037
#4. Last update exceeded 14 days
https://issues.apache.org/jira/browse/CALCITE-4455
https://issues.apache.org/jira/browse/CALCITE-5826
On Wed, 25 Oct 2023 at 11:40, Benchao Li <
libenc...@apache.org>
wrote:
Thanks Mihai for the quick response, I'll take a look at
the PR.
Mihai Budiu 于2023年10月25日周三 05:02写道：
For the blocker issues, I have filed two PRs which
should
collectively
fix them.
https://github.com/apache/calcite/pull/3481 fixes
https://issues.apache.org/jira/brow
Re: [DISCUSS] Towards Calcite 1.36.0
; will be invalid. > >>>>>>>>>> > >>>>>>>>>> Tanner Clary 于2023年11月8日周三 > >>>>>>>>>> 10:43写道： > >>>>>>>>>>> > >>>>>>>>>>> The commit reverting 3154708 is here: > >>>>>>>>>>> > >>>>>>>>>> > >>>>>>> https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 > >>>>>>>>>>> > >>>>>>>>>>> Let me know if I can do anything else to help and thank y'all for > >>>>>>>>>> handling > >>>>>>>>>>> the release! > >>>>>>>>>>> > >>>>>>>>>>> Best, > >>>>>>>>>>> Tanner > >>>>>>>>>>> > >>>>>>>>>>> On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary > >>>>>>>>>>> > >>>>>>>>>> wrote: > >>>>>>>>>>> > >>>>>>>>>>>> I can revert it if that's alright, hope this helps! > >>>>>>>>>>>> > >>>>>>>>>>>> Best, > >>>>>>>>>>>> Tanner > >>>>>>>>>>>> > >>>>>>>>>>>> On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang < > >>>>>>>>>> francischu...@apache.org> > >>>>>>>>>>>> wrote: > >>>>>>>>>>>> > >>>>>>>>>>>>> I believe the main branch should still be frozen as we're still > >>>>>>>>>> voting > >>>>>>>>>>>>> for 1.36.0. > >>>>>>>>>>>>> > >>>>>>>>>>>>> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be > >>>>>>> reverted > >>>>>>>>>>>>> and then rebased on to main after 1.36.0 has been released. > >>>>>>>>>>>>> > >>>>>>>>>>>>> Francis > >>>>>>>>>>>>> > >>>>>>>>>>>>> On 8/11/2023 12:58 pm, Jiajun Xie wrote: > >>>>>>>>>>>>>> Hi, Benchao > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> Is the main branch still frozen? > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> I found a new commit[1], but 1.36.0 has not been released. > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> [1] > >>>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>> > >>>>>>> https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> On Mon, 6 Nov 2023 at 14:59, Benchao Li > >>>>>>>>>> wrote: > >>>>>>>>>>>>>> > >>>>>>>>>>>>>>> The release note PR is now available for review: > >>>>>>>>>>>>>>> https://github.com/apache/calcite/pull/3505 > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Benchao Li 于2023年11月6日周一 12:46写道： > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Hi devs, > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> All the issues targeted for 1.36.0 have been resolved, I'll > >>>>>>>>>> start the > >>>>>>>>>>>>>>>> release process now. Therefore main branch is in code freeze > >>>>>>>>>> until > >>>>>>>>>>>>>>>> further notice. > >>>>>>>>>>
Re: [DISCUSS] Towards Calcite 1.36.0
> > > >>>>>>> https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > > >>>>>>>>>> ), > > >>>>>>>>>> and force push main branch". Because the commit we are voting on > > >>>>>>>>>> is > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>> https://github.com/apache/calcite/commit/0be8eaebcf27afae9ecda8ab79db63c214426561 > > >>>>>>>>>> , > > >>>>>>>>>> after the voting, I'll push it to main with additional commits > > >>>>>>>>>> preparing for next version, then all the commits after > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>> https://github.com/apache/calcite/commit/4c9011c388f826c36463ae7da875ddb525104376 > > >>>>>>>>>> will be invalid. > > >>>>>>>>>> > > >>>>>>>>>> Tanner Clary 于2023年11月8日周三 > > >>>>>>>>>> 10:43写道： > > >>>>>>>>>>> > > >>>>>>>>>>> The commit reverting 3154708 is here: > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>> https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 > > >>>>>>>>>>> > > >>>>>>>>>>> Let me know if I can do anything else to help and thank y'all > > >>>>>>>>>>> for > > >>>>>>>>>> handling > > >>>>>>>>>>> the release! > > >>>>>>>>>>> > > >>>>>>>>>>> Best, > > >>>>>>>>>>> Tanner > > >>>>>>>>>>> > > >>>>>>>>>>> On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary > > >>>>>>>>>>> > > >>>>>>>>>> wrote: > > >>>>>>>>>>> > > >>>>>>>>>>>> I can revert it if that's alright, hope this helps! > > >>>>>>>>>>>> > > >>>>>>>>>>>> Best, > > >>>>>>>>>>>> Tanner > > >>>>>>>>>>>> > > >>>>>>>>>>>> On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang < > > >>>>>>>>>> francischu...@apache.org> > > >>>>>>>>>>>> wrote: > > >>>>>>>>>>>> > > >>>>>>>>>>>>> I believe the main branch should still be frozen as we're > > >>>>>>>>>>>>> still > > >>>>>>>>>> voting > > >>>>>>>>>>>>> for 1.36.0. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be > > >>>>>>> reverted > > >>>>>>>>>>>>> and then rebased on to main after 1.36.0 has been released. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Francis > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> On 8/11/2023 12:58 pm, Jiajun Xie wrote: > > >>>>>>>>>>>>>> Hi, Benchao > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Is the main branch still frozen? > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> I found a new commit[1], but 1.36.0 has not been released. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> [1] > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>> > > >>>>>>>>&
