Review Request 13056: CLOUDSTACK-3168: Fix test_reboot_router.py to ssh using public IP

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13056/
---

Review request for cloudstack and Prasanna Santhanam.


Bugs: CLOUDSTACK-3168


Repository: cloudstack-git


Description
---

test_reboot_router.py was trying to ssh to vm using private IP
and hence it failed with error "No route to host."
Fixed the testcase to ssh using public IP.


Diffs
-

  test/integration/smoke/test_network.py dad5630 

Diff: https://reviews.apache.org/r/13056/diff/


Testing
---


Thanks,

Girish Shilamkar

Re: Review Request 13055: Fix to select default vpc offering with internal lb

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/#review24214
---


Review 13055 PASSED the build test
The url of build cloudstack-master-with-patch #78 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/78/

- Jenkins Cloudstack.org


On July 30, 2013, 6:51 a.m., SrikanteswaraRao Talluri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13055/
> ---
> 
> (Updated July 30, 2013, 6:51 a.m.)
> 
> 
> Review request for cloudstack, venkata swamy babu  budumuru and Prasanna 
> Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3923
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When there are multiple VPC offerings, test is failing because list VPC 
> offering is listing multiple vpc offerings.
> 
> Test requires to select the default VPC offering which has lb service as 
> internal LB which has id=1.
> 
> fix is to select vpc offering with id=1
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_internal_lb.py 0535d6a 
>   test/integration/smoke/test_network_acl.py 4b3c1f7 
> 
> Diff: https://reviews.apache.org/r/13055/diff/
> 
> 
> Testing
> ---
> 
> tested.
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>

Re: [DISCUSS] Compatibility issue between network plugins and hypervisors

[Daan Hoogland]

Toshaki,

As long as the enabling of features is completely in control by
cloudstack developers this model will probably work fine. If generic
code in cloudstack enables a new feature in the upgrade version of an
SDN implementation or storage provider or hypervisor, it may not. I
think we want to write as much of such generic code as possible to be
vendor/version independent as much as we can. This is the conflict I
am seeing with the model. As a guiding principle it is fine for
specific code that can not be abstracted away from the target
implementations.

regards,

On Tue, Jul 30, 2013 at 2:50 AM, Toshiaki Hatano
 wrote:
> Daan,
>
> In my opinion, it's responsibility of the developer to provide
> information and to stop Ops from failing over cliff.
> Obviously Dev knows how code works (sometime not :), but Ops doesn't.
> So, if Dev deny to help Ops, how can Ops setup the cloud in proper way?
>
> When someone enhance hypervisor and/or network implementations, they
> should conduct test of their enhancement before submitting patch.
> Then, they may be able to notice that the checks are not up to date.
> Even if they didn't notice that, someone who try to use the feature
> should notice that.
>
> Do you think this model will not work?
>
> Thanks,
> --
> Toshiaki
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Saturday, July 27, 2013 05:06
> To: dev
> Subject: Re: [DISCUSS] Compatibility issue between network plugins and
> hypervisors
>
> H,
>
> isn't it the responsibility of the administrator to setup the cloud in a
> proper way? hypervisor and network implementations may enhance their
> capabilities at minor upgrades so it will not be easy to keep checks on
> this up to date in cloudstack. Am I missing the point here?
>
> regards,
> Daan
>
>
> On Sat, Jul 27, 2013 at 1:10 AM, Toshiaki Hatano
> wrote:
>
>> I agree with Murali.
>>
>> I feel NetworkGuru should know their capability and should called when
>
>> we add cluster.
>> NetworkGurus already provide canHandle(NetworkOffering, NetworkType,
>> PhysicalNetwork) method to check their capability.
>> So, how about overloading this method to get HypervisorType in
> arguments?
>>
>> Thanks,
>> --
>> Toshiaki
>>
>> -Original Message-
>> From: Murali Reddy [mailto:murali.re...@citrix.com]
>> Sent: Thursday, July 25, 2013 22:33
>> To: dev@cloudstack.apache.org
>> Subject: Re: [DISCUSS] Compatibility issue between network plugins and
>
>> hypervisors
>>
>> Also, should not we treat 'isolation' as Network Element capability
>> rather than Hypervisor. Tunnelling capability could be a Hypervisor
>> capability, but isolation (STT/GRE) is Network Element capability?
>> So,zone isolation
>> -> isolation provider -> supported hypervisors should be checked
>> -> against
>> add cluster IMO.
>>
>> On 26/07/13 9:24 AM, "Chiradeep Vittal" 
>> wrote:
>>
>> >+1 (with a caveat), good idea since isolation method is supported on
>> >+a
>> >per-zone basis.
>> >The caveat is that sometimes it makes sense to support multiple
>> >isolation methods in a zone.
>> >For example, VPC(advanced) + basic in the same zone.
>> >Why would one do this? Simply because someone might start with one
>> >isolation method (basic) and then offer advanced (using overlays like
>
>> >VxLAN f.e). Since templates/snapshots/volumes tend to be
>> >zone-specific, this makes the transition easier.
>> >This is not unlike AWS "EC2-classic" and "VPC" in the same zone.
>> >
>> >
>> >On 7/26/13 3:34 AM, "Alex Huang"  wrote:
>> >
>> >>+1
>> >>
>> >>I think we should take advantage of hypervisor capabilities to look
>> >>for that compatibility.
>> >>
>> >>--Alex
>> >>
>> >>> -Original Message-
>> >>> From: Toshiaki Hatano [mailto:toshiaki.hat...@verio.net]
>> >>> Sent: Thursday, July 25, 2013 3:01 PM
>> >>> To: dev@cloudstack.apache.org
>> >>> Subject: [DISCUSS] Compatibility issue between network plugins and
>
>> >>> hypervisors
>> >>>
>> >>> Hi devs,
>> >>>
>> >>>
>> >>>
>> >>> CloudStack supports many hypervisors and many network isolation
>> >>>methods.
>> >>>
>> >>> Some isolation method doesn't (or cannot) support some
>> >>> hypervisors,
>> >>>
>> >>> but it looks cloudstack doesn't check compatibility between
>> >>>network isolation  and hypervisors.
>> >>>
>> >>>
>> >>>
>> >>> Why don't we check it during addCluster, first timing cloudstack-
>> >>>management know isolation and hypervisor, and fail if it's
>> >>>incompatible?
>> >>>
>> >>>
>> >>>
>> >>> Best Regards,
>> >>>
>> >>> --
>> >>>
>> >>> Toshiaki Hatano
>> >>>
>> >>> Verio, an NTT Communications company
>> >>> E-mail:  toshiaki.hat...@verio.net
>> >>> 
>> >>>
>> >>> AIM:  toshiaki.hat...@verio.net
> 
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>> This email message is intended for the use of the person to whom
>> >>>it has  been sent, and may contain information that is confidential
>
>> >>>or legally  protected. If you are 

Re: [VOTE] Whitespace changes to bylaws.mdtext

[Wido den Hollander]

+1

On 07/29/2013 11:55 PM, Noah Slater wrote:

Hi,

I'd like to make several changes to our by-laws, but before I continue,
I've prepared a changset that tidies up whitespace and hard wraps. This
will make it easier to edit.

The only non-whitespace change my patch makes is to correct two spelling
errors:

Transparancy -> Transparency
desicion -> decision

I am hoping this is a non-contentious change and can get the requisite 3 +1
votes. :)

Per the by-laws, this is a lazy majority vote, and will be open for 72
hours. We need 3 +1 votes to pass, and more +1 votes than -1 votes.

See the end of this email for the full patch. (Our ML does not allow
attachments. And I want the change to be concretely tied to the votes.)

Thanks,

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/
---

(Updated July 30, 2013, 8:46 a.m.)


Review request for cloudstack, Alena Prokharchyk and Sheng Yang.


Changes
---

Moved the functionality of adding and remove vlan to addOrRemoveVlan function. 
This is called by both create and update physicalnetwork methods. As a result 
both create and update physical network can handle multiple vlan ranges.

now we can reset the valan ranges to a null value.

Added a comment to clarify the usage of the deletevnets function.


Bugs: Cloudstack-3753


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-3753
Multiple VLAN range API need to accept a list rather than "add" or "remove" per 
command


Diffs (updated)
-

  api/src/com/cloud/network/NetworkService.java 59ccdbf 
  
api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
 333564e 
  engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
  engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
  server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
  server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 

Diff: https://reviews.apache.org/r/12905/diff/


Testing
---

Tested on master.
removed the removevlan parameter.
vlan parameter can be used for both addition and removal of valns.
instead of passing only a vlan range. user has to pass all the vlan ranges that 
he wants to keep.
the vlan ranges missing in the input and present in the db (not allocated) will 
be removed.


Thanks,

bharat kumar

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

[bharat kumar]

> On July 29, 2013, 8:45 p.m., Alena Prokharchyk wrote:
> > 1) DataCenterVnetDaoImpl.java
> > 
> > deleteRange method.
> > 
> > List vnets - this type is very ambigous. How is it represented? 
> > 100-200? 100,101,102,103? People are going to use this method, you either 
> > have to document it well, or use diff datastructure.
> > 
> > 2) Not able to re-set the range back to NULL
> > 
> > 3) The main concern:
> > 
> > createPhysicalNetwork should work just as updatePhysicalNetwork. Right now 
> > it fails:
> > 
> > http://localhost:8096/?command=createPhysicalNetwork&name=200&vlan=1-2,6-100&zoneId=1
> > 
> > 
> > 431
> > 4350
> > Please specify valid integers for the vlan range.
> > 

fixed these issues.


- bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/#review24171
---


On July 30, 2013, 8:46 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12905/
> ---
> 
> (Updated July 30, 2013, 8:46 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
> 
> 
> Bugs: Cloudstack-3753
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3753
> Multiple VLAN range API need to accept a list rather than "add" or "remove" 
> per command
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/NetworkService.java 59ccdbf 
>   
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
>  333564e 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
>   server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 
> 
> Diff: https://reviews.apache.org/r/12905/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> removed the removevlan parameter.
> vlan parameter can be used for both addition and removal of valns.
> instead of passing only a vlan range. user has to pass all the vlan ranges 
> that he wants to keep.
> the vlan ranges missing in the input and present in the db (not allocated) 
> will be removed.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.

[Sanjay Tripathi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13057/
---

Review request for cloudstack, Devdeep Singh and Fang Wang.


Bugs: CLOUDSTACK-2909


Repository: cloudstack-git


Description
---

CLOUDSTACK-2909: patch to fix TAB in US keyboard.


Diffs
-

  services/console-proxy/server/js/ajaxkeys.js 725c8c5 

Diff: https://reviews.apache.org/r/13057/diff/


Testing
---

Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as 
hypervisor.


Thanks,

Sanjay Tripathi

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/
---

(Updated July 30, 2013, 8:53 a.m.)


Review request for cloudstack, Alena Prokharchyk and Sheng Yang.


Bugs: Cloudstack-3753


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-3753
Multiple VLAN range API need to accept a list rather than "add" or "remove" per 
command


Diffs (updated)
-

  api/src/com/cloud/network/NetworkService.java 59ccdbf 
  
api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
 333564e 
  engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
  engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
  server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
  server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 

Diff: https://reviews.apache.org/r/12905/diff/


Testing
---

Tested on master.
removed the removevlan parameter.
vlan parameter can be used for both addition and removal of valns.
instead of passing only a vlan range. user has to pass all the vlan ranges that 
he wants to keep.
the vlan ranges missing in the input and present in the db (not allocated) will 
be removed.


Thanks,

bharat kumar

S3 Object Store testing

[Thomas O'Dowd]

Sanjeev,

I was talking to Prasanna earlier regarding testing various parts of the
S3 Object Store integration. I've been testing on and off myself using
devcloud but have yet to get a snapshot to work. It looks like devcloud
version of XCP at least doesn't have /opt/xensource/sm/ so its failing
to store the snapshot. See this issue here:
https://issues.apache.org/jira/browse/CLOUDSTACK-3229

I'm going to try to find some hardware to test with KVM but not sure how
soon I can do it. I'm interested to hear regarding how far you have
tested different hypervisors with S3 and which areas you have concern
with or need further testing.

Tom.
-- 
Cloudian KK - http://cloudian.jp/
S3 REST API Compliant Cloud Storage with Cloudian®

RE: S3 Object Store testing

[Sanjeev Neelarapu]

Hi Tom,

Thanks for testing this feature on XCP. I haven't covered XCP in my tests. So 
far testing has been done on XenServer and KVM. 

Thanks,
Sanjeev

-Original Message-
From: Thomas O'Dowd [mailto:tpod...@cloudian.com] 
Sent: Tuesday, July 30, 2013 2:25 PM
To: Sanjeev Neelarapu
Cc: Cloudstack DEV
Subject: S3 Object Store testing

Sanjeev,

I was talking to Prasanna earlier regarding testing various parts of the
S3 Object Store integration. I've been testing on and off myself using devcloud 
but have yet to get a snapshot to work. It looks like devcloud version of XCP 
at least doesn't have /opt/xensource/sm/ so its failing to store the snapshot. 
See this issue here:
https://issues.apache.org/jira/browse/CLOUDSTACK-3229

I'm going to try to find some hardware to test with KVM but not sure how soon I 
can do it. I'm interested to hear regarding how far you have tested different 
hypervisors with S3 and which areas you have concern with or need further 
testing.

Tom.
--
Cloudian KK - http://cloudian.jp/
S3 REST API Compliant Cloud Storage with Cloudian®

Re: Review Request 13056: CLOUDSTACK-3168: Fix test_reboot_router.py to ssh using public IP

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13056/#review24218
---


Review 13056 PASSED the build test
The url of build cloudstack-master-with-patch #79 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/79/

- Jenkins Cloudstack.org


On July 30, 2013, 7:17 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13056/
> ---
> 
> (Updated July 30, 2013, 7:17 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3168
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> test_reboot_router.py was trying to ssh to vm using private IP
> and hence it failed with error "No route to host."
> Fixed the testcase to ssh using public IP.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_network.py dad5630 
> 
> Diff: https://reviews.apache.org/r/13056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: S3 Object Store testing

[Prasanna Santhanam]

Tom,

It looks like the test plans and execution are tracked here. I'm not
sure if the execution itself will be useful to you. But the tests
itself being covered across various deployments and hypervisors should
be here:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Object+Store+Test+Execution

On Tue, Jul 30, 2013 at 09:04:17AM +, Sanjeev Neelarapu wrote:
> Hi Tom,
> 
> Thanks for testing this feature on XCP. I haven't covered XCP in my
> tests. So far testing has been done on XenServer and KVM. 
> 
> Thanks,
> Sanjeev
> 
> -Original Message-
> From: Thomas O'Dowd [mailto:tpod...@cloudian.com] 
> Sent: Tuesday, July 30, 2013 2:25 PM
> To: Sanjeev Neelarapu
> Cc: Cloudstack DEV
> Subject: S3 Object Store testing
> 
> Sanjeev,
> 
> I was talking to Prasanna earlier regarding testing various parts of the
> S3 Object Store integration. I've been testing on and off myself using 
> devcloud but have yet to get a snapshot to work. It looks like devcloud 
> version of XCP at least doesn't have /opt/xensource/sm/ so its failing to 
> store the snapshot. See this issue here:
> https://issues.apache.org/jira/browse/CLOUDSTACK-3229
> 
> I'm going to try to find some hardware to test with KVM but not sure how soon 
> I can do it. I'm interested to hear regarding how far you have tested 
> different hypervisors with S3 and which areas you have concern with or need 
> further testing.
> 
> Tom.
> --
> Cloudian KK - http://cloudian.jp/
> S3 REST API Compliant Cloud Storage with Cloudian??
> 

-- 
Prasanna.,


Powered by BigRock.com

[4.1] getVMPassword > how to decrypt

[Antonio Petrocelli]

  
  
Hello,

http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/getVMPassword.html

after retrieved the password i'm unable to decrypt the encryptedpassword.
  
Suggestions?

Thanks.

Regards.
-- 
   
  

  

  
  
  Supernova
  s.r.l.
  Via G. Misiticoni, 3
  65126 - Pescara
  ITALY
  
  www.netsons.com


   Antonio
Petrocelli
Software Engineer 
   
  
  t. (+39)
085 45 100 52
  e. a.petroce...@netsons.com
  
  
   
   
  

  
  
  
  Netsons® è un marchio registrato dalla Supernova s.r.l.
  
  
  
Le informazioni trasmesse sono riservate alla persona o alla
società indicata come destinatario, e possono includere
contenuti considerati confidenziali. Ogni elaborazione,
comunicazione, trasmissione o altro utilizzo, anche azioni
conseguenti alla conoscenza di queste informazioni da parte di
chiunque non sia espressamente indicato come destinatario è
proibita. Nel caso abbiate ricevuto per errore questa
comunicazione, siete pregati di darne avviso a info [at]
netsons.com ed eliminare ogni stampa ed ogni traccia
informatica. Il ricevente dovrà inoltre accertarsi che gli
eventuali allegati non contengano virus prima di aprirli.
Qualunque opinione o affermazione presentata in questo messaggio
è da ritenersi propria dell'autore e non rappresenta
necessariamente la posizione della Società.


The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential
material. Any review, retransmission, dissemination or other use
of, or taking of any action in reliance upon this information by
persons or entities other than the intended recipient is
prohibited. If you received this in error, please contact: info
[at] netsons.com and delete the material from any computer. If
this email contains attachments you should ensure they are
checked for viruses before opening them. Any views or opinions
presented are solely those of the author and do not necessarily
represent those of the company.
  

  



smime.p7s
Description: Firma crittografica S/MIME

Re: Noisy ASFBot

[Prasanna Santhanam]

On Sat, Jul 20, 2013 at 12:15:33PM +0200, Daan Hoogland wrote:
> I agree,
> 
> @Prasanna, can we make ignore default and /activate ASFBot? That would have
> my preference.
> 

I got annoyed about this today myself. 

infrabot:
Prasanna Santhanam [Created] (INFRA-6605) Turn off git2jira reports coming from 
ASFBot

-- 
Prasanna.,


Powered by BigRock.com

Review Request 13058: unable to update the concurrent_connections in networkoffering.

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13058/
---

Review request for cloudstack and Abhinandan Prateek.


Bugs: Cloudstack-2997


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-2997

cloud not update the concurrent_connections parameter of networkoffering 
because of some dao dependency.

The update was not happening because of choosing a VO variable name having a 
underscore.  


Diffs
-

  engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 406d98a 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3ec3514 

Diff: https://reviews.apache.org/r/13058/diff/


Testing
---

Tested on 4.2


Thanks,

bharat kumar

Re: Review Request 13001: Automation: Adding test cases for CPU limits from Limit Resources.

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/
---

(Updated July 30, 2013, 10:27 a.m.)


Review request for cloudstack, Girish Shilamkar, sailaja mada, Sanjay Tripathi, 
and Prasanna Santhanam.


Changes
---

including dev/qa owners for first review.


Repository: cloudstack-git


Description
---

Adding test cases for CPU limits from Limit Resources.
Marvin changes have to be picked up from Memory Limits patch 
(https://reviews.apache.org/r/11626/). Those are not included in this patch.


Diffs
-

  test/integration/component/cpu_limits/test_cpu_limits.py PRE-CREATION 
  test/integration/component/cpu_limits/test_domain_limits.py PRE-CREATION 
  test/integration/component/cpu_limits/test_maximum_limits.py PRE-CREATION 
  test/integration/component/cpu_limits/test_project_limits.py PRE-CREATION 

Diff: https://reviews.apache.org/r/13001/diff/


Testing
---


Thanks,

Gaurav Aradhye

Re: Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13057/#review24219
---


Review 13057 PASSED the build test
The url of build cloudstack-master-with-patch #80 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/80/

- Jenkins Cloudstack.org


On July 30, 2013, 8:50 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13057/
> ---
> 
> (Updated July 30, 2013, 8:50 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-2909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2909: patch to fix TAB in US keyboard.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxkeys.js 725c8c5 
> 
> Diff: https://reviews.apache.org/r/13057/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as 
> hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 13058: unable to update the concurrent_connections in networkoffering.

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13058/#review24220
---


Review 13058 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #81 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/81/

- Jenkins Cloudstack.org


On July 30, 2013, 10:24 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13058/
> ---
> 
> (Updated July 30, 2013, 10:24 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: Cloudstack-2997
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-2997
> 
> cloud not update the concurrent_connections parameter of networkoffering 
> because of some dao dependency.
> 
> The update was not happening because of choosing a VO variable name having a 
> underscore.  
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 406d98a 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3ec3514 
> 
> Diff: https://reviews.apache.org/r/13058/diff/
> 
> 
> Testing
> ---
> 
> Tested on 4.2
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 13058: unable to update the concurrent_connections in networkoffering.

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13058/
---

(Updated July 30, 2013, 10:52 a.m.)


Review request for cloudstack and Abhinandan Prateek.


Changes
---

Added maxconnections to the response of the create and update network offering 


Bugs: Cloudstack-2997


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-2997

cloud not update the concurrent_connections parameter of networkoffering 
because of some dao dependency.

The update was not happening because of choosing a VO variable name having a 
underscore.  


Diffs (updated)
-

  api/src/org/apache/cloudstack/api/response/NetworkOfferingResponse.java 
6b35d7b 
  engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 406d98a 
  server/src/com/cloud/api/ApiResponseHelper.java e331bef 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3ec3514 

Diff: https://reviews.apache.org/r/13058/diff/


Testing
---

Tested on 4.2


Thanks,

bharat kumar

blocker bug Vm deployment is failing

[Shweta Agarwal]

Hi
I filed a blocker bug
Vm deployment is failing on build CloudPlatform-4.2-292-rhel6.3.tar.gz
https://issues.apache.org/jira/browse/CLOUDSTACK-3944

Can somebody fix it ASAP .

Thanks
Shweta

Re: Review Request 13022: Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13022/
---

(Updated July 30, 2013, 11:15 a.m.)


Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.


Bugs: Cloustack-3910


Repository: cloudstack-git


Description
---

Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.
https://issues.apache.org/jira/browse/CLOUDSTACK-3910


Diffs (updated)
-

  engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e8ca579 
  setup/db/db/schema-410to420.sql 7377cbd 

Diff: https://reviews.apache.org/r/13022/diff/


Testing
---

Tested upgrade from 3.0.6 to 4.2


Thanks,

bharat kumar

RE: Git Push Summary

[Saksham Srivastava]

Isaac, I tried some of your changes. Looks good.

Regards,
Saksham

-Original Message-
From: Isaac Chiang [mailto:isaacchi...@gmail.com] 
Sent: Wednesday, July 24, 2013 3:12 PM
To: Pranav Saxena
Cc: dev@cloudstack.apache.org
Subject: Re: Git Push Summary

Hi all,
 I've been working on re-factoring the dedication UI code in these days 
and just finished.
I discussed the requirements with Pranav before. The changes are listed as
following:

1. zone wizard: (JIRA ticket :
https://issues.apache.org/jira/browse/CLOUDSTACK-3700)

Add a dedication step to activating zone process with rules as:
(A) if the user check the "dedicate" checkbox and provide correct 
account information, the wizard will have an extra dedicating step
  when activating the newly created zone(show in the activating 
steps).
(B) if the user check the "dedicate" checkbox and provide incorrect 
account information, the wizard will return to "Setup Zone" step. Let

  the user has the opportunity to modify the acc or uncheck the 
"dedicate" checkbox. It runs into two cases after the user click on fix
  error through the wizard:
  (a) If the user unchecks the "dedicate" checkbox this time, the 
wizard will continue to finish the rest of the activating process without
showing the dedicating step.
  (b) If the user provides the correct account this time, the 
wizard will process the dedicating step again(show in the wizard) and
finish the rest of activating process

2. Create pod/cluster/host from dialog: (JIRA ticket :
https://issues.apache.org/jira/browse/CLOUDSTACK-3388)
 Fix the dedication code to fit asynchronous dedication api commands.
The UI now shows correct notification message for the dedication operation.

Please let me know if you have any concerns, thanks! :)


Regards

Isaac









On Fri, Jul 19, 2013 at 10:04 AM, Isaac Chiang wrote:

> Hi Pranav,
> I'll do more tests before applying the code to master in next 
> few days. Since the UI code has been re-formatted yesterday, I'd like 
> to copy/paste the modified part into master instead of merging the branch.
> Thanks for all the help and advice :)
>
> Regards
>
>
> On Thu, Jul 18, 2013 at 2:47 PM, Pranav Saxena  wrote:
>
>> Hey Isaac ,
>>
>> I verified your code changes in your private asf branch . The code 
>> changes look good to me. I am assuming that it would work fine for 
>> the following cases -
>> 1) Dedication is a success , addition of resource is a success
>> 2) Dedication is a failure , addition of resource is still a success
>> 3) Dedication is a failure , addition is also a failure
>>
>>  - All 3 cases should have notification displayed for each of the API 
>> calls getting triggered ( which I believe would be there after your 
>> code
>> changes)
>>  - Also you could provide a "setInterval" waiting time function of 
>> say
>> 2-3 seconds between two successive notifications.
>>
>> One thing which I realized after looking at your code changes is that 
>> you would have to bear the pain of resolving the merge conflicts when 
>> you merge your branch with master. Since your code 
>> modifications/additions have been done on the already existing code , 
>> I am pretty sure you would have to take care of these conflicts. 
>> Since the changes aren't that huge, you could manually copy them to 
>> the master branch or replace the entire system.js file in your branch 
>> in the master assuming you forked your branch out of master and there 
>> haven't been other changes in system.js file . First option is a safer 
>> approach though !!
>>
>> Thanks,
>> Pranav
>>
>>
>> On Thu, Jul 18, 2013 at 8:18 AM, Isaac Chiang wrote:
>>
>>> Hi Pranav:
>>>  I just pushed part of modified code in to the branch.
>>> Please have a look if the commit fix the issue as expected.
>>>
>>> Thanks,
>>>
>>> Regards
>>>
>>>
>>> -- Forwarded message --
>>> From: Pranav Saxena 
>>> Date: Tue, Jul 16, 2013 at 4:52 PM
>>> Subject: Re: Git Push Summary
>>> To: dev@cloudstack.apache.org, jessica.w...@citrix.com, 
>>> sonny.ch...@citrix.com
>>> Cc: comm...@cloudstack.apache.org
>>>
>>>
>>> Thanks Isaac for creating this branch. I'll keep an eye on the 
>>> commits you make your here . Once the code for handling nested query 
>>> API calls are ready , you can merge it into master.
>>>
>>> @Jessica - I have had conversations with Isaac and he is in the 
>>> process of re-factoring the code for dedicated resources to handle 
>>> the nested query API calls . You could review it once as well when 
>>> he sends out a request for merge . It should not be a big change 
>>> though !
>>>
>>> Thanks,
>>> Pranav
>>>
>>>
>>> On Tue, Jul 16, 2013 at 2:00 PM,  wrote:
>>>
>>> > Updated Branches:
>>> >   refs/heads/ui-dedicatedresources-refactoring [created] 22ddc3fa0
>>> >
>>>
>>>
>>
>

Request to inform which DB command to run on existing setup if any db schema changes

[Rajesh Battala]

Hi All,
Please share sql statements to be inserted in the dev list, if any db schema 
changes are committed and require deploy db on existing setup .
This will save lots of development time.
More time is getting consumed in clearing the entire setup and set it again.

Thanks
Rajesh Battala

Review Request 13060: Mid-term report for Dharmesh's update

[Dharmesh Kakadia]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13060/
---

Review request for cloudstack and Sebastien Goasguen.


Repository: cloudstack-git


Description
---

GSoC updates from Dharmesh


Diffs
-

  docs/en-US/gsoc-midsummer-dharmesh.xml 69e417a 

Diff: https://reviews.apache.org/r/13060/diff/


Testing
---

Built with publican


Thanks,

Dharmesh Kakadia

RE: Request to inform which DB command to run on existing setup if any db schema changes

[Koushik Das]

Rajesh,
You can look at the check-in history for schema-410to420.sql for the changes

> -Original Message-
> From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> Sent: Tuesday, July 30, 2013 5:03 PM
> To: dev@cloudstack.apache.org
> Subject: Request to inform which DB command to run on existing setup if any
> db schema changes
> 
> Hi All,
> Please share sql statements to be inserted in the dev list, if any db schema
> changes are committed and require deploy db on existing setup .
> This will save lots of development time.
> More time is getting consumed in clearing the entire setup and set it again.
> 
> Thanks
> Rajesh Battala

RE: Request to inform which DB command to run on existing setup if any db schema changes

[Rajesh Battala]

That's a default solution. But the rate at which commits are making to repo 
it's not easy to figure out which commits are causing db changes.
Hope you had already faced this situation 

Thanks
Rajesh Battala


> -Original Message-
> From: Koushik Das [mailto:koushik@citrix.com]
> Sent: Tuesday, July 30, 2013 5:14 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Request to inform which DB command to run on existing setup if
> any db schema changes
> 
> Rajesh,
> You can look at the check-in history for schema-410to420.sql for the changes
> 
> > -Original Message-
> > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> > Sent: Tuesday, July 30, 2013 5:03 PM
> > To: dev@cloudstack.apache.org
> > Subject: Request to inform which DB command to run on existing setup
> > if any db schema changes
> >
> > Hi All,
> > Please share sql statements to be inserted in the dev list, if any db
> > schema changes are committed and require deploy db on existing setup .
> > This will save lots of development time.
> > More time is getting consumed in clearing the entire setup and set it again.
> >
> > Thanks
> > Rajesh Battala

Re: Request to inform which DB command to run on existing setup if any db schema changes

[Nitin Mehta]

+1 Rajesh. Its just that its difficult to enforce all.

On 30/07/13 5:18 PM, "Rajesh Battala"  wrote:

>That's a default solution. But the rate at which commits are making to
>repo it's not easy to figure out which commits are causing db changes.
>Hope you had already faced this situation
>
>Thanks
>Rajesh Battala
>
>
>> -Original Message-
>> From: Koushik Das [mailto:koushik@citrix.com]
>> Sent: Tuesday, July 30, 2013 5:14 PM
>> To: dev@cloudstack.apache.org
>> Subject: RE: Request to inform which DB command to run on existing
>>setup if
>> any db schema changes
>> 
>> Rajesh,
>> You can look at the check-in history for schema-410to420.sql for the
>>changes
>> 
>> > -Original Message-
>> > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
>> > Sent: Tuesday, July 30, 2013 5:03 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: Request to inform which DB command to run on existing setup
>> > if any db schema changes
>> >
>> > Hi All,
>> > Please share sql statements to be inserted in the dev list, if any db
>> > schema changes are committed and require deploy db on existing setup .
>> > This will save lots of development time.
>> > More time is getting consumed in clearing the entire setup and set it
>>again.
>> >
>> > Thanks
>> > Rajesh Battala

Re: Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13016/
---

(Updated July 30, 2013, 12:11 p.m.)


Review request for cloudstack and Kishan Kavala.


Changes
---

Differentiated usage events for stopped vms and running vms and added action 
events in all the cases


Bugs: CLOUDSTACK-3848


Repository: cloudstack-git


Description
---

CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM


Diffs (updated)
-

  api/src/com/cloud/event/EventTypes.java 6f1eed6 
  
api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java 
a077e24 
  api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 758d9c1 
  server/src/com/cloud/server/ManagementServerImpl.java 996c693 
  server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 
  usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd 

Diff: https://reviews.apache.org/r/13016/diff/


Testing
---

Tested locally


Thanks,

Harikrishna Patnala

Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/#review24222
---


Commit e45888df961890af476f0f9f9b6d1c91c26cbbb6 in branch refs/heads/4.2 from 
Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e45888d ]

CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.


- ASF Subversion and Git Services


On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13015/
> ---
> 
> (Updated July 29, 2013, 1:04 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-1961
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-1961: Common issues found in English OS with EN-US standard 
> Keyboard.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxviewer.js a6e1eda 
> 
> Diff: https://reviews.apache.org/r/13015/diff/
> 
> 
> Testing
> ---
> 
> Tested the fix on windows 7 guestOS and Xenserver hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13057/#review24221
---


Commit 7cb1c6fa7ba229484ec3e87ad5f50b35eeacf953 in branch refs/heads/4.2 from 
Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7cb1c6f ]

CLOUDSTACK-2909: patch to fix TAB in US keyboard.


- ASF Subversion and Git Services


On July 30, 2013, 8:50 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13057/
> ---
> 
> (Updated July 30, 2013, 8:50 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-2909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2909: patch to fix TAB in US keyboard.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxkeys.js 725c8c5 
> 
> Diff: https://reviews.apache.org/r/13057/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as 
> hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/#review24224
---


Commit 33122478c392a6471cf550c40d655b6f70e4701a in branch refs/heads/master 
from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3312247 ]

CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.


- ASF Subversion and Git Services


On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13015/
> ---
> 
> (Updated July 29, 2013, 1:04 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-1961
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-1961: Common issues found in English OS with EN-US standard 
> Keyboard.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxviewer.js a6e1eda 
> 
> Diff: https://reviews.apache.org/r/13015/diff/
> 
> 
> Testing
> ---
> 
> Tested the fix on windows 7 guestOS and Xenserver hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13057/#review24223
---


Commit 6ec2bb1518898c55739f74a11d881b1ba587d94a in branch refs/heads/master 
from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6ec2bb1 ]

CLOUDSTACK-2909: patch to fix TAB in US keyboard.


- ASF Subversion and Git Services


On July 30, 2013, 8:50 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13057/
> ---
> 
> (Updated July 30, 2013, 8:50 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-2909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2909: patch to fix TAB in US keyboard.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxkeys.js 725c8c5 
> 
> Diff: https://reviews.apache.org/r/13057/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as 
> hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13057/#review24226
---

Ship it!


Ship It!

- Devdeep Singh


On July 30, 2013, 8:50 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13057/
> ---
> 
> (Updated July 30, 2013, 8:50 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-2909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2909: patch to fix TAB in US keyboard.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxkeys.js 725c8c5 
> 
> Diff: https://reviews.apache.org/r/13057/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as 
> hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/#review24225
---

Ship it!


Ship It!

- Devdeep Singh


On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13015/
> ---
> 
> (Updated July 29, 2013, 1:04 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-1961
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-1961: Common issues found in English OS with EN-US standard 
> Keyboard.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxviewer.js a6e1eda 
> 
> Diff: https://reviews.apache.org/r/13015/diff/
> 
> 
> Testing
> ---
> 
> Tested the fix on windows 7 guestOS and Xenserver hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: [VOTE] Whitespace changes to bylaws.mdtext

[Chip Childers]

On Mon, Jul 29, 2013 at 10:55:23PM +0100, Noah Slater wrote:
> Hi,
> 
> I'd like to make several changes to our by-laws, but before I continue,
> I've prepared a changset that tidies up whitespace and hard wraps. This
> will make it easier to edit.
> 
> The only non-whitespace change my patch makes is to correct two spelling
> errors:
> 
> Transparancy -> Transparency
> desicion -> decision
> 
> I am hoping this is a non-contentious change and can get the requisite 3 +1
> votes. :)
> 
> Per the by-laws, this is a lazy majority vote, and will be open for 72
> hours. We need 3 +1 votes to pass, and more +1 votes than -1 votes.
> 
> See the end of this email for the full patch. (Our ML does not allow
> attachments. And I want the change to be concretely tied to the votes.)
> 
> Thanks,
> 
> -- 
> NS

+1

Re: Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13016/
---

(Updated July 30, 2013, 12:47 p.m.)


Review request for cloudstack, Kishan Kavala and Nitin Mehta.


Bugs: CLOUDSTACK-3848


Repository: cloudstack-git


Description
---

CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM


Diffs
-

  api/src/com/cloud/event/EventTypes.java 6f1eed6 
  
api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java 
a077e24 
  api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 758d9c1 
  server/src/com/cloud/server/ManagementServerImpl.java 996c693 
  server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 
  usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd 

Diff: https://reviews.apache.org/r/13016/diff/


Testing
---

Tested locally


Thanks,

Harikrishna Patnala

Re: [VOTE] Apache Cloudstack 4.1.1 (Second Round)

[Chip Childers]

Ove,

Thanks for reporting this, and for the suggested fix.  It appears that 
the issue has existed for quite some time (if I'm understanding it 
correctly), so it's great to see that we've found it now.

As for 4.1.1, we are likely to need to include the fix for 3880 as 
part of a 4.1.2 or 4.2.0 release (whichever comes first).

-chip

On Sat, Jul 27, 2013 at 08:55:28PM +0200, Ove Ewerlid wrote:
> -1
> 
> Details;
>https://issues.apache.org/jira/browse/CLOUDSTACK-3880
> 
> RHEL6 specific; risk for database corruption if MGR is shutdown via
> anything that changes runlevel resulting in use of
> cloudstack-management, cloudstack-usage stop() targets (e.g.,
> /sbin/shutdown, "telinit 1", ACPID initiated poweroff, etc).
> 
> /Ove
> 
> 
> On 07/25/2013 08:04 PM, Musayev, Ilya wrote:
> >Hi All,
> >
> >I've created a 4.1.1 release, with the following artifacts up for a vote:
> >
> >Git Branch and Commit SH:
> >https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.1
> >Commit: d2c646f0a434831bd5aef88b5692c108fe26e718
> >
> >Release notes:
> >
> >http://jenkins.cloudstack.org/view/4.1/job/docs-4.1-releasenotes/23/
> >
> >
> >Source release (checksums and signatures are available at the same
> >location):
> >https://dist.apache.org/repos/dist/dev/cloudstack/4.1/
> >
> >PGP release keys (signed using B7B5E7FD):
> >https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> >
> >Vote will be open for 72 hours.
> >
> >For sanity in tallying the vote, can PMC members please be sure to indicate 
> >"(binding)" with their vote?
> >
> >[ ] +1  approve
> >[ ] +0  no opinion
> >[ ] -1  disapprove (and reason why)
> >
> >d2c646f0a434831bd5aef88b5692c108fe26e718
> >
> 
> 
> -- 
> Ove Everlid
> System Administrator / Architect / SDN & Linux hacker
> Mobile: +46706662363
> Office: +4618656913 (note EMEA Time Zone)
> 

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

[Saksham Srivastava]

> On July 28, 2013, 3:59 a.m., Min Chen wrote:
> > server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 249
> > 
> >
> > This is not right. For cross-zone template, in 
> > HypervisorTemplateAdapter.create(TemplateProfile) method, you will see that 
> > there is a for-loop to download the template to each image store for each 
> > zone. For each image store, this createTemplateAsyncCallback will be 
> > invoked. So in this callback, you should just generate usage event for this 
> > zone.

The reason I do it is because, this part of code will be executed only once 
even when template is cross zone.
If I do not generate all the events here, only the first template that got 
created will publish the usage event.
Usage records do not have the information about store id, so we cannot be sure 
if the usage_record for that store id is already created or not.

It is too much of unnecessary hack to bypass the root issue, I am discarding 
the whole patch and will wait for the root cause (2 async call backs for a 
single register-template) to get fix.
Then it won't be required to do this.


> On July 28, 2013, 3:59 a.m., Min Chen wrote:
> > server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 229
> > 
> >
> > How can you guarantee that listSrcTmpltStore.get(0) is the entry you 
> > desire? You should find that exact (templateId, storeId) entry by passing 
> > both templateId and storeId, which should be able to be obtained from 
> > template.getDataStore().getId().

This is based on 2 assumptions:
1)Size/physical size of cross-zone template on all the stores will be equal
2)Size/physical sizes are populated only when 100% download is complete.
So even if there are multiple results for the same, all results will have same 
sizes.
For the first time when the template is downloaded to a store, there would be a 
single result having the correct sizes.
For later downloads of template this variable would not be even required 
because I am trying to publish all events at the first shot.


> On July 28, 2013, 3:59 a.m., Min Chen wrote:
> > server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 234
> > 
> >
> > Why cannot you provide a method in UsageEventDao to search by template 
> > id and event type? This way, you don't need to find a bigger set and filter 
> > here by looping.

Not sure how much we can save here, even though we can add a filter for the 
event-type, a single crosszone template can have multiple usage-records for 
same event-type.
But yes, it will make the search results smaller.


- Saksham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12968/#review24049
---


On July 27, 2013, 6:58 p.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12968/
> ---
> 
> (Updated July 27, 2013, 6:58 p.m.)
> 
> 
> Review request for cloudstack and Min Chen.
> 
> 
> Bugs: 3686
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Registering a template does not generate a usage event.
> The process should generate a usage event when the template is 100% 
> downloaded.
> Added a new usage event that has virtual_size also as a parameter.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 
>   engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java cda02ef 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 4b3cade 
> 
> Diff: https://reviews.apache.org/r/12968/diff/
> 
> 
> Testing
> ---
> 
> Now usage_event table is getting updated with the new usage_event.
> 
>  select * from usage_event where id = 23;
> ++-++-+-+-+---+-+-+--+---+---+--+
> | id | type| account_id | created | zone_id | 
> resource_id | resource_name | offering_id | template_id | size | 
> resource_type | processed | virtual_size |
> ++-++-+-+-+---+-+-+--+---+---+--+
> | 23 | TEMPLATE.CREATE |  2 | 2013-07-26 12:04:29 |   0 | 
> 215 | r8|NULL |NULL | 1628 | NULL  |  
>0 | 16777216 |
> ++-++-+-+-+---

Re: deploydb jdbc/mysql connector error?

[Chip Childers]

Alex,

This sounds related to the changes you have been making.


On Mon, Jul 29, 2013 at 09:46:20PM +0100, Ian Duffy wrote:
> Removing the scope line from 183 of the root pom.xml also seemed to
> get it going again.
> 
> On 29 July 2013 21:41, Vijayendra Bhamidipati
>  wrote:
> > Thanks Ian! I'll give that a try.
> >
> > Regards,
> > Vijay
> >
> > -Original Message-
> > From: Ian Duffy [mailto:i...@ianduffy.ie]
> > Sent: Monday, July 29, 2013 1:27 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: deploydb jdbc/mysql connector error?
> >
> > 1f64354ec830db6e30c17ec6e4a6d8c33f2e10da few days old.
> >
> > On 29 July 2013 21:20, Vijayendra Bhamidipati 
> >  wrote:
> >> I see! What commit # are you on? I'd rather use the same one to get by for 
> >> now until this is fixed.
> >>
> >> Regards,
> >> Vijay
> >>
> >> -Original Message-
> >> From: Ian Duffy [mailto:i...@ianduffy.ie]
> >> Sent: Monday, July 29, 2013 1:16 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: deploydb jdbc/mysql connector error?
> >>
> >> I'm having this issue too when trying to do deploydb on master. Its 
> >> working fine on a slightly older branch.
> >>
> >> On 29 July 2013 20:53, Vijayendra Bhamidipati 
> >>  wrote:
> >>> Prachi and I had a look at this, I should have pasted the entire output 
> >>> of the deploydb command - in Prachi's env we see that the 
> >>> mysql-connector.jar is getting copied over to the deps/ directory, but I 
> >>> see this warning in the beginning when I run deploydb:
> >>>
> >>>
> >>> [WARNING] Some problems were encountered while building the effective
> >>> model for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
> >>> [WARNING]
> >>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
> >>> e :classifier)' must be unique: mysql:mysql-connector-java:jar ->
> >>> duplicate declaration of version ${cs.mysql.version} @
> >>> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT,
> >>> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278,
> >>> column 19 [WARNING] [WARNING] Some problems were encountered while
> >>> building the effective model for
> >>> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
> >>> [WARNING]
> >>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
> >>> e :classifier)' must be unique: mysql:mysql-connector-java:jar ->
> >>> duplicate declaration of version ${cs.mysql.version} @ line 278, column 
> >>> 19 [WARNING] [WARNING] It is highly recommended to fix these problems 
> >>> because they threaten the stability of your build.
> >>> [WARNING]
> >>> [WARNING] For this reason, future Maven versions might no longer support 
> >>> building such malformed projects.
> >>> [WARNING]
> >>>
> >>>
> >>> Any idea why this is happening?
> >>>
> >>>
> >>> The complete output is pasted below:
> >>>
> >>> [root@vijay-vm1 cloudstack]# mvn -e -P developer -pl developer
> >>> -Ddeploydb Listening for transport dt_socket at address: 8787 [INFO]
> >>> Error stacktraces are turned on.
> >>> [INFO] Scanning for projects...
> >>> [WARNING]
> >>> [WARNING] Some problems were encountered while building the effective
> >>> model for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
> >>> [WARNING]
> >>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
> >>> e :classifier)' must be unique: mysql:mysql-connector-java:jar ->
> >>> duplicate declaration of version ${cs.mysql.version} @
> >>> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT,
> >>> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278,
> >>> column 19 [WARNING] [WARNING] Some problems were encountered while
> >>> building the effective model for
> >>> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
> >>> [WARNING]
> >>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
> >>> e :classifier)' must be unique: mysql:mysql-connector-java:jar ->
> >>> duplicate declaration of version ${cs.mysql.version} @ line 278, column 
> >>> 19 [WARNING] [WARNING] It is highly recommended to fix these problems 
> >>> because they threaten the stability of your build.
> >>> [WARNING]
> >>> [WARNING] For this reason, future Maven versions might no longer support 
> >>> building such malformed projects.
> >>> [WARNING]
> >>> [INFO]
> >>> [INFO]
> >>> -
> >>> -
> >>> -- [INFO] Building Apache CloudStack Developer Mode 4.2.0-SNAPSHOT
> >>> [INFO]
> >>> -
> >>> -
> >>> --
> >>> [INFO]
> >>> [INFO] ---
> >>> properties-maven-plugin:1.0-alpha-2:read-project-properties
> >>> (default) @ cloud-developer --- [INFO] [INFO] ---
> >>> maven-remote-resources-plugin:1.3:process (default) @ cloud-developer
> >>> --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (default) @
> >>> cloud-developer --- [INFO] Executing tasks
> >>>
> >>> main:
> >>> [INFO] Executed tasks
> >>> [INFO]
> >>> [INFO] >>> exec-maven-plugin:1.2.1:j

Re: [DISCUSS] maven dependencies...

[Chip Childers]

On Mon, Jul 29, 2013 at 08:40:44PM +, Donal Lafferty wrote:
> Could you also have a look at ./client/tomcatconf/log4j-cloud.xml.in?
> 
> It looks like it was updated in the refactor.
> 
> AFAIK, in '', {1.} should be {1}.
> 
> See "Conversion Character" chart under 
> http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html
>  
> 
> There's a lot of paper work for me to make the update :(
> 
> DL

Done!

commit 4c729e7

Review Request 13061: Unable to create the Internal LB vm.

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13061/
---

Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, and Ram Ganesh.


Bugs: 3924


Repository: cloudstack-git


Description
---

Issue:
==
Unable to created internalLB Vm. this is due while determining maxconn value 
from networkoffering.
to find the networking offering, networkid is passed instead of networkoffering 
id which is causing the issue.

fixed:
=
fixed the issue by passing the network offering id instead of network id.


Diffs
-

  
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java
 76507e9 

Diff: https://reviews.apache.org/r/13061/diff/


Testing
---

1. was able to create the 'b' vm. internal LB VM.


Thanks,

Rajesh Battala

Re: [VOTE] Apache Cloudstack 4.1.1 (Second Round)

[nicolas.lamirault]

OK Thanks.
I'll try to reproduce this issue and add some details of our configuration.
Regards.

Le 26/07/2013 19:30, Musayev, Ilya a écrit :
> I'm also unable to reproduce this issue in my 4.1.1 env
> 
> Screenshot for added and attached 1 root and 3 data disks
> https://www.diigo.com/item/image/3qjce/wnhb
> 
> Screenshot that stop and start VMs have been successful
> https://www.diigo.com/item/image/3qjce/q4i6
> 
> Not adding any longs as nothing was out of the ordinary there..
> 
>> -Original Message-
>> From: Musayev, Ilya [mailto:imusa...@webmd.net]
>> Sent: Friday, July 26, 2013 1:04 PM
>> To: dev@cloudstack.apache.org
>> Subject: RE: [VOTE] Apache Cloudstack 4.1.1 (Second Round)
>>
>> Nicolas,
>>
>> This issue exists in 4.1.0, 4.2.0 and as you can see has not been fixed in 
>> 4.1.1
>>
>> Since no-one is assigned to work on this ticket and we made no claims that it
>> has been fixed in 4.1.1, IMHO posting "-1" is a bit too harsh.
>>
>> While I am all for fixing this issue and will also look into this problem 
>> (we are
>> vpshere shop and I did not know if this problem), we need to raise
>> awareness on this bug and not block 4.1.1 release, because this specific 
>> issue
>> has not yet been addressed. We did address about 20+ bug fixes. If we were
>> to follow a methodology of blocking every single release because a specific
>> issue exists and has not been addressed, there is a good chance we will
>> never release anything.
>>
>> As you know, open source projects are ran by volunteers (and while many
>> developers are paid by company X), in general we do not make
>> commitments of any kind - we can try out best, but if it does not happen, we
>> will try on the next release. Therefore ACS community cannot guarantee that
>> issue X or feature Y will be added or resolved in the next release.
>>
>> With that in mind, let's work on raising awareness for this problem.
>>
>> Regards
>> ilya
>>
>>
>>
>>> -Original Message-
>>> From: nicolas.lamira...@orange.com
>>> [mailto:nicolas.lamira...@orange.com]
>>> Sent: Friday, July 26, 2013 3:26 AM
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: [VOTE] Apache Cloudstack 4.1.1 (Second Round)
>>>
>>> Hi,
>>>
>>> -1 due to the opened issue :
>>>
>>> - https://issues.apache.org/jira/browse/CLOUDSTACK-2895
>>>
>>> Le 26/07/2013 05:42, Marcus Sorensen a écrit :
 +1 binding, CentOS 6.4. Used devcloud-kvm advanced zone marvin
 +config,
 started up a VPC, registered a template, started a VM. Tested NFS,
 local, CLVM primary storage.

 One of these days I'll get around to making an Ubuntu devcloud-kvm.

 On Thu, Jul 25, 2013 at 2:54 PM, Simon Weller  wrote:
> +1
>
> Built NONOSS rpms and deployed on RHEL 6.3
>
> Tested vm creation + deletion, network creation + deletion,
> template
>>> creation + deletion.
>
> - Si
>
> - Original Message -
>
> From: "Ilya Musayev" 
> To: dev@cloudstack.apache.org
> Sent: Thursday, July 25, 2013 1:04:27 PM
> Subject: [VOTE] Apache Cloudstack 4.1.1 (Second Round)
>
> Hi All,
>
> I've created a 4.1.1 release, with the following artifacts up for a vote:
>
> Git Branch and Commit SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog
> ;h
> =refs/heads/4.1
> Commit: d2c646f0a434831bd5aef88b5692c108fe26e718
>
> Release notes:
>
> http://jenkins.cloudstack.org/view/4.1/job/docs-4.1-releasenotes/23
> /
>
>
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/4.1/
>
> PGP release keys (signed using B7B5E7FD):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
> Vote will be open for 72 hours.
>
> For sanity in tallying the vote, can PMC members please be sure to
>>> indicate "(binding)" with their vote?
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> d2c646f0a434831bd5aef88b5692c108fe26e718
>


>>>
>>>
>>> --
>>> Nicolas Lamirault
>>>
>>>
>> __
>>>
>> __
>>> _
>>>
>>> Ce message et ses pieces jointes peuvent contenir des informations
>>> confidentielles ou privilegiees et ne doivent donc pas etre diffuses,
>>> exploites ou copies sans autorisation. Si vous avez recu ce message
>>> par erreur, veuillez le signaler a l'expediteur et le detruire ainsi
>>> que les pieces jointes. Les messages electroniques etant susceptibles
>>> d'alteration, Orange decline toute responsabilite si ce message a ete 
>>> altere,
>> deforme ou falsifie. Merci.
>>>
>>> This message and its attachments may contain confidential or
>>> privileged information that may be protected by law; they should not
>>> be distributed, used or copied without authorisation.

Re: Review Request 12967: Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure

[Nitin Mehta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12967/#review24227
---

Ship it!



server/src/com/cloud/capacity/CapacityManagerImpl.java


Probably for future please have a better naming convention


- Nitin Mehta


On July 26, 2013, 11:59 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12967/
> ---
> 
> (Updated July 26, 2013, 11:59 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-1695
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-1695
> Not enough cpu avialable in cluster according to new overcommit ratio but all 
> stopped Vms can be started without any failure(required cpu for stopped vm is 
> >> available cpu )
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f 
> 
> Diff: https://reviews.apache.org/r/12967/diff/
> 
> 
> Testing
> ---
> 
> Tested on old master.
> This happened because we were not recalculating the used and the reserved 
> capacities based on the new overcommit ratio. 
> 
> Now used and reserved capacities of all the hosts in a overcommited cluster 
> will be recalculated on overcommit change by the capacity checker. However 
> this will happen only when capacity checker runs meaning the change in 
> capacities due to updated overcommit values will not be instantaneous.
>   
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Review Request 13062: Disable password change on UI when ldap is enabled

[Ian Duffy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13062/
---

Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.


Repository: cloudstack-git


Description
---

General clean up 
+
Disable password change on UI when ldap is enabled


Diffs
-

  client/WEB-INF/classes/resources/messages.properties 3e775e0 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccount.java
 01aebce 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java
 98c9fcf 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy
 27f3dfc 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVOSpec.groovy
 PRE-CREATION 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapCreateAccountCmdSpec.groovy
 PRE-CREATION 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy
 f4d185b 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListAllUsersCmdSpec.groovy
 2756e92 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy
 cf2f9ec 
  plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif f46a383 
  ui/dictionary.jsp eec0264 
  ui/scripts/accounts.js 43b242d 
  ui/scripts/ui-custom/accountsWizard.js 7951553 

Diff: https://reviews.apache.org/r/13062/diff/


Testing
---

Unit tests, ran + looked at.


Thanks,

Ian Duffy

Re: Review Request 13022: Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13022/#review24228
---

Ship it!


commit 03cbf51e159a452f18f560ac64c6ae64e34df12c

- Kishan Kavala


On July 30, 2013, 4:45 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13022/
> ---
> 
> (Updated July 30, 2013, 4:45 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Bugs: Cloustack-3910
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.
> https://issues.apache.org/jira/browse/CLOUDSTACK-3910
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e8ca579 
>   setup/db/db/schema-410to420.sql 7377cbd 
> 
> Diff: https://reviews.apache.org/r/13022/diff/
> 
> 
> Testing
> ---
> 
> Tested upgrade from 3.0.6 to 4.2
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 13060: Mid-term report for Dharmesh's update

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13060/#review24229
---


Review 13060 PASSED the build test
The url of build cloudstack-master-with-patch #82 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/82/

- Jenkins Cloudstack.org


On July 30, 2013, 11:42 a.m., Dharmesh Kakadia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13060/
> ---
> 
> (Updated July 30, 2013, 11:42 a.m.)
> 
> 
> Review request for cloudstack and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> GSoC updates from Dharmesh
> 
> 
> Diffs
> -
> 
>   docs/en-US/gsoc-midsummer-dharmesh.xml 69e417a 
> 
> Diff: https://reviews.apache.org/r/13060/diff/
> 
> 
> Testing
> ---
> 
> Built with publican
> 
> 
> Thanks,
> 
> Dharmesh Kakadia
> 
>

Re: Review Request 13022: Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13022/#review24230
---


Can upload patch for master branch?

- Kishan Kavala


On July 30, 2013, 4:45 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13022/
> ---
> 
> (Updated July 30, 2013, 4:45 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Bugs: Cloustack-3910
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.
> https://issues.apache.org/jira/browse/CLOUDSTACK-3910
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e8ca579 
>   setup/db/db/schema-410to420.sql 7377cbd 
> 
> Diff: https://reviews.apache.org/r/13022/diff/
> 
> 
> Testing
> ---
> 
> Tested upgrade from 3.0.6 to 4.2
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 13062: Disable password change on UI when ldap is enabled

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13062/#review24231
---


Review 13062 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #83 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/83/

- Jenkins Cloudstack.org


On July 30, 2013, 1:41 p.m., Ian Duffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13062/
> ---
> 
> (Updated July 30, 2013, 1:41 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> General clean up 
> +
> Disable password change on UI when ldap is enabled
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 3e775e0 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccount.java
>  01aebce 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java
>  98c9fcf 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy
>  27f3dfc 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVOSpec.groovy
>  PRE-CREATION 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapCreateAccountCmdSpec.groovy
>  PRE-CREATION 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy
>  f4d185b 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListAllUsersCmdSpec.groovy
>  2756e92 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy
>  cf2f9ec 
>   plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif f46a383 
>   ui/dictionary.jsp eec0264 
>   ui/scripts/accounts.js 43b242d 
>   ui/scripts/ui-custom/accountsWizard.js 7951553 
> 
> Diff: https://reviews.apache.org/r/13062/diff/
> 
> 
> Testing
> ---
> 
> Unit tests, ran + looked at.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>

Re: Review Request 12966: overcommited memory is not getting displayed at zone level and used % is based on actual memory

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12966/
---

(Updated July 30, 2013, 2:11 p.m.)


Review request for cloudstack, Kishan Kavala and Nitin Mehta.


Changes
---

uploaded the correct file.


Bugs: Cloudstack-1640


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-1640
overcommited memory is not getting displayed at zone level and used % is based 
on actual memory


Diffs (updated)
-

  engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java dc2899f 
  server/src/com/cloud/alert/AlertManagerImpl.java bff36c7 
  server/src/com/cloud/api/ApiResponseHelper.java f7b740b 
  server/src/com/cloud/server/ManagementServerImpl.java 0bdb114 

Diff: https://reviews.apache.org/r/12966/diff/


Testing
---

Tested on older master.
deployed vms and checked the capacites displayed on the dashboard.


Thanks,

bharat kumar

RE: deploydb jdbc/mysql connector error?

[Alex Huang]

Already fixed.  I neglected to test the deploydb because I had a db deployed 
already.  My bad.

--Alex

> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Tuesday, July 30, 2013 6:01 AM
> To: dev@cloudstack.apache.org; Alex Huang
> Subject: Re: deploydb jdbc/mysql connector error?
> 
> Alex,
> 
> This sounds related to the changes you have been making.
> 
> 
> On Mon, Jul 29, 2013 at 09:46:20PM +0100, Ian Duffy wrote:
> > Removing the scope line from 183 of the root pom.xml also seemed to
> > get it going again.
> >
> > On 29 July 2013 21:41, Vijayendra Bhamidipati
> >  wrote:
> > > Thanks Ian! I'll give that a try.
> > >
> > > Regards,
> > > Vijay
> > >
> > > -Original Message-
> > > From: Ian Duffy [mailto:i...@ianduffy.ie]
> > > Sent: Monday, July 29, 2013 1:27 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: deploydb jdbc/mysql connector error?
> > >
> > > 1f64354ec830db6e30c17ec6e4a6d8c33f2e10da few days old.
> > >
> > > On 29 July 2013 21:20, Vijayendra Bhamidipati
>  wrote:
> > >> I see! What commit # are you on? I'd rather use the same one to get by
> for now until this is fixed.
> > >>
> > >> Regards,
> > >> Vijay
> > >>
> > >> -Original Message-
> > >> From: Ian Duffy [mailto:i...@ianduffy.ie]
> > >> Sent: Monday, July 29, 2013 1:16 PM
> > >> To: dev@cloudstack.apache.org
> > >> Subject: Re: deploydb jdbc/mysql connector error?
> > >>
> > >> I'm having this issue too when trying to do deploydb on master. Its
> working fine on a slightly older branch.
> > >>
> > >> On 29 July 2013 20:53, Vijayendra Bhamidipati
>  wrote:
> > >>> Prachi and I had a look at this, I should have pasted the entire output
> of the deploydb command - in Prachi's env we see that the mysql-
> connector.jar is getting copied over to the deps/ directory, but I see this
> warning in the beginning when I run deploydb:
> > >>>
> > >>>
> > >>> [WARNING] Some problems were encountered while building the
> > >>> effective model for
> > >>> org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
> > >>> [WARNING]
> > >>>
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:
> > >>> typ e :classifier)' must be unique: mysql:mysql-connector-java:jar
> > >>> -> duplicate declaration of version ${cs.mysql.version} @
> > >>> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT,
> > >>> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278,
> > >>> column 19 [WARNING] [WARNING] Some problems were
> encountered while
> > >>> building the effective model for
> > >>> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
> > >>> [WARNING]
> > >>>
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:
> > >>> typ e :classifier)' must be unique: mysql:mysql-connector-java:jar
> > >>> -> duplicate declaration of version ${cs.mysql.version} @ line
> > >>> 278, column 19 [WARNING] [WARNING] It is highly recommended to
> fix these problems because they threaten the stability of your build.
> > >>> [WARNING]
> > >>> [WARNING] For this reason, future Maven versions might no longer
> support building such malformed projects.
> > >>> [WARNING]
> > >>>
> > >>>
> > >>> Any idea why this is happening?
> > >>>
> > >>>
> > >>> The complete output is pasted below:
> > >>>
> > >>> [root@vijay-vm1 cloudstack]# mvn -e -P developer -pl developer
> > >>> -Ddeploydb Listening for transport dt_socket at address: 8787
> > >>> [INFO] Error stacktraces are turned on.
> > >>> [INFO] Scanning for projects...
> > >>> [WARNING]
> > >>> [WARNING] Some problems were encountered while building the
> > >>> effective model for
> > >>> org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
> > >>> [WARNING]
> > >>>
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:
> > >>> typ e :classifier)' must be unique: mysql:mysql-connector-java:jar
> > >>> -> duplicate declaration of version ${cs.mysql.version} @
> > >>> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT,
> > >>> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278,
> > >>> column 19 [WARNING] [WARNING] Some problems were
> encountered while
> > >>> building the effective model for
> > >>> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
> > >>> [WARNING]
> > >>>
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:
> > >>> typ e :classifier)' must be unique: mysql:mysql-connector-java:jar
> > >>> -> duplicate declaration of version ${cs.mysql.version} @ line
> > >>> 278, column 19 [WARNING] [WARNING] It is highly recommended to
> fix these problems because they threaten the stability of your build.
> > >>> [WARNING]
> > >>> [WARNING] For this reason, future Maven versions might no longer
> support building such malformed projects.
> > >>> [WARNING]
> > >>> [INFO]
> > >>> [INFO]
> > >>> --
> > >>> ---
> > >>> -
> > >>> -- [INFO] Building Apache CloudStack Developer Mode 4.2.0-
> SNAPSHOT
> > >>> [INFO]
> > >>> --

Re: Review Request 13020: CLOUDSTACK-3252 An instance deployed using explicit or implicit dedication doesn't generate a usage even

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13020/#review24232
---


COde changes are required in UsageManager to handle new usage event

- Kishan Kavala


On July 29, 2013, 9:28 p.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13020/
> ---
> 
> (Updated July 29, 2013, 9:28 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Kishan Kavala.
> 
> 
> Bugs: 3252
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> If an instance is deployed using explicit or implicit dedication, or neither 
> of them a usage event isn't generated. 
> Added 2 new usage_events : 
> EVENT_DEDICATED_VM_CREATE_IMPLICIT and EVENT_DEDICATED_VM_CREATE_EXPLICIT
> generated when VMs are deployed using corresponding dedications.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 6f1eed6 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 
> 
> Diff: https://reviews.apache.org/r/13020/diff/
> 
> 
> Testing
> ---
> 
> usage_events table has now entries for new types:
> select * from usage_event where type like "VM%CREATE%"
>id: 25
>  type: VM.CREATE.IMPLICIT
>account_id: 2
>   created: 2013-07-29 15:46:36
>   zone_id: 1
>   resource_id: 7
> resource_name: c85cbc76-36fb-4fdc-97d6-8179f670cc54
>   offering_id: 15
>   template_id: 5
>  size: NULL
> resource_type: XenServer
> processed: 0
>  virtual_size: NULL
> 
> 
> Build passed.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

RE: [DISCUSS] maven dependencies...

[Alex Huang]

Chip and Donal,

I should have replied to this earlier.  I changed from a logging category of 
[cloud.vm.VirtualMachineManagerImpl] to [c.c.v.VirtualMachineManagerImpl].  
It's shorter and really no one looks at the package any more with editors that 
can open any file from any package but every so often you need it and having 
the package abbreviation comes in handy.  To do that I changed from %{c3} to 
%{c1.} but it required the use of EnhancedPatternLayout.

What I failed to notice (because the startup log rolls by so fast) is that some 
of the appenders are not using EnhancedPatternLayout.

I've already put in a fix after Donal's email to put the ones that are using 
PatternLayout to go back to the old %{c3}.  They're specific to syslog and snmp 
so I didn't want to screw up anything in those implementations.

I will revert Chip's commit that changed all the rest of them to %{c1} unless 
we rather not have the package abbreviations.

--Alex

> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Tuesday, July 30, 2013 6:05 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] maven dependencies...
> 
> On Mon, Jul 29, 2013 at 08:40:44PM +, Donal Lafferty wrote:
> > Could you also have a look at ./client/tomcatconf/log4j-cloud.xml.in?
> >
> > It looks like it was updated in the refactor.
> >
> > AFAIK, in '', {1.} should be {1}.
> >
> > See "Conversion Character" chart under
> http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayou
> t.html
> >
> > There's a lot of paper work for me to make the update :(
> >
> > DL
> 
> Done!
> 
> commit 4c729e7

Re: Review Request 13061: Unable to create the Internal LB vm.

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13061/#review24233
---


Review 13061 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #84 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/84/

- Jenkins Cloudstack.org


On July 30, 2013, 1:07 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13061/
> ---
> 
> (Updated July 30, 2013, 1:07 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, and Ram 
> Ganesh.
> 
> 
> Bugs: 3924
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue:
> ==
> Unable to created internalLB Vm. this is due while determining maxconn value 
> from networkoffering.
> to find the networking offering, networkid is passed instead of 
> networkoffering id which is causing the issue.
> 
> fixed:
> =
> fixed the issue by passing the network offering id instead of network id.
> 
> 
> Diffs
> -
> 
>   
> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java
>  76507e9 
> 
> Diff: https://reviews.apache.org/r/13061/diff/
> 
> 
> Testing
> ---
> 
> 1. was able to create the 'b' vm. internal LB VM.
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 13055: Fix to select default vpc offering with internal lb

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/#review24234
---



test/integration/smoke/test_internal_lb.py


we should not use the ids to list. How about list the vpcoffering based on 
the name? and then use the returned uuid.



test/integration/smoke/test_network_acl.py


we should not use the ids to list. How about list the vpcoffering based on 
the name? and then use the returned uuid.


- Prasanna Santhanam


On July 30, 2013, 6:51 a.m., SrikanteswaraRao Talluri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13055/
> ---
> 
> (Updated July 30, 2013, 6:51 a.m.)
> 
> 
> Review request for cloudstack, venkata swamy babu  budumuru and Prasanna 
> Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3923
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When there are multiple VPC offerings, test is failing because list VPC 
> offering is listing multiple vpc offerings.
> 
> Test requires to select the default VPC offering which has lb service as 
> internal LB which has id=1.
> 
> fix is to select vpc offering with id=1
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_internal_lb.py 0535d6a 
>   test/integration/smoke/test_network_acl.py 4b3c1f7 
> 
> Diff: https://reviews.apache.org/r/13055/diff/
> 
> 
> Testing
> ---
> 
> tested.
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>

Re: Review Request 13056: CLOUDSTACK-3168: Fix test_reboot_router.py to ssh using public IP

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13056/#review24236
---


Commit 906ea82572ad51b093b06369e9d6e3eabf777492 in branch refs/heads/master 
from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=906ea82 ]

CLOUDSTACK-3168: Fix test_reboot_router.py to ssh using public IP

test_reboot_router.py was trying to ssh to vm using private IP
and hence it failed with error "No route to host."
Fixed the testcase to ssh using public IP.

Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On July 30, 2013, 7:17 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13056/
> ---
> 
> (Updated July 30, 2013, 7:17 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3168
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> test_reboot_router.py was trying to ssh to vm using private IP
> and hence it failed with error "No route to host."
> Fixed the testcase to ssh using public IP.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_network.py dad5630 
> 
> Diff: https://reviews.apache.org/r/13056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 13056: CLOUDSTACK-3168: Fix test_reboot_router.py to ssh using public IP

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13056/#review24237
---

Ship it!


- Prasanna Santhanam


On July 30, 2013, 7:17 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13056/
> ---
> 
> (Updated July 30, 2013, 7:17 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3168
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> test_reboot_router.py was trying to ssh to vm using private IP
> and hence it failed with error "No route to host."
> Fixed the testcase to ssh using public IP.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_network.py dad5630 
> 
> Diff: https://reviews.apache.org/r/13056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 13056: CLOUDSTACK-3168: Fix test_reboot_router.py to ssh using public IP

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13056/#review24235
---


Commit 6ec4e5722807b0cdf75104ed61889f1e56efae02 in branch refs/heads/4.2 from 
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6ec4e57 ]

CLOUDSTACK-3168: Fix test_reboot_router.py to ssh using public IP

test_reboot_router.py was trying to ssh to vm using private IP
and hence it failed with error "No route to host."
Fixed the testcase to ssh using public IP.

Signed-off-by: Prasanna Santhanam 
(cherry picked from commit 003721a085210afe167fbc734abe4cc8e2d3d23f)


- ASF Subversion and Git Services


On July 30, 2013, 7:17 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13056/
> ---
> 
> (Updated July 30, 2013, 7:17 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3168
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> test_reboot_router.py was trying to ssh to vm using private IP
> and hence it failed with error "No route to host."
> Fixed the testcase to ssh using public IP.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_network.py dad5630 
> 
> Diff: https://reviews.apache.org/r/13056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 13022: Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13022/
---

(Updated July 30, 2013, 2:47 p.m.)


Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.


Changes
---

rebased the patch with master.


Bugs: Cloustack-3910


Repository: cloudstack-git


Description
---

Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.
https://issues.apache.org/jira/browse/CLOUDSTACK-3910


Diffs (updated)
-

  engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 61e6781 
  setup/db/db/schema-410to420.sql f392603 

Diff: https://reviews.apache.org/r/13022/diff/


Testing
---

Tested upgrade from 3.0.6 to 4.2


Thanks,

bharat kumar

Re: [DISCUSS] maven dependencies...

[Chip Childers]

On Tue, Jul 30, 2013 at 10:22 AM, Alex Huang  wrote:

> Chip and Donal,
>
> I should have replied to this earlier.  I changed from a logging category
> of [cloud.vm.VirtualMachineManagerImpl] to
> [c.c.v.VirtualMachineManagerImpl].  It's shorter and really no one looks at
> the package any more with editors that can open any file from any package
> but every so often you need it and having the package abbreviation comes in
> handy.  To do that I changed from %{c3} to %{c1.} but it required the use
> of EnhancedPatternLayout.
>
> What I failed to notice (because the startup log rolls by so fast) is that
> some of the appenders are not using EnhancedPatternLayout.
>
> I've already put in a fix after Donal's email to put the ones that are
> using PatternLayout to go back to the old %{c3}.  They're specific to
> syslog and snmp so I didn't want to screw up anything in those
> implementations.
>
> I will revert Chip's commit that changed all the rest of them to %{c1}
> unless we rather not have the package abbreviations.
>
>
Good clarification.  Revert away.


> --Alex
>
> > -Original Message-
> > From: Chip Childers [mailto:chip.child...@sungard.com]
> > Sent: Tuesday, July 30, 2013 6:05 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [DISCUSS] maven dependencies...
> >
> > On Mon, Jul 29, 2013 at 08:40:44PM +, Donal Lafferty wrote:
> > > Could you also have a look at ./client/tomcatconf/log4j-cloud.xml.in?
> > >
> > > It looks like it was updated in the refactor.
> > >
> > > AFAIK, in '', {1.} should be {1}.
> > >
> > > See "Conversion Character" chart under
> >
> http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayou
> > t.html
> > >
> > > There's a lot of paper work for me to make the update :(
> > >
> > > DL
> >
> > Done!
> >
> > commit 4c729e7
>
>

Re: Network Problem

[Thomas Schneider]

Hi,

I created a Security Group that allow all traffic by default in both way.
I can ssh to a VM, but when I install LAMP I can't reach the web server.
Do you have an idea of the problem ?

Regards


Le 30/07/2013 03:11, Jijun a écrit :
> Hi ,
> Basic Network will setup the security group, and it will deny all the
> inbound traffic and allow outbound traffic.
>
> you should manually add some ingress rules.
>
> offical document:
>
> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Installation_Guide/security-groups.html
>
>
>
> On 07/30/2013 01:34 AM, Thomas Schneider wrote:
>> Hello,
>>
>> I have setup cloudstack and it work fine, I can launch VM etc...
>> But the problem is I can only SSH to the VM from the host on which she
>> is running.
>> When I am in the vm I can ping exernal network and download package to
>> setup lamp for example.
>>
>> I'm in basic network mode
>> My config is:
>>
>> mgmt srv: 10.10.10.20
>> host1: 10.10.10.30
>> host2: 10.10.10.31
>> nfs for storage 10.10.10.100
>>
>> pod pool 10.10.10.110 - 150
>> guest pool 10.10.10.200 -250
>>
>> and my network config on the host in /etc/init.d/networking/interface
>> is:
>> ---
>> auto p49p1
>> iface p49p1 inet manual
>>
>> auto cloudbr0
>> iface cloudbr0 inet static
>>  bridge_ports p49p1
>>  address 10.10.10.31
>>  netmask 255.255.255.0
>>  network 10.10.10.0
>>  broadcast 10.10.10.255
>>  gateway 10.10.10.254
>>  # dns-* options are implemented by the resolvconf package, if
>> installed
>>  dns-nameservers 10.1.1.2
>> ---
>>
>> I also with to use OpenVSwitch but I didn't found a lot of documentation
>> for configuring in basic nework mode on ubuntu.
>>
>> Tkanks for your Help.
>>
>> Best Regards,
>>
>
>


-- 
*Thomas Schneider*

Review Request 13063: Disables password changing from the API when LDAP is enabled.

[Ian Duffy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13063/
---

Review request for cloudstack and Abhinandan Prateek.


Repository: cloudstack-git


Description
---

Disables password changing from the API when LDAP is enabled.


Diffs
-

  api/src/org/apache/cloudstack/api/LdapValidator.java PRE-CREATION 
  api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
60d1a97 
  api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
52ec2ab 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 b6fb3e8 

Diff: https://reviews.apache.org/r/13063/diff/


Testing
---

Compiled... unit tests passed.

Enabled LDAP... attempted to change password, failed as expected.
Disabled LDAP... attempted to change password, success as expected.


Thanks,

Ian Duffy

Re: Review Request 13063: Disables password changing from the API when LDAP is enabled.

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13063/#review24241
---


Review 13063 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #85 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/85/

- Jenkins Cloudstack.org


On July 30, 2013, 3:20 p.m., Ian Duffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13063/
> ---
> 
> (Updated July 30, 2013, 3:20 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Disables password changing from the API when LDAP is enabled.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/LdapValidator.java PRE-CREATION 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> 60d1a97 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> 52ec2ab 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
>  b6fb3e8 
> 
> Diff: https://reviews.apache.org/r/13063/diff/
> 
> 
> Testing
> ---
> 
> Compiled... unit tests passed.
> 
> Enabled LDAP... attempted to change password, failed as expected.
> Disabled LDAP... attempted to change password, success as expected.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>

Re: Review Request 12967: Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12967/
---

(Updated July 30, 2013, 3:55 p.m.)


Review request for cloudstack, Kishan Kavala and Nitin Mehta.


Changes
---

Changed the naming convention and fixed the reserve memory recalculate.


Bugs: Cloudstack-1695


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-1695
Not enough cpu avialable in cluster according to new overcommit ratio but all 
stopped Vms can be started without any failure(required cpu for stopped vm is 
>> available cpu )


Diffs (updated)
-

  server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f 

Diff: https://reviews.apache.org/r/12967/diff/


Testing
---

Tested on old master.
This happened because we were not recalculating the used and the reserved 
capacities based on the new overcommit ratio. 

Now used and reserved capacities of all the hosts in a overcommited cluster 
will be recalculated on overcommit change by the capacity checker. However this 
will happen only when capacity checker runs meaning the change in capacities 
due to updated overcommit values will not be instantaneous.
  


Thanks,

bharat kumar

Re: Network Problem

[Ahmad Emneina]

guest os firewall?


On Tue, Jul 30, 2013 at 8:14 AM, Thomas Schneider <
thomas.schnei...@euskill.com> wrote:

> Hi,
>
> I created a Security Group that allow all traffic by default in both way.
> I can ssh to a VM, but when I install LAMP I can't reach the web server.
> Do you have an idea of the problem ?
>
> Regards
>
>
> Le 30/07/2013 03:11, Jijun a écrit :
> > Hi ,
> > Basic Network will setup the security group, and it will deny all the
> > inbound traffic and allow outbound traffic.
> >
> > you should manually add some ingress rules.
> >
> > offical document:
> >
> >
> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Installation_Guide/security-groups.html
> >
> >
> >
> > On 07/30/2013 01:34 AM, Thomas Schneider wrote:
> >> Hello,
> >>
> >> I have setup cloudstack and it work fine, I can launch VM etc...
> >> But the problem is I can only SSH to the VM from the host on which she
> >> is running.
> >> When I am in the vm I can ping exernal network and download package to
> >> setup lamp for example.
> >>
> >> I'm in basic network mode
> >> My config is:
> >>
> >> mgmt srv: 10.10.10.20
> >> host1: 10.10.10.30
> >> host2: 10.10.10.31
> >> nfs for storage 10.10.10.100
> >>
> >> pod pool 10.10.10.110 - 150
> >> guest pool 10.10.10.200 -250
> >>
> >> and my network config on the host in /etc/init.d/networking/interface
> >> is:
> >> ---
> >> auto p49p1
> >> iface p49p1 inet manual
> >>
> >> auto cloudbr0
> >> iface cloudbr0 inet static
> >>  bridge_ports p49p1
> >>  address 10.10.10.31
> >>  netmask 255.255.255.0
> >>  network 10.10.10.0
> >>  broadcast 10.10.10.255
> >>  gateway 10.10.10.254
> >>  # dns-* options are implemented by the resolvconf package, if
> >> installed
> >>  dns-nameservers 10.1.1.2
> >> ---
> >>
> >> I also with to use OpenVSwitch but I didn't found a lot of documentation
> >> for configuring in basic nework mode on ubuntu.
> >>
> >> Tkanks for your Help.
> >>
> >> Best Regards,
> >>
> >
> >
>
>
> --
> *Thomas Schneider*
>
>

Re: Review Request 10776: CLOUDSTACK-2191: Added the following to tests to qualify "Optional Public IP" changes happend in EIP enabled Zone

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10776/#review24242
---


Can you make these changes now that you have commit access? Or discard the 
review request as appropriate?

- Prasanna Santhanam


On April 25, 2013, 2:40 p.m., venkata swamy babu  budumuru wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10776/
> ---
> 
> (Updated April 25, 2013, 2:40 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, SrikanteswaraRao Talluri, 
> and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-2191
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2191: Added the following to tests to qualify "Optional Public 
> IP" changes happend in EIP enabled Zone
> 1. Verify that the EIP zone is created with "AssociatePublicIp" 
> capability set to "false"
> 2. Verify that VM doesn't get public ip by default after 
> deployVirtualMachine
> 3. Eanble static NAT and verify EIP semantics
> 4. disable static NAT and verify EIP semantics
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_eip_optional_publicip.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10776/diff/
> 
> 
> Testing
> ---
> 
> Encountered few bugs while doing pilot run of the suite hence, couldn't test 
> it completely.
> 
> Bugs encountered during the run are :
> 
> CLOUDSTACK-2193 https://issues.apache.org/jira/browse/CLOUDSTACK-2193
> CLOUDSTACK-2192 https://issues.apache.org/jira/browse/CLOUDSTACK-2192
> 
> 
> Thanks,
> 
> venkata swamy babu  budumuru
> 
>

Re: Review Request 10776: CLOUDSTACK-2191: Added the following to tests to qualify "Optional Public IP" changes happend in EIP enabled Zone

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10776/
---

(Updated July 30, 2013, 4:07 p.m.)


Review request for cloudstack.


Bugs: CLOUDSTACK-2191


Repository: cloudstack-git


Description
---

CLOUDSTACK-2191: Added the following to tests to qualify "Optional Public 
IP" changes happend in EIP enabled Zone
1. Verify that the EIP zone is created with "AssociatePublicIp" capability 
set to "false"
2. Verify that VM doesn't get public ip by default after 
deployVirtualMachine
3. Eanble static NAT and verify EIP semantics
4. disable static NAT and verify EIP semantics


Diffs
-

  test/integration/component/test_eip_optional_publicip.py PRE-CREATION 

Diff: https://reviews.apache.org/r/10776/diff/


Testing
---

Encountered few bugs while doing pilot run of the suite hence, couldn't test it 
completely.

Bugs encountered during the run are :

CLOUDSTACK-2193 https://issues.apache.org/jira/browse/CLOUDSTACK-2193
CLOUDSTACK-2192 https://issues.apache.org/jira/browse/CLOUDSTACK-2192


Thanks,

venkata swamy babu  budumuru

RE: [DISCUSS] maven dependencies...

[Donal Lafferty]

BTW, how is the dependency on org.apache.commons.io.FileUtils expressed?  Has 
this code changed recently?

Using this morning's master, the management server can't find the FileUtils 
class.  I.e.

INFO  [ConfigurationServerImpl] (Timer-2:null) Generated SSL keystore.
Exception in thread "Timer-2" java.lang.NoClassDefFoundError: 
org/apache/commons/io/FileUtils
at 
com.cloud.server.ConfigurationServerImpl.getBase64Keystore(ConfigurationServerImpl.java:453)
at 
com.cloud.server.ConfigurationServerImpl.updateSSLKeystore(ConfigurationServerImpl.java:520)
at 
com.cloud.server.ConfigurationServerImpl.persistDefaultValues(ConfigurationServerImpl.java:289)
at 
com.cloud.server.ConfigurationServerImpl_EnhancerByCloudStack_4741108b.CGLIB$persistDefaultValues$14()
at 
com.cloud.server.ConfigurationServerImpl_EnhancerByCloudStack_4741108b_FastClassByCloudStack_d48cf40f.invoke()
at net.sf.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:228)
at 
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at 
com.cloud.server.ConfigurationServerImpl_EnhancerByCloudStack_4741108b.persistDefaultValues()
at 
com.cloud.server.ConfigurationServerImpl.configure(ConfigurationServerImpl.java:157)
at 
com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(ComponentContext.java:111)
at 
com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)
Caused by: java.lang.ClassNotFoundException: org.apache.commons.io.FileUtils
at 
org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:244)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:230)
at 
org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:401)
at 
org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:363)
... 13 more

> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: 30 July 2013 4:12 PM
> To: 
> Subject: Re: [DISCUSS] maven dependencies...
> 
> On Tue, Jul 30, 2013 at 10:22 AM, Alex Huang 
> wrote:
> 
> > Chip and Donal,
> >
> > I should have replied to this earlier.  I changed from a logging
> > category of [cloud.vm.VirtualMachineManagerImpl] to
> > [c.c.v.VirtualMachineManagerImpl].  It's shorter and really no one
> > looks at the package any more with editors that can open any file from
> > any package but every so often you need it and having the package
> > abbreviation comes in handy.  To do that I changed from %{c3} to
> > %{c1.} but it required the use of EnhancedPatternLayout.
> >
> > What I failed to notice (because the startup log rolls by so fast) is
> > that some of the appenders are not using EnhancedPatternLayout.
> >
> > I've already put in a fix after Donal's email to put the ones that are
> > using PatternLayout to go back to the old %{c3}.  They're specific to
> > syslog and snmp so I didn't want to screw up anything in those
> > implementations.
> >
> > I will revert Chip's commit that changed all the rest of them to %{c1}
> > unless we rather not have the package abbreviations.
> >
> >
> Good clarification.  Revert away.
> 
> 
> > --Alex
> >
> > > -Original Message-
> > > From: Chip Childers [mailto:chip.child...@sungard.com]
> > > Sent: Tuesday, July 30, 2013 6:05 AM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: [DISCUSS] maven dependencies...
> > >
> > > On Mon, Jul 29, 2013 at 08:40:44PM +, Donal Lafferty wrote:
> > > > Could you also have a look at ./client/tomcatconf/log4j-cloud.xml.in?
> > > >
> > > > It looks like it was updated in the refactor.
> > > >
> > > > AFAIK, in '', {1.} should be {1}.
> > > >
> > > > See "Conversion Character" chart under
> > >
> > http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLa
> > you
> > > t.html
> > > >
> > > > There's a lot of paper work for me to make the update :(
> > > >
> > > > DL
> > >
> > > Done!
> > >
> > > commit 4c729e7
> >
> >

Re: Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13016/#review24244
---

Ship it!


commit a5054c1cde40eca3f6869a645331fbfd0332d398

- Kishan Kavala


On July 30, 2013, 6:17 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13016/
> ---
> 
> (Updated July 30, 2013, 6:17 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3848
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 6f1eed6 
>   
> api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java
>  a077e24 
>   api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 758d9c1 
>   server/src/com/cloud/server/ManagementServerImpl.java 996c693 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 
>   usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd 
> 
> Diff: https://reviews.apache.org/r/13016/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Open up ports beyond 80/443/8080 for downloading templates

[Min Chen]

Prasanna,
Based on your comment, what will happen if we remove that check and 
still
NFS as secondary storage? In that case, register template is still done
through
SSVM. Any side effect? I had the same question as Tom when I was doing
object store refactoring, but hesitated to remove it because of not
knowing the history of it.

Thanks
-min

On 7/29/13 11:45 PM, "Prasanna Santhanam"  wrote:

>On Tue, Jul 30, 2013 at 03:37:39PM +0900, Thomas O'Dowd wrote:
>> Thanks Ian. I had a look at this file. It's an easy fix to remove the
>> check from here but it's a general utility function so will also affect
>> other uris... If there is no reason to limit any uri to those ports then
>> I'd like to remove this check and open them up.
>> 
>> Interested to hear opinions,
>
>This is probably because earlier one would interact only with the SSVM
>to download any images off of secondary storage. With 4.2 that ability
>is transferred to the image store like say s3/cloudian and one can get
>direct http access to the image on the object store. The code in
>validateUrl assumes that the url check goes always to the SSVM on
>which only 80/443/8080 are open by default.
>
>-- 
>Prasanna.,
>
>
>Powered by BigRock.com
>

Re: Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13016/#review24243
---


Commit a5054c1cde40eca3f6869a645331fbfd0332d398 in branch refs/heads/4.2 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a5054c1 ]

CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM


- ASF Subversion and Git Services


On July 30, 2013, 12:47 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13016/
> ---
> 
> (Updated July 30, 2013, 12:47 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3848
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 6f1eed6 
>   
> api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java
>  a077e24 
>   api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 758d9c1 
>   server/src/com/cloud/server/ManagementServerImpl.java 996c693 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 
>   usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd 
> 
> Diff: https://reviews.apache.org/r/13016/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12966: overcommited memory is not getting displayed at zone level and used % is based on actual memory

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12966/#review24248
---

Ship it!


commit 6e9bf56cf195f990cf4b37556d0f5e796de2238a

- Kishan Kavala


On July 30, 2013, 7:41 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12966/
> ---
> 
> (Updated July 30, 2013, 7:41 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-1640
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-1640
> overcommited memory is not getting displayed at zone level and used % is 
> based on actual memory
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java dc2899f 
>   server/src/com/cloud/alert/AlertManagerImpl.java bff36c7 
>   server/src/com/cloud/api/ApiResponseHelper.java f7b740b 
>   server/src/com/cloud/server/ManagementServerImpl.java 0bdb114 
> 
> Diff: https://reviews.apache.org/r/12966/diff/
> 
> 
> Testing
> ---
> 
> Tested on older master.
> deployed vms and checked the capacites displayed on the dashboard.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Review Request 13065: Add support for memberof filter i.e. groups within LDAP.

[Ian Duffy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13065/
---

Review request for cloudstack and Abhinandan Prateek.


Repository: cloudstack-git


Description
---

Add support for memberof filter i.e. groups within LDAP.


Diffs
-

  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
 d0ae4d2 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java
 f255752 
  server/src/com/cloud/configuration/Config.java 1ec0576 
  setup/db/db/schema-410to420.sql f4cd1b1 

Diff: https://reviews.apache.org/r/13065/diff/


Testing
---

Tested against active directory, worked successfully.

If the value is left empty its not applied.


Thanks,

Ian Duffy

Re: Review Request 10776: CLOUDSTACK-2191: Added the following to tests to qualify "Optional Public IP" changes happend in EIP enabled Zone

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10776/#review24252
---


Review 10776 PASSED the build test
The url of build cloudstack-master-with-patch #86 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/86/

- Jenkins Cloudstack.org


On July 30, 2013, 4:07 p.m., venkata swamy babu  budumuru wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10776/
> ---
> 
> (Updated July 30, 2013, 4:07 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-2191
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2191: Added the following to tests to qualify "Optional Public 
> IP" changes happend in EIP enabled Zone
> 1. Verify that the EIP zone is created with "AssociatePublicIp" 
> capability set to "false"
> 2. Verify that VM doesn't get public ip by default after 
> deployVirtualMachine
> 3. Eanble static NAT and verify EIP semantics
> 4. disable static NAT and verify EIP semantics
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_eip_optional_publicip.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10776/diff/
> 
> 
> Testing
> ---
> 
> Encountered few bugs while doing pilot run of the suite hence, couldn't test 
> it completely.
> 
> Bugs encountered during the run are :
> 
> CLOUDSTACK-2193 https://issues.apache.org/jira/browse/CLOUDSTACK-2193
> CLOUDSTACK-2192 https://issues.apache.org/jira/browse/CLOUDSTACK-2192
> 
> 
> Thanks,
> 
> venkata swamy babu  budumuru
> 
>

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

[Min Chen]

> On July 28, 2013, 3:59 a.m., Min Chen wrote:
> > server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 249
> > 
> >
> > This is not right. For cross-zone template, in 
> > HypervisorTemplateAdapter.create(TemplateProfile) method, you will see that 
> > there is a for-loop to download the template to each image store for each 
> > zone. For each image store, this createTemplateAsyncCallback will be 
> > invoked. So in this callback, you should just generate usage event for this 
> > zone.
> 
> Saksham Srivastava wrote:
> The reason I do it is because, this part of code will be executed only 
> once even when template is cross zone.
> If I do not generate all the events here, only the first template that 
> got created will publish the usage event.
> Usage records do not have the information about store id, so we cannot be 
> sure if the usage_record for that store id is already created or not.
> 
> It is too much of unnecessary hack to bypass the root issue, I am 
> discarding the whole patch and will wait for the root cause (2 async call 
> backs for a single register-template) to get fix.
> Then it won't be required to do this.

I disagree on this. Yes, Usage event will not have store id information, but it 
has zone information. For zone-wide image store, your code of searching for 
duplicate should use zone_id to filter as well.


- Min


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12968/#review24049
---


On July 27, 2013, 6:58 p.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12968/
> ---
> 
> (Updated July 27, 2013, 6:58 p.m.)
> 
> 
> Review request for cloudstack and Min Chen.
> 
> 
> Bugs: 3686
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Registering a template does not generate a usage event.
> The process should generate a usage event when the template is 100% 
> downloaded.
> Added a new usage event that has virtual_size also as a parameter.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 
>   engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java cda02ef 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 4b3cade 
> 
> Diff: https://reviews.apache.org/r/12968/diff/
> 
> 
> Testing
> ---
> 
> Now usage_event table is getting updated with the new usage_event.
> 
>  select * from usage_event where id = 23;
> ++-++-+-+-+---+-+-+--+---+---+--+
> | id | type| account_id | created | zone_id | 
> resource_id | resource_name | offering_id | template_id | size | 
> resource_type | processed | virtual_size |
> ++-++-+-+-+---+-+-+--+---+---+--+
> | 23 | TEMPLATE.CREATE |  2 | 2013-07-26 12:04:29 |   0 | 
> 215 | r8|NULL |NULL | 1628 | NULL  |  
>0 | 16777216 |
> ++-++-+-+-+---+-+-+--+---+---+--+
> 
> 
> Build passed.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

RE: [VOTE] Apache Cloudstack 4.1.1 (Second Round)

[Alex Huang]

+1 (binding) 

Ran it on Ubuntu in Basic mode zone with XenServers.  Tested start, stop, SG.

I really dislike that we have to put in the vhdutil by hand.  I keep forgetting 
it.  It's not a stopper though.

--Alex

> -Original Message-
> From: Wido den Hollander [mailto:w...@widodh.nl]
> Sent: Saturday, July 27, 2013 11:13 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [VOTE] Apache Cloudstack 4.1.1 (Second Round)
> 
> +1 (binding)
> 
> I've upgraded a couple of internal systems and even production systems to
> 4.1.1
> 
> We were facing a couple of bugs in production which lead me to deploy a
> homebrew version of 4.1.1 in our company. The only change is a very small
> change in the security groups script for something in our env, not applicable
> to any other setup.
> 
> So I've tested 4.1.1 on our production Ubuntu 12.04 clusters.
> 
> I have to note though that we run a patched version of libvirt due to this
> issue: https://bugzilla.redhat.com/show_bug.cgi?id=977706
> 
> Building goes fine on my systems and it runs without issues for us on a large
> scale KVM deployment.
> 
> Wido
> 
> On 07/25/2013 08:04 PM, Musayev, Ilya wrote:
> > Hi All,
> >
> > I've created a 4.1.1 release, with the following artifacts up for a vote:
> >
> > Git Branch and Commit SH:
> > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=
> > refs/heads/4.1
> > Commit: d2c646f0a434831bd5aef88b5692c108fe26e718
> >
> > Release notes:
> >
> > http://jenkins.cloudstack.org/view/4.1/job/docs-4.1-releasenotes/23/
> >
> >
> > Source release (checksums and signatures are available at the same
> > location):
> > https://dist.apache.org/repos/dist/dev/cloudstack/4.1/
> >
> > PGP release keys (signed using B7B5E7FD):
> > https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> >
> > Vote will be open for 72 hours.
> >
> > For sanity in tallying the vote, can PMC members please be sure to indicate
> "(binding)" with their vote?
> >
> > [ ] +1  approve
> > [ ] +0  no opinion
> > [ ] -1  disapprove (and reason why)
> >
> > d2c646f0a434831bd5aef88b5692c108fe26e718
> >

Review Request 13072: Print agent host name in logging of agent commands

[Marcus Sorensen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/
---

Review request for cloudstack.


Bugs: CLOUDSTACK-3872


Repository: cloudstack-git


Description
---

Print agent name when logging Commands sent to VM hosts. See bug description.  
I'm not super familiar with this code, so I'd like someone to look over it and 
verify it's the right thing.


Diffs
-

  core/src/com/cloud/agent/transport/Request.java b0fa4cc 
  server/src/com/cloud/agent/manager/AgentManagerImpl.java b157838 

Diff: https://reviews.apache.org/r/13072/diff/


Testing
---

Tested on KVM zone, need help testing others.


Thanks,

Marcus Sorensen

Re: Review Request 13065: Add support for memberof filter i.e. groups within LDAP.

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13065/#review24255
---


Review 13065 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #87 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/87/

- Jenkins Cloudstack.org


On July 30, 2013, 5:06 p.m., Ian Duffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13065/
> ---
> 
> (Updated July 30, 2013, 5:06 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Add support for memberof filter i.e. groups within LDAP.
> 
> 
> Diffs
> -
> 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
>  d0ae4d2 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java
>  f255752 
>   server/src/com/cloud/configuration/Config.java 1ec0576 
>   setup/db/db/schema-410to420.sql f4cd1b1 
> 
> Diff: https://reviews.apache.org/r/13065/diff/
> 
> 
> Testing
> ---
> 
> Tested against active directory, worked successfully.
> 
> If the value is left empty its not applied.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>

Setting API query permissions

[Ian Duffy]

Hi,

I'm having an issue with API query permissions.

I have a getEntityOwnerId() returning ACCOUNT_TYPE_NORMAL / 0 which I
believe should let all authenticated users access it.

However when I test this is not the case.

Am I missing something?

RE: Setting API query permissions

[Alex Huang]

That's not the case.  getEntityOwnerId() should return the actual owner of the 
entity.   Determination of whether someone can access an entity is in one of 
the security adapters and retrieves the caller id instead.

--Alex

> -Original Message-
> From: Ian Duffy [mailto:i...@ianduffy.ie]
> Sent: Tuesday, July 30, 2013 10:45 AM
> To: CloudStack Dev
> Cc: Abhinandan Prateek
> Subject: Setting API query permissions
> 
> Hi,
> 
> I'm having an issue with API query permissions.
> 
> I have a getEntityOwnerId() returning ACCOUNT_TYPE_NORMAL / 0 which I
> believe should let all authenticated users access it.
> 
> However when I test this is not the case.
> 
> Am I missing something?

Re: Review Request 13055: Fix to select default vpc offering with internal lb

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/
---

(Updated July 30, 2013, 6:24 p.m.)


Review request for cloudstack, venkata swamy babu  budumuru and Prasanna 
Santhanam.


Changes
---

Filtering it using 'isdefault=true'


Bugs: CLOUDSTACK-3923


Repository: cloudstack-git


Description
---

When there are multiple VPC offerings, test is failing because list VPC 
offering is listing multiple vpc offerings.

Test requires to select the default VPC offering which has lb service as 
internal LB which has id=1.

fix is to select vpc offering with id=1


Diffs (updated)
-

  test/integration/smoke/test_internal_lb.py 0535d6a 
  test/integration/smoke/test_network_acl.py 4b3c1f7 

Diff: https://reviews.apache.org/r/13055/diff/


Testing
---

tested.


Thanks,

SrikanteswaraRao Talluri

Re: Review Request 13055: Fix to select default vpc offering with internal lb

[SrikanteswaraRao Talluri]

> On July 30, 2013, 2:41 p.m., Prasanna Santhanam wrote:
> > test/integration/smoke/test_internal_lb.py, line 116
> > 
> >
> > we should not use the ids to list. How about list the vpcoffering based 
> > on the name? and then use the returned uuid.

Filtering it using 'isdefault=true'


> On July 30, 2013, 2:41 p.m., Prasanna Santhanam wrote:
> > test/integration/smoke/test_network_acl.py, line 112
> > 
> >
> > we should not use the ids to list. How about list the vpcoffering based 
> > on the name? and then use the returned uuid.

Filtering it using 'isdefault=true'


- SrikanteswaraRao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/#review24234
---


On July 30, 2013, 6:51 a.m., SrikanteswaraRao Talluri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13055/
> ---
> 
> (Updated July 30, 2013, 6:51 a.m.)
> 
> 
> Review request for cloudstack, venkata swamy babu  budumuru and Prasanna 
> Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3923
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When there are multiple VPC offerings, test is failing because list VPC 
> offering is listing multiple vpc offerings.
> 
> Test requires to select the default VPC offering which has lb service as 
> internal LB which has id=1.
> 
> fix is to select vpc offering with id=1
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_internal_lb.py 0535d6a 
>   test/integration/smoke/test_network_acl.py 4b3c1f7 
> 
> Diff: https://reviews.apache.org/r/13055/diff/
> 
> 
> Testing
> ---
> 
> tested.
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>

Re: Review Request 13055: Fix to select default vpc offering with internal lb

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/
---

(Updated July 30, 2013, 6:39 p.m.)


Review request for cloudstack, venkata swamy babu  budumuru and Prasanna 
Santhanam.


Changes
---

uploaded final corrected diff file


Bugs: CLOUDSTACK-3923


Repository: cloudstack-git


Description
---

When there are multiple VPC offerings, test is failing because list VPC 
offering is listing multiple vpc offerings.

Test requires to select the default VPC offering which has lb service as 
internal LB which has id=1.

fix is to select vpc offering with id=1


Diffs (updated)
-

  test/integration/smoke/test_internal_lb.py 0535d6a 
  test/integration/smoke/test_network_acl.py 4b3c1f7 

Diff: https://reviews.apache.org/r/13055/diff/


Testing
---

tested.


Thanks,

SrikanteswaraRao Talluri

RE: blocker bug Vm deployment is failing

[Edison Su]

It's fixed.

> -Original Message-
> From: Shweta Agarwal [mailto:shweta.agar...@citrix.com]
> Sent: Tuesday, July 30, 2013 3:53 AM
> To: dev@cloudstack.apache.org
> Subject: blocker bug Vm deployment is failing
> 
> Hi
> I filed a blocker bug
> Vm deployment is failing on build CloudPlatform-4.2-292-rhel6.3.tar.gz
> https://issues.apache.org/jira/browse/CLOUDSTACK-3944
> 
> Can somebody fix it ASAP .
> 
> Thanks
> Shweta
> 

Virtio

[Jeronimo Garcia]

Hi List.

Is there anyway to load virtio drives by default in my guests.

When  i examine the dumpxls .. virtio isn't enabled by default.

Please let me know.

Re: Virtio

[Simon Weller]

Jeronimo, 


Are you running Windows VMs? If so, create a template using "Other PV" as the 
OS type. 


- Si 

- Original Message -

From: "Jeronimo Garcia"  
To: cloudstack-...@incubator.apache.org 
Sent: Tuesday, July 30, 2013 1:47:29 PM 
Subject: Virtio 

Hi List. 

Is there anyway to load virtio drives by default in my guests. 

When i examine the dumpxls .. virtio isn't enabled by default. 

Please let me know. 

Re: Virtio

[Marcus Sorensen]

Virtio is selected by the OS type of the template that you launch
with. As mentioned, if you register a template with OS type of 'Other
PV', that is a blanket 'turn on virtio', regardless of the operating
system.

On Tue, Jul 30, 2013 at 12:56 PM, Simon Weller  wrote:
> Jeronimo,
>
>
> Are you running Windows VMs? If so, create a template using "Other PV" as the 
> OS type.
>
>
> - Si
>
> - Original Message -
>
> From: "Jeronimo Garcia" 
> To: cloudstack-...@incubator.apache.org
> Sent: Tuesday, July 30, 2013 1:47:29 PM
> Subject: Virtio
>
> Hi List.
>
> Is there anyway to load virtio drives by default in my guests.
>
> When i examine the dumpxls .. virtio isn't enabled by default.
>
> Please let me know.
>

Re: Review Request 13072: Print agent host name in logging of agent commands

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/#review24262
---


Review 13072 PASSED the build test
The url of build cloudstack-master-with-patch #88 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/88/

- Jenkins Cloudstack.org


On July 30, 2013, 5:37 p.m., Marcus Sorensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13072/
> ---
> 
> (Updated July 30, 2013, 5:37 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-3872
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Print agent name when logging Commands sent to VM hosts. See bug description. 
>  I'm not super familiar with this code, so I'd like someone to look over it 
> and verify it's the right thing.
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/transport/Request.java b0fa4cc 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java b157838 
> 
> Diff: https://reviews.apache.org/r/13072/diff/
> 
> 
> Testing
> ---
> 
> Tested on KVM zone, need help testing others.
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>

[ACS42] Release Status Update: After Code Freeze Next Steps

[Animesh Chaturvedi]

Folks code freeze was on 7/29 and starting today we are moving ACS 42 into 
limited updates in preparation for RC on 8/19. Code changes are now limited to 
fixes to blocker and critical bugs only. I need to follow up on doc and 
translations.


There is a tremendous effort going on since last couple of weeks to fix issues 
found during the QA cycle. In last week alone 175 new issues were created and 
250 were resolved. The current unresolved issue count stands at 300+ with 60 
blocker and critical.

Given the high number of blocker and critical and that QA is still filing many 
defects I will follow what Chip did for 4.1 [1]. Up until when we cut the first 
RC on (2013-08-19) committers should continue to check in fixes to 4.2 branch 
for blocker and critical issues. Please do any fixes as cleanly as possible 
(i.e., squash related commits and make sure to avoid messy merge commits as 
much as possible).


For Contributors if you have a fix that needs to go into 4.2, please email the 
list with the subject tag [ACS42] and note the review that contains the patch.  
I'll pick whichever I can, but will also rely on others with commit rights to 
make it efficient.

I will review all commits going into that branch, and will revert anything 
that's outside the scope of that I outlined above (unless there is a discussion 
and consensus on this list to include something else).

There are large number of issues that are resolved but not verified yet. Given 
that the number is huge  with over 300 blocker and critical we need to 
prioritize and verify the ones that were returned by developers as ( Invalid, 
Incomplete, CanNotReproduce, Later, NotAProblem) first.  I have created a 
filter [2] to facilitate identifying these issues. This is no way means not to 
verify other issues but it is to close on the ones that have the most 
likelihood of being reopened during verification.

[1] http://markmail.org/message/qkkxycablpsmogsx
[2] https://issues.apache.org/jira/issues/#?filter=12324570


Thanks
Animesh

Re: Virtio

[Jeronimo Garcia]

Thanks marcus ... i just found out in the doc :)  THanks!!
[image: Inline image 1]


On Tue, Jul 30, 2013 at 1:59 PM, Marcus Sorensen wrote:

> Virtio is selected by the OS type of the template that you launch
> with. As mentioned, if you register a template with OS type of 'Other
> PV', that is a blanket 'turn on virtio', regardless of the operating
> system.
>
> On Tue, Jul 30, 2013 at 12:56 PM, Simon Weller  wrote:
> > Jeronimo,
> >
> >
> > Are you running Windows VMs? If so, create a template using "Other PV"
> as the OS type.
> >
> >
> > - Si
> >
> > - Original Message -
> >
> > From: "Jeronimo Garcia" 
> > To: cloudstack-...@incubator.apache.org
> > Sent: Tuesday, July 30, 2013 1:47:29 PM
> > Subject: Virtio
> >
> > Hi List.
> >
> > Is there anyway to load virtio drives by default in my guests.
> >
> > When i examine the dumpxls .. virtio isn't enabled by default.
> >
> > Please let me know.
> >
>

Re: Virtio

[Jeronimo Garcia]

Since we're talking about KVM etc... , is this limit real? ( it can't be ..
i have more than 50 Vms running )
[image: Inline image 1]


On Tue, Jul 30, 2013 at 2:42 PM, Jeronimo Garcia wrote:

> Thanks marcus ... i just found out in the doc :)  THanks!!
> [image: Inline image 1]
>
>
> On Tue, Jul 30, 2013 at 1:59 PM, Marcus Sorensen wrote:
>
>> Virtio is selected by the OS type of the template that you launch
>> with. As mentioned, if you register a template with OS type of 'Other
>> PV', that is a blanket 'turn on virtio', regardless of the operating
>> system.
>>
>> On Tue, Jul 30, 2013 at 12:56 PM, Simon Weller  wrote:
>> > Jeronimo,
>> >
>> >
>> > Are you running Windows VMs? If so, create a template using "Other PV"
>> as the OS type.
>> >
>> >
>> > - Si
>> >
>> > - Original Message -
>> >
>> > From: "Jeronimo Garcia" 
>> > To: cloudstack-...@incubator.apache.org
>> > Sent: Tuesday, July 30, 2013 1:47:29 PM
>> > Subject: Virtio
>> >
>> > Hi List.
>> >
>> > Is there anyway to load virtio drives by default in my guests.
>> >
>> > When i examine the dumpxls .. virtio isn't enabled by default.
>> >
>> > Please let me know.
>> >
>>
>
>

[GSoC] mid-term report and evaluation

[Sebastien Goasguen]

Hi everyone,

The reports are all in, you can see the latest pdf from jenkins at:

http://jenkins.cloudstack.org/job/docs-4.3-gsoc-guide/lastSuccessfulBuild/artifact/Apache_CloudStack-4.2.0-CloudStack_GSoC_Guide-en-US.pdf

Mentors and students make sure you submit your evaluations before the end of 
the week.

I will be off-line till August 15th.

Cheers,

-Sebastien

Re: Review Request 13060: Mid-term report for Dharmesh's update

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13060/#review24277
---

Ship it!


applied to master, please mark review as submitted

- Sebastien Goasguen


On July 30, 2013, 11:42 a.m., Dharmesh Kakadia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13060/
> ---
> 
> (Updated July 30, 2013, 11:42 a.m.)
> 
> 
> Review request for cloudstack and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> GSoC updates from Dharmesh
> 
> 
> Diffs
> -
> 
>   docs/en-US/gsoc-midsummer-dharmesh.xml 69e417a 
> 
> Diff: https://reviews.apache.org/r/13060/diff/
> 
> 
> Testing
> ---
> 
> Built with publican
> 
> 
> Thanks,
> 
> Dharmesh Kakadia
> 
>

Re: Review Request 13062: Disable password change on UI when ldap is enabled

[Ian Duffy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13062/
---

(Updated July 30, 2013, 8:44 p.m.)


Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.


Changes
---

Fix issues with conditional branches and command permissions.


Repository: cloudstack-git


Description
---

General clean up 
+
Disable password change on UI when ldap is enabled


Diffs (updated)
-

  client/WEB-INF/classes/resources/messages.properties 3e775e0 
  client/tomcatconf/commands.properties.in b275017 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccount.java
 01aebce 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java
 98c9fcf 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy
 27f3dfc 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVOSpec.groovy
 PRE-CREATION 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapCreateAccountCmdSpec.groovy
 PRE-CREATION 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy
 f4d185b 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListAllUsersCmdSpec.groovy
 2756e92 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy
 cf2f9ec 
  plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif f46a383 
  ui/dictionary.jsp eec0264 
  ui/scripts/accounts.js 43b242d 
  ui/scripts/ui-custom/accountsWizard.js 7951553 

Diff: https://reviews.apache.org/r/13062/diff/


Testing
---

Unit tests, ran + looked at.


Thanks,

Ian Duffy

Re: [ACS42] Release Status Update: After Code Freeze Next Steps

[Chip Childers]

On Tue, Jul 30, 2013 at 07:25:14PM +, Animesh Chaturvedi wrote:
> 
> Folks code freeze was on 7/29 and starting today we are moving ACS 42 into 
> limited updates in preparation for RC on 8/19. Code changes are now limited 
> to fixes to blocker and critical bugs only. I need to follow up on doc and 
> translations.
> 
> 
> There is a tremendous effort going on since last couple of weeks to fix 
> issues found during the QA cycle. In last week alone 175 new issues were 
> created and 250 were resolved. The current unresolved issue count stands at 
> 300+ with 60 blocker and critical.
> 
> Given the high number of blocker and critical and that QA is still filing 
> many defects I will follow what Chip did for 4.1 [1]. Up until when we cut 
> the first RC on (2013-08-19) committers should continue to check in fixes to 
> 4.2 branch for blocker and critical issues. Please do any fixes as cleanly as 
> possible (i.e., squash related commits and make sure to avoid messy merge 
> commits as much as possible).
> 

The best type of commit for keeping things clean is a cherry-pick.
Merging into the release branch is messy to track as the RM.

> 
> For Contributors if you have a fix that needs to go into 4.2, please email 
> the list with the subject tag [ACS42] and note the review that contains the 
> patch.  I'll pick whichever I can, but will also rely on others with commit 
> rights to make it efficient.
> 
> I will review all commits going into that branch, and will revert anything 
> that's outside the scope of that I outlined above (unless there is a 
> discussion and consensus on this list to include something else).
> 
> There are large number of issues that are resolved but not verified yet. 
> Given that the number is huge  with over 300 blocker and critical we need to 
> prioritize and verify the ones that were returned by developers as ( Invalid, 
> Incomplete, CanNotReproduce, Later, NotAProblem) first.  I have created a 
> filter [2] to facilitate identifying these issues. This is no way means not 
> to verify other issues but it is to close on the ones that have the most 
> likelihood of being reopened during verification.
> 
> [1] http://markmail.org/message/qkkxycablpsmogsx
> [2] https://issues.apache.org/jira/issues/#?filter=12324570
> 
> 
> Thanks
> Animesh
> 

RE: [ACS42] Release Status Update: After Code Freeze Next Steps

[Alex Huang]

> The best type of commit for keeping things clean is a cherry-pick.
> Merging into the release branch is messy to track as the RM.
> 

That should be a rule for release branches after code freeze.

--Alex

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

[Alena Prokharchyk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/#review24293
---


Bharat, applied the patch on the latest 4.2. Created a physical network with 
vnet range:

mysql> select vnet from physical_network;
+---+
| vnet  |
+---+
| 2000-2079 |
+---+

And updatePhysicalNetwork failed to update it with the new vlan range:

http://localhost:8096/?command=updatePhysicalNetwork&id=200&vlan=2001-2010,2012-2013

ERROR [cloud.async.AsyncJobManagerImpl] (Job-Executor-9:job-11 = [ 
58ff063c-1ad6-45d8-89dd-d39dec291c1c ]) Unexpected exception while executing 
org.apache.cloudstack.api.command.admin.network.UpdatePhysicalNetworkCmd
java.lang.NumberFormatException: For input string: "2000,2011"
at 
java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
at java.lang.Integer.parseInt(Integer.java:458)
at java.lang.Integer.parseInt(Integer.java:499)
at 
com.cloud.network.NetworkServiceImpl.getVnetsToremove(NetworkServiceImpl.java:2751)
at 
com.cloud.network.NetworkServiceImpl.addOrRemoveVnets(NetworkServiceImpl.java:2596)
at 
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at 
com.cloud.network.NetworkServiceImpl.updatePhysicalNetwork(NetworkServiceImpl.java:2575)
at 
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at 
org.apache.cloudstack.api.command.admin.network.UpdatePhysicalNetworkCmd.execute(UpdatePhysicalNetworkCmd.java:98)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
at 
com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:680)
ERROR [cloud.api.ApiServer] (ApiServer-1:) invalid request, no command sent


Could you please fix it, as well as give it more QA on 4.2?

- Alena Prokharchyk


On July 30, 2013, 8:53 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12905/
> ---
> 
> (Updated July 30, 2013, 8:53 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
> 
> 
> Bugs: Cloudstack-3753
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3753
> Multiple VLAN range API need to accept a list rather than "add" or "remove" 
> per command
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/NetworkService.java 59ccdbf 
>   
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
>  333564e 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
>   server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 
> 
> Diff: https://reviews.apache.org/r/12905/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> removed the removevlan parameter.
> vlan parameter can be used for both addition and removal of valns.
> instead of passing only a vlan range. user has to pass all the vlan ranges 
> that he wants to keep.
> the vlan ranges missing in the input and present in the db (not allocated) 
> will be removed.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

RE: [ACS42] Release Status Update: After Code Freeze Next Steps

[Animesh Chaturvedi]

> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: Tuesday, July 30, 2013 2:06 PM
> To: dev@cloudstack.apache.org
> Subject: RE: [ACS42] Release Status Update: After Code Freeze Next Steps
> 
> > The best type of commit for keeping things clean is a cherry-pick.
> > Merging into the release branch is messy to track as the RM.
> >
> 
> That should be a rule for release branches after code freeze.
> 
> --Alex
[Animesh>] Thanks for clarifying, we will follow that for 4.2

Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when physical interface name is in pXpY format

[Toshiaki Hatano]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13088/
---

Review request for cloudstack, edison su and Wido den Hollander.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3959


Repository: cloudstack-git


Description
---

CloudStack failed to add kvm host when 'pXpY' name format (udev named) physical 
interface is a member of the bridge (kvm traffic label) on the host.

Root cause is in 
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.matchPifFileInDirectory(String).
There're no handling code for 'pXpY' format interface, so I added that.


Diffs
-

  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 571bcc8 

Diff: https://reviews.apache.org/r/13088/diff/


Testing
---

Tested locally, advanced zone with vlan isolation, kvm hypervisor (ubuntu 
13.04).


Thanks,

Toshiaki Hatano

[ACS42][QA] Blocker and Critical Resolved Issues that need to be closed

[Sudha Ponnaganti]

Community,

Following are the critical and blocker defects that got fixed in 4.2. Pl make 
sure to review the fix / validate and close them

Reporter  Total
Grand Total309
Prasanna Santhanam 28
Sanjeev N   24
Srikanteswararao Talluri24
Sangeetha Hariharan  23
Rayees Namathponnan21
Chandan Purushothama   20
venkata swamybabu budumuru   15
prashant kumar mishra 14
Sateesh Chodapuneedi 13
Sailaja Mada   12
Sheng Yang 8
Harikrishna Patnala 7
angeline shen6
Jayapal Reddy   6
Parth Jagirdar6
sadhu suresh 6
Nitin Mehta5
Rajesh Battala   5
shweta agarwal5
Abhinav Roy   4
Alena Prokharchyk  4
Minying Bao   4
Bharat Kumar3
Devdeep Singh 3
Min Chen3
Murali Reddy 3
Ryan Lei   3
Sowmya Krishnan3
Fang Wang  2
ilya musayev  2
Kishan Kavala 2
Koushik Das2
manasaveloori  2
Rohit Yadav2
Saksham Srivastava 2
Abhinandan Prateek  1
Brian Angus1
Brian Spindler1
Chip Childers  1
Daan Hoogland 1
Girish Shilamkar1
Hiroaki Kawai 1
Joe Brockmeier 1
John Burwell  1
Kelven Yang   1
Kiran Koneti   1
Nick Wales  1
Nicolas Lamirault  1
Radhika Nair   1
satoru nakaya1
Sharad Yadav 1
Simon Weller 1

Thanks
/sudha

Re: [DISCUSS] Should we be releasing -beta releases?

[Nux!]

On 14.05.2013 15:41, Chip Childers wrote:

As a way to get more user feedback on our major feature releases, what
does everyone think about releasing one or two -beta releases for each
major feature release?


Hi,

What has been decided? Will we see any 4.2 betas?

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro