RE: [EVENT] Announcing Apache CloudStack Bangalore December Meetup

[Radhika Puthiyetath]

Please RSVP at http://t.co/Iift0ehUl1


-Original Message-
From: Radhika Puthiyetath [mailto:radhika.puthiyet...@citrix.com] 
Sent: Thursday, November 28, 2013 12:08 PM
To: dev@cloudstack.apache.org; market...@cloudstack.apache.org; CloudStack-Users
Subject: [EVENT] Announcing Apache CloudStack Bangalore December Meetup

Hi All,

Agenda is ready for the last Meetup of the year 2013.  We have the lady 
battalion of Citrix ready to speak about Apache CloudStack. To give them a 
company, Iliyas Shirol, Cloud/BigData Evangelist at InMobi has come up an 
interesting topic.

The agenda is

5.00 - 5.30 PM

Automation Using Marvin Framework
-Sowmya Krishnan, Apache CloudStack Committer

5.30 - 6.15 PM

Troubleshooting Apache CloudStack
-Sailaja Mada and Likitha Shetty, Apache CloudStack Committers

6.20 to 7.15 PM

Nexenta Powered Apache CloudStack
-Iliyas Shirol, Cloud/BigData Evangelist, InMobi

We have not yet finalized the venue; if you are interested to host this event 
at your premises for free, please get in touch with one of the organizers.

Looking forward to meeting you all

-Radhika

Review Request 15902: CLOUDSTACK-4904: Unable to see a derieved template if the parent template is deleted

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15902/
---

Review request for cloudstack and Nitin Mehta.


Bugs: CLOUDSTACK-4904
https://issues.apache.org/jira/browse/CLOUDSTACK-4904


Repository: cloudstack-git


Description
---

CLOUDSTACK-4904: Unable to see a derieved template if the parent template is 
deleted

Added supported for listing all templates/ISOs with showremoved = true


Diffs
-

  api/src/org/apache/cloudstack/api/ApiConstants.java 6f919c1 
  api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java c3f558b 
  api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 
4b34909 
  server/src/com/cloud/api/query/QueryManagerImpl.java 58df38c 
  server/src/com/cloud/api/query/dao/TemplateJoinDao.java f73f5bd 
  server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 468fb83 

Diff: https://reviews.apache.org/r/15902/diff/


Testing
---

Tested locally.

http://localhost:8096/client/api?command=listTemplates&listAll=true&page=1&pagesize=20&templatefilter=all&_=1385533457469&showremoved=true

In the below API response "win" template is removed.

3

f0fdb4d8-fd2f-4fc2-9590-6b45689d2a29
win
win


7240316e-5299-11e3-b8bd-9d3b4dd13283
CentOS 5.6(64-bit) no GUI (XenServer)
CentOS 5.6(64-bit) no GUI (XenServer)


723ff2c6-5299-11e3-b8bd-9d3b4dd13283
SystemVM Template (XenServer)SystemVM Template 
(XenServer)false2013-11-21T16:16:00+0530truefalseVHDfalsetrue72487d10-5299-11e3-b8bd-9d3b4dd13283Debian
 GNU/Linux 
7(32-bit)system0b267864-376e-43ab-8804-57a1a6b9a135xenDownload
 
Complete2101252608SYSTEMXenServerROOT730b0240-5299-11e3-b8bd-9d3b4dd13283falsefb1b6e032a160d86f2c28feb5add6d83falsefalse


Thanks,

Harikrishna Patnala

[EVENT] Announcing Apache CloudStack Bangalore December Meetup

[Radhika Puthiyetath]

Hi All,

Agenda is ready for the last Meetup of the year 2013.  We have the lady 
battalion of Citrix ready to speak about Apache CloudStack. To give them a 
company, Iliyas Shirol, Cloud/BigData Evangelist at InMobi has come up an 
interesting topic.

The agenda is

5.00 - 5.30 PM

Automation Using Marvin Framework
-Sowmya Krishnan, Apache CloudStack Committer

5.30 - 6.15 PM

Troubleshooting Apache CloudStack
-Sailaja Mada and Likitha Shetty, Apache CloudStack Committers

6.20 to 7.15 PM

Nexenta Powered Apache CloudStack
-Iliyas Shirol, Cloud/BigData Evangelist, InMobi

We have not yet finalized the venue; if you are interested to host this event 
at your premises for free, please get in touch with one of the organizers.

Looking forward to meeting you all

-Radhika

Re: Review Request 15832: enable custom offering support for scalevm

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15832/
---

(Updated Nov. 28, 2013, 6:18 a.m.)


Review request for cloudstack and Koushik Das.


Changes
---

Rebased with master.


Bugs: CLOUDSTACK-5161
https://issues.apache.org/jira/browse/CLOUDSTACK-5161


Repository: cloudstack-git


Description
---

enable scaling of a vm using custom offering
CLOUDSTACK-5161


Diffs (updated)
-

  api/src/org/apache/cloudstack/api/ApiConstants.java 7b87264 
  
api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java 
a7c864d 
  
api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
 1357a7d 
  api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 6cb49c1 
  api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 3dfcdf9 
  api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
7ec739e 
  engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f 
  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70 
  engine/schema/src/com/cloud/event/UsageEventVO.java 719a79b 
  engine/schema/src/com/cloud/service/ServiceOfferingVO.java d968de5 
  engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 10d6616 
  engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f1f97fc 
  engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java cd746c2 
  server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 4f351eb 
  server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 2260e1e 
  server/src/com/cloud/capacity/CapacityManagerImpl.java c733c03 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3770eb8 
  server/src/com/cloud/server/ManagementServerImpl.java d34da4f 
  server/src/com/cloud/vm/UserVmManager.java 8463326 
  server/src/com/cloud/vm/UserVmManagerImpl.java c0b0031 
  server/test/com/cloud/vm/UserVmManagerTest.java 71bbebe 
  usage/src/com/cloud/usage/UsageManagerImpl.java 81e7892 

Diff: https://reviews.apache.org/r/15832/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

RE: [PROPOSAL] User VM HA using native XS HA capabilities

[Alex Huang]

That's always been true of VmWare but is not true of XS and KVM.  Losing it 
would mean it's a regression for those hypervisors.

--Alex

> -Original Message-
> From: Koushik Das [mailto:koushik@citrix.com]
> Sent: Wednesday, November 27, 2013 10:12 PM
> To: 
> Subject: Re: [PROPOSAL] User VM HA using native XS HA capabilities
> 
> I looked at the affinity group FS [1]. Based on what I understand with host
> affinity even CS HA won't work if the specific host fails. For cluster/pod
> affinity it will work though. Can someone confirm if this is the case?
> 
> For native XS HA since cluster is where HA gets configured, affinity groups
> can be realised at cluster level. For host affinity to work if the implicit
> assumption is to not make the VM HA enabled then there shouldn't be any
> issues. But there may be scenarios which won't be possible with native HA.
> 
> Also in the FAQ section of [1] I see the following:
> "DRS?
> 
>   *   This is applicable only for placement operations through CloudStack. 
> This
> implementation is to only support scenarios where the HV does not do HA or
> DRS."
> 
> This means that with Vmware (where there is native HA), affinity groups
> doesn't work.
> 
> -Koushik
> 
> [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+-
> +Affinity-Anti-affinity+groups
> 
> On 28-Nov-2013, at 3:29 AM, Alex Huang
> mailto:alex.hu...@citrix.com>> wrote:
> 
> Koushik,
> 
> How do you propose for XS HA to work with CloudStack's host affinity use
> cases?  I don't see anything in the spec regarding this.  I generally don't 
> think
> VM HA can be done with hypervisor HA because of this.
> 
> --Alex
> 
> -Original Message-
> From: Koushik Das [mailto:koushik@citrix.com]
> Sent: Tuesday, November 26, 2013 10:51 PM
> To: mailto:dev@cloudstack.apache.org>>
> Subject: Re: [PROPOSAL] User VM HA using native XS HA capabilities
> 
> I haven't tried in XS 6.1 but in 6.2 if a VM is marked as HA enabled (based on
> ha-restart-priority) in a HA enabled cluster then if the VM is not stopped
> using xapi then it is automatically re-started.
> 
> I tried the following on XS 6.2 and it worked as expected:
> - Logged on to a guest VM marked as HA enabled
> - Ran "shutdown -h now"
> - After sometime the VM got restarted
> 
> -Koushik
> 
> 
> On 27-Nov-2013, at 2:11 AM, Chiradeep Vittal
> mailto:chiradeep.vit...@citrix.com>>
> wrote:
> 
> According to
> http://support.citrix.com/proddocs/topic/xencenter-61/xs-xc-pools-ha-
> about.
> html
> 
> 
> XS HA is about dealing with host failures.
> However CS HA also deals with individual VM failures ("fast restart").
> I hope you are not removing fast VM restart.
> 
> On 11/26/13 6:54 AM, "David Nalley"
> mailto:da...@gnsa.us>> wrote:
> 
> Hi Koushik:
> 
> Thanks for the reply - a few followup comments inline. I look forward to
> seeing this work.
> 
> Other folks: please read the entire thread and the links from Koushik; there's
> a planned deprecation here.
> 
> --David
> 
> On Mon, Nov 25, 2013 at 2:38 AM, Koushik Das
> mailto:koushik@citrix.com>>
> wrote:
> Thanks for the comments David. See inline.
> 
> -Koushik
> 
> On 22-Nov-2013, at 7:31 PM, David Nalley
> mailto:da...@gnsa.us>> wrote:
> 
> Hi Koushik:
> 
> In general I like the idea. A couple of comments:
> 
> The upgrade section has a manual step for enabling HA manually per instance.
> Why a manual step? Why is CloudStack not checking the desired state (e.g. if
> HA is enabled in the instance service group) with the actual state (what is
> reflected on the hypervisor) and changing it when appropriate.
> 
> We are already going to need to reconcile the state (things like host the
> instance is running on will change for instance) with reality already - so it
> seems like making this an automatic step wouldn't be much extra effort and
> would scale far easier.
> 
> [Koushik] Are you suggesting that as part of the upgrade process, all
> impacted VMs should be automatically updated? If so, yes it can be done.
> For now I am keeping it manual, in future the process can be automated.
> 
> 
> Why keeping it manual now? Actually let me rephrase - I can understand why
> someone might not want things changed automagically (as an admin I'd want
> nothing changed by default, but changed if I cared about it in some
> automated fashion) Is there a reason we would not include some
> functionality to let the operator automatically change this on some subset or
> all of the machines in an automated fashion?
> 
> 
> Are there plans on deprecating the custom HA solution, or will it be
> supported forever? If the plan is to deprecate, lets go ahead and start
> planning that/announcing/etc and not let it fall into disrepair.
> 
> [Koushik] That's the plan going forward. For the next release both options
> will be there. Maybe post that the custom HA solution can be removed for XS
> 6.2 and above.
> 
> 
> 
> Please make sure that the deprecation is explicitly called out. E.g 

Re: [PROPOSAL] User VM HA using native XS HA capabilities

[Koushik Das]

I looked at the affinity group FS [1]. Based on what I understand with host 
affinity even CS HA won't work if the specific host fails. For cluster/pod 
affinity it will work though. Can someone confirm if this is the case?

For native XS HA since cluster is where HA gets configured, affinity groups can 
be realised at cluster level. For host affinity to work if the implicit 
assumption is to not make the VM HA enabled then there shouldn't be any issues. 
But there may be scenarios which won't be possible with native HA.

Also in the FAQ section of [1] I see the following:
"DRS?

  *   This is applicable only for placement operations through CloudStack. This 
implementation is to only support scenarios where the HV does not do HA or DRS."

This means that with Vmware (where there is native HA), affinity groups doesn't 
work.

-Koushik

[1] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+-+Affinity-Anti-affinity+groups

On 28-Nov-2013, at 3:29 AM, Alex Huang 
mailto:alex.hu...@citrix.com>> wrote:

Koushik,

How do you propose for XS HA to work with CloudStack's host affinity use cases? 
 I don't see anything in the spec regarding this.  I generally don't think VM 
HA can be done with hypervisor HA because of this.

--Alex

-Original Message-
From: Koushik Das [mailto:koushik@citrix.com]
Sent: Tuesday, November 26, 2013 10:51 PM
To: mailto:dev@cloudstack.apache.org>>
Subject: Re: [PROPOSAL] User VM HA using native XS HA capabilities

I haven't tried in XS 6.1 but in 6.2 if a VM is marked as HA enabled (based on
ha-restart-priority) in a HA enabled cluster then if the VM is not stopped
using xapi then it is automatically re-started.

I tried the following on XS 6.2 and it worked as expected:
- Logged on to a guest VM marked as HA enabled
- Ran "shutdown -h now"
- After sometime the VM got restarted

-Koushik


On 27-Nov-2013, at 2:11 AM, Chiradeep Vittal 
mailto:chiradeep.vit...@citrix.com>>
wrote:

According to
http://support.citrix.com/proddocs/topic/xencenter-61/xs-xc-pools-ha-
about.
html


XS HA is about dealing with host failures.
However CS HA also deals with individual VM failures ("fast restart").
I hope you are not removing fast VM restart.

On 11/26/13 6:54 AM, "David Nalley" mailto:da...@gnsa.us>> wrote:

Hi Koushik:

Thanks for the reply - a few followup comments inline. I look forward
to seeing this work.

Other folks: please read the entire thread and the links from
Koushik; there's a planned deprecation here.

--David

On Mon, Nov 25, 2013 at 2:38 AM, Koushik Das 
mailto:koushik@citrix.com>>
wrote:
Thanks for the comments David. See inline.

-Koushik

On 22-Nov-2013, at 7:31 PM, David Nalley mailto:da...@gnsa.us>> 
wrote:

Hi Koushik:

In general I like the idea. A couple of comments:

The upgrade section has a manual step for enabling HA manually per
instance. Why a manual step? Why is CloudStack not checking the
desired state (e.g. if HA is enabled in the instance service group)
with the actual state (what is reflected on the hypervisor) and
changing it when appropriate.

We are already going to need to reconcile the state (things like
host the instance is running on will change for instance) with
reality already - so it seems like making this an automatic step
wouldn't be much extra effort and would scale far easier.

[Koushik] Are you suggesting that as part of the upgrade process,
all impacted VMs should be automatically updated? If so, yes it can be
done.
For now I am keeping it manual, in future the process can be automated.


Why keeping it manual now? Actually let me rephrase - I can
understand why someone might not want things changed automagically
(as an admin I'd want nothing changed by default, but changed if I
cared about it in some automated fashion) Is there a reason we would
not include some functionality to let the operator automatically
change this on some subset or all of the machines in an automated
fashion?


Are there plans on deprecating the custom HA solution, or will it
be supported forever? If the plan is to deprecate, lets go ahead
and start planning that/announcing/etc and not let it fall into disrepair.

[Koushik] That's the plan going forward. For the next release both
options will be there. Maybe post that the custom HA solution can be
removed for XS 6.2 and above.



Please make sure that the deprecation is explicitly called out. E.g
will be present but deprecated in 4.4 and removed in 4.5; and let's
make sure a doc bug gets filed when this is ready for merge.

--David

RE: system VMs are not coming up on 4.3 on VMware

[Suresh Sadhu]

Talluri,

Seen similar kind of  issue and systemvms are not coming up. Please raise a bug.

Regards
Sadhu


-Original Message-
From: Srikanteswararao Talluri [mailto:srikanteswararao.tall...@citrix.com] 
Sent: 27 November 2013 20:42
To: dev@cloudstack.apache.org
Subject: system VMs are not coming up on 4.3 on VMware

I am hitting the following error while system Vms are coming  on a  zone with 
latest 4.3 code. Has any one seen this?

I could see https://issues.apache.org/jira/browse/CLOUDSTACK-4860 was filed a 
while ago, but I don't see any commits updated there but it is in resolved 
state now.



Unable to copy template to primary storage due to exception:Exception: 
javax.xml.ws.soap.SOAPFaultException

Message:

Required parameter spec is missing


while parsing call information for method ImportVApp

at line 1, column 110


while parsing SOAP body

at line 1, column 102


while parsing SOAP envelope

at line 1, column 38


while parsing HTTP request for method importVApp

on object of type vim.ResourcePool

at line 1, column 0


javax.xml.ws.soap.SOAPFaultException:

Required parameter spec is missing


while parsing call information for method ImportVApp

at line 1, column 110


while parsing SOAP body

at line 1, column 102


while parsing SOAP envelope

at line 1, column 38


while parsing HTTP request for method importVApp

on object of type vim.ResourcePool

at line 1, column 0

at 
com.sun.xml.internal.ws.fault.SOAP11Fault.getProtocolException(SOAP11Fault.java:178)

at 
com.sun.xml.internal.ws.fault.SOAPFaultBuilder.createException(SOAPFaultBuilder.java:119)

at 
com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(SyncMethodHandler.java:108)

at 
com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(SyncMethodHandler.java:78)

at com.sun.xml.internal.ws.client.sei.SEIStub.invoke(SEIStub.java:107)

at $Proxy382.importVApp(Unknown Source)

at 
com.cloud.hypervisor.vmware.mo.HypervisorHostHelper.importVmFromOVF(HypervisorHostHelper.java:1336)

at com.cloud.hypervisor.vmware.mo.HostMO.importVmFromOVF(HostMO.java:749)

at 
com.cloud.storage.resource.VmwareStorageProcessor.copyTemplateFromSecondaryToPrimary(VmwareStorageProcessor.java:161)

at 
com.cloud.storage.resource.VmwareStorageProcessor.copyTemplateToPrimaryStorage(VmwareStorageProcessor.java:221)

at 
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:75)

at 
com.cloud.storage.resource.VmwareStorageSubsystemCommandHandler.execute(VmwareStorageSubsystemCommandHandler.java:155)

at 
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageCommands(StorageSubsystemCommandHandlerBase.java:50)

at 
com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:553)

at 
com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:216)

at 
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)

at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)

at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)

at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)

at 
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)

at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)

at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)

at java.util.concurrent.FutureTask.run(FutureTask.java:166)

at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)

at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)

at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)

at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)

at java.lang.Thread.run(Thread.java:679)

2013-11-28 00:03:05,946 DEBUG [c.c.a.m.DirectAgentAttache] 
(DirectAgent-20:ctx-e249eed1) Seq 3-925171747: Response Received:

~Talluri

Re: JIRA 3061

[Mandar Barve]

Works.

Thanks,
Mandar


On Wed, Nov 27, 2013 at 3:13 PM, Daan Hoogland wrote:

> Can you try again, I put you in the contributers group but i am not
> sure if this gives you enough rights
>
> thanks,
> Daan
>
> On Wed, Nov 27, 2013 at 6:56 AM, Mandar Barve 
> wrote:
> > Thanks Daan for your inputs. It looks like I don't have permissions to
> > assign or change bug state. What should I do to get these?
> >
> > Thanks,
> > Mandar
> >
> >
> > On Tue, Nov 26, 2013 at 2:25 PM, Daan Hoogland  >wrote:
> >
> >> H Mandar,
> >>
> >> You can contact the reporter directly but that would only be to ask to
> >> verify in the newer version. This can be a hassle for small plants. So
> >> you could put to resolved with the right fix-version.
> >>
> >> regards,
> >>
> >>
> >> On Mon, Nov 25, 2013 at 9:00 AM, Mandar Barve  >
> >> wrote:
> >> > Hi all,
> >> >
> >> > Problem: JIRA says list hosts API response didn't return CPU used
> >> parameter
> >> > value. This bug is reported against version 4.0.2.
> >> >
> >> > I could not reproduce this problem with CS version 4.2.
> >> >
> >> > I used CloudMonkey CLI to fire API commands to the management server.
> >> With
> >> > a basic zone created that has 1 pod, cluster and couple of system vms
> >> > connected to the management server using CloudMonkey CLI sent the list
> >> > hosts API command and the JSON response output could be captured in
> the
> >> log
> >> > file. JSON response and the CLI output shows "cpuused". The value seen
> >> here
> >> > could be matched against the portal reported host statistics value for
> >> CPU
> >> > used.
> >> >
> >> > CLI output:
> >> >
> >> >> list hosts
> >> > count = 1
> >> > host:
> >> > id = df4fe805-a320-4417-b8be-22dd0b86561e
> >> > name = devcloud
> >> > capabilities = xen-3.0-x86_32p , hvm
> >> > clusterid = b3b80638-1fc5-4d13-aafc-28ff5155c681
> >> > clustername = test000
> >> > clustertype = CloudManaged
> >> > cpuallocated = 0%
> >> > cpunumber = 2
> >> > cpuspeed = 2486
> >> > *cpuused = 0.22%*
> >> > cpuwithoverprovisioning = 4972.0
> >> > created = 2013-10-07T18:57:58+0530
> >> > disconnected = 2013-10-15T11:24:19+0530
> >> > events = PingTimeout; AgentConnected; HostDown; ShutdownRequested;
> >> > AgentDisconnected; ManagementServerDown; Remove; Ping;
> >> StartAgentRebalance
> >> > hahost = False
> >> > hypervisor = XenServer
> >> > ipaddress = 192.168.56.10
> >> > islocalstorageactive = False
> >> > lastpinged = 1970-01-16T20:20:29+0530
> >> >
> >> >  JSON response log:
> >> >
> >> > 2013-10-15 11:48:32,724 - requester.py:45 - [DEBUG]  START
> >> Request
> >> > 
> >> > 2013-10-15 11:48:32,724 - requester.py:45 - [DEBUG] Requesting
> >> > command=listHosts, args={}
> >> > 2013-10-15 11:48:32,725 - requester.py:45 - [DEBUG] Request sent:
> >> >
> >>
> http://localhost:8080/client/api?apiKey=c9uPXphFfiQS5589hVp245hWrqcg1yxcVNg9h1xJES34j8uAtvKj0EP6h8jlSC5_VlajL1a2TaXuYFGoON0DMg&command=listHosts&response=json&signature=hKQ5hI0XFpAzNPJYJ7ivR53%2FzJU%3D
> >> > 2013-10-15 11:48:32,820 - requester.py:45 - [DEBUG] Response
> received: {
> >> > "listhostsresponse" : { "count":1 ,"host" : [
> >> >
> >>
>  
> {"id":"df4fe805-a320-4417-b8be-22dd0b86561e","name":"devcloud","state":"Up","disconnected":"2013-10-15T11:24:19+0530","type":"Routing","ipaddress":"192.168.56.10","zoneid":"7b015b74-f00f-4216-b523-efc2e32c6bc5","zonename":"DevCloud0","podid":"c58e91d0-ad57-4d09-a485-f0decab857b4","podname":"test00","version":"4.2.0","hypervisor":"XenServer","cpunumber":2,"cpuspeed":2486,"cpuallocated":"0%",
> >> >
> >>
> *"cpuused":"0.22%"*,"cpuwithoverprovisioning":"4972.0","networkkbsread":57462,"networkkbswrite":38105,"memorytotal":251632,"memoryallocated":0,"memoryused":546428,"capabilities":"xen-3.0-x86_32p
> >> > ,
> >> >
> >>
> hvm","lastpinged":"1970-01-16T20:20:29+0530","managementserverid":8796750265493,"clusterid":"b3b80638-1fc5-4d13-aafc-28ff5155c681","clustername":"test000","clustertype":"CloudManaged","islocalstorageactive":false,"created":"2013-10-07T18:57:58+0530","events":"PingTimeout;
> >> > AgentConnected; HostDown; ShutdownRequested; AgentDisconnected;
> >> > ManagementServerDown; Remove; Ping;
> >> > StartAgentRebalance","resourcestate":"Enabled","hahost":false} ] } }
> >> > 2013-10-15 11:48:32,821 - requester.py:45 - [DEBUG]  END
> Request
> >> > 
> >> >
> >> > Can this be closed? I have updated the JIRA with same comment.
> >> >
> >> > Thanks,
> >> > Mandar
> >>
> >>
>
>

Re: [QA][PROPOSAL][ACS4.3] Test plan review: Remote Access VPN Feature on VPC

[Sheng Yang]

Hi Chandan,

I think we can add something more, e.g:
1. Set two tiers, one ACL is allow another is deny. VPN client to the VPC
should able to access the vm in the allow one, but not the vms in the deny
one.
2. One VPN user is current in use, then delete the user from CloudStack,
User should be disconnected.  But the other connected user should not be
affected.

--Sheng


On Wed, Nov 27, 2013 at 5:00 PM, Chandan Purushothama <
chandan.purushoth...@citrix.com> wrote:

> Hello Sheng,
>
> Please review the test plan for feature " Remote Access VPN on VPC
> Feature" and let me know the review comments. The test cases are mentioned
> in an excel sheet attached to the page.
>
> Test Plan  :
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Remote+Access+VPN+on+VPC+Feature+Test+Plan
> Functional Spec:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Remote+Access+VPN+for+VPC
> Bug Id   :
> https://issues.apache.org/jira/browse/CLOUDSTACK-754
>
> Thank you,
> Chandan.
>

Re: Review Request 15832: enable custom offering support for scalevm

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15832/
---

(Updated Nov. 28, 2013, 2:26 a.m.)


Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-5161
https://issues.apache.org/jira/browse/CLOUDSTACK-5161


Repository: cloudstack-git


Description
---

enable scaling of a vm using custom offering
CLOUDSTACK-5161


Diffs (updated)
-

  api/src/org/apache/cloudstack/api/ApiConstants.java 7b87264 
  
api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java 
a7c864d 
  
api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
 1357a7d 
  api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 6cb49c1 
  api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 3dfcdf9 
  api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
7ec739e 
  engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f 
  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70 
  engine/schema/src/com/cloud/event/UsageEventVO.java 719a79b 
  engine/schema/src/com/cloud/service/ServiceOfferingVO.java d968de5 
  engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 10d6616 
  engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f1f97fc 
  server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 4f351eb 
  server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 2260e1e 
  server/src/com/cloud/capacity/CapacityManagerImpl.java c733c03 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3770eb8 
  server/src/com/cloud/server/ManagementServerImpl.java d34da4f 
  server/src/com/cloud/vm/UserVmManager.java 8463326 
  server/src/com/cloud/vm/UserVmManagerImpl.java c0b0031 
  server/test/com/cloud/vm/UserVmManagerTest.java 71bbebe 

Diff: https://reviews.apache.org/r/15832/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

Re: Review Request 15832: enable custom offering support for scalevm

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15832/
---

(Updated Nov. 28, 2013, 2:04 a.m.)


Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-5161
https://issues.apache.org/jira/browse/CLOUDSTACK-5161


Repository: cloudstack-git


Description
---

enable scaling of a vm using custom offering
CLOUDSTACK-5161


Diffs (updated)
-

  api/src/org/apache/cloudstack/api/ApiConstants.java 7b87264 
  
api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java 
a7c864d 
  
api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
 1357a7d 
  api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 6cb49c1 
  api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 3dfcdf9 
  api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
7ec739e 
  engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f 
  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70 
  engine/schema/src/com/cloud/event/UsageEventVO.java 719a79b 
  engine/schema/src/com/cloud/service/ServiceOfferingVO.java d968de5 
  engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 10d6616 
  engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f1f97fc 
  server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 4f351eb 
  server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 2260e1e 
  server/src/com/cloud/capacity/CapacityManagerImpl.java c733c03 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3770eb8 
  server/src/com/cloud/server/ManagementServerImpl.java d34da4f 
  server/src/com/cloud/vm/UserVmManager.java 8463326 
  server/src/com/cloud/vm/UserVmManagerImpl.java c0b0031 
  server/test/com/cloud/vm/UserVmManagerTest.java 71bbebe 

Diff: https://reviews.apache.org/r/15832/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

Re: Getting error while adding Netscaler with the new 10.1 API

[Syed Ahmed]

Got it Vijay.  I have submitted another patch for certificate chaining. 
I have tested with 10.1 and it works. I send a patch for the move to 
10.1 as well.


Thanks,
-Syed

On Wed 27 Nov 2013 04:52:47 AM EST, Vijay Venkatachalam wrote:

In order to continue with the old behavior, use HTTPS but have cert and 
hostname validation turned off, the following has to be done
  nitro_service.set_certvalidation(false);
  nitro_service.set_hostnameverification(false);


-Original Message-
From: Syed Ahmed [mailto:sah...@cloudops.com]
Sent: Wednesday, November 27, 2013 5:58 AM
To: dev@cloudstack.apache.org
Subject: Getting error while adding Netscaler with the new 10.1 API

Hi,

I am trying to move the Netscaler to the 10.1 Nitro API and while using the
new API I am getting the following error when adding Netscaler device

PKIX
   path building failed:
sun.security.provider.certpath.SunCertPathBuilderException: unable to find
valid certification path to requested target


I have changed to use HTTP instead of HTTPS in nitro to temporarily work
around this problem. Is HTTPS absolutely required for communication with
external devices? or does my workaround is a valid fix?

Thanks,
-Syed

Review Request 15897: Add certificate chain support for netscaler.

[Syed Ahmed]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15897/
---

Review request for cloudstack and Murali Reddy.


Bugs: CLOUDSTACK-5296
https://issues.apache.org/jira/browse/CLOUDSTACK-5296


Repository: cloudstack-git


Description
---

This patch adds support for trust chains in the netscaler. 

I initially planned on using the 10.1 API's "bundle" feature but during my 
testing I found that was not working. So I am doing the chain linking myself. 
Also NS can have only one entity of a certificate ie lets say two different 
users try to add the same certificate on the netscaler only one of them will go 
through. The other one says resouce already exists even though they have 
different files. 

This can be a problem in trust chains where the chain can be shared between 
multiple accounts/certificates. So, I am using the figerprint as an identifier 
of a certificate and making sure that we delete it only when no one references 
it. 


Diffs
-

  .gitignore dab1b3f 
  api/src/com/cloud/network/lb/LoadBalancingRule.java 4b2f9c4 
  engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java 99354c5 
  
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
 7dac9a0 
  server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a2eba07 
  server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 17f88bd 
  utils/src/com/cloud/utils/security/CertificateHelper.java e8d20b0 

Diff: https://reviews.apache.org/r/15897/diff/


Testing
---

Testing was done a a 3-length chain with a root, intermediate and a client 
certificate. Two clients share the same intermediate certificate.


Thanks,

Syed Ahmed

[QA][PROPOSAL][ACS4.3] Test plan review: Remote Access VPN Feature on VPC

[Chandan Purushothama]

Hello Sheng,

Please review the test plan for feature " Remote Access VPN on VPC Feature" and 
let me know the review comments. The test cases are mentioned in an excel sheet 
attached to the page.

Test Plan  :   
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Remote+Access+VPN+on+VPC+Feature+Test+Plan
Functional Spec: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Remote+Access+VPN+for+VPC
Bug Id   :   
https://issues.apache.org/jira/browse/CLOUDSTACK-754

Thank you,
Chandan.

Build failed in Jenkins: cloudstack-4.3-maven-build-noredist #40

[jenkins]

See 


Changes:

[Alena Prokharchyk] Resource metadata support for NetworkACLItem

--
[...truncated 575 lines...]
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-s3 ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image Swift provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-swift ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image default provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-default ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image sample provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-sample ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume SolidFire Provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-solidfire ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume default provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-default ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume sample provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-sample ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - SNMP Alerts 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-snmp-alerts ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Syslog Alerts 4.3

RE: [PROPOSAL] User VM HA using native XS HA capabilities

[Alex Huang]

Koushik,

How do you propose for XS HA to work with CloudStack's host affinity use cases? 
 I don't see anything in the spec regarding this.  I generally don't think VM 
HA can be done with hypervisor HA because of this.  

--Alex  

> -Original Message-
> From: Koushik Das [mailto:koushik@citrix.com]
> Sent: Tuesday, November 26, 2013 10:51 PM
> To: 
> Subject: Re: [PROPOSAL] User VM HA using native XS HA capabilities
> 
> I haven't tried in XS 6.1 but in 6.2 if a VM is marked as HA enabled (based on
> ha-restart-priority) in a HA enabled cluster then if the VM is not stopped
> using xapi then it is automatically re-started.
> 
> I tried the following on XS 6.2 and it worked as expected:
> - Logged on to a guest VM marked as HA enabled
> - Ran "shutdown -h now"
> - After sometime the VM got restarted
> 
> -Koushik
> 
> 
> On 27-Nov-2013, at 2:11 AM, Chiradeep Vittal 
> wrote:
> 
> > According to
> > http://support.citrix.com/proddocs/topic/xencenter-61/xs-xc-pools-ha-
> about.
> > html
> >
> >
> > XS HA is about dealing with host failures.
> > However CS HA also deals with individual VM failures ("fast restart").
> > I hope you are not removing fast VM restart.
> >
> > On 11/26/13 6:54 AM, "David Nalley"  wrote:
> >
> >> Hi Koushik:
> >>
> >> Thanks for the reply - a few followup comments inline. I look forward
> >> to seeing this work.
> >>
> >> Other folks: please read the entire thread and the links from
> >> Koushik; there's a planned deprecation here.
> >>
> >> --David
> >>
> >> On Mon, Nov 25, 2013 at 2:38 AM, Koushik Das 
> >> wrote:
> >>> Thanks for the comments David. See inline.
> >>>
> >>> -Koushik
> >>>
> >>> On 22-Nov-2013, at 7:31 PM, David Nalley  wrote:
> >>>
>  Hi Koushik:
> 
>  In general I like the idea. A couple of comments:
> 
>  The upgrade section has a manual step for enabling HA manually per
>  instance. Why a manual step? Why is CloudStack not checking the
>  desired state (e.g. if HA is enabled in the instance service group)
>  with the actual state (what is reflected on the hypervisor) and
>  changing it when appropriate.
> 
>  We are already going to need to reconcile the state (things like
>  host the instance is running on will change for instance) with
>  reality already - so it seems like making this an automatic step
>  wouldn't be much extra effort and would scale far easier.
> >>>
> >>> [Koushik] Are you suggesting that as part of the upgrade process,
> >>> all impacted VMs should be automatically updated? If so, yes it can be
> done.
> >>> For now I am keeping it manual, in future the process can be automated.
> >>>
> >>
> >> Why keeping it manual now? Actually let me rephrase - I can
> >> understand why someone might not want things changed automagically
> >> (as an admin I'd want nothing changed by default, but changed if I
> >> cared about it in some automated fashion) Is there a reason we would
> >> not include some functionality to let the operator automatically
> >> change this on some subset or all of the machines in an automated
> fashion?
> >>
> 
>  Are there plans on deprecating the custom HA solution, or will it
>  be supported forever? If the plan is to deprecate, lets go ahead
>  and start planning that/announcing/etc and not let it fall into 
>  disrepair.
> >>>
> >>> [Koushik] That's the plan going forward. For the next release both
> >>> options will be there. Maybe post that the custom HA solution can be
> >>> removed for XS 6.2 and above.
> >>>
> 
> >>
> >> Please make sure that the deprecation is explicitly called out. E.g
> >> will be present but deprecated in 4.4 and removed in 4.5; and let's
> >> make sure a doc bug gets filed when this is ready for merge.
> >>
> >> --David
> >

Build failed in Jenkins: cloudstack-4.3-maven-build-noredist #39

[jenkins]

See 


Changes:

[jessicawang] CLOUDSTACK-1889: UI > accounts > Update Resource Count action > 
after action succeeds, pop up a dialog to show updated count of resources.

--
[...truncated 575 lines...]
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-s3 ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image Swift provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-swift ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image default provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-default ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image sample provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-sample ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume SolidFire Provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-solidfire ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume default provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-default ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume sample provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-sample ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - SNMP Alerts 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-snmp-alerts ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 

Re: Getting bug fixes into 4.3

[Will Stevens]

I have compiled a list of bugs in this issue:
https://issues.apache.org/jira/browse/CLOUDSTACK-5278

Will


On Wed, Nov 27, 2013 at 3:59 PM, Animesh Chaturvedi <
animesh.chaturv...@citrix.com> wrote:

> It is best to file issues and then we can triage them, once you have
> compiled the list call it out on the mailing list and we can discuss what
> can or cannot be done in 4.3 There is still time for 4.3 so ideally we
> should address as much as possible in 4.3
>
> Animesh
>
> -Original Message-
> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> Behalf Of Will Stevens
> Sent: Wednesday, November 27, 2013 10:57 AM
> To: dev@cloudstack.apache.org
> Subject: Getting bug fixes into 4.3
>
> While I was troubleshooting some bugs that appeared in my Palo Alto
> Networks firewall integration, I found a bunch of bugs with the way that
> the egress firewall rules were handled.
>
> I have created an issue for these bugs:
> https://issues.apache.org/jira/browse/CLOUDSTACK-5278
>
> I am not sure how these bugs should be resolved because I am not very
> familiar with the underlying implementation of the egress rules.
>
> Should I try to just work around the current issues in the egress rules
> implementation for my specific plugin or should I create an issue for the
> bugs in my plugin which is dependant on the egress bugs issue and set the
> egress rule bugs issue as blocking the issue for my plugin?
>
> Since we need to tie up all the loose ends for the 4.3 code base, I am not
> sure the best way to handle this.  I believe the other plugins have
> implemented workarounds for these issues, but I don't know that for sure.
>
> Thanks,
>
> Will
>

RE: Getting bug fixes into 4.3

[Animesh Chaturvedi]

It is best to file issues and then we can triage them, once you have compiled 
the list call it out on the mailing list and we can discuss what can or cannot 
be done in 4.3 There is still time for 4.3 so ideally we should address as much 
as possible in 4.3

Animesh

-Original Message-
From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On Behalf Of 
Will Stevens
Sent: Wednesday, November 27, 2013 10:57 AM
To: dev@cloudstack.apache.org
Subject: Getting bug fixes into 4.3

While I was troubleshooting some bugs that appeared in my Palo Alto Networks 
firewall integration, I found a bunch of bugs with the way that the egress 
firewall rules were handled.

I have created an issue for these bugs:
https://issues.apache.org/jira/browse/CLOUDSTACK-5278

I am not sure how these bugs should be resolved because I am not very familiar 
with the underlying implementation of the egress rules.

Should I try to just work around the current issues in the egress rules 
implementation for my specific plugin or should I create an issue for the bugs 
in my plugin which is dependant on the egress bugs issue and set the egress 
rule bugs issue as blocking the issue for my plugin?

Since we need to tie up all the loose ends for the 4.3 code base, I am not sure 
the best way to handle this.  I believe the other plugins have implemented 
workarounds for these issues, but I don't know that for sure.

Thanks,

Will

RE: persistence layer

[Frank Zhang]

Hi Lukas:
Glad to see developer behind JOOQ here, I originally recommended using 
QueryDSL instead of JOOQ,
there are some of my concerns:

- Spring support. You know CloudStack is based on Spring IOC, the most 
compelling thing of Spring DB is its transaction
management framework. QueryDSL has been integrated into Spring for two years. 
But there is only a simple page
(http://www.jooq.org/doc/3.2/manual/getting-started/tutorials/jooq-with-spring/)
 demonstrating JOOQ and Spring,  however,
the code just shows how to load JOOQ in IOC, it doesn't show any advanced 
feature of Spring DB for example declarative 
transaction management. If JOOQ is not compatible with Spring DB, then we loss 
a widely used feature.

- It's not JPA based on. This might be an argument that JOOQ may claim as its 
biggest advantage. I agree JPA does have
some bad thing(e.g. criteria API), but  the rest part is doing very well. The 
most important thing here is JPA is just API so I can choose
underlying vendor by my preference. This non-lock-in feature is very appealing. 
For example, Hibernate has been proven by industry
for 10 years, I can fairly trust its quality. And vendor may have some advanced 
feature like secondary cache I may need someday.
Instead, using JOOQ means I have to rely on its underlying implementation with 
no choice.

You know almost all JPA vendors support different SQL dialects. And fluent 
API(or DSL) is not attractive to me. Frankly speaking,
IMO, for insert/update/delete clause the fluent API makes thing unnecessary 
complex that you are writing something which is even
more complicated than SQL, for example in JOOQ,

== persistence ===
create.insertInto(AUTHOR)
  .set(AUTHOR.ID, 100)
  .set(AUTHOR.FIRST_NAME, "Hermann")
  .set(AUTHOR.LAST_NAME, "Hesse")
  .newRecord()
  .set(AUTHOR.ID, 101)
  .set(AUTHOR.FIRST_NAME, "Alfred")
  .set(AUTHOR.LAST_NAME, "Döblin");

In this area, JPA does the right thing.

Author author = new Author(...);
JPAEntityManary.persist(author);

The later one is more Java more OOP.

=== single table query 
Speaking of query, for single table query, fluent API is not attractive too. 
For example:

Raw SQL:
  SELECT * FROM BOOK
   WHERE BOOK.PUBLISHED_IN = 2011
ORDER BY BOOK.TITLE

JOOQ:
create.selectFrom(BOOK)
  .where(BOOK.PUBLISHED_IN.eq(2011))
  .orderBy(BOOK.TITLE)


CloudStack search criteria built on JPA:
Qeury q = new Qeury();
q.add(Book_.PublishedIn. Op.eq, 2011);
q.orderBy(Book_.title);
List books = q.list();

The last way is more Java for sure, people who even has no SQL knowledge can 
write the search. 

=== multiple tables query ===
The only place fluent API shining is querying multiple tables:

  SELECT AUTHOR.FIRST_NAME, AUTHOR.LAST_NAME, COUNT(*)
FROM AUTHOR
JOIN BOOK ON AUTHOR.ID = BOOK.AUTHOR_ID
   WHERE BOOK.LANGUAGE = 'DE'
 AND BOOK.PUBLISHED > '2008-01-01'
GROUP BY AUTHOR.FIRST_NAME, AUTHOR.LAST_NAME
  HAVING COUNT(*) > 5
ORDER BY AUTHOR.LAST_NAME ASC NULLS FIRST
   LIMIT 2
  OFFSET 1
 FOR UPDATE

JOOQ:

create.select(AUTHOR.FIRST_NAME, AUTHOR.LAST_NAME, count())
  .from(AUTHOR)
  .join(BOOK).on(BOOK.AUTHOR_ID.equal(AUTHOR.ID))
  .where(BOOK.LANGUAGE.equal("DE"))
  .and(BOOK.PUBLISHED.greaterThan("2008-01-01"))
  .groupBy(AUTHOR.FIRST_NAME, AUTHOR.LAST_NAME)
  .having(count().greaterThan(5))
  .orderBy(AUTHOR.LAST_NAME.asc().nullsFirst())
  .limit(1)
  .offset(2)
  .forUpdate();

JPA does very badly in this area. However, you notice you are actually 
translating raw SQL into JOOQ DSL. In fact
writing such a query is harder in JOOQ than in raw SQL, because you must not 
only know SQL knowledge but also know
JOOQ dialects.  The only gain is type-safe. I know Java developers are used to 
static type too much, they are not willing
to write any code that cannot be checked by compiler. Type safe is the reason 
that no ORM is perfect, and it can never be.

In summary, I don't think dropping in any ORM can solve problem perfectly, if I 
did it, I would do:

- Using JPA based framework.
- building persistent interface(create/update/delete) and single table search 
criteria using JPA
- for multiple tables query, either using JPA JPQL(if you don't mind type safe) 
or dropping in some fluent API framework if you can not stand for any type 
unsafe thing.



> -Original Message-
> From: Lukas Eder [mailto:lukas.e...@gmail.com]
> Sent: Tuesday, November 26, 2013 3:58 AM
> To: dev@cloudstack.apache.org
> Subject: Re: persistence layer
> 
> Dear CloudStack developers,
> 
> This thread has caught my attention and I thought I might chime in and give
> you some background information about jOOQ, JDBC, RDBMS in general (I
> work for Data Geekery, the company behind jOOQ). I've already had the
> pleasure to talk to Darren on the jOOQ User Group and on the phone.
> 
> Here are some answers to open questions I've seen in this thread:
> 
> 2013/11/26 Alex Huang 
> 
> > Has anyone 

Getting bug fixes into 4.3

[Will Stevens]

While I was troubleshooting some bugs that appeared in my Palo Alto
Networks firewall integration, I found a bunch of bugs with the way that
the egress firewall rules were handled.

I have created an issue for these bugs:
https://issues.apache.org/jira/browse/CLOUDSTACK-5278

I am not sure how these bugs should be resolved because I am not very
familiar with the underlying implementation of the egress rules.

Should I try to just work around the current issues in the egress rules
implementation for my specific plugin or should I create an issue for the
bugs in my plugin which is dependant on the egress bugs issue and set the
egress rule bugs issue as blocking the issue for my plugin?

Since we need to tie up all the loose ends for the 4.3 code base, I am not
sure the best way to handle this.  I believe the other plugins have
implemented workarounds for these issues, but I don't know that for sure.

Thanks,

Will

system VMs are not coming up on 4.3 on VMware

[Srikanteswararao Talluri]

I am hitting the following error while system Vms are coming  on a  zone with 
latest 4.3 code. Has any one seen this?

I could see https://issues.apache.org/jira/browse/CLOUDSTACK-4860 was filed a 
while ago, but I don’t see any commits updated there but it is in resolved 
state now.



Unable to copy template to primary storage due to exception:Exception: 
javax.xml.ws.soap.SOAPFaultException

Message:

Required parameter spec is missing


while parsing call information for method ImportVApp

at line 1, column 110


while parsing SOAP body

at line 1, column 102


while parsing SOAP envelope

at line 1, column 38


while parsing HTTP request for method importVApp

on object of type vim.ResourcePool

at line 1, column 0


javax.xml.ws.soap.SOAPFaultException:

Required parameter spec is missing


while parsing call information for method ImportVApp

at line 1, column 110


while parsing SOAP body

at line 1, column 102


while parsing SOAP envelope

at line 1, column 38


while parsing HTTP request for method importVApp

on object of type vim.ResourcePool

at line 1, column 0

at 
com.sun.xml.internal.ws.fault.SOAP11Fault.getProtocolException(SOAP11Fault.java:178)

at 
com.sun.xml.internal.ws.fault.SOAPFaultBuilder.createException(SOAPFaultBuilder.java:119)

at 
com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(SyncMethodHandler.java:108)

at 
com.sun.xml.internal.ws.client.sei.SyncMethodHandler.invoke(SyncMethodHandler.java:78)

at com.sun.xml.internal.ws.client.sei.SEIStub.invoke(SEIStub.java:107)

at $Proxy382.importVApp(Unknown Source)

at 
com.cloud.hypervisor.vmware.mo.HypervisorHostHelper.importVmFromOVF(HypervisorHostHelper.java:1336)

at com.cloud.hypervisor.vmware.mo.HostMO.importVmFromOVF(HostMO.java:749)

at 
com.cloud.storage.resource.VmwareStorageProcessor.copyTemplateFromSecondaryToPrimary(VmwareStorageProcessor.java:161)

at 
com.cloud.storage.resource.VmwareStorageProcessor.copyTemplateToPrimaryStorage(VmwareStorageProcessor.java:221)

at 
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:75)

at 
com.cloud.storage.resource.VmwareStorageSubsystemCommandHandler.execute(VmwareStorageSubsystemCommandHandler.java:155)

at 
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageCommands(StorageSubsystemCommandHandlerBase.java:50)

at 
com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:553)

at 
com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:216)

at 
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)

at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)

at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)

at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)

at 
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)

at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)

at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)

at java.util.concurrent.FutureTask.run(FutureTask.java:166)

at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)

at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)

at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)

at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)

at java.lang.Thread.run(Thread.java:679)

2013-11-28 00:03:05,946 DEBUG [c.c.a.m.DirectAgentAttache] 
(DirectAgent-20:ctx-e249eed1) Seq 3-925171747: Response Received:

~Talluri

Build failed in Jenkins: cloudstack-4.3-maven-build-noredist #38

[jenkins]

See 


Changes:

[w.zhou] CLOUDSTACK-5293: fix issue when collect vm disk statistics from iso

--
[...truncated 575 lines...]
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-s3 ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image Swift provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-swift ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image default provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-default ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image sample provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-sample ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume SolidFire Provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-solidfire ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume default provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-default ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume sample provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-sample ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - SNMP Alerts 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-snmp-alerts ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Syslo

Re: Review Request 15876: Fixed spelling typo

[Jan-Arve Nygård]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15876/#review29490
---

Ship it!


Ship It!

- Jan-Arve Nygård


On Nov. 27, 2013, 1:03 p.m., Jan-Arve Nygård wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15876/
> ---
> 
> (Updated Nov. 27, 2013, 1:03 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed spelling typo in messages.properties
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 461aa84 
> 
> Diff: https://reviews.apache.org/r/15876/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan-Arve Nygård
> 
>

Re: Review Request 15667: Fix for Coverity issues CID_1116744, CID_1116718 and CID_1116682, all related to resource leak.

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15667/#review29489
---

Ship it!


226b193488638dfeff7a003b8c1ca6c760e00cd1

- daan Hoogland


On Nov. 27, 2013, 1:18 p.m., Wilder Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15667/
> ---
> 
> (Updated Nov. 27, 2013, 1:18 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing resource leak on Coverity issues CID_1116744, CID_1116718 and 
> CID_1116682.
> 
> The resource leak problems were mostly related to InpuStreams instantiated 
> and not closed after used.
> 
> 
> Diffs
> -
> 
>   
> framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
>  177ae09 
>   server/src/com/cloud/api/doc/ApiXmlDocWriter.java a91530b 
> 
> Diff: https://reviews.apache.org/r/15667/diff/
> 
> 
> Testing
> ---
> 
> A full build was executed on top of the branch created for these changes. 
> After committed and patched, the a brand new branch was created from Master 
> and patched with this patch. Everything worked fine.
> 
> No new feature was added.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>

Re: Review Request 15667: Fix for Coverity issues CID_1116744, CID_1116718 and CID_1116682, all related to resource leak.

[Wilder Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15667/
---

(Updated Nov. 27, 2013, 1:18 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Removing ConfigurationServerImpl from the patch


Repository: cloudstack-git


Description
---

Fixing resource leak on Coverity issues CID_1116744, CID_1116718 and 
CID_1116682.

The resource leak problems were mostly related to InpuStreams instantiated and 
not closed after used.


Diffs (updated)
-

  
framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
 177ae09 
  server/src/com/cloud/api/doc/ApiXmlDocWriter.java a91530b 

Diff: https://reviews.apache.org/r/15667/diff/


Testing
---

A full build was executed on top of the branch created for these changes. After 
committed and patched, the a brand new branch was created from Master and 
patched with this patch. Everything worked fine.

No new feature was added.


Thanks,

Wilder Rodrigues

Re: Review Request 15876: Fixed spelling typo

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15876/#review29486
---

Ship it!


Ship It!

- daan Hoogland


On Nov. 27, 2013, 1:03 p.m., Jan-Arve Nygård wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15876/
> ---
> 
> (Updated Nov. 27, 2013, 1:03 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed spelling typo in messages.properties
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 461aa84 
> 
> Diff: https://reviews.apache.org/r/15876/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan-Arve Nygård
> 
>

Re: Review Request 15876: Fixed spelling typo

[daan Hoogland]

> On Nov. 27, 2013, 1:18 p.m., daan Hoogland wrote:
> > Ship It!

de2c4ceeb9b1724599979c864cf0c7e7c3ff8b83


- daan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15876/#review29486
---


On Nov. 27, 2013, 1:03 p.m., Jan-Arve Nygård wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15876/
> ---
> 
> (Updated Nov. 27, 2013, 1:03 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed spelling typo in messages.properties
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 461aa84 
> 
> Diff: https://reviews.apache.org/r/15876/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan-Arve Nygård
> 
>

Review Request 15876: Fixed spelling typo

[Jan-Arve Nygård]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15876/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

Fixed spelling typo in messages.properties


Diffs
-

  client/WEB-INF/classes/resources/messages.properties 461aa84 

Diff: https://reviews.apache.org/r/15876/diff/


Testing
---


Thanks,

Jan-Arve Nygård

Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/#review29485
---



server/src/com/cloud/vm/UserVmManagerImpl.java


Is there a guarantee that the parameter is castable to Long?


- daan Hoogland


On Nov. 27, 2013, 11:12 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15875/
> ---
> 
> (Updated Nov. 27, 2013, 11:12 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5160
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> use a map to specify the custom parameters in the deployvm api Instead of one 
> parameter for each.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5160
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/UserVmService.java 444c47a 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 7180f4e 
>   engine/schema/src/com/cloud/service/ServiceOfferingVO.java 67fea00 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 
> 
> Diff: https://reviews.apache.org/r/15875/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 15647: Fixing coverity issues related to resource leak on FileInputStream being created anonymously.

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15647/#review29484
---

Ship it!


d19688103ba7f7c53c264fb67cb534dd693c95cd (remarks are about the old code not 
this patch)


awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java


code in comment (not as comment). this should be removed



awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java


code in comment (not as comment). this should be removed



awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java


code in comment (not as comment). this should be removed


- daan Hoogland


On Nov. 26, 2013, 1:06 p.m., Wilder Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15647/
> ---
> 
> (Updated Nov. 26, 2013, 1:06 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing coverity issues related to resource leak on FileInputStream being 
> created anonymously.
> 
> This patch fixed the following Coverity issues:
> 
> cv_1116497
> cv_1116681
> cv_1116694
> cv_1116567
> cv_1116495
> 
> 
> Diffs
> -
> 
>   awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 5c56e9d 
>   awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java 
> deb886f 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 59abca0 
>   framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 3e7138f 
>   services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java 
> 0d28e09 
> 
> Diff: https://reviews.apache.org/r/15647/diff/
> 
> 
> Testing
> ---
> 
> A build full build was executed on top of the branch created for these 
> changes. After committed and patched, the a brand new branch was created from 
> Master and patched with this patch. Everything worked fine.
> 
> No new feature was added.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>

Re: Review Request 15832: enable custom offering support for scalevm

[Koushik Das]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15832/#review29479
---



engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java


This is already there. check. Avoid duplicating the enum between cloud and 
usage db.



framework/db/src/com/cloud/utils/db/GenericDaoBase.java


'\' got added in the name, will result in build errors.



server/src/com/cloud/configuration/ConfigurationManagerImpl.java


Update the FS with this information.
Fix typos in comments and exception messages.



server/src/com/cloud/vm/UserVmManager.java


Why is this needed in the interface?



server/src/com/cloud/vm/UserVmManagerImpl.java


Below I see some save/remove custom details methods? Shouldn't you just 
call those methods here?



server/src/com/cloud/vm/UserVmManagerImpl.java


Why is there a dependency to UsageVMInstanceVO? Isn't that a table in usage 
server?



server/src/com/cloud/vm/UserVmManagerImpl.java


There are 2 things happening here: validating custom parameters and 
updating service offering. Separate them into separate functions. If validation 
is successful then update service offering.



server/src/com/cloud/vm/UserVmManagerImpl.java


remove this check as this is always called from internal code and custom 
parameters will be non null.



server/src/com/cloud/vm/UserVmManagerImpl.java


This is also not required as custom parameter map cannot be null



server/src/com/cloud/vm/UserVmManagerImpl.java


Put some comment to explain the logic



server/src/com/cloud/vm/UserVmManagerImpl.java


I see the usage event publishing code getting repeated. Move them to a 
separate method.


- Koushik Das


On Nov. 27, 2013, 9:33 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15832/
> ---
> 
> (Updated Nov. 27, 2013, 9:33 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5161
> https://issues.apache.org/jira/browse/CLOUDSTACK-5161
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> enable scaling of a vm using custom offering
> CLOUDSTACK-5161
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6f919c1 
>   
> api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java
>  a7c864d 
>   
> api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
>  1357a7d 
>   api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 6cb49c1 
>   api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 3dfcdf9 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
> 7ec739e 
>   engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 3a3de70 
>   engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f1f97fc 
>   engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java 06a7bee 
>   framework/db/src/com/cloud/utils/db/GenericDaoBase.java 8e6f6a4 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 4f351eb 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 2260e1e 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3770eb8 
>   server/src/com/cloud/server/ManagementServerImpl.java d34da4f 
>   server/src/com/cloud/vm/UserVmManager.java b7b4bd5 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 
>   server/test/com/cloud/vm/UserVmManagerTest.java 71bbebe 
> 
> Diff: https://reviews.apache.org/r/15832/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: [Discuss] AutoScaling.next in CloudStack

[Daan Hoogland]

I have some (limited) experience, it seems the fs[1] refered in this
thread is good enough if you need to expose data. How much of this is
being implemented at the moment?

I suppose you need to design a way for leveraging data from
components, do you? i.e. the monitoriing service from Chiradeeps
picture[2]

Daan

[1] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+for+Integrating+CS+alerts+via+SNMP+to+external+management+system
[2] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Autoscale+framework

On Wed, Nov 27, 2013 at 11:36 AM, Nguyen Anh Tu  wrote:
> Anyone can help in SNMP monitoring design? I have very limit experience
> with SNMP :-)
>
> Thanks,
>
> --Tuna
>
>
> On Tue, Nov 26, 2013 at 11:31 AM, Vijay Venkatachalam <
> vijay.venkatacha...@citrix.com> wrote:
>
>> Hi Chiradeep,
>> The monitoring service seems to be collecting statistics using
>> polling and
>> triggers actions during  threshold breach. This seems to be very
>> tasking.
>> Can it be designed to listen for events on threshold breach as
>> well?
>> For ex. a configuration "response timeout > 30 ms" on a VIP can be
>> sent to LB appliance, the LB appliance can intimate the Monitoring
>> service
>> when the threshold breach has happened. Basically offloading the
>> responsibility.
>> Thanks,
>> Vijay V.
>>
>>
>> > -Original Message-
>> > From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
>> > Sent: Tuesday, November 26, 2013 8:07 AM
>> > To: dev@cloudstack.apache.org
>> > Subject: Re: [Discuss] AutoScaling.next in CloudStack
>> >
>> > Hi Tuna,
>> >
>> > I boldly diagrammed out what we talked about here:
>> >
>> > https://cwiki.apache.org/confluence/x/M6YTAg
>> >
>> > The idea is to keep the monitoring part separate from the autoscale
>> decision.
>> > So, the monitoring can be SNMP/RRD/whatever.
>> >
>> > Scale-up using reconfiguration then becomes a mere matter of modifying
>> the
>> > autoscale service.
>> >
>> >
>> > On 11/25/13 8:57 AM, "tuna"  wrote:
>> >
>> > >Hi guys,
>> > >
>> > >At CCCEU13 I talked about the AutoScale without NetScaler feature
>> > >working with XenServer & XCP. For anyone don¹t know about this feature,
>> > >take a look into my slide here:
>> > >http://www.slideshare.net/tuna20073882/autoscale-without-
>> > netscalerccceu13.
>> > >
>> > >Chiradeep and I had a short talk after the presentation about how to
>> > >improve the AutoScale feature in future. We agreed that:
>> > >
>> > >+ Need to remove Load Balancing feature from AutoScaling. That¹s very
>> > >simple to do.
>> > >+ Need to use SNMP for monitoring not only instance-level but also
>> > >application-level.
>> > >+ Also, supporting well KVM hypervisor
>> > >
>> > >So, I blow up this thread for all of you guys to discuss the way we
>> > >design that feature, such as:
>> > >+ technical side, how to integrate effectively SNMP into CLoudStack.
>> > >Where do we put SNMP monitor components into infrastructure? etc
>> > >+ user experience, how user configure that feature with SNMP monitoring.
>> > >I image that user can figure out they need AutoScale for which of
>> > >following items: application, protocol (tcp, udp), port, bandwidth,
>> > >disk, cpu and memory also, etc
>> > >+ How about autoscale action, not just only deploy or destroy VM, we
>> > >+ need
>> > >maybe dynamically increase-decrease memory/cpu, nic bandwidth, disk,Š
>> > >
>> > >Personally, we should think about a completely autoscaling feature.
>> > >
>> > >Cheers,
>> > >
>> > >‹Tuna
>>
>>

Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15875/
---

Review request for cloudstack, Jayapal Reddy and Koushik Das.


Bugs: CLOUDSTACK-5160
https://issues.apache.org/jira/browse/CLOUDSTACK-5160


Repository: cloudstack-git


Description
---

use a map to specify the custom parameters in the deployvm api Instead of one 
parameter for each.

https://issues.apache.org/jira/browse/CLOUDSTACK-5160


Diffs
-

  api/src/com/cloud/vm/UserVmService.java 444c47a 
  api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 7180f4e 
  engine/schema/src/com/cloud/service/ServiceOfferingVO.java 67fea00 
  server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 

Diff: https://reviews.apache.org/r/15875/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

Re: Build failed in Jenkins: cloudstack-4.3-maven-build-noredist #37

[Hugo Trippaers]

Configuration error on the Jenkins slave. Will fix :-)

Sent from my iPhone

> On 27 nov. 2013, at 12:00, jenk...@cloudstack.org wrote:
> 
> See 
> 
> 
> Changes:
> 
> [rajesh.battala] Fix VM stats collections in HyperV
> 
> [rajesh.battala] Added hv kvp daemon support for 64 bit systemvm template to 
> support system vms to run on HyperV. hv_kvp daemon is used to pass the boot 
> args from host to the guest.
> 
> --
> [...truncated 956 lines...]
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
> cloud-plugin-storage-image-s3 ---
> [INFO] Deleting 
> 
>  (includes = [target, dist], excludes = [])
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache CloudStack Plugin - Storage Image Swift provider 
> 4.3.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
> cloud-plugin-storage-image-swift ---
> [INFO] Deleting 
> 
>  (includes = [target, dist], excludes = [])
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache CloudStack Plugin - Storage Image default provider 
> 4.3.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
> cloud-plugin-storage-image-default ---
> [INFO] Deleting 
> 
>  (includes = [target, dist], excludes = [])
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache CloudStack Plugin - Storage Image sample provider 
> 4.3.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
> cloud-plugin-storage-image-sample ---
> [INFO] Deleting 
> 
>  (includes = [target, dist], excludes = [])
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache CloudStack Plugin - Storage Volume SolidFire Provider 
> 4.3.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
> cloud-plugin-storage-volume-solidfire ---
> [INFO] Deleting 
> 
>  (includes = [target, dist], excludes = [])
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache CloudStack Plugin - Storage Volume default provider 
> 4.3.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
> cloud-plugin-storage-volume-default ---
> [INFO] Deleting 
> 
>  (includes = [target, dist], excludes = [])
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache CloudStack Plugin - Storage Volume sample provider 
> 4.3.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
> cloud-plugin-storage-volume-sample ---
> [INFO] Deleting 
> 
>  (includes = [target, dist], excludes = [])
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache CloudStack Plugin - SNMP Alerts 4.3.0-SNAPSHOT
> [INFO] 
> 

Build failed in Jenkins: cloudstack-4.3-maven-build-noredist #37

[jenkins]

See 


Changes:

[rajesh.battala] Fix VM stats collections in HyperV

[rajesh.battala] Added hv kvp daemon support for 64 bit systemvm template to 
support system vms to run on HyperV. hv_kvp daemon is used to pass the boot 
args from host to the guest.

--
[...truncated 956 lines...]
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-s3 ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image Swift provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-swift ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image default provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-default ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Image sample provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-image-sample ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume SolidFire Provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-solidfire ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume default provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-default ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Volume sample provider 
4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-volume-sample ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - SNMP Alerts 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-snmp-alerts ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO]  

Re: Review Request 15667: Fix for Coverity issues CID_1116744, CID_1116718 and CID_1116682, all related to resource leak.

[Wilder Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15667/
---

(Updated Nov. 27, 2013, 10:51 a.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Applying changes suggested by Daan.


Repository: cloudstack-git


Description
---

Fixing resource leak on Coverity issues CID_1116744, CID_1116718 and 
CID_1116682.

The resource leak problems were mostly related to InpuStreams instantiated and 
not closed after used.


Diffs (updated)
-

  
framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
 177ae09 
  server/src/com/cloud/api/doc/ApiXmlDocWriter.java a91530b 
  server/src/com/cloud/server/ConfigurationServerImpl.java cfc95ca 

Diff: https://reviews.apache.org/r/15667/diff/


Testing
---

A full build was executed on top of the branch created for these changes. After 
committed and patched, the a brand new branch was created from Master and 
patched with this patch. Everything worked fine.

No new feature was added.


Thanks,

Wilder Rodrigues

Re: Review Request 15667: Fix for Coverity issues CID_1116744, CID_1116718 and CID_1116682, all related to resource leak.

[Wilder Rodrigues]

> On Nov. 27, 2013, 10:28 a.m., daan Hoogland wrote:
> > server/src/com/cloud/api/doc/ApiXmlDocWriter.java, line 142
> > 
> >
> > shouldn't this go in a finally clause?

Didn't add a finally to the try/catch block because it might not happen. There 
is a if block before, and the try/catch is surrounded by it. There could be the 
case that we move the try/catch outside, but then we would have code into the 
block that wouldn't cause neither a ClassNotFound nor a NoClassDefFound 
exception/error.


> On Nov. 27, 2013, 10:28 a.m., daan Hoogland wrote:
> > server/src/com/cloud/server/ConfigurationServerImpl.java, line 745
> > 
> >
> > shouldn't these go to a finally clause?

For that one, yes... I can change it in order to have the DataInputStream 
outside the tr/catch and close it in the finally. By the way, closing the 
DataInputStream is enough, since it's created based on the FileInputStream. So, 
closing it will close the other one as well. Will fix that.


- Wilder


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15667/#review29481
---


On Nov. 27, 2013, 9:47 a.m., Wilder Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15667/
> ---
> 
> (Updated Nov. 27, 2013, 9:47 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing resource leak on Coverity issues CID_1116744, CID_1116718 and 
> CID_1116682.
> 
> The resource leak problems were mostly related to InpuStreams instantiated 
> and not closed after used.
> 
> 
> Diffs
> -
> 
>   
> framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
>  177ae09 
>   server/src/com/cloud/api/doc/ApiXmlDocWriter.java a91530b 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cfc95ca 
> 
> Diff: https://reviews.apache.org/r/15667/diff/
> 
> 
> Testing
> ---
> 
> A full build was executed on top of the branch created for these changes. 
> After committed and patched, the a brand new branch was created from Master 
> and patched with this patch. Everything worked fine.
> 
> No new feature was added.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>

Re: [Discuss] AutoScaling.next in CloudStack

[Nguyen Anh Tu]

Anyone can help in SNMP monitoring design? I have very limit experience
with SNMP :-)

Thanks,

--Tuna


On Tue, Nov 26, 2013 at 11:31 AM, Vijay Venkatachalam <
vijay.venkatacha...@citrix.com> wrote:

> Hi Chiradeep,
> The monitoring service seems to be collecting statistics using
> polling and
> triggers actions during  threshold breach. This seems to be very
> tasking.
> Can it be designed to listen for events on threshold breach as
> well?
> For ex. a configuration "response timeout > 30 ms" on a VIP can be
> sent to LB appliance, the LB appliance can intimate the Monitoring
> service
> when the threshold breach has happened. Basically offloading the
> responsibility.
> Thanks,
> Vijay V.
>
>
> > -Original Message-
> > From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
> > Sent: Tuesday, November 26, 2013 8:07 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [Discuss] AutoScaling.next in CloudStack
> >
> > Hi Tuna,
> >
> > I boldly diagrammed out what we talked about here:
> >
> > https://cwiki.apache.org/confluence/x/M6YTAg
> >
> > The idea is to keep the monitoring part separate from the autoscale
> decision.
> > So, the monitoring can be SNMP/RRD/whatever.
> >
> > Scale-up using reconfiguration then becomes a mere matter of modifying
> the
> > autoscale service.
> >
> >
> > On 11/25/13 8:57 AM, "tuna"  wrote:
> >
> > >Hi guys,
> > >
> > >At CCCEU13 I talked about the AutoScale without NetScaler feature
> > >working with XenServer & XCP. For anyone don¹t know about this feature,
> > >take a look into my slide here:
> > >http://www.slideshare.net/tuna20073882/autoscale-without-
> > netscalerccceu13.
> > >
> > >Chiradeep and I had a short talk after the presentation about how to
> > >improve the AutoScale feature in future. We agreed that:
> > >
> > >+ Need to remove Load Balancing feature from AutoScaling. That¹s very
> > >simple to do.
> > >+ Need to use SNMP for monitoring not only instance-level but also
> > >application-level.
> > >+ Also, supporting well KVM hypervisor
> > >
> > >So, I blow up this thread for all of you guys to discuss the way we
> > >design that feature, such as:
> > >+ technical side, how to integrate effectively SNMP into CLoudStack.
> > >Where do we put SNMP monitor components into infrastructure? etc
> > >+ user experience, how user configure that feature with SNMP monitoring.
> > >I image that user can figure out they need AutoScale for which of
> > >following items: application, protocol (tcp, udp), port, bandwidth,
> > >disk, cpu and memory also, etc
> > >+ How about autoscale action, not just only deploy or destroy VM, we
> > >+ need
> > >maybe dynamically increase-decrease memory/cpu, nic bandwidth, disk,Š
> > >
> > >Personally, we should think about a completely autoscaling feature.
> > >
> > >Cheers,
> > >
> > >‹Tuna
>
>

Re: Review Request 15667: Fix for Coverity issues CID_1116744, CID_1116718 and CID_1116682, all related to resource leak.

[Wilder Rodrigues]

> On Nov. 27, 2013, 10:28 a.m., daan Hoogland wrote:
> > framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java,
> >  line 171
> > 
> >
> > isn't this one superfluent? (Does coverity force you to do this?)

Yes... coverity forces a bit those "Resource leaks" errors


- Wilder


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15667/#review29481
---


On Nov. 27, 2013, 9:47 a.m., Wilder Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15667/
> ---
> 
> (Updated Nov. 27, 2013, 9:47 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing resource leak on Coverity issues CID_1116744, CID_1116718 and 
> CID_1116682.
> 
> The resource leak problems were mostly related to InpuStreams instantiated 
> and not closed after used.
> 
> 
> Diffs
> -
> 
>   
> framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
>  177ae09 
>   server/src/com/cloud/api/doc/ApiXmlDocWriter.java a91530b 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cfc95ca 
> 
> Diff: https://reviews.apache.org/r/15667/diff/
> 
> 
> Testing
> ---
> 
> A full build was executed on top of the branch created for these changes. 
> After committed and patched, the a brand new branch was created from Master 
> and patched with this patch. Everything worked fine.
> 
> No new feature was added.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>

Re: Review Request 15667: Fix for Coverity issues CID_1116744, CID_1116718 and CID_1116682, all related to resource leak.

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15667/#review29481
---



framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java


isn't this one superfluent? (Does coverity force you to do this?)



server/src/com/cloud/api/doc/ApiXmlDocWriter.java


shouldn't this go in a finally clause?



server/src/com/cloud/server/ConfigurationServerImpl.java


shouldn't these go to a finally clause?


- daan Hoogland


On Nov. 27, 2013, 9:47 a.m., Wilder Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15667/
> ---
> 
> (Updated Nov. 27, 2013, 9:47 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing resource leak on Coverity issues CID_1116744, CID_1116718 and 
> CID_1116682.
> 
> The resource leak problems were mostly related to InpuStreams instantiated 
> and not closed after used.
> 
> 
> Diffs
> -
> 
>   
> framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
>  177ae09 
>   server/src/com/cloud/api/doc/ApiXmlDocWriter.java a91530b 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cfc95ca 
> 
> Diff: https://reviews.apache.org/r/15667/diff/
> 
> 
> Testing
> ---
> 
> A full build was executed on top of the branch created for these changes. 
> After committed and patched, the a brand new branch was created from Master 
> and patched with this patch. Everything worked fine.
> 
> No new feature was added.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>

Re: Review Request 15351: Fixing bugs from Coverity related to Dereferenced Null after check and as return value.

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15351/#review29480
---

Ship it!


2774b62d64989bddc1e4664ef7a93dff11c77657

- daan Hoogland


On Nov. 25, 2013, 11:02 a.m., Wilder Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15351/
> ---
> 
> (Updated Nov. 25, 2013, 11:02 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing Coverity bugs with IDs: cv_1125361, cv_1125357, cv_1125356, 
> cv_1125355, cv_1117769, cv_1125354, cv_1125353, cv_1125346, cv_1125352, 
> cv_1125360 
> 
> 
> Diffs
> -
> 
>   agent/src/com/cloud/agent/AgentShell.java 936e3cd 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
>  ca44757 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
>  32d5d93 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  129392e 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cfc95ca 
>   utils/src/com/cloud/utils/nio/Link.java 3b30053 
> 
> Diff: https://reviews.apache.org/r/15351/diff/
> 
> 
> Testing
> ---
> 
> All tests passed during build.
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 10:19.357s
> [INFO] Finished at: Fri Nov 08 15:06:34 CET 2013
> [INFO] Final Memory: 68M/163M
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>

RE: Getting error while adding Netscaler with the new 10.1 API

[Vijay Venkatachalam]

In order to continue with the old behavior, use HTTPS but have cert and 
hostname validation turned off, the following has to be done
 nitro_service.set_certvalidation(false);
 nitro_service.set_hostnameverification(false);

> -Original Message-
> From: Syed Ahmed [mailto:sah...@cloudops.com]
> Sent: Wednesday, November 27, 2013 5:58 AM
> To: dev@cloudstack.apache.org
> Subject: Getting error while adding Netscaler with the new 10.1 API
> 
> Hi,
> 
> I am trying to move the Netscaler to the 10.1 Nitro API and while using the
> new API I am getting the following error when adding Netscaler device
> 
> PKIX
>   path building failed:
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find
> valid certification path to requested target
> 
> 
> I have changed to use HTTP instead of HTTPS in nitro to temporarily work
> around this problem. Is HTTPS absolutely required for communication with
> external devices? or does my workaround is a valid fix?
> 
> Thanks,
> -Syed

Re: Review Request 15667: Fix for Coverity issues CID_1116744, CID_1116718 and CID_1116682, all related to resource leak.

[Wilder Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15667/
---

(Updated Nov. 27, 2013, 9:47 a.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

repatch in order to apply the whitespace lines fixed by Alex.


Repository: cloudstack-git


Description
---

Fixing resource leak on Coverity issues CID_1116744, CID_1116718 and 
CID_1116682.

The resource leak problems were mostly related to InpuStreams instantiated and 
not closed after used.


Diffs (updated)
-

  
framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
 177ae09 
  server/src/com/cloud/api/doc/ApiXmlDocWriter.java a91530b 
  server/src/com/cloud/server/ConfigurationServerImpl.java cfc95ca 

Diff: https://reviews.apache.org/r/15667/diff/


Testing
---

A full build was executed on top of the branch created for these changes. After 
committed and patched, the a brand new branch was created from Master and 
patched with this patch. Everything worked fine.

No new feature was added.


Thanks,

Wilder Rodrigues

Re: JIRA 3061

[Daan Hoogland]

Can you try again, I put you in the contributers group but i am not
sure if this gives you enough rights

thanks,
Daan

On Wed, Nov 27, 2013 at 6:56 AM, Mandar Barve  wrote:
> Thanks Daan for your inputs. It looks like I don't have permissions to
> assign or change bug state. What should I do to get these?
>
> Thanks,
> Mandar
>
>
> On Tue, Nov 26, 2013 at 2:25 PM, Daan Hoogland wrote:
>
>> H Mandar,
>>
>> You can contact the reporter directly but that would only be to ask to
>> verify in the newer version. This can be a hassle for small plants. So
>> you could put to resolved with the right fix-version.
>>
>> regards,
>>
>>
>> On Mon, Nov 25, 2013 at 9:00 AM, Mandar Barve 
>> wrote:
>> > Hi all,
>> >
>> > Problem: JIRA says list hosts API response didn't return CPU used
>> parameter
>> > value. This bug is reported against version 4.0.2.
>> >
>> > I could not reproduce this problem with CS version 4.2.
>> >
>> > I used CloudMonkey CLI to fire API commands to the management server.
>> With
>> > a basic zone created that has 1 pod, cluster and couple of system vms
>> > connected to the management server using CloudMonkey CLI sent the list
>> > hosts API command and the JSON response output could be captured in the
>> log
>> > file. JSON response and the CLI output shows "cpuused". The value seen
>> here
>> > could be matched against the portal reported host statistics value for
>> CPU
>> > used.
>> >
>> > CLI output:
>> >
>> >> list hosts
>> > count = 1
>> > host:
>> > id = df4fe805-a320-4417-b8be-22dd0b86561e
>> > name = devcloud
>> > capabilities = xen-3.0-x86_32p , hvm
>> > clusterid = b3b80638-1fc5-4d13-aafc-28ff5155c681
>> > clustername = test000
>> > clustertype = CloudManaged
>> > cpuallocated = 0%
>> > cpunumber = 2
>> > cpuspeed = 2486
>> > *cpuused = 0.22%*
>> > cpuwithoverprovisioning = 4972.0
>> > created = 2013-10-07T18:57:58+0530
>> > disconnected = 2013-10-15T11:24:19+0530
>> > events = PingTimeout; AgentConnected; HostDown; ShutdownRequested;
>> > AgentDisconnected; ManagementServerDown; Remove; Ping;
>> StartAgentRebalance
>> > hahost = False
>> > hypervisor = XenServer
>> > ipaddress = 192.168.56.10
>> > islocalstorageactive = False
>> > lastpinged = 1970-01-16T20:20:29+0530
>> >
>> >  JSON response log:
>> >
>> > 2013-10-15 11:48:32,724 - requester.py:45 - [DEBUG]  START
>> Request
>> > 
>> > 2013-10-15 11:48:32,724 - requester.py:45 - [DEBUG] Requesting
>> > command=listHosts, args={}
>> > 2013-10-15 11:48:32,725 - requester.py:45 - [DEBUG] Request sent:
>> >
>> http://localhost:8080/client/api?apiKey=c9uPXphFfiQS5589hVp245hWrqcg1yxcVNg9h1xJES34j8uAtvKj0EP6h8jlSC5_VlajL1a2TaXuYFGoON0DMg&command=listHosts&response=json&signature=hKQ5hI0XFpAzNPJYJ7ivR53%2FzJU%3D
>> > 2013-10-15 11:48:32,820 - requester.py:45 - [DEBUG] Response received: {
>> > "listhostsresponse" : { "count":1 ,"host" : [
>> >
>>  
>> {"id":"df4fe805-a320-4417-b8be-22dd0b86561e","name":"devcloud","state":"Up","disconnected":"2013-10-15T11:24:19+0530","type":"Routing","ipaddress":"192.168.56.10","zoneid":"7b015b74-f00f-4216-b523-efc2e32c6bc5","zonename":"DevCloud0","podid":"c58e91d0-ad57-4d09-a485-f0decab857b4","podname":"test00","version":"4.2.0","hypervisor":"XenServer","cpunumber":2,"cpuspeed":2486,"cpuallocated":"0%",
>> >
>> *"cpuused":"0.22%"*,"cpuwithoverprovisioning":"4972.0","networkkbsread":57462,"networkkbswrite":38105,"memorytotal":251632,"memoryallocated":0,"memoryused":546428,"capabilities":"xen-3.0-x86_32p
>> > ,
>> >
>> hvm","lastpinged":"1970-01-16T20:20:29+0530","managementserverid":8796750265493,"clusterid":"b3b80638-1fc5-4d13-aafc-28ff5155c681","clustername":"test000","clustertype":"CloudManaged","islocalstorageactive":false,"created":"2013-10-07T18:57:58+0530","events":"PingTimeout;
>> > AgentConnected; HostDown; ShutdownRequested; AgentDisconnected;
>> > ManagementServerDown; Remove; Ping;
>> > StartAgentRebalance","resourcestate":"Enabled","hahost":false} ] } }
>> > 2013-10-15 11:48:32,821 - requester.py:45 - [DEBUG]  END Request
>> > 
>> >
>> > Can this be closed? I have updated the JIRA with same comment.
>> >
>> > Thanks,
>> > Mandar
>>
>>

Re: Edit access to Cwiki

[Daan Hoogland]

On Wed, Nov 27, 2013 at 10:07 AM, Manasa Veloori (3P)
 wrote:
> Manasa


now you do

Re: Review Request 15832: enable custom offering support for scalevm

[bharat kumar]

> On Nov. 26, 2013, 6:27 p.m., Nitin Mehta wrote:
> > api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java,
> >  line 63
> > 
> >
> > All this is boilerplate code. Have an abstract class and make all these 
> > classes extend this abstract class. There are some examples to get an idea 
> > for doing this.

Hi Nitin, 

The scalevm, scalesystemvm, upgradesystemvm and upgradevm all have similar API 
parameters. we need to move all these into a base class.
I have created a bug for this. 
https://issues.apache.org/jira/browse/CLOUDSTACK-5286.
 


> On Nov. 26, 2013, 6:27 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 812
> > 
> >
> > I would suggest writing a util function for adding and removing these 
> > details. I think it can be used while deploying vm as well.

Added functions saveCusotmOfferingDetails and removeCustomOfferingDetails.


> On Nov. 26, 2013, 6:27 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 866
> > 
> >
> > can you please break it down ? or write comments please

Added a comment.


> On Nov. 26, 2013, 6:27 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 1938
> > 
> >
> > check for !(cpuNumber == null && cpuSpeed == null && memory == null)
> > 
> >

Hi Nitin, the intention is to check if any one of the params (cpu men etc) is 
null then all should be null.


- bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15832/#review29445
---


On Nov. 27, 2013, 9:33 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15832/
> ---
> 
> (Updated Nov. 27, 2013, 9:33 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5161
> https://issues.apache.org/jira/browse/CLOUDSTACK-5161
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> enable scaling of a vm using custom offering
> CLOUDSTACK-5161
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6f919c1 
>   
> api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java
>  a7c864d 
>   
> api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
>  1357a7d 
>   api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 6cb49c1 
>   api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 3dfcdf9 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
> 7ec739e 
>   engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 3a3de70 
>   engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f1f97fc 
>   engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java 06a7bee 
>   framework/db/src/com/cloud/utils/db/GenericDaoBase.java 8e6f6a4 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 4f351eb 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 2260e1e 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3770eb8 
>   server/src/com/cloud/server/ManagementServerImpl.java d34da4f 
>   server/src/com/cloud/vm/UserVmManager.java b7b4bd5 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 
>   server/test/com/cloud/vm/UserVmManagerTest.java 71bbebe 
> 
> Diff: https://reviews.apache.org/r/15832/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 15832: enable custom offering support for scalevm

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15832/
---

(Updated Nov. 27, 2013, 9:33 a.m.)


Review request for cloudstack and Koushik Das.


Changes
---

Incorporated review comments.


Bugs: CLOUDSTACK-5161
https://issues.apache.org/jira/browse/CLOUDSTACK-5161


Repository: cloudstack-git


Description
---

enable scaling of a vm using custom offering
CLOUDSTACK-5161


Diffs (updated)
-

  api/src/org/apache/cloudstack/api/ApiConstants.java 6f919c1 
  
api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java 
a7c864d 
  
api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
 1357a7d 
  api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 6cb49c1 
  api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 3dfcdf9 
  api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
7ec739e 
  engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f 
  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70 
  engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f1f97fc 
  engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java 06a7bee 
  framework/db/src/com/cloud/utils/db/GenericDaoBase.java 8e6f6a4 
  server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 4f351eb 
  server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 2260e1e 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3770eb8 
  server/src/com/cloud/server/ManagementServerImpl.java d34da4f 
  server/src/com/cloud/vm/UserVmManager.java b7b4bd5 
  server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 
  server/test/com/cloud/vm/UserVmManagerTest.java 71bbebe 

Diff: https://reviews.apache.org/r/15832/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

Edit access to Cwiki

[Manasa Veloori (3P)]

Hi ,

I do not have edit access to Cwiki . Request you to  provide me the same.

Thanks,
Manasa

Re: Help In Launch instance Schedule policy

[Yitao Jiang]

Hi ,

I work with 4.1.0.And now i find out how it working. The two classes only
override the needed methods, and other logics are handled by method in
FirstFit class. The plan method of FirstFit class call different method
according algorithms configured by global configuration.



Thanks,

Yitao


2013/11/27 Prachi Damle 

> Hi Yitao,
>
> Which version of CloudStack are you working with? That will determine the
> configuration needed.
>
> The UserDispersing and UserConcentrated extend the FirstFit and just
> override the methods that decide the order of clusters to be considered for
> searching the resources, based on their respective heuristics.
>
> Prachi
>
> > On Nov 26, 2013, at 10:04 PM, "Yitao Jiang" 
> wrote:
> >
> > Hi, Prachi,
> >
> > I followed the directions of above link , and configure
> > vm.allocation.algorithm
> > to userconcentratedpod_random. But it seems does't work.
> > Through the codes about the deployment plan, i found that the algorithms
> of
> > UserDispersingPlanner
> > and UserConcentratedPodPlanner all extends FirstFitPlanner, but neither
> > implement the method of
> > plan, which actually works for deciding where to deploy a vm, so no
> matter
> > what algorithms i used,
> > it all use the algorithm of firstfit algorithm, cause it implement the
> plan
> > method.
> > Is this a bug or developer should implement this method, or did i miss
> > something in the global configuration ?
> >
> >
> >
> > 2013/11/23 Prachi Damle 
> >
> >> Hi Yitao,
> >>
> >> CloudStack scheduling policies are implemented by the DeploymentPlanner
> >> and HostAllocator/StoragePoolAllocator components.
> >> If you want to take a look at the source code of these components, this
> >> will tell you where to look:
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Deployment+Planning+and+Resource+Allocation
> >>
> >> These components implement the Adapter  interface of CloudStack - so you
> >> can provide your own implementation and plug it in to be used for VM
> >> deployment. Let me know if you face any questions on this.
> >>
> >> Thanks,
> >> Prachi
> >> -Original Message-
> >> From: Yitao Jiang [mailto:willier...@gmail.com]
> >> Sent: Thursday, November 21, 2013 10:11 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: Help In Launch instance Schedule policy
> >>
> >> Hi,
> >>
> >> I was looking for some help in launching instance using some schedule
> >> policies.
> >> I know that Openstack allow developers write their own policy .So I
> guess
> >> cloudstack support maybe that .Since i am just started developing it ,
> i'll
> >> be really appreciate someone can tell me where i can write it  using
> some
> >> policy, such as according to the weight of each host, or RoundRobin.
> >> --
> >>
> >> Best regards,
> >>
> >> Yitao Jiang
> >
> >
> >
> > --
> >
> > Best regards,
> >
> > Yitao Jiang
>

RE: ACS 4.2.1 - Multi-Zone vSphere Architecture

[Simon Murphy]

thanks. i found the management.cidr global setting that needs to be set to make 
the setup work.

Sent from my Android phone using TouchDown (www.nitrodesk.com)

-Original Message-
From: Sanjeev Neelarapu [sanjeev.neelar...@citrix.com]
Received: Wednesday, 27 Nov 2013, 6:12pm
To: us...@cloudstack.apache.org [us...@cloudstack.apache.org]; 
dev@cloudstack.apache.org [dev@cloudstack.apache.org]
Subject: RE: ACS 4.2.1 - Multi-Zone vSphere Architecture

Hi,

It is not mandatory to use single dedicated vlan in a multi zone environment. 
It is possible to have a dedicated VLAN at each site for vCenter, ESXi console 
ports and the system VM's, and then have the ACS server sitting in a separate 
VLAN that can route between both networks.

Thanks,
Sanjeev

From: Simon Murphy [mailto:simon.mur...@vifx.co.nz]
Sent: Monday, November 25, 2013 7:32 AM
To: us...@cloudstack.apache.org; dev@cloudstack.apache.org
Subject: ACS 4.2.1 - Multi-Zone vSphere Architecture

Hi all,

Im after some guidance on setting up ACS 4.2.1 with vSphere in a multi zone 
environment. The only way I have been able to successfully build a zone to this 
point is by having vSphere, ESXi console ports, ACS and the reserved system 
range on a single VLAN. This is OK for a small, single site deployment but how 
does this translate for multiple zones? The docs suggest that configuring a 
single /20 range for management is desired, does that imply that that range 
should be stretched across sites?

Should it be possible to have a dedicated VLAN at each site for vCenter, ESXi 
console ports and the system VM's, and then have the ACS server sitting in a 
separate VLAN that can route between both networks? I have been unsuccessful in 
getting his working to date so hopefully someone out there has some experience 
setting up a multi-site ACS/vSphere envoronment.

Any guidance would be greatly appreciated!


Simon Murphy
Solutions Architect

ViFX | Cloud Infrastructure
Level 7, 57 Fort Street, Auckland, New Zealand 1010
PO Box 106700, Auckland, New Zealand 1143
M +64 21 285 4519 | S simon_a_murphy
www.vifx.co.nz follow us on 
twitter
Auckland | Wellington | Christchurch

[cid:image003.jpg@01CDDF95.815BF160]

experience. expertise. execution.

This email and any files transmitted with it are confidential, without 
prejudice and may contain information that is subject to legal privilege. It is 
intended solely for the use of the individual/s to whom it is addressed in 
accordance with the provisions of the Privacy Act (1993). The content contained 
in this email does not, necessarily, reflect the official policy position of 
ViFX nor does ViFX have any responsibility for any alterations to the contents 
of this email that may occur following transmission. If you are not the 
addressee it may be unlawful for you to read, copy, distribute, disclose or 
otherwise use the information contained within this email. If you are not the 
intended recipient, please notify the sender prior to deleting this email 
message from your system. Please note ViFX reserves the right to monitor, from 
time to time, the communications sent to and from its email network.