Review Request: Cloudstack-2736 [Multiple_IP_Ranges] Failed to deploy vm with IP address from new CIDR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11621/ --- Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- Cloudstack-2736 [Multiple_IP_Ranges] Failed to deploy vm with IP address from new CIDR https://issues.apache.org/jira/browse/CLOUDSTACK-2736 This addresses bug Cloudstack-2736. Diffs - server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java f7e77f3 Diff: https://reviews.apache.org/r/11621/diff/ Testing --- tested on master. Thanks, bharat kumar
Re: Review Request: Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset to existing CIDR is allowed https://issues.apache.org/jira/browse/CLOUDSTACK-2511, Cloudstack-2651 [Sha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11600/ --- (Updated June 4, 2013, 2:51 p.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description (updated) --- Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset to existing CIDR is allowed https://issues.apache.org/jira/browse/CLOUDSTACK-2511 Cloudstack-2651 [Shared n/w]Add IP range should not ask for gateway and netmask while adding the ip range to the existing subnet. https://issues.apache.org/jira/browse/CLOUDSTACK-2651 This addresses bugs Cloudstack-2511 and Cloudstack-2651. Diffs (updated) - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf server/test/com/cloud/configuration/ValidateIpRangeTest.java 7681667 utils/src/com/cloud/utils/net/NetUtils.java 8c094c8 Diff: https://reviews.apache.org/r/11600/diff/ Testing --- Tested with master. Thanks, bharat kumar
Review Request: Cloudstack-2854 [Multiple_IP_Ranges] Failed to create ip alias on VR while deploying guest vm with ip address from new CIDR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11656/ --- Review request for cloudstack and Abhinandan Prateek. Description --- [Multiple_IP_Ranges] Failed to create ip alias on VR while deploying guest vm with ip address from new CIDR https://issues.apache.org/jira/browse/CLOUDSTACK-2854 This addresses bug Cloudstack-2854. Diffs - core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 9e40eef scripts/network/domr/call_dnsmasq.sh PRE-CREATION scripts/network/domr/createipAlias.sh PRE-CREATION scripts/network/domr/deleteipAlias.sh PRE-CREATION Diff: https://reviews.apache.org/r/11656/diff/ Testing --- tested on master. Thanks, bharat kumar
Re: Review Request: Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset to existing CIDR is allowed https://issues.apache.org/jira/browse/CLOUDSTACK-2511, Cloudstack-2651 [Sha
> On June 10, 2013, 4:23 p.m., Koushik Das wrote: > > Don't combine multiple fixes in a single commit. Keep it simple -> 1 commit > > = 1 bug fix These issues are closely related to each other and so i think combining them is not bad - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11600/#review21654 --- On June 4, 2013, 2:51 p.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11600/ > --- > > (Updated June 4, 2013, 2:51 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > --- > > Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset > to existing CIDR is allowed > https://issues.apache.org/jira/browse/CLOUDSTACK-2511 > > Cloudstack-2651 [Shared n/w]Add IP range should not ask for gateway and > netmask while adding the ip range to the existing subnet. > https://issues.apache.org/jira/browse/CLOUDSTACK-2651 > > > This addresses bugs Cloudstack-2511 and Cloudstack-2651. > > > Diffs > - > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf > server/test/com/cloud/configuration/ValidateIpRangeTest.java 7681667 > utils/src/com/cloud/utils/net/NetUtils.java 8c094c8 > > Diff: https://reviews.apache.org/r/11600/diff/ > > > Testing > --- > > Tested with master. > > > Thanks, > > bharat kumar > >
Re: Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
> On June 11, 2013, 5:19 a.m., Koushik Das wrote: > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 3037 > > <https://reviews.apache.org/r/11435/diff/2/?file=299906#file299906line3037> > > > > Instead of using _accountDao.findById(Account.ACCOUNT_ID_SYSTEM) why > > don't you pass the 'caller' parameter from the calling function The ip alias is a system managed ip so think it should not belong to any of the caller's account - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/#review21688 ------- On June 3, 2013, 10:27 a.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11435/ > --- > > (Updated June 3, 2013, 10:27 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > --- > > [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C > https://issues.apache.org/jira/browse/CLOUDSTACK-2621 > > > This addresses bug Cloudstack-2621. > > > Diffs > - > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > c71d037 > > Diff: https://reviews.apache.org/r/11435/diff/ > > > Testing > --- > > tested on master. > > > Thanks, > > bharat kumar > >
Re: Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
> On June 11, 2013, 5:22 a.m., Koushik Das wrote: > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 3083 > > <https://reviews.apache.org/r/11435/diff/2/?file=299906#file299906line3083> > > > > if result_final == false, why is txn committed? i missed the txn.rollback here, the txn.commit is okay. - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/#review21692 --- On June 3, 2013, 10:27 a.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11435/ > --- > > (Updated June 3, 2013, 10:27 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > --- > > [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C > https://issues.apache.org/jira/browse/CLOUDSTACK-2621 > > > This addresses bug Cloudstack-2621. > > > Diffs > - > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > c71d037 > > Diff: https://reviews.apache.org/r/11435/diff/ > > > Testing > --- > > tested on master. > > > Thanks, > > bharat kumar > >
Re: Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/ --- (Updated June 11, 2013, 6:33 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C https://issues.apache.org/jira/browse/CLOUDSTACK-2621 This addresses bug Cloudstack-2621. Diffs (updated) - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037 Diff: https://reviews.apache.org/r/11435/diff/ Testing --- tested on master. Thanks, bharat kumar
Re: Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/ --- (Updated June 11, 2013, 6:38 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C https://issues.apache.org/jira/browse/CLOUDSTACK-2621 This addresses bug Cloudstack-2621. Diffs (updated) - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037 Diff: https://reviews.apache.org/r/11435/diff/ Testing --- tested on master. Thanks, bharat kumar
Re: Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
> On June 11, 2013, 8:42 a.m., Koushik Das wrote: > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 2967 > > <https://reviews.apache.org/r/11435/diff/4/?file=303425#file303425line2967> > > > > why not pass the 'caller' parameter to handleIpAliasDelete? I am not using the caller in the handleIpAliasDeletion - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/#review21700 --- On June 11, 2013, 6:38 a.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11435/ > --- > > (Updated June 11, 2013, 6:38 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > --- > > [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C > https://issues.apache.org/jira/browse/CLOUDSTACK-2621 > > > This addresses bug Cloudstack-2621. > > > Diffs > - > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > c71d037 > > Diff: https://reviews.apache.org/r/11435/diff/ > > > Testing > --- > > tested on master. > > > Thanks, > > bharat kumar > >
Re: Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/ --- (Updated June 11, 2013, 11:16 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C https://issues.apache.org/jira/browse/CLOUDSTACK-2621 This addresses bug Cloudstack-2621. Diffs (updated) - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037 Diff: https://reviews.apache.org/r/11435/diff/ Testing --- tested on master. Thanks, bharat kumar
Re: Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/ --- (Updated June 12, 2013, 10:28 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C https://issues.apache.org/jira/browse/CLOUDSTACK-2621 This addresses bug Cloudstack-2621. Diffs (updated) - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java db4786a Diff: https://reviews.apache.org/r/11435/diff/ Testing --- tested on master. Thanks, bharat kumar
Re: Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/ --- (Updated June 12, 2013, 10:59 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C https://issues.apache.org/jira/browse/CLOUDSTACK-2621 This addresses bug Cloudstack-2621. Diffs (updated) - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java db4786a Diff: https://reviews.apache.org/r/11435/diff/ Testing --- tested on master. Thanks, bharat kumar
Review Request: CLOUDSTACK-2963 Build failure due to validateIpRange test failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11833/ --- Review request for cloudstack and Abhinandan Prateek. Description --- CLOUDSTACK-2963 Build failure due to validateIpRange test failure https://issues.apache.org/jira/browse/CLOUDSTACK-2963 This addresses bug Cloudstack-2963. Diffs - server/test/com/cloud/configuration/ValidateIpRangeTest.java a083cc6 Diff: https://reviews.apache.org/r/11833/diff/ Testing --- Test succeeded on master. Thanks, bharat kumar
Re: Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/ --- (Updated June 17, 2013, 10:01 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Changes --- rebased with master. Description --- [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C https://issues.apache.org/jira/browse/CLOUDSTACK-2621 This addresses bug Cloudstack-2621. Diffs (updated) - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 111586d server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java db4786a Diff: https://reviews.apache.org/r/11435/diff/ Testing --- tested on master. Thanks, bharat kumar
Review Request: Cloudstack-2644 [Multiple_IP_Ranges] user data service on VR does not work in case of multiple subnets Cloudstack-2953 [Multiple_IP_Ranges] VM does not get the public key from VR incas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11959/ --- Review request for cloudstack and Abhinandan Prateek. Description --- Cloudstack-2644 [Multiple_IP_Ranges] user data service on VR does not work in case of multiple subnets https://issues.apache.org/jira/browse/CLOUDSTACK-2644 Cloudstack-2953 [Multiple_IP_Ranges] VM does not get the public key from VR incase of multiple subnets per vlan Also removed some unused code. https://issues.apache.org/jira/browse/CLOUDSTACK-2953 This addresses bugs Cloudstack-2644 and Cloudstack-2953. Diffs - patches/systemvm/debian/config/etc/init.d/cloud-early-config 0dcd571 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 8da5176 server/src/com/cloud/vm/dao/NicIpAliasDao.java f1e4b8e server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java e6c52a2 setup/bindir/cloud-set-guest-sshkey.in 15008b8 Diff: https://reviews.apache.org/r/11959/diff/ Testing --- tested on master. Thanks, bharat kumar
Review Request: Cloudstack-2938 [Multiple_IP_Ranges] Password Service does not work in case of multiple subnets in a vlan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11960/ --- Review request for cloudstack and Abhinandan Prateek. Description --- Cloudstack-2938 [Multiple_IP_Ranges] Password Service does not work in case of multiple subnets in a vlan https://issues.apache.org/jira/browse/CLOUDSTACK-2938 This addresses bug Cloudstack-2938. Diffs - patches/systemvm/debian/config/root/createIpAlias.sh 2c79813 Diff: https://reviews.apache.org/r/11960/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request: Cloudstack-2644 [Multiple_IP_Ranges] user data service on VR does not work in case of multiple subnets Cloudstack-2953 [Multiple_IP_Ranges] VM does not get the public key from VR i
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11959/ --- (Updated June 20, 2013, 5:37 a.m.) Review request for cloudstack and Abhinandan Prateek. Description --- Cloudstack-2644 [Multiple_IP_Ranges] user data service on VR does not work in case of multiple subnets https://issues.apache.org/jira/browse/CLOUDSTACK-2644 Cloudstack-2953 [Multiple_IP_Ranges] VM does not get the public key from VR incase of multiple subnets per vlan Also removed some unused code. https://issues.apache.org/jira/browse/CLOUDSTACK-2953 This addresses bugs Cloudstack-2644 and Cloudstack-2953. Diffs (updated) - patches/systemvm/debian/config/etc/init.d/cloud-early-config 0dcd571 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 8edd5bd server/src/com/cloud/vm/dao/NicIpAliasDao.java f1e4b8e server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java e6c52a2 setup/bindir/cloud-set-guest-sshkey.in f3f02b1 Diff: https://reviews.apache.org/r/11959/diff/ Testing --- tested on master. Thanks, bharat kumar
Re: Review Request: Cloudstack-2644 [Multiple_IP_Ranges] user data service on VR does not work in case of multiple subnets Cloudstack-2953 [Multiple_IP_Ranges] VM does not get the public key from VR i
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11959/ --- (Updated June 20, 2013, 5:39 a.m.) Review request for cloudstack and Abhinandan Prateek. Changes --- Removed tabs Description --- Cloudstack-2644 [Multiple_IP_Ranges] user data service on VR does not work in case of multiple subnets https://issues.apache.org/jira/browse/CLOUDSTACK-2644 Cloudstack-2953 [Multiple_IP_Ranges] VM does not get the public key from VR incase of multiple subnets per vlan Also removed some unused code. https://issues.apache.org/jira/browse/CLOUDSTACK-2953 This addresses bugs Cloudstack-2644 and Cloudstack-2953. Diffs (updated) - patches/systemvm/debian/config/etc/init.d/cloud-early-config 0dcd571 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 8edd5bd server/src/com/cloud/vm/dao/NicIpAliasDao.java f1e4b8e server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java e6c52a2 setup/bindir/cloud-set-guest-sshkey.in f3f02b1 Diff: https://reviews.apache.org/r/11959/diff/ Testing --- tested on master. Thanks, bharat kumar
Review Request 12107: Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries. Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results in
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12107/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-2150 and Cloudstack-2980 Repository: cloudstack-git Description --- Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries. https://issues.apache.org/jira/browse/CLOUDSTACK-2980 Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results in inconsistent DB entries https://issues.apache.org/jira/browse/CLOUDSTACK-2980 Diffs - engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java e97f2c6 server/src/com/cloud/network/NetworkServiceImpl.java 25cd887 Diff: https://reviews.apache.org/r/12107/diff/ Testing --- tested on master. Thanks, bharat kumar
Review Request 12109: HAProxy maxconn is not configurable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12109/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-2997 Repository: cloudstack-git Description --- Cloudstack-2997 HAProxy maxconn is not configurable https://issues.apache.org/jira/browse/CLOUDSTACK-2997 Diffs - api/src/com/cloud/offering/NetworkOffering.java 5f522eb api/src/org/apache/cloudstack/api/ApiConstants.java b43f06c api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java febb0c3 api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 core/src/com/cloud/network/HAProxyConfigurator.java 29fdf4a engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java fae315b plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java b21e8f9 plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 2bdb28f plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e server/src/com/cloud/configuration/Config.java 2b0ffaf server/src/com/cloud/configuration/ConfigurationManager.java 8db037b server/src/com/cloud/configuration/ConfigurationManagerImpl.java 97f0d33 server/src/com/cloud/network/NetworkManagerImpl.java 8c2806a server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 7f3a88e server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 21b3590 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 4a2c867 setup/db/db/schema-410to420.sql 181f1cb Diff: https://reviews.apache.org/r/12109/diff/ Testing --- Tested on master. Thanks, bharat kumar
Review Request 12110: Cloudstack-3106 Delete all the ips except for the ip alias.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12110/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-3106 Repository: cloudstack-git Description --- Cloudstack-3106 Delete all the ips except for the ip alias. https://issues.apache.org/jira/browse/CLOUDSTACK-3106 Diffs - engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc server/src/com/cloud/configuration/ConfigurationManagerImpl.java 97f0d33 Diff: https://reviews.apache.org/r/12110/diff/ Testing --- Tested on master. Thanks, bharat kumar
Review Request 12111: [Multiple_IP_Ranges] Deleting guest IP range is not throwing any error message to user while the ip addresses are being used
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12111/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-2732 Repository: cloudstack-git Description --- [Multiple_IP_Ranges] Deleting guest IP range is not throwing any error message to user while the ip addresses are being used https://issues.apache.org/jira/browse/CLOUDSTACK-2732 Diffs - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 97f0d33 Diff: https://reviews.apache.org/r/12111/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 12107: Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries. Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12107/ --- (Updated June 27, 2013, 9:26 a.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-2150 and Cloudstack-2980 Repository: cloudstack-git Description --- Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries. https://issues.apache.org/jira/browse/CLOUDSTACK-2980 Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results in inconsistent DB entries https://issues.apache.org/jira/browse/CLOUDSTACK-2980 Diffs (updated) - engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java e97f2c6 server/src/com/cloud/network/NetworkServiceImpl.java 5e900bb Diff: https://reviews.apache.org/r/12107/diff/ Testing --- tested on master. Thanks, bharat kumar
Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the ip alias.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12110/ --- (Updated June 27, 2013, 10:56 a.m.) Review request for cloudstack and Abhinandan Prateek. Changes --- rebased with master-stable. Bugs: Cloudstack-3106 Repository: cloudstack-git Description --- Cloudstack-3106 Delete all the ips except for the ip alias. https://issues.apache.org/jira/browse/CLOUDSTACK-3106 Diffs (updated) - engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc server/src/com/cloud/configuration/ConfigurationManagerImpl.java cb4f76b Diff: https://reviews.apache.org/r/12110/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the ip alias.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12110/ --- (Updated June 27, 2013, 10:57 a.m.) Review request for cloudstack and Abhinandan Prateek. Changes --- rebased with master. Bugs: Cloudstack-3106 Repository: cloudstack-git Description --- Cloudstack-3106 Delete all the ips except for the ip alias. https://issues.apache.org/jira/browse/CLOUDSTACK-3106 Diffs (updated) - engine/schema/src/com/cloud/dc/VlanVO.java a2f7a9c server/src/com/cloud/configuration/ConfigurationManagerImpl.java 041f29a Diff: https://reviews.apache.org/r/12110/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the ip alias.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12110/ --- (Updated June 28, 2013, 9:13 a.m.) Review request for cloudstack and Abhinandan Prateek. Changes --- rebased with master-stable. Bugs: Cloudstack-3106 Repository: cloudstack-git Description --- Cloudstack-3106 Delete all the ips except for the ip alias. https://issues.apache.org/jira/browse/CLOUDSTACK-3106 Diffs (updated) - engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc engine/schema/src/com/cloud/network/dao/IPAddressDao.java fecd44a engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 886011e server/src/com/cloud/configuration/ConfigurationManagerImpl.java cb4f76b server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 4b29eab Diff: https://reviews.apache.org/r/12110/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the ip alias. Cloudstack-3119 Shared network removal doesn't cleanup corresponding IP ranges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12110/ --- (Updated June 28, 2013, 9:14 a.m.) Review request for cloudstack and Abhinandan Prateek. Summary (updated) - Cloudstack-3106 Delete all the ips except for the ip alias. Cloudstack-3119 Shared network removal doesn't cleanup corresponding IP ranges Bugs: Cloudstack-3106 Repository: cloudstack-git Description (updated) --- Cloudstack-3106 Delete all the ips except for the ip alias. https://issues.apache.org/jira/browse/CLOUDSTACK-3106 Cloudstack-3119 Shared network removal doesn't cleanup corresponding IP ranges https://issues.apache.org/jira/browse/CLOUDSTACK-3119 Diffs - engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc engine/schema/src/com/cloud/network/dao/IPAddressDao.java fecd44a engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 886011e server/src/com/cloud/configuration/ConfigurationManagerImpl.java cb4f76b server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 4b29eab Diff: https://reviews.apache.org/r/12110/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 12111: [Multiple_IP_Ranges] Deleting guest IP range is not throwing any error message to user while the ip addresses are being used
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12111/ --- (Updated June 28, 2013, 11:26 a.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-2732 Repository: cloudstack-git Description --- [Multiple_IP_Ranges] Deleting guest IP range is not throwing any error message to user while the ip addresses are being used https://issues.apache.org/jira/browse/CLOUDSTACK-2732 Diffs (updated) - server/src/com/cloud/configuration/ConfigurationManagerImpl.java c19f401 Diff: https://reviews.apache.org/r/12111/diff/ Testing --- Tested on master. Thanks, bharat kumar
Review Request 12207: Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware, Cloudstack-3240 corrected a mistake in the script name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12207/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-3240 and Cloudstack-3299 Repository: cloudstack-git Description --- Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware, Cloudstack-3240 corrected a mistake in the script name. Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 286eb48 Diff: https://reviews.apache.org/r/12207/diff/ Testing --- Thanks, bharat kumar
Review Request 12209: Cloudstack-3302 VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12209/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-3302 Repository: cloudstack-git Description --- Cloudstack-3302 VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 286eb48 Diff: https://reviews.apache.org/r/12209/diff/ Testing --- Thanks, bharat kumar
Re: Review Request 12220: Cloudstack-3313 Ipv6 - Not able to deploy a new VM in IPV6 network.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12220/ --- (Updated July 2, 2013, 2:07 a.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-3313 Repository: cloudstack-git Description --- Cloudstack-3313 Ipv6 - Not able to deploy a new VM in IPV6 network. Diffs - server/src/com/cloud/network/NetworkManagerImpl.java eef5d76 Diff: https://reviews.apache.org/r/12220/diff/ Testing --- Thanks, bharat kumar
Review Request 12220: Cloudstack-3313 Ipv6 - Not able to deploy a new VM in IPV6 network.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12220/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-3313 Repository: cloudstack-git Description --- Cloudstack-3313 Ipv6 - Not able to deploy a new VM in IPV6 network. Diffs - server/src/com/cloud/network/NetworkManagerImpl.java eef5d76 Diff: https://reviews.apache.org/r/12220/diff/ Testing --- Thanks, bharat kumar
Review Request 12224: Cloudstack-3313 Ipv6 - Not able to deploy a new VM in IPV6 network
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12224/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-3313 Repository: cloudstack-git Description --- Cloudstack-3313 Ipv6 - Not able to deploy a new VM in IPV6 network Diffs - patches/systemvm/debian/config/etc/init.d/cloud-early-config b215271 server/src/com/cloud/configuration/ConfigurationManagerImpl.java eba246f server/src/com/cloud/network/NetworkManagerImpl.java eef5d76 Diff: https://reviews.apache.org/r/12224/diff/ Testing --- Thanks, bharat kumar
Re: Review Request 12207: Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware, Cloudstack-3240 corrected a mistake in the script name.
> On July 2, 2013, 6:26 a.m., Abhinandan Prateek wrote: > > Has this been tested ? I did not test the fix, I don't have access to the vmware setup as of now. - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12207/#review22646 --- On July 1, 2013, 12:53 p.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12207/ > --- > > (Updated July 1, 2013, 12:53 p.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Bugs: Cloudstack-3240 and Cloudstack-3299 > > > Repository: cloudstack-git > > > Description > --- > > Cloudstack-3299 incorrect arguments sent to the script createIpalias in case > of vmware, > Cloudstack-3240 corrected a mistake in the script name. > > > Diffs > - > > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 286eb48 > > Diff: https://reviews.apache.org/r/12207/diff/ > > > Testing > --- > > > Thanks, > > bharat kumar > >
Re: Review Request 12207: Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware, Cloudstack-3240 corrected a mistake in the script name.
> On July 2, 2013, 6:28 a.m., Abhinandan Prateek wrote: > > Also for two bug fixes submit different reviews or if they are duplicate > > mark these as such. linked the issues - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12207/#review22647 --- On July 1, 2013, 12:53 p.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12207/ > --- > > (Updated July 1, 2013, 12:53 p.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Bugs: Cloudstack-3240 and Cloudstack-3299 > > > Repository: cloudstack-git > > > Description > --- > > Cloudstack-3299 incorrect arguments sent to the script createIpalias in case > of vmware, > Cloudstack-3240 corrected a mistake in the script name. > > > Diffs > - > > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 286eb48 > > Diff: https://reviews.apache.org/r/12207/diff/ > > > Testing > --- > > > Thanks, > > bharat kumar > >
Review Request 12251: Incorporating the review comments given by Alena and Sheng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ --- Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and Sheng Yang. Repository: cloudstack-git Description --- Incorporating the review comments given by Alena and Sheng. Diffs - api/src/com/cloud/agent/api/to/DnsmasqTO.java c7be04d api/src/com/cloud/network/element/DhcpServiceProvider.java 83008ca core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java a52af90 core/src/com/cloud/network/DnsMasqConfigurator.java dd34926 engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8 engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69 patches/systemvm/debian/config/root/createIpAlias.sh 1db210b patches/systemvm/debian/config/root/deleteIpAlias.sh cf6d4de patches/systemvm/debian/config/root/dnsmasq.sh 656fd3c scripts/network/domr/call_dnsmasq.sh 097e185 scripts/vm/hypervisor/xenserver/createipAlias.sh c35658e scripts/vm/hypervisor/xenserver/deleteipAlias.sh 6816edd server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java e863af4 utils/src/com/cloud/utils/net/NetUtils.java 5c13454 Diff: https://reviews.apache.org/r/12251/diff/ Testing --- Thanks, bharat kumar
Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review22722 --- core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java <https://reviews.apache.org/r/12251/#comment46413> rename the dnsmasqto to dhcpto engine/schema/src/com/cloud/network/dao/IPAddressDao.java <https://reviews.apache.org/r/12251/#comment46414> Removed the sqlexception. engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java <https://reviews.apache.org/r/12251/#comment46415> removed the sqlexception server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/12251/#comment46416> added the enum server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/12251/#comment46417> removed the sql exception server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/12251/#comment46418> not using rollback explicitly server/src/com/cloud/network/element/VirtualRouterElement.java <https://reviews.apache.org/r/12251/#comment46419> not catching the exception any more server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/12251/#comment46420> renamed dnsmasq to dhcpto - bharat kumar On July 3, 2013, 3:50 p.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12251/ > --- > > (Updated July 3, 2013, 3:50 p.m.) > > > Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and > Sheng Yang. > > > Repository: cloudstack-git > > > Description > --- > > Incorporating the review comments given by Alena and Sheng. > > > Diffs > - > > api/src/com/cloud/agent/api/to/DnsmasqTO.java c7be04d > api/src/com/cloud/network/element/DhcpServiceProvider.java 83008ca > core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java a52af90 > core/src/com/cloud/network/DnsMasqConfigurator.java dd34926 > engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8 > engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69 > patches/systemvm/debian/config/root/createIpAlias.sh 1db210b > patches/systemvm/debian/config/root/deleteIpAlias.sh cf6d4de > patches/systemvm/debian/config/root/dnsmasq.sh 656fd3c > scripts/network/domr/call_dnsmasq.sh 097e185 > scripts/vm/hypervisor/xenserver/createipAlias.sh c35658e > scripts/vm/hypervisor/xenserver/deleteipAlias.sh 6816edd > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 > server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde > server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > e863af4 > utils/src/com/cloud/utils/net/NetUtils.java 5c13454 > > Diff: https://reviews.apache.org/r/12251/diff/ > > > Testing > --- > > > Thanks, > > bharat kumar > >
Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng
> On July 3, 2013, 3:58 p.m., bharat kumar wrote:
> > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 3054
> > <https://reviews.apache.org/r/12251/diff/1/?file=318002#file318002line3054>
> >
> > removed the sql exception
>
> Alena Prokharchyk wrote:
> Bharat, I still see SQLException being caught:
>
> } catch (SQLException e) {
> 3090
> throw new CloudRuntimeException(e.getMessage());
> 3104
> }
> 3091
> }
>
> Can you please remove this try/catch as you are not throwing the
> exception any longer?
The function deletePublicIPRangeExceptAliasIP used in handleIpAliasDeletion
throws the sql exception.
- bharat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12251/#review22722
-------
On July 3, 2013, 3:50 p.m., bharat kumar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12251/
> ---
>
> (Updated July 3, 2013, 3:50 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and
> Sheng Yang.
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Incorporating the review comments given by Alena and Sheng.
>
>
> Diffs
> -
>
> api/src/com/cloud/agent/api/to/DnsmasqTO.java c7be04d
> api/src/com/cloud/network/element/DhcpServiceProvider.java 83008ca
> core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java a52af90
> core/src/com/cloud/network/DnsMasqConfigurator.java dd34926
> engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8
> engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69
> patches/systemvm/debian/config/root/createIpAlias.sh 1db210b
> patches/systemvm/debian/config/root/deleteIpAlias.sh cf6d4de
> patches/systemvm/debian/config/root/dnsmasq.sh 656fd3c
> scripts/network/domr/call_dnsmasq.sh 097e185
> scripts/vm/hypervisor/xenserver/createipAlias.sh c35658e
> scripts/vm/hypervisor/xenserver/deleteipAlias.sh 6816edd
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51
> server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde
> server/src/com/cloud/network/element/VirtualRouterElement.java 1916678
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
> e863af4
> utils/src/com/cloud/utils/net/NetUtils.java 5c13454
>
> Diff: https://reviews.apache.org/r/12251/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ --- (Updated July 4, 2013, 2:09 a.m.) Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and Sheng Yang. Changes --- Sheng commented on the issue that we are calling the function configDhcpSupportForSubnet for all dhcp service providers even if they do not support multiple subnets. This will cause the dhcp config to fail in cases which do not support this feature. I fixed this by adding the dhcpservice across multiple subnets as a capability of the virtualrouter's dhcp service, introduced a check before adding a new subnet and also before calling the configDhcpSupportForSubnet. Repository: cloudstack-git Description --- Incorporating the review comments given by Alena and Sheng. Diffs (updated) - api/src/com/cloud/network/Network.java a06208b api/src/com/cloud/network/NetworkService.java 405cecd server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 server/src/com/cloud/network/NetworkManagerImpl.java 708c03d server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 server/test/com/cloud/network/MockNetworkManagerImpl.java 077395f server/test/com/cloud/vpc/MockNetworkManagerImpl.java b609022 Diff: https://reviews.apache.org/r/12251/diff/ Testing --- Thanks, bharat kumar
Review Request 12273: Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results inco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12273/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-2150 and Cloudstack-2980 Repository: cloudstack-git Description --- Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results inconsistent DB entries This fix was causing a regression due to which the state of the physical network was not getting updated and as a result basic zone deployment failed. Resubmitting the fixed code. Diffs - engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java e97f2c6 server/src/com/cloud/network/NetworkServiceImpl.java f88f600 Diff: https://reviews.apache.org/r/12273/diff/ Testing --- Tested basic zone deployment. adding vlan removing vlan removing all vlan checked if all the added vlans are in the db. Thanks, bharat kumar
Review Request 12323: Cloudstack-4241 Adding ip range fails if there are two IP ranges existing in two different CIDRs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12323/ --- Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy. Bugs: Cloudstack-32141 Repository: cloudstack-git Description --- Cloudstack-4241 Adding ip range fails if there are two IP ranges existing in two different CIDRs Diffs - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1c973b8 Diff: https://reviews.apache.org/r/12323/diff/ Testing --- Tested on master-stable Thanks, bharat kumar
Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review22836 --- server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/12251/#comment46541> Not calling the Transaction start here. i broke them into smaller transactions. Also not holing the transaction while sending the command to the backend. - bharat kumar On July 4, 2013, 2:09 a.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12251/ > --- > > (Updated July 4, 2013, 2:09 a.m.) > > > Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and > Sheng Yang. > > > Repository: cloudstack-git > > > Description > --- > > Incorporating the review comments given by Alena and Sheng. > > > Diffs > - > > api/src/com/cloud/network/Network.java a06208b > api/src/com/cloud/network/NetworkService.java 405cecd > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 > server/src/com/cloud/network/NetworkManagerImpl.java 708c03d > server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde > server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 > server/test/com/cloud/network/MockNetworkManagerImpl.java 077395f > server/test/com/cloud/vpc/MockNetworkManagerImpl.java b609022 > > Diff: https://reviews.apache.org/r/12251/diff/ > > > Testing > --- > > > Thanks, > > bharat kumar > >
Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ --- (Updated July 8, 2013, 5:47 p.m.) Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and Sheng Yang. Repository: cloudstack-git Description --- Incorporating the review comments given by Alena and Sheng. Diffs (updated) - engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8 engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 Diff: https://reviews.apache.org/r/12251/diff/ Testing --- Thanks, bharat kumar
Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review22839 --- engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java <https://reviews.apache.org/r/12251/#comment46547> removed the raw sql code. server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/12251/#comment46549> Not catching the SQL exception any more. - bharat kumar On July 8, 2013, 5:47 p.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12251/ > --- > > (Updated July 8, 2013, 5:47 p.m.) > > > Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and > Sheng Yang. > > > Repository: cloudstack-git > > > Description > --- > > Incorporating the review comments given by Alena and Sheng. > > > Diffs > - > > engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8 > engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 > > Diff: https://reviews.apache.org/r/12251/diff/ > > > Testing > --- > > > Thanks, > > bharat kumar > >
Re: Review Request 12323: Cloudstack-3241 Adding ip range fails if there are two IP ranges existing in two different CIDRs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12323/ --- (Updated July 9, 2013, 5:35 a.m.) Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy. Summary (updated) - Cloudstack-3241 Adding ip range fails if there are two IP ranges existing in two different CIDRs Bugs: Cloudstack-32141 Repository: cloudstack-git Description --- Cloudstack-4241 Adding ip range fails if there are two IP ranges existing in two different CIDRs Diffs - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1c973b8 Diff: https://reviews.apache.org/r/12323/diff/ Testing --- Tested on master-stable Thanks, bharat kumar
Re: Review Request 12273: Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12273/ --- (Updated July 10, 2013, 5:43 p.m.) Review request for cloudstack and Abhinandan Prateek. Changes --- updated and rebased the code with master-stable Bugs: Cloudstack-2150 and Cloudstack-2980 Repository: cloudstack-git Description --- Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results inconsistent DB entries This fix was causing a regression due to which the state of the physical network was not getting updated and as a result basic zone deployment failed. Resubmitting the fixed code. Diffs (updated) - engine/schema/src/com/cloud/dc/dao/DataCenterDao.java ed6e696 engine/schema/src/com/cloud/dc/dao/DataCenterDaoImpl.java 503306f engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java 778498d engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java e97f2c6 server/src/com/cloud/network/NetworkServiceImpl.java 49bfb88 server/test/com/cloud/network/UpdatePhysicalNetworkTest.java 25c023e Diff: https://reviews.apache.org/r/12273/diff/ Testing --- Tested basic zone deployment. adding vlan removing vlan removing all vlan checked if all the added vlans are in the db. Thanks, bharat kumar
Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ --- (Updated July 13, 2013, 2:33 p.m.) Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and Sheng Yang. Changes --- incorporating the comments given by Murali. Revoking the alias ip when the last vm from the subnet is expunged. Repository: cloudstack-git Description --- Incorporating the review comments given by Alena and Sheng. Diffs (updated) - api/src/com/cloud/agent/api/to/DhcpTO.java PRE-CREATION api/src/com/cloud/agent/api/to/DnsmasqTO.java c7be04d api/src/com/cloud/network/Network.java a06208b api/src/com/cloud/network/NetworkService.java 405cecd api/src/com/cloud/network/element/DhcpServiceProvider.java 83008ca core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java a52af90 core/src/com/cloud/network/DnsMasqConfigurator.java dd34926 engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8 engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69 patches/systemvm/debian/config/root/createIpAlias.sh 1db210b patches/systemvm/debian/config/root/deleteIpAlias.sh cf6d4de scripts/network/domr/call_dnsmasq.sh 097e185 scripts/vm/hypervisor/xenserver/createipAlias.sh c35658e scripts/vm/hypervisor/xenserver/deleteipAlias.sh 6816edd server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 server/src/com/cloud/network/NetworkManagerImpl.java 708c03d server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java e863af4 server/src/com/cloud/vm/VirtualMachineManagerImpl.java de0368a server/test/com/cloud/network/MockNetworkManagerImpl.java 077395f server/test/com/cloud/vpc/MockNetworkManagerImpl.java b609022 utils/src/com/cloud/utils/net/NetUtils.java 5c13454 Diff: https://reviews.apache.org/r/12251/diff/ Testing --- Thanks, bharat kumar
Review board is not accessible.
Can some one restart it .
Review Request 12622: Cloudstack-3313 Unable to deploy a vm in ipv6 network.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12622/ --- Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy. Bugs: Cloudstack-3313 Repository: cloudstack-git Description --- Cloudstack-3313 Unable to deploy a vm in ipv6 network. Diffs - patches/systemvm/debian/config/etc/init.d/cloud-early-config f93c39d server/src/com/cloud/configuration/ConfigurationManagerImpl.java 7e0bc25 server/src/com/cloud/network/NetworkManagerImpl.java 42430bc Diff: https://reviews.apache.org/r/12622/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 12109: HAProxy maxconn is not configurable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12109/ --- (Updated July 17, 2013, 2:07 a.m.) Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy. Changes --- Rebased with master Bugs: Cloudstack-2997 Repository: cloudstack-git Description --- Cloudstack-2997 HAProxy maxconn is not configurable https://issues.apache.org/jira/browse/CLOUDSTACK-2997 Diffs (updated) - api/src/com/cloud/offering/NetworkOffering.java 43312db api/src/org/apache/cloudstack/api/ApiConstants.java 83999b6 api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java 94e263c api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 core/src/com/cloud/network/HAProxyConfigurator.java 162571f engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 6317f72 plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 5f603b3 plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 5d6a671 plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e server/src/com/cloud/configuration/Config.java e77f6ce server/src/com/cloud/configuration/ConfigurationManager.java 1b99b63 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 7e0bc25 server/src/com/cloud/network/NetworkManagerImpl.java 42430bc server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 7bd2864 server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 7a61978 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 36564d9 setup/db/db/schema-410to420.sql e9fa995 Diff: https://reviews.apache.org/r/12109/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 12109: HAProxy maxconn is not configurable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12109/ --- (Updated July 17, 2013, 3:41 a.m.) Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy. Changes --- rebased with master. Bugs: Cloudstack-2997 Repository: cloudstack-git Description --- Cloudstack-2997 HAProxy maxconn is not configurable https://issues.apache.org/jira/browse/CLOUDSTACK-2997 Diffs (updated) - api/src/com/cloud/offering/NetworkOffering.java 43312db api/src/org/apache/cloudstack/api/ApiConstants.java 83999b6 api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java 94e263c api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java ba685a9 core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 1c1fb91 core/src/com/cloud/network/HAProxyConfigurator.java 162571f engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 6317f72 plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 9c34a8b plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 5d6a671 plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java a19a82e server/src/com/cloud/configuration/Config.java e77f6ce server/src/com/cloud/configuration/ConfigurationManager.java 1b99b63 server/src/com/cloud/configuration/ConfigurationManagerImpl.java fd170bd server/src/com/cloud/network/NetworkManagerImpl.java f6e9a0a server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 0a67cff server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 7a61978 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java 9825cab setup/db/db/schema-410to420.sql e9fa995 Diff: https://reviews.apache.org/r/12109/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ --- (Updated July 17, 2013, 5:52 a.m.) Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and Sheng Yang. Changes --- rebased with master. Repository: cloudstack-git Description --- Incorporating the review comments given by Alena and Sheng. Diffs (updated) - api/src/com/cloud/agent/api/to/DhcpTO.java PRE-CREATION api/src/com/cloud/agent/api/to/DnsmasqTO.java c7be04d api/src/com/cloud/network/Network.java a06208b api/src/com/cloud/network/NetworkService.java 405cecd api/src/com/cloud/network/element/DhcpServiceProvider.java 83008ca core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java a52af90 core/src/com/cloud/network/DnsMasqConfigurator.java dd34926 engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java cecc145 engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8 engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69 engine/schema/src/com/cloud/vm/dao/NicDao.java 83f280e engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java 420643f patches/systemvm/debian/config/root/createIpAlias.sh 1db210b patches/systemvm/debian/config/root/deleteIpAlias.sh cf6d4de patches/systemvm/debian/config/root/dnsmasq.sh 656fd3c scripts/network/domr/call_dnsmasq.sh 097e185 scripts/vm/hypervisor/xenserver/createipAlias.sh c35658e scripts/vm/hypervisor/xenserver/deleteipAlias.sh 6816edd server/src/com/cloud/configuration/ConfigurationManagerImpl.java 801028d server/src/com/cloud/network/NetworkManagerImpl.java db375c3 server/src/com/cloud/network/NetworkServiceImpl.java ccd23bf server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java e437af6 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 39d0895 server/src/com/cloud/vm/VirtualMachineManagerImpl.java afdc85d server/test/com/cloud/network/MockNetworkManagerImpl.java 9c7d092 server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java 04a3601 server/test/com/cloud/vpc/MockNetworkManagerImpl.java 523dfb8 utils/conf/db.properties e1b5fe9 utils/src/com/cloud/utils/net/NetUtils.java 68f4965 Diff: https://reviews.apache.org/r/12251/diff/ Testing --- Thanks, bharat kumar
Regarding the bug Cloudstack-3589 VM created from VPC network is not getting IP
Hi Dann, The bug fix https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=b903262df5e2ff5d174859ce28abae75c4689f0c is causing an null value in dnsmasq.config file while creating VPC network (bug-id Cloudstack-3589 ). Can you please take a look at this. Regards, Bharat.
Re: Regarding the bug Cloudstack-3589 VM created from VPC network is not getting IP
Hi Dann, The commit d73bb22802cba9116f27fada6780c966b0060b30 changes the name of the dnamsqTo to dhcpTo and adds some dns specific config as a part of the review comments. The bug Cloudstack-3589 is because of passing null value to the dhcpto ( As a result the dhcp setting has a null in it.) , It is not related to the changes made in commit d73bb22802cba9116f27fada6780c966b0060b30. Also i think this issue can be fixed in parallel, i mean no need to wait for rewrite of the dnsmasqconfigurator in bash. This bug is not introduced because of the Dnsmasqconfigurator. The rewire only changes the way we configure the dnamsq. Instead of generating the file in java and overwriting the file in the virtualrouter with the new config, we are going to edit the existing file. This is being done as overwriting the existing config file is error prone. However I am going to upload the patch related to dnsmasqconfigurator rewrite today. Regards, Bharat. On Jul 21, 2013, at 5:26 PM, Daan Hoogland wrote: > Bharat, > > sorry to haven't noticed this post earlier; > > Your commit d73bb22802cba9116f27fada6780c966b0060b30 is changing code of > commit b903262df5e2ff5d174859ce28abae75c4689f0c. What is the rationale > behind changing configDnsMasq() in VpcVirtualNetworkApplianceManagerImpl? > > regards, > Daan > > > On Thu, Jul 18, 2013 at 6:52 PM, Bharat Kumar wrote: > >> Hi Dann, >> >> The bug fix >> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=b903262df5e2ff5d174859ce28abae75c4689f0cis >> causing an null value in dnsmasq.config file while creating VPC network >> (bug-id Cloudstack-3589 ). >> >> Can you please take a look at this. >> >> Regards, >> Bharat.
Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Diffs - core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df patches/systemvm/debian/config/root/createIpAlias.sh 5498195 patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 scripts/vm/hypervisor/xenserver/vmops f8c0253 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 Diff: https://reviews.apache.org/r/12810/diff/ Testing --- Tested on old master using xenserver. Could not test on the latest one as it is broken. Thanks, bharat kumar
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 22, 2013, 12:54 p.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes --- Removed set -x from dnsmasq.sh Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Diffs (updated) - core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df patches/systemvm/debian/config/root/createIpAlias.sh 5498195 patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 scripts/vm/hypervisor/xenserver/vmops f8c0253 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 Diff: https://reviews.apache.org/r/12810/diff/ Testing --- Tested on old master using xenserver. Could not test on the latest one as it is broken. Thanks, bharat kumar
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
> On July 22, 2013, 10:23 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 54 > > <https://reviews.apache.org/r/12810/diff/2/?file=324528#file324528line54> > > > > You don't need so complicate way to find dns is enabled or not. Just > > check /var/cache/cloud/cmdline for entry " dns1", " dns2"(remember add > > leading space to avoid ip6dns) > > > > And if cmdline contained "useextdns=true", then dns1/dns2 should be > > used directly in such case. You don't need to check eth0 ip is dns or not. > > > > In fact I don't think you need to add dhcp-option=tag:xxx,6,xxx for dns > > server of every range you added. You should able to use the original > > dhcp-option=6,xxx to cover all the cases. It should by default cover > > everything. Hi sheng, in case if useextndns is not true we have to add the routerip corresponding to each subnet so we need to add the option like this dhcp-option=tag:xxx,6,xxx. - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23649 --- On July 22, 2013, 12:54 p.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12810/ > --- > > (Updated July 22, 2013, 12:54 p.m.) > > > Review request for cloudstack, Alena Prokharchyk and Sheng Yang. > > > Bugs: CLOUDSTACK-3694 > > > Repository: cloudstack-git > > > Description > --- > > https://issues.apache.org/jira/browse/CLOUDSTACK-3694 > > wrote the dnsmasq config in bash instead of creating the config file in java > and overwriting. > > > Diffs > - > > core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > 0b26220 > core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df > patches/systemvm/debian/config/root/createIpAlias.sh 5498195 > patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > c7f487e > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > f80d4b6 > scripts/vm/hypervisor/xenserver/vmops f8c0253 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 6c0f7a1 > > Diff: https://reviews.apache.org/r/12810/diff/ > > > Testing > --- > > Tested on old master using xenserver. > Could not test on the latest one as it is broken. > > > Thanks, > > bharat kumar > >
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 23, 2013, 12:42 p.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes --- Incorporated the review comments. Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Diffs (updated) - build/replace.properties 265f335 core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df patches/systemvm/debian/config/root/createIpAlias.sh 5498195 patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 scripts/vm/hypervisor/xenserver/vmops f8c0253 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 Diff: https://reviews.apache.org/r/12810/diff/ Testing --- Tested on old master using xenserver. Could not test on the latest one as it is broken. Thanks, bharat kumar
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 23, 2013, 1:07 p.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes --- added the remove multiple_ranges.conf statement in cloud-early-config. Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Diffs (updated) - core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 scripts/vm/hypervisor/xenserver/vmops f8c0253 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 Diff: https://reviews.apache.org/r/12810/diff/ Testing --- Tested on old master using xenserver. Could not test on the latest one as it is broken. Thanks, bharat kumar
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
> On July 23, 2013, 8:51 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 100 > > <https://reviews.apache.org/r/12810/diff/4/?file=325449#file325449line100> > > > > dhcp-option=tag.* is not in the log the dhcp-option=tag* will be there in the new config. I am not logging it as it is not a part of the config which i am removing from /etc/dnsmasq.conf. - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23713 --- On July 23, 2013, 1:07 p.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12810/ > --- > > (Updated July 23, 2013, 1:07 p.m.) > > > Review request for cloudstack, Alena Prokharchyk and Sheng Yang. > > > Bugs: CLOUDSTACK-3694 > > > Repository: cloudstack-git > > > Description > --- > > https://issues.apache.org/jira/browse/CLOUDSTACK-3694 > > wrote the dnsmasq config in bash instead of creating the config file in java > and overwriting. > > > Diffs > - > > core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > 0b26220 > core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df > patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 > patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > c7f487e > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > f80d4b6 > scripts/vm/hypervisor/xenserver/vmops f8c0253 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 6c0f7a1 > > Diff: https://reviews.apache.org/r/12810/diff/ > > > Testing > --- > > Tested on old master using xenserver. > Could not test on the latest one as it is broken. > > > Thanks, > > bharat kumar > >
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
> On July 23, 2013, 8:51 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 100 > > <https://reviews.apache.org/r/12810/diff/4/?file=325449#file325449line100> > > > > dhcp-option=tag.* is not in the log > > bharat kumar wrote: > the dhcp-option=tag* will be there in the new config. I am not logging it > as it is not a part of the config which i am removing from /etc/dnsmasq.conf. > > Sheng Yang wrote: > Not quite understand... All your new config should be in > /etc/dnsmasq.d/multiple_ranges.conf rather than /etc/dnsmasq.conf. Why there > are any dhcp-options=tag* in dnsmasq.conf? Sheng you are right. This setting is not there in the dnsmasq.conf. so this line is not needed. I will remove it. - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23713 ------- On July 23, 2013, 1:07 p.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12810/ > --- > > (Updated July 23, 2013, 1:07 p.m.) > > > Review request for cloudstack, Alena Prokharchyk and Sheng Yang. > > > Bugs: CLOUDSTACK-3694 > > > Repository: cloudstack-git > > > Description > --- > > https://issues.apache.org/jira/browse/CLOUDSTACK-3694 > > wrote the dnsmasq config in bash instead of creating the config file in java > and overwriting. > > > Diffs > - > > core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > 0b26220 > core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df > patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 > patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > c7f487e > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > f80d4b6 > scripts/vm/hypervisor/xenserver/vmops f8c0253 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 6c0f7a1 > > Diff: https://reviews.apache.org/r/12810/diff/ > > > Testing > --- > > Tested on old master using xenserver. > Could not test on the latest one as it is broken. > > > Thanks, > > bharat kumar > >
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 24, 2013, 10:28 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes --- Fixed the issues pointed out in the review. Also added a fix to handle vms with multiple nics. Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Diffs (updated) - core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 scripts/vm/hypervisor/xenserver/vmops f8c0253 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 7a4bf50 Diff: https://reviews.apache.org/r/12810/diff/ Testing --- Tested on old master using xenserver. Could not test on the latest one as it is broken. Thanks, bharat kumar
Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- Review request for cloudstack and Sheng Yang. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than "add" or "remove" per command Diffs - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 24, 2013, 8:02 p.m.) Review request for cloudstack and Sheng Yang. Changes --- Fixed UpdatePhysicalNetworkTest and a bug which led to wrong display of the vnet string. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than "add" or "remove" per command Diffs (updated) - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
Hi Alena, The code as of now works with a valn siting having ranges separated by semicolons(it is like this now 2001-2003;2012-2013, I will update it to work with comas. rather than compare each range with the existing one we have used sets to figure out what to add and and what to remove. On Jul 25, 2013, at 4:26 AM, Alena Prokharchyk mailto:alena.prokharc...@citrix.com>> wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ 1) Bharat, can you please check if your API allows you to set the vnet range with the multiple ranges. The command syntax should be like this - vnets should be specified and separated by comma: http://localhost:8096/?command=updatePhysicalNetwork&id=200&vlan=2001-2010,2012-2013 2) Also I find it very confusing that you are continuing to store the vnet field in physical_network table. Once the ranges were introduced, you should have moved them to the separate data structure as its very hard to update/validate the String representation as every single time you have to * split the ranges * validate each range against the new range you pass in - Alena Prokharchyk On July 24th, 2013, 9:57 p.m. UTC, bharat kumar wrote: Review request for cloudstack, Alena Prokharchyk and Sheng Yang. By bharat kumar. Updated July 24, 2013, 9:57 p.m. Bugs: Cloudstack-3753 Repository: cloudstack-git Description https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than "add" or "remove" per command Testing Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Diffs * api/src/com/cloud/network/NetworkService.java (59ccdbf) * api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java (333564e) * engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java (e2e6b79) * engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java (ced2982) * server/src/com/cloud/network/NetworkServiceImpl.java (f1f71ca) * server/test/com/cloud/network/MockNetworkManagerImpl.java (4577d0a) * server/test/com/cloud/network/UpdatePhysicalNetworkTest.java (e3fc36a) * server/test/com/cloud/vpc/MockNetworkManagerImpl.java (fd61bc6) View Diff<https://reviews.apache.org/r/12905/diff/>
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
Thank you Sheng.
Bharat.
On Jul 25, 2013, at 12:20 AM, Sheng Yang
mailto:sh...@yasker.org>> wrote:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12810/
Ship it!
Nice work!
patches/systemvm/debian/config/root/dnsmasq.sh<https://reviews.apache.org/r/12810/diff/4-5/?file=325449#file325449line59>
(Diff revisions 4 - 5)
56
dns2=$(grep -o " dns2=.* " "$CMDLINE" | sed -e 's/dns2=//' | awk '{print $1}')
59
dns2=$(echo "CMDLINE" | grep -o " dns2=.* " | sed -e 's/dns2=//' | awk '{print
$1}')
Typo here. I would fix it when check in the patch.
- Sheng Yang
On July 24th, 2013, 10:28 a.m. UTC, bharat kumar wrote:
Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
By bharat kumar.
Updated July 24, 2013, 10:28 a.m.
Bugs: CLOUDSTACK-3694
Repository: cloudstack-git
Description
https://issues.apache.org/jira/browse/CLOUDSTACK-3694
wrote the dnsmasq config in bash instead of creating the config file in java
and overwriting.
Testing
Tested on old master using xenserver.
Could not test on the latest one as it is broken.
Diffs
* core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java (521ad70)
*
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
(0b26220)
* core/src/com/cloud/network/DnsMasqConfigurator.java (3fc61df)
* patches/systemvm/debian/config/etc/init.d/cloud-early-config (c04ff90)
* patches/systemvm/debian/config/root/dnsmasq.sh (b70e2d3)
*
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
(c7f487e)
*
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
(f80d4b6)
* scripts/vm/hypervisor/xenserver/vmops (f8c0253)
*
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
(6c0f7a1)
* server/src/com/cloud/vm/VirtualMachineManagerImpl.java (7a4bf50)
View Diff<https://reviews.apache.org/r/12810/diff/>
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 26, 2013, 4:17 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes --- Now vlan list can be specified using a coma instead of a semicolon. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than "add" or "remove" per command Diffs (updated) - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
> On July 26, 2013, 4:56 a.m., Jenkins Cloudstack.org wrote: > > Review 12905 failed the build test : FAILURE > > The url of build cloudstack-master-with-patch #42 is : > > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/42/ this patch did not apply. will rebase with master and resubmit. - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/#review23911 --- On July 26, 2013, 4:17 a.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12905/ > --- > > (Updated July 26, 2013, 4:17 a.m.) > > > Review request for cloudstack, Alena Prokharchyk and Sheng Yang. > > > Bugs: Cloudstack-3753 > > > Repository: cloudstack-git > > > Description > --- > > https://issues.apache.org/jira/browse/CLOUDSTACK-3753 > Multiple VLAN range API need to accept a list rather than "add" or "remove" > per command > > > Diffs > - > > api/src/com/cloud/network/NetworkService.java 59ccdbf > > api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java > 333564e > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 > server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca > server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a > server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a > server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 > > Diff: https://reviews.apache.org/r/12905/diff/ > > > Testing > --- > > Tested on master. > removed the removevlan parameter. > vlan parameter can be used for both addition and removal of valns. > instead of passing only a vlan range. user has to pass all the vlan ranges > that he wants to keep. > the vlan ranges missing in the input and present in the db (not allocated) > will be removed. > > > Thanks, > > bharat kumar > >
Review Request 12966: overcommited memory is not getting displayed at zone level and used % is based on actual memory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12966/ --- Review request for cloudstack, Kishan Kavala and Nitin Mehta. Bugs: Cloudstack-1640 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-1640 overcommited memory is not getting displayed at zone level and used % is based on actual memory Diffs - server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f Diff: https://reviews.apache.org/r/12966/diff/ Testing --- Tested on older master. deployed vms and checked the capacites displayed on the dashboard. Thanks, bharat kumar
Review Request 12967: Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12967/ --- Review request for cloudstack, Kishan Kavala and Nitin Mehta. Bugs: Cloudstack-1695 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-1695 Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure(required cpu for stopped vm is >> available cpu ) Diffs - server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f Diff: https://reviews.apache.org/r/12967/diff/ Testing --- Tested on old master. This happened because we were not recalculating the used and the reserved capacities based on the new overcommit ratio. Now used and reserved capacities of all the hosts in a overcommited cluster will be recalculated on overcommit change by the capacity checker. However this will happen only when capacity checker runs meaning the change in capacities due to updated overcommit values will not be instantaneous. Thanks, bharat kumar
Review Request 13011: XEN - Unable to deploy VM in guest network VLAN with different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13011/ --- Review request for cloudstack and Sheng Yang. Bugs: Cloudstack-3871 Repository: cloudstack-git Description --- XEN - Unable to deploy VM in guest network VLAN with different subnets https://issues.apache.org/jira/browse/CLOUDSTACK-3871 Diffs - scripts/vm/hypervisor/xenserver/vmops 9a0ef44 Diff: https://reviews.apache.org/r/13011/diff/ Testing --- Tested with latest 4.2 Thanks, bharat kumar
Regarding the variable names in the VOs.
Hi all, I am came across a bug which was caused because of using underscore in the variable name in the VO. @Column(name = "concurrent_connections") Integer concurrent_connections; because of this the call to update dose not update the VO and if the API is used only with this parameter the API server throws an error. but if i change it to @Column(name = "concurrent_connections") Integer concurrentConnections; (remove the underscore) it works. Dose any one know why this dependency is there. Regards, Bharat.
Review Request 13012: createipAlias.sh/deleteipAliash.sh should not be allowed with Isolated Guest Networks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13012/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-2622 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-2622 createipAlias.sh/deleteipAliash.sh should not be allowed with Isolated Guest Networks Diffs - server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 2a8a6e2 Diff: https://reviews.apache.org/r/13012/diff/ Testing --- Tested with 4.2 Thanks, bharat kumar
Review Request 13013: remove the duplicate entries of the data-server from the /etc/hosts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13013/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-3882 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3882 remove the duplicate entries of the data-server from the /etc/hosts Diffs - patches/systemvm/debian/config/etc/init.d/cloud-early-config c0a7189 Diff: https://reviews.apache.org/r/13013/diff/ Testing --- Tested on 4.2 Thanks, bharat kumar
Re: Review Request 13013: remove the duplicate entries of the data-server from the /etc/hosts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13013/ --- (Updated July 29, 2013, 12:17 p.m.) Review request for cloudstack and Abhinandan Prateek. Changes --- Made the regex tighter. Bugs: Cloudstack-3882 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3882 remove the duplicate entries of the data-server from the /etc/hosts Diffs (updated) - patches/systemvm/debian/config/etc/init.d/cloud-early-config c0a7189 Diff: https://reviews.apache.org/r/13013/diff/ Testing --- Tested on 4.2 Thanks, bharat kumar
Review Request 13022: Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13022/ --- Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs: Cloustack-3910 Repository: cloudstack-git Description --- Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions. https://issues.apache.org/jira/browse/CLOUDSTACK-3910 Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e8ca579 setup/db/db/schema-410to420.sql 7377cbd Diff: https://reviews.apache.org/r/13022/diff/ Testing --- Tested upgrade from 3.0.6 to 4.2 Thanks, bharat kumar
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 30, 2013, 8:46 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes --- Moved the functionality of adding and remove vlan to addOrRemoveVlan function. This is called by both create and update physicalnetwork methods. As a result both create and update physical network can handle multiple vlan ranges. now we can reset the valan ranges to a null value. Added a comment to clarify the usage of the deletevnets function. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than "add" or "remove" per command Diffs (updated) - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
> On July 29, 2013, 8:45 p.m., Alena Prokharchyk wrote: > > 1) DataCenterVnetDaoImpl.java > > > > deleteRange method. > > > > List vnets - this type is very ambigous. How is it represented? > > 100-200? 100,101,102,103? People are going to use this method, you either > > have to document it well, or use diff datastructure. > > > > 2) Not able to re-set the range back to NULL > > > > 3) The main concern: > > > > createPhysicalNetwork should work just as updatePhysicalNetwork. Right now > > it fails: > > > > http://localhost:8096/?command=createPhysicalNetwork&name=200&vlan=1-2,6-100&zoneId=1 > > > > > > 431 > > 4350 > > Please specify valid integers for the vlan range. > > fixed these issues. - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/#review24171 --- On July 30, 2013, 8:46 a.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12905/ > --- > > (Updated July 30, 2013, 8:46 a.m.) > > > Review request for cloudstack, Alena Prokharchyk and Sheng Yang. > > > Bugs: Cloudstack-3753 > > > Repository: cloudstack-git > > > Description > --- > > https://issues.apache.org/jira/browse/CLOUDSTACK-3753 > Multiple VLAN range API need to accept a list rather than "add" or "remove" > per command > > > Diffs > - > > api/src/com/cloud/network/NetworkService.java 59ccdbf > > api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java > 333564e > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 > server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca > server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a > server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a > server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 > > Diff: https://reviews.apache.org/r/12905/diff/ > > > Testing > --- > > Tested on master. > removed the removevlan parameter. > vlan parameter can be used for both addition and removal of valns. > instead of passing only a vlan range. user has to pass all the vlan ranges > that he wants to keep. > the vlan ranges missing in the input and present in the db (not allocated) > will be removed. > > > Thanks, > > bharat kumar > >
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 30, 2013, 8:53 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than "add" or "remove" per command Diffs (updated) - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
Review Request 13058: unable to update the concurrent_connections in networkoffering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13058/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-2997 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-2997 cloud not update the concurrent_connections parameter of networkoffering because of some dao dependency. The update was not happening because of choosing a VO variable name having a underscore. Diffs - engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 406d98a server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3ec3514 Diff: https://reviews.apache.org/r/13058/diff/ Testing --- Tested on 4.2 Thanks, bharat kumar
Re: Review Request 13058: unable to update the concurrent_connections in networkoffering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13058/ --- (Updated July 30, 2013, 10:52 a.m.) Review request for cloudstack and Abhinandan Prateek. Changes --- Added maxconnections to the response of the create and update network offering Bugs: Cloudstack-2997 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-2997 cloud not update the concurrent_connections parameter of networkoffering because of some dao dependency. The update was not happening because of choosing a VO variable name having a underscore. Diffs (updated) - api/src/org/apache/cloudstack/api/response/NetworkOfferingResponse.java 6b35d7b engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 406d98a server/src/com/cloud/api/ApiResponseHelper.java e331bef server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3ec3514 Diff: https://reviews.apache.org/r/13058/diff/ Testing --- Tested on 4.2 Thanks, bharat kumar
Re: Review Request 13022: Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13022/ --- (Updated July 30, 2013, 11:15 a.m.) Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs: Cloustack-3910 Repository: cloudstack-git Description --- Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions. https://issues.apache.org/jira/browse/CLOUDSTACK-3910 Diffs (updated) - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e8ca579 setup/db/db/schema-410to420.sql 7377cbd Diff: https://reviews.apache.org/r/13022/diff/ Testing --- Tested upgrade from 3.0.6 to 4.2 Thanks, bharat kumar
Re: Review Request 12966: overcommited memory is not getting displayed at zone level and used % is based on actual memory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12966/ --- (Updated July 30, 2013, 2:11 p.m.) Review request for cloudstack, Kishan Kavala and Nitin Mehta. Changes --- uploaded the correct file. Bugs: Cloudstack-1640 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-1640 overcommited memory is not getting displayed at zone level and used % is based on actual memory Diffs (updated) - engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java dc2899f server/src/com/cloud/alert/AlertManagerImpl.java bff36c7 server/src/com/cloud/api/ApiResponseHelper.java f7b740b server/src/com/cloud/server/ManagementServerImpl.java 0bdb114 Diff: https://reviews.apache.org/r/12966/diff/ Testing --- Tested on older master. deployed vms and checked the capacites displayed on the dashboard. Thanks, bharat kumar
Re: Review Request 13022: Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13022/ --- (Updated July 30, 2013, 2:47 p.m.) Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Changes --- rebased the patch with master. Bugs: Cloustack-3910 Repository: cloudstack-git Description --- Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions. https://issues.apache.org/jira/browse/CLOUDSTACK-3910 Diffs (updated) - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 61e6781 setup/db/db/schema-410to420.sql f392603 Diff: https://reviews.apache.org/r/13022/diff/ Testing --- Tested upgrade from 3.0.6 to 4.2 Thanks, bharat kumar
Re: Review Request 12967: Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12967/ --- (Updated July 30, 2013, 3:55 p.m.) Review request for cloudstack, Kishan Kavala and Nitin Mehta. Changes --- Changed the naming convention and fixed the reserve memory recalculate. Bugs: Cloudstack-1695 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-1695 Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure(required cpu for stopped vm is >> available cpu ) Diffs (updated) - server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f Diff: https://reviews.apache.org/r/12967/diff/ Testing --- Tested on old master. This happened because we were not recalculating the used and the reserved capacities based on the new overcommit ratio. Now used and reserved capacities of all the hosts in a overcommited cluster will be recalculated on overcommit change by the capacity checker. However this will happen only when capacity checker runs meaning the change in capacities due to updated overcommit values will not be instantaneous. Thanks, bharat kumar
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 31, 2013, 2:46 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes --- Fixed the error with update physical network Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than "add" or "remove" per command Diffs (updated) - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
Re: Review Request 13058: unable to update the concurrent_connections in networkoffering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13058/ --- (Updated July 31, 2013, 5:51 a.m.) Review request for cloudstack and Abhinandan Prateek. Changes --- rebased with master. Bugs: Cloudstack-2997 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-2997 cloud not update the concurrent_connections parameter of networkoffering because of some dao dependency. The update was not happening because of choosing a VO variable name having a underscore. Diffs (updated) - api/src/org/apache/cloudstack/api/response/NetworkOfferingResponse.java 6b35d7b engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java b0cb85d server/src/com/cloud/api/ApiResponseHelper.java c1ae7d0 server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e6c00 Diff: https://reviews.apache.org/r/13058/diff/ Testing --- Tested on 4.2 Thanks, bharat kumar
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
> On July 31, 2013, 7:35 a.m., Likitha Shetty wrote: > > Since you have changed the vnet range separator from ';' to ',' > > PhysicalNetworkVO -> getVnet needs to be updated. > > This method is referenced in quite a few places. > > > > If not already done, please open a bug to track the UI changes that will be > > needed once this change is checked in. sure Likitha will check if i have done this and update the patch. Thank you for the comment. - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/#review24330 ------- On July 31, 2013, 2:46 a.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12905/ > --- > > (Updated July 31, 2013, 2:46 a.m.) > > > Review request for cloudstack, Alena Prokharchyk and Sheng Yang. > > > Bugs: Cloudstack-3753 > > > Repository: cloudstack-git > > > Description > --- > > https://issues.apache.org/jira/browse/CLOUDSTACK-3753 > Multiple VLAN range API need to accept a list rather than "add" or "remove" > per command > > > Diffs > - > > api/src/com/cloud/network/NetworkService.java 59ccdbf > > api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java > 333564e > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 > server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca > server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a > server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a > server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 > > Diff: https://reviews.apache.org/r/12905/diff/ > > > Testing > --- > > Tested on master. > removed the removevlan parameter. > vlan parameter can be used for both addition and removal of valns. > instead of passing only a vlan range. user has to pass all the vlan ranges > that he wants to keep. > the vlan ranges missing in the input and present in the db (not allocated) > will be removed. > > > Thanks, > > bharat kumar > >
Re: Review Request 12967: Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12967/ --- (Updated July 31, 2013, 9:49 a.m.) Review request for cloudstack, Kishan Kavala and Nitin Mehta. Changes --- rebased the patch with 4.2 Bugs: Cloudstack-1695 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-1695 Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure(required cpu for stopped vm is >> available cpu ) Diffs (updated) - server/src/com/cloud/capacity/CapacityManagerImpl.java 56c3b71 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 31bae47 Diff: https://reviews.apache.org/r/12967/diff/ Testing --- Tested on old master. This happened because we were not recalculating the used and the reserved capacities based on the new overcommit ratio. Now used and reserved capacities of all the hosts in a overcommited cluster will be recalculated on overcommit change by the capacity checker. However this will happen only when capacity checker runs meaning the change in capacities due to updated overcommit values will not be instantaneous. Thanks, bharat kumar
Re: Review Request 12967: Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12967/ --- (Updated July 31, 2013, 9:54 a.m.) Review request for cloudstack, Kishan Kavala and Nitin Mehta. Changes --- revision 3 is for 4.2 revision 4 is for master. Bugs: Cloudstack-1695 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-1695 Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure(required cpu for stopped vm is >> available cpu ) Diffs (updated) - server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f Diff: https://reviews.apache.org/r/12967/diff/ Testing --- Tested on old master. This happened because we were not recalculating the used and the reserved capacities based on the new overcommit ratio. Now used and reserved capacities of all the hosts in a overcommited cluster will be recalculated on overcommit change by the capacity checker. However this will happen only when capacity checker runs meaning the change in capacities due to updated overcommit values will not be instantaneous. Thanks, bharat kumar
Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13112/ --- Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: Cloudstack-3836 Repository: cloudstack-git Description --- upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes" https://issues.apache.org/jira/browse/CLOUDSTACK-3836 This extra column is because of the fix Parent id of template incorrectly recorded as last ISO attached to VM. when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation. we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template. Diffs - engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf server/src/com/cloud/storage/VolumeManager.java 2e44a3c server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 setup/db/db/schema-410to420.sql 9cdf837 Diff: https://reviews.apache.org/r/13112/diff/ Testing --- Tested on 4.2. Thanks, bharat kumar
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 31, 2013, 3:07 p.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes --- changed the function getvnets to use coma instead of semicolon. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than "add" or "remove" per command Diffs (updated) - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 engine/schema/src/com/cloud/network/dao/PhysicalNetworkVO.java f68eee1 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13112/ --- (Updated July 31, 2013, 7:17 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- Chaged the way we handle upgrade. now we remove the column iso_id in schema307-401 and add iso_id in schema401-402. Bugs: Cloudstack-3836 Repository: cloudstack-git Description --- upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes" https://issues.apache.org/jira/browse/CLOUDSTACK-3836 This extra column is because of the fix Parent id of template incorrectly recorded as last ISO attached to VM. when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation. we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template. Diffs (updated) - engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf server/src/com/cloud/storage/VolumeManager.java 2e44a3c server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 setup/db/db/schema-307to410.sql be6c17d setup/db/db/schema-410to420.sql 9cdf837 Diff: https://reviews.apache.org/r/13112/diff/ Testing --- Tested on 4.2. Thanks, bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13112/ --- (Updated Aug. 1, 2013, 4:34 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- rebased with 4.2 Bugs: Cloudstack-3836 Repository: cloudstack-git Description --- upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes" https://issues.apache.org/jira/browse/CLOUDSTACK-3836 This extra column is because of the fix Parent id of template incorrectly recorded as last ISO attached to VM. when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation. we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template. Diffs (updated) - engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 server/src/com/cloud/storage/VolumeManager.java 2e44a3c server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 setup/db/db/schema-410to420.sql 3f25c3b Diff: https://reviews.apache.org/r/13112/diff/ Testing --- Tested on 4.2. Thanks, bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13112/ --- (Updated Aug. 1, 2013, 4:51 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- rebased with master. Bugs: Cloudstack-3836 Repository: cloudstack-git Description --- upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes" https://issues.apache.org/jira/browse/CLOUDSTACK-3836 This extra column is because of the fix Parent id of template incorrectly recorded as last ISO attached to VM. when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation. we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template. Diffs (updated) - engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 server/src/com/cloud/storage/VolumeManager.java 13ddbab server/src/com/cloud/storage/VolumeManagerImpl.java 3cce8b6 server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5b7aa5b setup/db/db/schema-307to410.sql be6c17d setup/db/db/schema-410to420.sql 99a0208 Diff: https://reviews.apache.org/r/13112/diff/ Testing --- Tested on 4.2. Thanks, bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13112/ --- (Updated Aug. 1, 2013, 5:08 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- Missed a change while rebasing with 4.2 Bugs: Cloudstack-3836 Repository: cloudstack-git Description --- upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes" https://issues.apache.org/jira/browse/CLOUDSTACK-3836 This extra column is because of the fix Parent id of template incorrectly recorded as last ISO attached to VM. when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation. we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template. Diffs (updated) - engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 server/src/com/cloud/storage/VolumeManager.java 2e44a3c server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 setup/db/db/schema-307to410.sql be6c17d setup/db/db/schema-410to420.sql 3f25c3b Diff: https://reviews.apache.org/r/13112/diff/ Testing --- Tested on 4.2. Thanks, bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13112/ --- (Updated Aug. 1, 2013, 6:01 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- rebased with master Bugs: Cloudstack-3836 Repository: cloudstack-git Description --- upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes" https://issues.apache.org/jira/browse/CLOUDSTACK-3836 This extra column is because of the fix Parent id of template incorrectly recorded as last ISO attached to VM. when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation. we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template. Diffs (updated) - engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 server/src/com/cloud/storage/VolumeManager.java 13ddbab server/src/com/cloud/storage/VolumeManagerImpl.java 3cce8b6 server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5b7aa5b setup/db/db/schema-307to410.sql be6c17d setup/db/db/schema-410to420.sql 99a0208 Diff: https://reviews.apache.org/r/13112/diff/ Testing --- Tested on 4.2. Thanks, bharat kumar
Review Request 13239: fixed the test test_non_contigiousvlan.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13239/ --- Review request for cloudstack and Prasanna Santhanam. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- fixed the test test_non_contigiousvlan.py https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Diffs - test/integration/smoke/test_non_contigiousvlan.py 5fdc034 Diff: https://reviews.apache.org/r/13239/diff/ Testing --- tested on 4.2 Thanks, bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13112/ --- (Updated Aug. 2, 2013, 11:16 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- rebased with master. Bugs: Cloudstack-3836 Repository: cloudstack-git Description --- upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes" https://issues.apache.org/jira/browse/CLOUDSTACK-3836 This extra column is because of the fix Parent id of template incorrectly recorded as last ISO attached to VM. when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation. we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template. Diffs (updated) - engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 server/src/com/cloud/storage/VolumeManager.java 13ddbab server/src/com/cloud/storage/VolumeManagerImpl.java 393904e server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 08bca43 setup/db/db/schema-307to410.sql be6c17d setup/db/db/schema-410to420.sql 657d947 Diff: https://reviews.apache.org/r/13112/diff/ Testing --- Tested on 4.2. Thanks, bharat kumar
Review Request 13241: was not populating the overcommit details in uservm details when overcommit is decreased to one.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13241/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-1695 Repository: cloudstack-git Description --- was not populating the overcommit details in uservm details when overcommit is decreased to one. Diffs - server/src/com/cloud/vm/VirtualMachineManagerImpl.java cf24502 Diff: https://reviews.apache.org/r/13241/diff/ Testing --- Tested on 4.2 Thanks, bharat kumar
