Re: Review Request 24632: Updated health check to use the new CommandInfo.
On Aug. 13, 2014, 5:23 a.m., Timothy Chen wrote: src/health-check/main.cpp, line 171 https://reviews.apache.org/r/24632/diff/1/?file=659122#file659122line171 Thanks for the update! Do you mind adding a test for the shell path? Jie Yu wrote: I think the shell path should have already been tested by the existing tests, right? Timothy Chen wrote: Yes sorry the new exec path that you have. Done. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24632/#review50405 --- On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24632/ --- (Updated Aug. 13, 2014, 5:21 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- See summary. Diffs - src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789 Diff: https://reviews.apache.org/r/24632/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24464: Redirect docker logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50423 --- Patch looks great! Reviews applied: [24464] All tests passed. - Mesos ReviewBot On Aug. 12, 2014, 10:28 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 12, 2014, 10:28 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/24464 Diffs - src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d Diff: https://reviews.apache.org/r/24464/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 24464: Redirect docker logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50426 --- Just realized. What's the recover story? 1) what if the slave exits, does the log process terminate? 2) if the log process does not terminate, how do we recover it (so that we can destroy it later)? - Jie Yu On Aug. 12, 2014, 10:28 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 12, 2014, 10:28 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/24464 Diffs - src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d Diff: https://reviews.apache.org/r/24464/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 24194: Fixed bug in io::poll.
On Aug. 4, 2014, 10:48 p.m., Jie Yu wrote: 3rdparty/libprocess/src/process.cpp, line 3709 https://reviews.apache.org/r/24194/diff/1/?file=648813#file648813line3709 It's likely that _poll is called after poll-watcher.async has been stopped. Will that cause any issue when we invoke ev_async_send(loop, async.get()) in _poll? If not, it worths adding a comment here. Added a comment! - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24194/#review49473 --- On Aug. 1, 2014, 8:05 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24194/ --- (Updated Aug. 1, 2014, 8:05 p.m.) Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-1658 https://issues.apache.org/jira/browse/MESOS-1658 Repository: mesos-git Description --- See bug. Note that we already had tests for discarding an io::poll. Diffs - 3rdparty/libprocess/src/process.cpp 6f6f3f96a2c2354faf7a58f8627cd87fd22d9b9b Diff: https://reviews.apache.org/r/24194/diff/ Testing --- make check Thanks, Benjamin Hindman
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2310
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2310/changes Changes: [benjamin.hindman] Add ContainerInfo and Volumes protobufs. -- [...truncated 2577 lines...] mv -f examples/.deps/long_lived_executor-long_lived_executor.Tpo examples/.deps/long_lived_executor-long_lived_executor.Po /bin/bash ../libtool --tag=CXX --mode=link g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o long-lived-executor examples/long_lived_executor-long_lived_executor.o libmesos.la -lsasl2 -lcurl -lz -lrt libtool: link: g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o .libs/long-lived-executor examples/long_lived_executor-long_lived_executor.o ./.libs/libmesos.so -lsasl2 /usr/lib/x86_64-linux-gnu/libcurl-nss.so -lz -lrt -pthread g++ -DPACKAGE_NAME=\mesos\ -DPACKAGE_TARNAME=\mesos\ -DPACKAGE_VERSION=\0.20.0\ -DPACKAGE_STRING=\mesos\ 0.20.0\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\mesos\ -DVERSION=\0.20.0\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBCURL=1 -DHAVE_LIBSASL2=1 -I. -I../../src -Wall -Werror -DLIBDIR=\/usr/local/lib\ -DPKGLIBEXECDIR=\/usr/local/libexec/mesos\ -DPKGDATADIR=\/usr/local/share/mesos\ -I../../include -I../../3rdparty/libprocess/include -I../../3rdparty/libprocess/3rdparty/stout/include -I../include -I../include/mesos -I../3rdparty/libprocess/3rdparty/boost-1.53.0 -I../3rdparty/libprocess/3rdparty/picojson-4f93734 -I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/leveldb/include -I../3rdparty/zookeeper-3.4.5/src/c/include -I../3rdparty/zookeeper-3.4.5/src/c/generated -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT examples/no_executor_framework-no_executor_framework.o -MD -MP -MF examples/.deps/no_executor_framework-no_executor_framework.Tpo -c -o examples/no_executor_framework-no_executor_framework.o `test -f 'examples/no_executor_framework.cpp' || echo '../../src/'`examples/no_executor_framework.cpp mv -f examples/.deps/no_executor_framework-no_executor_framework.Tpo examples/.deps/no_executor_framework-no_executor_framework.Po /bin/bash ../libtool --tag=CXX --mode=link g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o no-executor-framework examples/no_executor_framework-no_executor_framework.o libmesos.la -lsasl2 -lcurl -lz -lrt libtool: link: g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o .libs/no-executor-framework examples/no_executor_framework-no_executor_framework.o ./.libs/libmesos.so -lsasl2 /usr/lib/x86_64-linux-gnu/libcurl-nss.so -lz -lrt -pthread g++ -DPACKAGE_NAME=\mesos\ -DPACKAGE_TARNAME=\mesos\ -DPACKAGE_VERSION=\0.20.0\ -DPACKAGE_STRING=\mesos\ 0.20.0\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\mesos\ -DVERSION=\0.20.0\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBCURL=1 -DHAVE_LIBSASL2=1 -I. -I../../src -Wall -Werror -DLIBDIR=\/usr/local/lib\ -DPKGLIBEXECDIR=\/usr/local/libexec/mesos\ -DPKGDATADIR=\/usr/local/share/mesos\ -I../../include -I../../3rdparty/libprocess/include -I../../3rdparty/libprocess/3rdparty/stout/include -I../include -I../include/mesos -I../3rdparty/libprocess/3rdparty/boost-1.53.0 -I../3rdparty/libprocess/3rdparty/picojson-4f93734 -I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/leveldb/include -I../3rdparty/zookeeper-3.4.5/src/c/include -I../3rdparty/zookeeper-3.4.5/src/c/generated -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT examples/docker_no_executor_framework-docker_no_executor_framework.o -MD -MP -MF examples/.deps/docker_no_executor_framework-docker_no_executor_framework.Tpo -c -o examples/docker_no_executor_framework-docker_no_executor_framework.o `test -f 'examples/docker_no_executor_framework.cpp' || echo '../../src/'`examples/docker_no_executor_framework.cpp mv -f examples/.deps/docker_no_executor_framework-docker_no_executor_framework.Tpo examples/.deps/docker_no_executor_framework-docker_no_executor_framework.Po /bin/bash ../libtool --tag=CXX --mode=link g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o docker-no-executor-framework examples/docker_no_executor_framework-docker_no_executor_framework.o libmesos.la -lsasl2 -lcurl -lz -lrt libtool: link: g++ -pthread -g -g2
Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review50433 --- Patch looks great! Reviews applied: [22313] All tests passed. - Mesos ReviewBot On Aug. 12, 2014, 11:07 p.m., Yifan Gu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ --- (Updated Aug. 12, 2014, 11:07 p.m.) Review request for mesos, Ian Downes and Vinod Kone. Bugs: MESOS-886 https://issues.apache.org/jira/browse/MESOS-886 Repository: mesos-git Description --- Added __runTask() to wait for the completion of containerizer-update() and check the result before sending RunTaskMessage. Diffs - src/slave/slave.hpp 9d4607e src/slave/slave.cpp 787bd05 src/tests/slave_tests.cpp 69be28f Diff: https://reviews.apache.org/r/22313/diff/ Testing --- SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved SlaveTest.LaunchTaskAfterContainerizerUpdate ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*LaunchTask* successful times 2000 make check File Attachments framework will exit https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff log https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log Thanks, Yifan Gu
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2332
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2332/changes Changes: [yujie.jay] Made value in CommandInfo optional and added argv. [yujie.jay] Refactored the protobuf message comparison logic. [yujie.jay] Updated health check to use the new CommandInfo. [yujie.jay] Updated mesos containerizer launcher to use the new CommandInfo. [yujie.jay] Updated slave http to use the new CommmandInfo. [yujie.jay] Updated command executor to use the new CommandInfo. -- [...truncated 3721 lines...] [ RUN ] StringsTest.Format [ OK ] StringsTest.Format (0 ms) [ RUN ] StringsTest.TokenizeStringWithDelimsAtStart [ OK ] StringsTest.TokenizeStringWithDelimsAtStart (0 ms) [ RUN ] StringsTest.TokenizeStringWithDelimsAtStartAndEnd [ OK ] StringsTest.TokenizeStringWithDelimsAtStartAndEnd (0 ms) [ RUN ] StringsTest.SplitStringWithDelimsAtStartAndEnd [ OK ] StringsTest.SplitStringWithDelimsAtStartAndEnd (0 ms) [ RUN ] StringsTest.SplitStringWithDelimsAtStart [ OK ] StringsTest.SplitStringWithDelimsAtStart (0 ms) [ RUN ] StringsTest.SplitN [ OK ] StringsTest.SplitN (0 ms) [ RUN ] StringsTest.SplitNStringWithDelimsAtEnd [ OK ] StringsTest.SplitNStringWithDelimsAtEnd (0 ms) [--] 29 tests from StringsTest (1 ms total) [--] 1 test from GzipTest [ RUN ] GzipTest.CompressDecompressString [ OK ] GzipTest.CompressDecompressString (93 ms) [--] 1 test from GzipTest (94 ms total) [--] 2 tests from Base64 [ RUN ] Base64.Encode [ OK ] Base64.Encode (0 ms) [ RUN ] Base64.Decode [ OK ] Base64.Decode (0 ms) [--] 2 tests from Base64 (0 ms total) [--] 6 tests from MultimapTest/0, where TypeParam = Multimapstd::string, unsigned short [ RUN ] MultimapTest/0.Size [ OK ] MultimapTest/0.Size (0 ms) [ RUN ] MultimapTest/0.Foreach [ OK ] MultimapTest/0.Foreach (0 ms) [ RUN ] MultimapTest/0.Remove [ OK ] MultimapTest/0.Remove (0 ms) [ RUN ] MultimapTest/0.Put [ OK ] MultimapTest/0.Put (0 ms) [ RUN ] MultimapTest/0.Keys [ OK ] MultimapTest/0.Keys (0 ms) [ RUN ] MultimapTest/0.Iterator [ OK ] MultimapTest/0.Iterator (0 ms) [--] 6 tests from MultimapTest/0 (0 ms total) [--] 1 test from NoneTest [ RUN ] NoneTest.Test [ OK ] NoneTest.Test (0 ms) [--] 1 test from NoneTest (0 ms total) [--] 5 tests from LinkedHashmapTest [ RUN ] LinkedHashmapTest.Values [ OK ] LinkedHashmapTest.Values (0 ms) [ RUN ] LinkedHashmapTest.Erase [ OK ] LinkedHashmapTest.Erase (0 ms) [ RUN ] LinkedHashmapTest.Contains [ OK ] LinkedHashmapTest.Contains (0 ms) [ RUN ] LinkedHashmapTest.Keys [ OK ] LinkedHashmapTest.Keys (0 ms) [ RUN ] LinkedHashmapTest.Put [ OK ] LinkedHashmapTest.Put (0 ms) [--] 5 tests from LinkedHashmapTest (0 ms total) [--] 1 test from Thread [ RUN ] Thread.local [ OK ] Thread.local (0 ms) [--] 1 test from Thread (0 ms total) [--] 3 tests from Stout [ RUN ] Stout.Bytes [ OK ] Stout.Bytes (0 ms) [ RUN ] Stout.Some [ OK ] Stout.Some (0 ms) [ RUN ] Stout.Set [ OK ] Stout.Set (0 ms) [--] 3 tests from Stout (0 ms total) [--] 1 test from OsSendfileTest [ RUN ] OsSendfileTest.sendfile [ OK ] OsSendfileTest.sendfile (0 ms) [--] 1 test from OsSendfileTest (1 ms total) [--] 1 test from ProtobufTest [ RUN ] ProtobufTest.JSON [ OK ] ProtobufTest.JSON (13 ms) [--] 1 test from ProtobufTest (13 ms total) [--] 9 tests from JsonTest [ RUN ] JsonTest.NumericAssignment [ OK ] JsonTest.NumericAssignment (0 ms) [ RUN ] JsonTest.NumberFormat [ OK ] JsonTest.NumberFormat (0 ms) [ RUN ] JsonTest.BooleanAssignement [ OK ] JsonTest.BooleanAssignement (0 ms) [ RUN ] JsonTest.CStringAssignment [ OK ] JsonTest.CStringAssignment (0 ms) [ RUN ] JsonTest.BinaryData [ OK ] JsonTest.BinaryData (0 ms) [ RUN ] JsonTest.BooleanFormat [ OK ] JsonTest.BooleanFormat (0 ms) [ RUN ] JsonTest.DefaultValueIsNull [ OK ] JsonTest.DefaultValueIsNull (0 ms) [ RUN ] JsonTest.parse [ OK ] JsonTest.parse (0 ms) [ RUN ] JsonTest.Find [ OK ] JsonTest.Find (0 ms) [--] 9 tests from JsonTest (0 ms total) [--] 2 tests from HashMapTest [ RUN ] HashMapTest.Contains [ OK ] HashMapTest.Contains (0 ms) [ RUN ] HashMapTest.Insert [ OK ] HashMapTest.Insert (0 ms) [--] 2 tests from HashMapTest (0 ms total) [--] 4 tests from Cache [ RUN ] Cache.Erase [ OK ] Cache.Erase (0 ms) [ RUN ] Cache.LRUEviction [ OK ] Cache.LRUEviction (0 ms) [ RUN ] Cache.Update [ OK ] Cache.Update (0 ms) [ RUN ]
Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2311
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2311/changes
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2046
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2046/changes Changes: [benjamin.hindman] Fixed bug in io::poll. -- [...truncated 3653 lines...] make[3]: Nothing to be done for `examples/java/test-framework'. make[3]: Nothing to be done for `examples/java/test-executor'. make[3]: Nothing to be done for `examples/java/test-exception-framework'. make[3]: Nothing to be done for `examples/java/test-multiple-executors-framework'. make[3]: Nothing to be done for `examples/java/test-log'. make[3]: Nothing to be done for `examples/python/test_containerizer.py'. make[3]: Nothing to be done for `examples/python/test-containerizer'. make[3]: Nothing to be done for `examples/python/test_framework.py'. make[3]: Nothing to be done for `examples/python/test-framework'. make[3]: Nothing to be done for `examples/python/test_executor.py'. make[3]: Nothing to be done for `examples/python/test-executor'. make[3]: Nothing to be done for `tests/balloon_framework_test.sh'. make[3]: Nothing to be done for `tests/low_level_scheduler_libprocess_test.sh'. make[3]: Nothing to be done for `tests/low_level_scheduler_pthread_test.sh'. make[3]: Nothing to be done for `tests/java_exception_test.sh'. make[3]: Nothing to be done for `tests/java_framework_test.sh'. make[3]: Nothing to be done for `tests/java_log_test.sh'. make[3]: Nothing to be done for `tests/no_executor_framework_test.sh'. make[3]: Nothing to be done for `tests/python_framework_test.sh'. make[3]: Nothing to be done for `tests/test_framework_test.sh'. make[3]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src' make check-local make[3]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src' ./mesos-tests Source directory: https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/ Build directory: https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/ Note: Google Test filter = [==] Running 0 tests from 0 test cases. [==] 0 tests from 0 test cases ran. (0 ms total) [ PASSED ] 0 tests. YOU HAVE 5 DISABLED TESTS make[3]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src' make[2]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src' make[1]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src' Making check in ec2 make[1]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/ec2' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/ec2' + date Wed Aug 13 10:12:51 UTC 2014 + GLOG_v=1 + MESOS_VERBOSE=1 + make check GTEST_SHUFFLE=1 Making check in . make[1]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/' make[1]: Nothing to be done for `check-am'. make[1]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/' Making check in 3rdparty make[1]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty' make check-recursive make[2]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty' Making check in libprocess make[3]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty/libprocess' Making check in 3rdparty make[4]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty/libprocess/3rdparty' make check-recursive make[5]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty/libprocess/3rdparty' Making check in stout make[6]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty/libprocess/3rdparty/stout' Making check in . make[7]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty/libprocess/3rdparty/stout' make[7]: Nothing to be done for `check-am'. make[7]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty/libprocess/3rdparty/stout' Making check in include make[7]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty/libprocess/3rdparty/stout/include' make[7]: Nothing to be done for `check'. make[7]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty/libprocess/3rdparty/stout/include' make[6]: Leaving directory
Re: Review Request 24628: MESOS-1171: unbundle gmock
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/#review50447 --- Patch looks great! Reviews applied: [24628] All tests passed. - Mesos ReviewBot On Aug. 13, 2014, 2:35 a.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/ --- (Updated Aug. 13, 2014, 2:35 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1171 https://issues.apache.org/jira/browse/MESOS-1171 Repository: mesos-git Description --- Enable support to build against unbundled versions of gmock. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24628/diff/ Testing --- configure make check configure --disable-bundled make check configure --with-gmock=/opt/gmock make check Thanks, Timothy St. Clair
Build failed in Jenkins: mesos-reviewbot #1331
See https://builds.apache.org/job/mesos-reviewbot/1331/
--
[...truncated 5435 lines...]
rm -rf zookeeper/.libs zookeeper/_libs
rm -f usage/*.o
rm -f usage/*.lo
rm -f zookeeper/*.o
rm -f zookeeper/*.lo
rm -rf ./.deps authorizer/.deps cli/.deps common/.deps containerizer/.deps
docker/.deps examples/.deps exec/.deps files/.deps health-check/.deps
java/jni/.deps jvm/.deps jvm/org/apache/.deps launcher/.deps linux/.deps
linux/routing/.deps linux/routing/filter/.deps linux/routing/link/.deps
linux/routing/queueing/.deps local/.deps log/.deps log/tool/.deps logging/.deps
master/.deps messages/.deps sasl/.deps sched/.deps scheduler/.deps slave/.deps
slave/containerizer/.deps slave/containerizer/isolators/cgroups/.deps
slave/containerizer/isolators/network/.deps slave/containerizer/mesos/.deps
state/.deps tests/.deps usage/.deps zookeeper/.deps
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.20.0/_build/src'
Making distclean in ec2
make[2]: Entering directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.20.0/_build/ec2'
rm -rf .libs _libs
rm -f *.lo
test -z || rm -f
test . = ../../ec2 || test -z || rm -f
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.20.0/_build/ec2'
rm -f config.status config.cache config.log configure.lineno
config.status.lineno
rm -f Makefile
make[1]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.20.0/_build'
if test -d mesos-0.20.0; then find mesos-0.20.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.20.0 || { sleep 5 rm -rf
mesos-0.20.0; }; else :; fi
==
mesos-0.20.0 archives ready for distribution:
mesos-0.20.0.tar.gz
==
real30m59.537s
user138m37.631s
sys 7m5.547s
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile Makefile.am
Makefile.in NOTICE README.md aclocal.m4 ar-lib autom4te.cache bin bootstrap
compile config.guess config.log config.lt config.status config.sub configure
configure.ac depcomp docs ec2 frameworks include install-sh libtool ltmain.sh
m4 mesos-0.20.0.tar.gz mesos.pc mesos.pc.in missing mpi src support
+ git clean -fdx
Removing .libs/
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
Removing 3rdparty/libprocess/3rdparty/Makefile
Removing 3rdparty/libprocess/3rdparty/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/aclocal.m4
Removing 3rdparty/libprocess/3rdparty/stout/autom4te.cache/
Removing 3rdparty/libprocess/3rdparty/stout/config.log
Removing 3rdparty/libprocess/3rdparty/stout/config.status
Removing 3rdparty/libprocess/3rdparty/stout/configure
Removing 3rdparty/libprocess/3rdparty/stout/include/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/include/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/missing
Removing 3rdparty/libprocess/Makefile
Removing 3rdparty/libprocess/Makefile.in
Removing 3rdparty/libprocess/aclocal.m4
Removing 3rdparty/libprocess/ar-lib
Removing 3rdparty/libprocess/autom4te.cache/
Removing 3rdparty/libprocess/compile
Removing 3rdparty/libprocess/config.guess
Removing 3rdparty/libprocess/config.log
Removing 3rdparty/libprocess/config.lt
Removing 3rdparty/libprocess/config.status
Removing 3rdparty/libprocess/config.sub
Removing 3rdparty/libprocess/configure
Removing 3rdparty/libprocess/depcomp
Removing 3rdparty/libprocess/include/Makefile
Removing 3rdparty/libprocess/include/Makefile.in
Removing 3rdparty/libprocess/libtool
Removing 3rdparty/libprocess/ltmain.sh
Removing 3rdparty/libprocess/m4/libtool.m4
Removing 3rdparty/libprocess/m4/ltoptions.m4
Removing 3rdparty/libprocess/m4/ltsugar.m4
Removing 3rdparty/libprocess/m4/ltversion.m4
Removing 3rdparty/libprocess/m4/lt~obsolete.m4
Removing 3rdparty/libprocess/missing
Removing Makefile
Removing Makefile.in
Removing aclocal.m4
Removing ar-lib
Removing autom4te.cache/
Removing bin/gdb-mesos-local.sh
Removing bin/gdb-mesos-master.sh
Removing bin/gdb-mesos-slave.sh
Removing bin/gdb-mesos-tests.sh
Removing bin/lldb-mesos-local.sh
Removing bin/lldb-mesos-master.sh
Removing bin/lldb-mesos-slave.sh
Removing bin/lldb-mesos-tests.sh
Removing bin/mesos-local-flags.sh
Removing bin/mesos-local.sh
Removing bin/mesos-master-flags.sh
Removing bin/mesos-master.sh
Removing bin/mesos-slave-flags.sh
Removing bin/mesos-slave.sh
Removing bin/mesos-tests-flags.sh
Removing bin/mesos-tests.sh
Removing bin/mesos.sh
Removing bin/valgrind-mesos-local.sh
Removing bin/valgrind-mesos-master.sh
Removing bin/valgrind-mesos-slave.sh
Removing bin/valgrind-mesos-tests.sh
Removing compile
Removing config.guess
Removing config.log
Removing config.lt
Removing config.status
Removing config.sub
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2333
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2333/changes Changes: [benjamin.hindman] Fixed bug in io::poll. -- [...truncated 3449 lines...] mv -f tests/.deps/mesos_tests-docker_containerizer_tests.Tpo tests/.deps/mesos_tests-docker_containerizer_tests.Po g++ -DPACKAGE_NAME=\mesos\ -DPACKAGE_TARNAME=\mesos\ -DPACKAGE_VERSION=\0.20.0\ -DPACKAGE_STRING=\mesos\ 0.20.0\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\mesos\ -DVERSION=\0.20.0\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBCURL=1 -DHAVE_LIBSASL2=1 -DMESOS_HAS_JAVA=1 -DHAVE_PYTHON=\2.7\ -DMESOS_HAS_PYTHON=1 -I. -I../../src -Wall -Werror -DLIBDIR=\/usr/local/lib\ -DPKGLIBEXECDIR=\/usr/local/libexec/mesos\ -DPKGDATADIR=\/usr/local/share/mesos\ -I../../include -I../../3rdparty/libprocess/include -I../../3rdparty/libprocess/3rdparty/stout/include -I../include -I../include/mesos -I../3rdparty/libprocess/3rdparty/boost-1.53.0 -I../3rdparty/libprocess/3rdparty/picojson-4f93734 -I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/leveldb/include -I../3rdparty/zookeeper-3.4.5/src/c/include -I../3rdparty/zookeeper-3.4.5/src/c/generated -DSOURCE_DIR=\https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/..\; -DBUILD_DIR=\https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build\; -I../3rdparty/libprocess/3rdparty/gmock-1.6.0/gtest/include -I../3rdparty/libprocess/3rdparty/gmock-1.6.0/include -I/home/jenkins/tools/java/jdk1.6.0_20-64/include -I/home/jenkins/tools/java/jdk1.6.0_20-64/include/linux -DZOOKEEPER_VERSION=\3.4.5\ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT tests/mesos_tests-environment.o -MD -MP -MF tests/.deps/mesos_tests-environment.Tpo -c -o tests/mesos_tests-environment.o `test -f 'tests/environment.cpp' || echo '../../src/'`tests/environment.cpp mv -f tests/.deps/mesos_tests-environment.Tpo tests/.deps/mesos_tests-environment.Po g++ -DPACKAGE_NAME=\mesos\ -DPACKAGE_TARNAME=\mesos\ -DPACKAGE_VERSION=\0.20.0\ -DPACKAGE_STRING=\mesos\ 0.20.0\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\mesos\ -DVERSION=\0.20.0\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBCURL=1 -DHAVE_LIBSASL2=1 -DMESOS_HAS_JAVA=1 -DHAVE_PYTHON=\2.7\ -DMESOS_HAS_PYTHON=1 -I. -I../../src -Wall -Werror -DLIBDIR=\/usr/local/lib\ -DPKGLIBEXECDIR=\/usr/local/libexec/mesos\ -DPKGDATADIR=\/usr/local/share/mesos\ -I../../include -I../../3rdparty/libprocess/include -I../../3rdparty/libprocess/3rdparty/stout/include -I../include -I../include/mesos -I../3rdparty/libprocess/3rdparty/boost-1.53.0 -I../3rdparty/libprocess/3rdparty/picojson-4f93734 -I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/leveldb/include -I../3rdparty/zookeeper-3.4.5/src/c/include -I../3rdparty/zookeeper-3.4.5/src/c/generated -DSOURCE_DIR=\https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/..\; -DBUILD_DIR=\https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build\; -I../3rdparty/libprocess/3rdparty/gmock-1.6.0/gtest/include -I../3rdparty/libprocess/3rdparty/gmock-1.6.0/include -I/home/jenkins/tools/java/jdk1.6.0_20-64/include -I/home/jenkins/tools/java/jdk1.6.0_20-64/include/linux -DZOOKEEPER_VERSION=\3.4.5\ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT tests/mesos_tests-examples_tests.o -MD -MP -MF tests/.deps/mesos_tests-examples_tests.Tpo -c -o tests/mesos_tests-examples_tests.o `test -f 'tests/examples_tests.cpp' || echo '../../src/'`tests/examples_tests.cpp mv -f tests/.deps/mesos_tests-examples_tests.Tpo tests/.deps/mesos_tests-examples_tests.Po g++ -DPACKAGE_NAME=\mesos\ -DPACKAGE_TARNAME=\mesos\ -DPACKAGE_VERSION=\0.20.0\ -DPACKAGE_STRING=\mesos\ 0.20.0\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\mesos\ -DVERSION=\0.20.0\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBCURL=1 -DHAVE_LIBSASL2=1 -DMESOS_HAS_JAVA=1 -DHAVE_PYTHON=\2.7\ -DMESOS_HAS_PYTHON=1 -I. -I../../src -Wall -Werror
Re: Review Request 24407: Use curl-config to locate lib curl when possible
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24407/#review50460 --- The option description needs to be added e.g. - AC_ARG_WITH([glog], AS_HELP_STRING([--with-glog@:@=DIR@:@], [excludes building and using the bundled glog package in lieu of an installed version at a location prefixed by the given path]), [without_bundled_glog=yes], []) Also, you can update the patch via Update-Update Diff - Timothy St. Clair On Aug. 11, 2014, 7:28 p.m., Chris Heller wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24407/ --- (Updated Aug. 11, 2014, 7:28 p.m.) Review request for mesos and Timothy St. Clair. Repository: mesos-git Description --- If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS. To work around this we can use curl-config to provide the needed path and link options to the compiler. This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible. Diffs - configure.ac a9cc6df Diff: https://reviews.apache.org/r/24407/diff/ Testing --- Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS. File Attachments Add --with-curl, --with-sasl2, --with-zlib to configure https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1___configure_with_libs.patch Thanks, Chris Heller
Re: Review Request 24177: Pass executor directory to Isolator::prepare().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24177/#review50352 --- src/tests/isolator_tests.cpp https://reviews.apache.org/r/24177/#comment88054 Remove 'dir' when test finishes? src/tests/isolator_tests.cpp https://reviews.apache.org/r/24177/#comment88055 Ditto. src/tests/isolator_tests.cpp https://reviews.apache.org/r/24177/#comment88056 Ditto. src/tests/isolator_tests.cpp https://reviews.apache.org/r/24177/#comment88057 Ditto. - Jie Yu On Aug. 1, 2014, 6:06 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24177/ --- (Updated Aug. 1, 2014, 6:06 a.m.) Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Description --- Pass executor directory to Isolator::prepare(). Will be used for FilesystemIsolator. Diffs - src/slave/containerizer/isolator.hpp e52e8b15c740c62ef64b49897d3d6ae5179d4719 src/slave/containerizer/isolator.cpp 5e61bf2e3cf14be53d41aa657b4a78ab2dd6ecb0 src/slave/containerizer/isolators/cgroups/cpushare.hpp 780037b093cb5b61254e61ddcfb9ecd4b0551a77 src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a8084dfab6f3c9244f8f227e4024d8afe68a src/slave/containerizer/isolators/cgroups/mem.hpp 8c476c7847baa923821bc89a1e04f50f019c6ecb src/slave/containerizer/isolators/cgroups/mem.cpp e8d1e35a1acdb3beb03a91cfd734a59417657b20 src/slave/containerizer/isolators/cgroups/perf_event.hpp 4ceb07a6e4f171788cfbabca78c14ae23ff183db src/slave/containerizer/isolators/cgroups/perf_event.cpp 6f65b722c5b22a71a7c334c2b63db1584cb9fe29 src/slave/containerizer/isolators/posix.hpp 17bbd10c565aa88048ec3a845014ceee582396d2 src/slave/containerizer/mesos/containerizer.cpp 2c394e2c8702166266f5d20ff005abb218da8a6c src/tests/isolator.hpp 89df4c4959c680354b002fa12e3a270a358087af src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 Diff: https://reviews.apache.org/r/24177/diff/ Testing --- make check Thanks, Ian Downes
Jenkins build is back to normal : mesos-reviewbot #1332
See https://builds.apache.org/job/mesos-reviewbot/1332/
Re: Python bindings are changing!
Thomas, We are about to cut the 0.20.0 release. I am updating the docs/upgrades.md. Regarding the python binding change, can you let us know the exact deploy procedure if someone is using the old python binding? More specifically, say all masters/slaves/executors/schedulers are using 0.19.1. What should we upgrade first? For example 1) If we upgrade the slaves first (libmesos.so will be updated), what happens if the new slave launches an old executor? (here, you actually have two cases: a) the executor bundles libmesos.so; b) the execute does not bundle libmesos.so) 2) Same question for framework, which one should we upgrade first (scheduler or master)? Also, would you please test all these scenarios so that we can provide correct guidance to the community. Thanks a lot! - Jie On Sun, Aug 3, 2014 at 11:18 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: It might work to use 0.19 with a 0.20 mesos (or visa versa), but there be dragons =) Is there a deprecation cycle? How should folks be upgrading Python schedulers and executors to 0.20.0 if they are not statically bundling libmesos? Is there an upgrade order required? We will need to document this carefully in the upgrade procedures for 0.20.0. Thanks for cleaning this up Thomas! Appreciate it. On Sat, Aug 2, 2014 at 12:12 PM, Thomas Rampelberg tho...@saunter.org wrote: You'll want to match the python bindings to your mesos version as the functionality is coming from libmesos itself. It might work to use 0.19 with a 0.20 mesos (or visa versa), but there be dragons =) On Fri, Aug 1, 2014 at 1:30 PM, Jie Yu yujie@gmail.com wrote: Thomas, Thank you for the heads-up. One question: what if mesos and python binding have different versions? For example, is it ok to use a 0.19.0 python binding and having a 0.20.0 mesos? Same question for the reverse. - Jie On Fri, Aug 1, 2014 at 9:37 AM, Thomas Rampelberg tho...@saunter.org wrote: - What problem are we trying to solve? Currently, the python bindings group protobufs, stub implementations and compiled code into a single python package that cannot be distributed easily. This forces python projects using mesos to copy protobufs around and forces a onerous dependency on anyone who would like to do a pure python binding. - How was this problem solved? The current python package has been split into two separate packages: - mesos.interface (stub implementations and protobufs) - mesos.native (old _mesos module) These are python meta-packages and can be installed as separate pieces. The `mesos.interface` package will be hosted on pypi and can be installed via. easy_install and pip. See https://issues.apache.org/jira/browse/MESOS-857 and https://reviews.apache.org/r/23224/. - Why should I care? These changes are not backwards compatible. With 0.20.0 you will need to change how you use the python bindings. Here's a quick overview: mesos.Scheduler - mesos.interface.Scheduler mesos.mesos_pb2 - mesos.interface.mesos_pb2 mesos.MesosSchedulerDriver - mesos.native.MesosSchedulerDriver For more details, you can take a look at the examples in `src/examples/python.
Review Request 24656: Add Docker::log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24656/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Add Docker::log. Diffs - src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 Diff: https://reviews.apache.org/r/24656/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 24464: Redirect docker logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 13, 2014, 5:33 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/24464 Diffs (updated) - src/slave/containerizer/docker.cpp 904cdd3 src/tests/docker_containerizer_tests.cpp a559836 Diff: https://reviews.apache.org/r/24464/diff/ Testing --- make check Thanks, Timothy Chen
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2331
filed https://issues.apache.org/jira/browse/MESOS-1698 On Tue, Aug 12, 2014 at 10:43 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2331/changes Changes: [benjamin.hindman] Add ContainerInfo and Volumes protobufs. -- [...truncated 1596 lines...] /bin/bash ./libtool --tag=CXX --mode=link g++ -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -DNDEBUG -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11-o libglog.la -rpath /usr/local/lib libglog_la-logging.lo libglog_la-raw_logging.lo libglog_la-vlog_is_on.lo libglog_la-utilities.lo libglog_la-demangle.lo libglog_la-symbolize.lo libglog_la-signalhandler.lo -lpthread libtool: link: ar cru .libs/libglog.a libglog_la-logging.o libglog_la-raw_logging.o libglog_la-vlog_is_on.o libglog_la-utilities.o libglog_la-demangle.o libglog_la-symbolize.o libglog_la-signalhandler.o libtool: link: ranlib .libs/libglog.a libtool: link: ( cd .libs rm -f libglog.la ln -s ../libglog.la libglog.la ) g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread-Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT logging_unittest-logging_unittest.o -MD -MP -MF .deps/logging_unittest-logging_unittest.Tpo -c -o logging_unittest-logging_unittest.o `test -f 'src/logging_unittest.cc' || echo './'`src/logging_unittest.cc mv -f .deps/logging_unittest-logging_unittest.Tpo .deps/logging_unittest-logging_unittest.Po /bin/bash ./libtool --tag=CXX --mode=link g++ -pthread-Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -pthread -o logging_unittest logging_unittest-logging_unittest.o libglog.la -lpthread libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -pthread -o logging_unittest logging_unittest-logging_unittest.o ./.libs/libglog.a -lpthread -pthread g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread-Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT demangle_unittest-demangle_unittest.o -MD -MP -MF .deps/demangle_unittest-demangle_unittest.Tpo -c -o demangle_unittest-demangle_unittest.o `test -f 'src/demangle_unittest.cc' || echo './'`src/demangle_unittest.cc mv -f .deps/demangle_unittest-demangle_unittest.Tpo .deps/demangle_unittest-demangle_unittest.Po /bin/bash ./libtool --tag=CXX --mode=link g++ -pthread-Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -pthread -o demangle_unittest demangle_unittest-demangle_unittest.o libglog.la -lpthread libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -pthread -o demangle_unittest demangle_unittest-demangle_unittest.o ./.libs/libglog.a -lpthread -pthread g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread-Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT stacktrace_unittest-stacktrace_unittest.o -MD -MP -MF .deps/stacktrace_unittest-stacktrace_unittest.Tpo -c -o stacktrace_unittest-stacktrace_unittest.o `test -f 'src/stacktrace_unittest.cc' || echo './'`src/stacktrace_unittest.cc mv -f .deps/stacktrace_unittest-stacktrace_unittest.Tpo .deps/stacktrace_unittest-stacktrace_unittest.Po /bin/bash ./libtool --tag=CXX --mode=link g++ -pthread-Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -pthread -o stacktrace_unittest stacktrace_unittest-stacktrace_unittest.o libglog.la -lpthread libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -pthread -o stacktrace_unittest stacktrace_unittest-stacktrace_unittest.o ./.libs/libglog.a -lpthread -pthread g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread-Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT symbolize_unittest-symbolize_unittest.o -MD -MP -MF .deps/symbolize_unittest-symbolize_unittest.Tpo -c -o symbolize_unittest-symbolize_unittest.o `test -f 'src/symbolize_unittest.cc' || echo './'`src/symbolize_unittest.cc mv -f .deps/symbolize_unittest-symbolize_unittest.Tpo .deps/symbolize_unittest-symbolize_unittest.Po /bin/bash ./libtool --tag=CXX --mode=link g++ -pthread-Wall -Wwrite-strings -Woverloaded-virtual
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2310
filed https://issues.apache.org/jira/browse/MESOS-1699 On Wed, Aug 13, 2014 at 1:34 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2310/changes Changes: [benjamin.hindman] Add ContainerInfo and Volumes protobufs. -- [...truncated 2577 lines...] mv -f examples/.deps/long_lived_executor-long_lived_executor.Tpo examples/.deps/long_lived_executor-long_lived_executor.Po /bin/bash ../libtool --tag=CXX --mode=link g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o long-lived-executor examples/long_lived_executor-long_lived_executor.o libmesos.la -lsasl2 -lcurl -lz -lrt libtool: link: g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o .libs/long-lived-executor examples/long_lived_executor-long_lived_executor.o ./.libs/libmesos.so -lsasl2 /usr/lib/x86_64-linux-gnu/libcurl-nss.so -lz -lrt -pthread g++ -DPACKAGE_NAME=\mesos\ -DPACKAGE_TARNAME=\mesos\ -DPACKAGE_VERSION=\0.20.0\ -DPACKAGE_STRING=\mesos\ 0.20.0\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\mesos\ -DVERSION=\0.20.0\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBCURL=1 -DHAVE_LIBSASL2=1 -I. -I../../src -Wall -Werror -DLIBDIR=\/usr/local/lib\ -DPKGLIBEXECDIR=\/usr/local/libexec/mesos\ -DPKGDATADIR=\/usr/local/share/mesos\ -I../../include -I../../3rdparty/libprocess/include -I../../3rdparty/libprocess/3rdparty/stout/include -I../include -I../include/mesos -I../3rdparty/libprocess/3rdparty/boost-1.53.0 -I../3rdparty/libprocess/3rdparty/picojson-4f93734 -I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/leveldb/include -I../3rdparty/zookeeper-3.4.5/src/c/include -I../3rdparty/zookeeper-3.4.5/src/c/generated -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT examples/no_executor_framework-no_executor_framework.o -MD -MP -MF examples/.deps/no_executor_framework-no_executor_framework.Tpo -c -o examples/no_executor_framework-no_executor_framework.o `test -f 'examples/no_executor_framework.cpp' || echo '../../src/'`examples/no_executor_framework.cpp mv -f examples/.deps/no_executor_framework-no_executor_framework.Tpo examples/.deps/no_executor_framework-no_executor_framework.Po /bin/bash ../libtool --tag=CXX --mode=link g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o no-executor-framework examples/no_executor_framework-no_executor_framework.o libmesos.la -lsasl2 -lcurl -lz -lrt libtool: link: g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o .libs/no-executor-framework examples/no_executor_framework-no_executor_framework.o ./.libs/libmesos.so -lsasl2 /usr/lib/x86_64-linux-gnu/libcurl-nss.so -lz -lrt -pthread g++ -DPACKAGE_NAME=\mesos\ -DPACKAGE_TARNAME=\mesos\ -DPACKAGE_VERSION=\0.20.0\ -DPACKAGE_STRING=\mesos\ 0.20.0\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\mesos\ -DVERSION=\0.20.0\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBCURL=1 -DHAVE_LIBSASL2=1 -I. -I../../src -Wall -Werror -DLIBDIR=\/usr/local/lib\ -DPKGLIBEXECDIR=\/usr/local/libexec/mesos\ -DPKGDATADIR=\/usr/local/share/mesos\ -I../../include -I../../3rdparty/libprocess/include -I../../3rdparty/libprocess/3rdparty/stout/include -I../include -I../include/mesos -I../3rdparty/libprocess/3rdparty/boost-1.53.0 -I../3rdparty/libprocess/3rdparty/picojson-4f93734 -I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/leveldb/include -I../3rdparty/zookeeper-3.4.5/src/c/include -I../3rdparty/zookeeper-3.4.5/src/c/generated -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT examples/docker_no_executor_framework-docker_no_executor_framework.o -MD -MP -MF examples/.deps/docker_no_executor_framework-docker_no_executor_framework.Tpo -c -o examples/docker_no_executor_framework-docker_no_executor_framework.o `test -f 'examples/docker_no_executor_framework.cpp' || echo '../../src/'`examples/docker_no_executor_framework.cpp mv -f examples/.deps/docker_no_executor_framework-docker_no_executor_framework.Tpo examples/.deps/docker_no_executor_framework-docker_no_executor_framework.Po /bin/bash ../libtool --tag=CXX --mode=link g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o
Re: Review Request 24657: Revert Refactored the protobuf message comparison logic.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24657/#review50474 --- Ship it! Ship It! - Vinod Kone On Aug. 13, 2014, 5:48 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24657/ --- (Updated Aug. 13, 2014, 5:48 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - src/common/type_utils.cpp af0e3a69ee6a725d4530fb80770d8d6245626b9d Diff: https://reviews.apache.org/r/24657/diff/ Testing --- Thanks, Jie Yu
Review Request 24657: Revert Refactored the protobuf message comparison logic.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24657/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - src/common/type_utils.cpp af0e3a69ee6a725d4530fb80770d8d6245626b9d Diff: https://reviews.apache.org/r/24657/diff/ Testing --- Thanks, Jie Yu
Review Request 24658: Updated equality check for CommandInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24658/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee Diff: https://reviews.apache.org/r/24658/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24619: Made value in CommandInfo optional and added argv.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24619/#review50476 --- A few notes since we're going to cut 0.20.0 and this is an API change! include/mesos/mesos.proto https://reviews.apache.org/r/24619/#comment88282 It's not clear why we need the boolean 'shell', since the non-emptiness of 'argv' should indicate a preference to use that over 'value'. If there's some reason we need the boolean (e.g. Docker implementation leaking in here) we should add a small note. Is it possible to have an empty 'argv'? Curious, is a boolean enough or do you want a Type enum here? Is it true that we'll be using 'execve'? Seems like we just might want to outline the two styles of running commands taking inspiration from Subprocess: https://docs.python.org/2/library/subprocess.html#subprocess.Popen include/mesos/mesos.proto https://reviews.apache.org/r/24619/#comment88290 s/argv/arguments/ 'argv' seems to be a historical name coming from the c 'argc' (count) 'argv' (vector) argument passing technique. Seems like we should avoid it by just calling this arguments since we avoid abbreviations as well. Maybe a small example to indicate that the program name is expected to be included here. - Ben Mahler On Aug. 12, 2014, 11:21 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24619/ --- (Updated Aug. 12, 2014, 11:21 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- See summary. Diffs - include/mesos/mesos.proto cc9f20e Diff: https://reviews.apache.org/r/24619/diff/ Testing --- Thanks, Jie Yu
Re: Review Request 24658: Updated equality check for CommandInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24658/#review50478 --- src/common/type_utils.cpp https://reviews.apache.org/r/24658/#comment88289 Hmm. I think the order is important for argv right? e.g., ./foo argv1 argv2 is not the same as ./foo argv2 argv1. - Vinod Kone On Aug. 13, 2014, 5:49 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24658/ --- (Updated Aug. 13, 2014, 5:49 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee Diff: https://reviews.apache.org/r/24658/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24658: Updated equality check for CommandInfo.
On Aug. 13, 2014, 6:10 p.m., Vinod Kone wrote: src/common/type_utils.cpp, lines 76-86 https://reviews.apache.org/r/24658/diff/1/?file=659441#file659441line76 Hmm. I think the order is important for argv right? e.g., ./foo argv1 argv2 is not the same as ./foo argv2 argv1. Good catch! - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24658/#review50478 --- On Aug. 13, 2014, 5:49 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24658/ --- (Updated Aug. 13, 2014, 5:49 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee Diff: https://reviews.apache.org/r/24658/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24658: Updated equality check for CommandInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24658/ --- (Updated Aug. 13, 2014, 6:39 p.m.) Review request for mesos and Vinod Kone. Changes --- Vinod's comment. Repository: mesos-git Description --- See summary. Diffs (updated) - src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee Diff: https://reviews.apache.org/r/24658/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24658: Updated equality check for CommandInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24658/ --- (Updated Aug. 13, 2014, 6:40 p.m.) Review request for mesos and Vinod Kone. Changes --- Updated 'depends' Repository: mesos-git Description --- See summary. Diffs - src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee Diff: https://reviews.apache.org/r/24658/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24658: Updated equality check for CommandInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24658/#review50484 --- Ship it! Ship It! - Vinod Kone On Aug. 13, 2014, 6:40 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24658/ --- (Updated Aug. 13, 2014, 6:40 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee Diff: https://reviews.apache.org/r/24658/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24576: Some Master cleanups.
On Aug. 13, 2014, 2:42 a.m., Niklas Nielsen wrote: src/master/master.cpp, lines 2252-2253 https://reviews.apache.org/r/24576/diff/1/?file=658113#file658113line2252 It this comment still relevant? Good catch, I think vinod meant stack instead of heap, since they have always been on the heap. I will update it! - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/#review50396 --- On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/ --- (Updated Aug. 11, 2014, 11:32 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Repository: mesos-git Description --- There were a few cleanups here that I did on the way to MESOS-1620. (1) Remove the need for Offer/Task Visitor memory cleanup by using Owned. (2) Restructured the launch task code to be easier to read and understand. Diffs - src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 Diff: https://reviews.apache.org/r/24576/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 24576: Some Master cleanups.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/ --- (Updated Aug. 13, 2014, 6:51 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Changes --- Rebased and updated per Vinod and Niklas' reviews. Repository: mesos-git Description --- There were a few cleanups here that I did on the way to MESOS-1620. (1) Remove the need for Offer/Task Visitor memory cleanup by using Owned. (2) Restructured the launch task code to be easier to read and understand. Diffs (updated) - src/master/master.cpp a8cf9ba07b041a770416ee70a0cff9ef51e0a844 Diff: https://reviews.apache.org/r/24576/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 24515: Model pending tasks in the Master's metrics and JSON.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24515/ --- (Updated Aug. 13, 2014, 6:51 p.m.) Review request for mesos and Vinod Kone. Changes --- Rebased and updated per Vinod's review. Bugs: MESOS-1620 https://issues.apache.org/jira/browse/MESOS-1620 Repository: mesos-git Description --- We were not surfacing tasks that are pending validation / authorization. These are now surfaced as staging tasks through metrics and through the http state endpoint. Diffs (updated) - src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/common/http.hpp 8216401e116406da7557f144ea13756013ec1c09 src/common/http.cpp d27fe21cd381ed2b6a52b1246bf6c7db33c0873e src/master/http.cpp 9317a95133e9bba54d037057a147ae6d91125441 src/master/master.cpp a8cf9ba07b041a770416ee70a0cff9ef51e0a844 src/tests/common/http_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/24515/diff/ Testing --- Added a test for the JSON modeling, there were no tests previously. Thanks, Ben Mahler
Re: Review Request 24516: Expose pending tasks during reconciliation.
On Aug. 12, 2014, 9:54 p.m., Vinod Kone wrote: src/master/master.cpp, line 3343 https://reviews.apache.org/r/24516/diff/1/?file=658120#file658120line3343 i don't think we should because that's a cache and people might un-necessarily depend on it. Agreed, removed this TODO. - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24516/#review50371 --- On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24516/ --- (Updated Aug. 11, 2014, 11:32 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-1620 https://issues.apache.org/jira/browse/MESOS-1620 Repository: mesos-git Description --- We were not surfacing tasks that are pending validation / authorization. These are now surfaced as staging tasks Diffs - src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 src/tests/master_authorization_tests.cpp 5c3557752df86e798ba5d804de588db55ddcfbf6 src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596 Diff: https://reviews.apache.org/r/24516/diff/ Testing --- Updated the existing test. I also removed the MasterAuthorizationTest.ReconcileTask test because it was redundant with ReconciliationTest.PendingTask. Thanks, Ben Mahler
Re: Review Request 24576: Some Master cleanups.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/ --- (Updated Aug. 13, 2014, 6:52 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Changes --- Added missing dependency. Repository: mesos-git Description --- There were a few cleanups here that I did on the way to MESOS-1620. (1) Remove the need for Offer/Task Visitor memory cleanup by using Owned. (2) Restructured the launch task code to be easier to read and understand. Diffs - src/master/master.cpp a8cf9ba07b041a770416ee70a0cff9ef51e0a844 Diff: https://reviews.apache.org/r/24576/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 24516: Expose pending tasks during reconciliation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24516/ --- (Updated Aug. 13, 2014, 6:53 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Changes --- Updated per vinod's review. Bugs: MESOS-1620 https://issues.apache.org/jira/browse/MESOS-1620 Repository: mesos-git Description --- We were not surfacing tasks that are pending validation / authorization. These are now surfaced as staging tasks Diffs (updated) - src/master/master.cpp a8cf9ba07b041a770416ee70a0cff9ef51e0a844 src/tests/master_authorization_tests.cpp f0f064808d8bf36a2a756bc907c477dd6440636c src/tests/reconciliation_tests.cpp 3c4d7ed886333f0ccc1460178b9e06e7e38246c9 Diff: https://reviews.apache.org/r/24516/diff/ Testing --- Updated the existing test. I also removed the MasterAuthorizationTest.ReconcileTask test because it was redundant with ReconciliationTest.PendingTask. Thanks, Ben Mahler
Re: Review Request 24464: Redirect docker logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50491 --- Patch looks great! Reviews applied: [24656, 24464] All tests passed. - Mesos ReviewBot On Aug. 13, 2014, 5:33 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 13, 2014, 5:33 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/24464 Diffs - src/slave/containerizer/docker.cpp 904cdd3 src/tests/docker_containerizer_tests.cpp a559836 Diff: https://reviews.apache.org/r/24464/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
On Aug. 11, 2014, 9:16 p.m., Vinod Kone wrote: src/examples/python/test-executor.in, lines 24-30 https://reviews.apache.org/r/23086/diff/4/?file=657922#file657922line24 Here and in other example python scripts below, do you want to pass PROTOBUF_EGG from configure.ac, similar to what you did with PROTOBUF_JAR? I think that would be more cleaner? So I've added a detection for the google.protobuf python module, but it doesn't install via prefix, it's a separate step. I've verified by checking the rpm deb packages. So we'll have to verify via PYTHONPATH. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50231 --- On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 11, 2014, 7:11 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 39af036 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/python/native/ext_modules.py.in 477e63d Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 13, 2014, 7:28 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes --- update from review to SUBST protoc and do a python check on google.protobuf. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp d98d953 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp ce8dd9b 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 87c5fc8 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e6 3rdparty/libprocess/configure.ac 7b39e63 3rdparty/libprocess/include/process/defer.hpp ebe6f2d 3rdparty/libprocess/include/process/future.hpp 46ae16b 3rdparty/libprocess/src/process.cpp c2bee98 configure.ac 8fb0a3a include/mesos/mesos.proto dc781d1 mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 0ac95b4 src/common/http.hpp afce7fe src/common/http.cpp 58050e9 src/common/type_utils.cpp 78bfa94 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/health-check/main.cpp 6849947 src/launcher/executor.cpp 64a4175 src/master/http.cpp 6dd11fe src/master/master.cpp e948803 src/python/native/ext_modules.py.in 477e63d src/slave/containerizer/mesos/launch.cpp 4e727a1 src/slave/http.cpp 92eb348 src/slave/slave.cpp 59477d5 src/tests/common/http_tests.cpp 5fa51bf src/tests/health_check_tests.cpp 64fbf62 src/tests/master_authorization_tests.cpp b9aa7bf src/tests/process_spawn.cpp PRE-CREATION src/tests/reconciliation_tests.cpp 8c66659 Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/ --- (Updated Aug. 13, 2014, 7:30 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu. Changes --- Adding Jie as this is a quick review I would like to get in for 0.20 Bugs: MESOS-1693 https://issues.apache.org/jira/browse/MESOS-1693 Repository: mesos-git Description --- Enable building against non-x86 arch, namely arm builders on Fedora. Diffs - 3rdparty/libprocess/include/process/internal.hpp 9f478ec 3rdparty/libprocess/src/process.cpp 14cf317 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24563/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50492 --- can you rebase? - Vinod Kone On Aug. 13, 2014, 7:28 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 13, 2014, 7:28 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp d98d953 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp ce8dd9b 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 87c5fc8 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e6 3rdparty/libprocess/configure.ac 7b39e63 3rdparty/libprocess/include/process/defer.hpp ebe6f2d 3rdparty/libprocess/include/process/future.hpp 46ae16b 3rdparty/libprocess/src/process.cpp c2bee98 configure.ac 8fb0a3a include/mesos/mesos.proto dc781d1 mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 0ac95b4 src/common/http.hpp afce7fe src/common/http.cpp 58050e9 src/common/type_utils.cpp 78bfa94 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/health-check/main.cpp 6849947 src/launcher/executor.cpp 64a4175 src/master/http.cpp 6dd11fe src/master/master.cpp e948803 src/python/native/ext_modules.py.in 477e63d src/slave/containerizer/mesos/launch.cpp 4e727a1 src/slave/http.cpp 92eb348 src/slave/slave.cpp 59477d5 src/tests/common/http_tests.cpp 5fa51bf src/tests/health_check_tests.cpp 64fbf62 src/tests/master_authorization_tests.cpp b9aa7bf src/tests/process_spawn.cpp PRE-CREATION src/tests/reconciliation_tests.cpp 8c66659 Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24555: MESOS-1169: unbundle distribute
On Aug. 11, 2014, 6:50 p.m., Vinod Kone wrote: Have you tested this with a prefix installed 'distribute'? Timothy St. Clair wrote: Has to be PYTHONPATH, on this one. So after talking with others PYTHONPATH is the best override mechanics for python dependencies so simply performing the checks and removing --with-pyDEP makes the most sense here. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/#review50210 --- On Aug. 11, 2014, 3:43 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/ --- (Updated Aug. 11, 2014, 3:43 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1169 https://issues.apache.org/jira/browse/MESOS-1169 Repository: mesos-git Description --- Enabling unbundling for distribute python utils. Diffs - 3rdparty/Makefile.am 70b45fe configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd Diff: https://reviews.apache.org/r/24555/diff/ Testing --- ./configure make check ./configure --disable-bundled make check For prefixed installs require updated PYTHON_PATH. Thanks, Timothy St. Clair
Re: Review Request 24555: MESOS-1169: unbundle distribute
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/ --- (Updated Aug. 13, 2014, 7:38 p.m.) Review request for mesos, Adam B, Jie Yu, and Vinod Kone. Changes --- updated to remove --with-PY package, in talking with other developers the standard override is PYTHONPATH checks. Bugs: MESOS-1169 https://issues.apache.org/jira/browse/MESOS-1169 Repository: mesos-git Description --- Enabling unbundling for distribute python utils. Diffs (updated) - 3rdparty/Makefile.am 70b45fe configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd Diff: https://reviews.apache.org/r/24555/diff/ Testing --- ./configure make check ./configure --disable-bundled make check For prefixed installs require updated PYTHON_PATH. Thanks, Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 13, 2014, 7:46 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes --- rebased to origin/master Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 0ac95b4 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/python/native/ext_modules.py.in 477e63d Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: 4.8.0 Cxx11 compilation issue
works with 4.8.2. Thanks!
Chinmaya
Benjamin Mahler mailto:benjamin.mah...@gmail.com
August 12, 2014 5:04 PM
Can you try it with 4.8.2?
I ask because most of the developers and many of the CI jobs compile
with 4.8.1 or 4.8.2, so it would be nice to rule out an issue with 4.8.0.
Chinmaya Manjunath mailto:chinm...@hedviginc.com
August 12, 2014 4:35 PM
I just tried it with 4.8.0 and got this. Would think that it could
happen with 4.8.1 as well.
This error disappears if I configure without cxx11 support, but I see
that it is a deprecated setting.
Benjamin Mahler mailto:benjamin.mah...@gmail.com
August 12, 2014 4:05 PM
Just curious, do you see this with gcc 4.8.1 / 4.8.2 or only with 4.8.0?
On Tue, Aug 12, 2014 at 3:07 PM, Chinmaya Manjunath
chinm...@hedviginc.com
Chinmaya Manjunath mailto:chinm...@hedviginc.com
August 12, 2014 3:07 PM
Hello Guys:
I am trying to build mesos on Centos6.5 and 4.8.0 g++ and am hitting
the following issue, help is appreciated.
Thanks!
ake[6]: Entering directory
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty/stout'
make[6]: Nothing to be done for `all'.
make[6]: Leaving directory
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty/stout'
make[6]: Entering directory
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
make[6]: Nothing to be done for `all-am'.
make[6]: Leaving directory
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
make[5]: Leaving directory
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
make[4]: Leaving directory
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
Making all in .
make[4]: Entering directory
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess'
/bin/sh ./libtool --tag=CXX --mode=compile g++
-DPACKAGE_NAME=\libprocess\ -DPACKAGE_TARNAME=\libprocess\
-DPACKAGE_VERSION=\0.0.1\ -DPACKAGE_STRING=\libprocess\ 0.0.1\
-DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\libprocess\
-DVERSION=\0.0.1\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1
-DLT_OBJDIR=\.libs/\ -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I.
-I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/include
-I../../../3rdparty/libprocess/3rdparty/stout/include
-I3rdparty/boost-1.53.0 -I3rdparty/glog-0.3.3/src
-I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734
-I3rdparty/ry-http-parser-1c3624a -Iparser/include -g -g2 -O2
-Wno-unused-local-typedefs -std=c++11 -MT libprocess_la-metrics.lo -MD
-MP -MF .deps/libprocess_la-metrics.Tpo -c -o libprocess_la-metrics.lo
`test -f 'src/metrics/metrics.cpp' || echo
'../../../3rdparty/libprocess/'`src/metrics/metrics.cpp
libtool: compile: g++ -DPACKAGE_NAME=\libprocess\
-DPACKAGE_TARNAME=\libprocess\ -DPACKAGE_VERSION=\0.0.1\
-DPACKAGE_STRING=\libprocess 0.0.1\ -DPACKAGE_BUGREPORT=\\
-DPACKAGE_URL=\\ -DPACKAGE=\libprocess\ -DVERSION=\0.0.1\
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\
-DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. -I../../../3rdparty/libprocess
-I../../../3rdparty/libprocess/include
-I../../../3rdparty/libprocess/3rdparty/stout/include
-I3rdparty/boost-1.53.0 -I3rdparty/glog-0.3.3/src
-I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734
-I3rdparty/ry-http-parser-1c3624a -Iparser/include -g -g2 -O2
-Wno-unused-local-typedefs -std=c++11 -MT libprocess_la-metrics.lo -MD
-MP -MF .deps/libprocess_la-metrics.Tpo -c
../../../3rdparty/libprocess/src/metrics/metrics.cpp -fPIC -DPIC -o
libprocess_la-metrics.o
In file included from
../../../3rdparty/libprocess/include/process/check.hpp:22:0,
from
../../../3rdparty/libprocess/include/process/collect.hpp:6,
from
../../../3rdparty/libprocess/src/metrics/metrics.cpp:6:
../../../3rdparty/libprocess/include/process/future.hpp: In
instantiation of 'class process::Futurevoid':
/usr/local/include/c++/4.8.0/functional:2177:71: required by
substitution of 'templateclass _Res, class ... _ArgTypes
templateclass _Functor using _Invoke = decltype
(std::__callable_functor(declval_Functor())((declval_ArgTypes)()...))
[with _Functor = const std::functionprocess::Futurevoid(const
process::Futuredouble); _Res = process::Futurevoid; _ArgTypes =
{const process::Futuredouble}]'
/usr/local/include/c++/4.8.0/functional:2331:2: required by
substitution of 'templateclass _Functor std::function_Res(_ArgTypes
...)::_Requiresstd::function_Res(_ArgTypes
...)::_CheckResultstd::function_Res(_ArgTypes
...)::_Invoke_Functor, _Res, std::function_Res(_ArgTypes ...)
std::function_Res(_ArgTypes ...)::operator=(_Functor) [with
_Functor = _Functor; _Res = process::Futurevoid; _ArgTypes =
Re: Review Request 24475: Add new Docker configurations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50485 --- Ship it! include/mesos/mesos.proto https://reviews.apache.org/r/24475/#comment88305 s/an mesos/a Mesos/ src/docker/docker.cpp https://reviews.apache.org/r/24475/#comment88306 s/a/an/ s/need/needs/ src/docker/docker.cpp https://reviews.apache.org/r/24475/#comment88307 s/this but/but this/ src/docker/docker.cpp https://reviews.apache.org/r/24475/#comment88309 s/to// src/slave/containerizer/docker.cpp https://reviews.apache.org/r/24475/#comment88344 Sorry if I missed it, but how does logging redirection get resumed when the slave restarts? src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/24475/#comment88345 Why the change in sleep time? Why not sleep 1000 which is used elsewhere for a long enough sleep. src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/24475/#comment88346 Ditto. src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/24475/#comment88347 Ditto. src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/24475/#comment88348 Ditto. I don't follow why there are different sleep times in these tests? - Ian Downes On Aug. 12, 2014, 10:47 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 12, 2014, 10:47 p.m.) Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Repository: mesos-git Description --- Added new DockerInfo for future docker options, and allow command uris to be fetched and mapped into docker before launching docker container. Diffs - include/mesos/mesos.proto cc9f20e src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 src/slave/containerizer/containerizer.hpp 02754cd src/slave/containerizer/containerizer.cpp c91ba38 src/slave/containerizer/docker.cpp 904cdd3 src/slave/containerizer/mesos/containerizer.cpp 694c9d1 src/slave/flags.hpp 841de23 src/slave/slave.cpp 787bd05 src/tests/docker_containerizer_tests.cpp a559836 src/tests/docker_tests.cpp 4ef1df4 Diff: https://reviews.apache.org/r/24475/diff/ Testing --- make check Thanks, Timothy Chen
Review Request 24667: Added a user doc for framework rate limiting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24667/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1683 https://issues.apache.org/jira/browse/MESOS-1683 Repository: mesos-git Description --- See summary. Diffs - docs/framework-rate-limiting.md PRE-CREATION Diff: https://reviews.apache.org/r/24667/diff/ Testing --- Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9 Thanks, Jiang Yan Xu
Re: Review Request 24475: Add new Docker configurations
On Aug. 13, 2014, 8:36 p.m., Ian Downes wrote: src/tests/docker_containerizer_tests.cpp, line 337 https://reviews.apache.org/r/24475/diff/5/?file=659137#file659137line337 Why the change in sleep time? Why not sleep 1000 which is used elsewhere for a long enough sleep. The sleep time differs as we originally use a large image to test launching executor. I agree we can just a consistent time now On Aug. 13, 2014, 8:36 p.m., Ian Downes wrote: src/slave/containerizer/docker.cpp, line 852 https://reviews.apache.org/r/24475/diff/5/?file=659133#file659133line852 Sorry if I missed it, but how does logging redirection get resumed when the slave restarts? It's not handled yet, and Ben and I are working on that - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50485 --- On Aug. 13, 2014, 5:47 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 13, 2014, 5:47 a.m.) Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Repository: mesos-git Description --- Added new DockerInfo for future docker options, and allow command uris to be fetched and mapped into docker before launching docker container. Diffs - include/mesos/mesos.proto cc9f20e src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 src/slave/containerizer/containerizer.hpp 02754cd src/slave/containerizer/containerizer.cpp c91ba38 src/slave/containerizer/docker.cpp 904cdd3 src/slave/containerizer/mesos/containerizer.cpp 694c9d1 src/slave/flags.hpp 841de23 src/slave/slave.cpp 787bd05 src/tests/docker_containerizer_tests.cpp a559836 src/tests/docker_tests.cpp 4ef1df4 Diff: https://reviews.apache.org/r/24475/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 24475: Add new Docker configurations
On Aug. 13, 2014, 8:36 p.m., Ian Downes wrote: src/tests/docker_containerizer_tests.cpp, line 337 https://reviews.apache.org/r/24475/diff/5/?file=659137#file659137line337 Why the change in sleep time? Why not sleep 1000 which is used elsewhere for a long enough sleep. The sleep time differs as we originally use a large image to test launching executor. I agree we can just a consistent time now On Aug. 13, 2014, 8:36 p.m., Ian Downes wrote: src/slave/containerizer/docker.cpp, line 852 https://reviews.apache.org/r/24475/diff/5/?file=659133#file659133line852 Sorry if I missed it, but how does logging redirection get resumed when the slave restarts? It's not handled yet, and Ben and I are working on that - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50485 --- On Aug. 13, 2014, 5:47 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 13, 2014, 5:47 a.m.) Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Repository: mesos-git Description --- Added new DockerInfo for future docker options, and allow command uris to be fetched and mapped into docker before launching docker container. Diffs - include/mesos/mesos.proto cc9f20e src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 src/slave/containerizer/containerizer.hpp 02754cd src/slave/containerizer/containerizer.cpp c91ba38 src/slave/containerizer/docker.cpp 904cdd3 src/slave/containerizer/mesos/containerizer.cpp 694c9d1 src/slave/flags.hpp 841de23 src/slave/slave.cpp 787bd05 src/tests/docker_containerizer_tests.cpp a559836 src/tests/docker_tests.cpp 4ef1df4 Diff: https://reviews.apache.org/r/24475/diff/ Testing --- make check Thanks, Timothy Chen
Build failed in Jenkins: mesos-reviewbot #1334
See https://builds.apache.org/job/mesos-reviewbot/1334/changes Changes: [yujie.jay] Revert Refactored the protobuf message comparison logic. [yujie.jay] Updated equality check for CommandInfo. [bmahler] Removed unused test file 'process_spawn.cpp'. [bmahler] Added a missing test target in Makefile.am. [bmahler] Some Master cleanups. [bmahler] Model pending tasks in the Master's metrics and JSON. [bmahler] Expose pending tasks during reconciliation. -- [...truncated 3752 lines...] running bdist_egg running egg_info writing requirements to src/mesos.interface.egg-info/requires.txt writing src/mesos.interface.egg-info/PKG-INFO writing namespace_packages to src/mesos.interface.egg-info/namespace_packages.txt writing top-level names to src/mesos.interface.egg-info/top_level.txt writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt reading manifest file 'src/mesos.interface.egg-info/SOURCES.txt' writing manifest file 'src/mesos.interface.egg-info/SOURCES.txt' installing library code to build/bdist.linux-x86_64/egg reading manifest file 'src/mesos.native.egg-info/SOURCES.txt' running install_lib running build_py creating build/bdist.linux-x86_64/egg creating build/bdist.linux-x86_64/egg/mesos copying build/lib.linux-x86_64-2.7/mesos/__init__.py - build/bdist.linux-x86_64/egg/mesos byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc writing manifest file 'src/mesos.native.egg-info/SOURCES.txt' installing library code to build/bdist.linux-x86_64/egg running install_lib running build_py running build_ext creating build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.egg-info/PKG-INFO - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.egg-info/SOURCES.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.egg-info/dependency_links.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.egg-info/namespace_packages.txt - build/bdist.linux-x86_64/egg/EGG-INFO creating build/bdist.linux-x86_64/egg copying src/mesos.egg-info/requires.txt - build/bdist.linux-x86_64/egg/EGG-INFO creating build/bdist.linux-x86_64/egg/mesos creating build/bdist.linux-x86_64/egg/mesos/native copying src/mesos.egg-info/top_level.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying build/lib.linux-x86_64-2.7/mesos/native/_mesos.so - build/bdist.linux-x86_64/egg/mesos/native zip_safe flag not set; analyzing archive contents... mesos.__init__: module references __path__ creating 'dist/mesos-0.20.0-py2.7.egg' and adding 'build/bdist.linux-x86_64/egg' to it running install_lib running build_py removing 'build/bdist.linux-x86_64/egg' (and everything under it) creating build/bdist.linux-x86_64/egg creating build/bdist.linux-x86_64/egg/mesos creating build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/containerizer_pb2.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/__init__.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/mesos_pb2.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/__init__.py - build/bdist.linux-x86_64/egg/mesos byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/containerizer_pb2.py to containerizer_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/__init__.py to __init__.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/mesos_pb2.py to mesos_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc creating build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/PKG-INFO - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/SOURCES.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/dependency_links.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/namespace_packages.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/requires.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/top_level.txt - build/bdist.linux-x86_64/egg/EGG-INFO zip_safe flag not set; analyzing archive contents... mesos.__init__: module references __path__ creating 'dist/mesos.interface-0.20.0-py2.7.egg' and adding 'build/bdist.linux-x86_64/egg' to it removing 'build/bdist.linux-x86_64/egg' (and everything under it) copying build/lib.linux-x86_64-2.7/mesos/native/__init__.py - build/bdist.linux-x86_64/egg/mesos/native copying build/lib.linux-x86_64-2.7/mesos/__init__.py - build/bdist.linux-x86_64/egg/mesos byte-compiling build/bdist.linux-x86_64/egg/mesos/native/__init__.py to __init__.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc creating stub loader for mesos/native/_mesos.so byte-compiling build/bdist.linux-x86_64/egg/mesos/native/_mesos.py to _mesos.pyc creating
Re: Review Request 24628: MESOS-1171: unbundle gmock
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/#review50494 --- 3rdparty/libprocess/3rdparty/Makefile.am https://reviews.apache.org/r/24628/#comment88356 How is that we didn't need to include these src dirs before but have to know? 3rdparty/libprocess/3rdparty/Makefile.am https://reviews.apache.org/r/24628/#comment88355 Pull this below #99? Also, should this be inside if WITH_BUNDLED_GMOCK ? 3rdparty/libprocess/3rdparty/gmock_sources.cc.in https://reviews.apache.org/r/24628/#comment88352 s/is/in/ ? s/automake/Automake/ 3rdparty/libprocess/3rdparty/gmock_sources.cc.in https://reviews.apache.org/r/24628/#comment88353 s/mundged/munged/ 3rdparty/libprocess/configure.ac https://reviews.apache.org/r/24628/#comment88320 s/#On/# On/ Also, can you expand on the comment? It's not clear to me why you including stdio.h here. Is it just a dummy? Also, where is gtest typically located on system installations? - Vinod Kone On Aug. 13, 2014, 2:35 a.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/ --- (Updated Aug. 13, 2014, 2:35 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1171 https://issues.apache.org/jira/browse/MESOS-1171 Repository: mesos-git Description --- Enable support to build against unbundled versions of gmock. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24628/diff/ Testing --- configure make check configure --disable-bundled make check configure --with-gmock=/opt/gmock make check Thanks, Timothy St. Clair
Review Request 24672: Renamed argv in CommandInfo to arguments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24672/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - include/mesos/mesos.proto dc781d15d3985bf15954a877c7bbd6dbfe2d9094 src/common/type_utils.cpp 78bfa942f3039d4eda5627d1340231d7110daed9 src/health-check/main.cpp 68499475520cac3e11b30621ac5684c6e1f8e2cb src/launcher/executor.cpp 64a41752ee77aa508862194d763dc578aca0c321 src/slave/containerizer/mesos/launch.cpp 4e727a1c90b94dbe46fcc23ea37c366472e233ab src/slave/http.cpp 92eb348707aa256799ebc46142e085107666f894 src/slave/slave.cpp 59477d57d9f99d61762652fe51ebf2aa770f8d66 src/tests/health_check_tests.cpp 64fbf629bfdc3ea6c4de7e902bebdea28fdb19b2 Diff: https://reviews.apache.org/r/24672/diff/ Testing --- make check Thanks, Jie Yu
Review Request 24669: Fixed a resource leak in ThreadLocal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24669/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description --- Two issues in ThreadLocal: (1) No release of the pthread keys upon destruction. (2) Errors not being printed correctly, errno is not used by the pthread_ family functions. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp a20df8647844bf855ccc32b69f66d451219c8ad2 Diff: https://reviews.apache.org/r/24669/diff/ Testing --- Ran the ThreadLocal tests with a lot of iterations. Thanks, Ben Mahler
Re: Review Request 24669: Fixed a resource leak in ThreadLocal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24669/ --- (Updated Aug. 13, 2014, 9:47 p.m.) Review request for mesos and Jie Yu. Changes --- Added ticket. Bugs: MESOS-1700 https://issues.apache.org/jira/browse/MESOS-1700 Repository: mesos-git Description --- Two issues in ThreadLocal: (1) No release of the pthread keys upon destruction. (2) Errors not being printed correctly, errno is not used by the pthread_ family functions. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp a20df8647844bf855ccc32b69f66d451219c8ad2 Diff: https://reviews.apache.org/r/24669/diff/ Testing --- Ran the ThreadLocal tests with a lot of iterations. Thanks, Ben Mahler
Re: Review Request 24628: MESOS-1171: unbundle gmock
On Aug. 13, 2014, 9:40 p.m., Vinod Kone wrote: 3rdparty/libprocess/3rdparty/Makefile.am, lines 87-88 https://reviews.apache.org/r/24628/diff/1/?file=659070#file659070line87 How is that we didn't need to include these src dirs before but have to know? The include changes b/c I had to add a source file redirector 'gmock_sources.cc' due to limitations on SUBST and _SOURCES in automake. On Aug. 13, 2014, 9:40 p.m., Vinod Kone wrote: 3rdparty/libprocess/3rdparty/Makefile.am, line 97 https://reviews.apache.org/r/24628/diff/1/?file=659070#file659070line97 Pull this below #99? Also, should this be inside if WITH_BUNDLED_GMOCK ? The file still builds in both cases, so it should not be wrapped in WITH_BUNDLED_GMOCK. On Aug. 13, 2014, 9:40 p.m., Vinod Kone wrote: 3rdparty/libprocess/configure.ac, line 175 https://reviews.apache.org/r/24628/diff/1/?file=659072#file659072line175 s/#On/# On/ Also, can you expand on the comment? It's not clear to me why you including stdio.h here. Is it just a dummy? Also, where is gtest typically located on system installations? It's a placeholder header for the substitution. gtest on a non-prefixed installation will be in the standard search paths. On epel Fedora its /usr/lib64 - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/#review50494 --- On Aug. 13, 2014, 2:35 a.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/ --- (Updated Aug. 13, 2014, 2:35 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1171 https://issues.apache.org/jira/browse/MESOS-1171 Repository: mesos-git Description --- Enable support to build against unbundled versions of gmock. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24628/diff/ Testing --- configure make check configure --disable-bundled make check configure --with-gmock=/opt/gmock make check Thanks, Timothy St. Clair
Review Request 24673: Used new CommandInfo with Docker::run.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24673/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 Diff: https://reviews.apache.org/r/24673/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24669: Fixed a resource leak in ThreadLocal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24669/#review50514 --- Ship it! Ship It! - Jie Yu On Aug. 13, 2014, 9:47 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24669/ --- (Updated Aug. 13, 2014, 9:47 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-1700 https://issues.apache.org/jira/browse/MESOS-1700 Repository: mesos-git Description --- Two issues in ThreadLocal: (1) No release of the pthread keys upon destruction. (2) Errors not being printed correctly, errno is not used by the pthread_ family functions. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp a20df8647844bf855ccc32b69f66d451219c8ad2 Diff: https://reviews.apache.org/r/24669/diff/ Testing --- Ran the ThreadLocal tests with a lot of iterations. Thanks, Ben Mahler
Re: Review Request 24672: Renamed argv in CommandInfo to arguments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24672/#review50516 --- Ship it! Ship It! - Benjamin Hindman On Aug. 13, 2014, 9:46 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24672/ --- (Updated Aug. 13, 2014, 9:46 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - include/mesos/mesos.proto dc781d15d3985bf15954a877c7bbd6dbfe2d9094 src/common/type_utils.cpp 78bfa942f3039d4eda5627d1340231d7110daed9 src/health-check/main.cpp 68499475520cac3e11b30621ac5684c6e1f8e2cb src/launcher/executor.cpp 64a41752ee77aa508862194d763dc578aca0c321 src/slave/containerizer/mesos/launch.cpp 4e727a1c90b94dbe46fcc23ea37c366472e233ab src/slave/http.cpp 92eb348707aa256799ebc46142e085107666f894 src/slave/slave.cpp 59477d57d9f99d61762652fe51ebf2aa770f8d66 src/tests/health_check_tests.cpp 64fbf629bfdc3ea6c4de7e902bebdea28fdb19b2 Diff: https://reviews.apache.org/r/24672/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24628: MESOS-1171: unbundle gmock
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/ --- (Updated Aug. 13, 2014, 9:55 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Changes --- update per review. Bugs: MESOS-1171 https://issues.apache.org/jira/browse/MESOS-1171 Repository: mesos-git Description --- Enable support to build against unbundled versions of gmock. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24628/diff/ Testing --- configure make check configure --disable-bundled make check configure --with-gmock=/opt/gmock make check Thanks, Timothy St. Clair
Re: Review Request 24672: Renamed argv in CommandInfo to arguments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24672/#review50513 --- Ship it! Much appreciated! include/mesos/mesos.proto https://reviews.apache.org/r/24672/#comment88360 Looks good, maybe we should avoid saying that we will use exec since that's not what we do with docker. Maybe just call out with a note that this is _similar_ to exec? include/mesos/mesos.proto https://reviews.apache.org/r/24672/#comment88361 I feel like we could do away with the individual comments on 'value' and 'arguments' and just rely on the block comment, might be easier: // There are two ways to specify the command: // (1) shell = true ... // (2) shell = false ... // // NOTE: value became optional in ... optional bool shell = 6 [default = true]; optional string value = 3; repeated string arguments = 7; Otherwise it seems like we are repeating ourselves a bit? - Ben Mahler On Aug. 13, 2014, 9:46 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24672/ --- (Updated Aug. 13, 2014, 9:46 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - include/mesos/mesos.proto dc781d15d3985bf15954a877c7bbd6dbfe2d9094 src/common/type_utils.cpp 78bfa942f3039d4eda5627d1340231d7110daed9 src/health-check/main.cpp 68499475520cac3e11b30621ac5684c6e1f8e2cb src/launcher/executor.cpp 64a41752ee77aa508862194d763dc578aca0c321 src/slave/containerizer/mesos/launch.cpp 4e727a1c90b94dbe46fcc23ea37c366472e233ab src/slave/http.cpp 92eb348707aa256799ebc46142e085107666f894 src/slave/slave.cpp 59477d57d9f99d61762652fe51ebf2aa770f8d66 src/tests/health_check_tests.cpp 64fbf629bfdc3ea6c4de7e902bebdea28fdb19b2 Diff: https://reviews.apache.org/r/24672/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24628: MESOS-1171: unbundle gmock
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/#review50517 --- Ship it! Ship It! - Vinod Kone On Aug. 13, 2014, 9:55 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/ --- (Updated Aug. 13, 2014, 9:55 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1171 https://issues.apache.org/jira/browse/MESOS-1171 Repository: mesos-git Description --- Enable support to build against unbundled versions of gmock. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24628/diff/ Testing --- configure make check configure --disable-bundled make check configure --with-gmock=/opt/gmock make check Thanks, Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50518 --- Ship it! i'm assuming you tested this with all 3 configurations (bundled,system,prefix) like you did for gmock? configure.ac https://reviews.apache.org/r/23086/#comment88370 shouldn't this be different if we are using bundled protoc vs system installed protoc? i guess it is ok here because PROTOCOMPILER is only used in non-bundled case below and later in src/Makefile.am. it was definitely a bit confusing to me, so maybe add a comment? alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it appropriately for bundled/prefix/system cases. i'm assuming you didn't do it that way because it isn't easy to get protobuf version? - Vinod Kone On Aug. 13, 2014, 7:46 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 13, 2014, 7:46 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 0ac95b4 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/python/native/ext_modules.py.in 477e63d Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24673: Used new CommandInfo with Docker::run.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24673/#review50519 --- Ship it! src/docker/docker.cpp https://reviews.apache.org/r/24673/#comment88380 I would probably rename it to argv as subprocess's signature uses argv. - Jie Yu On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24673/ --- (Updated Aug. 13, 2014, 9:53 p.m.) Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 Diff: https://reviews.apache.org/r/24673/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24673: Used new CommandInfo with Docker::run.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24673/#review50520 --- Ship it! Ship It! - Timothy Chen On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24673/ --- (Updated Aug. 13, 2014, 9:53 p.m.) Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 Diff: https://reviews.apache.org/r/24673/diff/ Testing --- make check Thanks, Benjamin Hindman
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2335
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2335/changes Changes: [yujie.jay] Revert Refactored the protobuf message comparison logic. [yujie.jay] Updated equality check for CommandInfo. [bmahler] Removed unused test file 'process_spawn.cpp'. [bmahler] Added a missing test target in Makefile.am. [bmahler] Some Master cleanups. [bmahler] Model pending tasks in the Master's metrics and JSON. [bmahler] Expose pending tasks during reconciliation. -- [...truncated 3067 lines...] running install_lib running build_py creating build creating build/lib.linux-x86_64-2.7 creating build/lib.linux-x86_64-2.7/mesos copying src/mesos/__init__.py - build/lib.linux-x86_64-2.7/mesos creating build/lib.linux-x86_64-2.7/mesos/interface copying src/mesos/interface/containerizer_pb2.py - build/lib.linux-x86_64-2.7/mesos/interface copying src/mesos/interface/__init__.py - build/lib.linux-x86_64-2.7/mesos/interface copying src/mesos/interface/mesos_pb2.py - build/lib.linux-x86_64-2.7/mesos/interface creating build/bdist.linux-x86_64 creating build/bdist.linux-x86_64/egg creating build/bdist.linux-x86_64/egg/mesos creating build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/containerizer_pb2.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/__init__.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/mesos_pb2.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/__init__.py - build/bdist.linux-x86_64/egg/mesos byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/containerizer_pb2.py to containerizer_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/__init__.py to __init__.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/mesos_pb2.py to mesos_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc creating build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/PKG-INFO - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/SOURCES.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/dependency_links.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/namespace_packages.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/requires.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/top_level.txt - build/bdist.linux-x86_64/egg/EGG-INFO zip_safe flag not set; analyzing archive contents... mesos.__init__: module references __path__ creating dist creating 'dist/mesos.interface-0.20.0-py2.7.egg' and adding 'build/bdist.linux-x86_64/egg' to it removing 'build/bdist.linux-x86_64/egg' (and everything under it) running bdist_egg running egg_info creating src/mesos.native.egg-info writing requirements to src/mesos.native.egg-info/requires.txt writing src/mesos.native.egg-info/PKG-INFO writing namespace_packages to src/mesos.native.egg-info/namespace_packages.txt writing top-level names to src/mesos.native.egg-info/top_level.txt writing dependency_links to src/mesos.native.egg-info/dependency_links.txt writing manifest file 'src/mesos.native.egg-info/SOURCES.txt' reading manifest file 'src/mesos.native.egg-info/SOURCES.txt' writing manifest file 'src/mesos.native.egg-info/SOURCES.txt' installing library code to build/bdist.linux-x86_64/egg running install_lib running build_py creating build creating build/lib.linux-x86_64-2.7 creating build/lib.linux-x86_64-2.7/mesos copying src/mesos/__init__.py - build/lib.linux-x86_64-2.7/mesos creating build/lib.linux-x86_64-2.7/mesos/native copying src/mesos/native/__init__.py - build/lib.linux-x86_64-2.7/mesos/native running build_ext building 'mesos.native._mesos' extension creating build/temp.linux-x86_64-2.7 creating build/temp.linux-x86_64-2.7/src creating build/temp.linux-x86_64-2.7/src/mesos creating build/temp.linux-x86_64-2.7/src/mesos/native gcc -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -g -g2 -O2 -std=c++0x -fPIC -I/x1/jenkins/jenkins-slave/workspace/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/build/../include -I/x1/jenkins/jenkins-slave/workspace/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/build/include -I/x1/jenkins/jenkins-slave/workspace/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/build/include/mesos -I/x1/jenkins/jenkins-slave/workspace/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/build/src -I/x1/jenkins/jenkins-slave/workspace/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/build/src/python/native/src/mesos/native -I/x1/jenkins/jenkins-slave/workspace/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src -I/usr/include/python2.7 -c
Review Request 24674: Added GLOG signal handler to print stack traces on segfault in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24674/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1698 https://issues.apache.org/jira/browse/MESOS-1698 Repository: mesos-git Description --- Will help us diagnose MESOS-1698. Diffs - 3rdparty/libprocess/src/tests/main.cpp 6c672b46bc4821445cac051a339bbb43ed8bbce9 Diff: https://reviews.apache.org/r/24674/diff/ Testing --- make check Thanks, Vinod Kone
Review Request 24675: Added GLOG signal handler to print stack traces on segfault in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24675/ --- Review request for mesos. Bugs: MESOS-1698 https://issues.apache.org/jira/browse/MESOS-1698 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/main.cpp 0f1e9cbb2b869a53b979f138d3a89015f2bfbf56 Diff: https://reviews.apache.org/r/24675/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 24675: Added GLOG signal handler to print stack traces on segfault in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24675/ --- (Updated Aug. 13, 2014, 10:36 p.m.) Review request for mesos and Ben Mahler. Changes --- added reviewer. Bugs: MESOS-1698 https://issues.apache.org/jira/browse/MESOS-1698 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/main.cpp 0f1e9cbb2b869a53b979f138d3a89015f2bfbf56 Diff: https://reviews.apache.org/r/24675/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 24674: Added GLOG signal handler to print stack traces on segfault in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24674/#review50521 --- Ship it! Ship It! - Ben Mahler On Aug. 13, 2014, 10:36 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24674/ --- (Updated Aug. 13, 2014, 10:36 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1698 https://issues.apache.org/jira/browse/MESOS-1698 Repository: mesos-git Description --- Will help us diagnose MESOS-1698. Diffs - 3rdparty/libprocess/src/tests/main.cpp 6c672b46bc4821445cac051a339bbb43ed8bbce9 Diff: https://reviews.apache.org/r/24674/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 24675: Added GLOG signal handler to print stack traces on segfault in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24675/#review50523 --- Ship it! Ship It! - Ben Mahler On Aug. 13, 2014, 10:36 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24675/ --- (Updated Aug. 13, 2014, 10:36 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1698 https://issues.apache.org/jira/browse/MESOS-1698 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/main.cpp 0f1e9cbb2b869a53b979f138d3a89015f2bfbf56 Diff: https://reviews.apache.org/r/24675/diff/ Testing --- make check Thanks, Vinod Kone
Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2048
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2048/
Review Request 24677: Add Docker::pull
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24677/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Added Docker pull(). BenH already has a patch and I'm taking his and adding inspect call into pull. Diffs - src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 Diff: https://reviews.apache.org/r/24677/diff/ Testing --- make check Thanks, Timothy Chen
Jenkins build is back to normal : mesos-reviewbot #1335
See https://builds.apache.org/job/mesos-reviewbot/1335/changes
Re: Review Request 24667: Added a user doc for framework rate limiting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24667/#review50526 --- docs/framework-rate-limiting.md https://reviews.apache.org/r/24667/#comment88388 s/the this/this/ s/that it crashes/causing the master to OOM/ docs/framework-rate-limiting.md https://reviews.apache.org/r/24667/#comment88389 not sure I understand the statement in brackets. can you rephrase maybe? docs/framework-rate-limiting.md https://reviews.apache.org/r/24667/#comment88390 s/turns/terms/ docs/framework-rate-limiting.md https://reviews.apache.org/r/24667/#comment88391 what do you mean by nature of the frameworks? do you mean messages generated by the frameworks? docs/framework-rate-limiting.md https://reviews.apache.org/r/24667/#comment88392 by its messages you mean master's or frameworks'? i guess the latter? i'm still a bit unclear on what the recommendation is here. can you expand on the comment? - Vinod Kone On Aug. 13, 2014, 9:10 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24667/ --- (Updated Aug. 13, 2014, 9:10 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1683 https://issues.apache.org/jira/browse/MESOS-1683 Repository: mesos-git Description --- See summary. Diffs - docs/framework-rate-limiting.md PRE-CREATION Diff: https://reviews.apache.org/r/24667/diff/ Testing --- Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9 Thanks, Jiang Yan Xu
Review Request 24678: Fixed the flaky SlaveRecoveryTest.ShutdownSlave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24678/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - src/tests/slave_recovery_tests.cpp b53353c7c557244ec4a673a7f8ed13c94bad1584 Diff: https://reviews.apache.org/r/24678/diff/ Testing --- make check bin/mesos-tests.sh --gtest_filter=*ShutdownSlave --gtest_repeat=20 Thanks, Jie Yu
Re: Review Request 24678: Fixed the flaky SlaveRecoveryTest.ShutdownSlave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24678/#review50529 --- Ship it! Ship It! - Vinod Kone On Aug. 13, 2014, 11:45 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24678/ --- (Updated Aug. 13, 2014, 11:45 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - src/tests/slave_recovery_tests.cpp b53353c7c557244ec4a673a7f8ed13c94bad1584 Diff: https://reviews.apache.org/r/24678/diff/ Testing --- make check bin/mesos-tests.sh --gtest_filter=*ShutdownSlave --gtest_repeat=20 Thanks, Jie Yu
Re: Review Request 24673: Used new CommandInfo with Docker::run.
On Aug. 13, 2014, 10:22 p.m., Timothy Chen wrote: Ship It! Ben you will need to update this rb with the new commandInfo argv - arguments renamed. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24673/#review50520 --- On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24673/ --- (Updated Aug. 13, 2014, 9:53 p.m.) Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 Diff: https://reviews.apache.org/r/24673/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.
On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote: src/tests/slave_tests.cpp, line 1254 https://reviews.apache.org/r/22313/diff/24/?file=653349#file653349line1254 Why are you failing the promise here? Don't you want to set it to Nothing and then make sure that task doesn't launch? Otherwise, what you are testing is containerizer update failure path and not executor/framework removed path. Yifan Gu wrote: Umm, I can return Nothing here, but I think since the executor/framework removed path is visited first, so either will test this path. that is true, but what if someone in the future comes along and changes the order of the if statements in __runTask()? On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote: src/tests/slave_tests.cpp, line 1314 https://reviews.apache.org/r/22313/diff/24/?file=653349#file653349line1314 Kill this? Why would there be subsequent updates here? Yifan Gu wrote: I remember that last time I ignored the subsequent updates, it will cause the tests to fail. https://issues.apache.org/jira/browse/MESOS-1460 But I have run these tests for more than 3000 times without .WillRepeatedly(Return()); They haven't failed yet... maybe it failed earlier because you didn't have the .WillRepeatedly() expectation below where you set the expectation for status2. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review50239 --- On Aug. 12, 2014, 11:07 p.m., Yifan Gu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ --- (Updated Aug. 12, 2014, 11:07 p.m.) Review request for mesos, Ian Downes and Vinod Kone. Bugs: MESOS-886 https://issues.apache.org/jira/browse/MESOS-886 Repository: mesos-git Description --- Added __runTask() to wait for the completion of containerizer-update() and check the result before sending RunTaskMessage. Diffs - src/slave/slave.hpp 9d4607e src/slave/slave.cpp 787bd05 src/tests/slave_tests.cpp 69be28f Diff: https://reviews.apache.org/r/22313/diff/ Testing --- SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved SlaveTest.LaunchTaskAfterContainerizerUpdate ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*LaunchTask* successful times 2000 make check File Attachments framework will exit https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff log https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log Thanks, Yifan Gu
Review Request 24681: Updated subprocess to use os::execvpe.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24681/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/src/subprocess.cpp 68bfd5d05c863f5fb00d10e6bfa3070c13d0e36c Diff: https://reviews.apache.org/r/24681/diff/ Testing --- make check Thanks, Jie Yu
Review Request 24682: Updated mesos to use os::execvpe.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24682/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - src/health-check/main.cpp 730a7a2828a332655e1843b992c099312ae42274 src/launcher/executor.cpp 9b767a57f6f90286bd0d884c9598dd6883267a43 src/slave/containerizer/mesos/launch.cpp 35b57b3bceb08e4109c75cb1f2cdcb8bf66a6049 src/tests/health_check_tests.cpp b6d7fa8ac8e00927129591e665d9edf3beb9fb0f Diff: https://reviews.apache.org/r/24682/diff/ Testing --- make check on both mac and linux Thanks, Jie Yu
Re: Review Request 24677: Add Docker::pull
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24677/#review50532 --- Ship it! src/docker/docker.cpp https://reviews.apache.org/r/24677/#comment88395 The image here might come from end user. So for security concern, we should use the argv version to prevent shell injection. You don't need to address that in this patch, but we should address that before releasing. For example, what if image == rm -rf / src/docker/docker.cpp https://reviews.apache.org/r/24677/#comment88396 Ditto. - Jie Yu On Aug. 13, 2014, 11:32 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24677/ --- (Updated Aug. 13, 2014, 11:32 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Added Docker pull(). BenH already has a patch and I'm taking his and adding inspect call into pull. Diffs - src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 Diff: https://reviews.apache.org/r/24677/diff/ Testing --- make check Thanks, Timothy Chen
Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2336
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2336/changes
Re: Review Request 24679: Added os::execvpe to stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24679/#review50534 --- As per your suggestion, exposing an os::environp() sounds good to me. 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp https://reviews.apache.org/r/24679/#comment88397 This seems a bit tricky since the caller needs to be aware of the fact that the 'environ' memory can be swapped without a leak occurring? Per your suggestion in our conversation, seems safer to expose a portable 'os::environp()'. Less prone to mistakes :) 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp https://reviews.apache.org/r/24679/#comment88398 This comment is great, I wonder if we can get away with just saying that this is a _portable_ version of execvpe (which does not exist on all systems)? Up to you. 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp https://reviews.apache.org/r/24679/#comment88399 I think your code is self-explanatory, and will be even more so with os::environp(), feel free to remove these code comments if you like :) s/ **/** / s/rc/result/ - Ben Mahler On Aug. 14, 2014, 12:02 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24679/ --- (Updated Aug. 14, 2014, 12:02 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- The idea here is to use the 'p' (search PATH) version consistently in the code base. Mac does not have os::execvpe defined, so I end up implementing it per this thread: http://stackoverflow.com/questions/7789750/execve-with-path-search Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 4d671869754ba7d83ca86d76eacdbb67c7828ee7 Diff: https://reviews.apache.org/r/24679/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24682: Updated mesos to use os::execvpe.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24682/#review50536 --- Ship it! src/tests/health_check_tests.cpp https://reviews.apache.org/r/24682/#comment88400 Why the change and what is the meaning of passing argv[0] as the string? - Ben Mahler On Aug. 14, 2014, 12:04 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24682/ --- (Updated Aug. 14, 2014, 12:04 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - src/health-check/main.cpp 730a7a2828a332655e1843b992c099312ae42274 src/launcher/executor.cpp 9b767a57f6f90286bd0d884c9598dd6883267a43 src/slave/containerizer/mesos/launch.cpp 35b57b3bceb08e4109c75cb1f2cdcb8bf66a6049 src/tests/health_check_tests.cpp b6d7fa8ac8e00927129591e665d9edf3beb9fb0f Diff: https://reviews.apache.org/r/24682/diff/ Testing --- make check on both mac and linux Thanks, Jie Yu
Review Request 24687: Added support for disabling glog initialization.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24687/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-1629 https://issues.apache.org/jira/browse/MESOS-1629 Repository: mesos-git Description --- C++ frameworks can now explicitly disable glog initialization if they choose to do so. By default now the executor driver also enables glog initialization. It didn't use to before, but I think that's a bug. Diffs - include/mesos/executor.hpp ed2330f1677b9aa56ef43bae5dec0b3acfca0e1c include/mesos/scheduler.hpp 802727270ae8afb2d772bdb0170a2378dd611ee4 src/exec/exec.cpp 15d41eb303c81a1ae958adc76a105c11d7ef72ef src/java/src/org/apache/mesos/MesosExecutorDriver.java 910548c0b5137294f67b8a21b8c77fc2d8dbd5e3 src/java/src/org/apache/mesos/MesosSchedulerDriver.java afdbbbc0e6deddcf620517b7ecc4ab7947ae91b6 src/logging/flags.hpp d30a7069c07af5b98a7f26e4158e839cbf424506 src/sched/sched.cpp cbc52916c551b324aab7c5ddb51b2f7679cae88b src/scheduler/scheduler.cpp 498d6aa421c96768d4be0ccff38d148e992949fc Diff: https://reviews.apache.org/r/24687/diff/ Testing --- make check # ./src/long-lived-framework 127.0.0.1:5050 I0814 01:13:32.889717 56878 sched.cpp:139] Version: 0.20.0 I0814 01:13:32.896556 56975 sched.cpp:235] New master detected at master@127.0.0.1:5050 I0814 01:13:32.896836 56975 sched.cpp:243] No credentials provided. Attempting to register without authentication # MESOS_LOGGING_INITIALIZE=0 ./src/long-lived-framework 127.0.0.1:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR I0814 01:14:18.517209 60286 sched.cpp:139] Version: 0.20.0 I0814 01:14:18.524113 60322 sched.cpp:235] New master detected at master@127.0.0.1:5050 I0814 01:14:18.524395 60322 sched.cpp:243] No credentials provided. Attempting to register without authentication # MESOS_LOGGING_INITIALIZE=1 ./src/long-lived-framework 127.0.0.1:5050 I0814 01:14:25.621443 60969 sched.cpp:139] Version: 0.20.0 I0814 01:14:25.628525 60986 sched.cpp:235] New master detected at master@127.0.0.1:5050 I0814 01:14:25.628746 60986 sched.cpp:243] No credentials provided. Attempting to register without authentication Thanks, Vinod Kone
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote: i'm assuming you tested this with all 3 configurations (bundled,system,prefix) like you did for gmock? correct. On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote: configure.ac, line 255 https://reviews.apache.org/r/23086/diff/4-6/?file=657913#file657913line255 shouldn't this be different if we are using bundled protoc vs system installed protoc? i guess it is ok here because PROTOCOMPILER is only used in non-bundled case below and later in src/Makefile.am. it was definitely a bit confusing to me, so maybe add a comment? alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it appropriately for bundled/prefix/system cases. i'm assuming you didn't do it that way because it isn't easy to get protobuf version? I updated the logic to make it similar to the others elif test x$enable_bundled = xno; then PROTOCOMPILER=protoc and added a comment. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50518 --- On Aug. 13, 2014, 7:46 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 13, 2014, 7:46 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 0ac95b4 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/python/native/ext_modules.py.in 477e63d Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 14, 2014, 1:21 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes --- update per review Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 0ac95b4 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/python/native/ext_modules.py.in 477e63d Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24475: Add new Docker configurations
On Aug. 13, 2014, 8:36 p.m., Ian Downes wrote: src/docker/docker.cpp, line 303 https://reviews.apache.org/r/24475/diff/5/?file=659130#file659130line303 s/to// I hope I can grok grammer one day. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50485 --- On Aug. 13, 2014, 5:47 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 13, 2014, 5:47 a.m.) Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Repository: mesos-git Description --- Added new DockerInfo for future docker options, and allow command uris to be fetched and mapped into docker before launching docker container. Diffs - include/mesos/mesos.proto cc9f20e src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 src/slave/containerizer/containerizer.hpp 02754cd src/slave/containerizer/containerizer.cpp c91ba38 src/slave/containerizer/docker.cpp 904cdd3 src/slave/containerizer/mesos/containerizer.cpp 694c9d1 src/slave/flags.hpp 841de23 src/slave/slave.cpp 787bd05 src/tests/docker_containerizer_tests.cpp a559836 src/tests/docker_tests.cpp 4ef1df4 Diff: https://reviews.apache.org/r/24475/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 24475: Add new Docker configurations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 14, 2014, 1:37 a.m.) Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Changes --- Took out docker logs from this reviewboard and addressed comments. Repository: mesos-git Description --- Added new DockerInfo for future docker options, and allow command uris to be fetched and mapped into docker before launching docker container. Diffs (updated) - include/mesos/mesos.proto adc8fab src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 src/slave/containerizer/containerizer.hpp 02754cd src/slave/containerizer/containerizer.cpp c91ba38 src/slave/containerizer/docker.cpp 904cdd3 src/slave/containerizer/mesos/containerizer.cpp 694c9d1 src/slave/flags.hpp 1e36c51 src/tests/docker_containerizer_tests.cpp a559836 src/tests/docker_tests.cpp 4ef1df4 Diff: https://reviews.apache.org/r/24475/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 24679: Added os::execvpe to stout.
On Aug. 14, 2014, 1:06 a.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 596-604 https://reviews.apache.org/r/24679/diff/1/?file=659693#file659693line596 This comment is great, I wonder if we can get away with just saying that this is a _portable_ version of execvpe (which does not exist on all systems)? Up to you. Done. On Aug. 14, 2014, 1:06 a.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 607-618 https://reviews.apache.org/r/24679/diff/1/?file=659693#file659693line607 I think your code is self-explanatory, and will be even more so with os::environp(), feel free to remove these code comments if you like :) s/ **/** / s/rc/result/ Done. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24679/#review50534 --- On Aug. 14, 2014, 12:02 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24679/ --- (Updated Aug. 14, 2014, 12:02 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- The idea here is to use the 'p' (search PATH) version consistently in the code base. Mac does not have os::execvpe defined, so I end up implementing it per this thread: http://stackoverflow.com/questions/7789750/execve-with-path-search Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 4d671869754ba7d83ca86d76eacdbb67c7828ee7 Diff: https://reviews.apache.org/r/24679/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24682: Updated mesos to use os::execvpe.
On Aug. 14, 2014, 1:12 a.m., Ben Mahler wrote: src/tests/health_check_tests.cpp, line 234 https://reviews.apache.org/r/24682/diff/1/?file=659698#file659698line234 Why the change and what is the meaning of passing argv[0] as the string? Changed back:) - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24682/#review50536 --- On Aug. 14, 2014, 12:04 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24682/ --- (Updated Aug. 14, 2014, 12:04 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - src/health-check/main.cpp 730a7a2828a332655e1843b992c099312ae42274 src/launcher/executor.cpp 9b767a57f6f90286bd0d884c9598dd6883267a43 src/slave/containerizer/mesos/launch.cpp 35b57b3bceb08e4109c75cb1f2cdcb8bf66a6049 src/tests/health_check_tests.cpp b6d7fa8ac8e00927129591e665d9edf3beb9fb0f Diff: https://reviews.apache.org/r/24682/diff/ Testing --- make check on both mac and linux Thanks, Jie Yu
Re: Review Request 24679: Added os::execvpe to stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24679/ --- (Updated Aug. 14, 2014, 2:39 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes --- BenM's comments. Repository: mesos-git Description --- The idea here is to use the 'p' (search PATH) version consistently in the code base. Mac does not have os::execvpe defined, so I end up implementing it per this thread: http://stackoverflow.com/questions/7789750/execve-with-path-search Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 4d67186 Diff: https://reviews.apache.org/r/24679/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24682: Updated mesos to use os::execvpe.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24682/ --- (Updated Aug. 14, 2014, 2:41 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes --- BenM's comments. Repository: mesos-git Description --- See summary. Diffs (updated) - src/health-check/main.cpp 730a7a2 src/launcher/executor.cpp 9b767a5 src/slave/containerizer/mesos/launch.cpp 35b57b3 src/tests/health_check_tests.cpp b6d7fa8 Diff: https://reviews.apache.org/r/24682/diff/ Testing --- make check on both mac and linux Thanks, Jie Yu
Re: Review Request 24555: MESOS-1169: unbundle distribute
On Aug. 13, 2014, 11:07 p.m., Vinod Kone wrote: mpi/mpiexec-mesos.in, lines 21-22 https://reviews.apache.org/r/24555/diff/2/?file=659530#file659530line21 In all these scripts, it's weird to me that we print a failed message even if the user specifically asked us to use a non-bundled egg. More importantly, if a bundled distribute egg exists in the build dir (perhaps from an earlier build) we favor it even when the user asked us to use the system installed version. My worry is that issues relating to these would be hard to diagnose down the line. Does this script have access to WITH_BUNDLED_DISTRIBUTE variable? If yes we should use that to determine whether to include DISTRIBUTE_EGG in the PYTHONPATH (down below where we exec). Does that make sense? I guess we have the same issue with protobuf egg in the earlier review. For the script work I honestly think it needs a lot more work and greater in scope then just this ticket. If it's ok with you, I would like to open some follow up tickets on this. Right now it would be an extremely rare case for folks to reconfigure bundled/unbundled and build when stale data is around, but I completely agree the logic is obtuse and weird. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/#review50522 --- On Aug. 14, 2014, 3:04 a.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/ --- (Updated Aug. 14, 2014, 3:04 a.m.) Review request for mesos, Adam B, Jie Yu, and Vinod Kone. Bugs: MESOS-1169 https://issues.apache.org/jira/browse/MESOS-1169 Repository: mesos-git Description --- Enabling unbundling for distribute python utils. Diffs - 3rdparty/Makefile.am 70b45fe configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd Diff: https://reviews.apache.org/r/24555/diff/ Testing --- ./configure make check ./configure --disable-bundled make check For prefixed installs require updated PYTHON_PATH. Thanks, Timothy St. Clair
Re: Review Request 24555: MESOS-1169: unbundle distribute
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/ --- (Updated Aug. 14, 2014, 3:04 a.m.) Review request for mesos, Adam B, Jie Yu, and Vinod Kone. Changes --- Update per review. Bugs: MESOS-1169 https://issues.apache.org/jira/browse/MESOS-1169 Repository: mesos-git Description --- Enabling unbundling for distribute python utils. Diffs (updated) - 3rdparty/Makefile.am 70b45fe configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd Diff: https://reviews.apache.org/r/24555/diff/ Testing (updated) --- ./configure make check ./configure --disable-bundled make check For prefixed installs require updated PYTHON_PATH. Thanks, Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote: configure.ac, line 255 https://reviews.apache.org/r/23086/diff/4-6/?file=657913#file657913line255 shouldn't this be different if we are using bundled protoc vs system installed protoc? i guess it is ok here because PROTOCOMPILER is only used in non-bundled case below and later in src/Makefile.am. it was definitely a bit confusing to me, so maybe add a comment? alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it appropriately for bundled/prefix/system cases. i'm assuming you didn't do it that way because it isn't easy to get protobuf version? Timothy St. Clair wrote: I updated the logic to make it similar to the others elif test x$enable_bundled = xno; then PROTOCOMPILER=protoc and added a comment. Let me know if you would like me to commit. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50518 --- On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 14, 2014, 1:21 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 0ac95b4 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/python/native/ext_modules.py.in 477e63d Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24679: Added os::execvpe to stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24679/#review50545 --- Ship it! Thanks! Looks like the s/rc/result/ change was missed? - Ben Mahler On Aug. 14, 2014, 2:39 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24679/ --- (Updated Aug. 14, 2014, 2:39 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- The idea here is to use the 'p' (search PATH) version consistently in the code base. Mac does not have os::execvpe defined, so I end up implementing it per this thread: http://stackoverflow.com/questions/7789750/execve-with-path-search Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 4d67186 Diff: https://reviews.apache.org/r/24679/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 24679: Added os::execvpe to stout.
On Aug. 14, 2014, 3:42 a.m., Ben Mahler wrote: Thanks! Looks like the s/rc/result/ change was missed? whoops.. will fix that! - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24679/#review50545 --- On Aug. 14, 2014, 2:39 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24679/ --- (Updated Aug. 14, 2014, 2:39 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- The idea here is to use the 'p' (search PATH) version consistently in the code base. Mac does not have os::execvpe defined, so I end up implementing it per this thread: http://stackoverflow.com/questions/7789750/execve-with-path-search Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 4d67186 Diff: https://reviews.apache.org/r/24679/diff/ Testing --- make check Thanks, Jie Yu
RB 2.0.5
Thanks to Jake Farrell, we now have an upgraded RB server (1.6.x to 2.0.x)! Apart from the UI flourishes, the thing I'm excited about is that this should fix our long standing problem of review updates obliterating depends on field! Thanks again Jake for the quick turn around. Really appreciate it.
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
On Aug. 14, 2014, 4:10 a.m., Vinod Kone wrote: LGTM. Go ahead and commit it. Thanks Time for your patience. Tim* - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50547 --- On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 14, 2014, 1:21 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 0ac95b4 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/python/native/ext_modules.py.in 477e63d Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50547 --- Ship it! LGTM. Go ahead and commit it. Thanks Time for your patience. - Vinod Kone On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 14, 2014, 1:21 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 0ac95b4 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/python/native/ext_modules.py.in 477e63d Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
