Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2503
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2503/changes
Build failed in Jenkins: mesos-reviewbot #2317
See https://builds.apache.org/job/mesos-reviewbot/2317/
--
[...truncated 5381 lines...]
rm -f sched/*.lo
rm -f scheduler/*.o
rm -f scheduler/*.lo
rm -f slave/*.o
rm -f slave/*.lo
rm -f slave/containerizer/*.o
rm -f slave/containerizer/*.lo
rm -f slave/containerizer/isolators/cgroups/*.o
rm -f slave/containerizer/isolators/cgroups/*.lo
rm -f slave/containerizer/isolators/filesystem/*.o
rm -f slave/containerizer/isolators/filesystem/*.lo
rm -f slave/containerizer/isolators/namespaces/*.o
rm -f slave/containerizer/isolators/namespaces/*.lo
rm -f slave/containerizer/isolators/network/*.o
rm -f slave/containerizer/isolators/network/*.lo
rm -f slave/containerizer/mesos/*.o
rm -rf authorizer/.libs authorizer/_libs
rm -rf common/.libs common/_libs
rm -rf containerizer/.libs containerizer/_libs
rm -f slave/containerizer/mesos/*.lo
rm -rf docker/.libs docker/_libs
rm -f state/*.o
rm -rf examples/.libs examples/_libs
rm -rf exec/.libs exec/_libs
rm -f state/*.lo
rm -f tests/*.o
rm -rf files/.libs files/_libs
rm -rf java/jni/.libs java/jni/_libs
rm -rf jvm/.libs jvm/_libs
rm -rf jvm/org/apache/.libs jvm/org/apache/_libs
rm -rf linux/.libs linux/_libs
rm -rf linux/routing/.libs linux/routing/_libs
rm -rf linux/routing/diagnosis/.libs linux/routing/diagnosis/_libs
rm -rf linux/routing/filter/.libs linux/routing/filter/_libs
rm -rf linux/routing/link/.libs linux/routing/link/_libs
rm -rf linux/routing/queueing/.libs linux/routing/queueing/_libs
rm -rf local/.libs local/_libs
rm -rf log/.libs log/_libs
rm -rf log/tool/.libs log/tool/_libs
rm -rf logging/.libs logging/_libs
rm -rf master/.libs master/_libs
rm -rf messages/.libs messages/_libs
rm -rf module/.libs module/_libs
rm -rf sasl/.libs sasl/_libs
rm -rf sched/.libs sched/_libs
rm -rf scheduler/.libs scheduler/_libs
rm -rf slave/.libs slave/_libs
rm -f tests/common/*.o
rm -f usage/*.o
rm -rf slave/containerizer/.libs slave/containerizer/_libs
rm -f usage/*.lo
rm -f zookeeper/*.o
rm -f zookeeper/*.lo
rm -rf slave/containerizer/isolators/cgroups/.libs
slave/containerizer/isolators/cgroups/_libs
rm -rf slave/containerizer/isolators/filesystem/.libs
slave/containerizer/isolators/filesystem/_libs
rm -rf slave/containerizer/isolators/namespaces/.libs
slave/containerizer/isolators/namespaces/_libs
rm -rf slave/containerizer/isolators/network/.libs
slave/containerizer/isolators/network/_libs
rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs
rm -rf state/.libs state/_libs
rm -rf usage/.libs usage/_libs
rm -rf zookeeper/.libs zookeeper/_libs
rm -rf ./.deps authorizer/.deps cli/.deps common/.deps containerizer/.deps
docker/.deps examples/.deps exec/.deps files/.deps health-check/.deps
java/jni/.deps jvm/.deps jvm/org/apache/.deps launcher/.deps linux/.deps
linux/routing/.deps linux/routing/diagnosis/.deps linux/routing/filter/.deps
linux/routing/link/.deps linux/routing/queueing/.deps local/.deps log/.deps
log/tool/.deps logging/.deps master/.deps messages/.deps module/.deps
sasl/.deps sched/.deps scheduler/.deps slave/.deps slave/containerizer/.deps
slave/containerizer/isolators/cgroups/.deps
slave/containerizer/isolators/filesystem/.deps
slave/containerizer/isolators/namespaces/.deps
slave/containerizer/isolators/network/.deps slave/containerizer/mesos/.deps
state/.deps tests/.deps tests/common/.deps usage/.deps zookeeper/.deps
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/src'
Making distclean in ec2
make[2]: Entering directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/ec2'
rm -rf .libs _libs
rm -f *.lo
test -z || rm -f
test . = ../../ec2 || test -z || rm -f
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/ec2'
rm -f config.status config.cache config.log configure.lineno
config.status.lineno
rm -f Makefile
make[1]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build'
if test -d mesos-0.21.0; then find mesos-0.21.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.21.0 || { sleep 5 rm -rf
mesos-0.21.0; }; else :; fi
==
mesos-0.21.0 archives ready for distribution:
mesos-0.21.0.tar.gz
==
real12m28.252s
user72m0.612s
sys 5m32.394s
+ chmod -R +w 3rdparty aclocal.m4 ar-lib autom4te.cache bin bootstrap CHANGELOG
compile config.guess config.log config.lt config.status config.sub configure
configure.ac depcomp docs Doxyfile ec2 frameworks include install-sh libtool
LICENSE ltmain.sh m4 Makefile Makefile.am Makefile.in mesos-0.21.0.tar.gz
mesos.pc mesos.pc.in missing mpi NOTICE README.md src support
+ git clean -fdx
Removing .gitignore
Removing .libs/
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
[GitHub] mesos pull request: Update mpiexec-mesos.in
GitHub user strat0sphere opened a pull request: https://github.com/apache/mesos/pull/28 Update mpiexec-mesos.in In the if statement [[ is used - [[ is a bash builtin command and is not available in sh. It will give an error ( [[: not found ) unless /bin/sh is a symbolic link to /bin/bash You can merge this pull request into a Git repository by running: $ git pull https://github.com/strat0sphere/mesos patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/mesos/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 08b507dd4a62e42acaa726f9ecb1529be862080f Author: Stratos Dimopoulos stratos.dimopou...@gmail.com Date: 2014-10-29T05:17:45Z Update mpiexec-mesos.in In the if statement [[ is used - [[ is a bash builtin command and is not available in sh. It will give an error ( [[: not found ) unless /bin/sh is a symbolic link to /bin/bash --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Jenkins build is back to normal : mesos-reviewbot #2318
See https://builds.apache.org/job/mesos-reviewbot/2318/changes
Re: Review Request 27054: Libprocess Socket: introduce connect()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/#review58966 --- Patch looks great! Reviews applied: [27023, 27054] All tests passed. - Mesos ReviewBot On Oct. 29, 2014, 5:18 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 29, 2014, 5:18 a.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Bugs: MESOS-1330 https://issues.apache.org/jira/browse/MESOS-1330 Repository: mesos-git Description --- Introduce the connect(const Node node) call to Socket. Use it in link() and send(). Diffs - 3rdparty/libprocess/include/process/socket.hpp 6683881 3rdparty/libprocess/src/process.cpp 85fb995 Diff: https://reviews.apache.org/r/27054/diff/ Testing --- make check Thanks, Joris Van Remoortere
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2227
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2227/changes Changes: [benjamin.hindman] Fixed signedness compilation bug. -- [...truncated 69451 lines...] I1029 08:29:01.746940 32251 master.cpp:358] Master only allowing authenticated frameworks to register I1029 08:29:01.746958 32251 master.cpp:363] Master only allowing authenticated slaves to register I1029 08:29:01.746973 32251 credentials.hpp:36] Loading credentials for authentication from '/tmp/MasterSlaveReconciliationTest_ReconcileLostTask_dHQFbB/credentials' I1029 08:29:01.747167 32251 master.cpp:392] Authorization enabled I1029 08:29:01.747524 32261 master.cpp:120] No whitelist given. Advertising offers for all slaves I1029 08:29:01.747531 32260 replica.cpp:638] Replica in STARTING status received a broadcasted recover request I1029 08:29:01.747757 32253 hierarchical_allocator_process.hpp:299] Initializing hierarchical allocator process with master : master@67.195.81.187:40696 I1029 08:29:01.748066 32259 recover.cpp:188] Received a recover response from a replica in STARTING status I1029 08:29:01.748724 32251 master.cpp:1242] The newly elected leader is master@67.195.81.187:40696 with id 20141029-082901-3142697795-40696-32232 I1029 08:29:01.748754 32251 master.cpp:1255] Elected as the leading master! I1029 08:29:01.748769 32251 master.cpp:1073] Recovering from registrar I1029 08:29:01.748764 32255 recover.cpp:554] Updating replica status to VOTING I1029 08:29:01.749003 32249 registrar.cpp:313] Recovering registrar I1029 08:29:01.749435 32261 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 461205ns I1029 08:29:01.749469 32261 replica.cpp:320] Persisted replica status to VOTING I1029 08:29:01.749611 32255 recover.cpp:568] Successfully joined the Paxos group I1029 08:29:01.749806 32255 recover.cpp:452] Recover process terminated I1029 08:29:01.750274 32254 log.cpp:656] Attempting to start the writer I1029 08:29:01.751739 32259 replica.cpp:474] Replica received implicit promise request with proposal 1 I1029 08:29:01.752102 32259 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 335010ns I1029 08:29:01.752128 32259 replica.cpp:342] Persisted promised to 1 I1029 08:29:01.752923 32251 coordinator.cpp:230] Coordinator attemping to fill missing position I1029 08:29:01.754606 32261 replica.cpp:375] Replica received explicit promise request for position 0 with proposal 2 I1029 08:29:01.754984 32261 leveldb.cpp:343] Persisting action (8 bytes) to leveldb took 341669ns I1029 08:29:01.755012 32261 replica.cpp:676] Persisted action at 0 I1029 08:29:01.756240 32258 replica.cpp:508] Replica received write request for position 0 I1029 08:29:01.756314 32258 leveldb.cpp:438] Reading position from leveldb took 42163ns I1029 08:29:01.756639 32258 leveldb.cpp:343] Persisting action (14 bytes) to leveldb took 285232ns I1029 08:29:01.756667 32258 replica.cpp:676] Persisted action at 0 I1029 08:29:01.757210 32261 replica.cpp:655] Replica received learned notice for position 0 I1029 08:29:01.757375 32261 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 136938ns I1029 08:29:01.757402 32261 replica.cpp:676] Persisted action at 0 I1029 08:29:01.757426 32261 replica.cpp:661] Replica learned NOP action at position 0 I1029 08:29:01.757891 32256 log.cpp:672] Writer started with ending position 0 I1029 08:29:01.758985 32255 leveldb.cpp:438] Reading position from leveldb took 24641ns I1029 08:29:01.762171 32257 registrar.cpp:346] Successfully fetched the registry (0B) in 13.080064ms I1029 08:29:01.762275 32257 registrar.cpp:445] Applied 1 operations in 25968ns; attempting to update the 'registry' I1029 08:29:01.765403 32258 log.cpp:680] Attempting to append 139 bytes to the log I1029 08:29:01.765553 32256 coordinator.cpp:340] Coordinator attempting to write APPEND action at position 1 I1029 08:29:01.766399 32261 replica.cpp:508] Replica received write request for position 1 I1029 08:29:01.766787 32261 leveldb.cpp:343] Persisting action (158 bytes) to leveldb took 356567ns I1029 08:29:01.766810 32261 replica.cpp:676] Persisted action at 1 I1029 08:29:01.767429 32253 replica.cpp:655] Replica received learned notice for position 1 I1029 08:29:01.767731 32253 leveldb.cpp:343] Persisting action (160 bytes) to leveldb took 271318ns I1029 08:29:01.767755 32253 replica.cpp:676] Persisted action at 1 I1029 08:29:01.767773 32253 replica.cpp:661] Replica learned APPEND action at position 1 I1029 08:29:01.768581 32257 registrar.cpp:490] Successfully updated the 'registry' in 6.209792ms I1029 08:29:01.768728 32257 registrar.cpp:376] Successfully recovered registrar I1029 08:29:01.768862 32246 log.cpp:699] Attempting to truncate the log to 1 I1029 08:29:01.769008 32259 master.cpp:1100] Recovered 0 slaves from the Registry (101B) ; allowing 10mins for slaves to re-register I1029 08:29:01.769173 32261 coordinator.cpp:340] Coordinator attempting
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2228
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2228/changes Changes: [benjamin.hindman] Fixed bug with snapshot positions when writing log diffs. -- [...truncated 69376 lines...] I1029 09:40:19.075613 3139 hierarchical_allocator_process.hpp:299] Initializing hierarchical allocator process with master : master@67.195.81.187:52646 I1029 09:40:19.077009 3135 replica.cpp:638] Replica in EMPTY status received a broadcasted recover request I1029 09:40:19.077117 3143 master.cpp:1242] The newly elected leader is master@67.195.81.187:52646 with id 20141029-094017-3142697795-52646-3116 I1029 09:40:19.077160 3143 master.cpp:1255] Elected as the leading master! I1029 09:40:19.077182 3143 master.cpp:1073] Recovering from registrar I1029 09:40:19.077455 3141 registrar.cpp:313] Recovering registrar I1029 09:40:19.077568 3139 recover.cpp:188] Received a recover response from a replica in EMPTY status I1029 09:40:19.078191 3131 recover.cpp:554] Updating replica status to STARTING I1029 09:40:19.079345 3138 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 985524ns I1029 09:40:19.079370 3138 replica.cpp:320] Persisted replica status to STARTING I1029 09:40:19.079610 3143 recover.cpp:463] Replica is in STARTING status I1029 09:40:19.080679 3132 replica.cpp:638] Replica in STARTING status received a broadcasted recover request I1029 09:40:19.081054 3137 recover.cpp:188] Received a recover response from a replica in STARTING status I1029 09:40:19.081483 3133 recover.cpp:554] Updating replica status to VOTING I1029 09:40:19.082223 3135 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 585974ns I1029 09:40:19.082250 3135 replica.cpp:320] Persisted replica status to VOTING I1029 09:40:19.082372 3131 recover.cpp:568] Successfully joined the Paxos group I1029 09:40:19.082594 3131 recover.cpp:452] Recover process terminated I1029 09:40:19.083050 3135 log.cpp:656] Attempting to start the writer I1029 09:40:19.084597 3142 replica.cpp:474] Replica received implicit promise request with proposal 1 I1029 09:40:19.085218 3142 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 588099ns I1029 09:40:19.085243 3142 replica.cpp:342] Persisted promised to 1 I1029 09:40:19.085911 3138 coordinator.cpp:230] Coordinator attemping to fill missing position I1029 09:40:19.087317 3141 replica.cpp:375] Replica received explicit promise request for position 0 with proposal 2 I1029 09:40:19.087848 3141 leveldb.cpp:343] Persisting action (8 bytes) to leveldb took 494271ns I1029 09:40:19.087873 3141 replica.cpp:676] Persisted action at 0 I1029 09:40:19.089040 3131 replica.cpp:508] Replica received write request for position 0 I1029 09:40:19.089090 3131 leveldb.cpp:438] Reading position from leveldb took 24077ns I1029 09:40:19.089602 3131 leveldb.cpp:343] Persisting action (14 bytes) to leveldb took 478794ns I1029 09:40:19.089628 3131 replica.cpp:676] Persisted action at 0 I1029 09:40:19.090229 3144 replica.cpp:655] Replica received learned notice for position 0 I1029 09:40:19.090790 3144 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 530255ns I1029 09:40:19.090814 3144 replica.cpp:676] Persisted action at 0 I1029 09:40:19.090836 3144 replica.cpp:661] Replica learned NOP action at position 0 I1029 09:40:19.091418 3141 log.cpp:672] Writer started with ending position 0 I1029 09:40:19.092674 3139 leveldb.cpp:438] Reading position from leveldb took 23812ns I1029 09:40:19.095818 3136 registrar.cpp:346] Successfully fetched the registry (0B) in 18.313984ms I1029 09:40:19.095935 3136 registrar.cpp:445] Applied 1 operations in 19557ns; attempting to update the 'registry' I1029 09:40:19.098989 3139 log.cpp:680] Attempting to append 138 bytes to the log I1029 09:40:19.099138 3141 coordinator.cpp:340] Coordinator attempting to write APPEND action at position 1 I1029 09:40:19.099973 3140 replica.cpp:508] Replica received write request for position 1 I1029 09:40:19.100742 3140 leveldb.cpp:343] Persisting action (157 bytes) to leveldb took 730714ns I1029 09:40:19.100769 3140 replica.cpp:676] Persisted action at 1 I1029 09:40:19.101434 3142 replica.cpp:655] Replica received learned notice for position 1 I1029 09:40:19.101959 3142 leveldb.cpp:343] Persisting action (159 bytes) to leveldb took 494168ns I1029 09:40:19.101985 3142 replica.cpp:676] Persisted action at 1 I1029 09:40:19.102006 3142 replica.cpp:661] Replica learned APPEND action at position 1 I1029 09:40:19.103004 3131 registrar.cpp:490] Successfully updated the 'registry' in 7.01696ms I1029 09:40:19.103142 3131 registrar.cpp:376] Successfully recovered registrar I1029 09:40:19.103440 3144 log.cpp:699] Attempting to truncate the log to 1 I1029 09:40:19.103482 3132 master.cpp:1100] Recovered 0 slaves from the Registry (100B) ; allowing 10mins for slaves to re-register I1029 09:40:19.103621 3134
Re: Review Request 27122: Reorganized authentication implementation locations.
On Oct. 28, 2014, 11:37 p.m., Kapil Arya wrote: src/authentication/cram_md5/authenticator.hpp, lines 19-20 https://reviews.apache.org/r/27122/diff/2/?file=733314#file733314line19 s/CRAMMD5/AUTHENTICATION_CRAM_MD5/ ? I find the idea of reversing the specification and the base interface rather unusual and it also would not fit our current scheme, e.g. ISOLATOR - MEM_ISOLATOR / SHARED_FILESYSTEM_ISOLATOR. Adding an extra underscore on the other hand should be fine. On Oct. 28, 2014, 11:37 p.m., Kapil Arya wrote: src/authentication/cram_md5/auxprop.cpp, line 1 https://reviews.apache.org/r/27122/diff/2/?file=733316#file733316line1 License blob missing. Ow indeed, we have failed to update this one for a long time. Well spotted :) - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/#review58910 --- On Oct. 25, 2014, 1:21 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/ --- (Updated Oct. 25, 2014, 1:21 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1893 https://issues.apache.org/jira/browse/MESOS-1893 Repository: mesos-git Description --- For paving the way into further authentication mechanism implementations, the existing is reorganized. Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp to src/tests/crammd5_authentication_tests.cpp. Adapt depending include paths. Rename specific test implementations from SASL to CRAMMD5Authentication. Rename sasl namespace to cram_md5 throughout all uses. Diffs - src/Makefile.am 2617f77 src/authentication/cram_md5/authenticatee.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/authentication/cram_md5/auxprop.hpp PRE-CREATION src/authentication/cram_md5/auxprop.cpp PRE-CREATION src/master/master.hpp b1a2cd0 src/master/master.cpp 95589b8 src/sasl/authenticatee.hpp ec2c841 src/sasl/authenticator.hpp 6f4d3db src/sasl/auxprop.hpp 44e201b src/sasl/auxprop.cpp 6de1222 src/sched/sched.cpp e89e5e5 src/scheduler/scheduler.cpp fb88a3e src/slave/slave.hpp eb5de73 src/slave/slave.cpp 55e5264 src/tests/crammd5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 27122: Reorganized authentication implementation locations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/ --- (Updated Oct. 29, 2014, 1:43 p.m.) Review request for mesos, Adam B and Vinod Kone. Changes --- Addressed comments. Bugs: MESOS-1893 https://issues.apache.org/jira/browse/MESOS-1893 Repository: mesos-git Description (updated) --- For paving the way into further authentication mechanism implementations, the existing is reorganized. Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp to src/tests/cram_md5_authentication_tests.cpp. Adapt depending include paths. Rename specific test implementations from SASL to CRAMMD5Authentication. Rename sasl namespace to cram_md5 throughout all uses. Add missing license blob to auxprop.cpp. Diffs (updated) - src/Makefile.am f177d87 src/authentication/cram_md5/authenticatee.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/authentication/cram_md5/auxprop.hpp PRE-CREATION src/authentication/cram_md5/auxprop.cpp PRE-CREATION src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/sasl/authenticatee.hpp ec2c841 src/sasl/authenticator.hpp 6f4d3db src/sasl/auxprop.hpp 44e201b src/sasl/auxprop.cpp 6de1222 src/sched/sched.cpp 0fb8c7b src/scheduler/scheduler.cpp fb88a3e src/slave/slave.hpp eb5de73 src/slave/slave.cpp 96fb5f7 src/tests/cram_md5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 29, 2014, 3:03 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- Addressed comments. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs (updated) - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing (updated) --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
On Oct. 28, 2014, 11:49 p.m., Kapil Arya wrote: We added a new module kind but didn't add any new tests. Wouldn't it be better to move the authenticator example to the patch where we add the test case or the other way around? Yes, that split is a bit random in some cases (there are more). I would still like to leave it as is to allow for smaller chunks in the reviews and to minimize repatching certain areas over multiple commits. All cram-md5 authenticator patches have to be committed or none as noted above. On Oct. 28, 2014, 11:49 p.m., Kapil Arya wrote: src/authentication/authenticator.hpp, line 24 https://reviews.apache.org/r/26857/diff/5/?file=735280#file735280line24 Shouldn't we also explicitly include process/pid.h (although it is being included indirectly by process/future.hpp). Yes, well spotted. On Oct. 28, 2014, 11:49 p.m., Kapil Arya wrote: src/authentication/authenticator.hpp, lines 19-20 https://reviews.apache.org/r/26857/diff/5/?file=735280#file735280line19 Shouldn't this be __AUTHENTICATION_AUTHENTICATOR_HPP__ I would like to leave it as is, following the example of the isolator. I think our current rule does not use the folder name unless we need to disambiguate. On Oct. 28, 2014, 11:49 p.m., Kapil Arya wrote: src/examples/test_authenticator_module.cpp, lines 22-26 https://reviews.apache.org/r/26857/diff/5/?file=735282#file735282line22 The file module/authenticator.hpp is not part of this patch. Shouldn't it be removed from https://reviews.apache.org/r/26859/diff/# and added here? Also, alphabetize please. Yes, it slipped into the wrong RR. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review58909 --- On Oct. 29, 2014, 3:03 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 29, 2014, 3:03 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 27122: Reorganized authentication implementation locations.
On Oct. 28, 2014, 7:37 p.m., Kapil Arya wrote: src/authentication/cram_md5/authenticator.hpp, lines 19-20 https://reviews.apache.org/r/27122/diff/2/?file=733314#file733314line19 s/CRAMMD5/AUTHENTICATION_CRAM_MD5/ ? Till Toenshoff wrote: I find the idea of reversing the specification and the base interface rather unusual and it also would not fit our current scheme, e.g. ISOLATOR - MEM_ISOLATOR / SHARED_FILESYSTEM_ISOLATOR. Adding an extra underscore on the other hand should be fine. I actually mean __AUTHENTICATION_CRAM_MD5_AUTHENTICATOR_HPP__ to replace the existing one to allow the base directory name to be also part of the include guard. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/#review58910 --- On Oct. 29, 2014, 9:43 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/ --- (Updated Oct. 29, 2014, 9:43 a.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1893 https://issues.apache.org/jira/browse/MESOS-1893 Repository: mesos-git Description --- For paving the way into further authentication mechanism implementations, the existing is reorganized. Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp to src/tests/cram_md5_authentication_tests.cpp. Adapt depending include paths. Rename specific test implementations from SASL to CRAMMD5Authentication. Rename sasl namespace to cram_md5 throughout all uses. Add missing license blob to auxprop.cpp. Diffs - src/Makefile.am f177d87 src/authentication/cram_md5/authenticatee.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/authentication/cram_md5/auxprop.hpp PRE-CREATION src/authentication/cram_md5/auxprop.cpp PRE-CREATION src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/sasl/authenticatee.hpp ec2c841 src/sasl/authenticator.hpp 6f4d3db src/sasl/auxprop.hpp 44e201b src/sasl/auxprop.cpp 6de1222 src/sched/sched.cpp 0fb8c7b src/scheduler/scheduler.cpp fb88a3e src/slave/slave.hpp eb5de73 src/slave/slave.cpp 96fb5f7 src/tests/cram_md5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 29, 2014, 3:34 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- Fixed distcheck issue. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs (updated) - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 27295: os::killtree() supports case when root pid has exited.
On Oct. 28, 2014, 5:40 p.m., Vinod Kone wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp, line 161 https://reviews.apache.org/r/27295/diff/1/?file=735584#file735584line161 Don't you have to check that child is not already in queue because it might be added in #80 or #84? No, we mark visited pids on #145 so on #127 we'll just continue if the pid has already been visited, i.e., it's okay to add a pid we've already seen or is already in the queue. On Oct. 28, 2014, 5:40 p.m., Vinod Kone wrote: 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 682 https://reviews.apache.org/r/27295/diff/1/?file=735585#file735585line682 #669 seems to indicate that process could be none when we are here? why not have ASSERT_SOME(process) up there instead? Good catch but it's the isNone() that is erroneous. We wait for it to exit and become zombied so that we can then reap it. - Ian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/#review58845 --- On Oct. 28, 2014, 11:28 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/ --- (Updated Oct. 28, 2014, 11:28 a.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1875 https://issues.apache.org/jira/browse/MESOS-1875 Repository: mesos-git Description --- Improve os::killtree() for the case when the root pid has exited and it has been instructed to either follow process groups or sessions. It will now kill all processes (and their trees) with pgid or session matching the root pid. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp fa1950cc8849fcd81d425c651848e0566078 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e9f37dfd3cf54c3ca85d74716b3ee4262b065fad Diff: https://reviews.apache.org/r/27295/diff/ Testing --- Added a test where the root pid exits (and is reaped), leaving behind a reparented subtree. This test initially fails. + // -+- child exit 0 [new session and process group leader] + // -+- grandchild sleep 100 + // -+- great grandchild sleep 100 Thanks, Ian Downes
Re: Review Request 27295: os::killtree() supports case when root pid has exited.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/ --- (Updated Oct. 29, 2014, 10:18 a.m.) Review request for mesos, Ben Mahler and Vinod Kone. Changes --- Addressed Vinod's comments. Bugs: MESOS-1875 https://issues.apache.org/jira/browse/MESOS-1875 Repository: mesos-git Description --- Improve os::killtree() for the case when the root pid has exited and it has been instructed to either follow process groups or sessions. It will now kill all processes (and their trees) with pgid or session matching the root pid. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 0dc2871af7d8c6646080263c71f41db855d50be4 3rdparty/libprocess/3rdparty/stout/Makefile.am 7aac3fdb864e838cdd4e0d817ed4dff14923c69d 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 00a4edd0bcde3f92630fb173aeb4fff8e9139f77 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp fa1950cc8849fcd81d425c651848e0566078 3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e9f37dfd3cf54c3ca85d74716b3ee4262b065fad 3rdparty/libprocess/configure.ac 18eb681a5779b15cc5c7b7187ba5da8b4059c530 src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 src/linux/ns.hpp ec1a5171c8923d8661caabd0d73d5140bee4 src/slave/containerizer/isolators/namespaces/pid.hpp 7c40e7730e690e69a3bbef02a46ccb32ebc6badf src/slave/containerizer/isolators/namespaces/pid.cpp 5a13a6d1249a8aca416080bcb509b703cf48d244 src/slave/containerizer/isolators/network/port_mapping.cpp 14fae1f00050afbc6b99f4aabf868a2d75774b15 src/slave/containerizer/linux_launcher.cpp 10c12039cf684bef9398da72c3eceb9ed8b8b9c9 src/slave/containerizer/mesos/containerizer.cpp d4b08f54d6feb453f3a9d27ca54c867176e62102 src/tests/isolator_tests.cpp 4d03f46cbe20c0e7aff15bab0a26d7738b55aab9 src/tests/ns_tests.cpp 872009fbd5e48f74f7183da085d462fb4b7b61d0 src/tests/setns_test_helper.hpp c6bec95632f7426c76a02eaddbcedade85e17436 src/tests/setns_test_helper.cpp eb8746bd6e75323682d9dbbf989b65e30e3c1cda src/tests/slave_recovery_tests.cpp 98e059f33b2b9f552b0a091ded97f78c3b217d45 Diff: https://reviews.apache.org/r/27295/diff/ Testing --- Added a test where the root pid exits (and is reaped), leaving behind a reparented subtree. This test initially fails. + // -+- child exit 0 [new session and process group leader] + // -+- grandchild sleep 100 + // -+- great grandchild sleep 100 Thanks, Ian Downes
Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 29, 2014, 5:19 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- Addressed comments. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Enables selecting a module based authenticator via the new --authenticators flag for mesos master. Additionally, all have been fixed towards in master.hpp and master.cpp. Diffs (updated) - src/examples/test_authenticator_module.cpp PRE-CREATION src/master/flags.hpp c931fd9 src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/tests/cram_md5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing (updated) --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.
On Oct. 28, 2014, 11:58 p.m., Kapil Arya wrote:
src/master/master.cpp, lines 3879-3888
https://reviews.apache.org/r/26859/diff/6/?file=735286#file735286line3879
Here if the user specifies an invalid modulename but doesn't specify
the module with --modules, shouldn't we give a simple error that the
authenticator 'name' was not found?
Sth along the lines of :
} else if
(modules::ModuleManager::containsAuthenticator(authenticatorModules[0])) {
... ModuleManager::create ...
} else {
ERROR(invalid module)
}
Yes, always better to have deterministic error messages where possible. Thank
you! I did however move that check further up, into initialize as we can check
at that point already.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26859/#review58924
---
On Oct. 29, 2014, 5:19 p.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26859/
---
(Updated Oct. 29, 2014, 5:19 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
Enables selecting a module based authenticator via the new --authenticators
flag for mesos master.
Additionally, all have been fixed towards in master.hpp and
master.cpp.
Diffs
-
src/examples/test_authenticator_module.cpp PRE-CREATION
src/master/flags.hpp c931fd9
src/master/master.hpp b1a2cd0
src/master/master.cpp 762d2ff
src/tests/cram_md5_authentication_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26859/diff/
Testing
---
make check
NOTE all four CRAM-MD5 authenticator module related RRs need to get applied
before running make check.
Thanks,
Till Toenshoff
Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.
On Oct. 29, 2014, 12:18 a.m., Cody Maloney wrote: src/master/master.cpp, line 3912 https://reviews.apache.org/r/26859/diff/6/?file=735286#file735286line3912 All the right angle bracket fixes are nice, but the ones in chunks of code which aren't otherwise touched make the diff harder to read. Yes, I feared this would come up. I think that we won't touch all areas of this implementation for a lng time, hence I simply took the freedom to get it done now. On Oct. 29, 2014, 12:18 a.m., Cody Maloney wrote: src/module/authenticator.hpp, line 1 https://reviews.apache.org/r/26859/diff/6/?file=735287#file735287line1 This needs to be added to a Makefile.am so that distcheck will pass. Ow, great point - thanks a bunch! As this file should have been added in 26857, I will fix it there. On Oct. 29, 2014, 12:18 a.m., Cody Maloney wrote: src/master/master.cpp, line 3873 https://reviews.apache.org/r/26859/diff/6/?file=735286#file735286line3873 Since all this code only can load one authenticator module it would be good to check the authetnicatorModules argument only produces a list of length 1 max and warn / exit early. Currently extra arguments are silently ignored. Yes indeed. On Oct. 29, 2014, 12:18 a.m., Cody Maloney wrote: src/master/master.cpp, line 3876 https://reviews.apache.org/r/26859/diff/6/?file=735286#file735286line3876 This assuems crammd5 can only appear first in the list of authenticator modules. MESOS-1939 will fix this, as noted. On Oct. 29, 2014, 12:18 a.m., Cody Maloney wrote: src/master/master.cpp, line 3875 https://reviews.apache.org/r/26859/diff/6/?file=735286#file735286line3875 The strings::split() API makes this a lot more complicated than it should be. split of an empty string returning an empty vector I think would make more sense... But alas... I think it would make sense though to default the argument to a list of one element ['crammd5'] by default. Then you should just error if not --authenticator= is passed without listing any authenticators, rather than try to fall back. Ideally the error would list available authentication modules. Using a default makes much more sense, even though it complicates the flags description a little. Changed that accordingly - thank you!. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review58921 --- On Oct. 29, 2014, 5:19 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 29, 2014, 5:19 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Enables selecting a module based authenticator via the new --authenticators flag for mesos master. Additionally, all have been fixed towards in master.hpp and master.cpp. Diffs - src/examples/test_authenticator_module.cpp PRE-CREATION src/master/flags.hpp c931fd9 src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/tests/cram_md5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 27295: os::killtree() supports case when root pid has exited.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/ --- (Updated Oct. 29, 2014, 10:26 a.m.) Review request for mesos, Ben Mahler and Vinod Kone. Changes --- Rebased. Bugs: MESOS-1875 https://issues.apache.org/jira/browse/MESOS-1875 Repository: mesos-git Description --- Improve os::killtree() for the case when the root pid has exited and it has been instructed to either follow process groups or sessions. It will now kill all processes (and their trees) with pgid or session matching the root pid. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp fa1950cc8849fcd81d425c651848e0566078 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e9f37dfd3cf54c3ca85d74716b3ee4262b065fad Diff: https://reviews.apache.org/r/27295/diff/ Testing --- Added a test where the root pid exits (and is reaped), leaving behind a reparented subtree. This test initially fails. + // -+- child exit 0 [new session and process group leader] + // -+- grandchild sleep 100 + // -+- great grandchild sleep 100 Thanks, Ian Downes
Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/
---
(Updated Oct. 29, 2014, 5:39 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Changes
---
Updated to match changes in depending RRs.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
Example usage:
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.so\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]}
Diffs (updated)
-
src/tests/flags.hpp 2886e89
src/tests/mesos.cpp 2e8e39a
Diff: https://reviews.apache.org/r/26860/diff/
Testing
---
make check
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.dylib\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]} --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:16:14.764703 298631168 master.cpp:3874] Using
'org_apache_mesos_authenticator_crammd5' authenticator
bin/mesos-tests.sh --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5
authenticator
Thanks,
Till Toenshoff
Re: Review Request 27295: os::killtree() supports case when root pid has exited.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/#review59017 --- Ship it! Ship It! - Vinod Kone On Oct. 29, 2014, 5:26 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/ --- (Updated Oct. 29, 2014, 5:26 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1875 https://issues.apache.org/jira/browse/MESOS-1875 Repository: mesos-git Description --- Improve os::killtree() for the case when the root pid has exited and it has been instructed to either follow process groups or sessions. It will now kill all processes (and their trees) with pgid or session matching the root pid. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp fa1950cc8849fcd81d425c651848e0566078 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e9f37dfd3cf54c3ca85d74716b3ee4262b065fad Diff: https://reviews.apache.org/r/27295/diff/ Testing --- Added a test where the root pid exits (and is reaped), leaving behind a reparented subtree. This test initially fails. + // -+- child exit 0 [new session and process group leader] + // -+- grandchild sleep 100 + // -+- great grandchild sleep 100 Thanks, Ian Downes
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2502
https://issues.apache.org/jira/browse/MESOS-2007 -- Jiang Yan Xu y...@jxu.me @xujyan http://twitter.com/xujyan On Tue, Oct 28, 2014 at 4:49 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2502/changes Changes: [tstclair] Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess [idownes] Include tests/setns_test_helper.hpp in Makefile. -- [...truncated 12824 lines...] I1028 23:48:22.413159 31211 hierarchical_allocator_process.hpp:734] Offering cpus(*):2; mem(*):1024; disk(*):3.70122e+06; ports(*):[31000-32000] on slave 20141028-234822-3193029443-50043-31190-S0 to framework 20141028-234822-3193029443-50043-31190- I1028 23:48:22.413290 31208 replica.cpp:508] Replica received write request for position 4 I1028 23:48:22.413421 31211 hierarchical_allocator_process.hpp:679] Performed allocation for slave 20141028-234822-3193029443-50043-31190-S0 in 346658ns I1028 23:48:22.413650 31208 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 336067ns I1028 23:48:22.413668 31208 replica.cpp:676] Persisted action at 4 I1028 23:48:22.413797 31216 master.cpp:3795] Sending 1 offers to framework 20141028-234822-3193029443-50043-31190- (default) at scheduler-0aa33fc7-0d29-487c-80eb-f933681f9c95@67.195.81.190:50043 I1028 23:48:22.414077 31212 replica.cpp:655] Replica received learned notice for position 4 I1028 23:48:22.414356 31212 leveldb.cpp:343] Persisting action (18 bytes) to leveldb took 260401ns I1028 23:48:22.414403 31212 leveldb.cpp:401] Deleting ~2 keys from leveldb took 28541ns I1028 23:48:22.414417 31212 replica.cpp:676] Persisted action at 4 I1028 23:48:22.414446 31212 replica.cpp:661] Replica learned TRUNCATE action at position 4 I1028 23:48:22.414422 31207 sched.cpp:544] Scheduler::resourceOffers took 310278ns I1028 23:48:22.415086 31214 master.cpp:2321] Processing reply for offers: [ 20141028-234822-3193029443-50043-31190-O0 ] on slave 20141028-234822-3193029443-50043-31190-S0 at slave(34)@67.195.81.190:50043 (pietas.apache.org) for framework 20141028-234822-3193029443-50043-31190- (default) at scheduler-0aa33fc7-0d29-487c-80eb-f933681f9c95@67.195.81.190:50043 W1028 23:48:22.415163 31214 master.cpp:1969] Executor default for task 0 uses less CPUs (None) than the minimum required (0.01). Please update your executor, as this will be mandatory in future releases. W1028 23:48:22.415186 31214 master.cpp:1980] Executor default for task 0 uses less memory (None) than the minimum required (32MB). Please update your executor, as this will be mandatory in future releases. I1028 23:48:22.415256 31214 master.cpp:2417] Authorizing framework principal 'test-principal' to launch task 0 as user 'jenkins' I1028 23:48:22.416033 31219 master.hpp:877] Adding task 0 with resources cpus(*):1; mem(*):500 on slave 20141028-234822-3193029443-50043-31190-S0 ( pietas.apache.org) I1028 23:48:22.416084 31219 master.cpp:2480] Launching task 0 of framework 20141028-234822-3193029443-50043-31190- (default) at scheduler-0aa33fc7-0d29-487c-80eb-f933681f9c95@67.195.81.190:50043 with resources cpus(*):1; mem(*):500 on slave 20141028-234822-3193029443-50043-31190-S0 at slave(34)@67.195.81.190:50043 (pietas.apache.org) I1028 23:48:22.416317 31214 slave.cpp:1081] Got assigned task 0 for framework 20141028-234822-3193029443-50043-31190- I1028 23:48:22.416679 31215 hierarchical_allocator_process.hpp:563] Recovered cpus(*):1; mem(*):524; disk(*):3.70122e+06; ports(*):[31000-32000] (total allocatable: cpus(*):1; mem(*):524; disk(*):3.70122e+06; ports(*):[31000-32000]) on slave 20141028-234822-3193029443-50043-31190-S0 from framework 20141028-234822-3193029443-50043-31190- I1028 23:48:22.416721 31215 hierarchical_allocator_process.hpp:599] Framework 20141028-234822-3193029443-50043-31190- filtered slave 20141028-234822-3193029443-50043-31190-S0 for 5secs I1028 23:48:22.416724 31214 slave.cpp:1191] Launching task 0 for framework 20141028-234822-3193029443-50043-31190- I1028 23:48:22.418534 31214 slave.cpp:3871] Launching executor default of framework 20141028-234822-3193029443-50043-31190- in work directory '/tmp/AllocatorTest_0_SlaveReregistersFirst_QPPV21/slaves/20141028-234822-3193029443-50043-31190-S0/frameworks/20141028-234822-3193029443-50043-31190-/executors/default/runs/d593f433-3c16-4678-8f76-4038fe2841c4' I1028 23:48:22.420557 31214 exec.cpp:132] Version: 0.21.0 I1028 23:48:22.420755 31213 exec.cpp:182] Executor started at: executor(22)@67.195.81.190:50043 with pid 31190 I1028 23:48:22.420903 31214 slave.cpp:1317] Queuing task '0' for executor default of framework '20141028-234822-3193029443-50043-31190- I1028 23:48:22.420997 31214 slave.cpp:555] Successfully attached file
Re: Review Request 27295: os::killtree() supports case when root pid has exited.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/#review59019 --- Patch looks great! Reviews applied: [27295] All tests passed. - Mesos ReviewBot On Oct. 29, 2014, 5:26 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/ --- (Updated Oct. 29, 2014, 5:26 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1875 https://issues.apache.org/jira/browse/MESOS-1875 Repository: mesos-git Description --- Improve os::killtree() for the case when the root pid has exited and it has been instructed to either follow process groups or sessions. It will now kill all processes (and their trees) with pgid or session matching the root pid. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp fa1950cc8849fcd81d425c651848e0566078 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e9f37dfd3cf54c3ca85d74716b3ee4262b065fad Diff: https://reviews.apache.org/r/27295/diff/ Testing --- Added a test where the root pid exits (and is reaped), leaving behind a reparented subtree. This test initially fails. + // -+- child exit 0 [new session and process group leader] + // -+- grandchild sleep 100 + // -+- great grandchild sleep 100 Thanks, Ian Downes
Review Request 27341: Define MNT_DETACH for pid isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27341/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --- MNT_DETACH (since Linux 2.4.11) may not be defined in older sys/mount.h Diffs - src/slave/containerizer/isolators/namespaces/pid.cpp 5a13a6d1249a8aca416080bcb509b703cf48d244 Diff: https://reviews.apache.org/r/27341/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/#review59022
---
Bad patch!
Reviews applied: [27122, 26797, 27051, 26797, 26857, 27122]
Failed command: ./support/apply-review.sh -n -r 27122
Error:
2014-10-29 18:18:18 URL:https://reviews.apache.org/r/27122/diff/raw/
[90131/90131] - 27122.patch [1]
error: patch failed: src/Makefile.am:249
error: src/Makefile.am: patch does not apply
error: src/authentication/cram_md5/authenticatee.hpp: already exists in index
error: src/authentication/cram_md5/authenticator.hpp: already exists in index
error: src/authentication/cram_md5/auxprop.hpp: already exists in index
error: src/authentication/cram_md5/auxprop.cpp: already exists in index
error: patch failed: src/master/master.hpp:72
error: src/master/master.hpp: patch does not apply
error: patch failed: src/master/master.cpp:51
error: src/master/master.cpp: patch does not apply
error: src/sasl/authenticatee.hpp: does not exist in index
error: src/sasl/authenticator.hpp: does not exist in index
error: src/sasl/auxprop.hpp: does not exist in index
error: src/sasl/auxprop.cpp: does not exist in index
error: patch failed: src/sched/sched.cpp:59
error: src/sched/sched.cpp: patch does not apply
error: patch failed: src/scheduler/scheduler.cpp:53
error: src/scheduler/scheduler.cpp: patch does not apply
error: patch failed: src/slave/slave.hpp:70
error: src/slave/slave.hpp: patch does not apply
error: patch failed: src/slave/slave.cpp:62
error: src/slave/slave.cpp: patch does not apply
error: src/tests/cram_md5_authentication_tests.cpp: already exists in index
error: src/tests/sasl_tests.cpp: does not exist in index
Failed to apply patch
- Mesos ReviewBot
On Oct. 29, 2014, 5:39 p.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/
---
(Updated Oct. 29, 2014, 5:39 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
Example usage:
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.so\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]}
Diffs
-
src/tests/flags.hpp 2886e89
src/tests/mesos.cpp 2e8e39a
Diff: https://reviews.apache.org/r/26860/diff/
Testing
---
make check
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.dylib\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]} --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:16:14.764703 298631168 master.cpp:3874] Using
'org_apache_mesos_authenticator_crammd5' authenticator
bin/mesos-tests.sh --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5
authenticator
Thanks,
Till Toenshoff
Re: Review Request 27341: Define MNT_DETACH for pid isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27341/#review59024 --- Ship it! Ship It! - Vinod Kone On Oct. 29, 2014, 6:17 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27341/ --- (Updated Oct. 29, 2014, 6:17 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- MNT_DETACH (since Linux 2.4.11) may not be defined in older sys/mount.h Diffs - src/slave/containerizer/isolators/namespaces/pid.cpp 5a13a6d1249a8aca416080bcb509b703cf48d244 Diff: https://reviews.apache.org/r/27341/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/
---
(Updated Oct. 29, 2014, 6:50 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Changes
---
Fixed dependency list.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
Example usage:
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.so\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]}
Diffs
-
src/tests/flags.hpp 2886e89
src/tests/mesos.cpp 2e8e39a
Diff: https://reviews.apache.org/r/26860/diff/
Testing
---
make check
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.dylib\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]} --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:16:14.764703 298631168 master.cpp:3874] Using
'org_apache_mesos_authenticator_crammd5' authenticator
bin/mesos-tests.sh --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5
authenticator
Thanks,
Till Toenshoff
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 29, 2014, 6:51 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- Fixed dependency list. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 29, 2014, 6:51 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- Fixed dependency list. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Enables selecting a module based authenticator via the new --authenticators flag for mesos master. Additionally, all have been fixed towards in master.hpp and master.cpp. Diffs - src/examples/test_authenticator_module.cpp PRE-CREATION src/master/flags.hpp c931fd9 src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/tests/cram_md5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 25735: change const pass-by-value to const reference in stout
On Sept. 17, 2014, 4:32 p.m., Dominic Hamon wrote: I'm not convinced that this is necessarily the way we want to go, given the benefits of move semantics in modern compilers, but for consistency we can ship this until we have proof that performance favours the alternative. Kamil Domanski wrote: Isn't move construction more expensive than const reference? Dominic Hamon wrote: http://stackoverflow.com/questions/21605579/how-true-is-want-speed-pass-by-value copy, yes. move, no. maybe. ;) http://www.youtube.com/watch?v=xnqTKD8uD64#t=3145 - the current guidelines. Passing by value probably isn't what you want. If you want to get the extra win for r-value referenes you should add another overload, or accept via perfect forwarding. Also note GCC libstdc++ doesn't implement the C++11/C++14 std::string, so it is Copy on Write (C++89) which means that copies are a little cheaper than they would be otherwise. - Cody --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/#review53688 --- On Sept. 17, 2014, 2:25 p.m., Kamil Domanski wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/ --- (Updated Sept. 17, 2014, 2:25 p.m.) Review request for mesos. Bugs: MESOS-1805 https://issues.apache.org/jira/browse/MESOS-1805 Repository: mesos-git Description --- os::shell and an overload of strings::internal::fmt in stout pass a const string parameter by copy instead of reference. This patch fixes that. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 Diff: https://reviews.apache.org/r/25735/diff/ Testing --- cd 3rdparty/libprocess/3rdparty/ make check Thanks, Kamil Domanski
Re: Review Request 27341: Define MNT_DETACH for pid isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27341/#review59031 --- Patch looks great! Reviews applied: [27341] All tests passed. - Mesos ReviewBot On Oct. 29, 2014, 6:17 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27341/ --- (Updated Oct. 29, 2014, 6:17 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- MNT_DETACH (since Linux 2.4.11) may not be defined in older sys/mount.h Diffs - src/slave/containerizer/isolators/namespaces/pid.cpp 5a13a6d1249a8aca416080bcb509b703cf48d244 Diff: https://reviews.apache.org/r/27341/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 20423: Moved validation visitors out of master.cpp.
On Oct. 23, 2014, 12:46 p.m., Vinod Kone wrote: Why are some definitions in .hpp and some in .cpp? Why not all in .cpp? Also, it's not clear to me how this split would help in unit testing? AFAICT, all these visitors take Master or Framework or Slave which needs bringing up a cluster. Dominic Hamon wrote: They could be all in cpp, but some are so simple that being inlineable seemed beneficial. This is a first step. The Master/Slave/Frameworks passed in could be mock/stub versions that would support lightweight testing. The change also has a benefit in reducing the amount of code in the master source file, which helps with compile time and readability. Cody Maloney wrote: Things in cpp files can be inlined with LTO (Which is something I'd like to get functioning in Mesos tooling in in the long term). There isn't much code which includes the header, so the increase in compile time / object size from having more in the header isn't something I'm worried about in this case though, so net meh from me either way. Reducing code in master.cpp is definitely good, although most of the slowness compiling it comes from things it includes, not master.cpp itself. (Flags tends to be one of the worse offenders last time I did some investigation). Agreed on all points. The main concern for me is starting to tease apart master.cpp to make things more readable, more composable, and to start to adhere to the Single Responsibility Principle. As a side effect, we can start writing more focused unit testing rather than integration testing (ie, the validation steps can be tested in isolation rather than requiring a master/slave/framework to actually be running). This should help our test time and increase code coverage (in cases where we don't happen to test the validation, which is admittedly rare). - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20423/#review58071 --- On Oct. 23, 2014, 3:48 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20423/ --- (Updated Oct. 23, 2014, 3:48 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1064 https://issues.apache.org/jira/browse/MESOS-1064 Repository: mesos-git Description --- This is the first step toward being able to write independent unit tests for the validation visitors. It also uses Owned to make visitor cleanup simpler (non-existent). Diffs - 3rdparty/libprocess/include/process/timeout.hpp 0bf63e11a7a63b714aafb5386bf2d169260396ce src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 src/master/master.cpp 95589b8f25a3e496eabc0cf84319c883c1ed7aec src/master/offervisitor.hpp PRE-CREATION src/master/offervisitor.cpp PRE-CREATION src/master/taskinfovisitor.hpp PRE-CREATION src/master/taskinfovisitor.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 9f745d897119a814bd9f8e1b6a0ce5eaef60ed36 src/zookeeper/group.hpp 924613065521a72887a2721b3db89f448fa50900 Diff: https://reviews.apache.org/r/20423/diff/ Testing --- make check. ran Java test framework. Thanks, Dominic Hamon
Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/#review59035
---
Bad patch!
Reviews applied: [27122, 26857, 26859]
Failed command: ./support/apply-review.sh -n -r 26859
Error:
2014-10-29 19:35:50 URL:https://reviews.apache.org/r/26859/diff/raw/
[23191/23191] - 26859.patch [1]
error: patch failed: src/examples/test_authenticator_module.cpp:41
error: src/examples/test_authenticator_module.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Oct. 29, 2014, 6:50 p.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/
---
(Updated Oct. 29, 2014, 6:50 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
Example usage:
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.so\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]}
Diffs
-
src/tests/flags.hpp 2886e89
src/tests/mesos.cpp 2e8e39a
Diff: https://reviews.apache.org/r/26860/diff/
Testing
---
make check
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.dylib\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]} --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:16:14.764703 298631168 master.cpp:3874] Using
'org_apache_mesos_authenticator_crammd5' authenticator
bin/mesos-tests.sh --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5
authenticator
Thanks,
Till Toenshoff
Re: Review Request 27315: Updated scheduler driver to exponentially backoff during registration retries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/#review59034 --- src/sched/sched.cpp https://reviews.apache.org/r/27315/#comment100315 the two places this is referenced it is doubled. Please add a comment why or just store the doubled factor somewhere to simplify the readability of the code. src/sched/sched.cpp https://reviews.apache.org/r/27315/#comment100313 maybe set this on line 503 and then override if necessary. This ensures it is set and is clearer to read. src/sched/sched.cpp https://reviews.apache.org/r/27315/#comment100314 it looks like you derefence this everywhere.. so why did it need to become a pointer? Why not a concrete instance member variable? - Dominic Hamon On Oct. 28, 2014, 4:08 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/ --- (Updated Oct. 28, 2014, 4:08 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1903 https://issues.apache.org/jira/browse/MESOS-1903 Repository: mesos-git Description --- Uses the same backoff (except no initial backoff) strategy used by the slave during registration. Diffs - include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 src/local/constants.hpp PRE-CREATION src/local/constants.cpp PRE-CREATION src/local/flags.hpp 54e88319afc68007ff5d7c0d0179b685ef845c87 src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd Diff: https://reviews.apache.org/r/27315/diff/ Testing --- make check Thanks, Vinod Kone
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2229
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2229/changes Changes: [idownes] Define MNT_DETACH for pid isolator. -- [...truncated 69433 lines...] I1029 20:01:09.767547 27824 auxprop.cpp:103] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true I1029 20:01:09.767561 27824 authenticator.hpp:381] Authentication success I1029 20:01:09.767650 27824 authenticatee.hpp:310] Authentication success I1029 20:01:09.767752 27820 master.cpp:3893] Successfully authenticated principal 'test-principal' at scheduler-433d5fe0-5dd8-4eb7-96a1-75a171494d2f@67.195.81.190:41000 I1029 20:01:09.768019 27824 sched.cpp:357] Successfully authenticated with master master@67.195.81.190:41000 I1029 20:01:09.768048 27824 sched.cpp:476] Sending registration request to master@67.195.81.190:41000 I1029 20:01:09.768321 27820 master.cpp:1362] Received registration request for framework 'framework3' at scheduler-433d5fe0-5dd8-4eb7-96a1-75a171494d2f@67.195.81.190:41000 I1029 20:01:09.768384 27820 master.cpp:1321] Authorizing framework principal 'test-principal' to receive offers for role 'role3' I1029 20:01:09.768911 27823 master.cpp:1426] Registering framework 20141029-200107-3193029443-41000-27796-0002 (framework3) at scheduler-433d5fe0-5dd8-4eb7-96a1-75a171494d2f@67.195.81.190:41000 I1029 20:01:09.769162 27817 sched.cpp:407] Framework registered with 20141029-200107-3193029443-41000-27796-0002 I1029 20:01:09.769201 27817 sched.cpp:421] Scheduler::registered took 16443ns I1029 20:01:09.769261 27825 hierarchical_allocator_process.hpp:329] Added framework 20141029-200107-3193029443-41000-27796-0002 I1029 20:01:09.769722 27825 hierarchical_allocator_process.hpp:734] Offering cpus(role3):4; mem(role3):4096; disk(role3):0; ports(role3):[31000-32000] on slave 20141029-200107-3193029443-41000-27796-S2 to framework 20141029-200107-3193029443-41000-27796-0002 I1029 20:01:09.770187 27825 hierarchical_allocator_process.hpp:659] Performed allocation for 4 slaves in 903391ns I1029 20:01:09.770460 27819 master.cpp:3795] Sending 1 offers to framework 20141029-200107-3193029443-41000-27796-0002 (framework3) at scheduler-433d5fe0-5dd8-4eb7-96a1-75a171494d2f@67.195.81.190:41000 I1029 20:01:09.770774 27816 sched.cpp:544] Scheduler::resourceOffers took 45045ns I1029 20:01:09.772645 27796 containerizer.cpp:100] Using isolation: posix/cpu,posix/mem I1029 20:01:09.776811 27820 slave.cpp:169] Slave started on 221)@67.195.81.190:41000 I1029 20:01:09.776852 27820 credentials.hpp:84] Loading credential for authentication from '/tmp/ReservationAllocatorTest_ReservedResources_amUsCX/credential' I1029 20:01:09.777021 27820 slave.cpp:276] Slave using credential for: test-principal I1029 20:01:09.777241 27820 slave.cpp:289] Slave resources: cpus(role1):1; mem(role1):512; disk(role1):0; ports(role1):[31000-32000] I1029 20:01:09.777340 27820 slave.cpp:318] Slave hostname: pietas.apache.org I1029 20:01:09.777358 27820 slave.cpp:319] Slave checkpoint: false W1029 20:01:09.777366 27820 slave.cpp:321] Disabling checkpointing is deprecated and the --checkpoint flag will be removed in a future release. Please avoid using this flag I1029 20:01:09.778183 27811 state.cpp:33] Recovering state from '/tmp/ReservationAllocatorTest_ReservedResources_amUsCX/meta' I1029 20:01:09.778393 27817 status_update_manager.cpp:197] Recovering status update manager I1029 20:01:09.778676 27815 containerizer.cpp:281] Recovering containerizer I1029 20:01:09.779857 27816 slave.cpp:3456] Finished recovery I1029 20:01:09.780598 27816 slave.cpp:602] New master detected at master@67.195.81.190:41000 I1029 20:01:09.780638 27816 slave.cpp:665] Authenticating with master master@67.195.81.190:41000 I1029 20:01:09.780674 27825 status_update_manager.cpp:171] Pausing sending status updates I1029 20:01:09.780791 27816 slave.cpp:638] Detecting new master I1029 20:01:09.780843 27818 authenticatee.hpp:133] Creating new client SASL connection I1029 20:01:09.781141 27810 master.cpp:3853] Authenticating slave(221)@67.195.81.190:41000 I1029 20:01:09.781342 27816 authenticator.hpp:161] Creating new server SASL connection I1029 20:01:09.781508 27816 authenticatee.hpp:224] Received SASL authentication mechanisms: CRAM-MD5 I1029 20:01:09.781529 27816 authenticatee.hpp:250] Attempting to authenticate with mechanism 'CRAM-MD5' I1029 20:01:09.781632 27824 authenticator.hpp:267] Received SASL authentication start I1029 20:01:09.781687 27824 authenticator.hpp:389] Authentication requires more steps I1029 20:01:09.781771 27824 authenticatee.hpp:270] Received SASL authentication step I1029 20:01:09.781875 27824 authenticator.hpp:295] Received SASL authentication step I1029 20:01:09.781903 27824 auxprop.cpp:81] Request to lookup properties for user: 'test-principal' realm: 'pietas.apache.org' server FQDN: 'pietas.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false
new dependencies
Hello I noticed this week that new dependencies have been added to Mesos: libapr1 and libsubversion. A good practice would be to have changes like this, that impact the developer community broadly, be more widely communicated. I don't think either of these libraries are unavailable for our target platforms, but other dependencies we might add might be. Or the versions required might be incompatible. Either way, I think it's important that we are clear when adding a dependency both what is being added, and why. In that spirit, I'll ask why these libraries were chosen specifically, and what factors were considered when adding them (as opposed to other libraries, implementing features ourselves, etc). Thanks! -- Dominic Hamon | @mrdo | Twitter *There are no bad ideas; only good ideas that go horribly wrong.*
Re: Review Request 27054: Libprocess Socket: introduce connect()
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27054/#review58907
---
3rdparty/libprocess/include/process/socket.hpp
https://reviews.apache.org/r/27054/#comment100075
We name our enumerations like constants, and we name our constants in
capital letters, like macros. See:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Enumerator_Names
(but note that we don't use the 'k' prefix style for naming, which was only
recently accepted for enumerations in the Google Style Guide).
Check out other examples in the code base too.
3rdparty/libprocess/include/process/socket.hpp
https://reviews.apache.org/r/27054/#comment100076
{ on newline please.
3rdparty/libprocess/include/process/socket.hpp
https://reviews.apache.org/r/27054/#comment100078
This should be virtual, no?
3rdparty/libprocess/include/process/socket.hpp
https://reviews.apache.org/r/27054/#comment100147
We've put friend declarations at the top of the private section because, if
you're not a friend, you have no reason to read below that line! ;-)
In all seriousness, the rationale here is exactly the same reasoning for
why we order public, protected, then private: the class declaration acts as
documentation, and most people care about the public members of the class first.
3rdparty/libprocess/src/process.cpp
https://reviews.apache.org/r/27054/#comment100150
I'd like us to call this struct Connect instead of AsyncConnect since this
will not be the first time that we have to create a struct for holding data
across continuations and it would be great to set a precedent for naming
continuation data. That is, this is a fundamental pattern that we'll replicate.
So in the future, we can have an internal::Write which we know maps to a
'write' continuation, etc. Sound good?
3rdparty/libprocess/src/process.cpp
https://reviews.apache.org/r/27054/#comment100151
Let's stay consistent with how we label our continuations:
s/async_receiving_connect/_connect/.
- Benjamin Hindman
On Oct. 29, 2014, 5:18 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27054/
---
(Updated Oct. 29, 2014, 5:18 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Bugs: MESOS-1330
https://issues.apache.org/jira/browse/MESOS-1330
Repository: mesos-git
Description
---
Introduce the connect(const Node node) call to Socket. Use it in link() and
send().
Diffs
-
3rdparty/libprocess/include/process/socket.hpp 6683881
3rdparty/libprocess/src/process.cpp 85fb995
Diff: https://reviews.apache.org/r/27054/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
Re: Review Request 27054: Libprocess Socket: introduce connect()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/#review59042 --- 3rdparty/libprocess/include/process/socket.hpp https://reviews.apache.org/r/27054/#comment100324 not without a check in configure, you don't :) 3rdparty/libprocess/include/process/socket.hpp https://reviews.apache.org/r/27054/#comment100325 needs a check in configure. - Dominic Hamon On Oct. 28, 2014, 10:18 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 28, 2014, 10:18 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Bugs: MESOS-1330 https://issues.apache.org/jira/browse/MESOS-1330 Repository: mesos-git Description --- Introduce the connect(const Node node) call to Socket. Use it in link() and send(). Diffs - 3rdparty/libprocess/include/process/socket.hpp 6683881 3rdparty/libprocess/src/process.cpp 85fb995 Diff: https://reviews.apache.org/r/27054/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 26382: Add source and reason to TaskStatus.
On Oct. 24, 2014, 11:08 a.m., Vinod Kone wrote: include/mesos/mesos.proto, line 636 https://reviews.apache.org/r/26382/diff/7/?file=727940#file727940line636 I think this will become a crutch. We should know the reasons for why a task is lost. i.e., kill this. Dominic Hamon wrote: it still might be 'unknown' in cases where the caller doesn't set the reason. is that acceptable? Vinod Kone wrote: the caller is mesos code (master, slave) which should always know the reason. do you have an example? the interface to create the status update should be optional for things like TASK_KILLED or TASK_STAGING (see reconciliation) when there is no reason per se. On Oct. 24, 2014, 11:08 a.m., Vinod Kone wrote: src/common/http.cpp, line 103 https://reviews.apache.org/r/26382/diff/7/?file=727941#file727941line103 what happens if this is not set? Dominic Hamon wrote: nothing - i thought it was a useful thing to export in the JSON model though. Vinod Kone wrote: nothing, as in empty? or does it return a default source (enum 0)? if it's the latter it's a problem. you should guard this statement with status.has_source(). sorry, i thought you meant if the key wasn't set in values. either way, i've removed this from the JSON as it's not really adding anything for this change. - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/#review58174 --- On Oct. 29, 2014, 1:45 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 29, 2014, 1:45 p.m.) Review request for mesos, Vinod Kone and Bill Farner. Bugs: MESOS-1830 and MESOS-343 https://issues.apache.org/jira/browse/MESOS-1830 https://issues.apache.org/jira/browse/MESOS-343 Repository: mesos-git Description --- Added source and reason, enabled TASK_ERROR, and made the changes necessary throughout the codebase. Diffs - include/mesos/mesos.proto 168a7a8c35ed1bf3f5bd6d7431b1e511bae7b789 src/common/protobuf_utils.hpp 212d5124b9a4cc58e61719fa7f07a61cd166e834 src/common/protobuf_utils.cpp a9b65e328c4c62bff7fbf5633dda25d742d79019 src/examples/balloon_framework.cpp b05d5679fe2915142907af0b2dc00c6cd76eb9c1 src/examples/java/TestFramework.java bc593d0abfacb00690b1492b2b82c970f4e4de6d src/examples/low_level_scheduler_libprocess.cpp 7ef5ea78ade4ed856b97009fdfe31281f0a55c17 src/examples/low_level_scheduler_pthread.cpp 6e233a10117a1c7aa669806b5b430e746e227ee5 src/examples/no_executor_framework.cpp f98a0735b9f287e7f1bf98af6c2e9a47ca6a77b2 src/examples/test_framework.cpp 187a611ebfe35cb13ee48aa5eca934cf55f34dea src/master/master.cpp 762d2ff6c168ac212f70b43275692a77496a7fcd src/scaling/nested_exec.py 17e61706c75e6e849b0c40ae5232d8dc60804c55 src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/slave/slave.cpp 96fb5f7385b0762d46d8129f7e43207bd6311644 src/tests/common/http_tests.cpp 912653b26615c86cc0204d80f58e6046c4b91a98 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd src/tests/master_authorization_tests.cpp 652e80d0d4567b225c6ffb326725ddfde06f7fd3 src/tests/master_tests.cpp 2e525749247626c05efb2f54a707599facb114b6 src/tests/reconciliation_tests.cpp 4ba53940951584d9baa2c7aa4e124814471206bc src/tests/resource_offers_tests.cpp fe66432b1bf75ee25feb73c4bb353e4d4e5b503f Diff: https://reviews.apache.org/r/26382/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 26382: Add source and reason to TaskStatus.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 29, 2014, 1:45 p.m.) Review request for mesos, Vinod Kone and Bill Farner. Bugs: MESOS-1830 and MESOS-343 https://issues.apache.org/jira/browse/MESOS-1830 https://issues.apache.org/jira/browse/MESOS-343 Repository: mesos-git Description --- Added source and reason, enabled TASK_ERROR, and made the changes necessary throughout the codebase. Diffs (updated) - include/mesos/mesos.proto 168a7a8c35ed1bf3f5bd6d7431b1e511bae7b789 src/common/protobuf_utils.hpp 212d5124b9a4cc58e61719fa7f07a61cd166e834 src/common/protobuf_utils.cpp a9b65e328c4c62bff7fbf5633dda25d742d79019 src/examples/balloon_framework.cpp b05d5679fe2915142907af0b2dc00c6cd76eb9c1 src/examples/java/TestFramework.java bc593d0abfacb00690b1492b2b82c970f4e4de6d src/examples/low_level_scheduler_libprocess.cpp 7ef5ea78ade4ed856b97009fdfe31281f0a55c17 src/examples/low_level_scheduler_pthread.cpp 6e233a10117a1c7aa669806b5b430e746e227ee5 src/examples/no_executor_framework.cpp f98a0735b9f287e7f1bf98af6c2e9a47ca6a77b2 src/examples/test_framework.cpp 187a611ebfe35cb13ee48aa5eca934cf55f34dea src/master/master.cpp 762d2ff6c168ac212f70b43275692a77496a7fcd src/scaling/nested_exec.py 17e61706c75e6e849b0c40ae5232d8dc60804c55 src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/slave/slave.cpp 96fb5f7385b0762d46d8129f7e43207bd6311644 src/tests/common/http_tests.cpp 912653b26615c86cc0204d80f58e6046c4b91a98 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd src/tests/master_authorization_tests.cpp 652e80d0d4567b225c6ffb326725ddfde06f7fd3 src/tests/master_tests.cpp 2e525749247626c05efb2f54a707599facb114b6 src/tests/reconciliation_tests.cpp 4ba53940951584d9baa2c7aa4e124814471206bc src/tests/resource_offers_tests.cpp fe66432b1bf75ee25feb73c4bb353e4d4e5b503f Diff: https://reviews.apache.org/r/26382/diff/ Testing --- make check Thanks, Dominic Hamon
Re: new dependencies
Hi Dominic, Thanks for the email, sorry I was thinking about writing an email to the list about the new dependencies but didn't get to it. I'll let BenH talk about why he used libsvn (libapr is a dependency for libsvn) for implementing diffs. I've updated the getting-started.md doc as part of the patch to look for libsvn and libapr headers, about instructions for CentOS and Ubuntu. For Mac OSX users, you can find subversion in the homebrew/versions tap and apr in the homebrew/apache tap. The only caveat is to either symlink the include header folders from /usr/local/Cellar folders to usr/include, or specify the directories with --with-apr and --with-svn flags to configure. Thanks! Tim On Wed, Oct 29, 2014 at 1:29 PM, Dominic Hamon dha...@twopensource.com wrote: Hello I noticed this week that new dependencies have been added to Mesos: libapr1 and libsubversion. A good practice would be to have changes like this, that impact the developer community broadly, be more widely communicated. I don't think either of these libraries are unavailable for our target platforms, but other dependencies we might add might be. Or the versions required might be incompatible. Either way, I think it's important that we are clear when adding a dependency both what is being added, and why. In that spirit, I'll ask why these libraries were chosen specifically, and what factors were considered when adding them (as opposed to other libraries, implementing features ourselves, etc). Thanks! -- Dominic Hamon | @mrdo | Twitter *There are no bad ideas; only good ideas that go horribly wrong.*
Re: Review Request 26382: Add source and reason to TaskStatus.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/#review59045 --- Patch looks great! Reviews applied: [26817, 26382] All tests passed. - Mesos ReviewBot On Oct. 29, 2014, 8:45 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 29, 2014, 8:45 p.m.) Review request for mesos, Vinod Kone and Bill Farner. Bugs: MESOS-1830 and MESOS-343 https://issues.apache.org/jira/browse/MESOS-1830 https://issues.apache.org/jira/browse/MESOS-343 Repository: mesos-git Description --- Added source and reason, enabled TASK_ERROR, and made the changes necessary throughout the codebase. Diffs - include/mesos/mesos.proto 168a7a8c35ed1bf3f5bd6d7431b1e511bae7b789 src/common/protobuf_utils.hpp 212d5124b9a4cc58e61719fa7f07a61cd166e834 src/common/protobuf_utils.cpp a9b65e328c4c62bff7fbf5633dda25d742d79019 src/examples/balloon_framework.cpp b05d5679fe2915142907af0b2dc00c6cd76eb9c1 src/examples/java/TestFramework.java bc593d0abfacb00690b1492b2b82c970f4e4de6d src/examples/low_level_scheduler_libprocess.cpp 7ef5ea78ade4ed856b97009fdfe31281f0a55c17 src/examples/low_level_scheduler_pthread.cpp 6e233a10117a1c7aa669806b5b430e746e227ee5 src/examples/no_executor_framework.cpp f98a0735b9f287e7f1bf98af6c2e9a47ca6a77b2 src/examples/test_framework.cpp 187a611ebfe35cb13ee48aa5eca934cf55f34dea src/master/master.cpp 762d2ff6c168ac212f70b43275692a77496a7fcd src/scaling/nested_exec.py 17e61706c75e6e849b0c40ae5232d8dc60804c55 src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/slave/slave.cpp 96fb5f7385b0762d46d8129f7e43207bd6311644 src/tests/common/http_tests.cpp 912653b26615c86cc0204d80f58e6046c4b91a98 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd src/tests/master_authorization_tests.cpp 652e80d0d4567b225c6ffb326725ddfde06f7fd3 src/tests/master_tests.cpp 2e525749247626c05efb2f54a707599facb114b6 src/tests/reconciliation_tests.cpp 4ba53940951584d9baa2c7aa4e124814471206bc src/tests/resource_offers_tests.cpp fe66432b1bf75ee25feb73c4bb353e4d4e5b503f Diff: https://reviews.apache.org/r/26382/diff/ Testing --- make check Thanks, Dominic Hamon
Review Request 27350: Libprocess: Introduce mutex configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27350/ --- Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2009 https://issues.apache.org/jira/browse/MESOS-2009 Repository: mesos-git Description --- Introduce mutex to the configure check for Libprocess Diffs - 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 Diff: https://reviews.apache.org/r/27350/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27054: Libprocess Socket: introduce connect()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 29, 2014, 9:47 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Changes --- Depends on mutex configure check for libprocess. Bugs: MESOS-1330 https://issues.apache.org/jira/browse/MESOS-1330 Repository: mesos-git Description --- Introduce the connect(const Node node) call to Socket. Use it in link() and send(). Diffs - 3rdparty/libprocess/include/process/socket.hpp 6683881 3rdparty/libprocess/src/process.cpp 85fb995 Diff: https://reviews.apache.org/r/27054/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 27350: Libprocess: Introduce mutex configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27350/#review59050 --- Ship it! Great! I'll let Ben determine if we want to move the entire codebase over to std::mutex. - Dominic Hamon On Oct. 29, 2014, 2:45 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27350/ --- (Updated Oct. 29, 2014, 2:45 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2009 https://issues.apache.org/jira/browse/MESOS-2009 Repository: mesos-git Description --- Introduce mutex to the configure check for Libprocess Diffs - 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 Diff: https://reviews.apache.org/r/27350/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2010 https://issues.apache.org/jira/browse/MESOS-2010 Repository: mesos-git Description --- Introduce enable_shared_from_this to the configure check for Libprocess Diffs - 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 Diff: https://reviews.apache.org/r/27351/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/#review59053 --- 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 https://reviews.apache.org/r/27351/#comment100330 can you add a comment introducing the scope of this test? (ie, check for std::enable_shared_from_this). 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 https://reviews.apache.org/r/27351/#comment100329 s/sharedStruct/SharedStruct/g - Dominic Hamon On Oct. 29, 2014, 3:02 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- (Updated Oct. 29, 2014, 3:02 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2010 https://issues.apache.org/jira/browse/MESOS-2010 Repository: mesos-git Description --- Introduce enable_shared_from_this to the configure check for Libprocess Diffs - 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 Diff: https://reviews.apache.org/r/27351/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- (Updated Oct. 29, 2014, 10:23 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Changes --- Add comment for scope. Rename struct. Bugs: MESOS-2010 https://issues.apache.org/jira/browse/MESOS-2010 Repository: mesos-git Description --- Introduce enable_shared_from_this to the configure check for Libprocess Diffs (updated) - 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 Diff: https://reviews.apache.org/r/27351/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27091: Move Linux namespace functions into linux/.
On Oct. 23, 2014, 6:58 p.m., Ben Mahler wrote: src/linux/ns.hpp, line 65 https://reviews.apache.org/r/27091/diff/2/?file=731817#file731817line65 s/ns/namespace/ for the argument I'd like to avoid using the reserved word 'namespace' in code, event for argument names. On Oct. 23, 2014, 6:58 p.m., Ben Mahler wrote: src/linux/ns.hpp, line 119 https://reviews.apache.org/r/27091/diff/2/?file=731817#file731817line119 s/ns/namespace/ for the argument I'd like to avoid using the reserved word 'namespace' in code, event for argument names. On Oct. 23, 2014, 6:58 p.m., Ben Mahler wrote: src/linux/ns.hpp, lines 63-65 https://reviews.apache.org/r/27091/diff/2/?file=731817#file731817line63 Looks like this can be hidden in an 'internal' namespace? Ideally yes, but it's used in tests. - Ian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27091/#review58201 --- On Oct. 24, 2014, 2:53 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27091/ --- (Updated Oct. 24, 2014, 2:53 p.m.) Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Description --- A following commit will remove this code from stout. Diffs - src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 src/linux/ns.hpp PRE-CREATION src/slave/containerizer/isolators/network/port_mapping.cpp 62ca9bca08de55f19bfff7b8828dfa4fb6c51f30 src/tests/ns_tests.cpp PRE-CREATION src/tests/setns_test_helper.hpp PRE-CREATION src/tests/setns_test_helper.cpp PRE-CREATION Diff: https://reviews.apache.org/r/27091/diff/ Testing --- make check Thanks, Ian Downes
Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/#review59057 --- Ship it! I don't know that it's necessary given the architecture we use and how we use shared_ptr, but i'll let Ben determine that. The configure check itself looks good. - Dominic Hamon On Oct. 29, 2014, 3:23 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- (Updated Oct. 29, 2014, 3:23 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2010 https://issues.apache.org/jira/browse/MESOS-2010 Repository: mesos-git Description --- Introduce enable_shared_from_this to the configure check for Libprocess Diffs - 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 Diff: https://reviews.apache.org/r/27351/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Review Request 27353: Clean up code for linux namespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27353/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --- Deferred cleanup from https://reviews.apache.org/r/27091/ Remove naming redundancy, e.g., ns::setns() - ns::set(). Add ns::supported(string) helper. Diffs - src/linux/ns.hpp ec1a5171c8923d8661caabd0d73d5140bee4 src/slave/containerizer/isolators/namespaces/pid.cpp edfb1f64fb535d826886922788d95d0850f49b3e src/slave/containerizer/isolators/network/port_mapping.cpp 14fae1f00050afbc6b99f4aabf868a2d75774b15 src/tests/isolator_tests.cpp 4d03f46cbe20c0e7aff15bab0a26d7738b55aab9 src/tests/ns_tests.cpp 046ea26701f346399f4bc31a5c9491325e8bd93f src/tests/setns_test_helper.cpp eb8746bd6e75323682d9dbbf989b65e30e3c1cda Diff: https://reviews.apache.org/r/27353/diff/ Testing --- make check Thanks, Ian Downes
Re: Review Request 27054: Libprocess Socket: introduce connect()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/#review59063 --- Patch looks great! Reviews applied: [27350, 27023, 27054] All tests passed. - Mesos ReviewBot On Oct. 29, 2014, 9:47 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 29, 2014, 9:47 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Bugs: MESOS-1330 https://issues.apache.org/jira/browse/MESOS-1330 Repository: mesos-git Description --- Introduce the connect(const Node node) call to Socket. Use it in link() and send(). Diffs - 3rdparty/libprocess/include/process/socket.hpp 6683881 3rdparty/libprocess/src/process.cpp 85fb995 Diff: https://reviews.apache.org/r/27054/diff/ Testing --- make check Thanks, Joris Van Remoortere
Review Request 27354: Introduce mutex configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27354/ --- Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2011 https://issues.apache.org/jira/browse/MESOS-2011 Repository: mesos-git Description --- * Introduce mutex to the configure check * Document availability of mutex in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27354/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27054: Libprocess Socket: introduce connect()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 29, 2014, 10:42 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Changes --- Depends on enable_shared_from_this configure check for libprocess. Bugs: MESOS-1330 https://issues.apache.org/jira/browse/MESOS-1330 Repository: mesos-git Description --- Introduce the connect(const Node node) call to Socket. Use it in link() and send(). Diffs - 3rdparty/libprocess/include/process/socket.hpp 6683881 3rdparty/libprocess/src/process.cpp 85fb995 Diff: https://reviews.apache.org/r/27054/diff/ Testing --- make check Thanks, Joris Van Remoortere
Review Request 27356: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 25735: change const pass-by-value to const reference in stout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/#review59068 --- We can't make these `const-ref` unfortunately because the second argument of `va_start` cannot be a reference type. N3797: 18.10 Other runtime support [support.runtime] The restrictions that ISO C places on the second parameter to the va_start() macro in header stdarg.h are different in this International Standard. The parameter parmN is the identifier of the rightmost parameter in the variable parameter list of the function definition (the one just before the ...). __If the parameter parmN is of a reference type, or of a type that is not compatible with the type that results when passing an argument for which there is no parameter, the behavior is undefined.__ - Michael Park On Sept. 17, 2014, 2:25 p.m., Kamil Domanski wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/ --- (Updated Sept. 17, 2014, 2:25 p.m.) Review request for mesos. Bugs: MESOS-1805 https://issues.apache.org/jira/browse/MESOS-1805 Repository: mesos-git Description --- os::shell and an overload of strings::internal::fmt in stout pass a const string parameter by copy instead of reference. This patch fixes that. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 Diff: https://reviews.apache.org/r/25735/diff/ Testing --- cd 3rdparty/libprocess/3rdparty/ make check Thanks, Kamil Domanski
Re: Review Request 27315: Updated scheduler driver to exponentially backoff during registration retries.
On Oct. 29, 2014, 2:43 a.m., Cody Maloney wrote: src/sched/sched.cpp, line 506 https://reviews.apache.org/r/27315/diff/1/?file=736571#file736571line506 maxBackoff is never set if duration.isNone. good catch! thanks. fixed. On Oct. 29, 2014, 2:43 a.m., Cody Maloney wrote: include/mesos/scheduler.hpp, line 443 https://reviews.apache.org/r/27315/diff/1/?file=736566#file736566line443 It would be more precise to use an Optional here rather than write the rules/semantics (if I'm reading the rest of the code correctly) into a pointer. Also means we don't have to manually clean up in the destructor. i restructured the code and this is n/a. On Oct. 29, 2014, 2:43 a.m., Cody Maloney wrote: src/sched/sched.cpp, line 519 https://reviews.apache.org/r/27315/diff/1/?file=736571#file736571line519 It would be nice to use random here (The headers at least are around in gcc 4.4). Doing this sort of math creates significantly biased randon numbers. added a TODO for now. i can fix it here and in slave in a subsequent review. On Oct. 29, 2014, 2:43 a.m., Cody Maloney wrote: src/sched/sched.cpp, line 522 https://reviews.apache.org/r/27315/diff/1/?file=736571#file736571line522 nextDuration/durationNext would be a more descriptive variable name. i'll leave it as is for consistency with the naming in slave. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/#review58951 --- On Oct. 28, 2014, 11:08 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/ --- (Updated Oct. 28, 2014, 11:08 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1903 https://issues.apache.org/jira/browse/MESOS-1903 Repository: mesos-git Description --- Uses the same backoff (except no initial backoff) strategy used by the slave during registration. Diffs - include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 src/local/constants.hpp PRE-CREATION src/local/constants.cpp PRE-CREATION src/local/flags.hpp 54e88319afc68007ff5d7c0d0179b685ef845c87 src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd Diff: https://reviews.apache.org/r/27315/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 27315: Updated scheduler driver to exponentially backoff during registration retries.
On Oct. 29, 2014, 7:36 p.m., Dominic Hamon wrote: src/sched/sched.cpp, line 1089 https://reviews.apache.org/r/27315/diff/1/?file=736571#file736571line1089 it looks like you derefence this everywhere.. so why did it need to become a pointer? Why not a concrete instance member variable? n/a after the restructure. On Oct. 29, 2014, 7:36 p.m., Dominic Hamon wrote: src/sched/sched.cpp, line 255 https://reviews.apache.org/r/27315/diff/1/?file=736571#file736571line255 the two places this is referenced it is doubled. Please add a comment why or just store the doubled factor somewhere to simplify the readability of the code. actually, no need for the double. i just copy pasted from slave code but didn't realize that the semantics are slightly different for driver, i.e., the first retry is tried between [0, b] instead of [0, 2b]. fixed. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/#review59034 --- On Oct. 28, 2014, 11:08 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/ --- (Updated Oct. 28, 2014, 11:08 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1903 https://issues.apache.org/jira/browse/MESOS-1903 Repository: mesos-git Description --- Uses the same backoff (except no initial backoff) strategy used by the slave during registration. Diffs - include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 src/local/constants.hpp PRE-CREATION src/local/constants.cpp PRE-CREATION src/local/flags.hpp 54e88319afc68007ff5d7c0d0179b685ef845c87 src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd Diff: https://reviews.apache.org/r/27315/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 27315: Updated scheduler driver to exponentially backoff during registration retries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/ --- (Updated Oct. 29, 2014, 11:16 p.m.) Review request for mesos and Ben Mahler. Changes --- After discussing w/ BenM, decided to move the constants and flags to src/sched directory instead of src/local to be more precise. Note that the new (event/call) driver in src/scheduler doesn't do reliable registration, so there are no updates to it. Bugs: MESOS-1903 https://issues.apache.org/jira/browse/MESOS-1903 Repository: mesos-git Description --- Uses the same backoff (except no initial backoff) strategy used by the slave during registration. Diffs (updated) - src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 src/sched/constants.hpp PRE-CREATION src/sched/constants.cpp PRE-CREATION src/sched/flags.hpp PRE-CREATION src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd Diff: https://reviews.apache.org/r/27315/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 27122: Reorganized authentication implementation locations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/#review59069 --- Ship it! Looks great! I can make these changes and commit it for you (unless somebody objects soon). src/authentication/cram_md5/authenticatee.hpp https://reviews.apache.org/r/27122/#comment100343 Could do __AUTHENTICATION_CRAM_MD5_AUTHENTICATEE_HPP__ as Kapil mentioned, to get the parent directory in there too. We skip it for some of the super redundant ones, like src/files/files.hpp or src/messages/messages.hpp, but it's probably better to be more explicit to prevent awkward collisions in the future. src/authentication/cram_md5/authenticator.hpp https://reviews.apache.org/r/27122/#comment100344 __AUTHENTICATION_CRAM_MD5_AUTHENTICATOR_HPP__? src/authentication/cram_md5/auxprop.hpp https://reviews.apache.org/r/27122/#comment100346 __AUTHENTICATION_CRAM_MD5_AUXPROP_HPP__? src/master/master.cpp https://reviews.apache.org/r/27122/#comment100348 into CRAM-MD5 Authenticator - Adam B On Oct. 29, 2014, 6:43 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/ --- (Updated Oct. 29, 2014, 6:43 a.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1893 https://issues.apache.org/jira/browse/MESOS-1893 Repository: mesos-git Description --- For paving the way into further authentication mechanism implementations, the existing is reorganized. Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp to src/tests/cram_md5_authentication_tests.cpp. Adapt depending include paths. Rename specific test implementations from SASL to CRAMMD5Authentication. Rename sasl namespace to cram_md5 throughout all uses. Add missing license blob to auxprop.cpp. Diffs - src/Makefile.am f177d87 src/authentication/cram_md5/authenticatee.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/authentication/cram_md5/auxprop.hpp PRE-CREATION src/authentication/cram_md5/auxprop.cpp PRE-CREATION src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/sasl/authenticatee.hpp ec2c841 src/sasl/authenticator.hpp 6f4d3db src/sasl/auxprop.hpp 44e201b src/sasl/auxprop.cpp 6de1222 src/sched/sched.cpp 0fb8c7b src/scheduler/scheduler.cpp fb88a3e src/slave/slave.hpp eb5de73 src/slave/slave.cpp 96fb5f7 src/tests/cram_md5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 27315: Updated scheduler driver to exponentially backoff during registration retries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/#review59075 --- LGTM - Cody Maloney On Oct. 29, 2014, 11:16 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/ --- (Updated Oct. 29, 2014, 11:16 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1903 https://issues.apache.org/jira/browse/MESOS-1903 Repository: mesos-git Description --- Uses the same backoff (except no initial backoff) strategy used by the slave during registration. Diffs - src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 src/sched/constants.hpp PRE-CREATION src/sched/constants.cpp PRE-CREATION src/sched/flags.hpp PRE-CREATION src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd Diff: https://reviews.apache.org/r/27315/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 27353: Clean up code for linux namespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27353/#review59077 --- Patch looks great! Reviews applied: [27353] All tests passed. - Mesos ReviewBot On Oct. 29, 2014, 10:26 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27353/ --- (Updated Oct. 29, 2014, 10:26 p.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- Deferred cleanup from https://reviews.apache.org/r/27091/ Remove naming redundancy, e.g., ns::setns() - ns::set(). Add ns::supported(string) helper. Diffs - src/linux/ns.hpp ec1a5171c8923d8661caabd0d73d5140bee4 src/slave/containerizer/isolators/namespaces/pid.cpp edfb1f64fb535d826886922788d95d0850f49b3e src/slave/containerizer/isolators/network/port_mapping.cpp 14fae1f00050afbc6b99f4aabf868a2d75774b15 src/tests/isolator_tests.cpp 4d03f46cbe20c0e7aff15bab0a26d7738b55aab9 src/tests/ns_tests.cpp 046ea26701f346399f4bc31a5c9491325e8bd93f src/tests/setns_test_helper.cpp eb8746bd6e75323682d9dbbf989b65e30e3c1cda Diff: https://reviews.apache.org/r/27353/diff/ Testing --- make check Thanks, Ian Downes
Re: Review Request 27054: Libprocess Socket: introduce connect()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/#review59083 --- Bad patch! Reviews applied: [27350, 27351, 27350] Failed command: ./support/apply-review.sh -n -r 27350 Error: 2014-10-29 23:57:20 URL:https://reviews.apache.org/r/27350/diff/raw/ [897/897] - 27350.patch [1] error: patch failed: 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4:37 error: 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4: patch does not apply Failed to apply patch - Mesos ReviewBot On Oct. 29, 2014, 10:42 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 29, 2014, 10:42 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Bugs: MESOS-1330 https://issues.apache.org/jira/browse/MESOS-1330 Repository: mesos-git Description --- Introduce the connect(const Node node) call to Socket. Use it in link() and send(). Diffs - 3rdparty/libprocess/include/process/socket.hpp 6683881 3rdparty/libprocess/src/process.cpp 85fb995 Diff: https://reviews.apache.org/r/27054/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review59073 --- Looks great! Minor tweaks for you to consider, then we can commit it. src/Makefile.am https://reviews.apache.org/r/26857/#comment100357 I'm not sure what we're doing here. It looks like test_authenticator_module.cpp is the only source, so I'd expect something like the libtestisolator stuff above, but the language seems to imply that the CRAM-MD5 authentication (not just authenticator) modules (not just for test) all lives in this library. For now, I think the comment and names should express that this is just for the test authenticator module, and then we can update the library name and comment when we actually add the authenticatee and split all of the authentication out of mesos into this library (as per your TODOs). src/authentication/authenticator.hpp https://reviews.apache.org/r/26857/#comment100359 __AUTHENTICATION_AUTHENTICATOR_HPP__? In case there's ever another authenticator not for authentication? Or this could be one of those super obvious ones (like master/master.hpp) where we don't need the directory name prefix because we never expect conflicts src/authentication/cram_md5/authenticator.hpp https://reviews.apache.org/r/26857/#comment100382 s/authenticator/crammd5_authenticator/ in case we end up with multiple authenticator process types (+kerberos) running simultaneously src/authentication/cram_md5/authenticator.hpp https://reviews.apache.org/r/26857/#comment100390 s/gotten/been/ src/authentication/cram_md5/authenticator.hpp https://reviews.apache.org/r/26857/#comment100388 CHECK_NOTNULL src/examples/test_authenticator_module.cpp https://reviews.apache.org/r/26857/#comment100392 org_apache_mesos_TestCRAMMD5Authenticator? Then when we add the real module, they won't conflict? src/module/manager.cpp https://reviews.apache.org/r/26857/#comment100393 Maybe these should be alphabetized, to make it easier to find modules as this list grows. - Adam B On Oct. 29, 2014, 11:51 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 29, 2014, 11:51 a.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 27356: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/#review59091 --- Patch looks great! Reviews applied: [27354, 27356] All tests passed. - Mesos ReviewBot On Oct. 29, 2014, 10:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- (Updated Oct. 29, 2014, 10:51 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
On Oct. 30, 2014, 12:15 a.m., Adam B wrote: src/authentication/cram_md5/authenticator.hpp, line 537 https://reviews.apache.org/r/26857/diff/7/?file=740321#file740321line537 CHECK_NOTNULL CHECK_NOTNULL does not allow for any helpful messages, hence I chose CHECK instead. On Oct. 30, 2014, 12:15 a.m., Adam B wrote: src/module/manager.cpp, lines 60-62 https://reviews.apache.org/r/26857/diff/7/?file=740324#file740324line60 Maybe these should be alphabetized, to make it easier to find modules as this list grows. Aye, makes sense. On Oct. 30, 2014, 12:15 a.m., Adam B wrote: src/authentication/cram_md5/authenticator.hpp, line 84 https://reviews.apache.org/r/26857/diff/7/?file=740321#file740321line84 s/authenticator/crammd5_authenticator/ in case we end up with multiple authenticator process types (+kerberos) running simultaneously Good point. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review59073 --- On Oct. 29, 2014, 6:51 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 29, 2014, 6:51 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 27122: Reorganized authentication implementation locations.
On Oct. 29, 2014, 11:20 p.m., Adam B wrote: Looks great! I can make these changes and commit it for you (unless somebody objects soon). I am on it... fixing everything that got commented on. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/#review59069 --- On Oct. 29, 2014, 1:43 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/ --- (Updated Oct. 29, 2014, 1:43 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1893 https://issues.apache.org/jira/browse/MESOS-1893 Repository: mesos-git Description --- For paving the way into further authentication mechanism implementations, the existing is reorganized. Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp to src/tests/cram_md5_authentication_tests.cpp. Adapt depending include paths. Rename specific test implementations from SASL to CRAMMD5Authentication. Rename sasl namespace to cram_md5 throughout all uses. Add missing license blob to auxprop.cpp. Diffs - src/Makefile.am f177d87 src/authentication/cram_md5/authenticatee.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/authentication/cram_md5/auxprop.hpp PRE-CREATION src/authentication/cram_md5/auxprop.cpp PRE-CREATION src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/sasl/authenticatee.hpp ec2c841 src/sasl/authenticator.hpp 6f4d3db src/sasl/auxprop.hpp 44e201b src/sasl/auxprop.cpp 6de1222 src/sched/sched.cpp 0fb8c7b src/scheduler/scheduler.cpp fb88a3e src/slave/slave.hpp eb5de73 src/slave/slave.cpp 96fb5f7 src/tests/cram_md5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review59097 --- src/authentication/cram_md5/authenticator.hpp https://reviews.apache.org/r/26857/#comment100414 not yours, but do you mind s/this/this is/ src/authentication/cram_md5/authenticator.hpp https://reviews.apache.org/r/26857/#comment100413 Why do this take an Option credentials if it always a requires it? AFAICT, the Authenticator interface doesn't dicate it. - Vinod Kone On Oct. 29, 2014, 6:51 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 29, 2014, 6:51 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 27122: Reorganized authentication implementation locations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/ --- (Updated Oct. 30, 2014, 1:13 a.m.) Review request for mesos, Adam B and Vinod Kone. Changes --- Addressed comments. Bugs: MESOS-1893 https://issues.apache.org/jira/browse/MESOS-1893 Repository: mesos-git Description --- For paving the way into further authentication mechanism implementations, the existing is reorganized. Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp to src/tests/cram_md5_authentication_tests.cpp. Adapt depending include paths. Rename specific test implementations from SASL to CRAMMD5Authentication. Rename sasl namespace to cram_md5 throughout all uses. Add missing license blob to auxprop.cpp. Diffs (updated) - src/Makefile.am f177d87 src/authentication/cram_md5/authenticatee.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/authentication/cram_md5/auxprop.hpp PRE-CREATION src/authentication/cram_md5/auxprop.cpp PRE-CREATION src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/sasl/authenticatee.hpp ec2c841 src/sasl/authenticator.hpp 6f4d3db src/sasl/auxprop.hpp 44e201b src/sasl/auxprop.cpp 6de1222 src/sched/sched.cpp 0fb8c7b src/scheduler/scheduler.cpp fb88a3e src/slave/slave.hpp eb5de73 src/slave/slave.cpp 96fb5f7 src/tests/cram_md5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 27315: Updated scheduler driver to exponentially backoff during registration retries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/#review59106 --- Patch looks great! Reviews applied: [27315] All tests passed. - Mesos ReviewBot On Oct. 29, 2014, 11:16 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/ --- (Updated Oct. 29, 2014, 11:16 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1903 https://issues.apache.org/jira/browse/MESOS-1903 Repository: mesos-git Description --- Uses the same backoff (except no initial backoff) strategy used by the slave during registration. Diffs - src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 src/sched/constants.hpp PRE-CREATION src/sched/constants.cpp PRE-CREATION src/sched/flags.hpp PRE-CREATION src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd Diff: https://reviews.apache.org/r/27315/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
On Oct. 30, 2014, 12:15 a.m., Adam B wrote: src/examples/test_authenticator_module.cpp, line 44 https://reviews.apache.org/r/26857/diff/7/?file=740322#file740322line44 org_apache_mesos_TestCRAMMD5Authenticator? Then when we add the real module, they won't conflict? This already implements a fully functional authenticator. We could replace the built-in mechanics with this module already without any drawbacks. Building another CRAM-MD5 SASL authenticator module would not make any sense. Is that convincing? - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review59073 --- On Oct. 29, 2014, 6:51 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 29, 2014, 6:51 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
On Oct. 30, 2014, 12:15 a.m., Adam B wrote: src/examples/test_authenticator_module.cpp, line 44 https://reviews.apache.org/r/26857/diff/7/?file=740322#file740322line44 org_apache_mesos_TestCRAMMD5Authenticator? Then when we add the real module, they won't conflict? Till Toenshoff wrote: This already implements a fully functional authenticator. We could replace the built-in mechanics with this module already without any drawbacks. Building another CRAM-MD5 SASL authenticator module would not make any sense. Is that convincing? Actually, now that I renamed the library, I will also rename the module according to your suggestion. That way we can keep this as an example even if we added another identical variant as a real authenticator. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review59073 --- On Oct. 29, 2014, 6:51 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 29, 2014, 6:51 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 30, 2014, 2:10 a.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- Addressed comments. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs (updated) - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26857: Added CRAM-MD5 Test Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 30, 2014, 2:25 a.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- Some more name changing to be more explicit on the purpose. Summary (updated) - Added CRAM-MD5 Test Authenticator module. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description (updated) --- Introducing the CRAM-MD5 SASL test authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs (updated) - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing (updated) --- make check NOTE all four CRAM-MD5 test authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 27122: Reorganized authentication implementation locations.
On Oct. 28, 2014, 11:37 p.m., Kapil Arya wrote: src/authentication/cram_md5/authenticator.hpp, lines 19-20 https://reviews.apache.org/r/27122/diff/2/?file=733314#file733314line19 s/CRAMMD5/AUTHENTICATION_CRAM_MD5/ ? Till Toenshoff wrote: I find the idea of reversing the specification and the base interface rather unusual and it also would not fit our current scheme, e.g. ISOLATOR - MEM_ISOLATOR / SHARED_FILESYSTEM_ISOLATOR. Adding an extra underscore on the other hand should be fine. Kapil Arya wrote: I actually mean __AUTHENTICATION_CRAM_MD5_AUTHENTICATOR_HPP__ to replace the existing one to allow the base directory name to be also part of the include guard. Whoops, sry - should have seen that. Thanks for this suggestion. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/#review58910 --- On Oct. 30, 2014, 1:13 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/ --- (Updated Oct. 30, 2014, 1:13 a.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1893 https://issues.apache.org/jira/browse/MESOS-1893 Repository: mesos-git Description --- For paving the way into further authentication mechanism implementations, the existing is reorganized. Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp to src/tests/cram_md5_authentication_tests.cpp. Adapt depending include paths. Rename specific test implementations from SASL to CRAMMD5Authentication. Rename sasl namespace to cram_md5 throughout all uses. Add missing license blob to auxprop.cpp. Diffs - src/Makefile.am f177d87 src/authentication/cram_md5/authenticatee.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/authentication/cram_md5/auxprop.hpp PRE-CREATION src/authentication/cram_md5/auxprop.cpp PRE-CREATION src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/sasl/authenticatee.hpp ec2c841 src/sasl/authenticator.hpp 6f4d3db src/sasl/auxprop.hpp 44e201b src/sasl/auxprop.cpp 6de1222 src/sched/sched.cpp 0fb8c7b src/scheduler/scheduler.cpp fb88a3e src/slave/slave.hpp eb5de73 src/slave/slave.cpp 96fb5f7 src/tests/cram_md5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/
---
(Updated Oct. 30, 2014, 2:54 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description (updated)
---
The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
Example usage:
bin/mesos-tests.sh --authenticators=org_apache_mesos_TestCRAMMD5Authenticator
--modules={\libraries\: [{\file\:
\src/.libs/libtestauthenticator.so\,\modules\: [{\name\:
\org_apache_mesos_TestCRAMMD5Authenticator\}]}]}
Diffs (updated)
-
src/tests/flags.hpp 2886e89
src/tests/mesos.cpp 2e8e39a
Diff: https://reviews.apache.org/r/26860/diff/
Testing (updated)
---
make check
bin/mesos-tests.sh --authenticators=org_apache_mesos_TestCRAMMD5Authenticator
--modules={\libraries\: [{\file\:
\src/.libs/libtestauthenticator.dylib\,\modules\: [{\name\:
\org_apache_mesos_TestCRAMMD5Authenticator\}]}]} --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:16:14.764703 298631168 master.cpp:3874] Using
'org_apache_mesos_TestCRAMMD5Authenticator' authenticator
bin/mesos-tests.sh --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5
authenticator
Thanks,
Till Toenshoff
Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/#review59125
---
Bad patch!
Reviews applied: [27122, 26857, 26859]
Failed command: ./support/apply-review.sh -n -r 26859
Error:
2014-10-30 03:03:42 URL:https://reviews.apache.org/r/26859/diff/raw/
[23191/23191] - 26859.patch [1]
error: patch failed: src/examples/test_authenticator_module.cpp:41
error: src/examples/test_authenticator_module.cpp: patch does not apply
error: patch failed: src/master/master.cpp:379
error: src/master/master.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Oct. 30, 2014, 2:54 a.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/
---
(Updated Oct. 30, 2014, 2:54 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
Example usage:
bin/mesos-tests.sh --authenticators=org_apache_mesos_TestCRAMMD5Authenticator
--modules={\libraries\: [{\file\:
\src/.libs/libtestauthenticator.so\,\modules\: [{\name\:
\org_apache_mesos_TestCRAMMD5Authenticator\}]}]}
Diffs
-
src/tests/flags.hpp 2886e89
src/tests/mesos.cpp 2e8e39a
Diff: https://reviews.apache.org/r/26860/diff/
Testing
---
make check
bin/mesos-tests.sh --authenticators=org_apache_mesos_TestCRAMMD5Authenticator
--modules={\libraries\: [{\file\:
\src/.libs/libtestauthenticator.dylib\,\modules\: [{\name\:
\org_apache_mesos_TestCRAMMD5Authenticator\}]}]} --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:16:14.764703 298631168 master.cpp:3874] Using
'org_apache_mesos_TestCRAMMD5Authenticator' authenticator
bin/mesos-tests.sh --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5
authenticator
Thanks,
Till Toenshoff
Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
On Oct. 30, 2014, 3:03 a.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [27122, 26857, 26859]
Failed command: ./support/apply-review.sh -n -r 26859
Error:
2014-10-30 03:03:42 URL:https://reviews.apache.org/r/26859/diff/raw/
[23191/23191] - 26859.patch [1]
error: patch failed: src/examples/test_authenticator_module.cpp:41
error: src/examples/test_authenticator_module.cpp: patch does not apply
error: patch failed: src/master/master.cpp:379
error: src/master/master.cpp: patch does not apply
Failed to apply patch
I wonder what I was doing wrong here ...
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/#review59125
---
On Oct. 30, 2014, 2:54 a.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/
---
(Updated Oct. 30, 2014, 2:54 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
Example usage:
bin/mesos-tests.sh --authenticators=org_apache_mesos_TestCRAMMD5Authenticator
--modules={\libraries\: [{\file\:
\src/.libs/libtestauthenticator.so\,\modules\: [{\name\:
\org_apache_mesos_TestCRAMMD5Authenticator\}]}]}
Diffs
-
src/tests/flags.hpp 2886e89
src/tests/mesos.cpp 2e8e39a
Diff: https://reviews.apache.org/r/26860/diff/
Testing
---
make check
bin/mesos-tests.sh --authenticators=org_apache_mesos_TestCRAMMD5Authenticator
--modules={\libraries\: [{\file\:
\src/.libs/libtestauthenticator.dylib\,\modules\: [{\name\:
\org_apache_mesos_TestCRAMMD5Authenticator\}]}]} --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:16:14.764703 298631168 master.cpp:3874] Using
'org_apache_mesos_TestCRAMMD5Authenticator' authenticator
bin/mesos-tests.sh --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5
authenticator
Thanks,
Till Toenshoff
Mesos Hackathon at ApacheCon EU in Budapest, November 17th
ApacheCon Europe http://events.linuxfoundation.org/events/apachecon-europe is taking place in Budapest, Hungary November 17-21! There are two Mesos talks on the schedule, and after chatting with conference organizers and Tim St Clair from Red Hat (who will also be there presenting), we've secured a space for a Mesos hackathon that will take place during day one of the conference. Given that ApacheCon EU and the Mesos hackathon are slightly less than three weeks away, I'd love for folks in the European Mesos community to participate and help get the word out. *When and Where* The Mesos hackathon will take place on Monday November 17th, and we can accommodate up to 25 folks. Attendees must be registered for ApacheConEU (details below on a discount). *ApacheCon EU Registration* Registration is through the conference website http://events.linuxfoundation.org//events/apachecon-europe/attend/register. There is a 50% off discount code for hackathon participants when they register: ACEMH14. This registration is for the full conference; there is not a one day registration available. If folks are registering I'd suggest doing this soon, since there is a lower registration rate through November 1st. *ApacheCon EU Hotel Block* The last day to book your hotel room at The Corinthia Hotel http://www.corinthia.com/hotels/budapest/ at the discounted room rate of €110/night is November 5, 2014. Please click here https://gc.synxis.com/rez.aspx?Hotel=28704Chain=11693shell=Flex5arrive=11%2f14%2f2014depart=11%2f23%2f2014adult=1child=0group=1411H2RSOU_001 to reserve your room. We encourage you to book prior toNovember 5 in order to ensure you receive a room at the discounted rate before our block sells out. *What will folks hack on?* There is not a specific hackathon theme at this time, however attendees are welcome to establish one or several themes. Chime-in on this email thread or IRC if you have opinions. Hacking could include Mesos core, frameworks, or resources around the project like tutorials or documentation. For example, the httpd hackathon that's also happening at ApacheCon EU will focus on documentation. *How do I sign up for the hackathon?* There is an ApacheCon Europe hackathon wiki https://wiki.apache.org/apachecon/HackathonEU14 which includes some potential hackathon ideas and current hackathon participants; we encourage participants to add their names directly (instructions for write access are on the wiki homepage https://wiki.apache.org/apachecon/), or just by responding to this thread and we'll add your name on your behalf. Hope to see many of you at ApacheCon Europe and our hackathon in November! Dave
Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review59088 --- Looks really good, but I think we need one more round to clear out the references to 'modules' when using generic 'authenticators'. src/examples/test_authenticator_module.cpp https://reviews.apache.org/r/26859/#comment100396 Strange, I didn't see these merge annotations in your previous patch that introduced this file. Not sure why it shows up in this diff, but as long as the lhs never gets checked in, we're fine. src/master/flags.hpp https://reviews.apache.org/r/26859/#comment100400 Why does this even talk about modules? It should talk about authenticators, and the --modules flag can talk about modules. And if there's a module with a new authenticator, you can tell them in your module's howto doc to use --modules to load it and --authenticators to enable it. Suggested new text: Comma separated list of authenticator(s) to use. Only uses the first authenticator in the list for now. src/master/master.hpp https://reviews.apache.org/r/26859/#comment100401 These are no longer necessarily 'modules', so maybe rename the variable to 'authenticatorNames' src/master/master.cpp https://reviews.apache.org/r/26859/#comment100403 s/module // src/master/master.cpp https://reviews.apache.org/r/26859/#comment100404 Shouldn't you also check that !authenticatorNames.empty() in case somebody overrides the default to set --authenticators=? Error and exit src/master/master.cpp https://reviews.apache.org/r/26859/#comment100402 It would be nice to see the name of the authenticator being used: Multiple authenticators are not supported. Only using: + authenticatorNames[0] src/master/master.cpp https://reviews.apache.org/r/26859/#comment100406 Let's get rid of the magic string and make crammd5 a string constant. src/master/master.cpp https://reviews.apache.org/r/26859/#comment100405 Can we reword this to not discuss 'modules'? Maybe just Authenticator ' authenticatorNames[0] ' not found. If you want to suggest how to fix it, you could suggest they check the spelling (compare to crammd5) or verify that they have the authenticator loaded in a module from --modules src/master/master.cpp https://reviews.apache.org/r/26859/#comment100407 Is this an error to 'load' or an error to 'create'? s/load/create/? src/master/master.cpp https://reviews.apache.org/r/26859/#comment100409 'auth' is to short/ambiguous. Use authenticator and authenticator_. You can pick which one is the Owned ptr vs. the normal pointer. src/master/master.cpp https://reviews.apache.org/r/26859/#comment100412 Blank like between these; pretty much always want a blank line before comments. src/tests/cram_md5_authentication_tests.cpp https://reviews.apache.org/r/26859/#comment100450 Two blank lines between tests - Adam B On Oct. 29, 2014, 11:51 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 29, 2014, 11:51 a.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Enables selecting a module based authenticator via the new --authenticators flag for mesos master. Additionally, all have been fixed towards in master.hpp and master.cpp. Diffs - src/examples/test_authenticator_module.cpp PRE-CREATION src/master/flags.hpp c931fd9 src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/tests/cram_md5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26382: Add source and reason to TaskStatus.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/#review59136 --- Patch looks great! Reviews applied: [26817, 26382] All tests passed. - Mesos ReviewBot On Oct. 30, 2014, 3:47 a.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 30, 2014, 3:47 a.m.) Review request for mesos, Vinod Kone and Bill Farner. Bugs: MESOS-1830 and MESOS-343 https://issues.apache.org/jira/browse/MESOS-1830 https://issues.apache.org/jira/browse/MESOS-343 Repository: mesos-git Description --- Added source and reason, enabled TASK_ERROR, and made the changes necessary throughout the codebase. Diffs - include/mesos/mesos.proto 168a7a8c35ed1bf3f5bd6d7431b1e511bae7b789 src/common/protobuf_utils.hpp 212d5124b9a4cc58e61719fa7f07a61cd166e834 src/common/protobuf_utils.cpp a9b65e328c4c62bff7fbf5633dda25d742d79019 src/examples/balloon_framework.cpp b05d5679fe2915142907af0b2dc00c6cd76eb9c1 src/examples/java/TestFramework.java bc593d0abfacb00690b1492b2b82c970f4e4de6d src/examples/low_level_scheduler_libprocess.cpp 7ef5ea78ade4ed856b97009fdfe31281f0a55c17 src/examples/low_level_scheduler_pthread.cpp 6e233a10117a1c7aa669806b5b430e746e227ee5 src/examples/no_executor_framework.cpp f98a0735b9f287e7f1bf98af6c2e9a47ca6a77b2 src/examples/test_framework.cpp 187a611ebfe35cb13ee48aa5eca934cf55f34dea src/master/master.cpp 762d2ff6c168ac212f70b43275692a77496a7fcd src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/slave/slave.cpp 96fb5f7385b0762d46d8129f7e43207bd6311644 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd src/tests/master_authorization_tests.cpp 652e80d0d4567b225c6ffb326725ddfde06f7fd3 src/tests/master_tests.cpp 2e525749247626c05efb2f54a707599facb114b6 src/tests/resource_offers_tests.cpp fe66432b1bf75ee25feb73c4bb353e4d4e5b503f Diff: https://reviews.apache.org/r/26382/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/#review59137
---
src/tests/flags.hpp
https://reviews.apache.org/r/26860/#comment100453
keep it in sync with the changes I asked you to make in the previous patch
(fewer references to 'modules' here)
- Adam B
On Oct. 29, 2014, 7:54 p.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/
---
(Updated Oct. 29, 2014, 7:54 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
Example usage:
bin/mesos-tests.sh --authenticators=org_apache_mesos_TestCRAMMD5Authenticator
--modules={\libraries\: [{\file\:
\src/.libs/libtestauthenticator.so\,\modules\: [{\name\:
\org_apache_mesos_TestCRAMMD5Authenticator\}]}]}
Diffs
-
src/tests/flags.hpp 2886e89
src/tests/mesos.cpp 2e8e39a
Diff: https://reviews.apache.org/r/26860/diff/
Testing
---
make check
bin/mesos-tests.sh --authenticators=org_apache_mesos_TestCRAMMD5Authenticator
--modules={\libraries\: [{\file\:
\src/.libs/libtestauthenticator.dylib\,\modules\: [{\name\:
\org_apache_mesos_TestCRAMMD5Authenticator\}]}]} --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:16:14.764703 298631168 master.cpp:3874] Using
'org_apache_mesos_TestCRAMMD5Authenticator' authenticator
bin/mesos-tests.sh --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5
authenticator
Thanks,
Till Toenshoff
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2230
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2230/changes Changes: [vinodkone] Added MesosCon'14 playlist to presentations. -- [...truncated 15872 lines...] I1030 05:54:04.505708 29517 replica.cpp:676] Persisted action at 2 I1030 05:54:04.505733 29517 replica.cpp:661] Replica learned TRUNCATE action at position 2 I1030 05:54:04.518836 29520 slave.cpp:169] Slave started on 27)@67.195.81.187:54775 I1030 05:54:04.518879 29520 credentials.hpp:84] Loading credential for authentication from '/tmp/ReconciliationTest_TaskStateMismatch_jXTxgL/credential' I1030 05:54:04.519043 29520 slave.cpp:276] Slave using credential for: test-principal I1030 05:54:04.519332 29520 slave.cpp:289] Slave resources: cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] I1030 05:54:04.519435 29520 slave.cpp:318] Slave hostname: pomona.apache.org I1030 05:54:04.519454 29520 slave.cpp:319] Slave checkpoint: false W1030 05:54:04.519462 29520 slave.cpp:321] Disabling checkpointing is deprecated and the --checkpoint flag will be removed in a future release. Please avoid using this flag I1030 05:54:04.520382 29526 state.cpp:33] Recovering state from '/tmp/ReconciliationTest_TaskStateMismatch_jXTxgL/meta' I1030 05:54:04.521198 29519 status_update_manager.cpp:197] Recovering status update manager I1030 05:54:04.521605 29521 slave.cpp:3456] Finished recovery I1030 05:54:04.522595 29515 status_update_manager.cpp:171] Pausing sending status updates I1030 05:54:04.522593 29524 slave.cpp:602] New master detected at master@67.195.81.187:54775 I1030 05:54:04.522677 29524 slave.cpp:665] Authenticating with master master@67.195.81.187:54775 I1030 05:54:04.522855 29524 slave.cpp:638] Detecting new master I1030 05:54:04.522924 29522 authenticatee.hpp:133] Creating new client SASL connection I1030 05:54:04.523164 29512 master.cpp:3853] Authenticating slave(27)@67.195.81.187:54775 I1030 05:54:04.523605 29523 authenticator.hpp:161] Creating new server SASL connection I1030 05:54:04.523784 29523 authenticatee.hpp:224] Received SASL authentication mechanisms: CRAM-MD5 I1030 05:54:04.523813 29523 authenticatee.hpp:250] Attempting to authenticate with mechanism 'CRAM-MD5' I1030 05:54:04.523910 29519 authenticator.hpp:267] Received SASL authentication start I1030 05:54:04.524049 29519 authenticator.hpp:389] Authentication requires more steps I1030 05:54:04.524139 29519 authenticatee.hpp:270] Received SASL authentication step I1030 05:54:04.524343 29524 authenticator.hpp:295] Received SASL authentication step I1030 05:54:04.524382 29524 auxprop.cpp:81] Request to lookup properties for user: 'test-principal' realm: 'pomona.apache.org' server FQDN: 'pomona.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I1030 05:54:04.524395 29524 auxprop.cpp:153] Looking up auxiliary property '*userPassword' I1030 05:54:04.524438 29524 auxprop.cpp:153] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I1030 05:54:04.524466 29524 auxprop.cpp:81] Request to lookup properties for user: 'test-principal' realm: 'pomona.apache.org' server FQDN: 'pomona.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true I1030 05:54:04.524479 29524 auxprop.cpp:103] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I1030 05:54:04.524488 29524 auxprop.cpp:103] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true I1030 05:54:04.524507 29524 authenticator.hpp:381] Authentication success I1030 05:54:04.524592 29523 authenticatee.hpp:310] Authentication success I1030 05:54:04.524618 29524 master.cpp:3893] Successfully authenticated principal 'test-principal' at slave(27)@67.195.81.187:54775 I1030 05:54:04.524847 29519 slave.cpp:722] Successfully authenticated with master master@67.195.81.187:54775 I1030 05:54:04.525086 29519 slave.cpp:1050] Will retry registration in 1.045728ms if necessary I1030 05:54:04.525368 29524 master.cpp:3032] Registering slave at slave(27)@67.195.81.187:54775 (pomona.apache.org) with id 20141030-055359-3142697795-54775-29497-S0 I1030 05:54:04.525885 29523 registrar.cpp:445] Applied 1 operations in 94940ns; attempting to update the 'registry' I1030 05:54:04.526000 29497 sched.cpp:137] Version: 0.21.0 I1030 05:54:04.526583 29521 slave.cpp:1050] Will retry registration in 17.399441ms if necessary I1030 05:54:04.526733 29526 master.cpp:3020] Ignoring register slave message from slave(27)@67.195.81.187:54775 (pomona.apache.org) as admission is already in progress I1030 05:54:04.526758 29514 sched.cpp:233] New master detected at master@67.195.81.187:54775 I1030 05:54:04.526803 29514 sched.cpp:283] Authenticating with master master@67.195.81.187:54775 I1030 05:54:04.527016 29518 authenticatee.hpp:133] Creating new client SASL connection I1030 05:54:04.527230 29524
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2508
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2508/changes Changes: [vinodkone] Added MesosCon'14 playlist to presentations. -- [...truncated 55745 lines...] I1030 05:55:05.082120 24483 replica.cpp:508] Replica received write request for position 4 I1030 05:55:05.082358 24486 hierarchical_allocator_process.hpp:679] Performed allocation for slave 20141030-055504-3142697795-40429-24459-S0 in 632705ns I1030 05:55:05.082669 24483 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 514640ns I1030 05:55:05.082698 24483 replica.cpp:676] Persisted action at 4 I1030 05:55:05.082751 24480 master.cpp:3795] Sending 1 offers to framework 20141030-055504-3142697795-40429-24459- (default) at scheduler-4c373650-2b25-4f8d-90bf-ebce4293d044@67.195.81.187:40429 I1030 05:55:05.083233 24477 sched.cpp:544] Scheduler::resourceOffers took 130329ns I1030 05:55:05.083710 24483 replica.cpp:655] Replica received learned notice for position 4 I1030 05:55:05.084239 24483 leveldb.cpp:343] Persisting action (18 bytes) to leveldb took 497420ns I1030 05:55:05.084332 24483 leveldb.cpp:401] Deleting ~2 keys from leveldb took 65118ns I1030 05:55:05.084355 24483 replica.cpp:676] Persisted action at 4 I1030 05:55:05.084367 24477 master.cpp:2321] Processing reply for offers: [ 20141030-055504-3142697795-40429-24459-O0 ] on slave 20141030-055504-3142697795-40429-24459-S0 at slave(202)@67.195.81.187:40429 (pomona.apache.org) for framework 20141030-055504-3142697795-40429-24459- (default) at scheduler-4c373650-2b25-4f8d-90bf-ebce4293d044@67.195.81.187:40429 I1030 05:55:05.084378 24483 replica.cpp:661] Replica learned TRUNCATE action at position 4 I1030 05:55:05.084741 24486 hierarchical_allocator_process.hpp:659] Performed allocation for 1 slaves in 123939ns I1030 05:55:05.084908 24487 master.cpp:120] No whitelist given. Advertising offers for all slaves I1030 05:55:05.085345 24482 slave.cpp:2522] Received ping from slave-observer(183)@67.195.81.187:40429 I1030 05:55:05.085438 24488 hierarchical_allocator_process.hpp:563] Recovered cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] (total allocatable: cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000]) on slave 20141030-055504-3142697795-40429-24459-S0 from framework 20141030-055504-3142697795-40429-24459- I1030 05:55:06.908022 24488 hierarchical_allocator_process.hpp:599] Framework 20141030-055504-3142697795-40429-24459- filtered slave 20141030-055504-3142697795-40429-24459-S0 for 5secs I1030 05:55:06.910189 24459 master.cpp:677] Master terminating I1030 05:55:06.910305 24482 sched.cpp:745] Stopping framework '20141030-055504-3142697795-40429-24459-' I1030 05:55:06.910907 24475 slave.cpp:2607] master@67.195.81.187:40429 exited W1030 05:55:06.910935 24475 slave.cpp:2610] Master disconnected! Waiting for a new master to be elected I1030 05:55:06.926357 24459 slave.cpp:484] Slave terminating [ OK ] MasterTest.OfferNotRescindedOnceDeclined (2135 ms) [--] 27 tests from MasterTest (73928 ms total) [--] 3 tests from DRFAllocatorTest [ RUN ] DRFAllocatorTest.DRFAllocatorProcess Using temporary directory '/tmp/DRFAllocatorTest_DRFAllocatorProcess_BI905j' I1030 05:55:06.934813 24459 leveldb.cpp:176] Opened db in 3.175202ms I1030 05:55:06.935925 24459 leveldb.cpp:183] Compacted db in 1.077924ms I1030 05:55:06.935976 24459 leveldb.cpp:198] Created db iterator in 16460ns I1030 05:55:06.935995 24459 leveldb.cpp:204] Seeked to beginning of db in 2018ns I1030 05:55:06.936005 24459 leveldb.cpp:273] Iterated through 0 keys in the db in 335ns I1030 05:55:06.936039 24459 replica.cpp:741] Replica recovered with log positions 0 - 0 with 1 holes and 0 unlearned I1030 05:55:06.936705 24480 recover.cpp:437] Starting replica recovery I1030 05:55:06.937023 24480 recover.cpp:463] Replica is in EMPTY status I1030 05:55:06.938158 24475 replica.cpp:638] Replica in EMPTY status received a broadcasted recover request I1030 05:55:06.938859 24482 recover.cpp:188] Received a recover response from a replica in EMPTY status I1030 05:55:06.939486 24474 recover.cpp:554] Updating replica status to STARTING I1030 05:55:06.940249 24489 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 591981ns I1030 05:55:06.940274 24489 replica.cpp:320] Persisted replica status to STARTING I1030 05:55:06.940752 24481 recover.cpp:463] Replica is in STARTING status I1030 05:55:06.940820 24489 master.cpp:312] Master 20141030-055506-3142697795-40429-24459 (pomona.apache.org) started on 67.195.81.187:40429 I1030 05:55:06.940871 24489 master.cpp:358] Master only allowing authenticated frameworks to register I1030 05:55:06.940891 24489 master.cpp:363] Master only allowing authenticated slaves to register I1030 05:55:06.940908 24489 credentials.hpp:36] Loading credentials for authentication from
