Re: Review Request 32008: Use LDADD to add unbundled libraries to all command line programs

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76405
---


Blanket LDADD will fail rpm checks because it will link all deps whether they 
are used or not.

- Timothy St. Clair


On March 13, 2015, 12:10 a.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32008/
> ---
> 
> (Updated March 13, 2015, 12:10 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Timothy St. Clair.
> 
> 
> Bugs: MESOS-2486
> https://issues.apache.org/jira/browse/MESOS-2486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When building with unbundled libraries, every program needs to link
> against the libraries, and can't assume it will be linked against
> because the program links with a program which links against the
> libraries.
> 
> This comes up on Debian and Ubuntu[1] which set the flag
> `-Wl,--no-copy-dt-needed-entries` which forcibly disables the binaries
> from getting automatically the dependencies of the shared libraries
> they link against.
> 
> Fixes MESOS-2486
> 
> [1] 
> https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--no-copy-dt-needed-entries
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 3059818231c46484039d179cd6916932eff6cd68 
> 
> Diff: https://reviews.apache.org/r/32008/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 with `--with-glog`, `--with-protobuf` and 
> `--with-boost`.
> 
> As a sanity check that all isntances of _LDADD are updated, I ran the grep: 
> `grep -r _LDADD . | grep -v '$(LDADD)'` that all the program-specific LDADD 
> flags now include the global LDADD.
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 32008: Use LDADD to add unbundled libraries to all command line programs

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76416
---

Ship it!


Provided builds are clean, +1

- Timothy St. Clair


On March 13, 2015, 7:55 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32008/
> ---
> 
> (Updated March 13, 2015, 7:55 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Timothy St. Clair.
> 
> 
> Bugs: MESOS-2486
> https://issues.apache.org/jira/browse/MESOS-2486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use LDADD to add unbundled libraries to all command line programs
> 
> When building with unbundled libraries, every program needs to link
> against the libraries, and can't assume it will be linked against
> because the program links with a program which links against the
> libraries.
> 
> This comes up on Debian and Ubuntu[1] which set the flag
> `-Wl,--no-copy-dt-needed-entries` which forcibly disables the binaries
> from getting automatically the dependencies of the shared libraries
> they link against.
> 
> Also adds -Wl,--as-neede to AM_LDFLAGS to silence warnings in Fedora
> packaging since we link against more libraries than things actually
> use at the command line. Debian and Ubuntu default to this option.
> 
> Fixes MESOS-2486
> 
> [1] 
> https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--no-copy-dt-needed-entries
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 3059818231c46484039d179cd6916932eff6cd68 
> 
> Diff: https://reviews.apache.org/r/32008/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 with `--with-glog`, `--with-protobuf` and 
> `--with-boost`.
> 
> As a sanity check that all isntances of _LDADD are updated, I ran the grep: 
> `grep -r _LDADD . | grep -v '$(LDADD)'` that all the program-specific LDADD 
> flags now include the global LDADD.
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 33111: Should install apr-util-devel in CentOS 6.5

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33111/#review79896
---

Ship it!


Ship It!

- Timothy St. Clair


On April 12, 2015, 9:33 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33111/
> ---
> 
> (Updated April 12, 2015, 9:33 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2611
> https://issues.apache.org/jira/browse/MESOS-2611
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Should install apr-util-devel in CentOS 6.5
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md b1d08e68bfce8097468e244f219bd178b6a33f57 
> 
> Diff: https://reviews.apache.org/r/33111/diff/
> 
> 
> Testing
> ---
> 
> apr-utils-devel should be apr-util-devel
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 24252: Create static mesos library.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24252/#review49738
---

Ship it!


Seems fine. 
We should probably open a ticket to add '-version-info 0:0:0' going forwards. 

- Timothy St. Clair


On Aug. 4, 2014, 7:33 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24252/
> ---
> 
> (Updated Aug. 4, 2014, 7:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1633
> https://issues.apache.org/jira/browse/MESOS-1633
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> By default, we now build both static and dynamic libraries. For 
> operators/package mantainers that do not want a static library included in 
> their distribution "--disable-static" configure flag can be provided.
> 
> This is consistent with how some other packages do it (e.g, libev, glog, 
> gmock).
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7 
> 
> Diff: https://reviews.apache.org/r/24252/diff/
> 
> 
> Testing
> ---
> 
> ./configure --> builds both static and dynamic mesos libs
> ./configure --disable-static --> builds only dynamic mesos lib
> 
> ./configure --disable-shared has a build error, but AFAICT it is irrelevant 
> to this change. I'll open separate ticket for that.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 23453: Unbundle glog

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23453/
---

(Updated Aug. 6, 2014, 4:33 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased patch verified on prefix installation. 


Bugs: MESOS-1170
https://issues.apache.org/jira/browse/MESOS-1170


Repository: mesos-git


Description
---

Enable mesos to build against the system installed version of glog. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 705d19c 
  3rdparty/libprocess/Makefile.am 583f6ef 
  3rdparty/libprocess/configure.ac 3a38b04 
  configure.ac a9cc6df 
  src/Makefile.am c741cdc 
  src/python/native/ext_modules.py.in a0f74b2 

Diff: https://reviews.apache.org/r/23453/diff/


Testing
---

configure --disable-bundled && make check 
configure && make check 

I did not test a full prefix install, but I relied on the previously defined 
semantics. 


Thanks,

Timothy St. Clair

Re: Review Request 23453: Unbundle glog

[Timothy St. Clair]

> On Aug. 6, 2014, 5:19 p.m., Vinod Kone wrote:
> > Ship It!
> 
> Vinod Kone wrote:
> @tim: want to commit this patch yourself with your new committer creds? 
> let me know if you need help on the right way to push upstream (e.g., no 
> merge commits).

Sounds good! I need to finish my setup then I'll walk it through. 


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23453/#review49752
---


On Aug. 6, 2014, 4:33 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23453/
> ---
> 
> (Updated Aug. 6, 2014, 4:33 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1170
> https://issues.apache.org/jira/browse/MESOS-1170
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against the system installed version of glog. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 705d19c 
>   3rdparty/libprocess/Makefile.am 583f6ef 
>   3rdparty/libprocess/configure.ac 3a38b04 
>   configure.ac a9cc6df 
>   src/Makefile.am c741cdc 
>   src/python/native/ext_modules.py.in a0f74b2 
> 
> Diff: https://reviews.apache.org/r/23453/diff/
> 
> 
> Testing
> ---
> 
> configure --disable-bundled && make check 
> configure && make check 
> 
> I did not test a full prefix install, but I relied on the previously defined 
> semantics. 
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: Update system check to unbundle protobuf

[Timothy St. Clair]

> On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 303
> > <https://reviews.apache.org/r/23086/diff/2/?file=639448#file639448line303>
> >
> > instead of hardcoding the version, is there a way to get this from 
> > 3rdparty versions.am?

So autoconf feeds forward into automake.  I don't know of a clean way to 
handle, unless it went through some common m4.

I'm hoping *this is temporary, and in next version we can remove this entirely 
and just check for protobuf, as it exists on nearly all platforms. 


> On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote:
> > configure.ac, line 347
> > <https://reviews.apache.org/r/23086/diff/2/?file=639449#file639449line347>
> >
> > instead of hardcoding the version, is there a way to get this from 
> > 3rdparty versions.am?

same as previous comment. 


> On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote:
> > src/Makefile.am, line 52
> > <https://reviews.apache.org/r/23086/diff/2/?file=639451#file639451line52>
> >
> > would this work if 'protoc' is installed in a prefix location?

Added a hard check in configure, it should be in the path. 


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review49532
---


On July 22, 2014, 6:14 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated July 22, 2014, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 705d19c 
>   3rdparty/libprocess/configure.ac 3a38b04 
>   configure.ac e747208 
>   mpi/mpiexec-mesos.in da0733f 
>   src/Makefile.am c216e2f 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in 569519b 
>   src/examples/python/test-executor.in 7e8875f 
>   src/examples/python/test-framework.in c4683b9 
>   src/python/setup.py.in b996dfe 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated Aug. 8, 2014, 5:58 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

update from review.


Summary (updated)
-

MESOS-1174: Update system check to unbundle protobuf


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/configure.ac 7b39e63 
  Doxyfile 8bba461 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/Makefile.am 39af036 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 
  src/master/hierarchical_allocator_process.hpp 34f8cd6 
  src/master/master.cpp e688b41 
  src/python/native/ext_modules.py.in 477e63d 
  src/slave/constants.hpp 9030871 
  src/slave/constants.cpp e1da5c0 
  src/slave/containerizer/isolators/network/port_mapping.cpp 938782a 
  src/slave/slave.cpp 787bd05 
  src/tests/allocator_tests.cpp 774528a 
  src/tests/health_check_tests.cpp 731d944 
  src/tests/mesos.cpp 6b5c43f 
  src/tests/port_mapping_tests.cpp a990da3 
  support/timed_tests.sh e060966 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 24407: Use curl-config to locate lib curl when possible

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review50057
---


why not follow the prefix pattern if it's in a non-standard location 
--with-curl=/my/custom/path?

- Timothy St. Clair


On Aug. 6, 2014, 7:37 p.m., Chris Heller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> ---
> 
> (Updated Aug. 6, 2014, 7:37 p.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> If libcurl.a is located on a non-standard path, the test for libcurl in the 
> configure script fails, even if the path is specified in LDFLAGS.
> 
> To work around this we can use curl-config to provide the needed path and 
> link options to the compiler.
> 
> This patch modifies configure.ac to check for curl-config and use its output 
> as an argument to AC_CHECK_LIB if possible.
> 
> 
> Diffs
> -
> 
>   configure.ac a9cc6df 
> 
> Diff: https://reviews.apache.org/r/24407/diff/
> 
> 
> Testing
> ---
> 
> Tested this on Ubuntu 12.04 against master with libcurl in a path not 
> included in LDFLAGS.
> 
> 
> Thanks,
> 
> Chris Heller
> 
>

Review Request 24555: MESOS-1169: unbundle distribute

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24555/
---

Review request for mesos, Adam B and Vinod Kone.


Bugs: MESOS-1169
https://issues.apache.org/jira/browse/MESOS-1169


Repository: mesos-git


Description
---

Enabling unbundling for distribute python utils.


Diffs
-

  3rdparty/Makefile.am 70b45fe 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 

Diff: https://reviews.apache.org/r/24555/diff/


Testing
---

./configure && make check 
./configure --disable-bundled  && make check

For prefixed installs require updated PYTHON_PATH.


Thanks,

Timothy St. Clair

Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
---

Review request for mesos, Adam B and Vinod Kone.


Bugs: MESOS-1693
https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
---

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs
-

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp 14cf317 
  configure.ac 8fb0a3a 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

> On Aug. 11, 2014, 4:57 p.m., Dominic Hamon wrote:
> > Have you tested this on ppc?

Tested no, but it should enable the build now, which was the goal at this 
point. 


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50186
---


On Aug. 11, 2014, 4:45 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> ---
> 
> (Updated Aug. 11, 2014, 4:45 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1693
> https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp 14cf317 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24555: MESOS-1169: unbundle distribute

[Timothy St. Clair]

> On Aug. 11, 2014, 6:50 p.m., Vinod Kone wrote:
> > Have you tested this with a prefix installed 'distribute'?

Has to be PYTHONPATH, on this one. 


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24555/#review50210
---


On Aug. 11, 2014, 3:43 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24555/
> ---
> 
> (Updated Aug. 11, 2014, 3:43 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1169
> https://issues.apache.org/jira/browse/MESOS-1169
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enabling unbundling for distribute python utils.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 70b45fe 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
> 
> Diff: https://reviews.apache.org/r/24555/diff/
> 
> 
> Testing
> ---
> 
> ./configure && make check 
> ./configure --disable-bundled  && make check
> 
> For prefixed installs require updated PYTHON_PATH.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

> On Aug. 11, 2014, 4:57 p.m., Dominic Hamon wrote:
> > Have you tested this on ppc?
> 
> Timothy St. Clair wrote:
> Tested no, but it should enable the build now, which was the goal at this 
> point.
> 
> Vinod Kone wrote:
> Please test this locally before updating upstream.

It's been tested on existing platforms, but I don't have resources to test ppc 
... I just figure we should not inhibit their ability to build as I've been 
explicitly asked to enable.  


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50186
-----------


On Aug. 11, 2014, 4:45 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> ---
> 
> (Updated Aug. 11, 2014, 4:45 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1693
> https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp 14cf317 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated Aug. 11, 2014, 7:11 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

rebase per request. 


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/configure.ac 7b39e63 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/Makefile.am 39af036 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 
  src/python/native/ext_modules.py.in 477e63d 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 24407: Use curl-config to locate lib curl when possible

[Timothy St. Clair]

> On Aug. 8, 2014, 6:31 p.m., Timothy St. Clair wrote:
> > why not follow the prefix pattern if it's in a non-standard location 
> > --with-curl=/my/custom/path?
> 
> Chris Heller wrote:
> I have no problem with that suggestion. I've created a new patch which 
> adds --with-curl (and also supports --with-sasl2 and --with-zlib). Would it 
> be OK to attach the patch to this review, or is it better to close this out 
> and submit again?

Feel free to attach to update the patch to this review for the curl mod, then 
we can create a JIRA and update for the other dep(s). 


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review50057
---


On Aug. 6, 2014, 7:37 p.m., Chris Heller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> ---
> 
> (Updated Aug. 6, 2014, 7:37 p.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> If libcurl.a is located on a non-standard path, the test for libcurl in the 
> configure script fails, even if the path is specified in LDFLAGS.
> 
> To work around this we can use curl-config to provide the needed path and 
> link options to the compiler.
> 
> This patch modifies configure.ac to check for curl-config and use its output 
> as an argument to AC_CHECK_LIB if possible.
> 
> 
> Diffs
> -
> 
>   configure.ac a9cc6df 
> 
> Diff: https://reviews.apache.org/r/24407/diff/
> 
> 
> Testing
> ---
> 
> Tested this on Ubuntu 12.04 against master with libcurl in a path not 
> included in LDFLAGS.
> 
> 
> Thanks,
> 
> Chris Heller
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
---

(Updated Aug. 11, 2014, 8:32 p.m.)


Review request for mesos, Adam B and Benjamin Hindman.


Changes
---

@benh: can you take a look at this?


Bugs: MESOS-1693
https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
---

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs
-

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp 14cf317 
  configure.ac 8fb0a3a 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Review Request 24628: MESOS-1171: unbundle gmock

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24628/
---

Review request for mesos, Jie Yu and Vinod Kone.


Bugs: MESOS-1171
https://issues.apache.org/jira/browse/MESOS-1171


Repository: mesos-git


Description
---

Enable support to build against unbundled versions of gmock.  


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 
  3rdparty/libprocess/configure.ac 7b39e63 
  configure.ac 8fb0a3a 

Diff: https://reviews.apache.org/r/24628/diff/


Testing
---

configure && make check
configure --disable-bundled && make check
configure --with-gmock=/opt/gmock && make check


Thanks,

Timothy St. Clair

Re: Review Request 24407: Use curl-config to locate lib curl when possible

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review50460
---


The option description needs to be added e.g. - 

AC_ARG_WITH([glog],
AS_HELP_STRING([--with-glog@<:@=DIR@:>@],
   [excludes building and using the bundled glog
   package in lieu of an installed version at a
   location prefixed by the given path]),
[without_bundled_glog=yes], [])

Also, you can update the patch via "Update->Update Diff" 

- Timothy St. Clair


On Aug. 11, 2014, 7:28 p.m., Chris Heller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> ---
> 
> (Updated Aug. 11, 2014, 7:28 p.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> If libcurl.a is located on a non-standard path, the test for libcurl in the 
> configure script fails, even if the path is specified in LDFLAGS.
> 
> To work around this we can use curl-config to provide the needed path and 
> link options to the compiler.
> 
> This patch modifies configure.ac to check for curl-config and use its output 
> as an argument to AC_CHECK_LIB if possible.
> 
> 
> Diffs
> -
> 
>   configure.ac a9cc6df 
> 
> Diff: https://reviews.apache.org/r/24407/diff/
> 
> 
> Testing
> ---
> 
> Tested this on Ubuntu 12.04 against master with libcurl in a path not 
> included in LDFLAGS.
> 
> 
> File Attachments
> 
> 
> Add --with-curl, --with-sasl2, --with-zlib to configure
>   
> https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1___configure_with_libs.patch
> 
> 
> Thanks,
> 
> Chris Heller
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

[Timothy St. Clair]

> On Aug. 11, 2014, 9:16 p.m., Vinod Kone wrote:
> > src/examples/python/test-executor.in, lines 24-30
> > <https://reviews.apache.org/r/23086/diff/4/?file=657922#file657922line24>
> >
> > Here and in other example python scripts below, do you want to pass 
> > PROTOBUF_EGG from configure.ac, similar to what you did with PROTOBUF_JAR? 
> > I think that would be more cleaner?
> > 
> >

So I've added a detection for the google.protobuf python module, but it doesn't 
install via prefix, it's a separate step.  I've verified by checking the rpm & 
deb packages.  

So we'll have to verify via PYTHONPATH.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50231
-----------


On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 11, 2014, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 39af036 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated Aug. 13, 2014, 7:28 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

update from review to SUBST protoc and do a python check on google.protobuf.


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp d98d953 
  3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp ce8dd9b 
  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 87c5fc8 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e6 
  3rdparty/libprocess/configure.ac 7b39e63 
  3rdparty/libprocess/include/process/defer.hpp ebe6f2d 
  3rdparty/libprocess/include/process/future.hpp 46ae16b 
  3rdparty/libprocess/src/process.cpp c2bee98 
  configure.ac 8fb0a3a 
  include/mesos/mesos.proto dc781d1 
  mpi/mpiexec-mesos.in 8812ee2 
  src/Makefile.am 0ac95b4 
  src/common/http.hpp afce7fe 
  src/common/http.cpp 58050e9 
  src/common/type_utils.cpp 78bfa94 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 
  src/health-check/main.cpp 6849947 
  src/launcher/executor.cpp 64a4175 
  src/master/http.cpp 6dd11fe 
  src/master/master.cpp e948803 
  src/python/native/ext_modules.py.in 477e63d 
  src/slave/containerizer/mesos/launch.cpp 4e727a1 
  src/slave/http.cpp 92eb348 
  src/slave/slave.cpp 59477d5 
  src/tests/common/http_tests.cpp 5fa51bf 
  src/tests/health_check_tests.cpp 64fbf62 
  src/tests/master_authorization_tests.cpp b9aa7bf 
  src/tests/process_spawn.cpp PRE-CREATION 
  src/tests/reconciliation_tests.cpp 8c66659 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
---

(Updated Aug. 13, 2014, 7:30 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.


Changes
---

Adding Jie as this is a quick review I would like to get in for 0.20


Bugs: MESOS-1693
https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
---

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs
-

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp 14cf317 
  configure.ac 8fb0a3a 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 24555: MESOS-1169: unbundle distribute

[Timothy St. Clair]

> On Aug. 11, 2014, 6:50 p.m., Vinod Kone wrote:
> > Have you tested this with a prefix installed 'distribute'?
> 
> Timothy St. Clair wrote:
> Has to be PYTHONPATH, on this one.

So after talking with others PYTHONPATH is the best override mechanics for 
python dependencies so simply performing the checks and removing --with-pyDEP 
makes the most sense here. 


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24555/#review50210
---


On Aug. 11, 2014, 3:43 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24555/
> ---
> 
> (Updated Aug. 11, 2014, 3:43 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1169
> https://issues.apache.org/jira/browse/MESOS-1169
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enabling unbundling for distribute python utils.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 70b45fe 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
> 
> Diff: https://reviews.apache.org/r/24555/diff/
> 
> 
> Testing
> ---
> 
> ./configure && make check 
> ./configure --disable-bundled  && make check
> 
> For prefixed installs require updated PYTHON_PATH.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24555: MESOS-1169: unbundle distribute

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24555/
---

(Updated Aug. 13, 2014, 7:38 p.m.)


Review request for mesos, Adam B, Jie Yu, and Vinod Kone.


Changes
---

updated to remove --with-PY package, in talking with other developers the 
standard override is PYTHONPATH checks. 


Bugs: MESOS-1169
https://issues.apache.org/jira/browse/MESOS-1169


Repository: mesos-git


Description
---

Enabling unbundling for distribute python utils.


Diffs (updated)
-

  3rdparty/Makefile.am 70b45fe 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 

Diff: https://reviews.apache.org/r/24555/diff/


Testing
---

./configure && make check 
./configure --disable-bundled  && make check

For prefixed installs require updated PYTHON_PATH.


Thanks,

Timothy St. Clair

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated Aug. 13, 2014, 7:46 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

rebased to origin/master


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/configure.ac 7b39e63 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/Makefile.am 0ac95b4 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 
  src/python/native/ext_modules.py.in 477e63d 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 24628: MESOS-1171: unbundle gmock

[Timothy St. Clair]

> On Aug. 13, 2014, 9:40 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/Makefile.am, lines 87-88
> > <https://reviews.apache.org/r/24628/diff/1/?file=659070#file659070line87>
> >
> > How is that we didn't need to include these "src" dirs before but have 
> > to know?

The include changes b/c I had to add a source file redirector 
'gmock_sources.cc' due to limitations on SUBST and _SOURCES in automake. 


> On Aug. 13, 2014, 9:40 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/Makefile.am, line 97
> > <https://reviews.apache.org/r/24628/diff/1/?file=659070#file659070line97>
> >
> > Pull this below #99?
> > 
> > Also, should this be inside if WITH_BUNDLED_GMOCK ?

The file still builds in both cases, so it should not be wrapped in 
WITH_BUNDLED_GMOCK. 


> On Aug. 13, 2014, 9:40 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 175
> > <https://reviews.apache.org/r/24628/diff/1/?file=659072#file659072line175>
> >
> > s/#On/# On/
> > 
> > Also, can you expand on the comment? It's not clear to me why you 
> > including "stdio.h" here. Is it just a dummy?
> > 
> > Also, where is gtest typically located on system installations?

It's a placeholder header for the substitution. 

gtest on a non-prefixed installation will be in the standard search paths.  
On epel & Fedora its /usr/lib64


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24628/#review50494
---


On Aug. 13, 2014, 2:35 a.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24628/
> ---
> 
> (Updated Aug. 13, 2014, 2:35 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1171
> https://issues.apache.org/jira/browse/MESOS-1171
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable support to build against unbundled versions of gmock.  
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24628/diff/
> 
> 
> Testing
> ---
> 
> configure && make check
> configure --disable-bundled && make check
> configure --with-gmock=/opt/gmock && make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24628: MESOS-1171: unbundle gmock

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24628/
---

(Updated Aug. 13, 2014, 9:55 p.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
---

update per review. 


Bugs: MESOS-1171
https://issues.apache.org/jira/browse/MESOS-1171


Repository: mesos-git


Description
---

Enable support to build against unbundled versions of gmock.  


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 
  3rdparty/libprocess/configure.ac 7b39e63 
  configure.ac 8fb0a3a 

Diff: https://reviews.apache.org/r/24628/diff/


Testing
---

configure && make check
configure --disable-bundled && make check
configure --with-gmock=/opt/gmock && make check


Thanks,

Timothy St. Clair

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

[Timothy St. Clair]

> On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote:
> > i'm assuming you tested this with all 3 configurations 
> > (bundled,system,prefix) like you did for gmock?

correct. 


> On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote:
> > configure.ac, line 255
> > <https://reviews.apache.org/r/23086/diff/4-6/?file=657913#file657913line255>
> >
> > shouldn't this be different if we are using bundled "protoc" vs system 
> > installed "protoc"? i guess it is ok here because PROTOCOMPILER is only 
> > used in non-bundled case below and later in src/Makefile.am.
> > 
> > it was definitely a bit confusing to me, so maybe add a comment?
> > 
> > alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it 
> > appropriately for bundled/prefix/system cases. i'm assuming you didn't do 
> > it that way because it isn't easy to get protobuf version?
> >

I updated the logic to make it similar to the others 

elif test "x$enable_bundled" = "xno"; then
  PROTOCOMPILER="protoc"

and added a comment.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50518
---


On Aug. 13, 2014, 7:46 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 13, 2014, 7:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 0ac95b4 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated Aug. 14, 2014, 1:21 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

update per review


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/configure.ac 7b39e63 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/Makefile.am 0ac95b4 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 
  src/python/native/ext_modules.py.in 477e63d 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 24555: MESOS-1169: unbundle distribute

[Timothy St. Clair]

> On Aug. 13, 2014, 11:07 p.m., Vinod Kone wrote:
> > mpi/mpiexec-mesos.in, lines 21-22
> > <https://reviews.apache.org/r/24555/diff/2/?file=659530#file659530line21>
> >
> > In all these scripts, it's weird to me that we print a failed message 
> > even if the user specifically asked us to use a non-bundled egg.
> > 
> > More importantly, if a bundled distribute egg exists in the build dir 
> > (perhaps from an earlier build) we favor it even when the user asked us to 
> > use the system installed version.
> > 
> > My worry is that issues relating to these would be hard to diagnose 
> > down the line.
> > 
> > Does this script have access to WITH_BUNDLED_DISTRIBUTE variable? If 
> > yes we should use that to determine whether to include DISTRIBUTE_EGG in 
> > the PYTHONPATH (down below where we exec). Does that make sense?
> > 
> > I guess we have the same issue with protobuf egg in the earlier review.
> > 
> >

For the script work I honestly think it needs a lot more work and greater in 
scope then just this ticket.  

If it's ok with you, I would like to open some follow up tickets on this.  

Right now it would be an extremely rare case for folks to reconfigure 
bundled/unbundled and build when stale data is around, but I completely agree 
the logic is obtuse and weird.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24555/#review50522
---


On Aug. 14, 2014, 3:04 a.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24555/
> ---
> 
> (Updated Aug. 14, 2014, 3:04 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1169
> https://issues.apache.org/jira/browse/MESOS-1169
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enabling unbundling for distribute python utils.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 70b45fe 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
> 
> Diff: https://reviews.apache.org/r/24555/diff/
> 
> 
> Testing
> ---
> 
> ./configure && make check 
> ./configure --disable-bundled  && make check
> 
> For prefixed installs require updated PYTHON_PATH.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24555: MESOS-1169: unbundle distribute

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24555/
---

(Updated Aug. 14, 2014, 3:04 a.m.)


Review request for mesos, Adam B, Jie Yu, and Vinod Kone.


Changes
---

Update per review. 


Bugs: MESOS-1169
https://issues.apache.org/jira/browse/MESOS-1169


Repository: mesos-git


Description
---

Enabling unbundling for distribute python utils.


Diffs (updated)
-

  3rdparty/Makefile.am 70b45fe 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 

Diff: https://reviews.apache.org/r/24555/diff/


Testing (updated)
---

./configure && make check 
./configure --disable-bundled  && make check

For prefixed installs require updated PYTHON_PATH.


Thanks,

Timothy St. Clair

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

[Timothy St. Clair]

> On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote:
> > configure.ac, line 255
> > <https://reviews.apache.org/r/23086/diff/4-6/?file=657913#file657913line255>
> >
> > shouldn't this be different if we are using bundled "protoc" vs system 
> > installed "protoc"? i guess it is ok here because PROTOCOMPILER is only 
> > used in non-bundled case below and later in src/Makefile.am.
> > 
> > it was definitely a bit confusing to me, so maybe add a comment?
> > 
> > alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it 
> > appropriately for bundled/prefix/system cases. i'm assuming you didn't do 
> > it that way because it isn't easy to get protobuf version?
> >
> 
> Timothy St. Clair wrote:
> I updated the logic to make it similar to the others 
> 
> elif test "x$enable_bundled" = "xno"; then
>   PROTOCOMPILER="protoc"
> 
> and added a comment.
>

Let me know if you would like me to commit.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50518
---


On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 14, 2014, 1:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 0ac95b4 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24628: MESOS-1171: unbundle gmock

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24628/
---

(Updated Aug. 14, 2014, 1:48 p.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
---

rebase patch for clean apply. 


Bugs: MESOS-1171
https://issues.apache.org/jira/browse/MESOS-1171


Repository: mesos-git


Description
---

Enable support to build against unbundled versions of gmock.  


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am ea46d6a 
  3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 
  3rdparty/libprocess/configure.ac d6695ce 
  configure.ac 5653775 

Diff: https://reviews.apache.org/r/24628/diff/


Testing
---

configure && make check
configure --disable-bundled && make check
configure --with-gmock=/opt/gmock && make check


Thanks,

Timothy St. Clair

Re: Review Request 24555: MESOS-1169: unbundle distribute

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24555/
---

(Updated Aug. 14, 2014, 2:45 p.m.)


Review request for mesos, Adam B, Jie Yu, and Vinod Kone.


Changes
---

rebase for clean apply


Bugs: MESOS-1169
https://issues.apache.org/jira/browse/MESOS-1169


Repository: mesos-git


Description
---

Enabling unbundling for distribute python utils.


Diffs (updated)
-

  3rdparty/Makefile.am 70b45fe 
  configure.ac e2d8371 
  mpi/mpiexec-mesos.in 9aa0702 
  src/examples/python/test-containerizer.in 3238ccc 
  src/examples/python/test-executor.in 072fd7d 
  src/examples/python/test-framework.in ee90e55 

Diff: https://reviews.apache.org/r/24555/diff/


Testing
---

./configure && make check 
./configure --disable-bundled  && make check

For prefixed installs require updated PYTHON_PATH.


Thanks,

Timothy St. Clair

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
---

(Updated Aug. 14, 2014, 6:16 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.


Changes
---

update per review.


Bugs: MESOS-1693
https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
---

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs (updated)
-

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp c2bee98 
  configure.ac 321f09d 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 24264: Installed python libraries during make install.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review50616
---


Let me know if you want any help on the updated configure checks.


3rdparty/Makefile.am
<https://reviews.apache.org/r/24264/#comment88486>

should wrap with new build mechanics for checking system



configure.ac
<https://reviews.apache.org/r/24264/#comment88485>

We have a .m4 that can check python mods


- Timothy St. Clair


On Aug. 11, 2014, 6:09 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> ---
> 
> (Updated Aug. 11, 2014, 6:09 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
> 
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 
>   3rdparty/pip-1.5.6.tar.gz PRE-CREATION 
>   3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 
>   3rdparty/wheel-0.24.0.tar.gz PRE-CREATION 
>   configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b 
>   mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 
>   src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 
>   src/examples/python/test-containerizer.in 
> f71828db98a90f455c88d90cb4e3320b7e8c9e9e 
>   src/examples/python/test-executor.in 
> b22e7a7dc0c26f805eb63c7139066ce7dc830636 
>   src/examples/python/test-framework.in 
> 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb 
> 
> Diff: https://reviews.apache.org/r/24264/diff/
> 
> 
> Testing
> ---
> 
> `make distcheck -j6`
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
---

(Updated Aug. 14, 2014, 6:38 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.


Changes
---

remove the nop s


Bugs: MESOS-1693
https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
---

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs (updated)
-

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp c2bee98 
  configure.ac 321f09d 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

> On Aug. 14, 2014, 4:44 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/include/process/internal.hpp, line 18
> > <https://reviews.apache.org/r/24563/diff/1/?file=657649#file657649line18>
> >
> > Do all the other arch have "nop" instruction?

That I'm aware of, yes.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50590
-----------


On Aug. 14, 2014, 6:38 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> ---
> 
> (Updated Aug. 14, 2014, 6:38 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.
> 
> 
> Bugs: MESOS-1693
> https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp c2bee98 
>   configure.ac 321f09d 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24714: fix prefiex glog on mac

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/
---

(Updated Aug. 14, 2014, 9:01 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos-git


Description
---

Fixes on glog check to support mac.


Diffs
-

  3rdparty/libprocess/configure.ac f552e60 
  configure.ac 30a7e26 

Diff: https://reviews.apache.org/r/24714/diff/


Testing
---

./configure --with-glog=/opt/local && make check  


Thanks,

Timothy St. Clair

Re: Review Request 24714: fix prefiex glog on mac

[Timothy St. Clair]

> On Aug. 14, 2014, 9:08 p.m., Vinod Kone wrote:
> > configure.ac, line 281
> > <https://reviews.apache.org/r/24714/diff/1/?file=660837#file660837line281>
> >
> > so "src" worked on linux but not on osx? how's that possible?

It shouldn't have worked.  
It likely flew under the radar due to system installation.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50639
-----------


On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> ---
> 
> (Updated Aug. 14, 2014, 9:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes on glog check to support mac.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60 
>   configure.ac 30a7e26 
> 
> Diff: https://reviews.apache.org/r/24714/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-glog=/opt/local && make check  
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24714: fix prefiex glog on mac

[Timothy St. Clair]

> On Aug. 14, 2014, 9:08 p.m., Vinod Kone wrote:
> > configure.ac, line 281
> > <https://reviews.apache.org/r/24714/diff/1/?file=660837#file660837line281>
> >
> > so "src" worked on linux but not on osx? how's that possible?
> 
> Timothy St. Clair wrote:
> It shouldn't have worked.  
> It likely flew under the radar due to system installation.

https://reviews.apache.org/r/23453/diff/#


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50639
-----------


On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> ---
> 
> (Updated Aug. 14, 2014, 9:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes on glog check to support mac.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60 
>   configure.ac 30a7e26 
> 
> Diff: https://reviews.apache.org/r/24714/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-glog=/opt/local && make check  
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24714: fix prefix glog on mac

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/
---

(Updated Aug. 15, 2014, 1:07 a.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-

fix prefix glog on mac


Repository: mesos-git


Description
---

Fixes on glog check to support mac.


Diffs
-

  3rdparty/libprocess/configure.ac f552e60 
  configure.ac 30a7e26 

Diff: https://reviews.apache.org/r/24714/diff/


Testing
---

./configure --with-glog=/opt/local && make check  


Thanks,

Timothy St. Clair

Re: Review Request 24734: Fixed a few issues in configure.ac.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50719
---


Thanks for all the help guys! & That is an epic configure line ;-) 

We need to be careful here, b/c even if they can build, their runtime will need 
to overload LD_LIBRARY_PATH to point to all the separte locations, and make 
sure that doesn't muck with other applications.  (recommend chroots where 
possible.)


3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/24734/#comment88581>

Don't we need LD_FLAGS here, as Vinod mentioned.



3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/24734/#comment88582>

Switching this check will cause linkage failure on the tests for pure 
--disable-bundled.  It will not affect --prefix installations so I would not 
change this one, it's a distribution only constraint at this point.



configure.ac
<https://reviews.apache.org/r/24734/#comment88583>

This needs to be here or else the includes fail on distributions.


- Timothy St. Clair


On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> ---
> 
> (Updated Aug. 15, 2014, 6:36 a.m.)
> 
> 
> Review request for mesos, Timothy St. Clair and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Merged the fix in https://reviews.apache.org/r/24714/
> 
> Fixed a few other issues.
> 
> Also, did a few consistency/style fix.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634 
>   configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c 
> 
> Diff: https://reviews.apache.org/r/24734/diff/
> 
> 
> Testing
> ---
> 
> On my mac:
> 
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure 
> --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled 
> --with-leveldb=/opt/twitter --with-glog=/opt/twitter 
> --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 
> --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 
> --with-libev=/opt/twitter --with-picojson=/tmp/picojson 
> --with-http-parser=/tmp/http-parser
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 20983: Update system check (http-parser)

[Timothy St. Clair]

> On Aug. 15, 2014, 1:45 a.m., Vinod Kone wrote:
> >

Stuff is flying all over atm, lets rally around 
https://reviews.apache.org/r/24734/ for final cleanup.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20983/#review50690
---


On May 5, 2014, 7:13 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20983/
> ---
> 
> (Updated May 5, 2014, 7:13 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1175
> https://issues.apache.org/jira/browse/MESOS-1175
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Updates libprocess configure check for http-parser to build against system 
> dependencies outlined in MESOS-1071
> + fixes libprocess local 'make check' which was broken
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 980146b 
>   3rdparty/libprocess/Makefile.am 8990f38 
>   3rdparty/libprocess/configure.ac 0c7cc6d 
> 
> Diff: https://reviews.apache.org/r/20983/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24734: Fixed a few issues in configure.ac.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50722
---



3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/24734/#comment88584>

We could add a LIB check, but it's not critical at this point.


- Timothy St. Clair


On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> ---
> 
> (Updated Aug. 15, 2014, 6:36 a.m.)
> 
> 
> Review request for mesos, Timothy St. Clair and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Merged the fix in https://reviews.apache.org/r/24714/
> 
> Fixed a few other issues.
> 
> Also, did a few consistency/style fix.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634 
>   configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c 
> 
> Diff: https://reviews.apache.org/r/24734/diff/
> 
> 
> Testing
> ---
> 
> On my mac:
> 
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure 
> --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled 
> --with-leveldb=/opt/twitter --with-glog=/opt/twitter 
> --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 
> --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 
> --with-libev=/opt/twitter --with-picojson=/tmp/picojson 
> --with-http-parser=/tmp/http-parser
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24714: fix prefix glog on mac

[Timothy St. Clair]

> On Aug. 15, 2014, 8:33 a.m., Mesos ReviewBot wrote:
> > Patch looks great!
> > 
> > Reviews applied: [24714]
> > 
> > All tests passed.

contained in: https://reviews.apache.org/r/24734/ 

Lets close this one out.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50712
---


On Aug. 15, 2014, 1:07 a.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> ---
> 
> (Updated Aug. 15, 2014, 1:07 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes on glog check to support mac.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60 
>   configure.ac 30a7e26 
> 
> Diff: https://reviews.apache.org/r/24714/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-glog=/opt/local && make check  
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24734: Fixed a few issues in configure.ac.

[Timothy St. Clair]

> On Aug. 15, 2014, 2:23 p.m., Timothy St. Clair wrote:
> > configure.ac, line 283
> > <https://reviews.apache.org/r/24734/diff/1/?file=661315#file661315line283>
> >
> > This needs to be here or else the includes fail on distributions.
> 
> Jie Yu wrote:
> Are you saying that I should do:
> 
> CPPFLAGS="$CPPFLAGS -I/usr/include" here?
> 
> Is that the default? I'm curious what the error is?

The build fails on zookeeper.h includes inside of the mesos srouce. b/c the -I 
path is only /usr/include and zookeeper lives under '/usr/include/zookeeper'


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50719
---


On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> -----------
> 
> (Updated Aug. 15, 2014, 6:36 a.m.)
> 
> 
> Review request for mesos, Timothy St. Clair and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Merged the fix in https://reviews.apache.org/r/24714/
> 
> Fixed a few other issues.
> 
> Also, did a few consistency/style fix.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634 
>   configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c 
> 
> Diff: https://reviews.apache.org/r/24734/diff/
> 
> 
> Testing
> ---
> 
> On my mac:
> 
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure 
> --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled 
> --with-leveldb=/opt/twitter --with-glog=/opt/twitter 
> --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 
> --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 
> --with-libev=/opt/twitter --with-picojson=/tmp/picojson 
> --with-http-parser=/tmp/http-parser
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24734: Fixed a few issues in configure.ac.

[Timothy St. Clair]

> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 425
> > <https://reviews.apache.org/r/24734/diff/3/?file=661496#file661496line425>
> >
> > I'm little confused on what the difference is between PROTOCOMPILER vs 
> > PROTOBUF_COMPILER vs PROTOC. can we consolidate?

It's strictly to prefent name collisions.. 

PROTOBUF_COMPILER could probably be PROTOBUF_COMPILER_TEST.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50751
---


On Aug. 15, 2014, 5:19 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> ---
> 
> (Updated Aug. 15, 2014, 5:19 p.m.)
> 
> 
> Review request for mesos, Timothy St. Clair and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Merged the fix in https://reviews.apache.org/r/24714/
> 
> Fixed a few other issues.
> 
> Also, did a few consistency/style fix.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6 
>   configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c 
>   src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c 
>   src/tests/master_contender_detector_tests.cpp 
> fdddfa1a9c793bb406d85d214a18ca4ced53b09f 
>   src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12 
>   src/zookeeper/authentication.hpp 7b6b767b1451bb361c0c26675b642a072f6e5103 
>   src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b 
> 
> Diff: https://reviews.apache.org/r/24734/diff/
> 
> 
> Testing
> ---
> 
> On my mac:
> 
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure 
> --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled 
> --with-leveldb=/opt/twitter --with-glog=/opt/twitter 
> --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 
> --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 
> --with-libev=/opt/twitter --with-picojson=/tmp/picojson 
> --with-http-parser=/tmp/http-parser
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24734: Fixed a few issues in configure.ac.

[Timothy St. Clair]

> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 111
> > <https://reviews.apache.org/r/24734/diff/3/?file=661496#file661496line111>
> >
> > should this be --with-http_parser? "_" between http and parser.

why? 

$ sudo yum list | grep http | grep parse
http-parser.x86_64 2.0-5.20121128gitcd01361.fc20@fedora 
http-parser-devel.x86_64   2.0-5.20121128gitcd01361.fc20@fedora


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50751
---


On Aug. 15, 2014, 5:19 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> ---
> 
> (Updated Aug. 15, 2014, 5:19 p.m.)
> 
> 
> Review request for mesos, Timothy St. Clair and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Merged the fix in https://reviews.apache.org/r/24714/
> 
> Fixed a few other issues.
> 
> Also, did a few consistency/style fix.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6 
>   configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c 
>   src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c 
>   src/tests/master_contender_detector_tests.cpp 
> fdddfa1a9c793bb406d85d214a18ca4ced53b09f 
>   src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12 
>   src/zookeeper/authentication.hpp 7b6b767b1451bb361c0c26675b642a072f6e5103 
>   src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b 
> 
> Diff: https://reviews.apache.org/r/24734/diff/
> 
> 
> Testing
> ---
> 
> On my mac:
> 
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure 
> --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled 
> --with-leveldb=/opt/twitter --with-glog=/opt/twitter 
> --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 
> --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 
> --with-libev=/opt/twitter --with-picojson=/tmp/picojson 
> --with-http-parser=/tmp/http-parser
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24734: Fixed a few issues in configure.ac.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50772
---

Ship it!


Ship It!

- Timothy St. Clair


On Aug. 15, 2014, 6:58 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24734/
> ---
> 
> (Updated Aug. 15, 2014, 6:58 p.m.)
> 
> 
> Review request for mesos, Timothy St. Clair and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Merged the fix in https://reviews.apache.org/r/24714/
> 
> Fixed a few other issues.
> 
> Also, did a few consistency/style fix.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 7ba4fad65a144bfe832e75993e5b8f72fcd66cc6 
>   configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c 
>   src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c 
>   src/tests/master_contender_detector_tests.cpp 
> fdddfa1a9c793bb406d85d214a18ca4ced53b09f 
>   src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12 
> 
> Diff: https://reviews.apache.org/r/24734/diff/
> 
> 
> Testing
> ---
> 
> On my mac:
> 
> CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure 
> --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled 
> --with-leveldb=/opt/twitter --with-glog=/opt/twitter 
> --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 
> --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 
> --with-libev=/opt/twitter --with-picojson=/tmp/picojson 
> --with-http-parser=/tmp/http-parser
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24816: MESOS-1208: Add -Wno-unused-local-typedefs if gcc version is >= 4.8

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24816/#review51198
---

Ship it!


I'm @ Mesoscon so I'll try to commit shortly.

- Timothy St. Clair


On Aug. 20, 2014, 8:29 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24816/
> ---
> 
> (Updated Aug. 20, 2014, 8:29 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1208
> https://issues.apache.org/jira/browse/MESOS-1208
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes `MESOS-1208`. The issue is that starting from GCC 4.8, `-Wall` includes 
> `-Wunused-local-typedefs` by default. Since `-Werror` is also present, we end 
> up with an error. I think the better fix would be to update boost, but this 
> fix has less risk.
> 
> EDIT: Turns out we were already handling this, but only for GCC 4.8. Modify 
> `configure.ac` to handle it for >= GCC 4.8 instead.
> 
> 
> Diffs
> -
> 
>   configure.ac 73ccbbe20cb45d8df60bcf0120b8c248fe969b2c 
> 
> Diff: https://reviews.apache.org/r/24816/diff/
> 
> 
> Testing
> ---
> 
> Successfully ran `make`. However, `make check` seems to fail. If all passes 
> with GCC 4.6, it may be an indication that using GCC 4.9 to compile Mesos has 
> further problems.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 24816: MESOS-1208: Add -Wno-unused-local-typedefs if gcc version is >= 4.8

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24816/#review51213
---

Ship it!


Ship It!

- Timothy St. Clair


On Aug. 20, 2014, 8:29 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24816/
> ---
> 
> (Updated Aug. 20, 2014, 8:29 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1208
> https://issues.apache.org/jira/browse/MESOS-1208
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes `MESOS-1208`. The issue is that starting from GCC 4.8, `-Wall` includes 
> `-Wunused-local-typedefs` by default. Since `-Werror` is also present, we end 
> up with an error. I think the better fix would be to update boost, but this 
> fix has less risk.
> 
> EDIT: Turns out we were already handling this, but only for GCC 4.8. Modify 
> `configure.ac` to handle it for >= GCC 4.8 instead.
> 
> 
> Diffs
> -
> 
>   configure.ac 73ccbbe20cb45d8df60bcf0120b8c248fe969b2c 
> 
> Diff: https://reviews.apache.org/r/24816/diff/
> 
> 
> Testing
> ---
> 
> Successfully ran `make`. However, `make check` seems to fail. If all passes 
> with GCC 4.6, it may be an indication that using GCC 4.9 to compile Mesos has 
> further problems.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 25030: Replaced PKG_CHECK_MODULES with AC_CHECKs in configure.ac.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25030/#review51468
---



configure.ac
<https://reviews.apache.org/r/25030/#comment89816>

Can we just do the compile check?


- Timothy St. Clair


On Aug. 25, 2014, 11:29 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25030/
> ---
> 
> (Updated Aug. 25, 2014, 11:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary and ticket. Some people suggested that PKG_CHECK_MODULES is 
> considered harmful.
> 
> 
> Diffs
> -
> 
>   configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c 
>   m4/ax_cxx_check_lib.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25030/diff/
> 
> 
> Testing
> ---
> 
> ./bootstrap.sh
> ./configure
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 25031: Replaced PKG_CHECK_MODULES with AC_CHECKs in configure.ac.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25031/#review51469
---


Provided the license is ok, I'm a ship it!

- Timothy St. Clair


On Aug. 25, 2014, 11:30 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25031/
> ---
> 
> (Updated Aug. 25, 2014, 11:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 053cf665597bd36c302272136d964bf6949b2993 
>   3rdparty/libprocess/m4/ax_cxx_check_lib.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25031/diff/
> 
> 
> Testing
> ---
> 
> ./bootstrap.sh
> ./configure
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24407: Use curl-config to locate lib curl when possible

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review51474
---

Ship it!


Sorry for the lag, I'm still catching up post #MesosCon

- Timothy St. Clair


On Aug. 15, 2014, 9:14 p.m., Chris Heller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> ---
> 
> (Updated Aug. 15, 2014, 9:14 p.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> If libcurl.a is located on a non-standard path, the test for libcurl in the 
> configure script fails, even if the path is specified in LDFLAGS.
> 
> To work around this we can use curl-config to provide the needed path and 
> link options to the compiler.
> 
> This patch modifies configure.ac to check for curl-config and use its output 
> as an argument to AC_CHECK_LIB if possible.
> 
> 
> Diffs
> -
> 
>   configure.ac 87bfb7e 
> 
> Diff: https://reviews.apache.org/r/24407/diff/
> 
> 
> Testing
> ---
> 
> Tested this on Ubuntu 12.04 against master with libcurl in a path not 
> included in LDFLAGS.
> 
> 
> File Attachments
> 
> 
> Add --with-curl, --with-sasl2, --with-zlib to configure
>   
> https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1___configure_with_libs.patch
> 
> 
> Thanks,
> 
> Chris Heller
> 
>

Re: Review Request 25031: Replaced PKG_CHECK_MODULES with AC_CHECKs in configure.ac.

[Timothy St. Clair]

> On Aug. 26, 2014, 12:39 a.m., Timothy St. Clair wrote:
> > Provided the license is ok, I'm a ship it!
> 
> Jie Yu wrote:
> It has the same license as m4/acx_pthread.m4 which already exists in the 
> repo.
> 
> However, all of them are GNU with AC exception, do you think that's ok?

Not a lawyer, still asking around.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25031/#review51469
---


On Aug. 25, 2014, 11:30 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25031/
> ---
> 
> (Updated Aug. 25, 2014, 11:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 053cf665597bd36c302272136d964bf6949b2993 
>   3rdparty/libprocess/m4/ax_cxx_check_lib.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25031/diff/
> 
> 
> Testing
> ---
> 
> ./bootstrap.sh
> ./configure
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24407: Use curl-config to locate lib curl when possible

[Timothy St. Clair]

> On Aug. 26, 2014, 12:56 a.m., Timothy St. Clair wrote:
> > Sorry for the lag, I'm still catching up post #MesosCon

You can mark as submitted. 

commit a56be86b950c2f64fa98d7f55488afbc7c68e468
Author: Chris Heller 
Date:   Tue Aug 26 11:08:01 2014 -0500


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review51474
---


On Aug. 15, 2014, 9:14 p.m., Chris Heller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> ---
> 
> (Updated Aug. 15, 2014, 9:14 p.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> If libcurl.a is located on a non-standard path, the test for libcurl in the 
> configure script fails, even if the path is specified in LDFLAGS.
> 
> To work around this we can use curl-config to provide the needed path and 
> link options to the compiler.
> 
> This patch modifies configure.ac to check for curl-config and use its output 
> as an argument to AC_CHECK_LIB if possible.
> 
> 
> Diffs
> -
> 
>   configure.ac 87bfb7e 
> 
> Diff: https://reviews.apache.org/r/24407/diff/
> 
> 
> Testing
> ---
> 
> Tested this on Ubuntu 12.04 against master with libcurl in a path not 
> included in LDFLAGS.
> 
> 
> File Attachments
> 
> 
> Add --with-curl, --with-sasl2, --with-zlib to configure
>   
> https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1___configure_with_libs.patch
> 
> 
> Thanks,
> 
> Chris Heller
> 
>

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25270/#review52347
---



src/docker/docker.cpp
<https://reviews.apache.org/r/25270/#comment91110>

Don't you want --host= and --bridge=br(x), in the case where folks 
configure bridges for vlans?


- Timothy St. Clair


On Sept. 2, 2014, 8:47 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25270/
> ---
> 
> (Updated Sept. 2, 2014, 8:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable bridge networking and port mapping for Docker
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto dea51f9 
>   src/docker/docker.cpp af51ac9 
>   src/slave/slave.cpp 5c76dd1 
>   src/tests/docker_containerizer_tests.cpp 8654f9c 
> 
> Diff: https://reviews.apache.org/r/25270/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Review Request 25355: Minor update to include package config file

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25355/
---

Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Bugs: MESOS-1764
https://issues.apache.org/jira/browse/MESOS-1764


Repository: mesos-git


Description
---

Minor update to include package config file 


Diffs
-

  Makefile.am e4ffa35 

Diff: https://reviews.apache.org/r/25355/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 25355: Minor update to include package config file

[Timothy St. Clair]

> On Sept. 4, 2014, 9:19 p.m., Vinod Kone wrote:
> > Makefile.am, lines 27-28
> > <https://reviews.apache.org/r/25355/diff/1/?file=679007#file679007line27>
> >
> > i'm likely missing context. what is this for?

A while back we added a package config file, or .pc file.  This mod installs it 
in the default location.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25355/#review52358
-------


On Sept. 4, 2014, 9 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25355/
> ---
> 
> (Updated Sept. 4, 2014, 9 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
> https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Minor update to include package config file 
> 
> 
> Diffs
> -
> 
>   Makefile.am e4ffa35 
> 
> Diff: https://reviews.apache.org/r/25355/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Review Request 25447: Update deploy_dir from localstate to sysconf

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25447/
---

Review request for mesos, Jie Yu and Vinod Kone.


Bugs: MESOS-1764
https://issues.apache.org/jira/browse/MESOS-1764


Repository: mesos-git


Description
---

Updates the mesos-env files to install to /etc/mesos vs. /var/lib/deploy/mesos.


Diffs
-

  src/Makefile.am 5526189 
  src/deploy/mesos-daemon.sh.in b9866ac 
  src/deploy/mesos-start-cluster.sh.in 500fb5c 
  src/deploy/mesos-start-masters.sh.in 36641ec 
  src/deploy/mesos-start-slaves.sh.in 8661c8d 
  src/deploy/mesos-stop-masters.sh.in c85c977 
  src/deploy/mesos-stop-slaves.sh.in ea5b26a 

Diff: https://reviews.apache.org/r/25447/diff/


Testing
---

make check && make install


Thanks,

Timothy St. Clair

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25439/#review52610
---

Ship it!


Ship It!

- Timothy St. Clair


On Sept. 8, 2014, 2:27 p.m., Kamil Doma?ski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25439/
> ---
> 
> (Updated Sept. 8, 2014, 2:27 p.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1774
> https://issues.apache.org/jira/browse/MESOS-1774
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> MESOS-1774
> 
> 
> Diffs
> -
> 
>   m4/ac_python_module.m4 5cb56ab01e9976d0d30a2e2960af007fc6400667 
> 
> Diff: https://reviews.apache.org/r/25439/diff/
> 
> 
> Testing
> ---
> 
>  ./configure --disable-bundled
> 
> 
> Thanks,
> 
> Kamil Doma?ski
> 
>

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25439/#review52717
---


Could you please rebase for clean apply.

- Timothy St. Clair


On Sept. 8, 2014, 6:35 p.m., Kamil Domanski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25439/
> ---
> 
> (Updated Sept. 8, 2014, 6:35 p.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1774
> https://issues.apache.org/jira/browse/MESOS-1774
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> MESOS-1774
> 
> 
> Diffs
> -
> 
>   m4/ac_python_module.m4 5cb56ab01e9976d0d30a2e2960af007fc6400667 
> 
> Diff: https://reviews.apache.org/r/25439/diff/
> 
> 
> Testing
> ---
> 
>  ./configure --disable-bundled
> 
> 
> Thanks,
> 
> Kamil Domanski
> 
>

Re: Review Request 25447: Update deploy_dir from localstate to sysconf

[Timothy St. Clair]

> On Sept. 9, 2014, 12:55 a.m., Vinod Kone wrote:
> > This probably needs a call out in the CHANGELOG so that people are not 
> > surprised by it. Also, do you know of anyone using/depending on it? If yes, 
> > this probably needs to go through a deprecation cycle.

Are there any mechanics to automatically cull the JIRA's to draft a changelog?


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25447/#review52659
---


On Sept. 8, 2014, 4:48 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25447/
> ---
> 
> (Updated Sept. 8, 2014, 4:48 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
> https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Updates the mesos-env files to install to /etc/mesos vs. 
> /var/lib/deploy/mesos.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5526189 
>   src/deploy/mesos-daemon.sh.in b9866ac 
>   src/deploy/mesos-start-cluster.sh.in 500fb5c 
>   src/deploy/mesos-start-masters.sh.in 36641ec 
>   src/deploy/mesos-start-slaves.sh.in 8661c8d 
>   src/deploy/mesos-stop-masters.sh.in c85c977 
>   src/deploy/mesos-stop-slaves.sh.in ea5b26a 
> 
> Diff: https://reviews.apache.org/r/25447/diff/
> 
> 
> Testing
> ---
> 
> make check && make install
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25447: Update deploy_dir from localstate to sysconf

[Timothy St. Clair]

> On Sept. 9, 2014, 12:55 a.m., Vinod Kone wrote:
> > This probably needs a call out in the CHANGELOG so that people are not 
> > surprised by it. Also, do you know of anyone using/depending on it? If yes, 
> > this probably needs to go through a deprecation cycle.
> 
> Timothy St. Clair wrote:
> Are there any mechanics to automatically cull the JIRA's to draft a 
> changelog?
> 
> Vinod Kone wrote:
> yup. see our releae guide. 
> http://mesos.apache.org/documentation/latest/release-guide/

I updated the thread and I'll keep track if it needs to go through a 
deprecation cycle.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25447/#review52659
-----------


On Sept. 8, 2014, 4:48 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25447/
> ---
> 
> (Updated Sept. 8, 2014, 4:48 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
> https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Updates the mesos-env files to install to /etc/mesos vs. 
> /var/lib/deploy/mesos.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5526189 
>   src/deploy/mesos-daemon.sh.in b9866ac 
>   src/deploy/mesos-start-cluster.sh.in 500fb5c 
>   src/deploy/mesos-start-masters.sh.in 36641ec 
>   src/deploy/mesos-start-slaves.sh.in 8661c8d 
>   src/deploy/mesos-stop-masters.sh.in c85c977 
>   src/deploy/mesos-stop-slaves.sh.in ea5b26a 
> 
> Diff: https://reviews.apache.org/r/25447/diff/
> 
> 
> Testing
> ---
> 
> make check && make install
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Review Request 25508: Fix git clean -xdf skipping leveldb

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25508/
---

Review request for mesos, Jie Yu and Vinod Kone.


Bugs: MESOS-1764
https://issues.apache.org/jira/browse/MESOS-1764


Repository: mesos-git


Description
---

Very minor change to allow git clean -xdf to remove the leveldb directory


Diffs
-

  3rdparty/Makefile.am 7cf0c88 

Diff: https://reviews.apache.org/r/25508/diff/


Testing
---

make check 


Thanks,

Timothy St. Clair

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

[Timothy St. Clair]

> On Sept. 10, 2014, 5:26 p.m., Vinod Kone wrote:
> > 3rdparty/Makefile.am, line 84
> > <https://reviews.apache.org/r/25508/diff/1/?file=684613#file684613line84>
> >
> > didn't realize that the leveldb we bundle has git files in it! isn't 
> > the proper fix here to bundle a proper 'dist'ribution of leveldb instead of 
> > its git tree?

You're probably right.  I didn't want to rethunk a tarball though.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25508/#review52894
-----------


On Sept. 10, 2014, 4:30 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25508/
> ---
> 
> (Updated Sept. 10, 2014, 4:30 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
> https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Very minor change to allow git clean -xdf to remove the leveldb directory
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 7cf0c88 
> 
> Diff: https://reviews.apache.org/r/25508/diff/
> 
> 
> Testing
> ---
> 
> make check 
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25439/#review52898
---

Ship it!


Ship It!

- Timothy St. Clair


On Sept. 9, 2014, 2:49 p.m., Kamil Domanski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25439/
> ---
> 
> (Updated Sept. 9, 2014, 2:49 p.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1774
> https://issues.apache.org/jira/browse/MESOS-1774
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> MESOS-1774
> 
> 
> Diffs
> -
> 
>   m4/ac_python_module.m4 8360b65434e3c1912e2b8670f70e4130352a3c92 
> 
> Diff: https://reviews.apache.org/r/25439/diff/
> 
> 
> Testing
> ---
> 
>  ./configure --disable-bundled
> 
> 
> Thanks,
> 
> Kamil Domanski
> 
>

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

[Timothy St. Clair]

> On Sept. 10, 2014, 5:26 p.m., Vinod Kone wrote:
> > 3rdparty/Makefile.am, line 84
> > <https://reviews.apache.org/r/25508/diff/1/?file=684613#file684613line84>
> >
> > didn't realize that the leveldb we bundle has git files in it! isn't 
> > the proper fix here to bundle a proper 'dist'ribution of leveldb instead of 
> > its git tree?
> 
> Timothy St. Clair wrote:
> You're probably right.  I didn't want to rethunk a tarball though.
> 
> Vinod Kone wrote:
> can you try with replacing the bundled leveldb.tar.gz with this?
> 
> git archive -o leveldb.tar.gz --prefix=leveldb/ HEAD  (# run this from 
> unbundled leveldb clone, e.g., mesos/build/3rdparty/leveldb)
> 
> once you confirm that works, just have this patch be a replacement of the 
> .tar.gz. sounds good?

So if you navigate into the leveldb folder and run: 

'git archive --format=tar.gz --prefix=leveldb/ origin/master > leveldb.tar.gz' 
&& mv -f leveldb.tar.gz ../

It works, but it produces a large binary diff.  

How do you want to handle *this?


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25508/#review52894
---


On Sept. 10, 2014, 4:30 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25508/
> ---
> 
> (Updated Sept. 10, 2014, 4:30 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
> https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Very minor change to allow git clean -xdf to remove the leveldb directory
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 7cf0c88 
> 
> Diff: https://reviews.apache.org/r/25508/diff/
> 
> 
> Testing
> ---
> 
> make check 
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25508/#review52919
---

Ship it!


So for completeness the actual diff is not posted here b/c it is a binary blob 
re: comments, but was the result of the following: 

cd 3rdparty
tar -xzf leveldb.tar.gz 
cd leveldb 
git archive --format=tar.gz --prefix=leveldb/ origin/master > leveldb.tar.gz
mv leveldb.tar.gz ../ 
cd .. 
rm -rf leveldb 

then proceed to test the make mechanics as b4. 

git clean -xdf now removes the leveldb subdir.

- Timothy St. Clair


On Sept. 10, 2014, 4:30 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25508/
> ---
> 
> (Updated Sept. 10, 2014, 4:30 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
> https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Very minor change to allow git clean -xdf to remove the leveldb directory
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 7cf0c88 
> 
> Diff: https://reviews.apache.org/r/25508/diff/
> 
> 
> Testing
> ---
> 
> make check 
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25434/#review53038
---



src/exec/exec.cpp
<https://reviews.apache.org/r/25434/#comment92392>

Maybe I'm missing something, but is there a reason we don't check before a 
delay?  If ShutdownProcess is spawned, it's possible all other processes in the 
group have already cleaned up.



src/exec/exec.cpp
<https://reviews.apache.org/r/25434/#comment92395>

Does it make more sense to provide a sane default  and log in the case of 
bad config.  Doesn't CHECK_SOME bail?



src/launcher/executor.cpp
<https://reviews.apache.org/r/25434/#comment92399>

Doesn't the flags load export override for env vars that are on the commend 
line?  I would keep the original comment.  

e.g. 

cat /etc/mesos/mesos-slave-env.sh 
export MESOS_containerizers=docker,mesos



src/launcher/executor.cpp
<https://reviews.apache.org/r/25434/#comment92400>

I see we all agree here ;-)



src/launcher/executor.cpp
<https://reviews.apache.org/r/25434/#comment92402>

Same logic as above, do we want to bail on bad config or sane default?  
Imagine thousands of computers and some depoy script gets botched.



src/launcher/executor.cpp
<https://reviews.apache.org/r/25434/#comment92404>

imho the shutdown timeout logic should be part of a utility function, vs. 
re-creating in different locations, with subtle differences.



src/slave/containerizer/containerizer.hpp
<https://reviews.apache.org/r/25434/#comment92407>

This is more of a general comment for the gallery, but as signatures keep 
growing at some point we need to determine a limit and either create a utility 
class | struct to encapsulate.  

This appears to be a general theme.



src/tests/containerizer.cpp
<https://reviews.apache.org/r/25434/#comment92408>

Manifest constant please.


- Timothy St. Clair


On Sept. 9, 2014, 12:54 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25434/
> ---
> 
> (Updated Sept. 9, 2014, 12:54 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-1571
> https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The configurable slave's executor_shutdown_grace_period flag is propagated to 
> Executor and CommandExecutor through an environment variable. Shutdown 
> timeout in Executor and signal escalation timeout in CommandExecutor are now 
> dependent on this flag. Each nested timeout is somewhat shorter than the 
> parent one.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp 36d1778 
>   src/launcher/executor.cpp 12ac14b 
>   src/slave/constants.hpp 9030871 
>   src/slave/constants.cpp e1da5c0 
>   src/slave/containerizer/containerizer.hpp 8a66412 
>   src/slave/containerizer/containerizer.cpp 0254679 
>   src/slave/containerizer/docker.cpp 0febbac 
>   src/slave/containerizer/external_containerizer.cpp efbc68f 
>   src/slave/containerizer/mesos/containerizer.cpp 9d08329 
>   src/slave/flags.hpp 21e0021 
>   src/tests/containerizer.cpp a17e1e0 
> 
> Diff: https://reviews.apache.org/r/25434/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.9.4; Ubuntu 14.04 amd64)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 25551: Add standard versioning to shared libmesos.so

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551/
---

Review request for mesos, Jie Yu and Vinod Kone.


Bugs: MESOS-1764
https://issues.apache.org/jira/browse/MESOS-1764


Repository: mesos-git


Description
---

Add standard -version-info to shared libmesos, it will need to be updated on 
major modifications.


Diffs
-

  src/Makefile.am 9b973e5 

Diff: https://reviews.apache.org/r/25551/diff/


Testing
---

make check 


Thanks,

Timothy St. Clair

Re: Review Request 25551: Add standard versioning to shared libmesos.so

[Timothy St. Clair]

> On Sept. 11, 2014, 8:15 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 565
> > <https://reviews.apache.org/r/25551/diff/1/?file=686371#file686371line565>
> >
> > What is the benefit of doing this now? I think we need to have a 
> > discussion around how to version the library before we go down this path, 
> > MESOS-1675? 
> > 
> > Also, is this backwards compatible?

I commented on the JIRA, we can hash it out there.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551/#review53099
---------------


On Sept. 11, 2014, 7:56 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25551/
> ---
> 
> (Updated Sept. 11, 2014, 7:56 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
> https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Add standard -version-info to shared libmesos, it will need to be updated on 
> major modifications.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9b973e5 
> 
> Diff: https://reviews.apache.org/r/25551/diff/
> 
> 
> Testing
> ---
> 
> make check 
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25035: Fix for MESOS-1688

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review53343
---



src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/25035/#comment92977>

What happens in the case where all CPUs are taken but memory is available?  
It looks like it will return (true), but this should not be possible. 

I think you want to give an offer in the case where there are CPU resources 
available, but memory is consumed by the executor.


- Timothy St. Clair


On Sept. 13, 2014, 7:10 p.m., Martin Weindel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25035/
> ---
> 
> (Updated Sept. 13, 2014, 7:10 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1688
> https://issues.apache.org/jira/browse/MESOS-1688
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> As already explained in JIRA MESOS-1688, there are schedulers allocating 
> memory only for the executor and not for tasks. For tasks only CPU resources 
> are allocated in this case.
> Such a scheduler does not get offered any idle CPUs if the slave has nearly 
> used up all memory.
> This can easily lead to a dead lock (in the application, not in Mesos).
> 
> Simple example:
> 1. Scheduler allocates all memory of a slave for an executor
> 2. Scheduler launches a task for this executor (allocating 1 CPU)
> 3. Task finishes: 1 CPU , 0 MB memory allocatable.
> 4. No offers are made, as no memory is left. Scheduler will wait for offers 
> forever. Dead lock in the application.
> 
> To fix this problem, offers must be made if CPU resources are allocatable 
> without considering allocatable memory
> 
> 
> Diffs
> -
> 
>   CHANGELOG a822cc4 
>   src/common/resources.cpp edf36b1 
>   src/master/constants.cpp faa1503 
>   src/master/hierarchical_allocator_process.hpp 34f8cd6 
>   src/master/master.cpp 18464ba 
>   src/tests/allocator_tests.cpp 774528a 
> 
> Diff: https://reviews.apache.org/r/25035/diff/
> 
> 
> Testing
> ---
> 
> Deployed patched Mesos 0.19.1 on a small cluster with 3 slaves and tested 
> running multiple parallel Spark jobs in "fine-grained" mode to saturate 
> allocatable memory. The jobs run fine now. This load always caused a dead 
> lock in all Spark jobs within one minute with the unpatched Mesos.
> 
> 
> Thanks,
> 
> Martin Weindel
> 
>

Re: Review Request 22980: Enable support for existing cgroups, don't always try to create.

[Timothy St. Clair]

> On July 15, 2014, 6:03 a.m., Jie Yu wrote:
> > Tim, sorry for getting to your reviews late. I'm really swamped recently. 
> > Thank you for your patience.
> > 
> > I discovered at least three problems in this patch that needs to be 
> > addressed.
> > 
> > 1) In CgroupsCpushareIsolatorProcess::cleanup, for each 'hierarchy', you'll 
> > gonna call 'cgroups::destroy(hierarchy, info->cgroup, 
> > cgroups::DESTROY_TIMEOUT)'. If cpu,cpuacct are co-mounted, you'll gonna 
> > delete the same cgroup simultaneously by two threads!
> > 
> > 2) In CgroupsCpushareIsolatorProcess::isolate, you'll gonna call 
> > 'cgroups::assign' twice for the same cgroup. Although this is not a 
> > correctness problem, we should avoid that as much as possible.
> > 
> > 3) In CgroupsCpushareIsolatorProcess::recover, removing orphans will be 
> > done twice for each cgroup (although it's not a correctness issue because 
> > there will be no orphan for 'cpuacct' as all orphans will be removed when 
> > the control exits the loop for hierarchies["cpu"]).
> > 
> > I understand that the main trouble here is that our current containerizer 
> > code assumes a very specific cgroups layout (i.e., one subsystem per 
> > hierarchy, all nicely located under a base hierarchy like /sys/fs/cgroup). 
> > If a user has pre-mounted a few subsystems in non-standard locations, the 
> > current code will just fail during 'cgroups::prepare()'.
> > 
> > I really wanna change that. We can solve that iteratively. We probably 
> > wanna change 'cgroups::prepare' a little bit to handle pre-mounted cases. 
> > For example: instead of returning 'path::join(baseHierarchy, subsystem);' 
> > all the time, we can return the hierarchy where the 'subsystem' has already 
> > been pre-mounted (if that's the case). You probably wanna check the 
> > 'cgroups::hierarchy(subsystem)' function.
> > 
> > Then, in the cpushare isolator, during 
> > 'CgroupsCpushareIsolatorProcess::create', we can still maintain a map 
> > 'hierarchies: subsystem -> hierarchy'. In addition, we also keeps a vector 
> > 'subsystems': if it's a co-mounted situation, subsystems=['cpu,cpuacct'], 
> > otherwise subsystems=['cpu', 'cpuacct']. In that way, whenever you want to 
> > create/destroy a cgroup, we can do:
> > 
> > foreach (const string& subsystem, subsystems) {
> >   hierarchy = hierarchies[subsystem];
> >   // create/destroy cgroup.
> >   // ...
> > }
> > 
> > Let me know your thoughts or comments.
> 
> Timothy St. Clair wrote:
> Thanks for the feedback, I'll take a look today.

I'll post a new review which combines the other one and abandon this one.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22980/#review47764
---


On July 14, 2014, 8:04 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22980/
> ---
> 
> (Updated July 14, 2014, 8:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Currently if a controller is mounted outside of mesos perview it errors out.  
> This fixes that issue. 
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a80 
>   src/slave/containerizer/isolators/cgroups/mem.cpp e8d1e35 
> 
> Diff: https://reviews.apache.org/r/22980/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Review Request 25695: Update to enable systemd control of mesos services

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/
---

Review request for mesos, Jie Yu and Vinod Kone.


Bugs: MESOS-1195
https://issues.apache.org/jira/browse/MESOS-1195


Repository: mesos-git


Description
---

This update enables support for systemd co-managed cgroup controllers


Diffs
-

  configure.ac c4b4391 
  src/linux/cgroups.cpp 5093b4c 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 

Diff: https://reviews.apache.org/r/25695/diff/


Testing
---

systemctl start mesos-master mesos-slave
several runs of 'mesos execute' to verify creation and cleanup.
systemctl stop mesos-master mesos-slave

make check


Thanks,

Timothy St. Clair

Re: Review Request 25695: Update to enable systemd control of mesos services

[Timothy St. Clair]

or... g++ -E
> > checking for ld used by g++... /usr/bin/ld -m elf_x86_64
> > checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
> > checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
> > libraries... yes
> > checking for g++ option to produce PIC... -fPIC -DPIC
> > checking if g++ PIC flag -fPIC -DPIC works... yes
> > checking if g++ static flag -static works... yes
> > checking if g++ supports -c -o file.o... yes
> > checking if g++ supports -c -o file.o... (cached) yes
> > checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
> > libraries... yes
> > checking dynamic linker characteristics... (cached) GNU/Linux ld.so
> > checking how to hardcode library paths into programs... immediate
> > configure: creating ./config.lt
> > config.lt: creating libtool
> > configure: Setting up build environment for x86_64 linux-gnu
> > checking whether we are using the GNU C++ compiler... (cached) yes
> > checking whether g++ accepts -g... (cached) yes
> > checking dependency style of g++... (cached) gcc3
> > checking whether we are using the GNU C compiler... (cached) yes
> > checking whether gcc accepts -g... (cached) yes
> > checking for gcc option to accept ISO C89... (cached) none needed
> > checking whether gcc understands -c and -o together... (cached) yes
> > checking dependency style of gcc... (cached) gcc3
> > checking for pkg-config... /usr/bin/pkg-config
> > checking pkg-config is at least version 0.9.0... yes
> > checking for SYSTEMD... no
> > configure: error: Package requirements (libsystemd-daemon) were not met:
> > 
> > No package 'libsystemd-daemon' found
> > 
> > Consider adjusting the PKG_CONFIG_PATH environment variable if you
> > installed software in a non-standard prefix.
> > 
> > Alternatively, you may set the environment variables SYSTEMD_CFLAGS
> > and SYSTEMD_LIBS to avoid the need to call pkg-config.
> > See the pkg-config man page for more details.

whoops, fix coming.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/#review53534
---


On Sept. 16, 2014, 3:03 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25695/
> ---
> 
> (Updated Sept. 16, 2014, 3:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This update enables support for systemd co-managed cgroup controllers
> 
> 
> Diffs
> -
> 
>   configure.ac c4b4391 
>   src/linux/cgroups.cpp 5093b4c 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 
> 
> Diff: https://reviews.apache.org/r/25695/diff/
> 
> 
> Testing
> ---
> 
> systemctl start mesos-master mesos-slave
> several runs of 'mesos execute' to verify creation and cleanup.
> systemctl stop mesos-master mesos-slave
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25695: Update to enable systemd control of mesos services

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/
---

(Updated Sept. 16, 2014, 6:19 p.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
---

minor update to pass on missing dependency check.


Bugs: MESOS-1195
https://issues.apache.org/jira/browse/MESOS-1195


Repository: mesos-git


Description
---

This update enables support for systemd co-managed cgroup controllers


Diffs (updated)
-

  configure.ac c4b4391 
  src/linux/cgroups.cpp 5093b4c 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 

Diff: https://reviews.apache.org/r/25695/diff/


Testing
---

systemctl start mesos-master mesos-slave
several runs of 'mesos execute' to verify creation and cleanup.
systemctl stop mesos-master mesos-slave

make check


Thanks,

Timothy St. Clair

Re: Review Request 25035: Fix for MESOS-1688

[Timothy St. Clair]

> On Sept. 15, 2014, 3:23 p.m., Timothy St. Clair wrote:
> > src/master/hierarchical_allocator_process.hpp, line 837
> > <https://reviews.apache.org/r/25035/diff/7/?file=688721#file688721line837>
> >
> > What happens in the case where all CPUs are taken but memory is 
> > available?  It looks like it will return (true), but this should not be 
> > possible. 
> > 
> > I think you want to give an offer in the case where there are CPU 
> > resources available, but memory is consumed by the executor.
> 
> Vinod Kone wrote:
> Giving memory only resources is ok as long as it is used for a task and 
> not an executor. See my comments above.

Could you please add a detailed comment in the code above the mod, as on 1st 
inspection it leaves me still feeling unsettled.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review53343
---


On Sept. 16, 2014, 9:05 p.m., Martin Weindel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25035/
> ---
> 
> (Updated Sept. 16, 2014, 9:05 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1688
> https://issues.apache.org/jira/browse/MESOS-1688
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> As already explained in JIRA MESOS-1688, there are schedulers allocating 
> memory only for the executor and not for tasks. For tasks only CPU resources 
> are allocated in this case.
> Such a scheduler does not get offered any idle CPUs if the slave has nearly 
> used up all memory.
> This can easily lead to a dead lock (in the application, not in Mesos).
> 
> Simple example:
> 1. Scheduler allocates all memory of a slave for an executor
> 2. Scheduler launches a task for this executor (allocating 1 CPU)
> 3. Task finishes: 1 CPU , 0 MB memory allocatable.
> 4. No offers are made, as no memory is left. Scheduler will wait for offers 
> forever. Dead lock in the application.
> 
> To fix this problem, offers must be made if CPU resources are allocatable 
> without considering allocatable memory
> 
> 
> Diffs
> -
> 
>   CHANGELOG a822cc4 
>   src/common/resources.cpp edf36b1 
>   src/master/constants.cpp faa1503 
>   src/master/hierarchical_allocator_process.hpp 34f8cd6 
>   src/master/master.cpp 18464ba 
>   src/tests/allocator_tests.cpp 774528a 
> 
> Diff: https://reviews.apache.org/r/25035/diff/
> 
> 
> Testing
> ---
> 
> Deployed patched Mesos 0.19.1 on a small cluster with 3 slaves and tested 
> running multiple parallel Spark jobs in "fine-grained" mode to saturate 
> allocatable memory. The jobs run fine now. This load always caused a dead 
> lock in all Spark jobs within one minute with the unpatched Mesos.
> 
> 
> Thanks,
> 
> Martin Weindel
> 
>

Re: Review Request 25695: Update to enable systemd control of mesos services

[Timothy St. Clair]

> On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
> > src/linux/cgroups.cpp, lines 1778-1792
> > <https://reviews.apache.org/r/25695/diff/2/?file=690745#file690745line1778>
> >
> > So you never cleanup other cgroups (like memory) on machines with 
> > systemd?

Correct, *never* unmount, this is handled by systemd.


> On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
> > configure.ac, lines 470-472
> > <https://reviews.apache.org/r/25695/diff/2/?file=690744#file690744line470>
> >
> > Is there a way to eliminate `PKG_CHECK_MODULES`? I think last time, 
> > some people have issues when bootstrapping if `PKG_CHECK_MODULES` is used.

Could we determine what the root cause is before we through it out?  I would 
like to know why it is an issue.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/#review53837
-----------


On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25695/
> ---
> 
> (Updated Sept. 16, 2014, 6:19 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This update enables support for systemd co-managed cgroup controllers
> 
> 
> Diffs
> -
> 
>   configure.ac c4b4391 
>   src/linux/cgroups.cpp 5093b4c 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 
> 
> Diff: https://reviews.apache.org/r/25695/diff/
> 
> 
> Testing
> ---
> 
> systemctl start mesos-master mesos-slave
> several runs of 'mesos execute' to verify creation and cleanup.
> systemctl stop mesos-master mesos-slave
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25695: Update to enable systemd control of mesos services

[Timothy St. Clair]

> On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
> > src/linux/cgroups.cpp, lines 1778-1792
> > <https://reviews.apache.org/r/25695/diff/2/?file=690745#file690745line1778>
> >
> > So you never cleanup other cgroups (like memory) on machines with 
> > systemd?
> 
> Timothy St. Clair wrote:
> Correct, *never* unmount, this is handled by systemd.

or remove.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/#review53837
-----------


On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25695/
> ---
> 
> (Updated Sept. 16, 2014, 6:19 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This update enables support for systemd co-managed cgroup controllers
> 
> 
> Diffs
> -
> 
>   configure.ac c4b4391 
>   src/linux/cgroups.cpp 5093b4c 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 
> 
> Diff: https://reviews.apache.org/r/25695/diff/
> 
> 
> Testing
> ---
> 
> systemctl start mesos-master mesos-slave
> several runs of 'mesos execute' to verify creation and cleanup.
> systemctl stop mesos-master mesos-slave
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25695: Update to enable systemd control of mesos services

[Timothy St. Clair]

> On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
> > configure.ac, lines 470-472
> > <https://reviews.apache.org/r/25695/diff/2/?file=690744#file690744line470>
> >
> > Is there a way to eliminate `PKG_CHECK_MODULES`? I think last time, 
> > some people have issues when bootstrapping if `PKG_CHECK_MODULES` is used.
> 
> Timothy St. Clair wrote:
> Could we determine what the root cause is before we through it out?  I 
> would like to know why it is an issue.
> 
> Jie Yu wrote:
> Yeah, we tried but couldn't find out the cause. That's the reason we have 
> the following patches:
> 
> ```
> commit 358901a6d56ff9179ffa67077994ed618044179c
> Author: Jie Yu 
> Date:   Wed Aug 27 11:55:46 2014 -0700
> 
> Replaced PKG_CHECK_MODULES with AC_CHECKs in libprocess configure.ac.
> 
> Review: https://reviews.apache.org/r/25031
> 
> commit 66ecc377917581b891a2569b3343456a3d4c3be1
> Author: Jie Yu 
> Date:   Wed Aug 27 11:52:59 2014 -0700
> 
> Replaced PKG_CHECK_MODULES with AC_CHECKs in configure.ac.
> 
> Review: https://reviews.apache.org/r/25030
> ```

Does *this seem familiar?  http://myitcorner.com/blog/?p=207 
I was unable to repro in my env, but it sounds like the previous situation.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/#review53837
---


On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25695/
> ---
> 
> (Updated Sept. 16, 2014, 6:19 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This update enables support for systemd co-managed cgroup controllers
> 
> 
> Diffs
> -
> 
>   configure.ac c4b4391 
>   src/linux/cgroups.cpp 5093b4c 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 
> 
> Diff: https://reviews.apache.org/r/25695/diff/
> 
> 
> Testing
> ---
> 
> systemctl start mesos-master mesos-slave
> several runs of 'mesos execute' to verify creation and cleanup.
> systemctl stop mesos-master mesos-slave
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25695: Update to enable systemd control of mesos services

[Timothy St. Clair]

> On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
> > This more looks like a hack. What if people compile mesos on a machine 
> > without systemd and run it on a machine with systemd? I am in favor of a 
> > dynamic solution. Have you considered the suggestion I gave last time?

I didn't want to interfear with existing behavior if possible, and I know that 
it's going to have to shift again once the DBUS interface becomes the only 
method to interface with cgroups.  I was hoping in the future to wrap some of 
the isolation behind a Module such that in the future we could easily "proof of 
concept" the DBUS changes.  While this patch serves to "just get it working" 
for EL7 and Fedora.  

re: "What if people compile mesos on a machine without systemd and run it on a 
machine with systemd?" - That would only exist in a case where folks compiled 
on say EL5 and tried to run those binaries on EL7.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/#review53837
---------------


On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25695/
> ---
> 
> (Updated Sept. 16, 2014, 6:19 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This update enables support for systemd co-managed cgroup controllers
> 
> 
> Diffs
> -
> 
>   configure.ac c4b4391 
>   src/linux/cgroups.cpp 5093b4c 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 
> 
> Diff: https://reviews.apache.org/r/25695/diff/
> 
> 
> Testing
> ---
> 
> systemctl start mesos-master mesos-slave
> several runs of 'mesos execute' to verify creation and cleanup.
> systemctl stop mesos-master mesos-slave
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25695: Update to enable systemd control of mesos services

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/
---

(Updated Sept. 18, 2014, 7:40 p.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Bugs: MESOS-1195
https://issues.apache.org/jira/browse/MESOS-1195


Repository: mesos-git


Description
---

This update enables support for systemd co-managed cgroup controllers


Diffs
-

  configure.ac c4b4391 
  src/linux/cgroups.cpp 5093b4c 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 

Diff: https://reviews.apache.org/r/25695/diff/


Testing
---

systemctl start mesos-master mesos-slave
several runs of 'mesos execute' to verify creation and cleanup.
systemctl stop mesos-master mesos-slave

make check


Thanks,

Timothy St. Clair

Re: Review Request 25785: Add guide to becoming a committer

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25785/#review53869
---



docs/becoming-a-committer.md
<https://reviews.apache.org/r/25785/#comment93731>

It would be nice to have metrics that are easy to gather, similar to what 
is done on openstack.  With one snapshot you can see details about the user.

The idea of spreading around reviews may be a bit difficult for folks who 
are new to the project.


- Timothy St. Clair


On Sept. 18, 2014, 5:41 p.m., Dominic Hamon wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25785/
> ---
> 
> (Updated Sept. 18, 2014, 5:41 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1815
> https://issues.apache.org/jira/browse/MESOS-1815
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Add a guide to becoming a committer.
> 
> 
> Diffs
> -
> 
>   docs/becoming-a-committer.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25785/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

[Timothy St. Clair]

> On Sept. 11, 2014, 3:45 p.m., Timothy St. Clair wrote:
> > src/exec/exec.cpp, line 82
> > <https://reviews.apache.org/r/25434/diff/2/?file=683945#file683945line82>
> >
> > Maybe I'm missing something, but is there a reason we don't check 
> > before a delay?  If ShutdownProcess is spawned, it's possible all other 
> > processes in the group have already cleaned up.
> 
> Alexander Rukletsov wrote:
> Good questions. Can this be related to non-native bindings?

Perhaps we can open a separate JIRA on this issue as it was here before.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25434/#review53038
---


On Sept. 18, 2014, 11:03 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25434/
> ---
> 
> (Updated Sept. 18, 2014, 11:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, Till Toenshoff, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1571
> https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The configurable slave's executor_shutdown_grace_period flag is propagated to 
> Executor and CommandExecutor through an environment variable. Shutdown 
> timeout in Executor and signal escalation timeout in CommandExecutor are now 
> dependent on this flag. Each nested timeout is somewhat shorter than the 
> parent one.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9b973e5 
>   src/exec/exec.cpp e15f834 
>   src/launcher/executor.cpp cbc8750 
>   src/slave/constants.hpp 9030871 
>   src/slave/constants.cpp e1da5c0 
>   src/slave/containerizer/containerizer.hpp 8a66412 
>   src/slave/containerizer/containerizer.cpp 0254679 
>   src/slave/containerizer/docker.cpp 0febbac 
>   src/slave/containerizer/external_containerizer.cpp efbc68f 
>   src/slave/containerizer/mesos/containerizer.cpp 9d08329 
>   src/slave/flags.hpp 21e0021 
>   src/slave/utils.hpp PRE-CREATION 
>   src/slave/utils.cpp PRE-CREATION 
>   src/tests/containerizer.cpp a17e1e0 
> 
> Diff: https://reviews.apache.org/r/25434/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.9.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/#review54125
---


Thanks Jie! 1st pass testing worked, but I need to beat on it some more. 

Normally I would say we should probably separate out the cleanup work from the 
feature mod, but it's not that important to me.


src/linux/cgroups.cpp
<https://reviews.apache.org/r/25858/#comment94124>

I think I've missed something subtle, how did you bypass the cleanup 
semantics?



src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/25858/#comment94126>





src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/25858/#comment94127>

So does this rely on realpath squashing the symbolic link such that they 
are = ?


- Timothy St. Clair


On Sept. 20, 2014, 12:21 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25858/
> ---
> 
> (Updated Sept. 20, 2014, 12:21 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, Timothy St. Clair, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> A dynamic version after discussed with Tim.
> https://reviews.apache.org/r/25695
> 
> Did a few consistency fixes as well.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp 5093b4ca1ac17238234d96613b7f4ceab4373c48 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> d4df5f37e8d2e356d35ca40d799197a47393fa9a 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> b1cad472a561e81422f980182fd24eb95701140a 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> fb3db88af7b2ffa79272743f571c4c021c619c48 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> ff047d37c1b2e659b18b5d4a1e97301192d05e55 
>   src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e 
> 
> Diff: https://reviews.apache.org/r/25858/diff/
> 
> 
> Testing
> ---
> 
> make check
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/#review54165
---

Ship it!


Ship It!

- Timothy St. Clair


On Sept. 20, 2014, 12:21 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25858/
> ---
> 
> (Updated Sept. 20, 2014, 12:21 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, Timothy St. Clair, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> A dynamic version after discussed with Tim.
> https://reviews.apache.org/r/25695
> 
> Did a few consistency fixes as well.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp 5093b4ca1ac17238234d96613b7f4ceab4373c48 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> d4df5f37e8d2e356d35ca40d799197a47393fa9a 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> b1cad472a561e81422f980182fd24eb95701140a 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> fb3db88af7b2ffa79272743f571c4c021c619c48 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> ff047d37c1b2e659b18b5d4a1e97301192d05e55 
>   src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e 
> 
> Diff: https://reviews.apache.org/r/25858/diff/
> 
> 
> Testing
> ---
> 
> make check
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 25551: Add standard versioning to shared libmesos.so

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551/
---

(Updated Sept. 23, 2014, 7:16 p.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Bugs: MESOS-1675
https://issues.apache.org/jira/browse/MESOS-1675


Repository: mesos-git


Description
---

Add standard -version-info to shared libmesos, it will need to be updated on 
major modifications.


Diffs
-

  src/Makefile.am 9b973e5 

Diff: https://reviews.apache.org/r/25551/diff/


Testing
---

make check 


Thanks,

Timothy St. Clair

Re: Review Request 25848: Introducing mesos modules.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54425
---


I still debate whether we should name it "plugin" vs. "module".  Thoughts?


include/mesos/module.hpp
<https://reviews.apache.org/r/25848/#comment94563>

If this is just for version information perhaps we can @VERSION@ replace, 
vs. including the whole protobuf header chain.



include/mesos/module.hpp
<https://reviews.apache.org/r/25848/#comment94564>

Perhaps we can breakout in another JIRA, but I would to denote both some 
form of AUTHORING as well as define api's as EXPERIMENTAL.



src/examples/test_module.hpp
<https://reviews.apache.org/r/25848/#comment94565>

+1 re: Adams comment.



src/module/manager.hpp
<https://reviews.apache.org/r/25848/#comment94569>

If it's a singleton typically you can make the constructor 
protected/private such that it can never be instantiated externally.



src/module/manager.hpp
<https://reviews.apache.org/r/25848/#comment94571>

can't we use std::mutex now?



src/module/manager.cpp
<https://reviews.apache.org/r/25848/#comment94572>

same comment as above.



src/module/manager.cpp
<https://reviews.apache.org/r/25848/#comment94587>

You could probably stick the json parsing into a separate sub-class.  I'm 
all for breaking out a small JIRA tree from the comments.


- Timothy St. Clair


On Sept. 23, 2014, 4:05 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25848/
> ---
> 
> (Updated Sept. 23, 2014, 4:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1384
> https://issues.apache.org/jira/browse/MESOS-1384
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Adding a first class primitive, abstraction and process for dynamic library 
> writing and loading can make it easier to extend inner workings of Mesos. 
> Making it possible to have dynamic loadable resource allocators, isolators, 
> containerizes, authenticators and much more.
> 
> 
> Diffs
> -
> 
>   include/mesos/module.hpp PRE-CREATION 
>   src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 
>   src/examples/test_module.hpp PRE-CREATION 
>   src/examples/test_module_impl.cpp PRE-CREATION 
>   src/module/manager.hpp PRE-CREATION 
>   src/module/manager.cpp PRE-CREATION 
>   src/tests/module_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25848/diff/
> 
> 
> Testing
> ---
> 
> Ran make check with added tests for verifying library/module loading and 
> simple version check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 25848: Introducing mesos modules.

[Timothy St. Clair]

> On Sept. 24, 2014, 8:05 p.m., Timothy St. Clair wrote:
> > include/mesos/module.hpp, line 73
> > <https://reviews.apache.org/r/25848/diff/5/?file=701882#file701882line73>
> >
> > Perhaps we can breakout in another JIRA, but I would to denote both 
> > some form of AUTHORING as well as define api's as EXPERIMENTAL.
> 
> Niklas Nielsen wrote:
> In another JIRA to discuss the format of the macros? Or what should the 
> outcome be of the JIRA thread?
> 
> +1 on having AUTHORING.
> 
> How did you think about incorporating the experimentalness of the api? in 
> the macro name?

re-experimental, we could probably just append to the end of the name with 
token pasting, but lets open up a separate JIRA for that.  

I figure this will take iterations.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54425
---


On Sept. 25, 2014, 12:11 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25848/
> ---
> 
> (Updated Sept. 25, 2014, 12:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1384
> https://issues.apache.org/jira/browse/MESOS-1384
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Adding a first class primitive, abstraction and process for dynamic library 
> writing and loading can make it easier to extend inner workings of Mesos. 
> Making it possible to have dynamic loadable resource allocators, isolators, 
> containerizes, authenticators and much more.
> 
> 
> Diffs
> -
> 
>   configure.ac da61c2984bac378d5298b781476da4f0c20375d1 
>   include/mesos/module.hpp.in PRE-CREATION 
>   src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 
>   src/examples/test_module.hpp PRE-CREATION 
>   src/examples/test_module_impl.cpp PRE-CREATION 
>   src/module/manager.hpp PRE-CREATION 
>   src/module/manager.cpp PRE-CREATION 
>   src/tests/module_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25848/diff/
> 
> 
> Testing
> ---
> 
> Ran make check with added tests for verifying library/module loading and 
> simple version check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 25551: Add standard versioning to shared libmesos.so

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551/
---

(Updated Sept. 26, 2014, 3:31 p.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
---

Update to handle versioning over time in a cleaner way. 


Bugs: MESOS-1675
https://issues.apache.org/jira/browse/MESOS-1675


Repository: mesos-git


Description
---

Add standard -version-info to shared libmesos, it will need to be updated on 
major modifications.


Diffs (updated)
-

  configure.ac 86d448c 
  src/Makefile.am 27c42df 

Diff: https://reviews.apache.org/r/25551/diff/


Testing
---

make check 


Thanks,

Timothy St. Clair

Re: Review Request 25184: Delete framework data in TaskStatus to avoid OOM

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25184/#review54685
---


Please rebase to master as that function has diverged.

- Timothy St. Clair


On Sept. 6, 2014, 3:38 a.m., Chengwei Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25184/
> ---
> 
> (Updated Sept. 6, 2014, 3:38 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-1746
> https://issues.apache.org/jira/browse/MESOS-1746
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> There was a bug found that Spark use TaskStatus.data to transfer computed
> result and mesos-master RES memory keeps increasing fast and finally will be
> killed by OOM killer.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 2508b38e86b8399886bffcbaca8ec11c731363d8 
> 
> Diff: https://reviews.apache.org/r/25184/diff/
> 
> 
> Testing
> ---
> 
> tested with spark
> 
> 
> Thanks,
> 
> Chengwei Yang
> 
>

Re: Review Request 22994: Fixes for zookeeper tests when running --disable-bundled

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22994/#review54697
---


I'm discarding this review and will cleanup the patch, and create a JIRA + 
review.

- Timothy St. Clair


On July 11, 2014, 4:19 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22994/
> ---
> 
> (Updated July 11, 2014, 4:19 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1168
> https://issues.apache.org/jira/browse/MESOS-1168
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes for zookeeper tests when running --disable-bundled.  
> 
> There were issues with our zookeeper package so it was difficult to tease out 
> what was responsible.  
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 3c8b91a 
>   src/examples/java/test-log.in 8afed0d 
>   src/tests/zookeeper.cpp 29656eb 
> 
> Diff: https://reviews.apache.org/r/22994/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25848: Introducing mesos modules.

[Timothy St. Clair]

> On Sept. 24, 2014, 8:05 p.m., Timothy St. Clair wrote:
> > src/module/manager.cpp, line 173
> > <https://reviews.apache.org/r/25848/diff/5/?file=701887#file701887line173>
> >
> > You could probably stick the json parsing into a separate sub-class.  
> > I'm all for breaking out a small JIRA tree from the comments.
> 
> Niklas Nielsen wrote:
> Is it so we can discuss the format further or because we should address 
> this in different patches?
> 
> Kapil Arya wrote:
> I have created a new private function that does all the parsing. 
> Hopefully, that is more readable now.

+1.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54425
---


On Sept. 26, 2014, 11:26 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25848/
> ---
> 
> (Updated Sept. 26, 2014, 11:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1384
> https://issues.apache.org/jira/browse/MESOS-1384
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Adding a first class primitive, abstraction and process for dynamic library 
> writing and loading can make it easier to extend inner workings of Mesos. 
> Making it possible to have dynamic loadable resource allocators, isolators, 
> containerizes, authenticators and much more.
> 
> 
> Diffs
> -
> 
>   configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 
>   include/mesos/module.hpp.in PRE-CREATION 
>   src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
>   src/examples/test_module.hpp PRE-CREATION 
>   src/examples/test_module_impl.cpp PRE-CREATION 
>   src/examples/test_module_impl2.cpp PRE-CREATION 
>   src/module/manager.hpp PRE-CREATION 
>   src/module/manager.cpp PRE-CREATION 
>   src/tests/module_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25848/diff/
> 
> 
> Testing
> ---
> 
> Ran make check with added tests for verifying library/module loading and 
> simple version check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 25848: Introducing mesos modules.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54811
---

Ship it!


I still think there will be revisions, but I'm good for phase 1.  Thanks for 
all the work guys! 

We can open new JIRA's where needed.

- Timothy St. Clair


On Sept. 26, 2014, 11:26 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25848/
> ---
> 
> (Updated Sept. 26, 2014, 11:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1384
> https://issues.apache.org/jira/browse/MESOS-1384
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Adding a first class primitive, abstraction and process for dynamic library 
> writing and loading can make it easier to extend inner workings of Mesos. 
> Making it possible to have dynamic loadable resource allocators, isolators, 
> containerizes, authenticators and much more.
> 
> 
> Diffs
> -
> 
>   configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 
>   include/mesos/module.hpp.in PRE-CREATION 
>   src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
>   src/examples/test_module.hpp PRE-CREATION 
>   src/examples/test_module_impl.cpp PRE-CREATION 
>   src/examples/test_module_impl2.cpp PRE-CREATION 
>   src/module/manager.hpp PRE-CREATION 
>   src/module/manager.cpp PRE-CREATION 
>   src/tests/module_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25848/diff/
> 
> 
> Testing
> ---
> 
> Ran make check with added tests for verifying library/module loading and 
> simple version check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 25848: Introducing mesos modules.

[Timothy St. Clair]

> On Sept. 29, 2014, 9:57 p.m., Niklas Nielsen wrote:
> > include/mesos/module.hpp.in, lines 46-47
> > <https://reviews.apache.org/r/25848/diff/11/?file=708522#file708522line46>
> >
> > Can we use existing boost helpers for this? Something like 
> > http://www.boost.org/doc/libs/1_56_0/libs/preprocessor/doc/ref/cat.html
> 
> Kapil Arya wrote:
> Right now this files doesn't #include any other files and since its just 
> one definition, it seemed simpler to just define APPEND and EXPAND_AND_APPEND 
> macros.  If there is a strong preference, we can definitely use BOOST_PP_CAT 
> instead.

2¢ - Don't add extra inclusion.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54879
---


On Sept. 30, 2014, 11:01 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25848/
> ---
> 
> (Updated Sept. 30, 2014, 11:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1384
> https://issues.apache.org/jira/browse/MESOS-1384
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Adding a first class primitive, abstraction and process for dynamic library 
> writing and loading can make it easier to extend inner workings of Mesos. 
> Making it possible to have dynamic loadable resource allocators, isolators, 
> containerizes, authenticators and much more.
> 
> 
> Diffs
> -
> 
>   configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 
>   include/mesos/module.hpp.in PRE-CREATION 
>   src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
>   src/examples/test_module.hpp PRE-CREATION 
>   src/examples/test_module_impl.cpp PRE-CREATION 
>   src/examples/test_module_impl2.cpp PRE-CREATION 
>   src/module/manager.hpp PRE-CREATION 
>   src/module/manager.cpp PRE-CREATION 
>   src/tests/module_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25848/diff/
> 
> 
> Testing
> ---
> 
> Ran make check with added tests for verifying library/module loading and 
> simple version check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 25865: Pid namespace isolator for the MesosContainerizer.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25865/#review55231
---



src/slave/containerizer/isolators/filesystem/shared.cpp
<https://reviews.apache.org/r/25865/#comment95626>

Why not use api's and MS_REMOUNT?


- Timothy St. Clair


On Oct. 2, 2014, 6:23 p.m., Ian Downes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25865/
> ---
> 
> (Updated Oct. 2, 2014, 6:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Add namespaces/pid to --isolation slave flag. Places executor into a pid 
> namespace so it and all descendants will be contained in the namespace. 
> Requires the filesystem/shared isolator so /proc and /sys are remounted to 
> reflect the different namespace.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
>   src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION 
>   src/slave/containerizer/isolators/namespaces/pid.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/namespaces/pid.cpp PRE-CREATION 
>   src/slave/containerizer/linux_launcher.cpp 
> f7bc894830a7ca3f55465dacc7b653cdc2d7758b 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 9d083294caa5c5a47ba3ceaa1b57346144cb795c 
>   src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 
> 
> Diff: https://reviews.apache.org/r/25865/diff/
> 
> 
> Testing
> ---
> 
> Added test that command in pid namespaced container is in a different 
> namespace and that the command is 'init' (verifies remount of /proc).
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 26273: Define reverseforeach from Boost.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26273/#review55244
---

Ship it!


Ship It!

- Timothy St. Clair


On Oct. 2, 2014, 6:15 p.m., Ian Downes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26273/
> ---
> 
> (Updated Oct. 2, 2014, 6:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Define reverseforeach from Boost.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp 
> 0739d6360464873533af07e67f6beb7804af43aa 
> 
> Diff: https://reviews.apache.org/r/26273/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 26352: Add --with-curl to libprocess since needs it.

[Timothy St. Clair]

> On Oct. 6, 2014, 1:30 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/configure.ac, line 99
> > 
> >
> > Is there a reason you are not adhering to that without_bundled_xxx 
> > scheme we are using for other bundled libraries?

same sentiments.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26352/#review55495
---


On Oct. 5, 2014, 9:02 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26352/
> ---
> 
> (Updated Oct. 5, 2014, 9:02 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1843
> https://issues.apache.org/jira/browse/MESOS-1843
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> libprocess uses `` which includes ``. On a 
> machine without system-level libcurl installed, we should be able to build 
> `mesos` with the `--with-curl=` flag. The 
> `-I` gets added to the `CPPFLAGS` for `mesos` but it doesn't 
> added for libprocess. This patch makes libprocess actually use the 
> `--with-curl` flag.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 501de4076b6c3b996580d6656bc50103dcedc154 
> 
> Diff: https://reviews.apache.org/r/26352/diff/
> 
> 
> Testing
> ---
> 
> Built `mesos` on a machine without system-level libcurl installed with 
> `--with-curl` flag.
> 
> 
> Thanks,
> 
> Michael Park
> 
>