[jira] [Resolved] (TOMAHAWK-1650) Tree2 Javascript namespacing
[ https://issues.apache.org/jira/browse/TOMAHAWK-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Werner Punz resolved TOMAHAWK-1650. --- Resolution: Fixed Fix Version/s: 1.1.15-SNAPSHOT Tree2 Javascript namespacing Key: TOMAHAWK-1650 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1650 Project: MyFaces Tomahawk Issue Type: Improvement Reporter: Werner Punz Fix For: 1.1.15-SNAPSHOT Same here we have to renamespace for our tree2 Javascripts -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TOMAHAWK-1650) Tree2 Javascript namespacing
Werner Punz created TOMAHAWK-1650: - Summary: Tree2 Javascript namespacing Key: TOMAHAWK-1650 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1650 Project: MyFaces Tomahawk Issue Type: Bug Reporter: Werner Punz Same here we have to renamespace for our tree2 Javascripts -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-1556) tree2: Programatically setting of Treestate does only work on the first time
tree2: Programatically setting of Treestate does only work on the first time Key: TOMAHAWK-1556 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1556 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.9 Environment: MyFaces 1.1.1, Java SUN JDK 1.5. update 12, Bea Weblogic 9.2 MP3, Windows XP SP3 Reporter: Jochen List I have a problem with resetting the state and Model of tree2 component. On the Jsp a tree2 Component is placed. If the user clicks on a node, the node is marked as selected and highlighted with css. This works fine. Also on the page, there is a commandLink Reset, which should resets the tree. Resetting means, that the root node will be selected and of course, highlighted with css. If the users clicks on a treenode, the node is correctly marked as selected and highlighted. But if the users clicks on the reset Link, the root node will not be seleceted. The view shows the old node as selected. No reset is possible. In my reset method in the ManagedBean, which is connected to the Reset commandLink, I'm creating a new treemodel, setting the path to the selected node, and setting the model to the tree. I have tried both options, recreating model and tree and only updating the model. Nothing worked as expected. In both cases, the old node is shown as selected. I have debugged throw the code and in theBackingBean, everythink is correctly set. I can see the variables of htmlTree and treeModel and everythink looks like expected. Then I have debugged the isNodeSelected() Method of the tree, and I can see, that the getDataModel() Method of UITreeData returns a _cachedModel variable which contains the old model, with the old selected node. And this model seam to be used for rendering the jsp The JSP Code: t:tree2 value=#{bean.model} showRootNode=false var=node varNodeToggler=t binding=#{bean.htmlTree} clientSideToggle=false f:facet name=orga h:panelGroup t:commandLink immediate=false styleClass=#{t.nodeSelected ? 'selectedNode':'standardNode'} actionListener=#{t.setNodeSelected} action=#{bavCockpitBean.updateNodeList} t:graphicImage value=images/person.png border=0 alt=TreeIcon/ h:outputText value=#{node.description} / /t:commandLink /h:panelGroup /f:facet /t:tree2 The ManagedBean Code: private HtmlTree htmlTree = null; private TreeModelBase treeModel = null; private boolean forceTreeUpdate = true; public String reset() { this.forceUpdate = true; return success; } public TreeModel getHirarchieModel() { if ( forceUpdate ) { this.forceUpdate = false; TreeNode root = ... // Generating the tree; this.treeModel = new TreeModelBase(root); this.treeModel.getTreeState().setSelected( 0:0 ); this.htmlTree = new HtmlTree(); tree.setModel(this.treeModel); return this.treeModel; } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1113) Merge tree and tree2
[ https://issues.apache.org/jira/browse/TOMAHAWK-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901127#action_12901127 ] Leonardo Uribe commented on TOMAHAWK-1113: -- The following issues: TOMAHAWK-924Tree2 documentation fails to describe identifier concept TOMAHAWK-925 Improve Tree2 data model usability TOMAHAWK-739 Introduced a Tree-Interface for tree2 TOMAHAWK-95Need way to access Parental TreeNode When given NodeId from TreeModel (or UITreeData) - referring to t:tree2 usage Talks about the same, we need a better model, that allows be extended. There exists the following interfaces (on tree2 package) - TreeModel - TreeNode - TreeState - TreeWalker All of them are interfaces, so we can't add methods without break existing code. Note javax.faces.model.DataModel is an abstract class instead, so it is possible to add new methods without break anything. Also, it is not the same a tree component with a table as a model, than a tree component with a tree as a model, but maybe we can think on a common model. The cool stuff about t:tree2 is the way how it can customize node rendering using TreeNode.getType() value to locate the right facet to be rendered. Other advantage is how it is possible to build a tree model without much effort and complexity. To solve this issue it is necessary to create a new component with alternate interfaces that takes into account all knowledge learned from t:tree, t:tree2 and maybe other solutions available (trinidad tr:tree and tr:treeTable). Merge tree and tree2 Key: TOMAHAWK-1113 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1113 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree Table, Tree2 Environment: all Reporter: Dave tree2 does not support treeColumn (tree table), but tree does. These two components should be merged and support Tree Table. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-1490) Problem with tree2 when it expands a node
Problem with tree2 when it expands a node - Key: TOMAHAWK-1490 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1490 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree2 Environment: jsf 1.2 Reporter: Miguel Lozano When I expand a node, it produces a refresh page and return to the top of the page. It cause a problem whit the user, because when you have a lot of nodes and you have to expand a node that is too down, the refresh takes you to the top and you go down again to see the expanded node. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1490) Problem with tree2 when it expands a node
[ https://issues.apache.org/jira/browse/TOMAHAWK-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12830951#action_12830951 ] Jakob Korherr commented on TOMAHAWK-1490: - have you tried setting the init parameter org.apache.myfaces.AUTO_SCROLL to true? Problem with tree2 when it expands a node - Key: TOMAHAWK-1490 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1490 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree2 Environment: jsf 1.2 Reporter: Miguel Lozano When I expand a node, it produces a refresh page and return to the top of the page. It cause a problem whit the user, because when you have a lot of nodes and you have to expand a node that is too down, the refresh takes you to the top and you go down again to see the expanded node. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1490) Problem with tree2 when it expands a node
[ https://issues.apache.org/jira/browse/TOMAHAWK-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831331#action_12831331 ] Miguel Lozano commented on TOMAHAWK-1490: - Yes, I have tried with AUTO_SCROLL and I have the same problem. Problem with tree2 when it expands a node - Key: TOMAHAWK-1490 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1490 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree2 Environment: jsf 1.2 Reporter: Miguel Lozano When I expand a node, it produces a refresh page and return to the top of the page. It cause a problem whit the user, because when you have a lot of nodes and you have to expand a node that is too down, the refresh takes you to the top and you go down again to see the expanded node. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-1477) Cannot use multiple Tree2 components
Cannot use multiple Tree2 components Key: TOMAHAWK-1477 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1477 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5 Environment: tomahawk-1.1.5 JBoss 4.0.2 GA Reporter: Gregory Darcourt I'm trying to use multiple trees in the same page into two separated forms, uniques variables ... with server-side toggle. The trees get created with the correct data, however, I am unable to expand anything other than the first tree. Even though I click on the seconds tree's root node, the first tree is the one that expands. Action listener seems to be down. I searched on web and found this old conversation about the same issue: http://www.mail-archive.com/us...@myfaces.apache.org/msg02344.html It seems a patch was done about client-side but anything about server-side toggle. Thank you for your help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1453) [myfaces-example-simple-1.1.9] Tree2 (client-side/server-side toggle and hide root node examples) don't work with Mojarra
[ https://issues.apache.org/jira/browse/TOMAHAWK-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767306#action_12767306 ] Werner Punz commented on TOMAHAWK-1453: --- Ok I have added a blackboxed mojarra 1.2 to the examples and it seems to me that the onclick attribute is ignored by mojarras renderer. Our code internally adds correctly an onclick attribute to GraphicImage and Mojarra does not really render it. I will investigate further. [myfaces-example-simple-1.1.9] Tree2 (client-side/server-side toggle and hide root node examples) don't work with Mojarra - Key: TOMAHAWK-1453 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1453 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.9 Environment: Mojarra 1.2_14-SNAPSHOT Mojarra 2.0.0-SNAPSHOT Mac OS 10.5.6 JDK 1.6.0 Reporter: Ryan Lubke Assignee: Werner Punz Tree nodes don't expand when clicking the expansion icon. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1453) [myfaces-example-simple-1.1.9] Tree2 (client-side/server-side toggle and hide root node examples) don't work with Mojarra
[ https://issues.apache.org/jira/browse/TOMAHAWK-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767314#action_12767314 ] Werner Punz commented on TOMAHAWK-1453: --- Ok our code seems to trigger a bug in mojarra, I have contacted the mojarra people with further details. [myfaces-example-simple-1.1.9] Tree2 (client-side/server-side toggle and hide root node examples) don't work with Mojarra - Key: TOMAHAWK-1453 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1453 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.9 Environment: Mojarra 1.2_14-SNAPSHOT Mojarra 2.0.0-SNAPSHOT Mac OS 10.5.6 JDK 1.6.0 Reporter: Ryan Lubke Assignee: Werner Punz Tree nodes don't expand when clicking the expansion icon. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-1453) [myfaces-example-simple-1.1.9] Tree2 (client-side/server-side toggle and hide root node examples) don't work with Mojarra
[myfaces-example-simple-1.1.9] Tree2 (client-side/server-side toggle and hide root node examples) don't work with Mojarra - Key: TOMAHAWK-1453 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1453 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.9 Environment: Mojarra 1.2_14-SNAPSHOT Mojarra 2.0.0-SNAPSHOT Mac OS 10.5.6 JDK 1.6.0 Reporter: Ryan Lubke Tree nodes don't expand when clicking the expansion icon. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TOMAHAWK-1143) Tree2 renders nonconformant XHTML code
[ https://issues.apache.org/jira/browse/TOMAHAWK-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hazem Saleh resolved TOMAHAWK-1143. --- Resolution: Fixed resolved after adding a meaningful text to the empty generated alts. Tree2 renders nonconformant XHTML code -- Key: TOMAHAWK-1143 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1143 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5, 1.1.6 Reporter: Manfred Geiler Assignee: Hazem Saleh Fix For: 1.1.7-SNAPSHOT - background attribute not allowed for td - img without alt attribute -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TOMAHAWK-1143) Tree2 renders nonconformant XHTML code
[ https://issues.apache.org/jira/browse/TOMAHAWK-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Kitching reopened TOMAHAWK-1143: -- Reopening. As discussed on the mailing lists, setting ALT text to an empty string is not an acceptable solution. Tree2 renders nonconformant XHTML code -- Key: TOMAHAWK-1143 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1143 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5, 1.1.6 Reporter: Manfred Geiler Assignee: Hazem Saleh Fix For: 1.1.7-SNAPSHOT - background attribute not allowed for td - img without alt attribute -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TOMAHAWK-1143) Tree2 renders nonconformant XHTML code
[ https://issues.apache.org/jira/browse/TOMAHAWK-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hazem Saleh resolved TOMAHAWK-1143. --- Resolution: Fixed Tree2 renders nonconformant XHTML code -- Key: TOMAHAWK-1143 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1143 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5, 1.1.6 Reporter: Manfred Geiler Assignee: Hazem Saleh Fix For: 1.1.7-SNAPSHOT - background attribute not allowed for td - img without alt attribute -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-1179) Tree2 renders duplicate Id's for icons - incompatible w/ JSF 1.2 RI (patch attchd)
Tree2 renders duplicate Id's for icons - incompatible w/ JSF 1.2 RI (patch attchd) --- Key: TOMAHAWK-1179 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1179 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.7-SNAPSHOT Environment: JSF 1.2 RI Reporter: Jayson Raymond Priority: Blocker Tree2 renders the same Id for each of the icons in the tree, making it incompatible w/ JSF 1.2 RI. Attached patch increments Id for each image rendered. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-1179) Tree2 renders duplicate Id's for icons - incompatible w/ JSF 1.2 RI (patch attchd)
[ https://issues.apache.org/jira/browse/TOMAHAWK-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jayson Raymond updated TOMAHAWK-1179: - Status: Patch Available (was: Open) Tree2 renders duplicate Id's for icons - incompatible w/ JSF 1.2 RI (patch attchd) --- Key: TOMAHAWK-1179 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1179 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.7-SNAPSHOT Environment: JSF 1.2 RI Reporter: Jayson Raymond Priority: Blocker Tree2 renders the same Id for each of the icons in the tree, making it incompatible w/ JSF 1.2 RI. Attached patch increments Id for each image rendered. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TOMAHAWK-1179) Tree2 renders duplicate Id's for icons - incompatible w/ JSF 1.2 RI (patch attchd)
[ https://issues.apache.org/jira/browse/TOMAHAWK-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12560833#action_12560833 ] jaysonraymond edited comment on TOMAHAWK-1179 at 1/20/08 11:06 AM: Attached patch generates a new ID for each icon in tree, eliminating 'duplicate ID' incompatability with JSF 1.2 RI. was (Author: jaysonraymond): Corrects duplicate Ids for icons in tree cause 'duplicate ID' problems in JSF 1.2 RI Tree2 renders duplicate Id's for icons - incompatible w/ JSF 1.2 RI (patch attchd) --- Key: TOMAHAWK-1179 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1179 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.7-SNAPSHOT Environment: JSF 1.2 RI Reporter: Jayson Raymond Priority: Blocker Attachments: tree2-HtmlTreeRenderer-uniqueId-patch.txt Tree2 renders the same Id for each of the icons in the tree, making it incompatible w/ JSF 1.2 RI. Attached patch increments Id for each image rendered. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-1143) Tree2 renders nonconformant XHTML code
Tree2 renders nonconformant XHTML code -- Key: TOMAHAWK-1143 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1143 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.6, 1.1.5 Reporter: Manfred Geiler Assignee: Manfred Geiler Fix For: 1.1.7-SNAPSHOT - background attribute not allowed for td - img without alt attribute -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [tomahaw] ppr problems with log and tree2
Hi Ernst! Great you picked it up! I must have missed the point where this log got in - my guess is that it can optionally be defined or turned on in dojo or something. However I would think a check wether or not the object is defined before using it cannot hurt. Yea, I tried if (log), but even this lead to an exception ... I don't know why. I also like the suggestion of caching the patterns themselves and re-matching them against all inputs within updated areas. I have a relatively tight schedule this week, but I'll try to squeeze it in on the weekend. Oh - would be great if you could make it work :-) I'll spend you a beer - or two. Thanks! Ciao, Mario
Re: [tomahaw] ppr problems with log and tree2
Hi Ernst! I have a relatively tight schedule this week, but I'll try to squeeze it in on the weekend. I decided to have a look at it myself and it looks like I got it working. Please review r577913. Mainly I've cached the partialTrigger(Pattern) configuration and apply it after each ajax request by avoiding duplicates in oamPartialTriggersToZoneIds. BTW: I've seen some arrays are stored at window. instead of this.. I think this. should be sufficient here, no? Some code cleanup can be done after my changed, I just wanted to avoid to much changes - we can do it if we are happy with my changes. Ciao, Mario
[tomahaw] ppr problems with log and tree2
Hi! First, I've commented the using of the log stuff as it seems normally thre is no log object around, at least I don't know where. From our ppr.js: if(formElement) this._addEventHandler(formElement, connectToEventArr, eventHandler); -else + /* where is the log? + else log.error(Input element with id : +formElementId + not found.); +*/ Now, my use-case started working again, well, mostly ... the next problem I have is the following. I'd like to use a server-side-toggling tree2 embedded in an pprPanelGroup: s:pprPanelGroup id=pprRoleTree partialTriggerPattern=.*:t[0-9]+.* t:tree2 value=#{adEditRolle.roleModel} id=roleTree var=node varNodeToggler=t showRootNode=false preserveToggle=false clientSideToggle=false showNav=true showLines=true After triggering the first node its child nodes are shown ... fine, but now, even if the partialTriggerPattern matches on their commandLinks too, the ppr.js won't attach to them, only the already known elements are reattached. Is there a way to enhance the ppr.js in that direction? I think caching the patterns and their zones and reapplying them afterwards should do the trick, no? To speed up things we should only process the components received from the ajax call. Mr. Ajax, willing to do this ;-) ? Ciao, Mario
Re: [tomahaw] ppr problems with log and tree2
Hi Mario! thanks for pointing out this issues. I must have missed the point where this log got in - my guess is that it can optionally be defined or turned on in dojo or something. However I would think a check wether or not the object is defined before using it cannot hurt. @whoever did this - comments ? ;-) I also like the suggestion of caching the patterns themselves and re-matching them against all inputs within updated areas. I have a relatively tight schedule this week, but I'll try to squeeze it in on the weekend. greez Ernst On 9/19/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! First, I've commented the using of the log stuff as it seems normally thre is no log object around, at least I don't know where. From our ppr.js: if(formElement) this._addEventHandler(formElement, connectToEventArr, eventHandler); -else + /* where is the log? + else log.error(Input element with id : +formElementId + not found.); +*/ Now, my use-case started working again, well, mostly ... the next problem I have is the following. I'd like to use a server-side-toggling tree2 embedded in an pprPanelGroup: s:pprPanelGroup id=pprRoleTree partialTriggerPattern=.*:t[0-9]+.* t:tree2 value=#{adEditRolle.roleModel} id=roleTree var=node varNodeToggler=t showRootNode=false preserveToggle=false clientSideToggle=false showNav=true showLines=true After triggering the first node its child nodes are shown ... fine, but now, even if the partialTriggerPattern matches on their commandLinks too, the ppr.js won't attach to them, only the already known elements are reattached. Is there a way to enhance the ppr.js in that direction? I think caching the patterns and their zones and reapplying them afterwards should do the trick, no? To speed up things we should only process the components received from the ajax call. Mr. Ajax, willing to do this ;-) ? Ciao, Mario
[jira] Created: (TOMAHAWK-1113) Merge tree and tree2
Merge tree and tree2 Key: TOMAHAWK-1113 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1113 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree Table, Tree2 Environment: all Reporter: Dave tree2 does not support treeColumn (tree table), but tree does. These two components should be merged and support Tree Table. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1113) Merge tree and tree2
[ https://issues.apache.org/jira/browse/TOMAHAWK-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525971 ] Dave commented on TOMAHAWK-1113: Most poeple use tree2. It is sufficient to add treeTable feature into tree2. Merge tree and tree2 Key: TOMAHAWK-1113 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1113 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree Table, Tree2 Environment: all Reporter: Dave tree2 does not support treeColumn (tree table), but tree does. These two components should be merged and support Tree Table. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-94) tree2 should work with treeColumn
[ https://issues.apache.org/jira/browse/TOMAHAWK-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514752 ] Joshua Wojcik commented on TOMAHAWK-94: --- Can you add the code for the call too JSFUtils.resetAllIds(component, facesContext)? tree2 should work with treeColumn - Key: TOMAHAWK-94 URL: https://issues.apache.org/jira/browse/TOMAHAWK-94 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Environment: n/a Reporter: Bill Schneider Assignee: Martin Marinschek Attachments: HtmlTableTree.java, HtmlTree2TableRenderer.java, Tree2TableTag.java since tree is deprecated, there seems to be a lot of demand for treeColumn to work with tree2. searching the mailing list archives turns up a bunch of messages from a few months ago but nothing all that recent. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TOMAHAWK-94) tree2 should work with treeColumn
[ https://issues.apache.org/jira/browse/TOMAHAWK-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514752 ] Joshua Wojcik edited comment on TOMAHAWK-94 at 7/23/07 12:33 PM: - Can you add the code for the call to JSFUtils.resetAllIds(component, facesContext)? was: Can you add the code for the call too JSFUtils.resetAllIds(component, facesContext)? tree2 should work with treeColumn - Key: TOMAHAWK-94 URL: https://issues.apache.org/jira/browse/TOMAHAWK-94 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Environment: n/a Reporter: Bill Schneider Assignee: Martin Marinschek Attachments: HtmlTableTree.java, HtmlTree2TableRenderer.java, Tree2TableTag.java since tree is deprecated, there seems to be a lot of demand for treeColumn to work with tree2. searching the mailing list archives turns up a bunch of messages from a few months ago but nothing all that recent. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-997) Tree2 inputtext values are null
Tree2 inputtext values are null --- Key: TOMAHAWK-997 URL: https://issues.apache.org/jira/browse/TOMAHAWK-997 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.1 Environment: windows, jboss, java5, myfaces1.1 Reporter: VENKAT VARADARAJAN In our code we get display multiple products and availble qty each node is identified by assignpool variable, with option to purchase more in tree2. Code is as below. Input text value as orderbean.quantity value and submited for further processing. However on submit the qunatity is null. I am beginner with myfaces. Please advise what I am doing wrong %@ taglib uri=../WEB-INF/myfaces_html.tld prefix=h % %@ taglib uri=../WEB-INF/myfaces_core.tld prefix=f % %@ taglib uri=../WEB-INF/tomahawk.tld prefix=t % t:tree2 imageLocation=img id=serverTreePool value=#{myBean.poolTree} var=node clientSideToggle=true f:facet name=PoolRoot h:panelGroup h:outputText value=#{node.description} / /h:panelGroup /f:facet f:facet name=PoolReport h:panelGroup h:panelGrid columns=2 rowClasses=row1, row2 h:outputText value=Product / h:outputText value=Available Quantity / h:outputText value=#{node.description} / h:outputText value=#{node.quantity} / h:outputText value=Want More ? / h:outputText value=Additional Quantity / h:commandButton value=Purchase action=#{orderController.updatePool} t:updateActionListener property=#{myBean.assignPool} value=#{node.profileTypeId} / /h:commandButton h:inputText id = quantity1 value=#{orderBean.quantity}/ f:facet name=footer f:verbatimhr/f:verbatim /f:facet /h:panelGrid /h:panelGroup /f:facet /t:tree2 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-252) tree2 table, td for spacing/navigation inherits CSS styles
[ https://issues.apache.org/jira/browse/TOMAHAWK-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devendra Singh updated TOMAHAWK-252: Status: Patch Available (was: Open) tree2 table, td for spacing/navigation inherits CSS styles -- Key: TOMAHAWK-252 URL: https://issues.apache.org/jira/browse/TOMAHAWK-252 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree2 Affects Versions: 1.1.1 Environment: tree2 uses table and td to implement spacing and placement of the tree branch lines, folder images etc. this is problematic if the t:tree2 is within another table, as the cells may inherit CSS styles from the parent table class= resulting in undesireable borders or padding around the tree navigation components despite table border=0 cellpadding=0 etc. suggested solution is to use img instead for fixed width placeholders instead of a nested table. Reporter: Bill Schneider Attachments: Tree2.htm -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-976) CLONE -tree2 table, td for spacing/navigation inherits CSS styles
CLONE -tree2 table, td for spacing/navigation inherits CSS styles - Key: TOMAHAWK-976 URL: https://issues.apache.org/jira/browse/TOMAHAWK-976 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree2 Affects Versions: 1.1.1 Environment: tree2 uses table and td to implement spacing and placement of the tree branch lines, folder images etc. this is problematic if the t:tree2 is within another table, as the cells may inherit CSS styles from the parent table class= resulting in undesireable borders or padding around the tree navigation components despite table border=0 cellpadding=0 etc. suggested solution is to use img instead for fixed width placeholders instead of a nested table. Reporter: Devendra Singh -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TOMAHAWK-976) CLONE -tree2 table, td for spacing/navigation inherits CSS styles
[ https://issues.apache.org/jira/browse/TOMAHAWK-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devendra Singh reopened TOMAHAWK-976: - Is there any simple solution to have spaces when child node appears : ie when I click on a node, the child node opened on click of parent node should have some right shifting instead fo it's original place... CLONE -tree2 table, td for spacing/navigation inherits CSS styles - Key: TOMAHAWK-976 URL: https://issues.apache.org/jira/browse/TOMAHAWK-976 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree2 Affects Versions: 1.1.1 Environment: tree2 uses table and td to implement spacing and placement of the tree branch lines, folder images etc. this is problematic if the t:tree2 is within another table, as the cells may inherit CSS styles from the parent table class= resulting in undesireable borders or padding around the tree navigation components despite table border=0 cellpadding=0 etc. suggested solution is to use img instead for fixed width placeholders instead of a nested table. Reporter: Devendra Singh -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-926) selectBooleanCheckbox inside tree2 inside dataTable
selectBooleanCheckbox inside tree2 inside dataTable --- Key: TOMAHAWK-926 URL: https://issues.apache.org/jira/browse/TOMAHAWK-926 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.3, 1.1.5-SNAPSHOT Environment: win XP SP2, jdk1.5.0, tomcat-5.5.20 Reporter: Sébastien LEVER My usecase is a dataTable contaning checkedNodes trees. The checkBoxes events are managed correctly when there is 1 row. From two rows, problems happened: for this 2 rows structure: -[]folder1 -[]file1 -[]file2 --- -[]folder2 -[]file3 -[]file4 If I check folder1 node, folder 1 is unchecked by backend actions (if folder1 is expanded, it expands folder2). log: folder2.selectedValueChange(), oldValue: false, newValue: true folder2.setSelected(true) HAS CHANGED ! folder2.setSelected(true) folder2.setSelected(false) HAS CHANGED ! If I check folder2 node (all folder collapsed), folder 2 is checked by backend actions. log: folder2.selectedValueChange(), oldValue: false, newValue: true folder2.setSelected(true) HAS CHANGED ! folder2.setSelected(false) HAS CHANGED ! folder2.setSelected(true) HAS CHANGED ! Here is the page structure: [code] h:dataTable var=tableItem id=table value=#{table.data} preserveDataModel=false preserveSort=false sortable=false styleClass=standardTable headerClass=standardTable_Header footerClass=standardTable_Header rowClasses=standardTable_Row1,standardTable_Row2 columnClasses=standardTable_Column, standardTable_ColumnCentered, standardTable_Column ui:param name=sortedCol value=#{table.sortedColumn} / t:column defaultSorted=true f:facet name=header h:outputText value=#{bundle.tableColumnName} / /f:facet h:panelGroup rendered=#{tableItem.type=='folder' amp;amp; tableItem.node.childs} t:tree2 value=#{tableItem.node} var=subnode showLines=false f:facet name=folder h:panelGroup h:selectBooleanCheckbox id=_check value=#{subnode.infoBean.selected} valueChangeListener=#{subnode.infoBean.selectedValueChange} onclick=this.form.submit()/ h:outputText value=#{subnode.description} / /h:panelGroup /f:facet f:facet name=file h:panelGroup h:selectBooleanCheckbox id=_check value=#{subnode.infoBean.selected} valueChangeListener=#{subnode.infoBean.selectedValueChange} onclick=this.form.submit()/ h:outputText value=#{subnode.description} / /h:panelGroup /f:facet /t:tree2 /h:panelGroup /t:column /h:dataTable [/code] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-924) Tree2 documentation fails to describe identifier concept
Tree2 documentation fails to describe identifier concept -- Key: TOMAHAWK-924 URL: https://issues.apache.org/jira/browse/TOMAHAWK-924 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Reporter: Marko Asplund Priority: Minor The documentation for the TreeModelBase.getNodeById(String nodeId) method leads you to believe that you if you assign unique identifiers to TreeNode objects you can get hold of the TreeNode object by calling getNodeById. The documentation does not give any clues that it's more of a path than an identifier that you need to assign the nodes and pass getNodeById. TreeNode and TreeNodeBase documentation also fail to mention that the identifier needs to have specific structure. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-925) Improve Tree2 data model usability
Improve Tree2 data model usability -- Key: TOMAHAWK-925 URL: https://issues.apache.org/jira/browse/TOMAHAWK-925 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Reporter: Marko Asplund There're two specific issues that should be addressed in my opinion 1) if you use t:commandLink action inside t:tree2 it's very difficult to get hold of the actual node object that was clicked 2) not possible to use existing or business logic tree structures directly with t:tree2 1) Currently I'm constructing the TreeNode structure so that the identifiers are actually paths to the node from the root node (this special node id semantics doesn't seem to be documented). Then in a backing bean I use TreeNode.getNodeById(selectedNodePath); to get the actual node object reference. Since I'm required to assign the node path as the identifier, there's no fields in the structure for identifying the business id of the object. This forces me to always subclass TreeNodeBase. Oracle ADF Faces af:tree / TreeModel is much more intuitive since it follows the standard JSF h:dataTable / DataModel API pattern: public NavigatorBacking { TreeModel tree; public String nodeSelected() { if(tree.isRowAvailable()) { MyNode n = (MyNode)tree.getRowData(); // ... } return success; } } 2) the tree nodes are required to be of TreeNode type or its subclass. Suppose I have a tree hierarchy that I construct in the business tier and want to render this to the user through the UI. I need to rebuild the tree in the web tier with TreeNode nodes (and assign identifiers correctly). Typically one or more TreeNodeBase subclasses are also required. This adds development as well as performance overhead. AFAIK, the ADF Faces TreeModel (ChildPropertyTreeModel) can be populated with any JavaBeans based structure which makes it much more user friendly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-814) Tree2.getNodeById(nodeId) always returns root node
Tree2.getNodeById(nodeId) always returns root node -- Key: TOMAHAWK-814 URL: http://issues.apache.org/jira/browse/TOMAHAWK-814 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Reporter: Jayson Raymond -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (TOMAHAWK-814) Tree2.getNodeById(nodeId) always returns root node
[ http://issues.apache.org/jira/browse/TOMAHAWK-814?page=all ] Jayson Raymond resolved TOMAHAWK-814. - Resolution: Invalid Mistaken entry - please disregard. Tree2.getNodeById(nodeId) always returns root node -- Key: TOMAHAWK-814 URL: http://issues.apache.org/jira/browse/TOMAHAWK-814 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Reporter: Jayson Raymond -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Tomahawk Tree2 Javascript problem.
All, I've created a TreeModel and successfully rendered it on the browser, however, when I click on the expand/collapse button, it's not working. Apparently, in the HTML page generated, _javascript_ function "treeNavClick" was not generated, is there any tag/attribute i need to add to the Tree2 component? Hers is my Jsp: f:view t:tree2 id="myTree" showNav="true" rendered="#{LovBackingBean.lovTree!=null}" showRootNode="false" var="node" value="#{LovBackingBean.lovTree}" varNodeToggler="t" f:facet name="rootNode" h:panelGroup h:outputText value="#{node.description}"/ /h:panelGroup /f:facet f:facet name="topNode" h:panelGroup h:outputText value="#{node.description}"/ /h:panelGroup /f:facet f:facet name="childNode" h:panelGroup h:outputText value="#{node.description}"/ /h:panelGroup /f:facet /t:tree2 /f:view
Re: Tomahawk Tree2 Javascript problem.
On 11/18/06, Long Tran [EMAIL PROTECTED] wrote: I've created a TreeModel and successfully rendered it on the browser, however, when I click on the expand/collapse button, it's not working. Please ask questions on the user list, and let us know what version of Tomahawk, and what version of which JSF implementation you are using. -- Wendy
Re: Tomahawk Tree2 Javascript problem.
In addition to this, it seems that non of the javascript (links on the node) works. Should the javascript codes be generated in the HTML or should it be referenced as a .js file? Thanks Long Long Tran wrote: All, I've created a TreeModel and successfully rendered it on the browser, however, when I click on the expand/collapse button, it's not working. Apparently, in the HTML page generated, javascript function treeNavClick was not generated, is there any tag/attribute i need to add to the Tree2 component? Hers is my Jsp: f:view t:tree2 id=myTree showNav=true rendered=#{LovBackingBean.lovTree!=null} showRootNode=false var=node value=#{LovBackingBean.lovTree} varNodeToggler=t f:facet name=rootNode h:panelGroup h:outputText value=#{node.description}/ /h:panelGroup /f:facet f:facet name=topNode h:panelGroup h:outputText value=#{node.description}/ /h:panelGroup /f:facet f:facet name=childNode h:panelGroup h:outputText value=#{node.description}/ /h:panelGroup /f:facet /t:tree2 /f:view
Re: Tree2
Hi, did just that: http://issues.apache.org/jira/browse/TOMAHAWK-739 regards, Martin On 10/14/06, Sean Schofield [EMAIL PROTECTED] wrote: The problem was that you changed the TreeWalker interface. I've fixed my TreeWalker implementations but everyone else is going to have to do the same. I suggest at a minimum that you create a JIRA issue and mark it resolved so it makes it into the release notes. Sean On 10/10/06, Martin Marinschek [EMAIL PROTECTED] wrote: Yeah. I've already settled for a subclass. I had to copy over almost everything from the tree-sources. The only thing which rescued me from having to copy all was introducing the interface. Sean, is there a way you can get the interface working according to your needs? regards, Martin On 10/10/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I don't want the tree to _contain_ EditableValueHolders, but the tree to be an EditableValueHolder itself - imagine a dropdown which shows a tree, and you can select values from it... maybe a subclass is needed here, since that seams not to be a common use case, right? (I think we already said that during this thread) regards, Martin On 10/10/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin, What is the big deal about EditableValueHolder? Why should tree2 implement this? The idea is that Tree2 contains a tree of whatever types of JSF components you choose (just like dataTable.) You can use editable value holders right now if you want to. Just add one to your node. I am probably missing something but at the moment I fail to see the problem. Also, your tree intereface has broken some things on my end. TreeWalker now needs to take an instance of Tree instead of UITreeData. This breaks some custom tree implementations that I have done offline so I may need to revert that. Let me see if I can work with what you have. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: No, it's a pity that not, but I can't. I'm at a client here in Germany until end of November, can't take off a week. regards, Martin On 10/5/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin: I haven't had time to read this thread yet but I will shortly. Are you going to be at Apache Con this year? If so we can discuss some of your ideas in person as well. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Well, it wouldn't be a problem to have an extended version of the tree which implements EditableValueHolder, but not if the model of the tree is configured by setting the value-attribute - then extending won't work. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: hi Arash, sure your feedback is welcome :) like said before, a generic raw version + aditional tree stuff. During that task we should also take a look at tree / treeTable, IMHO. -M On 10/5/06, Arash Rajaeeyan [EMAIL PROTECTED] wrote: Hello Mattias, I am so new to this list and may be I am not allowed to say this, but I think most developers I have seen use menu related components for only displaying structured data, and most of times data is displayed to user for one of the following purposes: 1) selecting one item 2) selecting multiple item 3) displaying and editing tree structured data (like organization chart, directory services, etc) the first 2 options are currently supported features of tree2, the 3'rd is under debate. May be if we can use same parent for both menu and tree navigation related components and simple tree data structure as said by matias and zubin, for parent of all these components can have following benefits: 1) simplifying development 2) simplifying learning for users 3) making it easier to add more advanced trees later on demand Best regards Arash On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine
[jira] Created: (TOMAHAWK-739) Introduced a Tree-Interface for tree2
Introduced a Tree-Interface for tree2 - Key: TOMAHAWK-739 URL: http://issues.apache.org/jira/browse/TOMAHAWK-739 Project: MyFaces Tomahawk Issue Type: Improvement Components: Tree2 Affects Versions: 1.1.3 Reporter: Martin Marinschek Assigned To: Martin Marinschek Fix For: 1.1.5-SNAPSHOT To be able to reuse the tree-walker of the tree2 and the tree-model itself (without having to depend on UITreeData) a tree-interface has been refactored out of the UITreeData component. This means you'll need to adopt your specialized tree-walker implementations to use this tree-interface. commit: http://svn.apache.org/viewvc?view=revrev=454391 regards, Martin -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-736) Tree2 doesn't consume value bindings by boolean attributes
Tree2 doesn't consume value bindings by boolean attributes -- Key: TOMAHAWK-736 URL: http://issues.apache.org/jira/browse/TOMAHAWK-736 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.3 Reporter: Tomas Havelka Component tree2 doesn't consume value bindings by boolean attributes at all. It's because default values of these attributes are set in HtmlTree constructor and appropriate getters returns this value directly. Solution: Move default values from constructor to appropriate getters instead. Tom -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Tree2
The problem was that you changed the TreeWalker interface. I've fixed my TreeWalker implementations but everyone else is going to have to do the same. I suggest at a minimum that you create a JIRA issue and mark it resolved so it makes it into the release notes. Sean On 10/10/06, Martin Marinschek [EMAIL PROTECTED] wrote: Yeah. I've already settled for a subclass. I had to copy over almost everything from the tree-sources. The only thing which rescued me from having to copy all was introducing the interface. Sean, is there a way you can get the interface working according to your needs? regards, Martin On 10/10/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I don't want the tree to _contain_ EditableValueHolders, but the tree to be an EditableValueHolder itself - imagine a dropdown which shows a tree, and you can select values from it... maybe a subclass is needed here, since that seams not to be a common use case, right? (I think we already said that during this thread) regards, Martin On 10/10/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin, What is the big deal about EditableValueHolder? Why should tree2 implement this? The idea is that Tree2 contains a tree of whatever types of JSF components you choose (just like dataTable.) You can use editable value holders right now if you want to. Just add one to your node. I am probably missing something but at the moment I fail to see the problem. Also, your tree intereface has broken some things on my end. TreeWalker now needs to take an instance of Tree instead of UITreeData. This breaks some custom tree implementations that I have done offline so I may need to revert that. Let me see if I can work with what you have. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: No, it's a pity that not, but I can't. I'm at a client here in Germany until end of November, can't take off a week. regards, Martin On 10/5/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin: I haven't had time to read this thread yet but I will shortly. Are you going to be at Apache Con this year? If so we can discuss some of your ideas in person as well. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Well, it wouldn't be a problem to have an extended version of the tree which implements EditableValueHolder, but not if the model of the tree is configured by setting the value-attribute - then extending won't work. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: hi Arash, sure your feedback is welcome :) like said before, a generic raw version + aditional tree stuff. During that task we should also take a look at tree / treeTable, IMHO. -M On 10/5/06, Arash Rajaeeyan [EMAIL PROTECTED] wrote: Hello Mattias, I am so new to this list and may be I am not allowed to say this, but I think most developers I have seen use menu related components for only displaying structured data, and most of times data is displayed to user for one of the following purposes: 1) selecting one item 2) selecting multiple item 3) displaying and editing tree structured data (like organization chart, directory services, etc) the first 2 options are currently supported features of tree2, the 3'rd is under debate. May be if we can use same parent for both menu and tree navigation related components and simple tree data structure as said by matias and zubin, for parent of all these components can have following benefits: 1) simplifying development 2) simplifying learning for users 3) making it easier to add more advanced trees later on demand Best regards Arash On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface
Re: Tree2
Hi Sean, ok, I see - I thought it would be good to separate Tree and TreeWalker a bit more, so that I could reuse at least some of the functionality. I don't want the tree to _contain_ EditableValueHolders, but the tree to be an EditableValueHolder itself - imagine a dropdown which shows a tree, and you can select values from it... regards, Martin On 10/10/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin, What is the big deal about EditableValueHolder? Why should tree2 implement this? The idea is that Tree2 contains a tree of whatever types of JSF components you choose (just like dataTable.) You can use editable value holders right now if you want to. Just add one to your node. I am probably missing something but at the moment I fail to see the problem. Also, your tree intereface has broken some things on my end. TreeWalker now needs to take an instance of Tree instead of UITreeData. This breaks some custom tree implementations that I have done offline so I may need to revert that. Let me see if I can work with what you have. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: No, it's a pity that not, but I can't. I'm at a client here in Germany until end of November, can't take off a week. regards, Martin On 10/5/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin: I haven't had time to read this thread yet but I will shortly. Are you going to be at Apache Con this year? If so we can discuss some of your ideas in person as well. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Well, it wouldn't be a problem to have an extended version of the tree which implements EditableValueHolder, but not if the model of the tree is configured by setting the value-attribute - then extending won't work. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: hi Arash, sure your feedback is welcome :) like said before, a generic raw version + aditional tree stuff. During that task we should also take a look at tree / treeTable, IMHO. -M On 10/5/06, Arash Rajaeeyan [EMAIL PROTECTED] wrote: Hello Mattias, I am so new to this list and may be I am not allowed to say this, but I think most developers I have seen use menu related components for only displaying structured data, and most of times data is displayed to user for one of the following purposes: 1) selecting one item 2) selecting multiple item 3) displaying and editing tree structured data (like organization chart, directory services, etc) the first 2 options are currently supported features of tree2, the 3'rd is under debate. May be if we can use same parent for both menu and tree navigation related components and simple tree data structure as said by matias and zubin, for parent of all these components can have following benefits: 1) simplifying development 2) simplifying learning for users 3) making it easier to add more advanced trees later on demand Best regards Arash On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces
Re: Tree2
I don't want the tree to _contain_ EditableValueHolders, but the tree to be an EditableValueHolder itself - imagine a dropdown which shows a tree, and you can select values from it... maybe a subclass is needed here, since that seams not to be a common use case, right? (I think we already said that during this thread) regards, Martin On 10/10/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin, What is the big deal about EditableValueHolder? Why should tree2 implement this? The idea is that Tree2 contains a tree of whatever types of JSF components you choose (just like dataTable.) You can use editable value holders right now if you want to. Just add one to your node. I am probably missing something but at the moment I fail to see the problem. Also, your tree intereface has broken some things on my end. TreeWalker now needs to take an instance of Tree instead of UITreeData. This breaks some custom tree implementations that I have done offline so I may need to revert that. Let me see if I can work with what you have. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: No, it's a pity that not, but I can't. I'm at a client here in Germany until end of November, can't take off a week. regards, Martin On 10/5/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin: I haven't had time to read this thread yet but I will shortly. Are you going to be at Apache Con this year? If so we can discuss some of your ideas in person as well. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Well, it wouldn't be a problem to have an extended version of the tree which implements EditableValueHolder, but not if the model of the tree is configured by setting the value-attribute - then extending won't work. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: hi Arash, sure your feedback is welcome :) like said before, a generic raw version + aditional tree stuff. During that task we should also take a look at tree / treeTable, IMHO. -M On 10/5/06, Arash Rajaeeyan [EMAIL PROTECTED] wrote: Hello Mattias, I am so new to this list and may be I am not allowed to say this, but I think most developers I have seen use menu related components for only displaying structured data, and most of times data is displayed to user for one of the following purposes: 1) selecting one item 2) selecting multiple item 3) displaying and editing tree structured data (like organization chart, directory services, etc) the first 2 options are currently supported features of tree2, the 3'rd is under debate. May be if we can use same parent for both menu and tree navigation related components and simple tree data structure as said by matias and zubin, for parent of all these components can have following benefits: 1) simplifying development 2) simplifying learning for users 3) making it easier to add more advanced trees later on demand Best regards Arash On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable
Re: Tree2
Yeah. I've already settled for a subclass. I had to copy over almost everything from the tree-sources. The only thing which rescued me from having to copy all was introducing the interface. Sean, is there a way you can get the interface working according to your needs? regards, Martin On 10/10/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I don't want the tree to _contain_ EditableValueHolders, but the tree to be an EditableValueHolder itself - imagine a dropdown which shows a tree, and you can select values from it... maybe a subclass is needed here, since that seams not to be a common use case, right? (I think we already said that during this thread) regards, Martin On 10/10/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin, What is the big deal about EditableValueHolder? Why should tree2 implement this? The idea is that Tree2 contains a tree of whatever types of JSF components you choose (just like dataTable.) You can use editable value holders right now if you want to. Just add one to your node. I am probably missing something but at the moment I fail to see the problem. Also, your tree intereface has broken some things on my end. TreeWalker now needs to take an instance of Tree instead of UITreeData. This breaks some custom tree implementations that I have done offline so I may need to revert that. Let me see if I can work with what you have. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: No, it's a pity that not, but I can't. I'm at a client here in Germany until end of November, can't take off a week. regards, Martin On 10/5/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin: I haven't had time to read this thread yet but I will shortly. Are you going to be at Apache Con this year? If so we can discuss some of your ideas in person as well. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Well, it wouldn't be a problem to have an extended version of the tree which implements EditableValueHolder, but not if the model of the tree is configured by setting the value-attribute - then extending won't work. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: hi Arash, sure your feedback is welcome :) like said before, a generic raw version + aditional tree stuff. During that task we should also take a look at tree / treeTable, IMHO. -M On 10/5/06, Arash Rajaeeyan [EMAIL PROTECTED] wrote: Hello Mattias, I am so new to this list and may be I am not allowed to say this, but I think most developers I have seen use menu related components for only displaying structured data, and most of times data is displayed to user for one of the following purposes: 1) selecting one item 2) selecting multiple item 3) displaying and editing tree structured data (like organization chart, directory services, etc) the first 2 options are currently supported features of tree2, the 3'rd is under debate. May be if we can use same parent for both menu and tree navigation related components and simple tree data structure as said by matias and zubin, for parent of all these components can have following benefits: 1) simplifying development 2) simplifying learning for users 3) making it easier to add more advanced trees later on demand Best regards Arash On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping
Re: Tree2
Martin, What is the big deal about EditableValueHolder? Why should tree2 implement this? The idea is that Tree2 contains a tree of whatever types of JSF components you choose (just like dataTable.) You can use editable value holders right now if you want to. Just add one to your node. I am probably missing something but at the moment I fail to see the problem. Also, your tree intereface has broken some things on my end. TreeWalker now needs to take an instance of Tree instead of UITreeData. This breaks some custom tree implementations that I have done offline so I may need to revert that. Let me see if I can work with what you have. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: No, it's a pity that not, but I can't. I'm at a client here in Germany until end of November, can't take off a week. regards, Martin On 10/5/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin: I haven't had time to read this thread yet but I will shortly. Are you going to be at Apache Con this year? If so we can discuss some of your ideas in person as well. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Well, it wouldn't be a problem to have an extended version of the tree which implements EditableValueHolder, but not if the model of the tree is configured by setting the value-attribute - then extending won't work. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: hi Arash, sure your feedback is welcome :) like said before, a generic raw version + aditional tree stuff. During that task we should also take a look at tree / treeTable, IMHO. -M On 10/5/06, Arash Rajaeeyan [EMAIL PROTECTED] wrote: Hello Mattias, I am so new to this list and may be I am not allowed to say this, but I think most developers I have seen use menu related components for only displaying structured data, and most of times data is displayed to user for one of the following purposes: 1) selecting one item 2) selecting multiple item 3) displaying and editing tree structured data (like organization chart, directory services, etc) the first 2 options are currently supported features of tree2, the 3'rd is under debate. May be if we can use same parent for both menu and tree navigation related components and simple tree data structure as said by matias and zubin, for parent of all these components can have following benefits: 1) simplifying development 2) simplifying learning for users 3) making it easier to add more advanced trees later on demand Best regards Arash On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't
Re: Tree2
Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad the Tree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2 should extend UIData instead of UIComponent(Base) The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate nothing wrong w/ using model instead of value, since value makes sense on (editable)valueHolders to me... (like UIOutput, UIInput, UISelect*,...) anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). I guess they just simply introduced that since there was a value of (edit.)value:_holders Additionally, the tree is doing a lot with respect to the markup of the component. I'm not sure if this is useful as very large HTML-bases result from this. I suspect it would be better to only transfer the data-model to the client (and maybe templates for each node-type), and then render the nodes on the client dynamically. you mean sending xml to the client and using a JS_engine to render on the client side? -Matthias Thoughts? regards, Martin -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: Tree2
I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad the Tree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2 should extend UIData instead of UIComponent(Base) The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate nothing wrong w/ using model instead of value, since value makes sense on (editable)valueHolders to me... (like UIOutput, UIInput, UISelect*,...) anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). I guess they just simply introduced that since there was a value of (edit.)value:_holders Additionally, the tree is doing a lot with respect to the markup of the component. I'm not sure if this is useful as very large HTML-bases result from this. I suspect it would be better to only transfer the data-model to the client (and maybe templates for each node-type), and then render the nodes on the client dynamically. you mean sending xml to the client and using a JS_engine to render on the client side? -Matthias Thoughts? regards, Martin -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
Re: Tree2
Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad the Tree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2 should extend UIData instead of UIComponent(Base) The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate nothing wrong w/ using model instead of value, since value makes sense on (editable)valueHolders to me... (like UIOutput, UIInput, UISelect*,...) anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). I guess they just simply introduced that since there was a value of (edit.)value:_holders Additionally, the tree is doing a lot with respect to the markup of the component. I'm not sure if this is useful as very large HTML-bases result from this. I suspect it would be better to only transfer the data-model to the client (and maybe templates for each node-type), and then render the nodes on the client dynamically. you mean sending xml to the client and using a JS_engine to render on the client side? -Matthias Thoughts? regards, Martin -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: Tree2
I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad the Tree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2 should extend UIData instead of UIComponent(Base) The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate nothing wrong w/ using model instead of value, since value makes sense on (editable)valueHolders to me... (like UIOutput, UIInput, UISelect*,...) anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). I guess they just simply introduced that since there was a value of (edit.)value:_holders Additionally, the tree is doing a lot with respect to the markup of the component. I'm not sure if this is useful as very large HTML-bases result from this. I suspect it would be better to only transfer the data-model to the client (and maybe templates for each node-type), and then render the nodes on the client dynamically. you mean sending xml to the client and using a JS_engine to render on the client side? -Matthias Thoughts? regards, Martin -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
Re: Tree2
also why should a tree, used for navigation structure be an editable value holder? It just structures data :) On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad the Tree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2 should extend UIData instead of UIComponent(Base) The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate nothing wrong w/ using model instead of value, since value makes sense on (editable)valueHolders to me... (like UIOutput, UIInput, UISelect*,...) anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). I guess they just simply introduced that since there was a value of (edit.)value:_holders Additionally, the tree is doing a lot with respect to the markup of the component. I'm not sure if this is useful as very large HTML-bases result from this. I suspect it would be better to only transfer the data-model to the client (and maybe templates for each node-type), and then render the nodes on the client dynamically. you mean sending xml to the client and using a JS_engine to render on the client side? -Matthias Thoughts? regards, Martin -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail
Re: Tree2
I haven't said that there is no value for that. But I am abit against a super tree component :) Maybe there is value for a specialized editable tree or what ever. I know scenarios where that would be nice. but on the other hand you don't want this overhead when just displaying structured data. I think same is true for an editable table (not a table w/ inputText in it... ;) ) -M On 10/5/06, Zubin Wadia [EMAIL PROTECTED] wrote: Matthias, I think the Tree component can be used in contexts beyond navigation - for example, it can be implemented for Content/Document management where a Category-DocumentType heirarchy needs to be user managed and editable based on their changing business process and the type of content they wish to classify. In the .NET world - this excellent Tree component also supports Node editing for such scenarios: http://www.componentart.com/treeview/features.aspx I believe there is value in the use-case Martin is describing. Cheers, Zubin. On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: also why should a tree, used for navigation structure be an editable value holder? It just structures data :) On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad the Tree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2 should extend UIData instead of UIComponent(Base) The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate nothing wrong w/ using model instead of value, since value makes sense on (editable)valueHolders to me... (like UIOutput, UIInput, UISelect*,...) anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). I guess they just simply introduced that since
Re: Tree2
For better scope control perhaps we should have a baseTree and an advancedTree component set? yeah, maybe we go the route like Faces does it self. A generic component (UITree) and some more specialized (EditableTree) or what ever. -M Cheers, Zubin. On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I haven't said that there is no value for that. But I am abit against a super tree component :) Maybe there is value for a specialized editable tree or what ever. I know scenarios where that would be nice. but on the other hand you don't want this overhead when just displaying structured data. I think same is true for an editable table (not a table w/ inputText in it... ;) ) -M On 10/5/06, Zubin Wadia [EMAIL PROTECTED] wrote: Matthias, I think the Tree component can be used in contexts beyond navigation - for example, it can be implemented for Content/Document management where a Category-DocumentType heirarchy needs to be user managed and editable based on their changing business process and the type of content they wish to classify. In the .NET world - this excellent Tree component also supports Node editing for such scenarios: http://www.componentart.com/treeview/features.aspx I believe there is value in the use-case Martin is describing. Cheers, Zubin. On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: also why should a tree, used for navigation structure be an editable value holder? It just structures data :) On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad the Tree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2 should extend UIData instead
Re: Tree2
regarding the ajaxized version, would be cool if the renderer takes care of dojo. rendering out the dojo:widget / things and adding the dojo.js file to the *header* of the page. So the widget builds the client treee. -M On 10/5/06, Zubin Wadia [EMAIL PROTECTED] wrote: Right on. I think drag and drop node switching and editing should be part of an AJAXized implementation of the Tree component as that model suits it better. For better scope control perhaps we should have a baseTree and an advancedTree component set? Cheers, Zubin. On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I haven't said that there is no value for that. But I am abit against a super tree component :) Maybe there is value for a specialized editable tree or what ever. I know scenarios where that would be nice. but on the other hand you don't want this overhead when just displaying structured data. I think same is true for an editable table (not a table w/ inputText in it... ;) ) -M On 10/5/06, Zubin Wadia [EMAIL PROTECTED] wrote: Matthias, I think the Tree component can be used in contexts beyond navigation - for example, it can be implemented for Content/Document management where a Category-DocumentType heirarchy needs to be user managed and editable based on their changing business process and the type of content they wish to classify. In the .NET world - this excellent Tree component also supports Node editing for such scenarios: http://www.componentart.com/treeview/features.aspx I believe there is value in the use-case Martin is describing. Cheers, Zubin. On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: also why should a tree, used for navigation structure be an editable value holder? It just structures data :) On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well
Re: Tree2
Precisely! Perhaps Werner can chime in some more on this too..Z.On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote:regarding the ajaxized version, would be cool if the renderer takes care of dojo.rendering out the dojo:widget / things and adding the dojo.jsfile to the *header* of the page. So the widget builds the clienttreee.-MOn 10/5/06, Zubin Wadia [EMAIL PROTECTED] wrote: Right on. I think drag and drop node switching and editing should be part of an AJAXized implementation of the Tree component as that model suits it better. For better scope control perhaps we should have a baseTree and an advancedTree component set? Cheers, Zubin. On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I haven't said that there is no value for that. But I am abit against a super tree component :) Maybe there is value for a specialized editable tree or what ever. I know scenarios where that would be nice. but on the other hand you don't want this overhead when just displaying structured data. I think same is true for an editable table (not a table w/ inputText in it... ;) ) -M On 10/5/06, Zubin Wadia [EMAIL PROTECTED] wrote: Matthias, I think the Tree component can be used in contexts beyond navigation - for example, it can be implemented for Content/Document management where a Category-DocumentType heirarchy needs to be user managed and editable based on their changing business process and the type of content they wish to classify. In the .NET world - this excellent Tree component also supports Node editing for such scenarios: http://www.componentart.com/treeview/features.aspx I believe there is value in the use-case Martin is describing. Cheers, Zubin. On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote:also why should a tree, used for navigation structure be an editablevalue holder? It just structures data :) On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote:Hi *, yes, I'd also like to do an Ajaxified version, but that's not thefirst thing I'm looking at. I believe that extending from UIData is not really what we should do -UIData is totally row-based, and a row-index doesn't make so muchsense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface
Re: Tree2
I bet! :) On 10/5/06, Zubin Wadia [EMAIL PROTECTED] wrote: Precisely! Perhaps Werner can chime in some more on this too.. Z. On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: regarding the ajaxized version, would be cool if the renderer takes care of dojo. rendering out the dojo:widget / things and adding the dojo.js file to the *header* of the page. So the widget builds the client treee. -M On 10/5/06, Zubin Wadia [EMAIL PROTECTED] wrote: Right on. I think drag and drop node switching and editing should be part of an AJAXized implementation of the Tree component as that model suits it better. For better scope control perhaps we should have a baseTree and an advancedTree component set? Cheers, Zubin. On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I haven't said that there is no value for that. But I am abit against a super tree component :) Maybe there is value for a specialized editable tree or what ever. I know scenarios where that would be nice. but on the other hand you don't want this overhead when just displaying structured data. I think same is true for an editable table (not a table w/ inputText in it... ;) ) -M On 10/5/06, Zubin Wadia [EMAIL PROTECTED] wrote: Matthias, I think the Tree component can be used in contexts beyond navigation - for example, it can be implemented for Content/Document management where a Category-DocumentType heirarchy needs to be user managed and editable based on their changing business process and the type of content they wish to classify. In the .NET world - this excellent Tree component also supports Node editing for such scenarios: http://www.componentart.com/treeview/features.aspx I believe there is value in the use-case Martin is describing. Cheers, Zubin. On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: also why should a tree, used for navigation structure be an editable value holder? It just structures data :) On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could
[jira] Created: (TOMAHAWK-727) tree2 do not work with clientSideToggle=true and preserveToggle=false
tree2 do not work with clientSideToggle=true and preserveToggle=false - Key: TOMAHAWK-727 URL: http://issues.apache.org/jira/browse/TOMAHAWK-727 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree Affects Versions: 1.1.5-SNAPSHOT Reporter: Mario Ivankovits The reason is that the server side treeModel do not know which nodes are expanded and so do not call decode on them. 1) In HtmlTreeRenderer.decode If a node is expanded or not will be restored from the cookie (client-side) or from a request parameter (server-side) There the case that in client-side toggle there is no cookie will not be honored 2) UITreeData.processNodes There the TreeWalker see a all nodes closed tree and stops traversing -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-727) tree2 do not work with clientSideToggle=true and preserveToggle=false
[ http://issues.apache.org/jira/browse/TOMAHAWK-727?page=comments#action_12440099 ] Mario Ivankovits commented on TOMAHAWK-727: --- IMHO the correct solution is to transfer the tree state through a hidden field. The problem one might have then is, that the tree will show the nodes expanded after postback (even without preserverToggle). For me having the nodes expanded is the behavior I await from the tree. Any objections? tree2 do not work with clientSideToggle=true and preserveToggle=false - Key: TOMAHAWK-727 URL: http://issues.apache.org/jira/browse/TOMAHAWK-727 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree Affects Versions: 1.1.5-SNAPSHOT Reporter: Mario Ivankovits The reason is that the server side treeModel do not know which nodes are expanded and so do not call decode on them. 1) In HtmlTreeRenderer.decode If a node is expanded or not will be restored from the cookie (client-side) or from a request parameter (server-side) There the case that in client-side toggle there is no cookie will not be honored 2) UITreeData.processNodes There the TreeWalker see a all nodes closed tree and stops traversing -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Tree2
Let me read the entire thread first :-) later tonight Matthias Wessendorf schrieb: I bet! :) On 10/5/06, Zubin Wadia [EMAIL PROTECTED] wrote: Precisely! Perhaps Werner can chime in some more on this too.. Z.
Re: Tree2
Hello Mattias, I am so new to this list and may be I am not allowed to say this, but I think most developers I have seen use menu related components for only displaying structured data, and most of times data is displayed to user for one of the following purposes: 1) selecting one item 2) selecting multiple item 3) displaying and editing tree structured data (like organization chart, directory services, etc) the first 2 options are currently supported features of tree2, the 3'rd is under debate. May be if we can use same parent for both menu and tree navigation related components and simple tree data structure as said by matias and zubin, for parent of all these components can have following benefits: 1) simplifying development 2) simplifying learning for users 3) making it easier to add more advanced trees later on demand Best regards Arash On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component.What should the input be? So you are willing register also validatorson the tree?maybe that is more specialized use case instead a generic tree use case you are looking at.On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote:Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad theTree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2should extend UIData instead of UIComponent(Base) The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate nothing wrong w/ using model instead of value, since value makes sense on(editable)valueHolders to me...(like UIOutput, UIInput, UISelect*,...) anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). I guess they just simply introduced that since there was a value of(edit.)value:_holders Additionally, the tree is doing a lot with respect to the markup of the component. I'm not sure if this is useful as very large HTML-bases result from this. I suspect it would be better to only transfer the data-model to the client (and maybe templates for each node-type), and then render the nodes on the client dynamically. you mean sending xml to the client and using a JS_engine to renderon the client side? -Matthias Thoughts? regards, Martin -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development
Re: Tree2
hi Arash, sure your feedback is welcome :) like said before, a generic raw version + aditional tree stuff. During that task we should also take a look at tree / treeTable, IMHO. -M On 10/5/06, Arash Rajaeeyan [EMAIL PROTECTED] wrote: Hello Mattias, I am so new to this list and may be I am not allowed to say this, but I think most developers I have seen use menu related components for only displaying structured data, and most of times data is displayed to user for one of the following purposes: 1) selecting one item 2) selecting multiple item 3) displaying and editing tree structured data (like organization chart, directory services, etc) the first 2 options are currently supported features of tree2, the 3'rd is under debate. May be if we can use same parent for both menu and tree navigation related components and simple tree data structure as said by matias and zubin, for parent of all these components can have following benefits: 1) simplifying development 2) simplifying learning for users 3) making it easier to add more advanced trees later on demand Best regards Arash On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad the Tree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2 should extend UIData instead of UIComponent(Base) The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate nothing wrong w/ using model instead of value, since value makes sense on (editable)valueHolders to me... (like UIOutput, UIInput, UISelect*,...) anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). I guess they just simply introduced that since there was a value of (edit.)value:_holders Additionally, the tree is doing a lot with respect to the markup of the component. I'm
Re: Tree2
Well, it wouldn't be a problem to have an extended version of the tree which implements EditableValueHolder, but not if the model of the tree is configured by setting the value-attribute - then extending won't work. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: hi Arash, sure your feedback is welcome :) like said before, a generic raw version + aditional tree stuff. During that task we should also take a look at tree / treeTable, IMHO. -M On 10/5/06, Arash Rajaeeyan [EMAIL PROTECTED] wrote: Hello Mattias, I am so new to this list and may be I am not allowed to say this, but I think most developers I have seen use menu related components for only displaying structured data, and most of times data is displayed to user for one of the following purposes: 1) selecting one item 2) selecting multiple item 3) displaying and editing tree structured data (like organization chart, directory services, etc) the first 2 options are currently supported features of tree2, the 3'rd is under debate. May be if we can use same parent for both menu and tree navigation related components and simple tree data structure as said by matias and zubin, for parent of all these components can have following benefits: 1) simplifying development 2) simplifying learning for users 3) making it easier to add more advanced trees later on demand Best regards Arash On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad the Tree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2 should extend UIData instead of UIComponent(Base) The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate nothing wrong w/ using model instead of value, since value makes sense on (editable)valueHolders to me
Re: Tree2
No, it's a pity that not, but I can't. I'm at a client here in Germany until end of November, can't take off a week. regards, Martin On 10/5/06, Sean Schofield [EMAIL PROTECTED] wrote: Martin: I haven't had time to read this thread yet but I will shortly. Are you going to be at Apache Con this year? If so we can discuss some of your ideas in person as well. Sean On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Well, it wouldn't be a problem to have an extended version of the tree which implements EditableValueHolder, but not if the model of the tree is configured by setting the value-attribute - then extending won't work. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: hi Arash, sure your feedback is welcome :) like said before, a generic raw version + aditional tree stuff. During that task we should also take a look at tree / treeTable, IMHO. -M On 10/5/06, Arash Rajaeeyan [EMAIL PROTECTED] wrote: Hello Mattias, I am so new to this list and may be I am not allowed to say this, but I think most developers I have seen use menu related components for only displaying structured data, and most of times data is displayed to user for one of the following purposes: 1) selecting one item 2) selecting multiple item 3) displaying and editing tree structured data (like organization chart, directory services, etc) the first 2 options are currently supported features of tree2, the 3'rd is under debate. May be if we can use same parent for both menu and tree navigation related components and simple tree data structure as said by matias and zubin, for parent of all these components can have following benefits: 1) simplifying development 2) simplifying learning for users 3) making it easier to add more advanced trees later on demand Best regards Arash On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree should display structured data and not be an input component. What should the input be? So you are willing register also validators on the tree? maybe that is more specialized use case instead a generic tree use case you are looking at. On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi Matthias, for the reason that every component that has changing values needs to be an editable value holder. Imagine the case of a tree embedded in a data-table - a data-table, at least the ones of both MyFaces and the RI (I know, Trinidad's data-table does something different) only save whatever is part of the EditableValueHolder interface. So the selection model of a tree won't be saved in a dataTable, except it is part of the EditableValueHolder interface. regards, Martin On 10/5/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: I think a tree is much more about sturctured data instead of input data The UIXCollection is a base clazz for the stamping, that you can say var on those tags. UIComponent | + - UIXComponent | + - UIXComponentBase | + UIXCollection Collection has some subclasses like UIXHierarchy | + UIXTree and UIXIterator | + UIXTable The Trinidad Tree uses a TreeModel which extends CollectionModel (Trin) which extends DataModel (Faces). CollectionModel is also used by the Trin Table. But, I am not really sure, why the table should be EditableValueHolder ? Thanks! -Matthias On 10/5/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, yes, I'd also like to do an Ajaxified version, but that's not the first thing I'm looking at. I believe that extending from UIData is not really what we should do - UIData is totally row-based, and a row-index doesn't make so much sense for a dynamic tree. What are the tree and the table of trinidad sharing with the UIXCollection interface? regards, Martin On 10/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should
Tree2
Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). Additionally, the tree is doing a lot with respect to the markup of the component. I'm not sure if this is useful as very large HTML-bases result from this. I suspect it would be better to only transfer the data-model to the client (and maybe templates for each node-type), and then render the nodes on the client dynamically. Thoughts? regards, Martin -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: Tree2
Dear Martin I think for most people its easier to use list of values as selection model of the tree.would you please also consider adding an Ajax capability to Tree2 ?(beside server mode and client mode) regardsOn 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *,I'm reviewing the tree2 currently, and I was wondering if we couldhave a discussion about some of the concepts.First thing I'd like to discuss is what happens with selected nodes.Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be alist of values, stored at a useful place. Therefore, the tree shouldimplement the EditableValueHolder-interface, then we could do a lotmore with the values of the tree as well. The change would necessitate to move the current value attribute tosome other name - I suppose the name model would be more appropriateanyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attributeare generally quite different).Additionally, the tree is doing a lot with respect to the markup ofthe component. I'm not sure if this is useful as very large HTML-bases result from this. I suspect it would be better to only transfer thedata-model to the client (and maybe templates for each node-type), andthen render the nodes on the client dynamically.Thoughts? regards,Martin--http://www.irian.atYour JSF powerhouse -JSF Consulting, Development andCourses in English and GermanProfessional Support for Apache MyFaces -- Arash Rajaeeyan
Re: Tree2
would you please also consider adding an Ajax capability to Tree2 ? (beside server mode and client mode) there is a cool post from Rick Hightower how to use dojo and tree2 (or was it tree) -Matthias regards On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). Additionally, the tree is doing a lot with respect to the markup of the component. I'm not sure if this is useful as very large HTML-bases result from this. I suspect it would be better to only transfer the data-model to the client (and maybe templates for each node-type), and then render the nodes on the client dynamically. Thoughts? regards, Martin -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Arash Rajaeeyan -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
Re: Tree2
Hi M- On 10/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hi *, I'm reviewing the tree2 currently, and I was wondering if we could have a discussion about some of the concepts. First thing I'd like to discuss is what happens with selected nodes. Currently, selecting a node fires an action-listener. This is somewhat ok, but I believe the selection-model of a tree should rather be a list of values, stored at a useful place. Therefore, the tree should implement the EditableValueHolder-interface, then we could do a lot more with the values of the tree as well. I am not really sure about the EditableValueHolder. In Trinidad the Tree (UIXTree) is type of UIXCollection, which is also used by UIXTable. I remember some discussions from Sean in the past that they Tree2 should extend UIData instead of UIComponent(Base) The change would necessitate to move the current value attribute to some other name - I suppose the name model would be more appropriate nothing wrong w/ using model instead of value, since value makes sense on (editable)valueHolders to me... (like UIOutput, UIInput, UISelect*,...) anyways (I've never understood why a dataTable has a value-attribute, by the way, the semantics for the value-attribute are generally quite different). I guess they just simply introduced that since there was a value of (edit.)value:_holders Additionally, the tree is doing a lot with respect to the markup of the component. I'm not sure if this is useful as very large HTML-bases result from this. I suspect it would be better to only transfer the data-model to the client (and maybe templates for each node-type), and then render the nodes on the client dynamically. you mean sending xml to the client and using a JS_engine to render on the client side? -Matthias Thoughts? regards, Martin -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
[jira] Commented: (TOMAHAWK-437) Tree2 uses cookies when preserveToggle==false
[ http://issues.apache.org/jira/browse/TOMAHAWK-437?page=comments#action_12438666 ] Martin Schlierf commented on TOMAHAWK-437: -- Can you add a cookiePrefix parameter? That would help me with my issue which has the same root. My problem is: I use the tree to show the content of a folder which can be selected by a combobox. The user selects a folder. The Tree shows the content. The user opens some subfolders. The user selects another folder in the combobox. The tree is reinitialised and shows the content of the new folder but tries to expand the same subfolders as the folder before, because it´s saved in the cookie. Tree2 uses cookies when preserveToggle==false - Key: TOMAHAWK-437 URL: http://issues.apache.org/jira/browse/TOMAHAWK-437 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.2 Environment: actually the release version is 1.1.3 Reporter: Chris Hane Assigned To: sean schofield Priority: Minor Fix For: 1.1.4-SNAPSHOT This should probably be two issues, but I will let you decide that. 1. Can not have same screen open in two windows. Cookies from one screen affect the toggle status of the tree in the secon window. 2. preserveToggle==false still sets a cookie... Here is the original email to the list http://marc.theaimsgroup.com/?l=myfaces-devm=114727809302352w=2: paste I have been playing around with the tree2 control trying to make it do what I want. Nice control Question, I have been having issues with the following setup: - clientSideToggle = true - preserveToggle = false When I have two windows open on the same view, the tree2 state is shared between both. This means that someone can not view two different records and have different tree expand/collapse states. Or more specifically, when I execute an action (commandLink) on the tree and return the same view (i.e., add/delete a TreeNode), the state of expanded/collpased nodes is read from the cookie. I think I traced it down to the HtmlTreeRenderer.decode method. At line 123 is: if(tree.isClientSideToggle()) { restoreStateFromCookies(context, component); } Shouldn't the if statement also look at the tree.isPreserveToggle()? Not an expert in JSF by any stretch of the imagination, so if I'm on the wrong track or this doesn't make sense just let me know Chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-718) duplicated menu item for Tree2
duplicated menu item for Tree2 -- Key: TOMAHAWK-718 URL: http://issues.apache.org/jira/browse/TOMAHAWK-718 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Reporter: Luis Parravicini Priority: Minor There are two menu items in http://myfaces.apache.org/tomahawk/index.html for the Tree2 component. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (TOMAHAWK-534) tree2 expan/collapse broken when nested in a dataTable
[ http://issues.apache.org/jira/browse/TOMAHAWK-534?page=all ] Grant Smith reopened TOMAHAWK-534: -- tree2 expan/collapse broken when nested in a dataTable -- Key: TOMAHAWK-534 URL: http://issues.apache.org/jira/browse/TOMAHAWK-534 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.3 Environment: JBoss4.0.4.GA Reporter: Michal Borowiecki Assigned To: Grant Smith Attachments: HtmlTreeRenderer.patch, TreeToggle.PNG, TreeToggleDOM.PNG When a tree2 component is nested inside a dataTable the expand/collapse button doesn't work properly. Only the buttons in the tree in the first table row work correctly. Clicking the button to expand the root node in a tree in any row of the table always causes the root node in the first row to expand. This is caused by duplicate ids of the SPAN elements. The ids are rendered by HtmlTreeRenderer which incorrectly uses the tree's (simple) id instead of the (full) client id. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (TOMAHAWK-534) tree2 expan/collapse broken when nested in a dataTable
[ http://issues.apache.org/jira/browse/TOMAHAWK-534?page=all ] Grant Smith resolved TOMAHAWK-534. -- Resolution: Fixed tree2 expan/collapse broken when nested in a dataTable -- Key: TOMAHAWK-534 URL: http://issues.apache.org/jira/browse/TOMAHAWK-534 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.3 Environment: JBoss4.0.4.GA Reporter: Michal Borowiecki Assigned To: Grant Smith Attachments: HtmlTreeRenderer.patch, TreeToggle.PNG, TreeToggleDOM.PNG When a tree2 component is nested inside a dataTable the expand/collapse button doesn't work properly. Only the buttons in the tree in the first table row work correctly. Clicking the button to expand the root node in a tree in any row of the table always causes the root node in the first row to expand. This is caused by duplicate ids of the SPAN elements. The ids are rendered by HtmlTreeRenderer which incorrectly uses the tree's (simple) id instead of the (full) client id. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-671) Tree2 fails with NumberFormat Exception or Null Pointer Exception when ExpandAll button is placed in the same form as Tree2 using RI
[ http://issues.apache.org/jira/browse/TOMAHAWK-671?page=all ] Stan Laufik updated TOMAHAWK-671: - Status: Patch Available (was: Open) Tree2 fails with NumberFormat Exception or Null Pointer Exception when ExpandAll button is placed in the same form as Tree2 using RI Key: TOMAHAWK-671 URL: http://issues.apache.org/jira/browse/TOMAHAWK-671 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Environment: WindowsXP, SUN JSF RI 1.1.02, Tomahawk 1.1.5 Reporter: Stan Laufik Attachments: UITreeData.patch When a button that executes HtmlTree.expandAll is put into the same h:form then the Tree2 component after clicking on the button Tree2 throws NumberFormat or NullPointer exception (depending on which build of Tomahawk is used). On our system I have fixed it with teh following code: package org.apache.myfaces.custom.tree2 class UITreeData public void broadcast(FacesEvent event) throws AbortProcessingException { if (event instanceof FacesEventWrapper) { FacesEventWrapper childEvent = (FacesEventWrapper) event; String currNodeId = getNodeId(); setNodeId(childEvent.getNodeId()); FacesEvent nodeEvent = childEvent.getFacesEvent(); nodeEvent.getComponent().broadcast(nodeEvent); setNodeId(currNodeId); return; } else if(event instanceof ToggleExpandedEvent) { ToggleExpandedEvent toggleEvent = (ToggleExpandedEvent) event; if (toggleEvent.getNodeId() != null !null.equals(toggleEvent.getNodeId())) { String currentNodeId = getNodeId(); setNodeId(toggleEvent.getNodeId()); toggleExpanded(); setNodeId(currentNodeId); } } else { super.broadcast(event); return; } } The chanegd code first check if the node to be toggledis valid before it performs the toggle. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-671) Tree2 fails with NumberFormat Exception or Null Pointer Exception when ExpandAll button is placed in the same form as Tree2 using RI
[ http://issues.apache.org/jira/browse/TOMAHAWK-671?page=all ] Stan Laufik updated TOMAHAWK-671: - Status: Open (was: Patch Available) Tree2 fails with NumberFormat Exception or Null Pointer Exception when ExpandAll button is placed in the same form as Tree2 using RI Key: TOMAHAWK-671 URL: http://issues.apache.org/jira/browse/TOMAHAWK-671 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Environment: WindowsXP, SUN JSF RI 1.1.02, Tomahawk 1.1.5 Reporter: Stan Laufik Attachments: UITreeData.patch When a button that executes HtmlTree.expandAll is put into the same h:form then the Tree2 component after clicking on the button Tree2 throws NumberFormat or NullPointer exception (depending on which build of Tomahawk is used). On our system I have fixed it with teh following code: package org.apache.myfaces.custom.tree2 class UITreeData public void broadcast(FacesEvent event) throws AbortProcessingException { if (event instanceof FacesEventWrapper) { FacesEventWrapper childEvent = (FacesEventWrapper) event; String currNodeId = getNodeId(); setNodeId(childEvent.getNodeId()); FacesEvent nodeEvent = childEvent.getFacesEvent(); nodeEvent.getComponent().broadcast(nodeEvent); setNodeId(currNodeId); return; } else if(event instanceof ToggleExpandedEvent) { ToggleExpandedEvent toggleEvent = (ToggleExpandedEvent) event; if (toggleEvent.getNodeId() != null !null.equals(toggleEvent.getNodeId())) { String currentNodeId = getNodeId(); setNodeId(toggleEvent.getNodeId()); toggleExpanded(); setNodeId(currentNodeId); } } else { super.broadcast(event); return; } } The chanegd code first check if the node to be toggledis valid before it performs the toggle. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-667) Tree2 always collapse all on refresh
[ http://issues.apache.org/jira/browse/TOMAHAWK-667?page=comments#action_12434666 ] eric commented on TOMAHAWK-667: --- I think it comes from faces-config.xml I use tiles, so in order to upgrade Mafaces 1.1.1 to 1.1.3 I changed org.apache.myfaces.application.jsp.JspTilesViewHandlerImpl to org.apache.myfaces.tomahawk.application.jsp.JspTilesViewHandlerImpl Since, the Tree don't keep state's nodes. Tree2 always collapse all on refresh Key: TOMAHAWK-667 URL: http://issues.apache.org/jira/browse/TOMAHAWK-667 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Environment: Jboss Reporter: eric I have this code in my jsp : h:form t:tree2 value=#{arbre.tree} clientSideToggle=false showRootNode=true var=node varNodeToggler=t binding=#{arbre.treeBinding} javascriptLocation=/ressources/js/arbre imageLocation=/ressources/js/arbre/images f:facet name=Racine h:panelGroup t:graphicImage value=/ressources/images/treenode/yellow-folder-open.png rendered=#{t.nodeExpanded} border=0 id=image1racine/ t:graphicImage value=/ressources/images/treenode/yellow-folder-closed.png rendered=#{!t.nodeExpanded} border=0 id=image2racine/ t:outputText value=#{node.description} styleClass=nodeFolder forceId=true id=textracine/ /h:panelGroup /f:facet f:facet name=Dossier h:panelGroup t:graphicImage value=/ressources/images/treenode/yellow-folder-open.png rendered=#{t.nodeExpanded} border=0 id=image1dossier/ t:graphicImage value=/ressources/images/treenode/yellow-folder-closed.png rendered=#{!t.nodeExpanded} border=0 id=image2dossier/ t:outputText value=#{node.description} styleClass=nodeFolder forceId=true id=textdossier/ t:outputText value= (#{node.childCount}) styleClass=childCount rendered=#{!empty node.children} forceId=true id=textdossier2/ /h:panelGroup /f:facet f:facet name=DossierGrpCriteres h:panelGroup t:graphicImage value=/ressources/images/treenode/blue-folder-open.png rendered=#{t.nodeExpanded} border=0 id=image1dossiergrp/ t:graphicImage value=/ressources/images/treenode/blue-folder-closed.png rendered=#{!t.nodeExpanded} border=0 id=image2dossiergrp/ h:commandLink immediate=true styleClass=#{t.nodeSelected ? 'documentSelected':'document'} action=#{arbre.selectGrpCritere} id=lienDossierGrpcCritere h:outputText value=#{node.description} id=textDossierGrpCritere/ f:param name=id value=#{node.identifier} id=paramDossierGrpCritere/ /h:commandLink /h:panelGroup /f:facet f:facet name=TypeObjet h:panelGroup h:commandLink immediate=true styleClass=#{t.nodeSelected ? 'documentSelected':'document'} action=#{arbre.selectTypeObjet} id=lienTypeObjet t:graphicImage value=/ressources/images/treenode/document.png border=0 id=imageTypeObjet/ h:outputText value=#{node.description} id=textTypeObjet/ f:param name=id value=#{node.identifier} id=paramGrpCritere/ /h:commandLink /h:panelGroup /f:facet f:facet name=GrpCritere h:panelGroup h:commandLink immediate=true styleClass=#{t.nodeSelected ? 'documentSelected':'document'} action=#{arbre.selectGrpCritere} id=lienGrpcCritere t:graphicImage value=/ressources/images/treenode/document.png border=0 id=imageGrpCritere/ h:outputText value=#{node.description} id=textGrpCritere/ f:param name=id value=#{node.identifier} id=paramGrpCritere/ /h:commandLink /h:panelGroup /f:facet /t:tree2 /h:form When I click on a link, all my nodes are rendered collapse. I tried to call the method expandAll in the action of the link, but it didn't work. What can I do to fix this bug? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-671) Tree2 fails with NumberFormat Exception or Null Pointer Exception when ExpandAll button is placed in the same form as Tree2 using RI
[ http://issues.apache.org/jira/browse/TOMAHAWK-671?page=comments#action_12434799 ] Mike Kienenberger commented on TOMAHAWK-671: Thanks for working on this issue. Can you create a unified diff of your changes, attach the file to this issue, and click on the grant-rights-to-ASF radio button? Thanks! Tree2 fails with NumberFormat Exception or Null Pointer Exception when ExpandAll button is placed in the same form as Tree2 using RI Key: TOMAHAWK-671 URL: http://issues.apache.org/jira/browse/TOMAHAWK-671 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Environment: WindowsXP, SUN JSF RI 1.1.02, Tomahawk 1.1.5 Reporter: Stan Laufik When a button that executes HtmlTree.expandAll is put into the same h:form then the Tree2 component after clicking on the button Tree2 throws NumberFormat or NullPointer exception (depending on which build of Tomahawk is used). On our system I have fixed it with teh following code: package org.apache.myfaces.custom.tree2 class UITreeData public void broadcast(FacesEvent event) throws AbortProcessingException { if (event instanceof FacesEventWrapper) { FacesEventWrapper childEvent = (FacesEventWrapper) event; String currNodeId = getNodeId(); setNodeId(childEvent.getNodeId()); FacesEvent nodeEvent = childEvent.getFacesEvent(); nodeEvent.getComponent().broadcast(nodeEvent); setNodeId(currNodeId); return; } else if(event instanceof ToggleExpandedEvent) { ToggleExpandedEvent toggleEvent = (ToggleExpandedEvent) event; if (toggleEvent.getNodeId() != null !null.equals(toggleEvent.getNodeId())) { String currentNodeId = getNodeId(); setNodeId(toggleEvent.getNodeId()); toggleExpanded(); setNodeId(currentNodeId); } } else { super.broadcast(event); return; } } The chanegd code first check if the node to be toggledis valid before it performs the toggle. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-667) Tree2 always collapse all on refresh
[ http://issues.apache.org/jira/browse/TOMAHAWK-667?page=comments#action_12434421 ] eric commented on TOMAHAWK-667: --- This isn't a problem of library, in my point of view, it's a problem of configuration. Maybe the web.xml file, i don't know Tree2 always collapse all on refresh Key: TOMAHAWK-667 URL: http://issues.apache.org/jira/browse/TOMAHAWK-667 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Environment: Jboss Reporter: eric I have this code in my jsp : h:form t:tree2 value=#{arbre.tree} clientSideToggle=false showRootNode=true var=node varNodeToggler=t binding=#{arbre.treeBinding} javascriptLocation=/ressources/js/arbre imageLocation=/ressources/js/arbre/images f:facet name=Racine h:panelGroup t:graphicImage value=/ressources/images/treenode/yellow-folder-open.png rendered=#{t.nodeExpanded} border=0 id=image1racine/ t:graphicImage value=/ressources/images/treenode/yellow-folder-closed.png rendered=#{!t.nodeExpanded} border=0 id=image2racine/ t:outputText value=#{node.description} styleClass=nodeFolder forceId=true id=textracine/ /h:panelGroup /f:facet f:facet name=Dossier h:panelGroup t:graphicImage value=/ressources/images/treenode/yellow-folder-open.png rendered=#{t.nodeExpanded} border=0 id=image1dossier/ t:graphicImage value=/ressources/images/treenode/yellow-folder-closed.png rendered=#{!t.nodeExpanded} border=0 id=image2dossier/ t:outputText value=#{node.description} styleClass=nodeFolder forceId=true id=textdossier/ t:outputText value= (#{node.childCount}) styleClass=childCount rendered=#{!empty node.children} forceId=true id=textdossier2/ /h:panelGroup /f:facet f:facet name=DossierGrpCriteres h:panelGroup t:graphicImage value=/ressources/images/treenode/blue-folder-open.png rendered=#{t.nodeExpanded} border=0 id=image1dossiergrp/ t:graphicImage value=/ressources/images/treenode/blue-folder-closed.png rendered=#{!t.nodeExpanded} border=0 id=image2dossiergrp/ h:commandLink immediate=true styleClass=#{t.nodeSelected ? 'documentSelected':'document'} action=#{arbre.selectGrpCritere} id=lienDossierGrpcCritere h:outputText value=#{node.description} id=textDossierGrpCritere/ f:param name=id value=#{node.identifier} id=paramDossierGrpCritere/ /h:commandLink /h:panelGroup /f:facet f:facet name=TypeObjet h:panelGroup h:commandLink immediate=true styleClass=#{t.nodeSelected ? 'documentSelected':'document'} action=#{arbre.selectTypeObjet} id=lienTypeObjet t:graphicImage value=/ressources/images/treenode/document.png border=0 id=imageTypeObjet/ h:outputText value=#{node.description} id=textTypeObjet/ f:param name=id value=#{node.identifier} id=paramGrpCritere/ /h:commandLink /h:panelGroup /f:facet f:facet name=GrpCritere h:panelGroup h:commandLink immediate=true styleClass=#{t.nodeSelected ? 'documentSelected':'document'} action=#{arbre.selectGrpCritere} id=lienGrpcCritere t:graphicImage value=/ressources/images/treenode/document.png border=0 id=imageGrpCritere/ h:outputText value=#{node.description} id=textGrpCritere/ f:param name=id value=#{node.identifier} id=paramGrpCritere/ /h:commandLink /h:panelGroup /f:facet /t:tree2 /h:form When I click on a link, all my nodes are rendered collapse. I tried to call the method expandAll in the action of the link, but it didn't work. What can I do to fix this bug? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-671) Tree2 fails with NumberFormat Exception or Null Pointer Exception when ExpandAll button is placed in the same form as Tree2 using RI
Tree2 fails with NumberFormat Exception or Null Pointer Exception when ExpandAll button is placed in the same form as Tree2 using RI Key: TOMAHAWK-671 URL: http://issues.apache.org/jira/browse/TOMAHAWK-671 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Environment: WindowsXP, SUN JSF RI 1.1.02, Tomahawk 1.1.5 Reporter: Stan Laufik When a button that executes HtmlTree.expandAll is put into the same h:form then the Tree2 component after clicking on the button Tree2 throws NumberFormat or NullPointer exception (depending on which build of Tomahawk is used). On our system I have fixed it with teh following code: package org.apache.myfaces.custom.tree2 class UITreeData public void broadcast(FacesEvent event) throws AbortProcessingException { if (event instanceof FacesEventWrapper) { FacesEventWrapper childEvent = (FacesEventWrapper) event; String currNodeId = getNodeId(); setNodeId(childEvent.getNodeId()); FacesEvent nodeEvent = childEvent.getFacesEvent(); nodeEvent.getComponent().broadcast(nodeEvent); setNodeId(currNodeId); return; } else if(event instanceof ToggleExpandedEvent) { ToggleExpandedEvent toggleEvent = (ToggleExpandedEvent) event; if (toggleEvent.getNodeId() != null !null.equals(toggleEvent.getNodeId())) { String currentNodeId = getNodeId(); setNodeId(toggleEvent.getNodeId()); toggleExpanded(); setNodeId(currentNodeId); } } else { super.broadcast(event); return; } } The chanegd code first check if the node to be toggledis valid before it performs the toggle. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-667) Tree2 always collapse all on refresh
Tree2 always collapse all on refresh Key: TOMAHAWK-667 URL: http://issues.apache.org/jira/browse/TOMAHAWK-667 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.5-SNAPSHOT Environment: Jboss Reporter: eric I have this code in my jsp : h:form t:tree2 value=#{arbre.tree} clientSideToggle=false showRootNode=true var=node varNodeToggler=t binding=#{arbre.treeBinding} javascriptLocation=/ressources/js/arbre imageLocation=/ressources/js/arbre/images f:facet name=Racine h:panelGroup t:graphicImage value=/ressources/images/treenode/yellow-folder-open.png rendered=#{t.nodeExpanded} border=0 id=image1racine/ t:graphicImage value=/ressources/images/treenode/yellow-folder-closed.png rendered=#{!t.nodeExpanded} border=0 id=image2racine/ t:outputText value=#{node.description} styleClass=nodeFolder forceId=true id=textracine/ /h:panelGroup /f:facet f:facet name=Dossier h:panelGroup t:graphicImage value=/ressources/images/treenode/yellow-folder-open.png rendered=#{t.nodeExpanded} border=0 id=image1dossier/ t:graphicImage value=/ressources/images/treenode/yellow-folder-closed.png rendered=#{!t.nodeExpanded} border=0 id=image2dossier/ t:outputText value=#{node.description} styleClass=nodeFolder forceId=true id=textdossier/ t:outputText value= (#{node.childCount}) styleClass=childCount rendered=#{!empty node.children} forceId=true id=textdossier2/ /h:panelGroup /f:facet f:facet name=DossierGrpCriteres h:panelGroup t:graphicImage value=/ressources/images/treenode/blue-folder-open.png rendered=#{t.nodeExpanded} border=0 id=image1dossiergrp/ t:graphicImage value=/ressources/images/treenode/blue-folder-closed.png rendered=#{!t.nodeExpanded} border=0 id=image2dossiergrp/ h:commandLink immediate=true styleClass=#{t.nodeSelected ? 'documentSelected':'document'} action=#{arbre.selectGrpCritere} id=lienDossierGrpcCritere h:outputText value=#{node.description} id=textDossierGrpCritere/ f:param name=id value=#{node.identifier} id=paramDossierGrpCritere/ /h:commandLink /h:panelGroup /f:facet f:facet name=TypeObjet h:panelGroup h:commandLink immediate=true styleClass=#{t.nodeSelected ? 'documentSelected':'document'} action=#{arbre.selectTypeObjet} id=lienTypeObjet t:graphicImage value=/ressources/images/treenode/document.png border=0 id=imageTypeObjet/ h:outputText value=#{node.description} id=textTypeObjet/ f:param name=id value=#{node.identifier} id=paramGrpCritere/ /h:commandLink /h:panelGroup /f:facet f:facet name=GrpCritere h:panelGroup h:commandLink immediate=true styleClass=#{t.nodeSelected ? 'documentSelected':'document'} action=#{arbre.selectGrpCritere} id=lienGrpcCritere t:graphicImage value=/ressources/images/treenode/document.png border=0 id=imageGrpCritere/ h:outputText value=#{node.description} id=textGrpCritere/ f:param name=id value=#{node.identifier} id=paramGrpCritere/ /h:commandLink /h:panelGroup /f:facet /t:tree2 /h:form When I click on a link, all my nodes are rendered collapse. I tried to call the method expandAll in the action of the link, but it didn't work. What can I do to fix this bug? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1379) CLONE -commandLink actions ignored inside tree2
Hi, In response to your post at http://www.mail-archive.com/dev@myfaces.apache.org/msg16259.html Have you tried using immediate=true in your command link? I dont have any scientific basis for explaining this.. all I know is that immediate=true skips the validation phase? which I cant relate to the functioning of tree2. However using immediate=true caused my events to start working in this code here. If I do not use immediate=true, events do not fire. An explanation for this would be welcome also! t:tree2 id=userTeamTree value=#{treeMenu.treeModel} var=node showRootNode=false !-- render nodes of type root -- f:facet name=root h:panelGroup h:outputText value=All Teams and Users/ /h:panelGroup /f:facet %-- render nodes of type team --% f:facet name=team h:panelGroup t:graphicImage value=../images/teams.png/ h:commandLink immediate=true value=#{node.description} action=#{treeMenu.teamsInterface} f:param name=team_id value=#{node.identifier}/ /h:commandLink /h:panelGroup /f:facet !-- chosen to render nodes of type user -- f:facet name=user h:panelGroup h:commandLink immediate=true action=#{treeMenu.usersInterface} h:outputText value=#{node.description}/ f:param name=user_id value=#{node.identifier}/ /h:commandLink /h:panelGroup /f:facet /t:tree2 -- No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.1.405 / Virus Database: 268.11.2/422 - Release Date: 17/08/2006
tree2 component retains its state after sessin invaldation
I am using tree2 component as navigator in my application. The code is as follows: t:tree2 id=navMenu value=#{NavigationTreeHandler.expandedTreeData} binding=#{NavigationTreeHandler.tree} var=node varNodeToggler=t showLines=false showNav=false showRootNode=false preserveToggle=false clientSideToggle=false The tree works absolutely fine , but it persists its state even after the session has ended. When a new user logs in , instead of initially showing all the nodes collapsed the tree appears in the same state as the previous user had left it. How can I solve this. Need your help urgently -- View this message in context: http://www.nabble.com/tree2-component-retains-its-state-after-sessin-invaldation-tf2090367.html#a5761362 Sent from the My Faces - Dev forum at Nabble.com.
[jira] Created: (MYFACES-1379) CLONE -commandLink actions ignored inside tree2
CLONE -commandLink actions ignored inside tree2 --- Key: MYFACES-1379 URL: http://issues.apache.org/jira/browse/MYFACES-1379 Project: MyFaces Core Issue Type: Bug Affects Versions: 1.0.9m9 Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9. Reporter: Pavel Rezny Assigned To: sean schofield When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1379) CLONE -commandLink actions ignored inside tree2
[ http://issues.apache.org/jira/browse/MYFACES-1379?page=comments#action_12426150 ] Pavel Rezny commented on MYFACES-1379: -- I have the same problem with ignored Action listener of CommandButton/Commandlink. Java 1.5 update 7, Tomcat 5.5.17, JSF RI 1.1.02, Tomahawk Snapshot 1.1.4/1.1.5. The Listener is called if the definition is included in the JSP file. But creating the facet programmatically cause Listener to be ignored. (Actually I want to add whole tree programmatically to a page.) (I tried adding listener by method setActionListener and addActionListener - the same behaviour = listener ignored.) (Appearance of root node cause no change of the behavour.) HtmlTree tree = (HtmlTree) app.createComponent(HtmlTree.COMPONENT_TYPE); Map treeFacets = tree.getFacets(); treeFacets.clear(); HtmlCommandButton ot2 = (HtmlCommandButton) app.createComponent(HtmlCommandButton.COMPONENT_TYPE); ot2.setValue(Author); ot2.addActionListener(new ActionListener() { public void processAction(ActionEvent e) { throw new RuntimeException(YES); } }); treeFacets.put(clickable, ot2); // COMMENTING THIS LINE CAUSE USE OF FACET DEFINED IN JSP FILE AND ALL WORKS FINE Working definition in JSP file: h:form id=my_tree t:tree2 binding=#{DynamicTree['cidListTree']} value=#{TreeModelHolder.treeModel} id=my_tree_tree f:facet name=clickable h:commandLink actionListener=#{EventTrigger.onTreeNodeClick} value=#{node.description}/ /f:facet /t:tree /h:form CLONE -commandLink actions ignored inside tree2 --- Key: MYFACES-1379 URL: http://issues.apache.org/jira/browse/MYFACES-1379 Project: MyFaces Core Issue Type: Bug Affects Versions: 1.0.9m9 Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9. Reporter: Pavel Rezny Assigned To: sean schofield When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
tree2 documentation: value, var, varNodeToggler missing
I'm taking a look at tree2 for the first time. One thing I've noticed right off is the documentation, or lack thereof :) Most of the documentation is in the wiki, except for the tld. However, three attributes aren't documented at all: value, var, and varNodeToggler. I'm guessing var and value work like any UIData component (and it should be simple to copy those into the tlddocs from dataTable). However, varNodeToggler doesn't have any non-code documentation that I could find. I'm guessing it's an object that implements some kind of isExpanded/isCollapsed functionality and acts accordingly when a node's visibility state changes. Also, the http://www.irian.at/myfaces/tree2NoNav.jsf example seems kinda lame (only one node visible).
Re: tree2 documentation: value, var, varNodeToggler missing
I'm throwing all the documentation issues I encounter into this thread for now. Hopefully, I'll have time to update the docs at a later point. No documentation on what the allowable facets are. No documentation stating that expand and collapse facets need to be UIGraphic components. [Guess I shouldn't have tried replacing these with h:outputTexts] On 8/7/06, Mike Kienenberger [EMAIL PROTECTED] wrote: I'm taking a look at tree2 for the first time. One thing I've noticed right off is the documentation, or lack thereof :) Most of the documentation is in the wiki, except for the tld. However, three attributes aren't documented at all: value, var, and varNodeToggler. I'm guessing var and value work like any UIData component (and it should be simple to copy those into the tlddocs from dataTable). However, varNodeToggler doesn't have any non-code documentation that I could find. I'm guessing it's an object that implements some kind of isExpanded/isCollapsed functionality and acts accordingly when a node's visibility state changes. Also, the http://www.irian.at/myfaces/tree2NoNav.jsf example seems kinda lame (only one node visible).
Re: tree2 documentation: value, var, varNodeToggler missing
On 8/7/06, Mike Kienenberger [EMAIL PROTECTED] wrote: I'm throwing all the documentation issues I encounter into this thread for now. Hopefully, I'll have time to update the docs at a later point. Thanks, and so we don't lose track of your comments: http://issues.apache.org/jira/browse/TOMAHAWK-584 -- Wendy
Re: tree2 documentation: value, var, varNodeToggler missing
I'm guessing var and value work like any UIData component (and it should be simple to copy those into the tlddocs from dataTable). You guessed correctly. However, varNodeToggler doesn't have any non-code documentation that I could find. I'm guessing it's an object that implements some kind of isExpanded/isCollapsed functionality and acts accordingly when a node's visibility state changes. Yes. I will try to elaborate on that shortly (facing a deadline atm.) Also, the http://www.irian.at/myfaces/tree2NoNav.jsf example seems kinda lame (only one node visible). That doesn't sound right? Did you try expanding it? Again, I will look at it shortly. Sean
Re: tree2 documentation: value, var, varNodeToggler missing
No documentation on what the allowable facets are. No documentation stating that expand and collapse facets need to be UIGraphic components. [Guess I shouldn't have tried replacing these with h:outputTexts] The facets should be named after the node type. I know we need more documentation - I just never got around to it with all of the myfaces release stuff that I was doing. I'm taking a step back from the release stuff for now so I'll try and get back to some tree2 business. Please fell free to start some docs on the site. I'm happy to answer questions. Sean
Re: tree2 documentation: value, var, varNodeToggler missing
On 8/7/06, Wendy Smoak [EMAIL PROTECTED] wrote: On 8/7/06, Mike Kienenberger [EMAIL PROTECTED] wrote: I'm throwing all the documentation issues I encounter into this thread for now. Hopefully, I'll have time to update the docs at a later point. Thanks, and so we don't lose track of your comments: http://issues.apache.org/jira/browse/TOMAHAWK-584 Thanks, Wendy. I probably should have done that, but I wanted to make sure I hadn't missed any other documentation first. On 8/7/06, Sean Schofield [EMAIL PROTECTED] wrote: Yes. I will try to elaborate on that shortly (facing a deadline atm.) Completely understand. Take your time. I've got a deadline in a couple of weeks myself to meet. Also, the http://www.irian.at/myfaces/tree2NoNav.jsf example seems kinda lame (only one node visible). That doesn't sound right? Did you try expanding it? Again, I will look at it shortly. It doesn't seem to have any navigation controls (hence the name -- NoNav). On 8/7/06, Sean Schofield [EMAIL PROTECTED] wrote: No documentation on what the allowable facets are. No documentation stating that expand and collapse facets need to be UIGraphic components. [Guess I shouldn't have tried replacing these with h:outputTexts] The facets should be named after the node type. In addition, there's also collapse and expand facets -- I checked the source -- that expect UIGraphic children. I know we need more documentation - I just never got around to it with all of the myfaces release stuff that I was doing. I'm taking a step back from the release stuff for now so I'll try and get back to some tree2 business. Sean, let me go ahead and work with it for a little bit. Right now, I can work on documentation for tree2 (at least documentation drafts), but I can't work on releases. I'd rather let you do what only you can do :) (or at least, what you can do that I can't). My new eyes might point out some things that experienced tree2 users wouldn't see. Please fell free to start some docs on the site. I'm happy to answer questions. Yep, I'll do this once I get a better feel for the component.
[jira] Commented: (MYFACES-1376) getScrolling is not defined in simple tree2 example
[ http://issues.apache.org/jira/browse/MYFACES-1376?page=comments#action_12425566 ] Wendy Smoak commented on MYFACES-1376: -- On 02-Aug-2006, Matthias wrote: FIXED IN BRANCH URL: http://svn.apache.org/viewvc?rev=428231view=rev Log: fixed MYFACES-1376 by moving to commits from svn commit: r421297 to branch URL: http://svn.apache.org/viewvc?rev=428230view=rev Log: fixed MYFACES-1376 by moving to commits from svn commit: r421297 to branch ... and r421297 is: Author: mmarinschek Date: Wed Jul 12 08:54:40 2006 New Revision: 421297 URL: http://svn.apache.org/viewvc?rev=421297view=rev Log: made calling of several javascript functions dependent on if they are actually present. Added source section to the poms. Default message now also prints the message of the causes of an exception. getScrolling is not defined in simple tree2 example --- Key: MYFACES-1376 URL: http://issues.apache.org/jira/browse/MYFACES-1376 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.4-SNAPSHOT Reporter: sean schofield Assigned To: Matthias Weßendorf Priority: Blocker Fix For: 1.1.4-SNAPSHOT tree2NiceWrap.jsf throws a javascript error when you try to expand the node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1376) getScrolling is not defined in simple tree2 example
[ http://issues.apache.org/jira/browse/MYFACES-1376?page=comments#action_12425678 ] Wendy Smoak commented on MYFACES-1376: -- Matthias reverted part of r421297, here: http://svn.apache.org/viewvc?rev=428629view=rev (shared 2.0.4 trunk) http://svn.apache.org/viewvc?rev=428630view=rev (shared 2.0.3 branch) myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/util/JavascriptUtils.java -private static final String AUTO_SCROLL_PARAM = org_apache_myfaces_autoScroll; -private static final String AUTO_SCROLL_FUNCTION = org_apache_myfaces_getScrolling; +private static final String AUTO_SCROLL_PARAM = autoScroll; +private static final String AUTO_SCROLL_FUNCTION = getScrolling; getScrolling is not defined in simple tree2 example --- Key: MYFACES-1376 URL: http://issues.apache.org/jira/browse/MYFACES-1376 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.4-SNAPSHOT Reporter: sean schofield Assigned To: Matthias Weßendorf Priority: Blocker Fix For: 1.1.4-SNAPSHOT tree2NiceWrap.jsf throws a javascript error when you try to expand the node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-1376) getScrolling is not defined in simple tree2 example
getScrolling is not defined in simple tree2 example --- Key: MYFACES-1376 URL: http://issues.apache.org/jira/browse/MYFACES-1376 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.4-SNAPSHOT Reporter: sean schofield Priority: Blocker Fix For: 1.1.4-SNAPSHOT tree2NiceWrap.jsf throws a javascript error when you try to expand the node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1376) getScrolling is not defined in simple tree2 example
[ http://issues.apache.org/jira/browse/MYFACES-1376?page=comments#action_12425401 ] sean schofield commented on MYFACES-1376: - schedule1.jsf component is also experiencing this problem when you try to advance the calendar getScrolling is not defined in simple tree2 example --- Key: MYFACES-1376 URL: http://issues.apache.org/jira/browse/MYFACES-1376 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.4-SNAPSHOT Reporter: sean schofield Priority: Blocker Fix For: 1.1.4-SNAPSHOT tree2NiceWrap.jsf throws a javascript error when you try to expand the node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1376) getScrolling is not defined in simple tree2 example
[ http://issues.apache.org/jira/browse/MYFACES-1376?page=all ] Michael Hartman updated MYFACES-1376: - Status: Patch Available (was: Open) getScrolling is not defined in simple tree2 example --- Key: MYFACES-1376 URL: http://issues.apache.org/jira/browse/MYFACES-1376 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.4-SNAPSHOT Reporter: sean schofield Priority: Blocker Fix For: 1.1.4-SNAPSHOT tree2NiceWrap.jsf throws a javascript error when you try to expand the node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1376) getScrolling is not defined in simple tree2 example
[ http://issues.apache.org/jira/browse/MYFACES-1376?page=all ] sean schofield updated MYFACES-1376: Status: Open (was: Patch Available) getScrolling is not defined in simple tree2 example --- Key: MYFACES-1376 URL: http://issues.apache.org/jira/browse/MYFACES-1376 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.4-SNAPSHOT Reporter: sean schofield Priority: Blocker Fix For: 1.1.4-SNAPSHOT tree2NiceWrap.jsf throws a javascript error when you try to expand the node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1376) getScrolling is not defined in simple tree2 example
[ http://issues.apache.org/jira/browse/MYFACES-1376?page=comments#action_12425406 ] sean schofield commented on MYFACES-1376: - Apparently Michael Hartman marked this as patch available but I don't see one. Changing status back to Open. getScrolling is not defined in simple tree2 example --- Key: MYFACES-1376 URL: http://issues.apache.org/jira/browse/MYFACES-1376 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.4-SNAPSHOT Reporter: sean schofield Priority: Blocker Fix For: 1.1.4-SNAPSHOT tree2NiceWrap.jsf throws a javascript error when you try to expand the node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1376) getScrolling is not defined in simple tree2 example
[ http://issues.apache.org/jira/browse/MYFACES-1376?page=comments#action_12425423 ] Dennis Byrne commented on MYFACES-1376: --- There were a ton of users on the users list who had the problem but nobody could trace it down. I was one of the folks who couldn't reproduce it. A few weeks later I had the problem on a few pages of my app. I didn't spend much time on it, but for some reason I could fix it by adjusting position of the following element ... jsp:scriptletresponse.setContentType(text/html; charset=utf-8);/jsp:scriptlet very weird getScrolling is not defined in simple tree2 example --- Key: MYFACES-1376 URL: http://issues.apache.org/jira/browse/MYFACES-1376 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.4-SNAPSHOT Reporter: sean schofield Priority: Blocker Fix For: 1.1.4-SNAPSHOT tree2NiceWrap.jsf throws a javascript error when you try to expand the node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1376) getScrolling is not defined in simple tree2 example
[ http://issues.apache.org/jira/browse/MYFACES-1376?page=comments#action_12425433 ] Matthias Weßendorf commented on MYFACES-1376: - These page have also the same problem click on HOME for http://localhost:8080/myfaces/sample1.jsf click *each* link for: http://localhost:8080/myfaces/masterDetail.jsf http://localhost:8080/myfaces/dataScroller.jsf http://localhost:8080/myfaces/sortTable.jsf http://localhost:8080/myfaces/sortAutoTable.jsf http://localhost:8080/myfaces/sortAutoTable2.jsf http://localhost:8080/myfaces/pagedSortTable.jsf http://localhost:8080/myfaces/openDataTable.jsf http://localhost:8080/myfaces/crossDataTable.jsf# stopping here ... and trying 1.1.5 core getScrolling is not defined in simple tree2 example --- Key: MYFACES-1376 URL: http://issues.apache.org/jira/browse/MYFACES-1376 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.4-SNAPSHOT Reporter: sean schofield Priority: Blocker Fix For: 1.1.4-SNAPSHOT tree2NiceWrap.jsf throws a javascript error when you try to expand the node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-434) Tree2 Client Rendered when using MyFaces tiles support will not inject javascript tags correctly.
[ http://issues.apache.org/jira/browse/TOMAHAWK-434?page=comments#action_12422759 ] Chris Hornsey commented on TOMAHAWK-434: This is actually not related to the tiles as I had originally expected. The problem comes from pages which use more than one head tag. This is common for applciations which must be used by older IE browsers ref KB article : http://support.microsoft.com/kb/222064/en-us Microsoft suggests puting an extra head tag at the bottom of pages to force it to understand the cache headers correctly. This confuses the extension filter. When a page has more than one head tag (never should I know, but forced to support old browsers). the filter has an issues determining where to place the references to the requested resources. Tree2 Client Rendered when using MyFaces tiles support will not inject javascript tags correctly. - Key: TOMAHAWK-434 URL: http://issues.apache.org/jira/browse/TOMAHAWK-434 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.2 Environment: Rendered on client and on a page using the MyFaces Tiles integration. Reporter: Chris Hornsey When I put the tree control on a pge which uses the tiles support from MyFaces, then rendere page has the injected javascript references broken up. The page can not parse the rendered html to get a proper reference to the javascript files, thus the javascript functions needed when clicking the expand nodes will not execute. The javascript tags are rendered slightly above the begining of the controls form tag. You can see that the comment tag was interputed, it may be as simple as flushing the buffer in the appropriate spots: clear_propertyListResult(); //--/script/form/td/tr /tbody/table !-- MYFACES JAVASCR script type=text/javascript src=/CARE/faces/myFacesExtensionResource/org.apache.myfaces.renderkit.html.util.MyFacesResourceLoader/11474621/tree2.HtmlTreeRenderer/javascript/tree.js!-- //--/script -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-556) Tree2 (server side toggle) in form try validate(?) on expand node
Tree2 (server side toggle) in form try validate(?) on expand node - Key: TOMAHAWK-556 URL: http://issues.apache.org/jira/browse/TOMAHAWK-556 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.3, 1.1.2, 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Environment: all(?) I try with: sun java 1.5.06, apache tomcat 5.15 (linux and windows) Reporter: Piotr Beling Priority: Minor h:form ... t:tree2 clientSideToggle=false ... ... /t:tree2 ... h:inputText id=input_id ... required=true / ... /h:form Expand nodes in tree2 don't work when input (input_id) is empty. When clientSideToggle=true all is ok. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-557) Tree2 renderer (HtmlTreeRenderer) prints invalid clientId when a button/link with immediate='true' is fired
Tree2 renderer (HtmlTreeRenderer) prints invalid clientId when a button/link with immediate='true' is fired - Key: TOMAHAWK-557 URL: http://issues.apache.org/jira/browse/TOMAHAWK-557 Project: MyFaces Tomahawk Issue Type: Bug Components: Tree2 Affects Versions: 1.1.1 Environment: Jetty 5.1.10 MyFaces Core 1.1.1, MyFaces Tomahawk 1.1.1, Facelets 1.1, AJAX4JSF 1.0 Reporter: Nicholas Hagen I have a simple tree2 via: h:form id=form ... ... h:commandLink action=success value=Test immediate=true / t:tree2 id=test var=node value=#{Bean.model} clientSideToggle=false f:facet name=data h:outputText value=${node.description} / /f:facet /t:tree2 ... /h:form When first accessed, the page works correctly and the generated html shows: span id=form:test .../span However, if I click on the Test link that has immediate set to true, using no navigation rules so that the page just gets redisplayed, then I end up with an end result page with html: span id=form:test:0 ../span Looking into the code it appears that the :0 is appended during UIDataTree.getClientId() because the nodeId is not null. Normally, the tree is processed by calling the processDecodes, then processValidators, processUpdates, etc. At the end of processValidators and processUpdates, setNodeId(null) is called to reset the node id. Then, when encodeChidren is called on the renderer, the nodeId is null so that the clientId is correct. When immediate is set to true, then processValidators and processUpdates do not get called. Thus, the last decoded child (from processDecodes) is set as the node id, because processDecodes does not call setNodeId(null) nor does encodeBegin(). I looked at the implementation of HtmlDataTable and it appears that in its encodeBegin function that it calls setRowIndex(-1) to ensure the row is reset prior to building the table. I am wondering if this same behavior needs to be done in UIDataTree so that the node id is reset to null prior to rendering the tree. Also, should processDecodes call setNodeId(null) at the end of its processing similar to processValidators and processUpdates? This typically has no effect, unless you have JavaScript that expects that field to be properly named. For example, I am using AJAX4JSF to re-render this tree and A4J expects it to be called by the correct clientId, which initially works, but after causing an immediate event, it no longer works as the field is misnamed. The workaround for this issue for me was to subclass the renderer, register it in faces-config, and then call ((UITreeData) component).setNodeId(null) in the encodeBegin(...) method of the renderer. Further, I believe the last time I checked SVN, the sources still showed signs of this issue (ie: nothing was calling setNodeId(null) after the decode phase when processValidators/processUpdateValues was not called due to immediate events. However, I have not actually attempted to use a newer version than 1.1.1. If in fact this issue appears fixed in a newer version, let me know. Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira