[jira] [Commented] (SLING-6901) Remove commons.json from org.apache.sling.jcr.js.nodetypes
[ https://issues.apache.org/jira/browse/SLING-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048355#comment-16048355 ] Sandro Boehme commented on SLING-6901: -- I'am the maintainer for sling.jcr.js.nodetypes. It is needed for the Sling Resource Editor. I'll take the task and care about it as soon as I have the time to do it. > Remove commons.json from org.apache.sling.jcr.js.nodetypes > -- > > Key: SLING-6901 > URL: https://issues.apache.org/jira/browse/SLING-6901 > Project: Sling > Issue Type: Sub-task >Reporter: Karl Pauls > Assignee: Sandro Boehme > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (SLING-6901) Remove commons.json from org.apache.sling.jcr.js.nodetypes
[ https://issues.apache.org/jira/browse/SLING-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme reassigned SLING-6901: Assignee: Sandro Boehme > Remove commons.json from org.apache.sling.jcr.js.nodetypes > -- > > Key: SLING-6901 > URL: https://issues.apache.org/jira/browse/SLING-6901 > Project: Sling > Issue Type: Sub-task >Reporter: Karl Pauls > Assignee: Sandro Boehme > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Sling DevOps with Kubernetes on the Google Cloud Platform
Hello again, as mentioned in an other email [1] I wanted to create a Google Cloud based release process. Now I've created an initial working version with K8s on the Google Cloud. The goal of the project is, to provide a reusable production ready Sling infrastructure. It provides: o a mostly declaritive infrastructure for Sling o horizontal scalability for the application (not the DB) o high availability through: - auto recreation of the application and the Database instances - unready applications removed from load balancing - MongoDB Replica Set o and a rollout of new application versions without downtime You can check out the project at GitHub [2]. I'm looking forward to your bug reports, fixes, enhancements and comments! [1] - Subject: 'Make Sling shiny - Basic CMS :: Sitebuilder, Google Cloud' [2] - https://github.com/sandroboehme/sling-gce-k8s-launchpad Best, Sandro
[jira] [Commented] (SLING-6666) Make Sling shiny
[ https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954098#comment-15954098 ] Sandro Boehme commented on SLING-: -- I'm happy to see the ideas and improvements. SLING-3987 would also make Sling more shiny but I understand that it's a very big endeavor. > Make Sling shiny > > > Key: SLING- > URL: https://issues.apache.org/jira/browse/SLING- > Project: Sling > Issue Type: Task > Components: General >Reporter: Oliver Lietz > Attachments: Sling-4x.png > > > https://cwiki.apache.org/confluence/display/SLING/Make+Sling+shiny -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: [DISCUSSION] Make Sling shiny - Basic CMS :: Sitebuilder, Google Cloud
Hi, personally I'm a lot into the idea of a frontend component based Sitebuilder like the one I created a poc for [1]. It is a simple concept that is very very powerful in my opinion. But it was JSP-based and I would rather like to have it Angular 2 based and would like to build up some more Angular 2 knowledge on a project before abstracting from Angular 2 :-). An other major problem I identified was, that I needed to use internal (non-API) code to get the script(s) for the page that is shown. But of course if that changes it wont work for me anymore. To approach the Angular 2 project, I'm in the process of implementing a release process to the Google cloud for Sling. It's available for a single MongoDB but with a very rough and not always working documentation [2]. Since a few minutes it is also working for a MongoDB repl set. Documenting that and making some smaller adjustments is the next step to do. It would be fun to implement the MongoDB sharding as well but I won't need it in the near future so I have to pull myself up and care about the things I need :-). Best, Sandro [1] - https://vimeo.com/140369433 [2] - https://github.com/sandroboehme/sample-launchpad Am 30.03.17 um 23:06 schrieb Daniel Klco: All, It seems like creating a Basic Sling CMS is an exciting topic for a lot of people and something a lot of people are interested in. I've also been working on something on the side as well for this, and I was wondering if others would see this potentially as a good base to start with. The idea here is to be somewhat more developer focused (at least in the initial version) and somewhat limited in functionality, but to provide basic functionality for managing web content. It was based on Publick initially, but I found that was more single-blog focused than I wanted so it's significantly diverged. If you have a sec, I'd appreciate feedback and thoughts on the project. I haven't had a chance to really document much about how it should work and it's not 100% functional (aka don't try to edit a page) but a lot of the core functionality is there. https://github.com/klcodanr/sling-cms Thanks, Dan On Thu, Mar 30, 2017 at 3:45 PM, Chris Millar (JIRA)wrote: [ https://issues.apache.org/jira/browse/SLING-?page= com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel=15949678#comment-15949678 ] Chris Millar commented on SLING-: - I'm probably speaking out of turn, but I have many thoughts on this. First, I agree with what everyone is saying. Sling needs some presentation and branding love. I would break this down into the following buckets: # Docs - The information architecture of sling.apache.org needs to be addressed... Raise your hand if you need quick access to Sling 5 docs in the sidebar. # Marketing and Polish - Basic things like the site not being responsive or the logo being woefully out of date. # Better On-boarding for Developers - Someone who wants to run java -jar org.apache.sling.jar and start building something. How do you get from 8080 to 443? # Better On-boarding for Contributors - Someone who wants to start working with the guts of the project. # Better On-boarding for Users - A basic CMS... I really like the idea of everyone rallying around some _basic_ CMS for Sling. I would argue it should be a pure SlingPostServlet / UserManager solution over trying to make a tool like Composum or Slick bend to this purpose. Composum is more of a CRX/DE Lite replacement and Slick is _way_ too opinionated about its UX. I'll start adding some more thoughts to the wiki and will attach the logo I updated for Sling a while ago. I'll also subscribe to the dev channel as [~bdelacretaz] suggested. Make Sling shiny Key: SLING- URL: https://issues.apache.org/jira/browse/SLING- Project: Sling Issue Type: Task Components: General Reporter: Oliver Lietz https://cwiki.apache.org/confluence/display/SLING/Make+Sling+shiny -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (SLING-6350) Incorrect matching in Path class causes MountByFS to fail (more than 2 slashes fails)
[ https://issues.apache.org/jira/browse/SLING-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-6350. -- Resolution: Fixed Works like a charm, thanks guys! > Incorrect matching in Path class causes MountByFS to fail (more than 2 > slashes fails) > - > > Key: SLING-6350 > URL: https://issues.apache.org/jira/browse/SLING-6350 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: API 2.15.0 > Reporter: Sandro Boehme >Assignee: Carsten Ziegeler > Fix For: API 2.16.2 > > Attachments: patch.txt, sling-api-patch.txt, > testing-with-ant-all-tests-pass.patch, testing-with-ant.patch, > testing-with-ant.patch > > > If I mount a file system path to e.g. '/libs/sling/resource-editor' jsp > changes are not picked up by the jsp compiler. > FileMonitor.sendEvents(... ObservationReporter) gets an ObservationReporter > as a parameter that doesn't return ObserverConfigurations in > getObserverConfigurations() thus no changes are reported to the jsp compiler. > The reason is, that they are not added in it's constructor > (BasicObservationReporter:99) because 'providerPath.matches(p.getPath())' > returns false. If I manually change that in the debugger to true the mount > works well. In this example the providerPath is '/libs/sling/resource-editor' > and p.getPath() is 'glob:/libs/**/*.jsp'. (See patch for PathTest.java) > org.apache.sling.api.resource.path.Path.matches() in line 128 and following > counts three slashes for '/libs/sling/resource-editor' and uses the substring > of the glob expression until a fourth (3+1) slash or the end of the string. > This leads to a glob expression of 'glob:/libs/**/*.jsp' instead of > 'glob:/libs/**' and returns false. > I don't have an overview of all use cases but judging from the PathTest the > amount of slashes counted should not exceed the amount of slashes in the glob > expression minus one if the glob expression uses an extension. I will add a > patch for org.apache.sling.api.resource.path.Path as well so you can choose > not to apply it if it's not correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6350) Incorrect matching in Path class causes MountByFS to fail (more than 2 slashes fails)
[ https://issues.apache.org/jira/browse/SLING-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741529#comment-15741529 ] Sandro Boehme commented on SLING-6350: -- I don't know the exact semantics. I just expected that it checks if {{/libs/**/*.jsp}} files are within {{/libs/sling/resource-editor}} to recompile the jsp files in case of changes. > Incorrect matching in Path class causes MountByFS to fail (more than 2 > slashes fails) > - > > Key: SLING-6350 > URL: https://issues.apache.org/jira/browse/SLING-6350 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: API 2.15.0 > Reporter: Sandro Boehme > Fix For: API 2.16.2 > > Attachments: sling-api-patch.txt, > testing-with-ant-all-tests-pass.patch, testing-with-ant.patch, > testing-with-ant.patch > > > If I mount a file system path to e.g. '/libs/sling/resource-editor' jsp > changes are not picked up by the jsp compiler. > FileMonitor.sendEvents(... ObservationReporter) gets an ObservationReporter > as a parameter that doesn't return ObserverConfigurations in > getObserverConfigurations() thus no changes are reported to the jsp compiler. > The reason is, that they are not added in it's constructor > (BasicObservationReporter:99) because 'providerPath.matches(p.getPath())' > returns false. If I manually change that in the debugger to true the mount > works well. In this example the providerPath is '/libs/sling/resource-editor' > and p.getPath() is 'glob:/libs/**/*.jsp'. (See patch for PathTest.java) > org.apache.sling.api.resource.path.Path.matches() in line 128 and following > counts three slashes for '/libs/sling/resource-editor' and uses the substring > of the glob expression until a fourth (3+1) slash or the end of the string. > This leads to a glob expression of 'glob:/libs/**/*.jsp' instead of > 'glob:/libs/**' and returns false. > I don't have an overview of all use cases but judging from the PathTest the > amount of slashes counted should not exceed the amount of slashes in the glob > expression minus one if the glob expression uses an extension. I will add a > patch for org.apache.sling.api.resource.path.Path as well so you can choose > not to apply it if it's not correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6350) Incorrect matching in Path class causes MountByFS to fail (more than 2 slashes fails)
[ https://issues.apache.org/jira/browse/SLING-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741499#comment-15741499 ] Sandro Boehme commented on SLING-6350: -- Initially it was: {code} @Test public void testMorePathSlashesThenInGlobExp() { Path path = new Path("/libs/sling/resource-editor"); assertTrue(path.matches("glob:/libs/**/*.jsp")); path = new Path("/libs/sling/resource-editor/sub-path"); assertTrue(path.matches("glob:/libs/**/*.jsp")); } {code} but Bertrand identified more test cases. > Incorrect matching in Path class causes MountByFS to fail (more than 2 > slashes fails) > - > > Key: SLING-6350 > URL: https://issues.apache.org/jira/browse/SLING-6350 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: API 2.15.0 >Reporter: Sandro Boehme > Fix For: API 2.16.2 > > Attachments: sling-api-patch.txt, > testing-with-ant-all-tests-pass.patch, testing-with-ant.patch, > testing-with-ant.patch > > > If I mount a file system path to e.g. '/libs/sling/resource-editor' jsp > changes are not picked up by the jsp compiler. > FileMonitor.sendEvents(... ObservationReporter) gets an ObservationReporter > as a parameter that doesn't return ObserverConfigurations in > getObserverConfigurations() thus no changes are reported to the jsp compiler. > The reason is, that they are not added in it's constructor > (BasicObservationReporter:99) because 'providerPath.matches(p.getPath())' > returns false. If I manually change that in the debugger to true the mount > works well. In this example the providerPath is '/libs/sling/resource-editor' > and p.getPath() is 'glob:/libs/**/*.jsp'. (See patch for PathTest.java) > org.apache.sling.api.resource.path.Path.matches() in line 128 and following > counts three slashes for '/libs/sling/resource-editor' and uses the substring > of the glob expression until a fourth (3+1) slash or the end of the string. > This leads to a glob expression of 'glob:/libs/**/*.jsp' instead of > 'glob:/libs/**' and returns false. > I don't have an overview of all use cases but judging from the PathTest the > amount of slashes counted should not exceed the amount of slashes in the glob > expression minus one if the glob expression uses an extension. I will add a > patch for org.apache.sling.api.resource.path.Path as well so you can choose > not to apply it if it's not correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6350) MountByFS does not work if the Provider Root mounts below /libs or /apps and has more than 2 slashes
[ https://issues.apache.org/jira/browse/SLING-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728848#comment-15728848 ] Sandro Boehme commented on SLING-6350: -- If we just replace {{**}} in the pattern with 0..N then the tests you mentioned should still assertFalse as 0..N would still need to be between the two slashes: {code} final Path path_1 = new Path("glob:/apps/**/*.html"); assertFalse(path_1.matches("/apps/a.html")); final Path path_3 = new Path("glob:/a/m-p/$structure/**/[cmp]/*.html"); assertFalse(path_3.matches("/a/m-p/$structure/1/2/3/4/5/6[cmp]/test.html")); {code} I would also assume that this {code} assertFalse(path.matches("glob:/**")); assertFalse(path.matches("glob:/**/*.jsp")); {code} should assertTrue for {{final Path path = new Path("/apps/myproject");}} > MountByFS does not work if the Provider Root mounts below /libs or /apps and > has more than 2 slashes > > > Key: SLING-6350 > URL: https://issues.apache.org/jira/browse/SLING-6350 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: API 2.15.0 >Reporter: Sandro Boehme > Fix For: API 2.16.2 > > Attachments: sling-api-patch.txt > > > If I mount a file system path to e.g. '/libs/sling/resource-editor' jsp > changes are not picked up by the jsp compiler. > FileMonitor.sendEvents(... ObservationReporter) gets an ObservationReporter > as a parameter that doesn't return ObserverConfigurations in > getObserverConfigurations() thus no changes are reported to the jsp compiler. > The reason is, that they are not added in it's constructor > (BasicObservationReporter:99) because 'providerPath.matches(p.getPath())' > returns false. If I manually change that in the debugger to true the mount > works well. In this example the providerPath is '/libs/sling/resource-editor' > and p.getPath() is 'glob:/libs/**/*.jsp'. (See patch for PathTest.java) > org.apache.sling.api.resource.path.Path.matches() in line 128 and following > counts three slashes for '/libs/sling/resource-editor' and uses the substring > of the glob expression until a fourth (3+1) slash or the end of the string. > This leads to a glob expression of 'glob:/libs/**/*.jsp' instead of > 'glob:/libs/**' and returns false. > I don't have an overview of all use cases but judging from the PathTest the > amount of slashes counted should not exceed the amount of slashes in the glob > expression minus one if the glob expression uses an extension. I will add a > patch for org.apache.sling.api.resource.path.Path as well so you can choose > not to apply it if it's not correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6364) FsResourceProvider wrongly (?) changed service property => mountByFS via Maven Plugin broken
[ https://issues.apache.org/jira/browse/SLING-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728751#comment-15728751 ] Sandro Boehme commented on SLING-6364: -- Thanks for the changes [~sseif...@pro-vision.de]! > FsResourceProvider wrongly (?) changed service property => mountByFS via > Maven Plugin broken > > > Key: SLING-6364 > URL: https://issues.apache.org/jira/browse/SLING-6364 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: File System Resource Provider 1.2.0 >Reporter: Sandro Boehme >Assignee: Stefan Seifert > Fix For: File System Resource Provider 1.2.0, Maven Sling Plugin > 2.1.10 > > Attachments: FsResourceProvider.patch.txt > > > When installing a bundle with Maven and -Dsling.mountByFS=true it currently > doesn't work as the provider.roots property of the Filesystem Resource > Provider stays empty in the web console. > This is because the AbstractBundleInstallMojo class of the maven-sling-plugin > uses the property 'provider.roots' in the REST API [1] call [2] to create a > FsResourceProvider service instance but the FsResourceProvider class defined > 'provider.root' without the 's' at the end instead. > In revision 1769486 the property has been moved to a component property type. > Thus the method 'provider_root()' of '@interface Config' is translated to > 'provider.root' according to the spec [3]. > One could change the definition of the property in the FsResourceProvider or > the use of the property in the AbstractBundleInstallMojo. The commit for > 1769486 does not sound like the property definition change of the service was > by intention so I will provide a patch that keeps using 'provider.roots' > instead of 'provider.root' assuming others may still use 'provider.roots'. > Please tell me if my assumption was wrong [~cziegeler]. > I will also fix the WebConsole labels of the two properties as they got > switched. > References as note to myself as others probably know that: > [1] - > http://felix.apache.org/documentation/subprojects/apache-felix-web-console/web-console-restful-api.html#apply > [2] - curl -i -u admin --data > "apply=true=org.apache.sling.fsprovider.internal.FsResourceProvider=[Temporary > PID replaced by real PID upon > save]=/path/to/folder/in/filesystem=/path/to/repository/location=provider.roots,provider.file" > > http://localhost:8080/system/console/configMgr/org.apache.sling.fsprovider.internal.FsResourceProvider > [3] - see OSGi 6 Compendium 105.9.2 AttributeDefinition Annotation > "A single low line ('_' \u005F) is converted into a full stop ('.' \u002E)" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6364) FsResourceProvider wrongly (?) changed service property => mountByFS via Maven Plugin broken
[ https://issues.apache.org/jira/browse/SLING-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723588#comment-15723588 ] Sandro Boehme commented on SLING-6364: -- Can someone tell me if it has to be in line with org.apache.sling.spi.resource.provider.ResourceProvider.PROPERTY_ROOT which is "provider.root"? I guess it doesn't. In this case I would just commit the patch if there is no other veto. > FsResourceProvider wrongly (?) changed service property => mountByFS via > Maven Plugin broken > > > Key: SLING-6364 > URL: https://issues.apache.org/jira/browse/SLING-6364 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Sandro Boehme > Attachments: FsResourceProvider.patch.txt > > > When installing a bundle with Maven and -Dsling.mountByFS=true it currently > doesn't work as the provider.roots property of the Filesystem Resource > Provider stays empty in the web console. > This is because the AbstractBundleInstallMojo class of the maven-sling-plugin > uses the property 'provider.roots' in the REST API [1] call [2] to create a > FsResourceProvider service instance but the FsResourceProvider class defined > 'provider.root' without the 's' at the end instead. > In revision 1769486 the property has been moved to a component property type. > Thus the method 'provider_root()' of '@interface Config' is translated to > 'provider.root' according to the spec [3]. > One could change the definition of the property in the FsResourceProvider or > the use of the property in the AbstractBundleInstallMojo. The commit for > 1769486 does not sound like the property definition change of the service was > by intention so I will provide a patch that keeps using 'provider.roots' > instead of 'provider.root' assuming others may still use 'provider.roots'. > Please tell me if my assumption was wrong [~cziegeler]. > I will also fix the WebConsole labels of the two properties as they got > switched. > References as note to myself as others probably know that: > [1] - > http://felix.apache.org/documentation/subprojects/apache-felix-web-console/web-console-restful-api.html#apply > [2] - curl -i -u admin --data > "apply=true=org.apache.sling.fsprovider.internal.FsResourceProvider=[Temporary > PID replaced by real PID upon > save]=/path/to/folder/in/filesystem=/path/to/repository/location=provider.roots,provider.file" > > http://localhost:8080/system/console/configMgr/org.apache.sling.fsprovider.internal.FsResourceProvider > [3] - see OSGi 6 Compendium 105.9.2 AttributeDefinition Annotation > "A single low line ('_' \u005F) is converted into a full stop ('.' \u002E)" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-6364) FsResourceProvider wrongly (?) changed service property => mountByFS via Maven Plugin broken
[ https://issues.apache.org/jira/browse/SLING-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme updated SLING-6364: - Attachment: FsResourceProvider.patch.txt Patch for the class FsResourceProvider of org.apache.sling.fsresource. > FsResourceProvider wrongly (?) changed service property => mountByFS via > Maven Plugin broken > > > Key: SLING-6364 > URL: https://issues.apache.org/jira/browse/SLING-6364 > Project: Sling > Issue Type: Bug > Components: Extensions > Reporter: Sandro Boehme > Attachments: FsResourceProvider.patch.txt > > > When installing a bundle with Maven and -Dsling.mountByFS=true it currently > doesn't work as the provider.roots property of the Filesystem Resource > Provider stays empty in the web console. > This is because the AbstractBundleInstallMojo class of the maven-sling-plugin > uses the property 'provider.roots' in the REST API [1] call [2] to create a > FsResourceProvider service instance but the FsResourceProvider class defined > 'provider.root' without the 's' at the end instead. > In revision 1769486 the property has been moved to a component property type. > Thus the method 'provider_root()' of '@interface Config' is translated to > 'provider.root' according to the spec [3]. > One could change the definition of the property in the FsResourceProvider or > the use of the property in the AbstractBundleInstallMojo. The commit for > 1769486 does not sound like the property definition change of the service was > by intention so I will provide a patch that keeps using 'provider.roots' > instead of 'provider.root' assuming others may still use 'provider.roots'. > Please tell me if my assumption was wrong [~cziegeler]. > I will also fix the WebConsole labels of the two properties as they got > switched. > References as note to myself as others probably know that: > [1] - > http://felix.apache.org/documentation/subprojects/apache-felix-web-console/web-console-restful-api.html#apply > [2] - curl -i -u admin --data > "apply=true=org.apache.sling.fsprovider.internal.FsResourceProvider=[Temporary > PID replaced by real PID upon > save]=/path/to/folder/in/filesystem=/path/to/repository/location=provider.roots,provider.file" > > http://localhost:8080/system/console/configMgr/org.apache.sling.fsprovider.internal.FsResourceProvider > [3] - see OSGi 6 Compendium 105.9.2 AttributeDefinition Annotation > "A single low line ('_' \u005F) is converted into a full stop ('.' \u002E)" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-6364) FsResourceProvider wrongly (?) changed service property => mountByFS via Maven Plugin broken
Sandro Boehme created SLING-6364: Summary: FsResourceProvider wrongly (?) changed service property => mountByFS via Maven Plugin broken Key: SLING-6364 URL: https://issues.apache.org/jira/browse/SLING-6364 Project: Sling Issue Type: Bug Components: Extensions Reporter: Sandro Boehme When installing a bundle with Maven and -Dsling.mountByFS=true it currently doesn't work as the provider.roots property of the Filesystem Resource Provider stays empty in the web console. This is because the AbstractBundleInstallMojo class of the maven-sling-plugin uses the property 'provider.roots' in the REST API [1] call [2] to create a FsResourceProvider service instance but the FsResourceProvider class defined 'provider.root' without the 's' at the end instead. In revision 1769486 the property has been moved to a component property type. Thus the method 'provider_root()' of '@interface Config' is translated to 'provider.root' according to the spec [3]. One could change the definition of the property in the FsResourceProvider or the use of the property in the AbstractBundleInstallMojo. The commit for 1769486 does not sound like the property definition change of the service was by intention so I will provide a patch that keeps using 'provider.roots' instead of 'provider.root' assuming others may still use 'provider.roots'. Please tell me if my assumption was wrong [~cziegeler]. I will also fix the WebConsole labels of the two properties as they got switched. References as note to myself as others probably know that: [1] - http://felix.apache.org/documentation/subprojects/apache-felix-web-console/web-console-restful-api.html#apply [2] - curl -i -u admin --data "apply=true=org.apache.sling.fsprovider.internal.FsResourceProvider=[Temporary PID replaced by real PID upon save]=/path/to/folder/in/filesystem=/path/to/repository/location=provider.roots,provider.file" http://localhost:8080/system/console/configMgr/org.apache.sling.fsprovider.internal.FsResourceProvider [3] - see OSGi 6 Compendium 105.9.2 AttributeDefinition Annotation "A single low line ('_' \u005F) is converted into a full stop ('.' \u002E)" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: What repository explorer should we ship with Launchpad 9?
Hi, Am 21.11.16 um 10:12 schrieb Robert Munteanu: Hi, With the default Sling launchpad we're still shipping the content explorer from bundles/extensions/explorer. While this has the benefit of being available as a basic tool, it's pretty buggy and unmaintained - last 'non-administrative' commit was in Feb 2012 . I think it's time to retire this explorer to the attic and look for other options. I for one have been using Composum [1] with good results for some months. The resource explorer part is very good, and it also has other extras such as an ACL editor, user/group management and an interface for content package management. It is licensed under the MIT license, so we're clear here. We also have an explorer under contrib/explorers/resourceeditor, but it's still under contrib and though I like the approach it takes to designing and composing the frontend, my impression is that it's not yet ready to be moved to the main build and included in the launchpad. Of course, feel free to disagree :-) just for the record: I like the idea of integrating Composum instead of the resource editor because Composum provides more features. But I still think there is a place for the resource editor and I will continue to maintain (and improve) it. Best, Sandro PS: I'm glad you like the approach to designing and composing :-)
Re: mountByFS does not work
Hi Carsten, to try my patch within the server I used 'mvn clean install sling:install' as suggested. But sadly it didn't have any effect. When connecting with the debugger the old variables are still there. The maven output looks good: [INFO] --- maven-sling-plugin:2.1.8:install (default-cli) @ org.apache.sling.api --- [INFO] Installing Bundle org.apache.sling.api(/Users/sandro/Developing/Projekte/sling/svn2/bundles/api/target/org.apache.sling.api-2.15.1-SNAPSHOT.jar) to http://localhost:8080/system/console via WebConsole [INFO] Bundle installed I also don't see any error in the server output or the log file. Did you do it the same and did it work for you? Best, Sandro
Re: mountByFS does not work
Hi Carsten, Am 28.11.16 um 08:40 schrieb Sandro Boehme: Am 27.11.16 um 23:27 schrieb Sandro Boehme: Am 19.11.16 um 21:58 schrieb Sandro Boehme: Am 13.11.16 um 15:16 schrieb Carsten Ziegeler: > Sandro Boehme wrote >>>> in my case a FS mount (-Dsling.mountByFS=true) does not work. >>>> The configMgr of the web console shows that the mount is there and >>>> FileMonitor.check() detects the change and sends the event. >>>> My question is: Who is the receiver of the event? I understand that >>>> it's >>>> the event of the FsResourceProvider but what code listens to the >>>> change >>>> and (in my case) doesn't promote it. >>>> >>> The scripting jsp should listen to the events you mention above, but >>> now >>> the scripting is not using event admin anymore but uses the >>> ResourceChangeListener and therefore it never gets the event. >>> >>> The problem is that we need to update the fsresource bundle to use the >>> resource resolver observation api. I'll try to take care of it. >> >> Ah. Thanks a lot! >> > I've updated the fsresource bundle (SLING-6279) but didn't test it so > far :) > So if you want to give it a try... Thanks again. I did and it didn't work for me but I can imagine that the reason is something else. I will check it as soon as I have time for that and send the feedback here. Hi Carsten, sadly it doesn't work for me. If after restart I first change the JSP and then refresh the page the change is visible. But subsequent changes are not detected anymore. I tried without the reactor build and then with it and always changed the version of org.apache.sling.scripting.jsp to 2.2.1.SNAPSHOT in provisioning/scripting.txt. fsresource is already set to 1.1.5-SNAPSHOT. In FileMonitor.sendEvents() ObservationReporter.getObserverConfigurations() always returns an empty list. In an other configuration there were configurations returned but 'config.matches(monitorable.path)' always returns false so reporter.reportChanges() is never called. JspScriptEngineFactory.onChange() also seems to be never called. Help would be much appreciated! Best, Sandro Ok, in one case it works and both methods are called. I'll compare, why it doesn't work in the other occasion. Best, Sandro ok, I've finally found the problem and suggested a solution in SLING-6350 SLING-6350 - https://issues.apache.org/jira/browse/SLING-6350 Best, Sandro
[jira] [Updated] (SLING-6350) MountByFS does not work if the Provider Root mounts below /libs or /apps and has more than 2 slashes
[ https://issues.apache.org/jira/browse/SLING-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme updated SLING-6350: - Attachment: sling-api-patch.txt Patch for org.apache.sling.api in bundles/api. > MountByFS does not work if the Provider Root mounts below /libs or /apps and > has more than 2 slashes > > > Key: SLING-6350 > URL: https://issues.apache.org/jira/browse/SLING-6350 > Project: Sling > Issue Type: Bug > Components: Extensions > Reporter: Sandro Boehme > Attachments: sling-api-patch.txt > > > If I mount a file system path to e.g. '/libs/sling/resource-editor' jsp > changes are not picked up by the jsp compiler. > FileMonitor.sendEvents(... ObservationReporter) gets an ObservationReporter > as a parameter that doesn't return ObserverConfigurations in > getObserverConfigurations() thus no changes are reported to the jsp compiler. > The reason is, that they are not added in it's constructor > (BasicObservationReporter:99) because 'providerPath.matches(p.getPath())' > returns false. If I manually change that in the debugger to true the mount > works well. In this example the providerPath is '/libs/sling/resource-editor' > and p.getPath() is 'glob:/libs/**/*.jsp'. (See patch for PathTest.java) > org.apache.sling.api.resource.path.Path.matches() in line 128 and following > counts three slashes for '/libs/sling/resource-editor' and uses the substring > of the glob expression until a fourth (3+1) slash or the end of the string. > This leads to a glob expression of 'glob:/libs/**/*.jsp' instead of > 'glob:/libs/**' and returns false. > I don't have an overview of all use cases but judging from the PathTest the > amount of slashes counted should not exceed the amount of slashes in the glob > expression minus one if the glob expression uses an extension. I will add a > patch for org.apache.sling.api.resource.path.Path as well so you can choose > not to apply it if it's not correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-6350) MountByFS does not work if the Provider Root mounts below /libs or /apps and has more than 2 slashes
Sandro Boehme created SLING-6350: Summary: MountByFS does not work if the Provider Root mounts below /libs or /apps and has more than 2 slashes Key: SLING-6350 URL: https://issues.apache.org/jira/browse/SLING-6350 Project: Sling Issue Type: Bug Components: Extensions Reporter: Sandro Boehme If I mount a file system path to e.g. '/libs/sling/resource-editor' jsp changes are not picked up by the jsp compiler. FileMonitor.sendEvents(... ObservationReporter) gets an ObservationReporter as a parameter that doesn't return ObserverConfigurations in getObserverConfigurations() thus no changes are reported to the jsp compiler. The reason is, that they are not added in it's constructor (BasicObservationReporter:99) because 'providerPath.matches(p.getPath())' returns false. If I manually change that in the debugger to true the mount works well. In this example the providerPath is '/libs/sling/resource-editor' and p.getPath() is 'glob:/libs/**/*.jsp'. (See patch for PathTest.java) org.apache.sling.api.resource.path.Path.matches() in line 128 and following counts three slashes for '/libs/sling/resource-editor' and uses the substring of the glob expression until a fourth (3+1) slash or the end of the string. This leads to a glob expression of 'glob:/libs/**/*.jsp' instead of 'glob:/libs/**' and returns false. I don't have an overview of all use cases but judging from the PathTest the amount of slashes counted should not exceed the amount of slashes in the glob expression minus one if the glob expression uses an extension. I will add a patch for org.apache.sling.api.resource.path.Path as well so you can choose not to apply it if it's not correct. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: trunk build does not work // was: mountByFS does not work
Hi Robert, Am 28.11.16 um 23:32 schrieb Robert Munteanu: On Fri, 2016-11-18 at 00:22 +0100, Sandro Boehme wrote: Hi Julian, I like the idea of individual Jenkins jobs for the reasons you pointed out! If we would have a "nightly" build (whatever time that would be) we could link it at the Getting and building Sling page. We could write there that in case the build does currently not work (e.g. because there is some bigger work in progress or a plain oversight) they could have a look at what revision actually does work and use that. I've updated the building Sling docs to reflect how we expect things to work now, see especially http://sling.apache.org/documentation/development/getting-and-buildin g-sling.html#tldr-short-form-build-run-instructions http://sling.apache.org/documentation/development/getting-and-buildin g-sling.html#with-the-maven-command-line-tool Hopefully that makes more sense now. It absolutely does! I've just had cases where 'mvn clean install sling:install' of a snapshot bundle to the normal launchpad seem to make problems with resolving bundles. But if it should generally work it's all good. Best, Sandro
Re: Launchpad stable and launchpad unstable
Hi Bertrand, Am 29.11.16 um 13:25 schrieb Bertrand Delacretaz: Hi Sandro, On Mon, Nov 28, 2016 at 11:45 PM, Sandro Boehme <sandro.boe...@gmx.de> wrote: ...If I checkout and build the latest trunk I would expect that the built projects are available at the runtime of the server. This way I can set breakpoints in the debugger, examine the inner workings and maybe provide an improvement Yes, as a Sling developer that's what you want, and also for testing the whole thing in automated tests. OTOH for Sling to be always release ready we need a launchpad that refers only to released modules, so we need both. I agree that we need both! ...If the launchpad provides only stable versions I would always first have to switch to the snapshot versions using the script and I currently I can't do that, right?... The launchpad/builder/set-sling-snapshots.sh script should allow you to do that but when I wrote it it didn't fully work, see comments inside. -Bertrand I tried it with the current trunk and http://localhost:8080/ returned a 503 with 'AuthenticationSupport service missing. Cannot authenticate request.' 'mvn dependency:resolve | grep org.apache.sling | grep -v SNAPSHOT' returned: [INFO] org.apache.sling:org.apache.sling.commons.scheduler:jar:2.5.2:provided [INFO] org.apache.sling:org.apache.sling.repoinit.parser:jar:1.1.0:provided [INFO] org.apache.sling:org.apache.sling.commons.classloader:jar:1.3.6:provided [INFO]org.apache.sling:org.apache.sling.xss:jar:1.0.16:provided [INFO] org.apache.sling:org.apache.sling.provisioning.model:jar:1.7.0:provided [INFO]org.apache.sling:org.apache.sling.commons.mime:jar:2.1.10:provided [INFO]org.apache.sling:org.apache.sling.event.dea:jar:1.1.0:provided [INFO]org.apache.sling:org.apache.sling.auth.core:jar:1.3.22:provided When I look in the /logs/error.log after startup I see exceptions like 'java.lang.NoClassDefFoundError: javax/jcr/RepositoryException' I feel like I'm always just complaining but I'm afraid it would take way too much time to understand how the launchpad translates the txt files into installed Maven artifacts. Let alone fixing something there. OTOH I think the aspect I've mentioned in my last email is not unimportant. Best, Sandro
Re: Launchpad stable and launchpad unstable
- the launchpad maintained in trunk should always be the "stable" launchpad, referencing only released dependencies of the sling bundles and oft the integration tests project If I checkout and build the latest trunk I would expect that the built projects are available at the runtime of the server. This way I can set breakpoints in the debugger, examine the inner workings and maybe provide an improvement. If the launchpad provides only stable versions I would always first have to switch to the snapshot versions using the script and I currently I can't do that, right? Best, Sandro PS: Thanks Bertrand for pointing me to this discussion!
Re: mountByFS does not work
Am 27.11.16 um 23:27 schrieb Sandro Boehme: Am 19.11.16 um 21:58 schrieb Sandro Boehme: Am 13.11.16 um 15:16 schrieb Carsten Ziegeler: > Sandro Boehme wrote >>>> in my case a FS mount (-Dsling.mountByFS=true) does not work. >>>> The configMgr of the web console shows that the mount is there and >>>> FileMonitor.check() detects the change and sends the event. >>>> My question is: Who is the receiver of the event? I understand that >>>> it's >>>> the event of the FsResourceProvider but what code listens to the >>>> change >>>> and (in my case) doesn't promote it. >>>> >>> The scripting jsp should listen to the events you mention above, but >>> now >>> the scripting is not using event admin anymore but uses the >>> ResourceChangeListener and therefore it never gets the event. >>> >>> The problem is that we need to update the fsresource bundle to use the >>> resource resolver observation api. I'll try to take care of it. >> >> Ah. Thanks a lot! >> > I've updated the fsresource bundle (SLING-6279) but didn't test it so > far :) > So if you want to give it a try... Thanks again. I did and it didn't work for me but I can imagine that the reason is something else. I will check it as soon as I have time for that and send the feedback here. Hi Carsten, sadly it doesn't work for me. If after restart I first change the JSP and then refresh the page the change is visible. But subsequent changes are not detected anymore. I tried without the reactor build and then with it and always changed the version of org.apache.sling.scripting.jsp to 2.2.1.SNAPSHOT in provisioning/scripting.txt. fsresource is already set to 1.1.5-SNAPSHOT. In FileMonitor.sendEvents() ObservationReporter.getObserverConfigurations() always returns an empty list. In an other configuration there were configurations returned but 'config.matches(monitorable.path)' always returns false so reporter.reportChanges() is never called. JspScriptEngineFactory.onChange() also seems to be never called. Help would be much appreciated! Best, Sandro Ok, in one case it works and both methods are called. I'll compare, why it doesn't work in the other occasion. Best, Sandro
Re: trunk build does not work // was: mountByFS does not work
Am 19.11.16 um 21:56 schrieb Sandro Boehme: Am 17.11.16 um 23:22 schrieb Robert Munteanu: On Thu, 2016-11-17 at 14:53 +0100, Julian Sedding wrote: Hi Sandro You are right. However, the full build on Jenkins failed too often. Partly due to issues or flaky tests in Sling, partly due to e.g. infrastructure issues. This made the Jenkins builds almost useless, because chances were that it weren't your changes that made the build fail. Therefore Robert added configurations to run each module independently on Jenkins. That gives us a better overview of which modules are ok and which ones aren't. However, we lost the full build in the process. Maybe we could add it back and run it once every night. WDYT, Robert? First of all, I think that I should update the documentation :-) With all the SNAPSHOTs being deployed by the Jenkins jobs the only command that should be used to build Sling after the SVN checkout is $ cd launchpad/builder $ mvn -U clean install which matches to a large degree what the Jenkins jobs do. There should be absolutely no need to perform a full reactor build - which takes time, and is not always stable - to get a launchpad. Then I'd like to understand exactly why the reactor build fails, as it should not, at least not when the individual module builds are working. Robert Hi Robert, thanks a lot for the hint! Your magic commands make the build of the server very quick. That makes my work with Sling a lot easier and that would be true for everybody who reads it at the Sling website. I guess that if I change a Sling Maven project and 'mvn install' it the generated artifact is supposed to be picked up at Maven install phase of the builder. Best, Sandro Regards Julian On Wed, Nov 16, 2016 at 10:02 PM, Sandro Boehme <sandro.boe...@gmx.de wrote: According to our Jenkins job https://builds.apache.org/job/sling-launchpad-builder-1.8/ the launchpad should work without issues. A couple of additional questions: - what Java version do you use for building and running Sling? - what happens if you try to build the project with "-U", to force updating the snapshots? The command would then be mvn -U clean verify Robert According to the "Getting and Building Sling" page [1] I just did "svn co ...", "mvn clean install" (-DskipTests) and "java -jar ..." and expected to be able to build and use Sling. But if we don't have a Jenkins job that does the same a committer will probably more easily overlook if he breaks the build for people who are trying out Sling. But I guess you know that and I have the feeling that I miss something here. I use Java 8. I didn't try -U but Julians changes fixed the problem for me. [1] - http://sling.apache.org/documentation/development/getting-and-build ing-sling.html Best, Sandro When trying to get Carstens changes to work I saw that I had to change the version for scripting.jsp in the launchpad provisioning. I also recognized that it doesn't contain a lot of snapshot versions so the server will not load the bundle versions that are checked out at trunk from SVN. How do you guys work to make sure you get the latest trunk running in the server? Is there a launchpad version somewhere that compiles the latest snapshots to the standalone jar? I still feel like I miss something obvious. Best, Sandro
Re: mountByFS does not work
Am 19.11.16 um 21:58 schrieb Sandro Boehme: Am 13.11.16 um 15:16 schrieb Carsten Ziegeler: > Sandro Boehme wrote >>>> in my case a FS mount (-Dsling.mountByFS=true) does not work. >>>> The configMgr of the web console shows that the mount is there and >>>> FileMonitor.check() detects the change and sends the event. >>>> My question is: Who is the receiver of the event? I understand that >>>> it's >>>> the event of the FsResourceProvider but what code listens to the >>>> change >>>> and (in my case) doesn't promote it. >>>> >>> The scripting jsp should listen to the events you mention above, but >>> now >>> the scripting is not using event admin anymore but uses the >>> ResourceChangeListener and therefore it never gets the event. >>> >>> The problem is that we need to update the fsresource bundle to use the >>> resource resolver observation api. I'll try to take care of it. >> >> Ah. Thanks a lot! >> > I've updated the fsresource bundle (SLING-6279) but didn't test it so > far :) > So if you want to give it a try... Thanks again. I did and it didn't work for me but I can imagine that the reason is something else. I will check it as soon as I have time for that and send the feedback here. Hi Carsten, sadly it doesn't work for me. If after restart I first change the JSP and then refresh the page the change is visible. But subsequent changes are not detected anymore. I tried without the reactor build and then with it and always changed the version of org.apache.sling.scripting.jsp to 2.2.1.SNAPSHOT in provisioning/scripting.txt. fsresource is already set to 1.1.5-SNAPSHOT. In FileMonitor.sendEvents() ObservationReporter.getObserverConfigurations() always returns an empty list. In an other configuration there were configurations returned but 'config.matches(monitorable.path)' always returns false so reporter.reportChanges() is never called. JspScriptEngineFactory.onChange() also seems to be never called. Help would be much appreciated! Best, Sandro
Re: mountByFS does not work
Am 13.11.16 um 15:16 schrieb Carsten Ziegeler: Sandro Boehme wrote in my case a FS mount (-Dsling.mountByFS=true) does not work. The configMgr of the web console shows that the mount is there and FileMonitor.check() detects the change and sends the event. My question is: Who is the receiver of the event? I understand that it's the event of the FsResourceProvider but what code listens to the change and (in my case) doesn't promote it. The scripting jsp should listen to the events you mention above, but now the scripting is not using event admin anymore but uses the ResourceChangeListener and therefore it never gets the event. The problem is that we need to update the fsresource bundle to use the resource resolver observation api. I'll try to take care of it. Ah. Thanks a lot! I've updated the fsresource bundle (SLING-6279) but didn't test it so far :) So if you want to give it a try... Thanks again. I did and it didn't work for me but I can imagine that the reason is something else. I will check it as soon as I have time for that and send the feedback here. Best, Sandro Regards Carsten
Re: trunk build does not work // was: mountByFS does not work
Am 17.11.16 um 23:22 schrieb Robert Munteanu: On Thu, 2016-11-17 at 14:53 +0100, Julian Sedding wrote: Hi Sandro You are right. However, the full build on Jenkins failed too often. Partly due to issues or flaky tests in Sling, partly due to e.g. infrastructure issues. This made the Jenkins builds almost useless, because chances were that it weren't your changes that made the build fail. Therefore Robert added configurations to run each module independently on Jenkins. That gives us a better overview of which modules are ok and which ones aren't. However, we lost the full build in the process. Maybe we could add it back and run it once every night. WDYT, Robert? First of all, I think that I should update the documentation :-) With all the SNAPSHOTs being deployed by the Jenkins jobs the only command that should be used to build Sling after the SVN checkout is $ cd launchpad/builder $ mvn -U clean install which matches to a large degree what the Jenkins jobs do. There should be absolutely no need to perform a full reactor build - which takes time, and is not always stable - to get a launchpad. Then I'd like to understand exactly why the reactor build fails, as it should not, at least not when the individual module builds are working. Robert Hi Robert, thanks a lot for the hint! Your magic commands make the build of the server very quick. That makes my work with Sling a lot easier and that would be true for everybody who reads it at the Sling website. I guess that if I change a Sling Maven project and 'mvn install' it the generated artifact is supposed to be picked up at Maven install phase of the builder. Best, Sandro Regards Julian On Wed, Nov 16, 2016 at 10:02 PM, Sandro Boehme <sandro.boe...@gmx.de wrote: According to our Jenkins job https://builds.apache.org/job/sling-launchpad-builder-1.8/ the launchpad should work without issues. A couple of additional questions: - what Java version do you use for building and running Sling? - what happens if you try to build the project with "-U", to force updating the snapshots? The command would then be mvn -U clean verify Robert According to the "Getting and Building Sling" page [1] I just did "svn co ...", "mvn clean install" (-DskipTests) and "java -jar ..." and expected to be able to build and use Sling. But if we don't have a Jenkins job that does the same a committer will probably more easily overlook if he breaks the build for people who are trying out Sling. But I guess you know that and I have the feeling that I miss something here. I use Java 8. I didn't try -U but Julians changes fixed the problem for me. [1] - http://sling.apache.org/documentation/development/getting-and-build ing-sling.html Best, Sandro
Re: trunk build does not work // was: mountByFS does not work
Am 17.11.16 um 23:22 schrieb Robert Munteanu: On Thu, 2016-11-17 at 14:53 +0100, Julian Sedding wrote: Hi Sandro You are right. However, the full build on Jenkins failed too often. Partly due to issues or flaky tests in Sling, partly due to e.g. infrastructure issues. This made the Jenkins builds almost useless, because chances were that it weren't your changes that made the build fail. Therefore Robert added configurations to run each module independently on Jenkins. That gives us a better overview of which modules are ok and which ones aren't. However, we lost the full build in the process. Maybe we could add it back and run it once every night. WDYT, Robert? First of all, I think that I should update the documentation :-) With all the SNAPSHOTs being deployed by the Jenkins jobs the only command that should be used to build Sling after the SVN checkout is $ cd launchpad/builder $ mvn -U clean install which matches to a large degree what the Jenkins jobs do. There should be absolutely no need to perform a full reactor build - which takes time, and is not always stable - to get a launchpad. Then I'd like to understand exactly why the reactor build fails, as it should not, at least not when the individual module builds are working. Robert I don't know exactly why the reactor build failed. In the next days I will have a look on that to find out what's the difference between the reactor build and the launchpad build. But of course a quick and stable build sounds very very good to me! Best, Sandro Regards Julian On Wed, Nov 16, 2016 at 10:02 PM, Sandro Boehme <sandro.boe...@gmx.de wrote: According to our Jenkins job https://builds.apache.org/job/sling-launchpad-builder-1.8/ the launchpad should work without issues. A couple of additional questions: - what Java version do you use for building and running Sling? - what happens if you try to build the project with "-U", to force updating the snapshots? The command would then be mvn -U clean verify Robert According to the "Getting and Building Sling" page [1] I just did "svn co ...", "mvn clean install" (-DskipTests) and "java -jar ..." and expected to be able to build and use Sling. But if we don't have a Jenkins job that does the same a committer will probably more easily overlook if he breaks the build for people who are trying out Sling. But I guess you know that and I have the feeling that I miss something here. I use Java 8. I didn't try -U but Julians changes fixed the problem for me. [1] - http://sling.apache.org/documentation/development/getting-and-build ing-sling.html Best, Sandro
Re: trunk build does not work // was: mountByFS does not work
Hi Julian, I like the idea of individual Jenkins jobs for the reasons you pointed out! If we would have a "nightly" build (whatever time that would be) we could link it at the Getting and building Sling page. We could write there that in case the build does currently not work (e.g. because there is some bigger work in progress or a plain oversight) they could have a look at what revision actually does work and use that. People who would stop trying Sling because of a non working build and who would not ask at the mailing list would then have a chance to get the build working anyways. WDYT? Best, Sandro Am 17.11.16 um 14:53 schrieb Julian Sedding: Hi Sandro You are right. However, the full build on Jenkins failed too often. Partly due to issues or flaky tests in Sling, partly due to e.g. infrastructure issues. This made the Jenkins builds almost useless, because chances were that it weren't your changes that made the build fail. Therefore Robert added configurations to run each module independently on Jenkins. That gives us a better overview of which modules are ok and which ones aren't. However, we lost the full build in the process. Maybe we could add it back and run it once every night. WDYT, Robert? Regards Julian On Wed, Nov 16, 2016 at 10:02 PM, Sandro Boehme <sandro.boe...@gmx.de> wrote: According to our Jenkins job https://builds.apache.org/job/sling-launchpad-builder-1.8/ the launchpad should work without issues. A couple of additional questions: - what Java version do you use for building and running Sling? - what happens if you try to build the project with "-U", to force updating the snapshots? The command would then be mvn -U clean verify Robert According to the "Getting and Building Sling" page [1] I just did "svn co ...", "mvn clean install" (-DskipTests) and "java -jar ..." and expected to be able to build and use Sling. But if we don't have a Jenkins job that does the same a committer will probably more easily overlook if he breaks the build for people who are trying out Sling. But I guess you know that and I have the feeling that I miss something here. I use Java 8. I didn't try -U but Julians changes fixed the problem for me. [1] - http://sling.apache.org/documentation/development/getting-and-building-sling.html Best, Sandro
Re: trunk build does not work // was: mountByFS does not work
According to our Jenkins job https://builds.apache.org/job/sling-launchpad-builder-1.8/ the launchpad should work without issues. A couple of additional questions: - what Java version do you use for building and running Sling? - what happens if you try to build the project with "-U", to force updating the snapshots? The command would then be mvn -U clean verify Robert According to the "Getting and Building Sling" page [1] I just did "svn co ...", "mvn clean install" (-DskipTests) and "java -jar ..." and expected to be able to build and use Sling. But if we don't have a Jenkins job that does the same a committer will probably more easily overlook if he breaks the build for people who are trying out Sling. But I guess you know that and I have the feeling that I miss something here. I use Java 8. I didn't try -U but Julians changes fixed the problem for me. [1] - http://sling.apache.org/documentation/development/getting-and-building-sling.html Best, Sandro
Re: trunk build does not work // was: mountByFS does not work
Hi Julian, thanks for the changes! It works for me as well now. Best, Sandro Am 16.11.16 um 13:29 schrieb Julian Sedding: Hi Sandro I have committed my changes to these modules and run the full build multiple times. So I expect that you should be able to run a successful trunk build now. Regards Julian On Wed, Nov 16, 2016 at 1:18 PM, Robert Munteanu <romb...@apache.org> wrote: On Tue, 2016-11-15 at 15:51 +0100, Sandro Boehme wrote: Hi Julian, thanks for your feedback! Am 15.11.16 um 10:47 schrieb Julian Sedding: Hi Sandro org/apache/sling/jcr/base/LoginAdminWhitelist looks like your checkout or snapshots on your machine are not quite up to date. I removed the I'am at the latest trunk, did 'mvn clean ...' and created a new sling home with the '-c' option at server startup. What else do I have to do to be up to date? method AbstractSlingRepositoryManager.getLoginAdminWhitelist(), so maybe you need to first build a local snapshot of bundles/jcr/base and then try building bundles/jcr/oak-server again. What version of jcr/base is compatible with which version of jcr/oak- server? Sorry for the inconvenience. I should soon be done with refactoring these modules. Does that mean there is nothing I can do right now? According to our Jenkins job https://builds.apache.org/job/sling-launchpad-builder-1.8/ the launchpad should work without issues. A couple of additional questions: - what Java version do you use for building and running Sling? - what happens if you try to build the project with "-U", to force updating the snapshots? The command would then be mvn -U clean verify Robert Best, Sandro Regards Julian On Mon, Nov 14, 2016 at 9:50 PM, Sandro Boehme <sandro.boehme@gmx.d e> wrote: Hi Robert, It took me a while to get the trunk to build. I had to disable the Rat checks and update the dependency to org.apache.sling.jcr.base version 2.4.3-SNAPSHOT in org.apache.sling.jcr.oak.server. Why isn't there a build job anymore for trunk? Should I build Sling differently than described at the website [1]? The context as is at [2]. Basically, the big 'trunk' jobs were too slow and flaky. Now we have many small jobs, with none of them slow and a couple of them flaky :-) But the reactor build should work nonetheless. I currently can't build it due to repository.apache.org timeouts, can you post any errors that you get? Thanks, Robert [2]: https://cwiki.apache.org/confluence/display/SLING/Sling+Je nkins+Se tup The dependency to oasling.jcr.base 2.4.x has been changed by Julian in the meantime to prepare for the oak.server-1.1.2 release. So I could build the trunk a few minutes ago. But the server doesn't seem to start completely. When accessing http://localhost:8080 I get an HTTP 503 saying "Problem accessing /. Reason: AuthenticationSupport service missing. Cannot authenticate request." 138 bundles are available and active. The error log shows me this error: 14.11.2016 21:30:58.119 *ERROR* [OsgiInstallerImpl] org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManage r start: Uncaught Throwable trying to access Repository, calling stopRepository() java.lang.AbstractMethodError: org.apache.sling.jcr.base.AbstractSlingRepositoryManager.getLogin AdminWhitelist()Lorg/apache/sling/jcr/base/LoginAdminWhitelist; at org.apache.sling.jcr.base.AbstractSlingRepository2.loginAdministr ative(AbstractSlingRepository2.java:373) at org.apache.sling.jcr.base.internal.loader.Loader.getSession(Loade r.java:326) at org.apache.sling.jcr.base.internal.loader.Loader.registerNamespac es(Loader.java:213) at org.apache.sling.jcr.base.internal.loader.Loader.registerBundleIn ternal(Loader.java:225) at org.apache.sling.jcr.base.internal.loader.Loader.registerBundle(L oader.java:158) at org.apache.sling.jcr.base.internal.loader.Loader.(Loader.ja va:75) at org.apache.sling.jcr.base.AbstractSlingRepositoryManager.start(Ab stractSlingRepositoryManager.java:371) ... Any advice would be much appreciated! Best, Sandro
[jira] [Resolved] (SLING-6292) jcr.js.nodetypes tests fail when run in a different timezone
[ https://issues.apache.org/jira/browse/SLING-6292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-6292. -- Resolution: Fixed Hey [~rombert], Berlin is the epicenter of Sling at one time of the year - shouldn't that be enough to expect everybody to use this timezone? ;-) Thanks for reporting so specific and also for the pom changes! I fixed the comparison to always use UTC. > jcr.js.nodetypes tests fail when run in a different timezone > > > Key: SLING-6292 > URL: https://issues.apache.org/jira/browse/SLING-6292 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Robert Munteanu > Assignee: Sandro Boehme > Labels: sling-IT > > The NodeTypes module JSON comparison tests expect the formatted date to be in > the '+01:00' time zone, most likely were developed in the Europe/Berlin > timezone :-) > Of course, this fails when run in other timezones, for instance on Jenkins > which has the timezone set to Etc/GMT or anywhere else in the world. > [~sandro] - I think you're the best person to look into this, would be great > to fix as it would remove two failed jobs on Jenkins. > A sample test failure is: > {noformat}Tests run: 13, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: > 0.113 sec <<< FAILURE! - in > org.apache.sling.jcr.js.nodetypes.PropertyDefGenerationTest > testCompleteDatePropertyDefinition(org.apache.sling.jcr.js.nodetypes.PropertyDefGenerationTest) > Time elapsed: 0.037 sec <<< FAILURE! > org.junit.ComparisonFailure: Actual JSON: {"ntWithPropertyDefs": > {"declaredPropertyDefinitions": [{ > "name": "datePropertyDef", > "autoCreated": true, > "mandatory": true, > "protected": true, > "onParentVersion": "VERSION", > "defaultValues": [{ > "date": "2012-02-01T00:00:00.000Z", > "type": "Date" > }], > "requiredType": "Date", > "valueConstraints": ["2012-04-01T00:00:00Z"], > "multiple": true > }]}} > Expected JSON: { "ntWithPropertyDefs": {"declaredPropertyDefinitions": [ > {"defaultValues": [ {"date": > "2012-02-01T00:00:00.000+01:00","type": "Date" } > ],"requiredType": "Date","valueConstraints": [ > "2012-04-01T00:00:00Z"],"multiple": true, > "autoCreated": true,"mandatory": true,"protected": true, > "onParentVersion": "VERSION","name": "datePropertyDef" }] > }}: objects differed at key [ntWithPropertyDefs];: objects differed at key > [declaredPropertyDefinitions];: arrays first differed at element [0];: > objects differed at key [defaultValues];: arrays first differed at element > [0];: objects differed at key [date]; > expected:<...2-02-01T00:00:00.000[+01:00]> but > was:<...2-02-01T00:00:00.000[Z]> > at org.junit.Assert.assertEquals(Assert.java:115) > at > org.apache.sling.jcr.js.nodetypes.test.JSONAssert.assertEquals(JSONAssert.java:173) > at > org.apache.sling.jcr.js.nodetypes.test.JSONAssert.assertEquals(JSONAssert.java:99) > at > org.apache.sling.jcr.js.nodetypes.test.JSONAssert.assertEquals(JSONAssert.java:170) > at > org.apache.sling.jcr.js.nodetypes.test.JSONAssert.assertEquals(JSONAssert.java:99) > at > org.apache.sling.jcr.js.nodetypes.test.JSONAssert.assertEquals(JSONAssert.java:170) > at > org.apache.sling.jcr.js.nodetypes.test.JSONAssert.assertEquals(JSONAssert.java:167) > at > org.apache.sling.jcr.js.nodetypes.mock.MockNodeTypeGenerator.assertEqualsWithServletResult(MockNodeTypeGenerator.java:143) > at > org.apache.sling.jcr.js.nodetypes.PropertyDefGenerationTest.testCompletePropertyDefinition(PropertyDefGenerationTest.java:123) > at > org.apache.sling.jcr.js.nodetypes.PropertyDefGenerationTest.testCompleteDatePropertyDefinition(PropertyDefGenerationTest.java:70){noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: trunk build does not work // was: mountByFS does not work
Hi Julian, thanks for your feedback! Am 15.11.16 um 10:47 schrieb Julian Sedding: Hi Sandro org/apache/sling/jcr/base/LoginAdminWhitelist looks like your checkout or snapshots on your machine are not quite up to date. I removed the I'am at the latest trunk, did 'mvn clean ...' and created a new sling home with the '-c' option at server startup. What else do I have to do to be up to date? method AbstractSlingRepositoryManager.getLoginAdminWhitelist(), so maybe you need to first build a local snapshot of bundles/jcr/base and then try building bundles/jcr/oak-server again. What version of jcr/base is compatible with which version of jcr/oak-server? Sorry for the inconvenience. I should soon be done with refactoring these modules. Does that mean there is nothing I can do right now? Best, Sandro Regards Julian On Mon, Nov 14, 2016 at 9:50 PM, Sandro Boehme <sandro.boe...@gmx.de> wrote: Hi Robert, It took me a while to get the trunk to build. I had to disable the Rat checks and update the dependency to org.apache.sling.jcr.base version 2.4.3-SNAPSHOT in org.apache.sling.jcr.oak.server. Why isn't there a build job anymore for trunk? Should I build Sling differently than described at the website [1]? The context as is at [2]. Basically, the big 'trunk' jobs were too slow and flaky. Now we have many small jobs, with none of them slow and a couple of them flaky :-) But the reactor build should work nonetheless. I currently can't build it due to repository.apache.org timeouts, can you post any errors that you get? Thanks, Robert [2]: https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkins+Se tup The dependency to oasling.jcr.base 2.4.x has been changed by Julian in the meantime to prepare for the oak.server-1.1.2 release. So I could build the trunk a few minutes ago. But the server doesn't seem to start completely. When accessing http://localhost:8080 I get an HTTP 503 saying "Problem accessing /. Reason: AuthenticationSupport service missing. Cannot authenticate request." 138 bundles are available and active. The error log shows me this error: 14.11.2016 21:30:58.119 *ERROR* [OsgiInstallerImpl] org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager start: Uncaught Throwable trying to access Repository, calling stopRepository() java.lang.AbstractMethodError: org.apache.sling.jcr.base.AbstractSlingRepositoryManager.getLoginAdminWhitelist()Lorg/apache/sling/jcr/base/LoginAdminWhitelist; at org.apache.sling.jcr.base.AbstractSlingRepository2.loginAdministrative(AbstractSlingRepository2.java:373) at org.apache.sling.jcr.base.internal.loader.Loader.getSession(Loader.java:326) at org.apache.sling.jcr.base.internal.loader.Loader.registerNamespaces(Loader.java:213) at org.apache.sling.jcr.base.internal.loader.Loader.registerBundleInternal(Loader.java:225) at org.apache.sling.jcr.base.internal.loader.Loader.registerBundle(Loader.java:158) at org.apache.sling.jcr.base.internal.loader.Loader.(Loader.java:75) at org.apache.sling.jcr.base.AbstractSlingRepositoryManager.start(AbstractSlingRepositoryManager.java:371) ... Any advice would be much appreciated! Best, Sandro
java.lang.AbstractMethodError: org.apache.sling.jcr.base.AbstractSlingRepositoryManager.getLoginAdminWhitelist() - trunk build does not work // was: mountByFS does not work
Am 14.11.16 um 23:02 schrieb Robert Munteanu: On Mon, 2016-11-14 at 21:50 +0100, Sandro Boehme wrote: Hi Robert, It took me a while to get the trunk to build. I had to disable the Rat checks and update the dependency to org.apache.sling.jcr.base version 2.4.3-SNAPSHOT in org.apache.sling.jcr.oak.server. Why isn't there a build job anymore for trunk? Should I build Sling differently than described at the website [1]? The context as is at [2]. Basically, the big 'trunk' jobs were too slow and flaky. Now we have many small jobs, with none of them slow and a couple of them flaky :-) But the reactor build should work nonetheless. I currently can't build it due to repository.apache.org timeouts, can you post any errors that you get? Thanks, Robert [2]: https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkin s+Se tup The dependency to oasling.jcr.base 2.4.x has been changed by Julian in the meantime to prepare for the oak.server-1.1.2 release. So I could build the trunk a few minutes ago. But the server doesn't seem to start completely. When accessing http://localhost:8080 I get an HTTP 503 saying "Problem accessing /. Reason: AuthenticationSupport service missing. Cannot authenticate request." 138 bundles are available and active. The error log shows me this error: 14.11.2016 21:30:58.119 *ERROR* [OsgiInstallerImpl] org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager start: Uncaught Throwable trying to access Repository, calling stopRepository() java.lang.AbstractMethodError: org.apache.sling.jcr.base.AbstractSlingRepositoryManager.getLoginAdmi nWhitelist()Lorg/apache/sling/jcr/base/LoginAdminWhitelist; (snip) Seems like a mismatch between bundle versions. I think that this class/config was moved to oak-server recently. Just to be sure, can you navigate to launchpad/builder and: - remove any existing 'sling' directory - run `mvn clean verify` - run `java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar` Robert I have created new home folders with the -c option already. I followed your instructions anyways but I get the same error. BTW: org.apache.sling.launchpad.SmokeIT fails with the same error (...AuthenticationSupport service missing...). I agree that it might be a config error. The following bundles are active as seen in /system/console/bundles: - org.apache.sling.auth.core 1.3.20 - org.apache.sling.jcr.oak.server 1.1.1.SNAPSHOT - org.apache.sling.jcr.base 2.4.1.SNAPSHOT I also switched to org.apache.sling.jcr.oak.server 1.1.3.SNAPSHOT by changing /launchpad/builder/src/main/provisioning/oak.txt. But the error is still there. Best, Sandro
trunk build does not work // was: mountByFS does not work
Hi Robert, It took me a while to get the trunk to build. I had to disable the Rat checks and update the dependency to org.apache.sling.jcr.base version 2.4.3-SNAPSHOT in org.apache.sling.jcr.oak.server. Why isn't there a build job anymore for trunk? Should I build Sling differently than described at the website [1]? The context as is at [2]. Basically, the big 'trunk' jobs were too slow and flaky. Now we have many small jobs, with none of them slow and a couple of them flaky :-) But the reactor build should work nonetheless. I currently can't build it due to repository.apache.org timeouts, can you post any errors that you get? Thanks, Robert [2]: https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkins+Se tup The dependency to oasling.jcr.base 2.4.x has been changed by Julian in the meantime to prepare for the oak.server-1.1.2 release. So I could build the trunk a few minutes ago. But the server doesn't seem to start completely. When accessing http://localhost:8080 I get an HTTP 503 saying "Problem accessing /. Reason: AuthenticationSupport service missing. Cannot authenticate request." 138 bundles are available and active. The error log shows me this error: 14.11.2016 21:30:58.119 *ERROR* [OsgiInstallerImpl] org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager start: Uncaught Throwable trying to access Repository, calling stopRepository() java.lang.AbstractMethodError: org.apache.sling.jcr.base.AbstractSlingRepositoryManager.getLoginAdminWhitelist()Lorg/apache/sling/jcr/base/LoginAdminWhitelist; at org.apache.sling.jcr.base.AbstractSlingRepository2.loginAdministrative(AbstractSlingRepository2.java:373) at org.apache.sling.jcr.base.internal.loader.Loader.getSession(Loader.java:326) at org.apache.sling.jcr.base.internal.loader.Loader.registerNamespaces(Loader.java:213) at org.apache.sling.jcr.base.internal.loader.Loader.registerBundleInternal(Loader.java:225) at org.apache.sling.jcr.base.internal.loader.Loader.registerBundle(Loader.java:158) at org.apache.sling.jcr.base.internal.loader.Loader.(Loader.java:75) at org.apache.sling.jcr.base.AbstractSlingRepositoryManager.start(AbstractSlingRepositoryManager.java:371) ... Any advice would be much appreciated! Best, Sandro
Re: mountByFS does not work
The problem is that we need to update the fsresource bundle to use the resource resolver observation api. I'll try to take care of it. Ah. Thanks a lot! I've updated the fsresource bundle (SLING-6279) but didn't test it so far :) So if you want to give it a try... Thanks for updating Carsten! It took me a while to get the trunk to build. I had to disable the Rat checks and update the dependency to org.apache.sling.jcr.base version 2.4.3-SNAPSHOT in org.apache.sling.jcr.oak.server. Why isn't there a build job anymore for trunk? Should I build Sling differently than described at the website [1]? Now when I access http://localhost:8080/ I get the error "AuthenticationSupport service missing. Cannot authenticate request.". I will have a look at it again at an other day and may ask for support later. But of course if you have a hint already I would be happy about any advice. [1] - http://sling.apache.org/documentation/development/getting-and-building-sling.html Best, Sandro
Re: mountByFS does not work
in my case a FS mount (-Dsling.mountByFS=true) does not work. The configMgr of the web console shows that the mount is there and FileMonitor.check() detects the change and sends the event. My question is: Who is the receiver of the event? I understand that it's the event of the FsResourceProvider but what code listens to the change and (in my case) doesn't promote it. The scripting jsp should listen to the events you mention above, but now the scripting is not using event admin anymore but uses the ResourceChangeListener and therefore it never gets the event. The problem is that we need to update the fsresource bundle to use the resource resolver observation api. I'll try to take care of it. Ah. Thanks a lot! Best, Sandro
mountByFS does not work
Hello, in my case a FS mount (-Dsling.mountByFS=true) does not work. The configMgr of the web console shows that the mount is there and FileMonitor.check() detects the change and sends the event. My question is: Who is the receiver of the event? I understand that it's the event of the FsResourceProvider but what code listens to the change and (in my case) doesn't promote it. Thanks, Sandro
[jira] [Resolved] (SLING-6135) ResourceEditor build failure on Jenkins
[ https://issues.apache.org/jira/browse/SLING-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-6135. -- Resolution: Fixed Thanks for reporting [~rombert]! > ResourceEditor build failure on Jenkins > --- > > Key: SLING-6135 > URL: https://issues.apache.org/jira/browse/SLING-6135 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Robert Munteanu > Assignee: Sandro Boehme > Attachments: resourceeditor_failure.txt > > > The resource editor fails to build on Jenkins, and I have no idea how to > tackle the node build error. [~sandro] - IIRC you were the one who > contributed the module, perhaps you have an idea about how to fix the build. > The error lines that I spotted are: > * {{[ERROR] gyp_main.py: error: no such option: --no-parallel}} > * {{[ERROR] node-pre-gyp ERR! stack Error: Failed to execute 'node-gyp > configure --fallback-to-build > --module=/home/jenkins/jenkins-slave/workspace/sling-contrib-explorers-resourceeditor-1.7/frontend/node_modules/grunt-node-inspector/node_modules/node-inspector/node_modules/v8-debug/build/debug/v0.4.6/node-v14-linux-x64/debug.node > --module_name=debug > --module_path=/home/jenkins/jenkins-slave/workspace/sling-contrib-explorers-resourceeditor-1.7/frontend/node_modules/grunt-node-inspector/node_modules/node-inspector/node_modules/v8-debug/build/debug/v0.4.6/node-v14-linux-x64' > (1)}} > * {{[ERROR] Error: Cannot find module './pre-binding'}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-6252) Resource Editor :: Fix frontend build
[ https://issues.apache.org/jira/browse/SLING-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-6252. -- Resolution: Fixed > Resource Editor :: Fix frontend build > - > > Key: SLING-6252 > URL: https://issues.apache.org/jira/browse/SLING-6252 > Project: Sling > Issue Type: Bug > Components: Extensions > Reporter: Sandro Boehme > Assignee: Sandro Boehme > > The frontend build currently does not work because the package.json has to be > updated and the e2e tests for PhantomJS (and Chrome and Firefox) have to be > fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SLING-6252) Resource Editor :: Fix frontend build
[ https://issues.apache.org/jira/browse/SLING-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme reassigned SLING-6252: Assignee: Sandro Boehme > Resource Editor :: Fix frontend build > - > > Key: SLING-6252 > URL: https://issues.apache.org/jira/browse/SLING-6252 > Project: Sling > Issue Type: Bug > Components: Extensions > Reporter: Sandro Boehme > Assignee: Sandro Boehme > > The frontend build currently does not work because the package.json has to be > updated and the e2e tests for PhantomJS (and Chrome and Firefox) have to be > fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-6252) Resource Editor :: Fix frontend build
Sandro Boehme created SLING-6252: Summary: Resource Editor :: Fix frontend build Key: SLING-6252 URL: https://issues.apache.org/jira/browse/SLING-6252 Project: Sling Issue Type: Bug Components: Extensions Reporter: Sandro Boehme The frontend build currently does not work because the package.json has to be updated and the e2e tests for PhantomJS (and Chrome and Firefox) have to be fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-6248) Resource Editor :: Create a simple Resource Type Editor
[ https://issues.apache.org/jira/browse/SLING-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme updated SLING-6248: - Attachment: Bildschirmfoto 2016-11-06 um 00.27.24.png > Resource Editor :: Create a simple Resource Type Editor > --- > > Key: SLING-6248 > URL: https://issues.apache.org/jira/browse/SLING-6248 > Project: Sling > Issue Type: New Feature > Components: Extensions > Reporter: Sandro Boehme > Assignee: Sandro Boehme > Attachments: Bildschirmfoto 2016-11-06 um 00.27.24.png > > > It should be possible to choose a resource super type and on of it's scripts > to overwrite from an inheritance view. After that it should create the new > resource type, assign the super type and copy the super types script the new > resource type location. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SLING-6248) Resource Editor :: Create a simple Resource Type Editor
[ https://issues.apache.org/jira/browse/SLING-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme reassigned SLING-6248: Assignee: Sandro Boehme > Resource Editor :: Create a simple Resource Type Editor > --- > > Key: SLING-6248 > URL: https://issues.apache.org/jira/browse/SLING-6248 > Project: Sling > Issue Type: New Feature > Components: Extensions > Reporter: Sandro Boehme > Assignee: Sandro Boehme > > It should be possible to choose a resource super type and on of it's scripts > to overwrite from an inheritance view. After that it should create the new > resource type, assign the super type and copy the super types script the new > resource type location. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-6248) Resource Editor :: Create a simple Resource Type Editor
Sandro Boehme created SLING-6248: Summary: Resource Editor :: Create a simple Resource Type Editor Key: SLING-6248 URL: https://issues.apache.org/jira/browse/SLING-6248 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Sandro Boehme It should be possible to choose a resource super type and on of it's scripts to overwrite from an inheritance view. After that it should create the new resource type, assign the super type and copy the super types script the new resource type location. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: sling releases - deploy to OBR?
I personally used it as good as possible but also recognized that bundles were not available so I had to put it in my own OBR at some point. If I'm the only one it may not pay off to support it and I would be fine be remove the OBR support. Best, Sandro Am 01.11.16 um 08:24 schrieb Bertrand Delacretaz: On Mon, Oct 31, 2016 at 11:09 PM, Stefan Seifertwrote: ...do we still support OBR as deployment target? or should we just remove it from our relase management process... I suggest removing it, and if someone complains we can re-add. As you mention, many recent releases haven't been added there, so it's out of sync anyway. -Bertrand
Re: sling attic / cleanup (Sitebuilder, Resource Editor)
Hey Bertrand, Am 20.10.16 um 09:12 schrieb Bertrand Delacretaz: Hi Sandro, On Wed, Oct 19, 2016 at 11:15 PM, Sandro Boehme <sandro.boe...@gmx.de> wrote: ...I'm still working on the Sitebuilder [1] and the resource editor and need the js module for that... ok, good to hear from you! No problem keeping those modules out of the attic. -Bertrand glad to read that. Some background and direction: In the mean time I have one part time day a week where I can mostly work on it. My goal is to be able to use the Sitebuilder and Resource Editor for own websites. I will keep the Sitebuilder at GitHub and I guess I should rename it to not call it "Sling Sitebuilder" and only "Sitebuilder". But I would keep "sling" in the package name for now to avoid another refactoring. Best, Sandro
Re: sling attic / cleanup
Hello, I'm still working on the Sitebuilder [1] and the resource editor and need the js module for that. Please keep it. Thanks! Sandro 2) We scheduled contrib/jcr/js for removal, but it's indirectly referenced from contrib/explorers/resourceeditor. So we either keep both or move both to the attic. For 1) I suggest we keep the three modules. If at least one dev thinks they should stay, it's enough for me. I am not sure at all what to do about 2) though. Robert [1] - https://github.com/sandroboehme/sitebuilder
[jira] [Resolved] (SLING-5541) Relocate and clean up JSNodeTypes
[ https://issues.apache.org/jira/browse/SLING-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-5541. -- Resolution: Fixed Changed Java testing packages, JavaScript packages, artifact id, documentation and JavaScript tests. > Relocate and clean up JSNodeTypes > - > > Key: SLING-5541 > URL: https://issues.apache.org/jira/browse/SLING-5541 > Project: Sling > Issue Type: Task >Reporter: Oliver Lietz > Assignee: Sandro Boehme > > The package {{org.apache.sling.commons}} is reserved for code *NOT* depending > on Sling. So {{org.apache.sling.commons.js.nodetypes}} must be changed, > suggesting {{org.apache.sling.jcr.js.nodetypes}} and moved out of > {{contrib/commons}}. The namespace {{de.sandroboehme}} must be changed > accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5541) Relocate and clean up JSNodeTypes
[ https://issues.apache.org/jira/browse/SLING-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163834#comment-15163834 ] Sandro Boehme commented on SLING-5541: -- Thanks for the detailed info [~olli] I will change that. Please tell me in case it's urgent. > Relocate and clean up JSNodeTypes > - > > Key: SLING-5541 > URL: https://issues.apache.org/jira/browse/SLING-5541 > Project: Sling > Issue Type: Task >Reporter: Oliver Lietz > Assignee: Sandro Boehme > > The package {{org.apache.sling.commons}} is reserved for code *NOT* depending > on Sling. So {{org.apache.sling.commons.js.nodetypes}} must be changed, > suggesting {{org.apache.sling.jcr.js.nodetypes}} and moved out of > {{contrib/commons}}. The namespace {{de.sandroboehme}} must be changed > accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Sling CMS / component framework
Hello Sling developers, thanks again for your feedback on my last question (Would you use the CMS or do you know someone who would?). It was very good to have! It made me recognize that interest in a Sling CMS is limited (showcase for Sling and use cases of Ondrej). This is why I would be more than happy if you can tell me if it would be useful in the phase before. When it can not yet be used as a CMS without a developer as there are no components at the marketplace. This is the phase when it has to be useful for developers that create individual websites based on a web framework (like Sling). I think that it would be useful for them, to have a frontend component framework on top of Sling that adds only minimum overhead and also provides tooling to actually (re-)use the components on a page and share them (for free or for sale) at the marketplace. ++ The Page Editor is not needed ++ o Also with an other editor other code can be added to the page and the component can be moved around and deleted without problems. For adding a component without the Page Editor one has to make sure that its id is unique at the page. This will be easier after the implementation allows to use textual ids (not done yet). o One can work on a page with the Page Editor tool and the IDE or texteditor interchangeably. ++ Page Editor ++ The wysiwyg Page Editor allows to move frontend components from a toolbar to a page and to move them around on a page. If there are nested pages it can also move components from page to page while managing the uniqueness of the component id. The icons (move, delete, edit) and other HTML, CSS and JavaScript code is not persistent at the page it is added to the page at runtime instead. This way no preview code has to be removed later on. The Page Editor also contains a universal editor for the component content. There the user can enter the content in child resources and properties that the component needs. ++ HTML frontend component API ++ To have a HTML component that needs no data access only three simple changes need to be made to the HTML block: 1. Additional "component" css class. 2. Additional "data-component-type='component-type-name'" 3. Additional "data-component-id='1234'" ++ JavaScript frontent component API ++ To use JavaScript to access the content of the component the previous changes need to be made and the JavaScript API can be used to read the component content the user entered via JSON from the server. ++ JSP API ++ The component code can be wrapped with a custom tag that provides the page context attribute "componentResource". It is the root that contains the content the user entered for the component and can be used in JSP based components. ++ Sightly API ++ It is still work in progress and current tests make me confident that the API will also be straightforward. ++ page structure ++ The usual resource (super) type script resolution process and the include mechanisms are used to reuse pages. Components are also used for structuring and nesting components within a page. A css class "container" within a component defines a placeholder to drop other nested components. ++ frontend dependency management ++ This is work in progress. It should be possible to optionally define frontend packages (like jQuery, Bootstrap,...) as component dependencies in a package.json (similar to npm) and get these dependencies including their transitive dependencies resolved, downloaded and installed on the fly. Current tests show that it's possible using JSPM. ++ bundle dependencies ++ It should be possible to define OSGi bundles in the package.json as dependencies as well. That is still part of the backlog. Does that motivate you to use it and to you know of others who would use it? Thanks for reading, Sandro
Re: Worthwhile to create a Sling CMS?
I recognized I accidently answered privately to Ondrej by hitting 'reply'. So here is my answer to him from two days ago: Hi Ondrej, Am 19.01.16 um 15:49 schrieb Ondrej Florian: Having yet another CMS for 'normal' people like Wix may not be worthwhile. I think it is not like Wix as it is Open Source. But of course this is more important for developers than for users as long as Wix can provide enough reusable elements for the users. HOWEVER, going into verticals may be much more interesting. I absolutely agree. I personally think the Sling could be great data integration platform. - imagine modeling SAP or SF data as resources... - being able to 'mix' those resources into a web pages or reports - build forms / workflows Yes, that should certainly not be too hard to do. In the Sitebuilder poc demo [1] I moved simple text fields to the page, gave them an HTML name and the Sling POST servlet created the according node property. This way the page editor didn't have to do much. I also agree that it would integrate well into Java (-affine) architectures as it fits skill wise. ...this also takes you very close to document/knowledge management :-) Yes, this is probably right. Thanks, Sandro [1] - https://vimeo.com/140369433
Re: Worthwhile to create a Sling CMS?
Hi Ruben, Am 19.01.16 um 18:19 schrieb Ruben Reusser: for what it's worth, it would be really nice to have an inline editing experience, maybe like https://slate.adobe.com/welcome/ Yes, I agree. It should be possible for frontend components that are shown on the live page to have dependencies to other packages like inline editors. I did some test with the JSPM API [1] and it looks like it is feasible to download and install the dependencies and its transitive dependencies on the fly. To use that in the page editor for editing content more changes are needed but I think it should not be too hard and I agree that it would be a nice thing to have. Best, Sandro [1] - https://github.com/jspm/jspm-cli/blob/master/docs/api.md
Re: Worthwhile to create a Sling CMS?
Am 19.01.16 um 14:35 schrieb Bertrand Delacretaz: Hi Sandro, On Tue, Jan 19, 2016 at 2:25 PM, Sandro Boehme <sandro.boe...@gmx.de> wrote: ...It would help me a big deal if some of you could tell me if they would use this kind of CMS or if the know people who would use it as that validates (or invalidates) my effort!.. I don't need to host a CMS myself these days, so wouldn't use that, but I think a Sling-based CMS would be a great showcase of what Sling can do. -Bertrand Thanks for your feedback Bertrand! Would you use it and maybe develop components for it if it would be available immediately as a service in the web (e.g. like Wix)? What CMS would you personally use instead? Or what other superior offering is there in your opinion? Best, Sandro
Worthwhile to create a Sling CMS?
Hello, I personally think there is a market and demand for a small Sling CMS that is a website builder which assembles frontend components from an open marketplace. It would help me a big deal if some of you could tell me if they would use this kind of CMS or if the know people who would use it as that validates (or invalidates) my effort! It should be as simple and straightforward as a typical website builder for composing a page from the frontend components. At the same time the barrier to develop these components should be as low as possible and developers should be able to sell components to allow a thriving marketplace for users to choose components from. When researching to see if there is something comparable I didn't found anything. The closest were Wix, LightCMS, Hippo (marketplace planned), Liferay and Nuxeo. But they all have an enterprise edition which raises the barrier for many users and developers to use the CMS and makes the distribution of the CMS harder. If you know something else that matches my goals better I would really like to know it! For me it seems obvious to go that route but I'm certainly biased :-). This is why your opinion is very important to me! If you would like to know more about this initiative you will find more (technical) information at the introduction page of the survey here: https://de.surveymonkey.com/r/WL7S2PJ Of course if you don't have the time you don't need to fill the questionnaire and you can just read the first page. Any feedback is much appreciated! Thanks, Sandro
Re: Worthwhile to create a Sling CMS?
Hi Bertrand, Am 19.01.16 um 15:16 schrieb Bertrand Delacretaz: ... but my personal needs in terms of CMS are extremely limited these days. When my friends look for websites/CMS I usually steer them to wordpress.com to be able to get out of the way as soon :-D yeah I understand. as possible. And I use that as well for my own blog, for historical reasons and with no need for something better at the moment. I agree and used Wordpress for the web shop of my wife (wingsuit.de) as well. And then there are were cases where I would like to have small changes or update things. But with Wordpress being developed in PHP it doesn't really motivate me to do that let alone having fun doing it. Also for experimental blogs or business ideas I would love to have a very helpful CMS written in Java so I can have a more individual result. So my use cases are atypical, I'm not a good customer for such a thing. But as I said, very interested in having concrete examples of how to use Sling. Yeah, if it turns out, that the Sitebuilder has not enough value for users or developers to use, I'm happy to provide it as a showcase. Thanks a lot for your feedback! Sandro -Bertrand
Re: Worthwhile to create a Sling CMS?
Am 19.01.16 um 16:20 schrieb Peter Hunsberger: We use a sorta open source CMS called dotCMS. Rather obscure, but meets many of our needs, among which is scaling to support 400 authors and somewhere over 900 web sites. As we scale to more users we'd like to start to decompose that into distributed components: - authoring - indexing (Elastic Seach in our case) - publishing - caching (Redis in our case) - content distribution - workflow management - authorization, authentication Basically, having each function run in Docker containers that can be instantiated as needed. Our needs are likely way different than what you're aiming at, but to the extent you can meet them you may end up with a pretty flexible solution? Yes, I'm not aiming at distributed components and more for small to medium websites. There is no separated authoring and publishing instance for example. But I can imagine that this can be done using Slings discovery API later on. Best, Sandro
Requirements for a small Apache Sling CMS
Hello, I'm still working on the Sitebuilder CMS that I think has lot's of potential. You are the core users and developers target group as you have excellent know how of developing Sling and using Sling based CMSs. This is why I would like to introduce you to more details of the (in my opinion) innovative initiative and ask you for your valuable feedback in this survey. The survey contains the introduction and 20 questions and takes around 10-20 minues to complete. Here https://de.surveymonkey.com/r/WL7S2PJ you can find out more and support the initiative with your information! Thanks a lot! Sandro
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Hi Nicolas, I've configured my email client to display conversations as a thread as long as people "answer" to an email and I can imagine that it's the same for other people as well. To stop this vote thread as Carsten suggested it would be better to write a new email with a new subject to dev@sling.apache.org. This way your email would be more prominent in the mailing list and people would recognize your donation offer. You will have my +1 in any case! Best, Sandro Am 23.10.15 um 13:56 schrieb Nicolas Peltier: bump On 17 Oct 2015, at 10:54, Nicolas Peltierwrote: Hi, fixed the test issue for both java version (i should say nashorn versions) thanks to Robert’s patch. new version is attached, shasum is fdf8052425fa6a66199f8fd5bec8bf6f420983b1, please vote Nicolas On 15 Oct 2015, at 14:42, Nicolas Peltier wrote: yes, closing this thread now, will resend a vote once it’s fixed. Sorry about that. Nicolas On 15 Oct 2015, at 14:34, Carsten Ziegeler wrote: Can we maybe stop this vote thread, resolve the issues and then start a clean vote thread? Otherwise tracking this is very hard. Thanks Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: New Sling Sitebuilder proof of concept demo video
Am 07.10.15 um 15:17 schrieb Robert Munteanu: And as one person asked on site here at the adaptTo(): The license is of course planned to be the Apache license. Yup, I am always curious about licensing :-) Same for me :-). I think you have solved some interesting problems and it can be a good starting point for Sling-based applications, so it would be a nice addition to Sling. Thanks for the feedback Robert! I'm glad that the response the sitebuilder poc gets is so good. Not only here but also from personal talks at the adaptTo() and other occasions. Due to a time consuming hobby and the time that I would like to spend with my small family I'm currently searching for an additional way to really get it going and work on that. One idea is to work as a Junior AEM freelancer and use the time between the projects to work on the Sitebuilder. Even if that means I would need to quit an actually good job at inovex GmbH. If anyone knows about projects that fit please let me know. Best, Sandro Robert The Jericho parser that I included uses the EPL and the LGPL license. And to not needing the restrictions Apache expects when using an EPL licensed project I asked if we can get the Jericho parser Apache licensed and the response was positive which I'm happy about. Best, Sandro Am 28.09.15 um 10:09 schrieb Bertrand Delacretaz: Hi Sandro, On Fri, Sep 25, 2015 at 1:08 AM, Sandro Boehme < sandro.boe...@gmx.de> wrote: ...To see it in action and get an understanding of how it works I created a demo video... The concepts look interesting, can we see the code or test a live version somewhere? -Bertrand
Re: New Sling Sitebuilder proof of concept demo video
Hi Bertrand, I'm glad you like it! Yeah, the closing titles scrolled though way too quickly at the end. Here are the GitHub links: https://github.com/sandroboehme/sitebuilder https://github.com/sandroboehme/car_rental And as one person asked on site here at the adaptTo(): The license is of course planned to be the Apache license. The Jericho parser that I included uses the EPL and the LGPL license. And to not needing the restrictions Apache expects when using an EPL licensed project I asked if we can get the Jericho parser Apache licensed and the response was positive which I'm happy about. Best, Sandro Am 28.09.15 um 10:09 schrieb Bertrand Delacretaz: Hi Sandro, On Fri, Sep 25, 2015 at 1:08 AM, Sandro Boehme <sandro.boe...@gmx.de> wrote: ...To see it in action and get an understanding of how it works I created a demo video... The concepts look interesting, can we see the code or test a live version somewhere? -Bertrand
Re: New Sling Sitebuilder proof of concept demo video
Hello again, in the next days I'm at the adaptTo() conference in Berlin. I'm still hoping the Sitebuilder is generally of interest. If somebody want to talk about that I would be happy to meet you! Here [1] is a picture of me to find me. Best, Sandro [1] - https://scontent-frt3-1.xx.fbcdn.net/hphotos-xfa1/t31.0-0/p180x540/1900197_10203938203841788_8275678222473695468_o.jpg Am 26.09.15 um 21:15 schrieb Sandro Boehme: Hello again, I hope the Sitebuilder is of any interest. Let me tell you what I personally like the most about it: o Nested Frontend Components o Being able to change the page with the Page Editor and with an external editor interchangeably. o The Frontend Components needing only a minimum amount of requirements. Static HTML only needs a component CSS class and a component type attribute. And components that use repository content only additionally need the component JSP tag or the JavaScript client library to load the component resource data. o The component JSP tag provides an own scope for proper isolation. o Having a generic editor for the repository content. It should still not be too hard to make it possible for component developers to provide own editors for their content. o Being able to mangage the component resource for the component developers. They don't need to create, move or delete it. If the component is moved to or from a script included with it's resource that delivers the content of the component is moved from one parent resource to the other. (Does not yet work for nested components but should not be hard to do.) o At no time having any preview code in the final script that would need to be removed before deployment. I noted a lot to do's that have to be done until it's a releasable version. Beside a general cleanup, error handling, avoiding page refreshs and so on I would also like to make it possible to create Sightly based components. Best, Sandro Am 25.09.15 um 01:08 schrieb Sandro Boehme: Hello, as announced in my adaptTo() 2014 talk I worked on creating a CMS. What I've got now is a proof of concept for a Sling Sitebuilder and a frontend component API. To see it in action and get an understanding of how it works I created a demo video that you can find here (available in 0,5-1,5 hours): https://vimeo.com/140369433 It gets more and more into the details so you might not need to see the complete video. My basic questions are: o Is such a Sitebuilder actually something you and people you know want? o Do you see special technical risks? o Are you willing to cooperate on a Sling implementation or do you know of people who are willing to? o Do you know of a product that would benefit from the Sitebuilder and whose company would want to collaborate on that in some way? Thanks for any feedback! Best, Sandro
Re: New Sling Sitebuilder proof of concept demo video
Hello again, I hope the Sitebuilder is of any interest. Let me tell you what I personally like the most about it: o Nested Frontend Components o Being able to change the page with the Page Editor and with an external editor interchangeably. o The Frontend Components needing only a minimum amount of requirements. Static HTML only needs a component CSS class and a component type attribute. And components that use repository content only additionally need the component JSP tag or the JavaScript client library to load the component resource data. o The component JSP tag provides an own scope for proper isolation. o Having a generic editor for the repository content. It should still not be too hard to make it possible for component developers to provide own editors for their content. o Being able to mangage the component resource for the component developers. They don't need to create, move or delete it. If the component is moved to or from a script included with it's resource that delivers the content of the component is moved from one parent resource to the other. (Does not yet work for nested components but should not be hard to do.) o At no time having any preview code in the final script that would need to be removed before deployment. I noted a lot to do's that have to be done until it's a releasable version. Beside a general cleanup, error handling, avoiding page refreshs and so on I would also like to make it possible to create Sightly based components. Best, Sandro Am 25.09.15 um 01:08 schrieb Sandro Boehme: Hello, as announced in my adaptTo() 2014 talk I worked on creating a CMS. What I've got now is a proof of concept for a Sling Sitebuilder and a frontend component API. To see it in action and get an understanding of how it works I created a demo video that you can find here (available in 0,5-1,5 hours): https://vimeo.com/140369433 It gets more and more into the details so you might not need to see the complete video. My basic questions are: o Is such a Sitebuilder actually something you and people you know want? o Do you see special technical risks? o Are you willing to cooperate on a Sling implementation or do you know of people who are willing to? o Do you know of a product that would benefit from the Sitebuilder and whose company would want to collaborate on that in some way? Thanks for any feedback! Best, Sandro
New Sling Sitebuilder proof of concept demo video
Hello, as announced in my adaptTo() 2014 talk I worked on creating a CMS. What I've got now is a proof of concept for a Sling Sitebuilder and a frontend component API. To see it in action and get an understanding of how it works I created a demo video that you can find here (available in 0,5-1,5 hours): https://vimeo.com/140369433 It gets more and more into the details so you might not need to see the complete video. My basic questions are: o Is such a Sitebuilder actually something you and people you know want? o Do you see special technical risks? o Are you willing to cooperate on a Sling implementation or do you know of people who are willing to? o Do you know of a product that would benefit from the Sitebuilder and whose company would want to collaborate on that in some way? Thanks for any feedback! Best, Sandro
Re: Errorpage for the Sling Resource Editor
Hello again, sadly it worked only by mistake before. I want to have an error jsp that is shown on all errors of the Sling post servlet and that displays the according error message. I thought, that the Throwable.jsp placed below the node for the resource type is what I wanted but it worked only by accident as I created a NPE that lead to this page. Based on Bertrands example I would like to show what I mean: 1.The container node for the resource type $ curl -u admin:admin -Fsling:resourceType=posterror http://localhost:8080/apps/posterror 2. The html form $ echo 'htmlbodyform method=post input type=hidden name=:sendError value=true input type=text name=aProperty input type=submit /form/body/html' /tmp/posterror.jsp $ curl -u admin:admin -T/tmp/posterror.jsp http://localhost:8080/apps/posterror/posterror.jsp 3. The general error handler that I would like to show up because the post of the HTML form in the step before is not unauthenticated. $ echo 'This is a general error handler' /tmp/Throwable.jsp $ curl -u admin:admin -T /tmp/Throwable.jsp http://localhost:8080/apps/posterror/Throwable.jsp 4. The form whose submit should lead to the rendering of the Throwable.jsp. How can I make that happen? Is that a bug or is there an other way to do that? $ curl http://localhost:8080/apps/posterror.html 5. If I create a 500.jsp like this it gets rendered instead of the Throwable.jsp. Why is that the case as I would have expected it to be a 401 Unauthorized error? $ echo 'Error 500: %=request.getAttribute(javax.servlet.error.message)%, Exception: %=request.getAttribute(javax.servlet.error.exception)%' /tmp/500.jsp $ curl -u admin:admin -T /tmp/500.jsp http://localhost:8080/apps/posterror/500.jsp 6. Deleting the 500.jsp for debugging reasons $ curl -u admin:admin -F:operation=delete http://localhost:8080/apps/posterror/500.jsp Help is much appreciated! Thanks, Sandro Am 08.07.15 um 22:01 schrieb Sandro Boehme: Yeah! I've found the solution. I've just have to send :sendError=true with the post request. The only documentation I've found is the javadoc [1]. I think I could add the information about that parameter at the Special Parameters paragraph of the manipulating content page [2] like: :sendError Setting this parameter to true (case insensitive) allows to use custom error handling as described in the Errorhandling documentation [3] If there is no veto I would do that. There is already a test case for that: ErrorHandlingTest.test_errorhandling_POST_operation_SlingPostServlet() It sends a post to /apps/testNode and seem to use the resource type for the resolution of the error handler. [1] - https://sling.apache.org/apidocs/sling7/org/apache/sling/servlets/post/SlingPostConstants.html#RP_SEND_ERROR [2] - http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#special-parameters [3] - https://sling.apache.org/documentation/the-sling-engine/errorhandling.html Best, Sandro Am 06.07.15 um 16:00 schrieb Sandro Boehme: Am 06.07.15 um 15:20 schrieb Sandro Boehme: Hi Bertrand, Am 06.07.15 um 14:25 schrieb Bertrand Delacretaz: Hi Sandro, On Mon, Jul 6, 2015 at 2:00 PM, Sandro Boehme sandro.boe...@gmx.de wrote: Am 06.07.15 um 11:16 schrieb Bertrand Delacretaz: ...debugging the SlingServletResolver.handleError method should help as well The processing flow does not seem to go through this method as the debugger does not stop there The below example works for me, comparing with what you are doing might help? There are integration tests for this in ErrorHandlingTest [1] but they dont seem to test the resource-specific error handlers - if you can add some tests for that while investigating that would be great, of course. I'd be happy if I could do that. $ curl -u admin:admin -Fsling:resourceType=xyz http://localhost:8080/apps/xyz ... titleContent created /apps/xyz/title ... $ echo '% if(true) throw new IllegalStateException(this cannot work); %' /tmp/xyz.jsp $ curl -u admin:admin -T/tmp/xyz.jsp http://localhost:8080/apps/xyz/xyz.jsp $ echo 'This is the custom error handler' /tmp/IllegalStateException.jsp $ curl -u admin:admin -T /tmp/IllegalStateException.jsp http://localhost:8080/apps/xyz/IllegalStateException.jsp $ curl http://localhost:8080/apps/xyz.html This is the custom error handler Yeah, it works for me as well! Thanks for this error page example it runs through the handleError() methods as you wrote. I'll use the time between some family celebrations to compare with my code and let you and the list (archive) know about the results. As a quick check I've added your error handler jsp to the resource folder and added the throw statement to my page. It works and shows the custom error page! Next I will check for the right exception and resource type in my case. Best, Sandro
[jira] [Created] (SLING-4870) documentation for the :sendError parameter at the manipulating content page
Sandro Boehme created SLING-4870: Summary: documentation for the :sendError parameter at the manipulating content page Key: SLING-4870 URL: https://issues.apache.org/jira/browse/SLING-4870 Project: Sling Issue Type: Improvement Components: Documentation Reporter: Sandro Boehme Assignee: Sandro Boehme To allow for custom error handling the :sendError must be used. That should be reflected in the Special Parameters paragraph of the manipulating content page [1] like this: :sendError Setting this parameter to true (case insensitive) allows to use custom error handling as described in the Errorhandling documentation [2]. If there is no veto I will do that. [1] - http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#special-parameters [2] - https://sling.apache.org/documentation/the-sling-engine/errorhandling.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Errorpage for the Sling Resource Editor
Yeah! I've found the solution. I've just have to send :sendError=true with the post request. The only documentation I've found is the javadoc [1]. I think I could add the information about that parameter at the Special Parameters paragraph of the manipulating content page [2] like: :sendError Setting this parameter to true (case insensitive) allows to use custom error handling as described in the Errorhandling documentation [3] If there is no veto I would do that. There is already a test case for that: ErrorHandlingTest.test_errorhandling_POST_operation_SlingPostServlet() It sends a post to /apps/testNode and seem to use the resource type for the resolution of the error handler. [1] - https://sling.apache.org/apidocs/sling7/org/apache/sling/servlets/post/SlingPostConstants.html#RP_SEND_ERROR [2] - http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#special-parameters [3] - https://sling.apache.org/documentation/the-sling-engine/errorhandling.html Best, Sandro Am 06.07.15 um 16:00 schrieb Sandro Boehme: Am 06.07.15 um 15:20 schrieb Sandro Boehme: Hi Bertrand, Am 06.07.15 um 14:25 schrieb Bertrand Delacretaz: Hi Sandro, On Mon, Jul 6, 2015 at 2:00 PM, Sandro Boehme sandro.boe...@gmx.de wrote: Am 06.07.15 um 11:16 schrieb Bertrand Delacretaz: ...debugging the SlingServletResolver.handleError method should help as well The processing flow does not seem to go through this method as the debugger does not stop there The below example works for me, comparing with what you are doing might help? There are integration tests for this in ErrorHandlingTest [1] but they dont seem to test the resource-specific error handlers - if you can add some tests for that while investigating that would be great, of course. I'd be happy if I could do that. $ curl -u admin:admin -Fsling:resourceType=xyz http://localhost:8080/apps/xyz ... titleContent created /apps/xyz/title ... $ echo '% if(true) throw new IllegalStateException(this cannot work); %' /tmp/xyz.jsp $ curl -u admin:admin -T/tmp/xyz.jsp http://localhost:8080/apps/xyz/xyz.jsp $ echo 'This is the custom error handler' /tmp/IllegalStateException.jsp $ curl -u admin:admin -T /tmp/IllegalStateException.jsp http://localhost:8080/apps/xyz/IllegalStateException.jsp $ curl http://localhost:8080/apps/xyz.html This is the custom error handler Yeah, it works for me as well! Thanks for this error page example it runs through the handleError() methods as you wrote. I'll use the time between some family celebrations to compare with my code and let you and the list (archive) know about the results. As a quick check I've added your error handler jsp to the resource folder and added the throw statement to my page. It works and shows the custom error page! Next I will check for the right exception and resource type in my case. Best, Sandro
Re: Errorpage for the Sling Resource Editor
Hallo again, to be more concrete, I've added a Throwable.jsp and a 500.jsp to contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor/errorhandler and contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor but still the default white error page shows up with the 500 status. Does someone have an idea what's wrong with the configuration and how I can show an error page for the resource editor? Best, Sandro Am 02.07.15 um 10:19 schrieb Sandro Boehme: Hello, for the Resource Editor's [1] property page I would like to switch the addition and update of the properties from being ajax calls to be regular page requests. But on an error a new an plain error page is rendered while I would like to get my Resource Editor page [4] rendered with the error data as request attributes that I can use to show the error there. The Resource Editor uses a Resource Provider [2], that wraps the resources to add a resource type marker. Based on that marker the ResourceProviderBasedResourceDecorator [3] changes the resource type of a resource that leads to the JSP [4] to be rendered. I checked the errorhandling page [5] for Sling but couldn't get it working with that information. Any hint is much appreciated! Best, Sandro [1] - https://sling.apache.org/documentation/bundles/resource-editor.html - contrib/explorers/resourceeditor/README [2] - http://svn.apache.org/viewvc/sling/trunk/contrib/explorers/resourceeditor/src/main/java/org/apache/sling/reseditor/resource/ [3] - http://svn.apache.org/viewvc/sling/trunk/contrib/explorers/resourceeditor/src/main/java/org/apache/sling/reseditor/resource/ResourceProviderBasedResourceDecorator.java?view=markup [4] - http://svn.apache.org/viewvc/sling/trunk/contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor/html.jsp?view=markup [5] - https://sling.apache.org/documentation/the-sling-engine/errorhandling.html
Re: Errorpage for the Sling Resource Editor
Hi Bertrand, Am 06.07.15 um 11:16 schrieb Bertrand Delacretaz: Hi Sandro, On Mon, Jul 6, 2015 at 10:07 AM, Sandro Boehme sandro.boe...@gmx.de wrote: to be more concrete, I've added a Throwable.jsp and a 500.jsp to contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor/errorhandler... AFAIK those will only apply to resources of type sling/resource-editor/errorhandler and contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor Those should apply if a Throwable is thrown or sendResult(500) is called while processing a resource of the sling/resource-editor type. yes, the resource type is sling/resource-editor. Thanks for your infos, it's good to know that this files should apply. If you want to debug, grepping the DEBUG logs for candidate lists which scripts/servlets are considered, and debugging the SlingServletResolver.handleError method should help as well. The processing flow does not seem to go through this method as the debugger does not stop there. I debugged from the SlingPostServlet on and saw that AbstractPostOperation.run() line 144 set the error: } catch (Exception e) { log.error(Exception during response processing., e); response.setError(e); } and AbstractPostResponse:prepare() line 296 rendered the error page: if (getError() != null) { setStatus(500, getError().toString()); setTitle(Error while processing + path); } ... But I don't see something that decides when an error page should be shown. It looks like there is no simple answer so if there is no quick idea on what I could try I would have a look at the integration tests for custom error pages and/or would start from plain vanilla error page examples. Thanks, Sandro -Bertrand
Re: Errorpage for the Sling Resource Editor
Hi Bertrand, Am 06.07.15 um 14:25 schrieb Bertrand Delacretaz: Hi Sandro, On Mon, Jul 6, 2015 at 2:00 PM, Sandro Boehme sandro.boe...@gmx.de wrote: Am 06.07.15 um 11:16 schrieb Bertrand Delacretaz: ...debugging the SlingServletResolver.handleError method should help as well The processing flow does not seem to go through this method as the debugger does not stop there The below example works for me, comparing with what you are doing might help? There are integration tests for this in ErrorHandlingTest [1] but they dont seem to test the resource-specific error handlers - if you can add some tests for that while investigating that would be great, of course. I'd be happy if I could do that. $ curl -u admin:admin -Fsling:resourceType=xyz http://localhost:8080/apps/xyz ... titleContent created /apps/xyz/title ... $ echo '% if(true) throw new IllegalStateException(this cannot work); %' /tmp/xyz.jsp $ curl -u admin:admin -T/tmp/xyz.jsp http://localhost:8080/apps/xyz/xyz.jsp $ echo 'This is the custom error handler' /tmp/IllegalStateException.jsp $ curl -u admin:admin -T /tmp/IllegalStateException.jsp http://localhost:8080/apps/xyz/IllegalStateException.jsp $ curl http://localhost:8080/apps/xyz.html This is the custom error handler Yeah, it works for me as well! Thanks for this error page example it runs through the handleError() methods as you wrote. I'll use the time between some family celebrations to compare with my code and let you and the list (archive) know about the results. Thanks again! Sandro -Bertrand [1] https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/servlets/resolver/errorhandler/ErrorHandlingTest.java
Re: Errorpage for the Sling Resource Editor
Am 06.07.15 um 15:20 schrieb Sandro Boehme: Hi Bertrand, Am 06.07.15 um 14:25 schrieb Bertrand Delacretaz: Hi Sandro, On Mon, Jul 6, 2015 at 2:00 PM, Sandro Boehme sandro.boe...@gmx.de wrote: Am 06.07.15 um 11:16 schrieb Bertrand Delacretaz: ...debugging the SlingServletResolver.handleError method should help as well The processing flow does not seem to go through this method as the debugger does not stop there The below example works for me, comparing with what you are doing might help? There are integration tests for this in ErrorHandlingTest [1] but they dont seem to test the resource-specific error handlers - if you can add some tests for that while investigating that would be great, of course. I'd be happy if I could do that. $ curl -u admin:admin -Fsling:resourceType=xyz http://localhost:8080/apps/xyz ... titleContent created /apps/xyz/title ... $ echo '% if(true) throw new IllegalStateException(this cannot work); %' /tmp/xyz.jsp $ curl -u admin:admin -T/tmp/xyz.jsp http://localhost:8080/apps/xyz/xyz.jsp $ echo 'This is the custom error handler' /tmp/IllegalStateException.jsp $ curl -u admin:admin -T /tmp/IllegalStateException.jsp http://localhost:8080/apps/xyz/IllegalStateException.jsp $ curl http://localhost:8080/apps/xyz.html This is the custom error handler Yeah, it works for me as well! Thanks for this error page example it runs through the handleError() methods as you wrote. I'll use the time between some family celebrations to compare with my code and let you and the list (archive) know about the results. As a quick check I've added your error handler jsp to the resource folder and added the throw statement to my page. It works and shows the custom error page! Next I will check for the right exception and resource type in my case. Best, Sandro
Errorpage for the Sling Resource Editor
Hello, for the Resource Editor's [1] property page I would like to switch the addition and update of the properties from being ajax calls to be regular page requests. But on an error a new an plain error page is rendered while I would like to get my Resource Editor page [4] rendered with the error data as request attributes that I can use to show the error there. The Resource Editor uses a Resource Provider [2], that wraps the resources to add a resource type marker. Based on that marker the ResourceProviderBasedResourceDecorator [3] changes the resource type of a resource that leads to the JSP [4] to be rendered. I checked the errorhandling page [5] for Sling but couldn't get it working with that information. Any hint is much appreciated! Best, Sandro [1] - https://sling.apache.org/documentation/bundles/resource-editor.html - contrib/explorers/resourceeditor/README [2] - http://svn.apache.org/viewvc/sling/trunk/contrib/explorers/resourceeditor/src/main/java/org/apache/sling/reseditor/resource/ [3] - http://svn.apache.org/viewvc/sling/trunk/contrib/explorers/resourceeditor/src/main/java/org/apache/sling/reseditor/resource/ResourceProviderBasedResourceDecorator.java?view=markup [4] - http://svn.apache.org/viewvc/sling/trunk/contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor/html.jsp?view=markup [5] - https://sling.apache.org/documentation/the-sling-engine/errorhandling.html
[jira] [Resolved] (SLING-4736) Resource Editor :: properties page :: add CRUD for String and prepare for other types
[ https://issues.apache.org/jira/browse/SLING-4736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-4736. -- Resolution: Fixed o Added crud for String and Path properties o Added path-editor, path-viewer and string-editor tag files o Added e2e tests for the new crud and improved other e2e tests o Added shortcuts and a cheat sheet for properties to explain them o Added bootstrap-notify to notify after saving and deleting properties o Added Glyphicons-halflings icon font for property icons o Manually tested on IE9 o Styles adapted for IE9 o Added toolbar with dropdown for the properties page o Replaced some css colors by variables in less files o Added vertical scrolling to the properties page Resource Editor :: properties page :: add CRUD for String and prepare for other types - Key: SLING-4736 URL: https://issues.apache.org/jira/browse/SLING-4736 Project: Sling Issue Type: New Feature Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Yay, I can finally start with the editing functionality for the properties page! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4837) Resource Editor :: properties page :: add support for property arrays (multiple properties)
Sandro Boehme created SLING-4837: Summary: Resource Editor :: properties page :: add support for property arrays (multiple properties) Key: SLING-4837 URL: https://issues.apache.org/jira/browse/SLING-4837 Project: Sling Issue Type: New Feature Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Assignee: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Moving to servlet 3 as the base?
Am 25.06.15 um 18:17 schrieb Carsten Ziegeler: Hi, right now, Sling in theory runs on servet 2.4 and we have to do some ugly tricks to support 2.4/2.5 and 3.x. I think 3.0 is now out long enough that we could upgrade and require 3.0 as the base and get rid of all the special handling. WDYT? Carsten +1 It would be useful for the Resource Editor. Best, Sandro
automatic recompilation of tag files
Hello, for the Sling Resource Editor's [1] properties page I would like to create reusable Tag Files for the different property types. Right now I have a basic one working for string properties. But I need to 'mvn install...' it for every change. Is there a way to get them recompiled automatically like with the FsResourceProvider for usual JSP's? I've mounted the META-INF folder with the tld and the /tags/string-editor.tag files from the file system like the JSP's. But I suspect they are actually delivered to the server with the bundle jar which will not be updated on every Tag File update. Does someone know a way to see the Tag File changes equally fast at the server as the JSP changes? [1] - https://sling.apache.org/documentation/bundles/resource-editor.html Thanks in advance for any hints! Sandro
[jira] [Created] (SLING-4736) Resource Editor :: properties page :: add CRUD for String and prepare for other types
Sandro Boehme created SLING-4736: Summary: Resource Editor :: properties page :: add CRUD for String and prepare for other types Key: SLING-4736 URL: https://issues.apache.org/jira/browse/SLING-4736 Project: Sling Issue Type: New Feature Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Yay, I can finally start with the editing functionality for the properties page! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4555) Resource Editor: Add Jasmine tests, end to end tests and documentation
[ https://issues.apache.org/jira/browse/SLING-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550173#comment-14550173 ] Sandro Boehme commented on SLING-4555: -- Added Jasmine unit tests for Firefox and Chrome in r1678999. Resource Editor: Add Jasmine tests, end to end tests and documentation -- Key: SLING-4555 URL: https://issues.apache.org/jira/browse/SLING-4555 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Assignee: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4555) Resource Editor: Add Jasmine tests, end to end tests and documentation
[ https://issues.apache.org/jira/browse/SLING-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-4555. -- Resolution: Fixed Resource Editor: Add Jasmine tests, end to end tests and documentation -- Key: SLING-4555 URL: https://issues.apache.org/jira/browse/SLING-4555 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Assignee: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4555) Resource Editor: Add Jasmine tests, end to end tests and documentation
[ https://issues.apache.org/jira/browse/SLING-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550523#comment-14550523 ] Sandro Boehme commented on SLING-4555: -- Changed the documentation a bit. Resource Editor: Add Jasmine tests, end to end tests and documentation -- Key: SLING-4555 URL: https://issues.apache.org/jira/browse/SLING-4555 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Assignee: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4555) Resource Editor: Add Jasmine tests, end to end tests and documentation
[ https://issues.apache.org/jira/browse/SLING-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540169#comment-14540169 ] Sandro Boehme commented on SLING-4555: -- Added Jasmine end to end tests in r1678999. Resource Editor: Add Jasmine tests, end to end tests and documentation -- Key: SLING-4555 URL: https://issues.apache.org/jira/browse/SLING-4555 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Assignee: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Simplified bundle deployment on OBR
Hi, Am 27.04.15 um 11:36 schrieb Bertrand Delacretaz: Hi, On Fri, Apr 24, 2015 at 4:33 PM, Robert Munteanu romb...@apache.org wrote: ...I just checking in a shell script at tooling/releases/sync_obr_with_dist.sh [1] that can be used to update the sling.xml OBR file when releasing bundles Do we care about that OBR, is anyone using it? Now as the Resource Editor only uses Sling dependencies it doesn't need it anymore. But I used it in the JCRBrowser as it makes the installation of 3rd party libs very convenient for the user and I guess non committers / users of Sling might find it very useful as well. Best, Sandro -Bertrand
Re: Build failed in Jenkins: sling-trunk-1.6 #3256
Hi, ok the build is not broken anymore. Just in time to leave Germany to fly to Dubai in 2h :-). Best, Sandro Am 07.04.15 um 06:59 schrieb Sandro Boehme: Hi, I reverted my changes in 'r1671740' and hope it fixes the build. Best, Sandro Am 06.04.15 um 22:14 schrieb Sandro Boehme: Hi, somehow I managed to break the build of 'sling-trunk-1.6' by checking something in to 'contrib/explorers/resourceeditor'. From what I understand it should not have a dependency to that build, right? It looks like an integration test of the Event Support project failed. But I cannot reproduce it. The failsafe plugin version has been updated at a commit before but the build was blue. Does someone have a pointer? The problem is, that I will probably have no or not a good internet connection during the next 8 days. I will do my best to fix it. I guess I will not commit short before a vacation again. Best, Sandro Am 06.04.15 um 20:29 schrieb Apache Jenkins Server: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.16:integration-test (default) on project org.apache.sling.event: Execution default of goal org.apache.maven.plugins:maven-failsafe-plugin:2.16:integration-test failed: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? [ERROR] Command was/bin/sh -c cd https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event /home/jenkins/tools/java/jdk1.6.0_45-32/jre/bin/java -Xmx2048m -XX:MaxPermSize=512m -jar https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event/target/surefire/surefirebooter8966558270306960395.jar https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event/target/surefire/surefire4336694494544216414tmp https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event/target/surefire/surefire_23694121237566832733tmp
Re: Build failed in Jenkins: sling-trunk-1.6 #3256
Hi, somehow I managed to break the build of 'sling-trunk-1.6' by checking something in to 'contrib/explorers/resourceeditor'. From what I understand it should not have a dependency to that build, right? It looks like an integration test of the Event Support project failed. But I cannot reproduce it. The failsafe plugin version has been updated at a commit before but the build was blue. Does someone have a pointer? The problem is, that I will probably have no or not a good internet connection during the next 8 days. I will do my best to fix it. I guess I will not commit short before a vacation again. Best, Sandro Am 06.04.15 um 20:29 schrieb Apache Jenkins Server: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.16:integration-test (default) on project org.apache.sling.event: Execution default of goal org.apache.maven.plugins:maven-failsafe-plugin:2.16:integration-test failed: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? [ERROR] Command was/bin/sh -c cd https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event /home/jenkins/tools/java/jdk1.6.0_45-32/jre/bin/java -Xmx2048m -XX:MaxPermSize=512m -jar https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event/target/surefire/surefirebooter8966558270306960395.jar https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event/target/surefire/surefire4336694494544216414tmp https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event/target/surefire/surefire_23694121237566832733tmp
Re: Build failed in Jenkins: sling-trunk-1.6 #3256
Hi, I reverted my changes in 'r1671740' and hope it fixes the build. Best, Sandro Am 06.04.15 um 22:14 schrieb Sandro Boehme: Hi, somehow I managed to break the build of 'sling-trunk-1.6' by checking something in to 'contrib/explorers/resourceeditor'. From what I understand it should not have a dependency to that build, right? It looks like an integration test of the Event Support project failed. But I cannot reproduce it. The failsafe plugin version has been updated at a commit before but the build was blue. Does someone have a pointer? The problem is, that I will probably have no or not a good internet connection during the next 8 days. I will do my best to fix it. I guess I will not commit short before a vacation again. Best, Sandro Am 06.04.15 um 20:29 schrieb Apache Jenkins Server: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.16:integration-test (default) on project org.apache.sling.event: Execution default of goal org.apache.maven.plugins:maven-failsafe-plugin:2.16:integration-test failed: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? [ERROR] Command was/bin/sh -c cd https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event /home/jenkins/tools/java/jdk1.6.0_45-32/jre/bin/java -Xmx2048m -XX:MaxPermSize=512m -jar https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event/target/surefire/surefirebooter8966558270306960395.jar https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event/target/surefire/surefire4336694494544216414tmp https://builds.apache.org/job/sling-trunk-1.6/ws/trunk/bundles/extensions/event/target/surefire/surefire_23694121237566832733tmp
Re: Documentation for the Sling Resource Editor
Thanks for the info Bertrand, thats good to know! Am 01.04.15 um 10:09 schrieb Bertrand Delacretaz: On Tue, Mar 31, 2015 at 10:27 PM, Sandro Boehme sandro.boe...@gmx.de wrote: ...Are there any statistics about such pages?... No, we haven't set that up - http://jackrabbit.apache.org/ is using Google Analytics for example, along with http://jackrabbit.apache.org/privacy-policy.html to be open about it. -Bertrand
[jira] [Resolved] (SLING-4559) Resource Editor :: add node dialog :: use the entered but not yet selected values of the dropdowns
[ https://issues.apache.org/jira/browse/SLING-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-4559. -- Resolution: Fixed Resource Editor :: add node dialog :: use the entered but not yet selected values of the dropdowns -- Key: SLING-4559 URL: https://issues.apache.org/jira/browse/SLING-4559 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4559) Resource Editor :: add node dialog :: use the entered but not yet selected values of the dropdowns
Sandro Boehme created SLING-4559: Summary: Resource Editor :: add node dialog :: use the entered but not yet selected values of the dropdowns Key: SLING-4559 URL: https://issues.apache.org/jira/browse/SLING-4559 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4561) Resource Editor: avoid the submission of a node name in edit mode when the mouse hovers an other node
Sandro Boehme created SLING-4561: Summary: Resource Editor: avoid the submission of a node name in edit mode when the mouse hovers an other node Key: SLING-4561 URL: https://issues.apache.org/jira/browse/SLING-4561 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4561) Resource Editor: avoid the submission of a node name in edit mode when the mouse hovers an other node
[ https://issues.apache.org/jira/browse/SLING-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-4561. -- Resolution: Fixed Resource Editor: avoid the submission of a node name in edit mode when the mouse hovers an other node - Key: SLING-4561 URL: https://issues.apache.org/jira/browse/SLING-4561 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Assignee: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SLING-4559) Resource Editor :: add node dialog :: use the entered but not yet selected values of the dropdowns
[ https://issues.apache.org/jira/browse/SLING-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme reassigned SLING-4559: Assignee: Sandro Boehme Resource Editor :: add node dialog :: use the entered but not yet selected values of the dropdowns -- Key: SLING-4559 URL: https://issues.apache.org/jira/browse/SLING-4559 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Assignee: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SLING-4561) Resource Editor: avoid the submission of a node name in edit mode when the mouse hovers an other node
[ https://issues.apache.org/jira/browse/SLING-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme reassigned SLING-4561: Assignee: Sandro Boehme Resource Editor: avoid the submission of a node name in edit mode when the mouse hovers an other node - Key: SLING-4561 URL: https://issues.apache.org/jira/browse/SLING-4561 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Assignee: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Documentation for the Sling Resource Editor
Hi Bertrand and Robert, thanks for your quick answers! I will use the website now for documentation. And thanks for configuring the access Bertrand! Best, Sandro Am 31.03.15 um 10:56 schrieb Bertrand Delacretaz: Hi Sandro, On Mon, Mar 30, 2015 at 10:40 PM, Sandro Boehme sandro.boe...@gmx.de wrote: ...Or if it's better to use the Confluence wiki. Can somebody tell me how to get write access if I should use the latter?... Let us know your user ID there and we can hopefully give you access. -Bertrand (who started to hate Confluence the day it stopped being a wiki)
Re: Documentation for the Sling Resource Editor
Hi, I understand now how to change a page with the CMS. But can someone please tell me how to create a new one? I would like to add a link to a new page at 'http://sling.apache.org/documentation/bundles.html'. The idea is to have a link named Sling Resource Editor frontend under Content Presentation that links to the new page. Do I have to create a 'https://svn.apache.org/repos/asf/sling/site/trunk/content/documentation/bundles/resource-editor.mdtext' file in SVN and commit it there first? Best, Sandro Am 30.03.15 um 23:07 schrieb Robert Munteanu: Hi Sandro, On Mon, Mar 30, 2015 at 11:40 PM, Sandro Boehme sandro.boe...@gmx.de wrote: Hi, I would like to create online documentation for the Sling Resource Editor to get more users/contributors/committers for it. Now I wonder if it's practical (and allowed for me) to add the docu at the public Sling website even though the decommissioning of the CMS is proposed. Yes, please add the docs to the Sling website. If we end up migrating to a different system, we'll migrate everything anyway. Cheers, Robert Or if it's better to use the Confluence wiki. Can somebody tell me how to get write access if I should use the latter? Best, Sandro
Re: Documentation for the Sling Resource Editor
Yeah, it worked well! It's browsing the directory, then Edit this directory and then an input field that has to be submitted via the 'Return' key as there is no submit button. The initial version is now online. Are there any statistics about such pages? Best, Sandro Am 31.03.15 um 18:10 schrieb Bertrand Delacretaz: Hi, On Tue, Mar 31, 2015 at 5:24 PM, Sandro Boehme sandro.boe...@gmx.de wrote: ...Do I have to create a 'https://svn.apache.org/repos/asf/sling/site/trunk/content/documentation/bundles/resource-editor.mdtext' file in SVN and commit it there first?... I usually do it like this, but you could also use cms.apache.org, IIRC it's edit directory there. -Bertrand
[jira] [Resolved] (SLING-4205) Clarify the licensing of resourceeditor images, fonts etc.
[ https://issues.apache.org/jira/browse/SLING-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-4205. -- Resolution: Fixed The 'src/main/resources/SLING-INF/libs/sling/resource-editor-static-content/3rd_party' and the 'src/main/resources/SLING-INF/libs/sling/resource-editor-static-content/generated/3rd_party' folder now contain all the 3rd party frontend libraries. The latter is populated via npm and Grunt (frontend/Gruntfile.js) and will be regenerated. This happens either when grunt is called from Maven via the frontend-maven-plugin or with the '/frontend/grunt' script. In addition the './licenselist' script can be called within the 'frontend' folder to see the installed libs and its licenses. This clearly separates the 3rd party code from the own code and also lists the licenses. Clarify the licensing of resourceeditor images, fonts etc. -- Key: SLING-4205 URL: https://issues.apache.org/jira/browse/SLING-4205 Project: Sling Issue Type: Task Components: Extensions Reporter: Bertrand Delacretaz Assignee: Sandro Boehme Priority: Minor Fix For: Resource Editor 1.0.2 Attachments: AddNodeDialogPatch-alu.gif.txt, AddNodeDialogPatch-src-stainless_steel.xcf.txt As per SLING-4169 some of the images, fonts and maybe other resources used by the resource-editor module need clarification or replacement to make sure we can be release them under the Apache License. This issue is meant to keep track of which files are already ok and which ones need modifications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4462) Resource Editor :: Integrate Node.js, Grunt and npm for frontend libraries
[ https://issues.apache.org/jira/browse/SLING-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-4462. -- Resolution: Fixed Grunt is now configured with the used npm packages. Now the following things work: o A small Karma Jasmine test (src/test/javascript/spec/resource_editor_spec.js) via './grunt desktop_build' within the 'frontend' folder. o A small end to end Webdriver test (src/test/javascript/e2e/spec/e2e_spec.js) via './grunt desktop_build' within the 'frontend' folder. o `./grunt watch:less` in the frontend folder. The unsupported org.lesscss.lesscss-maven-plugin is removed now. o The lesscss source map is generated. o Bootstraps Less sources and many frontend libraries are removed from SVN. o The 'frontend/licenselist' skript now lists the frontend 3rd party libs and its licenses. Resource Editor :: Integrate Node.js, Grunt and npm for frontend libraries -- Key: SLING-4462 URL: https://issues.apache.org/jira/browse/SLING-4462 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Assignee: Sandro Boehme The goal is to configure the Resource Editor for frontend tests (Jasmine, Karma, end to end via Webdriver) and to optimize its frontend build configuration. To accomplish that the Frontend Maven Plugin (https://github.com/eirslett/frontend-maven-plugin) is used. It installs Node.js, Grunt and npm locally within in the project and makes it available in a Maven build. Con: o The npm repository that needs to be ignored for SVN is generated within the project folder. o The build takes longer initially as the npm repository needs to be filled with the dependencies (5min on my box). o a ~/.npm folder is created and filled with repository data Pro: o Avoids that I have to check in the frontend libraries and Bootstrap Less sources to SVN as they can be copied from the local npm repo during the build process. o Eases the listing of the 3rd party licenses of used npm package as the npm package 'nlf' for example can be used to list the licenses in a specific depth of transitive dependencies. It allows a good fix for SLING-4205. o I get a map file created by the less compiler o Better supported libraries: - BDD Unit Tests with different browsers Via Maven: https://github.com/karma-runner/maven-karma-plugin (31 Stars) Via npm: https://github.com/karma-runner/karma (4760 Stars) - Less CSS compiler and watch functionality Via Maven: https://github.com/marceloverdijk/lesscss-maven-plugin (155 Stars, not supported anymore) https://github.com/marceloverdijk/lesscss-java (151 Stars, not supported anymore) Via npm: https://github.com/gruntjs/grunt-contrib-watch (1380 Stars) https://github.com/gruntjs/grunt-contrib-less (519 Stars) - Minification: Via Maven: https://github.com/davidB/yuicompressor-maven-plugin (80 Stars) Via npm: https://github.com/gruntjs/grunt-contrib-uglify (850 Stars) https://github.com/gruntjs/grunt-contrib-cssmin (513 Stars) - BDD (Jasmine) End to End Tests are not available via Maven -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4555) Resource Editor: Add Jasmine, end to end tests and documentation
Sandro Boehme created SLING-4555: Summary: Resource Editor: Add Jasmine, end to end tests and documentation Key: SLING-4555 URL: https://issues.apache.org/jira/browse/SLING-4555 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4555) Resource Editor: Add Jasmine tests, end to end tests and documentation
[ https://issues.apache.org/jira/browse/SLING-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme updated SLING-4555: - Summary: Resource Editor: Add Jasmine tests, end to end tests and documentation (was: Resource Editor: Add Jasmine, end to end tests and documentation) Resource Editor: Add Jasmine tests, end to end tests and documentation -- Key: SLING-4555 URL: https://issues.apache.org/jira/browse/SLING-4555 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SLING-4555) Resource Editor: Add Jasmine tests, end to end tests and documentation
[ https://issues.apache.org/jira/browse/SLING-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme reassigned SLING-4555: Assignee: Sandro Boehme Resource Editor: Add Jasmine tests, end to end tests and documentation -- Key: SLING-4555 URL: https://issues.apache.org/jira/browse/SLING-4555 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Resource Editor 1.0.2 Reporter: Sandro Boehme Assignee: Sandro Boehme -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Documentation for the Sling Resource Editor
Hi, I would like to create online documentation for the Sling Resource Editor to get more users/contributors/committers for it. Now I wonder if it's practical (and allowed for me) to add the docu at the public Sling website even though the decommissioning of the CMS is proposed. Or if it's better to use the Confluence wiki. Can somebody tell me how to get write access if I should use the latter? Best, Sandro