Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Sat, Dec 8, 2012 at 7:21 AM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
edje: use eo more.
Author: cedric
Date: 2012-12-08 01:21:10 -0800 (Sat, 08 Dec 2012)
New Revision: 80519
Trac: http://trac.enlightenment.org/e/changeset/80519
Modified:
trunk/edje/src/lib/edje_calc.c
Modified: trunk/edje/src/lib/edje_calc.c
===
--- trunk/edje/src/lib/edje_calc.c 2012-12-08 08:53:38 UTC (rev 80518)
+++ trunk/edje/src/lib/edje_calc.c 2012-12-08 09:21:10 UTC (rev 80519)
@@ -676,8 +676,9 @@
ed-recalc_hints = EINA_FALSE;
-edje_object_size_min_calc(ed-obj, w, h);
-evas_object_size_hint_min_set(ed-obj, w, h);
+ eo_do(ed-obj,
+ edje_obj_size_min_get(w, h),
+ evas_obj_size_hint_min_set(w, h));
Hey Cedric, you are changin from size_min_calc to size_min_get here ^
Is this intended ?
}
if (!ed-collection) return ;
@@ -1230,9 +1231,9 @@
tw = th = 0;
if (!chosen_desc-text.min_x)
{
- evas_object_resize(ep-object, params-w, params-h);
- evas_object_textblock_size_formatted_get(ep-object,
tw,
-th);
+ eo_do(ep-object,
+evas_obj_size_set(params-w, params-h),
+evas_obj_textblock_size_formatted_get(tw, th));
}
else
evas_object_textblock_size_native_get(ep-object, tw,
th);
@@ -1257,8 +1258,9 @@
tw = th = 0;
if (!chosen_desc-text.max_x)
{
- evas_object_resize(ep-object, params-w, params-h);
- evas_object_textblock_size_formatted_get(ep-object, tw,
th);
+ eo_do(ep-object,
+ evas_obj_size_set(params-w, params-h),
+ evas_obj_textblock_size_formatted_get(tw, th));
}
else
evas_object_textblock_size_native_get(ep-object, tw, th);
@@ -1282,16 +1284,17 @@
double s = 1.0;
if (ep-part-scale) s = TO_DOUBLE(sc);
- evas_object_scale_set(ep-object, s);
- evas_object_textblock_size_formatted_get(ep-object, tw, th);
+eo_do(ep-object,
+ evas_obj_scale_set(s),
+ evas_obj_textblock_size_formatted_get(tw, th));
if (chosen_desc-text.fit_x)
{
if ((tw 0) (tw params-w))
{
s = (s * params-w) / (double)tw;
- evas_object_scale_set(ep-object, s);
- evas_object_textblock_size_formatted_get(ep-object,
-tw, th);
+ eo_do(ep-object,
+evas_obj_scale_set(s),
+evas_obj_textblock_size_formatted_get(tw, th));
}
}
if (chosen_desc-text.fit_y)
@@ -1299,9 +1302,9 @@
if ((th 0) (th params-h))
{
s = (s * params-h) / (double)th;
- evas_object_scale_set(ep-object, s);
- evas_object_textblock_size_formatted_get(ep-object,
-tw, th);
+ eo_do(ep-object,
+evas_obj_scale_set(s),
+evas_obj_textblock_size_formatted_get(tw, th));
}
}
}
@@ -1373,8 +1376,9 @@
(!chosen_desc-text.max_x) (!chosen_desc-text.max_y)))
return;
- evas_object_geometry_get(ep-object, NULL, NULL, tw, th);
- evas_object_text_style_pad_get(ep-object, l, r, t, b);
+ eo_do(ep-object,
+evas_obj_size_get(tw, th),
+evas_obj_text_style_pad_get(l, r, t, b));
mw = tw + l + r;
mh = th + t + b;
@@ -1533,9 +1537,10 @@
[(ep-part-effect EDJE_TEXT_EFFECT_MASK_SHADOW_DIRECTION)
4];
EVAS_TEXT_STYLE_SHADOW_DIRECTION_SET(style, shadow);
- evas_object_text_style_set(ep-object, style);
- evas_object_text_text_set(ep-object, text);
- evas_object_geometry_get(ep-object, NULL, NULL, tw, th);
+eo_do(ep-object,
+ evas_obj_text_style_set(style),
+ evas_obj_text_text_set(text),
+ evas_obj_size_get(tw, th));
if (chosen_desc-text.max_x)
{
int l, r;
@@ -2121,9 +2126,10 @@
{
Evas_Coord lminw = 0, lminh = 0;
-
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 8:30 PM, Carsten Haitzler ras...@rasterman.com wrote: On Thu, 20 Sep 2012 14:40:12 -0300 Eduardo Lima (Etrunko) ebl...@gmail.com said: On Thu, Sep 20, 2012 at 2:29 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:12 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 1:04 PM, Leandro Pereira lean...@profusion.mobi wrote: On 09/20/2012 03:28 AM, Michael Blumenkrantz wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... I honestly thought Edje was stable enough that it didn't have recent changes -- and since ChangeLogs are traditionally written with newer entries on top, I just added mine there. I'll be more careful next time. I'll still mutter something about ChangeLogs being useless given we have commit messages (which can be as long as needed to explain stuff, is easier to merge, is as good a cold beer on a hot day, yadda yadda yadda), though. +1 to drop ChangeLog entirely. Here is the difference between you and me: you claim that YOU don't need a changelog because there are svn commits, so every people on earth just have to install svn or look at a slow websvn to see the changes, even those which are just oupsie! etc... me, who think that an average user of a lib should not need to install svn (or git or etc...) or use a slow websvn to look quickly at a changelog file. And I say that because it was in that very situation. You think only about yourself, i thnk about everyone. It takes time to write entries but i'm not lazy. I take that time, on my very limited free time. We are all talking about developers here. Mr. Joe Average user will not use unstable software from the control system, but the stable one released with the generated changelog, be it manually or automatically generated. i guess here's the difference. NEWs and ChangeLog are intended for digestion at release time - ie sit in the tarball. the person compiling it (not a developer - packager etc.) digests these. he may use them roe package update/release notes, to see if he still needs to apply dome bugfix patch etc. etc. And I'm arguing we only need one of those. Lucas De Marchi -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 8:26 PM, Carsten Haitzler ras...@rasterman.com wrote: On Thu, 20 Sep 2012 23:43:36 +0200 Vincent Torri vincent.to...@gmail.com said: On Thu, Sep 20, 2012 at 7:53 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:30 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 7:26 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! It seems everybody except you agree the ChangeLog file is just plain useless. ultra funny. It's just profusion guys who want to drop changelog Eduardo doesn't work here: Excerpt from the README file in libabc (https://git.kernel.org/?p=linux/kernel/git/kay/libabc.git;a=blob;f=README;h=b4bed51b0403f0f55f4e8bb4706cd97e23c4858c;hb=HEAD): Update NEWS to let developers know what has changed - It's the history of the project, stuff that packagers need to know when putting a new version in the distro. The interesting changes or added/removed functionality from version to version. This is not a commit changelog. - If you want to provide ChangeLog, use the one generated by git, do not maintain your own. so what ? counter-example: http://www.gnu.org/prep/standards/html_node/Change-Logs.html kernel doesn't use a ChangeLog file systemd doesn't use a ChangeLog file bluez doesn't use a ChangeLog file connman doesn't use a ChangeLog file kernel doesn't use a ChangeLog file node doesn't use a ChangeLog file go doesn't use a ChangeLog file pulseaudio doesn't use a ChangeLog file v8 uses a ChangeLog file that's really a NEWS file webkit uses a semi-automated ChangeLog file, creating the commit message from the changelog. And it's stupid. Been there. and i'm sure i can find HUNDREDS of libs with changelog. I have as many arguments as you have. And WE are back to 90's maintaining that stupid files ourselves to be clear : I don't like our NEWS file. For me: ChangeLog should contain exactly what its name means : log of changes. Not all of changes of course. NEWS means what's new : that is, entries for the release, API additions, deprecations, and eventually the mention of a big improvement or a fix of a really big bug. That is, all the improvements part should go away, as I agree that it duplicates what is in ChangeLog. raster and others add that part, i accepted it. But I don't like it. And that's not the only stuff that I don't like but that i have accpeted in that project. i agree with vincent here fyi. the actual git or svn or cvs or whatever log is footwork. it isn't publishable data beyond being useful for day-to-day hunting of who did what. changelog is useful publishable changes just in the order they are done. that is the purpose of NEWS news is something you can just blindly copy paste into a release publication and is a summary of the important stuff. So we are maintaining the same thing, in 2 different places... NEWS and ChangeLog. It's just a change in format. this is the convention for most cases of these files that i have seen. changelog is kind of old as it comes from a time when people mostly didnt use scms, but it got repurposed as above. eg the first time u add a feature u add it to changelog. if u then spend the next week patching and fixing the feature and maturing it, you just commit. your changelog doesnt change. neither does news as both these files are intended for digestion at the next release. If there's a new feature at release time it should be in NEWS file. It doesn't matter the date in which it was added. Not for whoever is packaging that stuff. you could argue that changelog as a whole is obsolete. one could argue INSTALL should be removed as frankly README handles that and it doesnt add much more info (though it is static thus no one notices). hell there is an ABOUT-NLS event that is there that we never commit but autotools insists should be there. Remove the cruft and the unnecessary burden we have. Just because it was always done like this doesn't mean it has to continue /me stops now and thinks about who will add the ChangeLog when E17 is released Lucas De Marchi -- Got visibility? Most devs has no idea what their production app looks
Re: [E-devel] E SVN: cedric trunk/edje
On Fri, Sep 21, 2012 at 8:50 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 8:26 PM, Carsten Haitzler ras...@rasterman.com wrote: On Thu, 20 Sep 2012 23:43:36 +0200 Vincent Torri vincent.to...@gmail.com said: On Thu, Sep 20, 2012 at 7:53 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:30 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 7:26 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! It seems everybody except you agree the ChangeLog file is just plain useless. ultra funny. It's just profusion guys who want to drop changelog Eduardo doesn't work here: Excerpt from the README file in libabc (https://git.kernel.org/?p=linux/kernel/git/kay/libabc.git;a=blob;f=README;h=b4bed51b0403f0f55f4e8bb4706cd97e23c4858c;hb=HEAD): Update NEWS to let developers know what has changed - It's the history of the project, stuff that packagers need to know when putting a new version in the distro. The interesting changes or added/removed functionality from version to version. This is not a commit changelog. - If you want to provide ChangeLog, use the one generated by git, do not maintain your own. so what ? counter-example: http://www.gnu.org/prep/standards/html_node/Change-Logs.html kernel doesn't use a ChangeLog file systemd doesn't use a ChangeLog file bluez doesn't use a ChangeLog file connman doesn't use a ChangeLog file kernel doesn't use a ChangeLog file node doesn't use a ChangeLog file go doesn't use a ChangeLog file pulseaudio doesn't use a ChangeLog file v8 uses a ChangeLog file that's really a NEWS file webkit uses a semi-automated ChangeLog file, creating the commit message from the changelog. And it's stupid. Been there. and i'm sure i can find HUNDREDS of libs with changelog. I have as many arguments as you have. And WE are back to 90's maintaining that stupid files ourselves to be clear : I don't like our NEWS file. For me: ChangeLog should contain exactly what its name means : log of changes. Not all of changes of course. NEWS means what's new : that is, entries for the release, API additions, deprecations, and eventually the mention of a big improvement or a fix of a really big bug. That is, all the improvements part should go away, as I agree that it duplicates what is in ChangeLog. raster and others add that part, i accepted it. But I don't like it. And that's not the only stuff that I don't like but that i have accpeted in that project. i agree with vincent here fyi. the actual git or svn or cvs or whatever log is footwork. it isn't publishable data beyond being useful for day-to-day hunting of who did what. changelog is useful publishable changes just in the order they are done. that is the purpose of NEWS http://www.gnu.org/prep/standards/html_node/NEWS-File.html#NEWS-File http://www.gnu.org/prep/standards/html_node/Change-Logs.html So we are maintaining the same thing, in 2 different places... NEWS and ChangeLog. It's just a change in format. no, they are different. There are much more in changelog than in NEWS. If there's a new feature at release time it should be in NEWS file. It doesn't matter the date in which it was added. Not for whoever is packaging that stuff. what is important is the version in which the feature is added. Remove the cruft and the unnecessary burden we have. Just because it was always done like this doesn't mean it has to continue as i said, i would remove the improvements part of NEWS. But i don't care much actually. Vincent -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Fri, Sep 21, 2012 at 4:04 PM, Vincent Torri vincent.to...@gmail.com wrote: On Fri, Sep 21, 2012 at 8:50 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 8:26 PM, Carsten Haitzler ras...@rasterman.com wrote: On Thu, 20 Sep 2012 23:43:36 +0200 Vincent Torri vincent.to...@gmail.com said: On Thu, Sep 20, 2012 at 7:53 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:30 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 7:26 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! It seems everybody except you agree the ChangeLog file is just plain useless. ultra funny. It's just profusion guys who want to drop changelog Eduardo doesn't work here: Excerpt from the README file in libabc (https://git.kernel.org/?p=linux/kernel/git/kay/libabc.git;a=blob;f=README;h=b4bed51b0403f0f55f4e8bb4706cd97e23c4858c;hb=HEAD): Update NEWS to let developers know what has changed - It's the history of the project, stuff that packagers need to know when putting a new version in the distro. The interesting changes or added/removed functionality from version to version. This is not a commit changelog. - If you want to provide ChangeLog, use the one generated by git, do not maintain your own. so what ? counter-example: http://www.gnu.org/prep/standards/html_node/Change-Logs.html kernel doesn't use a ChangeLog file systemd doesn't use a ChangeLog file bluez doesn't use a ChangeLog file connman doesn't use a ChangeLog file kernel doesn't use a ChangeLog file node doesn't use a ChangeLog file go doesn't use a ChangeLog file pulseaudio doesn't use a ChangeLog file v8 uses a ChangeLog file that's really a NEWS file webkit uses a semi-automated ChangeLog file, creating the commit message from the changelog. And it's stupid. Been there. and i'm sure i can find HUNDREDS of libs with changelog. I have as many arguments as you have. And WE are back to 90's maintaining that stupid files ourselves to be clear : I don't like our NEWS file. For me: ChangeLog should contain exactly what its name means : log of changes. Not all of changes of course. NEWS means what's new : that is, entries for the release, API additions, deprecations, and eventually the mention of a big improvement or a fix of a really big bug. That is, all the improvements part should go away, as I agree that it duplicates what is in ChangeLog. raster and others add that part, i accepted it. But I don't like it. And that's not the only stuff that I don't like but that i have accpeted in that project. i agree with vincent here fyi. the actual git or svn or cvs or whatever log is footwork. it isn't publishable data beyond being useful for day-to-day hunting of who did what. changelog is useful publishable changes just in the order they are done. that is the purpose of NEWS http://www.gnu.org/prep/standards/html_node/NEWS-File.html#NEWS-File http://www.gnu.org/prep/standards/html_node/Change-Logs.html So we are maintaining the same thing, in 2 different places... NEWS and ChangeLog. It's just a change in format. no, they are different. There are much more in changelog than in NEWS. If there's a new feature at release time it should be in NEWS file. It doesn't matter the date in which it was added. Not for whoever is packaging that stuff. what is important is the version in which the feature is added. and that should be present in NEWS Lucas De Marchi -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 6:43 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 7:53 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:30 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 7:26 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! It seems everybody except you agree the ChangeLog file is just plain useless. ultra funny. It's just profusion guys who want to drop changelog Eduardo doesn't work here: Excerpt from the README file in libabc ( https://git.kernel.org/?p=linux/kernel/git/kay/libabc.git;a=blob;f=README;h=b4bed51b0403f0f55f4e8bb4706cd97e23c4858c;hb=HEAD ): Update NEWS to let developers know what has changed - It's the history of the project, stuff that packagers need to know when putting a new version in the distro. The interesting changes or added/removed functionality from version to version. This is not a commit changelog. - If you want to provide ChangeLog, use the one generated by git, do not maintain your own. so what ? counter-example: http://www.gnu.org/prep/standards/html_node/Change-Logs.html kernel doesn't use a ChangeLog file systemd doesn't use a ChangeLog file bluez doesn't use a ChangeLog file connman doesn't use a ChangeLog file kernel doesn't use a ChangeLog file node doesn't use a ChangeLog file go doesn't use a ChangeLog file pulseaudio doesn't use a ChangeLog file v8 uses a ChangeLog file that's really a NEWS file webkit uses a semi-automated ChangeLog file, creating the commit message from the changelog. And it's stupid. Been there. and i'm sure i can find HUNDREDS of libs with changelog. I have as many arguments as you have. And WE are back to 90's maintaining that stupid files ourselves to be clear : I don't like our NEWS file. For me: ChangeLog should contain exactly what its name means : log of changes. Not all of changes of course. NEWS means what's new : that is, entries for the release, API additions, deprecations, and eventually the mention of a big improvement or a fix of a really big bug. That is, all the improvements part should go away, as I agree that it duplicates what is in ChangeLog. raster and others add that part, i accepted it. But I don't like it. And that's not the only stuff that I don't like but that i have accpeted in that project. And Vincent, please stop taking it personal and insulting the others. Use stupid for ideas. Not people. the conversation is heated, that's all. I'm from south of France and we are not calm people, there. His answer upset me because what he said was almost an insult to what I did in Evil's ChangeLog. But nobody noted that. So I won't apologize. And I'm italian, so: [image: Inline image 1] Lucas De Marchi panunzio.JPG-- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
ah, if only we could do changelogs sanely like every other changelog in the
entire universe...
On Thu, Sep 20, 2012 at 7:27 AM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
edje: damn top poster !
Author: cedric
Date: 2012-09-19 23:27:34 -0700 (Wed, 19 Sep 2012)
New Revision: 76884
Trac: http://trac.enlightenment.org/e/changeset/76884
Modified:
trunk/edje/ChangeLog
Modified: trunk/edje/ChangeLog
===
--- trunk/edje/ChangeLog2012-09-20 05:48:05 UTC (rev 76883)
+++ trunk/edje/ChangeLog2012-09-20 06:27:34 UTC (rev 76884)
@@ -1,12 +1,3 @@
-2012-08-04 Flavio Ceolin
-
-* Added edje_codegen - tool that genereates code to working with
- edje files.
-
-2012-06-06 Leandro Pereira
-
-* Made state index optional (defaulting to 0.0).
-
2011-01-29 Carsten Haitzler (The Rasterman)
1.0.0 release
@@ -156,6 +147,11 @@
* Entry: Added changed,user signal. This signal indicates the entry
has changed because of user interaction, i.e not by code.
+2012-08-04 Flavio Ceolin
+
+* Added edje_codegen - tool that genereates code to working with
+ edje files.
+
2011-08-22 Cedric Bail
* Add collection.group.limits {
@@ -491,6 +487,10 @@
* Fix decompile of sound samples not double-free
* Fix alsa configure option to be alsa, not flac.
+2012-06-06 Leandro Pereira
+
+* Made state index optional (defaulting to 0.0).
+
2012-06-06 Jihoon Kim
* edje_entry: display preedit string even though there is no
attribute
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 8:28 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... i mentioned that several times: the moap tool 1) moap cl prep 2) you edit ChangeLog 3) moap cl ci that's all Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
doesn't work with git, and I was talking about the stupid reverse ordering of changelogs that we have On Thu, Sep 20, 2012 at 8:11 AM, Vincent Torri vincent.to...@gmail.comwrote: On Thu, Sep 20, 2012 at 8:28 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... i mentioned that several times: the moap tool 1) moap cl prep 2) you edit ChangeLog 3) moap cl ci that's all Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 9:37 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: doesn't work with git, and I was talking about the stupid reverse ordering of changelogs that we have I know you love top posting ! -- Cedric BAIL -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
I'm all about the top post On Thu, Sep 20, 2012 at 8:51 AM, Cedric BAIL cedric.b...@free.fr wrote: On Thu, Sep 20, 2012 at 9:37 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: doesn't work with git, and I was talking about the stupid reverse ordering of changelogs that we have I know you love top posting ! -- Cedric BAIL -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 9:51 AM, Cedric BAIL cedric.b...@free.fr wrote: On Thu, Sep 20, 2012 at 9:37 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: doesn't work with git, and I was talking about the stupid reverse ordering of changelogs that we have I know you love top posting ! that's also more logical to put the recent entries at the top. When people look at the ChageLog, it's often to see recent changes, and not ultra old ones Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
2012/9/20 Vincent Torri vincent.to...@gmail.com: On Thu, Sep 20, 2012 at 9:51 AM, Cedric BAIL cedric.b...@free.fr wrote: On Thu, Sep 20, 2012 at 9:37 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: doesn't work with git, and I was talking about the stupid reverse ordering of changelogs that we have I know you love top posting ! that's also more logical to put the recent entries at the top. When people look at the ChageLog, it's often to see recent changes, and not ultra old ones I would prefer it if we kept changes ordered alphabetically. Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
yep, but HE WHO SHALL REMAIN NAMELESS said that logs are created with the most recent item at the bottom. changelogs are logs. thus changelogs must have the most recent item at the bottom. direct quote. On Thu, Sep 20, 2012 at 1:14 PM, Vincent Torri vincent.to...@gmail.comwrote: On Thu, Sep 20, 2012 at 9:51 AM, Cedric BAIL cedric.b...@free.fr wrote: On Thu, Sep 20, 2012 at 9:37 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: doesn't work with git, and I was talking about the stupid reverse ordering of changelogs that we have I know you love top posting ! that's also more logical to put the recent entries at the top. When people look at the ChageLog, it's often to see recent changes, and not ultra old ones Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 4:11 AM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 8:28 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... i mentioned that several times: the moap tool 1) moap cl prep 2) you edit ChangeLog 3) moap cl ci that's all that's not sane neither. sane: before release you run a command once and only once to turn the commit messages into changelog entries. Lucas De Marchi -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 4:19 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 4:11 AM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 8:28 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... i mentioned that several times: the moap tool 1) moap cl prep 2) you edit ChangeLog 3) moap cl ci that's all that's not sane neither. sane: before release you run a command once and only once to turn the commit messages into changelog entries. moap cl prep : it retrieve info to modify ChangeLog. You just have to add the comments moap cl ci : it check in the modifications, that is, it's equivalent to svn commit so it's sane enough for me. Look at Evil's ChangeLog to see the result Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On 09/20/2012 03:28 AM, Michael Blumenkrantz wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... I honestly thought Edje was stable enough that it didn't have recent changes -- and since ChangeLogs are traditionally written with newer entries on top, I just added mine there. I'll be more careful next time. I'll still mutter something about ChangeLogs being useless given we have commit messages (which can be as long as needed to explain stuff, is easier to merge, is as good a cold beer on a hot day, yadda yadda yadda), though. Leandro -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 1:04 PM, Leandro Pereira lean...@profusion.mobi wrote: On 09/20/2012 03:28 AM, Michael Blumenkrantz wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... I honestly thought Edje was stable enough that it didn't have recent changes -- and since ChangeLogs are traditionally written with newer entries on top, I just added mine there. I'll be more careful next time. I'll still mutter something about ChangeLogs being useless given we have commit messages (which can be as long as needed to explain stuff, is easier to merge, is as good a cold beer on a hot day, yadda yadda yadda), though. +1 to drop ChangeLog entirely. Lucas De Marchi -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! It seems everybody except you agree the ChangeLog file is just plain useless. Lucas De Marchi -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 6:12 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 1:04 PM, Leandro Pereira lean...@profusion.mobi wrote: On 09/20/2012 03:28 AM, Michael Blumenkrantz wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... I honestly thought Edje was stable enough that it didn't have recent changes -- and since ChangeLogs are traditionally written with newer entries on top, I just added mine there. I'll be more careful next time. I'll still mutter something about ChangeLogs being useless given we have commit messages (which can be as long as needed to explain stuff, is easier to merge, is as good a cold beer on a hot day, yadda yadda yadda), though. +1 to drop ChangeLog entirely. Here is the difference between you and me: you claim that YOU don't need a changelog because there are svn commits, so every people on earth just have to install svn or look at a slow websvn to see the changes, even those which are just oupsie! etc... me, who think that an average user of a lib should not need to install svn (or git or etc...) or use a slow websvn to look quickly at a changelog file. And I say that because it was in that very situation. You think only about yourself, i thnk about everyone. It takes time to write entries but i'm not lazy. I take that time, on my very limited free time. Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 7:26 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! It seems everybody except you agree the ChangeLog file is just plain useless. ultra funny. It's just profusion guys who want to drop changelog Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! If being stupid means that I value more the content than the form than you can consider myself one of the most stupid of all times. -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 2:29 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:12 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 1:04 PM, Leandro Pereira lean...@profusion.mobi wrote: On 09/20/2012 03:28 AM, Michael Blumenkrantz wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... I honestly thought Edje was stable enough that it didn't have recent changes -- and since ChangeLogs are traditionally written with newer entries on top, I just added mine there. I'll be more careful next time. I'll still mutter something about ChangeLogs being useless given we have commit messages (which can be as long as needed to explain stuff, is easier to merge, is as good a cold beer on a hot day, yadda yadda yadda), though. +1 to drop ChangeLog entirely. Here is the difference between you and me: you claim that YOU don't need a changelog because there are svn commits, so every people on earth just have to install svn or look at a slow websvn to see the changes, even those which are just oupsie! etc... me, who think that an average user of a lib should not need to install svn (or git or etc...) or use a slow websvn to look quickly at a changelog file. And I say that because it was in that very situation. You think only about yourself, i thnk about everyone. It takes time to write entries but i'm not lazy. I take that time, on my very limited free time. We are all talking about developers here. Mr. Joe Average user will not use unstable software from the control system, but the stable one released with the generated changelog, be it manually or automatically generated. -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 7:30 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 7:26 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! It seems everybody except you agree the ChangeLog file is just plain useless. ultra funny. It's just profusion guys who want to drop changelog btw, when you say that i'm the only guy who dont want to drop changelog, you actually mean me and the maintainers of 99% of the FOSS which also have a changelog, right ? As i said, ultra funny. ok, now an example : the stupid brazilians who are authors of lua : The is no changelog, and no VCS that is accessible with a web browser. How can I know the changes ? what does it cost to have a changelog ? nothing except some very small amount of time. Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
2012/9/20 Eduardo Lima (Etrunko) ebl...@gmail.com: On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! If being stupid means that I value more the content than the form than you can consider myself one of the most stupid of all times. Name calling when it involves discomfitor, TAsn or me is usually fun because we don't really mean it, but outside of those contexts it's more deterring to the conversation than anything else. -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 7:42 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:29 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:12 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 1:04 PM, Leandro Pereira lean...@profusion.mobi wrote: On 09/20/2012 03:28 AM, Michael Blumenkrantz wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... I honestly thought Edje was stable enough that it didn't have recent changes -- and since ChangeLogs are traditionally written with newer entries on top, I just added mine there. I'll be more careful next time. I'll still mutter something about ChangeLogs being useless given we have commit messages (which can be as long as needed to explain stuff, is easier to merge, is as good a cold beer on a hot day, yadda yadda yadda), though. +1 to drop ChangeLog entirely. Here is the difference between you and me: you claim that YOU don't need a changelog because there are svn I and all the others responding to this thread. commits, so every people on earth just have to install svn or look at a slow websvn to see the changes, even those which are just oupsie! etc... Why the hell the user is looking to the changelog file? He shouldn't be. you're wrong, i have examples... Not only me. It's not just me. There are plenty of successful projects out there that abandoned the stupid idea of maintaining a text file that is a copy of what we have in our VCS. And if it isn't a copy, you are requiring every single programmer to take his time to write plain useless information there that nobody will read. me, who think that an average user of a lib should not need to install svn (or git or etc...) or use a slow websvn to look quickly at a changelog file. And I say that because it was in that very situation. Give the NEWS file to the user. Seriously, in what earth are you living on? You think only about yourself, i thnk about everyone. YOU think only about yourself. I have the very same reasoning other developers have, based on projects that abandoned the idea of a ChangeLog. Just write well formatted commits h, here is the core of the problem. Just look at our logs, there a huge of stupid comments for commits How much time will it take to force people to write good commits comments ? Look at the time it take to force people to update correctly doc and NEWS (i don't mention changelog as you don't care) ? I had to send plethore of mails to remember people to do properly Ok, now a guy commit something with a bad comment for the commit. What will you do ? you will revert it and ask the guy to recommit it with a proper comment ? just silly Vincent - who needs that information are the ones that will have git/svn/etc installed. It takes time to write entries but i'm not lazy. I take that time, on my very limited free time. It's just a waste of our time. Sorry, but you need to argue better to convince the world Lucas De Marchi -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 2:30 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 7:26 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! It seems everybody except you agree the ChangeLog file is just plain useless. ultra funny. It's just profusion guys who want to drop changelog Eduardo doesn't work here: Excerpt from the README file in libabc (https://git.kernel.org/?p=linux/kernel/git/kay/libabc.git;a=blob;f=README;h=b4bed51b0403f0f55f4e8bb4706cd97e23c4858c;hb=HEAD): Update NEWS to let developers know what has changed - It's the history of the project, stuff that packagers need to know when putting a new version in the distro. The interesting changes or added/removed functionality from version to version. This is not a commit changelog. - If you want to provide ChangeLog, use the one generated by git, do not maintain your own. kernel doesn't use a ChangeLog file systemd doesn't use a ChangeLog file bluez doesn't use a ChangeLog file connman doesn't use a ChangeLog file kernel doesn't use a ChangeLog file node doesn't use a ChangeLog file go doesn't use a ChangeLog file pulseaudio doesn't use a ChangeLog file v8 uses a ChangeLog file that's really a NEWS file webkit uses a semi-automated ChangeLog file, creating the commit message from the changelog. And it's stupid. Been there. And WE are back to 90's maintaining that stupid files ourselves Just to name a few. I'm sure I could go on and on with this list. And Vincent, please stop taking it personal and insulting the others. Use stupid for ideas. Not people. Lucas De Marchi -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 7:53 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:30 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 7:26 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! It seems everybody except you agree the ChangeLog file is just plain useless. ultra funny. It's just profusion guys who want to drop changelog Eduardo doesn't work here: Excerpt from the README file in libabc (https://git.kernel.org/?p=linux/kernel/git/kay/libabc.git;a=blob;f=README;h=b4bed51b0403f0f55f4e8bb4706cd97e23c4858c;hb=HEAD): Update NEWS to let developers know what has changed - It's the history of the project, stuff that packagers need to know when putting a new version in the distro. The interesting changes or added/removed functionality from version to version. This is not a commit changelog. - If you want to provide ChangeLog, use the one generated by git, do not maintain your own. so what ? counter-example: http://www.gnu.org/prep/standards/html_node/Change-Logs.html kernel doesn't use a ChangeLog file systemd doesn't use a ChangeLog file bluez doesn't use a ChangeLog file connman doesn't use a ChangeLog file kernel doesn't use a ChangeLog file node doesn't use a ChangeLog file go doesn't use a ChangeLog file pulseaudio doesn't use a ChangeLog file v8 uses a ChangeLog file that's really a NEWS file webkit uses a semi-automated ChangeLog file, creating the commit message from the changelog. And it's stupid. Been there. and i'm sure i can find HUNDREDS of libs with changelog. I have as many arguments as you have. And WE are back to 90's maintaining that stupid files ourselves to be clear : I don't like our NEWS file. For me: ChangeLog should contain exactly what its name means : log of changes. Not all of changes of course. NEWS means what's new : that is, entries for the release, API additions, deprecations, and eventually the mention of a big improvement or a fix of a really big bug. That is, all the improvements part should go away, as I agree that it duplicates what is in ChangeLog. raster and others add that part, i accepted it. But I don't like it. And that's not the only stuff that I don't like but that i have accpeted in that project. And Vincent, please stop taking it personal and insulting the others. Use stupid for ideas. Not people. the conversation is heated, that's all. I'm from south of France and we are not calm people, there. His answer upset me because what he said was almost an insult to what I did in Evil's ChangeLog. But nobody noted that. So I won't apologize. Vincent -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, 20 Sep 2012 14:40:12 -0300 Eduardo Lima (Etrunko) ebl...@gmail.com said: On Thu, Sep 20, 2012 at 2:29 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:12 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 1:04 PM, Leandro Pereira lean...@profusion.mobi wrote: On 09/20/2012 03:28 AM, Michael Blumenkrantz wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... I honestly thought Edje was stable enough that it didn't have recent changes -- and since ChangeLogs are traditionally written with newer entries on top, I just added mine there. I'll be more careful next time. I'll still mutter something about ChangeLogs being useless given we have commit messages (which can be as long as needed to explain stuff, is easier to merge, is as good a cold beer on a hot day, yadda yadda yadda), though. +1 to drop ChangeLog entirely. Here is the difference between you and me: you claim that YOU don't need a changelog because there are svn commits, so every people on earth just have to install svn or look at a slow websvn to see the changes, even those which are just oupsie! etc... me, who think that an average user of a lib should not need to install svn (or git or etc...) or use a slow websvn to look quickly at a changelog file. And I say that because it was in that very situation. You think only about yourself, i thnk about everyone. It takes time to write entries but i'm not lazy. I take that time, on my very limited free time. We are all talking about developers here. Mr. Joe Average user will not use unstable software from the control system, but the stable one released with the generated changelog, be it manually or automatically generated. i guess here's the difference. NEWs and ChangeLog are intended for digestion at release time - ie sit in the tarball. the person compiling it (not a developer - packager etc.) digests these. he may use them roe package update/release notes, to see if he still needs to apply dome bugfix patch etc. etc. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Thu, Sep 20, 2012 at 11:39 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 11:28 AM, David Seikel onef...@gmail.com wrote: On Thu, 20 Sep 2012 11:19:51 -0300 Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 4:11 AM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 8:28 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: ah, if only we could do changelogs sanely like every other changelog in the entire universe... i mentioned that several times: the moap tool 1) moap cl prep 2) you edit ChangeLog 3) moap cl ci that's all that's not sane neither. sane: before release you run a command once and only once to turn the commit messages into changelog entries. That only works if our commit messages are sane. I point to the commit that started this thread as an example. Though most are sane, so Most are insane, I'd say... and that's the first thing to fix svn log != ChangeLog. In svn log, you have every little change. In ChangeLog you only have a summary of the change that happen between revision - 1 and revision. No need to see all the little fix in the middle. Thinking that every commit should become a ChangeLog entry is insane. -- Cedric BAIL -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje
On Fri, Sep 21, 2012 at 2:26 AM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Sep 20, 2012 at 2:20 PM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Sep 20, 2012 at 6:27 PM, Eduardo Lima (Etrunko) ebl...@gmail.com wrote: that's what the commit message is for. When it does all automatically, then it's an option. did you look at the Evil's changeLog ? You'll see why the commit message is not sufficient If you are talking about the list of files changed, it is just plain useless. There is a --verbose option of svn log that will also output the changed files. you're stupid or what ? We are not talking about the content of a changelog but of its layout ! It seems everybody except you agree the ChangeLog file is just plain useless. No. That's not the case. Of course for developer that use all day long svn to work on it, ChangeLog is useless and a pain to maintain. But for release management, packager and developer that use our tarball. Dropping ChangeLog is just stupid. -- Cedric BAIL -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
Hi,
from the looks of this patch you can probably save yourself some time
and compares by checking for pl-u.ep-name at the beginning of this
hunk and skipping it entirely if it's NULL.
Regards,
Daniel Willmann
On 09/11/2012 09:15 AM, Enlightenment SVN wrote:
Log:
edje: don't strcmp ith NULL.
Author: cedric
Date: 2012-09-11 01:15:33 -0700 (Tue, 11 Sep 2012)
New Revision: 76449
Modified: trunk/edje/src/bin/edje_cc_out.c
===
--- trunk/edje/src/bin/edje_cc_out.c 2012-09-11 07:59:19 UTC (rev 76448)
+++ trunk/edje/src/bin/edje_cc_out.c 2012-09-11 08:15:33 UTC (rev 76449)
@@ -1881,27 +1881,32 @@
{
if (pl-u.ep-name) {
for (i = 0 ; i pc-programs.fnmatch_count ; i++)
{
- if (!strcmp(pl-u.ep-name, pc-programs.fnmatch[i]-name))
+ if (pl-u.ep-name pc-programs.fnmatch[i]-name
+ !strcmp(pl-u.ep-name, pc-programs.fnmatch[i]-name))
data_queue_anonymous_lookup(pc, pc-programs.fnmatch[i],
dest);
}
for (i = 0 ; i pc-programs.strcmp_count ; i++)
{
- if (!strcmp(pl-u.ep-name, pc-programs.strcmp[i]-name))
+ if (pl-u.ep-name pc-programs.strcmp[i]-name
+ !strcmp(pl-u.ep-name, pc-programs.strcmp[i]-name))
data_queue_anonymous_lookup(pc, pc-programs.strcmp[i],
dest);
}
for (i = 0 ; i pc-programs.strncmp_count ; i++)
{
- if (!strcmp(pl-u.ep-name, pc-programs.strncmp[i]-name))
+ if (pl-u.ep-name pc-programs.strncmp[i]-name
+ !strcmp(pl-u.ep-name, pc-programs.strncmp[i]-name))
data_queue_anonymous_lookup(pc, pc-programs.strncmp[i],
dest);
}
for (i = 0 ; i pc-programs.strrncmp_count ; i++)
{
- if (!strcmp(pl-u.ep-name,
pc-programs.strrncmp[i]-name))
+ if (pl-u.ep-name pc-programs.strrncmp[i]-name
+ !strcmp(pl-u.ep-name,
pc-programs.strrncmp[i]-name))
data_queue_anonymous_lookup(pc,
pc-programs.strrncmp[i], dest);
}
for (i = 0 ; i pc-programs.nocmp_count ; i++)
{
- if (!strcmp(pl-u.ep-name, pc-programs.nocmp[i]-name))
+ if (pl-u.ep-name pc-programs.nocmp[i]-name
+ !strcmp(pl-u.ep-name, pc-programs.nocmp[i]-name))
data_queue_anonymous_lookup(pc, pc-programs.nocmp[i],
dest);
}
}
}
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
daniel++
On Wed, Sep 12, 2012 at 9:36 AM, Daniel Willmann d.willm...@samsung.comwrote:
Hi,
from the looks of this patch you can probably save yourself some time
and compares by checking for pl-u.ep-name at the beginning of this
hunk and skipping it entirely if it's NULL.
Regards,
Daniel Willmann
On 09/11/2012 09:15 AM, Enlightenment SVN wrote:
Log:
edje: don't strcmp ith NULL.
Author: cedric
Date: 2012-09-11 01:15:33 -0700 (Tue, 11 Sep 2012)
New Revision: 76449
Modified: trunk/edje/src/bin/edje_cc_out.c
===
--- trunk/edje/src/bin/edje_cc_out.c 2012-09-11 07:59:19 UTC (rev 76448)
+++ trunk/edje/src/bin/edje_cc_out.c 2012-09-11 08:15:33 UTC (rev 76449)
@@ -1881,27 +1881,32 @@
{
if (pl-u.ep-name) {
for (i = 0 ; i pc-programs.fnmatch_count ; i++)
{
- if (!strcmp(pl-u.ep-name,
pc-programs.fnmatch[i]-name))
+ if (pl-u.ep-name pc-programs.fnmatch[i]-name
+ !strcmp(pl-u.ep-name,
pc-programs.fnmatch[i]-name))
data_queue_anonymous_lookup(pc,
pc-programs.fnmatch[i], dest);
}
for (i = 0 ; i pc-programs.strcmp_count ; i++)
{
- if (!strcmp(pl-u.ep-name,
pc-programs.strcmp[i]-name))
+ if (pl-u.ep-name pc-programs.strcmp[i]-name
+ !strcmp(pl-u.ep-name,
pc-programs.strcmp[i]-name))
data_queue_anonymous_lookup(pc,
pc-programs.strcmp[i], dest);
}
for (i = 0 ; i pc-programs.strncmp_count ; i++)
{
- if (!strcmp(pl-u.ep-name,
pc-programs.strncmp[i]-name))
+ if (pl-u.ep-name pc-programs.strncmp[i]-name
+ !strcmp(pl-u.ep-name,
pc-programs.strncmp[i]-name))
data_queue_anonymous_lookup(pc,
pc-programs.strncmp[i], dest);
}
for (i = 0 ; i pc-programs.strrncmp_count ; i++)
{
- if (!strcmp(pl-u.ep-name,
pc-programs.strrncmp[i]-name))
+ if (pl-u.ep-name pc-programs.strrncmp[i]-name
+ !strcmp(pl-u.ep-name,
pc-programs.strrncmp[i]-name))
data_queue_anonymous_lookup(pc,
pc-programs.strrncmp[i], dest);
}
for (i = 0 ; i pc-programs.nocmp_count ; i++)
{
- if (!strcmp(pl-u.ep-name,
pc-programs.nocmp[i]-name))
+ if (pl-u.ep-name pc-programs.nocmp[i]-name
+ !strcmp(pl-u.ep-name,
pc-programs.nocmp[i]-name))
data_queue_anonymous_lookup(pc,
pc-programs.nocmp[i], dest);
}
}
}
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Thanks. Great!
Now E17 works. Arggg NULL check!!!
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:05 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
edje: correct NULL check. Happy SeoZ :-)
Author: cedric
Date: 2012-09-06 03:05:34 -0700 (Thu, 06 Sep 2012)
New Revision: 76235
Trac: http://trac.enlightenment.org/e/changeset/76235
Modified:
trunk/edje/src/lib/edje_util.c
Modified: trunk/edje/src/lib/edje_util.c
===
--- trunk/edje/src/lib/edje_util.c 2012-09-06 10:01:44 UTC (rev 76234)
+++ trunk/edje/src/lib/edje_util.c 2012-09-06 10:05:34 UTC (rev 76235)
@@ -5083,9 +5083,7 @@
rp);
//If the map is enabled, uv should be updated when image size is changed.
- if (rp-swallowed_object
- evas_object_type_get(rp-swallowed_object)
- !strcmp(evas_object_type_get(rp-swallowed_object), image))
+ if (!strcmp(evas_object_type_get(rp-swallowed_object), image))
evas_object_event_callback_add(obj_swallow, EVAS_CALLBACK_IMAGE_RESIZE,
_edje_object_part_swallow_image_resize_cb,
rp);
@@ -5118,6 +5116,7 @@
void
_edje_real_part_swallow_clear(Edje_Real_Part *rp)
{
+ if (!rp-swallowed_object) return ;
evas_object_smart_member_del(rp-swallowed_object);
evas_object_event_callback_del_full(rp-swallowed_object,
EVAS_CALLBACK_DEL,
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
but we could found out the problem early.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seolt;seojuyu...@gmail.comgt;
To: lt;enlightenment-devel@lists.sourceforge.netgt;;
Cc: lt;enlightenment-...@lists.sourceforge.netgt;;
Sent: 2012-09-06 (목) 19:08:39
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Thanks. Great!
Now E17 works. Arggg NULL check!!!
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:05 PM, Enlightenment SVN
lt;no-replygt;@enlightenment.orggt; wrote:
gt; Log:
gt; edje: correct NULL check. Happy SeoZ :-)
gt;
gt;
gt; Author: cedric
gt; Date: 2012-09-06 03:05:34 -0700 (Thu, 06 Sep 2012)
gt; New Revision: 76235
gt; Trac: http://trac.enlightenment.org/e/changeset/76235
gt;
gt; Modified:
gt; trunk/edje/src/lib/edje_util.c
gt;
gt; Modified: trunk/edje/src/lib/edje_util.c
gt; ===
gt; --- trunk/edje/src/lib/edje_util.c 2012-09-06 10:01:44 UTC (rev 76234)
gt; +++ trunk/edje/src/lib/edje_util.c 2012-09-06 10:05:34 UTC (rev 76235)
gt; @@ -5083,9 +5083,7 @@
gt; rp);
gt;
gt; //If the map is enabled, uv should be updated when image size is
changed.
gt; - if (rp-gt;swallowed_object amp;amp;
gt; - evas_object_type_get(rp-gt;swallowed_object) amp;amp;
gt; - !strcmp(evas_object_type_get(rp-gt;swallowed_object), image))
gt; + if (!strcmp(evas_object_type_get(rp-gt;swallowed_object), image))
gt; evas_object_event_callback_add(obj_swallow,
EVAS_CALLBACK_IMAGE_RESIZE,
gt;
_edje_object_part_swallow_image_resize_cb,
gt; rp);
gt; @@ -5118,6 +5116,7 @@
gt; void
gt; _edje_real_part_swallow_clear(Edje_Real_Part *rp)
gt; {
gt; + if (!rp-gt;swallowed_object) return ;
gt; evas_object_smart_member_del(rp-gt;swallowed_object);
gt; evas_object_event_callback_del_full(rp-gt;swallowed_object,
gt; EVAS_CALLBACK_DEL,
gt;
gt;
gt;
--
gt; Live Security Virtual Conference
gt; Exclusive live event will cover all the ways today's security and
gt; threat landscape has changed and how IT managers can respond. Discussions
gt; will include endpoint security, mobile security and the latest in malware
gt; threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
gt; ___
gt; enlightenment-svn mailing list
gt; enlightenment-...@lists.sourceforge.net
gt; https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
the problem is that. it was not a small application crash.
my e17 is crashed.
for users, this is bad :(
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:13 PM, ChunEon Park her...@naver.com wrote:
but we could found out the problem early.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seolt;seojuyu...@gmail.comgt;
To: lt;enlightenment-devel@lists.sourceforge.netgt;;
Cc: lt;enlightenment-...@lists.sourceforge.netgt;;
Sent: 2012-09-06 (목) 19:08:39
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Thanks. Great!
Now E17 works. Arggg NULL check!!!
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:05 PM, Enlightenment SVN
lt;no-replygt;@enlightenment.orggt; wrote:
gt; Log:
gt; edje: correct NULL check. Happy SeoZ :-)
gt;
gt;
gt; Author: cedric
gt; Date: 2012-09-06 03:05:34 -0700 (Thu, 06 Sep 2012)
gt; New Revision: 76235
gt; Trac: http://trac.enlightenment.org/e/changeset/76235
gt;
gt; Modified:
gt; trunk/edje/src/lib/edje_util.c
gt;
gt; Modified: trunk/edje/src/lib/edje_util.c
gt; ===
gt; --- trunk/edje/src/lib/edje_util.c 2012-09-06 10:01:44 UTC (rev
76234)
gt; +++ trunk/edje/src/lib/edje_util.c 2012-09-06 10:05:34 UTC (rev
76235)
gt; @@ -5083,9 +5083,7 @@
gt; rp);
gt;
gt; //If the map is enabled, uv should be updated when image size is
changed.
gt; - if (rp-gt;swallowed_object amp;amp;
gt; - evas_object_type_get(rp-gt;swallowed_object) amp;amp;
gt; - !strcmp(evas_object_type_get(rp-gt;swallowed_object), image))
gt; + if (!strcmp(evas_object_type_get(rp-gt;swallowed_object), image))
gt; evas_object_event_callback_add(obj_swallow,
EVAS_CALLBACK_IMAGE_RESIZE,
gt;
_edje_object_part_swallow_image_resize_cb,
gt; rp);
gt; @@ -5118,6 +5116,7 @@
gt; void
gt; _edje_real_part_swallow_clear(Edje_Real_Part *rp)
gt; {
gt; + if (!rp-gt;swallowed_object) return ;
gt; evas_object_smart_member_del(rp-gt;swallowed_object);
gt; evas_object_event_callback_del_full(rp-gt;swallowed_object,
gt; EVAS_CALLBACK_DEL,
gt;
gt;
gt;
--
gt; Live Security Virtual Conference
gt; Exclusive live event will cover all the ways today's security and
gt; threat landscape has changed and how IT managers can respond. Discussions
gt; will include endpoint security, mobile security and the latest in malware
gt; threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
gt; ___
gt; enlightenment-svn mailing list
gt; enlightenment-...@lists.sourceforge.net
gt; https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Thanks to u,
The problem was found out early.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net;
Cc: enlightenment-...@lists.sourceforge.net;
Sent: 2012-09-06 (목) 19:15:48
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
the problem is that. it was not a small application crash.
my e17 is crashed.
for users, this is bad :(
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:13 PM, ChunEon Park hermet@naver.com wrote:
but we could found out the problem early.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: enlightenment-devel@lists.sourceforge.net;
Cc: enlightenment-...@lists.sourceforge.net;
Sent: 2012-09-06 (목) 19:08:39
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Thanks. Great!
Now E17 works. Arggg NULL check!!!
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:05 PM, Enlightenment SVN
no-reply@enlightenment.org wrote:
Log:
edje: correct NULL check. Happy SeoZ :-)
Author: cedric
Date: 2012-09-06 03:05:34 -0700 (Thu, 06 Sep 2012)
New Revision: 76235
Trac: http://trac.enlightenment.org/e/changeset/76235
Modified:
trunk/edje/src/lib/edje_util.c
Modified: trunk/edje/src/lib/edje_util.c
===
--- trunk/edje/src/lib/edje_util.c 2012-09-06 10:01:44 UTC (rev 76234)
+++ trunk/edje/src/lib/edje_util.c 2012-09-06 10:05:34 UTC (rev 76235)
@@ -5083,9 +5083,7 @@
rp);
//If the map is enabled, uv should be updated when image size is
changed.
- if (rp-swallowed_object
- evas_object_type_get(rp-swallowed_object)
- !strcmp(evas_object_type_get(rp-swallowed_object), image))
+ if (!strcmp(evas_object_type_get(rp-swallowed_object), image))
evas_object_event_callback_add(obj_swallow,
EVAS_CALLBACK_IMAGE_RESIZE,
_edje_object_part_swallow_image_resize_cb,
rp);
@@ -5118,6 +5116,7 @@
void
_edje_real_part_swallow_clear(Edje_Real_Part *rp)
{
+ if (!rp-swallowed_object) return ;
evas_object_smart_member_del(rp-swallowed_object);
evas_object_event_callback_del_full(rp-swallowed_object,
EVAS_CALLBACK_DEL,
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Yes in dev mode, we can fix it early by crashing it.
But I don't want to allow this kind of window manager crash in a real product.
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:21 PM, ChunEon Park her...@naver.com wrote:
Thanks to u,
The problem was found out early.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net;
Cc: enlightenment-...@lists.sourceforge.net;
Sent: 2012-09-06 (목) 19:15:48
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
the problem is that. it was not a small application crash.
my e17 is crashed.
for users, this is bad :(
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:13 PM, ChunEon Park hermet@naver.com wrote:
but we could found out the problem early.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: enlightenment-devel@lists.sourceforge.net;
Cc: enlightenment-...@lists.sourceforge.net;
Sent: 2012-09-06 (목) 19:08:39
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Thanks. Great!
Now E17 works. Arggg NULL check!!!
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:05 PM, Enlightenment SVN
no-reply@enlightenment.org wrote:
Log:
edje: correct NULL check. Happy SeoZ :-)
Author: cedric
Date: 2012-09-06 03:05:34 -0700 (Thu, 06 Sep 2012)
New Revision: 76235
Trac: http://trac.enlightenment.org/e/changeset/76235
Modified:
trunk/edje/src/lib/edje_util.c
Modified: trunk/edje/src/lib/edje_util.c
===
--- trunk/edje/src/lib/edje_util.c 2012-09-06 10:01:44 UTC (rev 76234)
+++ trunk/edje/src/lib/edje_util.c 2012-09-06 10:05:34 UTC (rev 76235)
@@ -5083,9 +5083,7 @@
rp);
//If the map is enabled, uv should be updated when image size is
changed.
- if (rp-swallowed_object
- evas_object_type_get(rp-swallowed_object)
- !strcmp(evas_object_type_get(rp-swallowed_object), image))
+ if (!strcmp(evas_object_type_get(rp-swallowed_object), image))
evas_object_event_callback_add(obj_swallow,
EVAS_CALLBACK_IMAGE_RESIZE,
_edje_object_part_swallow_image_resize_cb,
rp);
@@ -5118,6 +5116,7 @@
void
_edje_real_part_swallow_clear(Edje_Real_Part *rp)
{
+ if (!rp-swallowed_object) return ;
evas_object_smart_member_del(rp-swallowed_object);
evas_object_event_callback_del_full(rp-swallowed_object,
EVAS_CALLBACK_DEL,
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
I am serious.
It was horrible experience as a user.
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:25 PM, Daniel Juyung Seo seojuyu...@gmail.com wrote:
Yes in dev mode, we can fix it early by crashing it.
But I don't want to allow this kind of window manager crash in a real product.
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:21 PM, ChunEon Park her...@naver.com wrote:
Thanks to u,
The problem was found out early.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: Enlightenment developer
listenlightenment-devel@lists.sourceforge.net;
Cc: enlightenment-...@lists.sourceforge.net;
Sent: 2012-09-06 (목) 19:15:48
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
the problem is that. it was not a small application crash.
my e17 is crashed.
for users, this is bad :(
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:13 PM, ChunEon Park hermet@naver.com wrote:
but we could found out the problem early.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: enlightenment-devel@lists.sourceforge.net;
Cc: enlightenment-...@lists.sourceforge.net;
Sent: 2012-09-06 (목) 19:08:39
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Thanks. Great!
Now E17 works. Arggg NULL check!!!
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:05 PM, Enlightenment SVN
no-reply@enlightenment.org wrote:
Log:
edje: correct NULL check. Happy SeoZ :-)
Author: cedric
Date: 2012-09-06 03:05:34 -0700 (Thu, 06 Sep 2012)
New Revision: 76235
Trac: http://trac.enlightenment.org/e/changeset/76235
Modified:
trunk/edje/src/lib/edje_util.c
Modified: trunk/edje/src/lib/edje_util.c
===
--- trunk/edje/src/lib/edje_util.c 2012-09-06 10:01:44 UTC (rev
76234)
+++ trunk/edje/src/lib/edje_util.c 2012-09-06 10:05:34 UTC (rev
76235)
@@ -5083,9 +5083,7 @@
rp);
//If the map is enabled, uv should be updated when image size is
changed.
- if (rp-swallowed_object
- evas_object_type_get(rp-swallowed_object)
- !strcmp(evas_object_type_get(rp-swallowed_object), image))
+ if (!strcmp(evas_object_type_get(rp-swallowed_object), image))
evas_object_event_callback_add(obj_swallow,
EVAS_CALLBACK_IMAGE_RESIZE,
_edje_object_part_swallow_image_resize_cb,
rp);
@@ -5118,6 +5116,7 @@
void
_edje_real_part_swallow_clear(Edje_Real_Part *rp)
{
+ if (!rp-swallowed_object) return ;
evas_object_smart_member_del(rp-swallowed_object);
evas_object_event_callback_del_full(rp-swallowed_object,
EVAS_CALLBACK_DEL,
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
If you hope that, then fix all the bugs and incorrect logics before releasing
real product.
NULL check doesn't mean the above things.
By NULL checking, the real product would have potential disasters which were
not found in development process.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net;
Cc: enlightenment-...@lists.sourceforge.net;
Sent: 2012-09-06 (목) 19:25:16
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Yes in dev mode, we can fix it early by crashing it.
But I don't want to allow this kind of window manager crash in a real product.
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:21 PM, ChunEon Park hermet@naver.com wrote:
Thanks to u,
The problem was found out early.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyung2@gmail.com
To: Enlightenment developer
listenlightenment-devel@lists.sourceforge.net;
Cc: enlightenment-svn@lists.sourceforge.net;
Sent: 2012-09-06 (목) 19:15:48
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
the problem is that. it was not a small application crash.
my e17 is crashed.
for users, this is bad :(
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:13 PM, ChunEon Park hermet@naver.com wrote:
but we could found out the problem early.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyung2@gmail.com
To: enlightenment-devel@lists.sourceforge.net;
Cc: enlightenment-svn@lists.sourceforge.net;
Sent: 2012-09-06 (목) 19:08:39
Subject: Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Thanks. Great!
Now E17 works. Arggg NULL check!!!
Daniel Juyung Seo (SeoZ)
On Thu, Sep 6, 2012 at 7:05 PM, Enlightenment SVN
no-reply@enlightenment.org wrote:
Log:
edje: correct NULL check. Happy SeoZ :-)
Author: cedric
Date: 2012-09-06 03:05:34 -0700 (Thu, 06 Sep 2012)
New Revision: 76235
Trac: http://trac.enlightenment.org/e/changeset/76235
Modified:
trunk/edje/src/lib/edje_util.c
Modified: trunk/edje/src/lib/edje_util.c
===
--- trunk/edje/src/lib/edje_util.c 2012-09-06 10:01:44 UTC (rev 76234)
+++ trunk/edje/src/lib/edje_util.c 2012-09-06 10:05:34 UTC (rev 76235)
@@ -5083,9 +5083,7 @@
rp);
//If the map is enabled, uv should be updated when image size is
changed.
- if (rp-swallowed_object
- evas_object_type_get(rp-swallowed_object)
- !strcmp(evas_object_type_get(rp-swallowed_object), image))
+ if (!strcmp(evas_object_type_get(rp-swallowed_object), image))
evas_object_event_callback_add(obj_swallow,
EVAS_CALLBACK_IMAGE_RESIZE,
_edje_object_part_swallow_image_resize_cb,
rp);
@@ -5118,6 +5116,7 @@
void
_edje_real_part_swallow_clear(Edje_Real_Part *rp)
{
+ if (!rp-swallowed_object) return ;
evas_object_smart_member_del(rp-swallowed_object);
evas_object_event_callback_del_full(rp-swallowed_object,
EVAS_CALLBACK_DEL,
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
oops, sorry :)
2012/6/24 Enlightenment SVN no-re...@enlightenment.org
Log:
edje: Resistance is futile. The B0rk.
Author: cedric
Date: 2012-06-23 23:01:12 -0700 (Sat, 23 Jun 2012)
New Revision: 72754
Trac: http://trac.enlightenment.org/e/changeset/72754
Modified:
trunk/edje/src/bin/edje_cc_out.c
Modified: trunk/edje/src/bin/edje_cc_out.c
===
--- trunk/edje/src/bin/edje_cc_out.c2012-06-24 05:35:49 UTC (rev 72753)
+++ trunk/edje/src/bin/edje_cc_out.c2012-06-24 06:01:12 UTC (rev 72754)
@@ -2144,15 +2144,15 @@
}
else
{
- char *aliased;
- aliased = eina_hash_find(part-pc-aliased, part-name);
- if (!aliased)
- aliased = part-name;
+ char *alias;
+ alias = eina_hash_find(part-pc-alias, part-name);
+ if (!alias)
+ alias = part-name;
for (i = 0; i part-pc-parts_count; ++i)
{
ep = part-pc-parts[i];
- if ((ep-name) (!strcmp(ep-name, aliased)))
+ if ((ep-name) (!strcmp(ep-name, alias)))
{
handle_slave_lookup(part_slave_lookups, part-dest,
ep-id);
*(part-dest) = ep-id;
@@ -2162,8 +2162,8 @@
if (i == part-pc-parts_count)
{
- ERR(%s: Error. Unable to find part name \%s\.,
- progname, part-name);
+ ERR(%s: Error. Unable to find part name \%s\ needed
in group '%s'.,
+ progname, alias, part-pc-part);
exit(-1);
}
}
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Michaël Bouchaud (yoz) y...@efl.so
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
2012/1/23 Enlightenment SVN no-re...@enlightenment.org:
Log:
edje: detect when we try to inherit from ourself.
Author: cedric
Date: 2012-01-23 07:45:12 -0800 (Mon, 23 Jan 2012)
New Revision: 67472
Trac: http://trac.enlightenment.org/e/changeset/67472
Modified:
trunk/edje/src/bin/edje_cc_handlers.c
Modified: trunk/edje/src/bin/edje_cc_handlers.c
===
--- trunk/edje/src/bin/edje_cc_handlers.c 2012-01-23 15:17:16 UTC (rev
67471)
+++ trunk/edje/src/bin/edje_cc_handlers.c 2012-01-23 15:45:12 UTC (rev
67472)
@@ -2242,6 +2242,14 @@
progname, file_in, line - 1, parent_name);
exit(-1);
}
+ if (pc2 == pc)
+ {
+ ERR(%s: Error. parse error %s:%i. You are trying to inherit '%s'
from itself. That's not possible.
+ If there is another group of the same name, you want to inherit
from that group and have the
+ same name as that group, there is a trick ! Just put the
inherit before the directive that set
+ the name !, progname, file_in, line - 1, parent_name);
WHAT? Why would you do that? People goes all around fixing
shadowing of variables in the C code and now we are telling people
how to shadow Edje groups? Give me your phone number so I can
direct people asking how to fix the problems cause by this to talk
directly to you.
+ exit(-1);
+ }
if (pc2-data)
{
--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Mon, Jan 23, 2012 at 4:48 PM, Iván Briano (Sachiel)
sachi...@gmail.com wrote:
2012/1/23 Enlightenment SVN no-re...@enlightenment.org:
Log:
edje: detect when we try to inherit from ourself.
Author: cedric
Date: 2012-01-23 07:45:12 -0800 (Mon, 23 Jan 2012)
New Revision: 67472
Trac: http://trac.enlightenment.org/e/changeset/67472
Modified:
trunk/edje/src/bin/edje_cc_handlers.c
Modified: trunk/edje/src/bin/edje_cc_handlers.c
===
--- trunk/edje/src/bin/edje_cc_handlers.c 2012-01-23 15:17:16 UTC (rev
67471)
+++ trunk/edje/src/bin/edje_cc_handlers.c 2012-01-23 15:45:12 UTC (rev
67472)
@@ -2242,6 +2242,14 @@
progname, file_in, line - 1, parent_name);
exit(-1);
}
+ if (pc2 == pc)
+ {
+ ERR(%s: Error. parse error %s:%i. You are trying to inherit '%s'
from itself. That's not possible.
+ If there is another group of the same name, you want to
inherit from that group and have the
+ same name as that group, there is a trick ! Just put the
inherit before the directive that set
+ the name !, progname, file_in, line - 1, parent_name);
WHAT? Why would you do that? People goes all around fixing
shadowing of variables in the C code and now we are telling people
how to shadow Edje groups? Give me your phone number so I can
direct people asking how to fix the problems cause by this to talk
directly to you.
Because we are crazy french ! More seriously, by doing this you can
just #include the original elementary theme and change some part in a
group without copying code. So a very small and easy to read new theme
that will be kept in sync with original one. As for my phone number, I
have not setup yet an over priced phone line, but as soon as I have, I
will happily give it :)
--
Cedric BAIL
--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
2012/1/23 Cedric BAIL cedric.b...@free.fr: Because we are crazy french ! More seriously, by doing this you can just #include the original elementary theme and change some part in a group without copying code. So a very small and easy to read new theme that will be kept in sync with original one. As for my phone number, I have not setup yet an over priced phone line, but as soon as I have, I will happily give it :) Valid use case but it still sounds like a hacky solution. Maybe once group inheritance is solid enough we can think of a less awful way to do this. -- Cedric BAIL -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Wed, Nov 30, 2011 at 3:48 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Sun, 27 Nov 2011 15:55:38 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: edje: major cleanup of map calc in edje, now done inside Edje_Calc_Param. NOTE: This was necessary for solving issue with the new CURRENT feature. I don't like this massive change, but there is no way around. This patch is only the first step, I will wait the full night before completly fixing the issue with CURRENT. WARNING: If this patch doesn't break svn, you must feel lucky and go play money games. In all other case, please report any issue to the developper mailing-list. Author: cedric Date: 2011-11-27 15:55:37 -0800 (Sun, 27 Nov 2011) New Revision: 65619 Trac: http://trac.enlightenment.org/e/changeset/65619 Modified: trunk/edje/src/lib/edje_calc.c trunk/edje/src/lib/edje_private.h this breaks compile without calc cache. please if you're going to break stuff, at least test compile with and without relevant options. Sorry it compile for me. Could you tell me the error message and your compile option ? -- Cedric BAIL -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Wed, 30 Nov 2011 10:50:13 +0100 Cedric BAIL cedric.b...@free.fr wrote: On Wed, Nov 30, 2011 at 3:48 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Sun, 27 Nov 2011 15:55:38 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: edje: major cleanup of map calc in edje, now done inside Edje_Calc_Param. NOTE: This was necessary for solving issue with the new CURRENT feature. I don't like this massive change, but there is no way around. This patch is only the first step, I will wait the full night before completly fixing the issue with CURRENT. WARNING: If this patch doesn't break svn, you must feel lucky and go play money games. In all other case, please report any issue to the developper mailing-list. Author: cedric Date: 2011-11-27 15:55:37 -0800 (Sun, 27 Nov 2011) New Revision: 65619 Trac: http://trac.enlightenment.org/e/changeset/65619 Modified: trunk/edje/src/lib/edje_calc.c trunk/edje/src/lib/edje_private.h this breaks compile without calc cache. please if you're going to break stuff, at least test compile with and without relevant options. Sorry it compile for me. Could you tell me the error message and your compile option ? edje_calc.c: In function '_edje_part_recalc': edje_calc.c:2314: error: 'Edje_Real_Part' has no member named 'invalidate' edje_calc.c:2314: error: 'proxy_invalidate' undeclared (first use in this function) edje_calc.c:2314: error: (Each undeclared identifier is reported only once edje_calc.c:2314: error: for each function it appears in.) --disable-calc-cache -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Wed, 30 Nov 2011 11:58:11 +0100 Cedric BAIL cedric.b...@free.fr wrote: On Wed, Nov 30, 2011 at 11:18 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Wed, 30 Nov 2011 10:50:13 +0100 Cedric BAIL cedric.b...@free.fr wrote: On Wed, Nov 30, 2011 at 3:48 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Sun, 27 Nov 2011 15:55:38 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: edje: major cleanup of map calc in edje, now done inside Edje_Calc_Param. NOTE: This was necessary for solving issue with the new CURRENT feature. I don't like this massive change, but there is no way around. This patch is only the first step, I will wait the full night before completly fixing the issue with CURRENT. WARNING: If this patch doesn't break svn, you must feel lucky and go play money games. In all other case, please report any issue to the developper mailing-list. Author: cedric Date: 2011-11-27 15:55:37 -0800 (Sun, 27 Nov 2011) New Revision: 65619 Trac: http://trac.enlightenment.org/e/changeset/65619 Modified: trunk/edje/src/lib/edje_calc.c trunk/edje/src/lib/edje_private.h this breaks compile without calc cache. please if you're going to break stuff, at least test compile with and without relevant options. Sorry it compile for me. Could you tell me the error message and your compile option ? edje_calc.c: In function '_edje_part_recalc': edje_calc.c:2314: error: 'Edje_Real_Part' has no member named 'invalidate' edje_calc.c:2314: error: 'proxy_invalidate' undeclared (first use in this function) edje_calc.c:2314: error: (Each undeclared identifier is reported only once edje_calc.c:2314: error: for each function it appears in.) Fixed in svn. --disable-calc-cache I didn't remember we turned on by default the calc cache. That's interesting. me neither. hooray for it being on though! :) -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Wed, 30 Nov 2011 06:01:02 -0500 Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Wed, 30 Nov 2011 11:58:11 +0100 Cedric BAIL cedric.b...@free.fr wrote: On Wed, Nov 30, 2011 at 11:18 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Wed, 30 Nov 2011 10:50:13 +0100 Cedric BAIL cedric.b...@free.fr wrote: On Wed, Nov 30, 2011 at 3:48 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Sun, 27 Nov 2011 15:55:38 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: edje: major cleanup of map calc in edje, now done inside Edje_Calc_Param. NOTE: This was necessary for solving issue with the new CURRENT feature. I don't like this massive change, but there is no way around. This patch is only the first step, I will wait the full night before completly fixing the issue with CURRENT. WARNING: If this patch doesn't break svn, you must feel lucky and go play money games. In all other case, please report any issue to the developper mailing-list. Author: cedric Date: 2011-11-27 15:55:37 -0800 (Sun, 27 Nov 2011) New Revision: 65619 Trac: http://trac.enlightenment.org/e/changeset/65619 Modified: trunk/edje/src/lib/edje_calc.c trunk/edje/src/lib/edje_private.h this breaks compile without calc cache. please if you're going to break stuff, at least test compile with and without relevant options. Sorry it compile for me. Could you tell me the error message and your compile option ? edje_calc.c: In function '_edje_part_recalc': edje_calc.c:2314: error: 'Edje_Real_Part' has no member named 'invalidate' edje_calc.c:2314: error: 'proxy_invalidate' undeclared (first use in this function) edje_calc.c:2314: error: (Each undeclared identifier is reported only once edje_calc.c:2314: error: for each function it appears in.) Fixed in svn. --disable-calc-cache I didn't remember we turned on by default the calc cache. That's interesting. me neither. hooray for it being on though! :) I guess this is the cache thingy you were telling me to turn on? Yeah, I already had it turned on. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Sun, 27 Nov 2011 15:55:38 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: edje: major cleanup of map calc in edje, now done inside Edje_Calc_Param. NOTE: This was necessary for solving issue with the new CURRENT feature. I don't like this massive change, but there is no way around. This patch is only the first step, I will wait the full night before completly fixing the issue with CURRENT. WARNING: If this patch doesn't break svn, you must feel lucky and go play money games. In all other case, please report any issue to the developper mailing-list. Author: cedric Date: 2011-11-27 15:55:37 -0800 (Sun, 27 Nov 2011) New Revision: 65619 Trac: http://trac.enlightenment.org/e/changeset/65619 Modified: trunk/edje/src/lib/edje_calc.c trunk/edje/src/lib/edje_private.h this breaks compile without calc cache. please if you're going to break stuff, at least test compile with and without relevant options. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Mon, Nov 28, 2011 at 6:20 AM, Carsten Haitzler ras...@rasterman.com wrote: On Sun, 27 Nov 2011 15:55:38 -0800 Enlightenment SVN no-re...@enlightenment.org said: Log: edje: major cleanup of map calc in edje, now done inside Edje_Calc_Param. NOTE: This was necessary for solving issue with the new CURRENT feature. I don't like this massive change, but there is no way around. This patch is only the first step, I will wait the full night before completly fixing the issue with CURRENT. WARNING: If this patch doesn't break svn, you must feel lucky and go play money games. In all other case, please report any issue to the developper mailing-list. Author: cedric Date: 2011-11-27 15:55:37 -0800 (Sun, 27 Nov 2011) New Revision: 65619 Trac: http://trac.enlightenment.org/e/changeset/65619 this broke cpufreq dials broke map in edje... :( Damn, I just saw it this morning ! I didn't notice that before, grumbl :'( Looking at it ! -- Cedric BAIL -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Sun, 27 Nov 2011 15:55:38 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: edje: major cleanup of map calc in edje, now done inside Edje_Calc_Param. NOTE: This was necessary for solving issue with the new CURRENT feature. I don't like this massive change, but there is no way around. This patch is only the first step, I will wait the full night before completly fixing the issue with CURRENT. WARNING: If this patch doesn't break svn, you must feel lucky and go play money games. In all other case, please report any issue to the developper mailing-list. Author: cedric Date: 2011-11-27 15:55:37 -0800 (Sun, 27 Nov 2011) New Revision: 65619 Trac: http://trac.enlightenment.org/e/changeset/65619 Modified: trunk/edje/src/lib/edje_calc.c trunk/edje/src/lib/edje_private.h oh good we haven't had any commits like this in a while. I was thinking that you'd lost your touch -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Sun, 27 Nov 2011 15:55:38 -0800 Enlightenment SVN no-re...@enlightenment.org said: Log: edje: major cleanup of map calc in edje, now done inside Edje_Calc_Param. NOTE: This was necessary for solving issue with the new CURRENT feature. I don't like this massive change, but there is no way around. This patch is only the first step, I will wait the full night before completly fixing the issue with CURRENT. WARNING: If this patch doesn't break svn, you must feel lucky and go play money games. In all other case, please report any issue to the developper mailing-list. Author: cedric Date: 2011-11-27 15:55:37 -0800 (Sun, 27 Nov 2011) New Revision: 65619 Trac: http://trac.enlightenment.org/e/changeset/65619 this broke cpufreq dials broke map in edje... :( -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Sun, 20 Nov 2011 06:15:37 -0800 Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
edje: remove warning when building without Ecore_IMF.
Author: cedric
Date: 2011-11-20 06:15:37 -0800 (Sun, 20 Nov 2011)
New Revision: 65440
Trac: http://trac.enlightenment.org/e/changeset/65440
Modified:
trunk/edje/src/lib/edje_entry.c
Modified: trunk/edje/src/lib/edje_entry.c
===
--- trunk/edje/src/lib/edje_entry.c 2011-11-20 14:11:50 UTC
(rev 65439) +++ trunk/edje/src/lib/edje_entry.c 2011-11-20
14:15:37 UTC (rev 65440) @@ -1508,9 +1508,9 @@
_edje_key_up_cb(void *data, Evas *e __UNUSED__, Evas_Object *obj
__UNUSED__, void *event_info) {
Edje *ed = data;
- Evas_Event_Key_Up *ev = event_info;
Edje_Real_Part *rp = ed-focused_part;
Entry *en;
+
if (!rp) return;
en = rp-entry_data;
if ((!en) || (rp-part-type != EDJE_PART_TYPE_TEXTBLOCK) ||
@@ -1520,13 +1520,17 @@
#ifdef HAVE_ECORE_IMF
if (en-imf_context)
{
+Evas_Event_Key_Up *ev = event_info;
Ecore_IMF_Event_Key_Up ecore_ev;
+
ecore_imf_evas_event_key_up_wrap(ev, ecore_ev);
if (ecore_imf_context_filter_event(en-imf_context,
ECORE_IMF_EVENT_KEY_UP,
(Ecore_IMF_Event
*)ecore_ev)) return;
}
+#else
+ (void) event_info;
#endif
}
@@ -2057,9 +2061,9 @@
ecore_imf_context_input_mode_set(en-imf_context,
rp-part-entry_mode ==
EDJE_ENTRY_EDIT_MODE_PASSWORD ? ECORE_IMF_INPUT_MODE_INVISIBLE :
ECORE_IMF_INPUT_MODE_FULL);
+done:
#endif
}
-done:
en-cursor = (Evas_Textblock_Cursor
*)evas_object_textblock_cursor_get(rp-object); }
Think you just broke it here.
edje_entry.c: In function ‘_edje_entry_real_part_init’:
edje_entry.c:2064: error: label at end of compound statement
--
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
signature.asc
Description: PGP signature
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
backport to 1.0 ?
On Sun, 14 Aug 2011, Enlightenment SVN wrote:
Log:
edje: fix cache and proxy.
Author: cedric
Date: 2011-08-14 14:55:31 -0700 (Sun, 14 Aug 2011)
New Revision: 62464
Trac: http://trac.enlightenment.org/e/changeset/62464
Modified:
trunk/edje/src/lib/edje_calc.c
Modified: trunk/edje/src/lib/edje_calc.c
===
--- trunk/edje/src/lib/edje_calc.c2011-08-14 21:47:17 UTC (rev 62463)
+++ trunk/edje/src/lib/edje_calc.c2011-08-14 21:55:31 UTC (rev 62464)
@@ -1948,6 +1948,7 @@
_edje_part_recalc(Edje *ed, Edje_Real_Part *ep, int flags)
{
#ifdef EDJE_CALC_CACHE
+ Eina_Bool proxy_invalidate = EINA_FALSE;
int state1 = -1;
int state2 = -1;
int statec = -1;
@@ -2101,6 +2102,24 @@
return;
}
+ if (ep-part-type == EDJE_PART_TYPE_PROXY)
+ {
+Edje_Real_Part *pp;
+int part_id;
+
+if (pos = 0.5)
+ part_id = ((Edje_Part_Description_Proxy*)
ep-param2-description)-proxy.id;
+else
+ part_id = ((Edje_Part_Description_Proxy*) chosen_desc)-proxy.id;
+pp = ed-table_parts[part_id % ed-table_parts_size];
+#ifdef EDJE_CALC_CACHE
+if (pp-invalidate)
+ proxy_invalidate = EINA_TRUE;
+#endif
+
+if (!pp-calculated) _edje_part_recalc(ed, ep, flags);
+ }
+
#ifndef EDJE_CALC_CACHE
p1 = lp1;
#else
@@ -2114,6 +2133,7 @@
ep-invalidate ||
state1 = ep-param1.state ||
statec = ep-param1.state ||
+proxy_invalidate ||
((ep-part-type == EDJE_PART_TYPE_TEXT || ep-part-type ==
EDJE_PART_TYPE_TEXTBLOCK) ed-text_part_change))
#endif
{
@@ -2143,6 +2163,7 @@
ep-invalidate ||
state2 = ep-param2-state ||
statec = ep-param2-state ||
+proxy_invalidate ||
((ep-part-type == EDJE_PART_TYPE_TEXT || ep-part-type ==
EDJE_PART_TYPE_TEXTBLOCK) ed-text_part_change))
#endif
{
--
FREE DOWNLOAD - uberSVN with Social Coding for Subversion.
Subversion made easy with a complete admin console. Easy
to use, easy to manage, easy to install, easy to extend.
Get a Free download of the new open ALM Subversion platform now.
http://p.sf.net/sfu/wandisco-dev2dev
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
uberSVN's rich system and user administration capabilities and model
configuration take the hassle out of deploying and managing Subversion and
the tools developers use with it. Learn more about uberSVN and get a free
download at: http://p.sf.net/sfu/wandisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Wed, 22 Jun 2011 07:51:53 -0700 Enlightenment SVN
no-re...@enlightenment.org said:
so... what about colorclasses? they probably have the same problems as the last
2 textclass commit fixes. :)
Log:
edje: fix huge memory leak.
Author: cedric
Date: 2011-06-22 07:51:53 -0700 (Wed, 22 Jun 2011)
New Revision: 60593
Trac: http://trac.enlightenment.org/e/changeset/60593
Modified:
trunk/edje/src/lib/edje_main.c trunk/edje/src/lib/edje_private.h
trunk/edje/src/lib/edje_util.c
Modified: trunk/edje/src/lib/edje_main.c
===
--- trunk/edje/src/lib/edje_main.c2011-06-22 14:04:09 UTC (rev 60592)
+++ trunk/edje/src/lib/edje_main.c2011-06-22 14:51:53 UTC (rev 60593)
@@ -150,7 +150,7 @@
_text_class_member_free(const Eina_Hash *hash __UNUSED__,
const void *key,
void *data,
- void *fdata)
+ void *fdata __UNUSED__)
{
_edje_text_class_member_direct_del(key, data);
return EINA_TRUE;
Modified: trunk/edje/src/lib/edje_private.h
===
--- trunk/edje/src/lib/edje_private.h 2011-06-22 14:04:09 UTC (rev
60592) +++ trunk/edje/src/lib/edje_private.h 2011-06-22 14:51:53 UTC
(rev 60593) @@ -1545,7 +1545,7 @@
Edje_Text_Class *_edje_text_class_find(Edje *ed, const char *text_class);
void _edje_text_class_member_add(Edje *ed, const char
*text_class); void _edje_text_class_member_del(Edje *ed, const
char *text_class); -void _edje_text_class_member_direct_del
(const char *text_class, Eina_List *lookup); +void
_edje_text_class_member_direct_del(const char *text_class, void *lookup);
void _edje_text_class_members_free(void); void
_edje_text_class_hash_free(void);
Modified: trunk/edje/src/lib/edje_util.c
===
--- trunk/edje/src/lib/edje_util.c2011-06-22 14:04:09 UTC (rev 60592)
+++ trunk/edje/src/lib/edje_util.c2011-06-22 14:51:53 UTC (rev 60593)
@@ -32,6 +32,14 @@
Eina_List *list;
};
+typedef struct _Edje_List_Refcount Edje_List_Refcount;
+struct _Edje_List_Refcount
+{
+ EINA_REFCOUNT;
+
+ Eina_List *lookup;
+};
+
static Eina_Bool _edje_color_class_list_foreach(const Eina_Hash *hash, const
void *key, void *data, void *fdata); static Eina_Bool
_edje_text_class_list_foreach(const Eina_Hash *hash, const void *key, void
*data, void *fdata); static void _edje_object_image_preload_cb(void *data,
Evas *e, Evas_Object *obj, void *event_info); @@ -3711,34 +3719,46 @@
void
_edje_text_class_member_direct_del(const char *text_class,
- Eina_List *lookup)
+ void *l)
{
+ Edje_List_Refcount *lookup = l;
Eina_List *members;
members = eina_hash_find(_edje_text_class_member_hash, text_class);
- members = eina_list_remove_list(members, lookup);
+ members = eina_list_remove_list(members, lookup-lookup);
eina_hash_set(_edje_text_class_member_hash, text_class, members);
+ free(lookup);
}
void
_edje_text_class_member_add(Edje *ed, const char *text_class)
{
+ Edje_List_Refcount *lookup;
Eina_List *members;
if ((!ed) || (!text_class)) return;
+ lookup = eina_hash_find(ed-members, text_class);
+ if (lookup)
+ {
+EINA_REFCOUNT_REF(lookup);
+return;
+ }
+
+ lookup = malloc(sizeof (Edje_List_Refcount));
+ if (!lookup) return ;
+ EINA_REFCOUNT_INIT(lookup);
+
/* Get members list */
members = eina_hash_find(_edje_text_class_member_hash, text_class);
/* Update the member list */
- members = eina_list_prepend(members, ed);
- if (eina_list_count(members) 5)
- printf(ERROR. CEDRIC BROKE ME! I NOW LEAK TEXTCLASSES\n);
+ lookup-lookup = members = eina_list_prepend(members, ed);
/* Don't loose track of members list */
if (!ed-members)
ed-members = eina_hash_string_small_new(NULL);
- eina_hash_set(ed-members, text_class, members);
+ eina_hash_add(ed-members, text_class, lookup);
/* Reset the member list to the right pointer */
if (!_edje_text_class_member_hash)
@@ -3749,21 +3769,24 @@
void
_edje_text_class_member_del(Edje *ed, const char *text_class)
{
+ Edje_List_Refcount *lookup;
Eina_List *members;
- Eina_List *lookup;
if ((!ed) || (!text_class)) return;
members = eina_hash_find(_edje_text_class_member_hash, text_class);
if (!members) return;
lookup = eina_hash_find(ed-members, text_class);
-
if (!lookup) return ;
- eina_hash_del(ed-members, text_class, lookup);
- members = eina_list_remove_list(members, lookup);
+ EINA_REFCOUNT_UNREF(lookup)
+ {
+ members = eina_list_remove_list(members,
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
This patch broke everything.
If the signal is o*bj[id]:signal*.
Elementary is waiting *[id]:signal* and this patch provides *signal *which
is not enough. Elm need the* id.*
I do not know what cedric was trying to do and he is at holidays for 2
weeks.
I think we should revert it.
2010/11/30 Enlightenment SVN no-re...@enlightenment.org
Log:
* edje: the most simple and usefull case of alias convertion
wasn't implemented at all. Should be working now, please test
all your code that relly on part1:part2[index]:sig behaviour.
Author: cedric
Date: 2010-11-30 05:09:03 -0800 (Tue, 30 Nov 2010)
New Revision: 55086
Trac: http://trac.enlightenment.org/e/changeset/55086
Modified:
trunk/edje/src/lib/edje_program.c
Modified: trunk/edje/src/lib/edje_program.c
===
--- trunk/edje/src/lib/edje_program.c 2010-11-30 12:59:08 UTC (rev 55085)
+++ trunk/edje/src/lib/edje_program.c 2010-11-30 13:09:03 UTC (rev 55086)
@@ -1001,83 +1001,61 @@
if (ed-delete_me) return;
- sep = strchr(sig, EDJE_PART_PATH_SEPARATOR);
+ sep = strrchr(sig, EDJE_PART_PATH_SEPARATOR);
/* If we are not sending the signal to a part of the child, the
* signal if for ourself
*/
if (sep)
{
-char *idx, *newsig;
+Edje_Real_Part *rp;
+char *newsig;
size_t length;
char *part;
-unsigned int i;
-/* the signal contains a colon, split the signal into
part:signal,
- * and deliver it to part (if there is a GROUP or EXTERNAL part
named part)
+/* the signal contains a colon, split the signal into
parts:signal,
+ * use _edje_real_part_recursive_get_helper to find the real part.
*/
length = strlen(sig) + 1;
part = alloca(length);
memcpy(part, sig, length);
-/* The part contain a [index], retrieve it */
-idx = strchr(sig, EDJE_PART_PATH_SEPARATOR_INDEXL);
-if (!idx || sep idx) newsig = part + (sep - sig);
-else newsig = part + (idx - sig);
+newsig = part + (sep - sig);
*newsig = '\0';
newsig++;
-for (i = 0; i ed-table_parts_size; i++)
+rp = _edje_real_part_recursive_get(ed, part);
+if (rp rp-part)
{
- Edje_Real_Part *rp = ed-table_parts[i];
- if rp-part-type == EDJE_PART_TYPE_GROUP
-|| rp-part-type == EDJE_PART_TYPE_EXTERNAL)
-(rp-swallowed_object))
- || rp-part-type == EDJE_PART_TYPE_BOX ||
rp-part-type == EDJE_PART_TYPE_TABLE)
- (rp-part) (rp-part-name)
- (strcmp(rp-part-name, part) == 0))
+ switch (rp-part-type)
{
- if (rp-part-type == EDJE_PART_TYPE_GROUP)
-{
- Edje *ed2 = _edje_fetch(rp-swallowed_object);
- if (ed2) _edje_emit(ed2, newsig, src);
- return; /* stop processing.
-* XXX maybe let signal be processed
anyway?
-* XXX in this case, just comment this line
-*/
-}
- else if (rp-part-type == EDJE_PART_TYPE_EXTERNAL)
-{
- _edje_external_signal_emit(rp-swallowed_object,
newsig, src);
- return;
-}
- else if (rp-part-type == EDJE_PART_TYPE_BOX
- || rp-part-type == EDJE_PART_TYPE_TABLE)
-{
- const char *partid;
- Evas_Object *child;
- Edje *ed2 = NULL;
+case EDJE_PART_TYPE_GROUP:
+ {
+ Edje *ed2;
- idx = strchr(newsig,
EDJE_PART_PATH_SEPARATOR_INDEXR);
+ if (!rp-swallowed_object) break ;
- if (!idx) return ;
- if (idx[1] != ':') return ;
- if (!rp-object) return;
+ ed2 = _edje_fetch(rp-swallowed_object);
+ if (ed2) _edje_emit(ed2, newsig, src);
+ return; /* stop processing.
+ * XXX maybe let signal be processed anyway?
+ * XXX in this case, just comment this line
+ */
+ }
+case EDJE_PART_TYPE_EXTERNAL:
+ {
+ if (!rp-swallowed_object) break ;
- partid = newsig;
- newsig = idx;
-
- *newsig = '\0';
- newsig += 2; /* we jump over ']' and ':' */
-
-
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Sat, Dec 4, 2010 at 2:13 AM, Carsten Haitzler ras...@rasterman.com wrote: On Fri, 3 Dec 2010 18:47:38 +0100 (CET) Vincent Torri vto...@univ-evry.fr said: On Fri, 3 Dec 2010, Cedric BAIL wrote: On Fri, Dec 3, 2010 at 5:57 PM, Vincent Torri vto...@univ-evry.fr wrote: On Fri, 3 Dec 2010, Enlightenment SVN wrote: Log: * edje: improve portability and simplify code. + snprintf(buf, sizeof(buf), %s -I%s %s -E -o %s - %s, + getenv(CC) ? getenv(CC) : cc, inc, def, tmpn, file_in); ret = system(buf); shouldn't you also pass -x c to force the language (gcc can rely on the file extension to select the No need as I pass it using redirection instead of directly the filename. That was to avoid complexifying the command line. language) and -std=c99 to be sure to remove the c++ comments ? Good question, don't know if it will be supported by other compiler than gcc. What's your opinion ? sun (oracle) compiler: -xc99 (no -std option) icc: -std=c99 x86 open64 (amd) : -std=c99 vc++ (cl.exe): i don't know so maybe try first with -std=c99 ; if the command fails, try with -xc99 I don't know other interesting compiler actually... this brings up a bit of an issue. using cpp/cc/gcc to handle #includes and macros and #ifdefs and so on was a handy idea... but it creates a LOT of problems in the maintainability and portability of edje_cc due to relying on a nebulous cpp that may or may not behave as we expect. i'm thinking post 1.0 a lot of these features should go into edje_cc itself. being able to do includes and macros - maybe we can do much more intelligent macros that are able to understand the rest of the edc syntax and model. As Vincent said I would like in the futur to remove that dependency with cpp as it is a hell to make it portable. And by the mean time we could also add loop support and other usefull stuff that cpp is lacking for our use. But as always, it will require some time to be able to do it :-) -- Cedric BAIL -- What happens now with your Lotus Notes apps - do you make another costly upgrade, or settle for being marooned without product support? Time to move off Lotus Notes and onto the cloud with Force.com, apps are easier to build, use, and manage than apps on traditional platforms. Sign up for the Lotus Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Fri, 3 Dec 2010, Enlightenment SVN wrote: Log: * edje: improve portability and simplify code. + snprintf(buf, sizeof(buf), %s -I%s %s -E -o %s - %s, + getenv(CC) ? getenv(CC) : cc, inc, def, tmpn, file_in); ret = system(buf); shouldn't you also pass -x c to force the language (gcc can rely on the file extension to select the language) and -std=c99 to be sure to remove the c++ comments ? Vincent -- Increase Visibility of Your 3D Game App Earn a Chance To Win $500! Tap into the largest installed PC base get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Fri, Dec 3, 2010 at 5:57 PM, Vincent Torri vto...@univ-evry.fr wrote: On Fri, 3 Dec 2010, Enlightenment SVN wrote: Log: * edje: improve portability and simplify code. + snprintf(buf, sizeof(buf), %s -I%s %s -E -o %s - %s, + getenv(CC) ? getenv(CC) : cc, inc, def, tmpn, file_in); ret = system(buf); shouldn't you also pass -x c to force the language (gcc can rely on the file extension to select the No need as I pass it using redirection instead of directly the filename. That was to avoid complexifying the command line. language) and -std=c99 to be sure to remove the c++ comments ? Good question, don't know if it will be supported by other compiler than gcc. What's your opinion ? -- Cedric BAIL -- Increase Visibility of Your 3D Game App Earn a Chance To Win $500! Tap into the largest installed PC base get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Fri, 3 Dec 2010, Cedric BAIL wrote: On Fri, Dec 3, 2010 at 5:57 PM, Vincent Torri vto...@univ-evry.fr wrote: On Fri, 3 Dec 2010, Enlightenment SVN wrote: Log: * edje: improve portability and simplify code. + snprintf(buf, sizeof(buf), %s -I%s %s -E -o %s - %s, + getenv(CC) ? getenv(CC) : cc, inc, def, tmpn, file_in); ret = system(buf); shouldn't you also pass -x c to force the language (gcc can rely on the file extension to select the No need as I pass it using redirection instead of directly the filename. That was to avoid complexifying the command line. language) and -std=c99 to be sure to remove the c++ comments ? Good question, don't know if it will be supported by other compiler than gcc. What's your opinion ? sun (oracle) compiler: -xc99 (no -std option) icc: -std=c99 x86 open64 (amd) : -std=c99 vc++ (cl.exe): i don't know so maybe try first with -std=c99 ; if the command fails, try with -xc99 I don't know other interesting compiler Vincent-- Increase Visibility of Your 3D Game App Earn a Chance To Win $500! Tap into the largest installed PC base get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Fri, Dec 3, 2010 at 4:21 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
* edje: SPANK ! SPANK ! SPANK !
fprintf should always specify a format.
Author: cedric
Date: 2010-12-03 10:21:56 -0800 (Fri, 03 Dec 2010)
New Revision: 55213
Trac: http://trac.enlightenment.org/e/changeset/55213
Modified:
trunk/edje/src/lib/edje_edit.c
Modified: trunk/edje/src/lib/edje_edit.c
===
--- trunk/edje/src/lib/edje_edit.c 2010-12-03 18:12:19 UTC (rev 55212)
+++ trunk/edje/src/lib/edje_edit.c 2010-12-03 18:21:56 UTC (rev 55213)
@@ -6357,7 +6357,7 @@
success = EINA_FALSE;
}
else
- fprintf(f, eed-embryo_processed);
+ fprintf(f, %s, eed-embryo_processed);
}
it = eina_hash_iterator_data_new(eed-program_scripts);
@@ -6384,7 +6384,7 @@
continue;
}
fprintf(f, public _p%i(sig[], src[]) {\n, ps-id);
- fprintf(f, ps-processed);
+ fprintf(f, %s, ps-processed);
although GCC is smart and it shouldn't matter much, you should
actually call fputs() :-) (gcc should do it automatically)
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Increase Visibility of Your 3D Game App Earn a Chance To Win $500!
Tap into the largest installed PC base get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Fri, 3 Dec 2010 18:47:38 +0100 (CET) Vincent Torri vto...@univ-evry.fr said: On Fri, 3 Dec 2010, Cedric BAIL wrote: On Fri, Dec 3, 2010 at 5:57 PM, Vincent Torri vto...@univ-evry.fr wrote: On Fri, 3 Dec 2010, Enlightenment SVN wrote: Log: * edje: improve portability and simplify code. + snprintf(buf, sizeof(buf), %s -I%s %s -E -o %s - %s, + getenv(CC) ? getenv(CC) : cc, inc, def, tmpn, file_in); ret = system(buf); shouldn't you also pass -x c to force the language (gcc can rely on the file extension to select the No need as I pass it using redirection instead of directly the filename. That was to avoid complexifying the command line. language) and -std=c99 to be sure to remove the c++ comments ? Good question, don't know if it will be supported by other compiler than gcc. What's your opinion ? sun (oracle) compiler: -xc99 (no -std option) icc: -std=c99 x86 open64 (amd) : -std=c99 vc++ (cl.exe): i don't know so maybe try first with -std=c99 ; if the command fails, try with -xc99 I don't know other interesting compiler actually... this brings up a bit of an issue. using cpp/cc/gcc to handle #includes and macros and #ifdefs and so on was a handy idea... but it creates a LOT of problems in the maintainability and portability of edje_cc due to relying on a nebulous cpp that may or may not behave as we expect. i'm thinking post 1.0 a lot of these features should go into edje_cc itself. being able to do includes and macros - maybe we can do much more intelligent macros that are able to understand the rest of the edc syntax and model. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- What happens now with your Lotus Notes apps - do you make another costly upgrade, or settle for being marooned without product support? Time to move off Lotus Notes and onto the cloud with Force.com, apps are easier to build, use, and manage than apps on traditional platforms. Sign up for the Lotus Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Sat, 4 Dec 2010, Carsten Haitzler (The Rasterman) wrote: On Fri, 3 Dec 2010 18:47:38 +0100 (CET) Vincent Torri vto...@univ-evry.fr said: On Fri, 3 Dec 2010, Cedric BAIL wrote: On Fri, Dec 3, 2010 at 5:57 PM, Vincent Torri vto...@univ-evry.fr wrote: On Fri, 3 Dec 2010, Enlightenment SVN wrote: Log: * edje: improve portability and simplify code. + snprintf(buf, sizeof(buf), %s -I%s %s -E -o %s - %s, + getenv(CC) ? getenv(CC) : cc, inc, def, tmpn, file_in); ret = system(buf); shouldn't you also pass -x c to force the language (gcc can rely on the file extension to select the No need as I pass it using redirection instead of directly the filename. That was to avoid complexifying the command line. language) and -std=c99 to be sure to remove the c++ comments ? Good question, don't know if it will be supported by other compiler than gcc. What's your opinion ? sun (oracle) compiler: -xc99 (no -std option) icc: -std=c99 x86 open64 (amd) : -std=c99 vc++ (cl.exe): i don't know so maybe try first with -std=c99 ; if the command fails, try with -xc99 I don't know other interesting compiler actually... this brings up a bit of an issue. using cpp/cc/gcc to handle #includes and macros and #ifdefs and so on was a handy idea... but it creates a LOT of problems in the maintainability and portability of edje_cc due to relying on a nebulous cpp that may or may not behave as we expect. i'm thinking post 1.0 a lot of these features should go into edje_cc itself. being able to do includes and macros - maybe we can do much more intelligent macros that are able to understand the rest of the edc syntax and model. cedric had the same kind of idea, actually (writing a specific preprocessor for edc syntax). Vincent-- What happens now with your Lotus Notes apps - do you make another costly upgrade, or settle for being marooned without product support? Time to move off Lotus Notes and onto the cloud with Force.com, apps are easier to build, use, and manage than apps on traditional platforms. Sign up for the Lotus Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Sat, 4 Dec 2010 07:39:42 +0100 (CET) Vincent Torri vto...@univ-evry.fr said: actually... this brings up a bit of an issue. using cpp/cc/gcc to handle #includes and macros and #ifdefs and so on was a handy idea... but it #creates a LOT of problems in the maintainability and portability of edje_cc due to relying on a nebulous cpp that may or may not behave as we expect. i'm thinking post 1.0 a lot of these features should go into edje_cc itself. being able to do includes and macros - maybe we can do much more intelligent macros that are able to understand the rest of the edc syntax and model. cedric had the same kind of idea, actually (writing a specific preprocessor for edc syntax). great minds think :) -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- What happens now with your Lotus Notes apps - do you make another costly upgrade, or settle for being marooned without product support? Time to move off Lotus Notes and onto the cloud with Force.com, apps are easier to build, use, and manage than apps on traditional platforms. Sign up for the Lotus Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Mon, Oct 4, 2010 at 6:35 AM, Daniel Juyung Seo seojuyu...@gmail.com wrote: Hello, this is Daniel Juyung Seo. I have a question about below commit. It looks like the statement is trying to avoid argc == 2. Why 'argc 2 || argc 2' was used instead of 'argc != 2' ? Any reasons? Maybe it was too early in the morning. Duno why I wrote this that way. -- Cedric BAIL -- Virtualization is moving to the mainstream and overtaking non-virtualized environment for deploying applications. Does it make network security easier or more difficult to achieve? Read this whitepaper to separate the two and get a better understanding. http://p.sf.net/sfu/hp-phase2-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
Hello, this is Daniel Juyung Seo.
I have a question about below commit.
It looks like the statement is trying to avoid argc == 2.
Why 'argc 2 || argc 2' was used instead of 'argc != 2' ?
Any reasons?
Thank you.
Best Regards,
Daniel Juyung Seo.
On Mon, Aug 23, 2010 at 11:44 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
* edje: prevent segv when no param is given to edje_convert.
Author: cedric
Date: 2010-08-23 07:44:04 -0700 (Mon, 23 Aug 2010)
New Revision: 51575
Modified:
trunk/edje/src/bin/edje_convert_main.c
Modified: trunk/edje/src/bin/edje_convert_main.c
===
--- trunk/edje/src/bin/edje_convert_main.c 2010-08-23 14:27:50 UTC (rev
51574)
+++ trunk/edje/src/bin/edje_convert_main.c 2010-08-23 14:44:04 UTC (rev
51575)
@@ -128,7 +128,7 @@
eet_init();
progname = argv[0];
- if (argc 2 || !strcmp(argv[1], -h))
+ if (argc 2 || argc 2 || !strcmp(argv[1], -h))
{
main_help();
return 0;
--
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Virtualization is moving to the mainstream and overtaking non-virtualized
environment for deploying applications. Does it make network security
easier or more difficult to achieve? Read this whitepaper to separate the
two and get a better understanding.
http://p.sf.net/sfu/hp-phase2-d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Thu, 3 Jun 2010 07:26:43 +0200 (CEST) Vincent Torri vto...@univ-evry.fr wrote: On Thu, 3 Jun 2010, Carsten Haitzler (The Rasterman) wrote: On Wed, 2 Jun 2010 20:24:28 +0200 (CEST) Vincent Torri vto...@univ-evry.fr said: all other callback adds use const void *data - and that's correct as it means the add doesnt do anything to what data points to (doesn't modify) but the callback itself that is passed this pointer gets void * as the callback can modiy what it points to. but it breaks the 'const' chain. In that case, there is no interest of using any const pointers (for me).I like the C++ way of using const: if you pass a const pointer, at some point, you are sure that is it never modified later. Unfortunately C doesn't have the correct way to describe what we are after (this call won't modify the data, but you can do what you want to it, since it's yours). If we really really wanted to preserve appropriate const attributes we'd need two versions of each function: one for const data, and one for non-const, and even then it would fail to indicate EFL doesn't modify the data. Note the C standard library has _exactly_ the same problem. [I'm sure either the c89 or c99 rational document described this, but I can't find it anywhere - maybe a defect notice] Examples: char *strstr(const char *, const char *); Which returns you a non const version of the const paramater, so C (and C++) programmers should be aware of the problem. And since the users of the library then DON'T need to cast their modifiable data or the unmodifiable data (as long as their types are correct), it's all fine. Regards, nash -- ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Tue, 1 Jun 2010, Enlightenment SVN wrote:
Log:
* edje: fix constness warning.
Author: cedric
Date: 2010-06-01 07:35:19 -0700 (Tue, 01 Jun 2010)
New Revision: 49372
Modified:
trunk/edje/src/lib/edje_util.c
Modified: trunk/edje/src/lib/edje_util.c
===
--- trunk/edje/src/lib/edje_util.c2010-06-01 14:26:09 UTC (rev 49371)
+++ trunk/edje/src/lib/edje_util.c2010-06-01 14:35:19 UTC (rev 49372)
@@ -2136,7 +2136,7 @@
cb = calloc(1, sizeof(Edje_Text_Insert_Filter_Callback));
cb-part = eina_stringshare_add(part);
cb-func = func;
- cb-data = data;
+ cb-data = (void*) data;
wouldn't it be better to change
edje_object_text_insert_filter_callback_add() so that data is just a void
*
Indeed, if data is const void *, you alert the user that data will *not*
be modified. But the callback says that it can modify it.
Imho, what is currently done is not good
Also, it's (void *) and not (void*) :p
Vincent
ed-text_insert_filter_callbacks =
eina_list_append(ed-text_insert_filter_callbacks, cb);
}
@@ -2152,7 +2152,7 @@
if ((!ed) || (!part)) return;
EINA_LIST_FOREACH(ed-text_insert_filter_callbacks, l, cb)
{
-if ((!strcmp(cb-part, part)) (cb-func == func))
+if ((!strcmp(cb-part, part)) (cb-func == func) (cb-data ==
data))
{
ed-text_insert_filter_callbacks =
eina_list_remove_list(ed-text_insert_filter_callbacks, l);
--
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Wed, 2 Jun 2010 20:24:28 +0200 (CEST) Vincent Torri vto...@univ-evry.fr
said:
all other callback adds use const void *data - and that's correct as it means
the add doesnt do anything to what data points to (doesn't modify) but the
callback itself that is passed this pointer gets void * as the callback can
modiy what it points to.
On Tue, 1 Jun 2010, Enlightenment SVN wrote:
Log:
* edje: fix constness warning.
Author: cedric
Date: 2010-06-01 07:35:19 -0700 (Tue, 01 Jun 2010)
New Revision: 49372
Modified:
trunk/edje/src/lib/edje_util.c
Modified: trunk/edje/src/lib/edje_util.c
===
--- trunk/edje/src/lib/edje_util.c 2010-06-01 14:26:09 UTC (rev
49371) +++ trunk/edje/src/lib/edje_util.c 2010-06-01 14:35:19 UTC
(rev 49372) @@ -2136,7 +2136,7 @@
cb = calloc(1, sizeof(Edje_Text_Insert_Filter_Callback));
cb-part = eina_stringshare_add(part);
cb-func = func;
- cb-data = data;
+ cb-data = (void*) data;
wouldn't it be better to change
edje_object_text_insert_filter_callback_add() so that data is just a void
*
Indeed, if data is const void *, you alert the user that data will *not*
be modified. But the callback says that it can modify it.
Imho, what is currently done is not good
Also, it's (void *) and not (void*) :p
Vincent
ed-text_insert_filter_callbacks =
eina_list_append(ed-text_insert_filter_callbacks, cb);
}
@@ -2152,7 +2152,7 @@
if ((!ed) || (!part)) return;
EINA_LIST_FOREACH(ed-text_insert_filter_callbacks, l, cb)
{
-if ((!strcmp(cb-part, part)) (cb-func == func))
+if ((!strcmp(cb-part, part)) (cb-func == func) (cb-data
== data)) {
ed-text_insert_filter_callbacks =
eina_list_remove_list(ed-text_insert_filter_callbacks, l);
--
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Thu, 3 Jun 2010, Carsten Haitzler (The Rasterman) wrote:
On Wed, 2 Jun 2010 20:24:28 +0200 (CEST) Vincent Torri vto...@univ-evry.fr
said:
all other callback adds use const void *data - and that's correct as it means
the add doesnt do anything to what data points to (doesn't modify) but the
callback itself that is passed this pointer gets void * as the callback can
modiy what it points to.
but it breaks the 'const' chain. In that case, there is no interest of
using any const pointers (for me).I like the C++ way of using const: if
you pass a const pointer, at some point, you are sure that is it never
modified later.
Vincent
On Tue, 1 Jun 2010, Enlightenment SVN wrote:
Log:
* edje: fix constness warning.
Author: cedric
Date: 2010-06-01 07:35:19 -0700 (Tue, 01 Jun 2010)
New Revision: 49372
Modified:
trunk/edje/src/lib/edje_util.c
Modified: trunk/edje/src/lib/edje_util.c
===
--- trunk/edje/src/lib/edje_util.c 2010-06-01 14:26:09 UTC (rev
49371) +++ trunk/edje/src/lib/edje_util.c 2010-06-01 14:35:19 UTC
(rev 49372) @@ -2136,7 +2136,7 @@
cb = calloc(1, sizeof(Edje_Text_Insert_Filter_Callback));
cb-part = eina_stringshare_add(part);
cb-func = func;
- cb-data = data;
+ cb-data = (void*) data;
wouldn't it be better to change
edje_object_text_insert_filter_callback_add() so that data is just a void
*
Indeed, if data is const void *, you alert the user that data will *not*
be modified. But the callback says that it can modify it.
Imho, what is currently done is not good
Also, it's (void *) and not (void*) :p
Vincent
ed-text_insert_filter_callbacks =
eina_list_append(ed-text_insert_filter_callbacks, cb);
}
@@ -2152,7 +2152,7 @@
if ((!ed) || (!part)) return;
EINA_LIST_FOREACH(ed-text_insert_filter_callbacks, l, cb)
{
-if ((!strcmp(cb-part, part)) (cb-func == func))
+if ((!strcmp(cb-part, part)) (cb-func == func) (cb-data
== data)) {
ed-text_insert_filter_callbacks =
eina_list_remove_list(ed-text_insert_filter_callbacks, l);
--
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Wed, 7 Oct 2009, Enlightenment SVN wrote: Log: * edje: Another round of llvm warning removal. Author: cedric Date: 2009-10-07 04:36:23 -0700 (Wed, 07 Oct 2009) New Revision: 42932 Modified: trunk/edje/src/lib/edje_edit.c trunk/edje/src/lib/edje_util.c Modified: trunk/edje/src/lib/edje_edit.c === --- trunk/edje/src/lib/edje_edit.c2009-10-07 11:27:15 UTC (rev 42931) +++ trunk/edje/src/lib/edje_edit.c2009-10-07 11:36:23 UTC (rev 42932) @@ -5378,7 +5378,7 @@ strcpy(tmpn, /tmp/edje_edit.edc-tmp-XX); if (!(fd = mkstemp(tmpn))) return NULL; printf(*** tmp file: %s\n, tmpn); - if (!(f = fopen(tmpn, w))) return NULL; + if (!(f = fdopen(fd, w))) return NULL; can you please use wb, for compatibility with Windows ? (i can't do that right now) Vincent -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Wed, Oct 7, 2009 at 1:45 PM, Vincent Torri vto...@univ-evry.fr wrote: On Wed, 7 Oct 2009, Enlightenment SVN wrote: Log: * edje: Another round of llvm warning removal. Author: cedric Date: 2009-10-07 04:36:23 -0700 (Wed, 07 Oct 2009) New Revision: 42932 Modified: trunk/edje/src/lib/edje_edit.c trunk/edje/src/lib/edje_util.c Modified: trunk/edje/src/lib/edje_edit.c === --- trunk/edje/src/lib/edje_edit.c 2009-10-07 11:27:15 UTC (rev 42931) +++ trunk/edje/src/lib/edje_edit.c 2009-10-07 11:36:23 UTC (rev 42932) @@ -5378,7 +5378,7 @@ strcpy(tmpn, /tmp/edje_edit.edc-tmp-XX); if (!(fd = mkstemp(tmpn))) return NULL; printf(*** tmp file: %s\n, tmpn); - if (!(f = fopen(tmpn, w))) return NULL; + if (!(f = fdopen(fd, w))) return NULL; can you please use wb, for compatibility with Windows ? (i can't do that right now) In svn, if you have time please take a look at this file, I saw other comment regarding code not working on windows. -- Cedric BAIL -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Mon, 10 Aug 2009 18:39:23 +0200 Cedric BAIL cedric.b...@free.fr said: On Mon, Aug 10, 2009 at 5:21 PM, Gustavo Sverzut Barbieribarbi...@profusion.mobi wrote: On Mon, Aug 10, 2009 at 6:56 AM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: * edje: Reduce sizeof (Edje_Calc_Params). Note: It doesn't really impact edje memory foot print yet. But in the plan to do a computation cache inside edje, this structure will be used a lot (I am planning to do this feature at some point, but no ETA yet, and be reassured it will be optionnal so we can choose between CPU load or memory load). Note: As I was looking for similar area of improvements, Edje_Part_Description could really use an union to reduce it's size, but as we load this structure directly from an Eet file, we need union in Eet first. And this should be part of a comming Edje file format break. Better than union is to have the single part in one structure and specific bits in their own structure. Depending on how we do the Eet + union support, we may think on how to do it to cover this case as well. I'd say instead of allocate memory and fill it, one could give a type value to user callback and then it would receive the correct Eet_Data_Descriptor for that subtype. So union would return the data descriptor with the same struct size for all types, while dynamic would check (switch/case) which one to use, and return the fields properly. This is likely to reduce memory consumption a lot because we often have LOTS of rectangle that have almost no field, while we have very few TEXT/TEXTBLOCK/GRADIENT that consume most memory. Hum, that's another possibility, this is almost like implementing some object inheritence support in eet. This could be much more efficient than using union, but only if type can't change, or you could be forced to reallocate another structure. But this seems more usefull than union for Edje. Will put this somewhere in the TODO :-) BTW, something that could improve memory there is using mempool. I don't really see how, what do you want to put inside this mempool (one per type of edje object ?) ? but Edje_Calc_Params is runtime - not in the .edj file :) no need to worry about eet here. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Mon, 10 Aug 2009 12:21:11 -0300 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: On Mon, Aug 10, 2009 at 6:56 AM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: * edje: Reduce sizeof (Edje_Calc_Params). Note: It doesn't really impact edje memory foot print yet. But in the plan to do a computation cache inside edje, this structure will be used a lot (I am planning to do this feature at some point, but no ETA yet, and be reassured it will be optionnal so we can choose between CPU load or memory load). Note: As I was looking for similar area of improvements, Edje_Part_Description could really use an union to reduce it's size, but as we load this structure directly from an Eet file, we need union in Eet first. And this should be part of a comming Edje file format break. Better than union is to have the single part in one structure and specific bits in their own structure. Depending on how we do the Eet + union support, we may think on how to do it to cover this case as well. I'd say instead of allocate memory and fill it, one could give a type value to user callback and then it would receive the correct Eet_Data_Descriptor for that subtype. So union would return the data descriptor with the same struct size for all types, while dynamic would check (switch/case) which one to use, and return the fields properly. This is likely to reduce memory consumption a lot because we often have LOTS of rectangle that have almost no field, while we have very few TEXT/TEXTBLOCK/GRADIENT that consume most memory. BTW, something that could improve memory there is using mempool. even mempool will fragment. it isnt necessarily a silver bullet. not allocating is better than anything else :) i am wondering if simple N structs with casting is best (and a common header in all for common members for all types). -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Sat, Aug 15, 2009 at 7:20 AM, Carsten Haitzlerras...@rasterman.com wrote: On Mon, 10 Aug 2009 12:21:11 -0300 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: On Mon, Aug 10, 2009 at 6:56 AM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: * edje: Reduce sizeof (Edje_Calc_Params). Note: It doesn't really impact edje memory foot print yet. But in the plan to do a computation cache inside edje, this structure will be used a lot (I am planning to do this feature at some point, but no ETA yet, and be reassured it will be optionnal so we can choose between CPU load or memory load). Note: As I was looking for similar area of improvements, Edje_Part_Description could really use an union to reduce it's size, but as we load this structure directly from an Eet file, we need union in Eet first. And this should be part of a comming Edje file format break. Better than union is to have the single part in one structure and specific bits in their own structure. Depending on how we do the Eet + union support, we may think on how to do it to cover this case as well. I'd say instead of allocate memory and fill it, one could give a type value to user callback and then it would receive the correct Eet_Data_Descriptor for that subtype. So union would return the data descriptor with the same struct size for all types, while dynamic would check (switch/case) which one to use, and return the fields properly. This is likely to reduce memory consumption a lot because we often have LOTS of rectangle that have almost no field, while we have very few TEXT/TEXTBLOCK/GRADIENT that consume most memory. BTW, something that could improve memory there is using mempool. even mempool will fragment. it isnt necessarily a silver bullet. not allocating is better than anything else :) i am wondering if simple N structs with casting is best (and a common header in all for common members for all types). Yes, and this is really the best solution BUT with current fscking huge code it's very hard to do. As I said to cedric, go and do a refactor to isolate parts dealing with common bits or specific (text, textblock) in separate functions, than errors will be harder to happen. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
Modified: trunk/edje/src/lib/edje_private.h
===
--- trunk/edje/src/lib/edje_private.h 2009-08-13 15:42:30 UTC (rev 41743)
+++ trunk/edje/src/lib/edje_private.h 2009-08-13 16:13:49 UTC (rev 41744)
@@ -740,7 +740,7 @@
int angle; // 4
int spread; // 4
} fill;
- Edje_Color color, color2, color3; // 12
+ Edje_Color color; // 4
union {
struct {
int l, r, t, b; // 16
@@ -749,12 +749,13 @@
Edje_Alignment align; /* text alignment within bounds */ // 16
double elipsis; // 8
intsize; // 4
- } text; // 28
+ Edje_Color color2, color3; // 8
+ } text; // 36
struct {
int id; // 4
char *type; // 4
} gradient; // 8
- } type; // 28
+ } type; // 36
unsigned charvisible : 1;
unsigned charsmooth : 1; // 4
}; // 116
note that on 64 bits computers, the size is bigger. Maybe one can put also
the size for that arch
Vincent
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Thu, Aug 13, 2009 at 07:10:06PM +0200, Vincent Torri wrote:
Modified: trunk/edje/src/lib/edje_private.h
===
--- trunk/edje/src/lib/edje_private.h 2009-08-13 15:42:30 UTC (rev
41743)
+++ trunk/edje/src/lib/edje_private.h 2009-08-13 16:13:49 UTC (rev
41744)
@@ -740,7 +740,7 @@
int angle; // 4
int spread; // 4
} fill;
- Edje_Color color, color2, color3; // 12
+ Edje_Color color; // 4
union {
struct {
int l, r, t, b; // 16
@@ -749,12 +749,13 @@
Edje_Alignment align; /* text alignment within bounds */ // 16
double elipsis; // 8
intsize; // 4
- } text; // 28
+Edje_Color color2, color3; // 8
+ } text; // 36
struct {
int id; // 4
char *type; // 4
} gradient; // 8
- } type; // 28
+ } type; // 36
unsigned charvisible : 1;
unsigned charsmooth : 1; // 4
}; // 116
note that on 64 bits computers, the size is bigger. Maybe one can put also
the size for that arch
Or use the types from stdint.h: eg, uint8_t, uint16_t, uint32_t, etc. Which
are not only more consistent, but also self-documenting.
pete
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Mon, Aug 10, 2009 at 6:56 AM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: * edje: Reduce sizeof (Edje_Calc_Params). Note: It doesn't really impact edje memory foot print yet. But in the plan to do a computation cache inside edje, this structure will be used a lot (I am planning to do this feature at some point, but no ETA yet, and be reassured it will be optionnal so we can choose between CPU load or memory load). Note: As I was looking for similar area of improvements, Edje_Part_Description could really use an union to reduce it's size, but as we load this structure directly from an Eet file, we need union in Eet first. And this should be part of a comming Edje file format break. Better than union is to have the single part in one structure and specific bits in their own structure. Depending on how we do the Eet + union support, we may think on how to do it to cover this case as well. I'd say instead of allocate memory and fill it, one could give a type value to user callback and then it would receive the correct Eet_Data_Descriptor for that subtype. So union would return the data descriptor with the same struct size for all types, while dynamic would check (switch/case) which one to use, and return the fields properly. This is likely to reduce memory consumption a lot because we often have LOTS of rectangle that have almost no field, while we have very few TEXT/TEXTBLOCK/GRADIENT that consume most memory. BTW, something that could improve memory there is using mempool. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Mon, Aug 10, 2009 at 5:21 PM, Gustavo Sverzut Barbieribarbi...@profusion.mobi wrote: On Mon, Aug 10, 2009 at 6:56 AM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: * edje: Reduce sizeof (Edje_Calc_Params). Note: It doesn't really impact edje memory foot print yet. But in the plan to do a computation cache inside edje, this structure will be used a lot (I am planning to do this feature at some point, but no ETA yet, and be reassured it will be optionnal so we can choose between CPU load or memory load). Note: As I was looking for similar area of improvements, Edje_Part_Description could really use an union to reduce it's size, but as we load this structure directly from an Eet file, we need union in Eet first. And this should be part of a comming Edje file format break. Better than union is to have the single part in one structure and specific bits in their own structure. Depending on how we do the Eet + union support, we may think on how to do it to cover this case as well. I'd say instead of allocate memory and fill it, one could give a type value to user callback and then it would receive the correct Eet_Data_Descriptor for that subtype. So union would return the data descriptor with the same struct size for all types, while dynamic would check (switch/case) which one to use, and return the fields properly. This is likely to reduce memory consumption a lot because we often have LOTS of rectangle that have almost no field, while we have very few TEXT/TEXTBLOCK/GRADIENT that consume most memory. Hum, that's another possibility, this is almost like implementing some object inheritence support in eet. This could be much more efficient than using union, but only if type can't change, or you could be forced to reallocate another structure. But this seems more usefull than union for Edje. Will put this somewhere in the TODO :-) BTW, something that could improve memory there is using mempool. I don't really see how, what do you want to put inside this mempool (one per type of edje object ?) ? -- Cedric BAIL -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/lib
On Mon, Aug 10, 2009 at 1:39 PM, Cedric BAILcedric.b...@free.fr wrote: On Mon, Aug 10, 2009 at 5:21 PM, Gustavo Sverzut Barbieribarbi...@profusion.mobi wrote: On Mon, Aug 10, 2009 at 6:56 AM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: * edje: Reduce sizeof (Edje_Calc_Params). Note: It doesn't really impact edje memory foot print yet. But in the plan to do a computation cache inside edje, this structure will be used a lot (I am planning to do this feature at some point, but no ETA yet, and be reassured it will be optionnal so we can choose between CPU load or memory load). Note: As I was looking for similar area of improvements, Edje_Part_Description could really use an union to reduce it's size, but as we load this structure directly from an Eet file, we need union in Eet first. And this should be part of a comming Edje file format break. Better than union is to have the single part in one structure and specific bits in their own structure. Depending on how we do the Eet + union support, we may think on how to do it to cover this case as well. I'd say instead of allocate memory and fill it, one could give a type value to user callback and then it would receive the correct Eet_Data_Descriptor for that subtype. So union would return the data descriptor with the same struct size for all types, while dynamic would check (switch/case) which one to use, and return the fields properly. This is likely to reduce memory consumption a lot because we often have LOTS of rectangle that have almost no field, while we have very few TEXT/TEXTBLOCK/GRADIENT that consume most memory. Hum, that's another possibility, this is almost like implementing some object inheritence support in eet. This could be much more efficient than using union, but only if type can't change, or you could be forced to reallocate another structure. But this seems more usefull than union for Edje. Will put this somewhere in the TODO :-) BTW, something that could improve memory there is using mempool. I don't really see how, what do you want to put inside this mempool (one per type of edje object ?) ? Edje_Part_Description is fixed size, would match perfectly fixed size mempool allocators. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
