[gwt-contrib] Re: Recent browser-specific change to JSONObject
Sending to the contributors mailing list.. --Sri 2009/11/17 Matt Bishop > I am referring to this recent checkin: > > > http://code.google.com/p/google-web-toolkit/source/diff?spec=svn6936&r=6936&format=side&path=/releases/2.0/user/src/com/google/gwt/json/client/JSONObject.java > > The checkin comment states the change is needed for Chrome, but it is > checked into the main JSONObject, not into a ChromeJSONObject. I > would expect it to be in a Chrome class because: > > 1. It would keep the generated code for non-Chrome browsers smaller. > 2. The change itself slows down non-Chrome browsers unnecessarily. > > JSONObject is a well-used object and it is important to keep it as > small and fast is humanly possible. > > -- > > You received this message because you are subscribed to the Google Groups > "Google Web Toolkit" group. > To post to this group, send email to google-web-tool...@googlegroups.com. > To unsubscribe from this group, send email to > google-web-toolkit+unsubscr...@googlegroups.com > . > For more options, visit this group at > http://groups.google.com/group/google-web-toolkit?hl=. > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Recent browser-specific change to JSONObject
The change was rolled back due to FF production mode issues, but will be added back in the future when those issues are corrected. However, since different browsers add different properties, I think iterating over the keys without checking hasOwnProperty is already broken. Also, JSONObject is essentially deprecated -- if you care about performance, you will write your own JavaScriptObject subclass and get zero overhead access to the JSON fields. On 11/17/09, Sripathi Krishnan wrote: > Sending to the contributors mailing list.. > > --Sri > > > 2009/11/17 Matt Bishop > >> I am referring to this recent checkin: >> >> >> http://code.google.com/p/google-web-toolkit/source/diff?spec=svn6936&r=6936&format=side&path=/releases/2.0/user/src/com/google/gwt/json/client/JSONObject.java >> >> The checkin comment states the change is needed for Chrome, but it is >> checked into the main JSONObject, not into a ChromeJSONObject. I >> would expect it to be in a Chrome class because: >> >> 1. It would keep the generated code for non-Chrome browsers smaller. >> 2. The change itself slows down non-Chrome browsers unnecessarily. >> >> JSONObject is a well-used object and it is important to keep it as >> small and fast is humanly possible. >> >> -- >> >> You received this message because you are subscribed to the Google Groups >> "Google Web Toolkit" group. >> To post to this group, send email to google-web-tool...@googlegroups.com. >> To unsubscribe from this group, send email to >> google-web-toolkit+unsubscr...@googlegroups.com >> . >> For more options, visit this group at >> http://groups.google.com/group/google-web-toolkit?hl=. >> >> >> > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on UsingOOPHM in google-web-toolkit
Comment by dusan.maliarik: @mark.renouf: Thanks Mark! You saved my day :) BTW have you seen nice new templates for SOYC? now we have yet another place for Google logo to creep on us For more information: http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6956 committed - Go back to outrageously long URL for IE, fix typo....
Revision: 6956
Author: j...@google.com
Date: Tue Nov 17 08:54:24 2009
Log: Go back to outrageously long URL for IE, fix typo.
Patch by: jat
Review by: cramsdale (TBR)
http://code.google.com/p/google-web-toolkit/source/detail?r=6956
Modified:
/trunk/plugins/MissingPlugin/war/MissingPlugin.html
/trunk/plugins/MissingPlugin/war/WEB-INF/appengine-web.xml
===
--- /trunk/plugins/MissingPlugin/war/MissingPlugin.html Mon Nov 16 17:08:00
2009
+++ /trunk/plugins/MissingPlugin/war/MissingPlugin.html Tue Nov 17 08:54:24
2009
@@ -85,7 +85,7 @@
"safari-win" :
{
-"caption" : "Sorry, there is currently no GWT Developer Plugin
for Safar on Windows",
+"caption" : "Sorry, there is currently no GWT Developer Plugin
for Safari on Windows",
"url" : troubleshootingUrl,
"supported" : false
},
@@ -101,7 +101,7 @@
"ie" :
{
"caption" : "Download the GWT Developer PluginFor Internet
Explorer",
-"url" :
"https://dl-ssl.google.com/gwt/plugins/ie/gwt-dev-plugin.exe";,
+"url" :
"https://dl-ssl.google.com/tag/s/appguid%3D%7B9a5e649a-ec63-4c7d-99bf-75adb345e7e5%7D%26lang%3Den%26appname%3DGWT%2520Developer%2520Plugin%2520for%2520IE%26needsadmin%3Dfalse/gwt/plugins/ie/GwtDevPluginSetup.exe";,
"platforms" : "Win x86",
"supported" : true
},
===
--- /trunk/plugins/MissingPlugin/war/WEB-INF/appengine-web.xml Mon Nov 16
17:14:30 2009
+++ /trunk/plugins/MissingPlugin/war/WEB-INF/appengine-web.xml Tue Nov 17
08:54:24 2009
@@ -1,7 +1,7 @@
http://appengine.google.com/ns/1.0";>
gwt-dev-plugin-missing
- 3
+ 4
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Cannot install gwt-dev-plugin.exe from gwt-dev-missing-plugin.appspot.com
Yes, we are aware of it and fixing it right now. In the meantime, you can use this outrageously long URL: https://dl-ssl.google.com/tag/s/appguid%3D%7B9a5e649a-ec63-4c7d-99bf-75adb345e7e5%7D%26lang%3Den%26appname%3DGWT%2520Developer%2520Plugin%2520for%2520IE%26needsadmin%3Dfalse/gwt/plugins/ie/GwtDevPluginSetup.exe On 11/17/09, Mark Renouf wrote: > All I get is a dialog box "Google Installer" / "Unknown Installer > Error" > > Windows XP SP3, IE7, VMware > > Screenshot: > http://google-web-toolkit-contributors.googlegroups.com/web/Screenshot-windows_xp_ie7.png?gsc=kDdB-AsAAADPmowlpgHeLooOj_z_2VOf > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Cannot install gwt-dev-plugin.exe from gwt-dev-missing-plugin.appspot.com
Oh, sorry... I *just* saw r6956. That worked. Thanks! On Nov 17, 12:05 pm, John Tamplin wrote: > Yes, we are aware of it and fixing it right now. > > In the meantime, you can use this outrageously long URL: > > https://dl-ssl.google.com/tag/s/appguid%3D%7B9a5e649a-ec63-4c7d-99bf-... > > On 11/17/09, Mark Renouf wrote: > > > All I get is a dialog box "Google Installer" / "Unknown Installer > > Error" > > > Windows XP SP3, IE7, VMware > > > Screenshot: > >http://google-web-toolkit-contributors.googlegroups.com/web/Screensho... > > > -- > >http://groups.google.com/group/Google-Web-Toolkit-Contributors > > -- > John A. Tamplin > Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix error starting up in DevMode+GAE
Reviewers: jat, scottb,
Description:
If a GC occurs during startup, the AbstractReferenceMap that maps from
the module name to its ModuleDef in ModuleDefLoader can be cleared.
When we attempt to reload the module, we cannot because we only have the
module's "effective name" (i.e., a short, lower-case name), whereas we
need its physical name (i.e., a fully-qualified class name) to perform
the load. This patch creates a separate effective-to-physical name
mapping so even if we lose the ModuleDef we retain the ability to reload
it based on the effective name.
Please review this at http://gwt-code-reviews.appspot.com/103801
Affected files:
dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java
Index: dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java
===
--- dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java(revision 6955)
+++ dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java(working copy)
@@ -28,6 +28,7 @@
import java.io.Reader;
import java.net.URISyntaxException;
import java.net.URL;
+import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
import java.util.Set;
@@ -60,11 +61,17 @@
/**
* Keep soft references to loaded modules so the VM can gc them when
memory is
- * tight.
+ * tight. The module's physical name is used as a key.
*/
@SuppressWarnings("unchecked")
private static final Map loadedModules = new
ReferenceMap(
AbstractReferenceMap.HARD, AbstractReferenceMap.SOFT);
+
+ /**
+ * A mapping from effective to physical module names.
+ */
+ private static final Map
moduleEffectiveNameToPhysicalName =
+new HashMap();
/**
* Creates a module in memory that is not associated with a
@@ -119,6 +126,12 @@
*/
public static ModuleDef loadFromClassPath(TreeLogger logger,
String moduleName, boolean refresh) throws UnableToCompleteException
{
+// Look up the module's physical name; if null, we are either
encountering
+// the module for the first time, or else the name is already physical
+String physicalName =
moduleEffectiveNameToPhysicalName.get(moduleName);
+if (physicalName != null) {
+ moduleName = physicalName;
+}
ModuleDef moduleDef = tryGetLoadedModule(logger, moduleName, refresh);
if (moduleDef != null) {
return moduleDef;
@@ -275,8 +288,8 @@
// Add the "physical" module name: com.google.Module
loadedModules.put(moduleName, moduleDef);
-// Add the module's effective name: some.other.Module
-loadedModules.put(moduleDef.getName(), moduleDef);
+// Add a maping from the module's effective name to its physical name
+moduleEffectiveNameToPhysicalName.put(moduleDef.getName(), moduleName);
return moduleDef;
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Cannot install gwt-dev-plugin.exe from gwt-dev-missing-plugin.appspot.com
And, by the way, a lot of this stuff is still in flux. If you're grabbing bits and pieces as they appear, you mileage is bound to vary widely :-) On Tue, Nov 17, 2009 at 12:20 PM, Mark Renouf wrote: > Oh, sorry... I *just* saw r6956. That worked. Thanks! > > On Nov 17, 12:05 pm, John Tamplin wrote: > > Yes, we are aware of it and fixing it right now. > > > > In the meantime, you can use this outrageously long URL: > > > > https://dl-ssl.google.com/tag/s/appguid%3D%7B9a5e649a-ec63-4c7d-99bf-... > > > > On 11/17/09, Mark Renouf wrote: > > > > > All I get is a dialog box "Google Installer" / "Unknown Installer > > > Error" > > > > > Windows XP SP3, IE7, VMware > > > > > Screenshot: > > >http://google-web-toolkit-contributors.googlegroups.com/web/Screensho. > .. > > > > > -- > > >http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > -- > > John A. Tamplin > > Software Engineer (GWT), Google > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6957 committed - Edited wiki page through web user interface.
Revision: 6957 Author: br...@google.com Date: Tue Nov 17 10:56:40 2009 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=6957 Modified: /wiki/GWT_2_0_RC.wiki === --- /wiki/GWT_2_0_RC.wiki Mon Nov 16 19:48:40 2009 +++ /wiki/GWT_2_0_RC.wiki Tue Nov 17 10:56:40 2009 @@ -2,19 +2,114 @@ = Getting Started with GWT 2.0 RC1 = + +Before using GWT 2.0 RC1, please understand that it is still a release candidate and will likely change before its official release. +We do not recommend using this release candidate build for production applications. + + This release contains big changes to improve developer productivity, make cross-browser development easier, and produce faster web applications. -=== Things that are changing with GWT 2.0 that might otherwise be confusing without explanation === - * Terminology changes: We're going to start using the term "development mode" rather than the old term "hosted mode." - * The term "hosted mode" was sometimes confusing to people, so we'll be using the more descriptive term "development mode" from now on. For similar reasons, we'll be using the term "production mode" rather than "web mode" when referring to compiled script. - * Changes to the distribution: Note that there's only one download, and it's no longer platform-specific. You download the same zip file for every development platform. This is made possible by the new plugin approach used to implement development mode (see below). The distribution file does not include the browser plugins themselves; those are downloaded separately the first time you use development mode in a browser that doesn't have the plugin installed. - -=== Major New Features === - * In-Browser Development Mode: Prior to 2.0, GWT hosted mode provided a special-purpose "hosted browser" to debug your GWT code. In 2.0, the web page being debugged is viewed within a regular-old browser. Development mode is supported through the use of a native-code plugin called the "Google Web Toolkit Developer Plugin" for many popular browsers. In other words, you can use development mode directly from Safari, Firefox, IE, and Chrome. - * Code Splitting: Developer-guided code splitting using GWT.runAsync(), along with compile reports (also known as http://code.google.com/events/io/2009/sessions/StoryCompilerGwtCompiler.html";>The Story of Your Compile) allows you to chunk your GWT code into multiple fragments for faster startup. Imagine having to download a whole movie before being able to watch it. Well, that's what you have to do with most Ajax apps these days -- download the whole thing before using it. With code splitting, you can arrange to load just the minimum script needed to get the application running and the user interacting, while the rest of the app is downloaded as needed. - * Declarative User Interface: GWT's http://google-web-toolkit.googlecode.com/svn/javadoc/2.0/com/google/gwt/uibinder/client/UiBinder.html";>!UiBinder now allows you to create user interfaces mostly declaratively. Previously, widgets had to be created and assembled programmatically, requiring lots of code. Now, you can use XML to declare your UI, making the code more readable, easier to maintain, and faster to develop. The Mail sample has been updated to show a practical example of using !UiBinder. - * Bundling of resources via http://google-web-toolkit.googlecode.com/svn/javadoc/2.0/com/google/gwt/resources/client/ClientBundle.html";>!ClientBundle. GWT introduced http://google-web-toolkit.googlecode.com/svn/javadoc/2.0/com/google/gwt/user/client/ui/ImageBundle.html";>!ImageBundle in 1.4 to provide automatic spriting of images. !ClientBundle generalizes this technique, bringing the power of combining and optimizing resources into one download to things like text files, CSS, and XML. This means fewer network round trips, which in turn can decrease application latency -- especially on mobile applications. - * Using !HtmlUnit for running test cases based on http://google-web-toolkit.googlecode.com/svn/javadoc/2.0/com/google/gwt/junit/client/GWTTestCase.html";>GWTTestCase: Prior to 2.0, GWTTestCase relied on SWT and native code versions of actual browsers to run unit tests. As a result, running unit tests required starting an actual browser. As of 2.0, GWTTestCase no longer uses SWT or native code. Instead, it uses !HtmlUnit as the built-in browser. Because !HtmlUnit is written entirely in the Java language, there is no longer any native code involved in typical test-driven development. Debugging GWT Tests in development mode can be done entirely in a Java debugger. +== Downloading and Installing GWT 2.0 RC1 SDK == +No installation process is required to use the GWT SDK; simply unzip it into any convenient directory. + + +http://google-web-toolkit.googlecode.com/fi
[gwt-contrib] Re: Fix error starting up in DevMode+GAE
As discussed FTF, I think a better plan is to pin the loaded modules in memory until they have been referenced at least once from a browser. Letting them be immediately unloaded before they are used and then reloading them seems inefficient and will annoy the user with duplicate warnings/errors from the module load. The downside of this approach is that any modules which are loaded but never referenced (such as from a launch config that is used for many different modules) will pin those modules in memory indefinitely, but I think that is the lesser evil. http://gwt-code-reviews.appspot.com/103801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Google Web Toolkit 2.0 RC1 Now Available
Hi folks! GWT 2.0 RC1 is now ready for you to try. The full documentation is still very much a work in progress, but you can at least start trying out the GWT SDK distribution and the Google Plugin for Eclipse using the following instructions: http://code.google.com/p/google-web-toolkit/wiki/GWT_2_0_RC GWT 2.0 is going to be a big release, so don't be surprised if there are a few bumps and surprises as we continue to finalize everything. Similarly, we would caution you against using GWT 2.0 RC1 in production. We are eager to get your feedback, both good and bad, in the Google Web Toolkit Developer Forum: http://groups.google.com/group/google-web-toolkit If you find specific bugs to report, please do so in the GWT Issue Tracker: http://code.google.com/p/google-web-toolkit/issues See you online. Happy coding :-) -- Bruce, on behalf of the GWT team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Google Web Toolkit 2.0 RC1 Now Available
Woo! Go team! I've been using MS2 on an old 1.4 app that I'm updating. Upgrade was smooth. New dev mode is great. Looking forward to trying RC1 now with the Eclipse plugin update. Thanks! On Tue, Nov 17, 2009 at 2:13 PM, Bruce Johnson wrote: > Hi folks! > GWT 2.0 RC1 is now ready for you to try. The full documentation is still > very much a work in progress, but you can at least start trying out the GWT > SDK distribution and the Google Plugin for Eclipse using the following > instructions: > http://code.google.com/p/google-web-toolkit/wiki/GWT_2_0_RC > GWT 2.0 is going to be a big release, so don't be surprised if there are a > few bumps and surprises as we continue to finalize everything. Similarly, we > would caution you against using GWT 2.0 RC1 in production. > We are eager to get your feedback, both good and bad, in the Google Web > Toolkit Developer Forum: > http://groups.google.com/group/google-web-toolkit > If you find specific bugs to report, please do so in the GWT Issue Tracker: > http://code.google.com/p/google-web-toolkit/issues > See you online. Happy coding :-) > -- Bruce, on behalf of the GWT team > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6958 committed - Noted the DevMode + GAE problem.
Revision: 6958
Author: rj...@google.com
Date: Tue Nov 17 11:29:08 2009
Log: Noted the DevMode + GAE problem.
http://code.google.com/p/google-web-toolkit/source/detail?r=6958
Modified:
/wiki/GWT_2_0_RC.wiki
===
--- /wiki/GWT_2_0_RC.wiki Tue Nov 17 10:56:40 2009
+++ /wiki/GWT_2_0_RC.wiki Tue Nov 17 11:29:08 2009
@@ -151,3 +151,6 @@
* !HtmlUnit does not attempt to emulate authentic browser layout.
Consequently, tests that are sensitive to browser layout are very likely to
fail. However, since GWTTestCase supports other methods of running tests,
such as Selenium, that do support accurate layout testing, it can still
make sense to keep layout-sensitive tests in the same test case as
non-layout-sensitive tests. If you want such tests to be ignored
by !HtmlUnit, simply annotate the test methods with
@!DoNotRunWith({Platform.!HtmlUnit}). Versions of Google Plugin for Eclipse
prior to 1.2 will only allow you to add GWT release directories that
include a file with a name like `gwt-dev-windows.jar`. You can fool it by
sym linking or copying gwt-dev.jar to the appropriate name.
* The way arguments are passed to the GWT testing infrastructure has
been revamped. There is now a consistent syntax to support arbitrary "run
styles", including user-written, with no changes to GWT itself. For
example, `-selenium FF3` has become `-runStyle selenium:FF3`. This change
likely does not affect typical test invocation scripts, but if you do use
`-Dgwt.args` to pass arguments to GWTTestCase, be aware that you may need
to make some changes.
* When using !ClientBundle, be aware that images using alpha
transparency do not appear transparent in IE6. The Mail sample application
included in the GWT distribution currently suffers from this limitation
(that is, the images have opaque backgrounds when viewed on IE6).
+ * Users of the Google Plugin for Eclipse that are running Google App
Engine projects in development mode may see errors like "Unable to find
+'myApp.gwt.xml' on your classpath; could be a typo, or maybe you
+forgot to include a classpath entry for source?". This is due to an
unfortunate interaction between weak references to module definitions and
garbage collection kicked off by the App Engine.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6959 committed - Formatting problem
Revision: 6959
Author: rj...@google.com
Date: Tue Nov 17 11:30:04 2009
Log: Formatting problem
http://code.google.com/p/google-web-toolkit/source/detail?r=6959
Modified:
/wiki/GWT_2_0_RC.wiki
===
--- /wiki/GWT_2_0_RC.wiki Tue Nov 17 11:29:08 2009
+++ /wiki/GWT_2_0_RC.wiki Tue Nov 17 11:30:04 2009
@@ -151,6 +151,4 @@
* !HtmlUnit does not attempt to emulate authentic browser layout.
Consequently, tests that are sensitive to browser layout are very likely to
fail. However, since GWTTestCase supports other methods of running tests,
such as Selenium, that do support accurate layout testing, it can still
make sense to keep layout-sensitive tests in the same test case as
non-layout-sensitive tests. If you want such tests to be ignored
by !HtmlUnit, simply annotate the test methods with
@!DoNotRunWith({Platform.!HtmlUnit}). Versions of Google Plugin for Eclipse
prior to 1.2 will only allow you to add GWT release directories that
include a file with a name like `gwt-dev-windows.jar`. You can fool it by
sym linking or copying gwt-dev.jar to the appropriate name.
* The way arguments are passed to the GWT testing infrastructure has
been revamped. There is now a consistent syntax to support arbitrary "run
styles", including user-written, with no changes to GWT itself. For
example, `-selenium FF3` has become `-runStyle selenium:FF3`. This change
likely does not affect typical test invocation scripts, but if you do use
`-Dgwt.args` to pass arguments to GWTTestCase, be aware that you may need
to make some changes.
* When using !ClientBundle, be aware that images using alpha
transparency do not appear transparent in IE6. The Mail sample application
included in the GWT distribution currently suffers from this limitation
(that is, the images have opaque backgrounds when viewed on IE6).
- * Users of the Google Plugin for Eclipse that are running Google App
Engine projects in development mode may see errors like "Unable to find
-'myApp.gwt.xml' on your classpath; could be a typo, or maybe you
-forgot to include a classpath entry for source?". This is due to an
unfortunate interaction between weak references to module definitions and
garbage collection kicked off by the App Engine.
+ * Users of the Google Plugin for Eclipse that are running Google App
Engine projects in development mode may see errors like "Unable to
find'myApp.gwt.xml' on your classpath; could be a typo, or maybe you forgot
to include a classpath entry for source?". This is due to an unfortunate
interaction between weak references to module definitions and garbage
collection kicked off by the App Engine.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6960 committed - Another bit of formatting
Revision: 6960
Author: rj...@google.com
Date: Tue Nov 17 11:31:29 2009
Log: Another bit of formatting
http://code.google.com/p/google-web-toolkit/source/detail?r=6960
Modified:
/wiki/GWT_2_0_RC.wiki
===
--- /wiki/GWT_2_0_RC.wiki Tue Nov 17 11:30:04 2009
+++ /wiki/GWT_2_0_RC.wiki Tue Nov 17 11:31:29 2009
@@ -151,4 +151,4 @@
* !HtmlUnit does not attempt to emulate authentic browser layout.
Consequently, tests that are sensitive to browser layout are very likely to
fail. However, since GWTTestCase supports other methods of running tests,
such as Selenium, that do support accurate layout testing, it can still
make sense to keep layout-sensitive tests in the same test case as
non-layout-sensitive tests. If you want such tests to be ignored
by !HtmlUnit, simply annotate the test methods with
@!DoNotRunWith({Platform.!HtmlUnit}). Versions of Google Plugin for Eclipse
prior to 1.2 will only allow you to add GWT release directories that
include a file with a name like `gwt-dev-windows.jar`. You can fool it by
sym linking or copying gwt-dev.jar to the appropriate name.
* The way arguments are passed to the GWT testing infrastructure has
been revamped. There is now a consistent syntax to support arbitrary "run
styles", including user-written, with no changes to GWT itself. For
example, `-selenium FF3` has become `-runStyle selenium:FF3`. This change
likely does not affect typical test invocation scripts, but if you do use
`-Dgwt.args` to pass arguments to GWTTestCase, be aware that you may need
to make some changes.
* When using !ClientBundle, be aware that images using alpha
transparency do not appear transparent in IE6. The Mail sample application
included in the GWT distribution currently suffers from this limitation
(that is, the images have opaque backgrounds when viewed on IE6).
- * Users of the Google Plugin for Eclipse that are running Google App
Engine projects in development mode may see errors like "Unable to
find'myApp.gwt.xml' on your classpath; could be a typo, or maybe you forgot
to include a classpath entry for source?". This is due to an unfortunate
interaction between weak references to module definitions and garbage
collection kicked off by the App Engine.
+ * Users of the Google Plugin for Eclipse that are running Google App
Engine projects in development mode may see errors like "Unable to
find 'myApp.gwt.xml' on your classpath; could be a typo, or maybe you
forgot to include a classpath entry for source?". This is due to an
unfortunate interaction between weak references to module definitions and
garbage collection kicked off by the App Engine.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6961 committed - Note lowercasing of module name in GAE issue.
Revision: 6961
Author: rj...@google.com
Date: Tue Nov 17 11:34:47 2009
Log: Note lowercasing of module name in GAE issue.
http://code.google.com/p/google-web-toolkit/source/detail?r=6961
Modified:
/wiki/GWT_2_0_RC.wiki
===
--- /wiki/GWT_2_0_RC.wiki Tue Nov 17 11:31:29 2009
+++ /wiki/GWT_2_0_RC.wiki Tue Nov 17 11:34:47 2009
@@ -151,4 +151,4 @@
* !HtmlUnit does not attempt to emulate authentic browser layout.
Consequently, tests that are sensitive to browser layout are very likely to
fail. However, since GWTTestCase supports other methods of running tests,
such as Selenium, that do support accurate layout testing, it can still
make sense to keep layout-sensitive tests in the same test case as
non-layout-sensitive tests. If you want such tests to be ignored
by !HtmlUnit, simply annotate the test methods with
@!DoNotRunWith({Platform.!HtmlUnit}). Versions of Google Plugin for Eclipse
prior to 1.2 will only allow you to add GWT release directories that
include a file with a name like `gwt-dev-windows.jar`. You can fool it by
sym linking or copying gwt-dev.jar to the appropriate name.
* The way arguments are passed to the GWT testing infrastructure has
been revamped. There is now a consistent syntax to support arbitrary "run
styles", including user-written, with no changes to GWT itself. For
example, `-selenium FF3` has become `-runStyle selenium:FF3`. This change
likely does not affect typical test invocation scripts, but if you do use
`-Dgwt.args` to pass arguments to GWTTestCase, be aware that you may need
to make some changes.
* When using !ClientBundle, be aware that images using alpha
transparency do not appear transparent in IE6. The Mail sample application
included in the GWT distribution currently suffers from this limitation
(that is, the images have opaque backgrounds when viewed on IE6).
- * Users of the Google Plugin for Eclipse that are running Google App
Engine projects in development mode may see errors like "Unable to
find 'myApp.gwt.xml' on your classpath; could be a typo, or maybe you
forgot to include a classpath entry for source?". This is due to an
unfortunate interaction between weak references to module definitions and
garbage collection kicked off by the App Engine.
+ * Users of the Google Plugin for Eclipse that are running Google App
Engine projects in development mode may see errors like "Unable to
find 'myapp.gwt.xml' on your classpath; could be a typo, or maybe you
forgot to include a classpath entry for source?". (Note that the app name
has been cast to lowercase, that's a symptom.) This is due to an
unfortunate interaction between weak references to module definitions and
garbage collection kicked off by the App Engine.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Reduce log levels, remove stderr launch URL message
Reviewers: mmendez, bruce,
Please review this at http://gwt-code-reviews.appspot.com/104801
Affected files:
dev/core/src/com/google/gwt/dev/DevMode.java
dev/core/src/com/google/gwt/dev/DevModeBase.java
Index: dev/core/src/com/google/gwt/dev/DevModeBase.java
===
--- dev/core/src/com/google/gwt/dev/DevModeBase.java(revision 6956)
+++ dev/core/src/com/google/gwt/dev/DevModeBase.java(working copy)
@@ -703,7 +703,7 @@
try {
for (String prenormalized : options.getStartupURLs()) {
startupURL = normalizeURL(prenormalized, getPort(), getHost());
-logger.log(TreeLogger.INFO, "Starting URL: " + startupURL, null);
+logger.log(TreeLogger.TRACE, "Starting URL: " + startupURL, null);
launchURL(startupURL);
}
} catch (UnableToCompleteException e) {
@@ -764,7 +764,7 @@
* subclasses that need to change the behavior of ShellModuleSpaceHost.
*
* @param logger TreeLogger to use
- * @param typeOracle
+ * @param compilationState
* @param moduleDef
* @return ShellModuleSpaceHost instance
*/
@@ -881,9 +881,6 @@
getTopLogger().log(TreeLogger.ERROR, "Invalid URL " + url, e);
throw new UnableToCompleteException();
}
-System.err.println("Using a browser with the GWT Developer Plugin,
please browse to");
-System.err.println("the following URL:");
-System.err.println(" " + url);
final URL helpInfoUrl = parsedUrl;
getTopLogger().log(TreeLogger.INFO,
"Waiting for browser connection to " + url, null, new HelpInfo() {
Index: dev/core/src/com/google/gwt/dev/DevMode.java
===
--- dev/core/src/com/google/gwt/dev/DevMode.java(revision 6956)
+++ dev/core/src/com/google/gwt/dev/DevMode.java(working copy)
@@ -344,7 +344,7 @@
ui.setCallback(RestartServerEvent.getType(), this);
// TODO(jat): find a safe way to get an icon for the servlet
container
TreeLogger serverLogger = ui.getWebServerLogger(getWebServerName(),
null);
- serverLogger.log(TreeLogger.INFO, "Starting HTTP on port " +
getPort(),
+ serverLogger.log(TreeLogger.TRACE, "Starting HTTP on port " +
getPort(),
null);
server = options.getServletContainerLauncher().start(serverLogger,
getPort(), options.getWarDir());
@@ -375,6 +375,7 @@
return options.getServletContainerLauncher().getName();
}
+ @Override
protected synchronized void produceOutput(TreeLogger logger,
StandardLinkerContext linkerStack, ArtifactSet artifacts, ModuleDef
module)
throws UnableToCompleteException {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6962 committed - Updated patch for issue 3527 (getDisabled() -> isDisabled() on Select...
Revision: 6962
Author: j...@google.com
Date: Tue Nov 17 11:51:29 2009
Log: Updated patch for issue 3527 (getDisabled() -> isDisabled() on Select
and OptGroup elements.
Review: http://gwt-code-reviews.appspot.com/97803
http://code.google.com/p/google-web-toolkit/source/detail?r=6962
Modified:
/trunk/user/src/com/google/gwt/dom/client/OptGroupElement.java
/trunk/user/src/com/google/gwt/dom/client/SelectElement.java
/trunk/user/test/com/google/gwt/dom/client/ElementTest.java
===
--- /trunk/user/src/com/google/gwt/dom/client/OptGroupElement.java Fri Jul
11 13:35:23 2008
+++ /trunk/user/src/com/google/gwt/dom/client/OptGroupElement.java Tue Nov
17 11:51:29 2009
@@ -41,6 +41,7 @@
* The control is unavailable in this context.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ * @deprecated use {...@link #isDisabled()} instead.
*/
public final native String getDisabled() /*-{
return this.disabled;
@@ -55,6 +56,24 @@
return this.label;
}-*/;
+ /**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ */
+ public final native boolean isDisabled() /*-{
+ return !!this.disabled;
+ }-*/;
+
+ /**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ */
+ public final native void setDisabled(boolean disabled) /*-{
+ this.disabled = disabled;
+ }-*/;
+
/**
* The control is unavailable in this context.
*
===
--- /trunk/user/src/com/google/gwt/dom/client/SelectElement.javaFri May
15
13:11:37 2009
+++ /trunk/user/src/com/google/gwt/dom/client/SelectElement.javaTue Nov
17
11:51:29 2009
@@ -80,6 +80,7 @@
* The control is unavailable in this context.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ * @deprecated use {...@link #isDisabled()} instead.
*/
public final native String getDisabled() /*-{
return this.disabled;
@@ -160,6 +161,15 @@
return this.value;
}-*/;
+ /**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ */
+ public final native boolean isDisabled() /*-{
+ return !!this.disabled;
+ }-*/;
+
/**
* If true, multiple OPTION elements may be selected in this SELECT.
*
@@ -178,6 +188,15 @@
public final void remove(int index) {
DOMImpl.impl.selectRemoveOption(this, index);
}
+
+ /**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ */
+ public final native void setDisabled(boolean disabled) /*-{
+ this.disabled = disabled;
+ }-*/;
/**
* The control is unavailable in this context.
===
--- /trunk/user/test/com/google/gwt/dom/client/ElementTest.java Mon Oct 26
18:35:41 2009
+++ /trunk/user/test/com/google/gwt/dom/client/ElementTest.java Tue Nov 17
11:51:29 2009
@@ -84,6 +84,16 @@
assertFalse(input.isDisabled());
input.setDisabled(true);
assertTrue(input.isDisabled());
+
+SelectElement select = Document.get().createSelectElement();
+assertFalse(select.isDisabled());
+select.setDisabled(true);
+assertTrue(select.isDisabled());
+
+OptGroupElement optgroup = Document.get().createOptGroupElement();
+assertFalse(optgroup.isDisabled());
+optgroup.setDisabled(true);
+assertTrue(optgroup.isDisabled());
}
/**
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Increasing timeout of a test that had a very tight window
Reviewers: fabbott,
Description:
DisclosurePanelTest#testCoreFunctionality has a 50ms window for a Timer
to fire before the test completes, which is sometimes too small.
Fix:
===
Increasing timeout to 5000ms.
Testing:
Verified the test passes, although it only failed rarely before.
Please review this at http://gwt-code-reviews.appspot.com/103802
Affected files:
user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
Index: user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
===
--- user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
(revision 6956)
+++ user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
(working copy)
@@ -48,7 +48,7 @@
panel.setOpen(true);
-delayTestFinish(500);
+delayTestFinish(5000);
// Allow the animation time to finish
Timer t = new Timer() {
@Override
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Increasing timeout of a test that had a very tight window
LGTM http://gwt-code-reviews.appspot.com/103802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6963 committed - Merging tr...@r6962 into releases/2.0.
Revision: 6963
Author: j...@google.com
Date: Tue Nov 17 11:54:37 2009
Log: Merging tr...@r6962 into releases/2.0.
http://code.google.com/p/google-web-toolkit/source/detail?r=6963
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/src/com/google/gwt/dom/client/OptGroupElement.java
/releases/2.0/user/src/com/google/gwt/dom/client/SelectElement.java
/releases/2.0/user/test/com/google/gwt/dom/client/ElementTest.java
===
--- /releases/2.0/branch-info.txt Mon Nov 16 19:22:20 2009
+++ /releases/2.0/branch-info.txt Tue Nov 17 11:54:37 2009
@@ -724,3 +724,8 @@
GWTShell now reuses dev mode linking code to populate its generated
resources directory.
svn merge --ignore-ancestry -r6942:6949
https://google-web-toolkit.googlecode.com/svn/trunk/ .
+tr...@6962 was merged into this branch
+ Updated patch for issue 3527 (getDisabled() -> isDisabled() on Select and
OptGroup elements.
+svn merge --ignore-ancestry -c6962 \
+ https://google-web-toolkit.googlecode.com/svn/trunk/ .
+
===
--- /releases/2.0/user/src/com/google/gwt/dom/client/OptGroupElement.java
Fri Jul 11 13:35:23 2008
+++ /releases/2.0/user/src/com/google/gwt/dom/client/OptGroupElement.java
Tue Nov 17 11:54:37 2009
@@ -41,6 +41,7 @@
* The control is unavailable in this context.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ * @deprecated use {...@link #isDisabled()} instead.
*/
public final native String getDisabled() /*-{
return this.disabled;
@@ -55,6 +56,24 @@
return this.label;
}-*/;
+ /**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ */
+ public final native boolean isDisabled() /*-{
+ return !!this.disabled;
+ }-*/;
+
+ /**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ */
+ public final native void setDisabled(boolean disabled) /*-{
+ this.disabled = disabled;
+ }-*/;
+
/**
* The control is unavailable in this context.
*
===
--- /releases/2.0/user/src/com/google/gwt/dom/client/SelectElement.java Fri
May 15 13:11:37 2009
+++ /releases/2.0/user/src/com/google/gwt/dom/client/SelectElement.java Tue
Nov 17 11:54:37 2009
@@ -80,6 +80,7 @@
* The control is unavailable in this context.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ * @deprecated use {...@link #isDisabled()} instead.
*/
public final native String getDisabled() /*-{
return this.disabled;
@@ -160,6 +161,15 @@
return this.value;
}-*/;
+ /**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ */
+ public final native boolean isDisabled() /*-{
+ return !!this.disabled;
+ }-*/;
+
/**
* If true, multiple OPTION elements may be selected in this SELECT.
*
@@ -178,6 +188,15 @@
public final void remove(int index) {
DOMImpl.impl.selectRemoveOption(this, index);
}
+
+ /**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled";>W3C
HTML Specification
+ */
+ public final native void setDisabled(boolean disabled) /*-{
+ this.disabled = disabled;
+ }-*/;
/**
* The control is unavailable in this context.
===
--- /releases/2.0/user/test/com/google/gwt/dom/client/ElementTest.java Wed
Oct 28 19:23:32 2009
+++ /releases/2.0/user/test/com/google/gwt/dom/client/ElementTest.java Tue
Nov 17 11:54:37 2009
@@ -84,6 +84,16 @@
assertFalse(input.isDisabled());
input.setDisabled(true);
assertTrue(input.isDisabled());
+
+SelectElement select = Document.get().createSelectElement();
+assertFalse(select.isDisabled());
+select.setDisabled(true);
+assertTrue(select.isDisabled());
+
+OptGroupElement optgroup = Document.get().createOptGroupElement();
+assertFalse(optgroup.isDisabled());
+optgroup.setDisabled(true);
+assertTrue(optgroup.isDisabled());
}
/**
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] CookieTest fails in dev mode if server and client times aren't synced
Reviewers: jat,
Description:
In dev mode, CookieTest sets a cookie expiration to 5000ms based on the
time on the JUnitShell host, but expects the cookie to expire in exactly
5010ms based on the time on the client. If the host is more than 10ms
ahead of the client (which our test host is), the test will fail.
I verified that our test host can be off by 10ms.
Fix:
We now allow the test host and client to be off by 1000ms, which is
plenty for our test infrastructure.
Technically, it still isn't deterministic, but a deterministic solution
(getting the current time from the client in dev mode) would be more
complicated and wouldn't necessarily test the more common use case of
setting a timeout using the Date object.
Testing:
===
I verified that the test now passes reliably.
Please review this at http://gwt-code-reviews.appspot.com/103803
Affected files:
user/test/com/google/gwt/user/client/CookieTest.java
Index: user/test/com/google/gwt/user/client/CookieTest.java
===
--- user/test/com/google/gwt/user/client/CookieTest.java(revision 6956)
+++ user/test/com/google/gwt/user/client/CookieTest.java(working copy)
@@ -76,7 +76,7 @@
Cookies.setCookie(lateCookie, "late", expiresLate);
Cookies.setCookie(sessionCookie, "forever", null);
-delayTestFinish(6 * 1000);
+delayTestFinish(7000);
// Wait until the cookie expires before checking it
Timer timer = new Timer() {
@Override
@@ -96,7 +96,7 @@
finishTest();
}
};
-timer.schedule(5010);
+timer.schedule(6000);
}
/**
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] adding new names to the blackout list
I don't promise this is exhaustive, but it catches up to the mozilla and IE references, plus uneval from issue 3965. (Which wasn't on the mozilla pages, despite being reserved there, so I'm in fact almost sure this *isn't* exhaustive...) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors namespace.patch Description: Binary data
[gwt-contrib] [google-web-toolkit] r6964 committed - Remove status line update from IE plugin....
Revision: 6964
Author: j...@google.com
Date: Tue Nov 17 12:12:15 2009
Log: Remove status line update from IE plugin.
Patch by: jat
Unreviewed
http://code.google.com/p/google-web-toolkit/source/detail?r=6964
Modified:
/trunk/plugins/ie/oophm/oophm/IESessionHandler.cpp
===
--- /trunk/plugins/ie/oophm/oophm/IESessionHandler.cpp Thu Sep 3 15:22:56
2009
+++ /trunk/plugins/ie/oophm/oophm/IESessionHandler.cpp Tue Nov 17 12:12:15
2009
@@ -25,7 +25,7 @@
IESessionHandler::IESessionHandler(HostChannel* channel,
IHTMLWindow2* window) :
SessionData(channel, window, this), jsObjectId(1)
{
- window->put_defaultStatus(L"GWT OOPHM Plugin active");
+ // window->put_defaultStatus(L"GWT Developer Plugin active");
}
IESessionHandler::~IESessionHandler(void) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] adding new names to the blackout list
> // "future reserved words" > "abstract", "int", "short", "boolean", "interface", "static", "byte", > "long", "char", "final", "native", "synchronized", "float", "package", > "throws", "goto", "private", "transient", "implements", "protected", > "volatile", "double", "public", What a future it will be... Dan On Tue, Nov 17, 2009 at 3:11 PM, Freeland Abbott wrote: > I don't promise this is exhaustive, but it catches up to the mozilla and IE > references, plus uneval from issue 3965. (Which wasn't on the mozilla > pages, despite being reserved there, so I'm in fact almost sure this > isn't exhaustive...) > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: CookieTest fails in dev mode if server and client times aren't synced
LGTM http://gwt-code-reviews.appspot.com/103803 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6965 committed - Increasing timeout of DisclosurePanelTest because the existing 50ms ti...
Revision: 6965
Author: jlaba...@google.com
Date: Tue Nov 17 12:12:25 2009
Log: Increasing timeout of DisclosurePanelTest because the existing 50ms
timeout was too small.
Patch by: jlabanca
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6965
Modified:
/trunk/user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
===
--- /trunk/user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
Wed Sep 30 16:46:38 2009
+++ /trunk/user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
Tue Nov 17 12:12:25 2009
@@ -48,7 +48,7 @@
panel.setOpen(true);
-delayTestFinish(500);
+delayTestFinish(5000);
// Allow the animation time to finish
Timer t = new Timer() {
@Override
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6966 committed - Spell out GWT in first line of Add-Ons menu....
Revision: 6966 Author: j...@google.com Date: Tue Nov 17 12:14:44 2009 Log: Spell out GWT in first line of Add-Ons menu. Patch by: jat Unreviewed http://code.google.com/p/google-web-toolkit/source/detail?r=6966 Modified: /trunk/plugins/xpcom/install-template.rdf === --- /trunk/plugins/xpcom/install-template.rdf Mon Nov 9 06:14:18 2009 +++ /trunk/plugins/xpcom/install-template.rdf Tue Nov 17 12:14:44 2009 @@ -4,7 +4,7 @@ gwt-dev-plu...@google.com -GWT Developer Plugin for Firefox +Google Web Toolkit Developer Plugin for Firefox GWT_DEV_PLUGIN_VERSION 2 @@ -37,10 +37,12 @@ # replace default about dialog chrome://gwt-dmp/content/about.xul -# more platforms - any others? OS/ABI for FreeBSD? +# more platforms - any others? SunOS_sparc-sunc SunOS_x86-sunc SunOS_x86_64-sunc +FreeBSD_x86-gcc3 +FreeBSD_x86_64-gcc3 --> -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6967 committed - tr...@6965 was merged into this branch...
Revision: 6967
Author: jlaba...@google.com
Date: Tue Nov 17 12:15:50 2009
Log: tr...@6965 was merged into this branch
Increasing the timeout of DisclosurePanelTest#testCoreFunctionality()
svn merge --ignore-ancestry -c6965
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch by: jlabanca
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6967
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
===
--- /releases/2.0/branch-info.txt Tue Nov 17 11:54:37 2009
+++ /releases/2.0/branch-info.txt Tue Nov 17 12:15:50 2009
@@ -729,3 +729,7 @@
svn merge --ignore-ancestry -c6962 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
+tr...@6965 was merged into this branch
+ Increasing the timeout of DisclosurePanelTest#testCoreFunctionality()
+svn merge --ignore-ancestry -c6965
https://google-web-toolkit.googlecode.com/svn/trunk/ .
+
===
---
/releases/2.0/user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
Wed Sep 30 16:46:38 2009
+++
/releases/2.0/user/test/com/google/gwt/user/client/ui/DisclosurePanelTest.java
Tue Nov 17 12:15:50 2009
@@ -48,7 +48,7 @@
panel.setOpen(true);
-delayTestFinish(500);
+delayTestFinish(5000);
// Allow the animation time to finish
Timer t = new Timer() {
@Override
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6968 committed - Increasing the timeout in CookieTest to account for minor differences ...
Revision: 6968
Author: jlaba...@google.com
Date: Tue Nov 17 12:19:33 2009
Log: Increasing the timeout in CookieTest to account for minor differences
in time between the host and client.
Patch by: jlabanca
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6968
Modified:
/trunk/user/test/com/google/gwt/user/client/CookieTest.java
===
--- /trunk/user/test/com/google/gwt/user/client/CookieTest.java Wed Sep 30
16:46:38 2009
+++ /trunk/user/test/com/google/gwt/user/client/CookieTest.java Tue Nov 17
12:19:33 2009
@@ -76,7 +76,7 @@
Cookies.setCookie(lateCookie, "late", expiresLate);
Cookies.setCookie(sessionCookie, "forever", null);
-delayTestFinish(6 * 1000);
+delayTestFinish(7000);
// Wait until the cookie expires before checking it
Timer timer = new Timer() {
@Override
@@ -96,7 +96,7 @@
finishTest();
}
};
-timer.schedule(5010);
+timer.schedule(6000);
}
/**
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improve NumberFormat.format to avoid weird rounding issues
ping http://gwt-code-reviews.appspot.com/97812 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] RR : GWT 2.0 Polish : Set application title, dock image on OS X
Reviewers: jat, bruce, Message: Review requested. Description: This patch makes DevMode feel a little bit more like a native app. Please review this at http://gwt-code-reviews.appspot.com/103804 Affected files: M dev/core/src/com/google/gwt/dev/BootStrapPlatform.java M dev/core/src/com/google/gwt/dev/SwingUI.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: adding new names to the blackout list
On Tue, Nov 17, 2009 at 3:11 PM, Freeland Abbott wrote: > I don't promise this is exhaustive, but it catches up to the mozilla and IE > references, plus uneval from issue 3965. (Which wasn't on the mozilla > pages, despite being reserved there, so I'm in fact almost sure this > isn't exhaustive...) LGTM. -Lex -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: RR : GWT 2.0 Polish : Set application title, dock image on OS X
Haven't tested it on a Mac, but LGTM with minor nits http://gwt-code-reviews.appspot.com/103804/diff/1/2 File dev/core/src/com/google/gwt/dev/BootStrapPlatform.java (right): http://gwt-code-reviews.appspot.com/103804/diff/1/2#newcode42 Line 42: "GWT DevMode"); I think we have been spelling it out. For example, the Swing UI is titled "GWT Development Mode". http://gwt-code-reviews.appspot.com/103804/diff/1/3 File dev/core/src/com/google/gwt/dev/SwingUI.java (right): http://gwt-code-reviews.appspot.com/103804/diff/1/3#newcode95 Line 95: protected static final String PACKAGE_PATH = SwingUI.class.getPackage().getName().replace( Why this change, which pushes it beyond 80 chars? http://gwt-code-reviews.appspot.com/103804/diff/1/3#newcode135 Line 135: private final Map tabPanels = new HashMap(); Likewise here http://gwt-code-reviews.appspot.com/103804/diff/1/3#newcode151 Line 151: "GWT Code Server"); Where does this show up? If this is the name for the Swing UI, shouldn't that be GWT Development Mode? http://gwt-code-reviews.appspot.com/103804 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Using @if in CSS to provide 1-bit-alpha images on IE6 in the Mail sample.
LGTM http://gwt-code-reviews.appspot.com/104802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improve NumberFormat.format to avoid weird rounding issues
There is a big overriding issue I am concerned about. I have not gone over all the logic until that is answered, but overall I am not sure this is better than improving the current approach. http://gwt-code-reviews.appspot.com/97812/diff/1/2 File user/src/com/google/gwt/i18n/client/NumberFormat.java (right): http://gwt-code-reviews.appspot.com/97812/diff/1/2#newcode1323 Line 1323: String digits = Double.toString(number); This essentially reduces to "" + number in JS -- how certain are we that the result is sufficiently predictable across all browsers and locales that we can get the correct result. For example, what happens in locales that use different decimal/comma separators, or something besides E for exponential notation? I am very leery of relying on this behavior. http://gwt-code-reviews.appspot.com/97812 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6969 committed - Change font in bottom panel of Swing tree logger to match the upper pa...
Revision: 6969
Author: j...@google.com
Date: Tue Nov 17 14:20:58 2009
Log: Change font in bottom panel of Swing tree logger to match the upper
panel.
Patch by: jat
Review by: bruce (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=6969
Modified:
/trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
===
--- /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Thu Nov 5 08:35:05 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Tue Nov 17 14:20:58 2009
@@ -30,6 +30,7 @@
import java.awt.Component;
import java.awt.Dimension;
import java.awt.FlowLayout;
+import java.awt.Font;
import java.awt.HeadlessException;
import java.awt.Point;
import java.awt.datatransfer.Clipboard;
@@ -60,11 +61,14 @@
import javax.swing.KeyStroke;
import javax.swing.Popup;
import javax.swing.PopupFactory;
+import javax.swing.UIManager;
import javax.swing.event.HyperlinkEvent;
import javax.swing.event.HyperlinkListener;
import javax.swing.event.TreeSelectionEvent;
import javax.swing.event.TreeSelectionListener;
import javax.swing.event.HyperlinkEvent.EventType;
+import javax.swing.text.html.HTMLDocument;
+import javax.swing.text.html.HTMLEditorKit;
import javax.swing.tree.DefaultMutableTreeNode;
import javax.swing.tree.DefaultTreeCellRenderer;
import javax.swing.tree.DefaultTreeModel;
@@ -375,6 +379,11 @@
details.setContentType("text/html");
details.setForeground(Color.BLACK);
details.addHyperlinkListener(this);
+// font trick from
http://explodingpixels.wordpress.com/2008/10/28/make-jeditorpane-use-the-system-font/
+Font font = UIManager.getFont("Label.font");
+String bodyRule = "body { font-family: " + font.getFamily() + "; "
++ "font-size: " + font.getSize() + "pt; }";
+((HTMLDocument)
details.getDocument()).getStyleSheet().addRule(bodyRule);
JScrollPane msgView = new JScrollPane(details);
JSplitPane splitter = new JSplitPane(JSplitPane.VERTICAL_SPLIT);
splitter.setTopComponent(treeView);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6970 committed - Now using CssResource's @if to provide 1-bit-alpha images on IE6....
Revision: 6970
Author: j...@google.com
Date: Tue Nov 17 14:23:51 2009
Log: Now using CssResource's @if to provide 1-bit-alpha images on IE6.
Review: http://gwt-code-reviews.appspot.com/104802
http://code.google.com/p/google-web-toolkit/source/detail?r=6970
Added:
/trunk/samples/mail/war/contactsgroup_ie6.gif
/trunk/samples/mail/war/logo_ie6.gif
/trunk/samples/mail/war/mailboxesgroup_ie6.gif
/trunk/samples/mail/war/tasksgroup_ie6.gif
Modified:
/trunk/samples/mail/src/com/google/gwt/sample/mail/client/Shortcuts.ui.xml
/trunk/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml
===
--- /dev/null
+++ /trunk/samples/mail/war/contactsgroup_ie6.gif Tue Nov 17 14:23:51 2009
Binary file, no diff available.
===
--- /dev/null
+++ /trunk/samples/mail/war/logo_ie6.gifTue Nov 17 14:23:51 2009
Binary file, no diff available.
===
--- /dev/null
+++ /trunk/samples/mail/war/mailboxesgroup_ie6.gif Tue Nov 17 14:23:51 2009
Binary file, no diff available.
===
--- /dev/null
+++ /trunk/samples/mail/war/tasksgroup_ie6.gif Tue Nov 17 14:23:51 2009
Binary file, no diff available.
===
---
/trunk/samples/mail/src/com/google/gwt/sample/mail/client/Shortcuts.ui.xml
Thu Nov 12 14:37:02 2009
+++
/trunk/samples/mail/src/com/google/gwt/sample/mail/client/Shortcuts.ui.xml
Tue Nov 17 14:23:51 2009
@@ -22,20 +22,43 @@
border-top: 1px solid #888;
}
- @sprite .mailboxesIcon {
-gwt-image: 'mailboxesgroup';
-float: left;
- }
-
- @sprite .tasksIcon {
-gwt-image: 'tasksgroup';
-float: left;
- }
-
- @sprite .contactsIcon {
-gwt-image: 'contactsgroup';
-float: left;
- }
+ @if user.agent ie6 {
+ .mailboxesIcon {
+ background-image: url(mailboxesgroup_ie6.gif);
+ width: 31px;
+ height: 22px;
+ float: left;
+ }
+
+ .tasksIcon {
+ background-image: url(tasksgroup_ie6.gif);
+ width: 31px;
+ height: 22px;
+ float: left;
+ }
+
+ .contactsIcon {
+ background-image: url(contactsgroup_ie6.gif);
+ width: 31px;
+ height: 22px;
+ float: left;
+ }
+ } @else {
+@sprite .mailboxesIcon {
+ gwt-image: 'mailboxesgroup';
+ float: left;
+}
+
+@sprite .tasksIcon {
+ gwt-image: 'tasksgroup';
+ float: left;
+}
+
+@sprite .contactsIcon {
+ gwt-image: 'contactsgroup';
+ float: left;
+}
+ }
===
---
/trunk/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml
Mon Nov 9 10:52:41 2009
+++
/trunk/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml
Tue Nov 17 14:23:51 2009
@@ -18,9 +18,18 @@
text-align: right;
}
- @sprite .logo {
-gwt-image: 'logo';
-position: absolute;
+ @if user.agent ie6 {
+.logo {
+ background-image: url(logo_ie6.gif);
+ width: 140px;
+ height: 75px;
+ position: absolute;
+}
+ } @else {
+@sprite .logo {
+ gwt-image: 'logo';
+ position: absolute;
+}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] adding new names to the blackout list
I'm especially excited about "goto"! Think of how powerful and flexible that will be! On Tue, Nov 17, 2009 at 3:13 PM, Daniel Rice (דניאל רייס) wrote: > > // "future reserved words" > > "abstract", "int", "short", "boolean", "interface", "static", "byte", > > "long", "char", "final", "native", "synchronized", "float", "package", > > "throws", "goto", "private", "transient", "implements", "protected", > > "volatile", "double", "public", > > What a future it will be... > > Dan > > On Tue, Nov 17, 2009 at 3:11 PM, Freeland Abbott > wrote: > > I don't promise this is exhaustive, but it catches up to the mozilla and > IE > > references, plus uneval from issue 3965. (Which wasn't on the mozilla > > pages, despite being reserved there, so I'm in fact almost sure this > > isn't exhaustive...) > > > > -- > > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: RR : GWT 2.0 Polish : Set application title, dock image on OS X
Two other things: - Can we do something about the icon? - Where on earth is that About dialog box coming from? It has a completely random version string. http://gwt-code-reviews.appspot.com/103804/diff/1/2 File dev/core/src/com/google/gwt/dev/BootStrapPlatform.java (right): http://gwt-code-reviews.appspot.com/103804/diff/1/2#newcode42 Line 42: "GWT DevMode"); On 2009/11/17 21:59:57, jat wrote: > I think we have been spelling it out. For example, the Swing UI is titled "GWT > Development Mode". The ideal is for the menu item to read "Development Mode" (not prefixed with GWT) and for the About menu text to read "About Google Web Toolkit Development Mode" http://gwt-code-reviews.appspot.com/103804 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6971 committed - Merge trunk r6969 into this branch...
Revision: 6971
Author: j...@google.com
Date: Tue Nov 17 14:26:01 2009
Log: Merge trunk r6969 into this branch
Fix font in bottom part of Swing tree logger.
svn merge --ignore-ancestry -c6969 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=6971
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
===
--- /releases/2.0/branch-info.txt Tue Nov 17 12:15:50 2009
+++ /releases/2.0/branch-info.txt Tue Nov 17 14:26:01 2009
@@ -733,3 +733,7 @@
Increasing the timeout of DisclosurePanelTest#testCoreFunctionality()
svn merge --ignore-ancestry -c6965
https://google-web-toolkit.googlecode.com/svn/trunk/ .
+tr...@6969 was merged into this branch
+ Fix font in bottom part of Swing tree logger.
+svn merge --ignore-ancestry -c6969 \
+ https://google-web-toolkit.googlecode.com/svn/trunk/ .
===
---
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Thu Nov 5 11:28:20 2009
+++
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Tue Nov 17 14:26:01 2009
@@ -30,6 +30,7 @@
import java.awt.Component;
import java.awt.Dimension;
import java.awt.FlowLayout;
+import java.awt.Font;
import java.awt.HeadlessException;
import java.awt.Point;
import java.awt.datatransfer.Clipboard;
@@ -60,11 +61,14 @@
import javax.swing.KeyStroke;
import javax.swing.Popup;
import javax.swing.PopupFactory;
+import javax.swing.UIManager;
import javax.swing.event.HyperlinkEvent;
import javax.swing.event.HyperlinkListener;
import javax.swing.event.TreeSelectionEvent;
import javax.swing.event.TreeSelectionListener;
import javax.swing.event.HyperlinkEvent.EventType;
+import javax.swing.text.html.HTMLDocument;
+import javax.swing.text.html.HTMLEditorKit;
import javax.swing.tree.DefaultMutableTreeNode;
import javax.swing.tree.DefaultTreeCellRenderer;
import javax.swing.tree.DefaultTreeModel;
@@ -375,6 +379,11 @@
details.setContentType("text/html");
details.setForeground(Color.BLACK);
details.addHyperlinkListener(this);
+// font trick from
http://explodingpixels.wordpress.com/2008/10/28/make-jeditorpane-use-the-system-font/
+Font font = UIManager.getFont("Label.font");
+String bodyRule = "body { font-family: " + font.getFamily() + "; "
++ "font-size: " + font.getSize() + "pt; }";
+((HTMLDocument)
details.getDocument()).getStyleSheet().addRule(bodyRule);
JScrollPane msgView = new JScrollPane(details);
JSplitPane splitter = new JSplitPane(JSplitPane.VERTICAL_SPLIT);
splitter.setTopComponent(treeView);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6972 committed - Merging trunk c6970 into releases/2.0.
Revision: 6972
Author: j...@google.com
Date: Tue Nov 17 14:29:07 2009
Log: Merging trunk c6970 into releases/2.0.
http://code.google.com/p/google-web-toolkit/source/detail?r=6972
Added:
/releases/2.0/samples/mail/war/contactsgroup_ie6.gif
/releases/2.0/samples/mail/war/logo_ie6.gif
/releases/2.0/samples/mail/war/mailboxesgroup_ie6.gif
/releases/2.0/samples/mail/war/tasksgroup_ie6.gif
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/Shortcuts.ui.xml
/releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml
===
--- /dev/null
+++ /releases/2.0/samples/mail/war/contactsgroup_ie6.gifTue Nov 17
14:29:07 2009
Binary file, no diff available.
===
--- /dev/null
+++ /releases/2.0/samples/mail/war/logo_ie6.gif Tue Nov 17 14:29:07 2009
Binary file, no diff available.
===
--- /dev/null
+++ /releases/2.0/samples/mail/war/mailboxesgroup_ie6.gif Tue Nov 17
14:29:07 2009
Binary file, no diff available.
===
--- /dev/null
+++ /releases/2.0/samples/mail/war/tasksgroup_ie6.gif Tue Nov 17 14:29:07
2009
Binary file, no diff available.
===
--- /releases/2.0/branch-info.txt Tue Nov 17 14:26:01 2009
+++ /releases/2.0/branch-info.txt Tue Nov 17 14:29:07 2009
@@ -737,3 +737,8 @@
Fix font in bottom part of Swing tree logger.
svn merge --ignore-ancestry -c6969 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
+
+tr...@6970 was merged into this branch
+ Now using CssResource's @if to provide 1-bit-alpha images on IE6.
+svn merge --ignore-ancestry -c6970
https://google-web-toolkit.googlecode.com/svn/trunk/ .
+
===
---
/releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/Shortcuts.ui.xml
Thu Nov 12 14:52:16 2009
+++
/releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/Shortcuts.ui.xml
Tue Nov 17 14:29:07 2009
@@ -22,20 +22,43 @@
border-top: 1px solid #888;
}
- @sprite .mailboxesIcon {
-gwt-image: 'mailboxesgroup';
-float: left;
- }
-
- @sprite .tasksIcon {
-gwt-image: 'tasksgroup';
-float: left;
- }
-
- @sprite .contactsIcon {
-gwt-image: 'contactsgroup';
-float: left;
- }
+ @if user.agent ie6 {
+ .mailboxesIcon {
+ background-image: url(mailboxesgroup_ie6.gif);
+ width: 31px;
+ height: 22px;
+ float: left;
+ }
+
+ .tasksIcon {
+ background-image: url(tasksgroup_ie6.gif);
+ width: 31px;
+ height: 22px;
+ float: left;
+ }
+
+ .contactsIcon {
+ background-image: url(contactsgroup_ie6.gif);
+ width: 31px;
+ height: 22px;
+ float: left;
+ }
+ } @else {
+@sprite .mailboxesIcon {
+ gwt-image: 'mailboxesgroup';
+ float: left;
+}
+
+@sprite .tasksIcon {
+ gwt-image: 'tasksgroup';
+ float: left;
+}
+
+@sprite .contactsIcon {
+ gwt-image: 'contactsgroup';
+ float: left;
+}
+ }
===
---
/releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml
Mon Nov 9 11:00:52 2009
+++
/releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml
Tue Nov 17 14:29:07 2009
@@ -18,9 +18,18 @@
text-align: right;
}
- @sprite .logo {
-gwt-image: 'logo';
-position: absolute;
+ @if user.agent ie6 {
+.logo {
+ background-image: url(logo_ie6.gif);
+ width: 140px;
+ height: 75px;
+ position: absolute;
+}
+ } @else {
+@sprite .logo {
+ gwt-image: 'logo';
+ position: absolute;
+}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6973 committed - Adds additional icon sizes so Alt-Tab (etc) doesn't try and scale up t...
Revision: 6973
Author: j...@google.com
Date: Tue Nov 17 14:51:47 2009
Log: Adds additional icon sizes so Alt-Tab (etc) doesn't try and scale up
the 16x16
icon. Also fixes unused import left in previous change.
Patch by: jat
Review by: rjrjr (TBR)
http://code.google.com/p/google-web-toolkit/source/detail?r=6973
Added:
/trunk/dev/core/src/com/google/gwt/dev/shell/icon64.png
Modified:
/trunk/dev/core/src/com/google/gwt/dev/SwingUI.java
/trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
===
--- /dev/null
+++ /trunk/dev/core/src/com/google/gwt/dev/shell/icon64.png Tue Nov 17
14:51:47 2009
Binary file, no diff available.
===
--- /trunk/dev/core/src/com/google/gwt/dev/SwingUI.java Fri Oct 16 20:22:17
2009
+++ /trunk/dev/core/src/com/google/gwt/dev/SwingUI.java Tue Nov 17 14:51:47
2009
@@ -31,6 +31,7 @@
import java.awt.event.WindowEvent;
import java.io.File;
import java.net.URL;
+import java.util.Arrays;
import java.util.Map;
import javax.swing.Icon;
@@ -181,7 +182,12 @@
@Override
public void initialize(Type logLevel) {
super.initialize(logLevel);
-ImageIcon gwtIcon = loadImageIcon("icon24.png");
+ImageIcon gwtIcon16 = loadImageIcon("icon16.png");
+ImageIcon gwtIcon24 = loadImageIcon("icon24.png");
+ImageIcon gwtIcon32 = loadImageIcon("icon32.png");
+ImageIcon gwtIcon48 = loadImageIcon("icon48.png");
+ImageIcon gwtIcon64 = loadImageIcon("icon64.png");
+ImageIcon gwtIcon128 = loadImageIcon("icon128.png");
frame = new JFrame("GWT Development Mode");
tabs = new JTabbedPane();
if (options.alsoLogToFile()) {
@@ -189,7 +195,7 @@
}
mainWnd = new ShellMainWindow(logLevel,
options.getLogFile("main.log"));
topLogger = mainWnd.getLogger();
-tabs.addTab("Development Mode", gwtIcon, mainWnd, "GWT Development
Mode");
+tabs.addTab("Development Mode", gwtIcon24, mainWnd, "GWT Development
Mode");
frame.getContentPane().add(tabs);
frame.setSize(950, 700);
frame.setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
@@ -202,7 +208,9 @@
}
}
});
-frame.setIconImage(loadImageIcon("icon16.png").getImage());
+frame.setIconImages(Arrays.asList(gwtIcon48.getImage(),
+gwtIcon32.getImage(), gwtIcon64.getImage(), gwtIcon128.getImage(),
+gwtIcon16.getImage()));
frame.setVisible(true);
}
===
--- /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Tue Nov 17 14:20:58 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Tue Nov 17 14:51:47 2009
@@ -68,7 +68,6 @@
import javax.swing.event.TreeSelectionListener;
import javax.swing.event.HyperlinkEvent.EventType;
import javax.swing.text.html.HTMLDocument;
-import javax.swing.text.html.HTMLEditorKit;
import javax.swing.tree.DefaultMutableTreeNode;
import javax.swing.tree.DefaultTreeCellRenderer;
import javax.swing.tree.DefaultTreeModel;
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6974 committed - Merge trunk r6973 into this branch...
Revision: 6974
Author: j...@google.com
Date: Tue Nov 17 14:54:53 2009
Log: Merge trunk r6973 into this branch
Add more icon sizes.
svn merge --ignore-ancestry -c6973 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=6974
Added:
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/icon64.png
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/dev/core/src/com/google/gwt/dev/SwingUI.java
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
===
--- /dev/null
+++ /releases/2.0/dev/core/src/com/google/gwt/dev/shell/icon64.png Tue Nov
17 14:54:53 2009
Binary file, no diff available.
===
--- /releases/2.0/branch-info.txt Tue Nov 17 14:29:07 2009
+++ /releases/2.0/branch-info.txt Tue Nov 17 14:54:53 2009
@@ -742,3 +742,7 @@
Now using CssResource's @if to provide 1-bit-alpha images on IE6.
svn merge --ignore-ancestry -c6970
https://google-web-toolkit.googlecode.com/svn/trunk/ .
+tr...@6973 was merged into this branch
+ Add more icon sizes.
+svn merge --ignore-ancestry -c6973 \
+ https://google-web-toolkit.googlecode.com/svn/trunk/ .
===
--- /releases/2.0/dev/core/src/com/google/gwt/dev/SwingUI.java Fri Oct 16
20:22:17 2009
+++ /releases/2.0/dev/core/src/com/google/gwt/dev/SwingUI.java Tue Nov 17
14:54:53 2009
@@ -31,6 +31,7 @@
import java.awt.event.WindowEvent;
import java.io.File;
import java.net.URL;
+import java.util.Arrays;
import java.util.Map;
import javax.swing.Icon;
@@ -181,7 +182,12 @@
@Override
public void initialize(Type logLevel) {
super.initialize(logLevel);
-ImageIcon gwtIcon = loadImageIcon("icon24.png");
+ImageIcon gwtIcon16 = loadImageIcon("icon16.png");
+ImageIcon gwtIcon24 = loadImageIcon("icon24.png");
+ImageIcon gwtIcon32 = loadImageIcon("icon32.png");
+ImageIcon gwtIcon48 = loadImageIcon("icon48.png");
+ImageIcon gwtIcon64 = loadImageIcon("icon64.png");
+ImageIcon gwtIcon128 = loadImageIcon("icon128.png");
frame = new JFrame("GWT Development Mode");
tabs = new JTabbedPane();
if (options.alsoLogToFile()) {
@@ -189,7 +195,7 @@
}
mainWnd = new ShellMainWindow(logLevel,
options.getLogFile("main.log"));
topLogger = mainWnd.getLogger();
-tabs.addTab("Development Mode", gwtIcon, mainWnd, "GWT Development
Mode");
+tabs.addTab("Development Mode", gwtIcon24, mainWnd, "GWT Development
Mode");
frame.getContentPane().add(tabs);
frame.setSize(950, 700);
frame.setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
@@ -202,7 +208,9 @@
}
}
});
-frame.setIconImage(loadImageIcon("icon16.png").getImage());
+frame.setIconImages(Arrays.asList(gwtIcon48.getImage(),
+gwtIcon32.getImage(), gwtIcon64.getImage(), gwtIcon128.getImage(),
+gwtIcon16.getImage()));
frame.setVisible(true);
}
===
---
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Tue Nov 17 14:26:01 2009
+++
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Tue Nov 17 14:54:53 2009
@@ -68,7 +68,6 @@
import javax.swing.event.TreeSelectionListener;
import javax.swing.event.HyperlinkEvent.EventType;
import javax.swing.text.html.HTMLDocument;
-import javax.swing.text.html.HTMLEditorKit;
import javax.swing.tree.DefaultMutableTreeNode;
import javax.swing.tree.DefaultTreeCellRenderer;
import javax.swing.tree.DefaultTreeModel;
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] NPE during Serialization in deRPC
Bob, Another bug for you in deRPC. Please ping me if you want me to file an issue. *Test case : * domain model Order -> n Clients (ArrayList) getOrders() RPC service is supposed to return the Order with its Clients collection (initially empty). That works in DevMode and hangs in ProdMode with the current trunk When I call the rpc I get in ProdMode --- java.lang.NullPointerException at com.google.gwt.rpc.server.WebModePayloadSink.getBytes(WebModePayloadSink.java:860) at com.google.gwt.rpc.server.WebModePayloadSink$PayloadVisitor.constructorFunction(WebModePayloadSink.java:607) at com.google.gwt.rpc.server.WebModePayloadSink$PayloadVisitor.visit(WebModePayloadSink.java:260) at com.google.gwt.rpc.client.ast.InstantiateCommand.traverse(InstantiateCommand.java:54) at com.google.gwt.rpc.client.ast.RpcCommandVisitor.doAccept(RpcCommandVisitor.java:320) at com.google.gwt.rpc.client.ast.RpcCommandVisitor.accept(RpcCommandVisitor.java:42) at com.google.gwt.rpc.server.WebModePayloadSink$PayloadVisitor.visit(WebModePayloadSink.java:285) at com.google.gwt.rpc.client.ast.InstantiateCommand.traverse(InstantiateCommand.java:54) at com.google.gwt.rpc.client.ast.RpcCommandVisitor.doAccept(RpcCommandVisitor.java:320) at com.google.gwt.rpc.client.ast.RpcCommandVisitor.accept(RpcCommandVisitor.java:42) at com.google.gwt.rpc.server.WebModePayloadSink$PayloadVisitor.visit(WebModePayloadSink.java:237) at com.google.gwt.rpc.client.ast.ArrayValueCommand.traverse(ArrayValueCommand.java:53) at com.google.gwt.rpc.client.ast.RpcCommandVisitor.doAccept(RpcCommandVisitor.java:320) at com.google.gwt.rpc.client.ast.RpcCommandVisitor.accept(RpcCommandVisitor.java:42) Client side I get a "cannot read Property '0' for undefined bla bla" Don't know why "x" would be null in this case and don't get time to dig further ... I can post the json streams with gwt.rpc.pretty activated if u want. Sami -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6975 committed - Merges tr...@6932 into releases/2.0...
Revision: 6975
Author: rj...@google.com
Date: Tue Nov 17 15:22:47 2009
Log: Merges tr...@6932 into releases/2.0
Fixes bad code gen when css class names in a ui:style block have dashes
in them
svn merge --ignore-ancestry -c 6932
https://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=6975
Added:
/releases/2.0/user/src/com/google/gwt/uibinder/attributeparsers/CssNameConverter.java
/releases/2.0/user/test/com/google/gwt/uibinder/attributeparsers/CssNameConverterTest.java
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
/releases/2.0/user/src/com/google/gwt/uibinder/rebind/BundleWriter.java
/releases/2.0/user/src/com/google/gwt/uibinder/rebind/CssResourceWriter.java
/releases/2.0/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
/releases/2.0/user/test/com/google/gwt/uibinder/UiBinderJreSuite.java
/releases/2.0/user/test/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverterTest.java
/releases/2.0/user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
===
--- /dev/null
+++
/releases/2.0/user/src/com/google/gwt/uibinder/attributeparsers/CssNameConverter.java
Tue Nov 17 15:22:47 2009
@@ -0,0 +1,81 @@
+/*
+ * Copyright 2009 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.uibinder.attributeparsers;
+
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Converts css class names to a form safe to use as a Java identifier.
+ */
+public class CssNameConverter {
+ /**
+ * Thrown by {...@link CssNameConverter#convertSet(Set)} on name collision.
+ */
+ public static class Failure extends Exception {
+Failure(String message, Object... params) {
+ super(String.format(message, params));
+}
+ }
+
+ /**
+ * @param className a css class name
+ * @return the same name in a form safe to use as a Java identifier
+ */
+ public String convertName(String className) {
+String[] bits = className.split("\\-");
+StringBuilder b = new StringBuilder();
+for (String bit : bits) {
+ if (b.length() == 0) {
+b.append(bit);
+ } else {
+b.append(bit.substring(0, 1).toUpperCase());
+if (bit.length() > 1) {
+ b.append(bit.substring(1));
+}
+ }
+}
+String converted = b.toString();
+return converted;
+ }
+
+ /**
+ * @param classNames css class names to convert
+ * @return map of the same class names in a form safe for use as Java
+ * identifiers, with the order of the input set preserved
+ * @throws Failure on collisions due to conversions
+ */
+ public Map convertSet(Set classNames)
+ throws Failure {
+Map rawToConverted = new LinkedHashMap();
+Map convertedToRaw = new LinkedHashMap();
+for (String className : classNames) {
+ String converted = convertName(className);
+ String already = convertedToRaw.get(converted);
+ if (already != null) {
+throw new Failure("CSS class name collision: \"%s\" and \"%s\"",
already,
+className);
+ }
+ if (!converted.equals(className)) {
+convertedToRaw.put(converted, className);
+ }
+ rawToConverted.put(className, converted);
+}
+return rawToConverted;
+ }
+
+}
===
--- /dev/null
+++
/releases/2.0/user/test/com/google/gwt/uibinder/attributeparsers/CssNameConverterTest.java
Tue Nov 17 15:22:47 2009
@@ -0,0 +1,110 @@
+/*
+ * Copyright 2009 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.uibinder.attributeparsers;
+
+import com.google.gwt.dev.util.collect.Sets;
+
+import junit.framework.TestCase;
+
+import java.util.Map;
+import java.util.Set;
+
[gwt-contrib] Re: Makes dashes work in ui:style css class names
releases/2...@6975 http://gwt-code-reviews.appspot.com/100815 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Reduce log levels, remove stderr launch URL message
LGTM http://gwt-code-reviews.appspot.com/104801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] adding new names to the blackout list
Personally, I'm holding out for "transient goto"... imagine being able to leap to another chunk of code, and then back again when it finishes! On Tue, Nov 17, 2009 at 5:27 PM, Bruce Johnson wrote: > I'm especially excited about "goto"! Think of how powerful and flexible > that will be! > > > On Tue, Nov 17, 2009 at 3:13 PM, Daniel Rice (דניאל רייס) > wrote: > >> > // "future reserved words" >> > "abstract", "int", "short", "boolean", "interface", "static", "byte", >> > "long", "char", "final", "native", "synchronized", "float", "package", >> > "throws", "goto", "private", "transient", "implements", "protected", >> > "volatile", "double", "public", >> >> What a future it will be... >> >> Dan >> >> On Tue, Nov 17, 2009 at 3:11 PM, Freeland Abbott >> wrote: >> > I don't promise this is exhaustive, but it catches up to the mozilla and >> IE >> > references, plus uneval from issue 3965. (Which wasn't on the mozilla >> > pages, despite being reserved there, so I'm in fact almost sure this >> > isn't exhaustive...) >> > >> > -- >> > http://groups.google.com/group/Google-Web-Toolkit-Contributors >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improve NumberFormat.format to avoid weird rounding issues
My thinking is that unless we provide an implementation of Double.toString, we are best off trying to be consistent with the implementation at hand. If we use Double.toString (i.e., just Javascript native double-to-string conversion) some of the time, and use arithmetic ops to extract fractional digits some of the time, we will always see corner cases where things don't match. If we use Double.toString and extract digits from that, at least the answers form a consistent set. I take your point that we can't rely on the specific characters '.' and 'E'. Perhaps we can add some code to infer the right characters (caching them after they have been determined), or validate some heuristic such as 'digit=[0-9], exponential separator=[A-Za-z], decimal point=[anything else]'. Dan On Tue, Nov 17, 2009 at 5:14 PM, wrote: > There is a big overriding issue I am concerned about. I have not gone > over all the logic until that is answered, but overall I am not sure > this is better than improving the current approach. > > > http://gwt-code-reviews.appspot.com/97812/diff/1/2 > File user/src/com/google/gwt/i18n/client/NumberFormat.java (right): > > http://gwt-code-reviews.appspot.com/97812/diff/1/2#newcode1323 > Line 1323: String digits = Double.toString(number); > This essentially reduces to "" + number in JS -- how certain are we that > the result is sufficiently predictable across all browsers and locales > that we can get the correct result. For example, what happens in > locales that use different decimal/comma separators, or something > besides E for exponential notation? > > I am very leery of relying on this behavior. > > > http://gwt-code-reviews.appspot.com/97812 > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Reusing CssResource's @def (within e.g. UiBinder)
@bobv, please double check me here.
This will work, although I don't know if it will work in gwt/current or even
gwt/canary yet:
.foo { color: yellow; }
A ui:style element can have any number of css source files (space
separated). They'll be concatenated, and the body text appended to them. But
the ability for ui:style to have both a source css file and body text was a
fairly recent change. I doubt it's in gwt/current, and I'm not even sure
that it's in the long delayed gwt/canary.
@bobv, will anything pathological happen to the generated code if lots of
ui.xml files all do this? Remember that each ui.xml defines its own
ClientBundle.
On Tue, Nov 17, 2009 at 8:11 AM, Joel Webber wrote:
> [...@rjrjr, bobv: There's a way to reference Java constants from CSS, right?]
>
>
> On Mon, Nov 9, 2009 at 10:21 AM, Thomas Broyer wrote:
>
>>
>> Hi all,
>>
>> We're starting using UiBinder quite intensively and one thing we
>> haven't been able to do is to declare some constants in a CssResource
>> and reuse them in our ui.xml (I believe this is unrelated to UiBinder
>> actually, as I don't know how it could be made to work with plain old
>> CssResources only).
>>
>> Our use case is I believe very common: declare constants for common
>> colors to be shared thoughout the app (namely some kind of orange and
>> grays for use with borders, fore color and back color). I suspect we
>> might have the need for font sizes too.
>>
>> As a last resort, I tried the following (which forces me to have the
>> common CSS file in the same package as my ui.xml file):
>>
>>
>> > type='com.my.app.client.MyStyle' />
>>
>> @def yellow value('common.yellow');
>> .foo { color: yellow; }
>>
>>
>> but it fails with:
>> Scanning for additional dependencies: ...\gen\com\my\app\client
>> \Test_MyBinderImpl.java
>> Computing all possible rebind results for
>> 'com.my.app.client.Test_MyBinderImpl_GenBundle'
>> Rebinding com.my.app.client.Test_MyBinderImpl_GenBundle
>>Invoking >
>> class='com.google.gwt.resources.rebind.context.InlineClientBundleGenerator'/
>> >
>> Creating assignment for style()
>> Performing substitution in node color : .
>> ;
>>
>> [ERROR] Could not find no-arg method named yellow
>> in type com.my.app.client.Test_MyBinderImpl_GenCss_common
>>
>>
>> Is there a way to reuse @def-s in other CssResource-s? (in other
>> ClientBundle-s!) and which one?
>> --~--~-~--~~~---~--~~
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>> -~--~~~~--~~--~--~---
>>
>>
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] adding new names to the blackout list
+1 Freeland. You may then also like the planned "private goto", which goes somewhere but it doesn't tell you where it's gone. On Tuesday, November 17, 2009, Freeland Abbott wrote: > Personally, I'm holding out for "transient goto"... imagine being able to > leap to another chunk of code, and then back again when it finishes! > > On Tue, Nov 17, 2009 at 5:27 PM, Bruce Johnson wrote: > I'm especially excited about "goto"! Think of how powerful and flexible that > will be! > > > On Tue, Nov 17, 2009 at 3:13 PM, Daniel Rice (דניאל רייס) > wrote: >> // "future reserved words" >> "abstract", "int", "short", "boolean", "interface", "static", "byte", >> "long", "char", "final", "native", "synchronized", "float", "package", >> "throws", "goto", "private", "transient", "implements", "protected", >> "volatile", "double", "public", > > What a future it will be... > > Dan > > On Tue, Nov 17, 2009 at 3:11 PM, Freeland Abbott wrote: >> I don't promise this is exhaustive, but it catches up to the mozilla and IE >> references, plus uneval from issue 3965. (Which wasn't on the mozilla >> pages, despite being reserved there, so I'm in fact almost sure this >> isn't exhaustive...) >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > -- > > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] adding new names to the blackout list
Me, I'm holding out for the 'comefrom' statement. /kel On Tue, Nov 17, 2009 at 9:31 PM, Bruce Johnson wrote: > +1 Freeland. You may then also like the planned "private goto", which > goes somewhere but it doesn't tell you where it's gone. > > On Tuesday, November 17, 2009, Freeland Abbott wrote: > > Personally, I'm holding out for "transient goto"... imagine being able to > leap to another chunk of code, and then back again when it finishes! > > > > On Tue, Nov 17, 2009 at 5:27 PM, Bruce Johnson wrote: > > I'm especially excited about "goto"! Think of how powerful and flexible > that will be! > > > > > > On Tue, Nov 17, 2009 at 3:13 PM, Daniel Rice (דניאל רייס) < > r...@google.com> wrote: > >> // "future reserved words" > >> "abstract", "int", "short", "boolean", "interface", "static", "byte", > >> "long", "char", "final", "native", "synchronized", "float", "package", > >> "throws", "goto", "private", "transient", "implements", "protected", > >> "volatile", "double", "public", > > > > What a future it will be... > > > > Dan > > > > On Tue, Nov 17, 2009 at 3:11 PM, Freeland Abbott > wrote: > >> I don't promise this is exhaustive, but it catches up to the mozilla and > IE > >> references, plus uneval from issue 3965. (Which wasn't on the mozilla > >> pages, despite being reserved there, so I'm in fact almost sure this > >> isn't exhaustive...) > >> > >> -- > >> http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > -- > > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > > > > > -- > > > > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > > > > > > > -- > > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- If you received this communication by mistake, you are entitled to one free ice cream cone on me. Simply print out this email including all relevant SMTP headers and present them at my desk to claim your creamy treat. We'll have a laugh at my emailing incompetence, and play a game of ping pong. (offer may not be valid in all States). -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6976 committed - Adding a slew of reserved words, taken from mozilla and microsoft site...
Revision: 6976 Author: fabb...@google.com Date: Tue Nov 17 19:08:55 2009 Log: Adding a slew of reserved words, taken from mozilla and microsoft sites Fixes issue 3965. Review by: spoon http://code.google.com/p/google-web-toolkit/source/detail?r=6976 Modified: /trunk/dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java === --- /trunk/dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java Wed Oct 21 13:20:55 2009 +++ /trunk/dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java Tue Nov 17 19:08:55 2009 @@ -74,34 +74,86 @@ // B.2 Additional Properties (non-normative) "escape", "unescape", -// Window props (http://www.w3schools.com/HTMLDOM/dom_obj_window.asp) -"closed", "defaultStatus", "document", "frames", "history", "length", -"location", "name", "opener", "outerHeight", "outerWidth", -"pageXOffset", "pageYOffset", "parent", "personalbar", "scrollbars", -"self", "status", "statusbar", "toolbar", "top", - -// Window methods (http://www.w3schools.com/HTMLDOM/dom_obj_window.asp) -"alert", "blur", "clearInterval", "clearTimeout", "close", "confirm", -"createPopup", "focus", "moveBy", "moveTo", "open", "print", "prompt", -"resizeBy", "resizeTo", "scrollBy", "scrollTo", "setInterval", -"setTimeout", - -// IE event methods +// Window props (https://developer.mozilla.org/en/DOM/window) +"applicationCache", "closed", "Components", "content", "controllers", +"crypto", "defaultStatus", "dialogArguments", "directories", +"document", "frameElement", "frames", "fullScreen", "globalStorage", +"history", "innerHeight", "innerWidth", "length", +"location", "locationbar", "localStorage", "menubar", +"mozInnerScreenX", "mozInnerScreenY", "mozScreenPixelsPerCssPixel", +"name", "navigator", "opener", "outerHeight", "outerWidth", +"pageXOffset", "pageYOffset", "parent", "personalbar", "pkcs11", +"returnValue", "screen", "scrollbars", "scrollMaxX", "scrollMaxY", +"self", "sessionStorage", "sidebar", "status", "statusbar", "toolbar", +"top", "window", + +// Window methods (https://developer.mozilla.org/en/DOM/window) +"alert", "addEventListener", "atob", "back", "blur", "btoa", +"captureEvents", "clearInterval", "clearTimeout", "close", "confirm", +"disableExternalCapture", "dispatchEvent", "dump", +"enableExternalCapture", "escape", "find", "focus", "forward", +"GeckoActiveXObject", "getAttention", "getAttentionWithCycleCount", +"getComputedStyle", "getSelection", "home", "maximize", "minimize", +"moveBy", "moveTo", "open", "openDialog", "postMessage", "print", +"prompt", "QueryInterface", "releaseEvents", "removeEventListener", +"resizeBy", "resizeTo", "restore", "routeEvent", "scroll", "scrollBy", +"scrollByLines", "scrollByPages", "scrollTo", "setInterval", +"setResizeable", "setTimeout", "showModalDialog", "sizeToContent", +"stop", "uuescape", "updateCommands", "XPCNativeWrapper", +"XPCSafeJSOjbectWrapper", + +// Mozilla Window event handlers, same cite +"onabort", "onbeforeunload", "onchange", "onclick", "onclose", +"oncontextmenu", "ondragdrop", "onerror", "onfocus", "onhashchange", +"onkeydown", "onkeypress", "onkeyup", "onload", "onmousedown", +"onmousemove", "onmouseout", "onmouseover", "onmouseup", +"onmozorientation", "onpaint", "onreset", "onresize", "onscroll", +"onselect", "onsubmit", "onunload", + +// extra window methods +"uneval", + +// keywords https://developer.mozilla.org/en/New_in_JavaScript_1.7, +// https://developer.mozilla.org/en/New_in_JavaScript_1.8.1 +"getPrototypeOf", "let", + +// "future reserved words" +"abstract", "int", "short", "boolean", "interface", "static", "byte", +"long", "char", "final", "native", "synchronized", "float", "package", +"throws", "goto", "private", "transient", "implements", "protected", +"volatile", "double", "public", + +// IE methods // (http://msdn.microsoft.com/en-us/library/ms535873(VS.85).aspx#) +"attachEvent", "clientInformation", "clipboardData", "createPopup", +"dialogHeight", "dialogLeft", "dialogTop", "dialogWidth", "onafterprint", "onbeforedeactivate", "onbeforeprint", -"onbeforeunload", "onblur", "oncontrolselect", "ondeactivate", -"onerror", "onfocus", "onhashchange ", "onhelp", "onload", "onresize", -"onresizeend", "onscroll", -"onunload", +"oncontrolselect", "ondeactivate", "onhelp", "onresizeend", // Common browser-defined identifiers not defined in ECMAScript -"window", "dispatchEvent", "event", "external", "navigator", "screen", -"Debug"
[gwt-contrib] [google-web-toolkit] r6977 committed - Fix xhtml.ent url...
Revision: 6977 Author: rj...@google.com Date: Tue Nov 17 19:34:50 2009 Log: Fix xhtml.ent url TBR jgw http://code.google.com/p/google-web-toolkit/source/detail?r=6977 Modified: /trunk/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml === --- /trunk/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml Tue Nov 17 14:23:51 2009 +++ /trunk/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml Tue Nov 17 19:34:50 2009 @@ -1,5 +1,5 @@ http://google-web-toolkit.googlecode.com/files/xhtml.ent"; + SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent"; > http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] TBR: fix xhtml.net url in TopPanel.ui.xml
Joel, submitted this TBR you http://code.google.com/p/google-web-toolkit/source/detail?r=6977 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] adding new names to the blackout list
I thought the INTERCAL Front-end is next on the list of GWT input languages? -Ray On Tue, Nov 17, 2009 at 6:48 PM, Kelly Norton wrote: > Me, I'm holding out for the 'comefrom' statement. > > /kel > > > On Tue, Nov 17, 2009 at 9:31 PM, Bruce Johnson wrote: > >> +1 Freeland. You may then also like the planned "private goto", which >> goes somewhere but it doesn't tell you where it's gone. >> >> On Tuesday, November 17, 2009, Freeland Abbott >> wrote: >> > Personally, I'm holding out for "transient goto"... imagine being able >> to leap to another chunk of code, and then back again when it finishes! >> > >> > On Tue, Nov 17, 2009 at 5:27 PM, Bruce Johnson >> wrote: >> > I'm especially excited about "goto"! Think of how powerful and flexible >> that will be! >> > >> > >> > On Tue, Nov 17, 2009 at 3:13 PM, Daniel Rice (דניאל רייס) < >> r...@google.com> wrote: >> >> // "future reserved words" >> >> "abstract", "int", "short", "boolean", "interface", "static", "byte", >> >> "long", "char", "final", "native", "synchronized", "float", "package", >> >> "throws", "goto", "private", "transient", "implements", "protected", >> >> "volatile", "double", "public", >> > >> > What a future it will be... >> > >> > Dan >> > >> > On Tue, Nov 17, 2009 at 3:11 PM, Freeland Abbott >> wrote: >> >> I don't promise this is exhaustive, but it catches up to the mozilla >> and IE >> >> references, plus uneval from issue 3965. (Which wasn't on the mozilla >> >> pages, despite being reserved there, so I'm in fact almost sure this >> >> isn't exhaustive...) >> >> >> >> -- >> >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> > >> > -- >> > http://groups.google.com/group/Google-Web-Toolkit-Contributors >> > >> > >> > >> > -- >> > >> > http://groups.google.com/group/Google-Web-Toolkit-Contributors >> > >> > >> > >> > >> > -- >> > http://groups.google.com/group/Google-Web-Toolkit-Contributors >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> > > > > -- > If you received this communication by mistake, you are entitled to one free > ice cream cone on me. Simply print out this email including all relevant > SMTP headers and present them at my desk to claim your creamy treat. We'll > have a laugh at my emailing incompetence, and play a game of ping pong. > (offer may not be valid in all States). > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Reduce log levels, remove stderr launch URL message
There used to be a copy-pasteable URL in the DevMode log window of the app you started (removed in 6559), I found this hugely helpfull when i was new to devmode and could not remember the the ?gwt.codesrv or the magical path/directory it put the project in (altho it seems to always be just the root / now). -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r6978 committed - Merges tr...@6977 into releases/2.0...
Revision: 6978 Author: rj...@google.com Date: Tue Nov 17 19:58:44 2009 Log: Merges tr...@6977 into releases/2.0 Fix xhtml.ent url in mail/client/TopPanel.ui.xml svn merge --ignore-ancestry -c 6977 https://google-web-toolkit.googlecode.com/svn/trunk . http://code.google.com/p/google-web-toolkit/source/detail?r=6978 Modified: /releases/2.0/branch-info.txt /releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml === --- /releases/2.0/branch-info.txt Tue Nov 17 15:22:47 2009 +++ /releases/2.0/branch-info.txt Tue Nov 17 19:58:44 2009 @@ -750,3 +750,7 @@ tr...@6932 was merged into this branch Fixes bad code gen when css class names in a ui:style block have dashes in them svn merge --ignore-ancestry -c 6932 https://google-web-toolkit.googlecode.com/svn/trunk . + +tr...@6977 was merged into this branch + Fix xhtml.ent url in mail/client/TopPanel.ui.xml + svn merge --ignore-ancestry -c 6977 https://google-web-toolkit.googlecode.com/svn/trunk . === --- /releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml Tue Nov 17 14:29:07 2009 +++ /releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml Tue Nov 17 19:58:44 2009 @@ -1,5 +1,5 @@ http://google-web-toolkit.googlecode.com/files/xhtml.ent"; + SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent"; > http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Update IE plugin installer to install for the current user only
Reviewers: cramsdale, Description: The IE plugin installer fails on Windows 7 machines because it tries to install for all users. Fix: The installer now specifies that it should install for the current user only. Please review this at http://gwt-code-reviews.appspot.com/104805 Affected files: plugins/ie/installer/installer.wxs.xml plugins/ie/prebuilt/gwt-dev-plugin.msi Index: plugins/ie/installer/installer.wxs.xml === --- plugins/ie/installer/installer.wxs.xml (revision 6977) +++ plugins/ie/installer/installer.wxs.xml (working copy) @@ -4,7 +4,7 @@ - + ReallySuppress + + + Index: plugins/ie/prebuilt/gwt-dev-plugin.msi === Cannot display: file marked as a binary type. svn:mime-type = application/octet-stream -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] adding new names to the blackout list
I thought that was "protected goto"? Semi-seriously, I'm also somewhat amused by reserving "synchronized" but not, say, "wait" or "Thread"... On Tue, Nov 17, 2009 at 9:31 PM, Bruce Johnson wrote: > +1 Freeland. You may then also like the planned "private goto", which > goes somewhere but it doesn't tell you where it's gone. > > On Tuesday, November 17, 2009, Freeland Abbott wrote: > > Personally, I'm holding out for "transient goto"... imagine being able to > leap to another chunk of code, and then back again when it finishes! > > > > On Tue, Nov 17, 2009 at 5:27 PM, Bruce Johnson wrote: > > I'm especially excited about "goto"! Think of how powerful and flexible > that will be! > > > > > > On Tue, Nov 17, 2009 at 3:13 PM, Daniel Rice (דניאל רייס) < > r...@google.com> wrote: > >> // "future reserved words" > >> "abstract", "int", "short", "boolean", "interface", "static", "byte", > >> "long", "char", "final", "native", "synchronized", "float", "package", > >> "throws", "goto", "private", "transient", "implements", "protected", > >> "volatile", "double", "public", > > > > What a future it will be... > > > > Dan > > > > On Tue, Nov 17, 2009 at 3:11 PM, Freeland Abbott > wrote: > >> I don't promise this is exhaustive, but it catches up to the mozilla and > IE > >> references, plus uneval from issue 3965. (Which wasn't on the mozilla > >> pages, despite being reserved there, so I'm in fact almost sure this > >> isn't exhaustive...) > >> > >> -- > >> http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > -- > > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > > > > > -- > > > > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > > > > > > > -- > > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improve NumberFormat.format to avoid weird rounding issues
A quick and dirty test on Mac/Safari shows that the output of "Hello World! " + 3.1415926535E-20 + " " + 123456789 is not sensitive to the system locale setting. The numerical output uses a '.' and a lower-case 'e'. Dan On Tue, Nov 17, 2009 at 8:09 PM, Daniel Rice (דניאל רייס) wrote: > My thinking is that unless we provide an implementation of > Double.toString, we are best off trying to be consistent with the > implementation at hand. If we use Double.toString (i.e., just Javascript > native double-to-string conversion) some of the time, and use arithmetic ops > to extract fractional digits some of the time, we will always see corner > cases where things don't match. If we use Double.toString and extract > digits from that, at least the answers form a consistent set. > > I take your point that we can't rely on the specific characters '.' and > 'E'. Perhaps we can add some code to infer the right characters (caching > them after they have been determined), or validate some heuristic such as > 'digit=[0-9], exponential separator=[A-Za-z], decimal point=[anything > else]'. > > Dan > > > On Tue, Nov 17, 2009 at 5:14 PM, wrote: > >> There is a big overriding issue I am concerned about. I have not gone >> over all the logic until that is answered, but overall I am not sure >> this is better than improving the current approach. >> >> >> http://gwt-code-reviews.appspot.com/97812/diff/1/2 >> File user/src/com/google/gwt/i18n/client/NumberFormat.java (right): >> >> http://gwt-code-reviews.appspot.com/97812/diff/1/2#newcode1323 >> Line 1323: String digits = Double.toString(number); >> This essentially reduces to "" + number in JS -- how certain are we that >> the result is sufficiently predictable across all browsers and locales >> that we can get the correct result. For example, what happens in >> locales that use different decimal/comma separators, or something >> besides E for exponential notation? >> >> I am very leery of relying on this behavior. >> >> >> http://gwt-code-reviews.appspot.com/97812 >> > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update IE plugin installer to install for the current user only
Meta installer omits the "build" number. You'll need to update the patch number to be safe. http://gwt-code-reviews.appspot.com/104805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] adding new names to the blackout list
But with "volatile transient goto", we'll finally be able to do quantum computing in JavaScript. On Tue, Nov 17, 2009 at 7:01 PM, Freeland Abbott wrote: > Personally, I'm holding out for "transient goto"... imagine being able to > leap to another chunk of code, and then back again when it finishes! > > > On Tue, Nov 17, 2009 at 5:27 PM, Bruce Johnson wrote: > >> I'm especially excited about "goto"! Think of how powerful and flexible >> that will be! >> >> >> On Tue, Nov 17, 2009 at 3:13 PM, Daniel Rice (דניאל רייס) < >> r...@google.com> wrote: >> >>> > // "future reserved words" >>> > "abstract", "int", "short", "boolean", "interface", "static", "byte", >>> > "long", "char", "final", "native", "synchronized", "float", "package", >>> > "throws", "goto", "private", "transient", "implements", "protected", >>> > "volatile", "double", "public", >>> >>> What a future it will be... >>> >>> Dan >>> >>> On Tue, Nov 17, 2009 at 3:11 PM, Freeland Abbott >>> wrote: >>> > I don't promise this is exhaustive, but it catches up to the mozilla >>> and IE >>> > references, plus uneval from issue 3965. (Which wasn't on the mozilla >>> > pages, despite being reserved there, so I'm in fact almost sure this >>> > isn't exhaustive...) >>> > >>> > -- >>> > http://groups.google.com/group/Google-Web-Toolkit-Contributors >>> >>> -- >>> http://groups.google.com/group/Google-Web-Toolkit-Contributors >>> >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
