[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=321202&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321202 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 01/Oct/19 11:54 Start Date: 01/Oct/19 11:54 Worklog Time Spent: 10m Work Description: mxm commented on issue #9698: [BEAM-8021] Swap build-tools to be compile only so it isn't a "required" dependency of Flink. URL: https://github.com/apache/beam/pull/9698#issuecomment-537001462 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 321202) Time Spent: 9h 50m (was: 9h 40m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 9h 50m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=321149&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321149 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 01/Oct/19 09:37 Start Date: 01/Oct/19 09:37 Worklog Time Spent: 10m Work Description: lgajowy commented on pull request #9698: [BEAM-8021] Swap build-tools to be compile only so it isn't a "required" dependency of Flink. URL: https://github.com/apache/beam/pull/9698 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 321149) Time Spent: 9h 40m (was: 9.5h) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 9h 40m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=320905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320905 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 30/Sep/19 22:00 Start Date: 30/Sep/19 22:00 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9698: [BEAM-8021] Swap build-tools to be compile only so it isn't a "required" dependency of Flink. URL: https://github.com/apache/beam/pull/9698#issuecomment-536764603 R: @lgajowy @iemejia @aaltay @mxm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 320905) Time Spent: 9.5h (was: 9h 20m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 9.5h > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=320892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320892 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 30/Sep/19 21:40 Start Date: 30/Sep/19 21:40 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9698: [BEAM-8021] Swap build-tools to be compile only so it isn't a "required" dependency of Flink. URL: https://github.com/apache/beam/pull/9698#issuecomment-536764603 @lgajowy @iemejia @aaltay This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 320892) Time Spent: 9h 10m (was: 9h) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 9h 10m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=320894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320894 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 30/Sep/19 21:40 Start Date: 30/Sep/19 21:40 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9698: [BEAM-8021] Swap build-tools to be compile only so it isn't a "required" dependency of Flink. URL: https://github.com/apache/beam/pull/9698#issuecomment-536764603 R: @lgajowy @iemejia @aaltay This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 320894) Time Spent: 9h 20m (was: 9h 10m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 9h 20m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=320890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320890 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 30/Sep/19 21:38 Start Date: 30/Sep/19 21:38 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #9690: [BEAM-8021] Publish build-tools jar again due to flink runner usage issues URL: https://github.com/apache/beam/pull/9690 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 320890) Time Spent: 9h (was: 8h 50m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 9h > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=320889&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320889 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 30/Sep/19 21:38 Start Date: 30/Sep/19 21:38 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9690: [BEAM-8021] Publish build-tools jar again due to flink runner usage issues URL: https://github.com/apache/beam/pull/9690#issuecomment-536763886 Closing in favor of #9698 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 320889) Time Spent: 8h 50m (was: 8h 40m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 8h 50m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=320888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320888 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 30/Sep/19 21:37 Start Date: 30/Sep/19 21:37 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #9698: [BEAM-8021] Swap build-tools to be compile only so it isn't a "required" dependency of Flink. URL: https://github.com/apache/beam/pull/9698 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python37/lastC
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=320657&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320657 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 30/Sep/19 16:48 Start Date: 30/Sep/19 16:48 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9690: [BEAM-8021] Publish build-tools jar again due to flink runner usage issues URL: https://github.com/apache/beam/pull/9690#issuecomment-536648402 Shouldn't we mark https://github.com/apache/beam/blob/2acbfbd23a23ee6eed77cbe74690f66f985c9815/runners/flink/flink_runner.gradle#L102 `compileOnly` instead? It doesn't seem like Flink runner really wants to export build-tools as a dependency since the class in there is only an annotations that is used at build time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 320657) Time Spent: 8.5h (was: 8h 20m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 8.5h > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=320649&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320649 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 30/Sep/19 16:46 Start Date: 30/Sep/19 16:46 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9690: [BEAM-8021] Publish build-tools jar again due to flink runner usage issues URL: https://github.com/apache/beam/pull/9690#issuecomment-536648402 Shouldn't we mark https://github.com/apache/beam/blob/2acbfbd23a23ee6eed77cbe74690f66f985c9815/runners/flink/flink_runner.gradle#L102 `compileOnly` instead? It doesn't seem like Flink runner really wants to export build-tools as a dependency. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 320649) Time Spent: 8h 20m (was: 8h 10m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 8h 20m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=320468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320468 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 30/Sep/19 11:58 Start Date: 30/Sep/19 11:58 Worklog Time Spent: 10m Work Description: lgajowy commented on pull request #9690: [BEAM-8021] Publish build-tools jar again due to flink runner usage issues URL: https://github.com/apache/beam/pull/9690 Due to the fact that flink runner depends on build-tools, we need to publish it too. If not published, building a project depending on flink runner fails, because there is no build-tools jar on the classpath. Please look for more detailed description in the issue comments. @lukecwik or @mxm or @kennknowles could you take a look? Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[![Build St
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=318243&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318243 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 25/Sep/19 11:09 Start Date: 25/Sep/19 11:09 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-534971635 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 318243) Time Spent: 8h (was: 7h 50m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 8h > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=317841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317841 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 24/Sep/19 21:04 Start Date: 24/Sep/19 21:04 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317841) Time Spent: 7h 50m (was: 7h 40m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Fix For: 2.17.0 > > Time Spent: 7h 50m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=317829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317829
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 24/Sep/19 21:00
Start Date: 24/Sep/19 21:00
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r327830244
##
File path: model/job-management/build.gradle
##
@@ -17,10 +17,12 @@
*/
plugins { id 'org.apache.beam.module' }
-applyPortabilityNature(shadowJarValidationExcludes:[
-"org/apache/beam/model/expansion/v1/**",
-"org/apache/beam/model/jobmanagement/v1/**",
-])
+applyPortabilityNature(
+automaticModuleName: 'org.apache.beam.model.job.management',
+shadowJarValidationExcludes: [
+"org/apache/beam/model/expansion/v1/**",
Review comment:
```suggestion
// TODO: Migrate expansion service to separate module.
"org/apache/beam/model/expansion/v1/**",
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317829)
Time Spent: 7h 40m (was: 7.5h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=317830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317830
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 24/Sep/19 21:00
Start Date: 24/Sep/19 21:00
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r327831395
##
File path: sdks/java/io/common/build.gradle
##
@@ -17,7 +17,7 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(exportJavadoc: false)
+applyJavaNature(exportJavadoc: false, automaticModuleName:
'org.apache.beam.sdk.io.common')
Review comment:
I agree with you but let us revisit this once this PR is in so you don't
have to deal with so many merge conflicts/fix-ups.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317830)
Time Spent: 7h 40m (was: 7.5h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=317643&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317643
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 24/Sep/19 16:42
Start Date: 24/Sep/19 16:42
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r327720633
##
File path: sdks/java/io/common/build.gradle
##
@@ -17,7 +17,7 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(exportJavadoc: false)
+applyJavaNature(exportJavadoc: false, automaticModuleName:
'org.apache.beam.sdk.io.common')
Review comment:
@lukecwik I think that this module should also not be published - I think I
missed this. It contains only /test utilities and is used only by test code.
Let me know if you agree and if I should notify the devlist again or simply
stop publishing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317643)
Time Spent: 7.5h (was: 7h 20m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=317639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317639 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 24/Sep/19 16:35 Start Date: 24/Sep/19 16:35 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-534641065 @lukecwik you're right - I was too hasty. Reverted the name change to the previous state. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317639) Time Spent: 7h 20m (was: 7h 10m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 7h 20m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=313686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313686 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 17/Sep/19 13:01 Start Date: 17/Sep/19 13:01 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-532210056 @lukecwik I posted another round of fixes, more specifically: - nexmark, test-utils and expansion-service are still published with a proper atomaticModuleName. This comes from the devlist discussion. - I changed the prefixes of module names such as `org.apache.beam.sdk...` names to `org.apache.beam.sdks.java...`. I think we should still include the sdk name in case we have different sdks in JVM languages (kotlin?, scala?). As far as I understand, they will also require the automaticModuleName so it's good to prevent possible future collisions. Could you take a look again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 313686) Time Spent: 7h 10m (was: 7h) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 7h 10m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=305949&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-305949 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 03/Sep/19 22:45 Start Date: 03/Sep/19 22:45 Worklog Time Spent: 10m Work Description: pabloem commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-527669082 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 305949) Time Spent: 7h (was: 6h 50m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 7h > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=304576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304576 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 30/Aug/19 20:18 Start Date: 30/Aug/19 20:18 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-526735607 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 304576) Time Spent: 6h 50m (was: 6h 40m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 6h 50m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302918 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 28/Aug/19 14:38 Start Date: 28/Aug/19 14:38 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-525775538 Thanks! I posted the fixes for zetasketch, removed the legacy-worker's unneeded module name and added the documentation. Now I'll think about the task you suggested (`validateShadedJarDoesntLeakNonProjectClasses`). Let's also wait for the devlist to respond a few days. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302918) Time Spent: 6h 40m (was: 6.5h) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 6h 40m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302897 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 28/Aug/19 14:15 Start Date: 28/Aug/19 14:15 Worklog Time Spent: 10m Work Description: lgajowy commented on pull request #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#discussion_r318606098 ## File path: runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle ## @@ -81,6 +81,7 @@ def excluded_dependencies = [ ] applyJavaNature( +automaticModuleName: 'org.apache.beam.runners.dataflow.legacy.worker', Review comment: Good catch, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302897) Time Spent: 6.5h (was: 6h 20m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 6.5h > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302896&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302896 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 28/Aug/19 14:11 Start Date: 28/Aug/19 14:11 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-525763542 @lukecwik devlist thread: https://lists.apache.org/thread.html/379d5b6a556530b157b3bafdb21d135152cba6f65d87a9bc7d2f8246@%3Cdev.beam.apache.org%3E This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302896) Time Spent: 6h 20m (was: 6h 10m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 6h 20m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302841 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 28/Aug/19 13:19 Start Date: 28/Aug/19 13:19 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#discussion_r318571902 ## File path: runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle ## @@ -81,6 +81,7 @@ def excluded_dependencies = [ ] applyJavaNature( +automaticModuleName: 'org.apache.beam.runners.dataflow.legacy.worker', Review comment: This isn't needed since this module isn't published. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302841) Time Spent: 6h 10m (was: 6h) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 6h 10m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302840&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302840
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 28/Aug/19 13:19
Start Date: 28/Aug/19 13:19
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318570104
##
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##
@@ -130,6 +130,13 @@ class BeamModulePlugin implements Plugin {
/** Controls whether javadoc is exported for this project. */
boolean exportJavadoc = true
+
+/**
+ * Automatic-Module-Name Header value to be set in MANFIEST.MF file.
+ *
+ * @see:
https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/library-best-practices/JLBP-20.md
Review comment:
Please add a comment that this is a required parameter unless publish is
disabled here and where you added the parameter below.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302840)
Time Spent: 6h 10m (was: 6h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302788 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 28/Aug/19 11:57 Start Date: 28/Aug/19 11:57 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-525711581 @lukecwik thank you. I agree that we should not publish the artifacts in the first place. What I didn't realize is that this is a matter of setting one `publish` switch in nature's configuration. I changed the PR according to your suggestions. Could you take a look again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302788) Time Spent: 6h (was: 5h 50m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 6h > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302786 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 28/Aug/19 11:56 Start Date: 28/Aug/19 11:56 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-525711581 @lukecwik thank you. I agree that we should not publish the artifacts in the first place. What I didn't realize is that this is a matter of setting one `publish` switch in nature's configuration. I changed the PR according to your suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302786) Time Spent: 5h 50m (was: 5h 40m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 5h 50m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302397
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:49
Start Date: 27/Aug/19 20:49
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318285384
##
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##
@@ -123,13 +123,31 @@ class BeamModulePlugin implements Plugin {
*
* The shadowJar / shadowTestJar tasks execute the specified closure to
configure themselves.
*/
-Closure shadowClosure;
+Closure shadowClosure
/** Controls whether this project is published to Maven. */
boolean publish = true
/** Controls whether javadoc is exported for this project. */
boolean exportJavadoc = true
+
+/**
+ * Controls whether Automatic Module Header name should be set in
MANIFEST.MF file.
+ *
+ * Set to false if a module should not have this header. It happens when
we know for sure
+ * that a module should not be depended on. This includes the following
cases:
+ * - a module contains documentation only (javadoc)
+ * - pure testing modules (e.g. "file-based-io-tests" module)
+ * - Apache Beam usage examples
+ */
Review comment:
add `Binaries such as the SQL shell`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302397)
Time Spent: 5.5h (was: 5h 20m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302399
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:49
Start Date: 27/Aug/19 20:49
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318279275
##
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##
@@ -143,7 +161,25 @@ class BeamModulePlugin implements Plugin {
List shadowJarValidationExcludes = ["org/apache/beam/**"]
/** Override the default "beam-" + `dash separated path` archivesBaseName.
*/
-String archivesBaseName = null;
+String archivesBaseName = null
+
+/**
+ * Controls whether Automatic Module Header name should be set in
MANIFEST.MF file.
+ *
+ * Set to false if a module should not have this header. It happens when
we know for sure
+ * that a module should not be depended on. This includes the following
cases:
+ * - a module contains documentation only (javadoc)
+ * - pure testing modules (e.g. "file-based-io-tests" module)
+ * - Apache Beam usage examples
Review comment:
add `Binaries such as the SQL shell`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302399)
Time Spent: 5h 40m (was: 5.5h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302384&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302384
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318283629
##
File path: sdks/java/io/elasticsearch-tests/elasticsearch-tests-5/build.gradle
##
@@ -18,6 +18,7 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature(
+setAutomaticModuleName: false,
Review comment:
Can we disable publishing of this instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302384)
Time Spent: 4h (was: 3h 50m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 4h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302396
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318287417
##
File path: sdks/java/maven-archetypes/examples/build.gradle
##
@@ -17,7 +17,7 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(exportJavadoc: false)
+applyJavaNature(exportJavadoc: false, setAutomaticModuleName: false)
Review comment:
Use `org.apache.beam.maven_archetypes.examples`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302396)
Time Spent: 5h 20m (was: 5h 10m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302389
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318287980
##
File path: sdks/java/javadoc/build.gradle
##
@@ -24,7 +24,7 @@
* used as part of the beam-site source tree.
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature()
+applyJavaNature(setAutomaticModuleName: false)
Review comment:
I don't think this should be published.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302389)
Time Spent: 4h 40m (was: 4.5h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302393
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318287603
##
File path: sdks/java/maven-archetypes/starter/build.gradle
##
@@ -17,7 +17,7 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(exportJavadoc: false)
+applyJavaNature(exportJavadoc: false, setAutomaticModuleName: false)
Review comment:
Use `org.apache.beam.maven_archetypes.starter`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302393)
Time Spent: 5h (was: 4h 50m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 5h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302383
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318283642
##
File path: sdks/java/io/elasticsearch-tests/elasticsearch-tests-2/build.gradle
##
@@ -18,6 +18,7 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature(
+setAutomaticModuleName: false,
Review comment:
Can we disable publishing of this instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302383)
Time Spent: 4h (was: 3h 50m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 4h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302377
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318279275
##
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##
@@ -143,7 +161,25 @@ class BeamModulePlugin implements Plugin {
List shadowJarValidationExcludes = ["org/apache/beam/**"]
/** Override the default "beam-" + `dash separated path` archivesBaseName.
*/
-String archivesBaseName = null;
+String archivesBaseName = null
+
+/**
+ * Controls whether Automatic Module Header name should be set in
MANIFEST.MF file.
+ *
+ * Set to false if a module should not have this header. It happens when
we know for sure
+ * that a module should not be depended on. This includes the following
cases:
+ * - a module contains documentation only (javadoc)
+ * - pure testing modules (e.g. "file-based-io-tests" module)
+ * - Apache Beam usage examples
Review comment:
add `Binaries such as the SQL shell`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302377)
Time Spent: 3h (was: 2h 50m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 3h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302386
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318284828
##
File path: examples/kotlin/build.gradle
##
@@ -22,7 +22,7 @@ plugins { id 'org.apache.beam.module'
id 'org.jetbrains.kotlin.jvm' version '1.3.21'
}
-applyJavaNature(exportJavadoc: false)
+applyJavaNature(exportJavadoc: false, setAutomaticModuleName: false)
Review comment:
Use `org.apache.beam.sdks.examples.kotlin`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302386)
Time Spent: 4h 10m (was: 4h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302382&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302382
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318282931
##
File path: sdks/java/testing/nexmark/build.gradle
##
@@ -18,6 +18,7 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature(
+setAutomaticModuleName: false,
Review comment:
Can we disable publishing of this instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302382)
Time Spent: 3h 50m (was: 3h 40m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302385
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318285036
##
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##
@@ -143,7 +161,25 @@ class BeamModulePlugin implements Plugin {
List shadowJarValidationExcludes = ["org/apache/beam/**"]
/** Override the default "beam-" + `dash separated path` archivesBaseName.
*/
-String archivesBaseName = null;
+String archivesBaseName = null
+
+/**
+ * Controls whether Automatic Module Header name should be set in
MANIFEST.MF file.
+ *
+ * Set to false if a module should not have this header. It happens when
we know for sure
+ * that a module should not be depended on. This includes the following
cases:
+ * - a module contains documentation only (javadoc)
+ * - pure testing modules (e.g. "file-based-io-tests" module)
Review comment:
These shouldn't be published.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302385)
Time Spent: 4h 10m (was: 4h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302381
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318283701
##
File path: sdks/java/io/bigquery-io-perf-tests/build.gradle
##
@@ -17,7 +17,7 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(exportJavadoc: false)
+applyJavaNature(exportJavadoc: false, setAutomaticModuleName: false)
Review comment:
Can we disable publishing of this instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302381)
Time Spent: 3h 40m (was: 3.5h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302391
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318288090
##
File path: sdks/java/io/file-based-io-tests/build.gradle
##
@@ -17,7 +17,7 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(exportJavadoc: false)
+applyJavaNature(exportJavadoc: false, setAutomaticModuleName: false)
Review comment:
I don't think this should be published.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302391)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302380&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302380
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318280815
##
File path: examples/java/build.gradle
##
@@ -19,7 +19,7 @@
import groovy.json.JsonOutput
plugins { id 'org.apache.beam.module' }
-applyJavaNature(exportJavadoc: false)
+applyJavaNature(exportJavadoc: false, setAutomaticModuleName: false)
Review comment:
Use `org.apache.beam.sdks.examples`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302380)
Time Spent: 3.5h (was: 3h 20m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302388
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318284547
##
File path: runners/google-cloud-dataflow-java/worker/windmill/build.gradle
##
@@ -18,6 +18,7 @@
plugins { id 'org.apache.beam.module' }
applyPortabilityNature(
+automaticModuleName: 'org.apache.beam.runners.dataflow.worker.windmill',
Review comment:
Can we disable publishing instead?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302388)
Time Spent: 4.5h (was: 4h 20m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302378
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318282903
##
File path: sdks/java/testing/load-tests/build.gradle
##
@@ -18,6 +18,7 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature(
+setAutomaticModuleName: false,
Review comment:
Can we disable publishing of this instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302378)
Time Spent: 3h 10m (was: 3h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302392&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302392
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318282964
##
File path: sdks/java/testing/test-utils/build.gradle
##
@@ -18,6 +18,7 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature(
+automaticModuleName: 'org.apache.beam.sdk.testing.testutils',
Review comment:
Can we disable publishing of this instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302392)
Time Spent: 4h 50m (was: 4h 40m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302390
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318284119
##
File path: sdks/java/build-tools/build.gradle
##
@@ -17,6 +17,6 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(exportJavadoc: false)
+applyJavaNature(exportJavadoc: false, setAutomaticModuleName: false)
Review comment:
Can we disable publishing of this instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302390)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302395
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318285384
##
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##
@@ -123,13 +123,31 @@ class BeamModulePlugin implements Plugin {
*
* The shadowJar / shadowTestJar tasks execute the specified closure to
configure themselves.
*/
-Closure shadowClosure;
+Closure shadowClosure
/** Controls whether this project is published to Maven. */
boolean publish = true
/** Controls whether javadoc is exported for this project. */
boolean exportJavadoc = true
+
+/**
+ * Controls whether Automatic Module Header name should be set in
MANIFEST.MF file.
+ *
+ * Set to false if a module should not have this header. It happens when
we know for sure
+ * that a module should not be depended on. This includes the following
cases:
+ * - a module contains documentation only (javadoc)
+ * - pure testing modules (e.g. "file-based-io-tests" module)
+ * - Apache Beam usage examples
+ */
Review comment:
add `Binaries such as the SQL shell`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302395)
Time Spent: 5h 20m (was: 5h 10m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302379
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318282810
##
File path: sdks/java/testing/expansion-service/build.gradle
##
@@ -18,7 +18,7 @@
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
plugins { id 'org.apache.beam.module' }
-applyJavaNature()
+applyJavaNature(setAutomaticModuleName: false)
Review comment:
Can we disable publishing of this instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302379)
Time Spent: 3h 20m (was: 3h 10m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302394
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318283603
##
File path: sdks/java/io/elasticsearch-tests/elasticsearch-tests-6/build.gradle
##
@@ -18,6 +18,7 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature(
+setAutomaticModuleName: false,
Review comment:
Can we disable publishing of this instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302394)
Time Spent: 5h 10m (was: 5h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302387
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318283587
##
File path:
sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/build.gradle
##
@@ -18,6 +18,7 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature(
+setAutomaticModuleName: false,
Review comment:
Can we disable publishing of this instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 302387)
Time Spent: 4h 20m (was: 4h 10m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302044 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 27/Aug/19 14:49 Start Date: 27/Aug/19 14:49 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-525328195 I posted new fixes. Thanks to @iemejia 's comments I've read some more about the topic (https://blog.joda.org/2017/04/java-se-9-jpms-module-naming.html) and it turned out most of the names didn't adhere this rule: > Module names are strongly recommended to be the same as the name of the super-package. Therefore, I changed the name wherever it was needed. @iemejia, @kennknowles, @lukecwik could you take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302044) Time Spent: 2h 50m (was: 2h 40m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 2h 50m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302031 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 27/Aug/19 14:31 Start Date: 27/Aug/19 14:31 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-525328521 I also changed flink module name as @mxm suggested This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302031) Time Spent: 2h 40m (was: 2.5h) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 2h 40m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302030 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 27/Aug/19 14:30 Start Date: 27/Aug/19 14:30 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-525328195 I posted new fixes. Thanks to @iemejia 's comments I've read some more about the topic (https://blog.joda.org/2017/04/java-se-9-jpms-module-naming.html) and it turned out most of the names didn't adhere this rule: > Module names are strongly recommended to be the same as the name of the super-package. Therefore, I changed the name wherever it was needed. @iemejia could you take a look again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302030) Time Spent: 2.5h (was: 2h 20m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 2.5h > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301998
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 13:51
Start Date: 27/Aug/19 13:51
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9417: [BEAM-8021] Add
Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318092633
##
File path: runners/flink/1.5/build.gradle
##
@@ -28,6 +28,7 @@ project.ext {
main_resources_dirs = ["$basePath/src/main/resources"]
test_resources_dirs = ["$basePath/src/test/resources"]
archives_base_name = 'beam-runners-flink_2.11'
+ automatic_module_name = 'beam.runners.flink.2.11'
Review comment:
Exactly. That's why I would prefer `beam.runners.flink`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301998)
Time Spent: 2h 20m (was: 2h 10m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301992&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301992
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 13:45
Start Date: 27/Aug/19 13:45
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318089497
##
File path: runners/flink/1.5/build.gradle
##
@@ -28,6 +28,7 @@ project.ext {
main_resources_dirs = ["$basePath/src/main/resources"]
test_resources_dirs = ["$basePath/src/test/resources"]
archives_base_name = 'beam-runners-flink_2.11'
+ automatic_module_name = 'beam.runners.flink.2.11'
Review comment:
I think I misunderstood you before.
I did some thinking - If we decide to name the modules without version
`beam.runners.flink`, we will prevent users from importing 2 different versions
of Flink a once*. Preventing this sounds sane now but will it always be the
case?
According to my knowledge and current reasoning, the answer is "yes". Could
you confirm?
*JPMS will simply refuse to start a modulepath where two modules have the
same name, even if they contain different packages.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301992)
Time Spent: 2h 10m (was: 2h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301914
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 11:54
Start Date: 27/Aug/19 11:54
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9417: [BEAM-8021] Add
Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318037557
##
File path: runners/flink/1.5/build.gradle
##
@@ -28,6 +28,7 @@ project.ext {
main_resources_dirs = ["$basePath/src/main/resources"]
test_resources_dirs = ["$basePath/src/test/resources"]
archives_base_name = 'beam-runners-flink_2.11'
+ automatic_module_name = 'beam.runners.flink.2.11'
Review comment:
I would go without the version. No need to encode it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301914)
Time Spent: 2h (was: 1h 50m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 2h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301906
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 11:47
Start Date: 27/Aug/19 11:47
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318034976
##
File path: sdks/java/io/hadoop-common/build.gradle
##
@@ -17,7 +17,7 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature()
+applyJavaNature(automaticModuleName: 'beam.sdks.java.io.hadoop.common')
Review comment:
The reason I named it "common" is because it holds some commons so I didn't
want to block the hadoop name for the future.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301906)
Time Spent: 1h 40m (was: 1.5h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301907&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301907
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 11:47
Start Date: 27/Aug/19 11:47
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318035164
##
File path: runners/flink/1.5/build.gradle
##
@@ -28,6 +28,7 @@ project.ext {
main_resources_dirs = ["$basePath/src/main/resources"]
test_resources_dirs = ["$basePath/src/test/resources"]
archives_base_name = 'beam-runners-flink_2.11'
+ automatic_module_name = 'beam.runners.flink.2.11'
Review comment:
I will keep the version as Max suggests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301907)
Time Spent: 1h 50m (was: 1h 40m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301878&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301878
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 11:13
Start Date: 27/Aug/19 11:13
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318023455
##
File path: runners/google-cloud-dataflow-java/examples/build.gradle
##
@@ -19,7 +19,7 @@
import groovy.json.JsonOutput
plugins { id 'org.apache.beam.module' }
-applyJavaNature(publish: false, exportJavadoc: false)
+applyJavaNature(publish: false, exportJavadoc: false, setAutomaticModuleName:
false)
Review comment:
I'm still not 100% sure if we should leave modules without these headers, to
be honest. My motivation was to skip it in aggregated docs (javadoc module),
examples and testing modules because we know that people should not depend on
it (do we?). I also find it as a form of discouragement to depend on them so
but a very weak one.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301878)
Time Spent: 1.5h (was: 1h 20m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301863&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301863
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 27/Aug/19 10:36
Start Date: 27/Aug/19 10:36
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318010151
##
File path: model/fn-execution/build.gradle
##
@@ -17,7 +17,10 @@
*/
plugins { id 'org.apache.beam.module' }
-applyPortabilityNature(shadowJarValidationExcludes:
["org/apache/beam/model/fnexecution/v1/**"])
+applyPortabilityNature(
+automaticModuleName: 'beam.model.fn.execution',
Review comment:
You are right - I should change it as you suggest. There are strong
arguments to do so:
https://blog.joda.org/2017/04/java-se-9-jpms-module-naming.html
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301863)
Time Spent: 1h 20m (was: 1h 10m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301852&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301852 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 27/Aug/19 10:02 Start Date: 27/Aug/19 10:02 Worklog Time Spent: 10m Work Description: lgajowy commented on pull request #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#discussion_r317996912 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -38,6 +37,8 @@ import org.gradle.api.tasks.javadoc.Javadoc import org.gradle.api.tasks.testing.Test import org.gradle.testing.jacoco.tasks.JacocoReport +import java.util.concurrent.atomic.AtomicInteger Review comment: I think I have something incorrectly set up in my formatting rules. According to our convention in Beam, there should be alphabetical order. I will change it back. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 301852) Time Spent: 1h 10m (was: 1h) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301135
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 26/Aug/19 09:56
Start Date: 26/Aug/19 09:56
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9417: [BEAM-8021] Add
Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r317535145
##
File path: runners/flink/1.5/build.gradle
##
@@ -28,6 +28,7 @@ project.ext {
main_resources_dirs = ["$basePath/src/main/resources"]
test_resources_dirs = ["$basePath/src/test/resources"]
archives_base_name = 'beam-runners-flink_2.11'
+ automatic_module_name = 'beam.runners.flink.2.11'
Review comment:
I think `beam.runners.flink` would suffice here. If you want to include the
version, you can use the new artifact naming convention, e.g.
`beam.runners.flink.1.5`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301135)
Time Spent: 1h (was: 50m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301079&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301079
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 26/Aug/19 08:22
Start Date: 26/Aug/19 08:22
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r317492913
##
File path: model/fn-execution/build.gradle
##
@@ -17,7 +17,10 @@
*/
plugins { id 'org.apache.beam.module' }
-applyPortabilityNature(shadowJarValidationExcludes:
["org/apache/beam/model/fnexecution/v1/**"])
+applyPortabilityNature(
+automaticModuleName: 'beam.model.fn.execution',
Review comment:
wondering if for this and the other modules it would be better to have the
fully qualified name: `org.apache.beam.model.fn.execution`,
`org.apache.beam`. It could be long but it seems to be the convention, What
do others think?
I assume that some project can choose the beam project and have some clash
with us, however in principle nobody will choose the fully qualified Apache
path.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301079)
Time Spent: 40m (was: 0.5h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301082
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 26/Aug/19 08:22
Start Date: 26/Aug/19 08:22
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r317496489
##
File path: runners/google-cloud-dataflow-java/examples/build.gradle
##
@@ -19,7 +19,7 @@
import groovy.json.JsonOutput
plugins { id 'org.apache.beam.module' }
-applyJavaNature(publish: false, exportJavadoc: false)
+applyJavaNature(publish: false, exportJavadoc: false, setAutomaticModuleName:
false)
Review comment:
I suppose this does not have automtatic module name because people are not
suppose to build from it? We should probably document this as part of
`setAutomaticModuleName`in `BeamModulePlugin.groovy`. In what particular
reasons we do not set automatic module names. I suppose this will be the case
also for some test pure modules like the Elasticsearch ones.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301082)
Time Spent: 50m (was: 40m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301081&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301081
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 26/Aug/19 08:22
Start Date: 26/Aug/19 08:22
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r317497651
##
File path: sdks/java/io/hadoop-common/build.gradle
##
@@ -17,7 +17,7 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature()
+applyJavaNature(automaticModuleName: 'beam.sdks.java.io.hadoop.common')
Review comment:
This is a valid name, but I somehow expected it to coincide with the package
definition in the code, currently `org.apache.beam.sdk.io.hadoop` I think is ok
as it is, but maybe someone else can argue pro being consistent.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301081)
Time Spent: 50m (was: 40m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301078
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 26/Aug/19 08:22
Start Date: 26/Aug/19 08:22
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r317495310
##
File path: runners/flink/1.5/build.gradle
##
@@ -28,6 +28,7 @@ project.ext {
main_resources_dirs = ["$basePath/src/main/resources"]
test_resources_dirs = ["$basePath/src/test/resources"]
archives_base_name = 'beam-runners-flink_2.11'
+ automatic_module_name = 'beam.runners.flink.2.11'
Review comment:
I don't know if the _2.11 path will be removed in the future I suppose that
naming it with the exact version is probably better. Maybe @mxm may have a say.
I am wondering also if the `.` in the version of the name can produce
unintented consequences (package wise) in Java 11 but I don't think so.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 301078)
Time Spent: 40m (was: 0.5h)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301080 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 26/Aug/19 08:22 Start Date: 26/Aug/19 08:22 Worklog Time Spent: 10m Work Description: iemejia commented on pull request #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#discussion_r317492276 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -38,6 +37,8 @@ import org.gradle.api.tasks.javadoc.Javadoc import org.gradle.api.tasks.testing.Test import org.gradle.testing.jacoco.tasks.JacocoReport +import java.util.concurrent.atomic.AtomicInteger Review comment: I suppose this comes from autoformatting, if so it feels a bit weird to have separate blocks for these imports compared to the Java ones, curious. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 301080) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301066 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 26/Aug/19 07:58 Start Date: 26/Aug/19 07:58 Worklog Time Spent: 10m Work Description: iemejia commented on issue #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#issuecomment-524759754 I am adding to the review both @lukecwik and @kennknowles since both are probably the most knowledgeable people about the Beam build system and may also spot some unnamed artifact or Java 11 consequence easily. I think we need to look at this with extreme detail. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 301066) Time Spent: 0.5h (was: 20m) > Add Automatic-Module-Name headers for Beam Java modules > > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Ismaël Mejía >Assignee: Lukasz Gajowy >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=300361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300361
]
ASF GitHub Bot logged work on BEAM-8021:
Author: ASF GitHub Bot
Created on: 23/Aug/19 16:22
Start Date: 23/Aug/19 16:22
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r317206852
##
File path: runners/flink/1.5/build.gradle
##
@@ -28,6 +28,7 @@ project.ext {
main_resources_dirs = ["$basePath/src/main/resources"]
test_resources_dirs = ["$basePath/src/test/resources"]
archives_base_name = 'beam-runners-flink_2.11'
+ automatic_module_name = 'beam.runners.flink.2.11'
Review comment:
I am not sure if this is the right module name for flink in different
versions but couldn't come up with anything else. Please take extra look here.
:)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 300361)
Time Spent: 20m (was: 10m)
> Add Automatic-Module-Name headers for Beam Java modules
>
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Lukasz Gajowy
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules
[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=300360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300360 ] ASF GitHub Bot logged work on BEAM-8021: Author: ASF GitHub Bot Created on: 23/Aug/19 16:21 Start Date: 23/Aug/19 16:21 Worklog Time Spent: 10m Work Description: lgajowy commented on pull request #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417 The motivation is best described here: https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/library-best-practices/JLBP-20.md Quote: "For compatibility with the Java Platform Module System (JPMS) in Java 9 and later, every JAR you publish should have a module name, even if the library does not itself use modules. More precisely, the JAR manifest in META-INF/MANIFEST.MF should have an Automatic-Module-Name field" R: @iemejia could you take a look? In case you think someone else should take a look too (it's a big pr, sorry) feel free to tag them Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apac
