D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

[Pino Toscano]

pino added a comment.


  Polite ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13549

To: pino, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13670: Add subseq operator to match sub-sequences

[Michael Eden]

michaeleden added a comment.


  @dfaure if a user was trying to find `LibreOffice 6.0 Writer`
  
  with `subin` they would have type `libre` to narrow it down to LibreOffice 
programs, then `libreoffice 6.0 writer` to get to that application.
  with `subseq` they can type `libre` to get to LibreOffice programs but then 
just have `librewrite` match with `LibreOffice 6.0 Writer`
  
  This is related to Bug 262837 

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D13670

To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 - Build # 12 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.10/12/
 Project:
Frameworks knewstuff kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 25 Jun 2018 03:23:53 +
 Build duration:
1 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kmoretoolstest

D13706: [KMoreTools] Enable installing tools via appstream url

[Nathaniel Graham]

ngraham added a comment.


  @gregormi
  
  > Mostly, desktopEntryName and appstreamComponentId are equal. So, maybe one 
could use a placeholder (e.g. ~) to reuse the desktopEntryName
  
  Keep in mind that AppStream IDs are not guessable. Some apps use the correct 
format, e.g. "org.kde.konsole", while others just re-use their desktop file's 
filename (e.g. gucharmap.desktop). It's app-specific and can't be 
programmatically determined.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: ngraham, dhaumann, kde-frameworks-devel, michaelh, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[gregormi]

gregormi accepted this revision.
gregormi added a comment.


  Ok from my side. Probably Dominik also wants to approve.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> nicolasfella wrote in kmoretools_p.h:394
> + would give the same result. What % does is acting as a QStringBuilder, 
> which is more performant in theory (not that it really matters in this case)

See http://doc.qt.io/qt-5/qstring.html#more-efficient-string-construction for a 
detailed explanation

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> gregormi wrote in kmoretools_p.h:394
> What does the % sign do here? Can this be used to concatenate strings? Did 
> not try it myself.
> 
> Otherwise ready to land.

+ would give the same result. What % does is acting as a QStringBuilder, which 
is more performant in theory (not that it really matters in this case)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[gregormi]

gregormi added inline comments.

INLINE COMMENTS

> kmoretools_p.h:394
> +
> +QUrl appstreamUrl = QUrl(QStringLiteral("appstream://") % 
> appstreamId);
> +

What does the % sign do here? Can this be used to concatenate strings? Did not 
try it myself.

Otherwise ready to land.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Nicolas Fella]

nicolasfella updated this revision to Diff 36620.
nicolasfella added a comment.


  - Replace appstreamUrl with appstreamId

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13706?vs=36617=36620

BRANCH
  appstream

REVISION DETAIL
  https://phabricator.kde.org/D13706

AFFECTED FILES
  src/kmoretools/kmoretools.cpp
  src/kmoretools/kmoretools.h
  src/kmoretools/kmoretools_p.h
  src/kmoretools/kmoretoolsconfigdialog_p.cpp
  src/kmoretools/kmoretoolspresets.cpp

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[gregormi]

gregormi added inline comments.

INLINE COMMENTS

> kmoretoolspresets.cpp:59
>  //
> -ADD_ENTRY("angrysearch",0, 
> "https://github.com/DoTheEvo/ANGRYsearch;);
> -ADD_ENTRY("com.uploadedlobster.peek",   0, 
> "https://github.com/phw/peek;); // easy to use screen recorder, creates gif
> -ADD_ENTRY("catfish",1, 
> "http://www.twotoasts.de/index.php/catfish/;);
> -ADD_ENTRY("ding",   0, 
> "https://www-user.tu-chemnitz.de/~fri/ding/;); // Offline dict, Online: 
> http://dict.tu-chemnitz.de/dings.cgi
> -ADD_ENTRY("disk",   0, 
> "https://en.opensuse.org/YaST_Disk_Controller;);
> -ADD_ENTRY("fontinst",   0, 
> "https://docs.kde.org/trunk5/en/kde-workspace/kcontrol/fontinst/;); // good 
> for previewing many fonts at once
> -ADD_ENTRY("fontmatrix", 0, 
> "https://github.com/fontmatrix/fontmatrix;);
> -ADD_ENTRY("fsearch",0, 
> "http://www.fsearch.org/;);
> -ADD_ENTRY("giggle", 1, 
> "https://wiki.gnome.org/Apps/giggle/;); // good for searching in history
> -ADD_ENTRY("git-cola-folder-handler",1, 
> "https://git-cola.github.io;);
> -ADD_ENTRY("git-cola-view-history.kmt-edition",  1, 
> "https://git-cola.github.io;);
> -ADD_ENTRY("gitk.kmt-edition",   1, 
> "http://git-scm.com/docs/gitk;);
> -ADD_ENTRY("qgit.kmt-edition",   1, 
> "http://libre.tibirna.org/projects/qgit;);
> -ADD_ENTRY("gitg",   1, 
> "https://wiki.gnome.org/action/show/Apps/Gitg?action=show=Gitg;);
> -ADD_ENTRY("gnome-search-tool",  0, 
> "https://help.gnome.org/users/gnome-search-tool/;); // has good filtering 
> options
> -ADD_ENTRY("gucharmap",  0, 
> "https://wiki.gnome.org/action/show/Apps/Gucharmap;);
> -ADD_ENTRY("gparted",0, "http://gparted.org;);
> -ADD_ENTRY("htop",   0, 
> "http://hisham.hm/htop/;);
> -ADD_ENTRY("hotshots",   1, 
> "http://sourceforge.net/projects/hotshots/;);
> -ADD_ENTRY("kaption",0, 
> "http://kde-apps.org/content/show.php/?content=139302;);
> -ADD_ENTRY("kding",  0, ""); // Offline dict; 
> unmaintained?
> -ADD_ENTRY("org.kde.kmousetool", 0, 
> "https://www.kde.org/applications/utilities/kmousetool/;);
> -ADD_ENTRY("org.gnome.clocks",   0, 
> "https://wiki.gnome.org/Apps/Clocks;);
> -ADD_ENTRY("org.kde.filelight",  1, 
> "https://utils.kde.org/projects/filelight;);
> -ADD_ENTRY("org.kde.kcharselect",0, 
> "https://utils.kde.org/projects/kcharselect/;);
> -ADD_ENTRY("org.kde.kdf",0, 
> "https://www.kde.org/applications/system/kdiskfree;);
> -ADD_ENTRY("org.kde.kfind",  1, 
> "https://www.kde.org/applications/utilities/kfind/;); // has good filtering 
> options
> -ADD_ENTRY("org.kde.partitionmanager",   0, 
> "https://www.kde.org/applications/system/kdepartitionmanager/;);
> -ADD_ENTRY("org.kde.plasma.cuttlefish.kmt-edition", 0, 
> "http://vizzzion.org/blog/2015/02/say-hi-to-cuttlefish/;);
> -ADD_ENTRY("org.kde.ksysguard",  0, 
> "https://userbase.kde.org/KSysGuard;);
> -ADD_ENTRY("org.kde.ksystemlog", 0, 
> "https://www.kde.org/applications/system/ksystemlog/;);
> -ADD_ENTRY("org.kde.ktimer", 0, 
> "https://www.kde.org/applications/utilities/ktimer/;);
> -ADD_ENTRY("org.kde.spectacle",  0, 
> "https://www.kde.org/applications/graphics/spectacle;);
> -ADD_ENTRY("simplescreenrecorder",   0, 
> "http://www.maartenbaert.be/simplescreenrecorder/;);
> -ADD_ENTRY("shutter",0, 
> "http://shutter-project.org;); // good for edit screenshot after capture
> -ADD_ENTRY("vokoscreen", 0, 
> "https://github.com/vkohaupt/vokoscreen;); // feature-rich screen recorder
> -ADD_ENTRY("xfce4-taskmanager",  0, 
> "http://goodies.xfce.org/projects/applications/xfce4-taskmanager;);
> +ADD_ENTRY("angrysearch",0, 
> "https://github.com/DoTheEvo/ANGRYsearch;, "");
> +ADD_ENTRY("com.uploadedlobster.peek",   0, 
> "https://github.com/phw/peek;, ""); // easy to use screen recorder, creates 
> gif

I have these thoughts when I see the ADD_ENTRY lines:

1. Appstream data is _the_ important source of app data. So I would move it 
directly after the URL count and before the homepage

2. Mostly, desktopEntryName and appstreamComponentId are equal. So, maybe one 
could use a placeholder (e.g. ~) to reuse the desktopEntryName

ADD_ENTRY("catfish", 

D13706: [KMoreTools] Enable installing tools via appstream url

[gregormi]

gregormi added inline comments.

INLINE COMMENTS

> kmoretools.h:500
> + */
> +void setAppstreamUrl(const QUrl& url);
> +

I am not so familiar with appstream. Why not only setting the COMPONENT-ID 
instead of the whole URL? Then the method would be named 
setAppstreamComponentId.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Nicolas Fella]

nicolasfella updated this revision to Diff 36617.
nicolasfella added a comment.


  - Add documentation

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13706?vs=36612=36617

BRANCH
  appstream

REVISION DETAIL
  https://phabricator.kde.org/D13706

AFFECTED FILES
  src/kmoretools/kmoretools.cpp
  src/kmoretools/kmoretools.h
  src/kmoretools/kmoretools_p.h
  src/kmoretools/kmoretoolsconfigdialog_p.cpp
  src/kmoretools/kmoretoolspresets.cpp

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Nicolas Fella]

nicolasfella marked 2 inline comments as done.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Looks already pretty good to me, but please add API documentation.
  
  Rule of thumb: if you extend a header file that is documented, then follow 
this scheme and also document your new functions

INLINE COMMENTS

> kmoretools.h:488
>  
> +QUrl appstreamUrl() const;
> +

API documentation is missing. Please also add @since 5.48, since this will be 
the next frameworks release, see: https://community.kde.org/Schedules/Frameworks

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[gregormi]

gregormi added a comment.


  First of all, thanks for adding this feature. This was missing a long time 
:-). I will do some comments in the code.

INLINE COMMENTS

> kmoretools.h:488-491
> +QUrl appstreamUrl() const;
> +
> +void setAppstreamUrl(const QUrl& url);
> +

Please add a comment and add something like "@since 5.xx" (see elsewhere in the 
this file) to indicate since which frameworks version this will be available.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Dominik Haumann]

dhaumann added a reviewer: gregormi.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

[Vincent Pinon]

vpinon added inline comments.

INLINE COMMENTS

> dschmidt wrote in FindIcoTool.cmake:1
> @vpinon Can you let me know what you want here?

Hello,
FindIcoTool.cmake is largely copied from FindPng2Ico.cmake, I'm even not sure I 
can really claim the copyright.
In any case, I would choose the same license as all other ECM files (among 
which FindPng2Ico.cmake), which doesn't give its name but I believe is LGPLv2?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D13698

To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 151 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/151/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 24 Jun 2018 16:53:57 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31773/59693)38%
(16088/42562)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8783/9213)51%
(3844/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8366/14396)50%
(4677/9301)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3926/7912)34%
(1590/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1013)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(628/1330)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
  

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 302 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/302/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 24 Jun 2018 16:53:57 +
 Build duration:
6 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31711/59693)38%
(16044/42564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8783/9213)51%
(3844/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8328/14396)50%
(4657/9297)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3925/7912)34%
(1589/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1013)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1767/4320)35%
(1295/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
  

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/57/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 24 Jun 2018 16:53:57 +
 Build duration:
4 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 34 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kdiroperatortestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfilecustomdialogtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiofilewidgets-kurlcomboboxtestFailed: TestSuite.kiofilewidgets-kurlnavigatortestFailed: TestSuite.kiofilewidgets-kurlrequestertestFailed: TestSuite.kiogui-favicontestFailed: TestSuite.kioslave-httpauthenticationtestFailed: TestSuite.kioslave-httpheaderdispositiontestFailed: TestSuite.kioslave-httpheadertokenizetestFailed: TestSuite.kioslave-httpobjecttestFailed: TestSuite.kioslave-kcookiejartestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-accessmanagertest-qnamFailed: TestSuite.kiowidgets-clipboardupdatertestFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-jobguitestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-kfileitemactionstestFailed: TestSuite.kiowidgets-krununittestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertestFailed: TestSuite.kiowidgets-kurlcompletiontestFailed: TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: TestSuite.kiowidgets-pastetestFailed: TestSuite.kpasswdservertest

D13706: [KMoreTools] Enable installing tools via appstream url

[Nicolas Fella]

nicolasfella updated this revision to Diff 36612.
nicolasfella added a comment.


  - Add kmousetool url

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13706?vs=36609=36612

BRANCH
  appstream

REVISION DETAIL
  https://phabricator.kde.org/D13706

AFFECTED FILES
  src/kmoretools/kmoretools.cpp
  src/kmoretools/kmoretools.h
  src/kmoretools/kmoretools_p.h
  src/kmoretools/kmoretoolsconfigdialog_p.cpp
  src/kmoretools/kmoretoolspresets.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13674: Make it possible to go up to root again

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1cea9463f471: Make it possible to go up to root again 
(authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13674?vs=36534=36611

REVISION DETAIL
  https://phabricator.kde.org/D13674

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kfilewidget.cpp

To: jtamate, dfaure, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Nicolas Fella]

nicolasfella updated this revision to Diff 36609.
nicolasfella added a comment.


  - Add more appstream urls

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13706?vs=36606=36609

BRANCH
  appstream

REVISION DETAIL
  https://phabricator.kde.org/D13706

AFFECTED FILES
  src/kmoretools/kmoretools.cpp
  src/kmoretools/kmoretools.h
  src/kmoretools/kmoretools_p.h
  src/kmoretools/kmoretoolsconfigdialog_p.cpp
  src/kmoretools/kmoretoolspresets.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Nicolas Fella]

nicolasfella updated this revision to Diff 36606.
nicolasfella added a comment.


  - Whitespace

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13706?vs=36604=36606

BRANCH
  appstream

REVISION DETAIL
  https://phabricator.kde.org/D13706

AFFECTED FILES
  src/kmoretools/kmoretools.cpp
  src/kmoretools/kmoretools.h
  src/kmoretools/kmoretools_p.h
  src/kmoretools/kmoretoolsconfigdialog_p.cpp
  src/kmoretools/kmoretoolspresets.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When a tool is not installed add an action to trigger the appstream url if 
available. This allows installing via Discover or other software stores.
  
  Add GParted url as example. More urls should be added

TEST PLAN
  Install GParted from Dolphin

REPOSITORY
  R304 KNewStuff

BRANCH
  appstream

REVISION DETAIL
  https://phabricator.kde.org/D13706

AFFECTED FILES
  src/kmoretools/kmoretools.cpp
  src/kmoretools/kmoretools.h
  src/kmoretools/kmoretools_p.h
  src/kmoretools/kmoretoolsconfigdialog_p.cpp
  src/kmoretools/kmoretoolspresets.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

[Dominik Schmidt]

dschmidt marked an inline comment as done.
dschmidt added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in FindIcoTool.cmake:1
> - Missing doc
> - Missing license

@vpinon Can you let me know what you want here?

> cgiboudeaux wrote in ECMAddAppIcon.cmake:105-106
> ECMAddAppIcon has an unit test in tests/ECMAddAppIconTest/
> Please check if you can test the new parameters.

Added a test for OUTFILE_BASENAME and WIP for SIDEBAR_ICONS.

Need to get my hands on a macOS system to test further...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D13698

To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13627: [KIconThemes] Isolate private data from race conditions

[David Faure]

dfaure added a comment.


  1. write a unittest for the use case you're trying to solve
  2. let's discuss if the use case is valid
  3. make the correct, minimal fix, for that use case

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D13627

To: anthonyfieroni, davidedmundson, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13674: Make it possible to go up to root again

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13674

To: jtamate, dfaure, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D13670: Add subseq operator to match sub-sequences

[David Faure]

dfaure added a comment.


  I'm confused, what's the difference with subin?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D13670

To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13700: implement reading of the replaygain tags

[Alexander Stippich]

astippich added a comment.


  In D13700#282253 , @bruns wrote:
  
  > "dB" is nothing more than deci-Bel, i.e. 0.1 Bel. You can convert the value 
to e.g. mB or uB. This looks unfamiliar, but is e.g. also used by the CRDA WiFi 
compliance tool.
  
  
  I know what dB is :) 
  The question here is actually if we want to store the unit within the string 
as it is stored in the metadata, e.g. "-9.90 dB" or if we go to floats and drop 
the unit from the property in KFileMetaData

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams