Re: Switch to CMS ... ?

[sebb]

On 6 May 2012 19:45, Robert Burrell Donkin  wrote:
> On 05/06/12 16:04, sebb wrote:
>>
>> On 6 May 2012 13:52, Robert Burrell Donkin  wrote:
>>>
>>> The next stage of the graduation hand-over is setting up the
>>> infrastructure
>>> for Apache Creadur TLP. This includes the website.
>>>
>>>
>>> I think there's generally positive feelings about the CMS, excepting
>>> committing Maven generated sites. As a user, I find the Maven sites for
>>> releases are useful. So, I suggest switching to the CMS and dropping the
>>> Maven sites for anything other than releases.
>>
>>
>> Not sure what you mean by that.
>
>
> (I'm still trying - and failing - to be meaningful and concise...)
>
>
>> How can there be a CMS site and a separate Maven site?
>> What URLs will these be using?
>
>
> We were experimenting [1] with checking in Maven sites...
>
> Checking generated Maven sites into the CMS (eg [2]) produces lots of commit
> messages (eg [3]), and is a little fiddly.

AFAICT, most of the commit message flood at [3] is because Javadoc
embeds a timestamp comment in the generated output.
I don't think that is entirely Maven's fault, though of course Maven
does not support rebuilding only the changed part of a site.

[Unfortunately using -Dmaven.javadoc.skip does not quite work, as
Maven creates an empty apidocs/index.html file]

I had the same problem with JMeter Javadoc when it was in SVN; I
solved that by post-processing the html files to remove the dates in
the comments.
The same could probably be done in the Maven pom if required.

>
> [1]
> http://mail-archives.apache.org/mod_mbox/incubator-rat-dev/201204.mbox/%3C4F8037FE.7050302%40blueyonder.co.uk%3E
> [2] http://rat.staging.apache.org/rat/rat/
> [3]
> http://mail-archives.apache.org/mod_mbox/incubator-rat-commits/201204.mbox/%3C20120407124344.BB6C523889BB%40eris.apache.org%3E
>
>
>>> If we're going to switch to the CMS, it will save some effort if we ask
>>> infrastructure to set it up for the new TLP domain.
>>>
>>> Opinions? Objections?
>>
>>
>> I think the CMS works well for sites that need frequent updates of
>> parts of the site.
>> For example, the main ASF site.
>>
>> Conversion to Markdown format can be a non-trivial exercise; although
>> there are some scripts, their output still needs some tweaking.
>> And there are some features of HTML which are not directly supported
>> by Markdown (e.g. numbered lists using alpha).
>>
>> For Maven sites that are generally only updated with each new release,
>> the fact that Maven sites cannot be built piecemeal is not an issue,
>> so is it worth the conversion effort?
>
>
> Rat is sparsely documented, but I had hoped to work on some new,
> user-centered content in the CMS and leave the existing stuff for releases.

Unless it is going to change much between releases, it could still be
done by Maven at release time.

However, there might be some restrictions imposed by CMS or Infra as
to which URLs can be used for Maven and non-Maven generated site
files.

Might be an idea to run the plan past infra before doing much work.

> We need some form of cohesive top level site for Apache Creadur, hopefully
> with some more documentation for users. The consensus seemed to be that
> using the CMS fits this well, and allows some products to use Maven and some
> to use the CMS for their documentation (by checking the Maven generated
> sites into CMS).

For new content, CMS is probably a good choice.

> Having tried it for a while, never me nor Stefan are particular keen[1]
> about regularly checking in Maven generated sites. I'd be happy just
> checking in the Maven generated documentation for each release.

Indeed, Maven-generated sites are best suited for release time docs.

> Robert
>
> [1]
> http://mail-archives.apache.org/mod_mbox/incubator-rat-dev/201204.mbox/%3C87lim5las5.fsf%40v35516.1blu.de%3E

Re: [DISCUSS] Names [WAS Re: Apache += Creadur]

[sebb]

On 6 May 2012 14:44, Robert Burrell Donkin  wrote:
> On 04/30/12 16:06, Stefan Bodewig wrote:
>>
>> On 2012-04-30, Mark Struberg wrote:
>
>
> 
>
>>> Will the name of the maven plugin change?
>>
>>
>> Creadur is the project name and Rat will remain being a product of the
>> Creadur project, so I'd not expect the name to change.  But we haven't
>> discussed this explicitly, yet.
>
>
> From a branding and trademark perspective, "Apache Rat" is fine as a product
> name. So, there's no reason why we need to change it.
>
> I think keeping "Apache Rat" as the name of founding product makes sense:
> its well known around Apache and changing the name creates work for plugin
> users.

+1

> Robert

Re: Switch to CMS ... ?

[sebb]

On 6 May 2012 13:52, Robert Burrell Donkin  wrote:
> The next stage of the graduation hand-over is setting up the infrastructure
> for Apache Creadur TLP. This includes the website.
>
>
> I think there's generally positive feelings about the CMS, excepting
> committing Maven generated sites. As a user, I find the Maven sites for
> releases are useful. So, I suggest switching to the CMS and dropping the
> Maven sites for anything other than releases.

Not sure what you mean by that.
How can there be a CMS site and a separate Maven site?
What URLs will these be using?

> If we're going to switch to the CMS, it will save some effort if we ask
> infrastructure to set it up for the new TLP domain.
>
> Opinions? Objections?

I think the CMS works well for sites that need frequent updates of
parts of the site.
For example, the main ASF site.

Conversion to Markdown format can be a non-trivial exercise; although
there are some scripts, their output still needs some tweaking.
And there are some features of HTML which are not directly supported
by Markdown (e.g. numbered lists using alpha).

For Maven sites that are generally only updated with each new release,
the fact that Maven sites cannot be built piecemeal is not an issue,
so is it worth the conversion effort?

AIUI, a Maven generated site can still be published with svnpubsub.

> Robert

[jira] [Created] (RAT-116) Docs don't say what the default excludes are

[Sebb (Created) (JIRA)]

Docs don't say what the default excludes are


 Key: RAT-116
 URL: https://issues.apache.org/jira/browse/RAT-116
 Project: RAT
  Issue Type: Bug
Reporter: Sebb


The description for "useDefaultExcludes" does not say what the excludes are.

The default should exclude .pmd but does not seem to.

Probably all .* files in the top level directory should be excluded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [VOTE] RAT Ready To Graduate As Apache Creadur Top Level Project

[sebb]

On 26 February 2012 16:03, Robert Burrell Donkin  wrote:
> The graduation guide[1] recommends that the Rat community demonstrates it's
> willingness to govern itself through a free VOTE before asking the IPMC to
> approve graduation. So, here it is :-)
>
> See [2] for a draft of the charter, excluding the list of initial
> committers. Unless anyone jumps into this thread, I'll assume that the
> current list of committers would be fine. Please read, review and jump in -
> but this is a vote on the principle of graduating now.
>
> This VOTE is open to all, and I'll tally this no early than Wednesday, 29
> Feb 2012 17:00 UTC.
>
> Robert
>
> --8<---
> [X] +1 the RAT community feels ready to graduate as Apache Creadur
> [ ] +0
> [ ] -0
> [ ] -1 Do not graduate RAT at this time
> ---
>
>
> [1] http://incubator.apache.org/guides/graduation.html#toplevel
> [2] Suggested Draft Charter:
>
>       WHEREAS, the Board of Directors deems it to be in the best
>       interests of the Foundation and consistent with the
>       Foundation's purpose to establish a Project Management
>       Committee charged with the creation and maintenance of
>       open-source software related to the comprehension and
>       auditing of software distributions for distribution at
>       no charge to the public.
>
>       NOW, THEREFORE, BE IT RESOLVED, that a Project Management
>       Committee (PMC), to be known as the "Apache Creadur Project",
>       be and hereby is established pursuant to Bylaws of the
>       Foundation; and be it further
>
>       RESOLVED, that the Apache Creadur Project be and hereby is
>       responsible for the creation and maintenance of open-source
>       software related to the comprehension and auditing of software
>       distributions for distribution at no charge to the public
>
>       RESOLVED, that the office of "Vice President, Apache Creadur" be
>       and hereby is created, the person holding such office to
>       serve at the direction of the Board of Directors as the chair
>       of the Apache Creadur Project, and to have primary responsibility
>       for management of the projects within the scope of
>       responsibility of the Apache Creadur Project; and be it further
>
>       RESOLVED, that the persons listed immediately below be and
>       hereby are appointed to serve as the initial members of the
>       Apache Creadur Project:
>
>       ...
>
>       NOW, THEREFORE, BE IT FURTHER RESOLVED, that Robert Burrell
>       Donkin be appointed to the office of Vice President, Apache
>       Creadur, to serve in accordance with and subject to the
>       direction of the Board of Directors and the Bylaws of the
>       Foundation until death, resignation, retirement, removal or
>       disqualification, or until a successor is appointed; and be
>       it further
>
>       RESOLVED, that the initial Apache Creadur PMC be and hereby is
>       tasked with the creation of a set of bylaws intended to
>       encourage open development and increased participation in the
>       Apache Creadur Project; and be it further
>
>       RESOLVED, that the Apache Creadur Project be and hereby
>       is tasked with the migration and rationalization of the Apache
>       Incubator RAT podling; and be it further
>
>       RESOLVED, that all responsibilities pertaining to the Apache
>       Incubator RAT podling encumbered upon the Apache Incubator
>       Project are hereafter discharged.
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>

Re: Pushing RAT snapshots to http://repository.apache.org/snapshots/

[sebb]

On 25 February 2012 22:27, Jochen Wiedmann  wrote:
> Everything should be configured to publish those snapshots by just
> running maven deploy. I did that once manually. There is no automatic
> publication in place. Until then, this is mainly a good opportunity to
> vaidate your deployment settings before deploying an actual release.

+1!

I'm told it's possible to deploy snapshots from Jenkins, so that could
be enabled if necessary.
And the job can be set to run only when SVN changes.

>
> On Sat, Feb 25, 2012 at 2:52 PM, lewis john mcgibbney
>  wrote:
>> Hi Rat Dev's,
>>
>> Recently preparing for a Gora release, and made the change to the
>> apache-rat-plugin because I was totally disssatisifed with the
>> maven-license-plugin, no community etc.
>>
>> Anyway, I tried to pull your 0.9-SNAPSHOT's from the above URI and
>> couldn't, upon checking it out I couldn't see any material of use in there
>> either. Is this being dealt with? Is it an issue? Will I open a Jira?
>>
>> Thanks
>>
>> Best
>>
>> Lewis
>
>
>
> --
> "Bildung kommt von Bildschirm und nicht von Buch, sonst hieße es ja Buchung."
> Dieter Hildebrandt

Re: Pushing RAT snapshots to http://repository.apache.org/snapshots/

[sebb]

On 25 February 2012 14:34, Stefan Bodewig  wrote:
> On 2012-02-25, lewis john mcgibbney wrote:
>
>> Anyway, I tried to pull your 0.9-SNAPSHOT's from the above URI and
>> couldn't, upon checking it out I couldn't see any material of use in there
>> either. Is this being dealt with? Is it an issue? Will I open a Jira?
>
> Honestly I don't have any idea which process is supposed to populate
> this, I don't recall us publishing snapshots at all.  Of course my
> memory may be failing on me.
>
> Are you sure you need 0.9-SNAPSHOT?  There haven't been that many
> changes except for some additional licenses we detect since 0.8.

If RAT uses maven it's easy enough to use Maven deploy, provided that
RAT is Nexus-enabled.
If it's not enabled, that should be done anyway.

> Stefan

[jira] [Reopened] (RAT-109) Return value of mkdirs() is not checked and no error handling occurs

[Sebb (Reopened) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RAT-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb reopened RAT-109:
--


There's a small window in the patch code which can potentially cause a failure, 
see https://issues.apache.org/jira/browse/JCI-67 for further details.

The checks need to be the other way round, i.e.

if(!parent.mkdirs() && !parent.exists()) { // or !isDirectory() as appropriate
throw...
}


> Return value of mkdirs() is not checked and no error handling occurs
> 
>
> Key: RAT-109
> URL: https://issues.apache.org/jira/browse/RAT-109
> Project: RAT
>  Issue Type: Bug
>Affects Versions: 0.9
> Environment: Revision: 1208077
>Reporter: Hugo Hirsch
> Fix For: 0.9
>
> Attachments: RAT106errorPatch.diff, RAT109checkmkdirsReturnValue.patch
>
>
> The code contains calls to mkdir() without checking its return value.
> Patch attached for classes:
> *   apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java
> *   apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java
> *   apache-rat-tasks/src/test/java/org/apache/rat/anttasks/ReportTest.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [Vote] renaming the project to creadur

[sebb]

On 29 November 2011 13:51, Robert Burrell Donkin  wrote:
> On 11/29/11 13:36, Gavin McDonald wrote:
>>
>>
>>> -Original Message-
>>> From: Robert Burrell Donkin [mailto:rdon...@apache.org]
>>> Sent: Tuesday, 29 November 2011 10:48 PM
>>> To: rat-dev@incubator.apache.org
>>> Subject: Re: [Vote] renaming the project to creadur
>>>
>>> On 11/29/11 07:30, Hugo Hirsch wrote:
 Hi,

 as pointed out before let's start voting to rename the project to 
 'creadur'.

 +1
>>>
>>> The way I see it, we don't need to rename anything. Were Rat going to an
>>> existing TLP, there would be no problem. The product names don't need to
>>> change. We just need consensus on the board motion.
>>>
>>> Robert
>>
>> Yes it is the 'project' we are renaming not the product. it was you yourself 
>> that
>> said 'RAT' would not pass.
>
> That's my best guess but IANAL. I am reasonably sure that it will take
> months of extra work to resolve conclusively whether Rat is suitable or
> not. But it is also possible that the brand team may surprise me and
> just approve Rat as a suitable name. Or the Incubator may remove the
> rule about trademarks and push the problem of names back to the board.
>
> Having Rat as a podling name is safe but may no longer be suitable as a
> top level project name. Officially renaming the podling would mean work
> changing URLs etc which isn't necessary.
>
> So I think the best tactic is just to get everything else sorted out and
> leave the name until the last minute.

Perhaps turn this vote into:

Accept Creadur as an alternative TLP name

or similar, in which case the vote will be ready if needed.
Would that work?

> Robert

Re: Lets get out of here (was: RE: Top Level Project Name)

[sebb]

On 29 November 2011 07:16, Gavin McDonald  wrote:
>
>
>> -Original Message-
>> From: Robert Burrell Donkin [mailto:rdon...@apache.org]
>> Sent: Sunday, 20 November 2011 5:44 AM
>> To: rat-dev@incubator.apache.org
>> Subject: Re: Top Level Project Name
>>
>> On 11/19/11 19:07, Gavin McDonald wrote:
>>
>> 
>>
>> > I am -0 on changing the name. RAT was simple name and meant what the
>> > product does.
>>
>> Those qualities make it more difficult from a trademark perspective...
>>
>> > (And by now, folks know what it means to produce a 'Rat Report' ,
>> > asking folks to produce a Creadur Report rolls off the tongue less.)
>>
>> "Apache Rat" is fine as a product name. There's no need to change that nor
>> stop talking about rat reports.
>>
>> "Creadur" would just be the top level project name, with tentacles,
> whisker,
>> rat and so on as different products. May end up releasing some "creadur"
>> stuff to keep Maven happy.
>>
>> > If words like 'Apple' and 'Windows' can be tm'd I don't see why Rat
>> > should be any different.
>>
>> Trademark law is quite unlike copyright. Apple and Microsoft have big
>> marketing budgets to build and defend their trademarks. Apache doesn't.
>>
>> > But I don't want to hold up the graduation so above are just thoughts
>> > I won't do anything about.
>>
>> Thanks
>
> Ok so to not hold up a graduation means actually doing something about
> graduating.
>
> I've poured through docs and I think we are done at this point, the IPMC can
> point
> out anything else rather than us look for faults. But now we have this thing
> called a
> project rename to deal with. So:
>
> 1. Create a [VOTE] thread someone please to rename the project  to creadur.
> 2. Vote to graduate.
> 3. Take that vote to the IPMC.
> 4. Elect a chair.
> 5. Do the move.
>
> I am not going to do 1. so if someone can kindly get that done.
> I will happily create the vote for 2.
> I will happily do 3.
> I will happily call a vote for who becomes chair, though I'd rather RBL or

s/RBL/RBD/ ?

> Stefan just get it.
>  (It's going to be one of them)
> I will happily as part of RAT and as part of INFRA perform much of the move
> to TLP
>
> There are zero excuses now, let's get out of here :)
>
> Gav...
>
>>
>> Robert
>

Re: Rat Maven Plugin - A few comments & questions

[sebb]

On 29 November 2011 10:12, Jochen Wiedmann  wrote:
> On Mon, Nov 28, 2011 at 10:23 PM, John W Vines  wrote:
>> 2. Ignore files by size - I saw in the website that with ant I could do a 
>> filter based on file size, but I couldn't find anything in the pom. Does 
>> this feature exist?
>
> Is there a JIRA issue for that one?

https://issues.apache.org/jira/browse/RAT-2

mentions ignoring empty files and says that the Ant task supports
selection by size.

> Jochen
>
>
> --
> Capitalism is the astounding belief that the most wickedest of men
> will do the most wickedest of things for the greatest good of
> everyone.
>
> John Maynard Keynes (http://en.wikiquote.org/wiki/Keynes)
>
> https://linuxcounter.net/user/221257.html

Re: RAT-103: Automated code formatting for better readability / Opinions

[sebb]

On 27 November 2011 12:30, Hugo Hirsch  wrote:
> Hi again,
>
> Am 27.11.2011 12:24, schrieb sebb:
>>> > Of course code can be reformatted in various ways - but my proposal runs
>>> > automatically and needs no fine tuning on each plattform or special
>>> > IDE-settings.
>> However, that does not automatically ensure that the reformatting
>> preserves comments in a readable format.
>>
>> I suggest you attach some sample before and after files to the JIRA.
>
> The plugin relies on a formatter.xml file - I attached a sample to RAT-103.
>
> No javadoc is touched. The reformatting only applies to code, not
> comments etc.

This can be a problem where comments are indented to agree with code.

> No logic etc. is changed at all! It's just a formatter.
>
> I applied a before/after of
> apache-rat-core/src/main/java/org/apache/rat/document/impl/guesser/BinaryGuesser.java
> to RAT-103.

I've replied there.

> The settings in the ratFormatter.xml can be tweaked if there any wishes
> :-) It's just a proposal to open discussion.
>
> HTH
> Hugo
>

[jira] [Commented] (RAT-103) Proposal: automatic code formatting based on an example eclipse formater with maven-java-formatter-plugin performed by mvn before each compilation

[Sebb (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/RAT-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157894#comment-13157894
 ] 

Sebb commented on RAT-103:
--

Thanks, that's very useful. 

It shows to me that automated formatters still have some way to go.

The changes up to about line 78 are OK, however most if not all of the 
subsequent changes don't improve readability as far as I'm concerned.

In particular (but not exclusively):
- The reformatted public static final String[] entries are really hard to read.
- The comment "// try a taste" at the end is no longer correctly indented
- 125,127c114,115 change is harder to read

As I wrote on the ML, start by fixing tabs and indentation; that can make a big 
difference and is unlikely to cause any problems.


> Proposal: automatic code formatting based on an example eclipse formater with 
> maven-java-formatter-plugin performed by mvn before each compilation
> --
>
> Key: RAT-103
> URL: https://issues.apache.org/jira/browse/RAT-103
> Project: RAT
>  Issue Type: Improvement
>  Components: maven
>Affects Versions: 0.9
> Environment: Trunk Revision: 1203844
>Reporter: Hugo Hirsch
>  Labels: maven
> Attachments: BinaryGuesser.java.diff, 
> RAT103pomAdditionOfFormatterPlugin.txt, ratFormatter.xml
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Currently the whole source code is not formatted uniquely (some classes use 
> C-style, some Java-style).
> The Apache2-licensed maven plugin 
> http://code.google.com/p/maven-java-formatter-plugin/ provides an automated 
> means to format the code uniquely with each compile.
> Since it changes the whole trunk I didn't include a full patch, but only an 
> example formater file that needs to be referenced and additions to pom.xml.
> h3. Pom Addition
> {code}
>  
>   
> com.googlecode.maven-java-formatter-plugin
> maven-java-formatter-plugin
> 0.3.1
> 
>   
> 
>   format
> 
>   
> 
> 
>   ./ratFormatter.xml
>   1.4
>   1.4
>   1.4
>   UTF-8
>   LF
> 
>   
> {code}
> The formatter file needs toi be put on a publicly readable place and is 
> referenced inside of the pom.
> h3. example formatter
> {code}
> 
> 
> 
>  id="org.eclipse.jdt.core.formatter.comment.insert_new_line_before_root_tags" 
> value="insert"/>
>  value="@formatter:off"/>
>  id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_annotation" 
> value="insert"/>
>  id="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_type_parameters"
>  value="do not insert"/>
>  id="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_type_declaration"
>  value="insert"/>
>  id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_type_arguments"
>  value="insert"/>
>  id="org.eclipse.jdt.core.formatter.brace_position_for_anonymous_type_declaration"
>  value="end_of_line"/>
>  id="org.eclipse.jdt.core.formatter.insert_space_before_colon_in_case" 
> value="do not insert"/>
>  id="org.eclipse.jdt.core.formatter.insert_space_after_opening_brace_in_array_initializer"
>  value="do not insert"/>
>  id="org.eclipse.jdt.core.formatter.comment.new_lines_at_block_boundaries" 
> value="true"/>
>  id="org.eclipse.jdt.core.formatter.insert_new_line_in_empty_annotation_declaration"
>  value="insert"/>
>  id="org.eclipse.jdt.core.formatter.insert_new_line_before_closing_brace_in_array_initializer"
>  value="do not insert"/>
>  id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_annotation"
>  value="do not insert"/>
>  value="0"/>
>  id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_while" 
> value="do not insert"/>
> 
>  id="org.eclipse.jdt.core.formatter.insert_space_between_empty_parens_in_annotation_type_member_declaration"
>  value="do not insert"/>
>  id="org.eclipse.jdt.core.formatter.insert_new_line_before

[jira] [Commented] (RAT-59) Upgrade To Java 1.5

[Sebb (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/RAT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157892#comment-13157892
 ] 

Sebb commented on RAT-59:
-

Note that Java 5 is required for the Maven 2.2.1 and Maven 3.x; many plugins 
also require it.

One can use profiles to ensure that an earlier version of Java is used for 
compilation and testing, so I don't think there's any need to support versions 
of Java earlier than 1.5 for the Maven plugin. [Apache Commons uses such 
profiles]

For stand-alone RAT, there's also no need to support earlier versions.

> Upgrade To Java 1.5
> ---
>
> Key: RAT-59
> URL: https://issues.apache.org/jira/browse/RAT-59
> Project: RAT
>  Issue Type: Task
>  Components: antlib, cli, docs, engine, jar-license-meta-data, 
> license-meta-data, maven, mime-meta-data, reports
>Reporter: Robert Burrell Donkin
> Attachments: java15.txt, java15_basedOnTrunkRev1201428.txt
>
>
> Java 1.4 is now deprecated and more libraries are now switching to Java 1.5. 
> RAT 0.6 is satisfactory, so users requiring 1.4 can continue to use that 
> version.
> See 
> http://mail-archives.apache.org/mod_mbox/incubator-rat-dev/200906.mbox/%3c4a38c694.5060...@blueyonder.co.uk%3e

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: RAT-103: Automated code formatting for better readability / Opinions

[sebb]

On 26 November 2011 12:17, Hugo Hirsch  wrote:
> Hi,
>
> thanks for your ideas.
>
> Am 26.11.2011 13:13, schrieb sebb:
>> Is there a single Java style? or C style for that matter?
>
> To my mind this is c-style:
>
> public void foo()
> {
> ...
>
> while this is java style:
> public void foo() {
> 
>
> This applies to many more code snippets :-p

I marginally prefer the latter, as it requires fewer lines, so one can
see more of the code on a single screen.

However the former is a bit easier to navigate visually; and it's
easier to temporarily change conditions. e.g.

if (condition)
{
code
}

can be easily changed to force the condition by commenting it (most
IDEs have a line comment toggle).
I used that only recently in some debugging I was doing.

But it's not a reason to change.

> Of course code can be reformatted in various ways - but my proposal runs
> automatically and needs no fine tuning on each plattform or special
> IDE-settings.

However, that does not automatically ensure that the reformatting
preserves comments in a readable format.

I suggest you attach some sample before and after files to the JIRA.

> Yours,
> Hugo
>

Re: RAT-103: Automated code formatting for better readability / Opinions

[sebb]

On 26 November 2011 12:02, Hugo Hirsch  wrote:
> Hi *,
>
> I've proposed an automated code formatting via Jira
> (https://issues.apache.org/jira/browse/RAT-103) -
> that means with each mvn run the sources are formatted based on a
> default formatter (attached to the issue as well).
>
> Thus there are major changes when the plugin is enabled. Afterwards
> reformatting only applies to patches.
>
> The main goal of this is a cleaner readability of the code since some
> parts are formatted in C-style, others in Java-style, others in free

Is there a single Java style? or C style for that matter?

;-)

> style :-) I'd be happy to see a uniquely formatted code before the
> project leaves the incubator.
>
> Any objections/opinions?

Unless the code is very badly formatted, I'm not sure it's worth the
extra effort.
I'm still finding mangled (badly wrapped) comments in code that was
reformatted years ago.

However, I would recommend at least:
- removing all tabs
- ensuring consistent indentation (Java 4 spaces; XML 4 or 2)

I think these can be done with little or no adverse affect.

Also, once those are done, re-inspect the code and see if is still too diverse.

> Yours
> Hugo
>
>

[jira] [Closed] (RAT-101) Download page does not include pointer to KEYS file or hashes

[Sebb (Closed) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RAT-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb closed RAT-101.



Thanks. all looks OK now.

> Download page does not include pointer to KEYS file or hashes
> -
>
> Key: RAT-101
> URL: https://issues.apache.org/jira/browse/RAT-101
> Project: RAT
>  Issue Type: Bug
>    Reporter: Sebb
>
> The RAT download page should have links to KEYS and hashes

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Download CGI script and site plugin

[sebb]

On 25 November 2011 05:26, Stefan Bodewig  wrote:
> Hi all,
>
> I've created a Commons-like download page for RAT
>
> 
>
> This consists of a small shell script and a corresponding HTML template
> generated from an xdoc page.
>
> I don't know how to ensure the CGI script is executable after site:site
> or more importantly after site:deploy.  So far I've deployed the site
> manually and made sure all permissions are correct.  Any ideas?

AFAIK, the Commons cgi scripts are not stored in SVN, so they are
created once on the server with the correct permissions.
They are all identical so it's easy to recreate one by renaming a copy.

> Stefan
>

Re: buildbot failure in ASF Buildbot on rat_trunk

[sebb]

On 21 November 2011 04:58, Stefan Bodewig  wrote:
> On 2011-11-21, Gavin McDonald wrote:
>
>>> -Original Message-
>>> From: sebb [mailto:seb...@gmail.com]
>
>>> It just seems odd to indent the header when the file contents is not
>>> indented.
>
>> ack, agree with that and spotted that was your point.
>
>>> I would expect either both to be indented 1 space, or neither.
>
>> exactly, is that not precisely what my commit did ?
>
> No, with your commit only the first line of the file's content is
> indented, not the whole content.
>
> Personally I'd prefer to not indent the header either if we strived for
> consistency.

Me too.

> Stefan
>

Re: buildbot failure in ASF Buildbot on rat_trunk

[sebb]

On 21 November 2011 01:12, Gavin McDonald  wrote:
>
>
>> -Original Message-----
>> From: sebb [mailto:seb...@gmail.com]
>> Sent: Monday, 21 November 2011 8:17 AM
>> To: rat-dev@incubator.apache.org; ga...@16degrees.com.au
>> Subject: Re: buildbot failure in ASF Buildbot on rat_trunk
>>
>> On 20 November 2011 08:30, Gavin McDonald 
>> wrote:
>> >
>> >
>> >> -Original Message-
>> >> From: Stefan Bodewig [mailto:bode...@apache.org]
>> >> Sent: Sunday, 20 November 2011 4:16 PM
>> >> To: rat-dev@incubator.apache.org
>> >> Cc: ga...@16degrees.com.au
>> >> Subject: Re: buildbot failure in ASF Buildbot on rat_trunk
>> >>
>> >> On 2011-11-19, Gavin McDonald wrote:
>> >>
>> >> > All I did here was add a space for alignment, I'm not seeing how
>> >> > that could make the reportTest fail:
>> >>
>> >> The test compares the generated report with an expected layout.  The
>> >> space you've added adds a two space characters into the report.
>> >>
>> >> The section that lists the first lines of the file without license
>> >> now has
>> > an
>> >> extra space in front of the very first line of the file.
>> >>
>> >> It seems to me as if RAT-3 has been re-intorduced by the change
>> >> rather
>> > than
>> >> fixed and the test was broken because it asserted RAT-3 was fixed (as
>> >> a
>> > side
>> >> effect it not really is a unit test or even specific for this issue).
>> >>
>> >> Sebb's comment on RAT-3 really is different from the original issue.
>> >
>> >
>> > True
>> >
>> >>
>> >> The original issue is about the snippet being different from the
>> >> actual
>> > content
>> >> of the file and I agree it shouldn't be.  I.e. I wouldn't want to
>> >> indent
>> > the
>> >> original file content at all.
>> >>
>> >> Sebb's comment is about the header above the file content being
>> >> indented while file content is not.  Not sure what t make out of it.
>> >> Whether an indented header is good or bad really is a matter of taste
> to
>> me.
>> >
>> > I thought my change made the content indented, which is exactly what
>> > he asked for.
>>
>> Not quite.
>>
>> The original problem was that the header and first line were indented.
>
> Correct, I spotted that.
>
>>
>> The original fix removed the extra first line indent.
>
> Yep, spotted that too.
>
>>
>> It just seems odd to indent the header when the file contents is not
>> indented.
>
> ack, agree with that and spotted that was your point.
>
>>
>> I would expect either both to be indented 1 space, or neither.
>
> exactly, is that not precisely what my commit did ?

No idea, not yet tested.

You wrote:

>> > I thought my change made the content indented, which is exactly what
>> > he asked for.

I did not specifically ask for the content (or header) to be indented.
I asked for the content indent to be consistent with the header.

As I previously wrote, that is "Not quite" the same.

==

With version 0.8, most headers (e.g. Summary, Archives) are not
indented at all, e.g.

*
Summary
---

Yet suddenly the last section is indented 1 space:

 *
 Printing headers for files without AL header...

 ===

Not sure why that should be; it looks odd to me.
Maybe it can be fixed for 0.9 - i.e. *remove* the 1 space indentation
for the final section.

> Gav...
>
>>
>> > If you disagree then by all means revert and close the issue,
>> > otherwise I'll look to make the test case match.
>> >
>> > Gav..
>> >
>> >>
>> >> Stefan
>> >
>> >
>
>

Re: buildbot failure in ASF Buildbot on rat_trunk

[sebb]

On 20 November 2011 08:30, Gavin McDonald  wrote:
>
>
>> -Original Message-
>> From: Stefan Bodewig [mailto:bode...@apache.org]
>> Sent: Sunday, 20 November 2011 4:16 PM
>> To: rat-dev@incubator.apache.org
>> Cc: ga...@16degrees.com.au
>> Subject: Re: buildbot failure in ASF Buildbot on rat_trunk
>>
>> On 2011-11-19, Gavin McDonald wrote:
>>
>> > All I did here was add a space for alignment, I'm not seeing how that
>> > could make the reportTest fail:
>>
>> The test compares the generated report with an expected layout.  The space
>> you've added adds a two space characters into the report.
>>
>> The section that lists the first lines of the file without license now has
> an
>> extra space in front of the very first line of the file.
>>
>> It seems to me as if RAT-3 has been re-intorduced by the change rather
> than
>> fixed and the test was broken because it asserted RAT-3 was fixed (as a
> side
>> effect it not really is a unit test or even specific for this issue).
>>
>> Sebb's comment on RAT-3 really is different from the original issue.
>
>
> True
>
>>
>> The original issue is about the snippet being different from the actual
> content
>> of the file and I agree it shouldn't be.  I.e. I wouldn't want to indent
> the
>> original file content at all.
>>
>> Sebb's comment is about the header above the file content being indented
>> while file content is not.  Not sure what t make out of it.  Whether an
>> indented header is good or bad really is a matter of taste to me.
>
> I thought my change made the content indented, which is exactly what he
> asked for.

Not quite.

The original problem was that the header and first line were indented.

The original fix removed the extra first line indent.

It just seems odd to indent the header when the file contents is not indented.

I would expect either both to be indented 1 space, or neither.

> If you disagree then by all means revert and close the issue, otherwise I'll
> look to make
> the test case match.
>
> Gav..
>
>>
>> Stefan
>
>

[jira] [Commented] (RAT-101) Download page does not include pointer to KEYS file or hashes

[Sebb (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/RAT-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152056#comment-13152056
 ] 

Sebb commented on RAT-101:
--

Commons projects use the commons-build plugin to create download_component.xml 
which creates the .html as part of mvn site; the download_component.cgi file is 
manually created and referenced in site.xml

I suspect the plugin may be too Commons-specific to use, but you could just 
copy an existing download_*.xml file and modify that manually.

> Download page does not include pointer to KEYS file or hashes
> -
>
> Key: RAT-101
> URL: https://issues.apache.org/jira/browse/RAT-101
> Project: RAT
>  Issue Type: Bug
>Reporter: Sebb
>
> The RAT download page should have links to KEYS and hashes

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (RAT-101) Download page does not include pointer to KEYS file or hashes

[Sebb (Created) (JIRA)]

Download page does not include pointer to KEYS file or hashes
-

 Key: RAT-101
 URL: https://issues.apache.org/jira/browse/RAT-101
 Project: RAT
  Issue Type: Bug
Reporter: Sebb


The RAT download page should have links to KEYS and hashes

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Issues with 0.8 RC1 (was Re: [VOTE] Release Apache RAT Incubating 0.8 based on RC1)

[sebb]

On 8 November 2011 05:05, Stefan Bodewig  wrote:
> On 2011-11-07, sebb wrote:
>
>> The file:
>> apache-rat-core/src/test/resources/binaries/UTF16_with_signature.xml
>> in all source archives appears to be corrupt; it differs from the
>> version in SVN.
>
> I just downloaded the tar.bz2 (again) and verified it is identical to an
> svn export created on my Linux machine that I used to create the build.
> I will check with the Windows machine at $work later today.

I've just realised what the problem is - sorry, my fault.

Because the EOLs in the zip file are different from the SVN export
EOLs, I run an Ant script to force standard file types to CRLF.
However this does not take note of the SVN properties, just the file
extensions; I assume *.xml should be converted to CRLF.
[Also I realise that my script does not specify the encoding to be used]

When I compare the original extracted file against SVN export, all is well.

Sorry for the noise.

> The explicit MIME type of application/octet-stream for this file may
> explain the difference.  Any attempt to use a non-binary MIME type has
> made svn break the UTF-16 encoding for me so it deliberately is a
> binary.
>
>> The top-level NOTICE says:
>
>> Apache RAT
>> Copyright 2006-2010 The Apache Software Foundation
>
>> Some other NOTICE files correctly say 2011
>
> I didn't realize we had more than one NOTICE file and must have checked
> one of the good ones.  Will be fixed.
>
>> Some missing EOL settings:
>
> will fix except for
>
>> apache-rat-core/src/test/resources/binaries/UTF16_with_signature.xml
>
> which has to be a binary in order to work.
>
> Stefan
>

Re: [VOTE] Release Apache RAT Incubating 0.8 based on RC1

[sebb]

On 6 November 2011 15:31, Stefan Bodewig  wrote:
> Hi all,
>
> since the 0.7 release we've accumulated enough to warrant a release.
>
> svn tag:
>    
> https://svn.apache.org/repos/asf/incubator/rat/main/tags/apache-rat-project-0.8RC1/

-1

The file:
apache-rat-core/src/test/resources/binaries/UTF16_with_signature.xml
in all source archives appears to be corrupt; it differs from the
version in SVN.

The top-level NOTICE says:

Apache RAT
Copyright 2006-2010 The Apache Software Foundation

Some other NOTICE files correctly say 2011

Some missing EOL settings:
svn ps svn:eol-style native
apache-rat-core/src/main/java/org/apache/rat/analysis/license/SimplePatternBasedLicense.java
svn ps svn:eol-style native
apache-rat-core/src/test/resources/binaries/UTF16_with_signature.xml
svn ps svn:eol-style native
apache-rat-core/src/test/resources/binaries/UTF8_with_signature.xml
svn ps svn:eol-style native
apache-rat-plugin/src/site/apt/examples/custom-license.apt.vm
svn ps svn:eol-style native apache-rat-plugin/src/test/invoker/settings.xml
svn ps svn:eol-style native
apache-rat-plugin/src/test/invoker/it1/invoker.properties
svn ps svn:eol-style native apache-rat-plugin/src/test/invoker/it1/pom.xml
svn ps svn:eol-style native apache-rat-plugin/src/test/invoker/it1/src.apt
svn ps svn:eol-style native apache-rat-plugin/src/test/invoker/it1/verify.bsh
svn ps svn:eol-style native apache-rat-tasks/src/site/apt/report.apt
svn ps svn:eol-style native apache-rat-tasks/src/site/apt/types.apt
svn ps svn:eol-style native apache-rat-tasks/src/site/apt/examples/basic.apt
svn ps svn:eol-style native apache-rat-tasks/src/site/apt/examples/custom.apt

> tarballs:
>    http://people.apache.org/~bodewig/rat-0.8RC1/
>
> Maven artifacts:
>    
> https://repository.apache.org/content/repositories/orgapacherat-163/org/apache/rat/
>
> Release Notes:
>    
> https://svn.apache.org/repos/asf/incubator/rat/main/tags/apache-rat-project-0.8RC1/RELEASE_NOTES.txt
>
> Do we want to release this as RAT 0.8?
>
> Vote will be open for at least 72 hours closing no earlier than 15:30UTC
> (unless it gets shot down, that is).
>
> Stefan
>

Re: Website and Branding Rules

[sebb]

On 4 September 2011 06:18, Stefan Bodewig  wrote:
> On 2011-08-30, Robert Burrell Donkin wrote:
>
>> IMHO our existing site[1] is quite basic and aimed at developers. I
>> suspect work is needed to bring it into line with the new policy on
>> trademarks and branding[2]. I'd to take this opportunity to do a wider
>> refresh.
>
>> I would prefer a user centred top level landing page, pushing
>> developer centred product documentation down to a level.
>
> Sounds fine.  But it also likely means it will take longer to make the
> site conform to the branding reqs.
>
> I'm not familiar enough with the mvn site plugin to know how to get
> anything into the footer, but for the rest of the requirements I don't
> think it would take too much effort to just make the necessary
> modifications of adding a few "Apache"s here and "TM"s there.

We went through this exercise in Commons and HttpComponents.

This is not easy to do with current Maven, so they both use a
customised Maven skin with an updated VM template that picks up
 elements from site.xml.

You can use the commons skin (it's generic) in your site.xml

The commons top-level site.xml is here:

https://svn.apache.org/repos/asf/commons/proper/commons-site/trunk/src/site/site.xml

Should be easy enough to adapt for RAT.

> Stefan
>

[jira] [Reopened] (RAT-3) Incorrect alignment of file contents

[Sebb (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RAT-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb reopened RAT-3:



The report now looks like this:

 ===
 ==src/conf/MANIFEST.MF
 ===
Manifest-Version: 1.0
Package: @package@
Extension-Name: @name@

i.e. the header is indented, but the file is not.

This was using version 0.7

> Incorrect alignment of file contents
> 
>
> Key: RAT-3
> URL: https://issues.apache.org/jira/browse/RAT-3
> Project: RAT
>  Issue Type: Bug
>  Components: reports
>Affects Versions: 0.6
>Reporter: Sebb
>Priority: Minor
> Fix For: 0.6
>
>
> The alignment of file contents is incorrect; the first line is indented, but 
> subsequent ones are not, e.g.
>  ===
>  ==1.1-RC3/samples/osgi-supplychain/src/main/resources/osgi/ds/Shipper.mf
>  ===
>  Manifest-Version: 1.0
> Bundle-ManifestVersion: 2
> Bundle-Name: Shipper

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (RAT-98) Maven RAT report does not document skipped files

[Sebb (JIRA)]

Maven RAT report does not document skipped files


 Key: RAT-98
 URL: https://issues.apache.org/jira/browse/RAT-98
 Project: RAT
  Issue Type: Bug
Reporter: Sebb


The Maven RAT report should document which files have been skipped using the 
 option.

Either by listing the configuration details, or better by listing the file 
names with a marker, e.g. EX to show they were deliberately skipped.

Note: this only refers to files listed in  entries, not files which 
are excluded by default.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (RAT-96) Check source files for unexpected encodings

[Sebb (JIRA)]

[ 
https://issues.apache.org/jira/browse/RAT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085076#comment-13085076
 ] 

Sebb commented on RAT-96:
-

Sounds like RAT has some of the code already; but rather than comparing against 
the default encoding, I'm suggesting checking against basic ASCII.

This is because ASCII is a proper sub-set of many other encodings.
It's a lot harder to mangle ASCII characters inadvertently; it's quite easy to 
mangle characters outside the ASCII range.

BTW, checking against the platform encoding seems wrong - surely the checks 
should be against the actual encoding used by the project?
This is generally ISO-8859-1 or UTF-8. Probably very difficult to deternine 
automatically, so might need to be provided, perhaps with UTF-8 as default?

> Check source files for unexpected encodings
> ---
>
> Key: RAT-96
> URL: https://issues.apache.org/jira/browse/RAT-96
> Project: RAT
>  Issue Type: New Feature
>Reporter: Sebb
>
> Idea for possible enhancement:
> Source files with characters in encodings other than ASCII can easily get 
> mangled, so it might be worth offering a tool to report these.
> For example, I have come across Javadoc which uses dashes instead of hyphens, 
> and at some point the encoded dash got corrupted.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (RAT-96) Check source files for unexpected encodings

[Sebb (JIRA)]

Check source files for unexpected encodings
---

 Key: RAT-96
 URL: https://issues.apache.org/jira/browse/RAT-96
 Project: RAT
  Issue Type: New Feature
Reporter: Sebb


Idea for possible enhancement:

Source files with characters in encodings other than ASCII can easily get 
mangled, so it might be worth offering a tool to report these.

For example, I have come across Javadoc which uses dashes instead of hyphens, 
and at some point the encoded dash got corrupted.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Future For Rat...?

[sebb]

On 17 June 2011 14:01, Stefan Bodewig  wrote:
> On 2011-06-15, Robert Burrell Donkin wrote:
>
>> (My recovery has progressed, and I have now enough computer time -
>> around 4 hours per day but not continuous - to start some coding and
>> Apache stuff again :-)
>
> Good to hear that.

+1

>> I'm involved with some release and build wrangling over at James (and
>> probably in the OO.o podling as well). I'm likely to need to start on
>> some new tools related to Rat (similar to tools they have over in
>> Lucene-land which might come this way).
>
> What kind of tools are these and how do they relate to Rat?  I still
> have difficulties seeing what sort of TLP that could be.

There are other possible release-related tools.

For example, checking hashes and sigs.
Checking source archive content against SVN.
Checking jars contain N &L files, and that the manifest has suitable
Specification and/or Implementation entries

Also, checking SVN properties (eol-style etc).

>> TLP? Opinions?
>
>> And how close is Rat to being able to graduate?
>
> Rat has been in bugfix-only (if anything at all) mode for quite some
> time now and to me it oscilates between being ready to graduate and
> being ready to go to the Attic.
>
> Stefan
>

Re: Custom license

[sebb]

On 17 March 2011 10:03, Jochen Wiedmann  wrote:
> I have to admit, it isn't.
>
> However, I see this as a very important addition. If RAT ever wants to
> be useful outside the ASF, then this needs to be done:
>
> - Licenses (instances of org.apache.rat.analysis.IHeaderMatcher) must
> be pluggable.
> - For simple cases it should not be required to write a Java class,
> but simply to configure a small piece of text, which needs to be
> present. (See the
> org.apache.rat.analysis.license.ApacheSoftwareLicense20 for an
> example.)
> - In other words, "pluggable" means that you need to be able to write
> a plugin once and add it multiple times using suitable configuration
> values.
> - For Ant, and Maven, the plugin would be added through the respective
> build scripts. (build.xml, and pom.xml)
> - For the CLI, it must be possible to load an XML file, which declares
> the plugins.
>
> To give an example, I can imagine something like this in a pom.xml:
>
>    
>      all <-- For the ApacheSoftwareLicense20,
> this would be "any" -->
>      
>        Copyright (C) 2011, Foo, Inc.
>        No warranties: This software is distributed
> without any implied, or explicit, warranties.
>      
>    

This will be tedious to edit - would it not be better to have the bare
licence text(s) in separate file(s), referenced by name in the POM?
The license should have a mnemonic associated with the text, so
reports can show which licence is in use.

e.g. AL2, GPL, CPL, TNT, ETC.

> Are you interested to give this a try?
>
>
> Jochen
>
>
>
>
> On Thu, Mar 17, 2011 at 10:43 AM, Christian Grobmeier
>  wrote:
>> Hello,
>>
>> is RAT already able to check for a custom license?
>>
>> The license of my customer is a text block in at java doc class level
>> (first lines).
>>
>> I would love to use RAT for this - is it supported?
>>
>> Also @since tags are necessary. Is it better to use checkstyle for this?
>>
>> Cheers,
>> Christian
>>
>
>
>
> --
> I Am What I Am And That's All What I Yam (Popeye)
>

[jira] Commented: (RAT-85) --addLicense doesn't work

[Sebb (JIRA)]

[ 
https://issues.apache.org/jira/browse/RAT-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005729#comment-13005729
 ] 

Sebb commented on RAT-85:
-

FYI: in the UK, the noun is "licence" - e.g. driving licence - and the verb is 
"license" - for example licenser, licensee, licensed premises.

> --addLicense doesn't work 
> --
>
> Key: RAT-85
> URL: https://issues.apache.org/jira/browse/RAT-85
> Project: RAT
>  Issue Type: New Feature
>Affects Versions: 0.7
> Environment: Shouldn't matter, but I tested on Mac OSX with java 
> -version
> java version "1.6.0_22"
> Java(TM) SE Runtime Environment (build 1.6.0_22-b04-307-10M3261)
> Java HotSpot(TM) 64-Bit Server VM (build 17.1-b03-307, mixed mode)
>Reporter: Marlon Pierce
>Assignee: Stefan Bodewig
> Fix For: 0.8
>
>
> In org.apache.rat.Report, the --addLicense flag doesn't work.  I notice 
> "license" is spelled as "licence" below:
> Option addLicence = new Option(
> "a",
> "addLicence",
> false,
> "Add the default licence header to any file with an unknown licence 
> that is not in the exclusion list. By default new files will be created with 
> the licence header, to force the modification of existing files use the 
> --force option.");

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: VOTE: Release Apache RAT 0.7 rc3

[sebb]

On 15 July 2010 00:14, sebb  wrote:
> On 15 July 2010 00:06, Jochen Wiedmann  wrote:
>> Hi,
>>
>> I'd like to ask for a release of Apache RAT 0.7 rc3.
>>
>> The distribution files (binary and source) are here:
>>
>>   
>> https://repository.apache.org/content/repositories/orgapacherat-005/org/apache/rat/apache-rat/0.7/
>>
>> The proposed site and the KEYS file are here:
>>
>>   http://people.apache.org/~jochen/rat/site/
>>   http://people.apache.org/~jochen/rat/KEYS
>
> Where is the SVN tag?
>
>>
>> The list of resolved issues is here:
>>
>>   
>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310750&status=5&status=6&fixfor=12313890&sorter/field=issuekey&sorter/order=DESC
>>
>> Compared to RC2, the following changes have been made:
>>
>>  - Added license headers to 3 Java source files.
>>  - Updated release notes.
>>  - Updated the year in the NOTICE file.
>>  - Added a download page.

Which unfortunately does not have an AL header.
The generated output also looks odd, as the link has no text.

No AL header in:

src/test/resources/javadocs/notjavadoc.html

This might be deliberate, in which case it would be useful to add a
comment in it to say so.

Some missing EOL properties (this was done on SVN trunk)

svn ps svn:eol-style native
apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java
svn ps svn:eol-style native
apache-rat-core/src/main/java/org/apache/rat/report/AbstractReport.java
svn ps svn:eol-style native
apache-rat-core/src/main/java/org/apache/rat/report/claim/util/LicenseAddingReport.java
svn ps svn:eol-style native apache-rat-plugin/src/test/it3/src.apt
svn ps svn:eol-style native
apache-rat-tasks/src/test/resources/antunit/index.apt
svn ps svn:eol-style native src/site/apt/downloads.apt


>>
>>
>> Please, cast your vote.
>>
>> [ ] +1
>> [ ] =0
>> [ ] -1
>>
>> Thanks,
>>
>> Jochen
>>
>> --
>> Germanys national anthem is the most boring in the world - how telling!
>>
>

Re: VOTE: Release Apache RAT 0.7 rc3

[sebb]

On 15 July 2010 00:06, Jochen Wiedmann  wrote:
> Hi,
>
> I'd like to ask for a release of Apache RAT 0.7 rc3.
>
> The distribution files (binary and source) are here:
>
>   
> https://repository.apache.org/content/repositories/orgapacherat-005/org/apache/rat/apache-rat/0.7/
>
> The proposed site and the KEYS file are here:
>
>   http://people.apache.org/~jochen/rat/site/
>   http://people.apache.org/~jochen/rat/KEYS

Where is the SVN tag?

>
> The list of resolved issues is here:
>
>   
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310750&status=5&status=6&fixfor=12313890&sorter/field=issuekey&sorter/order=DESC
>
> Compared to RC2, the following changes have been made:
>
>  - Added license headers to 3 Java source files.
>  - Updated release notes.
>  - Updated the year in the NOTICE file.
>  - Added a download page.
>
>
> Please, cast your vote.
>
> [ ] +1
> [ ] =0
> [ ] -1
>
> Thanks,
>
> Jochen
>
> --
> Germanys national anthem is the most boring in the world - how telling!
>

Re: VOTE: Release Apache RAT 0.7

[sebb]

On 13 July 2010 23:50, Jochen Wiedmann  wrote:
> Hi,
>
> I'd like to ask for a release of Apache RAT 0.7.
>
> The distribution files (binary and source) are here:
>
>    
> https://repository.apache.org/content/repositories/orgapacherat-057/org/apache/rat/apache-rat/0.7/

KEYS file?

SVN tag which corresponds to the source?

At least 3 .java files don't have AL headers (and they don't appear to
be test files).

NOTICE file still says 2009.

RELEASE_NOTES.txt does not contain any entry for 0.7

Might be useful to move the first part into a README file, and just
have release notes in the RN file.

(could delete the .asc.md5 and .asc.sha1 files from Nexus as they are
not useful)

> The proposed site is here:
>
>    http://people.apache.org/~jochen/rat/site/

No download page?

> The list of resolved issues is here:
>
>    
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310750&status=5&status=6&fixfor=12313890&sorter/field=issuekey&sorter/order=DESC
>
> Please, cast your vote.
>
> [ ] +1
> [ ] =0
> [X] -1

See above; not all are blockers.

> Thanks,
>
> Jochen
>
> --
> Germanys national anthem is the most boring in the world - how telling!
>

Re: Mouse

[sebb]

On 29 June 2010 18:37, Adrien Grand  wrote:
> Hello Hyrum,
>
> On Mon, Jun 28, 2010 at 1:20 PM, Hyrum K. Wright
>  wrote:
>>> But, beg your pardon, what's so "heavy-weight" with RAT? I can't see
>>> any advantages of a Python implementation, other than it would be
>>> preferrable to Python developers.
>>
>> In our discussion, Robert and I observed that improving and extending
>> RAT as it is today can be quite a chore.  He explained the origins of
>> RAT as "and experiment in software architecture" and that it had
>> horribly gone wrong.  The architecture is way over-engineered for the
>> core mission of RAT, but because the tool proved useful, it was
>> adopted anyway.  mouse is an attempt to greatly reduce the amount of
>> code needed to accomplish that mission, and be much easier to extend
>> down the road.
>>
>> Another goal of mouse is to be easily incorporated into a post-commit
>> hook, so that it could audit the files being modified during each
>> commit.
>
> I'm not sure using Python as a programming language would make it
> simpler : Many people from the Java world enjoy audit tools such as
> CPD, Findbugs, Cobertura and so on, but they will only use a tool like
> RAT if it integrates with their build and integration tools such as
> Ant, Maven and Hudson. I have the feeling that you may waste much more
> time developing Maven/Ant plug-ins that call Python code (need to fork
> a process, what if Python is not installed?) than what you will gain
> by writing the core in Python. Another solution would be to rely on
> Jython to seemlessly integrate your code inside a Maven/Ant plug-in,
> but it looks more like a magic trick than the right thing to do, in my
> opinion.
>
> I admit that my arguments may sound a little bit Java-centric, but I
> think that there are many potential users of RAT among Java developers
> because of their love for audit tools. :-)

I'd just add that RAT currently has Ant and Maven interfaces which are
likely to have been used by lots of people/projects.

So Mouse needs to support any such interfaces.

Furthermore any change to the API which requires users to change their
scripts will not be popular and will hinder takeup.

> --
> Adrien Grand
>

Re: Release RAT 0.7?

[sebb]

On 08/06/2010, Stefan Bodewig  wrote:
> On 2010-06-08, sebb wrote:
>
>  > In the meantime, would anyone mind if I fixed some incorrect SVN 
> properties?
>
>  not at all.

OK, I've just done the rest - I did not want to clutter the e-mail, so
only included two of the changes below.

>  > e.g.
>  > svn pd svn:executable ant-task-examples.xml
>  > and
>  > svn ps svn:eol-style native apache-rat/src/site/site.xml
>
>  I've just now applied these, thanks
>
>
>  Stefan
>

Re: Release RAT 0.7? (was Re: xml output from ant task)

[sebb]

On 08/06/2010, Stefan Bodewig  wrote:
> Maybe this just requires a fresh thread.
>
>  Context: The Ant task and Maven plugin can now create XML reports rather
>  than plain text (and apply custom stylesheets).  In addition the CLI
>  interface can now apply a custom stylesheet as well.
>
>   is helped a lot
>  by the XML output and life would become easier if projects had released
>  versions of the plugin or task to rely on.
>
>  On 2010-06-01, Gav... wrote:
>
>  > Yes +1, I think what has been done lately is certainly enough to warrant a
>  > new release. It was also be so handy for the master-rat-summary page too if
>  > I was able to pull in all those Hudson built rat reports too.
>
>  > I think we need to update our docs to reflect the new additions, I can
>  > start on that,
>
>  I didn't know we had docs 8-)
>
>  > who wants to be RM ?
>
>  Personally I'd prefer it if anybody more Maven savvy than myself could
>  take the driver's seat here.
>

I'm not offering to RM, but I can perhaps help with some Maven
aspects, as I've just been working on BSF3 which has a complicated
Maven structure.

In the meantime, would anyone mind if I fixed some incorrect SVN properties?

e.g.
svn pd svn:executable ant-task-examples.xml
and
svn ps svn:eol-style native apache-rat/src/site/site.xml

>  Stefan
>

[jira] Commented: (RAT-2) RAT reports should be able to skip certain file types or contents:

[Sebb (JIRA)]

[ 
https://issues.apache.org/jira/browse/RAT-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789306#action_12789306
 ] 

Sebb commented on RAT-2:


Can RAT now be told to ignore very short files, e.g. CSS files which just 
include an "include" line?

Or do these have to be listed individually?

> RAT reports should be able to skip certain file types or contents:
> --
>
> Key: RAT-2
> URL: https://issues.apache.org/jira/browse/RAT-2
> Project: RAT
>  Issue Type: Improvement
>  Components: engine
>Reporter: Sebb
>
> RAT reports should be able to skip certain file types or contents:
> MANIFEST files
> *.css where the contents is a single "@include" line
> CHANGES file
> It would be useful if exceptions could be configured on a per-project basis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (RAT-22) [MOJO-1086] Allow user to specify binary file types

[Sebb (JIRA)]

[MOJO-1086] Allow user to specify binary file types
---

 Key: RAT-22
 URL: https://issues.apache.org/jira/browse/RAT-22
 Project: RAT
  Issue Type: New Feature
Reporter: Sebb


[Moved from MOJO-1086]

RAT may incorrectly process some binary file types.
These can obviously be excluded entirely, but it would sometimes be useful to 
show the filenames in the report as Binary.
Perhaps a config item could be added to allow addtional file-types to be 
processed as binary?
[For example .ear files are currently not treated as binary]
Equally, there may be file types that RAT thinks are binary, but which are not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (RAT-21) [MOJO-1090] Allow new license boiler-plate to be specified

[Sebb (JIRA)]

[MOJO-1090] Allow new license boiler-plate to be specified
--

 Key: RAT-21
 URL: https://issues.apache.org/jira/browse/RAT-21
 Project: RAT
  Issue Type: New Feature
Reporter: Sebb


[Moved from MOJO-1090]

It would be useful to be able to add files defining additional license 
boilerplate text for recognising additional licenses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (RAT-7) RAT should distinguish the different AL header versions

[Sebb (JIRA)]

RAT should distinguish the different AL header versions
---

 Key: RAT-7
 URL: https://issues.apache.org/jira/browse/RAT-7
 Project: RAT
  Issue Type: Bug
Reporter: Sebb


RAT currently does not seem to care which version of the AL header is present.

This is a bit misleading; IMO it should distinguishe between current AL and 
obsolete AL headers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (RAT-2) RAT reports should be able to skip certain file types or contents:

[Sebb (JIRA)]

[ 
https://issues.apache.org/jira/browse/RAT-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578522#action_12578522
 ] 

Sebb commented on RAT-2:


Files that need to be treated as binary:

*.swf

Files that need to be ignored:

*.asc
*.md5
*.sha[1]

> RAT reports should be able to skip certain file types or contents:
> --
>
> Key: RAT-2
> URL: https://issues.apache.org/jira/browse/RAT-2
> Project: RAT
>  Issue Type: Improvement
>Reporter: Sebb
>
> RAT reports should be able to skip certain file types or contents:
> MANIFEST files
> *.css where the contents is a single "@include" line
> CHANGES file
> It would be useful if exceptions could be configured on a per-project basis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.