Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components
> On Jan. 12, 2017, 10:53 p.m., Jayush Luniya wrote: > > ambari-web/app/controllers/main/service/info/configs.js, line 518 > > <https://reviews.apache.org/r/46268/diff/2/?file=1601192#file1601192line518> > > > > Is this supposed to be part of the fix? Yes we need to revert the earlier UI implementation to show all the ranger plugin configs even if rabger is not installed. - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review161439 --- On Jan. 13, 2017, 3:33 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46268/ > --- > > (Updated Jan. 13, 2017, 3:33 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-19044 > https://issues.apache.org/jira/browse/AMBARI-19044 > > > Repository: ambari > > > Description > --- > > Currently, Ambari provides a single toggle button to enable Ranger plugins > for a component. Plugin enabled results in a bunch of configuration which are > created on backend which are tighly coupled with Ranger admin installed on > the same cluster. > > Need to make sure plugins communicate to Ranger admin which is installed on > separate cluster. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 05510cd > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 6561928 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > cb509cd > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 9373f17 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py > f5d7f38 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 8eed2d5 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 0d73e39 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f804851 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > e3aff9d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > a515b62 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 81a4e3e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 82849c8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py > 528dec2 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml > b4c0790 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml > 3949402 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml > cf4a82e > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 91061d1 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > ae9314b > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > d245178 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > 7601dfa > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml > 95e653c > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml > 4dc51eb > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml > b1f6e1e > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml > 983702f > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > c167d7c > > ambari-server/src/main/resources/common-services/ST
Re: Review Request 55503: AMBARI-19526 : Ambari should mark oozie servers to be restarted when atlas hook configs or jars change.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55503/#review161535 --- Ship it! Ship It! - Mugdha Varadkar On Jan. 13, 2017, 3:28 p.m., Vishal Suvagia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55503/ > --- > > (Updated Jan. 13, 2017, 3:28 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan > Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty. > > > Bugs: AMBARI-19526 > https://issues.apache.org/jira/browse/AMBARI-19526 > > > Repository: ambari > > > Description > --- > > When making atlas config or jars change, oozie sharelib needs to be updated > for hive and Oozie should be marked for restart. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/metainfo.xml > 6392ed4 > > Diff: https://reviews.apache.org/r/55503/diff/ > > > Testing > --- > > Verified fresh installation on centos-6. > > > Thanks, > > Vishal Suvagia > >
Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components
> On Jan. 12, 2017, 10:53 p.m., Jayush Luniya wrote: > > ambari-web/app/controllers/wizard/step7_controller.js, line 539 > > <https://reviews.apache.org/r/46268/diff/2/?file=1601193#file1601193line539> > > > > Is this supposed to be part of the fix? Yes we need to revert the earlier UI implementation to show all the ranger plugin configs even if rabger is not installed. - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review161439 --- On Jan. 13, 2017, 3:33 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46268/ > --- > > (Updated Jan. 13, 2017, 3:33 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-19044 > https://issues.apache.org/jira/browse/AMBARI-19044 > > > Repository: ambari > > > Description > --- > > Currently, Ambari provides a single toggle button to enable Ranger plugins > for a component. Plugin enabled results in a bunch of configuration which are > created on backend which are tighly coupled with Ranger admin installed on > the same cluster. > > Need to make sure plugins communicate to Ranger admin which is installed on > separate cluster. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 05510cd > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 6561928 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > cb509cd > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 9373f17 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py > f5d7f38 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 8eed2d5 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 0d73e39 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f804851 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > e3aff9d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > a515b62 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 81a4e3e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 82849c8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py > 528dec2 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml > b4c0790 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml > 3949402 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml > cf4a82e > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 91061d1 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > ae9314b > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > d245178 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > 7601dfa > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml > 95e653c > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml > 4dc51eb > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml > b1f6e1e > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml > 983702f > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > c167d7c > > ambari-server/src/main/resources/common-services/ST
Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components
> On Jan. 12, 2017, 10:57 p.m., Jayush Luniya wrote: > > Patch doesnt apply cleanly on latest trunk. Can you update the patch? @Jayush I have attached the latest patch for trunk on https://issues.apache.org/jira/secure/attachment/12847349/AMBARI-19044.2.trunk.patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review161446 --- On Jan. 13, 2017, 3:33 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46268/ > --- > > (Updated Jan. 13, 2017, 3:33 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-19044 > https://issues.apache.org/jira/browse/AMBARI-19044 > > > Repository: ambari > > > Description > --- > > Currently, Ambari provides a single toggle button to enable Ranger plugins > for a component. Plugin enabled results in a bunch of configuration which are > created on backend which are tighly coupled with Ranger admin installed on > the same cluster. > > Need to make sure plugins communicate to Ranger admin which is installed on > separate cluster. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 05510cd > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 6561928 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > cb509cd > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 9373f17 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py > f5d7f38 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 8eed2d5 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 0d73e39 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f804851 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > e3aff9d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > a515b62 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 81a4e3e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 82849c8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py > 528dec2 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml > b4c0790 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml > 3949402 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml > cf4a82e > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 91061d1 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > ae9314b > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > d245178 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > 7601dfa > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml > 95e653c > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml > 4dc51eb > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml > b1f6e1e > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml > 983702f > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > c167d7c > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py > e81d62a > > ambari-server/src/main/resources/common-services/STORM/1.0.1/
Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components
/ha_bootstrap_standby_node_initial_start_dfs_nameservices.json 6b57397 ambari-server/src/test/python/stacks/2.0.6/configs/ha_default.json 1cdb982 ambari-server/src/test/python/stacks/2.0.6/configs/ha_secured.json 15902af ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json e6a8676 ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2-phoenix.json b1d603b ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 435291a ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json 9f0c236 ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 890b9f1 ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 699c1f5 ambari-server/src/test/python/stacks/2.1/configs/default-storm-start.json 92a7516 ambari-server/src/test/python/stacks/2.1/configs/default.json 6ee7612 ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json 9bd239c ambari-server/src/test/python/stacks/2.1/configs/secured.json 0e4bfc3 ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 02be812 ambari-server/src/test/python/stacks/2.2/configs/default.json 7583e27 ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json cb476d3 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 378522e ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json ffdd5e9 ambari-server/src/test/python/stacks/2.5/configs/hsi_ha.json def0e54 ambari-web/app/controllers/main/service/info/configs.js e718835 ambari-web/app/controllers/wizard/step7_controller.js f6cc93b Diff: https://reviews.apache.org/r/46268/diff/ Testing --- mvn -DskipPythonTests -Dtest=UpgradeCatalog250Test test --- T E S T S --- Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true Running org.apache.ambari.server.upgrade.UpgradeCatalog250Test Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.993 sec - in org.apache.ambari.server.upgrade.UpgradeCatalog250Test Results : Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 54.262s [INFO] Finished at: Mon Jan 09 13:59:40 UTC 2017 [INFO] Final Memory: 58M/766M [INFO] Thanks, Mugdha Varadkar
Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components
> On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml, > > line 26 > > <https://reviews.apache.org/r/46268/diff/1/?file=1599953#file1599953line26> > > > > Do all of these properties have to be added after an Ambari Upgrade? > > If the user is on HDP 2.3 or 2.4, they should already have them. > > Mugdha Varadkar wrote: > Customer has a cluster without Ranger on Ambari-2.4 and they want to > start using Ranger cloud support provided in Ambari-2.5, > so in order to allow them to see all Ranger plugin properties after > upgrading to Ambari-2.5, I have set ; so that, > they will see all ranger plugin properties as soon as they upgrade to > Ambari-2.5. > My question is: do we need to handle above scenario ? > > Jayush Luniya wrote: > @Mugdha, What is the minimum HDP version for Ranger cloud support? By > adding to KAFKA 0.9.0, does this mean that HDP-2.3+ will support external > Ranger. Also what is the impact of all this for HDF? Minimum HDP version is HDP-2.5. For cloud we have introduced below only four new properties added under ranger plugin supported component config-type(ranger--plugin-properties.xml) for stack 2.5 external_admin_username external_admin_password external_ranger_admin_username external_ranger_admin_password. So for HDP-2.3+ if customer add the above four properties as custom then they can enable plugins for external ranger. For HDF, as the changes for STORM and KAFKA are done at common-services and also on python scripts then eventually the mpack with Ambari-2.5.0 will have the fix. We are not considering NIFI for now. - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review160934 --- On Jan. 10, 2017, 1:31 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46268/ > --- > > (Updated Jan. 10, 2017, 1:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-19044 > https://issues.apache.org/jira/browse/AMBARI-19044 > > > Repository: ambari > > > Description > --- > > Currently, Ambari provides a single toggle button to enable Ranger plugins > for a component. Plugin enabled results in a bunch of configuration which are > created on backend which are tighly coupled with Ranger admin installed on > the same cluster. > > Need to make sure plugins communicate to Ranger admin which is installed on > separate cluster. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > a352f71 > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 537aaa0 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 172cbd4 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 8704d3e > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py > f5d7f38 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 8eed2d5 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 0d73e39 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f804851 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > e3aff9d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 61034cf > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 81a4e3e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 41970f8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py > 3a9f51e > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml > b4c0790 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properti
Re: Review Request 55382: AMBARI-19386 : ATLAS service check should run against metadata server host.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55382/#review161350 --- Ship it! Ship It! - Mugdha Varadkar On Jan. 10, 2017, 3:54 p.m., Vishal Suvagia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55382/ > --- > > (Updated Jan. 10, 2017, 3:54 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Madhan Neethiraj, Mugdha Varadkar, and Oliver Szabo. > > > Bugs: AMBARI-19386 > https://issues.apache.org/jira/browse/AMBARI-19386 > > > Repository: ambari > > > Description > --- > > Atlas service check fails as its hard coded to run check against the same > host where service check is running. It should instead run check against > ATLAS metadata server host. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 6a53b1a > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py > 8e27b38 > > Diff: https://reviews.apache.org/r/55382/diff/ > > > Testing > --- > > Verified install on centos6. > > > Thanks, > > Vishal Suvagia > >
Re: Review Request 55373: AMBARI-19438 Add enable delta sync property for Ranger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55373/ --- (Updated Jan. 12, 2017, 5:39 a.m.) Review request for Ambari, Gautam Borad, Jaimin Jetly, Jayush Luniya, and Velmurugan Periasamy. Changes --- Once https://reviews.apache.org/r/54758/ is committed, will close this RR Bugs: AMBARI-19438 https://issues.apache.org/jira/browse/AMBARI-19438 Repository: ambari Description --- Add new property ranger.usersync.ldap.deltasync under ranger-ugsync-site config type to enable delta-sync for stack 2.6. Need to show it under existing Smart Config Tab Ranger Usersync for LDAP/AD Sub Tab. Diffs - ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-ugsync-site.xml PRE-CREATION ambari-server/src/main/resources/common-services/RANGER/0.7.0/metainfo.xml bc01321 ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json PRE-CREATION Diff: https://reviews.apache.org/r/55373/diff/ Testing --- Tested Ranger installation for stack 2.6 on Centos 6. Thanks, Mugdha Varadkar
Review Request 55423: AMBARI-19459 Optimizing services startup time when ranger admin is down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55423/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Vishal Suvagia, and Velmurugan Periasamy. Bugs: AMBARI-19459 https://issues.apache.org/jira/browse/AMBARI-19459 Repository: ambari Description --- Optimizing services startup time for ranger plugin supported services when ranger admin is down. Before hitting the ranger API, we can short circuit this by checking policy cache folder in local box. Diffs - ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py 537aaa0 Diff: https://reviews.apache.org/r/55423/diff/ Testing --- Tested Ranger installation and enabled plugins on Centos 6. Thanks, Mugdha Varadkar
Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components
> On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml, > > line 26 > > <https://reviews.apache.org/r/46268/diff/1/?file=1599953#file1599953line26> > > > > Do all of these properties have to be added after an Ambari Upgrade? > > If the user is on HDP 2.3 or 2.4, they should already have them. Customer has a cluster without Ranger on Ambari-2.4 and they want to start using Ranger cloud support provided in Ambari-2.5, so in order to allow them to see all Ranger plugin properties after upgrading to Ambari-2.5, I have set ; so that, they will see all ranger plugin properties as soon as they upgrade to Ambari-2.5. My question is: do we need to handle above scenario ? - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review160934 ------- On Jan. 10, 2017, 1:31 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46268/ > --- > > (Updated Jan. 10, 2017, 1:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-19044 > https://issues.apache.org/jira/browse/AMBARI-19044 > > > Repository: ambari > > > Description > --- > > Currently, Ambari provides a single toggle button to enable Ranger plugins > for a component. Plugin enabled results in a bunch of configuration which are > created on backend which are tighly coupled with Ranger admin installed on > the same cluster. > > Need to make sure plugins communicate to Ranger admin which is installed on > separate cluster. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > a352f71 > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 537aaa0 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 172cbd4 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 8704d3e > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py > f5d7f38 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 8eed2d5 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 0d73e39 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f804851 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > e3aff9d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 61034cf > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 81a4e3e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 41970f8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py > 3a9f51e > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml > b4c0790 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml > 3949402 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml > cf4a82e > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 91061d1 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > ae9314b > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4a23bca > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > d4eb6b9 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml > 95e653c > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml > 4dc51eb > > ambari-server/src/
Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components
> On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 704 > > <https://reviews.apache.org/r/46268/diff/1/?file=1599942#file1599942line704> > > > > Please add some javadoc. Updated in latest patch > On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-plugin-properties.xml, > > line 31 > > <https://reviews.apache.org/r/46268/diff/1/?file=1599966#file1599966line31> > > > > Set for all props since EU/RU will add > > them. Need this property from stack 2.5 onwards. Added those peoperties as true since stack 2.5 is released and user doing ambari-upgrade with stack 2.5 will get the property. - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review160934 ------- On Jan. 10, 2017, 1:31 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46268/ > --- > > (Updated Jan. 10, 2017, 1:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-19044 > https://issues.apache.org/jira/browse/AMBARI-19044 > > > Repository: ambari > > > Description > --- > > Currently, Ambari provides a single toggle button to enable Ranger plugins > for a component. Plugin enabled results in a bunch of configuration which are > created on backend which are tighly coupled with Ranger admin installed on > the same cluster. > > Need to make sure plugins communicate to Ranger admin which is installed on > separate cluster. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > a352f71 > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 537aaa0 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 172cbd4 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 8704d3e > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py > f5d7f38 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 8eed2d5 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 0d73e39 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f804851 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > e3aff9d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 61034cf > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 81a4e3e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 41970f8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py > 3a9f51e > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml > b4c0790 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml > 3949402 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml > cf4a82e > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 91061d1 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > ae9314b > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4a23bca > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > d4eb6b9 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml > 95e653c > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-s
Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components
/test/python/stacks/2.1/configs/default.json 6ee7612 ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json 9bd239c ambari-server/src/test/python/stacks/2.1/configs/secured.json 0e4bfc3 ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 02be812 ambari-server/src/test/python/stacks/2.2/configs/default.json 7583e27 ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json cb476d3 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 378522e ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json ffdd5e9 ambari-server/src/test/python/stacks/2.5/configs/hsi_ha.json def0e54 ambari-web/app/controllers/main/service/info/configs.js e718835 ambari-web/app/controllers/wizard/step7_controller.js 3d22fe9 Diff: https://reviews.apache.org/r/46268/diff/ Testing --- mvn -DskipPythonTests -Dtest=UpgradeCatalog250Test test --- T E S T S --- Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true Running org.apache.ambari.server.upgrade.UpgradeCatalog250Test Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.993 sec - in org.apache.ambari.server.upgrade.UpgradeCatalog250Test Results : Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 54.262s [INFO] Finished at: Mon Jan 09 13:59:40 UTC 2017 [INFO] Final Memory: 58M/766M [INFO] Thanks, Mugdha Varadkar
Re: Review Request 55174: AMBARI-19288 : Ranger policies not syncing for storm, kafka and knox
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55174/#review161055 --- Ship it! Ship It! - Mugdha Varadkar On Jan. 9, 2017, 3:12 p.m., Vishal Suvagia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55174/ > --- > > (Updated Jan. 9, 2017, 3:12 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy. > > > Bugs: AMBARI-19360 > https://issues.apache.org/jira/browse/AMBARI-19360 > > > Repository: ambari > > > Description > --- > > On enabling Namenode-HA, and One-way SSL for Ranger, plugins are not able to > fetch latest policies as authorization does not work for Storm, knox and > Kafka plugins. > > Solution : Need to reate a core-site.xml for Storm, Knox and Kafka under > respective classpath when Ranger plugins are enabled and Namenode-HA is > enabled under kerberos. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > a352f71 > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 537aaa0 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 41970f8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py > 3a9f51e > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 8416e98 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > d4eb6b9 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > 67d5769 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py > caafd55 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > b94d376 > > Diff: https://reviews.apache.org/r/55174/diff/ > > > Testing > --- > > Verified install on cent-os 6. > > > Thanks, > > Vishal Suvagia > >
Review Request 55373: AMBARI-19438 Add enable delta sync property for Ranger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55373/ --- Review request for Ambari, Gautam Borad, Jaimin Jetly, Jayush Luniya, and Velmurugan Periasamy. Bugs: AMBARI-19438 https://issues.apache.org/jira/browse/AMBARI-19438 Repository: ambari Description --- Add new property ranger.usersync.ldap.deltasync under ranger-ugsync-site config type to enable delta-sync for stack 2.6. Need to show it under existing Smart Config Tab Ranger Usersync for LDAP/AD Sub Tab. Diffs - ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-ugsync-site.xml PRE-CREATION ambari-server/src/main/resources/common-services/RANGER/0.7.0/metainfo.xml bc01321 ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json PRE-CREATION Diff: https://reviews.apache.org/r/55373/diff/ Testing --- Tested Ranger installation for stack 2.6 on Centos 6. Thanks, Mugdha Varadkar
Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components
6ee7612 ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json 9bd239c ambari-server/src/test/python/stacks/2.1/configs/secured.json 0e4bfc3 ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 9d364ed ambari-server/src/test/python/stacks/2.2/configs/default.json 7583e27 ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json cb476d3 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 88fa6d0 ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json ffdd5e9 ambari-server/src/test/python/stacks/2.5/configs/hsi_ha.json def0e54 ambari-web/app/controllers/main/service/info/configs.js e718835 ambari-web/app/controllers/wizard/step7_controller.js 3d22fe9 Diff: https://reviews.apache.org/r/46268/diff/ Testing --- mvn -DskipPythonTests -Dtest=UpgradeCatalog250Test test --- T E S T S --- Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true Running org.apache.ambari.server.upgrade.UpgradeCatalog250Test Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.993 sec - in org.apache.ambari.server.upgrade.UpgradeCatalog250Test Results : Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 54.262s [INFO] Finished at: Mon Jan 09 13:59:40 UTC 2017 [INFO] Final Memory: 58M/766M [INFO] Thanks, Mugdha Varadkar
Re: Review Request 55007: AMBARI-19288 : Do not install hive-hook from Ambari if falcon client is installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55007/#review160036 --- Ship it! Ship It! - Mugdha Varadkar On Dec. 23, 2016, 5:23 a.m., Vishal Suvagia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55007/ > --- > > (Updated Dec. 23, 2016, 5:23 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Madhan Neethiraj, Mugdha Varadkar, and Oliver Szabo. > > > Bugs: AMBARI-19288 > https://issues.apache.org/jira/browse/AMBARI-19288 > > > Repository: ambari > > > Description > --- > > Currently, for 2.5 and 2.6 stacks, there a call to install hive-hook if > Falcon client is installed.Need to remove that dependency. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 7fbd6bd > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 78874ef > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > dde3e00 > > Diff: https://reviews.apache.org/r/55007/diff/ > > > Testing > --- > > Verified fresh install on Cent-OS 6. > > > Thanks, > > Vishal Suvagia > >
Re: Review Request 54817: AMBARI-19227 :: Provide support to show Ranger solr-configs in Ambari.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54817/#review159716 --- Ship it! Ship It! - Mugdha Varadkar On Dec. 19, 2016, 4:14 p.m., Vishal Suvagia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54817/ > --- > > (Updated Dec. 19, 2016, 4:14 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Mugdha Varadkar, and Velmurugan Periasamy. > > > Bugs: AMBARI-19227 > https://issues.apache.org/jira/browse/AMBARI-19227 > > > Repository: ambari > > > Description > --- > > Need to provide feature for Ranger and update Ambari stacks to show > solrconfig.xml on Ambari, so that user can update solr related configs > directly from Ambari. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 7fbd6bd > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > da9ee18 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > ac5b38e > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-solr-configuration.xml > PRE-CREATION > ambari-server/src/main/resources/common-services/RANGER/0.7.0/metainfo.xml > c9f3a9b > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > dde3e00 > ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py > a3ce186 > ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json > ad66c7a > ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json > 5562ea7 > > Diff: https://reviews.apache.org/r/54817/diff/ > > > Testing > --- > > Verified install on cent-os 6. > > test_start_default (test_ranger_admin.TestRangerAdmin) ... 2016-12-19 > 21:37:16,265 - Stack Feature Version Info: stack_version=2.6, > version=2.6.0.0-801, current_cluster_version=2.6.0.0-801 -> 2.6.0.0-801 > 2016-12-19 21:37:16,281 - Setting up Ranger DB and DB User > ok > test_start_secured (test_ranger_admin.TestRangerAdmin) ... 2016-12-19 > 21:37:16,296 - Stack Feature Version Info: stack_version=2.6, > version=2.6.0.0-801, current_cluster_version=2.6.0.0-801 -> 2.6.0.0-801 > 2016-12-19 21:37:16,312 - Setting up Ranger DB and DB User > ok > > > Thanks, > > Vishal Suvagia > >
Re: Review Request 54822: AMBARI-19228 :: Knox doesn't redirect to Atlas after entering correct credentials.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54822/#review159588 --- Ship it! Ship It! - Mugdha Varadkar On Dec. 16, 2016, 9:43 p.m., Vishal Suvagia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54822/ > --- > > (Updated Dec. 16, 2016, 9:43 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, > Madhan Neethiraj, and Mugdha Varadkar. > > > Bugs: AMBARI-19228 > https://issues.apache.org/jira/browse/AMBARI-19228 > > > Repository: ambari > > > Description > --- > > After enabling Atlas with Knox-SSO, user is not able to sign-in. but lands > back on the login page. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > a295915 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml > 0d6ee38 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/themes/theme_version_2.json > a5435e9 > > Diff: https://reviews.apache.org/r/54822/diff/ > > > Testing > --- > > Tested fresh install with Atlas on Cent-os 6. > > > Thanks, > > Vishal Suvagia > >
Re: Review Request 54706: AMBARI-19188 :: Provide Atlas Hook support for Hive2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54706/#review159145 --- Ship it! Ship It! - Mugdha Varadkar On Dec. 14, 2016, 1:26 p.m., Vishal Suvagia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54706/ > --- > > (Updated Dec. 14, 2016, 1:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan > Neethiraj, Mugdha Varadkar, and Swapan Shridhar. > > > Bugs: AMBARI-19188 > https://issues.apache.org/jira/browse/AMBARI-19188 > > > Repository: ambari > > > Description > --- > > Need to provide Atlas hook configuration support for HiveServer-Interactive. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 7fbd6bd > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py > af2a05d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 33f1056 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > dde3e00 > > Diff: https://reviews.apache.org/r/54706/diff/ > > > Testing > --- > > Tested Hive and Hive2 with Atlas installation on cent-os 6. > > > test_make_valid_json_6 (test_hive_server_int.TestHiveServerInteractive) ... ok > test_make_valid_json_7 (test_hive_server_int.TestHiveServerInteractive) ... ok > test_make_valid_json_8 (test_hive_server_int.TestHiveServerInteractive) ... ok > test_make_valid_json_9 (test_hive_server_int.TestHiveServerInteractive) ... ok > test_start_default_with_llap_multi_line_output > (test_hive_server_int.TestHiveServerInteractive) ... ok > test_start_default_with_llap_single_line_output > (test_hive_server_int.TestHiveServerInteractive) ... ok > test_start_hsi_ha_with_llap_single_line_output > (test_hive_server_int.TestHiveServerInteractive) ... ok > test_start_with_ha_and_llap_running > (test_hive_server_int.TestHiveServerInteractive) ... ok > > > Thanks, > > Vishal Suvagia > >
Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin
> On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > One thing I'm not clear on is how this will affect an existing > > installation. Won't Ranger have a problem if you change the name of a repo > > on an already running cluster? Reverting the logic > On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 384 > > <https://reviews.apache.org/r/53980/diff/2/?file=1578949#file1578949line384> > > > > I don't think this can be null/empty - ever. Reverting the logic > On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, > > lines 221-229 > > <https://reviews.apache.org/r/53980/diff/2/?file=1578967#file1578967line221> > > > > This is a lot of logic repeated over and over - can this be placed in a > > common function and just re-used in order to get the name of the repo? > > Similar to what you did in the upgrade? Reverting the logic > On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 377 > > <https://reviews.apache.org/r/53980/diff/2/?file=1578949#file1578949line377> > > > > Doc. Reverting the logic > On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 362 > > <https://reviews.apache.org/r/53980/diff/2/?file=1578949#file1578949line362> > > > > Doc. Reverting the logic - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review158525 --- On Dec. 13, 2016, 12:40 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53980/ > --- > > (Updated Dec. 13, 2016, 12:40 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-18945 > https://issues.apache.org/jira/browse/AMBARI-18945 > > > Repository: ambari > > > Description > --- > > Need to add a provision for creating default repository with static name or > user provided name. > > This will help user to provided service name under Ranger supported plugins > config tab and can take dump of latest snapshot of all policies and use it > while recreating another/multiple clusters with same service name. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 32e1510 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > f47dc8f > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > d86e360 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > e9436c1 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 5635fe3 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4cefbda > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > c20bdde > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > 4859534 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 1347864 > > Diff: https://reviews.apache.org/r/53980/diff/ > > > Testing > --- > > mvn -DskipPythonTests -Dtest=UpgradeCatalog250Test test > > --- > T E S T S > --- > OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support > was removed in 8.0 > Running org.apache.ambari.server.upgrade.UpgradeCatalog250Test > Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.548 sec - > in org.apache.ambari.server.upgrade.UpgradeCatalog250Test > > Results : > > Tests run: 13, Failures: 0, Errors: 0, Skipped: 0 > > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 30.347 s > [INFO] Finished at: 2016-11-22T11:51:23+00:00 > [INFO] Final Memory: 63M/1107M > [INFO] > > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/ --- (Updated Dec. 13, 2016, 12:40 p.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, Sumit Mohanty, and Velmurugan Periasamy. Changes --- Reverting the logic for UpgradeCatalog250.java and stack_advisor.py, because cluster_name key is not available under clusterData['referenceHost'] during first installation of cluster. This does not fail for UI based installation because Ranger has to be installed after cluster setup(by which time the cluster_name is available) However, this will fail at fetching the cluster_name for blue-print based installation(with config_recommendation_strategy set as ALWAYS_APPLY_DONT_OVERRIDE_CUSTOM_VALUES) where ranger-plugin is enabled. Bugs: AMBARI-18945 https://issues.apache.org/jira/browse/AMBARI-18945 Repository: ambari Description --- Need to add a provision for creating default repository with static name or user provided name. This will help user to provided service name under Ranger supported plugins config tab and can take dump of latest snapshot of all policies and use it while recreating another/multiple clusters with same service name. Diffs (updated) - ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 32e1510 ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py f47dc8f ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py d86e360 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py e9436c1 ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 5635fe3 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 4cefbda ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py c20bdde ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 4859534 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 1347864 Diff: https://reviews.apache.org/r/53980/diff/ Testing --- mvn -DskipPythonTests -Dtest=UpgradeCatalog250Test test --- T E S T S --- OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0 Running org.apache.ambari.server.upgrade.UpgradeCatalog250Test Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.548 sec - in org.apache.ambari.server.upgrade.UpgradeCatalog250Test Results : Tests run: 13, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 30.347 s [INFO] Finished at: 2016-11-22T11:51:23+00:00 [INFO] Final Memory: 63M/1107M [INFO] Thanks, Mugdha Varadkar
Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin
> On Dec. 5, 2016, 7:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 267 > > <https://reviews.apache.org/r/53980/diff/1/?file=1568483#file1568483line267> > > > > Same comment as Jonathan. The behavior of all of these functions is > > nearly similar and they can be handled with a single function that accepts > > the parameters for the config type and config name. Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review158045 ------- On Dec. 7, 2016, 7:36 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53980/ > --- > > (Updated Dec. 7, 2016, 7:36 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-18945 > https://issues.apache.org/jira/browse/AMBARI-18945 > > > Repository: ambari > > > Description > --- > > Need to add a provision for creating default repository with static name or > user provided name. > > This will help user to provided service name under Ranger supported plugins > config tab and can take dump of latest snapshot of all policies and use it > while recreating another/multiple clusters with same service name. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > ac97987 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 32e1510 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > f47dc8f > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 64f67b9 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 496102e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 5635fe3 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 91061d1 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4cefbda > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml > 95e653c > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > c20bdde > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml > 983702f > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > 4859534 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 4d42861 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml > 1deb9e5 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-security.xml > cfd8a4f > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml > ce4074a > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-security.xml > 9bd1079 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-security.xml > 5f69962 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 3c34fc6 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml > ea0a026 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 57555ee > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > d4f2e8b > ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json a6ed6ce > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 4a77086 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > f4538d7 > ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json > 05cb78a > ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json > 7054e8f > ambari-serve
Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin
> On Dec. 5, 2016, 3:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > lines 137-145 > > <https://reviews.apache.org/r/53980/diff/1/?file=1568483#file1568483line137> > > > > All of these essentially do the same thing, right? Just with different > > properties. It would be better to write the method once and then loop over > > the properties in a structured way. Updated in latest patch > On Dec. 5, 2016, 3:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py, > > lines 317-318 > > <https://reviews.apache.org/r/53980/diff/1/?file=1568484#file1568484line317> > > > > Just because it's supported doesn't mean that the property exists. Same > > goes for all of the other files below. Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review158001 --- On Dec. 7, 2016, 7:36 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53980/ > --- > > (Updated Dec. 7, 2016, 7:36 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-18945 > https://issues.apache.org/jira/browse/AMBARI-18945 > > > Repository: ambari > > > Description > --- > > Need to add a provision for creating default repository with static name or > user provided name. > > This will help user to provided service name under Ranger supported plugins > config tab and can take dump of latest snapshot of all policies and use it > while recreating another/multiple clusters with same service name. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > ac97987 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 32e1510 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > f47dc8f > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 64f67b9 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 496102e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 5635fe3 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 91061d1 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4cefbda > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml > 95e653c > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > c20bdde > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml > 983702f > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > 4859534 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 4d42861 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml > 1deb9e5 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-security.xml > cfd8a4f > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml > ce4074a > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-security.xml > 9bd1079 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-security.xml > 5f69962 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 3c34fc6 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml > ea0a026 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 57555ee > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > d4f2e8b > ambari-server/src/test/pyt
Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/ --- (Updated Dec. 7, 2016, 7:36 p.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, Sumit Mohanty, and Velmurugan Periasamy. Bugs: AMBARI-18945 https://issues.apache.org/jira/browse/AMBARI-18945 Repository: ambari Description --- Need to add a provision for creating default repository with static name or user provided name. This will help user to provided service name under Ranger supported plugins config tab and can take dump of latest snapshot of all policies and use it while recreating another/multiple clusters with same service name. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java ac97987 ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 32e1510 ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py f47dc8f ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 64f67b9 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 496102e ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 5635fe3 ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml 91061d1 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 4cefbda ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml 95e653c ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py c20bdde ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml 983702f ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 4859534 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 4d42861 ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml 1deb9e5 ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-security.xml cfd8a4f ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml ce4074a ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-security.xml 9bd1079 ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-security.xml 5f69962 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 3c34fc6 ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml ea0a026 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 57555ee ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java d4f2e8b ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json a6ed6ce ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 4a77086 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py f4538d7 ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json 05cb78a ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 7054e8f ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 011a874 Diff: https://reviews.apache.org/r/53980/diff/ Testing --- mvn -DskipPythonTests -Dtest=UpgradeCatalog250Test test --- T E S T S --- OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0 Running org.apache.ambari.server.upgrade.UpgradeCatalog250Test Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.548 sec - in org.apache.ambari.server.upgrade.UpgradeCatalog250Test Results : Tests run: 13, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 30.347 s [INFO] Finished at: 2016-11-22T11:51:23+00:00 [INFO] Final Memory: 63M/1107M [INFO] Thanks, Mugdha Varadkar
Review Request 54412: AMBARI-19080 Ambari stack-advisor error while adding knox service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54412/ --- Review request for Ambari, Alejandro Fernandez and Gautam Borad. Bugs: AMBARI-19080 https://issues.apache.org/jira/browse/AMBARI-19080 Repository: ambari Description --- STR: 1. Add knox service through service add wizard in secure env 2. Stack-advisor error pop appear at 'configure identities' step with list index out of range error. Diffs - ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d4a2e4 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py b5ff24c Diff: https://reviews.apache.org/r/54412/diff/ Testing --- Tested Knox installation on centos 6 in secure env test_recommendRangerConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok Thanks, Mugdha Varadkar
Re: Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster
> On Dec. 1, 2016, 5:53 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 329 > > <https://reviews.apache.org/r/54169/diff/2/?file=1573671#file1573671line329> > > > > Sorry to nitpick here, these 4 functions are nearly identical. Can you > > parametrize the service and config type? Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54169/#review157617 ------- On Dec. 2, 2016, 1:01 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54169/ > --- > > (Updated Dec. 2, 2016, 1:01 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan > Neethiraj, and Sumit Mohanty. > > > Bugs: AMBARI-19007 > https://issues.apache.org/jira/browse/AMBARI-19007 > > > Repository: ambari > > > Description > --- > > 1) Introduced new flag for all the hook suported > components(HIVE,STORM,SQOOP,FALCON)under there respective env config-type. > 2) If ATLAS service is present/selected for install, stack-advisor will set > the hook flag. This flag value is used to recommend the expected > configuration required for hook to work. > 3) For Blue-print based installation user need to set hook flag and add > common-atlas application properties under each hook config-type eg: > hive-atlas-application.properties config-type which are require to > communicate with external ATLAS > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py > a1d2f95 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > ec846f8 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 52de784 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > 09cced6 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 4429253 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 0fb21d0 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 150f629 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py > 5e2c709 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > bcc598a > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 01e5f00 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py > fe3f34a > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml > f682e97 > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml > f7823d2 > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py > 283f54d > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py > 68f06db > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml > 9547335 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > aca0681 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py > bda4fe2 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > ab350dc > > ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml > b71f4a9 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 775dbab > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > f2dd099 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > ce0b387 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 39cbbce > > Diff: https://reviews.apache.org/r/54169/diff/ > > > Testing > --- > > Tested Atlas installation via UI and blue-print. With blueprint us
Re: Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54169/ --- (Updated Dec. 2, 2016, 1:01 p.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, and Sumit Mohanty. Bugs: AMBARI-19007 https://issues.apache.org/jira/browse/AMBARI-19007 Repository: ambari Description --- 1) Introduced new flag for all the hook suported components(HIVE,STORM,SQOOP,FALCON)under there respective env config-type. 2) If ATLAS service is present/selected for install, stack-advisor will set the hook flag. This flag value is used to recommend the expected configuration required for hook to work. 3) For Blue-print based installation user need to set hook flag and add common-atlas application properties under each hook config-type eg: hive-atlas-application.properties config-type which are require to communicate with external ATLAS Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py a1d2f95 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java ec846f8 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 52de784 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml 09cced6 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 4429253 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 0fb21d0 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 150f629 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py 5e2c709 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bcc598a ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 01e5f00 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py fe3f34a ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml f682e97 ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml f7823d2 ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py 283f54d ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py 68f06db ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml 9547335 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py aca0681 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py bda4fe2 ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml ab350dc ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml b71f4a9 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 775dbab ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java f2dd099 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java ce0b387 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 39cbbce Diff: https://reviews.apache.org/r/54169/diff/ Testing --- Tested Atlas installation via UI and blue-print. With blueprint used config_recommendation_strategy as NEVER_APPLY and ALWAYS_APPLY_DONT_OVERRIDE_CUSTOM_VALUES mvn -DskipPythonTests -Dtest=BlueprintConfigurationProcessorTest test --- T E S T S --- Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true Running org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessorTest Tests run: 167, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.101 sec - in org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessorTest Results : Tests run: 167, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 24.484s [INFO] Finished at: Tue Nov 29 11:40:30 UTC 2016 [INFO] Final Memory: 62M/797M [INFO] Thanks, Mugdha Varadkar
Re: Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster
> On Nov. 29, 2016, 6:53 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml, > > line 32 > > <https://reviews.apache.org/r/54169/diff/1/?file=1572153#file1572153line32> > > > > This property will be added automatically after an Ambari Upgrade with > > the value "false". Should this be smarter to detect if Atlas and Storm are > > in the cluster and if so then set the value to true? > > Mugdha Varadkar wrote: > Hi Alejandro, > Yes there is a way this can be handled in UpgradeCatalog250.java. This > fix will is getting handled in > https://issues.apache.org/jira/browse/AMBARI-19024 > > Alejandro Fernandez wrote: > Mugdha, a lot of the items I brought up are being deferred to another > Jira. In my opinion, they should be done as part of this commit. Typically, > it's ok to create another Jira for additional functionality, but not very > common to fix more issues with the current patch. Thanks. Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54169/#review157296 --- On Dec. 1, 2016, 6:59 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54169/ > --- > > (Updated Dec. 1, 2016, 6:59 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan > Neethiraj, and Sumit Mohanty. > > > Bugs: AMBARI-19007 > https://issues.apache.org/jira/browse/AMBARI-19007 > > > Repository: ambari > > > Description > --- > > 1) Introduced new flag for all the hook suported > components(HIVE,STORM,SQOOP,FALCON)under there respective env config-type. > 2) If ATLAS service is present/selected for install, stack-advisor will set > the hook flag. This flag value is used to recommend the expected > configuration required for hook to work. > 3) For Blue-print based installation user need to set hook flag and add > common-atlas application properties under each hook config-type eg: > hive-atlas-application.properties config-type which are require to > communicate with external ATLAS > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py > a1d2f95 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > ec846f8 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 52de784 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > 09cced6 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 4429253 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 0fb21d0 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 150f629 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py > 5e2c709 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > bcc598a > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 01e5f00 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py > fe3f34a > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml > f682e97 > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml > f7823d2 > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py > 283f54d > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py > 68f06db > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml > 9547335 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > e753e98 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py > bda4fe2 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > ab350dc > > ambari-server/src/main/resources/sta
Re: Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54169/ --- (Updated Dec. 1, 2016, 6:59 a.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, and Sumit Mohanty. Changes --- Addressed AMBARI-19024(Ambari upgrade scenario) fix in latest patch Bugs: AMBARI-19007 https://issues.apache.org/jira/browse/AMBARI-19007 Repository: ambari Description --- 1) Introduced new flag for all the hook suported components(HIVE,STORM,SQOOP,FALCON)under there respective env config-type. 2) If ATLAS service is present/selected for install, stack-advisor will set the hook flag. This flag value is used to recommend the expected configuration required for hook to work. 3) For Blue-print based installation user need to set hook flag and add common-atlas application properties under each hook config-type eg: hive-atlas-application.properties config-type which are require to communicate with external ATLAS Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py a1d2f95 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java ec846f8 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 52de784 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml 09cced6 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 4429253 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 0fb21d0 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 150f629 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py 5e2c709 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bcc598a ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 01e5f00 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py fe3f34a ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml f682e97 ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml f7823d2 ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py 283f54d ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py 68f06db ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml 9547335 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py e753e98 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py bda4fe2 ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml ab350dc ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml b71f4a9 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 775dbab ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java f2dd099 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java ce0b387 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 39cbbce Diff: https://reviews.apache.org/r/54169/diff/ Testing --- Tested Atlas installation via UI and blue-print. With blueprint used config_recommendation_strategy as NEVER_APPLY and ALWAYS_APPLY_DONT_OVERRIDE_CUSTOM_VALUES mvn -DskipPythonTests -Dtest=BlueprintConfigurationProcessorTest test --- T E S T S --- Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true Running org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessorTest Tests run: 167, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.101 sec - in org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessorTest Results : Tests run: 167, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 24.484s [INFO] Finished at: Tue Nov 29 11:40:30 UTC 2016 [INFO] Final Memory: 62M/797M [INFO] Thanks, Mugdha Varadkar
Re: Review Request 53727: Provide SSL related configurations for Ranger-Tagsync.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53727/#review157401 --- Ship it! Ship It! - Mugdha Varadkar On Nov. 17, 2016, 2:51 p.m., Vishal Suvagia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53727/ > --- > > (Updated Nov. 17, 2016, 2:51 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Mugdha Varadkar, and Velmurugan Periasamy. > > > Bugs: AMBARI-18874 > https://issues.apache.org/jira/browse/AMBARI-18874 > > > Repository: ambari > > > Description > --- > > Need to provide ssl related configurations for Ranger-Tagsync service. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 3431495 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 6debaf1 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py > 1efa7e9 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > f1b4797 > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/atlas-tagsync-policymgr-ssl.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-policymgr-ssl.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-site.xml > PRE-CREATION > ambari-server/src/main/resources/common-services/RANGER/0.7.0/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > dd87b72 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-tagsync-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml > 6287e00 > ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/53727/diff/ > > > Testing > --- > > Tested Ranger with Tagsync installation on CentOS 6. > > Verified Unit-tests: > > test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:01:42,649 - Stack Feature Version Info: stack_version=2.6, > version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111 > 2016-11-17 20:01:42,670 - Stack Feature Version Info: stack_version=2.6, > version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111 > ok > test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok > test_start_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:01:42,691 - Stack Feature Version Info: stack_version=2.6, > version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111 > ok > test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:01:42,712 - Stack Feature Version Info: stack_version=2.6, > version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111 > ok > > > test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:02:05,297 - Stack Feature Version Info: stack_version=2.5, > version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 > ok > test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:02:05,318 - Stack Feature Version Info: stack_version=2.5, > version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 > ok > test_start_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:02:05,336 - Stack Feature Version Info: stack_version=2.5, > version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 > ok > test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:02:05,355 - Stack Feature Version Info: stack_version=2.5, > version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 > ok > > > Thanks, > > Vishal Suvagia > >
Re: Review Request 54189: After adding an Atlas server the first restart command fails since stop doesn't have any configs; if no pid dir exists during stop, perform no-op
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54189/#review157393 --- ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py (line 139) <https://reviews.apache.org/r/54189/#comment227997> Considering scenario 2 in your description, shouldn't the pid property be editable only at installation ? As per my knowledge : Whenever a service is installed it will first trigger the start call and then user have option to restart. Is there any way user can trigger restart after install ? - Mugdha Varadkar On Nov. 30, 2016, 1:15 a.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54189/ > --- > > (Updated Nov. 30, 2016, 1:15 a.m.) > > > Review request for Ambari, Mugdha Varadkar, Sumit Mohanty, and Swapan > Shridhar. > > > Bugs: AMBARI-19023 > https://issues.apache.org/jira/browse/AMBARI-19023 > > > Repository: ambari > > > Description > --- > > Whenever adding an Atlas Server on a host, if the user executes the first > command as a "restart" (stop+start) instead of a "start" command, then the > stop command will fail because Ambari will not have generated any configs yet > so Atlas' atlas_stop.py will fail. > > To fix it, during a stop command, > If the pid dir doesn't exist, this means either > 1. The user just added Atlas service and issued a restart command > (stop+start). So stop should be a no-op since there's nothing to stop because > the pid dir does not exist. > > OR > > 2. The user changed the value of the pid dir config and incorrectly issued a > restart command. > In which case the stop command cannot do anything since Ambari doesn't know > which process to kill. > The start command will spawn another instance. > The user should have issued a stop, changed the config, and then started it. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py > a469ebb > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py > 585dc94 > > Diff: https://reviews.apache.org/r/54189/diff/ > > > Testing > --- > > Verified on a life cluster. > > Python unit tests passed. > -- > Total run:1166 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54169/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, and Sumit Mohanty. Bugs: AMBARI-19007 https://issues.apache.org/jira/browse/AMBARI-19007 Repository: ambari Description --- 1) Introduced new flag for all the hook suported components(HIVE,STORM,SQOOP,FALCON)under there respective env config-type. 2) If ATLAS service is present/selected for install, stack-advisor will set the hook flag. This flag value is used to recommend the expected configuration required for hook to work. 3) For Blue-print based installation user need to set hook flag and add common-atlas application properties under each hook config-type eg: hive-atlas-application.properties config-type which are require to communicate with external ATLAS Diffs - ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py a1d2f95 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java ec846f8 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml 09cced6 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 4429253 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 0fb21d0 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 150f629 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py 5e2c709 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py bcc598a ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 01e5f00 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py fe3f34a ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml f682e97 ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml f7823d2 ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py 283f54d ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py 68f06db ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml 9547335 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py e753e98 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py bda4fe2 ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml ab350dc ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml b71f4a9 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 775dbab ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java f2dd099 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 39cbbce Diff: https://reviews.apache.org/r/54169/diff/ Testing --- Tested Atlas installation via UI and blue-print. With blueprint used config_recommendation_strategy as NEVER_APPLY and ALWAYS_APPLY_DONT_OVERRIDE_CUSTOM_VALUES mvn -DskipPythonTests -Dtest=BlueprintConfigurationProcessorTest test --- T E S T S --- Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true Running org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessorTest Tests run: 167, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.101 sec - in org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessorTest Results : Tests run: 167, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 24.484s [INFO] Finished at: Tue Nov 29 11:40:30 UTC 2016 [INFO] Final Memory: 62M/797M [INFO] Thanks, Mugdha Varadkar
Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin
> On Nov. 28, 2016, 7:57 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml,
> > line 24
> > <https://reviews.apache.org/r/53980/diff/1/?file=1568491#file1568491line24>
> >
> > Existing clusters will change to ${cluster_name}_kms during Ambari
> > Upgrade.
> >
> > New clusters will use Stack Advisor to get the same name.
> >
> > After this point, if the user wishes to change the cluster name then
> > the value of this config will remain the same.
> >
> > Is this the intended behavior? If so, mark this issue as fixed.
Hi Alejandro,
Yes this is what it is planned.
- Mugdha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53980/#review157126
-------
On Nov. 22, 2016, 11:53 a.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53980/
> ---
>
> (Updated Nov. 22, 2016, 11:53 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan
> Hurley, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-18945
> https://issues.apache.org/jira/browse/AMBARI-18945
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Need to add a provision for creating default repository with static name or
> user provided name.
>
> This will help user to provided service name under Ranger supported plugins
> config tab and can take dump of latest snapshot of all policies and use it
> while recreating another/multiple clusters with same service name.
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
> 3431495
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
> bc3c120
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
> 32e1510
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
> 1f32c41
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
> 64f67b9
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
> bba0f3b
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
> 0cb88fe
>
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml
> 91061d1
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
> 4cefbda
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml
> 95e653c
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
> c20bdde
>
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml
> 983702f
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
> e753e98
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
> 4d42861
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
> dd87b72
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml
> 1deb9e5
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-security.xml
> cfd8a4f
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
> ce4074a
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-security.xml
> 9bd1079
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-security.xml
> 5f69962
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py
> 775dbab
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml
> ea0a026
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
> f9a3a9a
>
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
> 4135919
> ambari
Review Request 54122: AMBARI-18994 In HA cluster copy the hdfs-site.xml and hbase-site.xml to Ranger conf directory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54122/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Vishal Suvagia, and Velmurugan Periasamy. Bugs: AMBARI-18994 https://issues.apache.org/jira/browse/AMBARI-18994 Repository: ambari Description --- In present , for HA cluster we have to symlink hbase-site.xml and hdfs-site.xml to the /etc/ranger/admin/conf to Test connection be successful in HDFS and HBASE Repo. Actually the better approach is copying these files to /etc/ranger/admin/conf as all the services might be running in different nodes. and it is better if it done while enabling corresponding plugin itself. Diffs - ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 6debaf1 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py f1b4797 ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml f330bc9 Diff: https://reviews.apache.org/r/54122/diff/ Testing --- Running tests for stack:2.5 service:RANGER test_configure_default (test_ranger_admin.TestRangerAdmin) ... 2016-11-28 18:32:51,664 - Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 ok test_configure_secured (test_ranger_admin.TestRangerAdmin) ... 2016-11-28 18:32:51,694 - Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 ok test_start_default (test_ranger_admin.TestRangerAdmin) ... 2016-11-28 18:32:51,730 - Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 ok test_start_secured (test_ranger_admin.TestRangerAdmin) ... 2016-11-28 18:32:51,769 - Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 ok test_stop_default (test_ranger_admin.TestRangerAdmin) ... 2016-11-28 18:32:51,808 - Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 ok Thanks, Mugdha Varadkar
Re: Review Request 53725: AMBARI-18834 Add Ranger proxy user under Ranger KMS config during stack upgrade
> On Nov. 15, 2016, 1:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml, > > lines 139-144 > > <https://reviews.apache.org/r/53725/diff/2/?file=1563953#file1563953line139> > > > > Are you sure this works? I don't think the XSD allows you to put an > > execute-stage in this location. > > > > I was actually referring to something like this: > > > > ``` > > > title="Update Kerberos Descriptors"> > > > > > > > class="org.apache.ambari.server.serveraction.upgrades.UpgradeUserKerberosDescriptor"/> > > > > > > ``` > > > > You can scope the new group type to service="RANGER" > > component="RANGER_KMS" > > Mugdha Varadkar wrote: > I will go through the upgrade-pack.xsd and update the patch. Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53725/#review155907 --- On Nov. 24, 2016, 7:16 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53725/ > --- > > (Updated Nov. 24, 2016, 7:16 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, and Velmurugan Periasamy. > > > Bugs: AMBARI-18834 > https://issues.apache.org/jira/browse/AMBARI-18834 > > > Repository: ambari > > > Description > --- > > Add below properties during stack upgrade to 2.5 in kerberos environment > under kms-site.xml > > - hadoop.kms.proxyuser.[ranger].groups=* > - hadoop.kms.proxyuser.[ranger].hosts=* > - hadoop.kms.proxyuser.[ranger].users=* > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfig.java > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 04e4f3e > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml > 3233f7e > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 95c5f06 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml > a01996a > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > 05e2be1 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml > 1a26e59 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > f0c6131 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml > f520faf > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfigTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53725/diff/ > > > Testing > --- > > Tested EU from 2.4 to 2.5 stack in kerberos environment on centos 6. > > > -- > T E S T S > --- > OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support > was removed in 8.0 > Running > org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.679 sec - > in org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest > > Results : > > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 53725: AMBARI-18834 Add Ranger proxy user under Ranger KMS config during stack upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53725/ --- (Updated Nov. 24, 2016, 7:16 a.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Velmurugan Periasamy. Changes --- Handled Jonathan's comment Bugs: AMBARI-18834 https://issues.apache.org/jira/browse/AMBARI-18834 Repository: ambari Description --- Add below properties during stack upgrade to 2.5 in kerberos environment under kms-site.xml - hadoop.kms.proxyuser.[ranger].groups=* - hadoop.kms.proxyuser.[ranger].hosts=* - hadoop.kms.proxyuser.[ranger].users=* Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfig.java PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 04e4f3e ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 3233f7e ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 95c5f06 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml a01996a ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 05e2be1 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 1a26e59 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml f0c6131 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml f520faf ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfigTest.java PRE-CREATION Diff: https://reviews.apache.org/r/53725/diff/ Testing --- Tested EU from 2.4 to 2.5 stack in kerberos environment on centos 6. -- T E S T S --- OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0 Running org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.679 sec - in org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 Thanks, Mugdha Varadkar
Review Request 54025: AMBARI-18971 Populate Ranger LDAP group configs under LDAP category used for authentication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54025/ --- Review request for Ambari, Gautam Borad, Jaimin Jetly, and Velmurugan Periasamy. Bugs: AMBARI-18971 https://issues.apache.org/jira/browse/AMBARI-18971 Repository: ambari Description --- There are two properties under advanced ranger-admin-site called "Group Search Base" and "Group Search Filter" which are auto populated with the ones from Ranger User Info Group config. These are used during ldap authentication. It is little confusing as they are hidden somewhere below and user is not aware of these config while configuring other authentication properties Diffs - ambari-web/app/data/HDP2.3/site_properties.js 9ae68df Diff: https://reviews.apache.org/r/54025/diff/ Testing --- Tested Ranger installation on Centos 6 Thanks, Mugdha Varadkar
Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin
> On Nov. 22, 2016, 10:15 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml,
> > line 24
> > <https://reviews.apache.org/r/53980/diff/1/?file=1568491#file1568491line24>
> >
> > Should the value of existing clusters change?
Hi Alejandro,
The default value for this property is changed from macro [which was calculated
as str(config['clusterName']) + '_{component-short-name}'] to default name
cluster_{component-short-name} in upcoming ambari version.
Whenever Ranger component plugin is enabled, stack-advisor will set the value
to {cluster-name}_{component-short-name}.
Also I have handled upgradeCatalog changes which will calculate and set the
value to existing cluster.
Previously, used to set the value of the property using macro and that was
non-overridable, hence, user value was not taken into consideration at all.
- Mugdha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53980/#review156651
---
On Nov. 22, 2016, 11:53 a.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53980/
> ---
>
> (Updated Nov. 22, 2016, 11:53 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan
> Hurley, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-18945
> https://issues.apache.org/jira/browse/AMBARI-18945
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Need to add a provision for creating default repository with static name or
> user provided name.
>
> This will help user to provided service name under Ranger supported plugins
> config tab and can take dump of latest snapshot of all policies and use it
> while recreating another/multiple clusters with same service name.
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
> 3431495
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
> bc3c120
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
> 32e1510
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
> 1f32c41
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
> 64f67b9
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
> bba0f3b
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
> 0cb88fe
>
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml
> 91061d1
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
> 4cefbda
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml
> 95e653c
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
> c20bdde
>
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml
> 983702f
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
> e753e98
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
> 4d42861
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
> dd87b72
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml
> 1deb9e5
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-security.xml
> cfd8a4f
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
> ce4074a
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-security.xml
> 9bd1079
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-security.xml
> 5f69962
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py
> 775dbab
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml
> ea0a026
> ambari-server/src/main/re
Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Velmurugan Periasamy. Bugs: AMBARI-18945 https://issues.apache.org/jira/browse/AMBARI-18945 Repository: ambari Description --- Need to add a provision for creating default repository with static name or user provided name. This will help user to provided service name under Ranger supported plugins config tab and can take dump of latest snapshot of all policies and use it while recreating another/multiple clusters with same service name. Diffs - ambari-common/src/main/python/resource_management/libraries/functions/constants.py 3431495 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java bc3c120 ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 32e1510 ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 1f32c41 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 64f67b9 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py bba0f3b ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 0cb88fe ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml 91061d1 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 4cefbda ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml 95e653c ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py c20bdde ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml 983702f ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py e753e98 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 4d42861 ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json dd87b72 ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml 1deb9e5 ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-security.xml cfd8a4f ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml ce4074a ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-security.xml 9bd1079 ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-security.xml 5f69962 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 775dbab ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml ea0a026 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f9a3a9a ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 4135919 ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json a6ed6ce ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 39cbbce ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 7124307 ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json 05cb78a ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 7054e8f Diff: https://reviews.apache.org/r/53980/diff/ Testing --- mvn -DskipPythonTests -Dtest=UpgradeCatalog250Test test --- T E S T S --- OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0 Running org.apache.ambari.server.upgrade.UpgradeCatalog250Test Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.548 sec - in org.apache.ambari.server.upgrade.UpgradeCatalog250Test Results : Tests run: 13, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 30.347 s [INFO] Finished at: 2016-11-22T11:51:23+00:00 [INFO] Final Memory: 63M/1107M [INFO] Thanks, Mugdha Varadkar
Re: Review Request 53978: AMBARI-18818 ADDENDUM Config changes for Atlas to Support KnoxSSO Authentication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53978/ --- (Updated Nov. 22, 2016, 11:39 a.m.) Review request for Ambari, Alejandro Fernandez and Gautam Borad. Bugs: AMBARI-18818 https://issues.apache.org/jira/browse/AMBARI-18818 Repository: ambari Description --- Providing addendum patch for AMBARI-18818 to change atlas knox sso config properties with correct name. Diffs (updated) - ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 8046695 ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/themes/theme_version_2.json f72ea4b ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 718da2c ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 7759c09 ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py a7a45f8 Diff: https://reviews.apache.org/r/53978/diff/ Testing --- Test report for stack-advisor Running tests for stack:2.6 service:common test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_WithDerby (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_WithPostgresql (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_heterogeneous_hosts (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_withMysql (test_stack_advisor.TestHDP26StackAdvisor) ... ok Ran 5 tests in 2.550s OK Thanks, Mugdha Varadkar
Review Request 53978: AMBARI-18818 ADDENDUM Config changes for Atlas to Support KnoxSSO Authentication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53978/ --- Review request for Ambari, Alejandro Fernandez and Gautam Borad. Bugs: AMBARI-18818 https://issues.apache.org/jira/browse/AMBARI-18818 Repository: ambari Description --- Providing addendum patch for AMBARI-18818 to change atlas knox sso config properties with correct name. Diffs - ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/themes/theme_version_2.json f72ea4b ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 718da2c ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py a7a45f8 Diff: https://reviews.apache.org/r/53978/diff/ Testing --- Test report for stack-advisor Running tests for stack:2.6 service:common test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_WithDerby (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_WithPostgresql (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_heterogeneous_hosts (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_withMysql (test_stack_advisor.TestHDP26StackAdvisor) ... ok Ran 5 tests in 2.550s OK Thanks, Mugdha Varadkar
Re: Review Request 53722: AMBARI-18425:Support PAM as an authentication option for Ranger in Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53722/#review156438 --- Ship it! Ship It! - Mugdha Varadkar On Nov. 17, 2016, 9:05 p.m., Shi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53722/ > --- > > (Updated Nov. 17, 2016, 9:05 p.m.) > > > Review request for Ambari and Robert Levas. > > > Bugs: trunk > https://issues.apache.org/jira/browse/trunk > > > Repository: ambari > > > Description > --- > > Ranger-842 has added PAM support for ranger, we need to add this part to > ambari, to do automatic setup for ranger to use PAM authentication. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 6462495 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_admin_pam.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_remote_pam.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml > c0e537b > ambari-web/app/data/HDP2.3/site_properties.js 9ae68df > > Diff: https://reviews.apache.org/r/53722/diff/ > > > Testing > --- > > In this patch, the default value for ranger-admin module is > authsufficientpam_unix.so > authsufficientpam_sss.so > account sufficientpam_unix.so > account sufficientpam_sss.so > 1. Create a Unix User shiwang, and sync unix user to Ranger, restart > ranger-admin as root and login to ranger using shiwang, it will success. > 2. Change ranger-admin pam file to > authsufficientpam_deny.so > account sufficientpam_deny.so > and login using shiwang it will fall. > 3. Change ranger-admin pam file to > authsufficientpam_ldap.so > account sufficientpam_ldap.so > and use a ldap user that already sync in ranger(it will show user not synced > error if not synced in ranger) login will success. > 4. Configure sssd with ldap and using the synced user from ldap login will > success. > > > Thanks, > > Shi Wang > >
Re: Review Request 53722: AMBARI-18425:Support PAM as an authentication option for Ranger in Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53722/#review156198 --- ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (line 164) <https://reviews.apache.org/r/53722/#comment226355> What if the directory is not present? Should it just ignore or create the directory? - Mugdha Varadkar On Nov. 17, 2016, 7:47 a.m., Shi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53722/ > --- > > (Updated Nov. 17, 2016, 7:47 a.m.) > > > Review request for Ambari and Robert Levas. > > > Bugs: trunk > https://issues.apache.org/jira/browse/trunk > > > Repository: ambari > > > Description > --- > > Ranger-842 has added PAM support for ranger, we need to add this part to > ambari, to do automatic setup for ranger to use PAM authentication. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 6462495 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_admin_pam.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_remote_pam.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml > c0e537b > ambari-web/app/data/HDP2.3/site_properties.js 9ae68df > > Diff: https://reviews.apache.org/r/53722/diff/ > > > Testing > --- > > In this patch, the default value for ranger-admin module is > authsufficientpam_unix.so > authsufficientpam_sss.so > account sufficientpam_unix.so > account sufficientpam_sss.so > 1. Create a Unix User shiwang, and sync unix user to Ranger, restart > ranger-admin as root and login to ranger using shiwang, it will success. > 2. Change ranger-admin pam file to > authsufficientpam_deny.so > account sufficientpam_deny.so > and login using shiwang it will fall. > 3. Change ranger-admin pam file to > authsufficientpam_ldap.so > account sufficientpam_ldap.so > and use a ldap user that already sync in ranger(it will show user not synced > error if not synced in ranger) login will success. > 4. Configure sssd with ldap and using the synced user from ldap login will > success. > > > Thanks, > > Shi Wang > >
Re: Review Request 53725: AMBARI-18834 Add Ranger proxy user under Ranger KMS config during stack upgrade
> On Nov. 14, 2016, 1:05 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml, > > lines 620-622 > > <https://reviews.apache.org/r/53725/diff/1/?file=1563029#file1563029line620> > > > > You can place this with a element inside of a > > element inside of the up top. > > > > If there's not already a group for Ranger KMS, you can add one. This > > way, you're still using the element. Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53725/#review155804 --- On Nov. 15, 2016, 6:43 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53725/ > --- > > (Updated Nov. 15, 2016, 6:43 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, and Velmurugan Periasamy. > > > Bugs: AMBARI-18834 > https://issues.apache.org/jira/browse/AMBARI-18834 > > > Repository: ambari > > > Description > --- > > Add below properties during stack upgrade to 2.5 in kerberos environment > under kms-site.xml > > - hadoop.kms.proxyuser.[ranger].groups=* > - hadoop.kms.proxyuser.[ranger].hosts=* > - hadoop.kms.proxyuser.[ranger].users=* > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfig.java > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 04e4f3e > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml > 3233f7e > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 95c5f06 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml > a01996a > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > 05e2be1 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml > 1a26e59 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > f0c6131 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml > f520faf > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfigTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53725/diff/ > > > Testing > --- > > Tested EU from 2.4 to 2.5 stack in kerberos environment on centos 6. > > > -- > T E S T S > --- > OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support > was removed in 8.0 > Running > org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.679 sec - > in org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest > > Results : > > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 53725: AMBARI-18834 Add Ranger proxy user under Ranger KMS config during stack upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53725/ --- (Updated Nov. 15, 2016, 6:43 a.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Velmurugan Periasamy. Bugs: AMBARI-18834 https://issues.apache.org/jira/browse/AMBARI-18834 Repository: ambari Description --- Add below properties during stack upgrade to 2.5 in kerberos environment under kms-site.xml - hadoop.kms.proxyuser.[ranger].groups=* - hadoop.kms.proxyuser.[ranger].hosts=* - hadoop.kms.proxyuser.[ranger].users=* Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfig.java PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 04e4f3e ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 3233f7e ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 95c5f06 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml a01996a ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 05e2be1 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 1a26e59 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml f0c6131 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml f520faf ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfigTest.java PRE-CREATION Diff: https://reviews.apache.org/r/53725/diff/ Testing --- Tested EU from 2.4 to 2.5 stack in kerberos environment on centos 6. -- T E S T S --- OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0 Running org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.679 sec - in org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 Thanks, Mugdha Varadkar
Re: Review Request 53705: AMBARI-18818 Config changes for Atlas to Support KnoxSSO Authentication
> On Nov. 14, 2016, 6:42 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py, > > line 47 > > <https://reviews.apache.org/r/53705/diff/1/?file=1562721#file1562721line47> > > > > We need to ensure this is deterministic. Please sort and then pick the > > element in index 0 Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53705/#review155827 ------- On Nov. 15, 2016, 6:02 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53705/ > --- > > (Updated Nov. 15, 2016, 6:02 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, > and Madhan Neethiraj. > > > Bugs: AMBARI-18818 > https://issues.apache.org/jira/browse/AMBARI-18818 > > > Repository: ambari > > > Description > --- > > Following properties are need to be added in atlas under > application.properties from Ambari Configs to enable Knox SSO in Atlas > atlas.sso.knox.enabled > atlas.sso.knox.providerurl > atlas.sso.knox.publicKey > atlas.sso.knox.browser.useragent > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml > 95715b3 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml > 92db1f9 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/themes/theme_version_2.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 49dd086 > ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py > 8227d69 > > Diff: https://reviews.apache.org/r/53705/diff/ > > > Testing > --- > > Tested Atlas installation with stack 2.6 on centos 6. > > Test report for stack-advisor > > Running tests for stack:2.6 service:common > test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) > ... ok > test_recommendDruidConfigurations_WithDerby > (test_stack_advisor.TestHDP26StackAdvisor) ... ok > test_recommendDruidConfigurations_WithPostgresql > (test_stack_advisor.TestHDP26StackAdvisor) ... ok > test_recommendDruidConfigurations_heterogeneous_hosts > (test_stack_advisor.TestHDP26StackAdvisor) ... ok > test_recommendDruidConfigurations_withMysql > (test_stack_advisor.TestHDP26StackAdvisor) ... ok > > -- > Ran 5 tests in 2.550s > > OK > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 53705: AMBARI-18818 Config changes for Atlas to Support KnoxSSO Authentication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53705/ --- (Updated Nov. 15, 2016, 6:02 a.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, and Madhan Neethiraj. Bugs: AMBARI-18818 https://issues.apache.org/jira/browse/AMBARI-18818 Repository: ambari Description --- Following properties are need to be added in atlas under application.properties from Ambari Configs to enable Knox SSO in Atlas atlas.sso.knox.enabled atlas.sso.knox.providerurl atlas.sso.knox.publicKey atlas.sso.knox.browser.useragent Diffs (updated) - ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml 95715b3 ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 92db1f9 ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/themes/theme_version_2.json PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 49dd086 ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 8227d69 Diff: https://reviews.apache.org/r/53705/diff/ Testing --- Tested Atlas installation with stack 2.6 on centos 6. Test report for stack-advisor Running tests for stack:2.6 service:common test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_WithDerby (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_WithPostgresql (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_heterogeneous_hosts (test_stack_advisor.TestHDP26StackAdvisor) ... ok test_recommendDruidConfigurations_withMysql (test_stack_advisor.TestHDP26StackAdvisor) ... ok -- Ran 5 tests in 2.550s OK Thanks, Mugdha Varadkar
Review Request 53725: AMBARI-18834 Add Ranger proxy user under Ranger KMS config during stack upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53725/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Velmurugan Periasamy. Bugs: AMBARI-18834 https://issues.apache.org/jira/browse/AMBARI-18834 Repository: ambari Description --- Add below properties during stack upgrade to 2.5 in kerberos environment under kms-site.xml - hadoop.kms.proxyuser.[ranger].groups=* - hadoop.kms.proxyuser.[ranger].hosts=* - hadoop.kms.proxyuser.[ranger].users=* Diffs - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfig.java PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 04e4f3e ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 3233f7e ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 95c5f06 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml a01996a ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 05e2be1 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 1a26e59 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml f0c6131 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml f520faf ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfigTest.java PRE-CREATION Diff: https://reviews.apache.org/r/53725/diff/ Testing --- Tested EU from 2.4 to 2.5 stack in kerberos environment on centos 6. -- T E S T S --- OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0 Running org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.679 sec - in org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 Thanks, Mugdha Varadkar
Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy
> On Nov. 8, 2016, 6:48 p.m., Alejandro Fernandez wrote: > > What should the behavior be for customers with Ranger and Kerberos that are > > upgrading their stack from an existing version with the old logic (could be > > HDP 2.3, 2.4, 2.5) to a higher HDP version? Thanks for pointing it out, will need Ranger proxy related properties if upgrading from 2.3/2.4 to 2.5 in config-upgrade.xml. Have created a Jira (https://issues.apache.org/jira/browse/AMBARI-18834) to track the fix. - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53129/#review155324 --- On Nov. 9, 2016, 1:25 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53129/ > --- > > (Updated Nov. 9, 2016, 1:25 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, > and Velmurugan Periasamy. > > > Bugs: AMBARI-18671 > https://issues.apache.org/jira/browse/AMBARI-18671 > > > Repository: ambari > > > Description > --- > > Add below properties under kms-site.xml having value as '*', if YARN|SPARK > services are installed > > - hadoop.kms.proxyuser.[livy|yarn].groups > - hadoop.kms.proxyuser.[livy|yarn].hosts > - hadoop.kms.proxyuser.[livy|yarn].users > > Also with above changes need to revert changes done for AMBARI-18096 > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 24b9f6e > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > ec92f3a > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > f759b6c > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > ad6842f > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 6fe357a > > Diff: https://reviews.apache.org/r/53129/diff/ > > > Testing > --- > > Tested Ranger Kms installation with Yarn|Spark on centos 6 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53129/ --- (Updated Nov. 9, 2016, 1:25 p.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, and Velmurugan Periasamy. Changes --- Shifted the logic of stack-advisor.py from 2.5 to 2.3. As AMBARI-18096 is reverted and the proxy-user needs to be added in stack 2.3 Bugs: AMBARI-18671 https://issues.apache.org/jira/browse/AMBARI-18671 Repository: ambari Description --- Add below properties under kms-site.xml having value as '*', if YARN|SPARK services are installed - hadoop.kms.proxyuser.[livy|yarn].groups - hadoop.kms.proxyuser.[livy|yarn].hosts - hadoop.kms.proxyuser.[livy|yarn].users Also with above changes need to revert changes done for AMBARI-18096 Diffs (updated) - ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 24b9f6e ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py ec92f3a ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py f759b6c ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py ad6842f ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 6fe357a Diff: https://reviews.apache.org/r/53129/diff/ Testing --- Tested Ranger Kms installation with Yarn|Spark on centos 6 Thanks, Mugdha Varadkar
Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy
> On Oct. 26, 2016, 6:11 p.m., Alejandro Fernandez wrote: > > How will this impact existing clusters? Do they need to update these > > configs once they upgrade Ambari? What about when they upgrade the stack? For existing clusters this properties will be available as custom properties. After ambari/stack upgrade the custom properties will be retained. Currently the properties needs to be added manually, this fix will automatically add it using Stack Advisor. - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53129/#review153916 --- On Oct. 26, 2016, 10:53 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53129/ > --- > > (Updated Oct. 26, 2016, 10:53 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, > and Velmurugan Periasamy. > > > Bugs: AMBARI-18671 > https://issues.apache.org/jira/browse/AMBARI-18671 > > > Repository: ambari > > > Description > --- > > Add below properties under kms-site.xml having value as '*', if YARN|SPARK > services are installed > > - hadoop.kms.proxyuser.[livy|yarn].groups > - hadoop.kms.proxyuser.[livy|yarn].hosts > - hadoop.kms.proxyuser.[livy|yarn].users > > Also with above changes need to revert changes done for AMBARI-18096 > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 24b9f6e > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 986ca69 > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > cd69dc3 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 72e59aa > > Diff: https://reviews.apache.org/r/53129/diff/ > > > Testing > --- > > Tested Ranger Kms installation with Yarn|Spark on centos 6 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy
> On Oct. 25, 2016, 4:32 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, > > line 1771 > > <https://reviews.apache.org/r/53129/diff/2/?file=1545133#file1545133line1771> > > > > Technically item is an "index" yes item is meant to be an index for the requiredServices. Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53129/#review153806 ------- On Oct. 26, 2016, 10:53 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53129/ > --- > > (Updated Oct. 26, 2016, 10:53 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, > and Velmurugan Periasamy. > > > Bugs: AMBARI-18671 > https://issues.apache.org/jira/browse/AMBARI-18671 > > > Repository: ambari > > > Description > --- > > Add below properties under kms-site.xml having value as '*', if YARN|SPARK > services are installed > > - hadoop.kms.proxyuser.[livy|yarn].groups > - hadoop.kms.proxyuser.[livy|yarn].hosts > - hadoop.kms.proxyuser.[livy|yarn].users > > Also with above changes need to revert changes done for AMBARI-18096 > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 24b9f6e > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 986ca69 > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > cd69dc3 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 72e59aa > > Diff: https://reviews.apache.org/r/53129/diff/ > > > Testing > --- > > Tested Ranger Kms installation with Yarn|Spark on centos 6 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53129/ --- (Updated Oct. 26, 2016, 10:53 a.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, and Velmurugan Periasamy. Bugs: AMBARI-18671 https://issues.apache.org/jira/browse/AMBARI-18671 Repository: ambari Description --- Add below properties under kms-site.xml having value as '*', if YARN|SPARK services are installed - hadoop.kms.proxyuser.[livy|yarn].groups - hadoop.kms.proxyuser.[livy|yarn].hosts - hadoop.kms.proxyuser.[livy|yarn].users Also with above changes need to revert changes done for AMBARI-18096 Diffs (updated) - ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 24b9f6e ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 986ca69 ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py cd69dc3 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 72e59aa Diff: https://reviews.apache.org/r/53129/diff/ Testing --- Tested Ranger Kms installation with Yarn|Spark on centos 6 Thanks, Mugdha Varadkar
Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53129/ --- (Updated Oct. 25, 2016, 2:20 p.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, and Velmurugan Periasamy. Bugs: AMBARI-18671 https://issues.apache.org/jira/browse/AMBARI-18671 Repository: ambari Description --- Add below properties under kms-site.xml having value as '*', if YARN|SPARK services are installed - hadoop.kms.proxyuser.[livy|yarn].groups - hadoop.kms.proxyuser.[livy|yarn].hosts - hadoop.kms.proxyuser.[livy|yarn].users Also with above changes need to revert changes done for AMBARI-18096 Diffs (updated) - ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 24b9f6e ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 986ca69 ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py cd69dc3 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 72e59aa Diff: https://reviews.apache.org/r/53129/diff/ Testing --- Tested Ranger Kms installation with Yarn|Spark on centos 6 Thanks, Mugdha Varadkar
Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53129/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, and Velmurugan Periasamy. Bugs: AMBARI-18671 https://issues.apache.org/jira/browse/AMBARI-18671 Repository: ambari Description --- Add below properties under kms-site.xml having value as '*', if YARN|SPARK services are installed - hadoop.kms.proxyuser.[livy|yarn].groups - hadoop.kms.proxyuser.[livy|yarn].hosts - hadoop.kms.proxyuser.[livy|yarn].users Also with above changes need to revert changes done for AMBARI-18096 Diffs - ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 24b9f6e ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 986ca69 ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py cd69dc3 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 72e59aa Diff: https://reviews.apache.org/r/53129/diff/ Testing --- Tested Ranger Kms installation with Yarn|Spark on centos 6 Thanks, Mugdha Varadkar
Review Request 52825: AMBARI-18585 Set _HOST for Hbase Master principal in Kerberos enabled Ranger Hbase Plugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52825/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, and Velmurugan Periasamy. Bugs: AMBARI-18585 https://issues.apache.org/jira/browse/AMBARI-18585 Repository: ambari Description --- Need to update hbase plugin repo config for master principal to have a _HOST instead of a specific node. Diffs - ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 49e4575 Diff: https://reviews.apache.org/r/52825/diff/ Testing --- Tested on centos 6 with Ranger Hbase plugin enabled. Thanks, Mugdha Varadkar
Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env
> On Oct. 5, 2016, 5:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java, > > line 171 > > <https://reviews.apache.org/r/52504/diff/1/?file=1519937#file1519937line171> > > > > You can set this to null and use StringUtils.isBlank() check Updated in latest patch > On Oct. 5, 2016, 5:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java, > > line 186 > > <https://reviews.apache.org/r/52504/diff/1/?file=1519937#file1519937line186> > > > > StringUtils.isBlank() Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52504/#review151518 --- On Oct. 6, 2016, 5:57 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52504/ > --- > > (Updated Oct. 6, 2016, 5:57 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, and Velmurugan Periasamy. > > > Bugs: AMBARI-18521 > https://issues.apache.org/jira/browse/AMBARI-18521 > > > Repository: ambari > > > Description > --- > > Stack changes required while upgrading to stack 2.5 in secure env > - Remove adding spnego principal value to > ranger-admin-site/ranger.spnego.kerberos.principal > - Get storm principal bare name and update it accordingly to > ranger-admin-site.xml/ranger.plugins.storm.serviceuser > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java > c3d71c0 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java > 133a9e3 > > Diff: https://reviews.apache.org/r/52504/diff/ > > > Testing > --- > > mvn -DskipPythonTests -Dtest=RangerKerberosConfigCalculationTest test > --- > T E S T S > --- > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; > support was removed in 8.0 > Running > org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec - > in > org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest > > Results : > > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 47.998 s > [INFO] Finished at: 2016-10-04T06:15:35+00:00 > [INFO] Final Memory: 67M/1203M > [INFO] > > > > Tested Ranger EU from 2.4 to 2.5 stack in secure env on centos6 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52504/ --- (Updated Oct. 6, 2016, 5:57 a.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Velmurugan Periasamy. Bugs: AMBARI-18521 https://issues.apache.org/jira/browse/AMBARI-18521 Repository: ambari Description --- Stack changes required while upgrading to stack 2.5 in secure env - Remove adding spnego principal value to ranger-admin-site/ranger.spnego.kerberos.principal - Get storm principal bare name and update it accordingly to ranger-admin-site.xml/ranger.plugins.storm.serviceuser Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java c3d71c0 ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java 133a9e3 Diff: https://reviews.apache.org/r/52504/diff/ Testing --- mvn -DskipPythonTests -Dtest=RangerKerberosConfigCalculationTest test --- T E S T S --- Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0 Running org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec - in org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 47.998 s [INFO] Finished at: 2016-10-04T06:15:35+00:00 [INFO] Final Memory: 67M/1203M [INFO] Tested Ranger EU from 2.4 to 2.5 stack in secure env on centos6 Thanks, Mugdha Varadkar
Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52504/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, and Velmurugan Periasamy. Bugs: AMBARI-18521 https://issues.apache.org/jira/browse/AMBARI-18521 Repository: ambari Description --- Stack changes required while upgrading to stack 2.5 in secure env - Remove adding spnego principal value to ranger-admin-site/ranger.spnego.kerberos.principal - Get storm principal bare name and update it accordingly to ranger-admin-site.xml/ranger.plugins.storm.serviceuser Diffs - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java c3d71c0 ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java 133a9e3 Diff: https://reviews.apache.org/r/52504/diff/ Testing --- mvn -DskipPythonTests -Dtest=RangerKerberosConfigCalculationTest test --- T E S T S --- Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0 Running org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec - in org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 47.998 s [INFO] Finished at: 2016-10-04T06:15:35+00:00 [INFO] Final Memory: 67M/1203M [INFO] Tested Ranger EU from 2.4 to 2.5 stack in secure env on centos6 Thanks, Mugdha Varadkar
Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5
> On Sept. 14, 2016, 5:58 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, > > line 694 > > <https://reviews.apache.org/r/51890/diff/2/?file=1498555#file1498555line694> > > > > Why using stack_supports_ranger_kerberos? It sounds like a workaround > > for >= HDP-2.5+. > > Mugdha Varadkar wrote: > Yes, using stack_supports_ranger_kerberos feature here only for stack 2.5 > onwards, since this feature is also introduced from stack 2.5 > Do you want me to add new feature here ? Added feature in updated patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51890/#review148939 ------- On Sept. 15, 2016, 5:26 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51890/ > --- > > (Updated Sept. 15, 2016, 5:26 a.m.) > > > Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and > Velmurugan Periasamy. > > > Bugs: AMBARI-18386 > https://issues.apache.org/jira/browse/AMBARI-18386 > > > Repository: ambari > > > Description > --- > > From ambari stacks for Ranger: enable ranger hive plugin takes care of using > right jdbc url for repo configs that are set for creating a repository in > Ranger for Secure and simple install of hive. > However in HiverServer2 HA env, jdbc url needs to change in repo config with > zk url. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 169fbff > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 5e3e233 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 8c838db > > Diff: https://reviews.apache.org/r/51890/diff/ > > > Testing > --- > > Tested Ranger hive plugin with Ranger install on centos6 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51890/ --- (Updated Sept. 15, 2016, 5:26 a.m.) Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. Changes --- Added stack feature in updated patch Ran 268 tests in 6.913s OK -- Total run:1126 Total errors:0 Total failures:0 Bugs: AMBARI-18386 https://issues.apache.org/jira/browse/AMBARI-18386 Repository: ambari Description --- >From ambari stacks for Ranger: enable ranger hive plugin takes care of using >right jdbc url for repo configs that are set for creating a repository in >Ranger for Secure and simple install of hive. However in HiverServer2 HA env, jdbc url needs to change in repo config with zk url. Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/constants.py 169fbff ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 5e3e233 ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 8c838db Diff: https://reviews.apache.org/r/51890/diff/ Testing --- Tested Ranger hive plugin with Ranger install on centos6 Thanks, Mugdha Varadkar
Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5
> On Sept. 14, 2016, 3:25 p.m., Velmurugan Periasamy wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, > > line 696 > > <https://reviews.apache.org/r/51890/diff/1/?file=1498387#file1498387line696> > > > > Should we use zookeeper based URL even if HA is not enabled? That would > > cover any additional parameters that need to be added for Hive (like http > > transport mode etc) Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51890/#review148907 ------- On Sept. 14, 2016, 4:32 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51890/ > --- > > (Updated Sept. 14, 2016, 4:32 p.m.) > > > Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and > Velmurugan Periasamy. > > > Bugs: AMBARI-18386 > https://issues.apache.org/jira/browse/AMBARI-18386 > > > Repository: ambari > > > Description > --- > > From ambari stacks for Ranger: enable ranger hive plugin takes care of using > right jdbc url for repo configs that are set for creating a repository in > Ranger for Secure and simple install of hive. > However in HiverServer2 HA env, jdbc url needs to change in repo config with > zk url. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 5e3e233 > > Diff: https://reviews.apache.org/r/51890/diff/ > > > Testing > --- > > Tested Ranger hive plugin with Ranger install on centos6 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51890/ --- (Updated Sept. 14, 2016, 4:32 p.m.) Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. Changes --- Updated patch removed hive-server2 HA check. Updating the jdbc url config from 2.5 stack onwards Summary (updated) - AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5 Bugs: AMBARI-18386 https://issues.apache.org/jira/browse/AMBARI-18386 Repository: ambari Description --- >From ambari stacks for Ranger: enable ranger hive plugin takes care of using >right jdbc url for repo configs that are set for creating a repository in >Ranger for Secure and simple install of hive. However in HiverServer2 HA env, jdbc url needs to change in repo config with zk url. Diffs (updated) - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 5e3e233 Diff: https://reviews.apache.org/r/51890/diff/ Testing --- Tested Ranger hive plugin with Ranger install on centos6 Thanks, Mugdha Varadkar
Re: Review Request 51846: AMBARI-18375 Ranger Plugin configs is not generated for Hive interactive
> On Sept. 13, 2016, 8:14 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive_interactive.py,
> > line 76
> > <https://reviews.apache.org/r/51846/diff/1/?file=1497805#file1497805line76>
> >
> > What was the diff?
There is a indentation diff at line 56, 57
<<from resource_management.libraries.functions.setup_ranger_plugin_xml
import setup_ranger_plugin
<<setup_ranger_plugin('hive-server2-hive2', 'hive',
params.ranger_previous_jdbc_jar,
params.ranger_downloaded_custom_connector,
- Mugdha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51846/#review148772
-------
On Sept. 13, 2016, 1:39 p.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51846/
> ---
>
> (Updated Sept. 13, 2016, 1:39 p.m.)
>
>
> Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and
> Velmurugan Periasamy.
>
>
> Bugs: AMBARI-18375
> https://issues.apache.org/jira/browse/AMBARI-18375
>
>
> Repository: ambari
>
>
> Description
> ---
>
> If audit to hdfs is OFF for ranger hive plugin, configs related to plugins
> are not generated for Hive interactive
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive_interactive.py
> 0b5d5db
>
> Diff: https://reviews.apache.org/r/51846/diff/
>
>
> Testing
> ---
>
> Tested Ranger hive plugin and hive interactive with Ranger install on centos6
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url, when hiveserver2 HA is enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51890/ --- Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. Bugs: AMBARI-18386 https://issues.apache.org/jira/browse/AMBARI-18386 Repository: ambari Description --- >From ambari stacks for Ranger: enable ranger hive plugin takes care of using >right jdbc url for repo configs that are set for creating a repository in >Ranger for Secure and simple install of hive. However in HiverServer2 HA env, jdbc url needs to change in repo config with zk url. Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 5e3e233 Diff: https://reviews.apache.org/r/51890/diff/ Testing --- Tested Ranger hive plugin with Ranger install on centos6 Thanks, Mugdha Varadkar
Review Request 51846: AMBARI-18375 Ranger Plugin configs is not generated for Hive interactive
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51846/ --- Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy. Bugs: AMBARI-18375 https://issues.apache.org/jira/browse/AMBARI-18375 Repository: ambari Description --- If audit to hdfs is OFF for ranger hive plugin, configs related to plugins are not generated for Hive interactive Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive_interactive.py 0b5d5db Diff: https://reviews.apache.org/r/51846/diff/ Testing --- Tested Ranger hive plugin and hive interactive with Ranger install on centos6 Thanks, Mugdha Varadkar
Review Request 50919: AMBARI-18073 Text change of Audit to DB Removal during upgrade for Ranger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50919/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Velmurugan Periasamy. Bugs: AMBARI-18073 https://issues.apache.org/jira/browse/AMBARI-18073 Repository: ambari Description --- Changing text during upgrade of Ranger for Audit to DB removal Diffs - ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java da07b26 ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml c41c90c Diff: https://reviews.apache.org/r/50919/diff/ Testing --- Tested Ranger Upgrade from 2.4 to 2.5 Thanks, Mugdha Varadkar
Re: Review Request 50791: AMBARI-18019 Referring component level identity is not working for ranger-atlas-plugin
> On Aug. 4, 2016, 4:39 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json,
> > line 13
> > <https://reviews.apache.org/r/50791/diff/1/?file=1462823#file1462823line13>
> >
> > folder should be common-services/ATLAS/0.7.0. The "2.5" is HDP specific
> > versioning and shouldnt be in common-services
Removed changes done common-service version in updated patch
- Mugdha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50791/#review144780
-------
On Aug. 4, 2016, 6:48 p.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50791/
> ---
>
> (Updated Aug. 4, 2016, 6:48 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya,
> Robert Levas, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-18019
> https://issues.apache.org/jira/browse/AMBARI-18019
>
>
> Repository: ambari
>
>
> Description
> ---
>
> In-order to support AMBARI-17902 changes for ranger-atlas plugin, trying to
> accommodate below code in common-services/ATLAS/0.7.0.2.5/kerberos.json.
> {
> "name": "/ATLAS/ATLAS_SERVER/atlas",
> "principal": {
> "configuration":
> "ranger-atlas-audit/xasecure.audit.jaas.Client.option.principal"
> },
> "keytab": {
> "configuration":
> "ranger-atlas-audit/xasecure.audit.jaas.Client.option.keyTab"
> }
> }
> However these configs are not being available at ranger-atlas-audit.xml
>
> This occurs because the Kerberos Descriptors does not allow using the same
> identity name more than once.
> After AMBARI-17993 fix this is made possible by using reference tag.
>
>
> Changes include:
> 1) updating kerberos.json
> 2) moving ranger related configs file from
> /stacks/HDP/2.5/services/ATLAS/configuration to
> /common-services/ATLAS/0.7.0.2.5/configuration as common service version
> 0.7.0.2.5 is maintained.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
> 2be4b7d
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
> 43c767d
>
> Diff: https://reviews.apache.org/r/50791/diff/
>
>
> Testing
> ---
>
> Tested Atlas installation in secure mode with and without Ranger
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 50791: AMBARI-18019 Referring component level identity is not working for ranger-atlas-plugin
> On Aug. 4, 2016, 4:48 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/ranger-atlas-policymgr-ssl.xml,
> > line 25
> > <https://reviews.apache.org/r/50791/diff/1/?file=1462821#file1462821line25>
> >
> > We should not setting any properties with value that has "hdp"
> > hardcoded in it in common-services. This should be set to whatever is the
> > Apache default and then overridden in the HDP stack.
> >
> > Refer:
> >
> > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml#L22-L27
> >
> > and
> >
> >
> > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-policymgr-ssl.xml#L22-L27
Removed changes done common-service version in updated patch
> On Aug. 4, 2016, 4:48 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/ranger-atlas-policymgr-ssl.xml,
> > line 43
> > <https://reviews.apache.org/r/50791/diff/1/?file=1462821#file1462821line43>
> >
> > No hdp hardcoding in common-services
Removed changes done common-service version in updated patch
- Mugdha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50791/#review144781
---
On Aug. 4, 2016, 6:48 p.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50791/
> ---
>
> (Updated Aug. 4, 2016, 6:48 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya,
> Robert Levas, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-18019
> https://issues.apache.org/jira/browse/AMBARI-18019
>
>
> Repository: ambari
>
>
> Description
> ---
>
> In-order to support AMBARI-17902 changes for ranger-atlas plugin, trying to
> accommodate below code in common-services/ATLAS/0.7.0.2.5/kerberos.json.
> {
> "name": "/ATLAS/ATLAS_SERVER/atlas",
> "principal": {
> "configuration":
> "ranger-atlas-audit/xasecure.audit.jaas.Client.option.principal"
> },
> "keytab": {
> "configuration":
> "ranger-atlas-audit/xasecure.audit.jaas.Client.option.keyTab"
> }
> }
> However these configs are not being available at ranger-atlas-audit.xml
>
> This occurs because the Kerberos Descriptors does not allow using the same
> identity name more than once.
> After AMBARI-17993 fix this is made possible by using reference tag.
>
>
> Changes include:
> 1) updating kerberos.json
> 2) moving ranger related configs file from
> /stacks/HDP/2.5/services/ATLAS/configuration to
> /common-services/ATLAS/0.7.0.2.5/configuration as common service version
> 0.7.0.2.5 is maintained.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
> 2be4b7d
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
> 43c767d
>
> Diff: https://reviews.apache.org/r/50791/diff/
>
>
> Testing
> ---
>
> Tested Atlas installation in secure mode with and without Ranger
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 50791: AMBARI-18019 Referring component level identity is not working for ranger-atlas-plugin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50791/
---
(Updated Aug. 4, 2016, 6:48 p.m.)
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya,
Robert Levas, and Velmurugan Periasamy.
Changes
---
Updated review with fix for the issue itself and dropped changes done
common-service version.
Bugs: AMBARI-18019
https://issues.apache.org/jira/browse/AMBARI-18019
Repository: ambari
Description
---
In-order to support AMBARI-17902 changes for ranger-atlas plugin, trying to
accommodate below code in common-services/ATLAS/0.7.0.2.5/kerberos.json.
{
"name": "/ATLAS/ATLAS_SERVER/atlas",
"principal": {
"configuration":
"ranger-atlas-audit/xasecure.audit.jaas.Client.option.principal"
},
"keytab": {
"configuration":
"ranger-atlas-audit/xasecure.audit.jaas.Client.option.keyTab"
}
}
However these configs are not being available at ranger-atlas-audit.xml
This occurs because the Kerberos Descriptors does not allow using the same
identity name more than once.
After AMBARI-17993 fix this is made possible by using reference tag.
Changes include:
1) updating kerberos.json
2) moving ranger related configs file from
/stacks/HDP/2.5/services/ATLAS/configuration to
/common-services/ATLAS/0.7.0.2.5/configuration as common service version
0.7.0.2.5 is maintained.
Diffs (updated)
-
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
2be4b7d
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
43c767d
Diff: https://reviews.apache.org/r/50791/diff/
Testing
---
Tested Atlas installation in secure mode with and without Ranger
Thanks,
Mugdha Varadkar
Review Request 50791: AMBARI-18019 Referring component level identity is not working for ranger-atlas-plugin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50791/
---
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya,
Robert Levas, and Velmurugan Periasamy.
Bugs: AMBARI-18019
https://issues.apache.org/jira/browse/AMBARI-18019
Repository: ambari
Description
---
In-order to support AMBARI-17902 changes for ranger-atlas plugin, trying to
accommodate below code in common-services/ATLAS/0.7.0.2.5/kerberos.json.
{
"name": "/ATLAS/ATLAS_SERVER/atlas",
"principal": {
"configuration":
"ranger-atlas-audit/xasecure.audit.jaas.Client.option.principal"
},
"keytab": {
"configuration":
"ranger-atlas-audit/xasecure.audit.jaas.Client.option.keyTab"
}
}
However these configs are not being available at ranger-atlas-audit.xml
This occurs because the Kerberos Descriptors does not allow using the same
identity name more than once.
After AMBARI-17993 fix this is made possible by using reference tag.
Changes include:
1) updating kerberos.json
2) moving ranger related configs file from
/stacks/HDP/2.5/services/ATLAS/configuration to
/common-services/ATLAS/0.7.0.2.5/configuration as common service version
0.7.0.2.5 is maintained.
Diffs
-
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/ranger-atlas-audit.xml
PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/ranger-atlas-plugin-properties.xml
PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/ranger-atlas-policymgr-ssl.xml
PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/ranger-atlas-security.xml
PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
2be4b7d
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml
630d403
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
43c767d
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml
36677a1
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml
fd623cb
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-policymgr-ssl.xml
dcffb63
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml
ea0a026
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml
4ba59d5
Diff: https://reviews.apache.org/r/50791/diff/
Testing
---
Tested Atlas installation in secure mode with and without Ranger
Thanks,
Mugdha Varadkar
Re: Review Request 50645: Ambari upgrade to 2.4.0 adds several config properties that are not necessary and some are incorrect
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50645/#review144480 --- ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml (line 169) <https://reviews.apache.org/r/50645/#comment210496> If this is deleted, is there any other way to get the port Since this is marked as dependent on atlas.kafka.bootstrap.servers/tagsync-application-properties.xml Link: https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-application-properties.xml#L30-L45 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml (line 21) <https://reviews.apache.org/r/50645/#comment210497> This config file is a part of RANGER KMS service and doesn't require changes. - Mugdha Varadkar On Aug. 2, 2016, 12:20 a.m., Sumit Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50645/ > --- > > (Updated Aug. 2, 2016, 12:20 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jaimin > Jetly, and Mugdha Varadkar. > > > Bugs: AMBARI-17971 > https://issues.apache.org/jira/browse/AMBARI-17971 > > > Repository: ambari > > > Description > --- > > Ambari upgrade to 2.4.0 adds several config properties that are not necessary > and some are incorrect. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml > 108c7b4 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-log4j.xml > a071442 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-solrconfig.xml > 35e9f58 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py > 1a0e797 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 8006158 > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/atlas-solrconfig.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-atlas-application.properties.xml > e653651 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml > 0275358 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml > 5257549 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml > 74cdf63 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml > f0fc160 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 3967e3e > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > f0f6f41 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml > 50a997c > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml > f7823d2 > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml > b7cf4c5 > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml > 9592914 > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml > 5f0e944 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-site.xml > ab7d9cb > > ambari-server/src/main/resources/common-services/STORM/0.9.3/configuration/ranger-storm-plugin-properties.xml > 9ba58b5 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml > 7b55225 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-site.xml > 3f860e0 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml > adcf116 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > 1e65763 > > ambari-server/src/main/resources/stacks/HDP/
Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2
> On July 28, 2016, 4:16 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py, > > line 74 > > <https://reviews.apache.org/r/50565/diff/1/?file=1456532#file1456532line74> > > > > I don't think you need the `upgrade_type is not None` since you have an > > equality check right after it. Updated it latest patch > On July 28, 2016, 4:16 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py, > > line 66 > > <https://reviews.apache.org/r/50565/diff/1/?file=1456531#file1456531line66> > > > > I don't think you need the `upgrade_type is not None` since you have an > > equality check right after it. Updated it latest patch > On July 28, 2016, 4:16 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py, > > lines 67-68 > > <https://reviews.apache.org/r/50565/diff/1/?file=1456531#file1456531line67> > > > > I'd rather see a specific check in the stack feature stuff for this; > > it's not clear what combination of stack features affect this. Yes it is specific for stack 2.2 only - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50565/#review143950 --- On July 29, 2016, 12:16 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50565/ > --- > > (Updated July 29, 2016, 12:16 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Nate Cole, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17945 > https://issues.apache.org/jira/browse/AMBARI-17945 > > > Repository: ambari > > > Description > --- > > As part of changes done in this AMBARI-17840, following changes are required > to handle EU scenario : > > 1] need to change the owner/mode of stop script and > 2] create symbolic link if it does not exists. > > > This patch handles the following upgrade scenarios: > 1) ranger admin from 2.2.x to 2.2.y > 2) ranger usersync from 2.2.x to 2.3, 2.4 > 3) ranger kms from 2.3 to 2.3.x, 2.4, 2.5 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > c0534f3 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py > 5ce0617 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > cbdcc8c > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py > 55c0486 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 4888aa6 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml > 95310d5 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 6e7e272 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml > b368db3 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 9eb4a44 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml > e67b82c > > Diff: https://reviews.apache.org/r/50565/diff/ > > > Testing > --- > > Tested EU from > 2.2 to 2.2 > 2.2 to 2.4 > 2.4 to 2.5 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2
> On July 28, 2016, 8:10 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml, > > lines 659-665 > > <https://reviews.apache.org/r/50565/diff/1/?file=1456536#file1456536line659> > > > > I think you might be able to use the "modern" here: > > > if-type="ranger-site" if-key="http.enabled" if-value="false" /> Updated it latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50565/#review143990 ------- On July 29, 2016, 12:16 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50565/ > --- > > (Updated July 29, 2016, 12:16 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Nate Cole, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17945 > https://issues.apache.org/jira/browse/AMBARI-17945 > > > Repository: ambari > > > Description > --- > > As part of changes done in this AMBARI-17840, following changes are required > to handle EU scenario : > > 1] need to change the owner/mode of stop script and > 2] create symbolic link if it does not exists. > > > This patch handles the following upgrade scenarios: > 1) ranger admin from 2.2.x to 2.2.y > 2) ranger usersync from 2.2.x to 2.3, 2.4 > 3) ranger kms from 2.3 to 2.3.x, 2.4, 2.5 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > c0534f3 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py > 5ce0617 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > cbdcc8c > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py > 55c0486 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 4888aa6 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml > 95310d5 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 6e7e272 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml > b368db3 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 9eb4a44 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml > e67b82c > > Diff: https://reviews.apache.org/r/50565/diff/ > > > Testing > --- > > Tested EU from > 2.2 to 2.2 > 2.2 to 2.4 > 2.4 to 2.5 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50565/ --- (Updated July 29, 2016, 12:16 p.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth Gunturi, and Velmurugan Periasamy. Changes --- Address Jonathan's comments Bugs: AMBARI-17945 https://issues.apache.org/jira/browse/AMBARI-17945 Repository: ambari Description --- As part of changes done in this AMBARI-17840, following changes are required to handle EU scenario : 1] need to change the owner/mode of stop script and 2] create symbolic link if it does not exists. This patch handles the following upgrade scenarios: 1) ranger admin from 2.2.x to 2.2.y 2) ranger usersync from 2.2.x to 2.3, 2.4 3) ranger kms from 2.3 to 2.3.x, 2.4, 2.5 Diffs (updated) - ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py c0534f3 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py 5ce0617 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py cbdcc8c ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 55c0486 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 4888aa6 ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 95310d5 ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 6e7e272 ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml b368db3 ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 9eb4a44 ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml e67b82c Diff: https://reviews.apache.org/r/50565/diff/ Testing --- Tested EU from 2.2 to 2.2 2.2 to 2.4 2.4 to 2.5 Thanks, Mugdha Varadkar
Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger
kerberos OFF 4) External solr cloud on secure env (i.e. external solr cloud +kerberos env) - audit to solr ON - solr cloud ON - external Solr cloud ON - external solr kerberos OFF 5) External solr cloud on secure env (i.e. external solr cloud +kerberos env) - audit to solr ON - solr cloud ON - external Solr cloud ON - external solr kerberos ON - Also verified upgrade from 2.4 to 2.5 in simple as well as kerberos Thanks, Mugdha Varadkar
Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger
> On July 27, 2016, 4:15 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json, > > line 189 > > <https://reviews.apache.org/r/50445/diff/1/?file=1452649#file1452649line189> > > > > How did this typo not cause problems in the past? This typo is for branch-2.4 and trunk. The commit link: https://github.com/apache/ambari/commit/592609bb077e157f094da7c968ca629dc5095ae5 - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50445/#review143669 --- On July 26, 2016, 2:49 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50445/ > --- > > (Updated July 26, 2016, 2:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Robert Levas, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17902 > https://issues.apache.org/jira/browse/AMBARI-17902 > > > Repository: ambari > > > Description > --- > > Ranger Service needs to support the following two scenarios in case when > audit to solr is enabled and solrCloud is used as destination. > > External Solr > If Audit to Solr is Enabled and Solr Cloud == true and Kerberos is Enabled > If is_external_solr == true > If is_external_solr_kerberized == true >Then recommend ranger.is.solr.kerberised as true. > > > Ambari Internal Solr > If Audit to Solr is Enabled and Solr Cloud == true > If is_external_solr == false and Kerberos is Enabled >Then directly recommend ranger.is.solr.kerberised as true. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json > 3d6e25c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 3ec4b53 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 1670d69 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jaas_conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jass_conf.j2 > a456688 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml > eacf541 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml > 2cf3539 > ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json > ffebb11 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json > e65c9b2 > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-audit.xml > 1c869ed > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json > f9fa30d > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > bfdb3d3 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > a1b93e3 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 96b1400 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > b2cc1c4 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > 86e0964 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > 2099958 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml > ac22729 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/configuration/ranger-hbase-audit.xml > cc9f0d2 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json > ada02ad > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/ranger-hdfs-audit.xml > 0a04953 > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-audit.xml > 671c08e > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json > f9a0caf > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/configuration/ranger-kafka-audit.xml > 6aca7e7 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos
Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger
> On July 27, 2016, 4:12 a.m., Jayush Luniya wrote: > > Is Kerberized External Solr + Unkerberized Cluster a valid scenario? AFAIK, even if solr is kerberized all scripts will make calls using simple method. - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50445/#review143667 --- On July 26, 2016, 2:49 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50445/ > --- > > (Updated July 26, 2016, 2:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Robert Levas, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17902 > https://issues.apache.org/jira/browse/AMBARI-17902 > > > Repository: ambari > > > Description > --- > > Ranger Service needs to support the following two scenarios in case when > audit to solr is enabled and solrCloud is used as destination. > > External Solr > If Audit to Solr is Enabled and Solr Cloud == true and Kerberos is Enabled > If is_external_solr == true > If is_external_solr_kerberized == true >Then recommend ranger.is.solr.kerberised as true. > > > Ambari Internal Solr > If Audit to Solr is Enabled and Solr Cloud == true > If is_external_solr == false and Kerberos is Enabled >Then directly recommend ranger.is.solr.kerberised as true. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json > 3d6e25c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 3ec4b53 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 1670d69 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jaas_conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jass_conf.j2 > a456688 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml > eacf541 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml > 2cf3539 > ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json > ffebb11 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json > e65c9b2 > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-audit.xml > 1c869ed > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json > f9fa30d > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > bfdb3d3 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > a1b93e3 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 96b1400 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > b2cc1c4 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > 86e0964 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > 2099958 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml > ac22729 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/configuration/ranger-hbase-audit.xml > cc9f0d2 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json > ada02ad > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/ranger-hdfs-audit.xml > 0a04953 > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-audit.xml > 671c08e > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json > f9a0caf > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/configuration/ranger-kafka-audit.xml > 6aca7e7 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KNOX/configuration/ranger-knox-audit.xml > bdd1994 > ambari-server/src/main/resources/stacks/HDP/2.5/services/KNOX/kerberos.json > PRE-
Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger
> On July 26, 2016, 6:07 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml, > > line 330 > > <https://reviews.apache.org/r/50445/diff/1/?file=1452654#file1452654line330> > > > > I thought this property will be completely removed. Why do we need this > > property anymore? This property is required as it is internally used in ranger code base. - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50445/#review143568 ------- On July 26, 2016, 2:49 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50445/ > --- > > (Updated July 26, 2016, 2:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Robert Levas, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17902 > https://issues.apache.org/jira/browse/AMBARI-17902 > > > Repository: ambari > > > Description > --- > > Ranger Service needs to support the following two scenarios in case when > audit to solr is enabled and solrCloud is used as destination. > > External Solr > If Audit to Solr is Enabled and Solr Cloud == true and Kerberos is Enabled > If is_external_solr == true > If is_external_solr_kerberized == true >Then recommend ranger.is.solr.kerberised as true. > > > Ambari Internal Solr > If Audit to Solr is Enabled and Solr Cloud == true > If is_external_solr == false and Kerberos is Enabled >Then directly recommend ranger.is.solr.kerberised as true. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json > 3d6e25c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 3ec4b53 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 1670d69 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jaas_conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jass_conf.j2 > a456688 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml > eacf541 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml > 2cf3539 > ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json > ffebb11 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json > e65c9b2 > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-audit.xml > 1c869ed > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json > f9fa30d > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > bfdb3d3 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > a1b93e3 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 96b1400 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > b2cc1c4 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > 86e0964 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > 2099958 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml > ac22729 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/configuration/ranger-hbase-audit.xml > cc9f0d2 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json > ada02ad > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/ranger-hdfs-audit.xml > 0a04953 > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-audit.xml > 671c08e > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json > f9a0caf > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/configuration/ranger-kafka-audit.xml > 6aca7e7 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/ke
Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger
te rather than make > > the properties here. > > > > Is it expected that a user might change them? Ranger Code doesn't support jaas.conf file. That is why can't use jinja2 template. > On July 26, 2016, 3:35 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json, > > lines 61-65 > > <https://reviews.apache.org/r/50445/diff/1/?file=1452659#file1452659line61> > > > > It seems like these should be set in a Jinja2 template rather than make > > the properties here. > > > > Is it expected that a user might change them? Ranger Code doesn't support jaas.conf file. That is why can't use jinja2 template. > On July 26, 2016, 3:35 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json, > > lines 18-22 > > <https://reviews.apache.org/r/50445/diff/1/?file=1452656#file1452656line18> > > > > it seems like these should be set in a Jinja2 template rather than make > > the properties here. > > > > Is it expected that a user might change them? Ranger Code doesn't support jaas.conf file. That is why can't use jinja2 template. > On July 26, 2016, 3:35 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json, > > line 1 > > <https://reviews.apache.org/r/50445/diff/1/?file=1452670#file1452670line1> > > > > Is this change specific to HDP 2.5 or could some other stack benefit > > from the changes. For example PHD X.Y? > > > > If so, then maybe a new common service version of HDFS should be > > created and referenced from HDP/2.5/HDFS. Till now this is specific to HDP only. @Jayush can you please take the decision on the same. - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50445/#review143535 --- On July 26, 2016, 2:49 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50445/ > --- > > (Updated July 26, 2016, 2:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Robert Levas, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17902 > https://issues.apache.org/jira/browse/AMBARI-17902 > > > Repository: ambari > > > Description > --- > > Ranger Service needs to support the following two scenarios in case when > audit to solr is enabled and solrCloud is used as destination. > > External Solr > If Audit to Solr is Enabled and Solr Cloud == true and Kerberos is Enabled > If is_external_solr == true > If is_external_solr_kerberized == true >Then recommend ranger.is.solr.kerberised as true. > > > Ambari Internal Solr > If Audit to Solr is Enabled and Solr Cloud == true > If is_external_solr == false and Kerberos is Enabled >Then directly recommend ranger.is.solr.kerberised as true. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json > 3d6e25c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 3ec4b53 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 1670d69 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jaas_conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jass_conf.j2 > a456688 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml > eacf541 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml > 2cf3539 > ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json > ffebb11 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json > e65c9b2 > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-audit.xml > 1c869ed > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json > f9fa30d > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > bfdb3d3 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrollin
Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger
(i.e. external solr cloud +kerberos env) - audit to solr ON - solr cloud ON - external Solr cloud ON - external solr kerberos OFF 5) External solr cloud on secure env (i.e. external solr cloud +kerberos env) - audit to solr ON - solr cloud ON - external Solr cloud ON - external solr kerberos ON - Also verified upgrade from 2.4 to 2.5 in simple as well as kerberos Thanks, Mugdha Varadkar
Re: Review Request 50337: AMBARI-17854 Config changes for Ranger HA in kerberos env
> On July 22, 2016, 5:54 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml, > > line 72 > > <https://reviews.apache.org/r/50337/diff/3/?file=1451220#file1451220line72> > > > > What should happen to existing clusters with Ranger that are Kerberized? This is new property in stack 2.5 - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50337/#review143245 --- On July 22, 2016, 2:52 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50337/ > --- > > (Updated July 22, 2016, 2:52 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Robert Levas, > Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17854 > https://issues.apache.org/jira/browse/AMBARI-17854 > > > Repository: ambari > > > Description > --- > > Setting default value for ranger.spnego.kerberos.principal as * > Use only /spengo keytab under > ranger-admin-site.xml/ranger.spnego.kerberos.keytab > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml > 477df7a > ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json > 94c681d > > Diff: https://reviews.apache.org/r/50337/diff/ > > > Testing > --- > > Tested Ranger installation in kerberos env > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 50337: AMBARI-17854 Config changes for Ranger HA in kerberos env
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50337/ --- (Updated July 22, 2016, 2:52 p.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Robert Levas, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy. Changes --- Rolling back to first version of diff Bugs: AMBARI-17854 https://issues.apache.org/jira/browse/AMBARI-17854 Repository: ambari Description --- Setting default value for ranger.spnego.kerberos.principal as * Use only /spengo keytab under ranger-admin-site.xml/ranger.spnego.kerberos.keytab Diffs (updated) - ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml 477df7a ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 94c681d Diff: https://reviews.apache.org/r/50337/diff/ Testing --- Tested Ranger installation in kerberos env Thanks, Mugdha Varadkar
Re: Review Request 50337: AMBARI-17854 Config changes for Ranger HA in kerberos env
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50337/ --- (Updated July 22, 2016, 2:18 p.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Robert Levas, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-17854 https://issues.apache.org/jira/browse/AMBARI-17854 Repository: ambari Description --- Setting default value for ranger.spnego.kerberos.principal as * Use only /spengo keytab under ranger-admin-site.xml/ranger.spnego.kerberos.keytab Diffs (updated) - ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 3ec4b53 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 0bc330f ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jaas_conf.j2 PRE-CREATION ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jass_conf.j2 a456688 ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml 477df7a ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 94c681d ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 2345b8e Diff: https://reviews.apache.org/r/50337/diff/ Testing --- Tested Ranger installation in kerberos env Thanks, Mugdha Varadkar
Re: Review Request 50337: AMBARI-17854 Config changes for Ranger HA in kerberos env
> On July 22, 2016, 1:07 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml,
> > line 72
> > <https://reviews.apache.org/r/50337/diff/1/?file=1451197#file1451197line72>
> >
> > Why is this *?
> >
> > I assume it will be replaced when Kerberos is enabled to some more
> > approproate value. However if * is left, it will break the principal
> > creation process since it is in a valid principal name.
@Robert, We have removed,
"principal": {
"configuration":
"ranger-admin-site/ranger.spnego.kerberos.principal"
}
from kerberos.json. This property will not be shown under Admin >> Kerberos >>
Advanced Tab.
Just want spnego keytab value in the ranger.spnego.kerberos.keytab
- Mugdha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50337/#review143221
---
On July 22, 2016, 1:31 p.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50337/
> ---
>
> (Updated July 22, 2016, 1:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Robert Levas,
> Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-17854
> https://issues.apache.org/jira/browse/AMBARI-17854
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Setting default value for ranger.spnego.kerberos.principal as *
> Use only /spengo keytab under
> ranger-admin-site.xml/ranger.spnego.kerberos.keytab
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
> 477df7a
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json
> 94c681d
>
> Diff: https://reviews.apache.org/r/50337/diff/
>
>
> Testing
> ---
>
> Tested Ranger installation in kerberos env
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Review Request 50337: AMBARI-17854 Config changes for Ranger HA in kerberos env
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50337/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Robert Levas, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-17854 https://issues.apache.org/jira/browse/AMBARI-17854 Repository: ambari Description --- Setting default value for ranger.spnego.kerberos.principal as * Use only /spengo keytab under ranger-admin-site.xml/ranger.spnego.kerberos.keytab Diffs - ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml 477df7a ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 94c681d Diff: https://reviews.apache.org/r/50337/diff/ Testing --- Tested Ranger installation in kerberos env Thanks, Mugdha Varadkar
Review Request 50294: AMBARI-17833 EU fails during restart of Ranger Admin at setup_ranger_audit_solr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50294/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-17833 https://issues.apache.org/jira/browse/AMBARI-17833 Repository: ambari Description --- Handling upgrade scenario for Ranger Admin from stack 2.4 to 2.5 with solrCloud enable. Diffs - ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py f235ba8 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py d3a6acb ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 49527dc ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py dcd6f73 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py e7ae8ba ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ea79ae1 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 7079626 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 5059595 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 21a70e6 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py fefc659 ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 53e26a6 Diff: https://reviews.apache.org/r/50294/diff/ Testing --- Tested Ranger upgrade from stack 2.4 to 2.5 with solrcloud enable in simple as well as secure env. Running tests for stack:2.5 service:RANGER test_configure_default (test_ranger_admin.TestRangerAdmin) ok test_configure_secured (test_ranger_admin.TestRangerAdmin) ok test_start_default (test_ranger_admin.TestRangerAdmin) ... ok test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok test_stop_default (test_ranger_admin.TestRangerAdmin) ok test_configure_default (test_ranger_usersync.TestRangerUsersync) ok test_configure_secured (test_ranger_usersync.TestRangerUsersync) ok test_start_default (test_ranger_usersync.TestRangerUsersync) ok test_stop_default (test_ranger_usersync.TestRangerUsersync) ok test_configure_default (test_ranger_tagsync.TestRangerTagsync) ok test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ok test_start_default (test_ranger_tagsync.TestRangerTagsync) ok test_stop_default (test_ranger_tagsync.TestRangerTagsync) ok -- Ran 13 tests in 0.380s OK Thanks, Mugdha Varadkar
Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50287/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-17830 https://issues.apache.org/jira/browse/AMBARI-17830 Repository: ambari Description --- Caused by: org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: Stack Advisor reported an error: KeyError: 'atlas.server.https.port' Diffs - ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 19753e5 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 5e380d8 Diff: https://reviews.apache.org/r/50287/diff/ Testing --- Tested Atlas installation Thanks, Mugdha Varadkar
Re: Review Request 50121: AMBARI-17763 Populating Ranger Tagsync principal/keytab using stack advisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50121/ --- (Updated July 18, 2016, 7:43 p.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, Robert Levas, Sumit Mohanty, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-17763 https://issues.apache.org/jira/browse/AMBARI-17763 Repository: ambari Description --- atlas.jaas.KafkaClient.option.keyTab and atlas.jaas.KafkaClient.option.principal properties are needed in tagsync-application-properties.xml when kerberos is enabled. These properties should have Ranger Tagsync principal/keytab. To achieve this changing the implementation from macro to stack advisor Diffs (updated) - ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 564c57b ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py db3614f Diff: https://reviews.apache.org/r/50121/diff/ Testing --- Tested Ranger installation along with Atlas. Thanks, Mugdha Varadkar
Review Request 50132: AMBARI-17767 Ranger UserSync stopped after EU from 2.2.9 to 2.4.2 with SSLHandshakeException
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50132/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-17767 https://issues.apache.org/jira/browse/AMBARI-17767 Repository: ambari Description --- Steps to reproduce: - Deploy 2.2.9 cluster with Ambari 2.2.1.1 - Upgrade Ambari to 2.4.0.0 - Perform Express Upgrade (EU) to 2.4.2.0 and let it complete - Observed that after EU, Ranger Usersync reports as down Analysis: For HDP 2.2 usersync process was started with root user and from HDP-2.3 onwards we support usersync process start for non-root user. Usersync process didn't started due /var/log/ranger/usersync/auth.log: Permission denied, which still had root permission after upgrade. Solution: Need to give recursive file-level ownership for log path /var/log/ranger/usersync Diffs - ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 7079626 ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 7b6e782 Diff: https://reviews.apache.org/r/50132/diff/ Testing --- Tested EU from 2.2.9 to 2.4.2.0 Running tests for stack:2.5 service:RANGER test_configure_default (test_ranger_admin.TestRangerAdmin) ... ok test_configure_secured (test_ranger_admin.TestRangerAdmin) ... ok test_start_default (test_ranger_admin.TestRangerAdmin) ... ok test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok test_stop_default (test_ranger_admin.TestRangerAdmin) ... ok test_configure_default (test_ranger_usersync.TestRangerUsersync) ... ok test_configure_secured (test_ranger_usersync.TestRangerUsersync) ... ok test_start_default (test_ranger_usersync.TestRangerUsersync) ... ok test_stop_default (test_ranger_usersync.TestRangerUsersync) ... ok test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... ok test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok test_start_default (test_ranger_tagsync.TestRangerTagsync) ... ok test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... ok -- Ran 13 tests in 0.408s OK Thanks, Mugdha Varadkar
Review Request 50121: AMBARI-17763 Populating Ranger Tagsync principal/keytab using stack advisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50121/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, Robert Levas, Sumit Mohanty, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-17763 https://issues.apache.org/jira/browse/AMBARI-17763 Repository: ambari Description --- atlas.jaas.KafkaClient.option.keyTab and atlas.jaas.KafkaClient.option.principal properties are needed in tagsync-application-properties.xml when kerberos is enabled. These properties should have Ranger Tagsync principal/keytab. To achieve this changing the implementation from macro to stack advisor Diffs - ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 91a0032 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py b84910a Diff: https://reviews.apache.org/r/50121/diff/ Testing --- Tested Ranger installation along with Atlas. Thanks, Mugdha Varadkar
Re: Review Request 50030: AMBARI-17688 Ranger stack changes in Ambari to support secure Solr
> On July 14, 2016, 6:30 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, > > line 630 > > <https://reviews.apache.org/r/50030/diff/1/?file=1443856#file1443856line630> > > > > Whynot use `hive_server2_keytab` from line 336? > > > > ``` > > hive_server2_keytab = > > config['configurations']['hive-site']['hive.server2.authentication.kerberos.keytab'] > > ``` hive_server2_keytab variable seems to be used in python code under appropriate if "security_enabled" conditions. However in our case the variable is to be consumed in xml, which does not have support for if. And it will break with configuration not available error in case of simple mode. That is the reason i used a new variable. Do you have a better approach? Maybe i can add an "if security_enabled:" condition for the declaration of hive_server2_keytab variable, but not sure if it will break something. > On July 14, 2016, 6:30 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py, > > line 191 > > <https://reviews.apache.org/r/50030/diff/1/?file=1443855#file1443855line191> > > > > `master_keytab_path` is not be set/created if `securiry_enabled` is > > `false`. This may cause an issue down the road if some other variable > > needs it... For Example: > > > > ``` > > ranger_hbase_keytab = master_keytab_path > > ``` > > > > Note: the above example will only exeucte if `security_enabled` is > > `true`; but this is still a possible issue. Please see my comment for hive_server2_keytab. Same applies here also. > On July 14, 2016, 6:30 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py, > > line 240 > > <https://reviews.apache.org/r/50030/diff/1/?file=1443862#file1443862line240> > > > > please verify the indent on this line, it appears to be a character off. Updated in latest patch > On July 14, 2016, 6:30 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py, > > line 1504 > > <https://reviews.apache.org/r/50030/diff/1/?file=1443864#file1443864line1504> > > > > The existance of KERBEROS in the services list does not indicate > > whether Kerberos is enabled or not. Use `cluster-env/security_enabled`, > > which used by the `isSecurityEnabled` - see > > `stacks.stack_advisor.DefaultStackAdvisor#isSecurityEnabled` Updated in latest patch > On July 14, 2016, 6:30 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, > > lines 1629-1632 > > <https://reviews.apache.org/r/50030/diff/1/?file=1443874#file1443874line1629> > > > > The existance or non-existance of the KERBEROS service should not be > > used to determine if Kerberos is enabled. Use > > `stacks.stack_advisor.DefaultStackAdvisor#isSecurityEnabled` instead. Updated in latest patch - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50030/#review142261 --- On July 15, 2016, 8:43 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50030/ > --- > > (Updated July 15, 2016, 8:43 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Jayush Luniya, Robert Levas, Srimanth Gunturi, and Velmurugan > Periasamy. > > > Bugs: AMBARI-17688 > https://issues.apache.org/jira/browse/AMBARI-17688 > > > Repository: ambari > > > Description > --- > > Below properties should be introduced to Ranger admin and plugins to support > secure Solr. Also recommend for plugin in any of the below property chnages > on Ranger Admin: > > xasecure.audit.jaas.Client.loginModuleName=com.sun.security.auth.module.Krb5LoginModule > xasecure.audit.jaas.Client.loginModuleControlFlag=required > xasecure.audit.jaas.Client.option.useKeyTab=true > xasecure.audit.jaas.Client.option.storeKey=false > xasecure.audit.jaas.Client.option.serviceName=solr > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_lin
Re: Review Request 50030: AMBARI-17688 Ranger stack changes in Ambari to support secure Solr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50030/ --- (Updated July 15, 2016, 8:43 a.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, Jayush Luniya, Robert Levas, Srimanth Gunturi, and Velmurugan Periasamy. Changes --- Handle Robert Levas comments for stack advisor changes Bugs: AMBARI-17688 https://issues.apache.org/jira/browse/AMBARI-17688 Repository: ambari Description --- Below properties should be introduced to Ranger admin and plugins to support secure Solr. Also recommend for plugin in any of the below property chnages on Ranger Admin: xasecure.audit.jaas.Client.loginModuleName=com.sun.security.auth.module.Krb5LoginModule xasecure.audit.jaas.Client.loginModuleControlFlag=required xasecure.audit.jaas.Client.option.useKeyTab=true xasecure.audit.jaas.Client.option.storeKey=false xasecure.audit.jaas.Client.option.serviceName=solr Diffs (updated) - ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 145c216 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6bb2cbc ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py fad4b9b ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 529ac8c ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml 1b2b5e0 ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml 341cff7 ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json 3f50774 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py dfcad32 ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py e570a5b7 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 2a2a3a3 ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml efeea5f ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/configuration/ranger-hbase-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/ranger-hdfs-audit.xml 019602a ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/configuration/ranger-kafka-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.5/services/KNOX/configuration/ranger-knox-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml 02b7565 ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/ranger-yarn-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 5fccb2a ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 86bf14d ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py a6baeea ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json 67b00a1 ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 9911e10 ambari-web/app/data/HDP2/site_properties.js 23fbf5e ambari-web/app/models/stack_service.js c63df3d Diff: https://reviews.apache.org/r/50030/diff/ Testing --- Tested Ranger and Ranger Plugins Installation with Logsearch solr on secure cluster. Thanks, Mugdha Varadkar
Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade
> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > I'm curious if you can make this simply by only using the > > `commandParams/version` property when calculating what to do. Here's an > > example of the various values during normal commands, upgrades, and > > downgrades. `version` seems to always be what you want, no? > > > > ``` > > NORMAL COMMANDS > > hostLevelParams > > stack_name = HDP > > stack_version = 2.3 > > current_version = 2.3.4.0-1234 > > > > commandParams > > version = 2.3.4.0-1234 > > > > > > UPGRADE > > hostLevelParams > > stack_name = HDP > > stack_version = 2.3 > > current_version = 2.3.4.0-1234 > > > > commandParams > > original_stack = 2.3 > > target_stack = 2.5 > > upgrade_direction = UPGRADE > > version = 2.5.0.0- > > > > > > DOWNGRADE > > hostLevelParams > > stack_name = HDP > > stack_version = 2.5 > > current_version = 2.3.4.0-1234 > > > > commandParams > > original_stack = 2.3 > > target_stack = 2.5 > > upgrade_direction = DOWNGRADE > > version = 2.3.4.0-1234 > > downgrade_from_version = 2.5.0.0- > > ``` > > Mugdha Varadkar wrote: > Thanks Jonathan Hurley. Actually this was done by taking reference from > similar code from > Ambari.(https://github.com/apache/ambari/commit/63f8d74f806aa55fcbb4e51b2c84a3fd0146c062#diff-a9a4cbc8111690ebc76b1e83491d2dba) > > @Jayush Luniya, can we use version in NORMAL COMMANDS/UPGRADE/DOWNGRADE > scenarios? > > Jonathan Hurley wrote: > Actually, an even better option is this: > > ``` > # determine which version to use for checking stack features; version is > the most accurate but > # may not always be available (especially on first install of the cluster) > version_for_stack_feature_checks = version if not None else > stack_version_unformatted > ``` > > It's possible that on initial install, `version` isn't defined since we > haven't calculated it yet. So, the above defaults to the stack version in > that case. Now, version covers all 3 of your scenarios. Updated in latest patch > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py, > > line 60 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443235#file1443235line60> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. > > Mugdha Varadkar wrote: > @Jonathan Hurley, am directly using check_stack_feature here because even > if we pass version as ---> 2.3.4.0-1234, the code has format flag as true, > which calls format_stack_version() function which can be used for comparision. > "compare_versions(stack_version, min_version, format = True) < 0" > > Also I have added the check for "version" in this way "if > upgrade_direction == Direction.DOWNGRADE and version" > > Jonathan Hurley wrote: > My point was that the code was originally: > `foo and check_stack_feature(feature, foo) ` > > You don't need the "foo and" part since the check_stack_feature is > checking it for None anyway. Updated in latest patch > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py, > > line 61 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443236#file1443236line61> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. > > Mugdha Varadkar wrote: > Same as above Updated in latest patch > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py, > > line 58 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443238#file1443238line58> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. > > Mugdha Varadkar wrote: > Same as above Updated in latest patch > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, > > line 57 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443239#file1443239line57> > > > > No n
Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49987/ --- (Updated July 14, 2016, 2:23 p.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy. Changes --- Handle Jonathan Hurley comments Bugs: AMBARI-17687 https://issues.apache.org/jira/browse/AMBARI-17687 Repository: ambari Description --- Scenario: 1. install ranger with stack 2.4 and ambari-2.4.0 2. register the version of stack 2.5 3. perform the upgrade at the step where it where zookeepers are upgraded , just downgraded. 4. downgrade was successful 5. check ranger service status , it was down try to restart the ranger but ranger startup is failing Diffs (updated) - ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 0df8270 ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 145c216 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py f24bd83 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 63a1100 ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py f47eee4 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 7e0477f ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py fad4b9b ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py dfcad32 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 5941ca1 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 44a0446 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 4c122e9 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml bbd0fe4 Diff: https://reviews.apache.org/r/49987/diff/ Testing --- Test Ranger Downgrade from stack 2.5 to 2.4 Thanks, Mugdha Varadkar
Review Request 50030: AMBARI-17688 Ranger stack changes in Ambari to support secure Solr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50030/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, Jayush Luniya, Robert Levas, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-17688 https://issues.apache.org/jira/browse/AMBARI-17688 Repository: ambari Description --- Below properties should be introduced to Ranger admin and plugins to support secure Solr. Also recommend for plugin in any of the below property chnages on Ranger Admin: xasecure.audit.jaas.Client.loginModuleName=com.sun.security.auth.module.Krb5LoginModule xasecure.audit.jaas.Client.loginModuleControlFlag=required xasecure.audit.jaas.Client.option.useKeyTab=true xasecure.audit.jaas.Client.option.storeKey=false xasecure.audit.jaas.Client.option.serviceName=solr Diffs - ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 145c216 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 63a1100 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py fad4b9b ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 529ac8c ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml 1b2b5e0 ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml 341cff7 ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json 3f50774 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py dfcad32 ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py e570a5b7 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 2a2a3a3 ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml efeea5f ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/configuration/ranger-hbase-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/ranger-hdfs-audit.xml 019602a ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/configuration/ranger-kafka-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.5/services/KNOX/configuration/ranger-knox-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml 02b7565 ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/ranger-yarn-audit.xml d3f9143 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 0e455e9 ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 86bf14d ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json 67b00a1 ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 9911e10 ambari-web/app/data/HDP2/site_properties.js 23fbf5e ambari-web/app/models/stack_service.js c63df3d Diff: https://reviews.apache.org/r/50030/diff/ Testing --- Tested Ranger and Ranger Plugins Installation with Logsearch solr on secure cluster. Thanks, Mugdha Varadkar
Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade
> On July 13, 2016, 5:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml,
> > line 529
> > <https://reviews.apache.org/r/49987/diff/1/?file=1443244#file1443244line529>
> >
> > Why is this needed exactly? Does Ranger not support a downgrade from
> > HDP 2.5 to an earlier stack with the earlier configs?
upgrade to 2.5 needs config changes which are added inside
. During downgrade all the tasks under
gets executed. This leads to below failure:
Fail("Configuration parameter '" + self.name + "' was not found in
configurations dictionary!")
resource_management.core.exceptions.Fail: Configuration parameter
'audit_db_name' was not found in configurations dictionary!
To avoid that tag is used.
Refer:
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml#L606
> On July 13, 2016, 5:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py,
> > line 214
> > <https://reviews.apache.org/r/49987/diff/1/?file=1443234#file1443234line214>
> >
> > This is not needed since setting it to the same value under more
> > conditions.
stack_supports_ranger_kerberos feature have min support version as 2.5
In normal case with 2.5 below code logic will be
stack_version_unformatted = config['hostLevelParams']['stack_version'] >
2.5
stack_version_formatted = format_stack_version(stack_version_unformatted) >
2.5.0.0
stack_supports_ranger_kerberos = stack_version_formatted and
check_stack_feature(StackFeature.RANGER_KERBEROS_SUPPORT,
stack_version_formatted) ---> True
In Downgrade case from 2.5 to lower version
stack_version still points to 2.5, because of which
stack_supports_ranger_kerberos flag becomes true which should be false.
That is the reason "if upgrade_direction == Direction.DOWNGRADE and version:"
check was added. Using version = default("/commandParams/version", None) which
gives downgrade version.
> On July 13, 2016, 5:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py,
> > line 76
> > <https://reviews.apache.org/r/49987/diff/1/?file=1443236#file1443236line76>
> >
> > No need to change stack_supports_ranger_kerberos
It is needed to be changed. Please see above comment
- Mugdha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49987/#review142084
---
On July 13, 2016, 12:25 p.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49987/
> ---
>
> (Updated July 13, 2016, 12:25 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan
> Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-17687
> https://issues.apache.org/jira/browse/AMBARI-17687
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Scenario:
> 1. install ranger with stack 2.4 and ambari-2.4.0
> 2. register the version of stack 2.5
> 3. perform the upgrade
> at the step where it where zookeepers are upgraded , just downgraded.
> 4. downgrade was successful
> 5. check ranger service status , it was down
> try to restart the ranger but ranger startup is failing
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
> 8445214
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
> 6d304d4
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
> f24bd83
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
> 571eebd
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
> f47eee4
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
> 7e0477f
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
> fad4b9b
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
> dfcad32
>
> ambari-server/src/main/resources
Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade
> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > I'm curious if you can make this simply by only using the > > `commandParams/version` property when calculating what to do. Here's an > > example of the various values during normal commands, upgrades, and > > downgrades. `version` seems to always be what you want, no? > > > > ``` > > NORMAL COMMANDS > > hostLevelParams > > stack_name = HDP > > stack_version = 2.3 > > current_version = 2.3.4.0-1234 > > > > commandParams > > version = 2.3.4.0-1234 > > > > > > UPGRADE > > hostLevelParams > > stack_name = HDP > > stack_version = 2.3 > > current_version = 2.3.4.0-1234 > > > > commandParams > > original_stack = 2.3 > > target_stack = 2.5 > > upgrade_direction = UPGRADE > > version = 2.5.0.0- > > > > > > DOWNGRADE > > hostLevelParams > > stack_name = HDP > > stack_version = 2.5 > > current_version = 2.3.4.0-1234 > > > > commandParams > > original_stack = 2.3 > > target_stack = 2.5 > > upgrade_direction = DOWNGRADE > > version = 2.3.4.0-1234 > > downgrade_from_version = 2.5.0.0- > > ``` Thanks Jonathan Hurley. Actually this was done by taking reference from similar code from Ambari.(https://github.com/apache/ambari/commit/63f8d74f806aa55fcbb4e51b2c84a3fd0146c062#diff-a9a4cbc8111690ebc76b1e83491d2dba) @Jayush Luniya, can we use version in NORMAL COMMANDS/UPGRADE/DOWNGRADE scenarios? > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py, > > line 60 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443235#file1443235line60> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. @Jonathan Hurley, am directly using check_stack_feature here because even if we pass version as ---> 2.3.4.0-1234, the code has format flag as true, which calls format_stack_version() function which can be used for comparision. "compare_versions(stack_version, min_version, format = True) < 0" Also I have added the check for "version" in this way "if upgrade_direction == Direction.DOWNGRADE and version" > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py, > > line 61 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443236#file1443236line61> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. Same as above > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py, > > line 58 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443238#file1443238line58> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. Same as above > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, > > line 57 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443239#file1443239line57> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. Same as above > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py, > > line 47 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443241#file1443241line47> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. Same as above - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49987/#review142063 --- On July 13, 2016, 12:25 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49987/ > --- > > (Updated July 13, 2016, 12:25 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Perias
Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49987/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-17687 https://issues.apache.org/jira/browse/AMBARI-17687 Repository: ambari Description --- Scenario: 1. install ranger with stack 2.4 and ambari-2.4.0 2. register the version of stack 2.5 3. perform the upgrade at the step where it where zookeepers are upgraded , just downgraded. 4. downgrade was successful 5. check ranger service status , it was down try to restart the ranger but ranger startup is failing Diffs - ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 8445214 ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 6d304d4 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py f24bd83 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 571eebd ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py f47eee4 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 7e0477f ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py fad4b9b ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py dfcad32 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 2afb187 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 44a0446 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 4c122e9 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml bbd0fe4 Diff: https://reviews.apache.org/r/49987/diff/ Testing --- Test Ranger Downgrade from stack 2.5 to 2.4 Thanks, Mugdha Varadkar
Review Request 49754: AMBARI-17607 Add localjecks support in ambari for Ranger and Ranger KMS services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49754/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-17607 https://issues.apache.org/jira/browse/AMBARI-17607 Repository: ambari Description --- Currently, localjceks scheme is not supported for ranger installation through Ambari. Ambari should use localjecks scheme to store, retrieve and list its alias and values while installing ranger through Ambari. Diffs - ambari-common/src/main/python/resource_management/libraries/functions/constants.py 85e04e7 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py a85bde0 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 5e675e6 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 0a8c7d3 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py dfcad32 ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json ca000d1 ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 247b978 ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 7b6e782 ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 70e3d42 Diff: https://reviews.apache.org/r/49754/diff/ Testing --- Running tests for stack:2.5 service:RANGER test_configure_default (test_ranger_admin.TestRangerAdmin) ... ok test_configure_secured (test_ranger_admin.TestRangerAdmin) ... ok test_start_default (test_ranger_admin.TestRangerAdmin) ... ok test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok test_stop_default (test_ranger_admin.TestRangerAdmin) ... ok test_configure_default (test_ranger_usersync.TestRangerUsersync) ... ok test_configure_secured (test_ranger_usersync.TestRangerUsersync) ... ok test_start_default (test_ranger_usersync.TestRangerUsersync) ... ok test_stop_default (test_ranger_usersync.TestRangerUsersync) ... ok test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... ok test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok test_start_default (test_ranger_tagsync.TestRangerTagsync) ... ok test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... ok -- Ran 13 tests in 0.337s OK Running tests for stack:2.5 service:RANGER_KMS test_configure_default (test_kms_server.TestRangerKMS) ... 2016-07-07 15:24:50,074 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf ok test_configure_secured (test_kms_server.TestRangerKMS) ... 2016-07-07 15:24:50,096 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf ok test_start_default (test_kms_server.TestRangerKMS) ... 2016-07-07 15:24:50,119 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf 2016-07-07 15:24:50,123 - Rangeradmin: Skip ranger admin if it's down ! ok test_start_secured (test_kms_server.TestRangerKMS) ... 2016-07-07 15:24:50,152 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf 2016-07-07 15:24:50,157 - RangeradminV2: Skip ranger admin if it's down ! 2016-07-07 15:24:50,157 - KMS repository c1_kms exist ok test_stop_default (test_kms_server.TestRangerKMS) ... 2016-07-07 15:24:50,177 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf ok -- Ran 5 tests in 0.123s OK Thanks, Mugdha Varadkar
