Re: version number changes

[Willem Ferguson via subsurface]

Sent with Proton Mail secure email.

On Sunday, January 7th, 2024 at 02:13, Dirk Hohndel via subsurface 
 wrote:


> Hi everyone,
Ok on Android 11 on Samsung Galaxy A20
Kind regards,
willem

> 
> Those who track the CICD builds may have seen a recent change... our CICD 
> builds now have versions starting with 6.0.build-nr -- this change is the 
> visible part of a pretty fundamental redesign how our version numbers are 
> managed. I'd appreciate if people could try the various builds (I have tried 
> Mac and Ubuntu already, but for example can't really try Windows). The "check 
> for updates" is still broken, I'm hoping to fix that tomorrow. But the 
> version in the package and report internally in the About dialog should now 
> be consistent...
> 
> Thanks
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: version number changes

[Willem Ferguson via subsurface]

Should the new apk file be loaded from the Subsurface website or can one use 
the Android play store?
Kind regards,
Willem

Sent from Proton Mail mobile

 Original Message 
On 07 Jan 2024, 10:06, Eric Tanguy via subsurface wrote:

> Hi, the windows and android versions works fine and indicate the right 
> version but I still have to uninstall the previous version before installing 
> the new one on android.
> Thanks
> Eric
> Le 7 janv. 2024, à 01:14, Dirk Hohndel via subsurface 
>  a écrit:
>
>> Hi everyone,
>>
>> Those who track the CICD builds may have seen a recent change... our CICD 
>> builds now have versions starting with
>> 6.0.build
>> -nr -- this change is the visible part of a pretty fundamental redesign how 
>> our version numbers are managed. I'd appreciate if people could try the 
>> various builds (I have tried Mac and Ubuntu already, but for example can't 
>> really try Windows). The "check for updates" is still broken, I'm hoping to 
>> fix that tomorrow. But the version in the package and report internally in 
>> the About dialog should now be consistent...
>>
>> Thanks
>>
>> /D
>>
>> ---
>>
>> subsurface mailing list
>>
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Viewing images in snap version of Subsurface

[Willem Ferguson via subsurface]

After installing the Subsurface snap image I cannot view any of the media 
associated with my dive log (photos/video). The thumbnails are shown in the 
dive log, but selecting them either on the profile or in the media tab does not 
start a viewer . The double-click is ignored. If I build Subsurface from source 
the viewing works perfectly, so I assume some snap variable needs to be set to 
point at the appropriate viewing code. I have not found anything useful while 
scanning the Internet. Does anyone have a suggestion?
Kind regards,
willem___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

building Qtwebkit

[Willem Ferguson via subsurface]

I am setting up my Ubuntu to build Subsurface from source. Looks like there was 
a large change with Qtwebkit for accessing the maps. I started with building 
webkit from source on github but it is pretty challenging for me. For instance 
the build uses cmake but a CMakeLists.txt file, normally required for building, 
is not discussed at all in the build instructions.
Is there a more simple way to get the subsurface maps unit to work?
Kind regards,
Willem.___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new laptop

[Willem Ferguson via subsurface]

Good morning,
I write to you because i've a problem with my new laptop when i try to put my 
mail and password to load/read in a cloud my dive.
I've tried to generate a new password, but the problem is the same.
Can you help me?
Have a new password isn't a problem!

thank you
kind regards
Mauro

Hi Mauro,
You do not give enough information to help you. Here are some questions.

After installing subsurface did you register with subsurface and received a pin 
via email?
Or did you register with subsurface using your previous laptop?
Is your problem a setup problem, having already used Subsurface beforehand?
Or is your problem in using Subsurface for the first time?
Do you already have a subsurface dive log with some dives on it?
Or have you not logged any dives to subsurface yet?
Did you save these dives onto the subsurface cloud?
Is you problem that you cannot access your existing cloud dive log containing 
some dives?
Or are you trying to create a cloud copy of your existing dive log?
More information would would make it easier to help you.

Kind regards,
Willem

On Friday, November 24th, 2023 at 01:16, Mauro Besana via subsurface 
 wrote:

> Good morning,
> I write to you because i've a problem with my new laptop when i try to put my 
> mail and password to load/read in a cloud my dive.
> I've tried to generate a new password, but the problem is the same.
> Can you help me?
> Have a new password isn't a problem!
>
> thank you
> kind regards
> Mauro___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Linux: Problems with Image files on external drive

[Willem Ferguson via subsurface]

My photographic images are on an external hard drive, labeled as 'TOSHIBA EXT. 
I cannot access the images from within subsurface.This coincidental with moving 
to a fresh newly-intalled Ubuntu on a new clean machine.

I use Ubuntu 23.10

PROBLEM 1:
--
Permissions for the external drive as follows:willemf@fergusn:/media$ ls -l 
willemf
total 4
drwxrwxrwx 1 willemf willemf 4096 Nov 19 16:45 'TOSHIBA EXT'

Obviously I work in the media directory located in the root directory and the 
first part of the path is /media/willemf/'TOSHIBA EXT'

The system location of one such image is:
willemf@fergusn:/media/willemf/TOSHIBA EXT/Fotos/Sodwana.2023 
Mei/darktable_exported
The relevant image in the above directory is:
$ ls White*
'Whitespotted butterflyfish Chaetodon kleinii.jpg'

The path and existence of the image is explicit.

The divelog reference of the above image is:


The reference in the divelog appears correct. Granted, the spaces in the 
reference cause complications but Linux can easily deal with that by using the 
' ' notation.

Subsurface does not recognise any of these references in the dive log and 
consequently shows an "Image not found" icon in the media panel of Subsurface. 
I have no idea how to address this issue.

The above issue possibly relates to:

PROBLEM 2:
--

Cannot set image directory in Subsurface GUI

[Screenshot from 2023-11-22 10-24-49.png]

When I try and set the directory with images, it does not se anything within 
the media directory. Consequently it is impossible to import images into 
Subsurface. The above media directory is the one in the root.

Could this be an installation issue on my side? I installed the snap from the 
Subsurface website and did not build it myself.

One last gripe. My installation of Subsurface does not show a launch screen and 
directly goes to the full GUI with all the dive information. Thus I do not know 
which version of Subsurface I work with. But the snap was installed 4 days ago. 
I cannot find the Subsurface log file.

Kind regards, Willem

Sent with [Proton Mail](https://proton.me/) secure email.___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Problems with access to dive log from two devices

[Willem Ferguson via subsurface]

When I do a manual sync from my Android device it does not reflect the
cloud dive log that I see on my Linux box. On Android phone, the last dive
trip is not reflected in the cloud dive log. When I load from cloud using
Linux, the log is complete including last dive trip. I did set the password
on both devices to reflect the same email address (used here) as well as
the same password. I would highly appreciate it if Dirk were prepared to
look at the transactions on the server to shed some light on the issue?
Kind regards and thank you for your time.
Willem
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Shearwater imports - phantom cylinders when additional gas mixes are configured (micha

[Willem Ferguson via subsurface]

I dive similar configurations, using a Petrel with Subsurface on Linux. Saving 
a dive using an app can be problematic because the app does not allow several 
items to be specified. A few pointers when using Linux. I assume the behavior 
on Mac is identical.
On the Shearwater the cylinders/gases are defined in a specific order using the 
System Setup panel. In the equipment tab of Subsurface I define my cylinders in 
the same order. I have never encountered the type of problem you describe. Try 
it out on either Linux or Mac. This will allow you to ascertain whether it is a 
user problem, an iPhone app problem or a general problem. I suspect an app 
problem. The app, as far as I can see, does not allow specification of 
individual cylinders. If cylinders are not explicitly defined beforehand, you 
have to trust the way that Shearwater defines the cylinders exported to the 
Subsurface app and this is not guaranteed to be 100% intelligible to the Dive 
log software. For that reason I save dives using Linux, keep master dive log on 
Linux, and then synchronize the dive log on the app. I hope this makes sense. 
Kind regards, willem.

Sent from Proton Mail mobile

 Original Message 
On 10 Nov 2023, 22:41, Hartley Horwitz via subsurface wrote:

>> -- Forwarded message --
>> From: micha 
>> To: subsurface@subsurface-divelog.org
>> Cc:
>> Bcc:
>> Date: Fri, 10 Nov 2023 08:29:05 +1000
>> Subject: Shearwater imports - phantom cylinders when additional gas mixes 
>> are configured
>> .snip
>>
>> At the moment I'm diving Sidemount again, and again having issues with
>> spurious cylinders due to additional gasses being defined (although
>> disabled) on my Shearwater computer. Recreationally I dive with 2
>> cylinders filled with the same gas mix (typically Air or EAN32), and
>> both cylinders have a transmitter. I leave my computer in "Tec" mode and
>> leave the common mixes I use during other dives disabled instead of
>> deleting them.
>
> [HH] I dive the same sidemount configuration, Shearwater Teric and Perdix AI 
> set in tech mode, Sidemount AI feature enabled (you didn't mention if that's 
> the case for you). I also dive with a 3rd cylinder (deco) without a 
> transmitter. I define 2 gases for dives with 3 cylinders, so 2 gases are 
> "ON", 1 gas is "ACTIVE".
>
> I do a gas switch if diving with 3 tanks near the end of the dive even with 
> no deco obligations
>
> Upon import, I see a slightly different issue. Firstly, it assumes that only 
> 1 of my two sidemount tanks has EAN32 (an example) and defaults the 2nd tank 
> to air. That takes a minor edit on the equipment tab on subsurface
>
> The gas switch event on Subsurface is switching tank 1 to tank 2 (my 2nd 
> sidemount tank). Using the desktop UI, I switch that to my 3rd deco tank.
>
> I do not get unexpected gas switches like you've described when only dive 2 
> tanks or choose not to switch to my deco bottle. I import my dives into 
> Subsurface using an iPhone. This leads me to guess that the difference 
> between your experience and mine is either the setup in your Shearwater, or 
> the difference in the app you use to download into Subsurface (android for 
> iOS).
>
>> ..snip..
>> I can manually fix the gas mix for Cylinders 1 & 2 using the UI. But
>> the only way to currently get rid of the phantom Cylinder 3 is by
>> manually editing the log files and deleting the initial gas change
>> event.
>>
>> Now, I see several simple approaches to allow the user to fix this using
>> the Subsurface UI:
>>
>> 1. Don't generate the initial "gaschange" event, which is wrong anyway.
>> (At this stage I'm not entirely sure if this is being sent by the dive
>> computer, or generated by Subsurface during the import process; still
>> investigating). Subsurface doesn't seem to need an initial "gaschange"
>> event to render a dive correctly.
>>
>> 
>> I also contacted Shearwater about adding gas status (on/off) to their
>> protocol, but did not receive a reply.
>>
>> Thanks,
>> - Micha.___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface-mobile support request / Lost Logs when synced to cloud

[Willem Ferguson via subsurface]

I am currently overseas but when I get back I will read the user manual 
carefully and see how some explicit text could be added if it does not exist 
alteady. This 'problem' is common enough so that Dirk does not need to repeat 
the full explanation every time. I will make contact contact in about a month's 
time.
Kind regards,
Willem

Sent from Proton Mail mobile

 Original Message 
On 15 Oct 2023, 18:53, Dirk Hohndel via subsurface wrote:

> The tone of your message makes me think that you are misunderstanding what is 
> happening. (a) the Google group requires a Google account. But it shouldn't 
> (and to the best of my knowledge doesn't) reject anyone who hasn't been 
> banned from other groups for excessive abusive behavior in the past. (b) the 
> developer mailing list that you tried sending an email to has been overrun 
> with subscription spam and now requires explicit approval from me to add 
> people - but I don't think that you want to be a developer from the way this 
> all sounds (c) your description of what happens is garbled and confusing. 
> Please try to explain in sequence what happened, how many devices / computers 
> were involved, etc (d) any data that was at some point saved to the cloud (so 
> that has successfully synced between two or more devices) is still there. You 
> just managed to confuse the algorithm with the sequence of actions which 
> resulted in it assuming that you wanted to replace old dives with new ones, 
> instead of adding new ones. I'll repeat what I have said in dozens of answers 
> that your search found already. This is an open source project - a hobby for 
> a bunch of people. Angry outbursts at the developers might work for a paid 
> product (newsflash, they usually don't), but when attacking someone who wants 
> to help you because it's something that they like to do, it generally tends 
> to have the opposite effect. If you would like help, I need two things (a) 
> your explicit permission to access your cloud data (because I never interact 
> with user dive data without such explicit permission) (b) a good descriptions 
> of which dives should be there (how many, what rough time frame are they 
> from) and the sequence of events that made everything disappear - because I 
> need to undo those events in the backend, and the more information I have on 
> what happened, the easier that process will be. Finally, as to your question 
> how to avoid this in the future - in about half of the cases the issues is 
> that on a PC you downloaded new dives before opening the cloud storage and 
> then ended up overwriting cloud storage. The other half are situation where 
> you made changes on two different devices without syncing first. There are a 
> couple of other scenarios, but they are very rare. The simple approach to 
> preventing this issue is to simply always sync with the cloud FIRST, before 
> making any changes (downloading new dives from a dive computer, editing 
> dives, etc). /D > On Oct 14, 2023, at 21:04, Callie K  wrote: > > Hello, > > 
> I am very upset. All my data was lost from your app tonight. > > I edited one 
> dive log, sync’d to the cloud, and it deleted four of them. Shortly there 
> after, I wasn’t sure what happened and I added another dive log and sync’d it 
> to the cloud again. This time I deleted all the remainder of my logs. There 
> were about 40 dive logs. > > There is no way I deleted my dove log 
> information, just no way. > > I googled this issue and saw numerous other 
> posts about this problem. I even went over to your Google groups, but it 
> would not allow me in, please explain how to access, that Google 
> sector/forum. I wasn’t able to find any way to add that as a group, nor 
> register. > > Please restore the data, your app deleted, hid, or 
> re-distributed to another area. > > Also, please explain what caused this 
> problem so as it can be avoided in the future. > > Thank you, > Callie > > > 
> Please describe your issue here and keep the attached logs. > > > > > 
> ___ subsurface mailing list 
> subsurface@subsurface-divelog.org 
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Feature request - min temp and max temp options to display in dive log listing

[Willem Ferguson via subsurface]

An attractive idea, Doug, but I suspect things are more complex. The water 
medium seldom has a single temperature with a single associated lag. As we dive 
through thermoclines the Dive computer is probably going through different lag 
periods dependent on the delta t between computer and water. Furthermore there 
are equipment limitations concerning the accuracy of temperature measurements 
by dive computers, depending on the thermal mass of the computer and a miriad 
of electronic characteristics of the equipment. Dive computers were just not 
made for accurate temperature measurements (depending on one's definition of 
'accurate'). For serious work, one would need a purpose built water temperature 
logger. Then one can define Max and Min temperature in a way it makes sense 
within the objectives of the work. Water temp is not an independent and 
universal variable. It reflects the complex interaction between environment and 
the water medium. To compare two water temperatures is therefore not a trivial 
issue. Kind regards, willem.

Sent from Proton Mail mobile

 Original Message 
On 14 Aug 2023, 22:21, Doug Junkins via subsurface wrote:

>> On Aug 14, 2023, at 11:58 AM, Robert Helling via subsurface 
>>  wrote:
>>
>> Matt,
>>
>>> On 14. Aug 2023, at 19:24, Matt Wilbur via subsurface 
>>>  wrote:
>>>
>>> I'm not sure this is a feasible request for mobile subsurface, but on mac I 
>>> frequently use subsurface, and I'm also doing surveys on every dive 
>>> for[reef.org](http://reef.org/)(I've done about 120 since may). We have to 
>>> report max and min temps in our surveys so they can hopefully correlate 
>>> temps with the critters and locations we find them in.
>>>
>>> Would it be possible to adjust the "Temp." displayed with the dives in the 
>>> dive log and the "Water Temp." in the info display to show a min and max 
>>> water temp? So I could just have my dive listing show me my min and max 
>>> temps so I don't have to mouse over the dive profile plot to read the max 
>>> temp on the dive?
>>>
>>> Whether this is doable or not, thank you SO MUCH for the fantastic open 
>>> source dive logging app. I thought I might take a crack at adding a max 
>>> temp field to display since the data is all in there - but lost my steam 
>>> with the info "Water temp." display possibly needing to be changed too.
>>
>> the problem with this is that the typical temperature sensors on dive 
>> computers are very slow. At the start of the dive, the dive computer 
>> probably is at the surface air temperature and only slowly (except for dives 
>> in mid winter freezing temperatures) cools down to the water temperature. 
>> Thus I would not expect that for the first few minutes of the dive, the 
>> recorded temperature is actually the ambient water temperature. So what you 
>> would be recording as the max temperature is probably much more related to 
>> the surface air temperature (which we log if the dive computer reports it).
>>
>> On the other hand, the dive temperature that is shown in the dive list (you 
>> realise you can change the fields that are displayed there and their order) 
>> is the minimum temperature.
>>
>> At some point, I tried plotting the temperature against depth (rather than 
>> against time). I was hoping to see things there like thermoclines but that 
>> did not work exactly for the reason of inertia of the temperature sensor.
>
> I was thinking about the lag issue as well. Maybe one way to do it is to cut 
> off the first 5-10 minutes of temperature samples before doing the Min/Max 
> calculation. It could even be a configuration option for how many minutes of 
> temperature samples to ignore in the calculation so people that really want 
> this info can customize it based on their own dive computer. Just my $0.02.
>
> -Doug___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Transifex translation PRs - and a question about the German translation

[Willem Ferguson via subsurface]

On Mon, 20 Feb 2023, 10:57 Robert Helling via subsurface, <
subsurface@subsurface-divelog.org> wrote:

> Hi Dirk,
>
> On 20. Feb 2023, at 00:34, Dirk Hohndel via subsurface <
> subsurface@subsurface-divelog.org> wrote:
>
> For those of you working on the German translations - I notice that
> someone started shifting from "Sie" to "Du"... I'd love to have a
> conversation about the preference amongst the German translators... I don't
> have an opinion (I never use software in German), but I want to make sure
> we are consistent.
>
>
> in those parts where I did German translations I tried to avoid the
> distinction using passive voice etc.
>
> When I did my first diving course in 1994, the instructor explained to us
> right at the start that divers address each other as „Du" (and I understand
> similar rules apply in the mountains above 1000m). So I would opt for
> Subsurface also addressing its users (if it cannot be avoided) by „Du“.
>
> Sehr geehrte Damen und Herren, ich verbleibe fürderhin mit den
> freundlichsten Grüßen.
>
> Hochachtungsvoll
> Dr. Robert Helling
> Oberrat
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Dear Subsurface builders,
In writing sections of the documentation I often found that I included to
many pronoun references to users (you, one). Many times the text can simply
be organized to a simple command mode "Select the top button", "when using
nitrox, select the second option". Recognising that 2nd person pronouns
cannot be eliminated all together, my feeling is that the use of second
person pronouns should be absolutely minimized. In the text that I wrote,
2nd person pronouns often just consumed more text space.
Kind regards, Willem.

>
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: please test: new beta Subsurface-mobile apps

[Willem Ferguson via subsurface]

It looks pretty good to me using Android V11.
Kind regards,
willem

On 2022/02/28 05:39, Dirk Hohndel via subsurface wrote:


On February 27, 2022 12:13:12 PM PST, Dirk Hohndel via subsurface 
 wrote:

Yea, that's my experience too. The font is bigger and blurrier, making it more
cluttered than before, especially on dives with more information in the
profile.


Thanks for the feedback. And I agree. What I have is definitely a hack and not 
the right way to do this.
Berthold and I are trying to figure out what the correct fix would be, but so 
far haven't quite gotten there, yet.


I think I found it.

New beta binaries are available in both beta channels. Ok my devices this looks 
very nice again

Please test

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
.




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Dive planner problems

[Willem Ferguson via subsurface]

On 2022/02/08 00:17, Michael Andreen wrote:

The problem seems to be what JB2Cool mentioned in the previous thread. You
have the planner deco pO2 set to 0.60 instead of 1.60. The available gases
shows both Bot. MOD and Deco switch at. The Bot. MOD uses the Bottom pO2 and
18m for 50% and 4m for 100% seems fine. The deco switch at uses the Deco pO2
and in your case it shows nonsense -3m for oxygen. I've recreated your plan
with Deco pO2 set to 0.60 and 1.60 and the 0.60 matches your values.

/Michael


Problem solved. As indicated previously, my finger trouble. Have no idea 
how the preference was set to pO2=0.6


Thank you, Michael.

wf



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface dive planning issues

[Willem Ferguson via subsurface]

Definitely not. It was ok until 5.05 as far as I am aware.

Thanks, Berthold.

wf

On 2022/02/07 12:02, Berthold Stoeger wrote:

Dear Willem,

On Montag, 7. Februar 2022 07:43:24 CET Willem Ferguson via subsurface wrote:


See attached image of a plan for a normoxic pSCR dive. There are
important problems, possibly bugs?

Recently, there have been massive changes of the profile and cylinder-model
code (as in nearly total rewrite). Since I don't use the planner, it is not
unlikely that I introduced bugs during that process.

Could you please check if the bugs exist older versions, say of one year ago?

Thank you,

Berthold





--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface mobile general question

[Willem Ferguson via subsurface]

On 2021/11/15 00:07, Robert Helling via subsurface wrote:

Hi Poltsi,

On 14. Nov 2021, at 22:44, Paul-Erik Törrönen via subsurface 
> wrote:


When CCR, you're mainly interested in the consumption of O2 as noted 
previously. The diluent is not really telling since it is mainly a 
function of your profile as you use diluent to equalize the pressure 
in the loop. A serrated profile (lot's of ups and down) == large 
volume of diluent used because of addition to loop when going down, 
then dumping it when ascending.


I can see that the amount of O2 used divided by total dive time could 
be of interest. But it’s definitely something else than SAC and thus 
should not be mixed with it. For example, in any statistics when you 
have both CCR and OC dives, it would make zero sense to combine the 
two. So even if we computed this number, it should not be displayed as 
SAC or stored as such. Let alone the number with an ambient pressure 
correction like the SAC makes zero sense for a CCR.




Of course this also happens to O2 also, but what would be interesting 
to see is how/when your consumption of O2 changes due to increased work.


I meant more the other way around: If you diluent also contains O2, 
you underestimate the O2 consumption if you only use the pressure drop 
in the O2 cylinder.


The O2 consumption under CCR is not a dive characteristic because the 
diver can bail out to OC. So O2-consumption would be a cylinder-level 
characteristic, associated with cylinder 0 ?? (i.e. the diluent cylinder 
because as far as I can remember the O2 cylinder does not explicitly 
exist in the Subsurface CCR dive log). In pSCR bailout is often part of 
the normal dive procedure during deco.




So here is a question I have: For a typical CCR dive, what is the 
ratio between used O2 and used diluent? I understand this depends on 
how often descend and how often you flush but what is a ballpark type 
figure?


As a ball park approximation, many CCR dives (up to 65m) are done using 
air as a diluent, supplemented with oxygen from the O2 cylinder to make 
up for oxygen consumed as well as for higher O2 levels during shallower 
deco.


Kind regards,

Willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Fwd: WebKit -> WebEngine

[Willem Ferguson via subsurface]

Good stuff Robert. Thank you. Kind regards, willem.

On Sun, 31 Oct 2021, 19:01 Lubomir I. Ivanov via subsurface, <
subsurface@subsurface-divelog.org> wrote:

> On Sun, 31 Oct 2021 at 17:12, Robert Helling  wrote:
> >
> > HI everybody,
> >
> > I wanted to report on my progress in replacing Subsurface’s use of
> WebKit by WebEngine. I had already done this in the part of the user
> manual, but as this transition was only fragmentary at the time the
> corresponding code was removed at a later point.
> >
> > So I reinserted it and also made quite some progress on the printing
> part. So much that I want to share it with you at this point. You can find
> it at
> >
> > https://github.com/atdotde/subsurface/tree/webengineagain
> >
> > I removed a lot of code originally contributed by Gehad ElRobey as a
> GSoC student in 2015 but what I have now appears to be a lot simpler to me.
> >
> > It still requires some cleaning up and there are a few things to fix.
> Specifically, at the moment, the print preview is broken and there is a
> mysterious empty page at the end of the print out. But I think the bulk of
> the work is done and it is time more eyes should have a look. I particular
> I would like to hear from Lubomir as he was the project’s mentor at the
> time IIRC.
> >
>
> hi Robert.
>
> thank you for working on this.
> it was discussed in the past that the WebEngine change has to happen
> eventually, but i think i recall blockers outside of the usage in
> printing and user manual - e.g. build process, distribution?
> could be wrong, not remembering correctly. if that is not longer the
> case, great...
>
> overall, if the printing "stack" port is one-to-one with the old code
> and we are not introducing user visible regressions this seems fine.
> if you send a PR broken into relevant commits i can try to find time
> for review, but likely only code review, without building and testing
> locally.
>
> lubomir
> --
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Android location recording gone?

[Willem Ferguson via subsurface]

On 2021/10/30 15:31, Jason Bramwell wrote:


This is quite a new change so that’s correct, this change is not yet 
reflected in the documentation, this will catch up at some point 
through (please remember that Subsurface is free of charge and is 
maintained by volunteers during their free time and they all have busy 
lives).


I am using an app called GPSRecorder on the iPhone, there may be 
something similar on Android. Be aware that this does not sync with 
Subsurface, you need to manually type the coordinates in (this is the 
way i’ve actually always done it).


Regards

Jason

In Android I use GPS Essentials. It is a fully-featured GPS tool that 
allows the recording of tracks and saving them to .GPX files. I save 
them on a SD card in the phone. Subsurface can read and integrate the 
.GPX data into the dive log.


Kind regards,

Willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Replacement GPS logging app for iPhone

[Willem Ferguson via subsurface]

In Android there are many similar programs. One of the more versatile is
GPS Essentials.
Kind regards,
Willem

On Mon, 18 Oct 2021, 15:52 Jason Bramwell via subsurface, <
subsurface@subsurface-divelog.org> wrote:

> I currently use the old no longer maintained Subsurface companion app for
> capturing my GPS position, this worked well for me and I didn’t really see
> any reason to switch my GPS logging to the newer Subsurface-mobile app. The
> old phone (this is the only thing I use it for) I use for capturing these
> GPS points is slowly dying and will need to be replaced at some point, the
> old app will not work on newer versions of iOS so I need to find an
> alternate solution.
>
> Subsurface-Mobile no longer supports GPS capture so that is no longer an
> option So I thought I’d tell others what app I have replaced it with (or am
> planning to use) as I’ve looked at quite a few and there has always been a
> catch or a problem with each one I’ve looked at before now.
>
> I’ve found an app today that seems to do exactly what I want, it captures
> GPS positions either as a one-time capture or an an automatic capture based
> on a time delay or distance between points. You can display the captured
> points either as a simple sequential list or visualise them on a map to
> pick the one you want.
>
> I’m hoping to try this for real alongside the old companion app) in the
> coming week but it looks like I now have something that’ll work for me.
>
> This is on iPhone, I don’t know if the same app is available on Android
> but if not this one then something similar will be out there. Perhaps
> Android users can reply with what they are using to save others the
> searching for something that isn’t junk.
>
> Regards
> Jason
>
>
>
> Sent from my iPhone___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Media option: Save dive data as subtitles.

[Willem Ferguson via subsurface]

I share your point of view because I am an old style underwater still
photographer. But every second diver has a Gopro these days and if any of
them use Subsurface the facility is probably useful. If I were a
videographer I would probably use this option.

On Fri, 24 Sep 2021, 17:47 Dirk Hohndel via subsurface, <
subsurface@subsurface-divelog.org> wrote:

>
>
> On Sep 24, 2021, at 5:08 AM, Willem Ferguson via subsurface <
> subsurface@subsurface-divelog.org> wrote:
>
> When right-clicking on a photo in the Subsurface Media tab on my desktop I
> just came across the option "Save dive data as subtitles". What does this
> do? I would like to include this in the user manual.
>
>
> Well, here's what the manual says today...
>
> *By right-clicking on a video and selecting the "Save dive data as
> subtitles" option, a subtitles*
> *file with the same name as the video but with an ".ass" extension is
> created that contains*
> *time dependent dive data (runtime, depth, temperature, NDL, TTS, surface
> GF) to be overlayed*
> *with the video. The VLC video player automatically finds this file upon
> playing the video*
> *and overlays the dive data. Alternatively, the ffmpeg video encoder can
> be used to create a*
> *new video file with the dive data encoded in the video stream. To do so
> run*
>
> *ffmpeg -v video.mp4 -vf "ass=video.ass" video_with_data.mp4*
>
> *from the command line. You need to have the libass library installed.*
>
>
>
> This is the classic example of a feature that one or two people wanted,
> one person implemented, and that no one uses or knows about.
> I'm tempted to make a bet whether this actually works - or whether this
> works on a platform different from the one the implementer uses...
>
> Well, this feature was added by Robert
>
> commit 52105e521720c87e64dbd2519be7bbe5dc243439
> Author: Robert C. Helling 
> Date:   Sun Apr 14 16:19:23 2019 +0200
>
> Write dive data as video subtitles
>
> This commit adds an entry to the dive media context
> menu which offers to write a subtitle file. This
> creates an .ass file for the selected videos.
>
> In an attempt to to clutter the screen too much, don't
> show irrelevant entries (zero temperature or
> NDL and show TTS only for dives with stops).
>
> VLC is able to show these subtitles directly, they
> can be integrated into the video file with ffmpeg.
>
> Signed-off-by: Robert C. Helling 
>
> So my guess is this works on macOS, this may work on Linux, this is
> unlikely to have ever been tested on Windows.
>
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Media option: Save dive data as subtitles.

[Willem Ferguson via subsurface]

When right-clicking on a photo in the Subsurface Media tab on my desktop 
I just came across the option "Save dive data as subtitles". What does 
this do? I would like to include this in the user manual.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Printing/Exporting statistics

[Willem Ferguson via subsurface]

On 2021/06/28 14:05, Robert Helling via subsurface wrote:

Hi,

a couple of days ago, I had the idea that it might be useful if the user could 
print the statistics plots or export those as images. But I could not figure 
out how to do that. The profile can be rendered as a QImage but the statistics 
uses GL functionality and I don’t understand to use those (except a simple 
screen shot). Am I missing something?

Best
Robert


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


I do that with screen capture. Easy, saves as .png file. Or do you have 
something else in mind?


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Subsurface-mobile on a Linux phone

[Willem Ferguson via subsurface]

With the advent of Linux mobile phones, all sorts of possibilities arise 
with Subsurface-mobile. Many of the I/O problems with Android are likely 
to disappear and a cleaner implementation is likely.


But this would probably require a separate build process. Would 
Subsurface-mobile install directly on a Linux phone? What dependencies 
would need to be met? Debian and Redhat are commonly implemented on 
these phones. Would this be a relative straight-forwards installation or 
would it require a whole new build process?


Kind regards,

Willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Latest builds

[Willem Ferguson via subsurface]

On 2021/02/18 19:43, Salvador Cuñat via subsurface wrote:


El jue., 18 feb. 2021 10:15, tormento via subsurface 
> escribió:


No recent Windows build found there.

Can you help me?

Thanks!


H.
I can see 4.9.10-477 built today.
May be it's not an installer, but just the executable file?

Best regards.
Salva.




Where should I look for the latest Android build?

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Willem Ferguson via subsurface]

On 2021/01/18 00:05, Dirk Hohndel wrote:
To me this flow is informative, relatively unobtrusive, and makes 
sense. Best of all, even if you miss the time window to press the 
button in the notification, you still can just open the context menu 
and trigger the undo (or redo) action.


Please, PLEASE test this and let me know how this works for you, if it 
is intuitive, if this should be changed in some way.
Of course the texts will be translated (and even the command in the 
button that's part of the notification will be translated).


As of this writing the new versions has just now been pushed for iOS, 
the Android one is still waiting for Google to review and push out - 
but lately that hasn't taken too long.


Thanks

/D


I tested this on a Galaxy A20 running Android 10. Deleted dives and 
edited dive contents, doing undo afterwards. Looks perfect to me. Huge 
improvement (that is, after I discovered the undo stack!, duh me.). LGTM.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Willem Ferguson via subsurface]

On 2021/01/18 11:13, Martin de Weger via subsurface wrote:
I had a quick look on the statistics. They look great. I found one 
weird thing:


When looking at the minimum depth per year, the minimum depth is shown 
in the column. When doing the same thing for maximum dept, the maximum 
depth isn’t shown in the table.


It is a question of having enough horizontal space in portrait mode 
(screen upright) to print all the text labels inside the bars. If I turn 
my phone to landscape (screen horizontal, not upright) then the text is 
shown. Maybe the default text size will have an effect.


Kind regards,

willem.


--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Subsurface User GUI access to read-only cloud git repository

[Willem Ferguson via subsurface]

On 2021/01/17 18:38, Dirk Hohndel wrote:

Willem,

As the person who looks at user repos most often, let me tell you that 
they are DECIDEDLY not linear. And that in 90+% of the cases it is 
merges that are causing the issues. And undoing a merge the wrong way 
can make the whole situation far worse. And we know from experience 
that nothing is ever the users’ fault. So giving them a tool to REALLY 
mess things up will be seen as “Subsurface sucks”. Not as “Subsurface 
is amazing, it gave me this powerful tool, but I didn’t understand 
enough about it to use it and made things worse”


git is powerful and complicated. As you have noticed yourself in your 
pull requests. Its behavior is not at all intuitive to someone who is 
used to linear or hierarchical systems.
You may remember that we briefly played with exactly this idea of 
stepping through the git hierarchy before settling on the current undo 
implementation - and the reason we did that is because the moment we 
encourage people to mess with the git repo they WILL permanently lose 
data.


I’d much rather get the occasional requests to undo things in the 
backend (currently I average fewer than one a week - most likely 
because a lot of people aren’t diving). But even if it is one a day, 
that’s still far less aggravating than having to tell people “sorry, 
you messed up the data”.


We have a full undo system. Your earlier email clearly shows that you 
didn’t realize that was available on mobile - maybe we need a tutorial 
mode that exposes that to users so they are aware of its existence.


Yes, that no longer works once you quit the app. When you do that, 
just drop me a line and I’ll do my best to fix the error.


/D


Thank you for your time with this. A full undo stack is miles more 
powerful than the simple solution I proposed.


Kind regards,

wf



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Subsurface User GUI access to read-only cloud git repository

[Willem Ferguson via subsurface]

Every time when something has gone wrong with saving dives to cloud, 
Dirk has to step in and correct the user blunder. Is there a fairly 
simple way to allow a user to step backwards and forwards in the Git 
tree? I suspect that the dive log Git repository on the cloud has a 
reasonably linear structure. It should not be to difficult to have a 
button that says "Load previous log", which causes the git pointer to 
move backwards and load the previously saved dive log. And, of course, 
the opposite for stepping forward. The specific dive log being accessed 
could be shown in the Subsurface window header, something like 
"Subsurface: Jan2021.ssrf (123 dives) Cloud dive log dated Jan 10 2021 
07:47:23". The only way in which a user could save dive log changes in 
her/his cloud repository should be by selecting a git dive log as the 
current and final version, downloading to laptop and editing a dive. 
Stepping up and down the git tree should not involve any changes to the 
repository at all. A GUI facility such as this would make Subsurface 
exceptional if not unique among all existing database applications.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Accidental file delete on mobile.

[Willem Ferguson via subsurface]

I replied about the re-designed dive edit layout on mobile: excellent. 
However, the issue of accidental deletion of dives is an issue. Given no 
visual feedback about deleting dives, the only way I could recover was:


1) Sync mobile with cloud. This means the dive is also deleted in cloud.

2) Do a trivial edit of the dive on laptop and select "save to cloud"

3) Sync mobile with cloud again. This restores the deleted dive.

Ultimately the backup copy of the dive log (the local one on the laptop) 
was critical to prevent accidental edits such as these.


An absolutely sure-fire way to prevent accidental deletion of dives or 
accidental edits on the mobile platform is critical for a positive user 
experience. I can help myself to prevent a catastrophe, but most newer 
mobile users will not be able to recover. It would really be useful if 
there could be a two-level insurance such as:


1) After editing a dive on mobile and hitting the Save icon (stiffy 
drive icon), ("Are you sure you want to save these edits? Y/n")


2) Upon exiting the mobile app, issue a message "Dive(s) have been 
edited. Do you want to save these edits? (Y/n)".


Kind regards,

willem





--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [subsurface/subsurface] Indicate goodness of fit of regression line (#3148)

[Willem Ferguson via subsurface]

I need to repeat:

Given a non-significant regression relationship between two variables, 
indicating any regression line at all is meaningless. In fact it is 
actively misleading, making you think that there may be a relationship. 
The slope of such a line has no meaning and henceforth is not useful for 
any interpretation.


The broad regression area that Robert indicates in his two diagrams are 
also not useful at all. If one were to plot a pink area of reliability, 
then a 1 standard deviation line is also not useful because it does not 
allow any reliable interpretation of the slope. If one were to do 
anything like this, one needs to indicate the 95% reliability area 
around the regression line, not a 1-sd line. The 1-sd line does not 
correspond to the statistical calculation that was done to generate the 
line. And then only individuals with some background in statistics would 
be able to interpret the 95% reliability area.


Honestly, my recommendation is not to show any regression line if there 
is not a statistically significant trend.


However, Dirk is correct in that it would help very much is some 
information about the regression line is shown. Probably something like 
"Linear regression line". If users could tolerate the statistical 
jargon, one could add the statistical probability, e.g. "p < 0.01".


I hope this makes sense???

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Statistics code for desktop (and soon mobile)

[Willem Ferguson via subsurface]

On 09.01.21 00:13, Berthold Stoeger wrote:

Hi Christof,

Thank you for the detailed report. A few short comments in-line.

On Freitag, 8. Jänner 2021 23:25:07 CET Christof Arnosti via subsurface wrote:

   * When I select date(yearly) as base variable and buddies as data, bar
 charts have a yellow warning in the drop down. Why's that?

A bar-chart is not recommended with continuous data. A histogram is preferred.
However, as you note, the warning icon is not a good UI element.


I suspect the warning bar is indeed a good UI element. The difference 
between continuous and categorical variables will be defined in the user 
manual, once I get to writing that text. It is not good practice to mix 
the use of these two different types of information and a solid warning 
is the least that I would expect. Personally I would prefer a red cross 
over each of the icons for the inappropriate graphs.




In case of sparse data I have likewise found bar charts to be more convenient
than histograms. On the other hand, I see the argument that they can be
misleading if only a few cups of data are missing.


Zero data are useful information. If you did no dives between 30 and 50 
meters, but yet did do dives down to 60m, then the blank areas in the 
range 30 - 50 meters represent valid data: no dives were executed for 
those depths. To ignore zero data is to misrepresent the information. 
This is one of the cases where using a bar graph to represent depth data 
is statistically wrong, leading to erroneous conclusions.





   * The trend line does not always appear in the scatter graph. For
 example, when I select date (no binning) / depth, there is no trend
 line, except for when I filter out very shallow depths. For water
 temp over date I get a trend line right away. I'm sure that's
 correct and there is a statistical reason for this that I'm not
 aware of.

Indeed, there is a statistical test whether there is a linear regression.
Willem knows more.

The red trend line (=linear regression line) is only shown for 
scatterplots where there is a statistically significant relationship 
between the two variables that are plotted. When there is no line, there 
is no relationship. Presenting a trend line in this case would be 
misleading and leads to erroneous conclusions. This will be explained in 
the user manual.



   * When I select Buddies over Date(yearly), and then grouped vertical
 bar chart, the bars are oddly spaced. I suspect that for every buddy
 there is a bar every year, even if the number is zero. This might
 make sense in some cases (for example water temperature), but in the
 buddy case it looks weird. Maybe add some "don't show empty bars"
 option for the grouped bar charts?

I'm not an expert in charts, but I think that this is how grouped bar charts
should be done(?). In the case of sparse data a stacked chart is probably
preferred.
In this case the discussion above is pertinent.*_Zero data are real 
data_**.* *Data of absence does NOT mean absence of data.* If a bar is 
empty it indicated that the buddy did not dive that year. The 
information indicating you did not dive with buddy X during 2020 is just 
as valuable as the information that you dived with her 30 times in 2019. 
Why make the graph pretty by eliminating the bars with zero height??

   * Is there some Export functionality planned? For example simple image
 export of the graph?
Screen capture software can easily be used to save a graph in almost any 
graphical format except as vector graphics.

Not yet.


   * For me the Filter GUI seems a bit unintuitive. When there is no
 constraint present, it's not very obvious that constraints can be
 added (the button is in an odd place). A change to make it more
 obvious could be to add a "Constraints" heading below the fulltext
 search, and move the button there? And maybe also display a "No
 constraints" text when no constraint is set? I really like the
 "Filter sets" functionality!

Yes, I also noticed that - especially in the German translation - the filter
is quite inaccessible.
If you click on "Add constraint", a list of all possible constraints is 
shown. I Need to look at the user manual to see if this aspect has been 
explained clearly. This is possibly my fault.


It is fantastic that you actually looked at the statistics option and 
that you  spent time to think about how it works or how it could work. 
Your comments are extremely valuable. Once the user manual for this has 
been written, hopefully many thing will become more clear, but your 
interpretation of the information and defining your needs are very 
valuable. Thank you for doing that.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

Re: Subsurface-downloader

[Willem Ferguson via subsurface]

Hallo Robert, Excellent work! What is the minimum specs required for the
Pi? There are many Pi models available these days. One of the issues I am
concerned with is the availability of IrDA dive downoads which is slowly
disappearing from most OSs. With a downloader one could maintain an IrDA
stack, although it might have an effect on the kernel version used. Kind
regards, Willem.


On Fri, 04 Dec 2020, 23:25 Robert Helling via subsurface, <
subsurface@subsurface-divelog.org> wrote:

> Hi,
>
> yesterday, we merged the Subsurface downloader branch and I would like to
> hear peoples comments and suggestions for improvement.
>
> So what is it?
>
> Subsurface downloader is a command line version of Subsurface that can
> read a local git repository, download dives from a dive computer and add
> those to the repository. In addition, there is a web interface (in terms of
> a CGI script) to drive it.
>
> What is the intended use?
>
> The iOS-Version of Subsurface in particular can only talk to Bluetooth LE
> devices, in particular there is not much hope to ever directly speak to
> dive computers over USB. I don’t know what is the situation with Android,
> also there accessing USB dive computers might be difficult given some
> security settings. In this case, you could get a Raspberry Pi and install
> the Subsurface downloader. You could tether the RPi to your phone and via
> the web interface make the RPi download your dives from the dive computer
> and upload them to your Subsurface Cloud logbook. And then add additional
> data via Subsurface-mobile on your phone. This would even work in remote
> locations where your only internet connection is via your phone.
>
> What is the current status?
>
> Works for me(™). But it’s not end user ready, yet. In
> ./subsurface/packaging/headless/Setting-up-downloader you will find
> (hopefully complete and I did not miss any step) instructions starting from
> a RPi and an empty SD card to build Subsurface downloader (this takes quite
> a while) and set up the web interface. The web interface and error
> reporting are still minimal and (as the installation process) on mass
> market compatible, yet.
>
> Please give it a try and let me know what you think. Any ideas for
> improvement welcome!
>
> I am really happy, this is now in a somewhat presentable state after the
> idea for this has been dormant for several years. The essential step was
> Dirk laying the foundations and recognising that tethering to the phone is
> enough to make this work (while I had thought it would need to work as a
> wifi access point and I got lost in getting that to work).
>
> Best
> Robert
>
> PS: Of course, nothing is really Raspberry Pi dependent. Also works on my
> Mac and any Linux system. Above instructions are written relative to a
> Debian based system.
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: changes to the mobile builds

[Willem Ferguson via subsurface]

On 2020/11/20 20:45, Dirk Hohndel wrote:

Given that you reported this on a OnePlus I dusted off my own OnePlus 6 and was 
able to reproduce the problem.
adb logcat showed the likely cause and I should have a new test build available 
soon.

Thank you so much for testing.

As I looked closer at the application bundle I am very worried that the cloud 
connection might fail on 32bit phones - but I don't have a 32bit phone that I 
can test on.
Is there anyone here with a 32bit Android device that runs a new enough version 
of Android to support Subsurface?

Willem, do I remember that you had a 32bit Android phone?

/


On my 64-bit phone (Galaxy A20) I see and run version 3.1 without 
problem. However, on my wife's 32-bit phone (Galaxy J2) I cannot see the 
new beta on the Google play store. I uninstalled Subsurface-Mobile and 
reinstalled it. Stlll the older version (3.0.16). When inspecting the 
Google Play store on the J2 it only shows V3.0.16. Can this be?


Kind regards,

willem


--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [subsurface/subsurface] Simple Mac OSX Dark Mode Fix (#3053)

[Willem Ferguson via subsurface]

I can understand that some users prefer a dark mode. However, I think it 
is a regression if the screen display falls back on a 1990's -like 
monocolor display of window text while monochrome monitor screens do not 
exist anymore.


There is a much more friendly solution. Since the use of a dark theme is 
not a corner use case, this is an aspect that can and should comfortably 
be handled by one or more appropriate preference settings. We have a 
screen for display preferences. I would suggest that, in the case of a 
dark theme, a pale blue colour is used instead of a medium blue colour.


Doug, if you look at the overall display of textual information in 
Subsurface in a dark theme, is the blue text the only issue, or can some 
other text colours also be improved?


I tried Ubuntu's dark theme and it does not display Subsurface in dark 
mode, only the window frame. This does not worry me personally, but 
there is a case to be made to have a discussion about the longer term 
vision with respect to how Subsurface as a program responds to different 
themes. Theming has been done in Subsurface-mobile, so there is no 
reason why the desktop application should lag behind in this respect. I 
understand that the question is who would be prepared to do this work? 
But at least if there is a vision of a path forward and an agreed-upon 
code-level strategy, then perhaps implementation could start in a 
stepwise manner.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

UI interdependency problems while building Subsurface

[Willem Ferguson via subsurface]

I need some help with what looks like not a simple problem with the way 
ui_ files (generated by the Qt metacompiler) interact. I have a PR 
pending on the Subsurface GitHub site that gives compilation errors that 
I cannot solve.


I moved the three files (TabDiveStatistics.*) located in 
src/subsurface/desktop-widgets/tab-widgets to a separate directory 
(src/subsurface/stats_widget) and it has brought lots of problems. 
Following a suggestion of @bstoeger I renamed the three files to 
lowercase, so they are (after application of the PR) located at 
subsurface/stats-widget/tab_divestatistics.*


One of the three files is tab_divestatistics.ui (formerly 
desktop-widgets/tab-widgets/TabDiveStatistics.ui). The Metampiler turns 
tab_divestatistics.ui into a c++ header file ui_tab_divestatistics.h. 
This header file, in turn, includes ui_renumber.h which resides in 
subsurface/build/desktop-widgets and NOT in 
subsurface/build/stats-widget (where one finds ui_tab_divestatistics). 
It appears that the build script expects ui_renumber.h in stats-widget. 
This, moving tab_divestatistics.ui from desktop-widgets/tab-widgets is 
causing some includes to fail with a "file not found" error.


Diagramatically, the move of files is like this:

Before move of source code:

subsurface/desktop-widgets/tab/widgets/

    TabDiveStatistics.h

    TabDiveStatistics.cpp

    TabDiveStatistics.ui


After move of source code:

subsurface/stats-widget

    tab_divestatistics.h

    tab_divestatistics.cpp

    tab_divestatistics.ui


After build process:

subsurface/build/desktop-widgets

    ui_renumber.h

subsurface/stats-widget

    ui_tab_divestatistics.h


and the problem is that ui_tab_divestatistics.h cannot find 
ui_renumber.h. Before moving the sourcecode, both ui_ files were in 
build/desktop_widgets.


Does anyone have advice?

Kind regards,

willem





--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Missing salinity from Perdix AI dives

[Willem Ferguson via subsurface]

On 2020/10/22 12:31, tormento via subsurface wrote:
As I wrote in a previous email, salinity is missing from downloaded 
Perdix AI dives.


Could you please check it out?

Thank you

/Alberto/

___
subsurface mailing list
subsurface@subsurface-divelog.org



http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Hi,

It's a 2-step process:

1) Inspect the XML code of your dive log to check if the salinity is 
shown in any way at all.


If it is NOT shown in the XML:

2) Get a dump file and a log file, following section 4.2.1 of the user 
manual, and mail them to this group.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Linux desktop: symbol lookup error

[Willem Ferguson via subsurface]

On 2020/10/04 15:23, Jason Bramwell wrote:

Remove install-root and rebuild. The supporting libraries are only built once 
and they now need to be rebuilt. I think you have an old library in there.

Jb


You are absolutely correct.

Thanks, Jason


--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Linux desktop: symbol lookup error

[Willem Ferguson via subsurface]

I have just upgraded my Linux box to Ubunto 20.04.

I build Subsurface using build.sh.

No error in building.

When I execute the binary I get:
./subsurface: symbol lookup error: 
/home/willem/src/install-root/usr/lib/x86_64-linux-gnu/qt5/plugins/geoservices/libqtgeoservices_googlemaps.so: 
undefined symbol: 
_ZN11QGeoMapTypeC1ENS_8MapStyleERK7QStringS3_bbi10QByteArray


I would appreciate any suggestions.

Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Dependencies of Subsurface on Ubuntu 20.04

[Willem Ferguson via subsurface]

On 2020/10/04 13:13, Miika Turkia wrote:
On Sun, Oct 4, 2020 at 1:18 PM Willem Ferguson via subsurface 
<mailto:subsurface@subsurface-divelog.org>> wrote:


I asked this question several times.

I have just upgraded to Ubuntu 20.04 and, of course, my subsurface
libraries were deleted. Where can I find the list of dependencies to
install for 20.04?


If you use our Launchpad repository, everything is taken care of for 
you. If you are planning on building Subsurface and need the 
dependencies for that, you can still benefit from the repository. To 
prepare, add our repository to your Ubuntu:

sudo add-apt-repository ppa:subsurface/subsurface
sudo apt-get update
Next step depends whether you want to install the version from our 
repository or compile yourself. To just install Subsurface from our 
repository use:

sudo add install subsurface
On the other hand, if you are planning to build yourself, use the 
following command to automatically install the packages building 
depends on:


sudo apt build-dep subsurface

I would be prepared to help maintain a page on the Subsurface web
site
that lists the dependencies for various Linux flavours.


I would think that the packages listed on INSTALL file in our sources 
would be reasonably up-to-date. For the general audience, I would 
suggest to just use the repository and not bother with listing the 
dependencies manually. But if you want to see the facts, the 
dependencies are included in the deb package in our repository, and 
are up-to-date as that is build in minimal build environment and 
whatever is needed to be installed, is automatically added to the 
package metadata. Anyway, if you wish to see the full list of current 
information, following command shows it (if you have our repository 
enabled):


apt-cache show subsurface

Finally, build dependencies you can see also from the repository, URL:

https://launchpad.net/~subsurface/+archive/ubuntu/subsurface/+sourcefiles/subsurface/4.9.7-1~focal/subsurface_4.9.7-1~focal.dsc

HTH,
miika


Thank you very much, miika



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Dependencies of Subsurface on Ubuntu 20.04

[Willem Ferguson via subsurface]

I asked this question several times.

I have just upgraded to Ubuntu 20.04 and, of course, my subsurface 
libraries were deleted. Where can I find the list of dependencies to 
install for 20.04?


I would be prepared to help maintain a page on the Subsurface web site 
that lists the dependencies for various Linux flavours.


KIind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Grouping and managing dive logs

[Willem Ferguson via subsurface]

On 2020/09/27 20:29, Attilla de Groot via subsurface wrote:



On September 27, 2020 20:18:49 Miika Turkia  
wrote:


On Sun, Sep 27, 2020 at 4:59 PM Attilla de Groot via subsurface 
> wrote:


You can add a trip (or multiple trips) manually, and add selected 
dives to the trip. Choose the dives you want to group together, click 
right button within the selection and choose create trip above. This 
should group all the selected dives together. (Not sure if it works 
if there is a different trip in between the dives, but it should be 
easy to test out.)


I've tested that part, but then the local dives get added to the trip 
in between. I can create a trip for each period between my actual 
trips, but it would be nice to have my local dives grouped together.


-- Attilla

The dive log is supposed to be a chronological sequence of dives. 
Tagging and filtering is designed to view groups of dives in any 
arbitrary way, exactly as in your requirement. I understand it's time 
consuming to add tags (I have had to do it myself), but if one requires 
additional functionality from the dive log,  the time invested in adding 
tags to historic dives is worth it.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Fwd: Re: RFC: Statistics in Subsurface

[Willem Ferguson via subsurface]

On 2020/09/27 15:13, Dirk Hohndel wrote:



I think there is some misunderstanding, or am I myself 
misunderstanding?? See inline below.



Hi Willem,

adding the Subsurface developer list to this thread

On Sep 27, 2020, at 5:34 AM, Willem Ferguson 
 wrote:


A quick question about the use of C++ and QML in writing code for 
presenting graphs. In general, my leaning is towards QML simply 
because making anything mobile-friendly is a longer term investment, 
even though I hate QML. But there are at least four parts of the code 
that may benefit differently from QML:


1) UI for selecting variables to be plotted. At this stage just two 
comboxes as discussed in previous emails during May this year. This 
could benefit from QML , but the UIs on desktop and mobile are likely 
to differ vastly. Therefore doing it in QML may not necessarily yield 
tangible benefits and one may just as well do it in C++ for the 
desktop. Comments?
The more I think about this, the less I think it makes sense for this 
to be in QML on the desktop. Yes, it will need a QML UI on mobile if 
we decide to allow editing on mobile - but part of the reason why we 
are storing those filters in the cloud storage is so that we don't 
need that UI on mobile in the first place. Because: painful, complex, 
error prone on a small touch screen

So I'm fine with what Berthold has started, just using QWidgets


I am talking about UI element(s) that allow selecting the variables one 
wants to graph. You appear to be talking about selecting dives to be 
analysed. In a typical situation one would use the filter to select all 
the dives at a particular dive site, or the dives during a particular 
year. After selecting the appropriate dives using the filter, one needs 
to, in addition, specify which variables on wishes to graph, e.g. SAC 
versus Depth. After using the filter, one ends up with a dive_table in 
which the filter has selected all the appropriate dives using the 
dive->selected boolean. Now one needs to define the plot variables. So 
this is a SECOND level of selection AFTER filtering. In most cases 
variables used in filtering will NOT be involved in the drawing process: 
e.g. if one filtered for dives during 2019, it does not make sense to 
plot year because there are only dives for one year (2019).


2) Background infrastructure for creating 
arrays/structures/linked-lists to be plotted. This interacts with the 
dive_table structure, extracts appropriate information, creates 
appropriate categories (e.g. when plotting values associated with 
tags). This should probably be in C++ since no UI is involved and I 
cannot see why QML would be beneficial. Is this point of view realistic?

Definitely. And I think Berthold is planning to write that code.
I am not talking about the filter here. Let's say we wish to graph the 
number of dives for each month of the year. The dives in the dive_table 
needs to be scanned for month and the appropriate accumulators created 
to keep a tally of the number of dives for each month as one scans the 
dives that have been marked as dive->selected.  This is likely to be in 
C or C++, not QML. These calculations are independent of the filtering 
process that is likely to have happened beforehand.


3) The graphing that occurs within a single graphview object. This 
should probably be beneficial if it were written in QML, since it 
would be portable to the mobile environment. Porting this to mobile 
might mean rewriting the UI frame/page/tab to place the graph at an 
appropriate place, but the way the graph is constructed will be 
standard across desktop and mobile. Is this point of view realistic?
Yes - if we can use the same QML code on desktop and mobile for 
actually creating the graphs, that would likely be best.
As a side-comment, every time I get in contact with Berthold's filter 
code I am impressed with the longer-term vision. Only now do I realise 
why the filter sets actually need to be stored on the cloud.

Curious if others have strong feelings about this...

/D




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Two issues in 4.9.7 on OS X

[Willem Ferguson via subsurface]

A question:


On 2020/09/25 22:33, Dirk Hohndel via subsurface wrote:

On Sep 24, 2020, at 10:35 PM, Attilla  wrote:

Hi,

I just installed 4.9.7 (never got around installing 4.9.6) and I noticed two 
small things:

- In dark mode the text on the information tab is blue. This makes it quite 
unreadable.

Yeah, I have never used dark mode - I assume that someone who's into that kinda 
thing will send patches.
Dark mode on mobile is also pretty crap, according to what users report.


Can one set dark mode in the Subsurface desktop application? Using Gnome 
Tweak in Ubuntu does not really create a dark theme.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Fwd: Re: Two issues in 4.9.7 on OS X

[Willem Ferguson via subsurface]

 Forwarded Message 
Subject:Re: Two issues in 4.9.7 on OS X
Date:   Sat, 26 Sep 2020 07:36:55 +0200
From:   Willem Ferguson 
Reply-To:   willemfergu...@zoology.up.ac.za
Organization:   University of Pretoria
To: JB2Cool 



On 2020/09/25 23:58, JB2Cool via subsurface wrote:
As for the colour of these fields, as far as i can see that's 
controlled by this file 
(https://github.com/subsurface/subsurface/blob/master/desktop-widgets/tab-widgets/TabDiveInformation.cpp). 
Now the information tab seems to be the only tab where these fields 
are blue, all the other tabs (as far as i can see) have black text in 
light mode and presumably white text for dark mode. Question, why are 
these fields blue? Would it be acceptable for them not to be blue?


JB


It is blue in order to clearly separate what is a heading (blue) and 
what is information (black). The screen is rather dense in text and 
information and without some way of separating headings from text, the 
readability of the information is much reduced. I would make the current 
blue text light blue in dark mode. In my view, a simple black/grey 
interface is also rather old-fashioned.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [subsurface/subsurface] [WIP] Filter constraint prototype (#2854)

[Willem Ferguson via subsurface]

On 2020/08/12 20:08, Dirk Hohndel wrote:


This hasn't seen updates in ages. I thought @willemferguson 
 was going to look into UI work, 
and then, err, forgot.
What are reasonable next steps to move this forward. I've played with 
it and think it is a very good way to build filters. But it needs a 
good "intuitive" UI (ha)


—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub 
, 
or unsubscribe 
.


Apologies for being slow. During the last 2 months I have been involved 
in a project that is extremely time consuming and have not kept my eye 
on this thread. Should be done within a week.


UI for the filter. I have been looking at the present layout of the 
filter quite carefully, and have in fact used it quite a bit and find it 
pretty intuitive. I could not see any immediate way of making a 
significant improvement to the present filter UI. I had a small issue 
with the divemode dropdown list but Berthold fixed that up as well. A 
lot of it has been in the user manual for some time. If Dirk, Berthold 
or anyone else has any specific suggestions, needs or requirements as 
far as UI is concerned, I would be much more than happy to investigate 
what is possible. It would be pretty high on my priority list.


The next thing is to make a start with the statistics. I would approach 
Tomaz to assist with the basic skeleton of something like this.


But for the moment let's focus on anything that is required for the filter.

Kind regards,

willem





--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: UI for dealing filter sets

[Willem Ferguson via subsurface]

On 2020/05/25 19:54, Berthold Stoeger wrote:

Hi Willem,

On Montag, 25. Mai 2020 17:49:57 CEST Willem Ferguson wrote:


My idea was to add the tools for dealing with sets to the toolbar at the
top of the filter panel. Something like the attached image with the set
controls grouped together. What was your conception of the number of
controls required? This image has three tools for manipulating sets, but
two of them would be complex. Firstly, the Save set control would
probably need to bring up a text box for naming the set to be saved.
Secondly, the List sets combobox showing all the saved set names would
need a right-click context menu for deleting a set and possibly for
editing a set. The number of tools should probably be minimised but on
the other hand the interface should be as intuitive as possible. What
are your thoughts?

This is in principle one of the two designs that I had in mind. The
other one would have been an extra tab for the management of the sets in
analogy to the dive-site tab (including e.g. renaming of sets).

I am not sure whether I understand the "Clear sets" button. Would it clear all
the sets? My original idea was to have a "Clear current set" button instead of
right-click.

I was also contemplating if there should be a "default" set, which can't be
deleted and is activated if the user switches to the filter.

Another question to ponder: If the user selects a set and changes the filter
constraints, is the selected set overwritten or does the user have to
explicitly save the set?

Berthold



Hi Berthold,

I am happy with whatever you feel is appropriate. The crucial question 
is the life expectancy of a set that has been saved. If it has a long 
life (maybe longer than a week or 2???) then a separate set manipulation 
tool may be warranted. I am not sure that a logical AND operation would 
be necessary when applying a filter with 2 or more sets on the dive 
list. An AND operation is probably best implemented *within* a single 
filter panel. Would this be correct?


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

UI for dealing filter sets

[Willem Ferguson via subsurface]

Berthold,

My idea was to add the tools for dealing with sets to the toolbar at the 
top of the filter panel. Something like the attached image with the set 
controls grouped together. What was your conception of the number of 
controls required? This image has three tools for manipulating sets, but 
two of them would be complex. Firstly, the Save set control would 
probably need to bring up a text box for naming the set to be saved. 
Secondly, the List sets combobox showing all the saved set names would 
need a right-click context menu for deleting a set and possibly for 
editing a set. The number of tools should probably be minimised but on 
the other hand the interface should be as intuitive as possible. What 
are your thoughts?


Comments, anyone?

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

RCF - - UI -- Filter constraint prototype (#2854)

[Willem Ferguson via subsurface]

On 2020/05/24 19:46, bstoeger wrote:


May I make some comments on the UI?

Any comments are highly welcome. I tried to sketch an implementation 
of your suggested layout. I failed in a few points, notably I didn't 
find out how to make the string-field stretch all the way to the side. 
One would think that setting the |sizeHint| to |minimumExpanding| 
would do the trick, but it doesn't.


I fear that I need help here - if I'm supposed to do the UI this will 
not go anywhere.


There are some slight differences between the filter options for a
Full Text search (Substring, Starts with, Full word) and for text
searches in other fields, (e.g. suit: these being substring,
starting with, exactly).

They do different things: When the tag search is set to "exactly", 
then the whole tag must match, even it if is composed of two words. In 
contrast, the fulltext search only matches single words. We probably 
should implement a better fulltext search where you can specify that 
whole phrases have to match with quotation marks. c.f. Google.



Hallo Berthold,

If my proposal for a Filter UI is acceptable at all, (I attach the 
mockup used in github), then I am prepared to give some UI support 
(within my rather restricted Qt skills, but I have dealt with similar 
panels in Subsurface) so that you can focus on the stuff that is really 
important. You should not need to worry about column alignment within a 
form.


I hope some group members will give some feedback.

Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: RFC: Statistics in Subsurface

[Willem Ferguson via subsurface]

On 2020/05/17 21:51, Linus Torvalds wrote:

On Sun, May 17, 2020 at 3:34 AM Willem Ferguson via subsurface
 wrote:

As a side note it is in principle possible for case (5) and (6) above
to include a *continuous* 3rd variable e.g. a scatter plot of SAC
versus dive depth where the colour of the dots indicate the water
temperature of each dive.

The temperature vs SAC scatterplot would be one of the few statistics
I'd like to see, because it's the one that I personally think might be
the best correlation. Not that I've really ever tested it.

You have those "SAC vs depth" and "SAC vs suit" correlations, but I
suspect at least some of them end up being about temperature, where
the suit choice (and depth) end up being incidental rather than
causal. Also, I happen to think thaty both of those choices are not
good scatterplot axis choices, because I'd consider them fairly
discrete (while temperature and SAC rate aren't).

So if we do fancy scatter-plots, I'd rather see them done the other
way around. Do the continuous variables as the axes, and then color by
the discrete variables (so you can see suit type by color if you
care).

And yes, depth may _technically_ be continuous, of course, but I don't
much think "depth" makes sense all that much sense treated as a
continuous variable. Nobody cares about 16m vs 19m, I suspect. But you
might care about "deepest dives" as thirds or quartiles, because
there's certainly a difference between a shallow dive and a very deep
one (but different people will have rather different notions of what
constitutes a "deep dive").

So if your max depth of all your selected dives is 176 ft (to pick a
random number that happens to be my two deepest dives), maybe it makes
sense to divide your dives into 0-60 ft, 60-120 ft, and 120+ feet and
give them three different colors, rather than a continuous axis.

Of course, this is only if you want to show three different variables.
If you only do two, then by all means do the depth continuos.

  Linus


You make perfect sense. Thank you for this input. Classes of depth 
should be easy to accommodate with Dirk's Granularity concept.


The word Granularity may need to change because, even though it is 
entirely intuitive for me, it is perhaps not intuitive for the 
first-time user. However, I have no idea which word may be better.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Fwd: Re: RFC: Statistics in Subsurface

[Willem Ferguson via subsurface]

On 2020/05/16 18:22, Dirk Hohndel wrote:



I'd argue that's six (but that's because of my potential additions):
two values:
- 1) Bar chart
- 2) Dot graph
- 3) Scatter plot
three values:
- 4) Stacked bar chart
- 5) Dot graph with colors
- 6) Scatter plot with colors.


We need to think about the UI for selecting the third variable. My idea 
was to use the Granularity dropbox for this purpose.


For case (4) above, only two options for the 3rd variable are available 
(total no. dives and total dive time). The 3rd variable provides for the 
units along the vertical axis. Because of the fact that a stacked bar 
graph indicates the sum of some discrete components, none of the other 
variables that we considered would make sense within this context.


In contrast, for cases (5) and (6) above, the 3rd variable is probably a 
*categorical* variable e.g. suit type, dive type or one or more tags. We 
might have a dot graph of SAC rate using different suits (case 5) or of 
SAC rate against dive depth (case 6) where the dots are colour-coded to 
represent dive mode. This would require a key to explain the different 
colours as presently in the stacked bar chart. Here are two mockups for 
this type of situation:


As a side note it is in principle possible for case (5) and (6) above to 
include a *continuous* 3rd variable e.g. a scatter plot of SAC versus 
dive depth where the colour of the dots indicate the water temperature 
of each dive. Here is a mockup of what I would call case (6a):




But this will require a different level of complexity in calculation and 
visual presentation.


What I am leading up to is that, if the Granularity dropbox is used for 
specifying the 3rd variable in cases (4) to (6) above, then these cases 
will not use the same 3rd variables. [case (4): no dives & total dive 
time; case (5) and (6): categorical (as well as continuous??) 
variables]. That would require that either some variables are greyed out 
in the Granularity dropbox, or that the Granularity dropbox is populated 
with a custom set of alternatives for each of these cases.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Fwd: Re: RFC: Statistics in Subsurface

[Willem Ferguson via subsurface]

On 2020/05/14 18:24, Dirk Hohndel wrote:


Willem, those are some very strong statements that initially provoked 
a rather negative reaction in me. Calling someone else's proposal "not 
up to modern standards" feels borderline insulting.
As a matter of fact, yes we can show vertical labels. They are also a 
complete pain to read. I would argue that the readability of a 
horizontal chart is actually much better than the vertical one that 
you so strongly argue for.
I did a quick survey of some of the other dive logs that have screen 
shots of their statistics pages up on their web sites. And they seem 
to be about equally split between the two different approaches.


I apologise unreservedly if I appeared insulting to anyone.



To me in the end this doesn't really matter. I don't think I'd ever 
use this other than to test that it works. Which is true for two 
thirds, actually, more likely 80% of the features in Subsurface.
What I do care about is that we continue to build something that stays 
maintainable, stays usable, and serves the need of a broad user base. 
That's why I refuse the frequent attempts to turn Subsurface into an 
asset management tool. And that's why I will gently push back to 
attempts to turn Subsurface into tool for statisticians. There are 
great tools for those purposes. Use them.


I attach a suggestion that, to me, what it does is to actually plot the 
raw data points and show what the mean value for each dataset is (red 
bar). This is much more usable than a mere report of min, mean, max. For 
instance, for the wetsuit dataset, the bottom two points are probably 
outliers (possibly erroneous cylinder pressures or cylinder type entered 
into the dive log?) and one might consider not using these to interpret 
the data. For wetsuit, it appears that SAC mostly varies between 13 and 
21, and that the min and max values indicated are not necessarily so 
useful. For the semidry suit data, the data points are much more 
cohesive and the min and max values plotted are possibly more useful. It 
depends on the person looking at the graph to use the min and max as 
plotted, or to use some other way of interpretation. This would provide 
a good impression of the distribution of the SAC data for each suit type 
and still provide mean, max and min values. And I think most persons 
should be able to interpret the diagram easily?


Kind regards,

willem







--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: RFC: Statistics in Subsurface

[Willem Ferguson via subsurface]

On 2020/05/13 23:11, Dirk Hohndel via subsurface wrote:
The video that Pedro linked to seemed to indicate that the first chart 
is most likely to be understood, and that the the second one was 
harder to see trends in.


Conflicting with that is the desire to more typically show bar graphs 
sideways, as that makes it easier to deal with many data sets (think 
labeling the columns vs. labeling rows)


So all this is super helpful in figuring out how we should visualize 
these things - but not necessarily all leading to the same answers, as 
I'm not sure how well these line graphs work when turned 90 degrees :-)


/D



On May 13, 2020, at 12:53 PM, Hartley Horwitz > wrote:


I"ve attached 3 graphs showing the statistics summary.  Once again I 
showed them to a work colleague.  He found the upper 2 graphs easiest 
to understand.


...Hartley

On Wed, May 13, 2020 at 3:24 PM Dirk Hohndel > wrote:


That is excellent input!

Your final point is one that I had kinda assumed - most of the
"more interesting" data no one but a geek will look into. And to
them either box and whiskers (so quartiles) or at least floating
box with mean (or your version in the first SAC chart below with
the 0 based box with the mean as height and with whiskers for
min/max) should make sense. But it also makes sense to look for
simper ways to give access to the same data. Can you give an
example for the "line graph with 3 lines for min/mean/max"?

Thanks

/D




___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


I must admit that I do not like any of these three representations. They 
are inappropriate and inaccurate, leading to misinterpretation.


The top graph is normally used to indicate trends in three *independent* 
variables that may or may not be correlated. In the dive the data 
represent a *single* variable with its min and max values.


The middle graph is a histogram that would normally also represent three 
*independent* variables that have been sampled on the same x-axis scale. 
Again, in the dive case the min and max values represent the *same* 
variable.


The bottom graph is normally used to indicate the proportion of a total 
that is formed by a specific component. In the case of this specific 
graph, the median would be indicated by the height of the orange bar 
(i.e. vertical distance between the grey-orange border and the 
orange/blue border). The max would be indicated by the height of the 
blue part of the graph, etc. Clearly this is not what is meant.


I want to make a call that, if we are dealing with representing 
statistics, we actually use the proper statistics representations that 
we are all used to. Most likely that is either some variant of a box and 
whiskers diagram or a vertical bar chart with error bars. If these 
diagrams have been shown once to an uninformed person, the 
interpretation will always be easy. Lets use diagrams for what they are 
meant to convey and not use a sports car to drive offroad. We do not 
want any statistics related to Subsurface to be presented in an 
unprofessional and inappropriate way.


As far as the horizontal graphs are concerned, they have a place, but we 
need to understand where they come from, and that is from the old days 
when we tried to print graphs on a mainframe line printer that could not 
print characters vertically. The conventional way to represent 
histograms or bar charts is in the vertical way *unless there is good 
reason to do otherwise*. These days there is no problem in printing 
labels vertically. To have a horizontal bar graph with depth 
measurements along the vertical axis is just totally unorthodox and not 
up to modern standards.


Kind regards,

willem








--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Fwd: Re: RFC: Statistics in Subsurface

[Willem Ferguson via subsurface]

 Forwarded Message 
Subject:Re: RFC: Statistics in Subsurface
Date:   Tue, 12 May 2020 21:41:08 +0200
From:   Willem Ferguson 
Reply-To:   willemfergu...@zoology.up.ac.za
Organization:   University of Pretoria
To: Dirk Hohndel 



On 2020/05/12 20:49, Dirk Hohndel wrote:

Hi Willem,

Thanks for responding... I wish more people got involved into these 
conversations. But usually topics like this get two or three of the 
300+ people here to respond. And then ten more will complain after we 
have done the next release and they notice for the first time that we 
added a feature...


On May 12, 2020, at 12:59 AM, Willem Ferguson 
<mailto:willemfergu...@zoology.up.ac.za>> wrote:


I understand Berthold's request with respect to temporal sequences. 
When developing such a temporal facility there is an important 
caveat. Emphatically, such temporal representations do not provide 
any clear *explanation* of anything: it is just a temporal pattern. 
For instance a decrease in SAC rate over time does not necessarily 
imply any improvement in physiological ability but may reflect 
adoption of new equipment or change in dive sites. Any explanation of 
a temporal trend is dependent on the understanding of the USER, not 
on the SOFTWARE. So, when dealing with temporal trends, one needs to 
consider carefully the intended type of use of it. I think Berthold 
is more concerned with continuous variables such as temperature, SAC, 
dive duration, depth, etc which could probably be reasonably easily 
implemented. To represent categorical variables such as tags, dive 
mode, people and suit (one could even add dive site) is a totally 
different issue requiring a totally different type of visual 
representation.




I was in complete agreement until the very last sentence. I don't 
understand why this 'per se' requires a "totally different type of 
visual representation".
Let's say I am charting SAC over my criteria. Let's assume I'm using 
box and whiskers charts to easily show the quartiles. The values on 
x-axis have implications for the interpretation, of course, but 
whether the x-axis is months of the year, the suit worn, the maximum 
depth of the dive, the tags present on the dive (e.g., teaching dive 
or non-teaching dive) has absolutely no impact on how this should be 
visually represented...


It would help, in this discussion, if one were to distinguish between 
the filtering aspect and the statistics display aspect and state that 
with respect to the argument. In Dirk's artwork above, I am not sure 
how the constraints will be used. Are we talking of the filtering 
process or the stats display mechanism? Let's say "Suit" is a 
constraint and two dates are provided. I am not sure what the 
expected result of the operation would be. Ahh, the problems of 
communication.




What I was trying to describe was a way to create criteria that can be 
used for columns in the visualization. You go through this filter 
process, name the result, and that name becomes one of the available 
labels over which you can chart the values.

Again, as I said before, I may simply be over-engineering this.

In general, in my opinion, the existing filter layout is a good 
starting point (I would add the variables of dive depth and dive 
duration because they are the two variables that fundamentally define 
a dive). As a filtering mechanism the current implementation is 
ultra-flexible.




While I respect your opinion, let me politely state that personally I 
believe that the current filter widget is a disaster and extremely 
unintuitive to use. That's not a criticism of the original author, nor 
of the people who have added to it - but yeah, that thing is a mess.


As far as UI for filter sets are concerned the minimum component 
count would include: Combobox of existing named filters within the 
set. Button: add current filter to filter set. These could 
potentially reside at the top right of the current filter panel. But 
there might be a need to give filter set a name as well. That would 
need a text box.




Making the current widget more convoluted and more confusing was not a 
direction that I was envisioning us to go.



Maybe we need to rain in the crazy German and go back to something 
much more basic. Something like ten predefined sets of criteria. And 
only apply them to the filtered dive list.


So.
(1) per month
(2) per year
(3) per trip
(4) by max depth in 10m increments
(5) by duration in 10min increments
(6) by min temperature in 10F / 5C increments
(7) by type (for people who track more than SCUBA)
(8) by suit (that's likely a fairly small set for most people)
(9) by tags (that one I'm unclear about - would likely need some more 
ability to influence how this is drawn - but straight forward would be 
to draw them in pairs of two, left one represents with the tag, right 
one without the tag)

(10) by people? (no idea how / why)
(11) by full text? (no idea ho

Re: Fwd: RFC: Statistics in Subsurface

[Willem Ferguson via subsurface]

On 2020/05/08 17:42, Dirk Hohndel wrote:


So let's go back to what I said earlier about (ab-)using the filter. 
How about we use the insanely flexible filter to allow the user to 
define their own group:

- pick filter settings (dive with tag 'boat', longer than 40min)
- name that 'set' (boat dives > 40min)
- pick different filter settings (dive with tag 'boat', 30-39:59 duration)
- name that 'set'
combine a group of 'sets' into a group which gives you the slicing of 
the dives that you want


Now offer those sets as rows in the statistics table. That way we can 
reasonably easily allow users to create almost any statistics they 
might want.



/D

So what this would amount to are two different initiatives which could, 
potentially, run in parallel.


1) Adapt the existing filter mechanism to store filter 'sets' and then 
apply them to the dive list. Mechanisms to store filter "sets" and 
combine them to extract dive list information that is stored in the 
yearly-statistics table. This table would now have slightly a different 
function, i.e. to store the output of the filter process. It might 
possibly not be directly displayed any more but be accessed through the 
Statistics facility.


2) Rendering statistics in a panel. For the moment, let us assume the 
current (yearly-statistics) table is used to store the results of the 
filtering. I cannot see why not since the table is easily extensible. So 
this second activity would include reading the information from the 
(yearly-statistics) table and presenting it in the statistics panel. 
This would be a QML implementation.


As for activity 1) above, There would need to be some UI components to 
manipulate filter 'sets".


A button to add (=store) a set after it has been defined/edited in the 
filter panel.


A dropdown box indicating the sets that have been defined. The sets 
would probably just be defined as "Filter1", "Filter2", etc. Clicking on 
a specific set in the dropdown box allows editing or deleting a set.


A button to clear all sets. Although the yellow-arrow button to "Reset 
filters" could perform this function.


BUT: would this mean that the existing filter panel be rewritten in QML 
to be mobile-compatible? For mobile, would this be a scaled down version 
or a full-blown version?


Kind regards,

willem





--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: quick update on test binaries

[Willem Ferguson via subsurface]

On 2020/05/08 18:06, Dirk Hohndel via subsurface wrote:
And it turns out that dives/images/wreck.jpg (which is part of the 
sources) does indeed contain GPS data,
so it's easy for everyone to test this by creating a dive 
around 2012-01-08 15:51:04


In my brief test on macOS with latest master (4.9.4-80) this appears 
to work as I would expect.


Thanks Theodor for pointing out the issues and Berthold for 
immediately fixing them!



Something I missed. If, for a dive, I have the dive location as a named 
dive site with coordinates and then attach a photo with other 
coordinates, does anything happen? I tried this on my Ubuntu box and I 
could not see anything happening (correctly, I would think). The photo 
appeared in the Media tab for that dive and I could not find any new 
location in dive site list.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: quick update on test binaries

[Willem Ferguson via subsurface]

On 2020/05/08 18:06, Dirk Hohndel via subsurface wrote:
And it turns out that dives/images/wreck.jpg (which is part of the 
sources) does indeed contain GPS data,
so it's easy for everyone to test this by creating a dive 
around 2012-01-08 15:51:04


In my brief test on macOS with latest master (4.9.4-80) this appears 
to work as I would expect.


Thanks Theodor for pointing out the issues and Berthold for 
immediately fixing them!


/D


I tested this with Ubuntu 18.04 and Subsurface 4.9.4-37. Everything 
works as expected. Created dive, added wreck photo, checked for a new 
dive site in the dive site tab.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Proposal: Statistics in Subsurface

[Willem Ferguson via subsurface]

I have been thinking  a long time about graphical statistics facilities 
for Subsurface, that is presenting the dive statistics as bar graphs or 
other types of graphics.


1) In doing so, I looked at the yearly statistics as implemented at the 
moment and realised that this is actually a pretty comprehensive 
statistical framework and that it would be inefficient to write a 
separate code base for graphical statistical presentation. The current 
code for statistics is somewhat complicated but perfectly workable.


2) The current statistics tab, accessible from the Notes Panel (i.e. the 
statistics tab adjacent to the Information tab) actually largely 
duplicates what can be obtained from the Yearly statistics panel. The 
only difference is that, currently, the Yearly statistics calculates 
results based on the whole dive log, while the Statistic tab presents 
results for all the dives selected on the dive list. However, 
yearlystatisticsmodel.cpp already already has code that in principle 
allows calculations for the *selected* dives in the dive log: it is just 
not activated as far as I can see.


3) The main problem with the yearly statistics is that the table is 
pretty large. In order to make this more user friendly, my proposal is 
to break the yearly statistics table into smaller chunks and move them 
over to the Statistics tab.


4) This would bring all the statistics together in one place. Seeing 
that the info in the Statistics tab has no one-to-one connection with 
the dive profile being displayed, the question arises: should the 
statistics tab not be elevated to the main menu rather than a tab within 
the Notes Panel ??


5) What I am thinking of is to break up the results for yearly 
statistics and move them over to the statistics tab. The interface may 
perhaps be a dropdown list corresponding to all the headings on the 
left-hand side of the yearly statistics. Another dropdown list would 
have information similar to the column headings of the yearly 
statistics. One would then select an item from each of the dropdown 
lists and this would bring up the relevant numbers as well as a 
graphical representation of these numbers. The min, max and average 
numbers currently shown in the statistics tab needs to be made 
accessible in some way, but probably integrated with the above 
somewhere. This would mean that the existing statistical infrastructure 
largely remains as is, it is just the UI for showing the results that 
changes.


Does this look like a viable approach at all?

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: 4.9.4 released

[Willem Ferguson via subsurface]

Dirk,

I think expressing our gratitude to you is in order. Code review, 
putting together the build environment, integration with Github and the 
publishing of new versions, take a huge amount of time. This is what 
facilitates the whole project. Thank you for that.


The latest development of the mobile app has also turned the app into a 
real self-sufficient application. The editing of trip information, 
widescale undo ability, and the implementation of several context menus 
has really created something that is much, much more than an add-on to 
desktop Subsurface, and I suspect you did most of that work. We deeply 
appreciate that.


Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: new CI builds

[Willem Ferguson via subsurface]

Using 4.9.3-1480 on Ubuntu 18.04

I downloaded this version from the Ubuntu ppa provided by Dirk.

(one question in total ignorance. Is this package a snap?)

I downloaded using both Bluetooth and iRDA, no problems. Edited these 
dives. No problem.


Tested all the options I could on the dive list context menu. No problem.

Tested all the possible preference values. No problem.

Created a dive manually with Log->Add dive. No problem. Edited profile 
by hand and manipulated the info in the various text boxes. Saved them. 
No problem.


Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: download log files from divecomputer

[Willem Ferguson via subsurface]

On 2020/04/18 10:06, René Ruiter wrote:
Must the divecomputer (cosmiq) always first download via bluetooth, 
before you can put the files on your computer. My phone has not so 
many space.


René


You are not absolutely clear, so I am reading between the lines. You 
want to download dives from your Cosmiq to your mobile phone and then 
transfer them to your desktop computer?? I deduce you use Windows on 
your desktop?


If this is what you wish to do, why not download from the Cosmiq 
straight onto your Desktop? From the above, I deduce you cannot do 
Bluetooth download to your desktop (perhaps no bluetooth available on 
your desktop??). Many inexpensive generic USB Bluetooth adapters can 
work with your desktop. If the Cosmiq connects to your mobile phone it 
should also connect to your desktop using a generic Bluetooth interface.


It is possible to download the dives using Bluetooth to your mobile 
phone and then transfer them to your desktop via the Cloud, but if your 
phone does not have space to keep a full dive log, this would need quite 
a bit of trickery.


Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Crash in Desktop-Subsurface 4.9.3-1455 on Ubuntu 18.04

[Willem Ferguson via subsurface]

I select some files in the dive list. Then I select Files -> Export -> 
Profile data CSV (Bottom of the list). I then specify a file name and 
hit Save.


    Crash.

Is this finger trouble on my side or is it repeatable elsewhere?

What is this option meant to do, separate from the other similar option 
6th from the top on that same list of export options?


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: towards 4.9.4

[Willem Ferguson via subsurface]

I'd like to see that the user manual is up to date for 4.9.4

Which are the obvious issues that you would like to see addressed?

Kind regards,
willem


On 2020/04/15 21:30, Dirk Hohndel via subsurface wrote:

Quick update on where we are...

Subsurface-mobile 3.0.4 with crash fixes has been pushed (I believe
it's out on iOS but still waiting for review on Android - part of this
is my fault as I messed up submitting the 3.0.4 beta on Android).

The crashes that have been reported here for Subsurface should be
fixed.

The git storage issues have been resolved and in the process another
long standing bug that rarely and randomly caused issues has been
fixed.

The UI issue with info tab on most (but not all) OSs / desktop
environments has been addressed.

If anyone is working on fixing the dark theme issues, I am not aware of
that. So that part of the problem might still be ongoing.

The user manual is still in need to have refresh.

None of the build infrastructure work has happened while we were
chasing the other bugs mentioned above. That's what I hope I'll get to
focus on in the next few days.


Please keep testing, please keep sending bug reports.
I know, few of us currently get to go diving so it may be hard to
motivate yourself to dig out a dive computer to test some downloads or
to work with the dive planner or to try printing some dives.

But maybe that's a good way to remember the enjoyment of diving while
dealing with the current COVID-19 reality.

Thanks

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Video user support for Subsurface-mobile

[Willem Ferguson via subsurface]

Please see the following link for five video files.

These are not meant to be to fully cover each aspect of 
Subsurface-mobile, but rather guide a newby to become more familiar with 
the software.


There needs to be a videos that cover USB dive download (I do not have 
access to a USB dive  computer at present) and also running and using 
the location service (I need to go do a few dives to generate the video 
material; waiting for lockdown to end).


Any other topics that would be highly useful?

https://www.dropbox.com/sh/z74vcrvjbvnb2ar/AABYsuVpsSYd4KkqGird1J4Wa?dl=0

I am not sure how to publish this. Possibly a static page on the 
Subsurface web site with a link in the user manual?


Kind regards,

willem





--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Crash in Subsurface-mobile 3.0.3 on Android 7

[Willem Ferguson via subsurface]

On 2020/04/12 20:58, Dirk Hohndel wrote:

I see two crashes from the 32bit version of Subsurface-mobile on Google Play. 
Are you using a Samsung Galaxy J2?

Neither of these crashes has a really useful crash. One happens without useful 
stack trace in the Qt QML shared library.
The other is a little more interesting:

   #00  pc 00017830  /system/lib/libc.so (memcpy+100)
   #01  pc 001fad55  
/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libsubsurface-mobile.so 
(FullText::unregisterWords(dive*, std::__ndk1::vector > const&)+96)
   #02  pc 001fa9af  
/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libsubsurface-mobile.so 
(FullText::unregisterDive(dive*)+14)
   #03  pc 001effb3  
/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libsubsurface-mobile.so
   #04  pc 001eff9b  
/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libsubsurface-mobile.so 
(free_dive+6)
   #05  pc 001e15c5  
/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libsubsurface-mobile.so 
(Command::DiveToAdd::~DiveToAdd()+16)
   #06  pc 001e1b0d  
/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libsubsurface-mobile.so 
(std::__ndk1::__vector_base >::~__vector_base()+16)
   #07  pc 001e488d  
/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libsubsurface-mobile.so 
(Command::DeleteDive::~DeleteDive()+24)
   #08  pc 001e48b1  
/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libsubsurface-mobile.so 
(Command::DeleteDive::~DeleteDive()+4)
   #09  pc 002cb771  
/data/app/org.subsurfacedivelog.mobile-1/lib/arm/libQt5Widgets.so

So we are once again crashing in the full text filter code when unregistering 
words as we delete a dive.
I am trying to reproduce your issue with my Sony Xperia which is my only 32bit 
Android device...

/D


Yup, I have 9 months to go before I can get a better phone.

Kind regards,

wf



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Crash in Subsurface-mobile 3.0.3 on Android 7

[Willem Ferguson via subsurface]

Several of the items in the context menu for dives in the dive list 
(i.e. long-tap on a dive in the dive list) result in a crash. Theses 
include Delete dive, Remove dive from trip, add dive to trip. The 
option: Show on map works ok. Have not tested mark as invalid.


Should I create an issue on Github?

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Dive trip editing using Subsurface-mobile

[Willem Ferguson via subsurface]

Having downloaded some dives from a divecomputer onto Subsurface-mobile, 
the newly-downloaded dives are listed in the dive list under a trip 
title showing year and month.


Is there a possibility to edit this information to show the broad 
identity of the trip (e.g. "Portofino, Italy", or "ScubaExtreme Divers, 
Portofino")? This need is acute if more than one dive trip per month is 
done, but in general one would like to put more specific information in 
the trip title.


Kind regards,

Willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Dive uploads on Subsurface-mobile

[Willem Ferguson via subsurface]

Three quick questions about dive uploads on Subsurface-mobile.

1) When opening Subsurface-mobile, the last dive trip is highlighted. In 
my case these trips were created on the Linux desktop and stored in the 
cloud. Consequently, when I download dives to the mobile phone they are 
stored under the last trip. I cannot find a way to get downloaded dives 
in the dive list ABOVE the last trip.


2) I cannot see how to create a trip for the newly downloaded dives in 
order to group them together. The context menu does not appear to 
provide such an option.


3) Newly downloaded dives are all show as "dive number 0". Is there, 
within the mobile app, a way to renumber dives in the dive list?


Any help is appreciated.

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Videocasts for Subsurface user support

[Willem Ferguson via subsurface]

Below is a link to a concept for making a few videocasts as a user 
support mechanism for Subsurface.


Give attention to the general approach and way of communication.

And please comment as this will help me decide how to do this in future.


https://www.dropbox.com/s/8le0m3gc0a9b39b/bluetooth.mp4?dl=0


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: releasing Subsurface-mobile 3.0 on Android

[Willem Ferguson via subsurface]

On 2020/03/30 22:05, Dirk Hohndel wrote:



  But trying it with the undo/redo submenu now appears
to work ok for me sometimes. The ideosyncracy is that sometimes the
submenu only has 2 items: undo and redo. In that case there appears
to
be no problem and I can quit with BACK. But in other cases 7 items
appear without me doing any editing on the dive contents. < Remove
dive
from trip (at top)  Redo (at bottom). In that case when I hit
the
Android BACK button, the undo/redo submenu is not closed. If I hit
the
BACK button a 2nd time then Subsurface (as it should) quits. In some
cases I can select the redo/undo from the dive list and then there
are
omly two options. In other cases, when I select the undo/redo on the
dive list, it opens the screen with the dive profile and then opens
a
7-option submenu. When I select undo/redo  from the dive list
immediately after startup, I get a 2-item submenu.


See the screencast at:

https://www.dropbox.com/s/olji337v2bw6mqy/20200331_094957.mp4?dl=0

Here is the context. There are three parts:


1) I open the dive list and hit the undo/redo button from the dive list

The undo/redo button opens. Ok so far.

I close the undo menu using the BACK button. The submenu closes correctly.


2) I select another dive in the dive list. This opens the dive 
info/profile panel.


I select the undo/redo button.

Then I try to close it using the BACK button.

This adds three more options to the undo/redo menu but does not close 
the submenu.


I then close it using the proper X button on the left.

This shows the dive list as expected.


3) I hit the undo/redo button *without selecting a different dive*.

The undo/redo submenu opens.

I hit the BACK button and the submenu closes as expected.


This may mean that some tweak is needed when the undo/redo menu is 
opened from the dive info/profile panel.


But the puzzling part is why 3 options are added to the undo menu when 
the BACK button is pressed.




Thanks for that. Obviously a bug, I'll look into that later today.

You must have looked at this because with this version (1277) the 
numbers correspond to those calculated in Subsurface Linux Desktop.


No issue that I can see.


Kind regards,

willem





--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: more fixes in 3.0.2

[Willem Ferguson via subsurface]

On 2020/03/30 21:06, Dirk Hohndel wrote:

On Sun, 2020-03-29 at 16:05 +0200, Willem Ferguson via subsurface
wrote:

One final moan. I attach a screenshot of a dive with a rather long
location title. The text overlap with the date/time is obvious. I do
not
know if there is a solution for this.


This is also fixed in 3.0.2 / 4.9.3.1263

I removed the rather redundant 'map it' button (there are two other
ways to get to the map - tap on the location text or tap on the left
action button) and made sure that the layout happily deals with
location texts of four or five lines...

/D

I was rather tentative with this observation. After all one cannot 
accommodate a title that is 500 characters long. Where should one draw 
the margin? My dive location text was unnecessary long as a lot of the 
same information is captured in the trip title.


Kind regards,

willem.



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: releasing Subsurface-mobile 3.0 on Android

[Willem Ferguson via subsurface]

Here are a few comments on V4.9.3.1258.

On 2020/03/30 00:03, Dirk Hohndel wrote:

Productive day here so far


On Sun, 2020-03-29 at 11:14 -0700, Dirk Hohndel via subsurface wrote:

Upon activating the software,  I get a message "No dives in dive
list"

It would make much more sense if the message said something like
"preparing the dive list".


Yes, please do that. Just "Loading dive list"


That should work in the beta.


When I tap the filter button, nothing happens.

This works perfectly now. Excellent!

One other issue:
When opening the Undo/Redo menu and I select the Android Return
button
(NOT the X-button the left of the Undo/Redo menu), I exit
Subsurface-mobile. This is counter-intuitive. Upon hitting the
Android
RETURN button, it should just close the Undo/Redo menu. This
should
probably apply to all submenus
By RETURN you mean the back arrow?
Yeah, that's definitely a bug.

Also fixed in the beta.

Hitting the Android BACK button still exits Subsurface.

In the new build I could not repeat the problem with unwanted cloud sync 
of dive logs.



Dive site editing while editing dive information. I hit the pencil icon 
while a dive profile is showing. Editing the dive location is a mess. I 
tried to remove some of the text and ended up with gibberish. I suspect 
it is a case where the screen pointer and the internal text pointer do 
not point at the same place in the text field. See the screen movie at


https://www.dropbox.com/s/ucss7bqtc7mdnp6/20200330_133215.mp4?dl=0

I suspected that the text editing would in general would be problematic, 
but I could not find similar problems when editing the dive notes, only 
while editing the dive location. I tested most of the other input fields 
in the dive edit screen and everything else appeared ok.


In the dive summary screen, the Avg SAC (when all dives are used) gives 
a zero or a negative value for both columns of results. The other SAC 
values displayed appear ok.


After editing a dive and exiting to the dive list: when I select, from 
the list, a different dive to view, the Android keyboard comes up in 
front of the dive information. Disabling the keyboard by hitting the 
Android BACK button only disables the keyboard for a few seconds, then 
the keyboard reappears. Frustrating. Restarting Subsurface removes the 
problem.


Kind regards,

willem











--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Switching dive computers

[Willem Ferguson]

On 2020/03/05 15:26, Linus Torvalds wrote:

Hmm. It worked for me with top-of-tree as of a few days ago.

Did you try different keyboard focus points? That's what had broken 
for us before (ie focus on the info window rather than the profile 
window or whatever)


    Linus


On Thu, Mar 5, 2020, 04:03 Miika Turkia > wrote:


Hello,

Seems that switching between dive computers is no longer possible
with left and right arrows. Regression or intentional? Tested with
4.8.4-1865-g9f8d593

miika
___

Miika, The current version is (or very recently was) 4.9.3-1026. Is your 
version correct 4.8.4-1865 ??


With my copy of the software there is no problem.

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: load-git and event parsing

[Willem Ferguson]

On 2020/02/15 20:42, Linus Torvalds wrote:

On Sat, Feb 15, 2020 at 10:35 AM Willem Ferguson
 wrote:

I built the latest master and the translation of dive mode changes appeared 
perfect. There was a warning message

"git-load: string marker after running out of strings ('description')"

I saved the git dive log but on reopening the same dive log the warning 
appeared again.

Hmm. I had that bug at one point, but I fixed it - and I verified that
it's fixed in current master.

But maybe you hit a different case.

I wish we had some easier way to pass git repositories around for
testing (even just a "can you just make it public on github" or
something)

Let me go stare at the description cases. Maybe there's some special
case I was missing.

 Linus


This hardly affects the utility of the software. In the long term one 
would try not to generate unnecessary warnings. I will help where I can 
but I am diving for the next week (doing lots of dive mode changes !!) 
and am not sure of the quality of my connections over there. But please 
communicate to my gmail address (fergusonwil...@gmail.com) if there is 
anything I could help with. I feel a special obilgation to help here 
because you and Robert are sorting out a mess that I created, something 
that I am immensely thankful for.


Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: load-git and event parsing

[Willem Ferguson]

On 2020/02/15 18:31, Dirk Hohndel wrote:

Which 'diff' did you apply? The first one posted to the mailing list wasn't 
perfect :-)

Can you just build current master and try again?

Thanks

/D


n Feb 15, 2020, at 5:42 AM, Willem Ferguson  
wrote:

Hallo Linus, Robert,


Applying Linus's diff file to my repository changes the icon for a dime mode 
change from a red flag (general dive event) to a yellow triangle (warning). See 
attached image.

I attach a small dive log with two pSCR rebreather dives involving dive mode 
changes.

Kind regards,

Willem


I built the latest master and the translation of dive mode changes 
appeared perfect. There was a warning message


"git-load: string marker after running out of strings ('description')"

I saved the git dive log but on reopening the same dive log the warning 
appeared again.


This is probably finger trouble, not knowing exactly how the software 
behaves now.


Kind regards,

willem


--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Proposal: mobile menu system

[Willem Ferguson]

The Mobile menu system is getting quite complex and if the developer 
options are enabled all the options often do not fit onto a smartphone 
screen. Would it make sense to reorganise the main menu?


An obvious improvement is to get all the dive list operations together. 
These are: 1) Copy dive list to clipboard; 2) Map; 3) Dive summary. [(4) 
Export???]. Ideally these options should be available from the dive list 
itself. A possibility is the right-hand part of the banner at the top of 
the dive list. That would be the most intuitive way. The not-so-perfect 
alternative is to insert them as items on a new main menu item, "Dive 
list tools"


Maybe the Export option could be part of the Dive Management menu? Would 
Copy dive list to clipboard fit better here?


The About screen contains very little useful information. The software 
version has been removed and I cannot find it in the App log. Would it 
make sense to move the About screen to the Help menu?


Kind regards,

Willem.




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Letting Subsurface see Qt

[Willem Ferguson]

I am setting up a subsurface build environment in Fedora 31. The src 
directory contains Qt 5.12 in a directory called Qt. My subsurface build 
aborts immediately, complaining that the build script cannot find qt. 
What is the appropriate action?


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Qt new style signals/slots

[Willem Ferguson]

On 2020/01/19 08:14, Dirk Hohndel wrote:

On my phone.
The first 'this' is wrong. That needs to be the address of the 
specific qdatetomeedit in the UI.

My mistake

/D

On January 18, 2020 9:32:43 PM PST, Willem Ferguson 
 wrote:


On 2020/01/18 21:32, Dirk Hohndel wrote:

Hi Willem,


On Jan 18, 2020, at 3:48 AM, Willem Ferguson
mailto:willemfergu...@zoology.up.ac.za>> wrote:

My formulation, reflecting my strong deficiencies in Qt coding
but following the above, for the new connection is:

connect(this,
ui.timeDiffEdit->timeChanged(ui.timeDiffEdit->time()),this,
this->timeDiffEditChanged());

The second parameter needs to be a pointer, for which I used
ui.timeDiffEdit. The timeChanged() signal needs a QTime value,
so I provided that with ui.timeDeffEdit->time(), the actual
amount of time by which the timeDiffEdit has been changed.

The last parameter also needs an address, provided by
this->timeDiffEditChanged() is the response to the signal
fromtimeDiffEdit->timeChanged(). It is a void function and the
source of build problems. The compiler generates an error:

/home/willem/src/subsurface/desktop-widgets/importgps.cpp:30:104:
error: invalid use of void expression
connect(this,
ui.timeDiffEdit->timeChanged(ui.timeDiffEdit->time()), this,
this->timeDiffEditChanged());
^

Obviously, accessing the pointer this->timeDiffEditChanged()
should not return a void value. I have no idea of how to respond
to this error. Any suggestions are very welcome.




How about

connect(this, ::timeChanged, this,
::timeDiffEditChanged);

That seems like it would follow the syntax suggested above, right?

/D


Thank you very much for your time.

For Dirk's suggestion I get:

/home/willem/src/subsurface/desktop-widgets/importgps.cpp: In
constructor ‘ImportGPS::ImportGPS(QWidget*, QString,
Ui::LocationInformation*)’:
/home/willem/src/subsurface/desktop-widgets/importgps.cpp:30:78:
error: no matching function for call to
‘ImportGPS::connect(ImportGPS*, void (QDateTimeEdit::*)(const
QTime&), ImportGPS*, void (ImportGPS::*)())’
  connect(this, ::timeChanged, this,
::timeDiffEditChanged);
^

I suspect this means that there is a problem in the types of
parameters in the call to connect() ??

For Bill's formulation there is an apparent problem with the
signal part of the call to connect():

/home/willem/src/subsurface/desktop-widgets/importgps.cpp:31:88:
error: invalid use of non-static member function ‘void
QDateTimeEdit::timeChanged(const QTime&)’
  connect(ui.timeDiffEdit, ui.timeDiffEdit->timeChanged, this,
this->timeDiffEditChanged)
^
I just do not know how to proceed.

Kind regards,

willem



This message and attachments are subject to a disclaimer.
Please refer to
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf>
for full details.


--
From my phone 


Problem solved, thank you very much. The final formulation is:

connect(ui.timeDiffEdit, ::timeChanged, this, 
::timeDiffEditChanged);


I appreciate your time.

Kind regards,

willem







--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Qt new style signals/slots

[Willem Ferguson]

On 2020/01/18 21:32, Dirk Hohndel wrote:

Hi Willem,

On Jan 18, 2020, at 3:48 AM, Willem Ferguson 
<mailto:willemfergu...@zoology.up.ac.za>> wrote:


My formulation, reflecting my strong deficiencies in Qt coding but 
following the above, for the new connection is:


connect(this, 
ui.timeDiffEdit->timeChanged(ui.timeDiffEdit->time()),this, 
this->timeDiffEditChanged());


The second parameter needs to be a pointer, for which I used 
ui.timeDiffEdit. The timeChanged() signal needs a QTime value, so I 
provided that with ui.timeDeffEdit->time(), the actual amount of time 
by which the timeDiffEdit has been changed.


The last parameter also needs an address, provided by 
this->timeDiffEditChanged() is the response to the signal 
fromtimeDiffEdit->timeChanged(). It is a void function and the source 
of build problems. The compiler generates an error:


/home/willem/src/subsurface/desktop-widgets/importgps.cpp:30:104: 
error: invalid use of void expression
connect(this, ui.timeDiffEdit->timeChanged(ui.timeDiffEdit->time()), 
this, this->timeDiffEditChanged());

^

Obviously, accessing the pointer this->timeDiffEditChanged() should 
not return a void value. I have no idea of how to respond to this 
error. Any suggestions are very welcome.





How about

connect(this, ::timeChanged, this, 
::timeDiffEditChanged);


That seems like it would follow the syntax suggested above, right?

/D


Thank you very much for your time.

For Dirk's suggestion I get:

/home/willem/src/subsurface/desktop-widgets/importgps.cpp: In 
constructor ‘ImportGPS::ImportGPS(QWidget*, QString, 
Ui::LocationInformation*)’:
/home/willem/src/subsurface/desktop-widgets/importgps.cpp:30:78: error: 
no matching function for call to ‘ImportGPS::connect(ImportGPS*, void 
(QDateTimeEdit::*)(const QTime&), ImportGPS*, void (ImportGPS::*)())’
  connect(this, ::timeChanged, this, 
::timeDiffEditChanged);

^

I suspect this means that there is a problem in the types of parameters 
in the call to connect() ??


For Bill's formulation there is an apparent problem with the signal part 
of the call to connect():


/home/willem/src/subsurface/desktop-widgets/importgps.cpp:31:88: error: 
invalid use of non-static member function ‘void 
QDateTimeEdit::timeChanged(const QTime&)’
  connect(ui.timeDiffEdit, ui.timeDiffEdit->timeChanged, this, 
this->timeDiffEditChanged)

^
I just do not know how to proceed.

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Qt new style signals/slots

[Willem Ferguson]

Following excellent review of a recent PR, I was asked to update the 
conventional string-based Qt connections to the new-style Qt 
connections. (https://wiki.qt.io/New_Signal_Slot_Syntax) The old style is:


connect(
sender, SIGNAL( valueChanged( QString, QString ) ),
receiver, SLOT( updateValue( QString ) )
);

My old-style connection is:

connect(ui.timeDiffEdit, SIGNAL(timeChanged(const QTime)), this, 
SLOT(timeDiffEditChanged()));


For the new style the specification in the Qt documentation is:

connect(
sender, ::valueChanged,
receiver, ::updateValue
);

My formulation, reflecting my strong deficiencies in Qt coding but 
following the above, for the new connection is:


connect(this, 
ui.timeDiffEdit->timeChanged(ui.timeDiffEdit->time()),this, 
this->timeDiffEditChanged());


The second parameter needs to be a pointer, for which I used 
ui.timeDiffEdit. The timeChanged() signal needs a QTime value, so I 
provided that with ui.timeDeffEdit->time(), the actual amount of time by 
which the timeDiffEdit has been changed.


The last parameter also needs an address, provided by 
this->timeDiffEditChanged() is the response to the signal 
fromtimeDiffEdit->timeChanged(). It is a void function and the source of 
build problems. The compiler generates an error:


/home/willem/src/subsurface/desktop-widgets/importgps.cpp:30:104: error: 
invalid use of void expression
connect(this, ui.timeDiffEdit->timeChanged(ui.timeDiffEdit->time()), 
this, this->timeDiffEditChanged());

^

Obviously, accessing the pointer this->timeDiffEditChanged() should not 
return a void value. I have no idea of how to respond to this error. Any 
suggestions are very welcome. For completeness I attach the code for the 
full object to this email.


Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
// SPDX-License-Identifier: GPL-2.0
#include "ui_importgps.h"
#include "desktop-widgets/importgps.h"
#include "desktop-widgets/locationinformation.h"
#include "core/dive.h"

#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 

#define BUFFER_SIZE 5000

/* Import dive coordinates from a GPS device and synchronise them with the dive profile information
   of a dive computer. This file contains the infrastructure to:
   1) Read a .GPX file from a GPS system.
   2) Find the first gpx trackpoint that follows after the start of the dive.
   3) Allow modification of the coordinates dependent on international time zone and
  on differences in local time settings between the GPS and the dive computer.
   4) Saving the coordinates into the Coordinates text box in the Dive Site Edit panel
  and which which causes the map to show the location of the dive site. 
   The structure coords is used to store critical information.  */
ImportGPS::ImportGPS(QWidget *parent, QString fileName, class Ui::LocationInformation *LocationUI) : QDialog(parent),
	fileName(fileName), LocationUI(LocationUI)
{
	connect(this, ui.timeDiffEdit->timeChanged(ui.timeDiffEdit->time()), this, this->timeDiffEditChanged());

//	connect(ui.timeDiffEdit, SIGNAL(timeChanged(const QTime)), this, SLOT(timeDiffEditChanged()));
	connect(ui.timeZoneEdit, SIGNAL(timeChanged(const QTime)), this, SLOT(timeZoneEditChanged()));
	connect(ui.timezone_backwards, SIGNAL(toggled(bool)), this, SLOT(changeZoneBackwards()));
	connect(ui.timezone_forward, SIGNAL(toggled(bool)), this, SLOT(changeZoneForward()));
	connect(ui.diff_backwards, SIGNAL(toggled(bool)), this, SLOT(changeDiffBackwards()));
	connect(ui.diff_forward, SIGNAL(toggled(bool)), this, SLOT(changeDiffForward()));
	connect(ui.GPSbuttonBox, SIGNAL(clicked(QAbstractButton *)), this, SLOT(buttonClicked(QAbstractButton *)));
	coords.settingsDiff_offset = 0;
	coords.timeZone_offset = 0;
	coords.lat = 0;
	coords.lon = 0;
	pixmapSize = (int) (ui.diveDateLabel->height() / 2);
}

void  ImportGPS::buttonClicked(QAbstractButton *button)
{
	if (ui.GPSbuttonBox->buttonRole(button) == QDialogButtonBox::AcceptRole) {
		// Write the coordinates in decimal degree format to the Coordinates QLineEdit of the LocationaInformationWidget UI:
		LocationUI->diveSiteCoordinates->setText(QString::number(coords.lat) + ", " + QString::number(coords.lon));
		LocationUI->diveSiteCoordinates->editingFinished();
	} else {
		close();
	}
}

// Extract text from the present position in the file until
//  the first 'delim' character is encountered.
int ImportGPS::get_substring(FILE *f, char *buf, char delim)
{
	int j;
	char c;
	for (j = 0; (c = fgetc(f)); j++) {
		if (c == delim) break;
		if (c == EOF) return 1;
		buf[j] = c;
		if (j >= BUFFER_SIZE)
			return 2;
	}
	buf[j] = 0x0; // terminate the string
	return 0;
}

// Find the next occurence of a specified GPX element in the file,
// characerised by a "" 

Invalid dives

[Willem Ferguson]

Berthold submitted a PR for invalidating dives e.g. pool dives or demo 
dives of other people, maybe even snorkel dives. I do not see the PR on 
the list of PRs any more. That means this has been merged into Master?? 
For the user manual I need information about how to mark a dive as 
invalid and how invalid dives are presented in the dive list.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Mark dives as invalid (was Re: Questions about obscure preferences)

[Willem Ferguson]

On 2019/12/13 15:49, Berthold Stoeger wrote:

2) Mark invalid dives, an option currently in the General preferences

tab.
Apparently one can mark dives as invalid (maybe pool dives or equipment
test dives??). How does one do this? The user manual has nothing useful.

I'm not sure if that functionality ever made it into the Qt ui. It was
there in the GTK+ version.

Indeed the basic implementation is rather trivial as shown in github PR #2440.
https://github.com/Subsurface-divelog/subsurface/pull/2440

What is still needed is a proper UI and some fine-tuning concerning the
interaction with the rest of the system. E.g. the planner.

If you have interest in marking dives as invalid (for example pool or
equipment test dives mentioned by Willem above), please speak up now, as Dirk
finds this a "very strange concept". ;)

Berthold


Even though I would probably not use this feature one should think of 
the utility of the software to the broader user base. The only obvious 
case is an instructor or some other professional who spends significant 
time in a rather deep pool (ours is 7m). There must have been a reason 
it was implemented in the GTK version of Subsurface? If some survey of 
user demand for this feature is done I would recommend sending it also 
to those that sent the google groups or developer mail list some 
inquiries about such a feature.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Questions about obscure preferences

[Willem Ferguson]

On 2019/12/11 23:50, Martin de Weger wrote:

Hi Willem,

I think I have figured out how the georeference facility does work (at 
least, this is what I see on my Mac).


I have set the Geo reference in my settings to the way I want to 
display the location (eg country, city).


In the Tap Dive sites I click on the icon in the first row of a dive 
site with coordinates stored, this is the edit button. In the next 
screen, behind the coordinates is a button. If I press that, it will 
put the location info below the coordinates.


Hope this makes sense. If not, I can try to clear things up with 
either screenshots or a clip.



Met vriendelijke groeten,

Martin de Weger


I figured it out at last.

Thank you very much for your time, Martin.

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Questions about obscure preferences

[Willem Ferguson]

In my work with the preferences code, I cam across two issues that have 
some unclarity.


1) The Georeference facility. I have never seen it in action. The user 
manual states that if one clicks on the map widget, georeferencing 
information is generated. It appears that I cannot get it working, 
probably resulting from finger trouble. I want to put a sentence or two 
of explanation in the preference tab that deals with georeferences. Does 
anyone have more information that I can put in the user manual and on 
the georeference preferences tab?


2) Mark invalid dives, an option currently in the General preferences 
tab. Apparently one can mark dives as invalid (maybe pool dives or 
equipment test dives??). How does one do this? The user manual has 
nothing useful.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

COMMENTS, PLEASE: Proposal for restructured preferences UI

[Willem Ferguson]

Following the discussion on this topic I have written code for a 
new-look preferences UI. If you can build Subsurface, load the 
repository at https://github.com/willemferguson/subsurface.git and the 
branch preferences1 and give me comments, please. The object is NOT to 
look at the code at all. Look at the implementation, the look-and-feel 
and the intuitiveness of the UI.


This is an extraordinarily difficult project to do in small commits. 
This is because so many parts of the code are interconnected and cannot 
compile without a full implementation to achieve a specific 
sub-objective. The work is divided into six commits. The work is not 
complete and still needs substantial attention from my side.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

RFC: Preferences UI changes

[Willem Ferguson]

I am wondering whether there is a need to reorganise the Preferences 
settings to make it more user friendly. Currently there are three main 
weaknesses of the Preferences UI:


1) Preference settings are in obscure places. For instance "Show unused 
cylinder in Equipment tab" is under the Profile settings and "Default 
cylinder is under the  general settings.


2) The examples above show that related preferences (in this case 
cylinder use) are located in different tabs. Other case is the settings 
relating to Media thumbnails (Profile tab) and ffmpg settings for video 
thumbnails (General settings).


3) Some settings are not clear and actually obscure to the person not 
understanding the UI. For instance "Reset dive computers" on the main 
tab actually relates to dive downloads from dive computers and the 
"Import from dc" main menu item. The two Clear Settings preference item 
needs to be split, appearing on different tabs.


The current interface is difficult to operate for those not conversant 
with the history of this interface and who has not read the user manual 
in detail. We need a Preferences UI that is much more intuitive.


I do not think that the following preferences tabs need change. They are 
very specific and currently focus on single topics.


Units, Language, Georeferences, Network.

Although I do not use the Georeferences facility, it is probably very 
useful and effort should probably go into making that a more-frequently 
used facility by adding some text or other help that facilitates its use.


I see no use for the General Preferences tab as it is unspecific and 
actually makes the preferences UI more difficult to work.


My proposal is to create several more tabs on the lefthand of the 
Preferences panel, yielding a total of maybe up to 12 or 15 items. Items 
that should feature on the tab list on the LH side of the Preferences UI 
should probably be:


Dive log (e.g. default divelog location and dive log name)

Display (e.g. font, animation speed)

Equipment (e.g. cylinder-related matters)

Import from dc

Media

The Cloud settings are currently a frequent source of user problems and 
maybe that should be locatable by its own tab.


Clear settings to default

The current Profile tab should probably be renamed Tech diving 
preferences or something similar. I would remove the section with Misc 
settings.


An obvious aspect that needs attention is that, if the number of tabs 
increase, several may only have one or two settings as is currently the 
case with the Georeferences tab. This may appear to waste the efficiency 
of presenting preferences information. An obvious possibility is to keep 
preferences for more than one tab on a single page. For instance the 
preferences for Cloud and Proxy may remain on a single panel as they 
currently are. Selecting the Cloud icon on the lefthand side opens the 
appropriate tab (with both Proxy and Cloud preferences), but highlights 
the Cloud preferences in some way, maybe using a blue frame. In such a 
case more than one icon on the lefthand side may actually open the same 
tab, but each highlighting its own particular setting(s).


The overall objective is to make the preferences as easy as possible for 
uninitiated users. Upon entering the Preferences UI, the user should be 
able to locate the appropriate preference rapidly. I would probably try 
to enable a clickable link with each setting that opens the user manual 
at the appropriate text.


Any suggestions?

Kind regards,

willem









--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

RFC: Subsurface Statistics tab

[Willem Ferguson]

Attached a screenshot of a concept of rearranging the statistics tab. 
The old design was not space efficient. This one provides all the 
information in the statistics tab of the present master. Important thing 
is that it frees a fairly large area at the bottom of the tab. The plan 
is to use this for more detailed graphical analyses such as bar charts 
of continuous variables and pie charts of categorical variables. The 
text box on the right with gas consumption information gets a scroll bar 
when the tab is made more narrow. Sometimes, with deco dives having 5 or 
6 gases, the text in the text box can exceed the depth of the  box. In 
this case a scroll bar appears and allows viewing all the text.


Would this be workable at all?

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Translations in Information tab

[Willem Ferguson]

During interactions with Stefan and Martin it became clear that I should 
have given much more attention to the translatability of this tab. In 
the .cpp files this is easy, but I do not understand how the strings 
defined in the .ui files are translated, e.g. where there is a section like:


  
    Date
  

Any comments?

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Subsurface Info tab: star widgets and water type/density

[Willem Ferguson]

Two issues:

1) With respect to the proposed star widgets (for current, surface 
waves, surge and chill) that I had for the Information tab, there was 
discussion on what to do with those (see image below). Currently only 
the star widget for visibility is shown. During the previous discussions 
on this mail list there was broad support for these. However a few 
developers thought this was not necessary. Dirk though that perhaps the 
star widget for current should be kept.


My proposal is to keep the star widgets for current and for visibility, 
and to make the other three user selectable through the preferences 
settings with the default state being those three not being shown.


2) The water type/Density widget. Currently it is not editable because 
of serious misgivings about the utility of this being editable. If one 
considers a dive log as a type of dive diary then there is a need to 
accurately reflect the dive. And I reckon that almost all divers that 
dive both fresh and sea water at some stage forget to set their dive 
computers to the correct water type. In addition, for manually-entered 
dives there is no possibility to define the water density at all. It is 
possible to hand-edit the water density in the xml dive log and this is 
what I have done on those few occasions. In the interest of having a 
true reflection of a dive in the dive log I honestly think that there is 
a need to be able to edit the water density value. Therefore I propose 
that, at least under some circumstances, the water type/Density value is 
made editable. The possibility is that here as well, one could make this 
user selectable with the default state being that the editability is 
turned off.


Comments, please?

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Scaling of cylinder pressures in profile

[Willem Ferguson]

On 2019/11/11 11:38, Berthold Stoeger wrote:

On Montag, 11. November 2019 09:05:18 CET Willem Ferguson wrote:

There appears to be a bug in Subsurface. Check the attached dive log and
the rendering of cylinder pressures. Also see attached screenshot. I did
not notice this until now. Is it perhaps the last merge base don my PR
that causes this?

Funnily enough, this seems to be an old bug that now becomes active. Consider
this code in calculate_max_limits_new():

for (cyl = 0; cyl < MAX_CYLINDERS; cyl++) {
int mbar = dive->cylinder[cyl].start.mbar;
if (mbar > maxpressure)
maxpressure = mbar;
if (mbar < minpressure)
minpressure = mbar;
}

If you have less than MAX_CYLINDERS cylinders (i.e. in 100% of cases), mbar
will evaluate to 0. Thus, minpressure will be 0 in all cases. This code never
worked.

What happens now is that this part of the code actually starts to work. But if
you don't have an "air integrated" computer, you will not have pressure
readings,
But, for non-AI dives, you have start and end pressures for each 
cylinder, typed in manually. For AI dives (as far as I can make out), 
start and end pressures are evaluated by the software.

so minpressure will remain the minimum start-pressure of any of your
cylinders.

This appears to be the appropriate procedure.


That gives the funky effect you see.

Possibility 1: if minpressure == maxpressure (meaning that we found no
pressure reading), set minpressure to 0. This will restore the old behavior
for non-air integrated computers.

Possibility 2: correctly determine the minimum pressure by looking at the
profile data not the *events*.
I think the profile data are actually used to initialise the min and max 
pressures for an instrumented cylinder and it might therefore not be 
necessary to inspect the actual cylinder pressure values during the 
dive. Which events do you refer to here? Gas change events? I know for 
some dive computers an automatic gas change event is created right at 
the start of the dive.


Is it necessary that the loop should go all the way to MAX_CYLINDERS ?? 
Surely, if there are only two cylinders then it could stop at an index 
of 1 ?? The question, of course, is how would dives behave that have 
some pressure for one or 2 cylinders but no pressure data for other. 
That is the situation that I am in with a sidemount configuration. Since 
I have only one sensor, I need to write the data for the second cylinder 
on my slate and then enter that by hand in the Equipment panel.


Kind regards,

willem









--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Scaling of cylinder pressures in profile

[Willem Ferguson]

There appears to be a bug in Subsurface. Check the attached dive log and 
the rendering of cylinder pressures. Also see attached screenshot. I did 
not notice this until now. Is it perhaps the last merge base don my PR 
that causes this?


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.













  



  


  


  






  


  


  


  


  


  countrytag: RSA additional name for site: Miller's Point, Simsontad, 
Cape Town  additional name for site: (Pyramid Rock, Simonstad) or (Miller's 
Point, Simonstad Cow sharks) 


  


  countrytag: Egypt(143) 
  


  


  countrytag: RSA 


  SubsurfaceWebservice 


  




  


  


  




  


  countrytag: RSA 


  






  countrytag: Egypt(149) 
  




  


  countrytag: RSA 




  






  countrytag: RSA 


  countrytag: Egypt(146) 
  


  


  countrytag: RSA 


  countrytag: Egypt(139) 
  


  


  SubsurfaceWebservice 


  countrytag: RSA
-30°11.320' 30°49.743' 


  


  


  


  






  


  countrytag: Mozambique 
  


  countrytag: RSA 


  


  countrytag: RSA 


  


  




  


  countrytag: RSA 


  countrytag: RSA 


  


  


  SubsurfaceWebservice 


  countrytag: Mozambique 
  


  SubsurfaceWebservice 


  countrytag: Egypt(140) 
  


  


  


  
  
  
  
  


  


  Wreck of 12m boat, the Altair, in about 40m of water, close to Puffin 
Dive Centre 
  


  SubsurfaceWebservice 


  




  countrytag: RSA 


  


  


  countrytag: Tanzania 
  


  


  countrytag: RSA 


  




  countrytag: Egypt(138) 
  


  SubsurfaceWebservice 


  


  


  


  countrytag: RSA 


  


  countrytag: RSA 




  countrytag: RSA 




  


  




  








  


  




  


  countrytag: Tanzania 
  


  




  


  


  


  


  


  countrytag: RSA 


  




  


  


  countrytag: Egypt(133) 
  


  countrytag: RSA 


  




  


  


  SubsurfaceWebservice 


  countrytag: RSA 


  countrytag: Egypt(152) 
  


  countrytag: Mozambique 
  


  countrytag: Tanzania 
  


  countrytag: RSA 


  


  


  


  




  




  SubsurfaceWebservice 


  


  countrytag: Tanzania 
  


  SubsurfaceWebservice 


  


  countrytag: RSA 


  countrytag: RSA 


  


  


  countrytag: Mozambique 
  


  


  countrytag: RSA 
  
  
  
  
  


  countrytag: RSA 


  countrytag: RSA 




  


  countrytag: RSA 


  


  SubsurfaceWebservice 




  




  countrytag: RSA 


  


  countrytag: Mozambique 
  


  


  countrytag: RSA 


  countrytag: Tanzania 
  


  SubsurfaceWebservice 


  


  


  SubsurfaceWebservice 


  countrytag: Egypt(148) 
  


  


  SubsurfaceWebservice 


  


  


  countrytag: Tanzania 
  




  


  SubsurfaceWebservice 


  countrytag: RSA 




  countrytag: Egypt(150) 
  


  countrytag: Tanzania 
  


  


  


  SubsurfaceWebservice 


  


  




  




  countrytag: RSA 


  countrytag: RSA 


  


  


  


  


  SubsurfaceWebservice 


  countrytag: RSA 


  countrytag: Tanzania 
  




  




  countrytag: RSA 














  countrytag: RSA 


  


  SubsurfaceWebservice 


  countrytag: RSA 


  countrytag: RSA 


  


  


  


  countrytag: Egypt(136) 
  






  


  countrytag: RSA additional name for site: Inner Edge, Aliwal Shoal, 
Umkomaas 


  countrytag: Egypt(144) 
  


  countrytag: Egypt(147) 
  


  


  countrytag: Egypt(135) 
  


  countrytag: RSA 


  countrytag: Egypt(151) 
  




  


  


  countrytag: RSA 


  countrytag: Egypt(142) 
  


  




  countrytag: RSA 


  countrytag: Tanzania 
  


  




  


  countrytag: RSA 


  


  
  
  
  
  


  countrytag: RSA 


  


  countrytag: Egypt(141) 
  


  


  


  


  countrytag: RSA 


  




  


  SubsurfaceWebservice 




  


  


  


  


  countrytag: Tanzania 
  




  


  SubsurfaceWebservice 




  


  


  


  






  










  countrytag: RSA 










  countrytag: RSA 




  


  SubsurfaceWebservice 








  countrytag: RSA 


  countrytag: Tanzania 
  


  
  
  
  
  


  


  countrytag: Tanzania 
  


  


  countrytag: Egypt(137) 
  


  






  SubsurfaceWebservice 


  countrytag: RSA 


  


  


  




  countrytag: Tanzania 
  




  


  


  


  


  







  Don Shirley IANTD 189
  Johan Ferguson
  5mm wetsuit, hoodie
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
 

Re: fundamental design issues with trips and dives

[Willem Ferguson]

On 2019/11/08 00:25, Dirk Hohndel wrote:

On Nov 7, 2019, at 2:02 PM, Linus Torvalds  
wrote:

On Thu, Nov 7, 2019 at 12:14 PM Berthold Stoeger
 wrote:

It doesn't have to. Just like you defined a proxy model on top of the
DiveListModel, one could implement a proxy model on top of the tree model that
"linearizes" it.

Maybe we should do that in general, even for the desktop case.

I don't think there is any major reason why the model should contain
all the dives. In many ways it would be much better if the model only
contains the *visible* dives, and we'd have a totally flat model,
where a trip (whether it's a collapsed header only, or the header for
a list of dives that has been exposed) is just a special model entry.

That would mean that we'd handle collapsing and exposing trips by just
removing/inserting the dives in the trip into that flat model.

IOW, get rid of the tree model entirely, and make that "proxy" model
be "the" model.

Yes, yes, we have this very clever code to keep dives selected even
when they're not visible. It's a pain. it's probably not worth it.

And it might be truly *lovely* for startup if we didn't populate the
whole model at all. For the git format, we could literally avoid even
parsing the dives that are in a collapsed trip and this not visible.

So we'd have a dive_table that isn't populated? That sounds entertaining.
And some magic code that figures out when we need a dive and then
quickly parses the information from git? But if loading XML we don't?
And statistics functions would trigger fully populating the dive_table?

Maybe it's the jet lag, but that sounds like a LOT of work and a lot of
new corner cases - and I'm not 100% sure what we'd gain.

I have only 640 dives in my dive list, so maybe that's not a good
benchmark, but even in a very low end VM with a single core and
not a lot of memory (2GB) I have never had issues with the Subsurface
startup speed on the desktop. Our mobile startup speed is terrible,
but that has other reasons.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


I would like to see retaining the feature of selecting a relatively 
large number of dives for manipulation, many more than what is shown 
on-screen at the time.


Given that, however, and as a totally separate issue, I must mention 
that selecting a long list of dives for the first time from the dive 
list currently is quite painfully slow, maybe around 6 sec. However, 
once a selection has been made, subsequent selections are relatively 
more fast. My guess is that, initially, not the whole dive list 
structure is loaded?


Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Feedback Subsurface-mobile 2.2.3 (4.9.3.258) for iOS

[Willem Ferguson]

On 2019/11/07 03:27, Dirk Hohndel wrote:

On Thu, Nov 07, 2019 at 12:42:51AM +0100, Dirk Hohndel wrote:

On Wed, Nov 06, 2019 at 02:22:59PM +0100, Dirk Hohndel wrote:

Ugh. Thanks. I had tested this at some point, but must have broken it again.

I would have been shocked had this "just worked". Stay tuned.

And because, well, because... I have this fixed, but I'm traveling.
And iTunesConnect refuses apps built with Xcore 11.2 (which I installed
before going on this trip), but downloading the 11.2.1 update that was
released yesterday from the hotel does not look promising...

Well, it took 2 hours. Internet is getting faster past midnight. So now at
2:25am I have submitted the new build for review - since it's just a minor
update with the same version number I hope that it will be pushed out
fairly quickly. By the time sane Europeans are awake, you should have it
waiting for you in TestFlight.

I might try getting some sleep now...

/D


Using subsurface-mobile 4.9.3.270 with android 7.1.1 on a Samsung J2

Manupulation of dive list much quicker than before, appears pretty 
efficient.


If I activate the filter, the filter text field at the top of the screen 
shows for about 250 ms, then disappears. Effectively filtering is not 
possible.


Kind regards,

willem


--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Water type in information panel

[Willem Ferguson]

The information contained within the tabs in the Subsurface Notes panel 
is currently undergoing reorganisation, so your request may have 
relevance. However, this is a topic with strongly differing sentiments 
among developers. So this depends on consensus among the developers. 
Let's see what happens as the reorganisation proceeds.

Kind regards,
willem


On 2019/10/24 13:50, tormento wrote:
Do you mind to introduce Water type selection into dive information 
panel such as the one in Plan dive?


There is no direct way to correct it but save to local file, edit XML 
and reimport it.


Thanks :)

/Alberto/

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Updating local git branch to latest master

[Willem Ferguson]

While I was away several weeks, several merges were done to master 
resulting my local system being old. I wish to update my system to 
current master.


If I say git pull or git pull origin, I get "Already up to date". 
However when I do git log it does not show any updates after my last 
commit 2 months ago.


Am I crazy?

Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: CNS calculation headaches - follow-up

[Willem Ferguson]

On 2019/08/10 22:09, Willem Ferguson wrote:

On 2019/08/10 20:30, Linus Torvalds wrote:



Just looking at that graph, I'd be comfortable using the 4th-order 
approximation for the valid range (ie pO2 of 0.6-1.6, which is what 
we have data points for).


I'd also think that the extensions _past_ that range look sane - BUT 
I think that if subsurface uses those extended areas, we should give 
a BIG BIG warning.


Comments?

                 Linus



Your plan could work because when pO2 < 0.5 no CNS calculation is 
made, so the part of the inaccuracy below 0.5 is irrelevant with 
respect to the algorithm for calculating CNS toxicity. However, the 
"bug report" we had about negative values highlights one issue: If 
people plan or log dives with pO2>1.6, how should one handle these 
badly-behaved data in terms of CNS so that a value as realistic as 
possible is reflected?


Kind regards,

willem


Here is a part of the deco for a sea dive. Although most of the depths 
are a tiny bit shallower than 6m, there are regular occurrences of pO2 
1.7 and 1.75. Of course there are also many values lower than 1.6. But 
as a diver I would like as realistic an assessment of CNS as possible.


Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: CNS calculation headaches

[Willem Ferguson]

On 2019/08/10 20:30, Linus Torvalds wrote:



Just looking at that graph, I'd be comfortable using the 4th-order 
approximation for the valid range (ie pO2 of 0.6-1.6, which is what we 
have data points for).


I'd also think that the extensions _past_ that range look sane - BUT I 
think that if subsurface uses those extended areas, we should give a 
BIG BIG warning.


Comments?

                 Linus



Your plan could work because when pO2 < 0.5 no CNS calculation is made, 
so the part of the inaccuracy below 0.5 is irrelevant with respect to 
the algorithm for calculating CNS toxicity. However, the "bug report" we 
had about negative values highlights one issue: If people plan or log 
dives with pO2>1.6, how should one handle these badly-behaved data in 
terms of CNS so that a value as realistic as possible is reflected?


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: CNS calculation headaches

[Willem Ferguson]

On 2019/08/10 17:04, Robert Helling wrote:

Willem,

On 10. Aug 2019, at 16:10, Willem Ferguson 
<mailto:willemfergu...@zoology.up.ac.za>> wrote:


An interesting alternative, Robert. I am not happy with the deviation 
at 1.5 and 1.6. One would have to check what the effect of these two 
points are on the power curve. What is the effect on the overall fit 
of the power curve if one omits those two points? What of a 3rd order 
polynomial that could in principle accommodate the inflection at 1.4? 
I am not averse to a mathematical solution because the linear 
interpolation also causes some inaccuracy.





here is the same on a log scale:



I would not be happy to fit this with a line for all points including 
the last two. Rather, I would use a new line for the last three points 
(and extrapolate that) for values above pO2=1.5bar.



Robert


Robert, I think we are making good progress here. The only real 
remaining question is what to do with pO2 values outside of the 
domain(s) of the function(s) used. My feeling is that the approach with 
the least error is to at least use a fixed value, e.g 1.65 for pO2 
values outside the domain. The CNS toxicity above 1.65 is highly 
unlikely to be less than that for 1.65. It is in fact expected to be 
more. I am not sure that omitting it is appropriate. I am worried about 
decompression at 6m which is right on that limit and which (at least in 
my case) often varies between 1.45 and 1.7, especially in the sea.


I am quite please the way this discussion has gone.

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: CNS calculation headaches

[Willem Ferguson]

On 2019/08/10 15:40, Robert Helling wrote:

Willem,

On 10. Aug 2019, at 15:19, Robert Helling > wrote:


PS: The original problem arose as the interpolated table value is 
used in the denominator of the cns += formula and would result in a 
pole when the extrapolated table value reaches 0. Maybe we should 
redo the whole thing and linearly interpolate the inverses of the 
table value rather than the table value. For those an extrapolation 
would be more sensible.


here is another idea: With the exception of the values above pO2 of 
1.5bar, a power law is actually a pretty good fit to the table:




This is exp(11.7853 - 0.00193873 pO2).

Maybe, we should give up the idea of the table entirely and use this 
power law instead?


Best
Robert


An interesting alternative, Robert. I am not happy with the deviation at 
1.5 and 1.6. One would have to check what the effect of these two points 
are on the power curve. What is the effect on the overall fit of the 
power curve if one omits those two points? What of a 3rd order 
polynomial that could in principle accommodate the inflection at 1.4? I 
am not averse to a mathematical solution because the linear 
interpolation also causes some inaccuracy.


And of course I like your graph because it is the right way round with 
time limit being the dependent variable. Baker's graph is the wrong way 
round.


I would also love to see what it will look like if one interpolates on 
inverses. But it does not in principle avoid the problem at pO2=1.65.


With respect to your idea of NOT calculating CNS when pO2 > 1.65, if I 
understand you correctly, the underestimate will be much higher if those 
points on the dive profile do not contribute to the total CNS toxicity. 
I think in the planner the solution is to incorporate whatever mechanism 
appears prudent and simply add a warning to the dive plan that the CNS 
value cannot be trusted because of the high pO2. In the dive log it is a 
different thing since the dive log has no way of adding system warnings 
except for the red banner at the bottom of the screen. I am not sure 
that a user would like to get past a red banner warning every time 
she/he views that dive.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Opening a local git repository

[Willem Ferguson]

After saving to a local git repository and hitting File in the main 
menu, I see the git repository listed under the recently-opened files an 
I can easily select it open it again. However, if I close down 
Subsurface and reactivate it again, the repository does not appear under 
the list of recently opened files. Moreover if I go File->open divelog 
and follow the path to the directory containing the git repo, of course, 
I cannot see the repo and I have no way to select it in order to open it.


Can anyone replicate this?

Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

CNS calculation headaches

[Willem Ferguson]

Robert, Linus,

The bug that that was encountered during dive planning by one of the 
users leads to an interesting point about the handling of dives that are 
not well-behaved, i.e. with pO2 above 1.6. The NOAA tables for 
calculating CNS toxicity only go up to a pO2 of 1.6. Above that our 
knowledge is so sparse that we do not really have a basis for 
calculating CNS toxicity. Using the standard algorithm, a negative CNS 
value is created when attempting to calculate CNS% at pO2 higher than 
1.65. Following the Shearwater web site, they implement a rule of "1% 
CNS for every 4 minutes above pO2=1.6". This means that, after 400 
seconds above pO2 of 1.6, an additional 100% of CNS is accrued. There 
are two problems.


1) The basis for using the Shearwater rule of 1% per 4s is unclear. I 
have read most of the literature around this (including Clark & 
Lambersen) and I admit I did not come across the 4s-1% generalisation. 
But the literature is really lengthy and I could easily have missed it. 
So I am note sure there is enough information available about CNS 
toxicity above 1.6 to really make any firm statement.


2) In diving practice there is a real problem. If I have 9 min of deco 
to do at 6m with oxygen I am right at the 1.6 pO2 limit. I might be in 
sea water at 6m, in which case I will be some 3% over the 1.6 limit. In 
this case I will accrue ~ 125% of CNS toxicity during my 9 min deco 
stop. This is blatantly not helpful and probably not realistic: using 
the 1%- 4s yard stick does not contribute to a sane CNS% value during 
that particular deco stop.


Assuming that Subsurface should attempt to take real dive conditions 
into account in which the pO2 may well exceed 1.6, the question is how 
to handle such cases since this is an unknown domain. One approach could 
be to treat all pO2 values > 1.65 as if it was at 1.65. In cases with 
pO2 above 1.65 this results in an underestimate of CNS%, but in the case 
of my deco stop at 6m it would be immensely more helpful than using a 
1%-4-minute thumb-suck.


Do you have any opinion?

Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Typo in CNS calculation

[Willem Ferguson]

On 2019/08/09 23:23, Robert Helling wrote:

Willem,

could you please have a look at the final computation in 
staticdoublecalculate_cns_dive(conststructdive*dive)

in divelist.c

It seems to me that the first minus in

cns+=(double)t/((double)cns_table[j][SINGLE_EXP]-((double)po2i-(double)cns_table[j][PO2VAL])*(double)cns_table[j][SINGLE_SLOPE]/10.0)*100;
should be plus (at least according to the formula in the comment above. At 
least, with this minus, you get negative CNS values for a planned air dive to 
80m of depth.
Best
Robert

The reason for the negative value is because the dive plan involves pO2 
values above 1.6bar (EAN38 at 35m=pO2 of 1.7bar). The NOAA tables do not 
provide values above pO2 = 1.6.


I am working on a sensible solution because we need a sensible approach 
for this use case.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface