Re: 5.0.9

2022-07-30 Thread Jason Bramwell via subsurface
The one thing that currently bugs me and may already be fixed since 5.0.8 was 
released is that the deco model on my OSMC isn’t being picked up and it instead 
reports as something else. As I say I think this has already been picked up but 
I’ve not yet tested a nightly build to confirm this is fixed.

Just wanted to flag this to ensure that this IS 100% included on the new 
release.

I’ll try and test a nightly tomorrow.

Jb

Sent from my iPhone

> On 30 Jul 2022, at 22:24, Dirk Hohndel via subsurface 
>  wrote:
> 
> 
> Hi there.
> 
> You may remember me.
> 
> The past six weeks have been pretty rough over here. A death in my family 
> derailed quite a few things, including all my time (and for a while, 
> motivation) to work on Subsurface.
> 
> I think / I hope that I'm back. And I'm back to hoping to do the 5.0.9 
> release "any day now".
> 
> Linus identified a really weird bug with cloudstorage that affected builds 
> with very recent libgit2 versions (1.2 or newer, I think). We should have 
> worked around this on the server (basically the newer versions of the library 
> throw up if HEAD points to an unborn reference). This only affected people 
> who used a version of Subsurface built against such a recent version of 
> libgit2 (Fedora 36, openSUSE 15.4), AND who tried to clone a cloud storage 
> repo for the first time. So people who upgraded and already had a checked out 
> version of their cloud repo weren't affected.
> 
> There are a few more small things that I'm checking, but I hope to get a 
> release out very soon.
> 
> All the best (and thanks to those of you who helped to keep the lights on 
> while I had disappeared).
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-07-30 Thread Dirk Hohndel via subsurface
Yes, I believe this is fixed - but please double check if you have the time.

commit 5f3a0f0b8a951030cbeb61b7b2d3416b02229bc7
Author: Michael Andreen 
Date:   Sun Apr 3 23:49:07 2022 +0200

OSTC: Use deco model instead of dive mode for deco model information

In the most recent merge deco model (byte 79) was swapped for divemode
(byte 82). This caused all OC dives to be classified as the older
algorithm without gradient factors.

Signed-off-by: Michael Andreen 

/D

> On Jul 30, 2022, at 2:31 PM, Jason wrote:
> 
> The one thing that currently bugs me and may already be fixed since 5.0.8 was 
> released is that the deco model on my OSMC isn’t being picked up and it 
> instead reports as something else. As I say I think this has already been 
> picked up but I’ve not yet tested a nightly build to confirm this is fixed.
> 
> Just wanted to flag this to ensure that this IS 100% included on the new 
> release.
> 
> I’ll try and test a nightly tomorrow.
> 
> Jb
> 
> Sent from my iPhone
> 
>> On 30 Jul 2022, at 22:24, Dirk Hohndel via subsurface 
>>  wrote:
>> 
>> 
>> Hi there.
>> 
>> You may remember me.
>> 
>> The past six weeks have been pretty rough over here. A death in my family 
>> derailed quite a few things, including all my time (and for a while, 
>> motivation) to work on Subsurface.
>> 
>> I think / I hope that I'm back. And I'm back to hoping to do the 5.0.9 
>> release "any day now".
>> 
>> Linus identified a really weird bug with cloudstorage that affected builds 
>> with very recent libgit2 versions (1.2 or newer, I think). We should have 
>> worked around this on the server (basically the newer versions of the 
>> library throw up if HEAD points to an unborn reference). This only affected 
>> people who used a version of Subsurface built against such a recent version 
>> of libgit2 (Fedora 36, openSUSE 15.4), AND who tried to clone a cloud 
>> storage repo for the first time. So people who upgraded and already had a 
>> checked out version of their cloud repo weren't affected.
>> 
>> There are a few more small things that I'm checking, but I hope to get a 
>> release out very soon.
>> 
>> All the best (and thanks to those of you who helped to keep the lights on 
>> while I had disappeared).
>> 
>> /D
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


RE: 5.0.9

2022-07-31 Thread Jason Bramwell via subsurface
I can confirm that this is indeed fixed with the latest nightly AppImage 
(5.0.8-63-g53fa568b90df).

Are the mobile apps and the desktop apps kept in sync or are these entirely 
separate as I think the mobile app also displays the same error. I’m using 
3.4.3 (5.0.6.83) on iOS

JB

Sent from Mail for Windows

From: Dirk Hohndel
Sent: 30 July 2022 22:41
To: Jason Bramwell
Cc: Subsurface
Subject: Re: 5.0.9

Yes, I believe this is fixed - but please double check if you have the time.

commit 5f3a0f0b8a951030cbeb61b7b2d3416b02229bc7
Author: Michael Andreen 
Date:   Sun Apr 3 23:49:07 2022 +0200

OSTC: Use deco model instead of dive mode for deco model information

In the most recent merge deco model (byte 79) was swapped for divemode
(byte 82). This caused all OC dives to be classified as the older
algorithm without gradient factors.

Signed-off-by: Michael Andreen 

/D

> On Jul 30, 2022, at 2:31 PM, Jason wrote:
> 
> The one thing that currently bugs me and may already be fixed since 5.0.8 was 
> released is that the deco model on my OSMC isn’t being picked up and it 
> instead reports as something else. As I say I think this has already been 
> picked up but I’ve not yet tested a nightly build to confirm this is fixed.
> 
> Just wanted to flag this to ensure that this IS 100% included on the new 
> release.
> 
> I’ll try and test a nightly tomorrow.
> 
> Jb
> 
> Sent from my iPhone
> 
>> On 30 Jul 2022, at 22:24, Dirk Hohndel via subsurface 
>>  wrote:
>> 
>> 
>> Hi there.
>> 
>> You may remember me.
>> 
>> The past six weeks have been pretty rough over here. A death in my family 
>> derailed quite a few things, including all my time (and for a while, 
>> motivation) to work on Subsurface.
>> 
>> I think / I hope that I'm back. And I'm back to hoping to do the 5.0.9 
>> release "any day now".
>> 
>> Linus identified a really weird bug with cloudstorage that affected builds 
>> with very recent libgit2 versions (1.2 or newer, I think). We should have 
>> worked around this on the server (basically the newer versions of the 
>> library throw up if HEAD points to an unborn reference). This only affected 
>> people who used a version of Subsurface built against such a recent version 
>> of libgit2 (Fedora 36, openSUSE 15.4), AND who tried to clone a cloud 
>> storage repo for the first time. So people who upgraded and already had a 
>> checked out version of their cloud repo weren't affected.
>> 
>> There are a few more small things that I'm checking, but I hope to get a 
>> release out very soon.
>> 
>> All the best (and thanks to those of you who helped to keep the lights on 
>> while I had disappeared).
>> 
>> /D
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-07-31 Thread Dirk Hohndel via subsurface
A draft announcement was pushed to GitHub if people have time to translate...


> On Jul 31, 2022, at 5:39 AM, Jason wrote:
> 
> I can confirm that this is indeed fixed with the latest nightly AppImage 
> (5.0.8-63-g53fa568b90df).

Awesome
 
> Are the mobile apps and the desktop apps kept in sync or are these entirely 
> separate as I think the mobile app also displays the same error. I’m using 
> 3.4.3 (5.0.6.83) on iOS

I'm not doing a great job keeping those updated. Will make new releases after 
5.0.9 is out

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-07-31 Thread Dirk Hohndel via subsurface
Subsurface 5.0.9 has now been released and the announcement has been posted.
Feel free to share elsewhere

All the binaries have been built, with the exception of some openSUSE binaries 
where it looks like I messed things up. I'll look into what I got wrong there 
and hopefully should have those up and building as well very soon.

Thanks for you patience - and to everyone who helped with code, bug reports, 
translations, supporting our users, and all the other things that you do. Much 
as it sometimes feels lonely where I sit - I couldn't do this without all of 
you.

As always, here's a shortlog; this of course exaggerates my contributions (so 
many small build system things and other random stuff), but it shows the 
roaring return of our hero to the #2 spot overall!

Thanks, Linus, for the continued help with Subsurface, with maintaining our 
flavor of libdivecomputer, and all the other help that you provide.

$ git shortlog -s -n v5.0.8..v5.0.9
52  Dirk Hohndel
 6  Linus Torvalds
 3  Robert C. Helling
 2  Michał Sawicz
 2  Berthold Stoeger
 2  Jon Massey
 1  Vlad A
 1  Jim Wobser
 1  Michael Andreen
 1  Anton Lundin

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-07-31 Thread Dirk Hohndel via subsurface
Fixed.

> On Jul 31, 2022, at 3:54 PM, Dirk Hohndel via subsurface 
>  wrote:
> 
> All the binaries have been built, with the exception of some openSUSE 
> binaries where it looks like I messed things up. I'll look into what I got 
> wrong there and hopefully should have those up and building as well very soon.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-07-31 Thread Jason Bramwell via subsurface
Many thanks for your continued efforts as always. 

I know what you mean about it being a bit lonely and I’m at a loss to 
understand why, there are plenty of IT people that are divers, i know in the UK 
GUE community we have a running joke that if you don’t know someone’s 
occupation there is an 80% chance that they work in some form of IT. You’d also 
think that having Linus on board would pull in some contributors too. I guess 
the IT world is very broad and some elements (like my own) are quite far away 
from coding, especially real coding like C/C++.

Jason

Sent from my iPhone

> On 31 Jul 2022, at 23:54, Dirk Hohndel via subsurface 
>  wrote:
> 
> Subsurface 5.0.9 has now been released and the announcement has been posted.
> Feel free to share elsewhere
> 
> All the binaries have been built, with the exception of some openSUSE 
> binaries where it looks like I messed things up. I'll look into what I got 
> wrong there and hopefully should have those up and building as well very soon.
> 
> Thanks for you patience - and to everyone who helped with code, bug reports, 
> translations, supporting our users, and all the other things that you do. 
> Much as it sometimes feels lonely where I sit - I couldn't do this without 
> all of you.
> 
> As always, here's a shortlog; this of course exaggerates my contributions (so 
> many small build system things and other random stuff), but it shows the 
> roaring return of our hero to the #2 spot overall!
> 
> Thanks, Linus, for the continued help with Subsurface, with maintaining our 
> flavor of libdivecomputer, and all the other help that you provide.
> 
> $ git shortlog -s -n v5.0.8..v5.0.9
>52  Dirk Hohndel
> 6  Linus Torvalds
> 3  Robert C. Helling
> 2  Michał Sawicz
> 2  Berthold Stoeger
> 2  Jon Massey
> 1  Vlad A
> 1  Jim Wobser
> 1  Michael Andreen
> 1  Anton Lundin
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-01 Thread Martin de Weger via subsurface
I couldn’t agree more with Jason. All the efforts the (small) team of 
developers are putting into this project is truly appreciated.

I just tried to download the latest stable build from the website but the DMG 
is 199 kB in size. It looks like the build failed. Also the link to the 
announcement of release of version 5.0.9 (on the Dutch version of the site) 
trows a 404 error.

Kind regards,

Martin de Weger

> Op 1 aug. 2022, om 08:49 heeft Jason Bramwell via subsurface 
>  het volgende geschreven:
> 
> Many thanks for your continued efforts as always. 
> 
> I know what you mean about it being a bit lonely and I’m at a loss to 
> understand why, there are plenty of IT people that are divers, i know in the 
> UK GUE community we have a running joke that if you don’t know someone’s 
> occupation there is an 80% chance that they work in some form of IT. You’d 
> also think that having Linus on board would pull in some contributors too. I 
> guess the IT world is very broad and some elements (like my own) are quite 
> far away from coding, especially real coding like C/C++.
> 
> Jason
> 
> Sent from my iPhone
> 
>> On 31 Jul 2022, at 23:54, Dirk Hohndel via subsurface 
>>  wrote:
>> 
>> Subsurface 5.0.9 has now been released and the announcement has been posted.
>> Feel free to share elsewhere
>> 
>> All the binaries have been built, with the exception of some openSUSE 
>> binaries where it looks like I messed things up. I'll look into what I got 
>> wrong there and hopefully should have those up and building as well very 
>> soon.
>> 
>> Thanks for you patience - and to everyone who helped with code, bug reports, 
>> translations, supporting our users, and all the other things that you do. 
>> Much as it sometimes feels lonely where I sit - I couldn't do this without 
>> all of you.
>> 
>> As always, here's a shortlog; this of course exaggerates my contributions 
>> (so many small build system things and other random stuff), but it shows the 
>> roaring return of our hero to the #2 spot overall!
>> 
>> Thanks, Linus, for the continued help with Subsurface, with maintaining our 
>> flavor of libdivecomputer, and all the other help that you provide.
>> 
>> $ git shortlog -s -n v5.0.8..v5.0.9
>>   52  Dirk Hohndel
>>6  Linus Torvalds
>>3  Robert C. Helling
>>2  Michał Sawicz
>>2  Berthold Stoeger
>>2  Jon Massey
>>1  Vlad A
>>1  Jim Wobser
>>1  Michael Andreen
>>1  Anton Lundin
>> 
>> /D
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-01 Thread Dirk Hohndel via subsurface


> On Aug 1, 2022, at 12:02 AM, Martin de Weger  > wrote:
> 
> I just tried to download the latest stable build from the website but the DMG 
> is 199 kB in size. It looks like the build failed.

It did fail in very odd ways - and it fooled my script into thinking that it 
worked.
I'm trying to debug this right now, before I have to focus on my day job. Not 
sure I'll get it fixed right away.

> Also the link to the announcement of release of version 5.0.9 (on the Dutch 
> version of the site) trows a 404 error.

That /should/ fall back to the English one. Dang.
Or someone could just create a Dutch translation. It's really easy :)

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-01 Thread Dirk Hohndel via subsurface



> On Aug 1, 2022, at 7:02 AM, Dirk Hohndel via subsurface 
>  wrote:
>> 
>> I just tried to download the latest stable build from the website but the 
>> DMG is 199 kB in size. It looks like the build failed.
> 
> It did fail in very odd ways - and it fooled my script into thinking that it 
> worked.
> I'm trying to debug this right now, before I have to focus on my day job. Not 
> sure I'll get it fixed right away.

That should be fixed. Thanks for reporting it!

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-01 Thread Dirk Hohndel via subsurface


> On Jul 31, 2022, at 10:35 AM, Dirk Hohndel via subsurface 
>  wrote:
>  
>> Are the mobile apps and the desktop apps kept in sync or are these entirely 
>> separate as I think the mobile app also displays the same error. I’m using 
>> 3.4.3 (5.0.6.83) on iOS
> 
> I'm not doing a great job keeping those updated. Will make new releases after 
> 5.0.9 is out

The Android app (3.4.6) is in the Beta channel.
You can join that right in the Google Play app - scroll to the bottom of the 
Subsurface-mobile page

The iOS app (3.4.6) has been submitted and is waiting for review, before it 
will land in the Beta channel.
You can join with this link https://testflight.apple.com/join/k2OGhIS5 


I have did rough testing (update cloud data, download from one BLE dive 
computer) with both of them, so nothing should be terribly broken.
I'm hoping to make those the official releases fairly quickly (and getting test 
reports - even a simple "I tried it, it didn't kill the kitten" - will 
obviously help me feel confident about this)

Thanks

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-01 Thread Martin de Weger via subsurface
Thanks, it has been fixed!

Kind regards,

Martin de Weger

> Op 1 aug. 2022, om 16:17 heeft Dirk Hohndel via subsurface 
>  het volgende geschreven:
> 
> 
> 
>> On Aug 1, 2022, at 7:02 AM, Dirk Hohndel via subsurface 
>>  wrote:
>>> 
>>> I just tried to download the latest stable build from the website but the 
>>> DMG is 199 kB in size. It looks like the build failed.
>> 
>> It did fail in very odd ways - and it fooled my script into thinking that it 
>> worked.
>> I'm trying to debug this right now, before I have to focus on my day job. 
>> Not sure I'll get it fixed right away.
> 
> That should be fixed. Thanks for reporting it!
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-01 Thread Dirk Hohndel via subsurface


> On Aug 1, 2022, at 11:07 AM, Dirk Hohndel via subsurface 
>  wrote:
> 
> 
> The iOS app (3.4.6) has been submitted and is waiting for review, before it 
> will land in the Beta channel.
> You can join with this link https://testflight.apple.com/join/k2OGhIS5 
> 
Thanks to a diligent tester I have learned that currently this link doesn't 
work. Googling for the reasons I have found out that it's the lack of "active" 
test build that prevents new people from joining.

So once the 3.4.6 build has been approved this should work again. I'll holler 
here once that's the case.

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-01 Thread Jason Bramwell via subsurface
Thanks, I’ll just sit tight and wait for this to get sorted from the Apple end 
and then that should let me have it, I can test this pretty easily.

Jb

Sent from my iPhone

> On 1 Aug 2022, at 20:51, Dirk Hohndel via subsurface 
>  wrote:
> 
> 
> 
>> On Aug 1, 2022, at 11:07 AM, Dirk Hohndel via subsurface 
>>  wrote:
>> 
>> 
>> The iOS app (3.4.6) has been submitted and is waiting for review, before it 
>> will land in the Beta channel.
>> You can join with this link https://testflight.apple.com/join/k2OGhIS5
> 
> Thanks to a diligent tester I have learned that currently this link doesn't 
> work. Googling for the reasons I have found out that it's the lack of 
> "active" test build that prevents new people from joining.
> 
> So once the 3.4.6 build has been approved this should work again. I'll holler 
> here once that's the case.
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-02 Thread Dirk Hohndel via subsurface
And a quick 30 hours after I submitted the build, it just got approved. And 
with that, the signup link for the beta also should work again:

https://testflight.apple.com/join/k2OGhIS5 


The Android binary is already available.

I'd appreciate some quick light testing from a few people, just so I know I 
didn't break anything too badly :)

Thanks

/D

> On Aug 1, 2022, at 1:19 PM, Jason  wrote:
> 
> Thanks, I’ll just sit tight and wait for this to get sorted from the Apple 
> end and then that should let me have it, I can test this pretty easily.
> 
> Jb
> 
> Sent from my iPhone
> 
>> On 1 Aug 2022, at 20:51, Dirk Hohndel via subsurface 
>>  wrote:
>> 
>> 
>> 
>>> On Aug 1, 2022, at 11:07 AM, Dirk Hohndel via subsurface 
>>> >> > wrote:
>>> 
>>> 
>>> The iOS app (3.4.6) has been submitted and is waiting for review, before it 
>>> will land in the Beta channel.
>>> You can join with this link https://testflight.apple.com/join/k2OGhIS5 
>>> 
>> Thanks to a diligent tester I have learned that currently this link doesn't 
>> work. Googling for the reasons I have found out that it's the lack of 
>> "active" test build that prevents new people from joining.
>> 
>> So once the 3.4.6 build has been approved this should work again. I'll 
>> holler here once that's the case.
>> 
>> /D
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-02 Thread Attilla de Groot via subsurface

Hi Dirk,

Updated on my Android. I can confirm you didn't kill any of my imaginary 
kittens.


-- Attilla

On August 3, 2022 02:27:04 Dirk Hohndel via subsurface 
 wrote:
And a quick 30 hours after I submitted the build, it just got approved. And 
with that, the signup link for the beta also should work again:


https://testflight.apple.com/join/k2OGhIS5

The Android binary is already available.

I'd appreciate some quick light testing from a few people, just so I know I 
didn't break anything too badly :)


Thanks

/D



On Aug 1, 2022, at 1:19 PM, Jason  wrote:

Thanks, I’ll just sit tight and wait for this to get sorted from the Apple 
end and then that should let me have it, I can test this pretty easily.


Jb


Sent from my iPhone

On 1 Aug 2022, at 20:51, Dirk Hohndel via subsurface 
 wrote:



On Aug 1, 2022, at 11:07 AM, Dirk Hohndel via subsurface 
 wrote:



The iOS app (3.4.6) has been submitted and is waiting for review, before it 
will land in the Beta channel.

You can join with this link https://testflight.apple.com/join/k2OGhIS5


Thanks to a diligent tester I have learned that currently this link doesn't 
work. Googling for the reasons I have found out that it's the lack of 
"active" test build that prevents new people from joining.


So once the 3.4.6 build has been approved this should work again. I'll 
holler here once that's the case.


/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-02 Thread Benjamin via subsurface
Loads all my current dives correctly (based on a random sample only). I'll
test the downloading and other functionality that i use this weekend :)

Benjamin

On Wed, 3 Aug 2022, 03:39 Attilla de Groot via subsurface, <
subsurface@subsurface-divelog.org> wrote:

> Hi Dirk,
>
> Updated on my Android. I can confirm you didn't kill any of my imaginary
> kittens.
>
> -- Attilla
>
> On August 3, 2022 02:27:04 Dirk Hohndel via subsurface <
> subsurface@subsurface-divelog.org> wrote:
>
>> And a quick 30 hours after I submitted the build, it just got approved.
>> And with that, the signup link for the beta also should work again:
>>
>> https://testflight.apple.com/join/k2OGhIS5
>>
>> The Android binary is already available.
>>
>> I'd appreciate some quick light testing from a few people, just so I know
>> I didn't break anything too badly :)
>>
>> Thanks
>>
>> /D
>>
>> On Aug 1, 2022, at 1:19 PM, Jason  wrote:
>>
>> Thanks, I’ll just sit tight and wait for this to get sorted from the
>> Apple end and then that should let me have it, I can test this pretty
>> easily.
>>
>> Jb
>>
>> Sent from my iPhone
>>
>> On 1 Aug 2022, at 20:51, Dirk Hohndel via subsurface <
>> subsurface@subsurface-divelog.org> wrote:
>>
>> 
>>
>> On Aug 1, 2022, at 11:07 AM, Dirk Hohndel via subsurface <
>> subsurface@subsurface-divelog.org> wrote:
>>
>>
>> The iOS app (3.4.6) has been submitted and is waiting for review, before
>> it will land in the Beta channel.
>> You can join with this link https://testflight.apple.com/join/k2OGhIS5
>>
>>
>> Thanks to a diligent tester I have learned that currently this link
>> doesn't work. Googling for the reasons I have found out that it's the lack
>> of "active" test build that prevents new people from joining.
>>
>> So once the 3.4.6 build has been approved this should work again. I'll
>> holler here once that's the case.
>>
>> /D
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>>
>>
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>>
>>
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-02 Thread Martin de Weger via subsurface
I did some light testing and was able to either crash or temporarily freeze 
subsurface on my iPhone. I can reproduce this. 

When I’m in a dive and turn the phone to landscape (long side down), tap on the 
graph (to see if it opens just the image, which it doesn’t) and turn the phone 
back to a normal position, the app crashes or will freeze for a few seconds. I 
did copy the log below, don’t know if it helps. 


- subsurface.log --
Cyclic dependency detected between "qrc:/org/kde/kirigami.2/Units.qml" and 
"qrc:/org/kde/kirigami.2/Units.qml"
"0.000: Successfully opened logfile 
/var/mobile/Containers/Data/Application/3D291CF9-F0BE-4B90-8D96-F1C5F2DFC11F/Documents/subsurface.log
 at wo aug. 3 07:15:57 2022"
"0.001: Starting Subsurface-mobile:3.4.6(5.0.9.1):iOS 15.6:arm64:nl-NL"
"0.001: built with libdivecomputer v0.8.0-devel-Subsurface-NG 
(107f5b14e31f276a9b5accde2c5032ea49602403)"
"0.001: built with Qt Version 5.15.2, runtime from Qt Version 5.15.2"
"0.001: built with libgit2 1.0.1"
"0.001: Running on iOS 15.6"
discovery methods 2
starting BT/BLE discovery
QObject::connect(QUndoStack, QMLManager): invalid nullptr parameter
"0.024: download page -- looking for known BT/BLE device"
"0.027: [screensetup] width changed now 450 x 675 vs screen 390 x 844"
"0.027: [screensetup] window width changed to 450 orientation 1"
"0.027: [screensetup] remembering new orientation"
qrc:/qml/StatisticsPage.qml:142:4: QML TemplateSlimComboBox: Binding loop 
detected for property "currentIndex"
qrc:/qml/StatisticsPage.qml:125:4: QML TemplateSlimComboBox: Binding loop 
detected for property "currentIndex"
qrc:/qml/StatisticsPage.qml:108:4: QML TemplateSlimComboBox: Binding loop 
detected for property "currentIndex"
"0.053: StartPage visibility changed to false"
"0.053: not yet initialized, show busy spinner"
"0.053: regular font size changed to 14.45"
qrc:/qml/DiveSummary.qml:33:2: QML Connections: Implicitly defined onFoo 
properties in Connections are deprecated. Use this syntax instead: function 
onFoo() { ... }
qrc:/qml/DownloadFromDiveComputer.qml:319:4: QML Connections: Implicitly 
defined onFoo properties in Connections are deprecated. Use this syntax 
instead: function onFoo() { ... }
qrc:/qml/DiveDetails.qml:414:4: QML Connections: Implicitly defined onFoo 
properties in Connections are deprecated. Use this syntax instead: function 
onFoo() { ... }
qrc:/qml/Export.qml:112:3: QML Connections: Implicitly defined onFoo properties 
in Connections are deprecated. Use this syntax instead: function 
onFoo() { ... }
qrc:/org/kde/kirigami.2/templates/AbstractApplicationHeader.qml:69: 
ReferenceError: AppHeaderSizeGroup is not defined
"0.254: finished setting up the diveListView"
"0.254: Running on iPhone built-in display"
"0.254: StartPage completed -- initialized is false"
"0.254: [screensetup] screenSizeObject constructor completed, initial width 450"
"0.254: 1 columns with column width of 450"
"0.254: width in Grid Units 28 original gridUnit 15 now 15.625"
"0.254: Done setting up sizes width 450 gridUnit 15.625"
loaded main.qml
qqwindow devicePixelRatio 3 3
qml_window reports width as 450 associated screen width 390 Qt screen reports 
width as 390
QMLManager received screen changed notification (390,844)
qqwindow screen has ldpi/pdpi 72 163
stale focus object QObject(0x0) , doing manual update
"0.305: [screensetup] width changed now 390 x 763 vs screen 390 x 844"
"0.305: [screensetup] window width changed to 390 orientation 1"
"0.305: [screensetup] remembering better height"
"0.305: 1 columns with column width of 390"
"0.305: width in Grid Units 24 original gridUnit 15 now 15.625"
"0.305: Done setting up sizes width 390 gridUnit 15.625"
"{2044-0101-0002-4000-}"
"{0005-4899-489f-a301-fbee544b1db0}"
"Discovered new device: 'BRIDGE-7C3C' 
[LE:{a42ef4c0-4132-4b76-6893-fcc8cb4cf870}]: " not recognized as dive computer
"Discovered new device: '' [LE:{2bbc8899-8a23-b9ed-823d-212ae786e7d5}]: " not 
recognized as dive computer
"Discovered new device: '' [LE:{3db4da54-6867-1d21-06d3-f1fc24ca227f}]: " not 
recognized as dive computer
"Discovered new device: '' [LE:{8a77bf00-011b-99d8-f4bd-4bb29a350c7e}]: " not 
recognized as dive computer
"Discovered new device: '' [LE:{b0ec218b-a66f-3d3c-4528-3e105e7b63d8}]: " not 
recognized as dive computer
"Discovered new device: '' [LE:{a1121fd2-b63b-ce8a-60f4-a573f5b8325a}]: " not 
recognized as dive computer
"Discovered new device: 'Apple TV Kantoor' 
[LE:{d1083487-7126-3258-7a7d-528756a786d7}]: " not recognized as dive computer
"Discovered new device: '' [LE:{5481a264-1730-0e1b-126d-0c891cb04cd0}]: " not 
recognized as dive computer
"Discovered new device: 'Woonkamer' 
[LE:{13f6a5a0-11ca-0729-7952-8c4fe8a3e17e}]: " not recognized as dive computer
"Discovered new device: '' [LE:{6e26b4fe-b446-6581-3a20-26c31f577260}]: " not 
recognized as dive computer
"Discovered new device: 'Woonkamer (2)' 
[LE:{2f398d30-6d30-a41f-e7e1-e04568bc6fe4}]: " not recognized as d

Re: 5.0.9

2022-08-03 Thread JB2Cool via subsurface
That's looking good for me, it certainly fixes the OSMC deco model issue at
least (tested on hwOS Tech and hwOS Sport). I could download off both
computers and sync with cloud storage. I've not done any extensive testing
but i can't seem to reproduce the portrait/landscape issue that Martin
mentioned.

JB

On Wed, 3 Aug 2022 at 06:24, Martin de Weger via subsurface <
subsurface@subsurface-divelog.org> wrote:

> I did some light testing and was able to either crash or temporarily
> freeze subsurface on my iPhone. I can reproduce this.
>
> When I’m in a dive and turn the phone to landscape (long side down), tap
> on the graph (to see if it opens just the image, which it doesn’t) and turn
> the phone back to a normal position, the app crashes or will freeze for a
> few seconds. I did copy the log below, don’t know if it helps.
>
>
> - subsurface.log --
> Cyclic dependency detected between "qrc:/org/kde/kirigami.2/Units.qml" and
> "qrc:/org/kde/kirigami.2/Units.qml"
> "0.000: Successfully opened logfile
> /var/mobile/Containers/Data/Application/3D291CF9-F0BE-4B90-8D96-F1C5F2DFC11F/Documents/subsurface.log
> at wo aug. 3 07:15:57 2022"
> "0.001: Starting Subsurface-mobile:3.4.6(5.0.9.1):iOS 15.6:arm64:nl-NL"
> "0.001: built with libdivecomputer v0.8.0-devel-Subsurface-NG
> (107f5b14e31f276a9b5accde2c5032ea49602403)"
> "0.001: built with Qt Version 5.15.2, runtime from Qt Version 5.15.2"
> "0.001: built with libgit2 1.0.1"
> "0.001: Running on iOS 15.6"
> discovery methods 2
> starting BT/BLE discovery
> QObject::connect(QUndoStack, QMLManager): invalid nullptr parameter
> "0.024: download page -- looking for known BT/BLE device"
> "0.027: [screensetup] width changed now 450 x 675 vs screen 390 x 844"
> "0.027: [screensetup] window width changed to 450 orientation 1"
> "0.027: [screensetup] remembering new orientation"
> qrc:/qml/StatisticsPage.qml:142:4: QML TemplateSlimComboBox: Binding loop
> detected for property "currentIndex"
> qrc:/qml/StatisticsPage.qml:125:4: QML TemplateSlimComboBox: Binding loop
> detected for property "currentIndex"
> qrc:/qml/StatisticsPage.qml:108:4: QML TemplateSlimComboBox: Binding loop
> detected for property "currentIndex"
> "0.053: StartPage visibility changed to false"
> "0.053: not yet initialized, show busy spinner"
> "0.053: regular font size changed to 14.45"
> qrc:/qml/DiveSummary.qml:33:2: QML Connections: Implicitly defined onFoo
> properties in Connections are deprecated. Use this syntax instead: function
> onFoo() { ... }
> qrc:/qml/DownloadFromDiveComputer.qml:319:4: QML Connections: Implicitly
> defined onFoo properties in Connections are deprecated. Use this syntax
> instead: function onFoo() { ... }
> qrc:/qml/DiveDetails.qml:414:4: QML Connections: Implicitly defined onFoo
> properties in Connections are deprecated. Use this syntax instead: function
> onFoo() { ... }
> qrc:/qml/Export.qml:112:3: QML Connections: Implicitly defined onFoo
> properties in Connections are deprecated. Use this syntax instead: function
> onFoo() { ... }
> qrc:/org/kde/kirigami.2/templates/AbstractApplicationHeader.qml:69:
> ReferenceError: AppHeaderSizeGroup is not defined
> "0.254: finished setting up the diveListView"
> "0.254: Running on iPhone built-in display"
> "0.254: StartPage completed -- initialized is false"
> "0.254: [screensetup] screenSizeObject constructor completed, initial
> width 450"
> "0.254: 1 columns with column width of 450"
> "0.254: width in Grid Units 28 original gridUnit 15 now 15.625"
> "0.254: Done setting up sizes width 450 gridUnit 15.625"
> loaded main.qml
> qqwindow devicePixelRatio 3 3
> qml_window reports width as 450 associated screen width 390 Qt screen
> reports width as 390
> QMLManager received screen changed notification (390,844)
> qqwindow screen has ldpi/pdpi 72 163
> stale focus object QObject(0x0) , doing manual update
> "0.305: [screensetup] width changed now 390 x 763 vs screen 390 x 844"
> "0.305: [screensetup] window width changed to 390 orientation 1"
> "0.305: [screensetup] remembering better height"
> "0.305: 1 columns with column width of 390"
> "0.305: width in Grid Units 24 original gridUnit 15 now 15.625"
> "0.305: Done setting up sizes width 390 gridUnit 15.625"
> "{2044-0101-0002-4000-}"
> "{0005-4899-489f-a301-fbee544b1db0}"
> "Discovered new device: 'BRIDGE-7C3C'
> [LE:{a42ef4c0-4132-4b76-6893-fcc8cb4cf870}]: " not recognized as dive
> computer
> "Discovered new device: '' [LE:{2bbc8899-8a23-b9ed-823d-212ae786e7d5}]: "
> not recognized as dive computer
> "Discovered new device: '' [LE:{3db4da54-6867-1d21-06d3-f1fc24ca227f}]: "
> not recognized as dive computer
> "Discovered new device: '' [LE:{8a77bf00-011b-99d8-f4bd-4bb29a350c7e}]: "
> not recognized as dive computer
> "Discovered new device: '' [LE:{b0ec218b-a66f-3d3c-4528-3e105e7b63d8}]: "
> not recognized as dive computer
> "Discovered new device: '' [LE:{a1121fd2-b63b-ce8a-60f4-a573f5b8325a}]: "
> not recognized as dive computer
> "Di

Re: 5.0.9

2022-08-03 Thread Martin de Weger via subsurface
I did a install from TestFlight over the current stable version. After removing 
the installed version and a fresh install, it is working again.

Kind regards,

Martin de Weger

> Op 3 aug. 2022, om 10:02 heeft JB2Cool  het volgende 
> geschreven:
> 
> That's looking good for me, it certainly fixes the OSMC deco model issue at 
> least (tested on hwOS Tech and hwOS Sport). I could download off both 
> computers and sync with cloud storage. I've not done any extensive testing 
> but i can't seem to reproduce the portrait/landscape issue that Martin 
> mentioned.
> 
> JB
> 
> On Wed, 3 Aug 2022 at 06:24, Martin de Weger via subsurface 
>  > wrote:
> I did some light testing and was able to either crash or temporarily freeze 
> subsurface on my iPhone. I can reproduce this. 
> 
> When I’m in a dive and turn the phone to landscape (long side down), tap on 
> the graph (to see if it opens just the image, which it doesn’t) and turn the 
> phone back to a normal position, the app crashes or will freeze for a few 
> seconds. I did copy the log below, don’t know if it helps. 
> 
> 
> - subsurface.log --
> Cyclic dependency detected between "qrc:/org/kde/kirigami.2/Units.qml" and 
> "qrc:/org/kde/kirigami.2/Units.qml"
> "0.000: Successfully opened logfile 
> /var/mobile/Containers/Data/Application/3D291CF9-F0BE-4B90-8D96-F1C5F2DFC11F/Documents/subsurface.log
>  at wo aug. 3 07:15:57 2022"
> "0.001: Starting Subsurface-mobile:3.4.6(5.0.9.1):iOS 15.6:arm64:nl-NL"
> "0.001: built with libdivecomputer v0.8.0-devel-Subsurface-NG 
> (107f5b14e31f276a9b5accde2c5032ea49602403)"
> "0.001: built with Qt Version 5.15.2, runtime from Qt Version 5.15.2"
> "0.001: built with libgit2 1.0.1"
> "0.001: Running on iOS 15.6"
> discovery methods 2
> starting BT/BLE discovery
> QObject::connect(QUndoStack, QMLManager): invalid nullptr parameter
> "0.024: download page -- looking for known BT/BLE device"
> "0.027: [screensetup] width changed now 450 x 675 vs screen 390 x 844"
> "0.027: [screensetup] window width changed to 450 orientation 1"
> "0.027: [screensetup] remembering new orientation"
> qrc:/qml/StatisticsPage.qml:142:4: QML TemplateSlimComboBox: Binding loop 
> detected for property "currentIndex"
> qrc:/qml/StatisticsPage.qml:125:4: QML TemplateSlimComboBox: Binding loop 
> detected for property "currentIndex"
> qrc:/qml/StatisticsPage.qml:108:4: QML TemplateSlimComboBox: Binding loop 
> detected for property "currentIndex"
> "0.053: StartPage visibility changed to false"
> "0.053: not yet initialized, show busy spinner"
> "0.053: regular font size changed to 14.45"
> qrc:/qml/DiveSummary.qml:33:2: QML Connections: Implicitly defined onFoo 
> properties in Connections are deprecated. Use this syntax instead: function 
> onFoo() { ... }
> qrc:/qml/DownloadFromDiveComputer.qml:319:4: QML Connections: Implicitly 
> defined onFoo properties in Connections are deprecated. Use this syntax 
> instead: function onFoo() { ... }
> qrc:/qml/DiveDetails.qml:414:4: QML Connections: Implicitly defined onFoo 
> properties in Connections are deprecated. Use this syntax instead: function 
> onFoo() { ... }
> qrc:/qml/Export.qml:112:3: QML Connections: Implicitly defined onFoo 
> properties in Connections are deprecated. Use this syntax instead: function 
> onFoo() { ... }
> qrc:/org/kde/kirigami.2/templates/AbstractApplicationHeader.qml:69: 
> ReferenceError: AppHeaderSizeGroup is not defined
> "0.254: finished setting up the diveListView"
> "0.254: Running on iPhone built-in display"
> "0.254: StartPage completed -- initialized is false"
> "0.254: [screensetup] screenSizeObject constructor completed, initial width 
> 450"
> "0.254: 1 columns with column width of 450"
> "0.254: width in Grid Units 28 original gridUnit 15 now 15.625"
> "0.254: Done setting up sizes width 450 gridUnit 15.625"
> loaded main.qml
> qqwindow devicePixelRatio 3 3
> qml_window reports width as 450 associated screen width 390 Qt screen reports 
> width as 390
> QMLManager received screen changed notification (390,844)
> qqwindow screen has ldpi/pdpi 72 163
> stale focus object QObject(0x0) , doing manual update
> "0.305: [screensetup] width changed now 390 x 763 vs screen 390 x 844"
> "0.305: [screensetup] window width changed to 390 orientation 1"
> "0.305: [screensetup] remembering better height"
> "0.305: 1 columns with column width of 390"
> "0.305: width in Grid Units 24 original gridUnit 15 now 15.625"
> "0.305: Done setting up sizes width 390 gridUnit 15.625"
> "{2044-0101-0002-4000-}"
> "{0005-4899-489f-a301-fbee544b1db0}"
> "Discovered new device: 'BRIDGE-7C3C' 
> [LE:{a42ef4c0-4132-4b76-6893-fcc8cb4cf870}]: " not recognized as dive computer
> "Discovered new device: '' [LE:{2bbc8899-8a23-b9ed-823d-212ae786e7d5}]: " not 
> recognized as dive computer
> "Discovered new device: '' [LE:{3db4da54-6867-1d21-06d3-f1fc24ca227f}]: " not 
> recognized as dive computer
> "Discovered new device

Re: 5.0.9

2022-08-03 Thread Dirk Hohndel via subsurface
I tried on two different iOS devices (iPhone 8 plus, iPad Pro) and wasn't able 
to reproduce the issue.

The only thing that I saw in the log that looked odd was this:

>> CAEAGLLayer was resized between makeCurrent and swapBuffers, skipping flush
>> QIOSContext failed to make complete framebuffer object 
>> (GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT)

And I have no idea what might trigger this 🤷🏼‍♂️

Given that it went away for you as well, I think I'll call the activity so far 
"sufficient testing" (after all, there aren't any actual UI changes) and will 
release the two mobile apps today.

Thanks everyone

/D

> On Aug 3, 2022, at 1:37 AM, Martin  wrote:
> 
> I did a install from TestFlight over the current stable version. After 
> removing the installed version and a fresh install, it is working again.
> 
> Kind regards,
> 
> Martin de Weger
> 
>> Op 3 aug. 2022, om 10:02 heeft JB2Cool  het volgende geschreven:
>> 
>> That's looking good for me, it certainly fixes the OSMC deco model issue at 
>> least (tested on hwOS Tech and hwOS Sport). I could download off both 
>> computers and sync with cloud storage. I've not done any extensive testing 
>> but i can't seem to reproduce the portrait/landscape issue that Martin 
>> mentioned.
>> 
>> JB
>> 
>> On Wed, 3 Aug 2022 at 06:24, Martin  wrote:
>> I did some light testing and was able to either crash or temporarily freeze 
>> subsurface on my iPhone. I can reproduce this. 
>> 
>> When I’m in a dive and turn the phone to landscape (long side down), tap on 
>> the graph (to see if it opens just the image, which it doesn’t) and turn the 
>> phone back to a normal position, the app crashes or will freeze for a few 
>> seconds. I did copy the log below, don’t know if it helps. 
>> 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-04 Thread Dirk Hohndel via subsurface


Well, the new iOS app was rejected since it offers account creation but no 
account deletion.

So until I have figured out how to create a safe mechanism that allows people 
to delete their account, iOS users can either user the TestFlight version, or 
use the older production version (which of course doesn't contain the updated 
libdivecomputer).

I am always so happy to see how the app stores are making everyone's lives so 
much easier and safer.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-04 Thread Jason Bramwell via subsurface
So frustrating, especially when you are forced to play their game when they 
don’t play by the same rules themselves.

My sympathy as always, I sure wouldn’t like to be in your position.

Jb

Sent from my iPhone

> On 4 Aug 2022, at 21:14, Dirk Hohndel via subsurface 
>  wrote:
> 
> 
> Well, the new iOS app was rejected since it offers account creation but no 
> account deletion.
> 
> So until I have figured out how to create a safe mechanism that allows people 
> to delete their account, iOS users can either user the TestFlight version, or 
> use the older production version (which of course doesn't contain the updated 
> libdivecomputer).
> 
> I am always so happy to see how the app stores are making everyone's lives so 
> much easier and safer.
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 5.0.9

2022-08-15 Thread Dirk Hohndel via subsurface
With the recently added UI flow that allows deleting your account from the 
mobile app, Subsurface-mobile 3.4.6 was now accepted for the iOS app store as 
well.

I can't wait to see how many people mistakenly delete their account and all 
their data (permanently and not recoverable) thanks to this exciting new 
feature.

Progress. Progress indeed.

/D

> On Aug 4, 2022, at 1:14 PM, Dirk Hohndel  wrote:
> 
> 
> Well, the new iOS app was rejected since it offers account creation but no 
> account deletion.
> 
> So until I have figured out how to create a safe mechanism that allows people 
> to delete their account, iOS users can either user the TestFlight version, or 
> use the older production version (which of course doesn't contain the updated 
> libdivecomputer).
> 
> I am always so happy to see how the app stores are making everyone's lives so 
> much easier and safer.
> 
> /D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface