Change in vdsm[ovirt-3.3]: spec: Don't depend on unreleased RPMs.
Dan Kenigsberg has abandoned this change. Change subject: spec: Don't depend on unreleased RPMs. .. Abandoned -- To view, visit http://gerrit.ovirt.org/21300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4a753dd4fdb8f32e53ac3231b37c60fbafeb82b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Nir Soffer has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 7: Ignore the test failure, it is not relevant to this change. -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 7: Code-Review+1
(2 comments)
Needs docstring fix and shorter warning may be also nice. +1 since I do not
want to delay this.
File vdsm/storage/blockSD.py
Line 1059:
Line 1060: def activateVolumes(self, imgUUID, volUUIDs):
Line 1061: """
Line 1062: Activate all the volumes belonging to the image. Refresh any
active
Line 1063: volumes that belong to the image as long as they are not
special.
The docstring should have a one line title such as:
Activates or refresh all volumes belonging to the image.
Then you can explain why we should check which volumes are active and why it is
important to refresh them, mentioning the bug number.
Line 1064:
Line 1065: imgUUID: the image to be activated.
Line 1066: allVols: getAllVolumes result.
Line 1067:
Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs)
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active
and will be"
Line 1076: " refreshed before use : %s", toRefresh)
We are refreshing now, so "will be refreshed before use" is not the best
warning. I would shorten this warning to:
"Refreshing active lvs: %s"
Line 1077: lvm.refreshLVs(self.sdUUID, toRefresh)
Line 1078:
Line 1079: vgDir = os.path.join("/dev", self.sdUUID)
Line 1080: return self.createImageLinks(vgDir, imgUUID, volUUIDs)
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Lee Yarwood
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient
Dan Kenigsberg has submitted this change and it was merged. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient .. xmlrpc: Parsing error logging enhancement - vdsClient Logging enhancement which helps understand the issues during parsing xml response obtained from vdsm. Parsing issues can occur when bad characters are in xml etc. In order to get raw response we need to wrap one of transport classes (plain or provided class for ssl) and present it to the user when ExpatError is raised. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=982065 Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Signed-off-by: pkliczewski Reviewed-on: http://gerrit.ovirt.org/20627 Reviewed-by: Dan Kenigsberg --- M lib/vdsm/vdscli.py.in M tests/Makefile.am A tests/transportWrapperTests.py 3 files changed, 59 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient .. Patch Set 9: No Builds Executed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4709/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5509/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5588/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isLVActive() method public.
Nir Soffer has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: adopt xml changes of rebalance and remove-brick status
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: adopt xml changes of rebalance and remove-brick status .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4707/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5507/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5586/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b3031b6eb796b7475bbe533fbdd0366fbaf6aea Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: interpret and use correct xml elements
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: interpret and use correct xml elements .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4708/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5508/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5587/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b90283ac2b9f4b54acfccffa02a30e38e5e9d85 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4706/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5506/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5585/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isLVActive() method public.
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4704/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5504/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5583/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4705/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5584/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isLVActive() method public.
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4703/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5503/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5582/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4702/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5502/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5581/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4701/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5501/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5580/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isLVActive() method public.
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4699/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5499/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5578/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4700/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5500/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5579/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isLVActive() method public.
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4698/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5498/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5577/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4697/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5497/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5576/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
Lee Yarwood has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: (2 comments) > Are all callers updated by this patch? Yes. # git grep refreshLV vdsm/storage/blockVolume.py:lvm.refreshLVs(self.sdUUID, (self.volUUID,)) vdsm/storage/lvm.py:def refreshLVs(vgName, lvNames): Commit Message Line 8: Line 9: This change refactors the refreshLV method to allow multiple Line 10: volumes to be refreshed at once as possible with the activate Line 11: and deactive methods. Line 12: Done Line 13: Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d File vdsm/storage/blockVolume.py Line 94: raise se.VolumeDoesNotExist(self.volUUID) # Fix me Line 95: volume.Volume.validate(self) Line 96: Line 97: def refreshVolume(self): Line 98: lvm.refreshLVs(self.sdUUID, self.volUUID) Done Line 99: Line 100: @classmethod Line 101: def getVSize(cls, sdobj, imgUUID, volUUID, bs=BLOCK_SIZE): Line 102: """ Returns size in block units. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: add support for veth NICs
Dan Kenigsberg has submitted this change and it was merged. Change subject: ipwrapper: add support for veth NICs .. ipwrapper: add support for veth NICs Update ipwrapper to consider veth NICs as FakeNICs in the same way it does with dummy NICs. This change is required for the testSetupNetworksAddDelDhcp functional test. Change-Id: Ifc85a1d4c81b270025916b6bc650aa382fbb37ce Signed-off-by: Petr Benas Reviewed-on: http://gerrit.ovirt.org/21381 Reviewed-by: Antoni Segura Puimedon Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M lib/vdsm/ipwrapper.py 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc85a1d4c81b270025916b6bc650aa382fbb37ce Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Benas Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: add support for veth NICs
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc85a1d4c81b270025916b6bc650aa382fbb37ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Benas Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: autotools: fix make distcheck
oVirt Jenkins CI Server has posted comments on this change. Change subject: autotools: fix make distcheck .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4696/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5496/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/818/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5575/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba50c8540f35dbe64c67addf3ae522dc4957718a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 9: Code-Review-1
(3 comments)
Very minor comments, in general it looks good to me.
File tests/functional/firewall.py
Line 37: _execCmdChecker([_IPTABLES_BINARY.cmd, '-I', 'INPUT', '-i',
Line 38: interface, '-p', 'udp', '--sport', '68',
'--dport',
Line 39: '67', '-j', 'ACCEPT'])
Line 40: if _serviceRunning('firewalld'):
Line 41: '''
docstrings should be """ asdfjsadl""" Note quotes instead of apostrophes.
Line 42: zone "work" is used to not to disable dhcp in the public
zone
Line 43: after the test finishes, if it is enabled there
Line 44: '''
Line 45: _execCmdChecker([_FIREWALLD_BINARY.cmd, '--zone=work',
Line 46: '--add-interface=' + interface])
Line 47: _execCmdChecker([_FIREWALLD_BINARY.cmd, '--zone=work',
Line 48: '--add-service=dhcp'])
Line 49: except FirewallError as e:
Line 50: raise SkipTest('Failed to allow dhcp traffic in firewall
because of' +
the '+' is unnecessary ;-)
Line 51:'%s' % e)
Line 52:
Line 53:
Line 54: def stopAllowingDhcp(interface):
Line 73: return not ret
Line 74:
Line 75:
Line 76: def _execCmdChecker(command):
Line 77: (ret, _, err) = execCmd(command)
the parenthesis are unnecessary in the left hand side (also on line 71).
Line 78: if ret:
--
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Benas
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: add support for veth NICs
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc85a1d4c81b270025916b6bc650aa382fbb37ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Benas Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove irs_enable configuration attribute
Dan Kenigsberg has posted comments on this change. Change subject: remove irs_enable configuration attribute .. Patch Set 3: Code-Review-1 If this patch was a part of a patch series about modularization, i'd take it. But as it stands, it removes a configurable that is still useful. I enjoy setting it to false and testing getCaps or networking verbs - without Engine of course. -- To view, visit http://gerrit.ovirt.org/21141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7520f0691d10c7d79377724c1aadcae0173e5bae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: add support for veth NICs
Antoni Segura Puimedon has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc85a1d4c81b270025916b6bc650aa382fbb37ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Benas Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove irs_enable configuration attribute
Arik Hadas has posted comments on this change. Change subject: remove irs_enable configuration attribute .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/21141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7520f0691d10c7d79377724c1aadcae0173e5bae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isLVActive() method public.
Nir Soffer has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 2: (1 comment) Commit Message Line 7: lvm: Make the isLVActive() method public. Line 8: Line 9: This change makes the private isLVActive() method public for Line 10: use in the blockSD layer. Line 11: Add note that this is patch 2 of 3 - all must be merged to fix this bug. Add bug-url Line 12: Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Nir Soffer has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 3: (1 comment) Commit Message Line 10: given LV. This may not be the case if the LV has been modified Line 11: (extended, recreated etc) by another host while the LV is active on Line 12: the current host. Line 13: Line 14: This change forces active non-special LVs to be refresh before use. Add note that this is patch 3 of 3 - all must be merged to fix this bug. Add bug-url Line 15: Line 16: Change-Id: If3058cded234500e01939e50b2485afebd7087a3 -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: (1 comment) Commit Message Line 8: Line 9: This change refactors the refreshLV method to allow multiple Line 10: volumes to be refreshed at once as possible with the activate Line 11: and deactive methods. Line 12: Add note that this is patch 1 of 3 - all must be merged to fix this bug. Add bug-url Line 13: Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: Answering my questions about refreshing multiple lvs - it works and the manual does not say it should not. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate lvs during bootstrap
Nir Soffer has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5:
(3 comments)
File vdsm/storage/lvm.py
Line 659: activelvs.sort()
Line 660: for (vg, opened), group in groupby(activelvs, lambda triple:
triple[:2]):
Line 661: lvs = [triple[2] for triple in group]
Line 662: if opened:
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
The intent was to warn about open lvs which we cannot "fix" by deactivating.
Since they are expected (sanlock uses ids, running vms use their volumes), this
should be info.
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
Line 666: try:
Line 667: _setLVAvailability(vg, lvs, "n")
Line 661: lvs = [triple[2] for triple in group]
Line 662: if opened:
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
Active lvs are expected on boot with fcp, and not expected otherwise. Logging
warning will fill the log with bogus warnings during boot.
Line 666: try:
Line 667: _setLVAvailability(vg, lvs, "n")
Line 668: except se.CannotDeactivateLogicalVolume:
Line 669: log.error("Error deactivating lvs: vg=%s lvs=%s", vg,
lvs)
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
Line 666: try:
Line 667: _setLVAvailability(vg, lvs, "n")
There is ugly race here because this runs in a background thread. We can fix
the race [1], or pass list of lv names to ignore or refresh.
[1] http://gerrit.ovirt.org/#/c/21388
Line 668: except se.CannotDeactivateLogicalVolume:
Line 669: log.error("Error deactivating lvs: vg=%s lvs=%s", vg,
lvs)
Line 670: # Some lvs are inactive now
Line 671: _lvminfo._invalidatelvs(vg, lvs)
--
To view, visit http://gerrit.ovirt.org/21291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
(2 comments)
Looks good, need to check if special lvs are handled in the modified code path.
File vdsm/storage/blockSD.py
Line 1067:
Line 1068: If the image is based on a template image it will be
activated.
Line 1069: """
Line 1070: toRefresh = [vol for vol in volUUIDs if vol not in
SPECIAL_LVS and
Line 1071: lvm.isLVActive(self.sdUUID, vol)]
Special lvs belong to an image?
Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs)
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active
and will be"
Line 1068: If the image is based on a template image it will be
activated.
Line 1069: """
Line 1070: toRefresh = [vol for vol in volUUIDs if vol not in
SPECIAL_LVS and
Line 1071: lvm.isLVActive(self.sdUUID, vol)]
Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs)
I agree.
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active
and will be"
Line 1076: " refreshed before use : %s", toRefresh)
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
Gerrit-Reviewer: Lee Yarwood
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: add support for veth NICs
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4695/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5495/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/817/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5574/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc85a1d4c81b270025916b6bc650aa382fbb37ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Benas Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate lvs during bootstrap
Ayal Baron has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5:
(3 comments)
File vdsm/storage/lvm.py
Line 657: activelvs = [(lv.vg_name, lv.opened, lv.name)
Line 658: for lv in _lvminfo.getAllLvs() if lv.active]
Line 659: activelvs.sort()
Line 660: for (vg, opened), group in groupby(activelvs, lambda triple:
triple[:2]):
Line 661: lvs = [triple[2] for triple in group]
I wonder if it wouldn't be more legible to do this explicitly and not with
groupby etc
Line 662: if opened:
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
Line 659: activelvs.sort()
Line 660: for (vg, opened), group in groupby(activelvs, lambda triple:
triple[:2]):
Line 661: lvs = [triple[2] for triple in group]
Line 662: if opened:
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
why is this warning vs. info?
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
Line 666: try:
Line 667: _setLVAvailability(vg, lvs, "n")
Line 661: lvs = [triple[2] for triple in group]
Line 662: if opened:
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
why is this *not* warning?
Line 666: try:
Line 667: _setLVAvailability(vg, lvs, "n")
Line 668: except se.CannotDeactivateLogicalVolume:
Line 669: log.error("Error deactivating lvs: vg=%s lvs=%s", vg,
lvs)
--
To view, visit http://gerrit.ovirt.org/21291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4694/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5494/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/816/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5573/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Benas Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Benas Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isLVActive() method public.
Nir Soffer has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 2: (1 comment) Commit Message Line 6: Line 7: lvm: Make the isLVActive() method public. Line 8: Line 9: This change makes the private isLVActive() method public for Line 10: use in the blockSD layer. Please explain why the block layer needs this - activating lvs more precisely, avoiding activation of active lvs, etc. Line 11: Line 12: Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: tag pool monitored domains
Ayal Baron has posted comments on this change. Change subject: domainMonitor: tag pool monitored domains .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71714b24b7c8bbb437cbb2e8e254690215df020a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: (1 comment) Looks good except wrong call to new function. Some questions: - Are all callers updated by this patch? - Is this documented to work - refreshing multiple lvs? File vdsm/storage/blockVolume.py Line 94: raise se.VolumeDoesNotExist(self.volUUID) # Fix me Line 95: volume.Volume.validate(self) Line 96: Line 97: def refreshVolume(self): Line 98: lvm.refreshLVs(self.sdUUID, self.volUUID) Seems that you need to send a collection of uuids now: lvm.refreshLVs(self.sdUUID, (self.volUUID,)) Line 99: Line 100: @classmethod Line 101: def getVSize(cls, sdobj, imgUUID, volUUID, bs=BLOCK_SIZE): Line 102: """ Returns size in block units. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: wait until lvm bootstrap is done before connecting to pool
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: wait until lvm bootstrap is done before connecting to pool .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4693/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5493/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5572/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22e851dca4c2063d19446f34897a7b208b9cace4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
Petr Benas has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 8:
(1 comment)
File tests/functional/networkTests.py
Line 1581: {NETWORK_NAME: {'remove': True}},
Line 1582: {BONDING_NAME: {'remove': True}},
Line 1583: {'connectivityCheck': False})
Line 1584:
Line 1585: @permutations([[True], [False]])
I had @cleanupNet here, but It seems I had removed it unintionaly while
rebasing while resolving confilicts in this file.
Line 1586: @RequireVethMod
Line 1587: @ValidateRunningAsRoot
Line 1588: def testSetupNetworksAddDelDhcp(self, bridged):
Line 1589: with vethIf() as (left, right):
--
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Benas
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: wait until lvm bootstrap is done before connecting to pool
Nir Soffer has uploaded a new change for review.
Change subject: hsm: wait until lvm bootstrap is done before connecting to pool
..
hsm: wait until lvm bootstrap is done before connecting to pool
When hsm is created, a bootsrap thread is started, initializing lvm
cache and other parts of the system. This leads to races between
different threads when accessing lvm module when connecting to storage
pool. The races may lead to two threads trying to rebuild the cache in
the same time and possibly corrupt the cache.
This patch adds a synchronization point after lvm bootstrap is done. If
engine attempt to connect to storage pool while lvm cache is not ready
yet, it will wait until it is ready.
This patch will add a delay until a host can connect to the storage
pool. This delay is unavoidable if we want to have correct code.
Change-Id: I22e851dca4c2063d19446f34897a7b208b9cace4
Signed-off-by: Nir Soffer
---
M lib/vdsm/config.py.in
M vdsm/storage/hsm.py
2 files changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/21388/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 9668772..8e075fd 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -267,6 +267,10 @@
('use_volume_leases', 'false',
'Whether to use the volume leases or not.'),
+
+('lvm_bootstrap_timeout', '120',
+'Time in seconds to wait until lvm bootstrap is done when'
+' connecting to storage pool.')
]),
# Section: [addresses]
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 5e53f3a..725279f 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -373,8 +373,16 @@
except Exception:
self.log.warn("Failed to clean Storage Repository.", exc_info=True)
+self._bootstrapDone = threading.Event()
+
def storageRefresh():
-lvm._lvminfo.bootstrap()
+# This may take more then a minute when having lot of lvs. Until it
+# finish, we should not use the lvm module.
+try:
+lvm._lvminfo.bootstrap()
+finally:
+self._bootstrapDone.set()
+
sdCache.refreshStorage()
fileUtils.createdir(self.tasksDir)
@@ -1008,6 +1016,12 @@
"spUUID=%s, msdUUID=%s, masterVersion=%s, hostID=%s, "
"scsiKey=%s" % (spUUID, msdUUID, masterVersion,
hostID, scsiKey)))
+
+timeout = config.getint('vars', 'lvm_bootstrap_timeout')
+self._bootstrapDone.wait(timeout)
+if not self._bootstrapDone.is_set():
+raise se.StoragePoolConnectionError("Bootstrap is not done yet")
+
with rmanager.acquireResource(STORAGE, HSM_DOM_MON_LOCK,
rm.LockType.exclusive):
return self._connectStoragePool(spUUID, hostID, scsiKey, msdUUID,
--
To view, visit http://gerrit.ovirt.org/21388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22e851dca4c2063d19446f34897a7b208b9cace4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Lee Yarwood has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
(1 comment)
File vdsm/storage/blockSD.py
Line 1068: If the image is based on a template image it will be
activated.
Line 1069: """
Line 1070: toRefresh = [vol for vol in volUUIDs if vol not in
SPECIAL_LVS and
Line 1071: lvm.isLVActive(self.sdUUID, vol)]
Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs)
Nir, just to answer a question you asked before regarding passing all volumes
to the activateLVs method. I could create a toActivate list here and only pass
these but that duplicates the logic already in the activateLVs method. I don't
want to touch that method now so it's just easier to pass everything through
and let it filter them out.
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active
and will be"
Line 1076: " refreshed before use : %s", toRefresh)
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
Gerrit-Reviewer: Lee Yarwood
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4692/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5492/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5571/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4691/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5491/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5570/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 8: Code-Review-1
(1 comment)
File tests/functional/networkTests.py
Line 1581: {NETWORK_NAME: {'remove': True}},
Line 1582: {BONDING_NAME: {'remove': True}},
Line 1583: {'connectivityCheck': False})
Line 1584:
Line 1585: @permutations([[True], [False]])
we should not forget the @cleanupNet decorator.
And if you are changing this file, how about dropping the bridged permutation?
we should limit the number of tests due to their accumulating time.
Line 1586: @RequireVethMod
Line 1587: @ValidateRunningAsRoot
Line 1588: def testSetupNetworksAddDelDhcp(self, bridged):
Line 1589: with vethIf() as (left, right):
--
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Benas
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isLVActive() method public.
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isLVActive() method public. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4690/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5490/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5569/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: prevent faulty volume extensions
Federico Simoncelli has submitted this change and it was merged. Change subject: vm: prevent faulty volume extensions .. vm: prevent faulty volume extensions Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443 Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Signed-off-by: Federico Simoncelli Signed-off-by: Yeela Kaplan Reviewed-on: http://gerrit.ovirt.org/21150 Reviewed-by: Sergey Gotliv Reviewed-by: Ayal Baron Reviewed-by: Allon Mureinik Reviewed-on: http://gerrit.ovirt.org/21383 Reviewed-by: Dan Kenigsberg --- M vdsm/vm.py 1 file changed, 33 insertions(+), 2 deletions(-) Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop
Federico Simoncelli has submitted this change and it was merged. Change subject: vm: unify _highWrite and _onAbnormalStop .. vm: unify _highWrite and _onAbnormalStop Both _highWrite and _onAbnormalStop should share the same logic about the volume extension. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443 Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/20966 Reviewed-by: Sergey Gotliv Reviewed-by: Ayal Baron Reviewed-on: http://gerrit.ovirt.org/21382 Tested-by: Allon Mureinik Reviewed-by: Allon Mureinik Reviewed-by: Dan Kenigsberg --- M vdsm/vm.py 1 file changed, 24 insertions(+), 35 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4689/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5489/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5568/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Lee Yarwood has uploaded a new change for review.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
blockSD: Ensure active volumes are refreshed before use.
At present we trust that active LVs represent the current state of a
given LV. This may not be the case if the LV has been modified
(extended, recreated etc) by another host while the LV is active on
the current host.
This change forces active non-special LVs to be refresh before use.
Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Signed-off-by: Lee Yarwood
---
M vdsm/storage/blockSD.py
1 file changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/21387/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index d27f331..7d296b7 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -1059,14 +1059,23 @@
def activateVolumes(self, imgUUID, volUUIDs):
"""
-Activate all the volumes belonging to the image.
+Activate all the volumes belonging to the image. Refresh any active
+volumes that belong to the image as long as they are not special.
-imgUUID: the image to be deactivated.
+imgUUID: the image to be activated.
allVols: getAllVolumes result.
If the image is based on a template image it will be activated.
"""
+toRefresh = [ vol for vol in volUUIDs if vol not in SPECIAL_LVS and
+ lvm.isLVActive(self.sdUUID, vol)]
lvm.activateLVs(self.sdUUID, volUUIDs)
+
+if toRefresh:
+log.warning("The following volumes are already active and will be"
+" refreshed before use : %s", toRefresh)
+lvm.refreshLVs(self.sdUUID, toRefresh)
+
vgDir = os.path.join("/dev", self.sdUUID)
return self.createImageLinks(vgDir, imgUUID, volUUIDs)
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: add support for veth NICs
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 1: you are using veth devices in your "Add NetworkTest.testSetupNetworksAddDelkDhcp" patch, so this patch should come below it. -- To view, visit http://gerrit.ovirt.org/21381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc85a1d4c81b270025916b6bc650aa382fbb37ce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Benas Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isActiveLV() method public.
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Make the isActiveLV() method public. .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4688/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5488/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5567/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4687/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5487/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5566/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isActiveLV() method public.
Lee Yarwood has uploaded a new change for review. Change subject: lvm: Make the isActiveLV() method public. .. lvm: Make the isActiveLV() method public. This change makes the private isActiveLV() method public for use in the blockSD layer. Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Signed-off-by: Lee Yarwood --- M vdsm/storage/lvm.py 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/21386/1 diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index 112f1c0..76184b8 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -1221,10 +1221,8 @@ return os.path.basename(os.readlink(lvp)) -def _isLVActive(vgName, lvName): +def isLVActive(vgName, lvName): """Active volumes have a mp link. - -This function should not be used out of this module. """ return os.path.exists(lvPath(vgName, lvName)) -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: prevent faulty volume extensions
Dan Kenigsberg has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop
Dan Kenigsberg has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt
Alon Bar-Lev has posted comments on this change. Change subject: Fail pre-start run after configure libvirt .. Patch Set 2: (1 comment) File init/vdsmd_init_common.sh.in Line 58: if "$VDSM_TOOL" libvirt-configure | grep -q 'is done'; then Line 59: echo "Reconfigured libvirt. Please perform: " \ Line 60: "'vdsm-tool libvirt-configure-services-restart' " \ Line 61: "and start vdsmd again" Line 62: return 1 and the problem is? Line 63: fi Line 64: return 0 Line 65: } Line 66: -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Don't depend on unreleased RPMs.
Dan Kenigsberg has posted comments on this change. Change subject: spec: Don't depend on unreleased RPMs. .. Patch Set 1: Verified+1 Code-Review+2 (1 comment) verified by Saggi. Commit Message Line 6: Line 7: spec: Don't depend on unreleased RPMs. Line 8: Line 9: The requested package is not yet available in RHEL and will only be Line 10: available in 6.5. It's important to note that Vdsm continues to work as it should even without the dependency, with the exception of not solving https://bugzilla.redhat.com/964595 Line 11: Line 12: Change-Id: I4a753dd4fdb8f32e53ac3231b37c60fbafeb82b3 -- To view, visit http://gerrit.ovirt.org/21385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a753dd4fdb8f32e53ac3231b37c60fbafeb82b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Don't depend on unreleased RPMs.
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: Don't depend on unreleased RPMs. .. spec: Don't depend on unreleased RPMs. The requested package is not yet available in RHEL and will only be available in 6.5. Change-Id: I4a753dd4fdb8f32e53ac3231b37c60fbafeb82b3 Signed-off-by: Saggi Mizrahi Reviewed-on: http://gerrit.ovirt.org/21385 Tested-by: Dan Kenigsberg Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a753dd4fdb8f32e53ac3231b37c60fbafeb82b3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt
Yaniv Bronhaim has posted comments on this change. Change subject: Fail pre-start run after configure libvirt .. Patch Set 2: (1 comment) File init/vdsmd_init_common.sh.in Line 58: if "$VDSM_TOOL" libvirt-configure | grep -q 'is done'; then Line 59: echo "Reconfigured libvirt. Please perform: " \ Line 60: "'vdsm-tool libvirt-configure-services-restart' " \ Line 61: "and start vdsmd again" Line 62: return 1 than I need to update init/systemd/systemd-vdsmd.in and init/sysvinit/vdsmd.init.in and add print of explanation what to do to the libvirt_configure.sh script Line 63: fi Line 64: return 0 Line 65: } Line 66: -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Don't depend on unreleased RPMs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Don't depend on unreleased RPMs. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5486/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5565/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a753dd4fdb8f32e53ac3231b37c60fbafeb82b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Don't depend on unreleased RPMs.
Yaniv Bronhaim has posted comments on this change. Change subject: spec: Don't depend on unreleased RPMs. .. Patch Set 1: Saggi - please abandon http://gerrit.ovirt.org/#/c/21300/ . This is not relevant to ovirt-3.3 branch. Thanks. -- To view, visit http://gerrit.ovirt.org/21385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a753dd4fdb8f32e53ac3231b37c60fbafeb82b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Don't depend on unreleased RPMs.
Hello Saggi Mizrahi,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21385
to review the following change.
Change subject: spec: Don't depend on unreleased RPMs.
..
spec: Don't depend on unreleased RPMs.
The requested package is not yet available in RHEL and will only be
available in 6.5.
Change-Id: I4a753dd4fdb8f32e53ac3231b37c60fbafeb82b3
Signed-off-by: Saggi Mizrahi
---
M vdsm.spec.in
1 file changed, 11 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/21385/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 17564ea..c225c23 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -131,6 +131,17 @@
%endif
Requires: libvirt-python, libvirt-lock-sanlock, libvirt-client
+# iscsi-intiator versions
+%if 0%{?rhel}
+%if 0%{?rhel} >= 7
+Requires: iscsi-initiator-utils
+%else
+Requires: iscsi-initiator-utils >= 6.2.0.872-15
+%endif # rhel 7
+%else # fedora
+Requires: iscsi-initiator-utils >= 6.2.0.873-3
+%endif
+
%if 0%{?rhel}
Requires: python-ethtool >= 0.6-3
%if 0%{?rhel} >= 7
@@ -138,7 +149,6 @@
Requires: device-mapper-multipath
Requires: e2fsprogs
Requires: fence-agents-all
-Requires: iscsi-initiator-utils
Requires: lvm2
Requires: python
Requires: policycoreutils-python
@@ -152,7 +162,6 @@
# Update the qemu-kvm requires when block_stream will be included
Requires: qemu-kvm >= 2:0.12.1.2-2.295.el6_3.4
Requires: qemu-img >= 2:0.12.1.2-2.295.el6_3.4
-Requires: iscsi-initiator-utils >= 6.2.0.873-3
Requires: device-mapper-multipath >= 0.4.9-52
Requires: e2fsprogs >= 1.41.12-11
Requires: fence-agents
@@ -184,7 +193,6 @@
%if 0%{?fedora} >= 18
Requires: initscripts >= 9.42.2-1
%endif
-Requires: iscsi-initiator-utils >= 6.2.0.872-14
Requires: device-mapper-multipath >= 0.4.9-18
Requires: e2fsprogs >= 1.41.14
Requires: sanlock >= 2.4-2, sanlock-python
--
To view, visit http://gerrit.ovirt.org/21385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a753dd4fdb8f32e53ac3231b37c60fbafeb82b3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Saggi Mizrahi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt
Alon Bar-Lev has posted comments on this change. Change subject: Fail pre-start run after configure libvirt .. Patch Set 2: (1 comment) File init/vdsmd_init_common.sh.in Line 58: if "$VDSM_TOOL" libvirt-configure | grep -q 'is done'; then Line 59: echo "Reconfigured libvirt. Please perform: " \ Line 60: "'vdsm-tool libvirt-configure-services-restart' " \ Line 61: "and start vdsmd again" Line 62: return 1 in master it will insane to add grep. and as I wrote, the only automation we support is host-deploy, and host-deploy will cope with you using return code. so I am unsure what you fear of. Line 63: fi Line 64: return 0 Line 65: } Line 66: -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop
Allon Mureinik has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 2: Verified+1 Code-Review+1 Replaced "Bug-Url: Bug-Url:" in the commit message with "Bug-Url:" via gerrit. No changes in the patch itself. -- To view, visit http://gerrit.ovirt.org/21382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: add support for veth NICs
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: add support for veth NICs .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4685/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5485/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/815/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5564/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc85a1d4c81b270025916b6bc650aa382fbb37ce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Benas Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: prevent faulty volume extensions
Allon Mureinik has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt
Yaniv Bronhaim has posted comments on this change. Change subject: Fail pre-start run after configure libvirt .. Patch Set 2: (1 comment) File init/vdsmd_init_common.sh.in Line 58: if "$VDSM_TOOL" libvirt-configure | grep -q 'is done'; then Line 59: echo "Reconfigured libvirt. Please perform: " \ Line 60: "'vdsm-tool libvirt-configure-services-restart' " \ Line 61: "and start vdsmd again" Line 62: return 1 Prefer not, changing ret code means changing in the update flow and might be more usages that I don't think of. So as minor as I can, I prefer to leave this change as is. And, in ovirt-3.3 we don't have the print in the tool that says to use vdsm-tool verb to reset related services, so I'll need to add it also there.. Line 63: fi Line 64: return 0 Line 65: } Line 66: -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop
Allon Mureinik has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp .. Patch Set 8: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4684/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5484/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/814/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5563/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Benas Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Benas Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 1: Verified+1 Same as upstream. -- To view, visit http://gerrit.ovirt.org/21383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop
Federico Simoncelli has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 1: Verified+1 Same as upstream. -- To view, visit http://gerrit.ovirt.org/21382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: prevent faulty volume extensions
Hello Ayal Baron, Yeela Kaplan, Sergey Gotliv, Allon Mureinik, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/21383 to review the following change. Change subject: vm: prevent faulty volume extensions .. vm: prevent faulty volume extensions Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443 Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Signed-off-by: Federico Simoncelli Signed-off-by: Yeela Kaplan Reviewed-on: http://gerrit.ovirt.org/21150 Reviewed-by: Sergey Gotliv Reviewed-by: Ayal Baron Reviewed-by: Allon Mureinik --- M vdsm/vm.py 1 file changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/21383/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 2bf9a1e..0921fb2 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -2265,6 +2265,36 @@ continue capacity, alloc, physical = self._dom.blockInfo(drive.path, 0) + +# Since the check based on nextPhysSize is extremly risky (it +# may result in the VM being paused) we can't use the regular +# getNextVolumeSize call as it relies on a cached value of the +# drive apparentsize. +nextPhysSize = physical + drive.VOLWM_CHUNK_MB * constants.MEGAB + +# NOTE: the intent of this check is to prevent faulty images to +# trick qemu in requesting extremely large extensions (BZ#998443). +# Probably the definitive check would be comparing the allocated +# space with capacity + format_overhead. Anyway given that: +# +# - format_overhead is tricky to be computed (it depends on few +# assumptions that may change in the future e.g. cluster size) +# - currently we allow only to extend by one chunk at time +# +# the current check compares alloc with the next volume size. +# It should be noted that alloc cannot be directly compared with +# the volume physical size as it includes also the clusters not +# written yet (pending). +if alloc > nextPhysSize: +self.log.error( +"Improbable extension request for volume %s on domain " +"%s, pausing the VM to avoid corruptions (capacity: %s, " +"allocated: %s, physical: %s, next physical size: %s)", +drive.volumeID, drive.domainID, capacity, alloc, +physical, nextPhysSize) +self.pause(pauseCode='EOTHER') +return False + if physical - alloc < drive.watermarkLimit: extend.append((drive, capacity, alloc, physical)) @@ -2415,12 +2445,13 @@ if not guestCpuLocked: self._guestCpuLock.release() -def pause(self, afterState='Paused', guestCpuLocked=False): +def pause(self, afterState='Paused', guestCpuLocked=False, + pauseCode='NOERR'): if not guestCpuLocked: self._acquireCpuLockWithTimeout() try: with self._confLock: -self.conf['pauseCode'] = 'NOERR' +self.conf['pauseCode'] = pauseCode self._underlyingPause() if hasattr(self, 'updateGuestCpuRunning'): self.updateGuestCpuRunning() -- To view, visit http://gerrit.ovirt.org/21383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: unify _highWrite and _onAbnormalStop
Hello Ayal Baron, Sergey Gotliv,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21382
to review the following change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
vm: unify _highWrite and _onAbnormalStop
Both _highWrite and _onAbnormalStop should share the same logic about
the volume extension.
Bug-Url: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Signed-off-by: Federico Simoncelli
Reviewed-on: http://gerrit.ovirt.org/20966
Reviewed-by: Sergey Gotliv
Reviewed-by: Ayal Baron
---
M vdsm/vm.py
1 file changed, 24 insertions(+), 35 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/21382/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 475f6ce..2bf9a1e 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -504,22 +504,7 @@
if not self._vm.isDisksStatsCollectionEnabled():
# Avoid queries from storage during recovery process
return
-
-for vmDrive in self._vm._devices[DISK_DEVICES]:
-if not vmDrive.blockDev or vmDrive.format != 'cow':
-continue
-
-capacity, alloc, physical = \
-self._vm._dom.blockInfo(vmDrive.path, 0)
-
-if physical - alloc >= vmDrive.watermarkLimit:
-continue
-
-self._log.info('%s/%s apparent: %s capacity: %s, alloc: %s, '
- 'phys: %s', vmDrive.domainID, vmDrive.volumeID,
- vmDrive.apparentsize, capacity, alloc, physical)
-
-self._vm.extendDriveVolume(vmDrive)
+self._vm.extendDrivesIfNeeded()
def _updateVolumes(self):
if not self._vm.isDisksStatsCollectionEnabled():
@@ -2271,6 +2256,27 @@
self.log.debug('new rtc offset %s', timeOffset)
with self._confLock:
self.conf['timeOffset'] = timeOffset
+
+def extendDrivesIfNeeded(self):
+extend = []
+
+for drive in self._devices[DISK_DEVICES]:
+if not drive.blockDev or drive.format != 'cow':
+continue
+
+capacity, alloc, physical = self._dom.blockInfo(drive.path, 0)
+if physical - alloc < drive.watermarkLimit:
+extend.append((drive, capacity, alloc, physical))
+
+for drive, capacity, alloc, physical in extend:
+self.log.info(
+"Requesting extension for volume %s on domain %s (apparent: "
+"%s, capacity: %s, allocated: %s, physical: %s)",
+drive.volumeID, drive.domainID, drive.apparentsize, capacity,
+alloc, physical)
+self.extendDriveVolume(drive)
+
+return len(extend) > 0
def extendDriveVolume(self, vmDrive):
if not vmDrive.blockDev:
@@ -4208,25 +4214,8 @@
self.conf['pauseCode'] = err.upper()
self._guestCpuRunning = False
if err.upper() == 'ENOSPC':
-for d in self._devices[DISK_DEVICES]:
-if d.alias == blockDevAlias:
-#in the case of a qcow2-like file stored inside a block
-#device 'physical' will give the block device size, while
-#'allocation' will give the qcow2 image size
-#D. Berrange
-capacity, alloc, physical = self._dom.blockInfo(d.path, 0)
-if (physical >
-(alloc + config.getint(
-'irs', 'volume_utilization_chunk_mb'))):
-self.log.warn('%s = %s/%s error %s phys: %s alloc: %s '
- 'Ingnoring already managed event.',
- blockDevAlias, d.domainID, d.volumeID,
- err, physical, alloc)
-return
-self.log.info('%s = %s/%s error %s phys: %s alloc: %s',
- blockDevAlias, d.domainID, d.volumeID, err,
- physical, alloc)
-self.extendDriveVolume(d)
+if not self.extendDrivesIfNeeded():
+self.log.info("No VM drives were extended")
def _acpiShutdown(self):
self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
--
To view, visit http://gerrit.ovirt.org/21382
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Sergey Gotliv
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: add support for veth NICs
Petr Benas has uploaded a new change for review.
Change subject: ipwrapper: add support for veth NICs
..
ipwrapper: add support for veth NICs
Update ipwrapper to consider veth NICs as FakeNICs in the same
way it does with dummy NICs. This change is required for the
testSetupNetworksAddDelDhcp functional test.
Change-Id: Ifc85a1d4c81b270025916b6bc650aa382fbb37ce
Signed-off-by: Petr Benas
---
M lib/vdsm/ipwrapper.py
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/21381/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index 2210897..afd7f6c 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -67,6 +67,7 @@
TUN = 'tun'
OVS = 'openvswitch'
TEAM = 'team'
+VETH = 'veth'
@equals
@@ -88,7 +89,7 @@
self.vlanprotocol = vlanprotocol
for key, value in kwargs.items():
setattr(self, key, value)
-if linkType == LinkType.DUMMY:
+if linkType == LinkType.DUMMY or linkType == LinkType.VETH:
self._fakeNics = config.get('vars', 'fake_nics').split(',')
self._hiddenNics = config.get('vars', 'hidden_nics').split(',')
if linkType == LinkType.NIC:
@@ -186,20 +187,26 @@
def isNIC(self):
return self.type == LinkType.NIC
+def isVETH(self):
+return self.type == LinkType.VETH
+
def isVLAN(self):
return self.type == LinkType.VLAN
def isFakeNIC(self):
"""
-Returns True iff vdsm config marks the DUMMY dev to be reported as NIC.
+Returns True iff vdsm config marks the DUMMY or VETH dev to be reported
+as NIC.
"""
-return self.isDUMMY() and anyFnmatch(self.name, self._fakeNics)
+if self.isDUMMY() or self.isVETH():
+return anyFnmatch(self.name, self._fakeNics)
+return False
def isHidden(self):
"""Returns True iff vdsm config hides the device."""
if self.isVLAN():
return anyFnmatch(self.name, self._hiddenVlans)
-elif self.isDUMMY() or self.isNIC():
+elif self.isDUMMY() or self.isVETH() or self.isNIC():
return anyFnmatch(self.name, self._hiddenNics)
else:
raise NotImplementedError
--
To view, visit http://gerrit.ovirt.org/21381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc85a1d4c81b270025916b6bc650aa382fbb37ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: prevent faulty volume extensions .. vm: prevent faulty volume extensions Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443 Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Signed-off-by: Federico Simoncelli Signed-off-by: Yeela Kaplan Reviewed-on: http://gerrit.ovirt.org/21150 Reviewed-by: Sergey Gotliv Reviewed-by: Ayal Baron Reviewed-by: Allon Mureinik --- M vdsm/vm.py 1 file changed, 33 insertions(+), 2 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Federico Simoncelli: Verified Sergey Gotliv: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: -Code-Review (1 comment) File vdsm/vm.py Line 2291: Line 2292: # Since the check based on nextPhysSize is extremly risky (it Line 2293: # may result in the VM being paused) we can't use the regular Line 2294: # getNextVolumeSize call as it relies on a cached value of the Line 2295: # drive apparentsize. Using getNextVolumeSize() for extend attempts is fine, as it is retries until apparentsize is either updated or ignored. Here the situation is much riskier since if we stop a VM needlessly it's pretty much dead. Line 2296: nextPhysSize = physical + drive.VOLWM_CHUNK_MB * constants.MEGAB Line 2297: Line 2298: # NOTE: the intent of this check is to prevent faulty images to Line 2299: # trick qemu in requesting extremely large extensions (BZ#998443). -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add unit tests for unified network persistence
Assaf Muller has posted comments on this change. Change subject: Add unit tests for unified network persistence .. Patch Set 6: Verified+1 The test that fails on Jenkins works on my host. -- To view, visit http://gerrit.ovirt.org/21269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add unit tests for unified network persistence
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add unit tests for unified network persistence .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4683/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5483/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/813/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5562/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add unit tests for unified network persistence
Assaf Muller has posted comments on this change. Change subject: Add unit tests for unified network persistence .. Patch Set 4: (1 comment) File tests/netconfpersistenceTests.py Line 50: Line 51: persistence = Config(self.tempdir) Line 52: self.assertEqual(persistence.networks[NETWORK], NETWORK_ATTRIBUTES) Line 53: finally: Line 54: os.remove(filePath) If I do: with open(...): try: pass finally: os.remove(...) Then I'd fail to remove an open file... I can just use utils.rmFile. Line 55: Line 56: def testSetAndRemoveNetwork(self): Line 57: persistence = Config(self.tempdir) Line 58: persistence.setNetwork(NETWORK, NETWORK_ATTRIBUTES) -- To view, visit http://gerrit.ovirt.org/21269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient .. Patch Set 8: Code-Review+2 Sorry to have missed the args[1:] issue. -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient .. Patch Set 8: Code-Review-1 ouch, manual rebase needed. -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate lvs during bootstrap
Federico Simoncelli has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5: Code-Review+1
(3 comments)
Few comments. +1 for now, I still have doubts.
File vdsm/storage/hsm.py
Line 373: except Exception:
Line 374: self.log.warn("Failed to clean Storage Repository.",
exc_info=True)
Line 375:
Line 376: def storageRefresh():
Line 377: lvm.bootstrap()
I wonder how long this will take on large deployments, being asynchronous I am
worried that it might get in some more serious race with the activation of the
special LVs (e.g. triggered by a connectStoragePoool).
Line 378: sdCache.refreshStorage()
Line 379:
Line 380: fileUtils.createdir(self.tasksDir)
Line 381: # TBD: Should this be run in connectStoragePool? Should
tasksDir
File vdsm/storage/lvm.py
Line 661: lvs = [triple[2] for triple in group]
Line 662: if opened:
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
I guess we'll have to accept the massive logging on fcp at boot.
Line 666: try:
Line 667: _setLVAvailability(vg, lvs, "n")
Line 668: except se.CannotDeactivateLogicalVolume:
Line 669: log.error("Error deactivating lvs: vg=%s lvs=%s", vg,
lvs)
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
Line 666: try:
Line 667: _setLVAvailability(vg, lvs, "n")
This might be safe also for the special LVs (it seems to me that blockSD always
assumes that they could be inactive), unless we get in some sort of race (see
comment on hsm.py). Maybe special LVs just deserve a refresh instead of being
deactivated.
Line 668: except se.CannotDeactivateLogicalVolume:
Line 669: log.error("Error deactivating lvs: vg=%s lvs=%s", vg,
lvs)
Line 670: # Some lvs are inactive now
Line 671: _lvminfo._invalidatelvs(vg, lvs)
--
To view, visit http://gerrit.ovirt.org/21291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt
Alon Bar-Lev has posted comments on this change. Change subject: Fail pre-start run after configure libvirt .. Patch Set 2: (1 comment) File init/vdsmd_init_common.sh.in Line 58: if "$VDSM_TOOL" libvirt-configure | grep -q 'is done'; then Line 59: echo "Reconfigured libvirt. Please perform: " \ Line 60: "'vdsm-tool libvirt-configure-services-restart' " \ Line 61: "and start vdsmd again" Line 62: return 1 I thought you going to add return code to the tool, no? Line 63: fi Line 64: return 0 Line 65: } Line 66: -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: tag pool monitored domains
Allon Mureinik has posted comments on this change. Change subject: domainMonitor: tag pool monitored domains .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71714b24b7c8bbb437cbb2e8e254690215df020a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Report qemu-kvm-rhev if installed
Humble Devassy Chirammal has posted comments on this change. Change subject: Report qemu-kvm-rhev if installed .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6b59241bbf38b6cd15fd941e1f68115853d22c1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Humble Devassy Chirammal Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: caps: coarse-grain libvirt.rpm may be missing
mooli tayer has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: caps: coarse-grain libvirt.rpm may be missing
Douglas Schilling Landgraf has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Report qemu-kvm-rhev if installed
Douglas Schilling Landgraf has posted comments on this change. Change subject: Report qemu-kvm-rhev if installed .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6b59241bbf38b6cd15fd941e1f68115853d22c1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: new verb to remove host using host UUID
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: new verb to remove host using host UUID .. gluster: new verb to remove host using host UUID This patch adds a new verb glusterHostRemoveByUuid which retrives the host name based on uuid passed and uses it to remove the host. new verb: GlusterHostRemoveByUuid return type: bool (success or failure) possible Exception: GlusterHostNotFoundException / GlusterHostRemoveFailedException. Signed-off-by: ndarshan Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a Reviewed-on: http://gerrit.ovirt.org/20648 Reviewed-by: Dan Kenigsberg Reviewed-by: Bala.FA --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/vdsmapi-gluster-schema.json 3 files changed, 42 insertions(+), 1 deletion(-) Approvals: Bala.FA: Looks good to me, but someone else must approve Darshan N: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: caps: coarse-grain libvirt.rpm may be missing
Hello Douglas Schilling Landgraf, mooli tayer,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21363
to review the following change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
caps: coarse-grain libvirt.rpm may be missing
As of http://gerrit.ovirt.org/15761 we no longer require the legacy
libvirt.rpm to be installed on Fedora, so getCaps should not look for
it. Instead, it should report the information of the installed
libvirt-daemon-kvm.rpm.
Without this patch we get an annoying
(_getKeyPackages) rpm package libvirt not found
log message, and do not report libvirt's version.
Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4
Signed-off-by: Dan Kenigsberg
Reviewed-on: http://gerrit.ovirt.org/19295
Reviewed-by: mooli tayer
Reviewed-by: Douglas Schilling Landgraf
---
M vdsm/caps.py
1 file changed, 10 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/21363/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 3a7a6a2..c5ecadc 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -20,6 +20,7 @@
"""Collect host capabilities"""
+import itertools
import os
from xml.dom import minidom
import logging
@@ -323,12 +324,12 @@
pkgs = {'kernel': kernelDict()}
if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL):
-KEY_PACKAGES = {'qemu-kvm': 'qemu-kvm',
-'qemu-img': 'qemu-img',
-'vdsm': 'vdsm',
-'spice-server': 'spice-server',
-'libvirt': 'libvirt',
-'mom': 'mom',
+KEY_PACKAGES = {'qemu-kvm': ('qemu-kvm',),
+'qemu-img': ('qemu-img',),
+'vdsm': ('vdsm',),
+'spice-server': ('spice-server',),
+'libvirt': ('libvirt', 'libvirt-daemon-kvm'),
+'mom': ('mom',),
}
if _glusterEnabled:
@@ -337,9 +338,10 @@
try:
ts = rpm.TransactionSet()
-for pkg in KEY_PACKAGES:
+for pkg, names in KEY_PACKAGES.iteritems():
try:
-mi = ts.dbMatch('name', KEY_PACKAGES[pkg]).next()
+mi = itertools.chain(*[ts.dbMatch('name', name)
+ for name in names]).next()
except StopIteration:
logging.debug("rpm package %s not found",
KEY_PACKAGES[pkg])
--
To view, visit http://gerrit.ovirt.org/21363
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: mooli tayer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Report qemu-kvm-rhev if installed
Hello Douglas Schilling Landgraf,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21364
to review the following change.
Change subject: Report qemu-kvm-rhev if installed
..
Report qemu-kvm-rhev if installed
Change-Id: If6b59241bbf38b6cd15fd941e1f68115853d22c1
Bug-Url: https://bugzilla.redhat.com/1029792
Signed-off-by: Dan Kenigsberg
Reviewed-on: http://gerrit.ovirt.org/21226
Reviewed-by: Douglas Schilling Landgraf
---
M vdsm/caps.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/21364/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index c5ecadc..a6e22d2 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -324,8 +324,8 @@
pkgs = {'kernel': kernelDict()}
if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL):
-KEY_PACKAGES = {'qemu-kvm': ('qemu-kvm',),
-'qemu-img': ('qemu-img',),
+KEY_PACKAGES = {'qemu-kvm': ('qemu-kvm', 'qemu-kvm-rhev'),
+'qemu-img': ('qemu-img', 'qemu-img-rhev'),
'vdsm': ('vdsm',),
'spice-server': ('spice-server',),
'libvirt': ('libvirt', 'libvirt-daemon-kvm'),
--
To view, visit http://gerrit.ovirt.org/21364
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6b59241bbf38b6cd15fd941e1f68115853d22c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: new verb to remove host using host UUID
Darshan N has posted comments on this change. Change subject: gluster: new verb to remove host using host UUID .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/20648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate lvs during bootstrap
Allon Mureinik has posted comments on this change. Change subject: lvm: deactivate lvs during bootstrap .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: spec: Don't depend on unreleased RPMs.
Dan Kenigsberg has posted comments on this change. Change subject: spec: Don't depend on unreleased RPMs. .. Patch Set 1: Code-Review-1 We actually want this on "master". It should reach ovirt-3.3 only if (and when) the iscsi clean reaches here. -- To view, visit http://gerrit.ovirt.org/21300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a753dd4fdb8f32e53ac3231b37c60fbafeb82b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: Add python-inotify as buildrequires dep
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm.spec: Add python-inotify as buildrequires dep .. vdsm.spec: Add python-inotify as buildrequires dep This is needed because now the configure step checks for the packages necessary for running vdsm. Change-Id: I845c19fb2058d2f6036ce546f77f7b8ef28884a2 Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/21348 Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I845c19fb2058d2f6036ce546f77f7b8ef28884a2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: Add python-inotify as buildrequires dep
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: Add python-inotify as buildrequires dep .. Patch Set 1: Verified+1 Code-Review+2 not really verfied by me. -- To view, visit http://gerrit.ovirt.org/21348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I845c19fb2058d2f6036ce546f77f7b8ef28884a2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
