Change in vdsm[master]: caps: report if QEMU supports live snapshots
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: report if QEMU supports live snapshots .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6896/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/417/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7798/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78dd51fc72f1b6d7eadb5c18d3b768f42d8ee32b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: report if QEMU supports live snapshots
Francesco Romani has posted comments on this change. Change subject: caps: report if QEMU supports live snapshots .. Patch Set 5: Verified+1 Patch set 5: force the type to string for consistency. Verification: * added unit tests * used vdsClient and manually inspected the output * runned VDSM with a vanilla 3.5-master engine (everything works as expected) -- To view, visit http://gerrit.ovirt.org/26149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78dd51fc72f1b6d7eadb5c18d3b768f42d8ee32b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
Francesco Romani has posted comments on this change. Change subject: vm: avoid to reply with half-baked statistics .. Patch Set 3: Patch set 3: added and used a new error code -- To view, visit http://gerrit.ovirt.org/25803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: avoid to reply with half-baked statistics .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6897/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7687/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7799/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: report if QEMU supports live snapshots
Francesco Romani has posted comments on this change. Change subject: caps: report if QEMU supports live snapshots .. Patch Set 6: Verified+1 patch set 6: wrong c'n'p in spec file, no code changes, re-ticked verified flag. -- To view, visit http://gerrit.ovirt.org/26149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78dd51fc72f1b6d7eadb5c18d3b768f42d8ee32b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: report if QEMU supports live snapshots
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: report if QEMU supports live snapshots .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6898/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7688/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/418/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7800/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78dd51fc72f1b6d7eadb5c18d3b768f42d8ee32b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Introduce the network package
Francesco Romani has posted comments on this change. Change subject: network: Introduce the network package .. Patch Set 2: First things first: I really like this idea. But I strongly agree with Nir here: for the sake of ease of review, I think you should start with minimal changes like moving files and fixing imports without reorder them (which is of course good but to be done in a later patch). I'm ok with renaming files for good, since you are renaming them and git can track this. -- To view, visit http://gerrit.ovirt.org/25908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I532c179d4002ed1e8e5445d02297c8d5a6248647 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
Vinzenz Feenstra has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058206b7506ddbb5ec087c9ea0963a10ed57affb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/25803/3/vdsm/API.py
File vdsm/API.py:
Line 361: v = self._cif.vmContainer.get(self._UUID)
Line 362: if not v:
Line 363: return errCode['noVM']
Line 364: stats = v.getStats().copy()
Line 365: if not stats:
Yep, this was actually a typo of mine.
Hmm I am not sure if this is a good idea to return partial data. That might
have an unexpected impact on the engine because it might expect certain fields
when data is there which aren't there then.
This has to be verified that the engine does not make such assumptions.
Even more problematic I see other vdsm API consumers we really should follow
the API definition of optional and non-optional to make such a decision.
Line 366: return errCode['statsErr']
Line 367: stats['vmId'] = self._UUID
Line 368: return {'status': doneCode, 'statsList': [stats]}
Line 369:
http://gerrit.ovirt.org/#/c/25803/3/vdsm/vm.py
File vdsm/vm.py:
Line 2820: self.log.error(Error fetching vm stats, exc_info=True)
Line 2821: return stats
Line 2822:
Line 2823: def _getStatsInternal(self):
Line 2824: # used by API.Vm.getStats
the comment doesn't seem to be true actually, the only one calling this is
Yeah the getStatsInternal call was introduced during the merge of libvirtvm.py
and vm.py to avoid having to rewrite the logic of the code and by that
introduce bugs.
This was due to the fact that there is a return when the lastStatus is 'Down'
and I did not want to introduce non-trivial changes in the merge.
I'd be happy to see those two merged.
Line 2825:
Line 2826: def _getGuestStatus():
Line 2827: GUEST_WAIT_TIMEOUT = 60
Line 2828: now = time.time()
--
To view, visit http://gerrit.ovirt.org/25803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
Francesco Romani has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 7: Verified+1 Re-verified manually: * creation being tested during (still in progress) benchmarks * run cloud-init: OK * run boot from CDROM: OK * unit tests passes, no significant changes. -- To view, visit http://gerrit.ovirt.org/24636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058206b7506ddbb5ec087c9ea0963a10ed57affb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert vm status strings to constants
Francesco Romani has posted comments on this change. Change subject: Convert vm status strings to constants .. Patch Set 9: Verified+1 re-run same as for my previous comment tests on NFS storage, ticking verified. -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Francesco Romani has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 10: Verified+1 re-run same as for my previous comment tests on NFS storage, ticking verified. -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: avoid to reply with half-baked statistics .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6899/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7689/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7801/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
Francesco Romani has posted comments on this change. Change subject: vm: avoid to reply with half-baked statistics .. Patch Set 4: Patch set 4: actually discard partial stats as advertised -- To view, visit http://gerrit.ovirt.org/25803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
Michal Skrivanek has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/4/vdsm/vm.py
File vdsm/vm.py:
Line 2815: stats['hash'] = self._devXmlHash
Line 2816: if self._watchdogEvent:
Line 2817: stats[watchdogEvent] = self._watchdogEvent
Line 2818: except Exception:
Line 2819: self.log.error(Error fetching vm stats, exc_info=True)
what I meant is that partial stats may make sense. But we can only return them
iff the older engines are treating the errCode correctly
Line 2820: stats = {}
Line 2821: return stats
Line 2822:
Line 2823: def _getStatsInternal(self):
--
To view, visit http://gerrit.ovirt.org/25803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Introduce the network package
Antoni Segura Puimedon has posted comments on this change. Change subject: network: Introduce the network package .. Patch Set 2: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/25908/2/configure.ac File configure.ac: Line 268: vdsm-tool/Makefile Line 269: vdsm/Makefile Line 270: vdsm/gluster/Makefile Line 271: vdsm/network/configurators/Makefile Line 272: vdsm/network/Makefile Swap these two lines. Line 273: vdsm/sos/Makefile Line 274: vdsm/storage/Makefile Line 275: vdsm/storage/imageRepository/Makefile Line 276: vdsm/storage/protect/Makefile http://gerrit.ovirt.org/#/c/25908/2/vdsm/API.py File vdsm/API.py: Line 1: # Line 2: # Copyright (C) 2012-2014 Adam Litke, IBM Corporation 2012-2014 Red Hat. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or http://gerrit.ovirt.org/#/c/25908/2/vdsm/network/configurators/dhclient.py File vdsm/network/configurators/dhclient.py: Line 1: # Copyright (C) 2013-2014, IBM Corporation 2014 Red Hat Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or -- To view, visit http://gerrit.ovirt.org/25908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I532c179d4002ed1e8e5445d02297c8d5a6248647 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Introduce the network package
Dan Kenigsberg has posted comments on this change. Change subject: network: Introduce the network package .. Patch Set 2: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/25908/2/vdsm/API.py File vdsm/API.py: Line 1: # Line 2: # Copyright (C) 2012-2014 Adam Litke, IBM Corporation Toni, you are a Red Hat employee afaik Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or http://gerrit.ovirt.org/#/c/25908/2/vdsm/network/Makefile.am File vdsm/network/Makefile.am: Line 1: # Line 2: # Copyright 2014 Red Hat, Inc. Add new years... Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or http://gerrit.ovirt.org/#/c/25908/2/vdsm/write-net-config File vdsm/write-net-config: Line 1 kill this dead script - but in another patch. -- To view, visit http://gerrit.ovirt.org/25908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I532c179d4002ed1e8e5445d02297c8d5a6248647 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert vm status strings to constants
Dan Kenigsberg has posted comments on this change. Change subject: Convert vm status strings to constants .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert vm status strings to constants
Dan Kenigsberg has submitted this change and it was merged. Change subject: Convert vm status strings to constants .. Convert vm status strings to constants This patch replaces all vmstatuses to constants. Additionally added not documented 'Powering up' status to schema. Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21790 Reviewed-by: Francesco Romani from...@redhat.com Tested-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/functional/storageTests.py M tests/functional/virtTests.py M vdsm.spec.in M vdsm/API.py M vdsm/Makefile.am M vdsm/clientIF.py M vdsm/guestIF.py M vdsm/vm.py A vdsm/vmstatus.py M vdsm_api/vdsmapi-schema.json 10 files changed, 106 insertions(+), 56 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert vm status strings to constants
oVirt Jenkins CI Server has posted comments on this change. Change subject: Convert vm status strings to constants .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/419/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Dan Kenigsberg has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 10: (1 comment) Thanks! http://gerrit.ovirt.org/#/c/21792/10/vdsm/clientIF.py File vdsm/clientIF.py: Line 35: from virt import vm Line 36: from vdsm import constants Line 37: from vdsm import utils Line 38: import caps Line 39: from virt.vmChannels import Listener let's use this opportunity to rename the vmChannels to vmchannles. Line 40: from virt.vm import Vm Line 41: import blkid Line 42: import supervdsm Line 43: from virt import sampling -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Antoni Segura Puimedon has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 10: Code-Review-1
(7 comments)
Some minor changes.
http://gerrit.ovirt.org/#/c/21792/10/vdsm.spec.in
File vdsm.spec.in:
Line 933: %{_datadir}/%{vdsm_name}/tc.py*
Line 934: %{_datadir}/%{vdsm_name}/vdsm
Line 935: %{_datadir}/%{vdsm_name}/vdsm-restore-net-config
Line 936: %{_datadir}/%{vdsm_name}/vdsm-store-net-config
Line 937: %{_datadir}/%{vdsm_name}/virt/vm.py*
Please put the virt package together. Lines:
- 910,
- 930-932
- 937-939
- 960
- 1083
are the same package.
Line 938: %{_datadir}/%{vdsm_name}/virt/vmexitreason.py*
Line 939: %{_datadir}/%{vdsm_name}/virt/vmpowerdown.py*
Line 940:
Line 941: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/vdsm.conf
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/Makefile.am
File vdsm/virt/Makefile.am:
Line 1: #
Line 2: # Copyright 2013 Red Hat, Inc.
2014 for now ;-)
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/__init__.py
File vdsm/virt/__init__.py:
Line 1
Missing copyright notice for this beautiful blank line.
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/guestIF.py
File vdsm/virt/guestIF.py:
Line 25: import json
Line 26: import supervdsm
Line 27: import unicodedata
Line 28:
Line 29: import vmstatus
now that this is the virt package, this line should be
from . import vmstatus
Line 30:
Line 31: _MAX_SUPPORTED_API_VERSION = 0
Line 32: _IMPLICIT_API_VERSION_ZERO = 0
Line 33:
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 54: import caps
Line 55: import guestIF
Line 56: import hooks
Line 57: import kaxmlrpclib
Line 58: import sampling
from . import sampling
Line 59: import supervdsm
Line 60: import vmexitreason
Line 61: import vmstatus
Line 62:
Line 57: import kaxmlrpclib
Line 58: import sampling
Line 59: import supervdsm
Line 60: import vmexitreason
Line 61: import vmstatus
from . import vmstatus
And for the rest of imports of the virt package, the same.
Line 62:
Line 63: from vmpowerdown import VmShutdown, VmReboot
Line 64:
Line 65: _VMCHANNEL_DEVICE_NAME = 'com.redhat.rhevm.vdsm'
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/vmChannels.py
File vdsm/virt/vmChannels.py:
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
This file has been modified after 2012 IIRC
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit http://gerrit.ovirt.org/21792
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Rename vmChannels.py to vmchannels.py
Vinzenz Feenstra has uploaded a new change for review.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
virt: Rename vmChannels.py to vmchannels.py
Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
---
M debian/vdsm.install
M vdsm.spec.in
M vdsm/clientIF.py
M vdsm/virt/Makefile.am
R vdsm/virt/vmchannels.py
5 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/26192/1
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 8725d47..633f8fb 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -137,7 +137,7 @@
./usr/share/vdsm/virt/guestIF.py
./usr/share/vdsm/virt/sampling.py
./usr/share/vdsm/virt/vm.py
-./usr/share/vdsm/virt/vmChannels.py
+./usr/share/vdsm/virt/vmchannels.py
./usr/share/vdsm/virt/vmexitreason.py
./usr/share/vdsm/virt/vmpowerdown.py
./usr/share/vdsm/virt/vmstatus.py
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 896ef42..3fcd8b1 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -928,7 +928,7 @@
%{_datadir}/%{vdsm_name}/supervdsm.py*
%{_datadir}/%{vdsm_name}/supervdsmServer
%{_datadir}/%{vdsm_name}/virt/__init__.py*
-%{_datadir}/%{vdsm_name}/virt/vmChannels.py*
+%{_datadir}/%{vdsm_name}/virt/vmchannels.py*
%{_datadir}/%{vdsm_name}/virt/vmstatus.py*
%{_datadir}/%{vdsm_name}/tc.py*
%{_datadir}/%{vdsm_name}/vdsm
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index b171013..abf4c95 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -36,7 +36,7 @@
from vdsm import constants
from vdsm import utils
import caps
-from virt.vmChannels import Listener
+from virt.vmchannels import Listener
from virt.vm import Vm
import blkid
import supervdsm
diff --git a/vdsm/virt/Makefile.am b/vdsm/virt/Makefile.am
index bc7b8a3..16d4cda 100644
--- a/vdsm/virt/Makefile.am
+++ b/vdsm/virt/Makefile.am
@@ -26,7 +26,7 @@
guestIF.py \
sampling.py \
vm.py \
- vmChannels.py \
+ vmchannels.py \
vmexitreason.py \
vmpowerdown.py \
vmstatus.py \
diff --git a/vdsm/virt/vmChannels.py b/vdsm/virt/vmchannels.py
similarity index 100%
rename from vdsm/virt/vmChannels.py
rename to vdsm/virt/vmchannels.py
--
To view, visit http://gerrit.ovirt.org/26192
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6900/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7690/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/420/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7802/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Rename vmChannels.py to vmchannels.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Rename vmChannels.py to vmchannels.py .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6901/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7691/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/421/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7803/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Vinzenz Feenstra has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 10:
(6 comments)
http://gerrit.ovirt.org/#/c/21792/10/vdsm.spec.in
File vdsm.spec.in:
Line 933: %{_datadir}/%{vdsm_name}/tc.py*
Line 934: %{_datadir}/%{vdsm_name}/vdsm
Line 935: %{_datadir}/%{vdsm_name}/vdsm-restore-net-config
Line 936: %{_datadir}/%{vdsm_name}/vdsm-store-net-config
Line 937: %{_datadir}/%{vdsm_name}/virt/vm.py*
Please put the virt package together. Lines:
true true, and then again in this file is no order at all here
Line 938: %{_datadir}/%{vdsm_name}/virt/vmexitreason.py*
Line 939: %{_datadir}/%{vdsm_name}/virt/vmpowerdown.py*
Line 940:
Line 941: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/vdsm.conf
http://gerrit.ovirt.org/#/c/21792/10/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 35: from virt import vm
Line 36: from vdsm import constants
Line 37: from vdsm import utils
Line 38: import caps
Line 39: from virt.vmChannels import Listener
let's use this opportunity to rename the vmChannels to vmchannles.
The follow up commit for this has been submitted as:
http://gerrit.ovirt.org/26192
Line 40: from virt.vm import Vm
Line 41: import blkid
Line 42: import supervdsm
Line 43: from virt import sampling
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/Makefile.am
File vdsm/virt/Makefile.am:
Line 1: #
Line 2: # Copyright 2013 Red Hat, Inc.
2014 for now ;-)
The patch was originally done 2013, if at all we should update this to 2013-2014
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/__init__.py
File vdsm/virt/__init__.py:
Line 1
Missing copyright notice for this beautiful blank line.
Yay let's copyright all the blank files on this planet!
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/guestIF.py
File vdsm/virt/guestIF.py:
Line 25: import json
Line 26: import supervdsm
Line 27: import unicodedata
Line 28:
Line 29: import vmstatus
now that this is the virt package, this line should be
yes
Line 30:
Line 31: _MAX_SUPPORTED_API_VERSION = 0
Line 32: _IMPLICIT_API_VERSION_ZERO = 0
Line 33:
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/vmChannels.py
File vdsm/virt/vmChannels.py:
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
This file has been modified after 2012 IIRC
Unrelated to this patch though, but yes
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit http://gerrit.ovirt.org/21792
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
Francesco Romani has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
oVirt Jenkins CI Server has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6902/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7692/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7804/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Rename vmChannels.py to vmchannels.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Rename vmChannels.py to vmchannels.py .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6904/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7693/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/422/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7805/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6903/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7694/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/423/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7806/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: move threads in a separate module
Francesco Romani has posted comments on this change. Change subject: virt: migration: move threads in a separate module .. Patch Set 5: Verified+1 verification: * runned a few migration manually without problems since this patch just moves code around, marked verified. -- To view, visit http://gerrit.ovirt.org/25970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c7448b66417c7bba8ae3d301e7d777ca88067 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
Nir Soffer has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 8: Code-Review+1 This block importing pickle is little ugly, and repeating it everywhere increasing the ugliness. How about adding a lib/vdsm/compat.py module where we have this block once, and then do: from vdsm.compat import pickle There is probably other code that can go in that file. Otherwise this is good enough. -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
Francesco Romani has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 8: -Verified I like your proposal so much that I'm going to implement it and move this patch on top of it. -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Antoni Segura Puimedon has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 12: Code-Review+1 Thanks Vinzenz! -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Francesco Romani has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 12: Code-Review+1 Verified+1 the last changes seem to me small enough to not need to another round of testing, thus I'm reticking the verify flag. Let me know if some test has to be redone. -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Rename vmChannels.py to vmchannels.py
Dan Kenigsberg has posted comments on this change. Change subject: virt: Rename vmChannels.py to vmchannels.py .. Patch Set 2: I prefer to fix guestIF-guestagent, too, in one blow. Or have another followup. -- To view, visit http://gerrit.ovirt.org/26192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rename guestIF{, Tests}.py to guestagent{, Tests}.py
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Rename guestIF{,Tests}.py to guestagent{,Tests}.py
..
Rename guestIF{,Tests}.py to guestagent{,Tests}.py
Change-Id: I9f3f2068dd8f61538d76687cbf0c55c85d8eeb6e
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
---
M debian/vdsm.install
M tests/Makefile.am
R tests/guestagentTests.py
M vdsm.spec.in
M vdsm/virt/Makefile.am
R vdsm/virt/guestagent.py
M vdsm/virt/vm.py
7 files changed, 22 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/26195/1
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 633f8fb..87ba035 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -134,7 +134,7 @@
./usr/share/vdsm/vdsmDebugPlugin.py
./usr/share/vdsm/vdsmapi-schema.json
./usr/share/vdsm/virt/__init__.py
-./usr/share/vdsm/virt/guestIF.py
+./usr/share/vdsm/virt/guestagent.py
./usr/share/vdsm/virt/sampling.py
./usr/share/vdsm/virt/vm.py
./usr/share/vdsm/virt/vmchannels.py
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 37d1527..5ad5c0b 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -36,7 +36,7 @@
getAllVolumesTests.py \
gluster_cli_tests.py \
glusterTestData.py \
- guestIFTests.py \
+ guestagentTests.py \
hooksTests.py \
ipwrapperTests.py \
iscsiTests.py \
diff --git a/tests/guestIFTests.py b/tests/guestagentTests.py
similarity index 86%
rename from tests/guestIFTests.py
rename to tests/guestagentTests.py
index 1a6e6d2..63badef 100644
--- a/tests/guestIFTests.py
+++ b/tests/guestagentTests.py
@@ -20,7 +20,7 @@
#
import logging
from collections import namedtuple
-from virt import guestIF
+from virt import guestagent
import json
from testrunner import VdsmTestCase as TestCaseBase
@@ -85,32 +85,32 @@
class TestGuestIF(TestCaseBase):
def testfilterXmlChars(self):
ALL_LEGAL = uHello World
-self.assertEqual(ALL_LEGAL, guestIF._filterXmlChars(ALL_LEGAL))
+self.assertEqual(ALL_LEGAL, guestagent._filterXmlChars(ALL_LEGAL))
TM = u\u2122
-self.assertEqual(TM, guestIF._filterXmlChars(TM))
+self.assertEqual(TM, guestagent._filterXmlChars(TM))
invalid = u\u
-self.assertEqual(u'\ufffd', guestIF._filterXmlChars(invalid))
+self.assertEqual(u'\ufffd', guestagent._filterXmlChars(invalid))
invalid2 = u\u
-self.assertEqual(u'\ufffd', guestIF._filterXmlChars(invalid2))
+self.assertEqual(u'\ufffd', guestagent._filterXmlChars(invalid2))
invalid3 = u\ufffe
-self.assertEqual(u'\ufffd', guestIF._filterXmlChars(invalid3))
+self.assertEqual(u'\ufffd', guestagent._filterXmlChars(invalid3))
invalid4 = u\ud800
-self.assertEqual(u'\ufffd', guestIF._filterXmlChars(invalid4))
+self.assertEqual(u'\ufffd', guestagent._filterXmlChars(invalid4))
invalid5 = u\udc79
-self.assertEqual(u'\ufffd', guestIF._filterXmlChars(invalid5))
+self.assertEqual(u'\ufffd', guestagent._filterXmlChars(invalid5))
def test_filterObject(self):
ILLEGAL_DATA = {ufoo: u\x00data\x00test\u\ufffe\ud800\udc79}
LEGAL_DATA = {ufoo: u?data?test\U0001}
EXPECTED_DATA = {
ufoo: u\ufffddata\ufffdtest\ufffd\ufffd\ufffd\ufffd}
-self.assertEqual(EXPECTED_DATA, guestIF._filterObject(ILLEGAL_DATA))
-self.assertEqual(LEGAL_DATA, guestIF._filterObject(LEGAL_DATA))
+self.assertEqual(EXPECTED_DATA, guestagent._filterObject(ILLEGAL_DATA))
+self.assertEqual(LEGAL_DATA, guestagent._filterObject(LEGAL_DATA))
def test_handleMessage(self):
logging.TRACE = 5
-fakeGuestAgent = guestIF.GuestAgent(None,
-None, self.log, connect=False)
+fakeGuestAgent = guestagent.GuestAgent(None, None, self.log,
+ connect=False)
testCase = namedtuple('testCase', 'msgType, message, assertDict')
for t in zip(_MSG_TYPES, _INPUTS, _OUTPUTS):
@@ -129,8 +129,8 @@
# perform general setup tasks
def setUp(self):
logging.TRACE = 5
-self.fakeGuestAgent = guestIF.GuestAgent(None, None, self.log,
- connect=False)
+self.fakeGuestAgent = guestagent.GuestAgent(None, None, self.log,
+connect=False)
self.fakeGuestAgent.MAX_MESSAGE_SIZE = 100
self.maxMessageSize = self.fakeGuestAgent.MAX_MESSAGE_SIZE
self.fakeGuestAgent._clearReadBuffer()
@@ -179,11 +179,11 @@
self.fakeGuestAgent._handleData(chunk)
if chunk[-1] != '\n':
self.assertEqual(self.fakeGuestAgent._messageState,
-
Change in vdsm[master]: virt: Rename vmChannels.py to vmchannels.py
Antoni Segura Puimedon has posted comments on this change. Change subject: virt: Rename vmChannels.py to vmchannels.py .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Dan Kenigsberg has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 12: Code-Review+2 I think it's safe enough, too. -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 6:
(2 comments)
Code should be simplified and errors must be handled.
http://gerrit.ovirt.org/#/c/25877/6/vdsm/sampling.py
File vdsm/sampling.py:
Line 151: def getBootTime(filepath=None):
Line 152: if filepath is None:
Line 153: filepath = '/proc/stat'
Line 154:
Line 155: with file(filepath) as f:
We don't need the filepath arguemnt or temporary, just use literally use it:
with file('/proc/stat') as f:
...
Line 156: btime_line = [l for l in f.readlines() if
l.startswith('btime')][0]
Line 157: return int(btime_line.split()[-1])
Line 158:
Line 159:
Line 153: filepath = '/proc/stat'
Line 154:
Line 155: with file(filepath) as f:
Line 156: btime_line = [l for l in f.readlines() if
l.startswith('btime')][0]
Line 157: return int(btime_line.split()[-1])
I don't see any need for a list comprehension here. I guess that we should have
one such line, so this simple code is much more clear (it is also more
efficient but nobody cares).
The code should say - find the btime line and return the value.
for line in f:
if line.startswith('btime'):
return int(line.split()[-1])
Now line.split()[-1] assumes that the format is key value. If the format will
change in the future (unlikely) to key value1 value2, you will silently take
the last value, instead of the first value. So more forward compatible code may
be:
line.split()[1]
Finally we should handle the case where there is no such value. Your code will
raise IndexError, which is not an error from the domain of time keeping.
So either raise proper error, or use alternative method to get this value, like
using /proc/uptime and current time.
Line 158:
Line 159:
Line 160: class HostSample(BaseSample):
Line 161:
--
To view, visit http://gerrit.ovirt.org/25877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Tal Nisan tni...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/25877/6/tests/samplingTests.py
File tests/samplingTests.py:
Line 60: os.remove(path)
Line 61:
Line 62: def testBootTimeEmpty(self):
Line 63: with self.assertRaises(IndexError):
Line 64: sampling.getBootTime('/dev/null')
This test document the wrong error handling in this code. Does it make sense
that getBootTime raise an IndexError?
This error is just a side effect of the current implementation, and should not
be part of the api.
Line 65:
Line 66: def testBootTimeMalformed(self):
Line 67: (f, path) = tempfile.mkstemp()
Line 68: os.write(f, self.boot_time_fixture_bad)
--
To view, visit http://gerrit.ovirt.org/25877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Tal Nisan tni...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
Nir Soffer has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 6: Code-Review-1 Not ready -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
Francesco Romani has uploaded a new change for review.
Change subject: py3: introduce a compatibility helper
..
py3: introduce a compatibility helper
introduce a module to host all the compatibility
code we need to support python2 and python3 with
the same codebase.
Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed
Signed-off-by: Francesco Romani from...@redhat.com
---
M debian/vdsm-python.install
M lib/vdsm/Makefile.am
A lib/vdsm/compat.py
M vdsm.spec.in
4 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/26196/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 7a78042..135860f 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -2,6 +2,7 @@
./usr/bin/vdsm-tool
./usr/lib/python2.7/dist-packages/vdsm/SecureXMLRPCServer.py
./usr/lib/python2.7/dist-packages/vdsm/__init__.py
+./usr/lib/python2.7/dist-packages/vdsm/compat.py
./usr/lib/python2.7/dist-packages/vdsm/config.py
./usr/lib/python2.7/dist-packages/vdsm/constants.py
./usr/lib/python2.7/dist-packages/vdsm/define.py
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 8575887..223edc7 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -23,6 +23,7 @@
dist_vdsmpylib_PYTHON = \
__init__.py \
+ compat.py \
define.py \
exception.py \
ipwrapper.py \
diff --git a/lib/vdsm/compat.py b/lib/vdsm/compat.py
new file mode 100644
index 000..a183198
--- /dev/null
+++ b/lib/vdsm/compat.py
@@ -0,0 +1,26 @@
+#
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+try:
+import cPickle as pickle
+except ImportError: # py3
+import pickle
+
+pickle # make pyflakes happy
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 64dce6e..a3343e3 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1129,6 +1129,7 @@
%dir %{python_sitearch}/%{vdsm_name}
%dir %{python_sitearch}/%{vdsm_name}/tool
%{python_sitearch}/%{vdsm_name}/__init__.py*
+%{python_sitearch}/%{vdsm_name}/compat.py*
%{python_sitearch}/%{vdsm_name}/config.py*
%{python_sitearch}/%{vdsm_name}/constants.py*
%{python_sitearch}/%{vdsm_name}/define.py*
--
To view, visit http://gerrit.ovirt.org/26196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
Francesco Romani has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/25860/9/vdsm/storage/remoteFileHandler.py File vdsm/storage/remoteFileHandler.py: Line 28: try: Line 29: import cPickle as pickle Line 30: pickle # make pyflakes happy Line 31: except ImportError: # py3 Line 32: import pickle Here and in storageServer: not sure we can use lib/vdsm code, will have a deeper look ASAP. Line 33: import signal Line 34: import sys Line 35: import select Line 36: from contextlib import contextmanager -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
Nir Soffer has posted comments on this change. Change subject: py3: introduce a compatibility helper .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rename guestIF{, Tests}.py to guestagent{, Tests}.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename guestIF{,Tests}.py to guestagent{,Tests}.py
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6906/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7696/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/425/ :
SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7808/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/26195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f3f2068dd8f61538d76687cbf0c55c85d8eeb6e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
Nir Soffer has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/25860/9/vdsm/storage/remoteFileHandler.py File vdsm/storage/remoteFileHandler.py: Line 28: try: Line 29: import cPickle as pickle Line 30: pickle # make pyflakes happy Line 31: except ImportError: # py3 Line 32: import pickle Here and in storageServer: not sure we can use lib/vdsm code, will have a d I think we can, this is the concept of the library, you can use it everywhere. Line 33: import signal Line 34: import sys Line 35: import select Line 36: from contextlib import contextmanager -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rename guestIF{, Tests}.py to guestagent{, Tests}.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename guestIF{,Tests}.py to guestagent{,Tests}.py
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6905/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7695/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/424/ :
SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7807/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/26195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f3f2068dd8f61538d76687cbf0c55c85d8eeb6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rename guestIF{, Tests}.py to guestagent{, Tests}.py
Antoni Segura Puimedon has posted comments on this change.
Change subject: Rename guestIF{,Tests}.py to guestagent{,Tests}.py
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f3f2068dd8f61538d76687cbf0c55c85d8eeb6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6907/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7697/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/426/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7809/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Rename vmChannels.py to vmchannels.py
Antoni Segura Puimedon has posted comments on this change. Change subject: virt: Rename vmChannels.py to vmchannels.py .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi.py: cleanup - remove temp variable
Dan Kenigsberg has posted comments on this change. Change subject: iscsi.py: cleanup - remove temp variable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb581010fab9f56de22c34b67b91b88f8ca3612f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Antoni Segura Puimedon has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
oVirt Jenkins CI Server has posted comments on this change. Change subject: py3: introduce a compatibility helper .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6910/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7700/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/428/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7812/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
Francesco Romani has posted comments on this change. Change subject: py3: introduce a compatibility helper .. Patch Set 1: make rpm runs smoothly on F20, will try on RHEL before to tick as verified. -- To view, visit http://gerrit.ovirt.org/26196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Rename vmChannels.py to vmchannels.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Rename vmChannels.py to vmchannels.py .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6908/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7698/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/427/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7810/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: fencing: stop using a deprecated command
Dan Kenigsberg has abandoned this change. Change subject: fencing: stop using a deprecated command .. Abandoned No urgency here, let's avoid the backporting headache. -- To view, visit http://gerrit.ovirt.org/26075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
Antoni Segura Puimedon has posted comments on this change. Change subject: py3: introduce a compatibility helper .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
Dan Kenigsberg has posted comments on this change. Change subject: py3: introduce a compatibility helper .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
oVirt Jenkins CI Server has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6909/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7699/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7811/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
oVirt Jenkins CI Server has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6911/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7701/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7813/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: collect vdsm-config.log
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-reg: collect vdsm-config.log .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: collect vdsm-config.log
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-reg: collect vdsm-config.log .. vdsm-reg: collect vdsm-config.log vdsm-config's log file was dumped in the catch-all /var/log directory. Placing it under /var/log/vdsm-reg makes a nicer compartmentalization, and makes vdsm's sosreport plugin collect it. Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24862 Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Tested-by: Douglas Schilling Landgraf dougsl...@redhat.com --- M vdsm_reg/vdsm-config 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Francesco Romani has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 13: Verified+1 re-verified using functional tests http://paste.fedoraproject.org/89516/ some glitches reported, but look unrelated, thus ticking verified. -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VmStatsThread: make _getNicStats testable
Antoni Segura Puimedon has posted comments on this change. Change subject: VmStatsThread: make _getNicStats testable .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: remove unused properties
Antoni Segura Puimedon has posted comments on this change. Change subject: oop: remove unused properties .. Patch Set 1: Could you put this patch on a topic branch so that the following patches are tied together with this one. Maybe the topic branch description could talk about the move from oop to ioprocess as well. -- To view, visit http://gerrit.ovirt.org/26174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35f3fae66a4ec71dea99f22d7e085f811f1e1b55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VmStatsThread: make _getNicStats testable
oVirt Jenkins CI Server has posted comments on this change. Change subject: VmStatsThread: make _getNicStats testable .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6912/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7702/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7814/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6914/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7704/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7816/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VmStatsThread: make _getNicStats testable
Dan Kenigsberg has posted comments on this change. Change subject: VmStatsThread: make _getNicStats testable .. Patch Set 5: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25982/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 622 Line 623 Line 624 Line 625 Line 626 Swallowing those exceptions is not required anymore? Indeed! It was quite evil to begin with. TypeError was caused when there's only one sample, and start_sample = end_sample = None. That's avoided by the new if sInfo is None: return ZeroDivisionError is from the ages before ifSpeed was calculated in-function. And KeyError? I think you've got me here. My suggested code may explode on hot-plug. -- To view, visit http://gerrit.ovirt.org/25982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VmStatsThread: make _getNicStats testable
Vinzenz Feenstra has posted comments on this change. Change subject: VmStatsThread: make _getNicStats testable .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/25982/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 622 Line 623 Line 624 Line 625 Line 626 Swallowing those exceptions is not required anymore? -- To view, visit http://gerrit.ovirt.org/25982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VmStatsThread: make _getNicStats testable
Vinzenz Feenstra has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/25982/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 590: self._log.debug(CPU stats not available: %s, e)
Line 591: stats['cpuUser'] = 0.0
Line 592: stats['cpuSys'] = 0.0
Line 593:
Line 594: def _getNicStats(self, name, model, mac,
@staticmethod?
Line 595: start_sample, end_sample, interval):
Line 596: ifSpeed = [100, 1000][model in ('e1000', 'virtio')]
Line 597:
Line 598: ifStats = {'macAddr': mac,
--
To view, visit http://gerrit.ovirt.org/25982
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6913/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7703/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7815/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rename guestIF{, Tests}.py to guestagent{, Tests}.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename guestIF{,Tests}.py to guestagent{,Tests}.py
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/433/ :
SUCCESS
--
To view, visit http://gerrit.ovirt.org/26195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f3f2068dd8f61538d76687cbf0c55c85d8eeb6e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
oVirt Jenkins CI Server has posted comments on this change. Change subject: py3: introduce a compatibility helper .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6919/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7709/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/431/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7821/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Rename vmChannels.py to vmchannels.py
Dan Kenigsberg has posted comments on this change. Change subject: virt: Rename vmChannels.py to vmchannels.py .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
Francesco Romani has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/4/vdsm/vm.py
File vdsm/vm.py:
Line 2815: stats['hash'] = self._devXmlHash
Line 2816: if self._watchdogEvent:
Line 2817: stats[watchdogEvent] = self._watchdogEvent
Line 2818: except Exception:
Line 2819: self.log.error(Error fetching vm stats, exc_info=True)
what I meant is that partial stats may make sense. But we can only return t
Ok, will verify on the engine side.
Line 2820: stats = {}
Line 2821: return stats
Line 2822:
Line 2823: def _getStatsInternal(self):
--
To view, visit http://gerrit.ovirt.org/25803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: Normalize shutdown timeout
Dan Kenigsberg has posted comments on this change. Change subject: init: Normalize shutdown timeout .. Patch Set 2: Code-Review-1 Allon, Liron: if Vdsm holds the SPM, but is non-responsive, when is it fenced? This patch adds 8 more seconds to the non-responsiveness interval on el6. I'm marking with -1 only to make sure this patch does not get in before we get Engine's consent. -- To view, visit http://gerrit.ovirt.org/26111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5434caff5bc95e2a76345191dec9ce4e33070a57 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika elimes...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
Dan Kenigsberg has submitted this change and it was merged. Change subject: py3: introduce a compatibility helper .. py3: introduce a compatibility helper introduce a module to host all the compatibility code we need to support python2 and python3 with the same codebase. Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/26196 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm-python.install M lib/vdsm/Makefile.am A lib/vdsm/compat.py M vdsm.spec.in 4 files changed, 29 insertions(+), 0 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/26196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
Francesco Romani has posted comments on this change. Change subject: py3: introduce a compatibility helper .. Patch Set 2: rebased and added fix for old pyflake -- To view, visit http://gerrit.ovirt.org/26196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
Dan Kenigsberg has submitted this change and it was merged. Change subject: performance: switch to cPickle .. performance: switch to cPickle profiling of the creation code path shows that the impact of pickle is not negligible. cPickle is a safe drop-in replacement, so this patch switch to it for the sake of performance. considering a 'monday morning' scenario (mass parallel start of many VMs) we see ~5% improvement in startup time before: mean: 27.984s stdev=1.074s best: 10.507s stdev=1.604s worst: 42.711s stdev=1.996s total: 895.479s stdev=34.375s after: mean: 26.423s stdev=1.413s best: 9.785s stdev=1.669s worst: 40.833s stdev=2.452s total: 845.523s stdev=45.218s pickle is used to save the VM params for checkpointing, so the benefits should affect, possibly with lower extent, to all VM operation flows. Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25860 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/API.py M vdsm/clientIF.py M vdsm/storage/remoteFileHandler.py M vdsm/storage/storageServer.py M vdsm/virt/vm.py 5 files changed, 6 insertions(+), 5 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: make virtTests run on RHEL/CentOS
Francesco Romani has posted comments on this change. Change subject: tests: make virtTests run on RHEL/CentOS .. Patch Set 1: Verified+1 verified running the tests. -- To view, visit http://gerrit.ovirt.org/26198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I248acbf03fa86585b74e3c6e8c76afe31561663d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
Dan Kenigsberg has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 8: Code-Review-1
(2 comments)
some more small comments
http://gerrit.ovirt.org/#/c/25977/8/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 356: self._progressTimeout = config.getint('vars',
Line 357:
'migrationprogressTimeout')
Line 358:
Line 359: self._downtime = downTime
Line 360: delayPerGiB = config.getint('vars',
'migration_downtime_delay')
I'd make this a constant.
Line 361: self._wait = (delayPerGiB * max(memSize, 2048) + 1023) / 1024
Line 362: self._downtimeInterval = self._wait / self.DOWNTIME_STEPS
Line 363: self._downtimeStep = 0
Line 364:
Line 440: def update_downtime(self, i):
Line 441: return self._downtime * (i + 1) / self.DOWNTIME_STEPS
Line 442:
Line 443: def monitor_downtime(self, step):
Line 444: if self._downtimeStep self.DOWNTIME_STEPS and \
prefer parenthesis to escaping line breaks.
Line 445:step % self._downtimeInterval == 0:
Line 446: downtime = self.update_downtime(self._downtimeStep)
Line 447: self._vm.log.debug('setting migration downtime to %d',
downtime)
Line 448: self._vm._dom.migrateSetMaxDowntime(downtime, 0)
--
To view, visit http://gerrit.ovirt.org/25977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Rename vmChannels.py to vmchannels.py
Francesco Romani has posted comments on this change. Change subject: virt: Rename vmChannels.py to vmchannels.py .. Patch Set 3: Verified+1 verified using functional tests on F19. -- To view, visit http://gerrit.ovirt.org/26192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Introduce the network package
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Introduce the network package .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6925/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7715/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/435/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1179/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7827/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I532c179d4002ed1e8e5445d02297c8d5a6248647 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: make virtTests run on RHEL/CentOS
Francesco Romani has posted comments on this change.
Change subject: tests: make virtTests run on RHEL/CentOS
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26198/1/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 282: def testVmWithCdrom(self, pathLocation):
Line 283: customization = {'vmId':
'----',
Line 284: 'devices': [],
Line 285: 'vmName':
Line 286: ('testVmWithCdrom_{0}').format(pathLocation)}
Since almost all the codebase uses % formatting and we agreed on that, mayb
I was actually wondering why this was different. Will fix.
Line 287:
Line 288: # echo -n testPayload | md5sum
Line 289: # d37e46c24c78b1aed33496107afdb44b
Line 290: vmPayloadName = ('/var/run/vdsm/payload/{0}.'
--
To view, visit http://gerrit.ovirt.org/26198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I248acbf03fa86585b74e3c6e8c76afe31561663d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 7: Code-Review-1
(2 comments)
Minor comments
http://gerrit.ovirt.org/#/c/25976/7/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 388: self.progress = 0
Line 389:
Line 390: memSize = int(self._vm.conf['memSize'])
Line 391: maxTimePerGiB = config.getint('vars',
Line 392: 'migrationMaxTime_per_gib_mem')
what about having maxTimePerGib be loaded after the imports as a constant
MAX_TIME_PER_GIB = config.getint('vars', 'migrationprogressTimeour')
Line 393: self._migrationMaxTime = (maxTimePerGiB * memSize + 1023) /
1024
Line 394: self._progressTimeout = config.getint('vars',
Line 395:
'migrationprogressTimeout')
Line 396:
Line 391: maxTimePerGiB = config.getint('vars',
Line 392: 'migrationMaxTime_per_gib_mem')
Line 393: self._migrationMaxTime = (maxTimePerGiB * memSize + 1023) /
1024
Line 394: self._progressTimeout = config.getint('vars',
Line 395:
'migrationprogressTimeout')
Same thing here, I don't think it should be an instance variable. It is
read-only and a configuration value.
Line 396:
Line 397: @property
Line 398: def enabled(self):
Line 399: return MigrationMonitorThread._MIGRATION_MONITOR_INTERVAL 0
--
To view, visit http://gerrit.ovirt.org/25976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
Antoni Segura Puimedon has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
Francesco Romani has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/25977/8/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 356: self._progressTimeout = config.getint('vars',
Line 357:
'migrationprogressTimeout')
Line 358:
Line 359: self._downtime = downTime
Line 360: delayPerGiB = config.getint('vars',
'migration_downtime_delay')
I'd make this a constant.
Done
Line 361: self._wait = (delayPerGiB * max(memSize, 2048) + 1023) / 1024
Line 362: self._downtimeInterval = self._wait / self.DOWNTIME_STEPS
Line 363: self._downtimeStep = 0
Line 364:
Line 440: def update_downtime(self, i):
Line 441: return self._downtime * (i + 1) / self.DOWNTIME_STEPS
Line 442:
Line 443: def monitor_downtime(self, step):
Line 444: if self._downtimeStep self.DOWNTIME_STEPS and \
prefer parenthesis to escaping line breaks.
Done
Line 445:step % self._downtimeInterval == 0:
Line 446: downtime = self.update_downtime(self._downtimeStep)
Line 447: self._vm.log.debug('setting migration downtime to %d',
downtime)
Line 448: self._vm._dom.migrateSetMaxDowntime(downtime, 0)
--
To view, visit http://gerrit.ovirt.org/25977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VmStatsThread: make _getNicStats testable
Antoni Segura Puimedon has posted comments on this change. Change subject: VmStatsThread: make _getNicStats testable .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: make virtTests run on RHEL/CentOS
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: make virtTests run on RHEL/CentOS .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6923/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7713/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7825/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I248acbf03fa86585b74e3c6e8c76afe31561663d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: always run migration monitor
Antoni Segura Puimedon has posted comments on this change. Change subject: virt: migration: always run migration monitor .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/25975/6/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 294:'with miguri %s', duri, muri) Line 295: Line 296: t = MigrationDowntimeThread(self._vm, int(self._downtime)) Line 297: Line 298: self._monitorThread = MigrationMonitorThread(self._vm, doesn't this fit all in 80 chars? Line 299: startTime) Line 300: self._monitorThread.start() Line 301: Line 302: try: -- To view, visit http://gerrit.ovirt.org/25975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4953ddda5a5c6c0ecd7ea0f95377309e18f771a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: Normalize shutdown timeout
Antoni Segura Puimedon has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26111/2/init/sysvinit/vdsmd.init.in
File init/sysvinit/vdsmd.init.in:
Line 137: log_failure_msg $prog: not running
Line 138: RETVAL=0
Line 139: else
Line 140: # Give process enough time for saving profiling data
Line 141: killproc -p $PIDFILE -d 10
Can we have this '10' be declared in the top of the script with a similar name
as what it has in systemd?
Line 142: RETVAL=$?
Line 143: [ $RETVAL = 0 ] @RM_PATH@ -f $LOCK_FILE /dev/null
21
Line 144: fi
Line 145: ${VDSMD_INIT_COMMON} --post-stop
--
To view, visit http://gerrit.ovirt.org/26111
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5434caff5bc95e2a76345191dec9ce4e33070a57
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eli Mesika elimes...@gmail.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Introduce the network package
Antoni Segura Puimedon has posted comments on this change. Change subject: network: Introduce the network package .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25908/2/vdsm/network/Makefile.am File vdsm/network/Makefile.am: Line 1: # Line 2: # Copyright 2014 Red Hat, Inc. Add new years... This is a new file, so it should only have 2014. The diff is wrong in showing it compared to vdsm/netconf/Makefile.am Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit http://gerrit.ovirt.org/25908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I532c179d4002ed1e8e5445d02297c8d5a6248647 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Rename vmChannels.py to vmchannels.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Rename vmChannels.py to vmchannels.py .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/432/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
oVirt Jenkins CI Server has posted comments on this change. Change subject: py3: introduce a compatibility helper .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/434/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3: introduce a compatibility helper
Dan Kenigsberg has posted comments on this change. Change subject: py3: introduce a compatibility helper .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2af4ccecf72045695ea263c1fc36ef9f76a499ed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: make virtTests run on RHEL/CentOS
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: make virtTests run on RHEL/CentOS .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6924/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7714/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7826/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I248acbf03fa86585b74e3c6e8c76afe31561663d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: always run migration monitor
Francesco Romani has posted comments on this change. Change subject: virt: migration: always run migration monitor .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/25975/6/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 294:'with miguri %s', duri, muri) Line 295: Line 296: t = MigrationDowntimeThread(self._vm, int(self._downtime)) Line 297: Line 298: self._monitorThread = MigrationMonitorThread(self._vm, doesn't this fit all in 80 chars? 78! fixed! Line 299: startTime) Line 300: self._monitorThread.start() Line 301: Line 302: try: -- To view, visit http://gerrit.ovirt.org/25975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4953ddda5a5c6c0ecd7ea0f95377309e18f771a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/25976/7/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 388: self.progress = 0
Line 389:
Line 390: memSize = int(self._vm.conf['memSize'])
Line 391: maxTimePerGiB = config.getint('vars',
Line 392: 'migrationMaxTime_per_gib_mem')
what about having maxTimePerGib be loaded after the imports as a constant M
Done
Line 393: self._migrationMaxTime = (maxTimePerGiB * memSize + 1023) /
1024
Line 394: self._progressTimeout = config.getint('vars',
Line 395:
'migrationprogressTimeout')
Line 396:
Line 391: maxTimePerGiB = config.getint('vars',
Line 392: 'migrationMaxTime_per_gib_mem')
Line 393: self._migrationMaxTime = (maxTimePerGiB * memSize + 1023) /
1024
Line 394: self._progressTimeout = config.getint('vars',
Line 395:
'migrationprogressTimeout')
Same thing here, I don't think it should be an instance variable. It is rea
Done
Line 396:
Line 397: @property
Line 398: def enabled(self):
Line 399: return MigrationMonitorThread._MIGRATION_MONITOR_INTERVAL 0
--
To view, visit http://gerrit.ovirt.org/25976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
