Change in vdsm[master]: gluster: verbs to enable/disable snapshot scheduling.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: verbs to enable/disable snapshot scheduling. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: monitor: return whether the reported status is actual
Federico Simoncelli has posted comments on this change. Change subject: monitor: return whether the reported status is actual .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: no need to log when network persistence path doesn'...
Dan Kenigsberg has posted comments on this change. Change subject: network: no need to log when network persistence path doesn't exist. .. Patch Set 2: I must remind you of your own comment to https://gerrit.ovirt.org/#/c/37418/1/lib/vdsm/netconfpersistence.py -- To view, visit https://gerrit.ovirt.org/40415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f998b5ec7a5d0d07e35afdcc9a9d76b42b3c6a0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require libvirt-python supporting blockCopy
Dan Kenigsberg has posted comments on this change. Change subject: spec: Require libvirt-python supporting blockCopy .. Patch Set 7: please introduce this change in the spec with the code that actually needs it. -- To view, visit https://gerrit.ovirt.org/40069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbafbfeb61f392bf420caa4589df7cdac92a6568 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Nir Soffer has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 47: # TODO: use introspection
Line 48: return (cls.NONE, cls.EXCLUSIVE, cls.SHARED, cls.TRANSIENT)
Line 49:
Line 50:
Line 51: def spec_list_from_legacy_conf(conf, arch):
This function extracts *disk specs* from legacy conf. As such, it is very m
I don't want to maintain this here. Please don't make my life harder.
And this must not be at the top of the module.
Line 52:
Line 53: Returns a list of drive specification dictionaries from legacy
vm.conf
Line 54:
Line 55: conf_drives = conf.get('drives', [])
Line 73:
Line 74: def _spec_list_from_legacy_direct_paths(conf):
Line 75:
Line 76: Backward compatibility for qa scripts that specify direct paths.
Line 77:
Michal mentions that we have to keep support of legacy devices as long as w
The conversion from legacy format to current format should be handled
elsewhere, ideally in one place - leagacy.py or format.py.
Line 78: legacies = []
Line 79: device_spec = ((0, 'hda'), (1, 'hdb'), (2, 'hdc'), (3, 'hdd'))
Line 80: for index, linux_name in device_spec:
Line 81: path = conf.get(linux_name)
--
To view, visit https://gerrit.ovirt.org/40133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: revamp in geo-replication status and list verbs.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: revamp in geo-replication status and list verbs. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9405e936b69e9dd4d2ed6621cfc1c70752def26 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: no need to log when network persistence path doesn'...
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: no need to log when network persistence path doesn't exist. .. network: no need to log when network persistence path doesn't exist. When RunningConfig is instantiated, its underlying directory structure may not exist. This is perfectly OK on the start-up of a process. We prefer dropping the messages over having __init__ with side effects on the file system. The dropped messages were contaminating supervdsm.log and are a source of confusion and red herrings. Change-Id: I6f998b5ec7a5d0d07e35afdcc9a9d76b42b3c6a0 Signed-off-by: Ido Barkan ibar...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40415 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/netconfpersistence.py 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: Ido Barkan: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f998b5ec7a5d0d07e35afdcc9a9d76b42b3c6a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: no need to log when network persistence path doesn'...
automat...@ovirt.org has posted comments on this change. Change subject: network: no need to log when network persistence path doesn't exist. .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f998b5ec7a5d0d07e35afdcc9a9d76b42b3c6a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: no need to log when network persistence path doesn'...
automat...@ovirt.org has posted comments on this change. Change subject: network: no need to log when network persistence path doesn't exist. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f998b5ec7a5d0d07e35afdcc9a9d76b42b3c6a0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: no need to log when network persistence path doesn'...
Dan Kenigsberg has posted comments on this change. Change subject: network: no need to log when network persistence path doesn't exist. .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f998b5ec7a5d0d07e35afdcc9a9d76b42b3c6a0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add allocation type for disk conversion
Francesco Romani has posted comments on this change. Change subject: v2v: Add allocation type for disk conversion .. Patch Set 1: Code-Review+1 scrap my previous comment. -- To view, visit https://gerrit.ovirt.org/40533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3ca2983455adbb51f11957e0ce042b0cfc5ef1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 12: Code-Review-1 we need to write only to runningConfig and drop the checkConnectivity behavior. setSafeConfig should handle the persisting. -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: avoid python3-inconsistent syntax
Dan Kenigsberg has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40215/3/Makefile.am File Makefile.am: Line 134: if [ -x $(PYTHON3) ]; \ Line 135: then \ Line 136: $(PYTHON3) -m compileall `find . -name '*.py' -o -name '*.py.in'`; \ Line 137: else \ Line 138: echo Warning: skipping python3 syntax check; \ This should not be a warning. I don't want to hard-build-require the existence of Python 3 as of yet. It would only slow down builds in koji etc. Do you think otherwise? Line 139: fi Line 140: Line 141: # Note: dependencies ordered by time needed to run them Line 142: check-recursive: gitignore python3 pyflakes pep8 -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add systemd_run command modifier
automat...@ovirt.org has posted comments on this change. Change subject: utils: Add systemd_run command modifier .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35bdae752228b6716c25f0b9975fc500897a592 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: wait for udev after configuring SRIOV
Dan Kenigsberg has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 7: Code-Review+1 horrible sleep, but reasonable as a stop-gap. -- To view, visit https://gerrit.ovirt.org/40400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04d63ca35aab585051c3d0a5f2652dbf2f91b080 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm payload: Add Joliet FS support
Eldan Shachar has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 2: verified by 1. sanity - use a payload with a long file name and make sure it's not displayed properly on windows. 2. apply patch and verify the file name is displayed correctly on both linux and windows systems (one from each). -- To view, visit https://gerrit.ovirt.org/39900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eldan Shachar eshac...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eldan Shachar eshac...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: avoid python3-inconsistent syntax
Nir Soffer has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40215/3/Makefile.am File Makefile.am: Line 134: if [ -x $(PYTHON3) ]; \ Line 135: then \ Line 136: $(PYTHON3) -m compileall `find . -name '*.py' -o -name '*.py.in'`; \ Line 137: else \ Line 138: echo Warning: skipping python3 syntax check; \ I don't want to hard-build-require the existence of Python 3 as of yet. It I agree, just remove the Warning: prefix. It is ok to build vdsm when python 3 is not installed, nothing to warn about. Line 139: fi Line 140: Line 141: # Note: dependencies ordered by time needed to run them Line 142: check-recursive: gitignore python3 pyflakes pep8 -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconfpersistence: refactor _getConfig and _clearDisk
Dan Kenigsberg has abandoned this change. Change subject: netconfpersistence: refactor _getConfig and _clearDisk .. Abandoned https://gerrit.ovirt.org/40415 -- To view, visit https://gerrit.ovirt.org/37418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ifaf1cca94d184d079a06e07a9b4d5d2bcca42377 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconfpersistence: refactor _getConfig and _clearDisk
automat...@ovirt.org has posted comments on this change. Change subject: netconfpersistence: refactor _getConfig and _clearDisk .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/37418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf1cca94d184d079a06e07a9b4d5d2bcca42377 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: cleanup v2v directory leftovers
Francesco Romani has posted comments on this change. Change subject: v2v: cleanup v2v directory leftovers .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f5b63863f4f7dc85d6af0ca015099274715441 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add allocation type for disk conversion
Francesco Romani has posted comments on this change. Change subject: v2v: Add allocation type for disk conversion .. Patch Set 1: (1 comment) codewise looks fine, we just need a bit more context https://gerrit.ovirt.org/#/c/40533/1//COMMIT_MSG Commit Message: Line 4: Commit: Shahar Havivi shah...@redhat.com Line 5: CommitDate: 2015-05-05 13:46:03 +0300 Line 6: Line 7: v2v: Add allocation type for disk conversion Line 8: please add a few lines explaining why we need this change Line 9: Change-Id: Ibd3ca2983455adbb51f11957e0ce042b0cfc5ef1 -- To view, visit https://gerrit.ovirt.org/40533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3ca2983455adbb51f11957e0ce042b0cfc5ef1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: avoid python3-inconsistent syntax
Dan Kenigsberg has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 4: Code-Review-1 marking with -1 for visibility -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: statscache: more robust remove()
Dan Kenigsberg has posted comments on this change. Change subject: sampling: statscache: more robust remove() .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1748cba3646341d2be799aaf30b81432b009359c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs to enable/disable snapshot scheduling.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: verbs to enable/disable snapshot scheduling. .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs to enable/disable snapshot scheduling.
Darshan N has posted comments on this change. Change subject: gluster: verbs to enable/disable snapshot scheduling. .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add format for disk conversion
Francesco Romani has posted comments on this change. Change subject: v2v: add format for disk conversion .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar eshac...@redhat.com Gerrit-Reviewer: Eldan Shachar eshac...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add CommandStream class
Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: add CommandStream class .. utils: add CommandStream class This patch adds CommandStream a generic class to process the output of external commands (both stdout and stderr) as soon as available. For this purpose CommandStream provides the ability to define callbacks that will be executed when data is available from the external command. This class is the foundation for long-running commands that are able to provide their progress during execution: their output must be processed as soon as possible to maintain and report status updates. Change-Id: Ie015368bb9c5992e5c73a149277c59fc4ffbd570 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: https://gerrit.ovirt.org/33909 Reviewed-by: Adam Litke ali...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com --- M lib/vdsm/utils.py M tests/testlib.py M tests/utilsTests.py 3 files changed, 171 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Adam Litke: Looks good to me, approved Federico Simoncelli: Verified -- To view, visit https://gerrit.ovirt.org/33909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie015368bb9c5992e5c73a149277c59fc4ffbd570 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add CommandStream class
automat...@ovirt.org has posted comments on this change. Change subject: utils: add CommandStream class .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/33909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie015368bb9c5992e5c73a149277c59fc4ffbd570 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: Force blocking DHCP when restoring networks
automat...@ovirt.org has posted comments on this change. Change subject: net: Force blocking DHCP when restoring networks .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::OK * Check Public Bug::#1218637::OK, public bug * Check Product::#1218637::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1218637::OK, correct target release 3.5.4 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/40567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9eb07f7dc54d9167460ea9936d68b77b96564d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: Force blocking DHCP when restoring networks
Ido Barkan has uploaded a new change for review.
Change subject: net: Force blocking DHCP when restoring networks
..
net: Force blocking DHCP when restoring networks
This is done right before restoring the network configuration, and
before calling setupNetworks. It forces the configurator to wait for
an IP address to be configured on the devices before restoration is
completed. This prevents VDSM from possibly report missing IP
addresses on interfaces that had been restored right before it was
started.
Change-Id: Ibc8b84a82794ac97eba6d34ec9d54430e387b659
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1218637
Signed-off-by: Ido Barkan ibar...@redhat.com
Change-Id: Ib9eb07f7dc54d9167460ea9936d68b77b96564d6
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M vdsm/vdsm-restore-net-config
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/40567/1
diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config
index d7cb8c7..515a03a 100755
--- a/vdsm/vdsm-restore-net-config
+++ b/vdsm/vdsm-restore-net-config
@@ -73,11 +73,27 @@
persistentConfig = PersistentConfig()
nets, bonds = _filter_nets_bonds(persistentConfig.networks,
persistentConfig.bonds)
+_convert_to_blocking_dhcp(nets)
logging.debug('Calling setupNetworks with networks (%s) and bond (%s).',
nets, bonds)
setupNetworks(nets, bonds, connectivityCheck=False, _inRollback=True)
+def _convert_to_blocking_dhcp(networks):
+
+This function changes DHCP configuration, if present, to be blocking.
+
+This is done right before restoring the network configuration, and forces
+the configurator to wait for an IP address to be configured on the devices
+before restoration is completed. This prevents VDSM to possibly report
+missing IP address on interfaces that had been restored right before it was
+started.
+
+for net, net_attr in networks.iteritems():
+if net_attr.get('bootproto') == 'dhcp':
+net_attr['blockingdhcp'] = True
+
+
def _filter_nets_bonds(nets, bonds):
Returns only nets and bonds that can be configured with the devices
present in the system
--
To view, visit https://gerrit.ovirt.org/40567
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9eb07f7dc54d9167460ea9936d68b77b96564d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: m2crypto removal
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/39990/3/tests/sslTests.py
File tests/sslTests.py:
Line 369: -key, self.keyfile,
Line 370: ])
Line 371: self.assertEquals(rc, 0)
Line 372:
Line 373: @brokentest
This is the test that checks that sessions are cached, in order to avoid pe
The python-native implementation of ssl is unaware of ssl sessions, and it does
not cache them.
However, since you introduced ssl session caching, the need for caching is much
weaker, as we use long-living TCP connection, thanks to html1.1.
I admit the verification of this patch must make sure that there is no typical
degradation of performance due to this patch. Piotr - are you aware if CPU
consuption under load was tested?
Also please explain why the test is broken:
@brokentest('support for SSL sessions discontinued and may be reintroduced
when we move to python 3')
https://docs.python.org/3/library/ssl.html#ssl-contexts
Line 374: def testSessionIsCached(self):
Line 375:
Line 376: Verify that SSL the session identifier is preserved when
Line 377: connecting two times without stopping the server.
--
To view, visit https://gerrit.ovirt.org/39990
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: enable libgfapi with snapshot support
Nir Soffer has posted comments on this change.
Change subject: virt: enable libgfapi with snapshot support
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/33768/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3705
Line 3706
Line 3707
Line 3708
Line 3709
We require now libvirt 1.2.8, so we can remove this hack.
Line 3708: 'protocol':
newDriveDict['volumeInfo']['protocol']})
Line 3709: hostAttrs.update({
Line 3710: 'name':
newDriveDict['volumeInfo']['volfileServer'],
Line 3711: 'port': newDriveDict['volumeInfo']['volPort'],
Line 3712: 'transport':
newDriveDict['volumeInfo']['volTransport']})
Should use new diskType, hosts, and protocol, introduced in the ceph topic:
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:ceph
Move to Drive.getSnapshotXML()?
Line 3713: else:
Line 3714: sourceAttrs.update({'file': newDriveDict['path']})
Line 3715:
Line 3716: # Libvirt versions before 1.2.2 do not understand
'type'
--
To view, visit https://gerrit.ovirt.org/33768
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0965bef605ba67297670c0bf7924f88fa3b0460
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Jason Brooks jbro...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: extract _ifup and call _ifup_nonblocking when 'async'...
Ido Barkan has posted comments on this change. Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used .. Patch Set 3: Code-Review-1 now this depends on the later commit so we should squash them. -- To view, visit https://gerrit.ovirt.org/40478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c40cb09f05a0865b1942448a64fd37b735857f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: Force blocking DHCP when restoring networks
automat...@ovirt.org has posted comments on this change. Change subject: net: Force blocking DHCP when restoring networks .. Patch Set 4: * Update tracker::#1218637::OK * Check Bug-Url::OK * Check Public Bug::#1218637::OK, public bug * Check Product::#1218637::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1218637::OK, correct target release 3.5.4 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/39529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8b84a82794ac97eba6d34ec9d54430e387b659 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: Force blocking DHCP when restoring networks
automat...@ovirt.org has posted comments on this change. Change subject: network: Force blocking DHCP when restoring networks .. Patch Set 3: * Update tracker::#1218637::OK * Check Bug-Url::OK * Check Public Bug::#1218637::OK, public bug * Check Product::#1218637::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1218637::OK, correct target release 3.5.4 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/39529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8b84a82794ac97eba6d34ec9d54430e387b659 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs to enable/disable snapshot scheduling.
Darshan N has posted comments on this change. Change subject: gluster: verbs to enable/disable snapshot scheduling. .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs to enable/disable snapshot scheduling.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: verbs to enable/disable snapshot scheduling. .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: Force blocking DHCP when restoring networks
automat...@ovirt.org has posted comments on this change. Change subject: net: Force blocking DHCP when restoring networks .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9eb07f7dc54d9167460ea9936d68b77b96564d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: Force blocking DHCP when restoring networks
Ido Barkan has abandoned this change. Change subject: net: Force blocking DHCP when restoring networks .. Abandoned mistake -- To view, visit https://gerrit.ovirt.org/40567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib9eb07f7dc54d9167460ea9936d68b77b96564d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: models, configurators: replace the internal 'async' flag wit...
Ido Barkan has posted comments on this change. Change subject: models, configurators: replace the internal 'async' flag with blockingdhcp .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e60040320d65ddbc4146a31c02c388ddad13ea9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Extract helpers for major XML elements
automat...@ovirt.org has posted comments on this change. Change subject: virt: Extract helpers for major XML elements .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ef6a38d3abc14413f1001a8673f38fce8d828b7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Extract helpers for major XML elements
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Extract helpers for major XML elements .. virt: Extract helpers for major XML elements Now drive xml is built using small helper methods creating each of the elements. This is more maintainable and will allow creating drive replica xml without code duplication. Change-Id: I6ef6a38d3abc14413f1001a8673f38fce8d828b7 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40066 Reviewed-by: Adam Litke ali...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/virt/vmdevices/storage.py 1 file changed, 61 insertions(+), 48 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ef6a38d3abc14413f1001a8673f38fce8d828b7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Improve spacing
automat...@ovirt.org has posted comments on this change. Change subject: virt: Improve spacing .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94b751112db67398891820035a9ec06abed59c3b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Simplify error handling in diskReplicateStart
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Simplify error handling in diskReplicateStart .. vm: Simplify error handling in diskReplicateStart Log only detailed exception in the outer try-except block, instead of detailed exception in the inner try-except block, and unhelpful exception in the outer block. Change-Id: I43814fa41c9cdc830fee9e929baa2e8249b18720 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40022 Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43814fa41c9cdc830fee9e929baa2e8249b18720 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Improve spacing
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Improve spacing .. virt: Improve spacing Separating logical blocks make it easier to to understand the flow. Change-Id: I94b751112db67398891820035a9ec06abed59c3b Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40067 Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/virt/vmdevices/storage.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94b751112db67398891820035a9ec06abed59c3b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Simplify error handling in diskReplicateStart
automat...@ovirt.org has posted comments on this change. Change subject: vm: Simplify error handling in diskReplicateStart .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43814fa41c9cdc830fee9e929baa2e8249b18720 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Run glusterfs in its own cgroup
Nir Soffer has posted comments on this change. Change subject: storageServer: Run glusterfs in its own cgroup .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40240/2/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 274: # - 22180 /usr/bin/glusterfs ... Line 275: #- run-21649.scope Line 276: # - 21692 /usr/bin/glusterfs ... Line 277: # Line 278: modifier = partial(cmdutils.systemd_run, scope=True, slice='glusterfs') Why do you create a systemd transient unit when we would just need cgexec(1 cgexec is not compatible with systemd on rhel 7.1. When you execute a process in its own cgroup, it remains also in systemd vdsm.scope, and when you stop vdsm, systemd will kill also the process you started using cgexec. This works on fedora 21, so it is probably a bug in systemd or cgexec. For long term, I think we should use systemd which provides much nicer api unless we plan to support systemd-less environment. Line 279: MountConnection.connect(self, modifier=modifier) Line 280: Line 281: Line 282: class NFSConnection(object): -- To view, visit https://gerrit.ovirt.org/40240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79714a9a6ecbde17c396eca6b17b9e3605fad688 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Vijay Bellur vbel...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Libvirt 1.2.14 is not released yet
Nir Soffer has posted comments on this change. Change subject: spec: Libvirt 1.2.14 is not released yet .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ecaecadad55fa73bdfd89f27abcead1c86ca8b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Run glusterfs in its own cgroup
Federico Simoncelli has posted comments on this change. Change subject: storageServer: Run glusterfs in its own cgroup .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40240/2/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 274: # - 22180 /usr/bin/glusterfs ... Line 275: #- run-21649.scope Line 276: # - 21692 /usr/bin/glusterfs ... Line 277: # Line 278: modifier = partial(cmdutils.systemd_run, scope=True, slice='glusterfs') cgexec is not compatible with systemd on rhel 7.1. When you execute a proce Add this knowledge somewhere (bug on systemd if any, etc.) Probably it would be best to make it explicit with a MountConnection property/attribute (e.g. connect_needs_cgroup = True|False ) so it's clear what you need and you don't have to pass around a modifier. Line 279: MountConnection.connect(self, modifier=modifier) Line 280: Line 281: Line 282: class NFSConnection(object): -- To view, visit https://gerrit.ovirt.org/40240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79714a9a6ecbde17c396eca6b17b9e3605fad688 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Vijay Bellur vbel...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Libvirt 1.2.14 is not released yet
Francesco Romani has posted comments on this change. Change subject: spec: Libvirt 1.2.14 is not released yet .. Patch Set 1: Code-Review+1 for virt, we don't need libvirt 1.2.14 and 1.2.13 should be fine for us. However, I see that virt-preview for F22 ships libvirt 1.2.14 https://repos.fedorapeople.org/repos/crobinso/virt-preview/fedora-22/x86_64/ We are used to recommend virt-preview on Fedora (CentOS is a different story), so should be good enough. -- To view, visit https://gerrit.ovirt.org/40552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ecaecadad55fa73bdfd89f27abcead1c86ca8b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: statscache: more robust remove()
Francesco Romani has posted comments on this change. Change subject: sampling: statscache: more robust remove() .. Patch Set 7: Verified+1 re-verified migrating a VM back and forth an handful of times, and trying various shutdowns. -- To view, visit https://gerrit.ovirt.org/40439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1748cba3646341d2be799aaf30b81432b009359c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Memory Hotplug for vm
automat...@ovirt.org has posted comments on this change. Change subject: Memory Hotplug for vm .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Hooks for Memory Hotplug
automat...@ovirt.org has posted comments on this change. Change subject: Hooks for Memory Hotplug .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Memory Hotplug for vm
Omer Frenkel has uploaded a new change for review.
Change subject: Memory Hotplug for vm
..
Memory Hotplug for vm
Introduces a new verb to hotplug memory to a running vm.
the memory is plugged to a guest NUMA node.
exposes it in the XML-RPC and JSON-RPC.
http://www.ovirt.org/Features/Memory_Hotplug
Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e
Signed-off-by: Omer Frenkel ofren...@redhat.com
---
M client/vdsClient.py
M lib/vdsm/define.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/Bridge.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/core.py
M vdsm/virt/vmdevices/hwclass.py
9 files changed, 205 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/40549/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 375fa1a..687f33f 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -325,6 +325,13 @@
params = {'vmId': args[0], 'drive': drive}
return self.ExecAndExit(self.s.hotunplugDisk(params))
+def hotplugMemory(self, args):
+memory = self._parseDriveSpec(args[1])
+memory['type'] = 'memory'
+memory['device'] = 'memory'
+params = {'vmId': args[0], 'memory': memory}
+return self.ExecAndExit(self.s.hotplugMemory(params))
+
def setNumberOfCpus(self, args):
return self.ExecAndExit(self.s.setNumberOfCpus(args[0], args[1]))
@@ -2750,6 +2757,14 @@
'vmId spUUID sdUUID imgUUID volUUID newSize',
'Extends the virtual size of a disk'
)),
+'hotplugMemory': (
+serv.hotplugMemory, (
+'vmId memDeviceSpec',
+'Hotplug memory to a running VM NUMA node',
+'memDeviceSpec parameters list: r=required, o=optional',
+'r size: memory size to plug in mb.',
+'r node: guest NUMA node id to plug into'
+)),
'setNumberOfCpus': (
serv.setNumberOfCpus, (
'vmId numberOfCpus',
diff --git a/lib/vdsm/define.py b/lib/vdsm/define.py
index f725748..a1b32d2 100644
--- a/lib/vdsm/define.py
+++ b/lib/vdsm/define.py
@@ -150,6 +150,9 @@
'V2VConnection': {'status': {
'code': 65,
'message': 'error connecting to hypervisor'}},
+'hotplugMem': {'status': {
+'code': 66,
+'message': 'Failed to hotplug memory'}},
'recovery': {'status': {
'code': 99,
'message': 'Recovering from crash or Initializing'}},
diff --git a/vdsm/API.py b/vdsm/API.py
index 3cdc465..d3efaf9 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -470,6 +470,23 @@
return curVm.hotunplugDisk(params)
+def hotplugMemory(self, params):
+try:
+utils.validateMinimalKeySet(params, ('vmId', 'memory'))
+except ValueError:
+self.log.error('Missing one of required parameters: vmId, memory')
+return {'status': {'code': errCode['MissParam']['status']['code'],
+ 'message': 'Missing one of required '
+ 'parameters: vmId, memory'}}
+
+try:
+curVm = self._cif.vmContainer[self._UUID]
+except KeyError:
+self.log.warning(vm %s doesn't exist, self._UUID)
+return errCode['noVM']
+
+return curVm.hotplugMemory(params)
+
def setNumberOfCpus(self, numberOfCpus):
if self._UUID is None or numberOfCpus is None:
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index 9a1da99..5fa511d 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -434,6 +434,10 @@
vm = API.VM(vmId)
return vm.updateDevice(params)
+def vmHotplugMemory(self, params):
+vm = API.VM(params['vmId'])
+return vm.hotplugMemory(params)
+
def vmSetNumberOfCpus(self, vmId, numberOfCpus):
vm = API.VM(vmId)
return vm.setNumberOfCpus(numberOfCpus)
@@ -1031,6 +1035,7 @@
(self.vmHotunplugNic, 'hotunplugNic'),
(self.vmUpdateDevice, 'vmUpdateDevice'),
(self.vmSetNumberOfCpus, 'setNumberOfCpus'),
+(self.vmHotplugMemory, 'hotplugMemory'),
(self.merge, 'merge'),
(self.vmUpdateVmPolicy, 'updateVmPolicy'),
(self.vmSetIoTune, 'setIoTune'),
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index cb149bc..d063e67 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -473,6 +473,7 @@
'VM_pause': {'ret': VM_running_state_change_Ret},
'VM_setCpuTunePeriod': {'ret': 'taskStatus'},
'VM_setCpuTuneQuota': {'ret': 'taskStatus'},
+'VM_hotplugMemory': {'ret': 'vmList'},
'VM_setNumberOfCpus': {'ret': 'vmList'},
'VM_setIoTune': {'ret': 'taskStatus'},
'VM_updateDevice': {'ret': 'vmList'},
diff --git
Change in vdsm[master]: storageServer: Run glusterfs in its own cgroup
Federico Simoncelli has posted comments on this change. Change subject: storageServer: Run glusterfs in its own cgroup .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40240/2/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 274: # - 22180 /usr/bin/glusterfs ... Line 275: #- run-21649.scope Line 276: # - 21692 /usr/bin/glusterfs ... Line 277: # Line 278: modifier = partial(cmdutils.systemd_run, scope=True, slice='glusterfs') Why do you create a systemd transient unit when we would just need cgexec(1)? Line 279: MountConnection.connect(self, modifier=modifier) Line 280: Line 281: Line 282: class NFSConnection(object): -- To view, visit https://gerrit.ovirt.org/40240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79714a9a6ecbde17c396eca6b17b9e3605fad688 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Vijay Bellur vbel...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require libvirt-python supporting blockCopy
Nir Soffer has posted comments on this change. Change subject: spec: Require libvirt-python supporting blockCopy .. Patch Set 7: I will check with infra why they fail to find the required package. -- To view, visit https://gerrit.ovirt.org/40069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbafbfeb61f392bf420caa4589df7cdac92a6568 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Gather disk replication private methods
automat...@ovirt.org has posted comments on this change. Change subject: vm: Gather disk replication private methods .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I075636735ad9f2a53c2ed81ea20925a7bfda376d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require libvirt-python supporting blockCopy
automat...@ovirt.org has posted comments on this change. Change subject: spec: Require libvirt-python supporting blockCopy .. Patch Set 8: * Update tracker::#1200718::OK * Check Bug-Url::OK * Check Public Bug::#1200718::OK, public bug * Check Product::#1200718::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbafbfeb61f392bf420caa4589df7cdac92a6568 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Delete Drive.diskReplicate before saving config
automat...@ovirt.org has posted comments on this change. Change subject: vm: Delete Drive.diskReplicate before saving config .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3112f94a4877e28057497749938aa8c3d7771d30 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require libvirt-python supporting blockCopy
Dan Kenigsberg has posted comments on this change. Change subject: spec: Require libvirt-python supporting blockCopy .. Patch Set 7: Code-Review-1 Regardless of the question whether to squash this patch to a the code that needs it, please do not merge before Jenkis is happy with it. -- To view, visit https://gerrit.ovirt.org/40069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbafbfeb61f392bf420caa4589df7cdac92a6568 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add allocation type for disk conversion
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Add allocation type for disk conversion .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3ca2983455adbb51f11957e0ce042b0cfc5ef1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Hooks for Memory Hotplug
Omer Frenkel has uploaded a new change for review.
Change subject: Hooks for Memory Hotplug
..
Hooks for Memory Hotplug
This patch introduce vdsm hooks for memory hot plug.
the hooks will be called before and after memory hotplug is performed in
libvirt.
the hooks are used in a following patch that introduce memory hotplug
implementation.
http://www.ovirt.org/Features/Memory_Hotplug
Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f
Signed-off-by: Omer Frenkel ofren...@redhat.com
---
M debian/vdsm.dirs
M vdsm.spec.in
M vdsm/hooks.py
M vdsm/vdsmd.8.in
M vdsm_hooks/Makefile.am
5 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/40548/1
diff --git a/debian/vdsm.dirs b/debian/vdsm.dirs
index 87703cd..4776f37 100644
--- a/debian/vdsm.dirs
+++ b/debian/vdsm.dirs
@@ -25,6 +25,7 @@
usr/libexec/vdsm/hooks/after_nic_hotunplug
usr/libexec/vdsm/hooks/after_nic_hotunplug_fail
usr/libexec/vdsm/hooks/after_set_num_of_cpus
+usr/libexec/vdsm/hooks/after_memory_hotplug
usr/libexec/vdsm/hooks/after_update_device
usr/libexec/vdsm/hooks/after_update_device_fail
usr/libexec/vdsm/hooks/after_vdsm_stop
@@ -50,6 +51,7 @@
usr/libexec/vdsm/hooks/before_nic_hotplug
usr/libexec/vdsm/hooks/before_nic_hotunplug
usr/libexec/vdsm/hooks/before_set_num_of_cpus
+usr/libexec/vdsm/hooks/before_memory_hotplug
usr/libexec/vdsm/hooks/before_update_device
usr/libexec/vdsm/hooks/before_vdsm_start
usr/libexec/vdsm/hooks/before_vm_cont
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 456a2d9..7f40c5a 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1257,6 +1257,8 @@
%dir %{_libexecdir}/%{vdsm_name}/hooks/after_network_setup
%dir %{_libexecdir}/%{vdsm_name}/hooks/before_set_num_of_cpus
%dir %{_libexecdir}/%{vdsm_name}/hooks/after_set_num_of_cpus
+%dir %{_libexecdir}/%{vdsm_name}/hooks/before_memory_hotplug
+%dir %{_libexecdir}/%{vdsm_name}/hooks/after_memory_hotplug
%dir %{_libexecdir}/%{vdsm_name}/hooks/before_get_vm_stats
%dir %{_libexecdir}/%{vdsm_name}/hooks/after_get_vm_stats
%dir %{_libexecdir}/%{vdsm_name}/hooks/before_get_all_vm_stats
diff --git a/vdsm/hooks.py b/vdsm/hooks.py
index cedf2be..cb49859 100644
--- a/vdsm/hooks.py
+++ b/vdsm/hooks.py
@@ -323,6 +323,16 @@
params=params, raiseError=False)
+def before_memory_hotplug(domxml, vmconf={}, params={}):
+return _runHooksDir(domxml, 'before_memory_hotplug', vmconf=vmconf,
+params=params)
+
+
+def after_memory_hotplug(domxml, vmconf={}, params={}):
+return _runHooksDir(domxml, 'after_memory_hotplug', vmconf=vmconf,
+params=params, raiseError=False)
+
+
def before_vdsm_start():
return _runHooksDir(None, 'before_vdsm_start', raiseError=False)
diff --git a/vdsm/vdsmd.8.in b/vdsm/vdsmd.8.in
index f6e7158..0f5f5c1 100644
--- a/vdsm/vdsmd.8.in
+++ b/vdsm/vdsmd.8.in
@@ -61,7 +61,8 @@
before_set_num_of_cpus, after_set_num_of_cpus,
before_get_vm_stats, after_get_vm_stats,
before_get_all_vm_stats, after_get_all_vm_stats,
-before_get_caps, after_get_caps, after_hostdev_list_by_caps.
+before_get_caps, after_get_caps, after_hostdev_list_by_caps,
+before_memory_hotplug, after_memory_hotplug.
Each hook executes the scripts under
.FN /usr/libexec/vdsm/hooks/hook-name/
diff --git a/vdsm_hooks/Makefile.am b/vdsm_hooks/Makefile.am
index 337284b..1971e75 100644
--- a/vdsm_hooks/Makefile.am
+++ b/vdsm_hooks/Makefile.am
@@ -125,6 +125,8 @@
before_get_caps \
after_get_caps \
after_hostdev_list_by_caps \
+ before_memory_hotplug \
+ after_memory_hotplug \
$(NULL)
all-local: \
--
To view, visit https://gerrit.ovirt.org/40548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel ofren...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add support for specifying vm maximum memory
Omer Frenkel has uploaded a new change for review.
Change subject: Add support for specifying vm maximum memory
..
Add support for specifying vm maximum memory
Added new parameter 'maxMemSize' to VM
this parameter is sent from engine backend and passed to libvirt xml
with the mandatory 'slots' attribute.
this parameter is mandatory for memory hotplug.
if this parameter is not passed, then it is not set in the libvirt xml,
and hotplug for this vm will not work.
Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8
Signed-off-by: Omer Frenkel ofren...@redhat.com
---
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vmxml.py
2 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/40547/1
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 0c73078..fa8f336 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -3583,6 +3583,9 @@
#
# @numOfIoThreads:#optional The num of iothreads qemu allocates
#
+# @maxMemSize:The maximum amount of memory that can be assigned
+# to the VM in MB
+#
# Since: 4.10.0
##
{'type': 'VmDefinition',
@@ -3599,7 +3602,7 @@
'status': 'VmStatus', 'timeOffset': 'uint',
'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str',
'vmType': 'VmType', '*exitCode': 'int', '*exitMessage': 'str',
- '*serial': 'str', '*numOfIoThreads': 'uint'}}
+ '*serial': 'str', '*numOfIoThreads': 'uint', 'maxMemSize': 'uint'}}
##
# @VmParameters:
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index 02bbb52..ea5b34e 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -167,6 +167,10 @@
memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
self.dom.appendChildWithArgs('memory', text=memSizeKB)
self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
+if 'maxMemSize' in self.conf:
+maxMemSizeKB = str(int(self.conf['maxMemSize']) * 1024)
+self.dom.appendChildWithArgs('maxMemory', text=maxMemSizeKB,
+ slots=self._getMaxVCpus())
vcpu = self.dom.appendChildWithArgs('vcpu', text=self._getMaxVCpus())
vcpu.setAttrs(**{'current': self._getSmp()})
--
To view, visit https://gerrit.ovirt.org/40547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel ofren...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add support for specifying vm maximum memory
automat...@ovirt.org has posted comments on this change. Change subject: Add support for specifying vm maximum memory .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: models, configurators: replace the internal 'async' flag wit...
automat...@ovirt.org has posted comments on this change. Change subject: models, configurators: replace the internal 'async' flag with blockingdhcp .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e60040320d65ddbc4146a31c02c388ddad13ea9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Separate validation from getXML
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Separate validation from getXML .. virt: Separate validation from getXML Extract _validate() method and move the validation code into it, and add missing tests for sgio and cow format. Change-Id: I00916c13850e335fb13e74a13b52b71560bfb797 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40065 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Adam Litke ali...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M tests/vmStorageTests.py M vdsm/virt/vmdevices/storage.py 2 files changed, 27 insertions(+), 7 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00916c13850e335fb13e74a13b52b71560bfb797 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automat...@ovirt.org has posted comments on this change. Change subject: block: convert getVolumeMetadataSlot into a contexmanager .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/25988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
Dan Kenigsberg has submitted this change and it was merged. Change subject: block: convert getVolumeMetadataSlot into a contexmanager .. block: convert getVolumeMetadataSlot into a contexmanager Using a contextmanager on getVolumeMetadataSlot allows us to hide the metadata slot lock inside the StorageDomain object instead of having to use it from other modules (e.g. formatConverter). Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: https://gerrit.ovirt.org/25988 Tested-by: Adam Litke ali...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/volumeTests.py M vdsm/storage/blockSD.py M vdsm/storage/blockVolume.py M vdsm/storage/imageRepository/formatConverter.py 4 files changed, 25 insertions(+), 17 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Adam Litke: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/25988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: extract _ifup and call _ifup_nonblocking when 'async'...
automat...@ovirt.org has posted comments on this change. Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c40cb09f05a0865b1942448a64fd37b735857f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Take _confLock when updating Vm.conf disk parameters
Francesco Romani has posted comments on this change. Change subject: vm: Take _confLock when updating Vm.conf disk parameters .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89967bd738dc9e4f808ae6674dd61c5c859b511c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Darshan N has uploaded a new change for review.
Change subject: gluster:Remove support for Replace gluster brick with data
migration.
..
gluster:Remove support for Replace gluster brick with data migration.
This patch removes verbs related to replace gluster brick
with data migration. Now only replace brick with commit
force option is retained. As this feature is deprecated in
glusterfs-3.7 on wards. These verbs were not consumed
by engine, so it should not cause any backward-compatibility
issues when removed.
Change-Id: I1569972120da27c17407bec5301b1ba417ce0768
Signed-off-by: Darshan N dnara...@redhat.com
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
6 files changed, 26 insertions(+), 228 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/40545/1
diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index 4f53eb4..cd0e2f3 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -163,56 +163,15 @@
status = self.s.glusterHostRemoveByUuid(hostUuid, force)
return status['status']['code'], status['status']['message']
-def do_glusterVolumeReplaceBrickStart(self, args):
+def do_glusterVolumeReplaceBrickCommitForce(self, args):
params = self._eqSplit(args)
volumeName = params.get('volumeName', '')
existingBrick = params.get('existingBrick', '')
newBrick = params.get('newBrick', '')
-status = self.s.glusterVolumeReplaceBrickStart(volumeName,
- existingBrick,
- newBrick)
-pp.pprint(status)
-return status['status']['code'], status['status']['message']
-
-def do_glusterVolumeReplaceBrickAbort(self, args):
-params = self._eqSplit(args)
-volumeName = params.get('volumeName', '')
-existingBrick = params.get('existingBrick', '')
-newBrick = params.get('newBrick', '')
-
-status = self.s.glusterVolumeReplaceBrickAbort(volumeName,
- existingBrick,
- newBrick)
-return status['status']['code'], status['status']['message']
-
-def do_glusterVolumeReplaceBrickPause(self, args):
-params = self._eqSplit(args)
-volumeName = params.get('volumeName', '')
-existingBrick = params.get('existingBrick', '')
-newBrick = params.get('newBrick', '')
-
-status = self.s.glusterVolumeReplaceBrickPause(volumeName,
- existingBrick,
- newBrick)
-return status['status']['code'], status['status']['message']
-
-def do_glusterVolumeReplaceBrickStatus(self, args):
-status = self.s.glusterVolumeReplaceBrickStatus(args[0], args[1],
-args[2])
-return status['status']['code'], status['status']['message']
-
-def do_glusterVolumeReplaceBrickCommit(self, args):
-params = self._eqSplit(args)
-volumeName = params.get('volumeName', '')
-existingBrick = params.get('existingBrick', '')
-newBrick = params.get('newBrick', '')
-force = (params.get('force', 'no').upper() == 'YES')
-
-status = self.s.glusterVolumeReplaceBrickCommit(volumeName,
-existingBrick,
-newBrick,
-force)
+status = self.s.glusterVolumeReplaceBrickCommitForce(volumeName,
+ existingBrick,
+ newBrick)
return status['status']['code'], status['status']['message']
def do_glusterVolumeRemoveBrickStart(self, args):
@@ -864,44 +823,10 @@
'gluster cluster',
'remove server from gluster cluster'
)),
- 'glusterVolumeReplaceBrickStart': (
- serv.do_glusterVolumeReplaceBrickStart,
+ 'glusterVolumeReplaceBrickCommitForce': (
+ serv.do_glusterVolumeReplaceBrickCommitForce,
('volumeName=volume_name existingBrick=existing_brick '
- 'newBrick=new_brick\n\t'
- 'volume_name is existing volume name\n\t'
- 'existing_brick is existing brick\n\t'
- 'new_brick is new brick',
- 'start volume replace brick'
- )),
- 'glusterVolumeReplaceBrickAbort': (
- serv.do_glusterVolumeReplaceBrickAbort,
- ('volumeName=volume_name
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
automat...@ovirt.org has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: introduce before/after_get_stats hook points
Federico Simoncelli has posted comments on this change. Change subject: hooks: introduce before/after_get_stats hook points .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ff93837abb73f88ececc7571115645b95486cf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon celeb...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Libvirt 1.2.14 is not released yet
Nir Soffer has uploaded a new change for review.
Change subject: spec: Libvirt 1.2.14 is not released yet
..
spec: Libvirt 1.2.14 is not released yet
In commit 87cf341acede (spec: Update libvirt-daemon and libvirt-python
requirements) we required libvirt = 1.2.4 on Fedora 22, but this
version is not available yet. We will have to wait until this version is
available.
Change-Id: I3ecaecadad55fa73bdfd89f27abcead1c86ca8b2
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/40552/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index f0375be..04114f5 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -211,7 +211,7 @@
%endif
%if 0%{?fedora} = 22
-Requires: libvirt-daemon = 1.2.14
+Requires: libvirt-daemon = 1.2.13
Requires: libvirt-python
%endif
--
To view, visit https://gerrit.ovirt.org/40552
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ecaecadad55fa73bdfd89f27abcead1c86ca8b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
Dan Kenigsberg has posted comments on this change. Change subject: block: convert getVolumeMetadataSlot into a contexmanager .. Patch Set 16: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/25988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Run glusterfs in its own cgroup
Nir Soffer has posted comments on this change. Change subject: storageServer: Run glusterfs in its own cgroup .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40240/2/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 274: # - 22180 /usr/bin/glusterfs ... Line 275: #- run-21649.scope Line 276: # - 21692 /usr/bin/glusterfs ... Line 277: # Line 278: modifier = partial(cmdutils.systemd_run, scope=True, slice='glusterfs') Add this knowledge somewhere (bug on systemd if any, etc.) I will open a cgexec/systemd bug, was busy in getting this work. I'm not very happy with the modifier thing, this was attempt to make smallest change to fix this issue. I will explore a nicer way to do this in the next version. Line 279: MountConnection.connect(self, modifier=modifier) Line 280: Line 281: Line 282: class NFSConnection(object): -- To view, visit https://gerrit.ovirt.org/40240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79714a9a6ecbde17c396eca6b17b9e3605fad688 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Vijay Bellur vbel...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Save state only if disk was updated
automat...@ovirt.org has posted comments on this change. Change subject: vm: Save state only if disk was updated .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I081a0c7f544a003665bd02769489d601bdf7a86b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Add _findConfDisk() helper
automat...@ovirt.org has posted comments on this change. Change subject: vm: Add _findConfDisk() helper .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3a59a2b798650035870c335ed7c949e2bd431d0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Add required information to replica dict
automat...@ovirt.org has posted comments on this change. Change subject: vm: Add required information to replica dict .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If28c9e6d084fd27857ff9da2c024d8798f375cbd Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Take _confLock when updating Vm.conf disk parameters
automat...@ovirt.org has posted comments on this change. Change subject: vm: Take _confLock when updating Vm.conf disk parameters .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89967bd738dc9e4f808ae6674dd61c5c859b511c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Unify disk replication terms
automat...@ovirt.org has posted comments on this change. Change subject: vm: Unify disk replication terms .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fa2f30f39eee73b107f5c055f5be790ed33da6a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Use blockCopy for live storage migration
automat...@ovirt.org has posted comments on this change. Change subject: vm: Use blockCopy for live storage migration .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a69e5af76bb6114f363441f22ea3dd70c7c2508 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Memory Hotplug for vm
automat...@ovirt.org has posted comments on this change. Change subject: Memory Hotplug for vm .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Support replication to different storage type
automat...@ovirt.org has posted comments on this change. Change subject: vm: Support replication to different storage type .. Patch Set 7: * Update tracker::#1058732::OK * Update tracker::#1058749::OK * Check Bug-Url::OK * Check Public Bug::#1058732::OK, public bug * Check Public Bug::#1058749::OK, public bug * Check Product::#1058732::OK, Correct product Red Hat Enterprise Virtualization Manager * Check Product::#1058749::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40185 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70eb93082af81fe54268ee0133d1252c0d537ca8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Use blockRebase if blockCopy is not supported
automat...@ovirt.org has posted comments on this change. Change subject: vm: Use blockRebase if blockCopy is not supported .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic03474e36d7e073b7e5924cb02f417e12d4ad75e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add Drive.replicaChunked property
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add Drive.replicaChunked property .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40184 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadf19fa3262e356ee87c92357b8d90aff7dc0356 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Streamline names in diskReplicateStart
automat...@ovirt.org has posted comments on this change. Change subject: vm: Streamline names in diskReplicateStart .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc3ead0616718b1fd6dd877ad98a4fcfce9e5af2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add CommandStream class
automat...@ovirt.org has posted comments on this change. Change subject: utils: add CommandStream class .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie015368bb9c5992e5c73a149277c59fc4ffbd570 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Libvirt 1.2.14 is not released yet
Francesco Romani has posted comments on this change. Change subject: spec: Libvirt 1.2.14 is not released yet .. Patch Set 1: Yes, I agree with your reasoning, we should eventually reach a stable point on which we're good with the libvirt/qemu shipped by default by fedora. So, let's try NOT to require virt-preview this time :) -- To view, visit https://gerrit.ovirt.org/40552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ecaecadad55fa73bdfd89f27abcead1c86ca8b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Extract Drive.diskType property
automat...@ovirt.org has posted comments on this change. Change subject: virt: Extract Drive.diskType property .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec13ca58ee4f3db919198bdeae781473a97e072d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add CommandStream class
Adam Litke has posted comments on this change. Change subject: utils: add CommandStream class .. Patch Set 9: Code-Review+2 Looks good. -- To view, visit https://gerrit.ovirt.org/33909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie015368bb9c5992e5c73a149277c59fc4ffbd570 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Libvirt 1.2.14 is not released yet
Nir Soffer has posted comments on this change. Change subject: spec: Libvirt 1.2.14 is not released yet .. Patch Set 1: https://apps.fedoraproject.org/packages/libvirt -- To view, visit https://gerrit.ovirt.org/40552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ecaecadad55fa73bdfd89f27abcead1c86ca8b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Libvirt 1.2.14 is not released yet
Nir Soffer has posted comments on this change. Change subject: spec: Libvirt 1.2.14 is not released yet .. Patch Set 1: Francesco, do you think we should require virt-preview for Fedora 22? I think we should require virt-preview only when we have no other choice. -- To view, visit https://gerrit.ovirt.org/40552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ecaecadad55fa73bdfd89f27abcead1c86ca8b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add CommandStream class
Adam Litke has posted comments on this change. Change subject: utils: add CommandStream class .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/33909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie015368bb9c5992e5c73a149277c59fc4ffbd570 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Extract Drive.diskType property
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Extract Drive.diskType property .. virt: Extract Drive.diskType property This is the first step in breaking getXML() to separate methods for rendering individual elements, required to create replica disk xml without code duplication. The diskType property is also required for Ceph support, where it will be sent from the engine. This property helps the rest of the code to work in the same way if diskType was sent from the engine (new engine) or deduced from blockDev and networkDev properties (old engine). Change-Id: Iec13ca58ee4f3db919198bdeae781473a97e072d Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40062 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Adam Litke ali...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/virt/vmdevices/storage.py 1 file changed, 24 insertions(+), 9 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec13ca58ee4f3db919198bdeae781473a97e072d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Set default device in __init__
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Set default device in __init__ .. virt: Set default device in __init__ Set Drive.device in __init__ instead of getXML(). Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40063 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Adam Litke ali...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/virt/vmdevices/storage.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Set default device in __init__
automat...@ovirt.org has posted comments on this change. Change subject: virt: Set default device in __init__ .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Set source attributes consistently
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Set source attributes consistently .. virt: Set source attributes consistently For block and network we were using source.setAttrs(key=value), but for file we were using less clear source.setAttrs(**dict). Change-Id: I4bcc3846428c7f2cc14cf19254617378b668404a Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40064 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Adam Litke ali...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/virt/vmdevices/storage.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bcc3846428c7f2cc14cf19254617378b668404a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
