Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Should be one bugfix of one RFE implementation :) -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Code-Review+1 (1 comment) codewise looks OK, but we need to address Dan's comments about commit message. https://gerrit.ovirt.org/#/c/41415/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-05-26 10:01:22 +0300 Line 4: Commit: Shahar Havivi Line 5: CommitDate: 2015-05-31 11:21:32 +0300 Line 6: Line 7: RFE: Report downtime for each live migration > this patch is a bugfix, isn't it? not RFE implementation. Should be one bugfix of one RFE implementation :) Line 8: Line 9: Libvirt report how much time the VM was off-line via jobStats. Line 10: We fetch the downtime key which return the correct time but the source Line 11: and dest hosts need to be in sync. -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Dan Kenigsberg has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/41415/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-05-26 10:01:22 +0300 Line 4: Commit: Shahar Havivi Line 5: CommitDate: 2015-05-31 11:21:32 +0300 Line 6: Line 7: RFE: Report downtime for each live migration this patch is a bugfix, isn't it? not RFE implementation. Line 8: Line 9: Libvirt report how much time the VM was off-line via jobStats. Line 10: We fetch the downtime key which return the correct time but the source Line 11: and dest hosts need to be in sync. Line 10: We fetch the downtime key which return the correct time but the source Line 11: and dest hosts need to be in sync. Line 12: downtime_net key return the same results but the hosts doesn't need to Line 13: be in sync. Line 14: This patch change the call from downtime to downtime_net. I don't get the difference between downtime and downtime_net. A link to http://libvirt.org/html/libvirt-libvirt-domain.html#VIR_DOMAIN_JOB_DOWNTIME_NET may help other reviewers Line 15: Line 16: Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Line 17: Bug-Url: https://bugzilla.redhat.com/970711 -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: (1 comment) reverting score only for visibility, the patch is fine. https://gerrit.ovirt.org/#/c/41415/1//COMMIT_MSG Commit Message: Line 7: RFE: Report downtime for each live migration Line 8: Line 9: Migration.py returning donwtime_net instead of downtime. Line 10: downtime returns actual vm downtime but the hosts need to be in sync, Line 11: downtime_net return the same but don't need the hosts to be in sync. codewise the patch is fine. The problem here is that I know what this patch fixes, so I can follow what the commit message hints. Otherwise, it is a bit hard to understand. Please rephrase the commit message providing more context, targeting someone which hasn't followed the discussion about downtime reporting. Line 12: Line 13: Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Line 14: Bug-Url: https://bugzilla.redhat.com/970711 -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 9: * Update tracker::#970711::OK -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has uploaded a new change for review. Change subject: RFE: Report downtime for each live migration .. RFE: Report downtime for each live migration Migration.py returning donwtime_net instead of downtime. downtime returns actual vm downtime but the hosts need to be in sync, downtime_net return the same but don't need the hosts to be in sync. Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Bug-Url: https://bugzilla.redhat.com/970711 Signed-off-by: Shahar Havivi --- M vdsm/virt/migration.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/41415/1 diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py index cbebed7..de5a011 100644 --- a/vdsm/virt/migration.py +++ b/vdsm/virt/migration.py @@ -100,8 +100,8 @@ self.status['progress'] = self._progress stat = self._vm._dom.jobStats(libvirt.VIR_DOMAIN_JOB_STATS_COMPLETED) -if 'downtime' in stat: -self.status['downtime'] = stat['downtime'] +if 'downtime_net' in stat: +self.status['downtime'] = stat['downtime_net'] return self.status -- To view, visit https://gerrit.ovirt.org/41415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has abandoned this change. Change subject: RFE: Report downtime for each live migration .. Abandoned Abandoning this patch will split to two different patches -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 9:
(2 comments)
looks OK, but commit message needs to be updated.
https://gerrit.ovirt.org/#/c/40103/9//COMMIT_MSG
Commit Message:
Line 9: vm.py getStat() is called when migration is done and from Engine
Line 10: initiative.
Line 11:
Line 12: There is no need to call libvirts domain getStats twice, only when
Line 13: Engine initiate the call.
can you elaborate about how this reflects in the changes you made into
migration.py?
Line 14:
Line 15: Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Line 16: Bug-Url: https://bugzilla.redhat.com/970711
https://gerrit.ovirt.org/#/c/40103/9/vdsm/API.py
File vdsm/API.py:
Line 352: try:
Line 353: v = self._cif.vmContainer[self._UUID]
Line 354: except KeyError:
Line 355: return errCode['noVM']
Line 356: return {'status': doneCode, 'migrationStats':
v.migrateStatus()}
this - and the Bridge.py counterpart - looks like a separate change squashed
inside this one. If it is not, please add a few lines in the commit message
explaining the interdependencies.
Line 357:
Line 358: def getStats(self):
Line 359: """
Line 360: Obtain statistics of the specified VM
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Piotr Kliczewski has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 9: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Piotr Kliczewski has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/40103/8/vdsm/API.py File vdsm/API.py: Line 356: M Please use lower letter at the beginning. It seems that it is the convention for the keys. -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/40103/7/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 383: """
Line 384: return {'params': ret['params'], 'migrationPort':
ret['migrationPort']}
Line 385:
Line 386:
Line 387: def VM_getMigrationStatus_Ret(ret):
> its not working other solutions suck as
Also since its a union the key for the 'ret' value is vary:
MigratedStats or MigratingStats it depend on the context - the empty method is
the one that works for both ways
Line 388: """
Line 389: Return status of the Migration, progress and downtime if available
Line 390: """
Line 391: return ret
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/40103/7/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 383: """
Line 384: return {'params': ret['params'], 'migrationPort':
ret['migrationPort']}
Line 385:
Line 386:
Line 387: def VM_getMigrationStatus_Ret(ret):
> I thought that we agreed not to have method which only returns result.
its not working other solutions suck as
'VM_getMigrationStatus': {}
and
'VM_getMigrationStatus': {'ret': 'MigrationStats'}
note:
MigrationStats is a union in json schema
Line 388: """
Line 389: Return status of the Migration, progress and downtime if available
Line 390: """
Line 391: return ret
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 7: migration.py part OK, waiting for the Bridge part as per Piotr's comment. -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Piotr Kliczewski has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40103/7/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 383: """
Line 384: return {'params': ret['params'], 'migrationPort':
ret['migrationPort']}
Line 385:
Line 386:
Line 387: def VM_getMigrationStatus_Ret(ret):
I thought that we agreed not to have method which only returns result.
Line 388: """
Line 389: Return status of the Migration, progress and downtime if available
Line 390: """
Line 391: return ret
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 7: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 6: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Piotr Kliczewski has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40103/4/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 387: def VM_getMigrationStatus_Ret(ret): Line 388: """ Line 389: Return status of the Migration, progress and downtime if available Line 390: """ Line 391: return ret > I will ask Piotr for review You just need to define a key which is use to hold your value. This method is not needed as Francesco is suggesting. Line 392: Line 393: Line 394: def Volume_getsize_Ret(ret): Line 395: """ -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 5: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40103/4/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 387: def VM_getMigrationStatus_Ret(ret): Line 388: """ Line 389: Return status of the Migration, progress and downtime if available Line 390: """ Line 391: return ret > still not sure about this trivial function, but I trust your verification. I will ask Piotr for review Line 392: Line 393: Line 394: def Volume_getsize_Ret(ret): Line 395: """ https://gerrit.ovirt.org/#/c/40103/4/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 98: # fetch migration status from the monitor thread Line 99: self.status['progress'] = self._monitorThread.progress Line 100: Line 101: stat = self._vm._dom.jobStats(libvirt. Line 102: VIR_DOMAIN_JOB_STATS_COMPLETED) > Is this intentional? no I will fix it Line 103: if 'downtime_net' in stat: Line 104: self.status['downtime'] = stat['downtime_net'] Line 105: Line 106: return self.status -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 4: Code-Review+1 (2 comments) seems OK. Please check my comment about formatting in migration.py https://gerrit.ovirt.org/#/c/40103/4/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 387: def VM_getMigrationStatus_Ret(ret): Line 388: """ Line 389: Return status of the Migration, progress and downtime if available Line 390: """ Line 391: return ret still not sure about this trivial function, but I trust your verification. Line 392: Line 393: Line 394: def Volume_getsize_Ret(ret): Line 395: """ https://gerrit.ovirt.org/#/c/40103/4/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 98: # fetch migration status from the monitor thread Line 99: self.status['progress'] = self._monitorThread.progress Line 100: Line 101: stat = self._vm._dom.jobStats(libvirt. Line 102: VIR_DOMAIN_JOB_STATS_COMPLETED) Is this intentional? Line 103: if 'downtime_net' in stat: Line 104: self.status['downtime'] = stat['downtime_net'] Line 105: Line 106: return self.status -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 4: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40103/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1717: 'network': {},
Line 1718: 'disks': {}}
Line 1719: if 'pauseCode' in self.conf:
Line 1720: stats['pauseCode'] = self.conf['pauseCode']
Line 1721: if self.isMigrating() and
self.migrateStatus().has_key('progress'):
> Yep, with the downtime reporting we will call migrateStatus() even after a
I will send it in a separate patch
Line 1722: stats['migrationProgress'] =
self.migrateStatus()['progress']
Line 1723:
Line 1724: decStats = {}
Line 1725: try:
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40103/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1717: 'network': {},
Line 1718: 'disks': {}}
Line 1719: if 'pauseCode' in self.conf:
Line 1720: stats['pauseCode'] = self.conf['pauseCode']
Line 1721: if self.isMigrating() and
self.migrateStatus().has_key('progress'):
> in migration.py at getStat():
Yep, with the downtime reporting we will call migrateStatus() even after a
migration.
But this added protection should be moved in a separate cleanup patch
Line 1722: stats['migrationProgress'] =
self.migrateStatus()['progress']
Line 1723:
Line 1724: decStats = {}
Line 1725: try:
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40103/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1717: 'network': {},
Line 1718: 'disks': {}}
Line 1719: if 'pauseCode' in self.conf:
Line 1720: stats['pauseCode'] = self.conf['pauseCode']
Line 1721: if self.isMigrating() and
self.migrateStatus().has_key('progress'):
> I'd say it should always have a progress when isMigrating()
in migration.py at getStat():
we only add progress on this condition:
if self._monitorThread is not None:
...
and we are calling migrateStat verb after migration done and the thread is
dead...
Line 1722: stats['migrationProgress'] =
self.migrateStatus()['progress']
Line 1723:
Line 1724: decStats = {}
Line 1725: try:
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40103/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1717: 'network': {},
Line 1718: 'disks': {}}
Line 1719: if 'pauseCode' in self.conf:
Line 1720: stats['pauseCode'] = self.conf['pauseCode']
Line 1721: if self.isMigrating() and
self.migrateStatus().has_key('progress'):
> There is not always progress and we had NPE when calling migrateStat verb.
I'd say it should always have a progress when isMigrating()
what NPE you get? There should have been an exception here on vdsm side
Line 1722: stats['migrationProgress'] =
self.migrateStatus()['progress']
Line 1723:
Line 1724: decStats = {}
Line 1725: try:
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 3: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/40103/2/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 387: def VM_getMigrationStatus_Ret(ret):
Line 388: """
Line 389: Return status of the Migration, progress and downtime if available
Line 390: """
Line 391: return ret
> why do we need this? looks like a simple passthrough, IIRC can be avoided
Without that we didn't got the response in the Engine,
That was Piotr suggestion (offline) I will add him for review.
Line 392:
Line 393:
Line 394: def Volume_getsize_Ret(ret):
Line 395: """
https://gerrit.ovirt.org/#/c/40103/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1717: 'network': {},
Line 1718: 'disks': {}}
Line 1719: if 'pauseCode' in self.conf:
Line 1720: stats['pauseCode'] = self.conf['pauseCode']
Line 1721: if self.isMigrating() and
self.migrateStatus().has_key('progress'):
> why is this needed?
There is not always progress and we had NPE when calling migrateStat verb.
I think that it was not tested...
It may be related to the schema fix
Line 1722: stats['migrationProgress'] =
self.migrateStatus()['progress']
Line 1723:
Line 1724: decStats = {}
Line 1725: try:
Line 1866: return self._migrationSourceThread.status
Line 1867: finally:
Line 1868: self._guestCpuLock.release()
Line 1869:
Line 1870: def migrateStatus(self):
> Can't we just always use the new downtime_net?
Libvirt holds the downtime statistics after and clear it so its important to
fetch it only when needed.
The new key downtime_net is not cleared so I will remove that flag
Line 1871: return self._migrationSourceThread.getStat(useDowntime=True)
Line 1872:
Line 1873: def migrateCancel(self):
Line 1874: self._acquireCpuLockWithTimeout()
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 2:
(3 comments)
a few questions inside
https://gerrit.ovirt.org/#/c/40103/2/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 387: def VM_getMigrationStatus_Ret(ret):
Line 388: """
Line 389: Return status of the Migration, progress and downtime if available
Line 390: """
Line 391: return ret
why do we need this? looks like a simple passthrough, IIRC can be avoided
Line 392:
Line 393:
Line 394: def Volume_getsize_Ret(ret):
Line 395: """
https://gerrit.ovirt.org/#/c/40103/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1717: 'network': {},
Line 1718: 'disks': {}}
Line 1719: if 'pauseCode' in self.conf:
Line 1720: stats['pauseCode'] = self.conf['pauseCode']
Line 1721: if self.isMigrating() and
self.migrateStatus().has_key('progress'):
why is this needed?
Line 1722: stats['migrationProgress'] =
self.migrateStatus()['progress']
Line 1723:
Line 1724: decStats = {}
Line 1725: try:
Line 1866: return self._migrationSourceThread.status
Line 1867: finally:
Line 1868: self._guestCpuLock.release()
Line 1869:
Line 1870: def migrateStatus(self):
Can't we just always use the new downtime_net?
Line 1871: return self._migrationSourceThread.getStat(useDowntime=True)
Line 1872:
Line 1873: def migrateCancel(self):
Line 1874: self._acquireCpuLockWithTimeout()
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Build Started (2/3) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18133/ -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Build Started (1/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17961/ -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has uploaded a new change for review.
Change subject: RFE: Report downtime for each live migration
..
RFE: Report downtime for each live migration
vm.py getStat() is called when migration is done and from Engine
initiative.
There is no need to call libvirts domain getStats twice, only when
Engine initiate the call.
Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Bug-Url: https://bugzilla.redhat.com/970711
Signed-off-by: Shahar Havivi
---
M vdsm/rpc/Bridge.py
M vdsm/virt/migration.py
M vdsm/virt/vm.py
3 files changed, 16 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/40103/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index bad8f1b..0484669 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -384,6 +384,13 @@
return {'params': ret['params'], 'migrationPort': ret['migrationPort']}
+def VM_getMigrationStatus_Ret(ret):
+"""
+Return status of the Migration, progress and downtime if available
+"""
+return ret
+
+
def Volume_getsize_Ret(ret):
"""
Merge the two sizes into a single dictionary result.
@@ -471,6 +478,7 @@
'VM_hotunplugNic': {'ret': 'vmList'},
'VM_mergeStatus': {'ret': 'mergeStatus'},
'VM_migrationCreate': {'ret': VM_migrationCreate_Ret},
+'VM_getMigrationStatus': {'ret': VM_getMigrationStatus_Ret},
'VM_pause': {'ret': VM_running_state_change_Ret},
'VM_setCpuTunePeriod': {'ret': 'taskStatus'},
'VM_setCpuTuneQuota': {'ret': 'taskStatus'},
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index f76fac2..8a31552 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -90,7 +90,7 @@
def hibernating(self):
return self._mode == MODE_FILE
-def getStat(self):
+def getStat(self, useDowntime=False):
"""
Get the status of the migration.
"""
@@ -98,9 +98,11 @@
# fetch migration status from the monitor thread
self.status['progress'] = self._monitorThread.progress
-stat = self._vm._dom.jobStats(libvirt.VIR_DOMAIN_JOB_STATS_COMPLETED)
-if 'downtime' in stat:
-self.status['downtime'] = stat['downtime']
+if useDowntime:
+stat = self._vm._dom.jobStats(libvirt.
+ VIR_DOMAIN_JOB_STATS_COMPLETED)
+if 'downtime' in stat:
+self.status['downtime'] = stat['downtime']
return self.status
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 2690c6e..bdb488b 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1718,7 +1718,7 @@
'disks': {}}
if 'pauseCode' in self.conf:
stats['pauseCode'] = self.conf['pauseCode']
-if self.isMigrating():
+if self.isMigrating() and self.migrateStatus().has_key('progress'):
stats['migrationProgress'] = self.migrateStatus()['progress']
decStats = {}
@@ -1868,7 +1868,7 @@
self._guestCpuLock.release()
def migrateStatus(self):
-return self._migrationSourceThread.getStat()
+return self._migrationSourceThread.getStat(useDowntime=True)
def migrateCancel(self):
self._acquireCpuLockWithTimeout()
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Vinzenz Feenstra has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3051: self.log.info("End of migration")
Line 3052:
Line 3053: def _getActualDowntime(self):
Line 3054: stat =
self._dom.jobStats(libvirt.VIR_DOMAIN_JOB_STATS_COMPLETED)
Line 3055: if 'downtime' in stat:
the whole if/else portion can be simplified to one line:
self._actualDowntime = stat.get('downtime', None)
Line 3056: self._actualDowntime = stat['downtime']
Line 3057: else:
Line 3058: self._actualDowntime = None
Line 3059:
--
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17035/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17209/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17209/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/780/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/376/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4761/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/753/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/382/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/783/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/381/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/371/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/787/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Started (9/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/371/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/787/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/376/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/753/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/382/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/381/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4761/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/783/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/780/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: sure I will add the progress to the schema -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Dan Kenigsberg has submitted this change and it was merged. Change subject: RFE: Report downtime for each live migration .. RFE: Report downtime for each live migration Added new value to migrateStatus verb: downtime. downtime reports the actual time that the VM was offline (ie not available for the user). Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Signed-off-by: Shahar Havivi Reviewed-on: https://gerrit.ovirt.org/39039 Tested-by: Shahar Havivi Reviewed-by: Michal Skrivanek Reviewed-by: Dan Kenigsberg --- M vdsm/rpc/vdsmapi-schema.json M vdsm/virt/migration.py 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Dan Kenigsberg: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Dan Kenigsberg has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Code-Review+2 (1 comment) Raising score https://gerrit.ovirt.org/#/c/39039/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 6445 Line 6446 Line 6447 Line 6448 Line 6449 > hm, isn't the existing "progress" missing form the schema? Correct. Should be fixed in a follow-up patch. Can you do this Shahar? -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Code-Review+1 (1 comment) not sure about schema, if it's indeed missing we should probably fix it too (can be done separately or right here, i don't care) https://gerrit.ovirt.org/#/c/39039/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 6445 Line 6446 Line 6447 Line 6448 Line 6449 hm, isn't the existing "progress" missing form the schema? -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has abandoned this change. Change subject: RFE: Report downtime for each live migration .. Abandoned -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: * Update tracker::#970711::OK -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has uploaded a new change for review.
Change subject: RFE: Report downtime for each live migration
..
RFE: Report downtime for each live migration
Added new value to migrateStatus verb: downtime.
downtime reports the actual time that the VM was offline (ie not
available for the user).
Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646
Signed-off-by: Shahar Havivi
---
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/migration.py
2 files changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/39039/1
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 52dea77..f0f978a 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -6433,6 +6433,18 @@
'data': {'vmID': 'UUID'},
'returns': 'VmDefinition'}
+##
+# @MigrationStatusInfo:
+#
+# Information regarding migration
+# on error return what cause the error
+# on success added actulal downtime of the VM
+#
+# @downtime: total time the the VM was offline
+#
+# Since: 4.17.0
+##
+{'type', 'MigrationStatusInfo', 'data': {'downtime': 'str'}}
##
# @VM.getMigrationStatus:
@@ -6447,7 +6459,8 @@
#'message')
##
{'command': {'class': 'VM', 'name': 'getMigrationStatus'},
- 'data': {'vmID': 'UUID'}}
+ 'data': {'vmID': 'UUID'},
+ 'returns': 'MigrationStatusInfo'}
##
# @VmExitCode:
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index c2a112e..6ad02d6 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -97,6 +97,11 @@
if self._monitorThread is not None:
# fetch migration status from the monitor thread
self.status['progress'] = self._monitorThread.progress
+
+stat = self._vm._dom.jobStats(libvirt.VIR_DOMAIN_JOB_STATS_COMPLETED)
+if 'downtime' in stat:
+self.status['downtime'] = stat['downtime']
+
return self.status
def _setupVdsConnection(self):
--
To view, visit https://gerrit.ovirt.org/39039
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17035/ -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d213ed2acb9a9556fa6e9197f686133a69b0646 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: good thing is that as far as I know no one ever used that new verb...I wouldn't mind breaking it. But I don't mind many things other people do...:-) -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 8:
Yes, sorry about my slowness with migrateStatus (still low on caffeine).
It could indeed lead to nicer code, but needs quite some work. For example I
find _really_ ugly this part
#
# Notes: Migration status is returned as the command status ('code' and
#'message')
(from schema) and for the usual backward compatibility reasons this has really
to be preserved (but also wiped away the moment we start work on 4.0).
But yes, could definitely make sense.
--
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: the call for downtime suppose to work until the next migration (according to Jiri) so a verb will probably work fine -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: my point is we already have such a verb And it makes more sense to explicitly call it after things are finished instead of relying on the latest polling of running stats (for progress it does make sense the way it is, but for the final result it does not) -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: Shahar: yep, RunningVmStats is in the schema. It is the data type you will get from VM.getStats() when you call getStats() on an active (status != 'Down' and status != 'Powering_Down') VM. Michal: unless I'm missing something, the new value will be reported by current code after a VM finished migration. Not sure a new query/verb is appropriate and/or may be an overkill. -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: -Code-Review well, we have migrateStatus for ongoing migration...so that's not a good name:/ hm, we can also extend that verb to work post-migration thinking about it even more, we probably should do it only there. As this is exactly what we need...one time query after migration finishes to get the data. And we don't really need it while the migration is in progress. Does it make sense? Francesco? -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: Francesco: is that RunningVmsStats in json structure? Michal: do you have suggested name? -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/37075/8/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 2029: # (new in version 4.15.0) Line 2030: # Line 2031: # @cpuStatistics: Statistics about each cpu core Line 2032: # (new in version 4.15.0) Line 2033: # @migDowntime: Duration that the VM was offline during migration > this doesn't belong to HostStats For some funny reason I always read it as part of Vm Stats. Good catch. Shahar, please move this into RunningVmStats. Line 2034: # in milliseconds. Line 2035: # (new in version 4.17.0) Line 2036: # Line 2037: # Since: 4.10.0 -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/37075/8/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 2029: # (new in version 4.15.0) Line 2030: # Line 2031: # @cpuStatistics: Statistics about each cpu core Line 2032: # (new in version 4.15.0) Line 2033: # @migDowntime: Duration that the VM was offline during migration this doesn't belong to HostStats Line 2034: # in milliseconds. Line 2035: # (new in version 4.17.0) Line 2036: # Line 2037: # Since: 4.10.0 -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: sorry for being so late, but how about changing the naming of getActualDowntime into something more generic. There are plenty of other parameters reported and some of them might be interesting to gather too (e.g. total transferred data, compression ratio) -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 4: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 5: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 7: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 6: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 3: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: when Francescos patch https://gerrit.ovirt.org/#/c/38538 will merged I will remove the version change in vdsm.spec.in and in debian/control -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/565/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/557/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16477/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1123/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16648/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1106/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15677/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/7/vdsm.spec.in
File vdsm.spec.in:
Line 185: Requires: libguestfs-tools-c >= 1:1.26.7-2
Line 186: %endif
Line 187:
Line 188: %if 0%{?rhel} >= 7 || 0%{?fedora}
Line 189: Requires: libvirt-daemon >= 1.1.1
> we need to update *this* line, which takes effect on el7 and Fedora.
Done
Line 190: Requires: libvirt-daemon-config-nwfilter
Line 191: Requires: libvirt-daemon-driver-network
Line 192: Requires: libvirt-daemon-driver-nwfilter
Line 193: Requires: libvirt-daemon-driver-qemu
--
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Dan Kenigsberg has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/37075/7/vdsm.spec.in
File vdsm.spec.in:
Line 185: Requires: libguestfs-tools-c >= 1:1.26.7-2
Line 186: %endif
Line 187:
Line 188: %if 0%{?rhel} >= 7 || 0%{?fedora}
Line 189: Requires: libvirt-daemon >= 1.1.1
we need to update *this* line, which takes effect on el7 and Fedora.
Line 190: Requires: libvirt-daemon-config-nwfilter
Line 191: Requires: libvirt-daemon-driver-network
Line 192: Requires: libvirt-daemon-driver-nwfilter
Line 193: Requires: libvirt-daemon-driver-qemu
--
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/7/vdsm.spec.in
File vdsm.spec.in:
Line 192: Requires: libvirt-daemon-driver-nwfilter
Line 193: Requires: libvirt-daemon-driver-qemu
Line 194: %else
Line 195: %if 0%{?rhel}
Line 196: Requires: libvirt >= 0.10.2-29.el6_5.4
> I guess you need something here too? Should be in 1.2.8 released in RHEL 7.
sorry, that belongs to the section above, RHEL 7+
Line 197: %else
Line 198: Requires: libvirt >= 1.2.9
Line 199: %endif
Line 200: %endif
--
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3056: if 'downtime' in stat:
Line 3057: self._actualDowntime = stat['downtime']
Line 3058: else:
Line 3059: self._actualDowntime = None
Line 3060: except Exception as e:
> "If this is the case, I'd rather not even ask libvirt, as periodic libvirt
I do think that the try/catch is not needed here since we do run in 1.2.8 that
suppose to support this version
Line 3061: self.log.error('error fetching domains jobStats: %r',
e.message)
Line 3062:
Line 3063: def _waitForUnderlyingMigration(self):
Line 3064: timeout = config.getint('vars',
'migration_destination_timeout')
--
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/7/vdsm.spec.in
File vdsm.spec.in:
Line 192: Requires: libvirt-daemon-driver-nwfilter
Line 193: Requires: libvirt-daemon-driver-qemu
Line 194: %else
Line 195: %if 0%{?rhel}
Line 196: Requires: libvirt >= 0.10.2-29.el6_5.4
I guess you need something here too? Should be in 1.2.8 released in RHEL 7.1
Line 197: %else
Line 198: Requires: libvirt >= 1.2.9
Line 199: %endif
Line 200: %endif
--
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3056: if 'downtime' in stat:
Line 3057: self._actualDowntime = stat['downtime']
Line 3058: else:
Line 3059: self._actualDowntime = None
Line 3060: except Exception as e:
> we must not swallow all exceptions - you should swallow only a specific exc
"If this is the case, I'd rather not even ask libvirt, as periodic libvirt
calls are known to accumulate and become expensive."
it's one per VM migration destination finish, that's not that bad...SLA does
worse things...
Line 3061: self.log.error('error fetching domains jobStats: %r',
e.message)
Line 3062:
Line 3063: def _waitForUnderlyingMigration(self):
Line 3064: timeout = config.getint('vars',
'migration_destination_timeout')
--
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Michal Skrivanek has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3056: if 'downtime' in stat:
Line 3057: self._actualDowntime = stat['downtime']
Line 3058: else:
Line 3059: self._actualDowntime = None
Line 3060: except Exception as e:
> Are you suggesting to remove the try/catch?
no, to restrict the exception to the exception you are expecting (missing
jobStats or unsupported flag or whatever)
and try/catch only around the offending call
Line 3061: self.log.error('error fetching domains jobStats: %r',
e.message)
Line 3062:
Line 3063: def _waitForUnderlyingMigration(self):
Line 3064: timeout = config.getint('vars',
'migration_destination_timeout')
--
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/537/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2620/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16266/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1095/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15466/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16436/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1078/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/37075/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3032: self._attachLibvirtDomainAfterMigration( Line 3033: self._incomingMigrationFinished.isSet(), usedTimeout) Line 3034: # else domain connection already established earlier Line 3035: self._domDependentInit() Line 3036: self._handleActualDowntime() > _getActualDowntime? Quite minor thing however Done Line 3037: del self.conf['migrationDest'] Line 3038: hooks.after_vm_migrate_destination(self._dom.XMLDesc(0), self.conf) Line 3039: Line 3040: for dev in self._customDevices(): -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
