Change in vdsm[master]: netlink: event monitor (even more simple version)
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 32: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 31: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 27: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 19: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 25: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 23: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 26: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 24: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 30: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 29: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 28: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 22: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 38: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/32626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23ea72986564c5a115e36be0e7cf679c28c8ea96 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 21: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 20: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
automat...@ovirt.org has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
Dan Kenigsberg has submitted this change and it was merged. Change subject: netlink: event monitor with timeout .. netlink: event monitor with timeout Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Signed-off-by: Petr Horáček Reviewed-on: http://gerrit.ovirt.org/37129 Reviewed-by: Dan Kenigsberg --- M lib/vdsm/netlink/monitor.py M tests/netlinkTests.py 2 files changed, 93 insertions(+), 28 deletions(-) Approvals: Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
Petr Horáček has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: Verified+1 Built OK, passed network's functional tests and netlinkTests. Plus manually tested -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: -Code-Review -Verified Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15361/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15192/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14404/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2531/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15361/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15192/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14404/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2529/ : The patch does not pass the network functional tests -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15361/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15192/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14404/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2528/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15361/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15192/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14404/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2527/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
Petr Horáček has posted comments on this change.
Change subject: netlink: event monitor with timeout
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/37129/5/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 79: mon = Monitor(groups=('link', 'ipv4-route'))
Line 80: mon.start()
Line 81: for event in mon:
Line 82: if foo:
Line 83: mon.stop()
> handling the even is still needed. why drop it from the example?
accident, it's back now
Line 84:
Line 85: Possible groups: link, notify, neigh, tc, ipv4-ifaddr, ipv4-mroute,
Line 86: ipv4-route ipv6-ifaddr, ipv6-mroute, ipv6-route, ipv6-ifinfo,
Line 87: decnet-ifaddr, decnet-route, ipv6-prefix
--
To view, visit http://gerrit.ovirt.org/37129
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15347/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15178/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14390/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2523/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15345/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15176/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14388/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2522/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor with timeout
..
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/37129/5/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 79: mon = Monitor(groups=('link', 'ipv4-route'))
Line 80: mon.start()
Line 81: for event in mon:
Line 82: if foo:
Line 83: mon.stop()
handling the even is still needed. why drop it from the example?
Line 84:
Line 85: Possible groups: link, notify, neigh, tc, ipv4-ifaddr, ipv4-mroute,
Line 86: ipv4-route ipv6-ifaddr, ipv6-mroute, ipv6-route, ipv6-ifinfo,
Line 87: decnet-ifaddr, decnet-route, ipv6-prefix
--
To view, visit http://gerrit.ovirt.org/37129
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 32: Build Failed http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6343/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/523/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/516/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/498/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/124/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/125/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/125/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/123/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4508/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has submitted this change and it was merged. Change subject: netlink: event monitor .. netlink: event monitor Current event monitor is implemented as a wrapper around `ip monitor` command. It sometimes returns before the underlying monitor is properly started. However, it's used just in a few tests. We want to implement more natural version of monitor - wrapper around the libnl library. With this monitor we will be able e.g. to monitor `ifup` operation on a new device and guarantee properly created network before returned. Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Signed-off-by: Petr Horáček Reviewed-on: http://gerrit.ovirt.org/36197 Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg --- M debian/vdsm-python.install M lib/vdsm/netlink/Makefile.am M lib/vdsm/netlink/__init__.py A lib/vdsm/netlink/monitor.py M tests/Makefile.am A tests/netlinkTests.py M vdsm.spec.in 7 files changed, 483 insertions(+), 4 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 31: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Ido Barkan has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 31: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15271/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15102/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14314/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2507/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15268/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15099/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14311/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2506/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15267/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15098/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14310/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2505/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 31: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/335/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15257/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15088/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14300/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/883/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/342/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/900/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2503/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor with timeout .. Patch Set 3: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/37129/3/lib/vdsm/netlink/monitor.py File lib/vdsm/netlink/monitor.py: Line 67: if foo: Line 68: mon.stop() Line 69: handle event Line 70: Line 71: Monitoring events with defined timeout. It there is no time left, 'It there is no time left' -> if timeout expires during iteration, MonitorError(E_TIMEOUTED) BTW, E_TIMEOUT looks better. Line 72: MonitorError: E_TIMEOUTED is raised by iteration: Line 73: mon = Monitor(timeout=2) Line 74: mon.start() Line 75: for event in mon: Line 74: mon.start() Line 75: for event in mon: Line 76: handle event Line 77: Line 78: Monitor defined groups (monitor everything if not set): why did you drop the nice "groups" example? Line 79: mon = Monitor() Line 80: mon.start() Line 81: for event in mon: Line 82: if foo: Line 85: Possible groups: link, notify, neigh, tc, ipv4-ifaddr, ipv4-mroute, Line 86: ipv4-route ipv6-ifaddr, ipv6-mroute, ipv6-route, ipv6-ifinfo, Line 87: decnet-ifaddr, decnet-route, ipv6-prefix Line 88: """ Line 89: def __init__(self, groups=frozenset(), timeout=None): please add a test for the new functionality or at least replace the timed_monitor with it. Line 90: self._time_start = None Line 91: self._timeout = timeout Line 92: self._stopped = False Line 93: if groups: Line 108: yield event Line 109: Line 110: def start(self): Line 111: if self._timeout: Line 112: self._time_start = time.time() please use monotonic_time(). setting _end_time() is slightly cleaner. Line 113: self._scan_thread.start() Line 114: self._scanning_started.wait() Line 115: Line 116: def _scan(self): Line 127: self._queue.put(_TIMEOUT_FLAG) Line 128: break Line 129: Line 130: events = NoIntrPoll(epoll.poll, timeout=timeout) Line 131: if events == []: len(events) == 0 is a bit nicer since it does not assume event isn't a tuple. Line 132: self._queue.put(_TIMEOUT_FLAG) Line 133: break Line 134: elif (self._pipetrick[0], select.POLLIN) in events: Line 135: NoIntrCall(os.read, self._pipetrick[0], 1) -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 31: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 29: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/326/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15180/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/891/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15011/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14223/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/874/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/333/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 30: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/327/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15181/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/892/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15012/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14224/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/875/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/334/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 28: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/325/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15179/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/890/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15010/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14222/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/873/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/332/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor with timeout
Petr Horáček has uploaded a new change for review. Change subject: netlink: event monitor with timeout .. netlink: event monitor with timeout Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Signed-off-by: Petr Horáček --- M lib/vdsm/netlink/monitor.py 1 file changed, 31 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/37129/1 diff --git a/lib/vdsm/netlink/monitor.py b/lib/vdsm/netlink/monitor.py index 307df48..6b938e8 100644 --- a/lib/vdsm/netlink/monitor.py +++ b/lib/vdsm/netlink/monitor.py @@ -23,6 +23,7 @@ import os import select import threading +import time from vdsm.utils import NoIntrCall, NoIntrPoll @@ -38,8 +39,10 @@ # If monitoring thread is running, queue waiting for new value and we call # stop(), we have to stop queue by passing special code. _STOP_FLAG = 31 +_TIMEOUT_FLAG = 32 E_NOT_RUNNING = 1 +E_TIMEOUTED = 2 class MonitorError(Exception): @@ -58,24 +61,34 @@ handle event Monitoring events synchronously: +mon = Monitor() mon.start() for event in mon: if foo: mon.stop() handle event -Monitor defined groups (monitor everything if not set): +Monitoring events with defined timeout. It there is no time left, +MonitorError: E_TIMEOUTED is raised by iteration: +mon = Monitor(timeout=2) mon.start() -for event in Monitor(groups=['link', 'ipv4-route']): +for event in mon: +handle event + +Monitor defined groups (monitor everything if not set): +mon = Monitor() +mon.start() +for event in mon: if foo: mon.stop() -handle event Possible groups: link, notify, neigh, tc, ipv4-ifaddr, ipv4-mroute, ipv4-route ipv6-ifaddr, ipv6-mroute, ipv6-route, ipv6-ifinfo, decnet-ifaddr, decnet-route, ipv6-prefix """ -def __init__(self, groups=frozenset()): +def __init__(self, groups=frozenset(), timeout=None): +self._time_start = None +self._timeout = timeout self._stopped = False if groups: self._groups = groups @@ -88,11 +101,15 @@ def __iter__(self): for event in iter(self._queue.get, None): -if event == _STOP_FLAG: +if event == _TIMEOUT_FLAG: +raise MonitorError(E_TIMEOUTED) +elif event == _STOP_FLAG: break yield event def start(self): +if self._timeout: +self._time_start = time.time() self._scan_thread.start() self._scanning_started.wait() @@ -102,11 +119,18 @@ with _pipetrick(epoll) as self._pipetrick: self._scanning_started.set() while True: -events = NoIntrPoll(epoll.poll) -if (self._pipetrick[0], select.POLLIN) in events: +timeout = ((self._time_start + self._timeout) + - time.time()) if self._timeout else -1 +events = NoIntrPoll(epoll.poll, timeout=timeout) + +if events == []: +self._queue.put(_TIMEOUT_FLAG) +break +elif (self._pipetrick[0], select.POLLIN) in events: NoIntrCall(os.read, self._pipetrick[0], 1) self._queue.put(_STOP_FLAG) break + _nl_recvmsgs_default(sock) def stop(self): -- To view, visit http://gerrit.ovirt.org/37129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Petr Horáček has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 31: Verified+1 Built OK, netlinkTests.py passed hundreds of times. -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 30: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Petr Horáček has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 30: Verified+1 Built OK, netlinkTests.py passed hundreds of times. -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Petr Horáček has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 27:
(7 comments)
http://gerrit.ovirt.org/#/c/36197/27/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 75: ipv4-route ipv6-ifaddr, ipv6-mroute, ipv6-route, ipv6-ifinfo,
Line 76: decnet-ifaddr, decnet-route, ipv6-prefix
Line 77: """
Line 78: def __init__(self, groups=frozenset()):
Line 79: self._stopped = False
> should be renamed to 'stopped' as it is used (read) publically
it is meant to be used locally, tests are just an exception
Line 80: if groups:
Line 81: self._groups = groups
Line 82: else:
Line 83: self._groups = _GROUPS.keys()
http://gerrit.ovirt.org/#/c/36197/27/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 15: class NetlinkEventMonitorTests(TestCaseBase):
Line 16:
Line 17: @ValidateRunningAsRoot
Line 18: def test_iterate_after_events(self):
Line 19: with _timed_monitor(1) as mon:
> just a matter of style, but passing this as a named argumet might be more r
Done
Line 20: dummy_name = dummy.create()
Line 21: dummy.remove(dummy_name)
Line 22: for event in mon:
Line 23: if event.get('name') == dummy_name:
Line 18: def test_iterate_after_events(self):
Line 19: with _timed_monitor(1) as mon:
Line 20: dummy_name = dummy.create()
Line 21: dummy.remove(dummy_name)
Line 22: for event in mon:
> Just so I understand: when no events are collected by the monitor, does the
If we did not catch dummy-related event, it fails with MonitorError, yes.
We are not able to test strictly no-events case, because we can't be sure,
there will be no external event (but we can just ignore incoming events).
I think testing timeout is not necessary, because now it's just a test's
feature, not a part of monitor.py.
Line 23: if event.get('name') == dummy_name:
Line 24: break
Line 25:
Line 26: @ValidateRunningAsRoot
Line 29: iteration we start _add_device, which waits for
iteration_ready event.
Line 30: """
Line 31: dummy_name = dummy.create()
Line 32:
Line 33: def _add_device():
> may rename this function to _add_and_remove?
if i do dummy.create() inside the thread's function, it would be hard to pass
dummy's name to the main thread.
Line 34: time.sleep(.2)
Line 35: dummy.setLinkUp(dummy_name)
Line 36: dummy.remove(dummy_name)
Line 37: add_device_thread = threading.Thread(target=_add_device)
Line 38:
Line 39: with _timed_monitor(1) as mon:
Line 40: add_device_thread.start()
Line 41: for event in mon:
Line 42: print event
> why print?
Done
Line 43: if event.get('name') == dummy_name:
Line 44: break
Line 45: add_device_thread.join()
Line 46:
Line 72: "to link or route." % event['event'])
Line 73:
Line 74: @ValidateRunningAsRoot
Line 75: def test_iteration(self):
Line 76: with _timed_monitor(1) as mon:
> * is this timeout enough even for slow Jenkins vms?
* i don't think so, the test passes within 0.038 second on vdsm-function-tests
Jenkins VM
* StopIteration could happen only after the monitor is stopped. If it is
monitoring, iterator.next() stuck until there is an event available.
Line 77: iterator = iter(mon)
Line 78:
Line 79: # Generate events to avoid blocking
Line 80: dummy_name = dummy.create()
Line 123: % (1 + len(expected_events)))
Line 124:
Line 125:
Line 126: @contextmanager
Line 127: def _timed_monitor(time, groups=frozenset(), raise_exception=True):
> why renaming this to 'time'? Maybe 'interval' (the original Timer arg name)
Done
Line 128: mon = monitor.Monitor(groups=groups)
Line 129: mon.start()
Line 130: try:
Line 131: timer = Timer(time, mon.stop)
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 27:
(3 comments)
http://gerrit.ovirt.org/#/c/36197/27/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 15: class NetlinkEventMonitorTests(TestCaseBase):
Line 16:
Line 17: @ValidateRunningAsRoot
Line 18: def test_iterate_after_events(self):
Line 19: with _timed_monitor(1) as mon:
> just a matter of style, but passing this as a named argumet might be more r
And defining a class-wide TIMEOUT=1 may be sensible, too.
Line 20: dummy_name = dummy.create()
Line 21: dummy.remove(dummy_name)
Line 22: for event in mon:
Line 23: if event.get('name') == dummy_name:
Line 72: "to link or route." % event['event'])
Line 73:
Line 74: @ValidateRunningAsRoot
Line 75: def test_iteration(self):
Line 76: with _timed_monitor(1) as mon:
> * is this timeout enough even for slow Jenkins vms?
/me does not understand your bullet #2.
Line 77: iterator = iter(mon)
Line 78:
Line 79: # Generate events to avoid blocking
Line 80: dummy_name = dummy.create()
Line 123: % (1 + len(expected_events)))
Line 124:
Line 125:
Line 126: @contextmanager
Line 127: def _timed_monitor(time, groups=frozenset(), raise_exception=True):
> why renaming this to 'time'? Maybe 'interval' (the original Timer arg name)
+1. time is a module in the standard library. let's not override it.
Line 128: mon = monitor.Monitor(groups=groups)
Line 129: mon.start()
Line 130: try:
Line 131: timer = Timer(time, mon.stop)
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Ido Barkan has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 27: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/36197/27/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 75: ipv4-route ipv6-ifaddr, ipv6-mroute, ipv6-route, ipv6-ifinfo,
Line 76: decnet-ifaddr, decnet-route, ipv6-prefix
Line 77: """
Line 78: def __init__(self, groups=frozenset()):
Line 79: self._stopped = False
should be renamed to 'stopped' as it is used (read) publically
Line 80: if groups:
Line 81: self._groups = groups
Line 82: else:
Line 83: self._groups = _GROUPS.keys()
http://gerrit.ovirt.org/#/c/36197/27/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 15: class NetlinkEventMonitorTests(TestCaseBase):
Line 16:
Line 17: @ValidateRunningAsRoot
Line 18: def test_iterate_after_events(self):
Line 19: with _timed_monitor(1) as mon:
just a matter of style, but passing this as a named argumet might be more
readable.
Line 20: dummy_name = dummy.create()
Line 21: dummy.remove(dummy_name)
Line 22: for event in mon:
Line 23: if event.get('name') == dummy_name:
Line 18: def test_iterate_after_events(self):
Line 19: with _timed_monitor(1) as mon:
Line 20: dummy_name = dummy.create()
Line 21: dummy.remove(dummy_name)
Line 22: for event in mon:
Just so I understand: when no events are collected by the monitor, does the
test fails with MonitorError?
If so, Does this flow (of not catching any events) worth yet another unit test?
if not, will you consider testing a 0 events scenario?
Line 23: if event.get('name') == dummy_name:
Line 24: break
Line 25:
Line 26: @ValidateRunningAsRoot
Line 29: iteration we start _add_device, which waits for
iteration_ready event.
Line 30: """
Line 31: dummy_name = dummy.create()
Line 32:
Line 33: def _add_device():
may rename this function to _add_and_remove?
why dummy.create is outside of it's scope?
Line 34: time.sleep(.2)
Line 35: dummy.setLinkUp(dummy_name)
Line 36: dummy.remove(dummy_name)
Line 37: add_device_thread = threading.Thread(target=_add_device)
Line 72: "to link or route." % event['event'])
Line 73:
Line 74: @ValidateRunningAsRoot
Line 75: def test_iteration(self):
Line 76: with _timed_monitor(1) as mon:
* is this timeout enough even for slow Jenkins vms?
* I think you should filter for dummy related events, so you won't get a
StopIteration on lines 84 or 81
Line 77: iterator = iter(mon)
Line 78:
Line 79: # Generate events to avoid blocking
Line 80: dummy_name = dummy.create()
Line 123: % (1 + len(expected_events)))
Line 124:
Line 125:
Line 126: @contextmanager
Line 127: def _timed_monitor(time, groups=frozenset(), raise_exception=True):
why renaming this to 'time'? Maybe 'interval' (the original Timer arg name) or
'timeout' is clearer?
Line 128: mon = monitor.Monitor(groups=groups)
Line 129: mon.start()
Line 130: try:
Line 131: timer = Timer(time, mon.stop)
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 27: Code-Review-1
(1 comment)
nit
http://gerrit.ovirt.org/#/c/36197/27/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 38:
Line 39: with _timed_monitor(1) as mon:
Line 40: add_device_thread.start()
Line 41: for event in mon:
Line 42: print event
why print?
Line 43: if event.get('name') == dummy_name:
Line 44: break
Line 45: add_device_thread.join()
Line 46:
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 27: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/310/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/316/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15097/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/875/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14928/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14140/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/858/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Petr Horáček has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 27: Verified+1 Built OK, netlinkTests.py passed hundreds of times. -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 26: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/309/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/315/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15096/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/874/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14927/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14139/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/857/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 25: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/308/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/314/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15095/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/873/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14926/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14138/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/856/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 24: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/306/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/312/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15089/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/871/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14920/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14132/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/854/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 23: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/305/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/311/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15088/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/870/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14919/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14131/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/853/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 23: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/36197/23/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 75: ipv4-route ipv6-ifaddr, ipv6-mroute, ipv6-route, ipv6-ifinfo,
Line 76: decnet-ifaddr, decnet-route, ipv6-prefix
Line 77: """
Line 78: def __init__(self, groups=frozenset()):
Line 79: self.stopped = False
this should better be private now.
Line 80: if groups:
Line 81: self._groups = groups
Line 82: else:
Line 83: self._groups = _GROUPS.keys()
http://gerrit.ovirt.org/#/c/36197/23/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 26: @ValidateRunningAsRoot
Line 27: def test_iterate_while_events(self):
Line 28: """Tests if monitor is able to catch event while iterating.
Before the
Line 29: iteration we start _add_device, which waits for
iteration_ready event.
Line 30: """
place
dummy_name = 'yet to be defined'
here, so the name can be used by the iteration
Line 31: def _add_device():
Line 32: time.sleep(.2)
Line 33: dummy_name = dummy.create(prefix='dummy_mon_')
Line 34: dummy.remove(dummy_name)
Line 48: dummy.remove(dummy_name)
Line 49:
Line 50: found = any('dummy_mon_' in event.get('name', frozenset())
Line 51: for event in mon)
Line 52: self.assertTrue(found, 'Expected event was not catched.')
caught
Line 53:
Line 54: @ValidateRunningAsRoot
Line 55: def test_event_groups(self):
Line 56: with _timed_monitor(1, groups=('ipv4-ifaddr',)) as mon_a:
Line 85: with self.assertRaises(StopIteration):
Line 86: while True:
Line 87: iterator.next()
Line 88:
Line 89: # TODO: sync version
drop this one?
Line 90: @ValidateRunningAsRoot
Line 91: def test_events_keys(self):
Line 92: def _expected_events(nic, address, cidr):
Line 93: return deque([
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Petr Horáček has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 22:
(2 comments)
http://gerrit.ovirt.org/#/c/36197/22/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 27: """Tests if monitor is able to catch event while iterating.
Before the
Line 28: iteration we start _add_device, which is delayed for .2
second. Then
Line 29: iteration starts and waits for new dummy."""
Line 30: def _add_device():
Line 31: time.sleep(.2)
> here is a place to use threading.Event(). wait() for it here, and set() ins
it probably will not reach the set() because there will be no events yielded
Line 32: dummy_name = dummy.create(prefix='dummy_mon_')
Line 33: dummy.remove(dummy_name)
Line 34: add_device_thread = threading.Thread(target=_add_device)
Line 35:
Line 35:
Line 36: with _timed_monitor(1) as mon:
Line 37: add_device_thread.start()
Line 38: for event in mon:
Line 39: if 'dummy_mon_' in event.get('name'):
> why aren't you waiting for the exact dummy_name ?
because of dummy package generates random suffix and dummy's name is returned
inside another thread
Line 40: break
Line 41: add_device_thread.join()
Line 42:
Line 43: @ValidateRunningAsRoot
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 22: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/303/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/309/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15067/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/868/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14898/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14110/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/851/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 21: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/302/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/308/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15066/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/867/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14897/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14109/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/850/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 22:
(7 comments)
http://gerrit.ovirt.org/#/c/36197/22/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 38: # If monitoring thread is running, queue waiting for new value and we
call
Line 39: # stop(), we have to stop queue by sending special code.
Line 40: _STOP_FLAG = 31
Line 41:
Line 42: E_NOT_RUNNING = (1, 'Monitor is not running.')
No real reason to add English text. It also complicates your exception handling.
Line 43:
Line 44:
Line 45: class MonitorError(Exception):
Line 46: pass
Line 109:
Line 110: def stop(self):
Line 111: if self._scan_thread.is_alive():
Line 112: self._scan_thread_scanning.wait()
Line 113: os.write(self._pipetrick[1], 'c')
There's still a race, I'm afraid. After _scan's _pipetrick.__exit__, the fd is
already BAD, but the thread is still running (although for a short while)
Personally, I find events way more confusing than locks. So in this case, I
think that protecting write/close with a mutex as the simplest solution.
Line 114: self._scan_thread.join()
Line 115: else:
Line 116: raise MonitorError(E_NOT_RUNNING)
Line 117:
http://gerrit.ovirt.org/#/c/36197/22/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 27: """Tests if monitor is able to catch event while iterating.
Before the
Line 28: iteration we start _add_device, which is delayed for .2
second. Then
Line 29: iteration starts and waits for new dummy."""
Line 30: def _add_device():
Line 31: time.sleep(.2)
here is a place to use threading.Event(). wait() for it here, and set() inside
the "for event in mon" loop.
Line 32: dummy_name = dummy.create(prefix='dummy_mon_')
Line 33: dummy.remove(dummy_name)
Line 34: add_device_thread = threading.Thread(target=_add_device)
Line 35:
Line 35:
Line 36: with _timed_monitor(1) as mon:
Line 37: add_device_thread.start()
Line 38: for event in mon:
Line 39: if 'dummy_mon_' in event.get('name'):
why aren't you waiting for the exact dummy_name ?
Line 40: break
Line 41: add_device_thread.join()
Line 42:
Line 43: @ValidateRunningAsRoot
Line 145:
Line 146: for event in mon:
Line 147: if _is_dictionary_subset(expected_events[0], event):
Line 148: del expected_events[0]
Line 149: if len(expected_events) == 0:
How about:
expected = q.get_nowait()
for event in mon:
if _is_dictionary_subset(expected, event):
expected = q.get_nowait()
...
assertEqual(q.empty())
Line 150: break
Line 151:
Line 152: self.assertEqual(0, len(expected_events), '%d expected events
has not'
Line 153: ' been caught (in the right order): %s'
Line 169: finally:
Line 170: try:
Line 171: mon.stop()
Line 172: except monitor.MonitorError as e:
Line 173: # If timer was triggered, mon.stop() was called twice and
second
in this point of time, the timer is no longer running. So we can test if mon
was stopped before calling stop() again.
This would basically render the comment in Python, which is a good idea in
general.
Line 174: # time it raised MonitorError(1, 'Monitor is not
running').
Line 175: if e[0] == monitor.E_NOT_RUNNING:
Line 176: raise monitor.MonitorError('Waiting too long for a
monitor'
Line 177:' event.')
Line 178: else:
Line 179: raise
Line 180:
Line 181:
Line 182: def _is_dictionary_subset(subset, superset):
_is_subdict() is a clearer, shorter name.
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 22: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Petr Horáček has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 20:
(1 comment)
http://gerrit.ovirt.org/#/c/36197/20/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 110: {'name': dummy_name, 'type': 'dummy', 'event':
'new_link'},
Line 111: {'label': dummy_name, 'family': 'inet', 'address':
IP_ADDRESS +
Line 112: '/' + IP_CIDR, 'event': 'new_addr'},
Line 113: {'oif': dummy_name, 'event': 'new_route'}]
Line 114: for event in mon:
> how about an exact list comparison - after filtering only dummy_name relate
different index, scope, assigned address
Line 115: for expected_event in expected_events:
Line 116: try:
Line 117: if all([expected_event[k] == event[k]
Line 118:for k in expected_events.keys()]):
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 20: Code-Review-1
(11 comments)
http://gerrit.ovirt.org/#/c/36197/20/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 102: self._queue.put(_STOP_FLAG)
Line 103: break
Line 104: _nl_recvmsgs_default(sock)
Line 105:
Line 106: def stop(self):
as found by your EBADF comment, we have a bug here.
We must never write to self._pipetrick[1] after it has been closed. The only
idea I have to avoid it is to initialize self._sync and acquire it before write
and close.
Line 107: os.write(self._pipetrick[1], 'c')
Line 108: self._scan_thread.join()
Line 109:
Line 110:
http://gerrit.ovirt.org/#/c/36197/20/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 11: from testValidation import ValidateRunningAsRoot
Line 12: from testlib import VdsmTestCase as TestCaseBase
Line 13:
Line 14:
Line 15: class TestNetlinkEventMonitor(TestCaseBase):
-> NetlinkEventMonitorTests
Line 16:
Line 17: @ValidateRunningAsRoot
Line 18: def testEventMonitorRunningAddDeviceBefore(self):
Line 19: with _timed_monitor(1) as mon:
Line 14:
Line 15: class TestNetlinkEventMonitor(TestCaseBase):
Line 16:
Line 17: @ValidateRunningAsRoot
Line 18: def testEventMonitorRunningAddDeviceBefore(self):
no need to the EventMonitor prefix - all this class does is test EventMonitor.
test_iterate_after_events() seems like a clearer name.
Line 19: with _timed_monitor(1) as mon:
Line 20: dummy_name = dummy.create(prefix='dummy_mon_')
Line 21: dummy.remove(dummy_name)
Line 22: for event in mon:
Line 20: dummy_name = dummy.create(prefix='dummy_mon_')
Line 21: dummy.remove(dummy_name)
Line 22: for event in mon:
Line 23: try:
Line 24: if 'dummy_mon_' in event['name']:
why aren't you waiting for the exact dummy_name ?
I'm not sure that exception handling has any benefit here over using
event.get('name').
Line 25: break
Line 26: except KeyError:
Line 27: pass
Line 28:
Line 26: except KeyError:
Line 27: pass
Line 28:
Line 29: @ValidateRunningAsRoot
Line 30: def testEventMonitorRunningAddDeviceDuring(self):
test_iterate_while_events()
Line 31: def _add_device():
Line 32: time.sleep(.2)
Line 33: dummy_name = dummy.create(prefix='dummy_mon_')
Line 34: dummy.remove(dummy_name)
Line 28:
Line 29: @ValidateRunningAsRoot
Line 30: def testEventMonitorRunningAddDeviceDuring(self):
Line 31: def _add_device():
Line 32: time.sleep(.2)
why's the sleep? could you add a comment?
Line 33: dummy_name = dummy.create(prefix='dummy_mon_')
Line 34: dummy.remove(dummy_name)
Line 35: add_device_thread = threading.Thread(target=_add_device)
Line 36:
Line 51: with _timed_monitor(1) as mon:
Line 52: dummy.remove(dummy_name)
Line 53:
Line 54: found = False
Line 55: for event in mon:
consider using a helper function. How about:
found = any(event.get(dummy_name)==dummy_name for event in mon)
?
Line 56: try:
Line 57: if 'dummy_mon_' in event['name']:
Line 58: found = True
Line 59: break
Line 70: dummy.setLinkUp(dummy_name)
Line 71: dummy.remove(dummy_name)
Line 72:
Line 73: for event in mon_a:
Line 74: self.assertIn('_addr', event['event'], "Catched event '%s'
is not "
Catched->caught
Line 75: "related to address." % event['event'])
Line 76:
Line 77: for event in mon_l_r:
Line 78: link_or_route = ('_link' in event['event'] or
Line 97: iterator.next()
Line 98:
Line 99: @ValidateRunningAsRoot
Line 100: def testEventMonitorEventsKeys(self):
Line 101: # TEMP NOTE: we don't need this test, it could be added with
improved
I'm not sure about the purpose of this test; but I'd love to verify that mon
sniffs a complete list of events, in the right order.
Line 102: # ifup which will use mechanism for testing expected events
Line 103: with _timed_monitor(1) as mon:
Line 104: dummy_name = dummy.create()
Line 105: dummy.setIP(dummy_name, IP_ADDRESS, IP_CIDR)
Line 110: {'name': dummy_name, 'type': 'dummy', 'event':
'new_link'},
Line 111: {'label': dummy_name, 'family': 'inet', 'address':
IP_ADDRESS +
Line 112: '/' + IP_CIDR, 'event': 'new_addr'},
Line 113: {'oif': dummy_name, 'event': 'new_route'}]
Line 114: for even
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 20: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/295/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/301/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15011/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/860/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14842/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14054/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/843/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Petr Horáček has abandoned this change. Change subject: netlink: event monitor .. Abandoned It was replaced by http://gerrit.ovirt.org/#/c/36197/ -- To view, visit http://gerrit.ovirt.org/32626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I23ea72986564c5a115e36be0e7cf679c28c8ea96 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 19:
(2 comments)
http://gerrit.ovirt.org/#/c/36197/19/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 78: dummy.remove(dummy_name)
Line 79: finally:
Line 80: mon.stop()
Line 81: found = False
Line 82: conditions = [
expected_events
Line 83: {'name': dummy_name, 'type': 'dummy', 'event': 'new_link'},
Line 84: {'label': dummy_name, 'family': 'inet', 'address':
IP_ADDRESS +
Line 85: '/' + IP_CIDR, 'event': 'new_addr'},
Line 86: {'oif': dummy_name, 'event': 'new_route'}]
Line 164: pass
Line 165:
Line 166:
Line 167: @contextmanager
Line 168: def _monitorTimer(monitor):
it would be nicer if a _timed_monitor(timeout) create a new monitor, and stops
it when timeout expires.
Line 169: def _timeout():
Line 170: monitor.stop()
Line 171:
Line 172: timer = Timer(1, _timeout)
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 19: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/36197/19/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 195: try:
Line 196: obj_dict['event'] = _EVENTS[msg_type]
Line 197: except KeyError:
Line 198: logging.error('unexpected msg_type %s', msg_type)
Line 199: pass
what is the point of these funny "pass"s?
Line 200: else:
Line 201: queue.put(obj_dict)
Line 202: _c_object_input = CFUNCTYPE(c_void_p, c_void_p,
py_object)(_object_input)
Line 203:
Line 234: _close_socket(sock)
Line 235:
Line 236:
Line 237: @contextmanager
Line 238: def _pipetimeout(epoll, timeout):
I think we can do without a second pipe (why waste two more fds?). In any case,
please delay timeout to a folow up patch.
Line 239: pipetimeout = os.pipe()
Line 240: try:
Line 241: timer = threading.Timer(timeout, lambda:
os.write(pipetimeout[1], 'c'))
Line 242: timer.start()
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 19: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/290/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/296/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14981/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/855/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14812/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14024/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/837/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 18: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/269/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/275/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14861/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14693/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13905/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/817/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 17: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/268/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/274/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14857/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/833/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14689/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13901/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/816/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/267/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/273/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14854/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/832/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13898/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/815/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor (even more simple version)
..
Patch Set 17:
(5 comments)
http://gerrit.ovirt.org/#/c/36197/17/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 81: self._queue = Queue.Queue()
Line 82: self._running = False
Line 83:
Line 84: def __iter__(self):
Line 85: getter = self._queue.get if self._running else
self._queue.get_nowait
if we are using the _STOP_QUEUE sentinel, why do we ever need get_nowait()?
If the thread is not yet running - we should block.
If the thread is not longer running - we would have _STOP_QUEUE in the queue.
Please make sure both of these cases are tested.
Line 86: try:
Line 87: for event in iter(getter, None):
Line 88: if event == _STOP_QUEUE:
Line 89: break
Line 97: scan_thread.start()
Line 98: self._running = True
Line 99:
Line 100: def _scan(self):
Line 101: epoll = select.epoll()
for the coolness factor (and 1 line less):
with closing(select.epoll()) as epoll:
Line 102: try:
Line 103: with _monitoring_socket(self._queue, self._groups, epoll)
as sock:
Line 104: with _pipetrick(epoll) as self._pipetrick:
Line 105: while True:
Line 105: while True:
Line 106: events = NoIntrPoll(epoll.poll)
Line 107: if (self._pipetrick[0], select.POLLIN) in
events:
Line 108: self._queue.put(_STOP_QUEUE)
Line 109: os.read(self._pipetrick[0], 1)
Please add a TODO regarding NoIntrCall
Line 110: break
Line 111: _nl_recvmsgs_default(sock)
Line 112: finally:
Line 113: epoll.close()
Line 193: argument (monitor's queue in this case)
Line 194: """
Line 195: nl_error = _nl_msg_parse(msg, _c_object_input, queue)
Line 196: if nl_error < 0:
Line 197: logging.error('EventMonitor nl_msg_parse() failed with %d\n' %
here, there's no need in a trailing \n. Also, please use
logging.error('EventMonitor nl_msg_parse() failed with %d\n',
nl_error)
to avoid formatting if loglevel is low.
Line 198: nl_error)
Line 199: return _NL_STOP
Line 200: _c_event_input = CFUNCTYPE(c_int, c_void_p, c_void_p)(_event_input)
Line 201:
Line 228: yield pipetrick
Line 229: finally:
Line 230: epoll.unregister(pipetrick[0])
Line 231: finally:
Line 232: os.close(pipetrick[0])
os.pipe() returns TWO new file descriptors. Here you close only the first. You
should close the second, too.
Line 233:
Line 234:
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 18: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/36197/18//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-10-30 18:28:23 +0100 Line 4: Commit: Petr Horáček Line 5: CommitDate: 2015-01-08 16:34:24 +0100 Line 6: Line 7: netlink: event monitor (even more simple version) future readers of `git log` would not understand " (even more simple version)", so please drop it. Line 8: Line 9: Current event monitor is implemented as a wrapper around `ip monitor` Line 10: command. It is sometimes returned before the underlying monitor is Line 11: properly started. However, it's used just in few tests. Line 6: Line 7: netlink: event monitor (even more simple version) Line 8: Line 9: Current event monitor is implemented as a wrapper around `ip monitor` Line 10: command. It is sometimes returned before the underlying monitor is "is sometimes" ->sometimes Line 11: properly started. However, it's used just in few tests. Line 12: Line 13: We want to implement more natural version of monitor - wrapper around Line 14: the libnl library. With this monitor we will be able e.g. to monitor http://gerrit.ovirt.org/#/c/36197/18/lib/vdsm/netlink/monitor.py File lib/vdsm/netlink/monitor.py: Line 97: scan_thread.start() Line 98: self._running = True Line 99: Line 100: def _scan(self): Line 101: epoll = select.epoll() please see my comments to ps 17. Line 102: try: Line 103: with _monitoring_socket(self._queue, self._groups, epoll) as sock: Line 104: with _pipetrick(epoll) as self._pipetrick: Line 105: while True: -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
Petr Horáček has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/36197/15/lib/vdsm/netlink/monitor.py File lib/vdsm/netlink/monitor.py: Line 218: yield pipetrick Line 219: finally: Line 220: epoll.unregister(pipetrick[0]) Line 221: finally: Line 222: os.close(pipetrick[0]) i do not open second file descriptor, its number is returned by nl_socket_get_fd() and just passed to poll, so probably it's closed on _close_socket() Line 223: Line 224: -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/265/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14806/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14638/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13850/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/813/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/271/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/264/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/269/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14799/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/829/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14631/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13843/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/812/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/265/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/270/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14806/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14638/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13850/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/813/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/263/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/268/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14798/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14630/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13842/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/811/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/255/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/260/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/820/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14604/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13816/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/803/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/254/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/259/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/819/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14603/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13815/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/802/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 15: Code-Review-1 (9 comments) http://gerrit.ovirt.org/#/c/36197/15/lib/vdsm/netlink/__init__.py File lib/vdsm/netlink/__init__.py: Line 67: Line 68: Line 69: def _open_socket(seq_check=True, callback_function=None, callback_arg=None): Line 70: """Returns an open netlink socket. Line 71: seq_check: If set to False, checking of sequence numbers on the netlink I'd love to keep this text, but as a comment to _nl_socket_disable_seq_check(). We can disable it whenever callback_function is not None. Line 72: socket is disabled. This is required to allow messages to be processed Line 73: which were not requested by a preceding request message, e.g. netlink Line 74: events. Line 75: Line 156: Line 157: Line 158: def _socket_memberships(socket_membership_function, socket, groups): Line 159: groups_codes = [_GROUPS[g] for g in groups] Line 160: groups_codes = groups_codes + [0] * (15 - len(groups_codes)) 15 = len(_GROUPS) - 1 Line 161: err = socket_membership_function(socket, *groups_codes) Line 162: if err: Line 163: _nl_socket_free(socket) Line 164: raise IOError(-err, _nl_geterror()) http://gerrit.ovirt.org/#/c/36197/15/lib/vdsm/netlink/monitor.py File lib/vdsm/netlink/monitor.py: Line 86: pass Line 87: Line 88: def start(self): Line 89: if not self._running: Line 90: thread.start_new(self._scan, tuple()) please use the higher-level threading module, unless you have a good reason not to. Line 91: self._running = True Line 92: Line 93: def _scan(self): Line 94: epoll = select.epoll() Line 97: with _pipetrick_w(epoll) as self._pipetrick: Line 98: while True: Line 99: events = NoIntrPoll(epoll.poll) Line 100: if (self._pipetrick[0], select.POLLIN) in events: Line 101: os.read(self._pipetrick[0], 1) strictly speaking, this read should be wrapped with NoIntrCall, that should be moved to vdsm.utils (on another patch) Line 102: break Line 103: _nl_recvmsgs_default(sock) Line 104: finally: Line 105: epoll.close() Line 152: 78: 'get_dcb', # RTM_GETDCB Line 153: 79: 'set_dcb'} # RTM_SETDCB Line 154: Line 155: Line 156: # This function serves as a callback for nl_msg_parse(message, callback, please re-write as a proper docstring. Line 157: # extra_argument) function. When nl_msg_parse() is called, it passes message as Line 158: # an object to defined callback with optional extra argument (monitor's queue Line 159: # in our case) Line 160: def _object_input(obj, queue): Line 181: # This function serves as a callback for netlink socket. When socket recieves Line 182: # a message, it passes it to callback function with optional extra argument Line 183: # (monitor's queue in this case) Line 184: def _event_input(msg, queue): Line 185: errno = _nl_msg_parse(msg, _c_object_input, queue) errno is an stdlib module, please do not override its name. Line 186: if errno < 0: Line 187: pass # TODO: what to do? Line 188: return _NL_STOP Line 189: _c_event_input = CFUNCTYPE(c_int, c_void_p, c_void_p)(_event_input) Line 183: # (monitor's queue in this case) Line 184: def _event_input(msg, queue): Line 185: errno = _nl_msg_parse(msg, _c_object_input, queue) Line 186: if errno < 0: Line 187: pass # TODO: what to do? I hope it is safe to call logging.error() here. if not - use sys.stderr.write(). Line 188: return _NL_STOP Line 189: _c_event_input = CFUNCTYPE(c_int, c_void_p, c_void_p)(_event_input) Line 190: Line 191: Line 189: _c_event_input = CFUNCTYPE(c_int, c_void_p, c_void_p)(_event_input) Line 190: Line 191: Line 192: @contextmanager Line 193: def _monitor_socket_w(queue, groups, epoll): _monitoring_socket Line 194: c_queue = py_object(queue) Line 195: sock = _open_socket(seq_check=False, callback_function=_c_event_input, Line 196: callback_arg=c_queue) Line 197: try: Line 218: yield pipetrick Line 219: finally: Line 220: epoll.unregister(pipetrick[0]) Line 221: finally: Line 222: os.close(pipetrick[0]) close second fd, too. Line 223: Line 224: -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-R
Change in vdsm[master]: netlink: event monitor (even more simple version)
Petr Horáček has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/36197/10/lib/vdsm/netlink/monitor.py File lib/vdsm/netlink/monitor.py: Line 97: finally: Line 98: _close_socket(sock) Line 99: Line 100: def stop(self): Line 101: # after stop, we have to reinit Monitor > Why? Why would a repeated iter() call fail? It was because of i didn't read stop chars from pipetrick. Line 102: os.write(self._pipetrick[1], 'c') Line 103: Line 104: Line 105: # libnl/include/linux/rtnetlink.h -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/250/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/255/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14742/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/815/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14574/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/798/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13786/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (even more simple version)
Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor (even more simple version) .. Patch Set 10: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/36197/10/lib/vdsm/netlink/__init__.py File lib/vdsm/netlink/__init__.py: Line 66: _pool = NLSocketPool(_POOL_SIZE) Line 67: Line 68: Line 69: def _open_socket(seq_check=True, callback_function=None): Line 70: """Returns an open netlink socket.""" please document the args and return value of the callback function Line 71: sock = _nl_socket_alloc() Line 72: if sock is None: Line 73: raise IOError(get_errno(), 'Failed to allocate netlink handle') Line 74: http://gerrit.ovirt.org/#/c/36197/10/lib/vdsm/netlink/monitor.py File lib/vdsm/netlink/monitor.py: Line 77: self._epoll.register(fd, select.EPOLLIN) Line 78: try: Line 79: while True: Line 80: events = NoIntrPoll(self._epoll.poll) Line 81: if (self._pipetrick[0], select.POLLIN) in events: fix comment: we do not know if "we" or someone else called stop(). All we know is that stop() was called - and we must stop. Also, for cleanliness, we should read a single char off the pipe. Line 82: # after yield we called stop, we are not interested Line 83: # in new events Line 84: break Line 85: Line 97: finally: Line 98: _close_socket(sock) Line 99: Line 100: def stop(self): Line 101: # after stop, we have to reinit Monitor Why? Why would a repeated iter() call fail? Line 102: os.write(self._pipetrick[1], 'c') Line 103: Line 104: Line 105: # libnl/include/linux/rtnetlink.h -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (simple version)
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor (simple version)
..
Patch Set 9: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/36197/9//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-10-30 18:28:23 +0100
Line 4: Commit: Petr Horáček
Line 5: CommitDate: 2014-12-19 10:11:03 +0100
Line 6:
Line 7: netlink: event monitor (simple version)
please explain why a netlink-based monitor is better.
Line 8:
Line 9: Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
http://gerrit.ovirt.org/#/c/36197/9/lib/vdsm/netlink/__init__.py
File lib/vdsm/netlink/__init__.py:
Line 66: _pool = NLSocketPool(_POOL_SIZE)
Line 67:
Line 68:
Line 69: def _open_socket(seq_check=True, callback_function=None):
Line 70: """Returns an open netlink socket."""
please document the args and return value of the callback function
Line 71: sock = _nl_socket_alloc()
Line 72: if sock is None:
Line 73: raise IOError(get_errno(), 'Failed to allocate netlink handle')
Line 74:
http://gerrit.ovirt.org/#/c/36197/9/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 41:
Line 42:
Line 43: class Monitor(object):
Line 44: """Netlink monitor. Usage:
Line 45: Get events collected while the monitor was running:
with the poll-based implementation, this option is less trivial (it requires
MonitorThread). Since it's not really required by Vdsm, let's drop it and allow
only synchronous event.
If someone wants to get events in async, he may shoot a new thread for that.
Line 46:
Line 47: mon = Monitor()
Line 48: mon.start()
Line 49:
http://gerrit.ovirt.org/#/c/36197/9/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 58: if ('dummy_mon_' in event['name']
Line 59: and event['type'] == 'dummy'
Line 60: and event['event'] == 'new_link'):
Line 61: found = True
Line 62: mon.stop()
drop this stop(), and you can drop the ugly "except monitor.MonitorError" in
the finally clause.
Line 63: break
Line 64: except KeyError:
Line 65: pass
Line 66: self.assertTrue(found)
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor (simple version)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor (simple version) .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/218/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/223/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13609/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14566/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/783/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14398/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/766/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
