[MediaWiki-CodeReview] [MediaWiki r88134]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Nikerabbit" posted a comment on MediaWiki.r88134.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88134#c16898
Commit summary:

Fixed a bug in transformation where previous language could leak into later 
transformations in UI language. Not sure what do with userlang.

Comment:

Please review and backport as appropriate.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88109]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" posted a comment on MediaWiki.r88109.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88109#c16899
Commit summary:

discussion with hashar
* moved getInfoBox into Xml.php as infoBox static method
* moved config-infobox* css classes from config to mw-infobox* in shared
* left getInfoBox as a wrapper in the installer

Comment:


+   static function infoBox( [...], $useStypePath = true ) {
+   
+   if ( $useStypePath ) {


Typo ;-)


: ''* moved config-infobox* css classes from config to mw-infobox* in shared''

+/* general info/warning box for SP */
+.mw-infobox {


What is SP and is/would/should this be used in articles/skin ? (since it's in 
shared now..)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88125]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" posted a comment on MediaWiki.r88125.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88125#c16900
Commit summary:

Removed the go() call, and the suspended until go() is called behavior.

Comment:


+   groups[group][groups[group].length] = batch[b];

Not confusing at all :D. Awesome line.


-   if ( !suspended && batch.length ) {

Did you intend to remove the batch.length check ?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88053]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" posted a comment on MediaWiki.r88053.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88053#c16901
Commit summary:

Added direct file loading functionality to debug mode for both scripts and 
styles, with callbacks for module state changes (changing to ready) and 
executing of jobs and modules awaiting dependency resolutions. These changes 
also provide a way to used mw.loader.implement with arrays of URLs for the 
scripts and styles arguments, which will make it possible to implement modules 
using user scripts. This probably solves bug #27023 - tests to verify that will 
be coming soon.

Comment:

Trevor fixed this in r88074.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88012]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" posted a comment on MediaWiki.r88012.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88012#c16902
Commit summary:

Adding qunit tests for isIPv4Address and isIPv6Address in mw.util

Comment:

I'm not sure we can or should. They don't test the same code.


PHPUnit tests the IP Class from IP.php, whereas these QUnit tests test the 
behaviour of the isIP* functions in mediawiki.util.js, they do not behave 
competely the same (for example when passing no arguments, or when passing an 
IP-range).

I only used the tests examples (ie. "...", "::0:", etc.) from the PHP Unit 
tests.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88129]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Bryan" posted a comment on MediaWiki.r88129.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88129#c16903
Commit summary:

(bug 28940) When making a thumb of an SVG, and only specifying the height
make the width be the max SVG size, not the natrual width of the SVG.

Some of the linker code here should perhaps be moved. See comments on bug 28940

Comment:

Now that I think of it; $wgSVGMaxSize is probably wrong, because the image may 
be some other non-svg vector image. I think the image handler should specify 
whether the image can be oversized; i.e. $file->getHandler()->canOversize(). 
Should be ok for now though.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88124]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Bryan" posted a comment on MediaWiki.r88124.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88124#c16904
Commit summary:

Add Rotem Liss and Platonides to author list.

Comment:

I fully agree with Platonides being added to the author list, but I do think 
that the authors list should contain real names.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88109]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Freakolowsky" posted a comment on MediaWiki.r88109.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88109#c16905
Commit summary:

discussion with hashar
* moved getInfoBox into Xml.php as infoBox static method
* moved config-infobox* css classes from config to mw-infobox* in shared
* left getInfoBox as a wrapper in the installer

Comment:

@Nikerabbit: not really. Most of the UI stuff like that is in Xml class. Will 
check with hashar.
@Krinkle: SP = SpecialPage. This function is mostly meant for use in special 
pages. I don't see much use for it in articles, but is good to have some simple 
way of exposing/warning about tricky parameters and expensive functionality.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88111]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Freakolowsky" posted a comment on MediaWiki.r88111.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111#c16906
Commit summary:

* added an option to toggle the display of diff size with a warning message.
* in misermode this option is disabled

Comment:

Nike some database guy i will leave unnamed will probably mind if i start doing 
outer joins. It is possible but after chatting with him about this i think it's 
just to expensive to do that.

And i don't think if someone just feels something should be done their was 
warrants the "fixme" status.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88109]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Nikerabbit" posted a comment on MediaWiki.r88109.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88109#c16907
Commit summary:

discussion with hashar
* moved getInfoBox into Xml.php as infoBox static method
* moved config-infobox* css classes from config to mw-infobox* in shared
* left getInfoBox as a wrapper in the installer

Comment:

They were added before Html class was created.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87940]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" changed the status of MediaWiki.r87940.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87940#c0
Commit summary:



___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87900]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" posted a comment on MediaWiki.r87900.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87900#c16908
Commit summary:

Add unit test for jquery.colorUtil module

Comment:

Is this still needed since you switched to using visibility as a CSS check?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87856]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" changed the status of MediaWiki.r87856.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87856#c0
Commit summary:

Creating a way to toggle mw.config LEGACY_GLOBALS from LocalSettings (bug 
28916).
* I thought a while for a way to somehow get that global variable from php to 
the start of the main mediaWiki object creation. Considered using a (temporary) 
global variable and deleting afterwards, but that looked like a hack and wasn't 
sure about the cross-browser functioning of it. Instead ended up by moving it 
to the startUp module where other global variables are accessed as well. This 
seems to work pretty good.

* Can be toggled from LocalSettings by setting $wgLegacyJavaScriptGlobals.
* Changed some usages of mediaWiki to use the global mw alias instead.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87857]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" changed the status of MediaWiki.r87857.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87857#c0
Commit summary:

RELEASE-NOTES for r87856

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87856]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" changed the status of MediaWiki.r87856.

Old Status: resolved
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87856#c0
Commit summary:

Creating a way to toggle mw.config LEGACY_GLOBALS from LocalSettings (bug 
28916).
* I thought a while for a way to somehow get that global variable from php to 
the start of the main mediaWiki object creation. Considered using a (temporary) 
global variable and deleting afterwards, but that looked like a hack and wasn't 
sure about the cross-browser functioning of it. Instead ended up by moving it 
to the startUp module where other global variables are accessed as well. This 
seems to work pretty good.

* Can be toggled from LocalSettings by setting $wgLegacyJavaScriptGlobals.
* Changed some usages of mediaWiki to use the global mw alias instead.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88130]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Catrope" posted a comment on MediaWiki.r88130.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88130#c16909
Commit summary:

Kill diff.js with fire. It only applies to versions of Gecko that were released 
before Nov 2002, which is wy beyond what we support, or what anyone could 
conceivably be using in this day and age.

Comment:

Alright then: Gecko 2002 and older Gecko engines account for 0.047% of our 
Gecko traffic, or 0.013% of our total traffic.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r78156]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" changed the status of MediaWiki.r78156.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78156#c0
Commit summary:

Ported jsMsg to mw.util; Fixing bugs and modernising 
mediawiki.action.watch.ajax.js a little more

* Using the raw element instead of jQuery object to get href. This way it's the 
complete url instead of what could potentially be a relative path 
(window.location.href is best passed a complete url)
* Adding 'mediawiki.legacy.ajax' as dependency for mediawiki.action.watch.ajax 
as it is and has been for a while.
* Ported jsMsg (legacy.wikibits) to mw.util.jsMessage()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r78157]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" changed the status of MediaWiki.r78157.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78157#c0
Commit summary:

Added a way to hide the jsMessage by calling with empty string, null or no 
arguments

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r78282]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" changed the status of MediaWiki.r78282.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78282#c0
Commit summary:

(mw.util.test) Escape the 'does return, the same way as the 'should return' 
(mw.html.escape() and spaces to non-breaking)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86218]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Raylton P. Sousa" posted a comment on MediaWiki.r86218.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86218#c16910
Commit summary:

Add ParserTest

Comment:

Solve in r87682.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r78345]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" changed the status of MediaWiki.r78345.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78345#c0
Commit summary:

added compareObject function to mediaWiki core jQuery prototyping utilities

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r82498]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Catrope" changed the status of MediaWiki.r82498.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/82498#c0
Commit summary:

bug 27146

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r78150]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Catrope" changed the status of MediaWiki.r78150.

Old Status: new
New Status: resolved

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/78150#c0
Commit summary:

Fixing bugs and modernising mediawiki.action.watch.ajax.js a little bit

* add() takes the selector directly. Passing a jQuery object either doesn't 
work or is an undocumented feature.
* using the mw.util functions instead of a less than perfect regex.
* closest() instead of parents() is faster and should be used whenever possible
* The this in processResult() didn't refer to the jQuery object of the anchor 
tag. It was probably never noticed since it's only used in the else{}-fallback 
(hard to mis). Fixed now by passing the link in the function
* The this in .bind('mw-ajaxwatch') didn't refer to this either, fixed also by 
passing  into the function
* Replace() function in .bind('mw-ajaxwatch') didn't work, the slashes causes 
nothing to be matched at all. Before this the href stayed the same and didn't 
change accordingly.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87900]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" posted a comment on MediaWiki.r87900.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87900#c16911
Commit summary:

Add unit test for jquery.colorUtil module

Comment:

This plugin wasn't written in this commit. colorUtil is used to convert colors 
and easily manipulate them.

I added it to the test suite to make sure it's working properly, just generally 
expanding our test suite.

I did use it to temporarily fix the color CSS check, which is removed now, but 
this plugin should still be part of the test suite on itself.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88111]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Nikerabbit" posted a comment on MediaWiki.r88111.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111#c16912
Commit summary:

* added an option to toggle the display of diff size with a warning message.
* in misermode this option is disabled

Comment:

If nothing else the notice is in the wrong place and needs some work:
 This '''instance''' has recent changes log limited to '''43,800h 0m 0s .''' If 
you use this option, pages not in this log will not be displayed


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88111]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Nikerabbit" posted a comment on MediaWiki.r88111.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111#c16913
Commit summary:

* added an option to toggle the display of diff size with a warning message.
* in misermode this option is disabled

Comment:

Besides, this is disabled in WMF already, so having it a bit slower for others 
wouldn't be an issue for them?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87899]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" posted a comment on MediaWiki.r87899.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87899#c16914
Commit summary:

Follow-up r87898: Using real path

Comment:

There's no way of knowing where the TestSwarm is (or of there's a test swarm at 
all, on this domain or another domain). 

inject.js should probably be written in a way that it'll offer the results to a 
possible test swarm, and the test swarm will pull them out when needed. 
(instead of it pushing it to a hardcoded path, like it is now).

I'm hoping to finish this within the weekend so that by the end of the weekend 
anyone having a MediaWiki install can set up their own test swarm without 
having to change anything within MediaWiki.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87899]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Hashar" changed the status of MediaWiki.r87899.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87899#c0
Commit summary:

Follow-up r87898: Using real path

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88142]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Jeroen De Dauw" changed the status of MediaWiki.r88142.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88142#c0
Commit summary:

Convert SemanticData to SqlStubSemanticData when keeping it in the internal 
cache after an update, and ensure that the completeness of this data is 
recorded correctly (no later attempts to extend it).

Either of these changes fixes Bug 28991, which is thus closed twice now (we can 
keep one closing for later, in case someone reopens it).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88144]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" changed the status of MediaWiki.r88144.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88144#c0
Commit summary:

Goodbye mediawiki.util.test. In no particular order:
* Uses ugly eval()
* Initially meant to cross-browser test mediawiki.util.test, (re|ab|)used for 
random other tests
* Uses ugly html-element innerText comparison to validate tests
* Loaded for all debug=true requests
* Not automatable, not distributeable, not pushable, not compatible with 
TestSwarm.
* I wrote it on a late sunday night because we needed it.
* QUnit is the opposite of this.

To run the test suite: visit /w/resources/test/

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88144]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" changed the status of MediaWiki.r88144.

Old Status: ok
New Status: fixme

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88144#c0
Commit summary:

Goodbye mediawiki.util.test. In no particular order:
* Uses ugly eval()
* Initially meant to cross-browser test mediawiki.util.test, (re|ab|)used for 
random other tests
* Uses ugly html-element innerText comparison to validate tests
* Loaded for all debug=true requests
* Not automatable, not distributeable, not pushable, not compatible with 
TestSwarm.
* I wrote it on a late sunday night because we needed it.
* QUnit is the opposite of this.

To run the test suite: visit /w/resources/test/

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88144]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Trevor Parscal" posted a comment on MediaWiki.r88144.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88144#c16915
Commit summary:

Goodbye mediawiki.util.test. In no particular order:
* Uses ugly eval()
* Initially meant to cross-browser test mediawiki.util.test, (re|ab|)used for 
random other tests
* Uses ugly html-element innerText comparison to validate tests
* Loaded for all debug=true requests
* Not automatable, not distributeable, not pushable, not compatible with 
TestSwarm.
* I wrote it on a late sunday night because we needed it.
* QUnit is the opposite of this.

To run the test suite: visit /w/resources/test/

Comment:

Wrong file?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88146]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r88146.

Old Status: new
New Status: fixme

User "Krinkle" also posted a comment on MediaWiki.r88146.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88146#c16916
Commit summary:

Suppress article feedback tool on redirects. (Bug reported on English
Wikipedia Village Pump).

Comment:

At this point ArticleFeedback is already fully loaded and about to be 
initialized. These kind of checks should be in the startup module so that it 
won't download articlefeedback (and all the dependancies) at all. 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88147]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r88147.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88147#c0
Commit summary:

Revert r88144, deleted the wrong file

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88144]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r88144.

Old Status: fixme
New Status: reverted

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88144#c0
Commit summary:

Goodbye mediawiki.util.test. In no particular order:
* Uses ugly eval()
* Initially meant to cross-browser test mediawiki.util.test, (re|ab|)used for 
random other tests
* Uses ugly html-element innerText comparison to validate tests
* Loaded for all debug=true requests
* Not automatable, not distributeable, not pushable, not compatible with 
TestSwarm.
* I wrote it on a late sunday night because we needed it.
* QUnit is the opposite of this.

To run the test suite: visit /w/resources/test/

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88124]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Siebrand" posted a comment on MediaWiki.r88124.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88124#c16917
Commit summary:

Add Rotem Liss and Platonides to author list.

Comment:

This is what he said his name was, so that's the name I added.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88146]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r88146.

Old Status: fixme
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88146#c0
Commit summary:

Suppress article feedback tool on redirects. (Bug reported on English
Wikipedia Village Pump).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88151]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r88151.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88151#c0
Commit summary:

Move to startup per r88146 code review comment

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88111]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Freakolowsky" posted a comment on MediaWiki.r88111.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111#c16918
Commit summary:

* added an option to toggle the display of diff size with a warning message.
* in misermode this option is disabled

Comment:

ok, true for the "needs more work" part. I'm not that good with messages, it 
took me some effort to not just put "Beware! There be dragons!!" in the 
message. And we need to extend that method to include days/months/years.

But even if this is disabled on WMF it is still not that great of an idea to do 
that on a bigger instance running a standard mysql db. wgRCMaxAge has a default 
of 13 weeks, so for most cases this situation would work anyway. For the edge 
case ... displaying this diff size is '''handy''' ... and i don't think 
something that has no specific functionality other than being handy deserves to 
make such expensive operations.

I might be overthinking this, tho ...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88141]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Nikerabbit" posted a comment on MediaWiki.r88141.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88141#c16919
Commit summary:

bug fixes 18635,27581,27419; new README.OpenID-mediawiki-extension to be 
distinct from README of php-openid library

Comment:

This looks hacky:
 +  $relative = preg_replace("!Special:OpenIDXRDS/!", "", 
$relative);
What if the special page name is localised?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88141]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Wikinaut" posted a comment on MediaWiki.r88141.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88141#c16920
Commit summary:

bug fixes 18635,27581,27419; new README.OpenID-mediawiki-extension to be 
distinct from README of php-openid library

Comment:

Oh yes, it is hackish to get it running. Have a look to the code lines before 
and after my patch. 
One moment - will check how the url looks like before. perhaps you can help me 
then with the correct solution

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88150]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Hashar" changed the status of MediaWiki.r88150.

Old Status: new
New Status: ok

User "Hashar" also posted a comment on MediaWiki.r88150.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88150#c16921
Commit summary:

Remove debugging code introduced in r88115

Comment:

maybe the ressourceLoader could just strips the console.log() stuff :)

Marking ok.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86519]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Happy-melon" posted a comment on MediaWiki.r86519.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86519#c16922
Commit summary:

FIx inconsistent messages in r86482.

Comment:

You removed the tabs from passwordreset-emailelement; was that intentional?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87200]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Bryan" posted a comment on MediaWiki.r87200.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87200#c16923
Commit summary:

Making output of Special:SiteMatrix?action=raw much more similar to 
api.php?action=sitematrix

* (bug 14955) Illogical XML in sitematrix API output

Comment:

Can't we just kill action=raw?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Hackathon parser session initial notes

2011-05-15 Thread Brion Vibber 
On Sat, May 14, 2011 at 7:09 PM, Brion Vibber  wrote:

> In the meantime, if you're brave you can peek at the raw session notes:
> http://etherpad.wikimedia.org/mwhack11Sat-Parser
>
> We're reviving the wikitext-l mailing list for people interested in the
> project; it's gotten some traffic about interesting projects but we'll be
> making it an active working group. I'll also be making regular posts here on
> wikitech-l, on the Wikimedia tech blog, and on the wikis -- but I don't want
> to clutter wikitech-l *too* much with the nitty-gritty details. ;)
>
> Project hub pages will go up tomorrow at
> http://www.mediawiki.org/wiki/Future
>

I've stubbed out a couple sections on:

http://www.mediawiki.org/wiki/Future/Parser_plan

More specific things to follow based on the notes previously posted.

-- brion
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r87200]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Reedy" posted a comment on MediaWiki.r87200.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87200#c16924
Commit summary:

Making output of Special:SiteMatrix?action=raw much more similar to 
api.php?action=sitematrix

* (bug 14955) Illogical XML in sitematrix API output

Comment:

Possibly, I'd imagine Chad would agree

But this would still need doing anyway ;)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87200]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Reedy" posted a comment on MediaWiki.r87200.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87200#c16925
Commit summary:

Making output of Special:SiteMatrix?action=raw much more similar to 
api.php?action=sitematrix

* (bug 14955) Illogical XML in sitematrix API output

Comment:

Wait, didn't I kill raw for SiteMatrix?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87200]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Reedy" changed the status of MediaWiki.r87200.

Old Status: new
New Status: old

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87200#c0
Commit summary:

Making output of Special:SiteMatrix?action=raw much more similar to 
api.php?action=sitematrix

* (bug 14955) Illogical XML in sitematrix API output

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88153]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Nikerabbit" posted a comment on MediaWiki.r88153.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88153#c16926
Commit summary:

initialize Profiler instance singleton with ProfilerStub if 'bogus' is 
detected, rather than failing. CBA to debug. Reviewed by Tim eating his lunch.

Comment:

County Bar Association?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88163]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Jeroen De Dauw" changed the status of MediaWiki.r88163.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88163#c0
Commit summary:

updated to be compatible with SMW 1.6 data model

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88162]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Jeroen De Dauw" changed the status of MediaWiki.r88162.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88162#c0
Commit summary:

use methods of SMWDIWikiPage where possible

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88159]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Jeroen De Dauw" changed the status of MediaWiki.r88159.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88159#c0
Commit summary:

move support for Title generation to the WikiPage data item

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88141]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Wikinaut" posted a comment on MediaWiki.r88141.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88141#c16927
Commit summary:

bug fixes 18635,27581,27419; new README.OpenID-mediawiki-extension to be 
distinct from README of php-openid library

Comment:

fixed in r88172 http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88172


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87635]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Reedy" changed the status of MediaWiki.r87635.

Old Status: fixme
New Status: reverted

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c0
Commit summary:

* Implement MW_VERSION constant in Defines.php and use it in preference to 
$wgVersion.  Defines.php will have been loaded anywhere that 
DefaultSettings.php has been loaded.
* Move the declaration of $wgFeedClasses from Defines.php to WebStart.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87637]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Reedy" changed the status of MediaWiki.r87637.

Old Status: new
New Status: reverted

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87637#c0
Commit summary:

Centralise the minimum-required-php-version in a MW_MIN_PHP_VERSION constant in 
Defines.php.  This requires loading Defines.php before the PHP4 version checks, 
so include a big note reminding people not to include anything other than 
vanilla define() statements in there.

I have a sneaking suspicion that including Defines.php in the entry points 
might not play nicely with HipHop, but I can't test it (wrong OS).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87639]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Reedy" changed the status of MediaWiki.r87639.

Old Status: new
New Status: reverted

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87639#c0
Commit summary:

Move minimum database versions to Defines.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87643]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Reedy" changed the status of MediaWiki.r87643.

Old Status: new
New Status: reverted

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87643#c0
Commit summary:

Follow-up r87637: the terrors of copy-and-paste.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88176]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Happy-melon" posted a comment on MediaWiki.r88176.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88176#c16928
Commit summary:

Revert r87635, r87637, r87639, r87643 (MW_MIN_PHP_VERSION etc.): breaks HipHop 
support.

Comment:

I don't believe r87635 or r87639 should have affected HipHop support, am I 
mistaken?  While I suspected that moving the includes might cause issues, I can 
find no documentation about exactly why doing so is problematic, or what the 
solution is.  I appreciate that this is a bleeding-edge area of work, but it 
would be helpful if you could explain exactly ''how''/why this "breaks HipHop 
support".  Otherwise similar issues will certainly recur in the future.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88179]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Hashar" changed the status of MediaWiki.r88179.

Old Status: new
New Status: ok

User "Hashar" also posted a comment on MediaWiki.r88179.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88179#c16929
Commit summary:

Changing !isset to is_null (thanks Roan!) and fixing some coding style stuff
Followup to r88178

Comment:

I noticed it but forgot to tell you about it :b   marking ok.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88178]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Hashar" changed the status of MediaWiki.r88178.

Old Status: new
New Status: ok

User "Hashar" also posted a comment on MediaWiki.r88178.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88178#c16930
Commit summary:

Setting $wgLocalTZoffset based on $wgLocaltimezone, using code that used to
be in a comment in DefaultSettings.  Pair programmed with hashar.

Comment:

We might want to have someone update the wiki documentation.  Marking 'ok'

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88177]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Hashar" changed the status of MediaWiki.r88177.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88177#c0
Commit summary:

Fix for HipHop breakage in r87748 etc. Please do not use 
require_once(dirname(__FILE__)...) to fetch class, function or define() 
dependencies anymore. You do not need to have HipHop to know that doing so will 
break it.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87652]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Bryan" changed the status of MediaWiki.r87652.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87652#c0
Commit summary:

(follow-up r87651) whoops, forgot release notes.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87651]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Bryan" changed the status of MediaWiki.r87651.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87651#c0
Commit summary:

(bug 28868) Include the number of pages in the default getLongDesc for 
multipaged documents

This will only include the number of pages if there is at least two pages.
If you have a pdf with a single page, it won't say 1 page. I modeled this
on how animated images will only say x frames if x > 1.

(For reference, this will affect extensions like pdfHandler, but it won't
affect extensions like PagedTiffHandler since that one totally overrides
the default method)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88167]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Bryan" changed the status of MediaWiki.r88167.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88167#c0
Commit summary:

Move $wgContLang out of the switch

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86212]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Bryan" posted a comment on MediaWiki.r86212.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86212#c16931
Commit summary:

(Follow-up r86169) Needed supress warnings around iconv
Also make it try to detect if a jpeg file comment has textual data, or is 
random binary stuff.

Comment:

If there should always be a wfSurpressWarnings() around iconv, there should be 
a wrapper function which does that. This function could then also invoke the 
compat iconv.


function wfIconv( $src, $target, $str ) {
 if ( function_exists( 'iconv' ) {
  wfSurpressWarnings();
  iconv( $src, $target, $str );
  wfRestoreWarnings();
 } else {
  Fallback::iconv( $src, $target, $str );
 }
}

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86221]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Bryan" changed the status of MediaWiki.r86221.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86221#c0
Commit summary:

(follow-up r86169) per Reedy, the $val = $val thing is weird.

Most of these were actually here going way way back to the dark ages
(although they were hidden as $tags[$tag] = $val; with $val being the same as 
$tags[$tag])

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r75906]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Bryan" changed the status of MediaWiki.r75906.

Old Status: fixme
New Status: resolved

User "Bryan" also posted a comment on MediaWiki.r75906.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/75906#c16932
Commit summary:

core changes for UploadWizard (merged from r73549 to HEAD in 
branches/uploadwizard/phase3)

Comment:

r88188

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88087]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Bryan" changed the status of MediaWiki.r88087.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88087#c0
Commit summary:

Fix line removedfor no explicit reason from r85771

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88184]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Catrope" changed the status of MediaWiki.r88184.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88184#c0
Commit summary:

w/s and typo fix

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] search=steven+tyler gets Steven_tyler

2011-05-15 Thread Aryeh Gregor 
On Fri, May 13, 2011 at 7:57 PM, Daniel Friesen
 wrote:
> Doesn't look that bad...
> - Some arcane maintenance scripts.
> - Some .js that can't interact with Title working with urls.
> - The expected User, Title, Parser, file related, etc... core api stuff
> that's easy to tweak.
> - Some hardcoded stuff for namespaces which could be improved, but
> actually isn't all that applicable to what we're trying to fix.
> - Some special pages cleaning up inputs where we might want to provide
> something inside Title for that.

Except that there are who knows how many other places in the code that
make such assumptions but aren't so easily found by searching.

On Fri, May 13, 2011 at 11:33 PM, Andrew Dunbar  wrote:
> I'm almost positive Azeri has the same dotless i issue and perhaps
> some of the other Turkic languages of Central Asia. One solution is to
> do accent/diacritic normalization too as part of the canonicalization.

The dotless-i issue affects "Turkic (Turkish/Azerbaijani)" text,
according to .
 This is a well-studied issue with existing standards, and we're not
going to do better than the Unicode Consortium has come up with.

You cannot fix the problem by doing accent/diacritic normalization.
"i" and "I" are the same letter in English but different letters in
Turkish.  You cannot get around that.  We'd need to have a separate
case-folding algorithm for Turkish wikis, or make them use one that's
incorrect for their language.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r88185]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Catrope" changed the status of MediaWiki.r88185.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88185#c0
Commit summary:

Fix Bug #28995: “public interface for getting state of a module” from
Bergi

Sometimes userscripts need to know about the registrated modules,
mostly about their state.
…
My patch also resolves inconsistencies in the naming conventions
of getters and setters; I think there should be a clear
difference.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88016]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "^demon" posted a comment on MediaWiki.r88016.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88016#c16933
Commit summary:

Rewrite importUseModWiki to subclass maintenance, general cleanup, etc. Also 
fixing bug 22287, change default field separator

Comment:

Deferred? This is a core change :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88143]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Catrope" changed the status of MediaWiki.r88143.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88143#c0
Commit summary:

(bug 27073) Lazy init the style marker and insert if not available (ie. when 
using resourceloader js on a non-mediawiki domain); fixing typo (r88074 CR)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88143]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Catrope" posted a comment on MediaWiki.r88143.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88143#c16934
Commit summary:

(bug 27073) Lazy init the style marker and insert if not available (ie. when 
using resourceloader js on a non-mediawiki domain); fixing typo (r88074 CR)

Comment:


+   //mw.log( 'getMarker> Caching marker' );

Don't introduce commented-out code like that, either uncomment or remove it.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87951]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Jeroen De Dauw" changed the status of MediaWiki.r87951.

Old Status: fixme
New Status: resolved

User "Jeroen De Dauw" also posted a comment on MediaWiki.r87951.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87951#c16935
Commit summary:

moved stubbing features of SMWSemanticData container to a new subclass, since 
the code is specific to SQL backends, and not needed in other places that use 
such data

Comment:

Fixed in r88142

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88187]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Hashar" changed the status of MediaWiki.r88187.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88187#c0
Commit summary:

Add check for evil, EVIL @

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Hashar" posted a comment on MediaWiki.r88187.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88187#c16936
Commit summary:

Add check for evil, EVIL @

Comment:

Well it would be useful to have an hint at the function / token using the @ 
operator. Maybe by looking for a method names in the next tokens?
And add a line number or something.

Without those, it is pretty useless.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88182]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Hashar" changed the status of MediaWiki.r88182.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88182#c0
Commit summary:

svn:eol-style native

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88181]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Hashar" changed the status of MediaWiki.r88181.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88181#c0
Commit summary:

Fix directory name, mw-config, not config

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88137]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Hashar" changed the status of MediaWiki.r88137.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88137#c0
Commit summary:

* fixed typo

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88109]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Hashar" posted a comment on MediaWiki.r88109.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88109#c16937
Commit summary:

discussion with hashar
* moved getInfoBox into Xml.php as infoBox static method
* moved config-infobox* css classes from config to mw-infobox* in shared
* left getInfoBox as a wrapper in the installer

Comment:

Freakolowsky > you might actually want to move those methods from Xml to the 
Html class.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] RTL triage at Berlin Hackathon

2011-05-15 Thread Mark A. Hershberger 

Yesterday, since Amir E. Aharoni, an RTL developer who has been
actively helping out by testing and filing RTL bugs, was at the
Berlin Hackathon along with Siebrand from TranslateWiki, it was the
perfect time to hold an RTL triage.

During the triage a developer made the point that screenshots help a
lot in RTL bugs.  Often the person filing the bug does not use English
regularly so their bug report isn't clear.  A screenshot that
demonstrates the problem, along with the URL that produced it, helps a
great deal.

Of course, this doesn't apply only to RTL bugs as even native English
speakers could often clarify their bug report with a screenshot.

During the triage, we looked at the list of RTL blockers on tracking
bug #745

Bug 6100 —  Allow different directionality (rtl/ltr) for user interface
and wiki content
http://bugzilla.wikimedia.org/6100

This is a particularly important bug for multilingual sites like
Commons and Incubator. Amir has said he will be willing to test
this as soon as anything is committed and deployed on
TranslateWiki.

Of course, if this is fixed, then we'll need a way specify the
directionality for a page.  Amir opened Bug 28970 to request this
functionality.

A number of other RTL bugs (e.g, 4236 “BiDi support for the
personal toolbar,” 13477 “Tabs collapsed on LTR wikis for RTL
users”, and 4236 “Bidi support for the personal toolbar”) would be
solved by fixing this bug.

Bug 28994 — Special pages such as watchlist and recent changes should be
tabular
http://bugzilla.wikimedia.org/28994

A few bugs mentioned RTL formatting problems on Special Pages.
Amir pointed out that much of this was tabular data that would be
better suited to table layout than list layout.  Using table
layout each cell of the table could specify the textual direction
and the problems could be solved.

Amir opened this request after the triage.

Bug 13285 — Background incorrectly extended in RTL wikis when using IE
http://bugzilla.wikimedia.org/13285

This one actually looks like it was mis-titled.  We're not
positive yet (and have asked Trevor to have a look), but it looks
like the problem was the background image for arwiki's monobook skin.

Bug 24204 — Problem with external link arrow in rtl languages
http://bugzilla.wikimedia.org/24204

The problem described here is actually a browser bug that we
pushed upstream last year.  We decided to close this bug since it
isn't one that we can fix and the problem is already reported, and
claimed to be fixed, upstream
(https://bugs.webkit.org/show_bug.cgi?id=9272).

Bug 4039 —  BiDI: please preserve dir="ltr" and dir="rtl" in TOC
http://bugzilla.wikimedia.org/4039

As Amir explained, this is not a MediaWiki bug, but a part of a
family of feature requests to make true BiDi editing
easier. Currently it can be solved by inserting LRMs in the right
places.

Bug 9316 —  checkbox alignment in protection form
http://bugzilla.wikimedia.org/9316

Apparently this has been fixed … maybe in Vector, but maybe no one
has checked since Brion last looked in 2007.

Bug 12242 — directionality is not present in action=render
http://bugzilla.wikimedia.org/12242

If you're fetching content using action=render, it is your
responsibility to make sure it is rendered correctly.  Usually,
people should be using the API for getting doing wikitext->html.

Bug 12151 — Bidi problem at Special:RenameUser
http://bugzilla.wikimedia.org/12151

This can't happen any more because of SUL, but even if it could,
bug 6100 (above) would probably take care of the fix.

The remaining three we discussed, we tested and found fixed:

Bug 3621 —  BiDi: evaluate LRM, RLM, followed by "*", "#", ":", ";" …
http://bugzilla.wikimedia.org/3621

Bug 12079 — BiDi problem at History/Diffs
http://bugzilla.wikimedia.org/12079

Bug 12225 — influencing the BiDi algorithm to clearly distinguish
between the signature
http://bugzilla.wikimedia.org/12225

Till next week, happy hacking!

Mark.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Shell requests backlog

2011-05-15 Thread Luiz Augusto 
Hi all,

Firstly, thank you very much for enabling DPL on all Wikisources! [1] It is
IMO a pity that this request was fulfilled based only in a direct request,
but at least it is now enabled.

I'm no longer involved on Wikimedia projects like in the past years, but I'm
still looking their development, for research pursposes. A lot of things
have changed on this time, but the issue of simply shell requests generating
a backlog don't seems to be one of those.

Please help us to develop Wikimedia contents in foreign languages simply
giving 30 minutes each week to check those requests!

Examples of backlogs:

25609  Enable
liquidthreads for the Wikimedia Brasil wiki (waiting since 2010-10-21)

28290  Create
namespaces Page and Index for Esperanto Wikisource (waiting since
2011-03-28)

28686  Enable
namespace "Mutirões:" for WIkimedia Brasil (wainting since 2011-04-24)

Best,
--[[:m:User:555]]

[1] - http://lists.wikimedia.org/pipermail/wikisource-l/2011-May/000973.html
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r88193]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r88193.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88193#c0
Commit summary:

(bug 26742) Add @noflip to RTL-specific rules in jquery.ui.datepicker.css

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88200]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r88200.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88200#c0
Commit summary:

Localisation updates for ToolserverI18N messages from translatewiki.net 
(2011-05-15 19:50:00 UTC)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87842]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r87842.

Old Status: deferred
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87842#c0
Commit summary:

Localisation updates for ToolserverI18N messages from translatewiki.net 
(2011-05-10 20:14:00 UTC)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88018]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r88018.

Old Status: deferred
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88018#c0
Commit summary:

Localisation updates for ToolserverI18N messages from translatewiki.net 
(2011-05-13 21:00:00 UTC)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88187]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "^demon" posted a comment on MediaWiki.r88187.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88187#c16938
Commit summary:

Add check for evil, EVIL @

Comment:

Line number would be hard, since the tokenizer doesn't keep track of those.

I disagree that it's useless, it makes it way easier to find violations :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Shell requests backlog

2011-05-15 Thread Strainu 
I totally aggree that site requests take waaay to long to be closed. I
therefore support Luiz Augusto's request.

Strainu

2011/5/15 Luiz Augusto :
> Hi all,
>
> Firstly, thank you very much for enabling DPL on all Wikisources! [1] It is
> IMO a pity that this request was fulfilled based only in a direct request,
> but at least it is now enabled.
>
> I'm no longer involved on Wikimedia projects like in the past years, but I'm
> still looking their development, for research pursposes. A lot of things
> have changed on this time, but the issue of simply shell requests generating
> a backlog don't seems to be one of those.
>
> Please help us to develop Wikimedia contents in foreign languages simply
> giving 30 minutes each week to check those requests!
>
> Examples of backlogs:
>
> 25609  Enable
> liquidthreads for the Wikimedia Brasil wiki (waiting since 2010-10-21)
>
> 28290  Create
> namespaces Page and Index for Esperanto Wikisource (waiting since
> 2011-03-28)
>
> 28686  Enable
> namespace "Mutirões:" for WIkimedia Brasil (wainting since 2011-04-24)
>
> Best,
> --[[:m:User:555]]
>
> [1] - http://lists.wikimedia.org/pipermail/wikisource-l/2011-May/000973.html
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Autocreated accounts are now logged again

2011-05-15 Thread Chad 
Hi everyone,

Just dropping a note to let people know that I've merged and deployed r85128--
reverting hiding logs of all autocreated accounts. As pointed out on bug 19161
(specifically, comment #46), this solution was overkill and failed to actually
address the underlying concern.

Fixes for the original bug are certainly welcome, but lets not use a
sledgehammer where we could've used a screwdriver.

-Chad

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r88053]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Krinkle" changed the status of MediaWiki.r88053.

Old Status: ok
New Status: fixme

User "Krinkle" also posted a comment on MediaWiki.r88053.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88053#c16939
Commit summary:

Added direct file loading functionality to debug mode for both scripts and 
styles, with callbacks for module state changes (changing to ready) and 
executing of jobs and modules awaiting dependency resolutions. These changes 
also provide a way to used mw.loader.implement with arrays of URLs for the 
scripts and styles arguments, which will make it possible to implement modules 
using user scripts. This probably solves bug #27023 - tests to verify that will 
be coming soon.

Comment:



+   function handlePending() {

if ( $.inArray( module, 
jobs[j].dependencies ) !== -1 ) {


module is not defined here. Causes ReferenceError: Can't find variable: 
module when (for example) tablesorter is loaded after dom-ready (try on 
a page with a ).

I guess passing module should do it although I'm not quite sure, this function 
is a little magic to me.

Doesn't err in production mode (either not happening or silently ignored, I 
guess the latter)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86519]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Siebrand" posted a comment on MediaWiki.r86519.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86519#c16940
Commit summary:

FIx inconsistent messages in r86482.

Comment:

Yes.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] search=steven+tyler gets Steven_tyler

2011-05-15 Thread Marco Schuster 
On Sun, May 15, 2011 at 5:02 PM, Aryeh Gregor
 wrote:
> You cannot fix the problem by doing accent/diacritic normalization.
> "i" and "I" are the same letter in English but different letters in
> Turkish.  You cannot get around that.  We'd need to have a separate
> case-folding algorithm for Turkish wikis, or make them use one that's
> incorrect for their language.
Actually non-Turkish/Azerbaijan wikis have this problem too, if the
wiki has articles or redirects using these characters...

Marco

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Stepping down as maintainer for OpenID extension

2011-05-15 Thread Sergey Chernyshev 
Guys,

I'd like to step down as maintainer for OpenID extension.
Please remove me as maintainer from Bugzilla.

Sorry - don't have time and energy to apply patches and fix bugs, hope
somebody else can pick it up.

Thank you,

 Sergey


--
Sergey Chernyshev
http://www.sergeychernyshev.com/
http://www.meetup.com/Web-Performance-NY/
http://www.showslow.com/
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r88210]: Revision status changed

2011-05-15 Thread MediaWiki Mail 
User "Jack Phoenix" changed the status of MediaWiki.r88210.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88210#c0
Commit summary:

updated my userinfo (+jQuery)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] Bugzilla Weekly Report

2011-05-15 Thread reporter 
MediaWiki Bugzilla Report for May 09, 2011 - May 16, 2011

Status changes this week

Bugs NEW   :  199 
Bugs ASSIGNED  :  20  
Bugs REOPENED  :  37  
Bugs RESOLVED  :  282 

Total bugs still open: 5760

Resolutions for the week:

Bugs marked FIXED  :  195 
Bugs marked REMIND :  0   
Bugs marked INVALID:  26  
Bugs marked DUPLICATE  :  21  
Bugs marked WONTFIX:  25  
Bugs marked WORKSFORME :  9   
Bugs marked LATER  :  7   
Bugs marked MOVED  :  0   

Specific Product/Component Resolutions & User Metrics 

New Bugs Per Component

UploadWizard6   
Blog5   
General/Unknown 5   
User interface  4   
General/Unknown 4   

New Bugs Per Product

MediaWiki   33  
Wikimedia   18  
MediaWiki extensions20  
Wikipedia Mobile1   
mwEmbed 3   

Top 5 Bug Resolvers

mah [AT] everybody.org  25  
sam [AT] reedyboy.net   23  
Bryan.TongMinh [AT] Gmail.com   13  
innocentkiller [AT] gmail.com   11  
hashar [AT] free.fr 11  


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r88129]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Bawolff" posted a comment on MediaWiki.r88129.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88129#c16941
Commit summary:

(bug 28940) When making a thumb of an SVG, and only specifying the height
make the width be the max SVG size, not the natrual width of the SVG.

Some of the linker code here should perhaps be moved. See comments on bug 28940

Comment:

Yeah I know, but $wgSVGMaxSize is the only relevant variable we had. Really all 
it needs is any random big number - the width is checked against the maximum 
later.

As for isVectorized vs canOversize. canOversize might be a better name if we 
were just introducing that now. As it stands, isVectorized is really only used 
to determine if it can be oversized.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87404]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail 
User "VasilievVV" changed the status of MediaWiki.r87404.

Old Status: new
New Status: fixme

User "VasilievVV" also posted a comment on MediaWiki.r87404.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87404#c16942
Commit summary:

Commit live hack for bug 28678

Comment:

That is completely wrong, because Special:WikiSets/0 is a link to add a new 
entry.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87405]: New comment added, and revision status changed

2011-05-15 Thread MediaWiki Mail 
User "VasilievVV" changed the status of MediaWiki.r87405.

Old Status: new
New Status: resolved

User "VasilievVV" also posted a comment on MediaWiki.r87405.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87405#c16943
Commit summary:

Same as r87404, in trunk. Fixes bug 28678: Special:WikiSets/0 explodes

Comment:

Re-implemented in r88215.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87404]: New comment added

2011-05-15 Thread MediaWiki Mail 
User "Peachey88" posted a comment on MediaWiki.r87404.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87404#c16944
Commit summary:

Commit live hack for bug 28678

Comment:

why is /0 a link to add a new entry... seems illogical?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

  1   2   >