named pipes still broken?
Is it just me, or are named pipes broken for other people, too? In my tests, Wine can create named pipes, but the reading side can't open them. (Even without my recent changes to sync.c which added filename checking.) - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
J. Grant wrote: Hi Tony, Thanks for the info. fixme:msvcrt:_XcptFilter (0,0x40626b58)semi-stub wine client error:0x80bd8b0: partial write 64 Sounds like this bug then. http://bugs.winehq.com/show_bug.cgi?id=1257 it is fixed by this patch (not yet in CVS) http://www.winehq.com/hypermail/wine-patches/2003/02/0098.html Just read that, so it appears that a work around is to copy the dll to windows/system dir? No. move, not copy, as long as the dll is in the programs directory wine will use the built-in (wines) version of the dll (bad bug! fifty pushups) This bug was introduced 2002/09/24 19:16:52 so it would affect your latter (20030115) tarball. Well, I just did that with msvcrt.dll and unfortunatly it still crashes with this wine ./nmake.exe or wine -dll msvcrt=n ./nmake.exe This leads me to think that that this is not the same bug with the newer wine build /nmake.exe/ and /cl.exe/ do not work. With the following error: fixme:msvcrt:_XcptFilter (-2147483392,0x40702720)semi-stub this is the built-in (wine) version of msvcrt that is reporting this. Your program is expecting its own version of msvcrt. -- Tony Lambregts
Re: Wine default install queries - Wine 20030115
Hi, This looks like a good thing to setup the locale etc. However, I have LANG=en_GB.UTF-8, so perhaps it should have selected en_GB in this process. It started doing this when I ran wcmd for the first time after installing. Regards JG $ wcmd Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: Could not stat /cdrom (No such file or directory), ignoring drive D: For language 'en' several language ids were found: en_US - 0409; en_GB - 0809; en_AU - 0C09; en_CA - 1009; en_NZ - 1409; en_IE - 1809; en_ZA - 1C09; en_JM - 2009; en_CB - 2409; en_BZ - 2809; en_TT - 2C09; en_ZW - 3009; en_PH - 3409; Instead of using first in the list, suggest to define your LANG environment variable like this: LANG=en_US Building font metrics. This may take some time...
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
Hi Tony, Thanks for the info. fixme:msvcrt:_XcptFilter (0,0x40626b58)semi-stub wine client error:0x80bd8b0: partial write 64 Sounds like this bug then. http://bugs.winehq.com/show_bug.cgi?id=1257 it is fixed by this patch (not yet in CVS) http://www.winehq.com/hypermail/wine-patches/2003/02/0098.html Just read that, so it appears that a work around is to copy the dll to windows/system dir? Well, I just did that with msvcrt.dll and unfortunatly it still crashes with this wine ./nmake.exe or wine -dll msvcrt=n ./nmake.exe This leads me to think that that this is not the same bug with the newer wine build /nmake.exe/ and /cl.exe/ do not work. With the following error: fixme:msvcrt:_XcptFilter (-2147483392,0x40702720)semi-stub Also /cmd.exe/ does not work: (is this related?) $ wine ./cmd.exe fixme:console:SetConsoleCtrlHandler (0x4ad09d41,1) - no error checking or testing yet A subdirectory or file .exe already exists. /link.exe/ does run, and so do /winemine/ and /notepad/, so I think the install must be ok. I could not find any bugs relating to XcptFilter, are you aware of any issues that could resolve this or workaround it please? Regards JG
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
Tony Lambregts wrote: http://www.winehq.org/docs/wine-devel/cvs-regression.shtml Unfortunatly I am on a momdem, which restricts my abilities here. I will look for a workaround to find the regression patch. I did regression testing via modem in the past. "cvs -z 3" compresses the stream so that download times are minimized. I found it much faster to simply download the raw CVS archives; do that once, and the cvs gets from the local archive run a zillion times faster. I think it's a win if you have to do more than four or five downloads. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045
Re: Wine default install queries - Wine 20030115
J. Grant wrote: Hi, WTH.. how is it getting this? something is wrong before this. Get rid of you old config file (rename it junk or something) and rerun ./tools/wineinstall. I would like to see the full log of this. OK: Created /home/now3d/.wine/config using default Wine configuration. You probably want to review the file, though. Compiling regedit... make: Nothing to be done for `all'. Preparing to install default Wine registry entries... Installing default Wine registry entries... Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: Could not stat /cdrom (No such file or directory), ignoring drive D: From "config" [Drive A] "Path" = "/mnt/fd0" "Type" = "floppy" "Label" = "Floppy" "Filesystem" = "win95" "Serial" = "87654321" "Device" = "/dev/fd0" [Drive D] "Path" = "/cdrom" "Type" = "cdrom" "Label" = "CD-Rom" "Filesystem" = "win95" ; make sure that device is correct and has proper permissions ! "Device" = "/dev/cdrom" Seems strange that although it said it was ignoring A: and D: it added them anyway. No No No. "The default config file contains has the floppy located at /mnt/fd0 (Where it actualy is depends on your distro) likewise for your CD-ROM. When tools/wineinstall starts up regedit to install the default registry it starts up wine. wine reads the config file and cannot find those directorys (since thats not where your CD-ROM and floppy are mounted) so it ignores them ignoring drive C: Could not stat /cdrom (No such file or directory), ignoring drive D: Invalid path L"c:\\windows" for L"windows" directory: does not exist Perhaps you have not properly edited or created your Wine configuration file. This is (supposed to be) '/home/now3d/.wine/config' Registry install failed. ### do you know what the "L" is in that text? I have seen it in other error messages but it seems strange... any ideas? The "L" tells me that the string is "unicode" as opposed to "ASCII" As for why "L" I do not know. Regards JG ps no need to cc me as I am on the wine-devel list now. -- Tony Lambregts
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
Salut Vincent, Thanks for your reply. This is most probably not what you want. If you grab this file, you'll have every (as in, since 1998 or so) revision of every file in the Wine CVS repository. Although with that, you won't need a net connection to do regressions before the day you downloaded it... Yes, this looked simplest, otherwise I'm on modem waiting while I do stuff, i would rather download at night and have it ready to work in the day. This is what the cvs-regression.shtml article suggested first it seemed. The wine-cvsdirs-* is the archive you want. It only contains the directories CVS uses to know which revision of each file is the current one in your tree. In this case, it's the one in the corresponding snapshot. Once installed the wine-cvsdirs-*, you'll be able to get a copy of the tree as of different times in the past, and locate when the problem you're looking for arose. OK, thanks, I will bare that in mind when working on this. Regards JG
Re: Wine default install queries - Wine 20030115
Hi, WTH.. how is it getting this? something is wrong before this. Get rid of you old config file (rename it junk or something) and rerun ./tools/wineinstall. I would like to see the full log of this. OK: Created /home/now3d/.wine/config using default Wine configuration. You probably want to review the file, though. Compiling regedit... make: Nothing to be done for `all'. Preparing to install default Wine registry entries... Installing default Wine registry entries... Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: Could not stat /cdrom (No such file or directory), ignoring drive D: From "config" [Drive A] "Path" = "/mnt/fd0" "Type" = "floppy" "Label" = "Floppy" "Filesystem" = "win95" "Serial" = "87654321" "Device" = "/dev/fd0" [Drive D] "Path" = "/cdrom" "Type" = "cdrom" "Label" = "CD-Rom" "Filesystem" = "win95" ; make sure that device is correct and has proper permissions ! "Device" = "/dev/cdrom" Seems strange that although it said it was ignoring A: and D: it added them anyway. ignoring drive C: Could not stat /cdrom (No such file or directory), ignoring drive D: Invalid path L"c:\\windows" for L"windows" directory: does not exist Perhaps you have not properly edited or created your Wine configuration file. This is (supposed to be) '/home/now3d/.wine/config' Registry install failed. ### do you know what the "L" is in that text? I have seen it in other error messages but it seems strange... any ideas? Regards JG ps no need to cc me as I am on the wine-devel list now.
Re: 2GB visible partition size
Duane Clark wrote: Tony Lambregts wrote: Alexandre Julliard wrote: Well, yes, if we really need to change the fstype it should be a generic option that allows all types to be specified, not just NTFS. And it shouldn't overload the existing "type" parameter, it should be a separate entry. OK. I guess my biggest problem with this is that the most obvious name for this entry is "Filesytem" which is already used . Since the parameter of interest is specifically named "fsname" rather than "fstype" or "Filesystem", perhaps that should be the configurable parameter name. I would think that would eliminate any confusion. Yes, but how about "FSname" (it looks better in the config file) -- Tony Lambregts
Re: Listview delete column zero
On February 13, 2003 11:06 pm, Duane Clark wrote: > I probably should have mentioned why the app deletes column zero. It > repeatedly deletes column zero, testing the returned Boolean until it > gets false, and then it starts inserting new columns. So it ends up > completely replacing the listview contents. That sounds ... strage . Why not just use LVM_DELETEALLITEMS? -- Dimi.
Re: wcmd autoexec.bat?
On Fri, 14 Feb 2003, J. Grant wrote: [...] > This could be a something to try, however I cannot find out the command > line, in man page or by guessing. > > Is it something like "wcmd -vars=BLAH=moo" d-aliegri mentioned this on > #winehq No, I mean: $ export BLAH=moo $ wcmd IOW, just set the Unix environment variable before starting wine. Or to automate things, write a script that executes the above two commands, or edit wcmd itself (I believeit is a shell script that invokes the wineloader). -- Francois Gouget [EMAIL PROTECTED]http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !
Re: Listview delete column zero
Duane Clark wrote: While the MSDN specifically says that column zero should not be deleted, it does in fact work on WinNT, and at least one app depends on it. On WinNT, deleting column zero deletes the last column of items but the first header. Since no app will ever depend on that bizarre behavior, we just delete the last column including the header. I probably should have mentioned why the app deletes column zero. It repeatedly deletes column zero, testing the returned Boolean until it gets false, and then it starts inserting new columns. So it ends up completely replacing the listview contents.
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
J. Grant wrote: OK, Eric Pouech wrote: were you using native or builtin msvcrt ? I installed Wine 20020804 again, and it is working again, it was using msvcrt.dll that I had placed in the bin dir. I get the following error without it, and the command returns without displaying anything. fixme:msvcrt:_XcptFilter (0,0x40626b58)semi-stub wine client error:0x80bd8b0: partial write 64 Sounds like this bug then. http://bugs.winehq.com/show_bug.cgi?id=1257 it is fixed by this patch (not yet in CVS) http://www.winehq.com/hypermail/wine-patches/2003/02/0098.html -- Tony Lambregts
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
J. Grant wrote: Hi Tony, I did regression testing via modem in the past. "cvs -z 3" compresses I have been looking for the best way to tackle this. http://www.winehq.org/docs/wine-devel/cvs-regression.shtml On this page cvs-dirs-2000-05-20.tar.gz is used, but I can not find a file starting with this filename. http://winehq.com/development/ mentions full-cvs-date.tar.gz as a full copy of the repository. available at ftp://ftp.winehq.com/pub/wine/ If these are the correct filenames instead of cvs-dirs-* (there were some files called wine-cvsdirs-* but they were only 40KB) could this be amended please? So, I am going to download this, as it looks big enough! 50MB! Hope its the right archive? ftp://ftp.winehq.com/pub/wine/full-cvs-2003-02-12.tar.gz What Vincent said about this is correct. Would it be possible to add this one line command to get the wine src to the development page ?(http://winehq.com/development/) I think its simpler to read, and might attract more people to wine.. cvs -z 3 -d :pserver:[EMAIL PROTECTED]:/home/wine co wine cvs -z 3 -d :pserver:[EMAIL PROTECTED]:/home/wine co wine Well if you are on a modem this might take a while! -- Tony Lambregts
Re: For your consideration, here's a preview of some new seh_try_macros-typestuff...
Alexandre Julliard wrote: There are people building Wine with the Sun compiler. Also it makes sense for at least some dlls to allow building them with MSVC to test them under Windows. And in general using different compilers is a good way to shake out bugs from the code. I always build my conformance tests both in the normal way and standalone with msvc. IMHO every executable and DLL we do should run on Windows, too, if it doesn't absolutely have to make Unix system calls. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
J. Grant a écrit: Hi Tony, I did regression testing via modem in the past. "cvs -z 3" compresses I have been looking for the best way to tackle this. http://www.winehq.org/docs/wine-devel/cvs-regression.shtml On this page cvs-dirs-2000-05-20.tar.gz is used, but I can not find a file starting with this filename. http://winehq.com/development/ mentions full-cvs-date.tar.gz as a full copy of the repository. available at ftp://ftp.winehq.com/pub/wine/ If these are the correct filenames instead of cvs-dirs-* (there were some files called wine-cvsdirs-* but they were only 40KB) could this be amended please? So, I am going to download this, as it looks big enough! 50MB! Hope its the right archive? ftp://ftp.winehq.com/pub/wine/full-cvs-2003-02-12.tar.gz This is most probably not what you want. If you grab this file, you'll have every (as in, since 1998 or so) revision of every file in the Wine CVS repository. Although with that, you won't need a net connection to do regressions before the day you downloaded it... The wine-cvsdirs-* is the archive you want. It only contains the directories CVS uses to know which revision of each file is the current one in your tree. In this case, it's the one in the corresponding snapshot. Once installed the wine-cvsdirs-*, you'll be able to get a copy of the tree as of different times in the past, and locate when the problem you're looking for arose. Vincent
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
Hi Tony, I did regression testing via modem in the past. "cvs -z 3" compresses I have been looking for the best way to tackle this. http://www.winehq.org/docs/wine-devel/cvs-regression.shtml On this page cvs-dirs-2000-05-20.tar.gz is used, but I can not find a file starting with this filename. http://winehq.com/development/ mentions full-cvs-date.tar.gz as a full copy of the repository. available at ftp://ftp.winehq.com/pub/wine/ If these are the correct filenames instead of cvs-dirs-* (there were some files called wine-cvsdirs-* but they were only 40KB) could this be amended please? So, I am going to download this, as it looks big enough! 50MB! Hope its the right archive? ftp://ftp.winehq.com/pub/wine/full-cvs-2003-02-12.tar.gz Would it be possible to add this one line command to get the wine src to the development page ?(http://winehq.com/development/) I think its simpler to read, and might attract more people to wine.. cvs -z 3 -d :pserver:[EMAIL PROTECTED]:/home/wine co wine cvs -z 3 -d :pserver:[EMAIL PROTECTED]:/home/wine co wine Regards JG
Re: Wine default install queries - Wine 20030115
J. Grant wrote: Hi, There is no windows version defined in the [Version] block, should a windows version be defined to use as default? The short answer is that it should not be required In the case where a program tries to detect what version of MS-Windows it is running on is there a default returned? From what I understand win31 It looks like that if you are using Windows dlls it takes the version from the first dll it loads and uses that. (I could be wrong) The code for this is in misc/version.c Are there any test programs to see this at all? I did not find a test dir in the src or other wine package for testing. There is a "tools" dir that had some very useful programs I have used before. I have no idea why it would be there. my personal guess is that there are some helper programs in the tools directory that might use it. (Does anyone know ?) Drive F: was setup as CDROM, even though the ./tools/wineinstall said it could not find the CDROM during the process I think. Checking fstab for "cdrom" would determine the cdrom drive(s) on most computers. This should work. A log of the relevant part of ./tools/wineinstall would be good. OK, I ran again, it ended abrumptly (perhaps because this was the 2nd time I ran it). You can see the log of the cdrom detection section though. ### Installing default Wine registry entries... Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: Could not stat /home/now3d/.wine/yes (No such file or directory), WTH.. how is it getting this? something is wrong before this. Get rid of you old config file (rename it junk or something) and rerun ./tools/wineinstall. I would like to see the full log of this. ignoring drive C: Could not stat /cdrom (No such file or directory), ignoring drive D: Invalid path L"c:\\windows" for L"windows" directory: does not exist Perhaps you have not properly edited or created your Wine configuration file. This is (supposed to be) '/home/now3d/.wine/config' Registry install failed. ### Well to be case correct "Wine". I think this is a holdover from when wine "needed windows" so the drive would be "MS-DOS" as oppossed to "*nix" The label is irrelavant to wine but.(ahem) isn't "MS-DOS" a (tm). Anyways changing it would not hurt any objections or other suggestions? "Wine" sounds good to me, I did not think partitions can have mixed case filenames in MS-Windows though? It seems to force the first character to be in upper-case only in my experience. Just a little joke on my part. "Wine" is the proper name of this project. I noticed a few references to MS-DOS in the "config" file, such as: ;; MS-DOS drives configuration Perhpas this would be better labeled as "DOS" (generally), or even just "Drive configuration" in this case..? MS-DOS is a trademark. Yeah I suppose we could change that too. -- Tony Lambregts
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
Hi Tony, I did regression testing via modem in the past. "cvs -z 3" compresses the stream so that download times are minimized. The number of downloads required to find the day. OK, thaks for this useful infomation! I have a 1GHz athlon so it should not be too painful. I will give it a try over the next day or so. One last thing. If you do decide to do this please first check that it is not fixed in an up-to-date CVS (it happens!) Yes, I was planning on checking that, and also Wine 20020804 incase it was my origional build that was at fault. Regards JG
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
OK, Eric Pouech wrote: were you using native or builtin msvcrt ? I installed Wine 20020804 again, and it is working again, it was using msvcrt.dll that I had placed in the bin dir. I get the following error without it, and the command returns without displaying anything. fixme:msvcrt:_XcptFilter (0,0x40626b58)semi-stub wine client error:0x80bd8b0: partial write 64 Regards JG
Re: wcmd autoexec.bat?
Hi Francois Gouget, Thanks for the reply. Francois Gouget wrote: On Thu, 13 Feb 2003, J. Grant wrote: [...] I think this is a key feature, I would like to use this to set some enviroment variables, currently I have to run a batch file manually each time I start wcmd. Could this be considered for implementation please? Why not set the environment variables on the Unix side instead? For instance in the wine wrapper script? This could be a something to try, however I cannot find out the command line, in man page or by guessing. Is it something like "wcmd -vars=BLAH=moo" d-aliegri mentioned this on #winehq Regards JG
Re: wine/dlls/comctl32 listview.c
On February 12, 2003 11:49 am, Rein Klazes wrote: > This causes a rgeression in newsbin. The listview with the headers do > not update during a "retrieve all headers". Indeed. Thanks for the bug report. Please give this a shot, it should fix it. ChangeLog Correctly remember the first paint event, but delay item metrics calculation until we actually have some items. Index: dlls/comctl32/listview.c === RCS file: /var/cvs/wine/dlls/comctl32/listview.c,v retrieving revision 1.339 diff -u -r1.339 listview.c --- dlls/comctl32/listview.c11 Feb 2003 22:17:31 - 1.339 +++ dlls/comctl32/listview.c14 Feb 2003 01:09:10 - @@ -226,6 +226,7 @@ HIMAGELIST himlState; BOOL bLButtonDown; BOOL bRButtonDown; + BOOL bNoItemMetrics; /* flags if item metrics are not yet computed */ INT nItemHeight; INT nItemWidth; RANGES selectionRanges; @@ -7032,6 +7033,7 @@ infoPtr->nHotItem = -1; infoPtr->bRedraw = TRUE; infoPtr->bFirstPaint = TRUE; + infoPtr->bNoItemMetrics = TRUE; infoPtr->iconSpacing.cx = GetSystemMetrics(SM_CXICONSPACING); infoPtr->iconSpacing.cy = GetSystemMetrics(SM_CYICONSPACING); infoPtr->nEditLabelItem = -1; @@ -7850,11 +7852,12 @@ { TRACE("(hdc=%p)\n", hdc); -if (infoPtr->bFirstPaint && infoPtr->nItemCount) +infoPtr->bFirstPaint = FALSE; +if (infoPtr->bNoItemMetrics && infoPtr->nItemCount) { UINT uView = infoPtr->dwStyle & LVS_TYPEMASK; - infoPtr->bFirstPaint = FALSE; + infoPtr->bNoItemMetrics = FALSE; LISTVIEW_UpdateItemSize(infoPtr); if (uView == LVS_ICON || uView == LVS_SMALLICON) LISTVIEW_Arrange(infoPtr, LVA_DEFAULT); -- Dimi.
Re: wcmd autoexec.bat?
Hi, Sylvain Petreolle: davep email arrived here after, not sure why. There is code in wcmdmain.c (line 113) to execute a batch file c:\autoexec.bat but it is commented out - it could be dangerous in a dual-boot machine to execute such a batch file by default. OK, this sounds like a good position to take, regarding c:\autoexec.bat. What I require is environment variables, could be defined in a batch file, or in some config similar to "System Properties -> Advanced -> Environment Variables.." in NT5. This could be implemented in several ways: 1. A "config" flag default false when installed to call c:\autoexec.bat. 2. A "config" block defining each variable 3. A c:\autoexec.wine file that was called when wine is run. 4. A ~/.wine/autoexec.bat file that would be empty by default and used by the user if they desired. With a "config" true/false flag if necessary. I believe suggestion four is most suitable. I is safe from the chance of being executed by accident and could be used to setup essential environment variables. Also sugestion one would mean we could enable the option to run this file in "config". Would be simpler to implement, and would not possibly run a batch file from off the configured wine drives. Cheers JG
Re: suspended threads acquiring synchronization objects
Dimitrie O. Paun wrote: On Thu, 13 Feb 2003, Peter Hunnisett wrote: ... I've attached a simple test case, the code for the test case and a ReWind licensed patch for the problem. Are you sure? The version with the attached test case got stuck in moderator limbo because it is 60KB, and I just now got to it.
Keyboard shortcut to disable DXGrab?
What would be involved in implementing a keyboard shortcut (ideally configurable) to temporarily disable DXGrab, when playing a game in a window? If such a thing was done, would it be accepted into the source? -- Matthew Toseland [EMAIL PROTECTED][EMAIL PROTECTED] Full time freenet hacker. http://freenetproject.org/ Freenet Distribution Node (temporary) at http://amphibian.dyndns.org:8889/ahNdJC6opVw/ ICTHUS. msg17505/pgp0.pgp Description: PGP signature
Re: 2GB visible partition size
Tony Lambregts wrote: Alexandre Julliard wrote: Well, yes, if we really need to change the fstype it should be a generic option that allows all types to be specified, not just NTFS. And it shouldn't overload the existing "type" parameter, it should be a separate entry. OK. I guess my biggest problem with this is that the most obvious name for this entry is "Filesytem" which is already used . Since the parameter of interest is specifically named "fsname" rather than "fstype" or "Filesystem", perhaps that should be the configurable parameter name. I would think that would eliminate any confusion.
Re: Wine default install queries - Wine 20030115
am I forbidden to call my dog 'ms-dos' ? > Well to be case correct "Wine". I think this is a holdover from when > wine "needed windows" so the drive would be "MS-DOS" as oppossed to > "*nix" The label is irrelavant to wine but.(ahem) isn't "MS-DOS" a > (tm). > Anyways changing it would not hurt any objections or other > suggestions? = Sylvain Petreolle [EMAIL PROTECTED] Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com
Re: popupmenu itemsize
Uwe Bonnes wrote: Christian> PS: By the way: every cvs operation (update, diff) hangs Christian> after processing the last directory. However it seems to be Christian> complete and pressing CTRL-C seems not to corrupt Christian> anything. Any ideas? Are you using rhlx01.fht-esslingen.de? Andi works on that problem then. I had this on another server, and solved it by upgrading CVS to the next version. I believe you can also prevent this by not using the -z option, but as I have already upgraded cvs this I can't test. The version of cvs in debian Woody has this problem. I upgraded to the version from testing to make it go away. Brad
suspended threads acquiring synchronization objects
Howdy, we've discovered that windows seems to not allow suspended threads to acquire synchronization objects, which make really really good sense, while wine does. I've attached a simple test case, the code for the test case and a ReWind licensed patch for the problem. Would people have a look at the patch and let me know if it's the best way to fix it, or if I've missed anything? (other than the attachements on the first go at this)? Thanks, Peter [EMAIL PROTECTED] <> // TestSuspendThread.cpp : Defines the entry point for the console application. // #include "stdafx.h" #include "windows.h" CRITICAL_SECTION CritSect; DWORD WINAPI TheyCallMeMrThread( LPVOID lpParameter ) { printf("Thread >B< Attempting to get critical section! \n"); EnterCriticalSection(&CritSect); printf("Thread >B< Critical section obtained!\n"); printf("Thread >B
Re: 2GB visible partition size
Hello, Actually Alexandre hasn't commented on it, so if it doesn't bit rot it still could be commited. However, at the time, there were some negative comments about it. It seems that the major concern is that it should do more than it does. The relevant thread on its pros and cons is here. http://www.winehq.com/hypermail/wine-devel/2003/01/0600.html Some interesting comments. Regarding the partition description (win95, unix, ntfs), it seems to only be the format of the filenames and the permissions, perhaps there is an independent way of stating this? such as "legacyfs" and "unixfs"... If the FS is specified as win95 that is an alias of fat32/vfat and this does not have 2GB file limit as I recall. So I'm not sure why this problem is even occuring. Does NTFS FS really get returned to win9x applications that might have been made before they could know about NTFS? At this point I have seen nothing to convince me that there is anything wrong with the patch, in fact I am quite pleased with it. Well, I would like to see this added to wine, Alexandre, would you comment on this issue please? Regards JG p.s. That block by you was just hysterical :)
Re: Looking for information on implemented API's in wine
Hmm. I did intend to use a database, specifically MySQL was my thinking. What I hoped was there would be a web interface to query the database and so everyone would not have to have MySQL to use it. Of course it needs to be hosted somewhere but I figured I'd cross that bridge when it became a problem. :) The move from flat file to SQL could be done with one 'mysqlimport command so right now I'll focus on gathering the information and placing it in a flat file. The question then will be how to query it, but I suppose it's best to deal with one problem at a time. - Original Message - From: "Dimitrie O. Paun" <[EMAIL PROTECTED]> To: "Dave Miller" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Thursday, February 13, 2003 7:31 PM Subject: Re: Looking for information on implemented API's in wine > On February 13, 2003 07:42 pm, Dave Miller wrote: > > I am ready to begin work on the actual database aspect of cross > > referencing the windows dlls. > > Hi Dave, I'm not sure if you intend to use a real database > (like MySql, or PostgreSQL) to implement this, but if you > do, I'd strongly advise against it. Doing so will limit > its usefulness tremendously, as few people are willing to > go through the pain of installing and setting the database > up just for this script. > > Ideally all information would be stored in ASCII flat files, > read in core at startup, and processed in memory. This way > everybody can play with the script. > > -- > Dimi. > >
Re: Looking for information on implemented API's in wine
Sounds to me like I can use the spec files as a reference, but to be accurate I'll need to scan the source code as well for any APIs which the spec files claim are implemented in order to determine if they are only FIXMEs. :( I'll see if I can understand how winapi_check does it. - Original Message - From: "Rolf Kalbermatter" <[EMAIL PROTECTED]> To: "David Miller" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Thursday, February 13, 2003 6:04 PM Subject: Re: Looking for information on implemented API's in wine > David Miller <[EMAIL PROTECTED]> wrote: > > >I am ready to begin work on the actual database aspect of cross referencing > >the windows dlls. As part of the database I would like to include the > >status of a given API in wine so it will be possible to do things like > >query for all unimplemented APIs in a given dll. The first questions I > >have are whether or not I can depend on the spec files to give a complete > >list, and can someone either point me to documentation on the spec files or > >explain everything I need to know in order to determine the status of APIs > >defined there? > > I'm sure this will not really be enough, although it is at least a start. > There are a lot of functions which are implemented according to the spec > file but only consists of an empty function body with a FIXME, or is only > partly implemented with again a FIXME somewhere in the function. > > Rolf Kalbermatter > > >
Re: Looking for information on implemented API's in wine
On February 13, 2003 07:42 pm, Dave Miller wrote: > I am ready to begin work on the actual database aspect of cross > referencing the windows dlls. Hi Dave, I'm not sure if you intend to use a real database (like MySql, or PostgreSQL) to implement this, but if you do, I'd strongly advise against it. Doing so will limit its usefulness tremendously, as few people are willing to go through the pain of installing and setting the database up just for this script. Ideally all information would be stored in ASCII flat files, read in core at startup, and processed in memory. This way everybody can play with the script. -- Dimi.
Re: Wine default install queries - Wine 20030115
Hi, There is no windows version defined in the [Version] block, should a windows version be defined to use as default? The short answer is that it should not be required In the case where a program tries to detect what version of MS-Windows it is running on is there a default returned? Are there any test programs to see this at all? I did not find a test dir in the src or other wine package for testing. There is a "tools" dir that had some very useful programs I have used before. Drive F: was setup as CDROM, even though the ./tools/wineinstall said it could not find the CDROM during the process I think. Checking fstab for "cdrom" would determine the cdrom drive(s) on most computers. This should work. A log of the relevant part of ./tools/wineinstall would be good. OK, I ran again, it ended abrumptly (perhaps because this was the 2nd time I ran it). You can see the log of the cdrom detection section though. ### Installing default Wine registry entries... Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: Could not stat /home/now3d/.wine/yes (No such file or directory), ignoring drive C: Could not stat /cdrom (No such file or directory), ignoring drive D: Invalid path L"c:\\windows" for L"windows" directory: does not exist Perhaps you have not properly edited or created your Wine configuration file. This is (supposed to be) '/home/now3d/.wine/config' Registry install failed. ### Well to be case correct "Wine". I think this is a holdover from when wine "needed windows" so the drive would be "MS-DOS" as oppossed to "*nix" The label is irrelavant to wine but.(ahem) isn't "MS-DOS" a (tm). Anyways changing it would not hurt any objections or other suggestions? "Wine" sounds good to me, I did not think partitions can have mixed case filenames in MS-Windows though? It seems to force the first character to be in upper-case only in my experience. I noticed a few references to MS-DOS in the "config" file, such as: ;; MS-DOS drives configuration Perhpas this would be better labeled as "DOS" (generally), or even just "Drive configuration" in this case..? MS-DOS is a trademark. Regards JG
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
Salut, Bien recu votre email. did you upgrade VC in the meantime ? Non, c'est tout comme avant. were you using native or builtin msvcrt ? Well, "config" [DllOverrides] has this line below, and I placed the msvcrt.dll in the mnake.exe dir, so I believe it could have been using it before. config line: "msvcrt" = "native, builtin" msvcrt.dll is still in the bin dir, so when i run nmake from wcmd or on a bash shell wine --.namke.exe it still has the same problem. Just in case I put some common dlls that I used to get other programs running (in the specific dir again) and called nmake again. Wine debugger started agian with the same issue as before. from bash I ran: wine -dll msvcrt,comctl32,comdlg32,mspdb60,commdlg=n d:\\vs\\vc98\\bin\\nmake.exe Regards JG
Re: Looking for information on implemented API's in wine
David Miller <[EMAIL PROTECTED]> wrote: >I am ready to begin work on the actual database aspect of cross referencing >the windows dlls. As part of the database I would like to include the >status of a given API in wine so it will be possible to do things like >query for all unimplemented APIs in a given dll. The first questions I >have are whether or not I can depend on the spec files to give a complete >list, and can someone either point me to documentation on the spec files or >explain everything I need to know in order to determine the status of APIs >defined there? I'm sure this will not really be enough, although it is at least a start. There are a lot of functions which are implemented according to the spec file but only consists of an empty function body with a FIXME, or is only partly implemented with again a FIXME somewhere in the function. Rolf Kalbermatter
Re: suspended threads acquiring synchronization objects
On Thu, 13 Feb 2003, Peter Hunnisett wrote: > ... I've attached a simple test case, the code for the test > case and a ReWind licensed patch for the problem. Are you sure? -- Dimi.
suspended threads acquiring synchronization objects
Howdy, we've discovered that windows seems to not allow suspended threads to acquire synchronization objects, which make really really good sense, while wine does. I've attached a simple test case, the code for the test case and a ReWind licensed patch for the problem. Would people have a look at the patch and let me know if it's the best way to fix it, or if I've missed anything? Thanks, Peter [EMAIL PROTECTED]
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
J. Grant wrote: Hi Tony, This is called a regression. I see you are not on CVS but if you switch to it, you could find the the patch that broke the app. The link on how to do this is here. http://www.winehq.org/docs/wine-devel/cvs-regression.shtml OK, thank you for the infomation, very well written document! Unfortunatly I am on a momdem, which restricts my abilities here. I will look for a workaround to find the regression patch. I did regression testing via modem in the past. "cvs -z 3" compresses the stream so that download times are minimized. The number of downloads required to find the day. Days No of itinerations 11 22 43 84 16 5 32 6 64 7 128 8 256 9 512 10 Assumming that there are no masking regressions to complicate the process you should be able to find the day after nine tests. After you have the day the number of substitue the number of patches for days to fine the itinerations required. Most days it would be 6 or less. The biggest problem with regression testing for me was not the download time but the compile time. which is dependent on the computers speed and amount of RAM. On my old P300 with 96mb it can take up to three hours. I obviously cant force you to do this but regression testing is the most efficient way to fix these problems. As a benifit of setting this up you get to be bleading edge up to date as possible, thus making it possible to find regressions very quickly. I actually have three trees one for development, one for regression testing and one "clean" up to date CVS. One last thing. If you do decide to do this please first check that it is not fixed in an up-to-date CVS (it happens!) If you have problems with this or have suggestions on how to improve the docu please let me know. Well, could "Cvs" be written "CVS" ? The technical infomation seems top notch. Can do. I see a few other minor thing I want to clean up while i'm at it. -- Tony Lambregts
Re: Error in the server thread id fix
Bill Medland wrote: On February 13, 2003 12:29 pm, Eric Pouech wrote: Bill Medland wrote: Is anyone else looking into a problem that appears to have been introduced by the server change on Feb 1st changing thread and process ids to small integers? does this help ? A+ Yep. (So should the fix be there or should get_process_id be able to handle a null pointer?) since the function is inline, it doesn't matter much I'd better leave it that way, so it makes it clear that we don't always keep track of the parent for a given process A+ -- Eric Pouech
Re: Error in the server thread id fix
On February 13, 2003 12:29 pm, Eric Pouech wrote: > Bill Medland wrote: > > Is anyone else looking into a problem that appears to have been > > introduced by the server change on Feb 1st changing thread and process > > ids to small integers? > > does this help ? > A+ Yep. (So should the fix be there or should get_process_id be able to handle a null pointer?) -- Bill Medland ACCPAC International, Inc. [EMAIL PROTECTED] Corporate: www.accpac.com Hosted Services: www.accpaconline.com
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
J. Grant wrote: Hi, Calling nmake from /wcmd/ used to work, now it does not. I can't see why not, here is the debugger ouput if anyone knows whats wrong I'd be happy to hear! did you upgrade VC in the meantime ? were you using native or builtin msvcrt ? A+ -- Eric Pouech
Re: wcmd autoexec.bat?
On Thu, 13 Feb 2003, J. Grant wrote: [...] > I think this is a key feature, I would like to use this to set some > enviroment variables, currently I have to run a batch file manually each > time I start wcmd. Could this be considered for implementation please? Why not set the environment variables on the Unix side instead? For instance in the wine wrapper script? -- Francois Gouget [EMAIL PROTECTED]http://fgouget.free.fr/ War doesn't determine who's right. War determines who's left.
Re: wcmd autoexec.bat?
--- "J. Grant" <[EMAIL PROTECTED]> a écrit : > Hello Sylvain, > > Sylvain Petreolle wrote: > >> Currently the wcmd shell starts up with no prompt, this has to be > >> corrected in my batch files. prompt $p$g etc. > > please update, this has been changed. > > Thanks for the info, I just tried the 20030115 and that > prompt $p$g is default somewhere now. (is there a file it is set in?) it was enabled by default into the wcmd code. > > However, the autoexec.bat is stil not executed, I tested with the > following and with wcmd. you missed the mail from davep, this a bad idea for now to execute it : http://www.winehq.com/hypermail/wine-devel/2003/02/0430.html = Sylvain Petreolle [EMAIL PROTECTED] Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com
Re: 2GB visible partition size
Alexandre Julliard wrote: Tony Lambregts <[EMAIL PROTECTED]> writes: Actually Alexandre hasn't commented on it, so if it doesn't bit rot it still could be commited. However, at the time, there were some negative comments about it. It seems that the major concern is that it should do more than it does. Well, yes, if we really need to change the fstype it should be a generic option that allows all types to be specified, not just NTFS. And it shouldn't overload the existing "type" parameter, it should be a separate entry. OK. I guess my biggest problem with this is that the most obvious name for this entry is "Filesytem" which is already used . But it may be enough to simply always return FAT32, if that works for the app in question. Not really. FAT32 has a limitation of 4GB which is why I picked NTFS (size is limited to HD space). In other words no size limitation. Returning NTFS is a bit misleading anyway since we don't implement any of the NTFS-specific features. I fail to see how this is a problem. IIRC a win95 workstation connected to a NT servers NTFS drive will return "NTFS" for that drive and Win95 does not implement any NTFS specific features. Now please correct me if I am wrong. Also the current code always returns "CDFS" for CD-ROMs and I would not want to change that behavior. All that being said I am not really opposed to having it as another entry. How about "FStype" would you prefer something else. -- Tony Lambregts
Re: Error in the server thread id fix
On February 13, 2003 11:56 am, Mike Hearn wrote: > Ah ha, so that's the problem is it? I'm seeing a similar issue with IE6 > after loading the adobe svg viewer plugin. For no apparent reason, Wine > bombs after about 1-2 minutes. It doesn't crash or anything, it just > stops, and the logs don't show anything out of the ordinary. The windows > stay on the screen, but the processes appear hung. > > How did you determine it was changing the ids? Just a regression search? Yep. It just takes processor time really, so that is the easiest way. Looks like it is the next_process handler. > > On Thu, 2003-02-13 at 18:52, Bill Medland wrote: > > Is anyone else looking into a problem that appears to have been > > introduced by the server change on Feb 1st changing thread and process > > ids to small integers? > > > > As a result ACCPAC for Windows' main desktop process shuts down after > > about a minute, but leaves various other processes running. > > > > I'll have a look at it but I don't know how successful I'll be. -- Bill Medland ACCPAC International, Inc. [EMAIL PROTECTED] Corporate: www.accpac.com Hosted Services: www.accpaconline.com
Re: Error in the server thread id fix
Bill Medland wrote: Is anyone else looking into a problem that appears to have been introduced by the server change on Feb 1st changing thread and process ids to small integers? does this help ? A+ -- Eric Pouech Index: server/snapshot.c === RCS file: /home/cvs/cvsroot/wine/wine/server/snapshot.c,v retrieving revision 1.18 diff -u -r1.18 snapshot.c --- server/snapshot.c 30 Jan 2003 00:26:44 - 1.18 +++ server/snapshot.c 13 Feb 2003 20:27:41 - @@ -124,7 +124,7 @@ ptr = &snapshot->processes[snapshot->process_pos++]; reply->count= ptr->count; reply->pid = get_process_id( ptr->process ); -reply->ppid = get_process_id( ptr->process->parent ); +reply->ppid = ptr->process->parent ? get_process_id( ptr->process->parent ) : +0; reply->heap = 0; /* FIXME */ reply->module = 0; /* FIXME */ reply->threads = ptr->threads;
Re: Error in the server thread id fix
On February 13, 2003 11:42 am, Uwe Bonnes wrote: > > "Bill" == Bill Medland <[EMAIL PROTECTED]> writes: > > Bill> Is anyone else looking into a problem that appears to have been > Bill> introduced by the server change on Feb 1st changing thread and > Bill> process ids to small integers? > > Bill> As a result ACCPAC for Windows' main desktop process shuts down > Bill> after about a minute, but leaves various other processes running. > > Bill> I'll have a look at it but I don't know how successful I'll be. > > Webpack doesn't work as before since the last CVS update. It uses a lot of > processes and perhaps threads. Maybe this problem is correlated. > > Bye Could be. Since the last CVS update? Do you mean the last snapshot on 20030115? If not then it probably isn't; this problem was introduced two weeks ago. (Shows how much attention I am paying) It looks like something goes wrong in the next_process handler. I'll let you know. -- Bill Medland ACCPAC International, Inc. [EMAIL PROTECTED] Corporate: www.accpac.com Hosted Services: www.accpaconline.com
Re: wcmd autoexec.bat?
Hello Sylvain, Sylvain Petreolle wrote: Currently the wcmd shell starts up with no prompt, this has to be corrected in my batch files. prompt $p$g etc. please update, this has been changed. Thanks for the info, I just tried the 20030115 and that prompt $p$g is default somewhere now. (is there a file it is set in?) However, the autoexec.bat is stil not executed, I tested with the following and with wcmd. @echo off echo test... set TEST=true I think this is a key feature, I would like to use this to set some enviroment variables, currently I have to run a batch file manually each time I start wcmd. Could this be considered for implementation please? Regards JG
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
Hi Tony, This is called a regression. I see you are not on CVS but if you switch to it, you could find the the patch that broke the app. The link on how to do this is here. http://www.winehq.org/docs/wine-devel/cvs-regression.shtml OK, thank you for the infomation, very well written document! Unfortunatly I am on a momdem, which restricts my abilities here. I will look for a workaround to find the regression patch. If you have problems with this or have suggestions on how to improve the docu please let me know. Well, could "Cvs" be written "CVS" ? The technical infomation seems top notch. Regards JG
Re: Error in the server thread id fix
Ah ha, so that's the problem is it? I'm seeing a similar issue with IE6 after loading the adobe svg viewer plugin. For no apparent reason, Wine bombs after about 1-2 minutes. It doesn't crash or anything, it just stops, and the logs don't show anything out of the ordinary. The windows stay on the screen, but the processes appear hung. How did you determine it was changing the ids? Just a regression search? On Thu, 2003-02-13 at 18:52, Bill Medland wrote: > Is anyone else looking into a problem that appears to have been introduced by > the server change on Feb 1st changing thread and process ids to small > integers? > > As a result ACCPAC for Windows' main desktop process shuts down after about a > minute, but leaves various other processes running. > > I'll have a look at it but I don't know how successful I'll be.
Re: Error in the server thread id fix
> "Bill" == Bill Medland <[EMAIL PROTECTED]> writes: Bill> Is anyone else looking into a problem that appears to have been Bill> introduced by the server change on Feb 1st changing thread and Bill> process ids to small integers? Bill> As a result ACCPAC for Windows' main desktop process shuts down Bill> after about a minute, but leaves various other processes running. Bill> I'll have a look at it but I don't know how successful I'll be. Webpack doesn't work as before since the last CVS update. It uses a lot of processes and perhaps threads. Maybe this problem is correlated. Bye -- Uwe Bonnes[EMAIL PROTECTED] Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt - Tel. 06151 162516 Fax. 06151 164321 --
Looking for information on implemented API's in wine
I am ready to begin work on the actual database aspect of cross referencing the windows dlls. As part of the database I would like to include the status of a given API in wine so it will be possible to do things like query for all unimplemented APIs in a given dll. The first questions I have are whether or not I can depend on the spec files to give a complete list, and can someone either point me to documentation on the spec files or explain everything I need to know in order to determine the status of APIs defined there?
Error in the server thread id fix
Is anyone else looking into a problem that appears to have been introduced by the server change on Feb 1st changing thread and process ids to small integers? As a result ACCPAC for Windows' main desktop process shuts down after about a minute, but leaves various other processes running. I'll have a look at it but I don't know how successful I'll be. -- Bill Medland ACCPAC International, Inc. [EMAIL PROTECTED] Corporate: www.accpac.com Hosted Services: www.accpaconline.com
Re: For your consideration, here's a preview of some new seh_try_macros-type stuff...
"Gregory M. Turner" <[EMAIL PROTECTED]> writes: > BTW, does wine really have non-gcc users? Or is it just a general policy to > not be gcc-specific within the wine platform core since it might get recycled by >other > projects, etc...? There are people building Wine with the Sun compiler. Also it makes sense for at least some dlls to allow building them with MSVC to test them under Windows. And in general using different compilers is a good way to shake out bugs from the code. -- Alexandre Julliard [EMAIL PROTECTED]
Re: 2GB visible partition size
Tony Lambregts <[EMAIL PROTECTED]> writes: > Actually Alexandre hasn't commented on it, so if it doesn't bit rot it > still could be commited. However, at the time, there were some > negative comments about it. It seems that the major concern is that > it should do more than it does. Well, yes, if we really need to change the fstype it should be a generic option that allows all types to be specified, not just NTFS. And it shouldn't overload the existing "type" parameter, it should be a separate entry. But it may be enough to simply always return FAT32, if that works for the app in question. Returning NTFS is a bit misleading anyway since we don't implement any of the NTFS-specific features. -- Alexandre Julliard [EMAIL PROTECTED]
Re: Wine default install queries - Wine 20030115
J. Grant wrote: Hi, Is there a reason e:\test is in the default path when I install from CVS? (this dir does not exist) Curious its been there for over two years does anyone object to having it removed? There is no windows version defined in the [Version] block, should a windows version be defined to use as default? The short answer is that it should not be required Drive F: was setup as CDROM, even though the ./tools/wineinstall said it could not find the CDROM during the process I think. Checking fstab for "cdrom" would determine the cdrom drive(s) on most computers. This should work. A log of the relevant part of ./tools/wineinstall would be good. [Drive C] was setup as type "win95", however its had label "MS-DOS", I think this would be better as "wine" by default, could this be considered please? Well to be case correct "Wine". I think this is a holdover from when wine "needed windows" so the drive would be "MS-DOS" as oppossed to "*nix" The label is irrelavant to wine but.(ahem) isn't "MS-DOS" a (tm). Anyways changing it would not hurt any objections or other suggestions? Thanks -- Tony Lambregts
Re: wcmd autoexec.bat?
On Thursday 13 Feb 2003 02:22, J. Grant wrote: > Hello > > I have been testing wcmd to automate some process I used to use on > win98. However I can not find the autoexec.bat for wcmd? > > Currently the wcmd shell starts up with no prompt, this has to be > corrected in my batch files. prompt $p$g etc. > > Wine seems to have 2 autoexec.bat's but does not seem to ever use them. > /var/lib/wine/autoexec.bat never seems to be executed. Neither is the > one I created in my fake c drive (/home/now3d/.wine/c/autoexec.bat) > > Is this issue known? are their any workarounds? There is code in wcmdmain.c (line 113) to execute a batch file c:\autoexec.bat but it is commented out - it could be dangerous in a dual-boot machine to execute such a batch file by default. Dave
Re: VC++ nmake not working with Wine 20030115 when it worked with200208xx
J. Grant wrote: Hi, Calling nmake from /wcmd/ used to work, now it does not. I can't see why not, here is the debugger ouput if anyone knows whats wrong I'd be happy to hear! This is called a regression. I see you are not on CVS but if you switch to it, you could find the the patch that broke the app. The link on how to do this is here. http://www.winehq.org/docs/wine-devel/cvs-regression.shtml If you have problems with this or have suggestions on how to improve the docu please let me know. -- Tony Lambregts
Re: CreateNamedPipe questions
Dmitry Timoshkov wrote: Under Win2k CreateNamedPipe(NULL) in your test returns INVALID_HANDLE_VALUE but sets last error to ERROR_PATH_NOT_FOUND, not ERROR_INVALID_NAME as your test expects. Thanks! For some reason, when I ran it on Win2K Professional, it seemed to succeed. I'll have to try it again. Also, dlls/kernel/sync.c seems to allow for NULL filenames for some reason. It worth to verify last error at least under NT 4.0 since it's ^^^ "it's worthless"? known that NT 4 either doesn't set last error at all, or often sets it differently than win2k/XP. What about NT 3.51? Same as NT 4? IMHO it's worth checking error codes anyway... maybe we could make that optional. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045
Re: CreateNamedPipe questions
Francois Gouget wrote: 2. of calling the API and testing for the error code, usually ERROR_CALL_NOT_IMPLEMENTED CreateNamedPipe{A,W} exists on Win95 so at most you will need something along the lines of 2. Will do, thanks. -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045
Re: popupmenu itemsize
> ... > Christian> lpitem->rect.bottom += 12; + > > Nagic constants mostly are evil? It the "12" perhaps related to some > SYSPARAMS? I agree, but I doubt that it can be related to any constant as it is an item of an "ownerdrawn" (I think this is what they called it in a comment) popup menu so the size is dependent on the item the caller wants to display, right? > > Are you using rhlx01.fht-esslingen.de? Andi works on that problem then. > Yes. Thanks, Christian
Re: popupmenu itemsize
> "Christian" == Christian Kristukat <[EMAIL PROTECTED]> writes: Christian> Hi, I suspect that this again is a dirty patch but it helps Christian> in working with Microcal Origin. Maybe a more skilled person Christian> than me finds the real origin of this problem. At one point Christian> in the program a popup menu opens but only the items' width Christian> is calculated correctly, the height is not, in fact it is Christian> equal zero. For that case I added an arbitrarily chosen Christian> height of 12 points and it works fine. Here's the patch: ... Christian> lpitem->rect.bottom += 12; + Nagic constants mostly are evil? It the "12" perhaps related to some SYSPARAMS? ... Christian> PS: By the way: every cvs operation (update, diff) hangs Christian> after processing the last directory. However it seems to be Christian> complete and pressing CTRL-C seems not to corrupt Christian> anything. Any ideas? Are you using rhlx01.fht-esslingen.de? Andi works on that problem then. Bye -- Uwe Bonnes[EMAIL PROTECTED] Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt - Tel. 06151 162516 Fax. 06151 164321 --
Re: Fix for Treeview Regression in Putty, winamp, et al.
Dimitrie O. Paun wrote: On February 13, 2003 12:46 am, Drew \"DanteAliegri\" Ogle wrote: When it is returning to a dialog, it returns a W, however, when the user code which the dialog calls is an A function, it excepts TVN_*A, when the treeview code is sending TVN_*W. It seems that the real fix is to always send TVN_*A in notifications. However, for whatever reason, that did not fix putty for me, so I did not submit it. Care to give that a shot? Well, I don't know enough about compiling to get a callback that is W, but if you compiled a app with TVN_SELCHANGED, and it was usiing W, wouldn't TNV_SELCHANGED evaluate to TVN_SELCHANGEDW? Also, this didn't seem to fix things for me until I did a make dep; make .. not sure why. -Dante
Re: CreateNamedPipe questions
"Dan Kegel" <[EMAIL PROTECTED]> wrote: > Oddly enough, it looks like it's ok to pass > NULL as the filename to CreateNamedPipe. Under Win2k CreateNamedPipe(NULL) in your test returns INVALID_HANDLE_VALUE but sets last error to ERROR_PATH_NOT_FOUND, not ERROR_INVALID_NAME as your test expects. It worth to verify last error at least under NT 4.0 since it's known that NT 4 either doesn't set last error at all, or often sets it differently than win2k/XP. -- Dmitry.
Re: CreateNamedPipe questions
On Wed, 12 Feb 2003, Dan Kegel wrote: [...] > The patch also adds a quickie regression test, > but I still have to use late binding for CreateNamedPipe > (or is it ok for the test to fail on win9x?). Nope. Tests should succeed on all Windows platforms. For platforms where the API is not supported, the individual checks should be skipped. Typically this involves either: 1. either using GetProcAddress if the API is missing altogether on some platforms 2. of calling the API and testing for the error code, usually ERROR_CALL_NOT_IMPLEMENTED CreateNamedPipe{A,W} exists on Win95 so at most you will need something along the lines of 2. -- Francois Gouget [EMAIL PROTECTED]http://fgouget.free.fr/ Linux, WinNT, MS-DOS - also known as the Good, the Bad and the Ugly.
CreateNamedPipe questions
Oddly enough, it looks like it's ok to pass NULL as the filename to CreateNamedPipe. Anyone know what programs do that, and why? Here's a patch that makes our CreateNamedPipe check for legal filenames (or NULL). It should probably allow forward slashes... The patch also adds a quickie regression test, but I still have to use late binding for CreateNamedPipe (or is it ok for the test to fail on win9x?). Would this test have caught the recent named pipe breakage? If not, what would I need to add? Comments welcome; I'll send it to wine-patches after addressing any feedback. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045 Index: dlls/kernel/sync.c === RCS file: /home/wine/wine/dlls/kernel/sync.c,v retrieving revision 1.26 diff -u -p -u -r1.26 sync.c --- dlls/kernel/sync.c 25 Oct 2002 21:02:30 - 1.26 +++ dlls/kernel/sync.c 13 Feb 2003 07:47:27 - @@ -508,6 +508,8 @@ HANDLE WINAPI CreateNamedPipeW( LPCWSTR { HANDLE ret; DWORD len = name ? strlenW(name) : 0; +static const WCHAR leadin[] = {'\\','\\','.','\\','P','I','P','E'}; +int i; TRACE("(%s, %#08lx, %#08lx, %ld, %ld, %ld, %ld, %p)\n", debugstr_w(name), dwOpenMode, dwPipeMode, nMaxInstances, @@ -516,7 +518,13 @@ HANDLE WINAPI CreateNamedPipeW( LPCWSTR if (len >= MAX_PATH) { SetLastError( ERROR_FILENAME_EXCED_RANGE ); -return 0; +return INVALID_HANDLE_VALUE; +} +/* FIXME: can name really be NULL?! */ +if (name && strncmpiW(name, leadin, sizeof(leadin)/sizeof(leadin[0]))) +{ +SetLastError( ERROR_INVALID_NAME ); +return INVALID_HANDLE_VALUE; } SERVER_START_REQ( create_named_pipe ) { Index: dlls/kernel/tests/Makefile.in === RCS file: /home/wine/wine/dlls/kernel/tests/Makefile.in,v retrieving revision 1.6 diff -u -p -u -r1.6 Makefile.in --- dlls/kernel/tests/Makefile.in 4 Oct 2002 17:42:27 - 1.6 +++ dlls/kernel/tests/Makefile.in 13 Feb 2003 07:47:27 - @@ -17,6 +17,7 @@ CTESTS = \ generated.c \ locale.c \ path.c \ + pipe.c \ process.c \ thread.c --- /dev/null 2002-08-30 16:31:37.0 -0700 +++ dlls/kernel/tests/pipe.c2003-02-12 23:44:20.0 -0800 @@ -0,0 +1,109 @@ +/* + * Unit tests for named pipe functions in Wine + * + * Copyright (c) 2002 Dan Kegel + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include +#include +#include + +#ifndef STANDALONE +#include "wine/test.h" +#else +#include +#define START_TEST(name) main(int argc, char **argv) +#define ok(condition, msg) assert(condition) +#endif + +#include +#include +#include +#include + +#define PIPENAME ".\\PiPe\\tests_" __FILE__ + +void test_CreateNamedPipeA(void) +{ +HANDLE hnp; +HANDLE hFile; +const char obuf[] = "Bit Bucket"; +char ibuf[32]; +DWORD written; +DWORD gelesen; + +/* Bad parameter checks */ +hnp = CreateNamedPipeA("not a named pipe", +PIPE_ACCESS_DUPLEX, PIPE_TYPE_BYTE|PIPE_WAIT, +/* nMaxInstances */ 1, +/* nOutBufSize */ 1024, +/* nInBufSize */ 1024, +/* nDefaultWait */ NMPWAIT_USE_DEFAULT_WAIT, +/* lpSecurityAttrib */ NULL); + +ok(hnp == INVALID_HANDLE_VALUE && GetLastError() == ERROR_INVALID_NAME, +"CreateNamedPipe should fail if name doesn't start with .\\pipe"); + +#if 0 /* Evidently it's ok in windows to pass NULL as the pipe name! */ +hnp = CreateNamedPipeA(NULL, +PIPE_ACCESS_DUPLEX, PIPE_TYPE_BYTE|PIPE_WAIT, +1, 1024, 1024, NMPWAIT_USE_DEFAULT_WAIT, NULL); +ok(hnp == INVALID_HANDLE_VALUE && GetLastError() == ERROR_INVALID_NAME, +"CreateNamedPipe should fail if name is NULL"); +#endif + +/* Functional checks */ + +hnp = CreateNamedPipeA(PIPENAME, +PIPE_ACCESS_DUPLEX, PIPE_TYPE_BYTE|PIPE_WAIT, +/* nMaxInstances */ 1, +/* nOutBufSize */ 1024, +/* nInBufSize */ 1024, +/* nDefaultWait */ NMPWAIT_USE_DEFAULT_WAIT, +/* lpSecurityAttrib */ NULL); +ok(hnp != INVALID_HANDLE_VALUE, "Cre