Thanks!
On 10/20/2016 1:58 PM, Sergey Bylokhov wrote:
Loos fine.
On 20.10.16 13:35, Alexander Stepanov wrote:
Hello Sergey,
Please see the updated webrev:
http://cr.openjdk.java.net/~avstepan/8159454/webrev.01/
Thanks,
Alexander
P.S.: there is no guarantee that CONFIGS does not contain
, Alexander
It will be good if the test always validate default GC per device.
On 19.10.16 19:33, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8159454/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8159454 ?
Thanks,
Alexander
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8159454/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8159454 ?
Thanks,
Alexander
Hello Sergey,
The fix looks good (not a reviewer).
Thanks,
Alexander
On 5/30/2016 7:39 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
The test DefaultPolicyChange_Swing.java has two issues:
- It uses invokeLater(), so the test usually pass before the code is
executed on t
Thanks!
On 3/18/2016 8:46 PM, Semyon Sadetsky wrote:
Looks good.
--Semyon
On 3/17/2016 10:15 AM, Alexander Stepanov wrote:
Hello Alexandr,
> it should be created and used on EDT
the following methods affecting UI are run on EDT: UI(),
showDialogOrFrame() and dispose() operations in doT
, Alexander Stepanov wrote:
Hello Alexandr,
just a minor remark about is2x() in tests:
do we still need this method in MultiresolutionIconTest?
The following simple check can be used in doTest() instead:
boolean is2x = "2".equals(scale);
Color
expected = is2x ? C2X : C1X,
unexpec
Thanks!
On 3/17/2016 12:45 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 17/03/16 11:15, Alexander Stepanov wrote:
Hello Alexandr,
> it should be created and used on EDT
the following methods affecting UI are run on EDT: UI(),
showDialogOrFrame()
ents.
Thanks,
Alexndr.
On 14/03/16 18:26, Alexander Stepanov wrote:
Hello Semyon,
> JOptionPane.showInternalInputDialog() is an utility method
Yes, the initial intention was to check the icons for all the dialogs
created by means of these utilities. But in principle these options
could be
Hello Alexandr,
just a minor remark about is2x() in tests:
do we still need this method in MultiresolutionIconTest?
The following simple check can be used in doTest() instead:
boolean is2x = "2".equals(scale);
Color
expected = is2x ? C2X : C1X,
unexpected = is2x ? C1X : C2X;
the same,
lease see the updated webrev:
http://cr.openjdk.java.net/~avstepan/8151714/webrev.01/
Thanks,
Alexander
On 3/11/2016 8:38 PM, Semyon Sadetsky wrote:
On 3/11/2016 7:38 PM, Alexander Stepanov wrote:
> just call dispose().
1.
SwingUtilities.invokeAndWait(() -> {
JOptionP
Thanks!
On 3/14/2016 12:12 PM, Yuri Nesterenko wrote:
+1
-yan
On 03/11/2016 06:05 PM, Alexander Scherbatiy wrote:
The test looks good to me.
Thanks,
Alexandr.
On 11/03/16 16:19, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the explanation. Could you please review the updated
;t pressed by the user (and
it differs from the initial test variety). not sure if it could be fixed
by some thread tricks.
Thanks,
Alexander
On 3/11/2016 7:17 PM, Semyon Sadetsky wrote:
On 3/11/2016 6:33 PM, Alexander Stepanov wrote:
> traverse the component tree
Hm, interesting. But I&#x
thanks!
On 3/11/2016 7:25 PM, Alexandr Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 3/11/2016 2:46 AM, Alexander Stepanov wrote:
Hello,
Could you please review the fix
http://cr.openjdk.java.net/~avstepan/8151697/webrev.00/
for
https://bugs.openjdk.java.net/browse
No, I simply believe that Alexandr is right :)
Thanks,
Alexander
On 3/11/2016 6:32 PM, Sergey Bylokhov wrote:
On 11.03.16 15:19, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the explanation. Could you please review the updated test?
http://cr.openjdk.java.net/~avstepan/8150724
/11/2016 5:45 PM, Alexander Stepanov wrote:
*inside of the internal pane
parent pane
On 3/11/2016 5:42 PM, Alexander Stepanov wrote:
Hello Semyon,
I'm not sure if we can control the location of the dialogs shown
(and of course we don't know the location of the icons on them), can
we?
*inside of the internal pane
parent pane
On 3/11/2016 5:42 PM, Alexander Stepanov wrote:
Hello Semyon,
I'm not sure if we can control the location of the dialogs shown (and
of course we don't know the location of the icons on them), can we?
It is clear that the internal dialogs a
st be automated? It is possible to read color from the
screen with AWT Robot.
--Semyon
On 3/11/2016 4:53 PM, Alexander Stepanov wrote:
Hello,
Could you please review the fix
http://cr.openjdk.java.net/~avstepan/8151714/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8151714
- just a si
Hello,
Could you please review the fix
http://cr.openjdk.java.net/~avstepan/8151714/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8151714
- just a single test added.
Thanks,
Alexander
Hello Alexandr,
Thank you for the explanation. Could you please review the updated test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/
The icon size was reduced.
Thanks,
Alexander
On 3/11/2016 3:14 PM, Alexander Scherbatiy wrote:
On 10/03/16 16:22, Alexander Stepanov wrote:
Hello
Thanks!
On 3/11/2016 1:11 PM, Sergey Bylokhov wrote:
Looks fine.
On 10.03.16 20:01, Alexander Stepanov wrote:
Hello Sergey,
> because setImageAutoSize is false by default.
Could you please review the fix:
http://cr.openjdk.java.net/~avstepan/8150643/fix.00/
If it is suitable, I'll
Hello,
Could you please review the fix
http://cr.openjdk.java.net/~avstepan/8151697/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8151697
- just a minor test update.
Thanks,
Alexander
it seems we have a bug
because setImageAutoSize(true) does not help. I'll update the test in
JDK-8150176.
On 26.02.16 19:09, Alexander Stepanov wrote:
Thanks! (will remove "for a few seconds").
Regards,
Alexander
On 2/26/2016 6:25 PM, Sergey Bylokhov wrote:
Looks fine.
Note t
Could you please review the updated version of the test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/
- should pass on OS X after JDK-8151303 fix. 16x16 and 32x32 icons are
used for the tab; the loop over L&Fs added.
Thanks,
Alexander
On 3/10/2016 3:22 PM, Alexander Stepanov w
Thanks!
On 3/10/2016 5:14 PM, Yuri Nesterenko wrote:
OK with me.
-yan
On 03/10/2016 05:13 PM, Sergey Bylokhov wrote:
Looks fine.
On 10.03.16 17:03, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8151627/webrev.00/
for
https
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8151627/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8151627
Thanks,
Alexander
th images
with sizes 16x16 and 32x32.
Thanks,
Alexandr.
Thanks,
Alexander
On 3/2/2016 7:15 PM, Alexander Stepanov wrote:
Hello Sergey,
It fails because of
https://bugs.openjdk.java.net/browse/JDK-8151060
(plus we need here some tricky check for resolution by the analogy
with 8150258 beca
Thanks!
On 3/9/2016 7:51 PM, Sergey Bylokhov wrote:
+1
On 09.03.16 19:18, Alexander Scherbatiy wrote:
The test looks good to me.
Thanks,
Alexandr.
On 04/03/16 17:17, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan
please clarify these lines:
117 tabbedPane.addTab("", new JPanel());
118 tabbedPane.setTabComponentAt(1, new JLabel());
On 09.03.16 18:48, Alexander Stepanov wrote:
Hello, Sergey,
Please see the updated version of the test:
http://cr.openjdk.java.net/~avstepan/8150724
t run on OS X.
Thanks,
Alexander
On 3/4/2016 7:08 PM, Alexander Stepanov wrote:
The test should be updated to cover the related issue
https://bugs.openjdk.java.net/browse/JDK-8151303
Regards,
Alexander
On 3/4/2016 1:15 PM, Alexander Stepanov wrote:
Hello, Sergey,
We have JLabel(icon) alread
Hello, Sergey, Semyon,
Thank you!
Regards,
Alexander
On 3/9/2016 10:32 AM, Semyon Sadetsky wrote:
+1
--Semyon
On 3/4/2016 8:25 PM, Sergey Bylokhov wrote:
Looks fine.
On 02.03.16 16:47, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net
The test should be updated to cover the related issue
https://bugs.openjdk.java.net/browse/JDK-8151303
Regards,
Alexander
On 3/4/2016 1:15 PM, Alexander Stepanov wrote:
Hello, Sergey,
We have JLabel(icon) already in the test, and we cannot have both
these cases at the same tab. Moreover, we
Thanks!
On 3/4/2016 6:31 PM, Yuri Nesterenko wrote:
+1
-yan
On 03/04/2016 06:13 PM, Sergey Bylokhov wrote:
Looks fine.
On 29.02.16 18:45, Alexander Stepanov wrote:
The following version of the test passes for OS X + retina (as well as
for Windows and Linux):
http://cr.openjdk.java.net
Thank you!
On 3/4/2016 6:13 PM, Sergey Bylokhov wrote:
Looks fine.
On 29.02.16 18:45, Alexander Stepanov wrote:
The following version of the test passes for OS X + retina (as well as
for Windows and Linux):
http://cr.openjdk.java.net/~avstepan/8150258/webrev.01/
not sure if
Hello Sergey,
the fix looks good to me (not a reviewer).
Thanks,
Alexander
On 2/29/2016 6:56 PM, Sergey Bylokhov wrote:
On 29.02.16 18:49, Yuri Nesterenko wrote:
Hi Sergey,
fix looks OK to me.
We didn't see the original issue on Mac, did we?
It was fixed long time ago before osx-port in jd
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8151269/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8151269 ?
Just a single test added.
Thanks,
Alexander
es to the test instead of replace the old
lines. The test will pass after the fix for 8151060.
On 03.03.16 17:45, Alexander Stepanov wrote:
Could you please review the updated version of the test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.01
Line
106 tabbedPane.addTab("
icon));
- in such a case the test passes for OS X (as well as for Windows, Linux).
Probably these changes should be reverted after JDK-8151060 fix.
Thanks,
Alexander
On 3/2/2016 7:15 PM, Alexander Stepanov wrote:
Hello Sergey,
It fails because of
https://bugs.openjdk.java.net/browse/JDK-8151060
10.11 + retina. Is it expected?
On 26.02.16 15:53, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150724 ?
Just a single test added.
Thanks,
Alexander
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8142406/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8142406
just a single test added.
Thanks,
Alexander
Please see JDK-8150844
On 2/29/2016 6:52 PM, Sergey Bylokhov wrote:
On 29.02.16 18:45, Alexander Stepanov wrote:
not sure if "-Dsun.java2d.uiScale" option was intended for use with OS X
(probably an enhancement bug should be created).
So for OS X now we have only single test run in
S X now we have only single test run in fact.
Thanks,
Alexander
On 2/29/2016 5:12 PM, Alexander Stepanov wrote:
Hello Sergey,
When running the following trivial test case (having Color set to
"Generic RGB Profile")
import java.awt.*;
public class ColorTest extends Frame {
test still fails for you when simply
set "expected = C2X" on the ln 116 and comment out the 1st "@run"?
Not sure if it should be considered as a bug, or some additional
settings are required, or the color check should be simply softened
(some tolerance used).
Thanks,
Alexande
by default. But it seems we have a bug
because setImageAutoSize(true) does not help. I'll update the test in
JDK-8150176.
On 26.02.16 19:09, Alexander Stepanov wrote:
Thanks! (will remove "for a few seconds").
Regards,
Alexander
On 2/26/2016 6:25 PM, Sergey Bylokhov wrote:
Thanks! (will remove "for a few seconds").
Regards,
Alexander
On 2/26/2016 6:25 PM, Sergey Bylokhov wrote:
Looks fine.
Note that the text "Two tray icons will appear for a few seconds
" should be updated also.
On 26.02.16 18:04, Alexander Stepanov wrote:
> Is it pos
It seemingly does not help (but maybe I'm doing something wrong).
On 2/26/2016 5:45 PM, Sergey Bylokhov wrote:
On 26.02.16 17:27, Alexander Stepanov wrote:
It seems that for osx + retina
1. -Dsun.java2d.uiScale option is ignored for multires. image (in
contrast for HiDPI + Win. 8, for ex
o expect that the
user will be able to find icon in a 7 seconds, especially if he run
the test for the firts time. Is it possible to clear the tray when the
test ended?
On 26.02.16 16:39, Alexander Stepanov wrote:
Hello Sergey,
This is a time interval for the user to examine the icons (which co
41 PM, Alexander Stepanov wrote:
Hello Sergey,
No, as well as for 8150724. I have to re-check, thank you.
Regards,
Alexander
On 2/26/2016 4:36 PM, Sergey Bylokhov wrote:
Hi, Alexander.
The test failed on my OSX 10.11 + retina. Is it expected?
On 25.02.16 17:51, Alexander Stepanov wrote:
Hello Sergey,
No, as well as for 8150724. I have to re-check, thank you.
Regards,
Alexander
On 2/26/2016 4:36 PM, Sergey Bylokhov wrote:
Hi, Alexander.
The test failed on my OSX 10.11 + retina. Is it expected?
On 25.02.16 17:51, Alexander Stepanov wrote:
Sorry, just a reminder.
Thanks
Bylokhov wrote:
Is it really necessary to block the EDT for 7 seconds?
On 25.02.16 18:22, Alexander Stepanov wrote:
(sorry, misprint, [9], not [8]. the same for RFR 8150258)
On 2/25/2016 5:50 PM, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150724 ?
Just a single test added.
Thanks,
Alexander
(sorry, misprint, [9], not [8]. the same for RFR 8150258)
On 2/25/2016 5:50 PM, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150643/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150643 ?
Just a single test added
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150643/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150643 ?
Just a single test added (still failing).
Thanks,
Alexander
Sorry, just a reminder.
Thanks,
Alexander
On 2/19/2016 7:17 PM, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150258/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150258
Just a single test added.
Thanks,
Alexander
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150258/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150258
Just a single test added.
Thanks,
Alexander
Thank you!
On 2/5/2016 7:58 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
On 05/02/16 15:59, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the notes; yes, these lines are unnecessary. Please see
the updated patch:
http://cr.openjdk.java.net/~avstepan/8142861/webrev
Graphics
also has drawImage(...) method?
Is it necessary to check the graphics to null? It looks like passed
null graphics should be considered as a bug.
Thanks,
Alexandr.
On 20/01/16 20:32, Alexander Stepanov wrote:
Sorry, just a reminder...
Thanks,
Alexander
On 1/14/2016 6:00 PM, Alexander
Thanks!
On 2/5/2016 1:55 PM, Alexander Scherbatiy wrote:
On 05/02/16 12:59, Alexander Stepanov wrote:
Hello Alexandr,
WRT WindowResizingOnDPIChangingTest - I have quite similar manual
test on review:
http://mail.openjdk.java.net/pipermail/awt-dev/2016-January/010569.html
(but it requires
Hello Alexandr,
WRT WindowResizingOnDPIChangingTest - I have quite similar manual test
on review:
http://mail.openjdk.java.net/pipermail/awt-dev/2016-January/010569.html
(but it requires two-display configuration).
Could these tests coexist later on? I hope they are not full duplicates.
(and
Thanks!
On 1/25/2016 8:08 PM, Alexander Scherbatiy wrote:
The test looks good to me.
Thanks,
Alexandr.
On 22/01/16 20:41, Alexander Stepanov wrote:
Hello,
Could you please review the fix
http://cr.openjdk.java.net/~avstepan/8147966/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK
Hello,
Could you please review the fix
http://cr.openjdk.java.net/~avstepan/8147966/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8147966
Just one simple test to cover BaseMultiResolutionImage.getProperty()
Thanks,
Alexander
Sorry, just a reminder...
Thanks,
Alexander
On 1/14/2016 6:00 PM, Alexander Stepanov wrote:
Hello Sergey,
> Note that MultiRes image can be created at runtime
Indeed, this case should be used for testing, as we have different
naming conventions for OS X and Windows, so the write-read lo
ted at runtime.
Please see the updated webrev:
http://cr.openjdk.java.net/~avstepan/8142861/webrev.03/
Regards,
Alexander
On 11/16/2015 4:23 PM, Alexander Stepanov wrote:
P.S.: The behavior with Mac OS X mission control should also be
checked which is definitely a manual job (it seems to be stra
http://cr.openjdk.java.net/~avstepan/8138838/jdk.patch
On 05.10.15 14:15, Alexander Stepanov wrote:
Sorry; wrong subject...
On 10/5/2015 2:12 PM, Alexander Stepanov wrote:
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8138838
Patch + webrev zipped + specdiff report:
probably will request some other possible form of review,
like package splitting.
[1] http://cr.openjdk.java.net/~avstepan/8138838/jdk.patch
On 05.10.15 14:15, Alexander Stepanov wrote:
Sorry; wrong subject...
On 10/5/2015 2:12 PM, Alexander Stepanov wrote:
Hello,
Could you please review the
P.S.: The behavior with Mac OS X mission control should also be checked
which is definitely a manual job (it seems to be strange sometimes; not
sure if buggy). So the test instructions should be appended a bit...
On 11/16/2015 3:24 PM, Alexander Stepanov wrote:
Hello Sergey,
Thank you for
ts why this test cannot be converted to auto
test? Probably some api can be added to jdk to simplify creation of
such tests? like already added "-Dsun.java2d.uiScale"(JDK-8073320).
On 13.11.15 14:34, Alexander Stepanov wrote:
webrev updated:
http://cr.openjdk.java.net/~anazarov/8142861/
webrev updated:
http://cr.openjdk.java.net/~anazarov/8142861/webrev.02/
Thanks,
Alexander
On 11/12/2015 7:51 PM, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~anazarov/8142861-3/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~anazarov/8142861-3/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8142861
Just a single manual test added.
(sorry, I'll remove these unnecessary 'static' modifiers for
'parentName', 'childName')
Checked on M
Sorry, just a reminder.
On 10/27/2015 9:02 PM, Alexander Stepanov wrote:
Hello Alexandr,
> PrinterInfo.java: Should the tag here also be changed to
{@code } ?
Here is again some mess about full / "minimal" fix. I still hope that
the full version could be reviewed (replacin
ld the tag here also be changed to
{@code } ?
Could you separate the Swing part of the fix and send it to the
swing-dev alias to the review?
Thanks,
Alexandr.
On 10/16/2015 6:40 PM, Alexander Stepanov wrote:
> Of cause I am not capable to review megabytes of changes in patch
file
ent is still desired (which is very doubtful) then
should be the "overall" fix be split into some observable parts?
Thanks,
Alexander
On 10/16/2015 5:37 PM, Semyon Sadetsky wrote:
On 10/16/2015 1:42 PM, Alexander Stepanov wrote:
// cutting off core-libs-dev
Hello Semyon,
> Si
o some notes:
MultiResolutionImage.java interface has a mix of verbose/implicit
method modifiers. It would be nice to reduce it to the uniform style.
MenuComponent.java : @param d - the Dimension... -
Should it also be replaced with brackets?
PrinterInfo.java - also is used.
--Semyon
On 10
Sorry, just a reminder. If the activity is untimely, then could you
please review the following minimum part of fix?
http://cr.openjdk.java.net/~avstepan/8138838/webrev.min.00/index.html
(some misprints + midget JDK-8138893 fixed).
Thanks,
Alexander
On 10/5/2015 2:12 PM, Alexander Stepanov
Sorry; wrong subject...
On 10/5/2015 2:12 PM, Alexander Stepanov wrote:
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8138838
Patch + webrev zipped + specdiff report:
http://cr.openjdk.java.net/~avstepan/8138838
Just some cosmetic changes for docs
ese changes are desired at all for now.
Thanks,
Alexander
(Just in case, adding the prehistory and sending a copy to core-libs-dev).
On 10/1/2015 2:31 PM, Alexander Stepanov wrote:
Hello Martin, Stuart,
Thank you for the notes,
Yes, the initial utility is quite ugly, I just tried to prepare it
Thanks!
On 8/26/2015 4:23 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 8/25/2015 7:47 PM, Alexander Stepanov wrote:
Sorry, just a reminder.
javax/swing/plaf/LayerUI.java was also touched.
Thanks,
Alexander
On 8/18/2015 2:51 PM, Alexander Stepanov
Sorry, just a reminder.
javax/swing/plaf/LayerUI.java was also touched.
Thanks,
Alexander
On 8/18/2015 2:51 PM, Alexander Stepanov wrote:
P.S. (sorry)
java.datatransfer/share/classes/java/awt/datatransfer/MimeType.java
was touched as well
On 8/18/2015 2:08 PM, Alexander Stepanov wrote
P.S. (sorry)
java.datatransfer/share/classes/java/awt/datatransfer/MimeType.java was
touched as well
On 8/18/2015 2:08 PM, Alexander Stepanov wrote:
Hello,
Could you please review the following fix:
http://cr.openjdk.java.net/~avstepan/8133807/webrev.00
for
https://bugs.openjdk.java.net
Hello,
Could you please review the following fix:
http://cr.openjdk.java.net/~avstepan/8133807/webrev.00
for
https://bugs.openjdk.java.net/browse/JDK-8133807
Just a minor cleanup for docs.
Thanks,
Alexander
Thanks!
On 8/12/2015 11:00 AM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 8/11/2015 6:45 PM, Alexander Stepanov wrote:
Hello,
Could you please review the following fix:
http://cr.openjdk.java.net/~avstepan/8133134/webrev.00
for
https
Hello,
Could you please review the following fix:
http://cr.openjdk.java.net/~avstepan/8133134/webrev.00
for
https://bugs.openjdk.java.net/browse/JDK-8133134
Deprecated tags replaced with {@code}.
Thanks,
Alexander
Thanks!
On 26.03.2015 0:10, Alexander Zvegintsev wrote:
Hello Alexander,
the fix looks fine to me.
--
Thanks,
Alexander.
On 25.03.2015 19:32, alexander stepanov wrote:
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8075956
Webrev:
http
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8075956
Webrev:
http://cr.openjdk.java.net/~avstepan/8075956/webrev.00/
Just a minor HTML markup fix.
Thanks,
Alexander
at 13:14, alexander stepanov
wrote:
Hello Petr,
Please see the updated webrev:
http://cr.openjdk.java.net/~avstepan/8054143/webrev.01/
Here you end up calling getLocationOnScreen not on EDT
The checks using 'getLocationOnScreen' are on EDT now;
it's better to calculate th
etLocationOnScreen of EDT
With best regards. Petr.
On 27 окт. 2014 г., at 14:24, alexander stepanov
wrote:
Hello,
Could please anyone review this old request?
Thanks,
Alexander
On 25.09.2014 17:06, alexander stepanov wrote:
Just a reminder.
Thanks,
Alexander
On 11.09.2014 18:29, alexander
Hello Petr,
Thanks!
Regards,
Alexander
On 14.11.2014 12:47, Petr Pchelko wrote:
Hello, Alexander.
The fix looks good to me.
With best regards. Petr.
On 27 окт. 2014 г., at 14:25, alexander stepanov
wrote:
Hello,
Could please anyone review this old request?
Thanks,
Alexander
On
Hello Petr,
Thanks!
Regards,
Alexander
On 10.11.2014 17:26, Petr Pchelko wrote:
Hello, Alexander.
The fix looks fine.
With best regards. Petr.
On 27 окт. 2014 г., at 14:24, alexander stepanov
wrote:
Hello,
Could please anyone review this old request?
Thanks,
Alexander
On 24.09.2014
Hello,
Could please anyone review this old request?
Thanks,
Alexander
On 25.09.2014 17:10, alexander stepanov wrote:
Sorry, just a reminder.
Thanks,
Alexander
On 11.09.2014 18:27, alexander stepanov wrote:
Could anyone review this old request?
Thanks,
Alexander
On 15.08.2014 12:19
Hello,
Could please anyone review this old request?
Thanks,
Alexander
On 25.09.2014 17:06, alexander stepanov wrote:
Just a reminder.
Thanks,
Alexander
On 11.09.2014 18:29, alexander stepanov wrote:
Sorry, just a reminder.
Thanks,
Alexander
On 05.09.2014 17:20, alexander stepanov wrote
Hello,
Could please anyone review this old request?
Thanks,
Alexander
On 25.09.2014 17:08, alexander stepanov wrote:
Sorry, just a reminder.
Thanks,
Alexander
On 12.09.2014 15:08, alexander stepanov wrote:
Hello Alexandr,
Fixed; please see the updated webrev:
http://cr.openjdk.java.net
Hello,
Could please anyone review this old request?
Thanks,
Alexander
On 24.09.2014 17:08, alexander stepanov wrote:
Hello Sergey,
Thanks, fixed:
http://cr.openjdk.java.net/~avstepan/8055836/webrev.01/
Regards,
Alexander
On 23.09.2014 18:58, Sergey Bylokhov wrote:
Hi, Alexander
Sorry, just a reminder.
Thanks,
Alexander
On 11.09.2014 18:27, alexander stepanov wrote:
Could anyone review this old request?
Thanks,
Alexander
On 15.08.2014 12:19, alexander stepanov wrote:
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8054358
Sorry, just a reminder.
Thanks,
Alexander
On 12.09.2014 15:08, alexander stepanov wrote:
Hello Alexandr,
Fixed; please see the updated webrev:
http://cr.openjdk.java.net/~avstepan/8054359/webrev.01/
Thanks,
Alexander
On 12.09.2014 12:49, Alexander Scherbatiy wrote:
75 int x
Just a reminder.
Thanks,
Alexander
On 11.09.2014 18:29, alexander stepanov wrote:
Sorry, just a reminder.
Thanks,
Alexander
On 05.09.2014 17:20, alexander stepanov wrote:
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8054143
webrev:
http
, alexander stepanov wrote:
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8055836
webrev:
http://cr.openjdk.java.net/~avstepan/8055836/
This is the result of refactoring for corresponding portion of
functional AWT tests.
The test was checked on Windows 7
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8055836
webrev:
http://cr.openjdk.java.net/~avstepan/8055836/
This is the result of refactoring for corresponding portion of
functional AWT tests.
The test was checked on Windows 7, Solaris 11, Mac OS X 10.8.
, 50);
77 window.setLocation(x, 250);
78 dialog.setLocation(x, 450);
It is better to use part of the screen or frame size instead of
absolute values like 200, 50 and 450.
Thanks,
Alexandr.
On 9/11/2014 6:31 PM, alexander stepanov wrote:
Sorry, just a reminder. Could anyone
Sorry, just a reminder. Could anyone please review that?
Thanks,
Alexander
On 22.08.2014 20:17, alexander stepanov wrote:
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8054359
webrev:
http://cr.openjdk.java.net/~avstepan/8054359/
This is the next
Sorry, just a reminder.
Thanks,
Alexander
On 05.09.2014 17:20, alexander stepanov wrote:
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8054143
webrev:
http://cr.openjdk.java.net/~avstepan/8054143/
This is the next portion of functional AWT tests
Could anyone review this old request?
Thanks,
Alexander
On 15.08.2014 12:19, alexander stepanov wrote:
Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8054358
webrev:
http://cr.openjdk.java.net/~avstepan/8054358/
This is the next portion of functional AWT
1 - 100 of 141 matches
Mail list logo
