Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

Thanks for the review Sergey! Need one more reviewer. > On 11-Apr-2019, at 7:40 AM, Sergey Bylokhov > wrote: > > On 10/04/2019 07:51, Krishna Addepalli wrote: >> Hi Sergey Bylokhov/Phil/Prasanta/Jay, >> Could you review the fix for this issue? Here

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

nconvenience. Thanks, Krishna > On 08-Apr-2019, at 10:33 AM, Krishna Addepalli > wrote: > > Hi Sergey Malenkov, > > Any chance that you can agree on my proposal? > If you are okay I can raise a new bug for addressing your concern, and fixing > the current problem at hand

Re: [13] RFR JDK-8222097: ProblemList tests that are failing recurringly and intermittently in PIT

Hmm! looks ok -Krishna > On 09-Apr-2019, at 10:11 AM, Prasanta Sadhukhan > wrote: > > I dont think we can AFAIK. > Regards > Prasanta > On 08-Apr-19 4:01 PM, Krishna Addepalli wrote: >> I understand that, but my question is if we can replace all those lines in &g

Re: [13] RFR JDK-8222097: ProblemList tests that are failing recurringly and intermittently in PIT

should test all these > tests pass. > > I need all these in ProblemList as in PIT all those tests fail on windows > recurringly, > > Regards > Prasanta > On 08-Apr-19 12:08 PM, Krishna Addepalli wrote: >> Hi Prasanta, >> >> As per my experienc

Re: [13] RFR JDK-8222097: ProblemList tests that are failing recurringly and intermittently in PIT

manageable? Thanks, Krishna > On 08-Apr-2019, at 11:54 AM, Prasanta Sadhukhan > wrote: > > Hi All, > > Please review an addition of some tests in ProblemList that fails recurringly > and some intermittently in PIT. > > Bug: https://bugs.openjdk.java.net/browse

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

Hi Sergey Malenkov, Any chance that you can agree on my proposal? If you are okay I can raise a new bug for addressing your concern, and fixing the current problem at hand? Thanks, Krishna > On 26-Mar-2019, at 4:26 PM, Krishna Addepalli > wrote: > > Hi Sergey Malenkov, > &

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

different bug(it could as well become an enhancement). Thanks, Krishna > On 21-Mar-2019, at 4:04 PM, Sergey Malenkov wrote: > > Hi Krishna, > >> But, currently, with my fix, the code will behave exactly as in Java 1.8. > > Nope, it still sends VK_ALT_GRAPH pressed

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

. I would suggest to re-look at my fix which fixes the current problem at hand, and perhaps we can move this discussion under a new bug. Thanks, Krishna > On 18-Mar-2019, at 8:02 PM, Sergey Malenkov wrote: > > Hi Sergey, > > ALT_GRAPH_DOWN_MASK is not the only mask missing in J

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

be helpful if you could point to some resources, wherein defining such shortcuts is acceptable. Thanks, Krishna > On 14-Mar-2019, at 4:03 PM, Sergey Malenkov wrote: > > I strongly don't like two masks for one key. If you press VK_ALT, > ALT_DOWN_MASK should be s

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

? Thanks, Krishna > On 06-Mar-2019, at 11:02 PM, Sergey Malenkov wrote: > > Hi Krishna, > > Your fix solves the issue that the right Alt key breaks further > processing of the left Alt key. > > But there is a problem with modifiers mask: > 304 java_awt_eve

[13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

etely remove the “altGRPressed” variable as “leftAtlPressed” is sufficient to determine which alt key was pressed. I have tested all the regressions associated with JDK-8156460, and found no new failures. Thanks, Krishna

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

Hi Sergey Malenkov, Thank you for pointing this out. This issue is also reported in JDK-8218917. I’m looking into the issue. Thanks, Krishna > On 01-Mar-2019, at 2:45 AM, Sergey Bylokhov > wrote: > > Hi, Sergey. > > Do you have bugid for this issue? > > On

Re: [13] Review Request: 8219504 Test for JDK-8211435 can be run on all platforms

+1 Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, February 21, 2019 8:01 AM To: awt-dev@openjdk.java.net Subject: [13] Review Request: 8219504 Test for JDK-8211435 can be run on all platforms Hello. Please review the fix for jdk 13. Bug: https

Re: [13] Review request for JDK-8207938: At step6, Click Add button, case failed automatically.

Looks fine. Thanks, Krishna From: Manajit Halder Sent: Tuesday, February 5, 2019 3:22 PM To: awt-dev@openjdk.java.net Subject: [13] Review request for JDK-8207938: At step6, Click Add button, case failed automatically. Hi All, Please review the fix for JDK13. Bug: https

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Sorry, please ignore my previous mail. My mail client synced up mails (after re-formatting) and showed this as a new mail. Sorry for the confusion. Thanks, Krishna > On 31-Jan-2019, at 12:30 PM, Krishna Addepalli > wrote: > > Hi Shashi, > I presume you meant this fix to be

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

/macosx/CAccessible.java.rej abort: patch failed to apply Thanks, Krishna > On 01-Oct-2018, at 3:10 PM, shashidhara.veerabhadra...@oracle.com wrote: > > Hi All, Please review a fix for an accessibility bug. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8061359 &g

Re: [13] RFR JDK-8217464: Remove resolved client bugs from the ProblemList.txt

+1 Krishna > On 30-Jan-2019, at 3:56 PM, Prasanta Sadhukhan > wrote: > > Hi All, > > Please review an updation of ProblemList to remove/update resolved client > bugs from ProblemList > > Bug: https://bugs.openjdk.java.net/browse/JDK-8217464 > webrev: http://c

Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

setAutoDelay call. Here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8215921/webrev05 <http://cr.openjdk.java.net/~kaddepalli/8215921/webrev05> Thanks, Krishna > On 29-Jan-2019, at 2:05 PM, Prasanta Sadhukhan > wrote: > > Hi Krishna, > Fix looks ok..In

Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

Hi Sergey, I corrected the test case to work on Mac, and here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8215921/webrev04 <http://cr.openjdk.java.net/~kaddepalli/8215921/webrev04> Thanks Krishna > On 24-Jan-2019, at 3:39 AM, Sergey Bylokhov > wrote: > >

Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

Hi Sergey, I have modified the test as you suggested. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8215921/webrev03/ <http://cr.openjdk.java.net/~kaddepalli/8215921/webrev03/> Thanks, Krishna > On 19-Jan-2019, at 3:39 AM, Sergey Bylokhov > wrote: > > Hi,

Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

. Thanks, Krishna From: <> Krishna Addepalli Sent: Thursday, January 17, 2019 8:34 PM To: Sergey Bylokhov Cc: awt-dev@openjdk.java.net Subject: Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse. Hi Sergey, The test case was lead

Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

item is selected again. Here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8215921/webrev02 <http://cr.openjdk.java.net/~kaddepalli/8215921/webrev02> Thanks, Krishna > On 17-Jan-2019, at 1:30 AM, Sergey Bylokhov > wrote: > > > On 16/01/2019 09:59, Kr

Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

net/~kaddepalli/8215921/webrev01/> Thanks, Krishna > On 16-Jan-2019, at 12:50 AM, Sergey Bylokhov > wrote: > > Hi, Krishna. > > On 15/01/2019 08:52, Krishna Addepalli wrote: >> While fixing JDK-8014503 <https://bugs.openjdk.java.net/browse/JDK-8014503>, >>

Re: [12] Review request for JDK-8215280: Double click on titlebar not working for Frame with extended state set to MAXIMIZED_BOTH

+1 -Original Message- From: Sergey Bylokhov Sent: Tuesday, January 15, 2019 7:19 AM To: Manajit Halder Cc: awt-dev@openjdk.java.net Subject: Re: [12] Review request for JDK-8215280: Double click on titlebar not working for Frame with extended state set to MAXIMIZED_BOTH Looks fine.

[12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

s for the mouse event clicked on a different item. This test was not present earlier, which made it harder to detect this. I have run the jtreg tests and did not find any new failures, and also verified that the newly introduced test case passes on Windows, Linux and Mac. Thanks, Krishna

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

+1 Thanks, Krishna From: Shashidhara Veerabhadraiah Sent: Thursday, January 3, 2019 3:06 PM To: awt-dev@openjdk.java.net; swing-...@openjdk.java.net Subject: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash Hi All, Please review a fix for the

Re: [13] RFR: JDK-8215910: Typo in AWT InvocationEvent Method Documentation

Thank you Alexey. I understood that the second Runnable was not needed, hence I made changes. So, I believe you are endorsing webrev01 right? Thanks Krishna -Original Message- From: Alexey Ivanov Sent: Thursday, January 3, 2019 3:14 PM To: Krishna Addepalli ; awt-dev Subject: Re

Re: [13] RFR: JDK-8215910: Typo in AWT InvocationEvent Method Documentation

Hi Alexey, Thank you for the suggestion. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8215910/webrev01/ <http://cr.openjdk.java.net/~kaddepalli/8215910/webrev01/> Thanks, Krishna > On 31-Dec-2018, at 6:39 PM, Alexey Ivanov wrote: > > Hi Krishna, > &g

[13] RFR: JDK-8215910: Typo in AWT InvocationEvent Method Documentation

Hi All, Please review a trivial doc fix for JDK-8215910. Webrev: http://cr.openjdk.java.net/~kaddepalli/8215910/webrev00/ <http://cr.openjdk.java.net/~kaddepalli/8215910/webrev00/> Thanks, Krishna

Re: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms

Hi Sergey,   The changes look fine to me.   Thanks, Krishna Subject: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms Date: Thu, 6 Dec 2018 09:26:06 -0800 From: Sergey Bylokhov HYPERLINK

Re: [12] Review Request: 8215200 IllegalArgumentException in sun.lwawt.macosx.CPlatformWindow

Hi Sergey, The fix looks good to me. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Friday, December 14, 2018 1:03 PM To: awt-dev@openjdk.java.net; dmitry markov Subject: [12] Review Request: 8215200 IllegalArgumentException in sun.lwawt.macosx.CPlatformWindow Hello

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Thanks for the review Sergey! -Original Message- From: Sergey Bylokhov Sent: Friday, December 14, 2018 10:07 AM To: Krishna Addepalli Cc: Shashidhara Veerabhadraiah ; awt-dev@openjdk.java.net; Prasanta Sadhukhan Subject: Re: RFR: [12] JDK-8196681: Java Access Bridge logging and

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi Sergey, I hope that your query is answered. Could you review the new webrev and approve it? Thanks, Krishna -Original Message- From: Krishna Addepalli Sent: Tuesday, December 11, 2018 5:14 PM To: Sergey Bylokhov ; Shashidhara Veerabhadraiah Cc: Prasanta Sadhukhan ; awt-dev

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

). 2. I made all the declarations auto. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev09 Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Tuesday, December 11, 2018 2:37 AM To: Krishna Addepalli ; Shashidhara Veerabhadraiah Cc: Prasanta

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi Sergey, The only way to avoid changes to make file is by using C string manipulation API. Here is the webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev08 , although I would personally prefer using the C++ api. Thanks, Krishna -Original Message- From: Krishna Addepalli

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

the modified webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev07 Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, December 6, 2018 11:37 PM To: Krishna Addepalli ; Shashidhara Veerabhadraiah Cc: Prasanta Sadhukhan ; awt-dev@openjdk.java.net Subject

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

, Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, December 6, 2018 10:49 PM To: Krishna Addepalli ; Shashidhara Veerabhadraiah Cc: Prasanta Sadhukhan ; awt-dev@openjdk.java.net Subject: Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

ath a local variable. Here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev06 Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, December 6, 2018 4:53 AM To: Krishna Addepalli ; Shashidhara Veerabhadraiah Cc: Prasanta Sadhukhan ; aw

Re: [12] RFR 8213983: [macosx] Keyboard shortcut “cmd +`” stops working properly if popup window is displayed

+1 Thanks, Krishna > On 06-Dec-2018, at 2:29 PM, Dmitry Markov wrote: > > Thank you, Sergey! > Looking for the second “+1” from someone else. > > Thanks, > Dmitry > >> On 6 Dec 2018, at 00:10, Sergey Bylokhov wrote: >> >> Looks fine. >> >

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Thanks for the review Shashi. Sergey could you also review? Thanks, Krishna > On 05-Dec-2018, at 10:16 AM, Shashidhara Veerabhadraiah > wrote: > > Hi Krishna, The changes looks good to me and I did imported this patch and > found that the debug logs are useful in debugging th

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi Shashi, Thanks for the comments, here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev05 Krishna -Original Message- From: Shashidhara Veerabhadraiah Sent: Tuesday, December 4, 2018 2:29 PM To: Krishna Addepalli ; Sergey Bylokhov ; Prasanta Sadhukhan

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

environment variable, the problem remains the same. So, I think we can only add a note saying that it is recommended to close JAWs after each debug session. Thanks, Krishna -Original Message- From: Shashidhara Veerabhadraiah Sent: Monday, December 3, 2018 10:44 AM To: Krishna Addepalli ; Sergey

Re: [OpenJDK 2D-Dev] [12] Review Request: 8214461 Some unused classes may be removed

Looks good to me. Krishna > On 01-Dec-2018, at 7:33 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for jdk 12. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214461 > Webrev: http://cr.openjdk.java.net/~serb/8214461/webrev.00 > >

Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

Hi Alexey, Thanks for your suggestions. I have already committed the changes. Can we address this in a new bug? Thanks, Krishna > On 29-Nov-2018, at 5:15 PM, Alexey Ivanov wrote: > > Hi Krishna, > > Thank you for dropping tags. > > *DesktopProperties.html:* > >

Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

Sure, Alexey that would be helpful. Thanks, Krishna -Original Message- From: Alexey Ivanov Sent: Thursday, November 29, 2018 4:23 PM To: Sergey Bylokhov ; Krishna Addepalli ; awt-dev Subject: Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files On 28/11/2018 21:55

Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

, addressing them in separate bug is better? Here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8213048/webrev02 Thanks, Krishna -Original Message- From: Alexey Ivanov Sent: Tuesday, November 27, 2018 5:18 PM To: Sergey Bylokhov ; Krishna Addepalli ; awt-dev Subject: Re: [12]RFR

Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

Hi Magnus,   Thanks for taking a look. I was wanting to change the SAFE_ALLOC definition, but since that file is in java.base, I was not sure of changing it.   Krishna   From: Magnus Ihse Bursie Sent: Tuesday, November 27, 2018 6:52 PM To: Krishna Addepalli Cc: Philip Race ; awt-dev

Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

K3 and did not find any crashes. Thanks, Krishna From: Krishna Addepalli Sent: Tuesday, October 2, 2018 8:53 PM To: Philip Race Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; build-dev Subject: Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve disabled warnings

Re: [12] RFR 8213583: Error while opening the JFileChooser when desktop contains shortcuts pointing to deleted files

Hi Dmitry, Thanks for fixing this issue. The change looks fine. Thanks, Krishna From: Dmitry Markov Sent: Monday, November 26, 2018 4:09 PM To: awt-dev@openjdk.java.net Subject: [12] RFR 8213583: Error while opening the JFileChooser when desktop contains shortcuts pointing to

Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

net/~kaddepalli/8213048/webrev01/ Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Saturday, November 10, 2018 2:19 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files Hi, Krishna. The closed tag &qu

Re: [12] RFR 8213983: [macosx] Keyboard shortcut “cmd +`” stops working properly if popup window is displayed

window has a ComboBox component in it, then PopupMenu will be an additional window, and the length may not necessarily be equal to one. Thanks, Krishna > On 21-Nov-2018, at 10:10 PM, Dmitry Markov wrote: > > Hello, > > Could you review a fix for jdk12, please? >

Re: OpenJdk11-28-EA JDialog hanging

Hi Martin & Laurent, Thank you for all your efforts in root causing and fixing this important issue. Regards, Krishna > On 14-Nov-2018, at 11:16 PM, Martin Balao wrote: > > Hi, > > Submit-repo tests passed. > > Changeset has been committed: > http://hg.

Re: OpenJdk11-28-EA JDialog hanging

+1   Krishna   From: Laurent Bourgès Sent: Tuesday, November 13, 2018 2:18 PM To: Martin Balao Cc: awt-dev@openjdk.java.net Subject: Re: OpenJdk11-28-EA JDialog hanging   Hi, Sergey approved the webrev.4, anyone else?   I would like this bug fix to be pushed soon, then this RFR

[12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

Hi All, Please review a simple fix for updating html attributes to use CSS style options to comply with HTML5. JDK-8213048: https://bugs.openjdk.java.net/browse/JDK-8213048 Webrev: http://cr.openjdk.java.net/~kaddepalli/8213048/webrev00/ Thanks, Krishna

Re: [12] RFR : JDK-8198002 : java/awt/Mixing/Validating.java debug assert on Windows

Hi Ambarish, Looks fine to me as well. Could you also remove the wildcard imports in the test? I don't need to see a new webrev - just do the changes and push it. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, November 8, 2018 10:41 PM To: Ambarish

Re: [12] Review Request: 8211822 and 8202886

Thanks for updating the tests Sergey, but I guess, the Platform specific check in the code can be removed now? Krishna > On 02-Nov-2018, at 1:15 AM, Sergey Bylokhov > wrote: > > Hi, Krishna. > > The tests were updated as requested: > http://cr.openjdk.java.net/~s

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

Hi Shashi, 1. Please add "@key headful" to the test. 2. I don’t think you need to replace the waitForIdle call with delay. You may choose to add delay in addition to waitForIdle. 3. Minor nit: replace () -> createAndShowGUI() with method reference. Thanks, Krishna -Ori

Re: [12] Review Request: 8211822 and 8202886

Also consider adding it for bug7154841, bug8007006.java. -Original Message- From: Krishna Addepalli Sent: Wednesday, October 31, 2018 1:35 PM To: Jayathirth D V ; Sergey Bylokhov Cc: awt-dev@openjdk.java.net; Igor Ignatyev Subject: Re: [12] Review Request: 8211822 and 8202886 Hi

Re: [12] Review Request: 8211822 and 8202886

Hi Sergey, Could you update the test use @requires tag, instead of relying on Platform for NSTexturedJFrame.java? This would probably make the test skip faster on non-Mac platforms. Thanks, Krishna -Original Message- From: Jayathirth Rao Sent: Wednesday, October 31, 2018 12:25 PM To

Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete

+1 Krishna -Original Message- From: Dmitry Markov Sent: Friday, October 26, 2018 4:57 PM To: Manajit Halder Cc: awt-dev@openjdk.java.net Subject: Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete Hi Manajit, Looks good to me

Re: OpenJdk11-28-EA JDialog hanging

Hi Sergey, I also agree with Laurent about root cause of hang provided by Martin. However, we just need to make sure that non Sequenced Events are not dispatched when SequencedEvents are being dealt with. Thanks, Krishna > On 25-Oct-2018, at 1:35 PM, Laurent Bourgès wrote: > >

Re: [12] Review Request: 8211435 Exception in thread "AWT-EventQueue-1" java.lang.IllegalArgumentException: null source

Looks good to me. > On 25-Oct-2018, at 5:41 PM, Laurent Bourgès wrote: > > Hi Sergey, > > (I am not a Reviewer). > > Thanks for both the bug report and the fix, it looks good for me. > > Laurent > > Le mer. 24 oct. 2018 à 23:32, Sergey Bylokhov > a écrit :

Re: [12]RFR: JDK-8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.html fails on Windows

containing the currently selected item, which is why the test was passing. Thanks, Krishna On 25-Oct-2018, at 9:57 AM, Sergey Bylokhov wrote: Hi, Krishna. This test was integrated 14 years ago, and this bug was filed 1 year ago. Can you please confirm that this is not regression and the

[12]RFR: JDK-8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.html fails on Windows

different item. Along with the fix, I have removed the applet based code, and also the test now passes on Mac (which was earlier excluded). Thanks, Krishna

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

shown on the progress bar, and at that point, it feels like the focus is lost and may lead to some confusion. I think it would be good if we can render a focus rect around the progress bar to let users know that it is in focus, which ofcourse can be addressed separately. Thanks, Krishna >

Re: OpenJdk11-28-EA JDialog hanging

are more qualified to comment on this, but this is my 2 cents! Thanks, Krishna > On 18-Oct-2018, at 2:15 PM, Martin Balao wrote: > > Hi Laurent, > > On Wed, Oct 17, 2018 at 8:13 PM, Laurent Bourgès <mailto:bourges.laur...@gmail.com>> wrote: > If the behavior chang

Re: OpenJdk11-28-EA JDialog hanging

– for example, the current SequencedEvent could be a focus change event, and the subsequent events could be Key events. So, as per your solution, if we dispatch them, there is a possibility that the intended component may not receive those events.   Thanks, Krishna   From: Martin Balao Sent

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

generate the file suffixed with "_java_access_bridge", whereas WindowsAccessBridge generates file suffixed with "_windows_access_bridge". Here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev04/ Thanks, Krishna -Original Message- From: S

Re: [12] Review Request: 8210231 Robot.delay() catches InterruptedException and prints stacktrace to stderr.

+1 Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Monday, October 8, 2018 10:26 AM To: awt-dev@openjdk.java.net Subject: [12] Review Request: 8210231 Robot.delay() catches InterruptedException and prints stacktrace to stderr. Hello. Please review the fix for jdk12

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

Looks fine.   Krishna   From: Manajit Halder Sent: Thursday, October 4, 2018 6:01 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu   Hi Krishna, Thanks for your

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

Hi Sergey, I had to update the test, since on Mac, it is always selecting the second element, and the test fails. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Monday, October 1, 2018 7:57 AM To: Krishna Addepalli Cc: Ajit Ghaisas ; Shashidhara Veerabhadraiah ; awt

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

line 825, you could initialize windowResizable like this: “resizable && !isMaximizedBoth()”.   Thanks, Krishna     From: Manajit Halder Sent: Tuesday, September 25, 2018 3:23 PM To: Krishna Addepalli mailto:krishna.addepa...@oracle.com"krishna.addepa...@oracle.com> Subject:

Re: OpenJdk11-28-EA JDialog hanging

problem. Then I’ll create a backout bug and push this patch.   Thanks, Krishna   From: Laurent Bourgès Sent: Thursday, September 27, 2018 12:57 PM To: Krishna Addepalli Cc: Phil Race ; Sergey Bylokhov ; awt-dev@openjdk.java.net Subject: Re: OpenJdk11-28-EA JDialog hanging   Any

Re: [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

Yes, that is right. I have compiled it Mac, Linux and Windows locally. I tried submitting a Mach5 job, but was unable to as it was down. Will try it again. Thanks Krishna > On 02-Oct-2018, at 3:39 AM, Philip Race wrote: > > I suspect I understand this one now .. the array is stack

Re: [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

Hi Sergey, By using static_cast, I have maintained the existing behaviour. I’m not sure about which function to use, but should we address it separately, or here itself? Thanks, Krishna > On 01-Oct-2018, at 8:33 AM, Sergey Bylokhov > wrote: > > Hi, Krishna. > One initial

[12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

Hi All, Please review a fix for JDK-8074824: https://bugs.openjdk.java.net/browse/JDK-8074824 Webrev: http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/ Most of the warnings have been fixed for Linux, Mac and Windows. Thanks, Krishna

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

tested it. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev03/ <http://cr.openjdk.java.net/~kaddepalli/8014503/webrev03/> Thanks, Krishna > On 23-Aug-2018, at 4:34 PM, Sergey Bylokhov > wrote: > > Hi, Krishna. > On 20/08/2018 04:30, Krishna Ad

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi Sergey, Since the bug was about supporting Java Access Bridge Debugging, I have enabled logging only for Java Access Bridge. So, any log statements form Windows Access bridge are ignored. Do you think we should enable logging for Windows Access Bridge as well? Thanks, Krishna > On 17-

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

anta > On 14-Sep-18 8:33 PM, Krishna Addepalli wrote: >> Nullptr is the recommended way in modern c++. I thought of changing the >> other places as well, but wanted to keep the changes minimal, so left them >> as is. >> >> Thanks, >> Krishna >> >

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Nullptr is the recommended way in modern c++. I thought of changing the other places as well, but wanted to keep the changes minimal, so left them as is. Thanks, Krishna From: Prasanta Sadhukhan Sent: Friday, September 14, 2018 5:48 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Thanks for the comments. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev02/ --Krishna From: Prasanta Sadhukhan Sent: Friday, September 14, 2018 3:23 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: RFR: [12] JDK-8196681: Java Access Bridge

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Thanks for the review Prasanta. Although there is not much difference between using fprintf and vfprintf, I have changed all the calls to vfprintf. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev01/ Krishna From: Prasanta Sadhukhan Sent: Friday, September

Re: [12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut

Looks fine to me!   Thanks, Krishna   From: Dmitry Markov Sent: Monday, September 10, 2018 6:06 PM To: Manajit Halder Cc: awt-dev@openjdk.java.net Subject: Re: [12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut   Hi

RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

ded. Note that the implementation is simplistic, and doesnot have any way to handle multiple applications, since it is a debug only feature. Thanks, Krishna

Re: OpenJdk11-28-EA JDialog hanging

Hi Laurent, Thanks for providing the test case. I was able to reproduce the issue. Glad to know that you found a workaround, as this issue is a bit tricky to fix. Meanwhile, I’m looking into fixing this issue, and your test case greatly helps me toward finding the fix faster. Krishna > On

Re: StackOverflowError happened by TextField.setFont(...)

Hi Ichiroh, Yes I'm able to see this issue in jdk12 repo on Ubuntu. But this issue is not reproducible on Windows. So, I guess the fix has to be specific to Linux. Thanks, Krishna -Original Message- From: Ichiroh Takiguchi Sent: Monday, September 3, 2018 4:26 PM To: Kr

Re: OpenJdk11-28-EA JDialog hanging

was reverted in JDK8, and since we couldn’t find a scenario in JDK11 (since webstart is deprecated). It would be helpful if you could provide smallest possible test case / sequence of steps to reproduce the problem. Thanks, Krishna > On 04-Sep-2018, at 6:26 PM, Laurent Bourgès wrote: >

Re: StackOverflowError happened by TextField.setFont(...)

Hi Ichiroh, I have tried the steps you outlined, but I'm not able to reproduce the issue you are seeing. Could you try with the latest jdk12 repo? Thanks, Krishna -Original Message- From: Ichiroh Takiguchi Sent: Friday, August 24, 2018 1:42 PM To: awt-dev@openjdk.java.net Su

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

t;, but my question is, should I make this change or keep the index based change, since that would keep the implementation also consistent across platforms. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Tuesday, August 14, 2018 7:52 AM To: Krishna Addepalli ; Aj

Re: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

, then the constructor would also be private. To work around this limitation, the compiler generates an additional public constructor with a dummy type as the parameter, which it in turn uses to instantiate the private inner classes. The changes look fine for me! +1. Thanks, Krishna -Original Message

Re: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

generate an accessor method. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Friday, August 10, 2018 8:25 AM To: awt-dev@openjdk.java.net; swing-...@openjdk.java.net Subject: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated Hello

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

intln(c.getSelectedIndex()); f.repaint(); sleep(5); c.remove("Item 4"); System.out.println(c.getSelectedIndex()); f.repaint(); }); sleep(5000); EventQueue.invokeAndWait(() -> { f.dispose();

Re: RFR: 8208353: Upgrade JDK 11 to libpng 1.6.35

One more thing, in the UPDATING.txt: In the first line: "TING libpng in OpenJDK". I guess it should have been "UPDATING" ... -Original Message- From: Krishna Addepalli Sent: Friday, July 27, 2018 5:46 PM To: Philip Race ; awt-dev@openjdk.java.net Subject: Re: RFR:

Re: RFR: 8208353: Upgrade JDK 11 to libpng 1.6.35

Hi Phil, The changes look fine to me. Great to see the steps that need to be followed for updating png library into UPDATING.txt. I see a small typo on line 19: "handiling". Don’t need a new webrev for this. Thanks, Krishna -Original Message- From: Philip Race Sent: Frida

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

Hi Prasanta/Sergey, Could you review this ? @Ajit, Shashi - Thanks for your review. Thanks, Krishna From: Ajit Ghaisas Sent: Tuesday, July 3, 2018 3:31 PM To: Krishna Addepalli ; Shashidhara Veerabhadraiah ; awt-dev@openjdk.java.net Subject: RE: [12]RFR : JDK-8014503: AWT

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

selectedIndex, this won't be the case. 4. Also, remove function is not called from here, but from outside. So, the state will clash, when I save the last selected index, and immediately remove gets called. Hope this clarifies. Thanks, Krishna From: Ajit Ghaisas Sen

Re: [OpenJDK 2D-Dev] [11] Review Request: 8201611 Broken links in java.desktop javadoc

Looks fine -Original Message- From: Phil Race Sent: Monday, July 2, 2018 10:46 PM To: Sergey Bylokhov ; awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net> Subject: Re: [OpenJDK 2D-Dev] [11] Review Request: 8201611 Broken links in java.desktop javadoc OK, +1 -phil. On 07/02/

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

Hi Shashi, Thanks for the review. Here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev01/ As for the test, it has already been corrected and pushed in JDK-8197810. Thanks, Krishna From: Shashidhara Veerabhadraiah Sent: Monday, July 2, 2018 11:30 PM

Re: [11] Review Request: 8205588 Deprecate for removal com.sun.awt.SecurityWarning

+1 -Original Message- From: Philip Race Sent: Tuesday, July 3, 2018 12:17 AM To: Sergey Bylokhov Cc: awt-dev@openjdk.java.net Subject: Re: [11] Review Request: 8205588 Deprecate for removal com.sun.awt.SecurityWarning +1 -phil. On 6/24/18, 11:27 PM, Sergey Bylokhov wrote: > Hello. >

[12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

not changed for Mac and Linux. This fix changes that behavior, and makes it consistent for all the three platforms. Thanks, Krishna

  1   2   >