Re: BBDB failed to handle what it considers duplicates

2013-01-13 Thread Roland Winkler
On Sat Jan 12 2013 Leo Liu wrote: It seems we are going back in time. The problem is name cannot single-handedly identify a record. Having used BBDB since v2 I have nearly a thousand records. Duplicates happen and v3 can not handle it or handle it badly. End of the year I installed a bunch of

Re: BBDB failed to handle what it considers duplicates

2013-01-12 Thread Leo Liu
On 2013-01-12 14:48 +0800, Roland Winkler wrote: ??? Do you want the excotic or the very excotic problems fixed? I think we should keep some priorities in mind. If you do have a real-worl problem, then please describe how it can be reproduced. It seems we are going back in time. The problem

Re: BBDB failed to handle what it considers duplicates

2013-01-11 Thread Leo Liu
Hello Roland, On 2012-10-16 09:12 +0800, Roland Winkler wrote: Recent BBDB3 doesn't allow duplicates by default. It does mail-completion from the first record of the duplicates. The others are ignored. I guess I start to understand, where your problem is coming from. When BBDB loads the

Re: BBDB failed to handle what it considers duplicates

2013-01-11 Thread Roland Winkler
On Sat Jan 12 2013 Leo Liu wrote: In my mail yesterday, I only thought of bbdb-complete-mail being affected by duplicate records. BBDB's MUA interface is actually more subtle. Here I can think of situations where BBDB can get confused and give strange results if, say, a message uses a name

Re: BBDB failed to handle what it considers duplicates

2012-10-15 Thread Roland Winkler
On Mon Oct 15 2012 Leo wrote: In BBDB3 (a few months old), duplicates were allowed by default. So if you typed a substring in a mailer that matches two duplicate records, it gave you an opportunity to choose. As I tried to explain, the old code was broken in various ways. Yet comments in the

Re: BBDB failed to handle what it considers duplicates

2012-10-15 Thread Leo
On 2012-10-16 09:12 +0800, Roland Winkler wrote: I guess I start to understand, where your problem is coming from. When BBDB loads the database, bbdb-allow-duplicates is nil, and there are multiple records with the same name, then only the first record with this name is hashed (so that it

Re: BBDB failed to handle what it considers duplicates

2012-10-14 Thread Roland Winkler
On Sun Oct 14 2012 Leo wrote: Sure. So bbdb-no-duplicates was renamed to bbdb-allow-duplicates while keeping the same value which amounts to disallow duplicates by default and that is exactly what caused me all the trouble. The annoying thing was that I kept both the default value and the

Re: BBDB failed to handle what it considers duplicates

2012-10-14 Thread Roland Winkler
On Sat Oct 13 2012 Roland Winkler wrote: See bbdb-allow-duplicates. [snip] Also, the docstring of this variable expresses the fact... ...that so far in BBDB's history nobody considered the case of records with duplicate names important enough to extend the code of bbdb-complete-mail to

Re: BBDB failed to handle what it considers duplicates

2012-10-13 Thread Roland Winkler
On Sat Oct 13 2012 Leo wrote: I just noticed BBDB no longer completes some emails because they are part of a record that BBDB considers a duplicate. This change is annoying and has caused me a lot of trouble sending emails to wrong recipients. Can you please be more specific? Under what

Re: BBDB failed to handle what it considers duplicates

2012-10-13 Thread Leo
On 2012-10-13 19:57 +0800, Roland Winkler wrote: Can you please be more specific? Under what circumstances did BBDB what, which now it does not do anymore? Create a bbdb db with two duplicate records and each has an email. Try completing emails in gnus or whatever mailer. Type a substring

Re: BBDB failed to handle what it considers duplicates

2012-10-13 Thread Roland Winkler
On Sun Oct 14 2012 Leo wrote: Yes, it is related. The way BBDB3 handles duplicates is pretty bad. Try to create two records with the same name. It throws an error in emacs -q. See bbdb-allow-duplicates. I guess it is fair to say that this variable was introduced long ago not as a bug, but as

Re: BBDB failed to handle what it considers duplicates

2012-10-13 Thread Leo
On 2012-10-14 00:46 +0800, Roland Winkler wrote: See bbdb-allow-duplicates. I guess it is fair to say that this variable was introduced long ago not as a bug, but as a feature. Depending on circumstances, it could be more likely that duplicate entries inadvertently refer to the same person.