Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

Thanks Daniel! On Wed, Mar 8, 2023 at 2:39 PM Daniel Bratell wrote: > LGTM3 to ship image-set > > /Daniel > > On 2023-03-08 15:51, Manuel Rego Casasnovas wrote: > > LGTM2 > > > > Thank you very much for fixing the issues before shipping. > > > > On 08/03/2023 10:53, Yoav Weiss wrote: > >> Even

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

LGTM3 to ship image-set /Daniel On 2023-03-08 15:51, Manuel Rego Casasnovas wrote: LGTM2 Thank you very much for fixing the issues before shipping. On 08/03/2023 10:53, Yoav Weiss wrote: Even though wpt.fyi

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

Thanks Rego! On Wed, Mar 8, 2023 at 6:51 AM Manuel Rego Casasnovas wrote: > LGTM2 > > Thank you very much for fixing the issues before shipping. > > On 08/03/2023 10:53, Yoav Weiss wrote: > > Even though wpt.fyi > > < >

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

Thanks Yoav! On Wed, Mar 8, 2023 at 1:53 AM Yoav Weiss wrote: > My LGTM1 still stands! :) > > On Wed, Mar 8, 2023 at 8:40 AM Traian Captan wrote: > >> Hi, >> >> Following the previous conversation, we worked on adding support for the >> missing functionality that is currently described in the

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

LGTM2 Thank you very much for fixing the issues before shipping. On 08/03/2023 10:53, Yoav Weiss wrote: > Even though wpt.fyi > > is reddish, I'm seeing all the tests pass on ToT. Thank

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

My LGTM1 still stands! :) On Wed, Mar 8, 2023 at 8:40 AM Traian Captan wrote: > Hi, > > Following the previous conversation, we worked on adding support for the > missing functionality that is currently described in the image-set spec >

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

Hi, Following the previous conversation, we worked on adding support for the missing functionality that is currently described in the image-set spec . Here is the updated intent: Contact emailstcap...@chromium.org

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

Thanks Noam! I'll add support for the other cases behind the feature flag and we'll ship it when we are "interoperable enough". Regards, Traian On Wed, Dec 14, 2022 at 6:41 AM Noam Rosenthal wrote: > > > On Wed, Dec 14, 2022 at 2:28 PM Manuel Rego Casasnovas > wrote: > >> If we have plans

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

Hi Rego, If we have plans to fix issues on this feature later, why not fixing > them before and then shipping when things look good? Sounds good. I'll fix the issues first, and then I will update the Intent. Checking the tests results in wpt.fyi: > >

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

On Wed, Dec 14, 2022 at 2:28 PM Manuel Rego Casasnovas wrote: > If we have plans to fix issues on this feature later, why not fixing > them before and then shipping when things look good? > > If we unprefix it, it'll kind of appear as a new Chromium feature that > people can use, and they will

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

If we have plans to fix issues on this feature later, why not fixing them before and then shipping when things look good? If we unprefix it, it'll kind of appear as a new Chromium feature that people can use, and they will expect it follows the spec. But we'll have to document it just works for

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

Thanks Stefan! That makes sense. We do plan to address some of the other issues. Having bugs filed would be helpful in prioritizing what we should focus on next. Regards, Traian On Wed, Dec 7, 2022 at 2:12 PM Stefan Zager wrote: > > > On Wed, Dec 7, 2022 at 5:39 AM Manuel Rego Casasnovas >

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

Hi Rego, > I do wonder what's the goal of removing the prefix, if we're not also > improving the spec compliance and interoperability? > It's an incremental step in the direction of spec compliance and interoperability. Further improvements will follow. This is similar to how Firefox handled the

[blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

Thanks Yoav! This intent only covers the unprefixing. Further interop improvements will come later. Regards, Traian On Wed, Dec 7, 2022 at 3:37 AM Yoav Weiss wrote: > LGTM1 > > Thanks for working on this!! Looking at wpt.fyi, other implementations are > passing the test suite for this to

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

On Wed, Dec 7, 2022 at 5:39 AM Manuel Rego Casasnovas wrote: > > On 07/12/2022 12:37, Yoav Weiss wrote: > > LGTM1 > > > > Thanks for working on this!! Looking at wpt.fyi, other implementations > > are passing the test suite for this to varying degrees. Does this intent > > cover full compliance

Re: [blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

On 07/12/2022 12:37, Yoav Weiss wrote: > LGTM1 > > Thanks for working on this!! Looking at wpt.fyi, other implementations > are passing the test suite for this to varying degrees. Does this intent > cover full compliance with the test suite? (e.g. `type()`, `url()`, non > `x` descriptors, and

[blink-dev] Re: Intent to Ship: Unprefix -webkit-image-set

LGTM1 Thanks for working on this!! Looking at wpt.fyi, other implementations are passing the test suite for this to varying degrees. Does this intent cover full compliance with the test suite? (e.g. `type()`, `url()`, non `x` descriptors, and maybe other dimensions) Or does it only cover the