[chromium-dev] Re: buildbot failure in Chromium on Chromium Builder (dbg), revision 36644

on it. Sorry. On Wed, Jan 20, 2010 at 10:52 AM, wrote: > http://build.chromium.org/buildbot/waterfall/ > > Automatically closing tree for "compile" on "Chromium Builder (dbg)" > > > http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Builder%20%28dbg%29/builds/15729 > > Revision:

Re: [chromium-dev] how to disable SVG when building chromium

Oh, according to the file, build/features_override.gypi will also do the trick. On Mon, Jan 18, 2010 at 11:53 PM, Jeremy Orlow wrote: > http://trac.webkit.org/browser/trunk/WebKit/chromium/features.gypi > > WebKit is under third_party/WebKit in the src tree > > On Mon, Jan 18, 2

Re: [chromium-dev] how to disable SVG when building chromium

http://trac.webkit.org/browser/trunk/WebKit/chromium/features.gypi WebKit is under third_party/WebKit in the src tree On Mon, Jan 18, 2010 at 11:45 PM, n179911 wrote: > Hi, > > Webkit has an option to disable SVG build with the executable. Can you > please tell me how can I disable SVG when bui

Re: [chromium-dev] Ajax maximum response size

Either way, it seems like these are bugs that are worthy of being filed. Greg, any advice? J On Fri, Jan 15, 2010 at 10:20 AM, Rryk wrote: > Hello, > > I am implementing 3D rendering engine for Chromium and I need to > download huge scenes via Ajax. However I've noticed that asyncronous > Ajax

Re: [chromium-dev] Re: updates to tech talks page: added link to "Exploring Chrome Internals" slide deck, etc

On Wed, Jan 13, 2010 at 3:55 PM, Chase Phillips wrote: > On Wed, Jan 13, 2010 at 14:50, Chase Phillips wrote: > >> Darin's June 2, 2009 Google I/O "Exploring Chrome Internals" presentation >> slide deck is now available from >> http://sites.google.com/a/chromium.org/dev/developers/tech-talk-vide

Re: [chromium-dev] RFC: Extensions Incognito

On Wed, Jan 13, 2010 at 3:48 PM, Antony Sargent wrote: > What if the Incognito profile started with a copy-on-write version of > extensions' localStorage? That way extensions in Incognito mode would see > the writes they just made, but changes would not persist beyond Incognito > mode. This act

Re: [chromium-dev] WebKit Gardeners <3 rebaseline.py -w

Same here. On Fri, Jan 8, 2010 at 4:51 PM, Drew Wilson wrote: > Do you find that you have time to figure out if rebaselining a test is the > right thing to do while you're actively gardening? Maybe I just work too > slowly, but I often find that if I'm trying to rebaseline on the fly, it > requi

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

What about renaming the function? EmptyStringHACK() or something? On Thu, Jan 7, 2010 at 1:49 PM, Peter Kasting wrote: > On Thu, Jan 7, 2010 at 1:43 PM, Jeremy Orlow wrote: > >> You ignored the second half of my suggestion. >> > > The second half of your suggestion lea

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

On Thu, Jan 7, 2010 at 1:38 PM, Peter Kasting wrote: > On Thu, Jan 7, 2010 at 1:34 PM, Jeremy Orlow wrote: > >> (As discussed during lunch...) Why not just do this in this case and >> remove EmptyString() altogether? >> >> const std::string& MyClass::foo() con

Re: [chromium-dev] Replicated State among tabs in Chromium

And before you suggest using software transactional memory, keep in mind that side effects (XHRs and other network activity for example) are prevalent in normal JavaScript usage. I don't mean to discourage you too muchespecially if you were interested in digging really deeply into this stuff..

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

(As discussed during lunch...) Why not just do this in this case and remove EmptyString() altogether? const std::string& MyClass::foo() const { static std::string empty = EmptyString(); return (everything == OK) ? member_string : empty; } I forget if this runs the constructor on first use or

Re: [chromium-dev] Replicated State among tabs in Chromium

On Thu, Jan 7, 2010 at 1:10 PM, Charlie Reis wrote: > > > On Thu, Jan 7, 2010 at 12:53 PM, Ben Laurie wrote: > >> >> >> On Thu, Jan 7, 2010 at 8:43 PM, Fady Samuel wrote: >> >>> Charles, I've read your paper and ultimately I think my goal may be >>> somewhere along the lines of making the DOM t

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

box is a better plan though since it's hard to predict when the feature will be complete and a user won't delete the --enable-webgl flag bug forget to delete the --disable-sandbox-until flag. > On Wed, Dec 30, 2009 at 3:56 PM, Jeremy Orlow wrote: > > On Wed, Dec 30, 2009 at 3:43

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

On Wed, Dec 30, 2009 at 3:43 PM, Peter Kasting wrote: > On Wed, Dec 30, 2009 at 3:22 PM, Jeremy Orlow wrote: > >> I just got back from vacation and would like to take action on this. I >> read through the thread, but I don't see any sort of consensus on what to >>

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

isabling --no-sandbox, but I'd like to >>> be more convinced of the arguments against it :) >>> >> >>> >>>> I think we should just add a modal dialog at startup that you must >>>> dismiss each time you launch Chrome until you remove the

Re: [chromium-dev] Re: [WebGL] Recommending --no-sandbox

On Fri, Dec 11, 2009 at 8:06 AM, Darin Fisher wrote: > I don't understand the argument for a periodic indicator. We don't have a > periodic indicator telling the user when to restart their browser to pick > up > auto-updates. > I don't think this is a fair comparison. One is a normal usage of

Re: [chromium-dev] Re: [WebGL] Recommending --no-sandbox

On Fri, Dec 11, 2009 at 1:10 AM, Kenneth Russell wrote: > (Resending from chromium.org) > > On Thu, Dec 10, 2009 at 8:22 PM, Darin Fisher wrote: > > After reading the WebGL blog post today, and following the link to the > wiki, > > it struck me as fairly *bad* that we are telling people to disab

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

True. But even if we disable the flags in stable builds, I'd still like to see some sort of warning UI. On Thu, Dec 10, 2009 at 11:02 PM, John Abd-El-Malek wrote: > > > On Thu, Dec 10, 2009 at 10:57 PM, Jeremy Orlow wrote: > >> On Thu, Dec 10, 2009 at 10:25 PM, Peter K

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

On Thu, Dec 10, 2009 at 10:25 PM, Peter Kasting wrote: > On Thu, Dec 10, 2009 at 9:38 PM, John Abd-El-Malek wrote: > >> We disable --single-process and --in-process-plugins on release Google >> Chrome builds to avoid the support headache that it causes. I think we >> should do the same for --no-

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

On Thu, Dec 10, 2009 at 9:29 PM, Jeremy Orlow wrote: > On Thu, Dec 10, 2009 at 8:22 PM, Darin Fisher wrote: > >> After reading the WebGL blog post today, and following the link to the >> wiki, it struck me as fairly *bad* that we are telling people to disable the >> sa

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

unter > argument that people should have to explicitly opt-in to disabling the > sandbox, but I'm not sure that out-weighs the cost of having a good number > of dev channel users running *permanently* without the sandbox. > > Was this idea considered? Any other ideas? > &

Re: [chromium-dev] Extensions and the Mac

Much of what can't be done on the web platform also can't be done inside the NaCl sandbox. On Thu, Dec 10, 2009 at 5:49 PM, John Abd-El-Malek wrote: > NaCl is the answer to all these problems... > > On Thu, Dec 10, 2009 at 5:15 PM, Jeremy Orlow wrote: > >> Or rej

Re: [chromium-dev] Extensions and the Mac

Or reject extensions that could be written without a NPAPI component. *ducks* On Thu, Dec 10, 2009 at 5:12 PM, Peter Kasting wrote: > On Thu, Dec 10, 2009 at 5:02 PM, Avi Drissman wrote: > >> Q: Can't we have the extensions gallery warn that it won't work? >> A: Sorry, we can't do that in an a

Re: [chromium-dev] Reflecting SSL state in a world with SharedWorkers and cross-window sharing/x-domain messaging

Personally, I feel the opposite, and I'm not sure the "perfect is the enemy of good" analogy doesn't really fit. If we erode the meaning of the secure (as opposed to mixed) content icon, it seems like we're just going to need to create UI in the future that says "this is really super secure". I d

Re: [chromium-dev] Re: Chromium Tech Talks

Personally, I really like the tech talk format as an introduction to a topic, but you're right that some would prefer something in written form and that a Wiki has many benefits that a video does not have. If you're willing to transcribe the information, I'm sure it would help others. On Wed, Dec

[chromium-dev] Re: Chromium Tech Talks

On Tue, Dec 8, 2009 at 11:25 AM, Jeremy Orlow wrote: > Last Friday we recorded 4 tech talks based on the feedback we got on what > topics would be interestingand here they are! > > http://www.youtube.com/watch?v=JFzC_Gx76E8 > Darin Fisher talks about the recently upstreamed

[chromium-dev] Re: Chromium Tech Talks

On Tue, Dec 8, 2009 at 11:25 AM, Jeremy Orlow wrote: > Last Friday we recorded 4 tech talks based on the feedback we got on what > topics would be interestingand here they are! > > http://www.youtube.com/watch?v=JFzC_Gx76E8 > Darin Fisher talks about the recently upstreamed

[chromium-dev] Chromium Tech Talks

Last Friday we recorded 4 tech talks based on the feedback we got on what topics would be interestingand here they are! http://www.youtube.com/watch?v=JFzC_Gx76E8 Darin Fisher talks about the recently upstreamed Chromium WebKit API. http://www.youtube.com/watch?v=bO3XEBuIDns Pam Greene talks

Re: [chromium-dev] Need a linux-views build buddy.

Isn't "gcl try -b linux_view" what you want? On Thu, Dec 3, 2009 at 1:46 PM, Mike Pinkerton wrote: > I've got a cl that builds fine on win/mac/linux but I'm afraid I could > impact views_linux. And, since there's no trybot, I have no way of > knowing until I actually check in and break it. > > T

Re: [chromium-dev] Compiler version used for official Windows builds?

On Wed, Nov 25, 2009 at 7:22 AM, Ted Mielczarek wrote: > Hi, > > I couldn't find this info anywhere on the dev site (maybe I just > wasn't looking hard enough), but I'm curious as to what version of > Visual C++ you're using for the official Chrome builds. We're still > using VC2005 for our Firefo

Re: [chromium-dev] Beginning with development

l be able to > download the already built libraries (by the builbots) corresponding to the > revision you're syncing. > > With this, a full initial checkout will produce a structure where you only > need to rebuild the modules you've changed their sourcecode to get the final &

[chromium-dev] Re: OWP feature owners: Please update the OWP roadmap.

one of the reasons this list is so incomplete). On Thu, Nov 12, 2009 at 12:56 PM, Jeremy Orlow wrote: > Things here have gotten a little stale: > http://dev.chromium.org/developers/web-platform-status Can everyone > working on OWP features please take a look and make sure what's writt

Re: [chromium-dev] Re: [chromium-extensions] openDatabase() maximum size

Bugged: http://code.google.com/p/chromium/issues/detail?id=27688 On Fri, Nov 13, 2009 at 2:30 PM, Marcos Aruj wrote: > It would be nice also for the user to know how much space an extension is > using. Like it is for memory usage right now. > > On Fri, Nov 13, 2009 at 3:28 PM,

Re: [chromium-dev] More sheriffs?

On Fri, Nov 13, 2009 at 3:38 PM, Peter Kasting wrote: > On Fri, Nov 13, 2009 at 2:56 PM, Dirk Pranke wrote: > >> I think two sheriffs in US/Pacific during US/Pacific work hours is >> plenty. >> > > I was told at lunch that we already try to some degree to schedule PST with > non-PST people (alth

Re: sheriff's keep the tree *open* WAS: [chromium-dev] More sheriffs?

+1 (for what it's worth) On Fri, Nov 13, 2009 at 2:28 PM, Ojan Vafai wrote: > On Fri, Nov 13, 2009 at 1:25 PM, Peter Kasting wrote: > >> On Fri, Nov 13, 2009 at 1:15 PM, Finnur Thorarinsson >> wrote: >> >>> If the sheriff load is too much for two people to devote 100% of their >>> time to, then

Re: [chromium-dev] Re: More sheriffs?

Maybe we should say at least one PST and at least one non-Americas? Note that even if people outside of the Americas are getting sheriff duty more often, the duty is lighter weight...so I think it balances out fairly well. As we get more non-Americas committers, we can think about adding another.

Re: [chromium-dev] Re: [chromium-extensions] openDatabase() maximum size

On Fri, Nov 13, 2009 at 1:21 PM, Aaron Boodman wrote: > On Fri, Nov 13, 2009 at 1:07 PM, Jeremy Orlow wrote: > > Just for the record, you're also the one who originally said it was fine > to > > limit them to 5mb (for LocalStorage anyhow). :-) > > It is a consisten

Re: [chromium-dev] Re: [chromium-extensions] openDatabase() maximum size

Just for the record, you're also the one who originally said it was fine to limit them to 5mb (for LocalStorage anyhow). :-) What kind of extra space did you have in mind? Unlimited? It's pretty late in the game to be making a decision like this for mstone-4, but it might be possible if this wa

Re: [chromium-dev] More sheriffs?

For a while now, I've advocated having 2 pacific timezone sheriffs always on duty and having one or two in other time zones. I still advocate such an idea. So, to be clear, I think this is a good idea as long as the distribution of sheriffs (time zone wise) is deliberate. (I think this addresses

Re: [chromium-dev] Any interest in command line tools for network stack?

What's the intended purpose of such tools? Do they offer any functionality beyond the standard tools? Do you envision them being helpful to people debugging the Chromium network stack? (Me replying does in no way imply that I have the authority to say yes or no, btw. :-) On Fri, Nov 13, 2009 a

Re: [chromium-dev] WebKit Windows try server?

re we can put them to work within a week. > > Adam > > > On Thu, Nov 12, 2009 at 1:54 PM, Marc-Antoine Ruel > wrote: > > To be clear, I have ~10 mac minis dying in a closet waiting for jobs. > > > > On Thu, Nov 12, 2009 at 4:52 PM, Jeremy Orlow wrote:

Re: [chromium-dev] WebKit Windows try server?

On Thu, Nov 12, 2009 at 1:50 PM, Adam Barth wrote: > On Thu, Nov 12, 2009 at 1:46 PM, Jeremy Orlow wrote: > > Btw, there's a webkit-dev thread out there right now about adding try > > servers. I don't think anyone's figured out where the hardware will come >

Re: [chromium-dev] WebKit Windows try server?

On Thu, Nov 12, 2009 at 1:46 PM, Peter Kasting wrote: > On Thu, Nov 12, 2009 at 1:43 PM, Nicolas Sylvain wrote: > >> On Thu, Nov 12, 2009 at 1:30 PM, Peter Kasting wrote: >> >>> I'm wondering if this is any more doable today than it was last time I >>> asked. Ojan reminded me that he has a numbe

Re: [chromium-dev] WebKit Windows try server?

On Thu, Nov 12, 2009 at 1:30 PM, Peter Kasting wrote: > A while ago I asked about the feasibility of setting up a WebKit Windows > try server. I seem to recall maruel mentioning that he didn't know it was > an interesting case and he'd look into it; and I know in general that we've > been resour

[chromium-dev] OWP feature owners: Please update the OWP roadmap.

Things here have gotten a little stale: http://dev.chromium.org/developers/web-platform-status Can everyone working on OWP features please take a look and make sure what's written there syncs up with reality? To edit: Scroll to the bottom, click sign in, sign in, then click "edit page" at the top

Re: [chromium-dev] Re: Tech talk topics

> > > > +1 for WebKit painting. > > > > On Nov 11, 2:24 pm, Peter Kasting wrote: > > > > > > > > > On Wed, Nov 11, 2009 at 11:20 AM, Jeremy Orlow > wrote: > > > > I think there's some painting stuff touched on in the first round

Re: [chromium-dev] Re: Tech talk topics

ia implementation. What is required for a GraphicsContext > port? What is the bottleneck in the paint process (e.g. the Skia blit ops)? > > 2009/11/5 Jeremy Orlow > > Thanks for the suggestions so far! Here's what I've seen so far: >> WebKit API - Darin? >> Eric&#

Re: [chromium-dev] Beginning with development

On Tue, Nov 10, 2009 at 2:31 PM, Roberto Perez wrote: > As Phistuck said, modifying gclient config file and then skipping the > changes of the modules that you're not working on seems a good solution to > prevent continuous rebuildings of other modules. > > But this doesn't skip the first large b

[chromium-dev] Local Storage directory moved as of rev 31584

*If you don't use extensions that use Local Storage or you only use the official Google Chrome builds, you can probably ignore this. (Local Storage was only enabled by default as of last Friday.)* As of svn rev 31584, local storage f

[chromium-dev] Re: 437k files checked out for an official build

This is related to the thread (last Friday?) about making a light weight checkout of Chromium the default. Btw a quick look indicates that 100k are Google specific files (hermetic build environment and such). 200k are layout tests. So that leaves "only" 150k filesprobably many of which are s

[chromium-dev] Re: Tech talk topics

tAPI infrastructure >> that darin organized. >> >> - Mohamed Mansour >> >> >> On Thu, Nov 5, 2009 at 5:17 PM, Scott Violet wrote: >> >>> >>> It's not Chromium, but how about some WebKit tech talks? Such talks >>> would be incredi

[chromium-dev] Re: The future for test shell (WAS: test_shell performance is bad compared to Chromium)

On Thu, Nov 5, 2009 at 3:01 PM, Jeremy Orlow wrote: > On Thu, Nov 5, 2009 at 2:46 PM, Dirk Pranke wrote: > >> >> On Thu, Nov 5, 2009 at 1:59 PM, Marshall Greenblatt >> wrote: >> > >> > On Thu, Nov 5, 2009 at 4:32 PM, Dirk Pranke >> wrote: >&

[chromium-dev] Re: Tech talk topics

wrote: > >> >> A general big picture talk would be a great starter. How the DOM is >> modeled, how the render tree works, the interesting objects ... >> >> -Scott >> >> On Thu, Nov 5, 2009 at 2:22 PM, Jeremy Orlow wrote: >> > Sure...we def

[chromium-dev] The future for test shell (WAS: test_shell performance is bad compared to Chromium)

On Thu, Nov 5, 2009 at 2:46 PM, Dirk Pranke wrote: > > On Thu, Nov 5, 2009 at 1:59 PM, Marshall Greenblatt > wrote: > > > > On Thu, Nov 5, 2009 at 4:32 PM, Dirk Pranke > wrote: > >> > >> test_shell being a test shell used mostly for non-interactive testing, > >> we haven't given a lot of concer

[chromium-dev] Re: Changes to using threads in the browser process

On Thu, Nov 5, 2009 at 2:01 PM, John Abd-El-Malek wrote: > > > On Thu, Nov 5, 2009 at 1:42 PM, Jeremy Orlow wrote: > >> On Thu, Nov 5, 2009 at 1:34 PM, John Abd-El-Malek wrote: >> >>> >>> >>> On Thu, Nov 5, 2009 at 1:15 PM, Jeremy Orlow wrote

[chromium-dev] Re: Tech talk topics

ow about some WebKit tech talks? Such talks > would be incredibly valuable to those helping out now and then with > WebKit. > > -Scott > > On Thu, Nov 5, 2009 at 1:35 PM, Jeremy Orlow wrote: > > About 6 months ago, we had a series of tech talks on various bits of > >

[chromium-dev] Re: Changes to using threads in the browser process

On Thu, Nov 5, 2009 at 1:34 PM, John Abd-El-Malek wrote: > > > On Thu, Nov 5, 2009 at 1:15 PM, Jeremy Orlow wrote: > >> On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek wrote: >> >>> Over the last week, I've been making some changes to how threads are use

[chromium-dev] Tech talk topics

About 6 months ago, we had a series of tech talks on various bits of Chromium's architecture. (They're listed here: http://dev.chromium.org/developers/tech-talk-videos) The youtube ratings are pretty high, they've all had over a thousand views, and I've seen them mentioned in a couple chromium-de

[chromium-dev] Re: Changes to using threads in the browser process

On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek wrote: > Over the last week, I've been making some changes to how threads are used > in the browser process, with the goal of simplifying cross-thread access and > improving stability. > > *The problem* > We were using a number of patterns that we

[chromium-dev] Re: Large commit - update your .gclient files to avoid

I started a new thread about a lite version of the checkout. Might be good to move discussion there. On Thu, Nov 5, 2009 at 12:44 PM, Scott Hess wrote: > On Thu, Nov 5, 2009 at 1:33 PM, Antoine Labour wrote: > > On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) > wrote: > >> it'd be nice

[chromium-dev] Lean Chromium checkout (WAS: Large commit - update your .gclient files to avoid)

On Thu, Nov 5, 2009 at 12:33 PM, Antoine Labour wrote: > > > On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) > wrote: > >> >> it'd be nice to have a gclient config lean or something like that. >> > > It'd be nice for it to be the default in fact. > I know we've avoided this in the past be

[chromium-dev] Re: Large commit - update your .gclient files to avoid

In general, it might be interesting to document how to get a more lean checkout of Chromium. On Thu, Nov 5, 2009 at 11:34 AM, Adam Barth wrote: > > Can we note this on dev.chromium.org somewhere? > > Adam > > > On Thu, Nov 5, 2009 at 11:16 AM, Steve VanDeBogart > wrote: > > This afternoon I wil

[chromium-dev] Re: Webkit Gyp Changes

Is it possible to name these differently? Especially when editing in xcode it can be kind of annoying having multiple project files named the same thing. On Tue, Nov 3, 2009 at 2:40 PM, Yaar Schnitman wrote: > A few changes have been made around the webkit.gyp in our ongoing effort to > upstrea

[chromium-dev] Re: Why is Linux Chrome so fast?

Ha. http://tech.slashdot.org/story/09/11/03/1334203/X11-Chrome-Reportedly-Outperforms-Windows-and-Mac-Versions On Fri, Oct 30, 2009 at 9:44 AM, Linus Upson wrote: > scrolling jank in gmail > http://crbug.com/25741 > > Linus > > > On Wed, Oct 28, 2009 at 12:05 PM, Adam Barth wrote: > >> >> On We

[chromium-dev] Re: Which editor do you recommend on Mac OS X?

On Tue, Nov 3, 2009 at 10:12 AM, Paweł Hajdan Jr. wrote: > On Tue, Nov 3, 2009 at 19:08, Drew Wilson wrote: > >> I've also been known to use the built-in GNU emacs from a terminal shell >> (especially when working remotely/SSH-ing). I see no reason why you can't >> have the same experience that y

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

d was really surprised that I couldn't find any mention of such a thing. On Fri, Oct 30, 2009 at 3:12 PM, Jeremy Orlow wrote: > > I've spent a good deal of this week trying to track down what turned out > to > > be a simple but fairly common problem: I forgot virtual di

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

On Fri, Oct 30, 2009 at 3:17 PM, Antoine Labour wrote: > On Fri, Oct 30, 2009 at 3:12 PM, Jeremy Orlow wrote: > >> I've spent a good deal of this week trying to track down what turned out >> to be a simple but fairly common problem: I forgot virtual dispatch onl

[chromium-dev] PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

I've spent a good deal of this week trying to track down what turned out to be a simple but fairly common problem: I forgot virtual dispatch only partially works in destructors. There have been several email threads about this, but it still bites us form time to time, so I thought it was worth ano

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

>From http://dev.chromium.org/developers/how-tos/build-instructions-windows Ensure that /MP is enabled. You can do this by creating a file called inc lude.gypi which contains the following lines: { 'variables': { 'msvs_multi_core_compile': 1 } } Put this file in a folder c

[chromium-dev] Re: [Green Tree] Task Force Status Update 10/26

On Tue, Oct 27, 2009 at 11:37 PM, Paweł Hajdan Jr. wrote: > On Wed, Oct 28, 2009 at 00:44, Ian Fette wrote: > >> In an effort to provide more transparency into what the team is working >> on, I'm sending out the meeting notes from the green tree task force to >> chromium-dev, below. I will try to

[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

I'll follow up with the NaCl team to make sure they are. On Wed, Oct 21, 2009 at 11:57 AM, John Grabowski wrote: > > > On Wed, Oct 21, 2009 at 11:37 AM, Jeremy Orlow wrote: > >> Why did you use the "internal nacl mailing list"? > > > To keep things unam

[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

Why did you use the "internal nacl mailing list"? This is an issue that affects all of Chromium. The NaCl team members are on chromium-dev, right? If not, they should have been the day that our fates became intertwined. J On Tue, Oct 20, 2009 at 12:17 PM, John Grabowski wrote: > I sent mail t

[chromium-dev] Re: WebKit API wrapper for Document

Darin knows for sure, but I'm not aware of any intentions on Google's part to engineer such an elaborate API. As long as it didn't add a major maintenance burden (i.e. exposed things similar to one of the other WebKit APIs) I'd imagine patches would be welcome though. I believe only Darin can spea

[chromium-dev] Re: Crashing layout tests

> > sure not everyone checks that every time they start gardening. > > dave > > On Tue, Oct 20, 2009 at 10:25 AM, Jeremy Orlow > wrote: > >> > >> On Tue, Oct 20, 2009 at 10:19 AM, David Levin wrote: > >>> > >>> That sounds like a reas

[chromium-dev] Re: Crashing layout tests

ost sense. And, when there's no obvious candidate, they can draft someone. (In general, I think we should empower gardeners to draft people when there are lots of high prioirity items stacking up and/or we get really behind ToT.) On Tue, Oct 20, 2009 at 9:23 AM, Jeremy Orlow wrote: &g

[chromium-dev] Crashing layout tests

Today I noticed a bunch of recently added CRASH test expectations for layout tests. I know that we sometimes have to roll in a crasher or two, but aren't we supposed to be filing p0-p1, dev channel release blockers at least until we can prove the crash is not exploitable in the browser and ideally

[chromium-dev] Re: LTTF helping the GTTF make cycle times *minutes* faster

On Fri, Oct 16, 2009 at 2:34 PM, Ojan Vafai wrote: > Thanks for everyone's help. Good overnight progress. 6 media tests skipped. > 2 tests marked SLOW. 5 assigned. > > 12 unassigned general tests. > 10 unassigned Mac plugin tests. > > Any takers? > > WIN/LINUX/MAC > LayoutTests/fast/dom/cssTarget

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

On Thu, Oct 15, 2009 at 12:17 PM, Michael Nordman wrote: > > > On Thu, Oct 15, 2009 at 12:16 PM, Michael Nordman wrote: > >> >> >> On Thu, Oct 15, 2009 at 11:45 AM, Jeremy Orlow wrote: >> >>> On Thu, Oct 15, 2009 at 11:33 AM, Michael Nordman >>

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

On Thu, Oct 15, 2009 at 11:33 AM, Michael Nordman wrote: > > > On Wed, Oct 14, 2009 at 4:42 PM, Darin Fisher wrote: > >> On Wed, Oct 14, 2009 at 3:50 PM, Adam Barth wrote: >> >>> On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman >>> wrote: >>> > As mentioned f2f, this falls apart as soon as Chro

[chromium-dev] Re: Canary bot, now with formatted layout test results

Christmas came early for anyone working on WebKit! Thanks Glen. :-) On Thu, Oct 15, 2009 at 9:17 AM, Erik Corry wrote: > > This makes me very happy! > > 2009/10/15 Glenn Wilson : > > Hi Webkit gardeners, > > The Windows canary bot now generates formatted layout test results on > each > > build

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

009 at 12:19 AM, Darin Fisher wrote: > On Wed, Oct 14, 2009 at 7:17 PM, Jeremy Orlow wrote: > >> I think the main points of contention regarding SecurityOrigin::toString() >> are the name "toString" and what type it should return. >> >> In terms of the nam

[chromium-dev] Re: When disabling a test, please assign to whoever wrote it

This is still happening. VERY annoying. ANYONE who is disabling tests, marking them flaky, etc needs to take the 30 seconds required to svn blame the file and cc people the relevant people. On Tue, Sep 22, 2009 at 2:33 PM, Aaron Boodman wrote: > > Seriously. In a project as big as Chrome, test

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

e between toString and a single getter that returns a string is subtle, but if all WebKit types follow this same convention, then it's much less likely that people will do stupid things with them. J On Wed, Oct 14, 2009 at 5:15 PM, Darin Fisher wrote: > On Wed, Oct 14, 2009 at 4:51

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

in the WebKit API use WebSecurityOrigin, then developers >> will be >> naturally inclined to convert between SecurityOrigin and >> WebSecurityOrigin, >> ignoring the toString() getter on WebSecurityOrigin. >> >> This is a case where existing code should help guide people in th

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

If this is the case, then I don't think a SecurityOrigin wrapper buys us anything. Never mind. On Wed, Oct 14, 2009 at 4:37 PM, Darin Fisher wrote: > > > On Wed, Oct 14, 2009 at 3:59 PM, Jeremy Orlow wrote: > >> On Wed, Oct 14, 2009 at 2:48 PM, Darin Fisher wrote: >

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

On Wed, Oct 14, 2009 at 4:32 PM, Michael Nordman wrote: > > > On Wed, Oct 14, 2009 at 4:03 PM, Jeremy Orlow wrote: > >> On Wed, Oct 14, 2009 at 3:58 PM, Dumitru Daniliuc wrote: >> >>> >>> >>> On Wed, Oct 14, 2009 at 2:47 PM, Darin Fisher wrot

[chromium-dev] Re: layout test dashboard goofup

x27;ve got a volunteer! :D :D :D > > On Wed, Oct 14, 2009 at 4:15 PM, Jeremy Orlow wrote: > > I assume we're going to start backing this data up from now on? > > > > On Wed, Oct 14, 2009 at 4:13 PM, Peter Kasting > wrote: > >> > >> On Wed, Oct 14,

[chromium-dev] Re: layout test dashboard goofup

I assume we're going to start backing this data up from now on? On Wed, Oct 14, 2009 at 4:13 PM, Peter Kasting wrote: > On Wed, Oct 14, 2009 at 3:58 PM, Ojan Vafai wrote: > >> I accidentally checked in some test code (one number was wrong!) and >> clobbered all but 10 of the runs of data for ea

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman wrote: > > > On Wed, Oct 14, 2009 at 2:08 PM, Jeremy Orlow wrote: > >> On Wed, Oct 14, 2009 at 2:00 PM, Michael Nordman wrote: >> >>> +1 SecurityOrigin class >>> Sounds like a reasonable plan. >>&g

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

On Wed, Oct 14, 2009 at 3:58 PM, Dumitru Daniliuc wrote: > > > On Wed, Oct 14, 2009 at 2:47 PM, Darin Fisher wrote: > >> On Wed, Oct 14, 2009 at 2:30 PM, Jeremy Orlow wrote: >> >>> On Wed, Oct 14, 2009 at 2:23 PM, Darin Fisher wrote: >>> >>>&g

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

On Wed, Oct 14, 2009 at 2:48 PM, Darin Fisher wrote: > On Wed, Oct 14, 2009 at 2:47 PM, Darin Fisher wrote: > >> On Wed, Oct 14, 2009 at 2:30 PM, Jeremy Orlow wrote: >> >>> On Wed, Oct 14, 2009 at 2:23 PM, Darin Fisher wrote: >>> >>>> On

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

On Wed, Oct 14, 2009 at 3:50 PM, Adam Barth wrote: > On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman > wrote: > > As mentioned f2f, this falls apart as soon as Chrome tries to manufacture > a > > security origin. I'm not sure, may already have instances of that in the > > code base for all I kn

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

On Wed, Oct 14, 2009 at 2:23 PM, Darin Fisher wrote: > On Wed, Oct 14, 2009 at 2:08 PM, Jeremy Orlow wrote: > >> On Wed, Oct 14, 2009 at 2:00 PM, Michael Nordman wrote: >> >>> +1 SecurityOrigin class >>> Sounds like a reasonable plan. >>> I s

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

s it coming from WebKit::WebSecurityOrigin (which only comes from WebCore::WebSecurityOrigin). We can then deal with these details only if/when we need to. On Wed, Oct 14, 2009 at 1:36 PM, Jeremy Orlow wrote: > >> Right now, we don't have a good story for what to do with >> WebCore::S

[chromium-dev] Is it time to create a SecurityOrigin class in Chromium?

Right now, we don't have a good story for what to do with WebCore::SecurityOrigins in Chromium. We now have a WebSecurityOrigin in WebKit, but if you want to move the data between processes, you need to convert it to a string and then send that. In some cases we then convert the string to a GURL,

[chromium-dev] Re: [LTTF][WebKit Gardening]: Keeping up with the weeds.

On Tue, Oct 13, 2009 at 10:31 AM, Dimitri Glazkov wrote: > > I think we need to change something. I am not sure what -- I have > ideas, but -- I would appreciate some collective thinking on this. > > PROBLEM: We accumulate more test failures via WebKit rolls than we fix > with our LTTF effort. Thi

[chromium-dev] Re: Please confirm the bug (some bitmaps aren/t displayed)

I think the bigger issue is how/when Area-Misc bugs get triaged. Do they ever? If not, we should probably change that. On Mon, Oct 12, 2009 at 11:50 AM, Guria wrote: > > Please confirm the bug > http://code.google.com/p/chromium/issues/detail?id=12900 > It really annoys me. > I expect that som

[chromium-dev] Re: Buildbot upgrade

Is there documentation anywhere for all the parameters you can feed into the buildbot webpage? If not, a cheat sheet would be really helpful. On Sat, Oct 10, 2009 at 6:25 PM, Nicolas Sylvain wrote: > Hello, > Today I upgraded buildbot to the latest version. > > If you have a bookmark for the "fa

[chromium-dev] Re: Friendly reminder: don't let changes rot

Part of this has to do with your level of experience and how big the review is. Doing code reviews for people not yet up to speed is _painful_. And large reviews also can be. I think part of the reason things seem better to you is a reflection on your level of experience. That said, some of us

[chromium-dev] Re: detecting tabs using a lot of CPU?

Pawel, I was responding to the idea of suspending a tab. I agree that exposing this information to extensions wouldn't be too hard and could be quite useful. On Wed, Oct 7, 2009 at 12:37 PM, Charles Reis wrote: > > > On Wed, Oct 7, 2009 at 12:25 PM, Jeremy Orlow wrote: >

  1   2   3   4   >