Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656

2010-01-21 Thread Marc-Antoine Ruel
With regards to BookmarkContextMenuTest.DeleteURL, I filed http://crbug.com/32784. Glen, you should make sure this bug is triaged accordingly since flaky crashers can't be tolerated. M-A On Thu, Jan 21, 2010 at 9:45 AM, Marc-Antoine Ruel wrote: > Clobber Done. > > > On Thu,

Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656

2010-01-21 Thread Marc-Antoine Ruel
1, 2010 at 9:36 AM, Marc-Antoine Ruel wrote: > >> [+chromium-dev and sheriffs] >> >> These are flaky tests. >> >> It is disturbing since there is a crash in a really "normal" UI workflow >> (bookmarks) >> >> Whoever knows about these test

[chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656

2010-01-21 Thread Marc-Antoine Ruel
[+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really "normal" UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last one since it's a crasher): - DownloadManagerTest.TestDo

[chromium-dev] Build exceptions

2010-01-08 Thread Marc-Antoine Ruel
Don't panic with the main waterfal, it's just a hotpatch to fix an exception that ... generated more exceptions. At least, the original exception is fixed. So I'll just restart the master to make sure nothing dangling is left. M-A -- Chromium Developers mailing list: chromium-dev@googlegroups.co

Re: [chromium-dev] Missing symbols for Chrome 3.0.195.38

2010-01-04 Thread Marc-Antoine Ruel
FYI, the symbols were added on Dec 30. http://build.chromium.org/buildbot/symbols/3.0.195.38/chrome_dll.pdb http://build.chromium.org/buildbot/symsrv/chrome_dll.pdb/A94BABB37F7A4445A7A2C7BC2B796FD81/chrome_dll.pdb M-A On Tue, Dec 29, 2009 at 10:14 PM, yuhong wrote: > BTW, consider compressing s

Re: [chromium-dev] chromium for arm can not play html5 video

2009-12-22 Thread Marc-Antoine Ruel
[bcc chromium-dev] User questions are best sent to chromium-disc...@googlegroups.com. chromium-dev@ is for engineering questions. The continuous Chromium builds don't have h.264 support. M-A On Tue, Dec 22, 2009 at 6:13 AM, Richard Zhao wrote: > I download > http://build.chromium.org/buildbot

Re: [chromium-dev] How to deal with flaky unit tests

2009-12-18 Thread Marc-Antoine Ruel
http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/scripts/master/log_parser/gtest_command.py?revision=28463&view=markup has some logic for that but doesn't seem to work anymore. Nicolas is on vacation, I'll take a look soon: http://crbug.com/30599 M-A On Fri, Dec 18, 2009 at 1:47 AM, Paw

Re: [chromium-dev] Trybot to run WebKit's LayoutTests?

2009-12-17 Thread Marc-Antoine Ruel
1. Install VS2005 Pro or better. or 2. Yes there is a wekbit try server but it cannot be triggered outside Google yet. Check your emails. http://build.chromium.org/buildbot/webkit-try/waterfall M-A On Thu, Dec 17, 2009 at 1:09 PM, Dominic Mazzoni wrote: > That's what I was afraid of. > > On Th

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-16 Thread Marc-Antoine Ruel
Thanks Lei for fixing everything! M-A On Wed, Dec 16, 2009 at 12:42 AM, Lei Zhang wrote: > I also needed to install libpam0g-dev. Linux_view try bots should be happy > now. > > On Tue, Dec 15, 2009 at 7:03 PM, Lei Zhang wrote: >> It'll reload the try server configuration so try jobs will pull

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Marc-Antoine Ruel
This lame email was a courtesy of Nexus One. So if you have time, good ahead otherwise I'll take care. > > On Dec 15, 2009 6:46 PM, "Mitsuru Oshima" wrote: > > satorux asked maruel t... - oshima On Tue, Dec 15, 2009 at 3:37 PM, Lei Zhang wrote: > > It has a custom .gcli... -- Chromium Develo

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Marc-Antoine Ruel
I've been offline most of the day. On Dec 15, 2009 6:46 PM, "Mitsuru Oshima" wrote: satorux asked maruel to fix it several hours ago. maruel? - oshima On Tue, Dec 15, 2009 at 3:37 PM, Lei Zhang wrote: > > It has a custom .gcli... -- Chromium Developers mailing list: chromium-dev@googlegroup

Re: [chromium-dev] Linux build bots

2009-12-11 Thread Marc-Antoine Ruel
I restarted the slaves. 2009/12/11 Hironori Bono (坊野 博典) > Greetings chromium-developers, sheriffs, and troopers, > > As you can see in our buildbot waterfall page, three build bots has > been stopping for a long time, "Chromium Linux", "Chromium Linux x64", > "Modules Linux" since I noticed the

Re: [chromium-dev] Thoughts on "// NOLINT"?

2009-12-10 Thread Marc-Antoine Ruel
On Thu, Dec 10, 2009 at 3:02 PM, Shall be Unnamed <@google.com> wrote: > On Thu, Dec 10, 2009 at 2:29 PM, Marc-Antoine Ruel wrote: > >> On Thu, Dec 10, 2009 at 2:24 PM, Peter Kasting >> wrote: >> >> On Thu, Dec 10, 2009 at 11:20 AM, Jacob Mandelson >&g

Re: [chromium-dev] Thoughts on "// NOLINT"?

2009-12-10 Thread Marc-Antoine Ruel
On Thu, Dec 10, 2009 at 2:24 PM, Peter Kasting wrote: > On Thu, Dec 10, 2009 at 11:20 AM, Jacob Mandelson > wrote: > >> If something extra in an expression is a common case, I've sometimes >> seen it done like: >>return DoWork(&foo) POSIX_ONLY(&& DoWork(&posix_specific)); >> where POSIX_ONL

Re: [chromium-dev] Embedding Chromium

2009-12-10 Thread Marc-Antoine Ruel
http://code.google.com/p/chromiumembedded/. Marshall would probably appreciate to have some help. On Thu, Dec 10, 2009 at 12:43 PM, hap 497 wrote: > Hi, > > Is it possible to embed a chromium in my c/c++ application? (just like > someone embed a Webkit rendering engine in his application). I >

Re: [chromium-dev] Modifying .gyp files

2009-12-10 Thread Marc-Antoine Ruel
  to run the command. If the list contains string >> "$matching_files" >>               it will be removed from the list and the list will be >> extended >>               by the list of matching files. >> >>  Example: >>    hooks = [ >>      { &q

Re: [chromium-dev] Modifying .gyp files

2009-12-09 Thread Marc-Antoine Ruel
Humm, that's a good question. Right now the only doc is gclient help runhooks which is .. uh .. not really useful. M-A On Wed, Dec 9, 2009 at 3:28 PM, Igor Gatis wrote: > Is there documentation somewhere regarding gclient? I'd like to know more > about how hooks and other gclient features work.

Re: [chromium-dev] Tryconsole

2009-12-08 Thread Marc-Antoine Ruel
pplication/json On Tue, Dec 8, 2009 at 4:22 PM, Marc-Antoine Ruel wrote: > On Tue, Dec 8, 2009 at 4:13 PM, Evan Martin wrote: >> On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson >> wrote: >>> I've got a prototype summary view of the trybots up >>> at http

Re: [chromium-dev] Tryconsole

2009-12-08 Thread Marc-Antoine Ruel
On Tue, Dec 8, 2009 at 4:13 PM, Evan Martin wrote: > On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson wrote: >> I've got a prototype summary view of the trybots up >> at http://tryconsole.appspot.com/ >> This will let you monitor/find your try jobs without digging through the >> waterfall. >> The

Re: [chromium-dev] Where buildbot outputs the intermediate builds?

2009-12-01 Thread Marc-Antoine Ruel
I had intention in archiving the intermediate build outputs in a shallow git repo for try server speedup but I have no intention in publishing this repo externally. I would recommend you to checkout the buildbot code and setup a local continuous build yourself. Instructions: http://dev.chromium.or

Re: [chromium-dev] Re: Never build chromium by Visual Studio 2008 + SP1

2009-12-01 Thread Marc-Antoine Ruel
Thanks for the notice but we have good performance regression testing. Also, the official builds don't use /O2. Only the continuous build uses /O2. IIRC, VS2008 RTM cannot be used to build Chromium. M-A On Tue, Dec 1, 2009 at 4:54 AM, avcoder wrote: > Sorry: > > .I can only get about 34xx sco

Re: [chromium-dev] Compiler version used for official Windows builds?

2009-11-30 Thread Marc-Antoine Ruel
On Mon, Nov 30, 2009 at 4:48 PM, Ted Mielczarek wrote: > On Wed, Nov 25, 2009 at 7:42 PM, Wan-Teh Chang wrote: > >> (The official build does whole program optimization and must be >> done on a 64-bit Windows machine with lots of memory.) >> >> > Thanks for the info. That's odd, since our PGO buil

Re: [chromium-dev] Compiler version used for official Windows builds?

2009-11-25 Thread Marc-Antoine Ruel
On Wed, Nov 25, 2009 at 7:42 PM, Wan-Teh Chang wrote: > On Wed, Nov 25, 2009 at 4:22 AM, Ted Mielczarek > wrote: >> Hi, >> >> I couldn't find this info anywhere on the dev site (maybe I just >> wasn't looking hard enough), but I'm curious as to what version of >> Visual C++ you're using for the o

Re: [chromium-dev] How do I generate an msvs_guid for the GYP file?

2009-11-24 Thread Marc-Antoine Ruel
AFAIK, you don't need one, it was mainly for the transition period. Brad, can we remove them all? On Tue, Nov 24, 2009 at 3:27 PM, Chris Bentzel wrote: > In http://codereview.chromium.org/428004, I introduced a new GYP target - > but don't have an msvs_guid for it. > > I'm guessing that I can j

Re: [chromium-dev] Xcode builds and dependencies

2009-11-24 Thread Marc-Antoine Ruel
You mean you implemented http://code.google.com/p/gyp/issues/detail?id=42 but for xcode only? On Tue, Nov 24, 2009 at 9:51 AM, Thomas Van Lenten wrote: > Last week Mark and I talked with someone in Apple's devtools team about > some of the dependency problems we've seen in our builds. We have a

Re: [chromium-dev] workflow for cross-platform development

2009-11-23 Thread Marc-Antoine Ruel
On Sat, Nov 21, 2009 at 1:52 PM, Chris Bentzel wrote: > Have there been any thoughts about adding gcl patch and unpatch commands > which will grab the file diffs as well as duplicate the CL metadata in > src/.svn/gcl_info? > There's the gcl metadata and the svn metadata. Webkit has a script to a

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-22 Thread Marc-Antoine Ruel
It's really about the unit tests, not in chromium. I guess we could probably leak the singleton in the unit tests too on each reset. Pawel, what do you think? Note to all the static local makers: you create an implicit atexit() each time... Use a leaky singleton instead. M-A On Sun, Nov 22, 200

Re: [chromium-dev] gcl upload error

2009-11-21 Thread Marc-Antoine Ruel
[+chromium-dev] One issue is that even a smoke test wouldn't have caught this problem since as I said, it was windows specific. Maybe it's time to create a try server for depot_tools. :/ M-A On Sat, Nov 21, 2009 at 5:23 PM, Marc-Antoine Ruel wrote: > I totally agree, I fully u

Re: [chromium-dev] gcl upload error

2009-11-21 Thread Marc-Antoine Ruel
Thanks, when I replied to Munjal, I only replied to him by error. So the fix is to run "gclient". M-A On Sat, Nov 21, 2009 at 2:56 PM, Munjal Doshi wrote: > Just in case anyone else hit this, it was fixed in 32748. > -Munjal > > On Sat, Nov 21, 2009 at 10:04 AM, Evan Martin wrote: >> >> A gues

Re: [chromium-dev] invalid literal for int() with base 10

2009-11-20 Thread Marc-Antoine Ruel
+msb but I think your depot_tools is old. Also your question is probably better directed at chromium-os-dev@ (well, next time) M-A On Fri, Nov 20, 2009 at 10:08 AM, Mr. Gecko wrote: > When syncing chromium with --deps="unix,chromeos", it gives me the > error below > Traceback (most recent cal

Re: [chromium-dev] support for WATCHLISTS in git-cl

2009-11-19 Thread Marc-Antoine Ruel
On Thu, Nov 19, 2009 at 4:46 PM, Evan Martin wrote: > On Thu, Nov 19, 2009 at 12:56 PM, Paweł Hajdan Jr. > wrote: >> It turns out that WATCHLISTS aren't fully effective because git-cl doesn't >> support them. It doesn't look very hard to implement the support for git-cl >> because there is alread

[chromium-dev] Re: New Presubmit actions

2009-11-18 Thread Marc-Antoine Ruel
First, I'd prefer to keep the presubmit checks from having any side-effect. For a) You haven't mentioned which editor you use but if it is a problem for you, maybe you should tweak the editor? VS, emacs, vim can be modified to do it or at least highlight it; I don't know about xcode. Otherwise a v

Re: [chromium-dev] Linting chrome/ in pre-submit checks

2009-11-17 Thread Marc-Antoine Ruel
To be clear, it'll be a warning prompt on commit, not an error. You can say (y)es to continue. M-A On Tue, Nov 17, 2009 at 2:16 PM, Elliot Glaysher (Chromium) wrote: > Chromium developers, > > I have just submitted a PRESUBMIT.py for chrome/ which will run > cpplint.py on your change as part of

Re: [chromium-dev] buildbot failure in Chromium on Mac10.5 Tests, revision 32176

2009-11-17 Thread Marc-Antoine Ruel
Glad to see you back, gatekeeper! chase++ On Tue, Nov 17, 2009 at 12:29 PM, wrote: > http://build.chromium.org/buildbot/waterfall/ > > Automatically closing tree for "unit_tests" on "Mac10.5 Tests" > > > http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/8528 > > Revi

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-16 Thread Marc-Antoine Ruel
p://cotsog.wordpress.com/2009/11/08/how-to-compile-google-chrome-with-visual-c-2008-express-edition/ >> >> -- Dominic. >> >> On Thu, Nov 12, 2009 at 7:51 PM, Bradley Nelson >> wrote: >> > Ok that fix is in. >> > You'd need to set GYP_MSVS_VERSION=2008

[chromium-dev] gcl misbehaving

2009-11-16 Thread Marc-Antoine Ruel
If gcl is misbehaving at home, please run "gclient" to update your depot_tools; it was broken this morning. M-A -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

Re: [chromium-dev] gclient failed to get the source

2009-11-16 Thread Marc-Antoine Ruel
I don't know where you put your depot_tools but I'd try to delete depot_tools\python.bat and try again. It seems like downloading the python zip failed. M-A On Sun, Nov 15, 2009 at 11:23 PM, Eduardo Maggio wrote: > Well, I'm not sure if it's the right place to post that, but anyway... > In orde

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-15 Thread Marc-Antoine Ruel
Fri, Nov 13, 2009 at 02:51, Bradley Nelson wrote: >>> >>> Ok that fix is in. >>> You'd need to set GYP_MSVS_VERSION=2008e >>> Let me know how that goes for you. >>> -BradN >>> >>> On Wed, Nov 11, 2009 at 12:50 PM, Marc-Antoine Ruel >&

Re: [chromium-dev] building without svg

2009-11-13 Thread Marc-Antoine Ruel
Dean had done one, at least on Windows, I don't recall offhand since it's been a while. On Fri, Nov 13, 2009 at 5:39 PM, Evan Martin wrote: > We track total binary size here: >  http://build.chromium.org/buildbot/perf/dashboard/sizes.html > > I don't know of any place we track per-module sizes. >

Re: [chromium-dev] Getting 'This is a read-only checkout' error from gcl

2009-11-13 Thread Marc-Antoine Ruel
Fixed, http://src.chromium.org/viewvc/chrome?view=rev&revision=31942 On Fri, Nov 13, 2009 at 3:51 PM, Dominic Mazzoni wrote: > I got the same error yesterday.  Note that I don't have write access, > so it's true that I do have a read-only checkout, but before, there > was no warning just to crea

Re: [chromium-dev] WebKit Windows try server?

2009-11-12 Thread Marc-Antoine Ruel
To be clear, I have ~10 mac minis dying in a closet waiting for jobs. On Thu, Nov 12, 2009 at 4:52 PM, Jeremy Orlow wrote: > On Thu, Nov 12, 2009 at 1:50 PM, Adam Barth wrote: >> >> On Thu, Nov 12, 2009 at 1:46 PM, Jeremy Orlow wrote: >> > Btw, there's a webkit-dev thread out there right now ab

Re: [chromium-dev] WebKit Windows try server?

2009-11-12 Thread Marc-Antoine Ruel
Wouha, let me reply! :) To clarify things, I already made an experimental webkit try server on the same host that the chromium try server master on a different port. The remaining blocking issue is the "revert" implementation. br...@apple told me he would look at the implementation but he hasn't y

Re: [chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-11-12 Thread Marc-Antoine Ruel
Ah, I always close it instinctively. :) /me who is always shocked by people keeping the two useless right-side box on their IDE, the server db and the toolbox. That's totally 16 pixels wasted. M-A On Wed, Nov 11, 2009 at 11:38 PM, Eric Roman wrote: > Yuck, I experienced the same gut-wrenchingly

Re: [chromium-dev] Re: [gyp-developer] Coping with configurations differences in sources

2009-11-11 Thread Marc-Antoine Ruel
On Tue, Nov 10, 2009 at 1:52 PM, Gregory Dardyk wrote: > We might build Chrome for 64-bit Windows in the future, but there are > several reasons why we would like to avoid porting all Chrome code to 64-bit > Windows now: > > We are now in the process of porting Native Client code that is 64-bit cl

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-11 Thread Marc-Antoine Ruel
Updated http://sites.google.com/a/chromium.org/dev/developers/how-tos/build-instructions-windows to reference your blog entry. I don't want to copy these instructions since it's too lengthy, inefficient and unsupported. I didn't realize one could download WDK 7 without needing a MSDN account. Th

Re: [chromium-dev] Beginning with development

2009-11-10 Thread Marc-Antoine Ruel
And you can use distcc. On Tue, Nov 10, 2009 at 1:21 PM, Paweł Hajdan jr wrote: > Note however that you can build specific projects. When working on base or > net for example, you can build just base_unittests and net_unittests. When > working on webkity things, you can sometimes compile just the

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread Marc-Antoine Ruel
On Tue, Nov 3, 2009 at 9:16 PM, John Abd-El-Malek wrote: > > > On Tue, Nov 3, 2009 at 6:08 PM, Ben Goodger (Google) wrote: > >> I am supportive of auto-revert as long as we apply it universally. So many >> times the tree has been busted forever because of a vacuum of action by the >> sheriff. >>

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Marc-Antoine Ruel
After thinking about it, just setting in Debugging properties: Command = c:\program files\Debugging Tools for Windows (x86)\windbg.exe Command Arguments = -o $(TargetPath) is way simpler, then you just use Ctrl-F5 to start debugging your app! M-A On Thu, Oct 29, 2009 at 10:50 PM, Marc-Antoine

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Marc-Antoine Ruel
Here are the fixes for your debugger sluggishness problems: Bind this macro to F7 http://code.google.com/p/chromium/wiki/WindowsVisualStudioMacros?ts=1256870705&updated=WindowsVisualStudioMacros#Only_build_startup_project and bind this macro to F5 http://code.google.com/p/chromium/wiki/WindowsVis

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Marc-Antoine Ruel
Not that it is effective :) On Wed, Oct 28, 2009 at 3:34 PM, Marc-Antoine Ruel wrote: > Have you tried starring http://crbug.com/22044 ? > > On Wed, Oct 28, 2009 at 3:28 PM, Albert J. Wong (王重傑) > wrote: >> If I'm not mistaken, I think like most everyone running on lin

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Marc-Antoine Ruel
Have you tried starring http://crbug.com/22044 ? On Wed, Oct 28, 2009 at 3:28 PM, Albert J. Wong (王重傑) wrote: > If I'm not mistaken, I think like most everyone running on linux is using > the make build nowadays, and the make build seems to work well enough for > most people.  The only time I he

[chromium-dev] Re: Reference build has been changed?

2009-10-28 Thread Marc-Antoine Ruel
FTR, you could have got the same info with: src\chrome\tools\test\reference_build\chrome>chrome about:version M-A On Wed, Oct 28, 2009 at 12:46 PM, Anton Muhin wrote: > > Thanks a lot, Tony. > > yours, > anton. > > On Wed, Oct 28, 2009 at 7:44 PM, Tony Chang wrote: >> From the svn log: >> r30

[chromium-dev] Re: Is there any plan to support Visual Studio 2010? (Current in Beta 2)

2009-10-28 Thread Marc-Antoine Ruel
bit in VS2010? In that case, the biggest > advantage may be to produce WPO builds on 64 bit machines. > > On Wed, Oct 28, 2009 at 7:50 AM, Marc-Antoine Ruel > wrote: >> >> [Subtly setting expectations here] >> >> Updated http://crbug.com/25628 accordingly. You hav

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Marc-Antoine Ruel
An additional note: Most Windows boxes have an AV installed while most linux boxes don't. Never underestimate the sluggishness of AVs. M-A On Wed, Oct 28, 2009 at 11:05 AM, Evan Martin wrote: > > On Tue, Oct 27, 2009 at 9:11 PM, Adam Barth wrote: >> My three laptops have relatively comparable

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread Marc-Antoine Ruel
On Wed, Oct 28, 2009 at 1:30 AM, Darin Fisher wrote: > I'm pretty sure that enabling USE_SYSTEM_MALLOC will also lead to corruption > since WebKit is not hermetic (we allocate things externally that we then > delete inside WebKit). > -Darin Wouha! That really limit our capacity to link wekbit.dl

[chromium-dev] Re: Is there any plan to support Visual Studio 2010? (Current in Beta 2)

2009-10-28 Thread Marc-Antoine Ruel
[Subtly setting expectations here] Updated http://crbug.com/25628 accordingly. You have your answer in this feature request and read my comment on it before adding any comment. (as in don't add any please) Feel free to star it though. But as a sane person, well, as sane as I can be, I can only

[chromium-dev] Re: Fun with timers! A horror story

2009-10-27 Thread Marc-Antoine Ruel
http://crbug.com/22926 You know the funny part? I had hacked that exact thing (in ChromiumCurrentTime.cpp) locally during work on this bug. M-A On Tue, Oct 27, 2009 at 9:53 PM, Albert J. Wong (王重傑) wrote: > Would a hack like running  nm --defined-only on each generated object, and > then check

[chromium-dev] depot_tools and pymox

2009-10-19 Thread Marc-Antoine Ruel
Hi I finally checked-in pymox into depot_tools. This mean that if you ever ran the depot_tools unit_tests, you may get this error svn: svn: Failed to add directory 'tests/pymox': a versioned directory of the same name already exists git-svn: error: Untracked working tree file 'tests/pymox/COPYI

[chromium-dev] Re: weird Visual Studio link error, will clobber fix it?

2009-10-16 Thread Marc-Antoine Ruel
... more hotfixes for you to install http://dev.chromium.org/developers/how-tos/build-instructions-windows On Fri, Oct 16, 2009 at 3:57 PM, Paweł Hajdan Jr. wrote: > I'm consistently getting this error when linking (fails 57 times when > compiling the entire chrome.sln): > 2>shell32.lib(shguid.

[chromium-dev] Re: Please update svn:ignore for gyp changes

2009-10-16 Thread Marc-Antoine Ruel
... and by the time I synced, it was closed again. :) On Fri, Oct 16, 2009 at 3:58 PM, Marc-Antoine Ruel wrote: > I'm doing it, I have a change pending, I was waiting for the tree to reopen... > > M-A > > On Fri, Oct 16, 2009 at 3:56 PM, Peter Kasting wrote: >> After

[chromium-dev] Re: Please update svn:ignore for gyp changes

2009-10-16 Thread Marc-Antoine Ruel
I'm doing it, I have a change pending, I was waiting for the tree to reopen... M-A On Fri, Oct 16, 2009 at 3:56 PM, Peter Kasting wrote: > After a recent sync I now have a large number of .rules/.sln/.vcproj files > in chrome_frame/.  Someone changed the gyp files in a way that introduced > the

[chromium-dev] Re: Canary bot, now with formatted layout test results

2009-10-15 Thread Marc-Antoine Ruel
Actually, can you package this so it could be upstreamed to webkit.org? On Thu, Oct 15, 2009 at 1:09 PM, Glenn Wilson wrote: > The tool lives in > src/webkit/tools/layout_tests/test_output_formatter{.bat,.sh}, and it can > actually be run against any builder, not just the canaries. Adding bette

[chromium-dev] Re: if you get gcl error ['svn', 'cat', ]

2009-10-14 Thread Marc-Antoine Ruel
.html, line 353 >>> Presubmit checks took 2.2s to calculate. >>> There were presubmit warnings. Are you sure you wish to continue? (y/N): >>> y >>> Got error status from ['svn', 'cat', >>> 'chrome/browser/sync/resource

[chromium-dev] Re: Building chromium stable

2009-10-09 Thread Marc-Antoine Ruel
Adding a few potentially interested people. On Fri, Oct 9, 2009 at 6:45 AM, Rozenkraft wrote: > > As a few of you know, I've been trying to build a stable version of > chromium for a month now. The problem is the DEPS file of the 195 > branch is outdated so it has wrong dependencies. I could upd

[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK

2009-10-08 Thread Marc-Antoine Ruel
Did you try the right file? On Thu, Oct 8, 2009 at 1:20 PM, yu...@chromium.org wrote: > > When trying to install the hotfix on Win7/64 I'm getting following > message: > > "The upgrade patch cannot be installed by the Windows Installer > service > because the program to be upgraded may be missin

[chromium-dev] Re: GYP and cross-compiling

2009-10-08 Thread Marc-Antoine Ruel
On Thu, Oct 8, 2009 at 12:49 PM, Evan Martin wrote: > > 3- Well, it only works for the make build. The current patch probably > breaks > > the scons one. XCode and MSVS should be mostly unaffected - but won't > > supposrt this, which I don't think is a big deal. > > How about 32/64-bit binaries f

[chromium-dev] Re: detecting tabs using a lot of CPU?

2009-10-07 Thread Marc-Antoine Ruel
It's better to be non-animated. Remember,ichrome is using too much CPU already. Second; the user is doing something, he doesn't want to be distracted with information unrelated to his current task. If the user finds himself waiting on his current tab, his eyes will probably see a tab being slightl

[chromium-dev] Re: Has anyone built successfully on Win7 64bit? I am getting bash.exe errors

2009-10-07 Thread Marc-Antoine Ruel
For the record, I build on win7 (both x86 and x64) on vs2008 without problem here. M-A On Tue, Oct 6, 2009 at 9:21 PM, vha14 wrote: > > Still having the same issue after following John's suggestions. Being > forced to use a separate cygwin's bash.exe. > > On Oct 2, 12:16 am, Abubakar wrote: >>

[chromium-dev] Re: build time speed improvement with solid state drive?

2009-10-05 Thread Marc-Antoine Ruel
Marshall, don't waste money on SSD (especially not MLC SSD). Get 2 standard HD, put the checkout on the secondary drive, get a dual-cpu quad-core ht with 8+ gigs of RAM (or up to the limit you can afford but get at least 8 gigs of RAM and at least one quad core). Core i7 or xeon nehalem *highly* re

[chromium-dev] Re: Google Blogoscoped author tries out Chrome app shortcuts

2009-10-05 Thread Marc-Antoine Ruel
[+chromium-dev] On Mon, Oct 5, 2009 at 12:36 PM, Philipp Lenssen wrote: > Hi Peter and Marc-Antoine! > > (forwarding my post via email as the Google Groups discussion is moderated) You need to subscribe first to not be moderated, e.g. ignored. > I'm glad to see the issues being looked at! > >

[chromium-dev] Re: Scalability

2009-10-05 Thread Marc-Antoine Ruel
Yes, Nicolas is working on making webkit.dll. It's painful to do; I know, I tried last year. :) On Mon, Oct 5, 2009 at 11:42 AM, Evan Martin wrote: > On Fri, Oct 2, 2009 at 8:26 AM, Marc-Antoine Ruel wrote: >> is linking. To give you an idea, here's a truncated dir list: >

[chromium-dev] Re: Google Blogoscoped author tries out Chrome app shortcuts

2009-10-04 Thread Marc-Antoine Ruel
On Sun, Oct 4, 2009 at 7:13 PM, Peter Kasting wrote: > With larger textarea content, Chrome’s up and downwards scrolling can show > minimal lags. Firefox handles this smoothly. > > Didn't try to test this one, filed crbug.com/23788 . We can trick things with ScrollWindowEx when we scroll the who

[chromium-dev] Re: buildbot failure in Chromium on Chromium Builder (dbg), revision 0

2009-10-02 Thread Marc-Antoine Ruel
Should we *not* close the tree on forced compile? I guess so. M-A On Fri, Oct 2, 2009 at 7:15 PM, wrote: > http://build.chromium.org/buildbot/waterfall/ > > Automatically closing tree for "compile" on "Chromium Builder (dbg)" > > > http://build.chromium.org/buildbot/waterfall/builders/Chromium%

[chromium-dev] Re: Try server follow up

2009-10-02 Thread Marc-Antoine Ruel
The windows try slaves are now back up with the symbols disabled. A side-effect is that process dump will always be red, since the symbols cannot be found. I'll remove this step soon. M-A On Fri, Oct 2, 2009 at 1:10 PM, Marc-Antoine Ruel wrote: > The windows slaves are really havin

[chromium-dev] Try server follow up

2009-10-02 Thread Marc-Antoine Ruel
The windows slaves are really having a hard time to compile, if it fails, just try again :( The command is or s/gcl/git/: gcl try foo --bot win In the short term, I'm disabling debug info on windows so they are at least somewhat useful. I'll probably restart the master in the middle of the day t

[chromium-dev] Scalability

2009-10-02 Thread Marc-Antoine Ruel
ut it takes time. As an example, syncapi links with net for a single string parsing function. But pulling net also pulls v8 so I'm splitting net in two to remove the dependency injection. We may go back to disabling PDBs, saving several gigs but that slightly reduce the usefulness. That's pro

[chromium-dev] Re: url request failing on unix with os_error = -7

2009-10-01 Thread Marc-Antoine Ruel
[bcc: chromium-dev] As I said in my previous email (which was blocked by the ML) you should have just replied to the email and saved 1600+ people time. That what is written on the try job status email for a reason. I'll send a follow up email with more information. M-A On Thu, Oct 1, 2009 at 9

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-10-01 Thread Marc-Antoine Ruel
On Thu, Oct 1, 2009 at 2:22 PM, Anton Muhin wrote: > > On Thu, Oct 1, 2009 at 10:18 PM, cpu wrote: >> >> Did somebody answer Marc-Antoine question? >> >> I don't see us ever releasing pages. I can fathom that we are not >> doing that so I must be reading the code wrong. > > What to you mean by r

[chromium-dev] Re: Update default subversion properties on d.c.o?

2009-10-01 Thread Marc-Antoine Ruel
As a dictator, I say the rule is simple; Is the .sln/.vcproj actually used in all.sln? - If not, we don't care and can leave the file as-is. We assume it's in third parties only. - If so, it needs to be converted. When we add new build "flavors" (purify, pgo, etc), it's a pain to manage non-gyp

[chromium-dev] Re: [Memory] low memory callback

2009-10-01 Thread Marc-Antoine Ruel
If you add this functionality, you should add this to SystemMonitor in src/base/system_monitor.h On Thu, Oct 1, 2009 at 9:17 AM, Anton Muhin wrote: > > Dear chromers! > > Do we have some notification mechanism for low memory event? > > If not, are you fine if I add it?  It would be completely op

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-10-01 Thread Marc-Antoine Ruel
[uninformed question] >From a quick search, when you're talking about decommit, you seem to always use MEM_DECOMMIT instead of MEM_RELEASE; I see no MEM_RELEASE in tcmalloc. You do leak the reserved pages or are they first reused? What I am referring to is to a potential virtual address space le

[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK

2009-09-30 Thread Marc-Antoine Ruel
I have done that last week. You can see the list grew even more. On Wed, Sep 30, 2009 at 1:44 PM, Stephen White wrote: > I see it's now listed as required for MSVC2005 (thanks to whoever updated > the build instructions). > > On Wed, Sep 30, 2009 at 1:39 PM, Stephen White > wrote: >> >> Just in

[chromium-dev] Re: Kiosk Mode for Chrome

2009-09-29 Thread Marc-Antoine Ruel
I think I'm right to say that a lot of the "knobs" stated by Mohamed can be achieved with content script. Everything that can be done with javascript for this particular use case should be done as javascript. For example, destroying the window.print prototype. I think you try to block to many thi

[chromium-dev] Re: Green tree task force: How to try upstream Windows layout tests?

2009-09-29 Thread Marc-Antoine Ruel
I don't think it'd be very hard, I didn't know this was a wanted feature. M-A On Tue, Sep 29, 2009 at 6:47 PM, Peter Kasting wrote: > On Tue, Sep 29, 2009 at 3:35 PM, Marc-Antoine Ruel > wrote: >> >> If I understand correctly, you're asking for a web

[chromium-dev] Re: Green tree task force: How to try upstream Windows layout tests?

2009-09-29 Thread Marc-Antoine Ruel
If I understand correctly, you're asking for a webkit try server? And in particular a apple windows builder/tester. M-A On Tue, Sep 29, 2009 at 6:18 PM, Peter Kasting wrote: > I figure this question is most suited for the Green Tree folks. > Ojan told me today that he had a patch to fix one of

[chromium-dev] Re: Try-ing WebKit patches (was WebKit Chromium Port Update Sep 29th)

2009-09-29 Thread Marc-Antoine Ruel
+Dimitri, who is doing that and didn't put Jeremy in the loop. On Tue, Sep 29, 2009 at 4:06 PM, Jeremy Orlow wrote: > On Tue, Sep 29, 2009 at 12:52 PM, Jeremy Orlow wrote: >> >> On Tue, Sep 29, 2009 at 12:05 PM, Eric Seidel >> wrote: >>> >>> On Tue, Sep 29, 2009 at 11:53 AM, Yaar Schnitman >>

[chromium-dev] Re: gclient sync

2009-09-28 Thread Marc-Antoine Ruel
Err, meant http://src.chromium.org/viewvc/chrome?view=rev&revision=27386 On Mon, Sep 28, 2009 at 2:57 PM, Marc-Antoine Ruel wrote: > Now fixed as http://chrome-svn/viewvc/chrome?view=rev&revision=27386 . > Will take a few minutes before it propagates to the proxies. > > On

[chromium-dev] Re: gclient sync

2009-09-28 Thread Marc-Antoine Ruel
Now fixed as http://chrome-svn/viewvc/chrome?view=rev&revision=27386 . Will take a few minutes before it propagates to the proxies. On Mon, Sep 28, 2009 at 2:45 PM, Marc-Antoine Ruel wrote: > If you can, please don't sync for the next 15 min

[chromium-dev] gclient sync

2009-09-28 Thread Marc-Antoine Ruel
If you can, please don't sync for the next 15 minutes. Thanks. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~

[chromium-dev] Re: Error in using gclient

2009-09-28 Thread Marc-Antoine Ruel
6:3178 svn.bat 2009-09-22 16:32 svn_bin 2 fichier(s) 145 octets > On Mon, Sep 28, 2009 at 11:13 AM, Marc-Antoine Ruel > wrote: >> >> On Mon, Sep 28, 2009 at 2:09 PM, Dan Kegel wrote: >> > >> > On S

[chromium-dev] Re: Error in using gclient

2009-09-28 Thread Marc-Antoine Ruel
On Mon, Sep 28, 2009 at 2:09 PM, Dan Kegel wrote: > > On Sat, Sep 26, 2009 at 6:23 PM, Marc-Antoine Ruel > wrote: >> Something disable a trick we use to download a zip file containing svn >> and uncompressing it. You can do it manually since it's one time >> pr

[chromium-dev] Re: FYI, project cruft

2009-09-28 Thread Marc-Antoine Ruel
GYP debugger? On Mon, Sep 28, 2009 at 2:00 PM, Nick Carter wrote: > I've noticed that the use of the 'direct_dependent_settings' in gyp to > propagate #defines and include paths makes it trickier to decipher the > actual build-order dependencies.  I've had cases where I needed to add a gyp > dep

[chromium-dev] Re: Skipping reference_build ?

2009-09-28 Thread Marc-Antoine Ruel
As usual, please file a feature request unless you plan on doing it, otherwise I'll forget. On Fri, Sep 25, 2009 at 3:59 PM, Jeremy Orlow wrote: > Sounds like we need a presubmit check. > > On Fri, Sep 25, 2009 at 6:38 AM, Marc-Antoine Ruel > wrote: >> >> It'

[chromium-dev] FYI, project cruft

2009-09-26 Thread Marc-Antoine Ruel
Project dependencies went out of control lately. As an example; mini_installer was depending of gtest. :) I started by splitting most constants out of chrome/common into common_constants and fixed 2 projects accordingly. My next target is most of the ui tests series and fetch_* that are linking

[chromium-dev] Re: Error in using gclient

2009-09-26 Thread Marc-Antoine Ruel
Hi Something disable a trick we use to download a zip file containing svn and uncompressing it. You can do it manually since it's one time process. See for the details: http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/bootstrap/win/win_tools.bat?view=markup If you follow the script

[chromium-dev] Re: new values for failures in test_expectations.txt

2009-09-25 Thread Marc-Antoine Ruel
On Fri, Sep 25, 2009 at 9:12 PM, Dirk Pranke wrote: > > Hi all, > > If you don't run layout_tests or ever need to modify > test_expecations.txt, you can ignore this ... As a reminder, every build sheriff needs to be able to modify this. M-A > As discussed earlier this week, we've added the abi

[chromium-dev] Re: gclient hang

2009-09-25 Thread Marc-Antoine Ruel
Yep, I specified one directory too deep. On Fri, Sep 25, 2009 at 2:50 PM, Mike Pinkerton wrote: > To get mine to work, I had to > >  rm -rf src/third_party/WebKit/WebKit > > just doing "chromium" wasn't enough to stop the hangs. > > On Fri, Sep 25, 2009 at

[chromium-dev] gclient hang

2009-09-25 Thread Marc-Antoine Ruel
Your next gclient sync will probably hang. The easiest way to fix it is to: rm -rf src/third_party/WebKit/WebKit/chromium or rd /q /s src\third_party\WebKit\WebKit\chromium before syncing. Sorry for the trouble, M-A --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: Build time doubled since May - what gives?

2009-09-25 Thread Marc-Antoine Ruel
09 AM, Nick Carter wrote: >> I'll volunteer to fix any build issues created as a result of sync. >> Building the protobuf compiler (protoc.exe) emits a bunch of warnings -- the >> bulk are signed/unsigned warnings.  I'll put together a change to suppress >> those.

[chromium-dev] Re: Kiosk Mode for Chrome

2009-09-25 Thread Marc-Antoine Ruel
Well, Mohamed's patch is *way* simpler and portable. On Fri, Sep 25, 2009 at 12:40 PM, Amit Joshi wrote: > Sorry for not being clear. What I meant was that you could create your own > kiosk shell and embed Chrome Frame as ActiveX control to render the pages > you want in it. That way you could c

  1   2   3   4   >