Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656

2010-01-21 Thread Thomas Van Lenten
DownloadFilename is a strings error, the bot needs a clobber. We had this on the main waterfall yesterday morning also and the few that saw it got fixed by a clobber. TVL On Thu, Jan 21, 2010 at 9:36 AM, Marc-Antoine Ruel wrote: > [+chromium-dev and sheriffs] > > These are flaky tests. > > It i

Re: [chromium-dev] How to rebuild after modifying extension_api.json?

2010-01-15 Thread Thomas Van Lenten
Actually, it think it's sorta captured -- chrome.gyp has chrome_resources_inputs, which is created by running a script to figure out the input from the grd files. Looking at my xcode project, there is a dependency on common/extensions/api/extension_api.json for the grd files listed in chrome_reso

[chromium-dev] Re: Running Chromebot on official builds from trunk

2009-12-30 Thread Thomas Van Lenten
>> On Wed, Dec 30, 2009 at 10:37 AM, Viet-trung Luu > wrote: > >>> > >>> There may be several (possibly related) problems. > >>> > >>> I'm definitely seeing zombie ps-es on 249.43 (the released beta). What > >>> Nirnimesh said about

[chromium-dev] Re: Running Chromebot on official builds from trunk

2009-12-30 Thread Thomas Van Lenten
s commands in terminal gets stuck too. >> >> >> On Wed, Dec 30, 2009 at 10:37 AM, Viet-trung Luu wrote: >> >>> There may be several (possibly related) problems. >>> >>> I'm definitely seeing zombie ps-es on 249.43 (the released beta). What >>&g

[chromium-dev] Re: Running Chromebot on official builds from trunk

2009-12-30 Thread Thomas Van Lenten
id about not being able to fork processes (until Chrome >> gets killed) could be caused by zombies. >> >> Is anyone else seeing zombies? >> >> - Trung >> >> On Wed, Dec 30, 2009 at 1:28 PM, Thomas Van Lenten >> wrote: >> > >> > >>

Re: [chromium-dev] Embedding chrome.pak in the chrome binary for Linux?

2009-12-12 Thread Thomas Van Lenten
[From the right address this time] There is a pak file for each language, so you'd have in include all language pak files in the binary, and only one would be used at any given time, so there would be some overhead as far a memory, etc. TVL On Sat, Dec 12, 2009 at 7:52 AM, Satoru Takabayashi wro

Fwd: [chromium-dev] Where buildbot outputs the intermediate builds?

2009-12-01 Thread Thomas Van Lenten
repost from right account... -- Forwarded message -- Date: Tue, Dec 1, 2009 at 10:50 AM Subject: Re: [chromium-dev] Where buildbot outputs the intermediate builds? To: robj.pe...@gmail.com Cc: Chromium-dev On Tue, Dec 1, 2009 at 10:27 AM, Roberto wrote: > Are the buildbots ar

Re: [chromium-dev] Xcode builds and dependencies

2009-11-24 Thread Thomas Van Lenten
.py), but the catch the the treating of outputs as sources, that needs to be done in the generators, so there really a good way to deal with it. TVL > > On Tue, Nov 24, 2009 at 9:51 AM, Thomas Van Lenten > wrote: > >> Last week Mark and I talked with someone in Apple's de

[chromium-dev] Xcode builds and dependencies

2009-11-24 Thread Thomas Van Lenten
Last week Mark and I talked with someone in Apple's devtools team about some of the dependency problems we've seen in our builds. We have a radar open with some repro steps, but we got a workaround for what we think we're seeing. I just rolled in a GYP change that applies this workaround(*). If

Re: [chromium-dev] Re: 437k files checked out for an official build

2009-11-10 Thread Thomas Van Lenten
the whole checkout and not just the build output directories? TVL > > On Mon, Nov 9, 2009 at 6:41 PM, Thomas Van Lenten > wrote: > > Right, but the builds need these files to run the tests to make sure the > > bits are good. > > The problem is some tests leave logs a

[chromium-dev] Re: 437k files checked out for an official build

2009-11-09 Thread Thomas Van Lenten
Right, but the builds need these files to run the tests to make sure the bits are good. The problem is some tests leave logs and such in the tree after running, if we could ensure nothing changes in the tree, we might be able to change the scripts to simply update. Or maybe we do the same gclient

[chromium-dev] Mac UI Types

2009-10-30 Thread Thomas Van Lenten
Gentle reminder: NSRect, NSPoint, NSSize are all defined based on CGFloat. In 64bit, this is a double, not a float. So please make sure all code dealing with these is using CGFloat so we don't have issues in the future. TVL --~--~-~--~~~---~--~~ Chromium Develope

[chromium-dev] Re: Change to default build architecture

2009-10-19 Thread Thomas Van Lenten
You need it defined when doing the gclient sync/runhooks, not when building. TVL On Sun, Oct 18, 2009 at 12:46 AM, Issac wrote: > > > > On Oct 15, 9:27 pm, Antoine Labour wrote: > > On Thu, Oct 15, 2009 at 9:04 PM, Michael Moss > wrote: > > > > > On Thu, Oct 15, 2009 at 8:59 PM, Fumitoshi Uka

[chromium-dev] Re: [Mac] Chromium terminates when running from Terminal

2009-10-15 Thread Thomas Van Lenten
How exactly are you launching it? ie-what are you typing into the terminal. it might be the executable path change last night. TVL On Thu, Oct 15, 2009 at 6:07 PM, Mikhail Naganov wrote: > > Hi all, > > Starting from today, I can't run Chromium from Terminal, unless I'm > running it under gdb.

[chromium-dev] Re: No co-sheriff today

2009-10-15 Thread Thomas Van Lenten
http://dev.chromium.org/developers/tree-sheriffs On Thu, Oct 15, 2009 at 4:12 PM, Abubakar wrote: > whats this sheriff thing can anyone explain :) ?I thought the first email > was a spam hehe . > > > On Fri, Oct 16, 2009 at 1:10 AM, Thomas Van Lenten > wrote: > >>

[chromium-dev] Re: No co-sheriff today

2009-10-15 Thread Thomas Van Lenten
I'll keep an eye on things tomorrow morning (east coast hours). TVL On Thu, Oct 15, 2009 at 4:06 PM, Mark Mentovai wrote: > > I've been sheriffing for Munjal for the past hour, when I found the > tree in a bad state. > > I'm happy to keep helping, but it'd be great if some other folks would > s

[chromium-dev] Re: if you get gcl error ['svn', 'cat', ]

2009-10-14 Thread Thomas Van Lenten
Not really sure since the snips you list are two different files, but the warning is not about eol-style, it's about lines ending with spaces, looks on the lines listed for things like: [space][space][real_code][space][space][LF] [space][space][LF] And take the spaces at the *end* of those lin

[chromium-dev] Re: Buildbot upgrade

2009-10-12 Thread Thomas Van Lenten
On Mon, Oct 12, 2009 at 10:45 AM, Nicolas Sylvain wrote: > > > On Sun, Oct 11, 2009 at 6:50 PM, Thomas Van Lenten > wrote: > >> Looks like the failures link needs to be updated in waterfall header. > > I'm pretty sure I did, can you show me which one is not updat

[chromium-dev] Re: Buildbot upgrade

2009-10-11 Thread Thomas Van Lenten
Looks like the failures link needs to be updated in waterfall header. TVL On Sat, Oct 10, 2009 at 9:25 PM, Nicolas Sylvain wrote: > Hello, > Today I upgraded buildbot to the latest version. > > If you have a bookmark for the "failures only" waterfall, you will need to > change it. Previously it

[chromium-dev] Re: GYP and cross-compiling

2009-10-07 Thread Thomas Van Lenten
It seems like another approach would be to use the target types to indicate if the library or executable is for the host or native (ie-add types for host vs. target), then you could use target_conditions to have different flags. TVL On Wed, Oct 7, 2009 at 10:06 PM, Antoine Labour wrote: > If yo

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

2009-10-07 Thread Thomas Van Lenten
http://developer.apple.com/mac/library/documentation/Darwin/Reference/ManPages/man1/dyld.1.html sorta "relative to the thing loading this" TVL On Wed, Oct 7, 2009 at 3:52 PM, Albert J. Wong (王重傑) wrote: > What is @loader_path relative off of? > > > On Wed, Oct 7, 2009 at 12:35 PM, Mark Mentovai

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

2009-10-07 Thread Thomas Van Lenten
Mark is probably the one to best answer a suggestion here. I'm assuming they also need to be handled in a version fashion with the app, yes? TVL On Wed, Oct 7, 2009 at 2:36 PM, Andrew Scherkus wrote: > On Wed, Oct 7, 2009 at 11:34 AM, Albert J. Wong (王重傑) > wrote: > >> We just noticed that the

[chromium-dev] Re: Turning on Mac pixel tests! Heads-up!

2009-10-02 Thread Thomas Van Lenten
Avi, thanks! We should also keep an eye on the cycle times for the bots to see how much more time they take with the pixel tests enabled. TVL On Fri, Oct 2, 2009 at 11:55 AM, Avi Drissman wrote: > That didn't turn out so bad. Pixel tests turned on as of r27839. The first > batch had failures >

[chromium-dev] Re: library targets with no sources fail to build on OS X

2009-10-02 Thread Thomas Van Lenten
The targets need a type so it knows what to build. I guess the different generators are defaulting differently. TVL On Thu, Oct 1, 2009 at 2:45 PM, brymcq wrote: > > I'm working on some code that uses the gyp build system. I find that > there are cases where I want to aggregate several librari

[chromium-dev] Re: gclient fails to update gyp files

2009-09-29 Thread Thomas Van Lenten
>> Is native_client really required? Why? We don't want to build this by >> default, do we? >> >> it's too big and it does not fit in the tarball, so it has been excluded >> there. >> >> Nicolas >> >> >> >> On Tue,

[chromium-dev] Re: gclient fails to update gyp files

2009-09-29 Thread Thomas Van Lenten
It's not in src.chromium.org, it comes in via DEPS: "src/native_client": "http://nativeclient.googlecode.com/svn/trunk/src/native_cli...@797";, TVL On Tue, Sep 29, 2009 at 3:32 PM, Nebojša Ćirić wrote: > Hi Nick, As Chris said, src/native_client is missing from the trunk (and I > don't h

[chromium-dev] Re: gclient fails to update gyp files

2009-09-29 Thread Thomas Van Lenten
Did you get any errors in the gclient sync? There is an entry for that dir within the DEPs file. TVL On Tue, Sep 29, 2009 at 12:52 PM, Nebojša Ćirić wrote: > This is a (read-only) client that synced without problems 4 days ago. Today > gclient sync failed with: > > running '/usr/bin/p

[chromium-dev] Re: Question about UI and "classic views"

2009-09-25 Thread Thomas Van Lenten
The other part of this might just be messaging. It's not uncommon for websites to have a link to let users try out the new experience before it launches. And once it does launch, they always seem to include a "Check out our new look and cool new features..." blurb. So it's sudden switch, but mess

[chromium-dev] Re: flaky resource failures

2009-09-25 Thread Thomas Van Lenten
On Thu, Sep 24, 2009 at 6:24 PM, Paweł Hajdan Jr. wrote: > On Thu, Sep 24, 2009 at 12:24, Thomas Van Lenten wrote: > >> Brad landed support for depending on all the python files that go into >> grit, so that part would have worked. The not always rebuilding for .h >&

[chromium-dev] Re: flaky resource failures

2009-09-24 Thread Thomas Van Lenten
On Thu, Sep 24, 2009 at 3:19 PM, Tony Chang wrote: > > Which build was this? I checked in a change that changes how grit > generates IDs. This type of change requires a clobber since I don't > think we depend on all the grit .py files. I think these changes are > rare enough that we can just c

[chromium-dev] Re: flaky resource failures

2009-09-24 Thread Thomas Van Lenten
On Thu, Sep 24, 2009 at 3:03 PM, Paweł Hajdan Jr. wrote: > We still have problems with resources, examples: > > [FATAL:tab_renderer.cc(132)] Check failed: waiting_animation_frames->width() > % waiting_animation_frames->height() == 0. > > [FATAL:image_operations.cc(373)] Check failed: rgb.width()

[chromium-dev] Re: Pasteboards and the mac valgrind builder

2009-09-24 Thread Thomas Van Lenten
On Thu, Sep 24, 2009 at 1:10 PM, Mark Mentovai wrote: > > Yes, I was poking this a little bit last week, and a little bit the > week before. It seems that under Valgrind, tests involving the > pasteboard, and maybe a couple of other things too, will always fail. > In some cases, the test failure

[chromium-dev] Re: Xcode dependency analysis

2009-09-22 Thread Thomas Van Lenten
list explicit dependencies. > > I think I'd have an easier time parsing your paragraph with specific > examples. > > -eric > > On Tue, Sep 22, 2009 at 5:30 AM, Thomas Van Lenten > wrote: > > I've confirmed this with Xcode 3.2; but my suspicion is it also happen

[chromium-dev] Xcode dependency analysis

2009-09-22 Thread Thomas Van Lenten
I've confirmed this with Xcode 3.2; but my suspicion is it also happens with Xcode 3.1.x, just less frequently. In our build process, we run scripts in a few places to generate headers. Those steps are usually done via Actions on targets. We have listed all of the outputs generated so the tool cha

[chromium-dev] Re: Link error for KeystoneGlue on mac ui_tests?

2009-09-20 Thread Thomas Van Lenten
The unittest should be able to skip keystone, since it's part of the update system for official builds. Either we have a shim, or we're pulling in something we've been able to avoid in the past. TVL On Sun, Sep 20, 2009 at 12:47 PM, Drew Wilson wrote: > Hi all, > I'm trying to fix up some of t

[chromium-dev] Re: "Clear Strict-Transport-Security state" checkbox added

2009-09-17 Thread Thomas Van Lenten
FYI: Mac does have this dialog, and it's actually 1 click away, as the there is a menu item in the menu bar to directly invoke it (since Safari and Firefox have menubar entries for this). TVL On Thu, Sep 17, 2009 at 8:20 PM, Adam Barth wrote: > > There's a slight race condition in making variou

[chromium-dev] Re: custom built chromium *much* slower than chrome

2009-09-17 Thread Thomas Van Lenten
On Thu, Sep 17, 2009 at 4:41 PM, Rozenkraft wrote: > > > The corresponding revision is not the right revision.Did you try to sync > > your Chromium source code to the 196 branch? This is the source code used > > for the 3.x release, not the corresponding revision you mentioned. Many > > improveme

[chromium-dev] Spike in Linux Reference times on Perf tests

2009-09-08 Thread Thomas Van Lenten
A few of the perf runs for linux shows a sudden change in the reference build performance. These show a slow down: Page Cycler Intl2 Page Cycler DHTML These show a speed up/improvement: Page Cycler Moz Page Cycler Intl1 Startup SunSpider V8 Benchmark Page Cycler Morejs The other

[chromium-dev] Re: Building Mac Chrome on 10.6 with Xcode 3.2 tool chain

2009-09-03 Thread Thomas Van Lenten
Quick update: Apple has confirms on the Xcode mailing list they are working on the issue. TVL On Mon, Aug 31, 2009 at 2:44 PM, Thomas Van Lenten wrote: > Just a quick heads up, if you are building on 10.6 with Xcode 3.2, you > might hit some hiccups with distributed builds. An all local

[chromium-dev] Re: Pixel tests on the Mac

2009-08-31 Thread Thomas Van Lenten
On Mon, Aug 31, 2009 at 5:01 PM, Avi Drissman wrote: > OK, so I was looking at the result pngs, and I was wrong. It seems to be > solely about the thumb length, which causes the wavy color to vary along the > length. > > Did we have any suspicions about how the length was turning out wrong the >

[chromium-dev] Building Mac Chrome on 10.6 with Xcode 3.2 tool chain

2009-08-31 Thread Thomas Van Lenten
Just a quick heads up, if you are building on 10.6 with Xcode 3.2, you might hit some hiccups with distributed builds. An all local build seems like it is working ok, but we're seeing a few different issues with distributed builds and Apple's distcc support (not finding remote machines, compiler c

[chromium-dev] Re: Major tab cold regression on mac around r24415

2009-08-26 Thread Thomas Van Lenten
On Wed, Aug 26, 2009 at 12:28 PM, Evan Martin wrote: > > PS Every time I want to call it the "EPIC CHANGE". > > On Wed, Aug 26, 2009 at 9:27 AM, Evan Martin wrote: > > Here's a guess: the "history" file is restored each time the test > > runs, and Brett's epoch change means that we need to re-mig

[chromium-dev] Re: Major tab cold regression on mac around r24415

2009-08-26 Thread Thomas Van Lenten
On Wed, Aug 26, 2009 at 12:32 PM, Thomas Van Lenten wrote: > > > On Wed, Aug 26, 2009 at 12:28 PM, Evan Martin wrote: > >> >> PS Every time I want to call it the "EPIC CHANGE". >> >> On Wed, Aug 26, 2009 at 9:27 AM, Evan Martin wrote: >> > H

[chromium-dev] Mac resources and bundles

2009-08-18 Thread Thomas Van Lenten
Anyone adding more resources (xibs, etc.) to the Mac, please remember always fetch them from mac_util::MainAppBundle() (base/mac_util.h) and do *not* use any Cocoa apis that assume [NSBundle mainBundle]. As part of the l10n, packaging, and updating, where resources live and what bundle is running

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-18 Thread Thomas Van Lenten
ObjC 2.0 apis should provide pretty clean ways to get all the data for ObjC classes, see http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/Foundation/GTMStackTrace.m(we already use some of GTM in Chrome/Chromium). TVL On Tue, Aug 18, 2009 at 12:16 AM, Viet-Trung Luu wrote: > >

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Thomas Van Lenten
ould be nice if you could do this entirely within the GYP files and not extra magic from the generator, but that might not be easily doable. > -BradN > > On Aug 12, 2009 2:22 PM, "Thomas Van Lenten" > wrote: > > > > On Wed, Aug 12, 2009 at 5:03 PM, Bradley Nelson > w

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Thomas Van Lenten
On Wed, Aug 12, 2009 at 5:03 PM, Bradley Nelson wrote: > That one is know (we have a gyp issue filed from a while back).The problem > is that visual studio doesn't detect command line changes (well actually it > does as long as you do them in the IDE and don't leave the sln). > We believe we can '

[chromium-dev] Mac l10n Notes

2009-08-12 Thread Thomas Van Lenten
Folks may have noticed the Mac L10n work has started to land in the tree. Apple's normal model of doing L10n would result in a *lot* of nib files for us to maintain, so we're going more our own path so we can reuse the strings in the pak files (generated from the GRDs). I'm putting the details in

[chromium-dev] Re: Flakiness. Please help.

2009-08-07 Thread Thomas Van Lenten
On Fri, Aug 7, 2009 at 6:46 AM, Marc-Antoine Ruel wrote: > > On Thu, Aug 6, 2009 at 5:05 PM, Jeremy Orlow wrote: > > On Thu, Aug 6, 2009 at 2:02 PM, Nicolas Sylvain > > wrote: > >> > >> > >> On Thu, Aug 6, 2009 at 1:05 PM, Scott Violet wrote: > >>> > >>> Not sure, perhaps Huan could answer that.

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

2009-08-06 Thread Thomas Van Lenten
What version of GYP do you have in tools? Do you have any GYP_* env var set? Do you have anything in ~/.gyp/* TVL On Thu, Aug 6, 2009 at 11:58 PM, Mohamed Mansour wrote: > Tonight I was trying to sync my project so I did "git pull" and it worked > fine, then I did "gclient sync" as well as --f

[chromium-dev] Re: Urgent, a very evil site i think which does evil things (no joke)

2009-08-06 Thread Thomas Van Lenten
On Thu, Aug 6, 2009 at 1:16 PM, Miguel F Mascarenhas Sousa Filipe < miguel.fil...@gmail.com> wrote: > Hi, > > On Thu, Aug 6, 2009 at 6:08 PM, Jeremy Orlow wrote: > >> Yoav everyone on this thread is a Chromium developer and almost everyone >> posting in this thread (not me) are some of the top de

[chromium-dev] Re: gcl change that you should be aware of

2009-08-06 Thread Thomas Van Lenten
On Thu, Aug 6, 2009 at 3:51 AM, Adam Barth wrote: > > Perhaps a better default is to use this behavior when first creating a > changelist and to use the old behavior when modifying a changelist. +1 TVL > > > Adam > > > On Thu, Aug 6, 2009 at 12:37 AM, Dirk Pranke wrote: > > > > I also fear t

[chromium-dev] Re: Trick question: Who is "responsible" for repairing a red tree?

2009-08-05 Thread Thomas Van Lenten
One thing the mozilla waterfall has (or did have at one time) is the ability to add comments to any build column/step. I've seen it used so someone can hang a quick comment of "reverting " or "### pushed with fix". That way right next to a specific problem you can have any extra info, and unl

[chromium-dev] Re: code coverage and browser_tests

2009-08-05 Thread Thomas Van Lenten
I don't think Mac passes browser_test, I believe it hangs. I opened a bug on this a little while ago: http://crbug.com/16322 TVL On Wed, Aug 5, 2009 at 3:49 PM, John Grabowski wrote: > Sure! For Mac and Linux I expect things will be fine no matter what you > throw in. > jrg > > > On Wed, Aug 5

[chromium-dev] Re: Question about chromium sandbox on Mac OSX

2009-07-30 Thread Thomas Van Lenten
I did try looking for the sandbox configuration format, but this > is the only thing I found, but it does not contain sandbox config file > format > > http://developer.apple.com/DOCUMENTATION/DARWIN/Reference/ManPages/man3/sandbox_init.3.html > > > On Thu, Jul 30, 2009 at 5:21

[chromium-dev] Re: Question about chromium sandbox on Mac OSX

2009-07-30 Thread Thomas Van Lenten
Those constants are pre-configured settings. The NAMED_EXTERNAL flag lets us pass in our own config, which is the renderer.sb. Apple hasn't really documented the file format, but if you do some searching on the web, you'll find some documentation folks have figured out and I believe there was a t

[chromium-dev] Re: packaging, locale .paks

2009-07-24 Thread Thomas Van Lenten
We haven't done the work in the chrome.gyp yet. Some folks where looking at the work. mmoss and mark? TVL On Fri, Jul 24, 2009 at 2:42 PM, Paweł Hajdan Jr. wrote: > How do I force scons to build all language .paks, like locales/en-US.pak ? > I don't want to build everything. I want to build ch

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Thomas Van Lenten
The other thing to remember is the buildbot scripts and a bunch of build scripts on all platforms are full of assumptions about the relationships between projects and the tree. :( TVL On Thu, Jul 23, 2009 at 12:11 PM, Dan Kegel wrote: > On Thu, Jul 23, 2009 at 9:07 AM, Thomas Van Len

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Thomas Van Lenten
On Thu, Jul 23, 2009 at 12:00 PM, Dan Kegel wrote: > > On Thu, Jul 23, 2009 at 2:28 PM, Darin Fisher wrote: > >>> An objdir-ish solution would make sense, except the native build > >>> systems we use don't really work in terms of objdirs, so we'd just > >>> wind up generating a parallel directory

[chromium-dev] Re: avoiding compile failures on buildbot

2009-07-23 Thread Thomas Van Lenten
Just to be complete, linux can have the same issue, and I'd expect Windows also to be able too. This is one class of things the try server doesn't catch because it is building debug/unoptimized. TVL On Wed, Jul 22, 2009 at 10:09 PM, Andrew Scherkus wrote: > On Wed, Jul 22, 2009 at 7:07 PM, Dan

[chromium-dev] Re: valgrind help office hours

2009-07-20 Thread Thomas Van Lenten
On Mon, Jul 20, 2009 at 10:04 PM, John Abd-El-Malek wrote: > I have a leak after a check-in. I tried following the instructions on my > Linux box, but couldn't (I hardly develop on Linux). > > jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh > tools/valgrind/chrome_tests.sh --generate_su

[chromium-dev] Re: gyp variants?

2009-07-18 Thread Thomas Van Lenten
One advantage loops might have over this approach is it keeps the support more portable. This approach requires requires invoking a shell, which could be harder to keep portable, no? I was thinking of some cases where a loop that defined actions could be handy, but this style approach might also w

[chromium-dev] Re: Mac Valgrind Bots

2009-07-17 Thread Thomas Van Lenten
On Fri, Jul 17, 2009 at 10:31 AM, Dan Kegel wrote: > On Fri, Jul 17, 2009 at 2:07 PM, Nicolas Sylvain > wrote: > >> We've finished the shuffle of the Mac Valgrind bots over to release > >> builds. It looks like some of the slower tests now run 2x as fast, so > the > >> cycles types seem to be a

[chromium-dev] Mac Valgrind Bots

2009-07-17 Thread Thomas Van Lenten
We've finished the shuffle of the Mac Valgrind bots over to release builds. It looks like some of the slower tests now run 2x as fast, so the cycles types seem to be a lot better (fewer cls per cycle). There are two bots on the main waterfall, and a few more on the fyi waterfall. Nirnimesh & Stuar

[chromium-dev] Re: How to Generate Visual Studio .SLN file from gyp

2009-07-16 Thread Thomas Van Lenten
we sorta left the "dogfood" state a while ago :) and it's role has evolved to the point the work it does is specific to Chromium. So when tweaking something in it for the buildbots the other day, we went ahead and renamed it. TVL > > -BradN > > > On Thu, Jul 1

[chromium-dev] Re: How to Generate Visual Studio .SLN file from gyp

2009-07-16 Thread Thomas Van Lenten
sync again, it sounds like your src tree and gyp version are out of sync. TVL On Thu, Jul 16, 2009 at 6:39 AM, zys wrote: > > Hello > You might think that this is a really a stupid question. > I have downloaded chrome source code as well as the depot_tools and > now I am trying to generate .SLN

[chromium-dev] Re: running layout_tests on vista and windows 7

2009-07-13 Thread Thomas Van Lenten
Quick skimmed reply: Mac already has expectations per OS where we need them, so you might be able to follow that basic model (and maybe small tweaks to the scripts to use it). It looks for version specific and then falls back to generic platform files so we only have to dup the ones that are os ve

[chromium-dev] New path service constants

2009-07-13 Thread Thomas Van Lenten
If you are adding new path service constants as part of a new feature (ie-adding new directories to the install footprint or a new data dir for storing things in), please make sure you include someone for each platform in the review and call out what the path is for. We've had a few paths added ov

[chromium-dev] Re: running browser_tests on more bots

2009-07-08 Thread Thomas Van Lenten
Looks like the tests don't run on the mac, I'll look into that. TVL On Wed, Jul 8, 2009 at 3:17 PM, Paweł Hajdan Jr. wrote: > > > Hmmm. They do run on try bots. > > Oh, indeed. But only on Windows. But I noticed you're working on this, > so - seems good. > > > They also do run in debug and relea

[chromium-dev] Re: running browser_tests on more bots

2009-07-08 Thread Thomas Van Lenten
Looks like the tests don't run on the mac, I'll look into that. TVL On Wed, Jul 8, 2009 at 3:17 PM, Paweł Hajdan Jr. wrote: > > > Hmmm. They do run on try bots. > > Oh, indeed. But only on Windows. But I noticed you're working on this, > so - seems good. > > > They also do run in debug and relea

[chromium-dev] Re: A suggestion to Drastically improve build times,

2009-07-08 Thread Thomas Van Lenten
On Wed, Jul 8, 2009 at 11:03 AM, Paweł Hajdan Jr. wrote: > > I wonder if it would be possible to have a conditional flag, maybe in > common.gypi, that you would flip to turn on incremental linking, with > still non-incremental linking being the default. Something like this probably makes sense t

[chromium-dev] Re: some questions about chrome's layout-test

2009-07-06 Thread Thomas Van Lenten
See the expectations file, it lists the ones that are known to fail on a given platform. This is how we easily track new failures. TVL 2009/7/6 David Jones > >It means those two tests failed to produce the expected results. When > >done, the summary page should open with a list of any tests t

[chromium-dev] Re: some questions about chrome's layout-test

2009-07-06 Thread Thomas Van Lenten
2009/7/6 David Jones > I have worked on webkit ,though I didn't know much about wekkit's > layout-test. I'm curious about chrome's layout-test. > -do you take webkit's layout-test into chrome with any changes? I don't > think so, so what're these changes? > It depends a little on the platform in

[chromium-dev] Re: what's difference between master.chromium and master.chromium.fyi?

2009-07-06 Thread Thomas Van Lenten
master.chromium -- http://build.chromium.org/buildbot/waterfall/ master.chromium.fyi -- http://build.chromium.org/buildbot/waterfall.fyi/ >From the main waterfall, the experimental link takes to you the fyi one. The fyi waterfall lists the bots that we run, but don't close the tree for. TVL 200

[chromium-dev] Re: Number of threads in Render Process on MacOSX

2009-06-21 Thread Thomas Van Lenten
If you look at a lot of Mac executables, you find that the system can create threads in response to same API calls. On the copy of Chrome I'm currently running, I seeing one renderer with 5 threads and another with 6. At quick glance the extra are the OS doing some extra work in response to api c

[chromium-dev] Re: IO Request Handing in Chromium

2009-06-19 Thread Thomas Van Lenten
See http://dev.chromium.org/developers/design-documents/plugin-architecturefor some more details. TVL On Fri, Jun 19, 2009 at 1:51 PM, Evan Martin wrote: > > On Thu, Jun 18, 2009 at 12:15 AM, n179911 wrote: > > In > > > http://dev.chromium.org/developers/design-documents/multi-process-resource-

[chromium-dev] Re: sandboxing external libraries (like Growl)

2009-06-18 Thread Thomas Van Lenten
On Thu, Jun 18, 2009 at 4:58 PM, John Gregg wrote: > Hi all, > > I'm working on a desktop notifications javascript API for web apps; on Mac > these calls will go out to the Growl notification system if it's installed > and user has granted permission to get notifications from that origin. I'm >

[chromium-dev] Re: Makefile build broken

2009-06-11 Thread Thomas Van Lenten
On Thu, Jun 11, 2009 at 12:48 PM, Adam Langley wrote: > > On Thu, Jun 11, 2009 at 8:52 AM, Tony Chang wrote: > > Albert, what do you think? I estimate that about 5-7 people on the > > linux team use the make build these days. > > I reverted in r18168. It sucks that there's no try or builders for

[chromium-dev] Re: Adding Mac OS X Spellchecker to Chromium

2009-06-10 Thread Thomas Van Lenten
On Wed, Jun 10, 2009 at 2:38 PM, p_W wrote: > > Forgive my (possibly) stupid concern here, but a few months ago there > was some talk about this, and about how integrating with the OS's > spellchecker was the preferred route as it allowed users to use their > dictionary customizations over all th

[chromium-dev] Re: confused with chrome's version control

2009-06-09 Thread Thomas Van Lenten
>From the very end of http://dev.chromium.org/developers/how-tos/get-the-code gclient sync --revision s...@ TVL On Tue, Jun 9, 2009 at 9:27 AM, Jickae Davis wrote: > And I also encountered a new question. > > How to update to certain revision of different > kinds(snapshot/continuous/tarb

[chromium-dev] Re: confused with chrome's version control

2009-06-09 Thread Thomas Van Lenten
On Tue, Jun 9, 2009 at 9:25 AM, Jickae Davis wrote: > After carefully check, I think I am confused about continuous and snapshot, > :(. > > Amanda said: > continuous: ever time anyone checks in a change, we have a continuous build > system that checks out the change and tries to build Chromium. >

[chromium-dev] Continuous builds

2009-06-08 Thread Thomas Van Lenten
The continuous build scripts have been updated to handle all three platforms. If you take the link on the top left of the waterfall pages, you'll go a listing that now includes directories for each platform. Each platform dir then has a LATEST link within it (the LATEST outside of the platform di

[chromium-dev] Build Bots

2009-06-05 Thread Thomas Van Lenten
Just a quick heads up, a new block of Mac Mini's are now online on both the main waterfall and the fyi waterfall. We now have builders/testers for a bunch of configs, as well as some jobs split between machines. Hopefully this will lower the Mac cycle times. This also gets the perf data we collec

[chromium-dev] Re: Does anyone have objections to adding a GetSwitchValues() accessor to CommandLine?

2009-06-03 Thread Thomas Van Lenten
On Wed, Jun 3, 2009 at 12:06 AM, Book'em Dano wrote: > > Does anyone have objections to including such a function? It would > just return a copy of std::map switches_; > > I'd like to add such a function so that I can iterate over the command > line args (both switches and loose values) and valid

[chromium-dev] Re: Is there any way to profile chromium on MacOS?

2009-06-02 Thread Thomas Van Lenten
On Tue, Jun 2, 2009 at 12:25 PM, Lucius Fox wrote: > > I can build and debug TestShell project. But can you please tell me > how to attach appropriate renderer with Shark? > What is an appropriate renderer? TestShell doesn't do the out of process model, all rendering is done inproc with TestShe

[chromium-dev] Re: Which is the Xcode project for chromium on MacOS

2009-05-26 Thread Thomas Van Lenten
On Tue, May 26, 2009 at 1:37 PM, Daniel Dreiberg < daniel.dreiber...@gmail.com> wrote: > Hi, > Can you please tell me where i can find Xcode project for chromium on > MacOS? > I tried $chromium_src_root/src/chrome/chrome.xcodeproj, but that does not > seem to have html parser code, javascript engi

[chromium-dev] Process Names

2009-05-14 Thread Thomas Van Lenten
Just a quick heads up, later today I'll be landing some initial fixes for code that cared about the application's name. If you find yourself needing this, look carefully at why and what you're using. The Mac version is going to need a little more work to get the final branding right in all places

[chromium-dev] Re: How can I run TestShell in Xcode on MacOS

2009-04-30 Thread Thomas Van Lenten
When in doubt, read the website: http://code.google.com/p/chromium/wiki/MacBuildInstructions TVL On Wed, Apr 29, 2009 at 9:53 PM, daniel wrote: > > Hi, > > How can I run TestShell in Xcode on MacOS? Which xcode project I > should use? > > I find these: > ./src/base/base.xcodeproj > ./src/breakp

[chromium-dev] Re: Changes to FilePath?

2009-04-28 Thread Thomas Van Lenten
On Tue, Apr 28, 2009 at 4:39 PM, Greg Spencer wrote: > Hi Chromium Developers, > > I'm working on Google's O3D (http://code.google.com/p/o3d), and we > (naturally) share some of Chrome's base classes for our code, including the > very useful class FilePath. > > However, in using FilePath in the l

[chromium-dev] Re: chromium resources always rebuilding

2009-04-28 Thread Thomas Van Lenten
The deps for all the files generated is a problem, Mark and I have talked about it a few times, but haven't come up with something complete for it yet, hopefully it will pop back up on our queues shortly so we can figure out something more complete. TVL On Mon, Apr 27, 2009 at 6:14 PM, Evan Mart

[chromium-dev] Re: Crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-04-27 Thread Thomas Van Lenten
On Fri, Apr 24, 2009 at 4:55 PM, Никита Офицеров wrote: > > There are now different platform-dependent ways to ensure that only > one instance of Chrome is running, and to get its pid. > I think that there is a way of accomplishing both goals in a > cross-platform way, reusing existing IPC system

[chromium-dev] Re: release builders now run webkit tests in parallel

2009-04-09 Thread Thomas Van Lenten
n Thu, Apr 9, 2009 at 9:11 AM, Thomas Van Lenten > wrote: > >> fyi -Some failures will happen on the Macs because test_shell >> sets/restores user settings on startup/shutdown, so having more then one >> running can cause things to fail as one exits changing state on another

[chromium-dev] Re: release builders now run webkit tests in parallel

2009-04-09 Thread Thomas Van Lenten
fyi -Some failures will happen on the Macs because test_shell sets/restores user settings on startup/shutdown, so having more then one running can cause things to fail as one exits changing state on another that's running. It's on my list to move into a helper app so it can be done around the whol

[chromium-dev] Re: Fwd: variant definitions in the .gyp files

2009-04-02 Thread Thomas Van Lenten
So we'd take the product of variants and configuration? I don't think we can do official this way because we need to modify sources lists, so official would stay controlled by a variable for the whole tree. I think your link changes would actually have to be w/in a tagert_conditional blocks so th

[chromium-dev] Re: Chromium App Executables Disk Layout

2009-03-29 Thread Thomas Van Lenten
Most mac apps solve this by having the app exit as part of the upgrade process, this way a new copy is launched w/ the new resources. On Sun, Mar 29, 2009 at 4:40 AM, John Grabowski wrote: > >> How will in-place updating work on the Mac and Linux? >> > > To be frank, we haven't solved this proble

[chromium-dev] Re: Chromium App Executables Disk Layout

2009-03-24 Thread Thomas Van Lenten
ays to trust the binary, the signature allows that to stay across updates (if the sig is the same). TVL > > > -George > > On Tue, Mar 24, 2009 at 11:45 AM, Thomas Van Lenten > wrote: > > The Windows product builds a small executable that then loads the main > > ch

[chromium-dev] Chromium App Executables Disk Layout

2009-03-24 Thread Thomas Van Lenten
The Windows product builds a small executable that then loads the main chromium dll, and hands off control to that. I believe this is done solely for updating reasons. All the difference processes start from that one shim. On the Mac, we are currently building as a single executable. But, this

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Thomas Van Lenten
On Tue, Mar 24, 2009 at 1:00 PM, Amanda Walker wrote: > 2009/3/24 John Abd-El-Malek : > > Right, this is used so that if the user starts Chrome a second time, it > > tells the currently running exe to open a new tab. This is the standard > way > > of doing it on Windows, but I don't know how Mac

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Thomas Van Lenten
A bunch of process handle code is something we're gonna need to look very carefully at. The filtering via names may be valid on Windows, but on Linux, a user could have Chromium running twice (with different profiles/user data dirs) pointing at different displays, so we'll have to be very careful

[chromium-dev] Re: Uploading new Patch to the existing issue.

2009-03-23 Thread Thomas Van Lenten
if you're using gcl, and use the same name for the issue (gcl upload [change_name]), it should do that for you. If you're using the upload.py script directly, then it takes a -i [issue_num]. TVL On Mon, Mar 23, 2009 at 10:16 AM, DeArto20 wrote: > > I wanna upload new patch to the existing issu

  1   2   >