Re: RFR: 8332550: [macos] Voice Over: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location [v4]

2024-06-06 Thread Alexander Zuev
On Thu, 6 Jun 2024 09:17:13 GMT, Abhishek Kumar wrote: >> "java.awt.IllegalComponentStateException: component must be showing on the >> screen to determine its location" is thrown when getLocationOnScreen method >> is invoked for JTableHeader while testing JFileChooser demo. It seems that >>

Re: RFR: 8332550: [macos] Voice Over: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location [v2]

2024-06-06 Thread Alexander Zuev
On Thu, 6 Jun 2024 05:11:41 GMT, Abhishek Kumar wrote: >> src/java.desktop/share/classes/javax/swing/table/JTableHeader.java line 1368: >> >>> 1366: try { >>> 1367: parentLocation = parent.getLocationOnScreen(); >>> 1368: } catch

Re: RFR: 8280990: [XWayland] XTest emulated mouse click does not bring window to front

2024-06-03 Thread Alexander Zuev
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev wrote: > Some of the modal tests fail in X11 compatibility mode on Wayland, because a > mouse click emulated with XTEST does not not cause the windows to be > reordered. > > This is a known limitation because these click events do not

Re: RFR: 8332431: NullPointerException in JTable of SwingSet2 [v2]

2024-05-28 Thread Alexander Zuev
On Tue, 28 May 2024 02:59:24 GMT, Prasanta Sadhukhan wrote: >> Issue is observed in JTable demo in SwingSet2 whereby if we set the focus on >> a table cell (or click on a table cell) and Press Ctrl+F1 (show/hide >> tooltip) on a cell of JTable then NullpointerException is seen >> >>>

Integrated: 8329667: [macos] Issue with JTree related fix for JDK-8317771

2024-05-24 Thread Alexander Zuev
On Thu, 16 May 2024 01:28:37 GMT, Alexander Zuev wrote: > Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no l

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-24 Thread Alexander Zuev
On Wed, 22 May 2024 06:38:26 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-24 Thread Alexander Zuev
On Thu, 23 May 2024 12:45:31 GMT, Artem Semenov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Replaced NULL with nil in OutlineAccessibility - functionally it has no >>

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-23 Thread Alexander Zuev
On Wed, 22 May 2024 11:17:26 GMT, Abhishek Kumar wrote: >> In multilevel trees when someone in the parent's path is collapsed the >> treeCollapsed event will be delivered to that node. We can either invalidate >> all leaf nodes caches (which is costly) or mark that exact node's cache as >>

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-22 Thread Alexander Zuev
On Tue, 21 May 2024 08:47:04 GMT, Abhishek Kumar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - Remove unused import; > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/Out

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-22 Thread Alexander Zuev
> Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no longer needed; Alexander Zuev has updated the

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v2]

2024-05-20 Thread Alexander Zuev
On Mon, 20 May 2024 07:16:49 GMT, Artem Semenov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - Removed the unused import in CAccessibility.java >> - Rolled back changes to th

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-20 Thread Alexander Zuev
> Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no longer needed; Alexander Zuev has updated the

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-20 Thread Alexander Zuev
On Fri, 17 May 2024 10:00:08 GMT, Abhishek Kumar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - Remove unused import; > > src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccess

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v2]

2024-05-19 Thread Alexander Zuev
> Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no longer needed; Alexander Zuev has updated the

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771

2024-05-19 Thread Alexander Zuev
On Sat, 18 May 2024 18:39:42 GMT, Artem Semenov wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer

RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771

2024-05-15 Thread Alexander Zuev
Caching children and selected children of the thee on the native level; Caching all children of a specific parent in CAccessibility to enhance recursive children selection algorithm; Removing fix for JDK-8317771 as no longer needed; - Commit messages: - 8329667: [macos] Issue with

Re: RFR: 8323965: modify fix for 8317771 to remove reflection instantiation of the inner class

2024-04-24 Thread Alexander Zuev
On Fri, 19 Apr 2024 15:16:41 GMT, Artem Semenov wrote: > I replaced reflection with using an accessor > @azuev-java please review src/java.desktop/share/classes/javax/swing/JTree.java line 4276: > 4274: > 4275: static { > 4276:

Re: RFR: 8323965: modify fix for 8317771 to remove reflection instantiation of the inner class

2024-04-22 Thread Alexander Zuev
On Fri, 19 Apr 2024 15:16:41 GMT, Artem Semenov wrote: > I replaced reflection with using an accessor > @azuev-java please review The problem with this fix is that on the test example attached to the bug any attempt of navigation trough the items of JTree whole voice over is enabled causes

Integrated: 8316324: Opensource five miscellaneous Swing tests

2024-03-25 Thread Alexander Zuev
On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev wrote: > Clean up and opensource five tests. This pull request has now been integrated. Changeset: 7560dbb9 Author: Alexander Zuev URL: https://git.openjdk.org/jdk/commit/7560dbb9258f651a221bc8350816845735929fd9 Stats: 572 li

Re: RFR: 8316324: Opensource five miscellaneous Swing tests [v3]

2024-03-25 Thread Alexander Zuev
> Clean up and opensource five tests. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Make test fail if it can not instantiate required look and feel; - Changes: - all: https://git.openjdk.org/jdk/pull/18443/fi

Re: RFR: 8316324: Opensource five miscellaneous Swing tests [v2]

2024-03-25 Thread Alexander Zuev
On Mon, 25 Mar 2024 21:24:13 GMT, Phil Race wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removing image file as not needed, generating ImageIcon instead; >> Moved test file fr

Integrated: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main

2024-03-25 Thread Alexander Zuev
On Mon, 18 Mar 2024 20:52:00 GMT, Alexander Zuev wrote: > Convert test to a main method based; > Move test to an apropriate location; > Remove old files; This pull request has now been integrated. Changeset: c7cf6020 Author:Alexander Zuev URL: https://git.openjdk.org/j

Re: RFR: 8316324: Opensource five miscellaneous Swing tests [v2]

2024-03-25 Thread Alexander Zuev
> Clean up and opensource five tests. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Removing image file as not needed, generating ImageIcon instead; Moved test file from the dedicated folder siince it is no longer nee

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-25 Thread Alexander Zuev
On Sat, 23 Mar 2024 23:59:42 GMT, Phil Race wrote: >> It is just a gif file filled with yellow color created specifically for that >> test. It was not provided by the test submitter or anything like that - it >> was just created in the graphics editor. There's no copyright issue with it. > >

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-25 Thread Alexander Zuev
On Sun, 24 Mar 2024 00:00:25 GMT, Phil Race wrote: >> test/jdk/javax/swing/InputVerifier/bug4774166.java line 229: >> >>> 227: public void cleanupGUI() { >>> 228: if (testframe != null) { >>> 229: testframe.setVisible(false); >> >> `testframe.setVisible(false);` is

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Alexander Zuev
On Fri, 22 Mar 2024 09:01:01 GMT, Tejesh R wrote: >> Clean up and opensource five tests. > > test/jdk/javax/swing/InputVerifier/bug4774166.java line 144: > >> 142: public void performTest() throws InterruptedException, >> InvocationTargetException { >> 143: robot.setAutoDelay(100);

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Alexander Zuev
On Fri, 22 Mar 2024 07:02:05 GMT, Prasanta Sadhukhan wrote: >> Clean up and opensource five tests. > > test/jdk/javax/swing/JButton/4385611/bug4385611.java line 42: > >> 40: public class bug4385611 { >> 41: static JButton bt1, bt2; >> 42: static final ImageIcon icon32x32 = new >>

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Alexander Zuev
On Fri, 22 Mar 2024 09:04:28 GMT, Tejesh R wrote: >> Clean up and opensource five tests. > > test/jdk/javax/swing/InputVerifier/bug4774166.java line 165: > >> 163: robot.hitKey(KeyEvent.VK_M); >> 164: robot.hitKey(KeyEvent.VK_N); >> 165: robot.hitKey(KeyEvent.VK_O); > >

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Alexander Zuev
On Fri, 22 Mar 2024 06:57:12 GMT, Prasanta Sadhukhan wrote: >> Clean up and opensource five tests. > > test/jdk/javax/swing/InputVerifier/bug4774166.java line 44: > >> 42: * @summary InputVerifier should be called after a window loses and then >> regains focus >> 43: * @library

Integrated: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main

2024-03-22 Thread Alexander Zuev
On Mon, 18 Mar 2024 20:36:53 GMT, Alexander Zuev wrote: > Convert test to a main based; > Move test to an appropriate folder; > Remove old files; This pull request has now been integrated. Changeset: b7a51dd0 Author:Alexander Zuev URL: https://git.openjdk.org/j

Re: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main [v5]

2024-03-22 Thread Alexander Zuev
> Convert test to main manual; > Move test to appropriate folder; > Delete old files; Alexander Zuev has updated the pull request incrementally with two additional commits since the last revision: - Moving toolkit checkto the beginning of the main method. - Update test/jdk/java/awt/F

Integrated: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main

2024-03-22 Thread Alexander Zuev
On Mon, 18 Mar 2024 20:45:03 GMT, Alexander Zuev wrote: > Convert test to main manual; > Move test to appropriate folder; > Delete old files; This pull request has now been integrated. Changeset: 739957ca Author:Alexander Zuev URL: https://git.openjdk.org/j

Re: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main [v2]

2024-03-21 Thread Alexander Zuev
On Thu, 21 Mar 2024 20:22:18 GMT, Alexander Zvegintsev wrote: >> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 59: >> >>> 57: frame.add(textScrollPane, BorderLayout.CENTER); >>> 58: >>> 59: fd = new FileDialog(new Frame(), "Open"); >> >> is there any need to

Re: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main [v2]

2024-03-21 Thread Alexander Zuev
On Thu, 21 Mar 2024 16:16:55 GMT, Prasanta Sadhukhan wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adding library and build clauses > > test/jdk/java/awt/FileDialog/File

Re: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main [v3]

2024-03-21 Thread Alexander Zuev
> Convert test to a main based; > Move test to an appropriate folder; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Got rid of the test window, using OassFailJFrame instead; Made all variables local

RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-21 Thread Alexander Zuev
Clean up and opensource five tests. - Commit messages: - 8316324: Opensource five miscellaneous Swing tests Changes: https://git.openjdk.org/jdk/pull/18443/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18443=00 Issue: https://bugs.openjdk.org/browse/JDK-8316324 Stats:

Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029

2024-03-21 Thread Alexander Zuev
On Wed, 20 Mar 2024 22:48:46 GMT, Alisen Chung wrote: > Removing applet usage from manual JFileChooser tests test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 111: > 109: } finally { > 110: if (!res) { > 111: throw new

Re: RFR: 8328570: Convert closed JViewport manual applet tests to main [v4]

2024-03-21 Thread Alexander Zuev
On Thu, 21 Mar 2024 14:42:49 GMT, Prasanta Sadhukhan wrote: >> Few closed manual applet JViewport tests are converted to main based and >> opensourced > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > formatting

Re: RFR: 8328570: Convert closed JViewport manual applet tests to main [v3]

2024-03-21 Thread Alexander Zuev
On Thu, 21 Mar 2024 11:37:01 GMT, Prasanta Sadhukhan wrote: >> Few closed manual applet JViewport tests are converted to main based and >> opensourced > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > formatting

Re: RFR: 8328570: Convert closed JViewport manual applet tests to main [v3]

2024-03-21 Thread Alexander Zuev
On Thu, 21 Mar 2024 11:37:01 GMT, Prasanta Sadhukhan wrote: >> Few closed manual applet JViewport tests are converted to main based and >> opensourced > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > formatting

Re: RFR: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization

2024-03-21 Thread Alexander Zuev
On Thu, 21 Mar 2024 13:02:29 GMT, Alexander Zvegintsev wrote: > Two tests may fail intermittently on Wayland, the standard `waitForIdle` and > `delay` fixes the issue. > > Manual and CI testing looks good. Marked as reviewed by kizune (Reviewer). Since you are editing these files you can

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v3]

2024-03-20 Thread Alexander Zuev
On Wed, 20 Mar 2024 17:21:13 GMT, Damon Nguyen wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moved test metadate closer to the class definition; >> Made variables local;

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v4]

2024-03-20 Thread Alexander Zuev
> Convert test to a main method based; > Move test to an apropriate location; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Remove .html from the @test clause - Changes: - a

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v3]

2024-03-20 Thread Alexander Zuev
On Wed, 20 Mar 2024 17:23:36 GMT, Damon Nguyen wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moved test metadate closer to the class definition; >> Made variables local;

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v3]

2024-03-20 Thread Alexander Zuev
> Convert test to a main method based; > Move test to an apropriate location; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Moved test metadate closer to the class definition; Made variables loca

Re: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main [v4]

2024-03-20 Thread Alexander Zuev
> Convert test to main manual; > Move test to appropriate folder; > Delete old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Moving test metadata closer to the class definition for better readability; Ma

Integrated: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main

2024-03-20 Thread Alexander Zuev
On Mon, 18 Mar 2024 21:00:36 GMT, Alexander Zuev wrote: > Convert applet based test to a main based test; > Move test to an apporpriate location; > Remove old files; This pull request has now been integrated. Changeset: e5e7cd20 Author:Alexander Zuev URL: https://git.op

Integrated: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main

2024-03-20 Thread Alexander Zuev
On Mon, 18 Mar 2024 17:59:37 GMT, Alexander Zuev wrote: > Convert test to manual main and move from the dedicated folder > Remove old files This pull request has now been integrated. Changeset: 1b68c731 Author:Alexander Zuev URL: https://git.openjdk.org/jdk/

Re: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main [v4]

2024-03-20 Thread Alexander Zuev
> Convert test to manual main and move from the dedicated folder > Remove old files Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Made colors variable local. - Changes: - all: https://git.openjdk.org/jd

Integrated: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main

2024-03-20 Thread Alexander Zuev
On Mon, 18 Mar 2024 18:16:08 GMT, Alexander Zuev wrote: > Convert test to main manual and move to the appropriate folder > Remove old files This pull request has now been integrated. Changeset: e0373e01 Author:Alexander Zuev URL: https://git.openjdk.org/jdk/

Integrated: 8328367: Convert java/awt/Component/UpdatingBootTime test to main

2024-03-20 Thread Alexander Zuev
On Mon, 18 Mar 2024 17:32:04 GMT, Alexander Zuev wrote: > Convert test to manual main > Move test to the Component folder This pull request has now been integrated. Changeset: 03c25b15 Author:Alexander Zuev URL: https://git.openjdk.org/jdk/

Re: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main [v3]

2024-03-20 Thread Alexander Zuev
On Tue, 19 Mar 2024 23:17:04 GMT, Alexander Zvegintsev wrote: >> Alexander Zuev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java >> &

Re: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main [v5]

2024-03-20 Thread Alexander Zuev
> Convert applet based test to a main based test; > Move test to an apporpriate location; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: More fixes based on review. - Changes: - a

Re: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main [v4]

2024-03-19 Thread Alexander Zuev
> Convert applet based test to a main based test; > Move test to an apporpriate location; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.jav

Re: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main [v3]

2024-03-19 Thread Alexander Zuev
> Convert test to main manual; > Move test to appropriate folder; > Delete old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Update test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java Co-authored-b

Re: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main [v3]

2024-03-19 Thread Alexander Zuev
On Wed, 20 Mar 2024 03:13:19 GMT, Prasanta Sadhukhan wrote: >> test/jdk/java/awt/FileDialog/FileDialogForDirectories.java line 43: >> >>> 41: public class FileDialogForDirectories { >>> 42: private static Button showBtn; >>> 43: private static FileDialog fd; >> >> Can be made local in

Re: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main [v3]

2024-03-19 Thread Alexander Zuev
> Convert test to main manual and move to the appropriate folder > Remove old files Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Made fd and showBtn variables local. - Changes: - all: https://git.openjdk.o

Re: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main [v2]

2024-03-19 Thread Alexander Zuev
On Tue, 19 Mar 2024 07:49:39 GMT, Prasanta Sadhukhan wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adding library and build clauses > > test/jdk/java/awt/FileDialog/FileDia

Re: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main [v2]

2024-03-19 Thread Alexander Zuev
On Wed, 20 Mar 2024 03:15:36 GMT, Prasanta Sadhukhan wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adding library and build clauses > > test/jdk/java/awt/Cursor/MultiRes

Re: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main [v3]

2024-03-19 Thread Alexander Zuev
> Convert test to manual main and move from the dedicated folder > Remove old files Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Removing setLocation() on frame; - Changes: - all: https://git.openjdk.org/jd

Re: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main [v3]

2024-03-19 Thread Alexander Zuev
On Tue, 19 Mar 2024 15:18:24 GMT, Alexander Zvegintsev wrote: >> Alexander Zuev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java >> &

Re: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main [v3]

2024-03-19 Thread Alexander Zuev
> Convert applet based test to a main based test; > Move test to an apporpriate location; > Remove old files; Alexander Zuev has updated the pull request incrementally with two additional commits since the last revision: - Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java

Re: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main [v2]

2024-03-19 Thread Alexander Zuev
> Convert applet based test to a main based test; > Move test to an apporpriate location; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java

Re: RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to main [v3]

2024-03-19 Thread Alexander Zuev
> Convert test to manual main > Move test to the Component folder Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Fixing instructions. - Changes: - all: https://git.openjdk.org/jdk/pull/18355/files - new:

Re: RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to main [v3]

2024-03-19 Thread Alexander Zuev
On Tue, 19 Mar 2024 06:00:56 GMT, Prasanta Sadhukhan wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixing instructions. > > test/jdk/java/awt/Component/UpdatingBootTime.java lin

RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main

2024-03-19 Thread Alexander Zuev
Convert applet based test to a main based test; Move test to an apporpriate location; Remove old files; - Commit messages: - Addid library and build clauses; - 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main Changes:

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v2]

2024-03-19 Thread Alexander Zuev
> Convert test to a main method based; > Move test to an apropriate location; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Adding library and build clauses - Changes: - a

Re: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main [v2]

2024-03-19 Thread Alexander Zuev
> Convert test to a main based; > Move test to an appropriate folder; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Adding library and build clauses - Changes: - all: https://git.op

Re: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main [v2]

2024-03-19 Thread Alexander Zuev
> Convert test to main manual; > Move test to appropriate folder; > Delete old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Adding library and build clauses - Changes: - all: https://git.openjd

Re: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main [v2]

2024-03-19 Thread Alexander Zuev
> Convert test to main manual and move to the appropriate folder > Remove old files Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Adding library and build clauses - Changes: - all: https://git.openjdk.org/jd

Re: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main [v2]

2024-03-19 Thread Alexander Zuev
> Convert test to manual main and move from the dedicated folder > Remove old files Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Adding library and build clauses - Changes: - all: https://git.openjdk.org/jd

Re: RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to main [v2]

2024-03-19 Thread Alexander Zuev
> Convert test to manual main > Move test to the Component folder Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Adding a tibrary abd build clauses - Changes: - all: https://git.openjdk.org/jdk/pull/18355

Integrated: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main

2024-03-19 Thread Alexander Zuev
On Fri, 15 Mar 2024 16:13:33 GMT, Alexander Zuev wrote: > Converted to a main manual test. This pull request has now been integrated. Changeset: 2094ff3c Author: Alexander Zuev URL: https://git.openjdk.org/jdk/commit/2094ff3c7ad829355bf13760d9a19b37649b3517 Stats: 348 lines i

RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main

2024-03-18 Thread Alexander Zuev
Convert test to a main method based; Move test to an apropriate location; Remove old files; - Commit messages: - 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main Changes: https://git.openjdk.org/jdk/pull/18363/files Webrev:

RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main

2024-03-18 Thread Alexander Zuev
Convert test to main manual; Move test to appropriate folder; Delete old files; - Commit messages: - Reorganize imports. - 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main Changes: https://git.openjdk.org/jdk/pull/18361/files Webrev:

RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main

2024-03-18 Thread Alexander Zuev
Convert test to a main based; Move test to an appropriate folder; Remove old files; - Commit messages: - Reorganize imports. - 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main Changes: https://git.openjdk.org/jdk/pull/18360/files Webrev:

RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main

2024-03-18 Thread Alexander Zuev
Convert test to main manual and move to the appropriate folder Remove old files - Commit messages: - 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main Changes: https://git.openjdk.org/jdk/pull/18358/files Webrev:

RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main

2024-03-18 Thread Alexander Zuev
Convert test to manual main and move from the dedicated folder Remove old files - Commit messages: - 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main Changes: https://git.openjdk.org/jdk/pull/18357/files Webrev:

Re: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main [v2]

2024-03-18 Thread Alexander Zuev
On Mon, 18 Mar 2024 08:24:31 GMT, Abhishek Kumar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixes based on review feedback > > test/jdk/java/awt/Cursor/CursorOverlappedPan

Re: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main [v3]

2024-03-18 Thread Alexander Zuev
> Converted to a main manual test. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Additional fixes based on review - Changes: - all: https://git.openjdk.org/jdk/pull/18331/files - new: https://git.openjdk.org/

RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to main

2024-03-18 Thread Alexander Zuev
Convert test to manual main Move test to the Component folder - Commit messages: - 8328367: Convert java/awt/Component/UpdatingBootTime test to main Changes: https://git.openjdk.org/jdk/pull/18355/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18355=00 Issue:

Re: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main [v2]

2024-03-17 Thread Alexander Zuev
> Converted to a main manual test. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Fixes based on review feedback - Changes: - all: https://git.openjdk.org/jdk/pull/18331/files - new: https://git.openjdk.org/

Re: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main [v2]

2024-03-17 Thread Alexander Zuev
On Sat, 16 Mar 2024 00:44:12 GMT, Harshitha Onkar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixes based on review feedback > > test/jdk/java/awt/Cursor/CursorOverlappedPan

RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main

2024-03-16 Thread Alexander Zuev
Converted to a main manual test. - Commit messages: - Correct the run clause of the test - Added a line to separate two methods - 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main Changes: https://git.openjdk.org/jdk/pull/18331/files Webrev:

Re: RFR: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet test to main

2024-03-15 Thread Alexander Zuev
On Thu, 14 Mar 2024 16:04:50 GMT, Tejesh R wrote: >> test/jdk/sun/java2d/loops/CopyAreaSpeed.java line 131: >> >>> 129: } >>> 130: try { >>> 131: Thread.sleep(1); >> >> I know it is an old code but i just wonder why do we add sleep to every >> iteration

Re: RFR: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet test to main

2024-03-15 Thread Alexander Zuev
On Thu, 14 Mar 2024 10:39:15 GMT, Tejesh R wrote: > Convert sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based > using PassFailJFrame. This is a performance measurement test which provide > benchmark to compare the outcome with different releases. I have converted > the

Integrated: 8316388: Opensource five Swing component related regression tests

2024-03-15 Thread Alexander Zuev
On Wed, 13 Mar 2024 06:49:16 GMT, Alexander Zuev wrote: > Cleaned up five more tests. > > Continuation of https://github.com/openjdk/jdk/pull/18184 > > Unfortunately one of the commits rendered the whole PR invalid so i closed it > and restarting it here. > All comme

Integrated: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test

2024-03-15 Thread Alexander Zuev
On Thu, 14 Mar 2024 12:27:29 GMT, Alexander Zuev wrote: > Convert test to the automatic main and move it from its own folder since it > is no longer required. This pull request has now been integrated. Changeset: b8dfeafd Author:Alexander Zuev URL: https://git.openjdk.o

Re: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test [v2]

2024-03-14 Thread Alexander Zuev
On Thu, 14 Mar 2024 16:03:46 GMT, Abhishek Kumar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor fixes > > test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 8

Re: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test [v4]

2024-03-14 Thread Alexander Zuev
> Convert test to the automatic main and move it from its own folder since it > is no longer required. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Minor updates - Changes: - all: https://git.openjdk.o

Re: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test [v3]

2024-03-14 Thread Alexander Zuev
> Convert test to the automatic main and move it from its own folder since it > is no longer required. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Update test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java Co-au

Re: RFR: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet test to main

2024-03-14 Thread Alexander Zuev
On Thu, 14 Mar 2024 10:39:15 GMT, Tejesh R wrote: > Convert sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based > using PassFailJFrame. This is a performance measurement test which provide > benchmark to compare the outcome with different releases. I have converted > the

Re: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test [v2]

2024-03-14 Thread Alexander Zuev
On Thu, 14 Mar 2024 12:39:40 GMT, Abhishek Kumar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor fixes > > test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 4

Re: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test [v2]

2024-03-14 Thread Alexander Zuev
On Thu, 14 Mar 2024 12:41:20 GMT, Abhishek Kumar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor fixes > > test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line

Re: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test [v2]

2024-03-14 Thread Alexander Zuev
> Convert test to the automatic main and move it from its own folder since it > is no longer required. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Minor fixes - Changes: - all: https://git.openjdk.org/jd

Re: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test

2024-03-14 Thread Alexander Zuev
On Thu, 14 Mar 2024 12:42:00 GMT, Abhishek Kumar wrote: >> Convert test to the automatic main and move it from its own folder since it >> is no longer required. > > test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 74: > >> 72:

Re: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test

2024-03-14 Thread Alexander Zuev
On Thu, 14 Mar 2024 12:40:59 GMT, Abhishek Kumar wrote: >> Convert test to the automatic main and move it from its own folder since it >> is no longer required. > > test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 65: > >> 63: }); >> 64: robot.waitForIdle(); >> 65:

RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test

2024-03-14 Thread Alexander Zuev
Convert test to the automatic main and move it from its own folder since it is no longer required. - Commit messages: - 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test Changes: https://git.openjdk.org/jdk/pull/18300/files Webrev:

Re: RFR: 8316388: Opensource five Swing component related regression tests [v4]

2024-03-14 Thread Alexander Zuev
On Thu, 14 Mar 2024 09:31:39 GMT, Alexey Ivanov wrote: >> This is try-with-resources so if i will do it in main i will have to add >> synchronizing and closing of writer which is a strange trade-off so i would >> have to do try block anyways. > > Why would you need synchronisation? > > >

Re: RFR: 8316388: Opensource five Swing component related regression tests [v3]

2024-03-14 Thread Alexander Zuev
On Thu, 14 Mar 2024 09:59:43 GMT, Alexey Ivanov wrote: >> test/jdk/javax/swing/JEditorPane/bug4325606.java line 100: >> >>> 98: Utilities.getRowStart(pane, pane.getCaretPosition()); >>> 99: } catch (BadLocationException blex) { >>> 100: throw new

  1   2   3   4   >