On Tue, 5 Dec 2023 07:59:19 GMT, Prasanta Sadhukhan
wrote:
>> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
>> field isn't declared as volatile. Without the volatile modifier,
>> double-checked locking implementation is broken.
>
> Prasanta Sadhukhan has updated
On Tue, 5 Dec 2023 12:17:55 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>> directori
On Tue, 5 Dec 2023 07:55:22 GMT, Prasanta Sadhukhan
wrote:
> > > > It is probably easy just drop the usage of loadedImage and use the
> > > > image instead?
> > >
> > >
> > > Ideally. Yet there's a corner case: if `url` is null, there's nothing to
> > > load; and it doesn't make sense to re-
On Mon, 4 Dec 2023 20:42:48 GMT, Sergey Bylokhov wrote:
> It is probably easy just drop the usage of loadedImage and use the image
> instead?
Ideally. Yet there's a corner case: if `url` is null, there's nothing to load;
and it doesn't make sense to re-try, the URL won't change. If it were not
On Wed, 22 Nov 2023 05:42:24 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>> director
On Mon, 4 Dec 2023 20:52:28 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test update
>
> test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirec
On Thu, 23 Nov 2023 11:53:00 GMT, Abhishek Kumar wrote:
>>> But the files gets deselected after selection which returns as no file
>>> selected and test failed.
>>
>> How is it? It sounds like magic… The working directory shouldn't matter; if
>> it does, the test isn't as stable as it should b
On Mon, 4 Dec 2023 06:30:01 GMT, Prasanta Sadhukhan
wrote:
> > That code does not look like double-checked lock, it is something
> > different. It checks/init/sets one field and then returns another one. Even
> > if both will be marked as volatile the method may return null, since the
> > loa
On Fri, 1 Dec 2023 06:31:00 GMT, Prasanta Sadhukhan
wrote:
> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
> field isn't declared as volatile. Without the volatile modifier,
> double-checked locking implementation is broken.
Based on my recent comment, the code
On Sat, 2 Dec 2023 20:55:30 GMT, Andrey Turbanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 3016:
>
>> 3014: // adjust the x
On Fri, 1 Dec 2023 06:31:00 GMT, Prasanta Sadhukhan
wrote:
> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
> field isn't declared as volatile. Without the volatile modifier,
> double-checked locking implementation is broken.
Marked as reviewed by aivanov (Review
On Fri, 1 Dec 2023 09:26:41 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Thu, 30 Nov 2023 18:14:21 GMT, Phil Race wrote:
>> That's the reason why I prefer you keep the `@run` tag in `SetOrient.java`:
>> to document that it's *an applet test* — with the html file being the test
>> starter.
>
> Ok, although when I see something like that it looks more like a bug to
On Thu, 30 Nov 2023 17:20:40 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
On Thu, 30 Nov 2023 17:44:11 GMT, Alexey Ivanov wrote:
>> I actually reused it from `JTableHeader` class and yeah it will be
>> `parent.getWidth ` always as of now, but I thought it might be for future
>> purpose, but not sure... Should we retain or just use `parent.getW
On Thu, 30 Nov 2023 17:03:00 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/JTable.java line 9809:
>>
>>> 9807: }
>>> 9808: return super.getWidth();
>>> 9809: }
>>
>> Can you elaborate on why it's needed? Presumably both versions return the
>> same width
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Mon, 27 Nov 2023 18:48:52 GMT, Phil Race wrote:
>> I see `SetOrient.java` has its sibling `SetOrient.html` where you added
>> `@key printer`.
>>
>> Since both files contain all the tags except for `@test` in the .java file,
>> you should not remove the `@run` tag from the .java file and add
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Mon, 27 Nov 2023 18:53:24 GMT, Phil Race wrote:
> I can .. but I am not aware of even a convention to do that ordering.
It's not written anywhere as far as I know. There's [an ongoing
discussion](https://github.com/openjdk/jdk/pull/16674#discussion_r1402082665)
about it in #16674.
https://
On Thu, 30 Nov 2023 10:52:18 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 3013:
>
On Thu, 30 Nov 2023 10:03:47 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
On Wed, 29 Nov 2023 19:14:33 GMT, Alexey Ivanov wrote:
> I can't make the test pass on macOS but it's a different problem.
I've submitted [JDK-8321042](https://bugs.openjdk.org/browse/JDK-8321042):
_Test java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.jav
On Tue, 28 Nov 2023 17:46:19 GMT, Alisen Chung wrote:
>> Updated previous fix (8262945) to work on extendedKeyCodes. Updated
>> AcceleratorTest to use PassFailJFrame instead of Applet
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revisio
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
test/jdk/java/awt/print/PrinterJob/PrintAllFon
On Wed, 22 Nov 2023 13:50:54 GMT, Alexey Ivanov wrote:
>>> And whilst import java.io sorts after java.awt, it is long standing
>>> convention that the "core"
>>> packages (easily distinguished these days as those in the java.base module)
>>> ar
On Thu, 23 Nov 2023 11:27:08 GMT, Alexey Ivanov wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> test
On Thu, 23 Nov 2023 11:53:08 GMT, Alexey Ivanov wrote:
> Having said the above, this test requires its own bug to fix the test.
I submitted [JDK-8320671](https://bugs.openjdk.org/browse/JDK-8320671):
PageFormat/SmallPaperPrinting.java needs three sets of @test tags
-
PR Rev
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
Changes requested by aivanov (Reviewer).
test
On Tue, 21 Nov 2023 21:23:12 GMT, Phil Race wrote:
> For as long as we've had the macOS port, it seems that queries on the
> GraphicsConfiguration associated with
> a printer would give you null for the defaultTransform.
> Clearly this API isn't a popular one to call in such a context else we'd
On Thu, 23 Nov 2023 05:08:29 GMT, Abhishek Kumar wrote:
> But the files gets deselected after selection which returns as no file
> selected and test failed.
How is it? It sounds like magic… The working directory shouldn't matter; if it
does, the test isn't as stable as it should be.
-
On Wed, 13 Sep 2023 14:42:59 GMT, Alexey Ivanov wrote:
> The manual test frame does not provide any layout managers for test windows,
> the user has to implement one. This demonstrates how to position a several
> test UI windows.
>
> We may include some implementations into
On Wed, 13 Sep 2023 18:50:54 GMT, Alexey Ivanov wrote:
>> The manual test frame does not provide any layout managers for test windows,
>> the user has to implement one. This demonstrates how to position a several
>> test UI windows.
>>
>> We may include some i
On Wed, 22 Nov 2023 04:25:38 GMT, Abhishek Kumar wrote:
>> JProgressBar is always painted with border irrespective of the value set via
>> the API `setBorderPainted(boolean value)` in Synth (Nimbus and GTK) LAF.
>> Proposed fix is to add a check before painting the component.
>>
>> CI jobs are
On Wed, 22 Nov 2023 03:27:01 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JProgressBar/TestProgressBarBorder.java line 28:
>>
>>> 26: import java.lang.reflect.InvocationTargetException;
>>> 27: import java.awt.Graphics;
>>> 28: import java.awt.image.BufferedImage;
>>
>> IDEA at my end dis
On Wed, 22 Nov 2023 13:36:31 GMT, Alexey Ivanov wrote:
>> Updated.
>
>> And whilst import java.io sorts after java.awt, it is long standing
>> convention that the "core"
>> packages (easily distinguished these days as those in the java.base module)
&
On Thu, 16 Nov 2023 05:14:21 GMT, Abhishek Kumar wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java
>> line 46:
>>
>>> 44: * @run main TestFileChooserSingleDirectorySelection
>>> 45: */
>>> 46:
>>
>> I don't know why it was necessary to move all arou
On Wed, 22 Nov 2023 05:37:55 GMT, Abhishek Kumar wrote:
> For some reasons when I used the `current directory i.e. scratch`, test
> failed in my local machine. `String tmpDir = System.getProperty(".");`
How does it fail?
Is it because `System.getProperty(".")` returns `null`? The property `".
On Wed, 22 Nov 2023 06:42:49 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java line
>> 2031:
>>
>>> 2029: damagedArea.x =
>>> SwingUtilities2.getXPosInRightToLeft(table, cMin);
>>> 2030: } else {
>>> 2031: damagedAre
On Wed, 22 Nov 2023 07:04:01 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java line
>> 2108:
>>
>>> 2106: paintCell(g, cellRect, row, column);
>>> 2107: }
>>> 2108: cellRect.x += column
On Tue, 21 Nov 2023 17:59:02 GMT, Abhishek Kumar wrote:
>> JProgressBar is always painted with border irrespective of the value set via
>> the API `setBorderPainted(boolean value)` in Synth (Nimbus and GTK) LAF.
>> Proposed fix is to add a check before painting the component.
>>
>> CI jobs are
On Tue, 21 Nov 2023 08:42:43 GMT, Abhishek Kumar wrote:
>> JProgressBar is always painted with border irrespective of the value set via
>> the API `setBorderPainted(boolean value)` in Synth (Nimbus and GTK) LAF.
>> Proposed fix is to add a check before painting the component.
>>
>> CI jobs are
On Tue, 21 Nov 2023 08:42:43 GMT, Abhishek Kumar wrote:
>> JProgressBar is always painted with border irrespective of the value set via
>> the API `setBorderPainted(boolean value)` in Synth (Nimbus and GTK) LAF.
>> Proposed fix is to add a check before painting the component.
>>
>> CI jobs are
On Tue, 21 Nov 2023 16:47:10 GMT, Abhishek Kumar wrote:
> > Do they need to be? I mean you can do everything on EDT, even throw the
> > exception from there.
>
> Yeah, everything can be done on EDT but what is the advantage of that?
Less code, all the variables are local in one method, no need
On Tue, 21 Nov 2023 16:54:28 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java line
>> 2031:
>>
>>> 2029: damagedArea.x =
>>> SwingUtilities2.getXPosInRightToLeft(table, cMin);
On Tue, 21 Nov 2023 14:40:35 GMT, Alexey Ivanov wrote:
> Does it mean that `table.getCellRect` returns an incorrect value in
> right-to-left case?
Yes, it does! Clicking to select doesn't work correctly: wherever I click only
the Salary column gets selected, there's no way t
On Tue, 21 Nov 2023 15:12:14 GMT, Alexey Ivanov wrote:
>> > src="https://github.com/openjdk/jdk/assets/94159358/3de732e6-cab6-4bb0-8c25-724fac22eced";>
>
>> As far as I understood from the description, it's about
>> **Orientation**—left-to-right vs. ri
On Tue, 21 Nov 2023 12:06:41 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
On Tue, 21 Nov 2023 04:53:35 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTableUI.java line
>> 855:
>>
>>> 853: }
>>> 854: }
>>> 855: private int getXPosition(int column) {
>>
>> This method is exactly the same as in `BasicTableUI`, if I do
On Tue, 21 Nov 2023 08:37:45 GMT, Abhishek Kumar wrote:
> `boolean` variable is changed to local variable. Others are used in EDT and
> other method, so kept it as class variables.
Do they need to be? I mean you can do everything on EDT, even throw the
exception from there. It could something
On Thu, 2 Nov 2023 23:25:31 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8314731 : Adds support for the alt attribute in the image type input
>> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
>>
>> This is tracked in JBS as
>> - [JDK-
On Thu, 16 Nov 2023 05:19:43 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>> director
On Mon, 20 Nov 2023 05:24:51 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
On Mon, 20 Nov 2023 10:55:47 GMT, Tejesh R wrote:
>> Ok.
>
> But the current logic in test doesn't hold good for few Look and Feel
> including Nimbus. Should I make the test as manual mentioning it to be tested
> against all Look and Feel?
You can have two tests: for Metal and for Synth (Nimbu
On Wed, 15 Nov 2023 19:17:14 GMT, Damon Nguyen wrote:
>> U mean to create a test directory and store image there?
>
> Not a new test directory. In that referenced PR, I had to get the path to the
> directory where test files are stored temporarily. This helps with testing
> mainly.
>
> `Path.o
On Mon, 20 Nov 2023 05:28:50 GMT, Abhishek Kumar wrote:
>> JProgressBar is always painted with border irrespective of the value set via
>> the API `setBorderPainted(boolean value)` in Synth (Nimbus and GTK) LAF.
>> Proposed fix is to add a check before painting the component.
>>
>> CI jobs are
On Mon, 20 Nov 2023 05:24:59 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JProgressBar/TestProgressBarBorder.java line 70:
>>
>>> 68: isImgSame = Util.compareBufferedImages(borderPaintedImg,
>>> borderNotPaintedImg);
>>> 69:
>>> 70: if (isImgSame) {
>>
>> Maybe w
On Mon, 6 Nov 2023 06:22:33 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBar
Update `FileChooserSymLinkTest.java` to simplify its implementation by
replacing `List` with `JFrame` of its `createTestUI` which now uses
`PassFailJFrame.Builder testUI(PassFailJFrame.WindowCreator)` instead of
`PassFailJFrame.Builder testUI(PassFailJFrame.WindowListCreator)`.
The test works c
On Fri, 17 Nov 2023 20:01:55 GMT, Alexey Ivanov wrote:
> Enhance `PassFailJFrame` for single-window test UI which is the most common
> case so that there's no need to return `List.of`.
>
> With this change, the lambda or method reference passed to `Builder.testUI`
> will r
Enhance `PassFailJFrame` for single-window test UI which is the most common
case so that there's no need to return `List.of`.
With this change, the lambda or method reference passed to `Builder.testUI`
will return Window instead of `List` (or `List`.
This change adds new functional interface `W
On Tue, 14 Nov 2023 21:22:37 GMT, Alisen Chung wrote:
> Updated previous fix (8262945) to work on extendedKeyCodes. Updated
> AcceleratorTest to use PassFailJFrame instead of Applet
I can't still make the test pass on macOS Ventura (13.5.2), yet the fix did
improve the situation. Previously, f
On Thu, 2 Nov 2023 04:13:17 GMT, Abhishek Kumar wrote:
> JProgressBar is always painted with border irrespective of the value set via
> the API `setBorderPainted(boolean value)` in Synth (Nimbus and GTK) LAF.
> Proposed fix is to add a check before painting the component.
>
> CI jobs are green
On Thu, 16 Nov 2023 12:23:03 GMT, Alexey Ivanov wrote:
>> It is not necessary to add the progress bar to the frame and then capture
>> the pixels by the robot. you can render content of the progress bar directly
>> to the BufferedImage.
>
> There are a number of tes
On Thu, 16 Nov 2023 06:50:36 GMT, Sergey Bylokhov wrote:
>> I couldn't understand. Can you please explain a bit more?
>
> It is not necessary to add the progress bar to the frame and then capture the
> pixels by the robot. you can render content of the progress bar directly to
> the BufferedIma
On Thu, 16 Nov 2023 11:25:47 GMT, Prasanta Sadhukhan
wrote:
>> CSSBackgroundImage.equals() is implemented
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove this reference
Marked as reviewed by aivanov (Reviewer
On Mon, 6 Nov 2023 06:22:33 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBar
On Thu, 16 Nov 2023 10:51:48 GMT, Prasanta Sadhukhan
wrote:
>> CSSBackgroundImage.equals() is implemented
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Use Objects.hashCode
src/java.desktop/share/classes/javax/swi
On Fri, 10 Nov 2023 13:50:27 GMT, Prasanta Sadhukhan
wrote:
> CSSBackgroundImage.equals() is implemented
[My recent
comment](https://github.com/openjdk/jdk/pull/16613#discussion_r1392808012)
removed my approval.
It's *approved* after the following is addressed:
> Please add 8318113 to the @
On Tue, 14 Nov 2023 11:10:06 GMT, Prasanta Sadhukhan
wrote:
>> Test was run without waiting for UI to be made visible leading to
>> IllegalComponentStateException.
>> Used robot.delay consistent with other headful tests to made the test wait
>> after UI is created and shown.
>>
>> Test passed
On Fri, 10 Nov 2023 13:50:27 GMT, Prasanta Sadhukhan
wrote:
> CSSBackgroundImage.equals() is implemented
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/text/html/CSS/CSSAttributeEqualityBug.java line 1:
> 1: /*
Please add 8318113 to the `@bug` tag in the test.
-
On Fri, 10 Nov 2023 13:50:27 GMT, Prasanta Sadhukhan
wrote:
> CSSBackgroundImage.equals() is implemented
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16613#pullrequestreview-1725016640
On Fri, 10 Nov 2023 04:30:33 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
On Mon, 6 Nov 2023 06:22:33 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBar
On Wed, 8 Nov 2023 05:06:14 GMT, Prasanta Sadhukhan
wrote:
> Although there seems to be no difference in rendering the scrollbars with and
> without these getXXX methods as can be seen here (top one without, bottom one
> with the methods),
I guess it's expected because `LayoutManager` usually
On Thu, 9 Nov 2023 18:42:24 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
On Thu, 9 Nov 2023 18:21:02 GMT, Abhishek Kumar wrote:
> > I wonder if it makes sense to resolve warnings about raw classes.
>
> I didn't get this. Which warnings need to be resolved?
test/jdk/javax/swing/JComboBox/6567433/UpdateUIRecursionTest.java:61: warning:
[unchecked] unchecked call to
On Thu, 9 Nov 2023 18:12:44 GMT, Abhishek Kumar wrote:
> So, I need to revert the changes that is done in the current commit and just
> add the bug id 8283214... right?
Yes, that's right.
-
PR Comment: https://git.openjdk.org/jdk/pull/14497#issuecomment-1804323444
On Thu, 9 Nov 2023 04:39:32 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
On Thu, 9 Nov 2023 04:36:08 GMT, Abhishek Kumar wrote:
> Observed a test failure (regression) while running the CI jobs with the fix.
The failed test is `javax/swing/JComboBox/6567433/UpdateUIRecursionTest.java`.
It fails with `NullPointerException` because `PropertyChangeListener` in
`AquaCom
On Thu, 9 Nov 2023 04:39:32 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
On Thu, 2 Nov 2023 14:01:20 GMT, xpbob wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>>
On Tue, 7 Nov 2023 03:29:15 GMT, Prasanta Sadhukhan
wrote:
> Can you please attach your testcode in JBS? I tried with the testcases
> JScrollBarMinLayout.java and JScrollBarMaxLauout.java resizing the frame and
> I dont see any difference in layout behaviour of the scrollbars with and
> witho
On Fri, 27 Oct 2023 23:29:19 GMT, lawrence.andrews wrote:
> 1) Fixed the @library regtesthelpers file path
> 2) Added @build PassFailJFrame
> 3) Added a empty line at the end of the file that was missing.
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.o
On Mon, 6 Nov 2023 07:17:27 GMT, Abhishek Kumar wrote:
>> This is definitely an improvement compared to the complete lack of magnified
>> text on hover, but it still doesn't handle custom renderers.
>>
>> I've been digging into how this works in Metal but I couldn't figure it out
>> completely
On Mon, 6 Nov 2023 06:22:33 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBar
On Tue, 26 Sep 2023 11:12:08 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This is
On Mon, 11 Sep 2023 16:54:10 GMT, Alexey Ivanov wrote:
> This update to `FileChooserSymLinkTest.java` demonstrates the usage of the
> `testUI` method of the `PassFailJFrame.Builder` class to streamline creating
> the UI for manual tests.
>
> The [`main`
> method](https://
On Thu, 26 Oct 2023 06:56:16 GMT, Daniel Jeliński wrote:
> The removed functions are empty on all platforms.
>
> This patch also removes calls to `Toolkit.loadLibraries();` in classes that
> no longer have any native methods. The call was needed to ensure that the
> native awt library is loade
On Thu, 26 Oct 2023 06:56:16 GMT, Daniel Jeliński wrote:
> The removed functions are empty on all platforms.
>
> This patch also removes calls to `Toolkit.loadLibraries();` in classes that
> no longer have any native methods. The call was needed to ensure that the
> native awt library is loade
On Fri, 13 Oct 2023 15:19:53 GMT, Daniel Jeliński wrote:
>> Please review this patch that removes a number of unused exports from
>> java.desktop native libraries.
>>
>> In most cases I removed JNIEXPORT from methods and variables that are only
>> used within a single shared library. Other tha
On Thu, 26 Oct 2023 06:11:50 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have added additional CountDownLatch for making sure button is visible
>> before proceeding,(observe this was one of the key reason for failure) so
>> this helps to improve test case stability. Modifi
On Wed, 25 Oct 2023 03:23:01 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have added additional CountDownLatch for making sure button is visible
>> before proceeding,(observe this was one of the key reason for failure) so
>> this helps to improve test case stability. Modifi
On Wed, 25 Oct 2023 13:29:01 GMT, Alexey Ivanov wrote:
>> This update to `FileChooserSymLinkTest.java` demonstrates the usage of the
>> `testUI` method of the `PassFailJFrame.Builder` class to streamline creating
>> the UI for manual tests.
>>
>> The [`main`
On Mon, 11 Sep 2023 18:18:28 GMT, Alexey Ivanov wrote:
> Refactored timeout handling in PassFailJFrame:
>
> 1. Managing the timer and formatting the time left is inside `TimeoutHandler`
> class.
> 2. The class handles timer events and updates the label accordingly.
>
> T
eating a manual test.
>
> This change depends on #15665 and
> [JDK-8294156](https://bugs.openjdk.org/browse/JDK-8294156) as well as #15661,
> both of which depend on #15660.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase. The pull request no
> Refactored timeout handling in PassFailJFrame:
>
> 1. Managing the timer and formatting the time left is inside `TimeoutHandler`
> class.
> 2. The class handles timer events and updates the label accordingly.
>
> This is implemented on top of #15665.
Alexey Ivanov
On Mon, 11 Sep 2023 13:28:40 GMT, Alexey Ivanov wrote:
> To demonstrate the functionality of HTML formatting in `PassFailJFrame`, I
> updated the instructions for the
> `test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java` test. The
> commands to create the symbolic link
1201 - 1300 of 2486 matches
Mail list logo
