[GitHub] [airflow-client-go] zbysir opened a new issue, #38: Request.Execute() return `undefined response type` error

2023-01-31 Thread via GitHub
zbysir opened a new issue, #38: URL: https://github.com/apache/airflow-client-go/issues/38 ``` ➜ ~ curl -i -X GET 'https://airflow.xxx.com/api/v1/dags/xx/dagRuns/xxx' \ -H 'Content-Type: application/json' -H 'Accept: application/json' \ --user "xxx:xxx" \ -d '{}' HTTP/2 404

[GitHub] [airflow] Taragolis commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-31 Thread via GitHub
Taragolis commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1092857724 ## airflow/jobs/local_task_job.py: ## @@ -203,6 +205,7 @@ def sigusr2_debug_handler(signum, frame): ) finally:

[GitHub] [airflow] Bhawana-Barfa opened a new issue, #29281: (psycopg2.errors.FeatureNotSupported) This ALTER TABLE command is not yet supported .While deploying airflow with Postgres

2023-01-31 Thread via GitHub
Bhawana-Barfa opened a new issue, #29281: URL: https://github.com/apache/airflow/issues/29281 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened Airflow Version : 2.2.3 I am trying to deploy airflow with postgres on cluster

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29281: (psycopg2.errors.FeatureNotSupported) This ALTER TABLE command is not yet supported .While deploying airflow with Postgres

2023-01-31 Thread boring-cyborg
boring-cyborg[bot] commented on issue #29281: URL: https://github.com/apache/airflow/issues/29281#issuecomment-1411585269 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] feluelle commented on pull request #28721: Use connection URI in SqliteHook

2023-01-31 Thread via GitHub
feluelle commented on PR #28721: URL: https://github.com/apache/airflow/pull/28721#issuecomment-1411582283 Yes, good catch @ashb and @josh-fell thank you for the heads-up. That is a tricky one. I would say we merge the other PR first and I will just update my PR and docs to reflect the

[GitHub] [airflow] ecerulm commented on a diff in pull request #29016: Fix leak sensitive field via V1EnvVar on exception

2023-01-31 Thread via GitHub
ecerulm commented on code in PR #29016: URL: https://github.com/apache/airflow/pull/29016#discussion_r1092846149 ## airflow/utils/log/secrets_masker.py: ## @@ -200,10 +222,18 @@ def _redact(self, item: Redactable, name: str | None, depth: int) -> Redacted: if name

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29224: add output format arg for `cli.dags.trigger`

2023-01-31 Thread via GitHub
ephraimbuddy commented on code in PR #29224: URL: https://github.com/apache/airflow/pull/29224#discussion_r1092826281 ## tests/api/client/test_local_client.py: ## @@ -128,6 +128,45 @@ def test_trigger_dag(self, mock): ) mock.reset_mock() +

[airflow] branch main updated: Adjust some wording in the release process (#29278)

2023-01-31 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 05fb80ee93 Adjust some wording in the

[GitHub] [airflow] ephraimbuddy merged pull request #29278: Adjust some wording in the release process

2023-01-31 Thread via GitHub
ephraimbuddy merged PR #29278: URL: https://github.com/apache/airflow/pull/29278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on pull request #29093: [WIP] Enable tags for statsd metrics in a backward compatible way

2023-01-31 Thread via GitHub
uranusjr commented on PR #29093: URL: https://github.com/apache/airflow/pull/29093#issuecomment-1411518422 If the goal is to remove statsd altogether eventually, emitting an event under multiple keys feels like the easiest solution to me. -- This is an automated message from the Apache

[GitHub] [airflow] sudeepgupta90 commented on issue #29273: Status of testing of Apache Airflow Helm Chart 1.8.0rc1

2023-01-31 Thread via GitHub
sudeepgupta90 commented on issue #29273: URL: https://github.com/apache/airflow/issues/29273#issuecomment-1411492577 Checked #28604 - all good On Wed, Feb 1, 2023 at 10:46 AM Aakcht ***@***.***> wrote: > Checked #27544

[GitHub] [airflow] Aakcht commented on issue #29273: Status of testing of Apache Airflow Helm Chart 1.8.0rc1

2023-01-31 Thread via GitHub
Aakcht commented on issue #29273: URL: https://github.com/apache/airflow/issues/29273#issuecomment-1411481922 Checked #27544 , #27779 and #29032 - all good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] riyaj8888 opened a new issue, #29280: elastic-search index creation

2023-01-31 Thread via GitHub
riyaj opened a new issue, #29280: URL: https://github.com/apache/airflow/issues/29280 ### Apache Airflow Provider(s) elasticsearch ### Versions of Apache Airflow Providers apache-airflow-providers-elasticsearch == 4.3.3 ### Apache Airflow version 2.3.2

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29280: elastic-search index creation

2023-01-31 Thread boring-cyborg
boring-cyborg[bot] commented on issue #29280: URL: https://github.com/apache/airflow/issues/29280#issuecomment-1411462214 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] taragurung commented on issue #29272: Airflow Dag fails with no logs , all services looks ok

2023-01-31 Thread via GitHub
taragurung commented on issue #29272: URL: https://github.com/apache/airflow/issues/29272#issuecomment-1411460251 This is what I see now ``` [2023-01-31, 20:28:18 UTC] {local_task_job.py:212} WARNING - State of this instance has been externally set to skipped. Terminating instance.

[GitHub] [airflow] josh-fell commented on a diff in pull request #29274: log the observed status in redshift sensor

2023-01-31 Thread via GitHub
josh-fell commented on code in PR #29274: URL: https://github.com/apache/airflow/pull/29274#discussion_r1092751084 ## airflow/providers/amazon/aws/sensors/redshift_cluster.py: ## @@ -56,8 +56,14 @@ def __init__( self.aws_conn_id = aws_conn_id def poke(self,

[GitHub] [airflow] jedcunningham opened a new pull request, #29279: Patch only single label when marking KPO checked

2023-01-31 Thread via GitHub
jedcunningham opened a new pull request, #29279: URL: https://github.com/apache/airflow/pull/29279 Instead of sending over a whole pod, we can simply send over the label to add to the pod instead. This is less work for us, and also avoids any issues like #24015. Fixes #24015 --

[GitHub] [airflow] EricGao888 commented on issue #29273: Status of testing of Apache Airflow Helm Chart 1.8.0rc1

2023-01-31 Thread via GitHub
EricGao888 commented on issue #29273: URL: https://github.com/apache/airflow/issues/29273#issuecomment-1411385945 I have validated #28858 which fixed some comments in the source code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] jedcunningham opened a new pull request, #29278: Adjust some wording in the release process

2023-01-31 Thread via GitHub
jedcunningham opened a new pull request, #29278: URL: https://github.com/apache/airflow/pull/29278 This rewords our the header in our testing issue, and fixes the rat section of the helm vote email. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] github-actions[bot] commented on pull request #24825: Dockerfile centos

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #24825: URL: https://github.com/apache/airflow/pull/24825#issuecomment-1411251315 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] o-nikolas commented on pull request #29276: AWS system test eks and fargate profile: get subnets as external parameter

2023-01-31 Thread via GitHub
o-nikolas commented on PR #29276: URL: https://github.com/apache/airflow/pull/29276#issuecomment-1411220093 FYI: @vincbeck is just making some internal preparations (to create the subnets that this test now expects to be present). I'll merge these changes tomorrow when that is done. --

[GitHub] [airflow] o-nikolas commented on pull request #29276: AWS system test eks and fargate profile: get subnets as external parameter

2023-01-31 Thread via GitHub
o-nikolas commented on PR #29276: URL: https://github.com/apache/airflow/pull/29276#issuecomment-1411219548 > For posterity: generally we would prefer to set up and tear down in the test, this is only getting changed because of the race condition it was causing. Good call out :+1:

[GitHub] [airflow] o-nikolas commented on pull request #29276: AWS system test eks and fargate profile: get subnets as external parameter

2023-01-31 Thread via GitHub
o-nikolas commented on PR #29276: URL: https://github.com/apache/airflow/pull/29276#issuecomment-1411165141 Agreed, great change. So beautiful when you can just use the variable fetcher to hide the nasty bits of creating/managing resources :smile: -- This is an automated message from

[GitHub] [airflow] danielhoherd commented on issue #29273: Status of testing of Apache Airflow Helm Chart 1.8.0rc1

2023-01-31 Thread via GitHub
danielhoherd commented on issue #29273: URL: https://github.com/apache/airflow/issues/29273#issuecomment-1411148100 I have validated https://github.com/apache/airflow/pull/27848 which was easy to validate. It was just a version bump. -- This is an automated message from the Apache Git

[GitHub] [airflow] kolfild26 commented on pull request #28998: write to DB a user who triggered a dag via API endpoint request

2023-01-31 Thread via GitHub
kolfild26 commented on PR #28998: URL: https://github.com/apache/airflow/pull/28998#issuecomment-140613 Hi, @ephraimbuddy I added test [_check_last_log](https://github.com/apache/airflow/pull/28998/commits/e2b670c4382b9e00adece76d5574268d9eb113f3) similarly it's done in

[GitHub] [airflow] eladkal commented on a diff in pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
eladkal commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1092504689 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -654,8 +673,8 @@ class SageMakerTrainingOperator(SageMakerBaseOperator): the operation does

[GitHub] [airflow] vincbeck opened a new pull request, #29276: AWS system test eks and fargate profile: get subnets as external parameter

2023-01-31 Thread via GitHub
vincbeck opened a new pull request, #29276: URL: https://github.com/apache/airflow/pull/29276 In both system tests `example_eks_with_fargate_profile` and `example_eks_with_fargate_in_one_step` subnets are created within the system test. In order to create these subnets, an available CIDR

[GitHub] [airflow] Gollum999 opened a new issue, #29275: Allow user DAGs to emit DagWarning (or similar)

2023-01-31 Thread via GitHub
Gollum999 opened a new issue, #29275: URL: https://github.com/apache/airflow/issues/29275 ### Description I would like a way to emit a warning or error message from a DAG that shows up as a banner in the web UI, similar to how exceptions are handled during DAG parsing or how

[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-31 Thread via GitHub
dstandish commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1092489357 ## airflow/executors/base_executor.py: ## @@ -355,14 +355,15 @@ def execute_async( """ raise NotImplementedError() -def get_task_log(self,

[GitHub] [airflow] Taragolis commented on pull request #28970: Fix support for macros with dots in DataProcJobBuilder

2023-01-31 Thread via GitHub
Taragolis commented on PR #28970: URL: https://github.com/apache/airflow/pull/28970#issuecomment-1411061835 I tried understand initial issue https://github.com/apache/airflow/issues/28810 >> I am passing string containing macros to DataProcJobBuilder task_id parameter: > {{

[airflow] branch constraints-main updated: Updating constraints. Github run id:4057758742

2023-01-31 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new fcc02204a4 Updating

[GitHub] [airflow] shahar1 commented on issue #10596: Add support for impersonation in GKEStartPodOperator, DataflowCreateJavaJobOperator and DataflowCreatePythonJobOperator

2023-01-31 Thread via GitHub
shahar1 commented on issue #10596: URL: https://github.com/apache/airflow/issues/10596#issuecomment-1411052265 @eladkal Please assign me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] Taragolis commented on pull request #28869: rewrite polling code for appflow hook

2023-01-31 Thread via GitHub
Taragolis commented on PR #28869: URL: https://github.com/apache/airflow/pull/28869#issuecomment-1411051606 @o-nikolas Oh, I really do not use Appflow. I've just ping Igor, because remember (and git blame told me) that he initially implement. But let me have a look. -- This is an

[GitHub] [airflow] potiuk commented on issue #29243: Auto refresh DAG state in UI

2023-01-31 Thread via GitHub
potiuk commented on issue #29243: URL: https://github.com/apache/airflow/issues/29243#issuecomment-1411044008 I see. Makes sense. Thanks @bbovenzi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] Gollum999 commented on issue #27399: CronTriggerTimetable lost one task occasionally

2023-01-31 Thread via GitHub
Gollum999 commented on issue #27399: URL: https://github.com/apache/airflow/issues/27399#issuecomment-1411036858 For what it's worth, prior to 2.4 I wrote my own timetable that acts almost exactly like `CronTriggerTimetable`, and I experienced a similar issue, so I'll mention my findings

[GitHub] [airflow] potiuk commented on pull request #29143: Demonstrate usage of the PythonSensor

2023-01-31 Thread via GitHub
potiuk commented on PR #29143: URL: https://github.com/apache/airflow/pull/29143#issuecomment-1411034438 Exactly same effect, example is runnable with `--load-example-dags` flag in start-airflow. No code duplication. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] potiuk commented on pull request #29143: Demonstrate usage of the PythonSensor

2023-01-31 Thread via GitHub
potiuk commented on PR #29143: URL: https://github.com/apache/airflow/pull/29143#issuecomment-1411031392 > I suggest showing reproducible examples. The current example for the PythonSensor is not easily reproducible because it doesn't show imports. Yes I understand that. What

[GitHub] [airflow] vandonr-amz opened a new pull request, #29274: log the observed status in redshift sensor

2023-01-31 Thread via GitHub
vandonr-amz opened a new pull request, #29274: URL: https://github.com/apache/airflow/pull/29274 this sensor only checks against the "wanted" status, and not other possibly terminal statuses. So if the cluster takes an unexpected branch and ends up in a semi-terminal state, this is

[GitHub] [airflow] jedcunningham opened a new issue, #29273: Status of testing of Apache Airflow Helm Chart 1.8.0rc1

2023-01-31 Thread via GitHub
jedcunningham opened a new issue, #29273: URL: https://github.com/apache/airflow/issues/29273 ### Body We have a kind request for all the contributors to the latest [Apache Airflow Helm Chart 1.8.0rc1](https://dist.apache.org/repos/dist/dev/airflow/helm-chart/1.8.0rc1). Could

[airflow] annotated tag helm-chart/1.8.0rc1 updated (bca7816f41 -> b17bd670ca)

2023-01-31 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to annotated tag helm-chart/1.8.0rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag helm-chart/1.8.0rc1 was modified! *** from bca7816f41 (commit) to

svn commit: r59767 - /dev/airflow/helm-chart/1.7.0rc1/

2023-01-31 Thread jedcunningham
Author: jedcunningham Date: Tue Jan 31 20:02:44 2023 New Revision: 59767 Log: Remove old Helm Chart release: 1.7.0rc1 Removed: dev/airflow/helm-chart/1.7.0rc1/

svn commit: r59766 - /dev/airflow/helm-chart/1.8.0rc1/

2023-01-31 Thread jedcunningham
Author: jedcunningham Date: Tue Jan 31 20:01:47 2023 New Revision: 59766 Log: Add artifacts for Helm Chart 1.8.0rc1 Added: dev/airflow/helm-chart/1.8.0rc1/ dev/airflow/helm-chart/1.8.0rc1/airflow-1.8.0.tgz (with props) dev/airflow/helm-chart/1.8.0rc1/airflow-1.8.0.tgz.asc

[GitHub] [airflow] ferruzzi commented on pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
ferruzzi commented on PR #29245: URL: https://github.com/apache/airflow/pull/29245#issuecomment-1410974971 I guess I see what you are saying. With a reasonably large range on the random suffix the collision rate will be low. My initial thought was how many times our proposed name might

[airflow] branch main updated (b3536aeac9 -> 42fbcb2c10)

2023-01-31 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b3536aeac9 Release notes for helm chart 1.8.0 (#29248) add 42fbcb2c10 Fix helm chart release notes code

[GitHub] [airflow] jedcunningham merged pull request #29271: Fix helm chart release notes code block

2023-01-31 Thread via GitHub
jedcunningham merged PR #29271: URL: https://github.com/apache/airflow/pull/29271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] taragurung opened a new issue, #29272: Airflow Dag status failed with no logs

2023-01-31 Thread via GitHub
taragurung opened a new issue, #29272: URL: https://github.com/apache/airflow/issues/29272 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened All of a sudden the DAG started failing and the problem is there are no informative

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29272: Airflow Dag status failed with no logs

2023-01-31 Thread boring-cyborg
boring-cyborg[bot] commented on issue #29272: URL: https://github.com/apache/airflow/issues/29272#issuecomment-1410966021 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
vandonr-amz commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1092398234 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -654,8 +673,8 @@ class SageMakerTrainingOperator(SageMakerBaseOperator): the operation

[GitHub] [airflow] vandonr-amz commented on pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
vandonr-amz commented on PR #29245: URL: https://github.com/apache/airflow/pull/29245#issuecomment-1410954197 > We're only counting jobs whose name matches [here](https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/hooks/sagemaker.py#L1022) Oh yes my bad, I read

[GitHub] [airflow] eladkal commented on a diff in pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
eladkal commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1092387832 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -654,8 +673,8 @@ class SageMakerTrainingOperator(SageMakerBaseOperator): the operation does

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
vandonr-amz commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1092382659 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -654,8 +673,8 @@ class SageMakerTrainingOperator(SageMakerBaseOperator): the operation

[GitHub] [airflow] ferruzzi commented on pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
ferruzzi commented on PR #29245: URL: https://github.com/apache/airflow/pull/29245#issuecomment-1410943198 I don't think I agree that using a random suffix is an improvement. > The sequence was already imperfect, because we counted all jobs, not just the ones with the same base

[GitHub] [airflow] eladkal commented on a diff in pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
eladkal commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1092374357 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -654,8 +673,8 @@ class SageMakerTrainingOperator(SageMakerBaseOperator): the operation does

[GitHub] [airflow] ferruzzi commented on a diff in pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
ferruzzi commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1092368310 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -679,11 +697,11 @@ def __init__( self.check_interval = check_interval

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
vandonr-amz commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1092360487 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -679,11 +697,11 @@ def __init__( self.check_interval = check_interval

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
vandonr-amz commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1092359626 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -679,11 +697,11 @@ def __init__( self.check_interval = check_interval

[GitHub] [airflow] o-nikolas commented on pull request #29144: rewrite invoke lamba operator tests

2023-01-31 Thread via GitHub
o-nikolas commented on PR #29144: URL: https://github.com/apache/airflow/pull/29144#issuecomment-1410906782 Hey folks, What's the status on this one? @Taragolis are you happy to approve the PR as it is now, or would you like to see some changes? -- This is an automated message

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29245: fix code checking job names in sagemaker

2023-01-31 Thread via GitHub
o-nikolas commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1092353835 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -679,11 +697,11 @@ def __init__( self.check_interval = check_interval

[airflow] branch main updated: Release notes for helm chart 1.8.0 (#29248)

2023-01-31 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b3536aeac9 Release notes for helm chart

[GitHub] [airflow] jedcunningham merged pull request #29248: Release notes for helm chart 1.8.0

2023-01-31 Thread via GitHub
jedcunningham merged PR #29248: URL: https://github.com/apache/airflow/pull/29248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal commented on issue #29202: Trigger rule one_success with dynamic task mapping

2023-01-31 Thread via GitHub
eladkal commented on issue #29202: URL: https://github.com/apache/airflow/issues/29202#issuecomment-1410900752 I agree with @hussein-awala explnation thus Im closing this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] eladkal closed issue #29202: Trigger rule one_success with dynamic task mapping

2023-01-31 Thread via GitHub
eladkal closed issue #29202: Trigger rule one_success with dynamic task mapping URL: https://github.com/apache/airflow/issues/29202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] o-nikolas commented on pull request #28869: rewrite polling code for appflow hook

2023-01-31 Thread via GitHub
o-nikolas commented on PR #28869: URL: https://github.com/apache/airflow/pull/28869#issuecomment-1410894943 @Taragolis @igorborgest are you happy with the state of this PR or would you like to see any other changes/testing? -- This is an automated message from the Apache Git Service. To

[airflow] branch main updated (42dd812021 -> a671561b8e)

2023-01-31 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 42dd812021 Add `FileTrigger` (#29265) add a671561b8e shorten other wait times in sys tests (#29254) No new

[GitHub] [airflow] o-nikolas merged pull request #29254: shorten other wait times in sys tests

2023-01-31 Thread via GitHub
o-nikolas merged PR #29254: URL: https://github.com/apache/airflow/pull/29254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] amoghrajesh commented on issue #28745: annotations in logs pvc

2023-01-31 Thread via GitHub
amoghrajesh commented on issue #28745: URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410862961 @do-it-tim added support for this in https://github.com/apache/airflow/pull/29270. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] amoghrajesh opened a new pull request, #29270: Adding possibility for annotations in logs pvc

2023-01-31 Thread via GitHub
amoghrajesh opened a new pull request, #29270: URL: https://github.com/apache/airflow/pull/29270 Logs persistent volume claim doesn't have the support to add annotations through the helm charts. The PR adds support for the same, similar to

[GitHub] [airflow] amoghrajesh commented on pull request #29214: Helm deployment fails when postgresql.nameOverride is used

2023-01-31 Thread via GitHub
amoghrajesh commented on PR #29214: URL: https://github.com/apache/airflow/pull/29214#issuecomment-1410854555 Just fixed all the test case issues. @potiuk / @jedcunningham can someone merge the PR once the CI passes? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] r-richmond commented on pull request #29226: Implement new filtering options in graph view

2023-01-31 Thread via GitHub
r-richmond commented on PR #29226: URL: https://github.com/apache/airflow/pull/29226#issuecomment-1410852859 Thanks for tackling this @yxiao1996. Left a tardy UI mockup suggestion for consideration in https://github.com/apache/airflow/issues/28847#issuecomment-1410851618. -- This is an

[GitHub] [airflow] r-richmond commented on issue #28847: Graph UI: Add Filter Downstream & Filter DownStream & Upstream

2023-01-31 Thread via GitHub
r-richmond commented on issue #28847: URL: https://github.com/apache/airflow/issues/28847#issuecomment-1410851618 Hey @yxiao1996 this looks great. 2 questions for you 1) For your example `After filtering downstream for one of the tasks` which task_id did you click on & which option

[GitHub] [airflow] vandonr-amz commented on issue #26725: Refactor `S3KeysUnchangedSensor` system test

2023-01-31 Thread via GitHub
vandonr-amz commented on issue #26725: URL: https://github.com/apache/airflow/issues/26725#issuecomment-1410828693 Yes, #28528 was about not rescheduling immediately and respecting the set interval, but sensors still run in reschedule mode, so this one still doesn't work. -- This is an

[airflow] branch main updated (51d96334b8 -> 42dd812021)

2023-01-31 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 51d96334b8 Use `schedule` param rather than `timetable` in Timetables docs (#29255) add 42dd812021 Add

[GitHub] [airflow] kaxil merged pull request #29265: Add `FileTrigger`

2023-01-31 Thread via GitHub
kaxil merged PR #29265: URL: https://github.com/apache/airflow/pull/29265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] syun64 commented on pull request #29093: [WIP] Enable tags for statsd metrics in a backward compatible way

2023-01-31 Thread via GitHub
syun64 commented on PR #29093: URL: https://github.com/apache/airflow/pull/29093#issuecomment-1410802425 > > Another alternative to this PR, is just to simply publish duplicate metrics > > I was thinking exactly this when I opened this PR. Is there a good way to deprecate stat

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-31 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1092263564 ## docs/apache-airflow/howto/usage-cli.rst: ## @@ -217,6 +217,17 @@ You can use the ``--dry-run`` option to print the row counts in the primary tabl By

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-31 Thread via GitHub
jedcunningham commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1092214629 ## docs/apache-airflow/howto/usage-cli.rst: ## @@ -217,6 +217,17 @@ You can use the ``--dry-run`` option to print the row counts in the primary tabl By

[GitHub] [airflow] yxiao1996 commented on pull request #29226: Implement new filtering options in graph view

2023-01-31 Thread via GitHub
yxiao1996 commented on PR #29226: URL: https://github.com/apache/airflow/pull/29226#issuecomment-1410730706 looks like it times out waiting for CI image ``` Progress: Image 3.7 Waiting: #675

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29248: Release notes for helm chart 1.8.0

2023-01-31 Thread via GitHub
ephraimbuddy commented on code in PR #29248: URL: https://github.com/apache/airflow/pull/29248#discussion_r1092200171 ## chart/RELEASE_NOTES.rst: ## @@ -23,15 +23,116 @@ Run ``helm repo update`` before upgrading the chart to the latest version. .. towncrier release notes

[GitHub] [airflow] kaxil commented on a diff in pull request #29265: Add `FileTrigger`

2023-01-31 Thread via GitHub
kaxil commented on code in PR #29265: URL: https://github.com/apache/airflow/pull/29265#discussion_r1092166719 ## tests/triggers/test_file.py: ## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] waldoppper opened a new issue, #29268: Statsd metric name components are unsanitized

2023-01-31 Thread via GitHub
waldoppper opened a new issue, #29268: URL: https://github.com/apache/airflow/issues/29268 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened [2.2.5] I recently enabled statsd metric emission on my team's deploy and began

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29268: Statsd metric name components are unsanitized

2023-01-31 Thread boring-cyborg
boring-cyborg[bot] commented on issue #29268: URL: https://github.com/apache/airflow/issues/29268#issuecomment-1410653574 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] bbovenzi commented on issue #29243: Auto refresh DAG state in UI

2023-01-31 Thread via GitHub
bbovenzi commented on issue #29243: URL: https://github.com/apache/airflow/issues/29243#issuecomment-1410650289 I'm going to remove the "good first issue". It's not a trivial change. That `state_token` is defined by Flask App Builder and not in js, and the auto-refresh in the graph

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-31 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1092132580 ## airflow/utils/db_cleanup.py: ## @@ -123,6 +127,15 @@ def _check_for_rows(*, query: Query, print_rows=False): return num_entities +def

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-31 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1092120446 ## docs/apache-airflow/howto/usage-cli.rst: ## @@ -217,6 +217,17 @@ You can use the ``--dry-run`` option to print the row counts in the primary tabl By

[GitHub] [airflow] VladaZakharova commented on pull request #29266: Add deferrable mode to GKEStartPodOperator

2023-01-31 Thread via GitHub
VladaZakharova commented on PR #29266: URL: https://github.com/apache/airflow/pull/29266#issuecomment-1410585964 @potiuk @kaxil Hi! Can you please check the changes for the GKEStartPod operator, please? This is the second part of the changes from the original PR. Many thanks! --

[GitHub] [airflow] tsoud commented on a diff in pull request #29158: Update pipeline.rst - Fix query in `merge_data()` task

2023-01-31 Thread via GitHub
tsoud commented on code in PR #29158: URL: https://github.com/apache/airflow/pull/29158#discussion_r1092087567 ## docs/apache-airflow/tutorial/pipeline.rst: ## @@ -170,7 +170,7 @@ Here we select completely unique records from the retrieved data, then we check

[GitHub] [airflow] BasPH commented on pull request #29143: Demonstrate usage of the PythonSensor

2023-01-31 Thread via GitHub
BasPH commented on PR #29143: URL: https://github.com/apache/airflow/pull/29143#issuecomment-1410573849 I suggest showing reproducible examples. The current example for the PythonSensor is not easily reproducible because it doesn't show imports. -- This is an automated message from the

[GitHub] [airflow] amoghrajesh commented on issue #28745: annotations in logs pvc

2023-01-31 Thread via GitHub
amoghrajesh commented on issue #28745: URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410523257 I can take it up then. @potiuk can I? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29224: add output format arg for `cli.dags.trigger`

2023-01-31 Thread via GitHub
ephraimbuddy commented on code in PR #29224: URL: https://github.com/apache/airflow/pull/29224#discussion_r1092054686 ## airflow/api/client/local_client.py: ## @@ -22,21 +22,39 @@ from airflow.api.common import delete_dag, trigger_dag from

[GitHub] [airflow] do-it-tim commented on issue #28745: annotations in logs pvc

2023-01-31 Thread via GitHub
do-it-tim commented on issue #28745: URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410489399 yes, think that would be the equivalent way to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29265: Add `FileTrigger`

2023-01-31 Thread via GitHub
ephraimbuddy commented on code in PR #29265: URL: https://github.com/apache/airflow/pull/29265#discussion_r1092031302 ## tests/triggers/test_file.py: ## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [airflow] VladaZakharova closed pull request #29266: Add deferrable mode to GKEStartPodOperator

2023-01-31 Thread via GitHub
VladaZakharova closed pull request #29266: Add deferrable mode to GKEStartPodOperator URL: https://github.com/apache/airflow/pull/29266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] amoghrajesh commented on issue #28745: annotations in logs pvc

2023-01-31 Thread via GitHub
amoghrajesh commented on issue #28745: URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410470039 Oh, thanks @do-it-tim. It would be nice to accept it from: `.Values.logs.persistence.annotations`? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] amoghrajesh commented on issue #28745: annotations in logs pvc

2023-01-31 Thread via GitHub
amoghrajesh commented on issue #28745: URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410454908 @potiuk @do-it-tim if nobody is actively developing this, i would be more than happy to take it up. I would require some more context and concrete idea before starting though.

[GitHub] [airflow] josh-fell commented on pull request #28721: Use connection URI in SqliteHook

2023-01-31 Thread via GitHub
josh-fell commented on PR #28721: URL: https://github.com/apache/airflow/pull/28721#issuecomment-1410452249 > LGTM. Does it need docs https://airflow.apache.org/docs/apache-airflow-providers-sqlite/stable/connections/sqlite.html updating? +1. [There is a PR

[GitHub] [airflow] BasPH opened a new issue, #29267: Support tabs in docs

2023-01-31 Thread via GitHub
BasPH opened a new issue, #29267: URL: https://github.com/apache/airflow/issues/29267 ### What do you see as an issue? I suggest supporting tabs in the docs to improve the readability when demonstrating different ways to achieve the same things. **Motivation** We have

[GitHub] [airflow] nsphung commented on issue #29112: "Operation not permitted" error when chmod on log folder

2023-01-31 Thread via GitHub
nsphung commented on issue #29112: URL: https://github.com/apache/airflow/issues/29112#issuecomment-1410442324 I have the same issue with image based on `apache/airflow:2.5.1-python3.9`. I have updated due to CVE-2023-22884 -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] VladaZakharova opened a new pull request, #29266: Add deferrable mode to GKEStartPodOperator

2023-01-31 Thread via GitHub
VladaZakharova opened a new pull request, #29266: URL: https://github.com/apache/airflow/pull/29266 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for

[GitHub] [airflow] kaxil opened a new pull request, #29265: Add `FileTrigger`

2023-01-31 Thread via GitHub
kaxil opened a new pull request, #29265: URL: https://github.com/apache/airflow/pull/29265 Contributes back one of the core Triggers from https://github.com/astronomer/astronomer-providers so that it can be used to create an operator /sensor or used within taskflow API ---

[GitHub] [airflow] norm commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-31 Thread via GitHub
norm commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1091933569 ## docs/apache-airflow/howto/usage-cli.rst: ## @@ -217,6 +217,17 @@ You can use the ``--dry-run`` option to print the row counts in the primary tabl By default,

  1   2   >