Re: [I] States of the time field corresponding to ti.state is not clear [airflow]

2024-04-01 Thread via GitHub
kzosabe commented on issue #38632: URL: https://github.com/apache/airflow/issues/38632#issuecomment-2031136250 @uranusjr Thanks for the explanation! Just to confirm, does a DEFFERED task really transition directly to RUNNING? I may be missing something, but I could not find a code

Re: [PR] pt012 rule enabled for sftp [airflow]

2024-04-01 Thread via GitHub
Bowrna commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2031133957 hello @Taragolis I fixed the conflicts. could you check this PR and let me know your views? Thanks -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] heartbeat recovery message [airflow]

2024-04-01 Thread via GitHub
Bowrna commented on code in PR #34457: URL: https://github.com/apache/airflow/pull/34457#discussion_r1547161284 ## airflow/jobs/job.py: ## @@ -131,22 +146,20 @@ def executors(self): def heartrate(self) -> float: return Job._heartrate(self.job_type) -def

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-04-01 Thread via GitHub
Xiroo commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-2031097434 @hussein-awala Hello, I hope this message finds you well. I understand you have a busy schedule, and I just wanted to gently remind you about the review of my pull request. You

(airflow) branch constraints-main updated: Updating constraints. Github run id:8517333181

2024-04-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 2d3c49b48e Updating

Re: [PR] Fix BigQuery connection and add docs [airflow]

2024-04-01 Thread via GitHub
shahar1 commented on PR #38430: URL: https://github.com/apache/airflow/pull/38430#issuecomment-2031052300 Having some issues after merging #38169, working on a fix :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Adding support to hive hook for high availability Hive installations [airflow]

2024-04-01 Thread via GitHub
amoghrajesh commented on code in PR #38651: URL: https://github.com/apache/airflow/pull/38651#discussion_r1547114486 ## airflow/providers/apache/hive/hooks/hive.py: ## @@ -100,6 +100,9 @@ def __init__( ) -> None: super().__init__() conn =

(airflow) branch main updated: Clean up unused triggers in a single query for all dialects except MySQL (#38663)

2024-04-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 12d38e1a55 Clean up unused triggers in a single

Re: [PR] Clean up unused triggers in a single query for all dialects except MySQL [airflow]

2024-04-01 Thread via GitHub
eladkal merged PR #38663: URL: https://github.com/apache/airflow/pull/38663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Can update RenderedTaskInstanceFields over RPC [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on code in PR #38565: URL: https://github.com/apache/airflow/pull/38565#discussion_r1547110943 ## airflow/models/renderedtifields.py: ## @@ -50,6 +50,12 @@ from airflow.models.taskinstance import TaskInstance, TaskInstancePydantic +def

Re: [PR] Can update RenderedTaskInstanceFields over RPC [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on code in PR #38565: URL: https://github.com/apache/airflow/pull/38565#discussion_r1547110943 ## airflow/models/renderedtifields.py: ## @@ -50,6 +50,12 @@ from airflow.models.taskinstance import TaskInstance, TaskInstancePydantic +def

Re: [PR] Remove select_column option in TaskInstance.get_task_instance [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on PR #38571: URL: https://github.com/apache/airflow/pull/38571#issuecomment-2031011676 I hope we’ll be able to clean up the try_number bs when we implement AIP-64. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Remove select_column option in TaskInstance.get_task_instance [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on code in PR #38571: URL: https://github.com/apache/airflow/pull/38571#discussion_r1547093071 ## airflow/models/taskinstance.py: ## @@ -532,8 +531,7 @@ def _refresh_from_db( task_instance.end_date = ti.end_date task_instance.duration =

Re: [PR] Add a task instance dependency for mapped dependencies [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on code in PR #37498: URL: https://github.com/apache/airflow/pull/37498#discussion_r1547089982 ## airflow/ti_deps/deps/mapped_task_upstream_dep.py: ## @@ -0,0 +1,106 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Implement start/end/debug for multiple executors in scheduler job [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on code in PR #38514: URL: https://github.com/apache/airflow/pull/38514#discussion_r1547079296 ## airflow/jobs/scheduler_job_runner.py: ## @@ -819,19 +821,20 @@ def _execute(self) -> int | None: ) try: -

Re: [PR] Don't create session in get_dag if not reading dags from database [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on code in PR #38553: URL: https://github.com/apache/airflow/pull/38553#discussion_r1547078170 ## airflow/utils/cli.py: ## @@ -231,10 +231,11 @@ def get_dag(subdir: str | None, dag_id: str, from_db: bool = False) -> DAG: if from_db: dagbag =

Re: [PR] Use `methodtools.lru_cache` instead of `functools.lru_cache` in class methods [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on code in PR #37757: URL: https://github.com/apache/airflow/pull/37757#discussion_r1547076978 ## airflow/models/abstractoperator.py: ## @@ -492,7 +492,7 @@ def get_extra_links(self, ti: TaskInstance, link_name: str) -> str | None: return

Re: [PR] Use `methodtools.lru_cache` instead of `functools.lru_cache` in class methods [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on code in PR #37757: URL: https://github.com/apache/airflow/pull/37757#discussion_r1547076493 ## .pre-commit-config.yaml: ## @@ -985,6 +985,13 @@ repos: files: \.py$ exclude: ^.*/.*_vendor/ additional_dependencies: ['rich>=12.4.4']

(airflow) branch main updated: Remove display of param from the UI (#38660)

2024-04-01 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e20a710587 Remove display of param from the UI

Re: [PR] remove display of param from the UI [airflow]

2024-04-01 Thread via GitHub
uranusjr merged PR #38660: URL: https://github.com/apache/airflow/pull/38660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improve trigger assign_unassigned method [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on PR #38664: URL: https://github.com/apache/airflow/pull/38664#issuecomment-2030955073 Do we even need to do this outside of `get_sorted_triggers` in the first place? I wonder why we can’t just pass `health_check_threshold` into the function and do the subquery there

Re: [PR] Update `pytest_collection_modifyitems` to use correct properties [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on code in PR #38665: URL: https://github.com/apache/airflow/pull/38665#discussion_r1547055685 ## tests/system/conftest.py: ## @@ -49,9 +49,9 @@ def skip_if_env_var_not_set(provider_env_vars): def pytest_collection_modifyitems(config, items): """Add

Re: [PR] Fix triggerer race condition in HA setting [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1547052295 ## airflow/jobs/triggerer_job_runner.py: ## @@ -672,6 +672,17 @@ def update_triggers(self, requested_trigger_ids: set[int]):

Re: [I] States of the time field corresponding to ti.state is not clear [airflow]

2024-04-01 Thread via GitHub
uranusjr commented on issue #38632: URL: https://github.com/apache/airflow/issues/38632#issuecomment-2030931931 DEFERRED is the easy one, it is basically the same as RUNNING from the scheduler’s perspective, except it is waiting for the trigger to continue. For a ti to entered the

Re: [I] 'cause' key need to be limited to 255 characters to avoid failures due to trigger_reason field [airflow]

2024-04-01 Thread via GitHub
uroy-personal commented on issue #34676: URL: https://github.com/apache/airflow/issues/34676#issuecomment-2030917892 Hi @eladkal , I worked on this and then lost track due to few issues on my side. I will finish it hopefully by this week. Is that okay? -- This is an automated message

Re: [PR] Fix triggerer race condition in HA setting [airflow]

2024-04-01 Thread via GitHub
boring-cyborg[bot] commented on PR #38666: URL: https://github.com/apache/airflow/pull/38666#issuecomment-2030896627 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[PR] Fix triggerer race condition in HA setting [airflow]

2024-04-01 Thread via GitHub
Lioscro opened a new pull request, #38666: URL: https://github.com/apache/airflow/pull/38666 closes: #38599 --- **^ Add meaningful description above** Read the **[Pull Request

[PR] Update `pytest_collection_modifyitems` to use correct properties [airflow]

2024-04-01 Thread via GitHub
syedahsn opened a new pull request, #38665: URL: https://github.com/apache/airflow/pull/38665 related: #38624 Removing `LocalPath` broke system tests because `pytest_collection_modifyitems` used deprecated properties. This fixes the issue. --- **^ Add

[PR] Clean up unused triggers in a single query for all dialects except MySQL [airflow]

2024-04-01 Thread via GitHub
hussein-awala opened a new pull request, #38663: URL: https://github.com/apache/airflow/pull/38663 This PR improves the performance of `clean_unsed` triggers method by executing the cleanup for Postgres and SQLite in a single query, which could reduce the latency and memory usage.

Re: [PR] Fix inital value for _batch_id attribute in livy operator [airflow]

2024-04-01 Thread via GitHub
alizademhdi commented on PR #38628: URL: https://github.com/apache/airflow/pull/38628#issuecomment-2030790977 Sure. I will try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] bump uv to 0.1.27 [airflow]

2024-04-01 Thread via GitHub
hussein-awala merged PR #38657: URL: https://github.com/apache/airflow/pull/38657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: bump uv to 0.1.27 (#38657)

2024-04-01 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9c611477c3 bump uv to 0.1.27 (#38657)

(airflow) branch main updated: Fix duplicate "health" line in internal api openapi config (#38661)

2024-04-01 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a059ba4f74 Fix duplicate "health" line in

Re: [PR] Fix duplicate "health" line in internal api openapi config [airflow]

2024-04-01 Thread via GitHub
dstandish merged PR #38661: URL: https://github.com/apache/airflow/pull/38661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated (bc7b68b83a -> 51b34bb146)

2024-04-01 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from bc7b68b83a Move cleanup-docker to a shell scripts from composite action (#38659) add 51b34bb146 Ensure orm

Re: [PR] Ensure orm models loaded when using RPC API [airflow]

2024-04-01 Thread via GitHub
dstandish merged PR #38568: URL: https://github.com/apache/airflow/pull/38568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Move cleanup-docker to a shell scripts from composite action (#38659)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new bc7b68b83a Move cleanup-docker to a shell scripts

Re: [PR] Move cleanup-docker to a shell scripts from composite action [airflow]

2024-04-01 Thread via GitHub
potiuk merged PR #38659: URL: https://github.com/apache/airflow/pull/38659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Simplify metrics handling [airflow]

2024-04-01 Thread via GitHub
ferruzzi commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2030691835 Not sure it really qualifies as a bug, but it didn't really feel like a "feature request" either. Feel free to adjust my tagging. I've added "good first issue" because

[PR] Fix duplicate "health" line in internal api openapi config [airflow]

2024-04-01 Thread via GitHub
dstandish opened a new pull request, #38661: URL: https://github.com/apache/airflow/pull/38661 just a rebase mistake i think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] remove display of param from the UI [airflow]

2024-04-01 Thread via GitHub
hussein-awala opened a new pull request, #38660: URL: https://github.com/apache/airflow/pull/38660 Displaying the root param in the UI was added in 2015 for some reason, but after checking the current usage, I believe it is completely useless:

(airflow) branch main updated: More human friendly "show tables" output for db cleanup (#38654)

2024-04-01 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 39b3eb2491 More human friendly "show tables"

Re: [PR] More human friendly "show tables" output for db cleanup [airflow]

2024-04-01 Thread via GitHub
hussein-awala merged PR #38654: URL: https://github.com/apache/airflow/pull/38654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: bump ruff to 0.3.5 (#38656)

2024-04-01 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8455eb26c1 bump ruff to 0.3.5 (#38656)

Re: [PR] bump ruff to 0.3.5 [airflow]

2024-04-01 Thread via GitHub
hussein-awala merged PR #38656: URL: https://github.com/apache/airflow/pull/38656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Simplify metrics handling [airflow]

2024-04-01 Thread via GitHub
potiuk commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2030566237 Yes. Good idea. Let's do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(airflow) branch move-cleanup-docker-to-bash-script updated (90a81ae732 -> f6af9f9c6d)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch move-cleanup-docker-to-bash-script in repository https://gitbox.apache.org/repos/asf/airflow.git omit 90a81ae732 Move cleanup-docker to a shell scripts from composite action add

(airflow) branch move-cleanup-docker-to-bash-script updated (df6eaf5e53 -> 90a81ae732)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch move-cleanup-docker-to-bash-script in repository https://gitbox.apache.org/repos/asf/airflow.git discard df6eaf5e53 Move cleanup-docker to a shell scripts from composite action add

(airflow) branch move-cleanup-docker-to-bash-script created (now df6eaf5e53)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch move-cleanup-docker-to-bash-script in repository https://gitbox.apache.org/repos/asf/airflow.git at df6eaf5e53 Move cleanup-docker to a shell scripts from composite action No new

[PR] Move cleanup-docker to a shell scripts from composite action [airflow]

2024-04-01 Thread via GitHub
potiuk opened a new pull request, #38659: URL: https://github.com/apache/airflow/pull/38659 Cleaning up docker is a single bash script to execute - it is defined as a composite action but since it's just one bash commenad to execute, it is better to just keep it as a bash script instead -

(airflow) branch switch-cache-building-to-public-macos-runners updated (f7bb3a99e8 -> e480072efc)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git omit f7bb3a99e8 Switch building images for ARM to public GitHub macos-14 runners

Re: [PR] Fix automatic termination issue in EmrOperator by ensuring `waiter_max_attempts` is set for deferrable triggers [airflow]

2024-04-01 Thread via GitHub
boring-cyborg[bot] commented on PR #38658: URL: https://github.com/apache/airflow/pull/38658#issuecomment-2030484929 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[PR] Fix automatic termination issue in EmrOperator by ensuring `waiter_max_attempts` is set for deferrable triggers [airflow]

2024-04-01 Thread via GitHub
beobest2 opened a new pull request, #38658: URL: https://github.com/apache/airflow/pull/38658 When running EMR jobs that require a long duration, setting the `waiter_max_attempts` in EmrOperator to a high value does not prevent the "waiter error: max attempts" error from occurring after a

Re: [PR] Improve stability of remove_task_decorator function [airflow]

2024-04-01 Thread via GitHub
romsharon98 commented on PR #38649: URL: https://github.com/apache/airflow/pull/38649#issuecomment-2030482012 > Thanks for the fix, even did not know about this bug. Thanks also for the TODO; I assume there should be better options to parse the source code other than cutting by keywords.

[PR] bump uv to 0.1.27 [airflow]

2024-04-01 Thread via GitHub
hussein-awala opened a new pull request, #38657: URL: https://github.com/apache/airflow/pull/38657 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] bump ruff to 0.3.5 [airflow]

2024-04-01 Thread via GitHub
hussein-awala opened a new pull request, #38656: URL: https://github.com/apache/airflow/pull/38656 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix BigQuery connection and add docs [airflow]

2024-04-01 Thread via GitHub
shahar1 commented on code in PR #38430: URL: https://github.com/apache/airflow/pull/38430#discussion_r1546734055 ## airflow/providers/google/cloud/hooks/bigquery.py: ## @@ -82,32 +83,113 @@ class BigQueryHook(GoogleBaseHook, DbApiHook): This hook uses the Google Cloud

Re: [PR] Fix BigQuery connection and add docs [airflow]

2024-04-01 Thread via GitHub
shahar1 commented on code in PR #38430: URL: https://github.com/apache/airflow/pull/38430#discussion_r1546734055 ## airflow/providers/google/cloud/hooks/bigquery.py: ## @@ -82,32 +83,113 @@ class BigQueryHook(GoogleBaseHook, DbApiHook): This hook uses the Google Cloud

[I] Simplify metrics handling [airflow]

2024-04-01 Thread via GitHub
ferruzzi opened a new issue, #38655: URL: https://github.com/apache/airflow/issues/38655 ### Apache Airflow version 2.9.0b2 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? When OTel support was added, it enabled adding

Re: [PR] Don't make unnecessary network calls with dag-related commands [airflow]

2024-04-01 Thread via GitHub
dstandish commented on PR #38553: URL: https://github.com/apache/airflow/pull/38553#issuecomment-2030236289 > Tests failing. should be resolved now 爛 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Implement start/end/debug for multiple executors in scheduler job [airflow]

2024-04-01 Thread via GitHub
o-nikolas commented on code in PR #38514: URL: https://github.com/apache/airflow/pull/38514#discussion_r1540104792 ## airflow/jobs/job.py: ## @@ -104,12 +105,13 @@ class Job(Base, LoggingMixin): Only makes sense for SchedulerJob and BackfillJob instances. """ -

(airflow) branch main updated: Improve stability of remove_task_decorator function (#38649)

2024-04-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f1301daef0 Improve stability of

Re: [PR] Improve stability of remove_task_decorator function [airflow]

2024-04-01 Thread via GitHub
eladkal merged PR #38649: URL: https://github.com/apache/airflow/pull/38649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] More human friendly "show tables" output for db cleanup [airflow]

2024-04-01 Thread via GitHub
jedcunningham opened a new pull request, #38654: URL: https://github.com/apache/airflow/pull/38654 Don't print the string representation of a list, print out just the table names. Before: ``` You have requested that we drop 4 archived tables prefixed with _airflow_deleted__.

Re: [PR] Improve stability of remove_task_decorator function [airflow]

2024-04-01 Thread via GitHub
SamWheating commented on PR #38649: URL: https://github.com/apache/airflow/pull/38649#issuecomment-2030147771 Thanks for reviving this old PR, I totally forgot about it but I'm glad to see that its back up for review  FWIW I still think that this is an imperfect solution (and

Re: [PR] Added Feature: search dags by task id with suggestions [airflow]

2024-04-01 Thread via GitHub
jscheffl commented on PR #37436: URL: https://github.com/apache/airflow/pull/37436#issuecomment-2030075088 I checked and I have no auto-complete and suggestions when I type as described in the PR descriptions. Tested with Firefox and Chromium. Did I mis-undertstand the PR that

Re: [PR] inherit key "verify" from env into session so that kv_client can read it properly [airflow]

2024-04-01 Thread via GitHub
hussein-awala commented on PR #38614: URL: https://github.com/apache/airflow/pull/38614#issuecomment-2029919432 > I'd like to help but don't understand how to run this test, seems it needs to be used against local vault server localhost:8081? They are unit tests and not integration

Re: [PR] inherit key "verify" from env into session so that kv_client can read it properly [airflow]

2024-04-01 Thread via GitHub
chz8494 commented on PR #38614: URL: https://github.com/apache/airflow/pull/38614#issuecomment-2029906734 > The verify argument is present in [Airflow documentation

Re: [PR] fix cosmos hook static checks by making providing partition_key mandatory [airflow]

2024-04-01 Thread via GitHub
hussein-awala commented on PR #38199: URL: https://github.com/apache/airflow/pull/38199#issuecomment-2029889888 @eladkal I updated the PR and its description according to azure python SDK maintainers, could you check if we can consider it as a bug fix or if we need a new major release? Do

[PR] Use `methodtools.lru_cache` instead of `functools.lru_cache` in class methods [airflow]

2024-04-01 Thread via GitHub
Taragolis opened a new pull request, #37757: URL: https://github.com/apache/airflow/pull/37757 This is attempt to prevent use `functools.lru_cache` or `functools.cache` on methods which lead to memory leak, e.g. object can't be garbage collected if it use methods decorated

Re: [PR] Use `methodtools.lru_cache` instead of `functools.lru_cache` in class methods [airflow]

2024-04-01 Thread via GitHub
Taragolis closed pull request #37757: Use `methodtools.lru_cache` instead of `functools.lru_cache` in class methods URL: https://github.com/apache/airflow/pull/37757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

(airflow) branch switch-cache-building-to-public-macos-runners updated (1a4e790a2d -> f7bb3a99e8)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git discard 1a4e790a2d Switch building images for ARM to public GitHub macos-14 runners

(airflow) branch main updated: Avoid to use `functools.lru_cache` in class methods in `google` provider (#38652)

2024-04-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d3dc88f084 Avoid to use `functools.lru_cache` in

Re: [PR] Avoid to use `functools.lru_cache` in class methods in `google` provider [airflow]

2024-04-01 Thread via GitHub
eladkal merged PR #38652: URL: https://github.com/apache/airflow/pull/38652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch switch-cache-building-to-public-macos-runners updated (55279f3a7c -> 1a4e790a2d)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git discard 55279f3a7c Update install_breeze.sh discard fd0c0c78fc Update

(airflow) branch main updated: Introducing --latest for generate-issue-content-helm-chart command (#38648)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 1cac59ed6f Introducing --latest for

Re: [PR] Introducing --latest for generate-issue-content-helm-chart command [airflow]

2024-04-01 Thread via GitHub
potiuk merged PR #38648: URL: https://github.com/apache/airflow/pull/38648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Add a migration script for encrypted trigger kwargs (#38358)

2024-04-01 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6f0e5bce59 Add a migration script for

Re: [PR] Add a migration script for encrypted trigger kwargs [airflow]

2024-04-01 Thread via GitHub
hussein-awala merged PR #38358: URL: https://github.com/apache/airflow/pull/38358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch switch-cache-building-to-public-macos-runners updated (fd0c0c78fc -> 55279f3a7c)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from fd0c0c78fc Update install_breeze.sh add 55279f3a7c Update

(airflow) branch switch-cache-building-to-public-macos-runners updated (4fc181916f -> fd0c0c78fc)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from 4fc181916f Update install_breeze.sh add fd0c0c78fc Update

(airflow) branch switch-cache-building-to-public-macos-runners updated (f8741cf732 -> 4fc181916f)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from f8741cf732 Update install_breeze.sh add 4fc181916f Update

(airflow) branch switch-cache-building-to-public-macos-runners updated (a2b55d4192 -> f8741cf732)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from a2b55d4192 Update install_breeze.sh add f8741cf732 Update

Re: [I] google provider: GCP credentials are not passed into transfer job polling when executing S3ToGCSOperator [airflow]

2024-04-01 Thread via GitHub
eladkal commented on issue #37331: URL: https://github.com/apache/airflow/issues/37331#issuecomment-2029719493 The remaining task on this issue is explained in: https://github.com/apache/airflow/pull/37518#discussion_r1546080795 -- This is an automated message from the Apache Git

(airflow) branch main updated: Fix credentials error for S3ToGCSOperator trigger (#37518)

2024-04-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 13e9a0d0d5 Fix credentials error for

Re: [PR] Fix credentials error for S3ToGCSOperator trigger [airflow]

2024-04-01 Thread via GitHub
boring-cyborg[bot] commented on PR #37518: URL: https://github.com/apache/airflow/pull/37518#issuecomment-2029718833 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Fix credentials error for S3ToGCSOperator trigger [airflow]

2024-04-01 Thread via GitHub
eladkal merged PR #37518: URL: https://github.com/apache/airflow/pull/37518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Adding support to hive hook for high availability Hive installations [airflow]

2024-04-01 Thread via GitHub
eladkal commented on code in PR #38651: URL: https://github.com/apache/airflow/pull/38651#discussion_r1546303780 ## airflow/providers/apache/hive/hooks/hive.py: ## @@ -100,6 +100,9 @@ def __init__( ) -> None: super().__init__() conn =

(airflow) branch switch-cache-building-to-public-macos-runners updated (9d02f08a99 -> a2b55d4192)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from 9d02f08a99 Update ci-image-build.yml add a2b55d4192 Update

(airflow) branch switch-cache-building-to-public-macos-runners updated (73e21d6e00 -> 9d02f08a99)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from 73e21d6e00 Update ci-image-build.yml add 9d02f08a99 Update

(airflow) branch switch-cache-building-to-public-macos-runners updated (c9b62ad5da -> 73e21d6e00)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from c9b62ad5da Update ci-image-build.yml add 73e21d6e00 Update

(airflow) branch switch-cache-building-to-public-macos-runners updated (d2d6cdbdaf -> c9b62ad5da)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from d2d6cdbdaf Update ci-image-build.yml add c9b62ad5da Update

[PR] Avoid to use `functools.lru_cache` in class methods in `google` provider [airflow]

2024-04-01 Thread via GitHub
Taragolis opened a new pull request, #38652: URL: https://github.com/apache/airflow/pull/38652 Part of the https://github.com/apache/airflow/pull/37757, since it only appear in one place in internal method we could avoid to use

(airflow) branch switch-cache-building-to-public-macos-runners updated (ad2d953c49 -> d2d6cdbdaf)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from ad2d953c49 Update push-image-cache.yml add d2d6cdbdaf Update

Re: [PR] Add a migration script for encrypted trigger kwargs [airflow]

2024-04-01 Thread via GitHub
hussein-awala commented on code in PR #38358: URL: https://github.com/apache/airflow/pull/38358#discussion_r1546237393 ## airflow/migrations/versions/0140_2_9_0_update_trigger_kwargs_type.py: ## @@ -0,0 +1,56 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

(airflow) branch switch-cache-building-to-public-macos-runners updated (02ecbcc4ef -> ad2d953c49)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from 02ecbcc4ef Update ci-image-build.yml add ad2d953c49 Update

(airflow) branch switch-cache-building-to-public-macos-runners updated (1033793aee -> 02ecbcc4ef)

2024-04-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git from 1033793aee Switch building images for ARM to public GitHub macos-14 runners

Re: [PR] Adding support to hive hook for high availability Hive installations [airflow]

2024-04-01 Thread via GitHub
amoghrajesh commented on PR #38651: URL: https://github.com/apache/airflow/pull/38651#issuecomment-2029586589 > Looks good :) Can u just add test with `proxy_user` in `extra_json` just to verify that it add `;` correctly and to verify someone else not remove it. Good catch! Updated

(airflow) branch main updated (9da08a525e -> 39b684d91a)

2024-04-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 9da08a525e Use explicit and easier to use runs-on approach for CI workflows (#38601) add 39b684d91a add

Re: [PR] add repair_run support to DatabricksRunNowOperator in deferrable mode [airflow]

2024-04-01 Thread via GitHub
eladkal merged PR #38619: URL: https://github.com/apache/airflow/pull/38619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >