[GitHub] [incubator-druid] gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature

2019-08-05 Thread GitBox
gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature URL: https://github.com/apache/incubator-druid/pull/8245#discussion_r310888120 ## File path: docs/content/development/indexer.md ## @@ -0,0 +1,152 @@ +--- +layout:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature

2019-08-05 Thread GitBox
gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature URL: https://github.com/apache/incubator-druid/pull/8245#discussion_r310888497 ## File path: docs/content/development/indexer.md ## @@ -0,0 +1,152 @@ +--- +layout:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature

2019-08-05 Thread GitBox
gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature URL: https://github.com/apache/incubator-druid/pull/8245#discussion_r310887454 ## File path: docs/content/development/indexer.md ## @@ -0,0 +1,152 @@ +--- +layout:

[GitHub] [incubator-druid] gianm commented on issue #8245: Add docs for CliIndexer as an experimental feature

2019-08-05 Thread GitBox
gianm commented on issue #8245: Add docs for CliIndexer as an experimental feature URL: https://github.com/apache/incubator-druid/pull/8245#issuecomment-518511216 I am so amped about the Indexer. This is an automated message

[GitHub] [incubator-druid] gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature

2019-08-05 Thread GitBox
gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature URL: https://github.com/apache/incubator-druid/pull/8245#discussion_r310885372 ## File path: docs/content/development/indexer.md ## @@ -0,0 +1,152 @@ +--- +layout:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature

2019-08-05 Thread GitBox
gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature URL: https://github.com/apache/incubator-druid/pull/8245#discussion_r310888041 ## File path: docs/content/development/indexer.md ## @@ -0,0 +1,152 @@ +--- +layout:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature

2019-08-05 Thread GitBox
gianm commented on a change in pull request #8245: Add docs for CliIndexer as an experimental feature URL: https://github.com/apache/incubator-druid/pull/8245#discussion_r310887504 ## File path: docs/content/development/indexer.md ## @@ -0,0 +1,152 @@ +--- +layout:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
gianm commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310885038 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
gianm commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310864811 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
gianm commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310861548 ## File path:

[GitHub] [incubator-druid] vogievetsky commented on issue #8232: Web-Console: add dimensions to datasources icon

2019-08-05 Thread GitBox
vogievetsky commented on issue #8232: Web-Console: add dimensions to datasources icon URL: https://github.com/apache/incubator-druid/pull/8232#issuecomment-518491012 Looks good. Thank you for fixing. g2g once travis passes. 

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8236: Add TaskResourceCleaner; fix a couple of concurrency bugs in batch tasks

2019-08-05 Thread GitBox
jihoonson commented on a change in pull request #8236: Add TaskResourceCleaner; fix a couple of concurrency bugs in batch tasks URL: https://github.com/apache/incubator-druid/pull/8236#discussion_r310870445 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8236: Add TaskResourceCleaner; fix a couple of concurrency bugs in batch tasks

2019-08-05 Thread GitBox
jihoonson commented on a change in pull request #8236: Add TaskResourceCleaner; fix a couple of concurrency bugs in batch tasks URL: https://github.com/apache/incubator-druid/pull/8236#discussion_r310870428 ## File path:

[incubator-druid] branch master updated: Web console: celebrate array based groupBy by supporting resultAsArray in the console (#8231)

2019-08-05 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 0235b33 Web console: celebrate array

[GitHub] [incubator-druid] clintropolis merged pull request #8231: Web console: celebrate array based groupBy by supporting resultAsArray in the console

2019-08-05 Thread GitBox
clintropolis merged pull request #8231: Web console: celebrate array based groupBy by supporting resultAsArray in the console URL: https://github.com/apache/incubator-druid/pull/8231 This is an automated message from the

[GitHub] [incubator-druid] jon-wei opened a new pull request #8245: Add docs for CliIndexer as an experimental feature

2019-08-05 Thread GitBox
jon-wei opened a new pull request #8245: Add docs for CliIndexer as an experimental feature URL: https://github.com/apache/incubator-druid/pull/8245 Adds a doc page for the new CliIndexer process (see #7900) as an experimental feature. This PR also adds a configuration option for

[GitHub] [incubator-druid] gianm commented on issue #8242: should we deprecate extractionFn field in various Aggregators and Filters

2019-08-05 Thread GitBox
gianm commented on issue #8242: should we deprecate extractionFn field in various Aggregators and Filters URL: https://github.com/apache/incubator-druid/issues/8242#issuecomment-518450278 I’m a bit nervous about removing something so widely used. I wonder if we can introduce a compat

[GitHub] [incubator-druid] himanshug commented on issue #8244: Update docker build

2019-08-05 Thread GitBox
himanshug commented on issue #8244: Update docker build URL: https://github.com/apache/incubator-druid/pull/8244#issuecomment-518438602 > @himanshug I am really sorry for opening this PR again. My forked master branch was messed up. Its fine, everyone messes up including me. +1 for

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
clintropolis commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310830104 ## File path:

[GitHub] [incubator-druid] vogievetsky commented on issue #8231: Web console: celebrate array based groupBy by supporting resultAsArray in the console

2019-08-05 Thread GitBox
vogievetsky commented on issue #8231: Web console: celebrate array based groupBy by supporting resultAsArray in the console URL: https://github.com/apache/incubator-druid/pull/8231#issuecomment-518435704 Ok updated to address @fjy 's comments. Also updated the licenses that went out of

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
clintropolis commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310812077 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
clintropolis commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310811872 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
clintropolis commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310807921 ## File path:

[GitHub] [incubator-druid] stale[bot] commented on issue #7648: Handle exceptions while fetching offsets

2019-08-05 Thread GitBox
stale[bot] commented on issue #7648: Handle exceptions while fetching offsets URL: https://github.com/apache/incubator-druid/pull/7648#issuecomment-518413793 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity

[GitHub] [incubator-druid] Fokko commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
Fokko commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310802823 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunnerV2.java

[GitHub] [incubator-druid] gianm merged pull request #8227: Web-Console: change go to sql button to more button

2019-08-05 Thread GitBox
gianm merged pull request #8227: Web-Console: change go to sql button to more button URL: https://github.com/apache/incubator-druid/pull/8227 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch master updated: Web-Console: change go to sql button to more button (#8227)

2019-08-05 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 5d0805d Web-Console: change go to sql

[GitHub] [incubator-druid] leventov commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310793741 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunnerV2.java

[GitHub] [incubator-druid] vogievetsky commented on issue #8227: Web-Console: change go to sql button to more button

2019-08-05 Thread GitBox
vogievetsky commented on issue #8227: Web-Console: change go to sql button to more button URL: https://github.com/apache/incubator-druid/pull/8227#issuecomment-518401428 Thank you for addressing my feedback, this is good to merge IMO 

[GitHub] [incubator-druid] ilhanadiyaman commented on issue #8244: Update docker build

2019-08-05 Thread GitBox
ilhanadiyaman commented on issue #8244: Update docker build URL: https://github.com/apache/incubator-druid/pull/8244#issuecomment-518397727 @himanshug I am really sorry for opening this PR again. My forked master branch was messed up.

[GitHub] [incubator-druid] ilhanadiyaman opened a new pull request #8244: Update docker build

2019-08-05 Thread GitBox
ilhanadiyaman opened a new pull request #8244: Update docker build URL: https://github.com/apache/incubator-druid/pull/8244 Sorry for opening again. My master branch was messed up. Fixes #8054 ### Description - [License generation

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #5872: add method getRequiredColumns for DimFilter

2019-08-05 Thread GitBox
clintropolis commented on a change in pull request #5872: add method getRequiredColumns for DimFilter URL: https://github.com/apache/incubator-druid/pull/5872#discussion_r310786713 ## File path: processing/src/main/java/io/druid/query/filter/DimFilter.java ## @@ -75,4

[GitHub] [incubator-druid] jihoonson commented on issue #8115: Add shuffleSegmentPusher for data shuffle

2019-08-05 Thread GitBox
jihoonson commented on issue #8115: Add shuffleSegmentPusher for data shuffle URL: https://github.com/apache/incubator-druid/pull/8115#issuecomment-518394084 @himanshug @clintropolis thank you for the review. This is an

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8222: Fix bugs in overshadowableManager and add unit tests

2019-08-05 Thread GitBox
jihoonson commented on a change in pull request #8222: Fix bugs in overshadowableManager and add unit tests URL: https://github.com/apache/incubator-druid/pull/8222#discussion_r310785662 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8222: Fix bugs in overshadowableManager and add unit tests

2019-08-05 Thread GitBox
jihoonson commented on a change in pull request #8222: Fix bugs in overshadowableManager and add unit tests URL: https://github.com/apache/incubator-druid/pull/8222#discussion_r310785630 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8222: Fix bugs in overshadowableManager and add unit tests

2019-08-05 Thread GitBox
jihoonson commented on a change in pull request #8222: Fix bugs in overshadowableManager and add unit tests URL: https://github.com/apache/incubator-druid/pull/8222#discussion_r310785647 ## File path:

[GitHub] [incubator-druid] himanshug closed issue #8054: Issue while using Docker build

2019-08-05 Thread GitBox
himanshug closed issue #8054: Issue while using Docker build URL: https://github.com/apache/incubator-druid/issues/8054 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-druid] himanshug merged pull request #8237: Update docker build

2019-08-05 Thread GitBox
himanshug merged pull request #8237: Update docker build URL: https://github.com/apache/incubator-druid/pull/8237 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[incubator-druid] branch master updated: Add shuffleSegmentPusher for data shuffle (#8115)

2019-08-05 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new ab5b3be Add shuffleSegmentPusher

[GitHub] [incubator-druid] himanshug merged pull request #8115: Add shuffleSegmentPusher for data shuffle

2019-08-05 Thread GitBox
himanshug merged pull request #8115: Add shuffleSegmentPusher for data shuffle URL: https://github.com/apache/incubator-druid/pull/8115 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-druid] himanshug commented on issue #8126: [Proposal] BufferAggregator support for growable sketches.

2019-08-05 Thread GitBox
himanshug commented on issue #8126: [Proposal] BufferAggregator support for growable sketches. URL: https://github.com/apache/incubator-druid/issues/8126#issuecomment-518386793 > If I now understand correctly the purpose of the current proposal is to handle the queries aggregation

[GitHub] [incubator-druid] clintropolis commented on issue #8242: should we deprecate extractionFn field in various Aggregators and Filters

2019-08-05 Thread GitBox
clintropolis commented on issue #8242: should we deprecate extractionFn field in various Aggregators and Filters URL: https://github.com/apache/incubator-druid/issues/8242#issuecomment-518386455 sgtm :+1: This is an

[GitHub] [incubator-druid] himanshug commented on issue #8109: fix merging of groupBy subtotal spec results

2019-08-05 Thread GitBox
himanshug commented on issue #8109: fix merging of groupBy subtotal spec results URL: https://github.com/apache/incubator-druid/pull/8109#issuecomment-518385521 @gianm can you please review it again ? This is an automated

[GitHub] [incubator-druid] himanshug opened a new pull request #8243: make double sum/min/max agg work on string columns

2019-08-05 Thread GitBox
himanshug opened a new pull request #8243: make double sum/min/max agg work on string columns URL: https://github.com/apache/incubator-druid/pull/8243 Partial work towards #8148 . There would be follow up PR to do same for other core aggregators once this is merged. ### Description

[GitHub] [incubator-druid] gianm commented on issue #7093: [PROPOSAL] Query vectorization

2019-08-05 Thread GitBox
gianm commented on issue #7093: [PROPOSAL] Query vectorization URL: https://github.com/apache/incubator-druid/issues/7093#issuecomment-518383739 Closed by #6794. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] gianm closed issue #7093: [PROPOSAL] Query vectorization

2019-08-05 Thread GitBox
gianm closed issue #7093: [PROPOSAL] Query vectorization URL: https://github.com/apache/incubator-druid/issues/7093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-druid] himanshug opened a new issue #8242: should we deprecate extractionFn field in various Aggregators and Filters

2019-08-05 Thread GitBox
himanshug opened a new issue #8242: should we deprecate extractionFn field in various Aggregators and Filters URL: https://github.com/apache/incubator-druid/issues/8242 they were added before `VirtualColumn` was introduced and I think a better alternative now could be to have a

[GitHub] [incubator-druid] Fokko commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
Fokko commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310750551 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunnerV2.java

[GitHub] [incubator-druid] Fokko commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
Fokko commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310750268 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunnerV2.java

[GitHub] [incubator-druid] Fokko commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
Fokko commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310749986 ## File path: core/src/main/java/org/apache/druid/java/util/common/io/Closer.java ## @@ -123,6 +123,17 @@ private

[GitHub] [incubator-druid] Fokko commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
Fokko commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310749285 ## File path: core/src/main/java/org/apache/druid/java/util/common/io/Closer.java ## @@ -123,6 +123,17 @@ private

[GitHub] [incubator-druid] Fokko commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
Fokko commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310748843 ## File path: core/src/main/java/org/apache/druid/java/util/common/io/Closer.java ## @@ -123,6 +123,17 @@ private

[GitHub] [incubator-druid] jon-wei merged pull request #8100: SQL support for t-digest based sketch aggregators

2019-08-05 Thread GitBox
jon-wei merged pull request #8100: SQL support for t-digest based sketch aggregators URL: https://github.com/apache/incubator-druid/pull/8100 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch master updated (ac856fe -> 93cf9d4)

2019-08-05 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from ac856fe Web-Console: Adds edit-context-dialog (#8228) add 93cf9d4 SQL support for t-digest based

[GitHub] [incubator-druid] Eshcar commented on issue #8126: [Proposal] BufferAggregator support for growable sketches.

2019-08-05 Thread GitBox
Eshcar commented on issue #8126: [Proposal] BufferAggregator support for growable sketches. URL: https://github.com/apache/incubator-druid/issues/8126#issuecomment-518356531 Thanks, that was our impression - that off-heap incremental index is not operational (however it does exist in

[GitHub] [incubator-druid] stale[bot] commented on issue #6541: compaction tasks run for much time

2019-08-05 Thread GitBox
stale[bot] commented on issue #6541: compaction tasks run for much time URL: https://github.com/apache/incubator-druid/issues/6541#issuecomment-518353565 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If this

[GitHub] [incubator-druid] leventov commented on a change in pull request #7562: Enable toggling request logging on/off for different query types

2019-08-05 Thread GitBox
leventov commented on a change in pull request #7562: Enable toggling request logging on/off for different query types URL: https://github.com/apache/incubator-druid/pull/7562#discussion_r310741593 ## File path:

[GitHub] [incubator-druid] capistrant commented on a change in pull request #7562: Enable toggling request logging on/off for different query types

2019-08-05 Thread GitBox
capistrant commented on a change in pull request #7562: Enable toggling request logging on/off for different query types URL: https://github.com/apache/incubator-druid/pull/7562#discussion_r310739354 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8236: Add TaskResourceCleaner; fix a couple of concurrency bugs in batch tasks

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8236: Add TaskResourceCleaner; fix a couple of concurrency bugs in batch tasks URL: https://github.com/apache/incubator-druid/pull/8236#discussion_r310723222 ## File path:

[GitHub] [incubator-druid] leventov commented on issue #8126: [Proposal] BufferAggregator support for growable sketches.

2019-08-05 Thread GitBox
leventov commented on issue #8126: [Proposal] BufferAggregator support for growable sketches. URL: https://github.com/apache/incubator-druid/issues/8126#issuecomment-518327693 Currently, the off-heap incremental index is used only in GroupBy V1, which is itself deprecated and may not

[GitHub] [incubator-druid] leventov commented on issue #8126: [Proposal] BufferAggregator support for growable sketches.

2019-08-05 Thread GitBox
leventov commented on issue #8126: [Proposal] BufferAggregator support for growable sketches. URL: https://github.com/apache/incubator-druid/issues/8126#issuecomment-518326114 > Then presenting a solution to this problem using Oak to manage the off-heap index, handling growable sketches

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310691637 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310705663 ## File path: processing/src/main/java/org/apache/druid/query/Druids.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310693015 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310692390 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310707102 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310695880 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310705538 ## File path: processing/src/main/java/org/apache/druid/query/Druids.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310706626 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310693642 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310695665 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310704426 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310704732 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310693686 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310694567 ## File path:

[GitHub] [incubator-druid] leventov opened a new issue #8241: Prohibit creating collections from stream.collect(...) using Structural Search inspection

2019-08-05 Thread GitBox
leventov opened a new issue #8241: Prohibit creating collections from stream.collect(...) using Structural Search inspection URL: https://github.com/apache/incubator-druid/issues/8241 1. ``` new $Coll$($stream$.collect($collector$)) ``` The whole match filter:

[GitHub] [incubator-druid] ccaominh opened a new pull request #8240: WIP Speedup Travis CI jobs

2019-08-05 Thread GitBox
ccaominh opened a new pull request #8240: WIP Speedup Travis CI jobs URL: https://github.com/apache/incubator-druid/pull/8240 _**NOTE: This PR is a work-in-progress to see effects of the Travis CI changes.**_ ### Description Reorganize Travis CI jobs into smaller (and more)

[GitHub] [incubator-druid] stale[bot] closed issue #6408: Selector filter for multi-value dimensions is not returning all values

2019-08-05 Thread GitBox
stale[bot] closed issue #6408: Selector filter for multi-value dimensions is not returning all values URL: https://github.com/apache/incubator-druid/issues/6408 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] stale[bot] commented on issue #6408: Selector filter for multi-value dimensions is not returning all values

2019-08-05 Thread GitBox
stale[bot] commented on issue #6408: Selector filter for multi-value dimensions is not returning all values URL: https://github.com/apache/incubator-druid/issues/6408#issuecomment-518311283 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue

[GitHub] [incubator-druid] leventov commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310683772 ## File path: core/src/main/java/org/apache/druid/java/util/common/io/Closer.java ## @@ -123,6 +123,17 @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310684423 ## File path: core/src/main/java/org/apache/druid/java/util/common/io/Closer.java ## @@ -123,6 +123,17 @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310686115 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunnerV2.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310686168 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunnerV2.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8235: Use Closer instead of List

2019-08-05 Thread GitBox
leventov commented on a change in pull request #8235: Use Closer instead of List URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310684935 ## File path: core/src/main/java/org/apache/druid/java/util/common/io/Closer.java ## @@ -123,6 +123,17 @@

[GitHub] [incubator-druid] leventov opened a new issue #8239: Specify lineWrappingIndentation in Checkstyle's Indentation check

2019-08-05 Thread GitBox
leventov opened a new issue #8239: Specify lineWrappingIndentation in Checkstyle's Indentation check URL: https://github.com/apache/incubator-druid/issues/8239 See https://checkstyle.org/config_misc.html#Indentation Currently, it's `lineWrappingIndentation` and

[GitHub] [incubator-druid] leventov commented on a change in pull request #7562: Enable toggling request logging on/off for different query types

2019-08-05 Thread GitBox
leventov commented on a change in pull request #7562: Enable toggling request logging on/off for different query types URL: https://github.com/apache/incubator-druid/pull/7562#discussion_r310683092 ## File path:

[GitHub] [incubator-druid] stale[bot] commented on issue #6539: Task failure for kafka indexing service in druid 0.12.1 with no error logs

2019-08-05 Thread GitBox
stale[bot] commented on issue #6539: Task failure for kafka indexing service in druid 0.12.1 with no error logs URL: https://github.com/apache/incubator-druid/issues/6539#issuecomment-518185577 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4

[GitHub] [incubator-druid] AlexandreYang opened a new pull request #8238: [statsd-emitter] Add config to send Druid process/service as tag

2019-08-05 Thread GitBox
AlexandreYang opened a new pull request #8238: [statsd-emitter] Add config to send Druid process/service as tag URL: https://github.com/apache/incubator-druid/pull/8238 ### Description When using `statsd-emitter` with Dogstatsd, the Druid process/service name (e.g.