Re: [Trivia PATCH 4/5] Check harder for -lresolv

2010-08-20 Thread Marcel Holtmann
Hi Pekka, Older Debians and friends expose __ns_initparse and their resolv.h defines ns_initparse is __ns_initparse. --- configure.ac |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 7762f5c..b7bfd67 100644 --- a/configure.ac

Re: [PATCH] fix iptables-test to work with iptables 1.4.9

2010-08-19 Thread Marcel Holtmann
Hi Robert, Starting with version 1.4.9 iptables dropped xtables_set_revision function. This patch removes any use of it. --- tools/iptables-test.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) patch has been applied. Thanks. Regards Marcel

Re: Configuration file naming

2010-08-18 Thread Marcel Holtmann
Hi Samuel, I put a configuration file in /var/lib/connman/ (STORAGEDIR). The file name is eap_peap.config. When I launch connman, I see that this file is not taken in account. After looking into the code, I saw that connman_dbus_validate_ident() accepts only numbers and letters

Re: [PATCH v2] Remove __ prefix from static functions

2010-08-18 Thread Marcel Holtmann
Hi Daniel, __connman prefixes are for non static functions exported to all connman core code (but not plugins). connman prefixes are for non static functions exported to all connman (core and plugins). --- src/element.c |6 +++--- src/provider.c |4 ++-- src/service.c | 36

Re: [RFC] [PATCH] ConnMan backtrace support

2010-08-17 Thread Marcel Holtmann
Hi Samuel, +static void signal_handler(int signo) +{ + switch (signo) { + case SIGSEGV: + case SIGBUS: + case SIGILL: + case SIGABRT: + connman_info(Aborting (signal %d), signo); + __connman_log_backtrace(); + exit(1); + + case

Re: [PATCH 2/3] Support ancient shells, do not use VAR+=VALUE

2010-08-17 Thread Marcel Holtmann
Hi Pekka, acinclude.m4 | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 84086fd..7e0cdc0 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -15,13 +15,20 @@ AC_DEFUN([COMPILER_FLAGS], [

Re: [PATCH 1/3] Use memcpy with dhcp unaligned access

2010-08-17 Thread Marcel Holtmann
Hi Pekka, --- gdhcp/client.c | 14 +++--- gdhcp/common.c |2 +- gdhcp/common.h | 17 +++-- 3 files changed, 15 insertions(+), 18 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index a7bd88a..ba43b85 100644 --- a/gdhcp/client.c +++

Re: Network configuration with connman

2010-08-13 Thread Marcel Holtmann
Hi Kalle, If yes please tell me how to configure/enable dhcp client using connman? configure script has --enable-dhclient which will enable ISC's dhcp client plugin. And connman also has the internal dhcp client, I think that's enabled by default (didn't check). yes, the internal one is

Re: ANNOUNCE: ConnMan 0.57

2010-08-13 Thread Marcel Holtmann
Hi Stephan, nice :-) is it possible to write such announce messages over this mailinglist with every new release? lets make a deal, you stop top posting and we try to make announcements on a more regular basis ;) Regards Marcel ___ connman

Re: Get information about the associated access point

2010-08-13 Thread Marcel Holtmann
Hi Javier, Is there any way to get information from the Connman Manager about the associated Access Point ? I would be interested on the MAC address, for instance, and other IP information. Check doc/network-lowlevel-api.txt and doc/service-api.txt. Also looking at the

Re: [PATCH] Add support for EAP configuration via service-api

2010-08-13 Thread Marcel Holtmann
Hi Lucio, I must admit that I haven't spent much on the details here, but in general I would you pass a configuration as string. This string for example could be the same format or maybe better XML. As I said, the only thing that I know is that we don't wanna do this via service

Re: [PATCH] Add support for EAP configuration via service-api

2010-08-13 Thread Marcel Holtmann
Hi Kalle, So, how that should work, we would pass a configuration filename for connman, that would set the service's settings and would save it to the proper place so it will read it every restart. Or just save the service settings using normal service storage? I must admit that

Re: [PATCH] Add support for EAP configuration via service-api

2010-08-12 Thread Marcel Holtmann
Hi Lucio, Support configuration of EAP parameters via service-api DBus interface. Also save and load EAP parameters from connman storage. Provisioned EAP services are still immutable and can't be changed using the service-api --- doc/service-api.txt | 77 ++

Re: [PATCH] Add support for EAP configuration via service-api

2010-08-12 Thread Marcel Holtmann
Hi Samuel, we don't really wanna do this and that is the reason why we never exposed these information. Ok. got it. I prefer actually that loading configuration via D-Bus is implemented than a bunch of WPA-Enterprise parameters that we can not expose to the end user

Re: [PATCH] Add support for EAP configuration via service-api

2010-08-12 Thread Marcel Holtmann
Hi Lucio, yes, that is what I mean. Install provision configuration via a user interface. And yes, the Manager interface sounds right. Are you planning to work on that? Thats is up to my Manager, but I hope so. I would really welcome that :) So, how that should work, we would pass a

Re: connman 0.55 crashing at launch

2010-08-03 Thread Marcel Holtmann
Hi Pierre, I have downloaded and compiled connman-0.55. It segfaults at launch, before I can do anything. It is cross-compiled for embedded arm platform. I have disabled the dhcp and udhcpc plugins (however even if I enable the udhcpc plugin the problem still occurs). It seems

Re: connman 0.55 crashing at launch

2010-08-02 Thread Marcel Holtmann
Hi Pierre, I have downloaded and compiled connman-0.55. It segfaults at launch, before I can do anything. It is cross-compiled for embedded arm platform. I have disabled the dhcp and udhcpc plugins (however even if I enable the udhcpc plugin the problem still occurs). It seems to crash in

Re: [PATCH] Set default IPv6 method as off

2010-08-02 Thread Marcel Holtmann
Hi David, diff --git a/src/ipconfig.c b/src/ipconfig.c index 6ffcd88..e6e63b2 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -849,6 +849,7 @@ static struct connman_ipconfig *create_ipv6config(int index) ipv6config-index = index; ipv6config-type =

Re: [PATCH] Set default IPv6 method as off

2010-07-29 Thread Marcel Holtmann
Hi Martin, --- src/ipconfig.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 6ffcd88..e6e63b2 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -849,6 +849,7 @@ static struct connman_ipconfig *create_ipv6config(int

RE: Bluetooth in connman

2010-07-27 Thread Marcel Holtmann
Hi Sebastien, a gentle reminder that we don't allow top-posting on this mailing list. I know it is hard with Outlook, but please obey our etiquette here. Does that mean that a handset using the latest connman release can't be used by a netbook/laptop (over BT PAN) to access network (3G/WLAN)

Re: [PATCH v2] watch: Free service data in service_reply

2010-07-26 Thread Marcel Holtmann
Hi Samuel, Avoid the memory leak of server_data. Patch applied, thanks for catching this. please do me a favor and wait with gdbus/ changes until we have synced them at least inside bluez.git. We need to apply them across projects and I like to keep the same commit messages. Regards Marcel

Re: [PATCH v2] Add support for roaming/home network statistic

2010-07-26 Thread Marcel Holtmann
Hi Daniel, Currently connman only has one set of counters for collecting statistics on online time and the amount of transfered bytes. For 3G connections we should destinguish between home network and roaming. This patch introduces two sets of counter values for home network and

Re: [PATCH v2] Add support for roaming/home network statistic

2010-07-26 Thread Marcel Holtmann
Hi Daniel, I'm not so sure doing the home/roaming on service level is correct. Consider following case: I'm travelling from Germany to Italy for a couple of days and then to Switzerland. The roaming statistics would not distinguish between Italy and Switzerland. The prolbem is that

Re: Connman + udhcpc not fetching an ip

2010-07-26 Thread Marcel Holtmann
Hi Mohammed, I'm running ConnMan on a embedded linux platform. The problem is that with the udhcpc plugin it doesn't fetch an ip. I've run the individual script with some debug print statements. # /sbin/udhcpc -f -i eth1 -p /home/MAK/UserArea/porting/

Re: [PATCH 1/2] Fix crash in dhclient release

2010-07-09 Thread Marcel Holtmann
Hi Pekka, plugins/dhclient.c | 40 ++-- 1 files changed, 22 insertions(+), 18 deletions(-) patch has been applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net

Re: [PATCH v2] Add additionals statistics counters

2010-07-08 Thread Marcel Holtmann
Hi Daniel, Adding rx_packets, tx_packets, rx_errors, tx_errors, rx_dropped and tx_dropped counters. patch has been applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH] Fix dhclient release crashing.

2010-07-08 Thread Marcel Holtmann
Hi Pekka, --- plugins/dhclient.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/plugins/dhclient.c b/plugins/dhclient.c index fd86773..01b87f3 100644 --- a/plugins/dhclient.c +++ b/plugins/dhclient.c @@ -114,15 +114,21 @@ struct dhclient_data {

Re: [PATCH v0] Initialize offset counters

2010-07-07 Thread Marcel Holtmann
Hi Daniel, The Service object needs the the first update of the statistic counters to know the offset for its calculation. Until now, the first timeout of timer was used to update this values. This fix triggers an update only for initialiting the offset values and does not notify the

Re: [PATCH v3 1/3] Centralize rntl update timers

2010-06-30 Thread Marcel Holtmann
Hi Daniel, +static gint compare_interval(gconstpointer a, gconstpointer b) +{ + guint i = GPOINTER_TO_UINT(a); + guint j = GPOINTER_TO_UINT(b); + + return i - j; +} So personally I would do val_a - val_b to give some relation to the pointer, but i and j work as well. I

Re: [PATCH v3 1/3] Centralize rntl update timers

2010-06-29 Thread Marcel Holtmann
Hi Daniel, Instead of creating a new rntl trigger for each Counter object move this part to the rtnl core. Only one update trigger will be registered at RTNL. The minimum interval will used for the timeout callback. patch looks good, but here are some minor nitpicks. +static gint

Re: [PATCH v3 3/3] Update service statistic

2010-06-29 Thread Marcel Holtmann
Hi Daniel, Instead of collecting statistics on interface name base and storing it local in counter.c, update the Service object. counter.c maps interface names to Service objects. The assumption is made that there is a 1:1 mapping between Service objects and interface name. A Counter

Re: [PATCH v3 2/3] Add service statistic data structure

2010-06-29 Thread Marcel Holtmann
Hi Daniel, The static values are maintained in the Service object and exposed through simple accessors. When a Service object enters the ready state it registers itself at Counter. If the Service object is leaving the ready state it will de-register itself from Counter and

Re: [RFC v0 1/2] Centralize rntl update timers

2010-06-16 Thread Marcel Holtmann
Hi Daniel, +static guint get_min_interval(unsigned int interval) +{ + GSList *list; + guint min = G_MAXUINT; + + for (list = update_list; list; list = list-next) + min = MIN(min, GPOINTER_TO_UINT(list-data)); + + return min; +} wouldn't it be better to just

Re: [PATCH v2] ofono: do not use context path as network group identifier

2010-06-11 Thread Marcel Holtmann
Hi Kalle, The ofono plugin was using context path as network group identifier which caused service path to end something like this: /profile/default/cellular_244053111242822_huawei2_primarycontext1 But the problem here is that with certain modems (like my Huawei E1552) the path will

Re: Multiple cellular connections

2010-06-02 Thread Marcel Holtmann
Hi Saandeep, I have some queries on connman, can any one address it, i am using connnman on mobile platform. 1) Does connman supports two cellular connections ? Ex:- one is GPRS and second one is MMS yes, it does support multiple GPRS connection if you configure them correctly.

Re: Ubuntu workitems for connman

2010-05-28 Thread Marcel Holtmann
Hi Kalle, * connecting state for icon animation We want to animate an icon whenever connman starts connection establishment from offline state. Currently there is no way to do that. One possibility is to add new state connecting to Manager interface (which currently supports

Re: Ubuntu workitems for connman

2010-05-27 Thread Marcel Holtmann
Hi Kalle, we are working on getting connman to Ubuntu Netbook Edition for 10.10 release. There's a lot of work todo, both in terms of features as well as bug fixing. It will be challenging, that's for sure. Especially because we don't have that much time, the first beta is scheduled to

Re: Ubuntu workitems for connman

2010-05-27 Thread Marcel Holtmann
Hi Kalle, * connecting state for icon animation We want to animate an icon whenever connman starts connection establishment from offline state. Currently there is no way to do that. One possibility is to add new state connecting to Manager interface (which currently supports only

Re: Stale online state after using cellular

2010-05-26 Thread Marcel Holtmann
Hi Kalle, I'm testing my infamous Huawei E1552 with connman now. I noticed that after I disconnect the cellular connection, connman still claims to be online even I do not have any other services connected: $ cmcc state State: online AvailableTechnologies: { ethernet wifi cellular }

Re: [PATCH] Add configuration file option for passphrase

2010-05-22 Thread Marcel Holtmann
Hi Daniel, --- doc/config-format.txt |1 + src/config.c | 11 +++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/doc/config-format.txt b/doc/config-format.txt index ef530e6..bc5a5c1 100644 --- a/doc/config-format.txt +++ b/doc/config-format.txt

Re: GENIVI connection manager

2010-05-22 Thread Marcel Holtmann
Hi Alan, My take on SIM PINs is that they are pointless. I would disagree somewhat. In an embedded environment they are of some value because - the fs may well be crypted or otherwise protected and is probably on flash - the average car thief doesn't talk JTAG anyway The average

Re: GENIVI connection manager

2010-05-21 Thread Marcel Holtmann
Hi Daniel, - why config is in XML and why does it duplicates some data that is stored in connman and ofono? I'd rather use simple pickle if it is meant to be always in Python, or ini-like format as allowed by the ConfigFile python module, it would be more in sync with connman :-)

Re: Interface for editing stored connections

2010-05-14 Thread Marcel Holtmann
Hi Kalle, I need an interface to add, edit and remove stored services, not just the ones which are currently available. I haven't found a way to do that with connman. Any ideas what's the best way to implement this? I need it for a GUI I'm working on:

Re: Interface for editing stored connections

2010-05-14 Thread Marcel Holtmann
Hi Lucas, So right now ConnMan only gives you the current list of available services. We believe that overloading the UI with information about other services that are currently not available is not needed. It is in Here I disagree (see below). Anyhow, we have been discussing this a

Re: problems with property change signals

2010-05-14 Thread Marcel Holtmann
Hi Jussi, I'm testing the manual DNS server configuration support that appeared on wednesday. It seems there are no property change signals when I set Nameservers.Configuration and re-connect, neither for Nameservers.Configuration nor for Nameservers. Calling GetProperties() does return

Re: [PATCH 2/2] Add cmc, a command-line client interface for ConnMan

2010-05-14 Thread Marcel Holtmann
Hi Kalle, A unified command-line interface helps users when they are testing ConnMan. Name the script as cmc, meaning ConnMan CLI. [...] nice tool, but I think we first need to discuss what you would expect from such a tool. And of course what is a good command line using

Re: Interface for editing stored connections

2010-05-13 Thread Marcel Holtmann
Hi Kalle, I need an interface to add, edit and remove stored services, not just the ones which are currently available. I haven't found a way to do that with connman. Any ideas what's the best way to implement this? I need it for a GUI I'm working on:

Re: Fail immediately enabling/disabling unregistered technology

2010-05-11 Thread Marcel Holtmann
Hi Forrest, Previously, calling EnableTechnology or DisableTechnology with an unregistered technology type caused the call to fail silently and eventually timeout. With this patch, a Not Registered error is returned immediately instead. good catch. --- src/connman.h |1 +

Re: [PATCH] Fail immediately enabling/disabling unregistered technology

2010-05-11 Thread Marcel Holtmann
Hi Forest, Previously, calling EnableTechnology or DisableTechnology with an unregistered technology type caused the call to fail silently and eventually timeout. With this patch, a Not Registered error is returned immediately instead. patch has been applied. Thanks. Regards Marcel

Re: [PATCH 1/2] Remove unfinished cm tool

2010-05-10 Thread Marcel Holtmann
Hi Kalle, It will be replaced by a tool written in python. I know that Python is quick solution, but I prefer to keep it and extend it into a real ConnMan command line client. Regards Marcel ___ connman mailing list connman@connman.net

Re: [PATCH 2/2] Add cmc, a command-line client interface for ConnMan

2010-05-10 Thread Marcel Holtmann
Hi Kalle, A unified command-line interface helps users when they are testing ConnMan. Name the script as cmc, meaning ConnMan CLI. I was thinking the name cm, but Ubuntu already had a package config-manager which has a command named cm. Commands provided by this script are: Usage: ./cmc

Re: [PATCH 1/1] Check ssid_len before set WiFi.SSID of network

2010-05-10 Thread Marcel Holtmann
Hi Martin, Wpa_s 0.7.1 reports hidden network SSID as NULL, during scan. Conseqently, the ssid of hidden network (which is set by user before) may be cleared, and can not be connected anymore. patch has been applied. Thanks. However can I remind you to keep the commit messages at 72 chars

Re: [PATCH] resolvfile: Support multiple nameservers.

2010-05-08 Thread Marcel Holtmann
Hi Forest, Nameservers are appended to a local entry list. The MAXNS most recently appended nameservers are written to /etc/resolv.conf in reverse order (the most recently appended entry becomes the primary nameserver). patch has been applied, but I had to do minor coding style updates

Re: [PATCH] resolvfile: Support multiple nameservers.

2010-05-08 Thread Marcel Holtmann
Hi Forrest, Nameservers are appended to a local entry list. The MAXNS most recently appended nameservers are written to /etc/resolv.conf in reverse order (the most recently appended entry becomes the primary nameserver). patch has been applied, but I had to do minor coding style

Re: [PATCH 1/1] Export Gateway from service properties ipv4

2010-05-07 Thread Marcel Holtmann
Hi Martin, src/ipconfig.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH 1/1] Check error before call dbus_message_get_args to acquire arguments.

2010-05-06 Thread Marcel Holtmann
Hi Martin, Function dbus_message_get_args just checks the signature which may happens to be s(string), then it will just return TRUE, and the error message is treated as return value. So dbus_set_error_from_message is used to check the error, before call dbus_message_get_args. patch has

Re: [PATCH 1/1] Set network associating as FALSE at function pan_disconnect()

2010-05-06 Thread Marcel Holtmann
Hi Martin, Otherwise, connman_network_set_connected() takes normal service disconnect as connecting failure. patch has been applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH 1/1] call __connman_notifier_connect() only when state is READY

2010-05-06 Thread Marcel Holtmann
Hi Martin, if we call it at READY or ONLINE state, The function will be called twice and connected times is set as two. And StateChanged signle offline will never be emited. patch has been applied. Thanks. Regards Marcel ___ connman mailing list

Re: [PATCH] Append Ethernet dictionary to cellular service properties

2010-05-06 Thread Marcel Holtmann
Hi Daniel, The docs says the Ethernet dictionary should be there. The address is of course not set but the interface name and MTU is still a valid information. patch has been applied. Thanks. Regards Marcel ___ connman mailing list

Re: [PATCH] Remove set_powered() calls based on IFF_UP

2010-05-06 Thread Marcel Holtmann
Hi Kalle, wpa_supplicant 0.7.2+ (from git) didn't connect automatically to a wifi network. I found out that this because of two calls to connman_device_set_powered(), from wifi_newlink() and get_interface_reply(). The former was called first and causing the latter call not to trigger a scan.

Re: [PATCH 1/2] Fix for two default gateways.

2010-05-06 Thread Marcel Holtmann
Hi Mohamed, This patch fixes the issue of more than one defaut gateway showing up. This caused because VPN gatway was added but an active flag never been set, which lead to two active gateway can be registered. patch has been applied. Thanks. Regards Marcel

Re: [PATCH 2/2] Clean all VPN added host and gateway entries on VPN disconnect.

2010-05-06 Thread Marcel Holtmann
Hi Mohamed, When VPN disconnect we need to clean all gateway and host entries correctly. VPN will add a gatway into active physical interface, this entries need to be delete on VPN disconnect. This patch fixes the issue of more than one defaut gateway showing up. VPN gateway needs extra

Re: service.ipv4 attributes can not be got when service is not in connection state

2010-05-05 Thread Marcel Holtmann
Hi Ying-An, I am adding static ip setting in Carrick so that people can use static ip on netbook. Here I got some problem: I failed to read out either wired or wireless connection with its ipv4 properties, as ip address, network mask or gateway when it is not in connected state. Only

Re: [PATCH] Remove set_powered() calls based on IFF_UP

2010-05-05 Thread Marcel Holtmann
Hi Kalle, wpa_supplicant 0.7.2+ (from git) didn't connect automatically to a wifi network. I found out that this because of two calls to connman_device_set_powered(), from wifi_newlink() and get_interface_reply(). The former was called first and causing the latter call not to trigger a scan.

RE: service.ipv4 attributes can not be got when service is not in connection state

2010-05-05 Thread Marcel Holtmann
Hi Ying-An, first a quick reminder that we are NOT top-posting on this mailing list. I know that this is hard with Outlook, but possible. So please keep that in mind. Thanks for your kindly reply. I tried with IPv4.configuration, and the settings can be read out even in non-connected state.

Re: [PATCH 1/4] resolvfile: Support multiple nameservers.

2010-05-04 Thread Marcel Holtmann
Hi Forest, Nameservers are appended to a local entry list. The MAXNS most recently appended nameservers written to /etc/resolv.conf. sorry for the delay, but I do have a few comments. --- src/resolver.c | 113 +--- 1 files changed,

Re: [PATCH 2/4] Split DHCP-provided nameserver string.

2010-05-04 Thread Marcel Holtmann
Hi Forest, The DHCP-provided nameserver string is split up into separate nameservers. Currently, only one nameserver can be stored in the connman_element.ipv4 structure, so all but the first of the DHCP-provided nameservers are thrown out. please try to keep the commit message at max 72

RE: Default interface not set for ppp0

2010-04-28 Thread Marcel Holtmann
Hi Martin, I was testing connman and ofono with a finnish Saunalahti prepaid sim. Otherwise it is working, there's just no default gateway set. This is what ofono says about the context: [ /huawei0 ] [ /huawei0/primarycontext1 ] Username =

Re: [PATCH 1/1] Check error beofre call dbus_message_get_args to acquire arguments.

2010-04-26 Thread Marcel Holtmann
Hi Martin, I think you see the spelling mistake in the subject after me point you at it ;) And please figure out why this email gets threaded as part of an old thread. It should be a new one actually. Function dbus_message_get_args just checks the signature which may happens to be s(string),

Re: [PATCH 1/1] Check error before call dbus_message_get_args to acquire arguments.

2010-04-26 Thread Marcel Holtmann
Hi Martin, you email still gets attached to a previous thread from you. It should show up as a new one. This is weird, Function dbus_message_get_args just checks the signature which may happens to be s(string), then it will just return TRUE, and the error message is treated as return value.

Re: How to handle pins?

2010-04-23 Thread Marcel Holtmann
Hi Daniel, I'm not sure if I'm going the right road. What is the great master plan to handle this? the PIN needs to be handled by the oFono UI. We can not handle this inside ConnMan. Otherwise the ConnMan UI and oFono UI will fight each other and that makes no sense. Okay, I

Re: How to handle pins?

2010-04-21 Thread Marcel Holtmann
Hi Daniel, I was able to get connman with ofono working with my Option modem. Though one of the problem I had to workaround was the pin entering. When the device is attached to the computer, ofono identifies it as: $ ./list-modems [ /hso0 ] Powered = 1 Interfaces =

Re: [PATCH] Fix typo: store password into service-password field

2010-04-21 Thread Marcel Holtmann
Hi Daniel, --- src/service.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/service.c b/src/service.c index 9e1dc03..0997109 100644 --- a/src/service.c +++ b/src/service.c @@ -2693,7 +2693,7 @@ static int service_load(struct connman_service *service)

Re: [PATCH] ofono API refactoring: Rename netreg Operator property to Name

2010-04-14 Thread Marcel Holtmann
Hi Daniel, for ofono version 0.20 --- plugins/ofono.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 2ad01f2..10cc6d6 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -229,7 +229,7 @@ static void

Re: [PATCH 1/1] Remove the access of status property of DataConnectionManager from oFono

2010-04-14 Thread Marcel Holtmann
Hi Martin, The status property has been removed from oFono post oFono 0.20 --- plugins/ofono.c | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 2ad01f2..2e47ce6 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c

Re: [PATCH v3] ofono API refactoring: Rename netreg Operator property to Name

2010-04-14 Thread Marcel Holtmann
Hi Daniel, for ofono version 0.20 --- v3: fix whitespace damage v2: add backwards compatibility patch has been applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: Option iCON 451

2010-04-13 Thread Marcel Holtmann
Hi Daniel, I recently learned that connman supports hso devices. I got a Option iCON 451 usb modem here and I tried it to get it working with connman. actually ConnMan doesn't support the HSO device directly. They are support by oFono and ConnMan has a plugin to talk to oFono. Regards Marcel

Re: Option iCON 451

2010-04-13 Thread Marcel Holtmann
Hi Daniel, I recently learned that connman supports hso devices. I got a Option iCON 451 usb modem here and I tried it to get it working with connman. The first problem is, that the kernel

Re: ConnMan and oFono integration

2010-04-06 Thread Marcel Holtmann
Hi Emmanuel, I'm a new comer on this list so let me introduce myself: I work in Intel on Meego program and especially on Telephony integration. welcome to the mailing list. We are currently using ofono 0.18 and connman 0.48. I would like to get some info about the integration status of

RE: [PATCH RFC 0/3] Session support

2010-04-01 Thread Marcel Holtmann
Hi Waldo, Nice feature. How is this handled if one application asks for a Wifi bearer and another one for a 3G bearer? Will the application have any guarantee and/or indication how it's IP traffic will be routed? Can the list of defined bearers be added to the API documentation? the

Re: [PATCH RFC 0/3] Session support

2010-04-01 Thread Marcel Holtmann
Hi Gustavo, Nice feature. How is this handled if one application asks for a Wifi bearer and another one for a 3G bearer? Will the application have any guarantee and/or indication how it's IP traffic will be routed? Hard to say due Linux networking design. The real use cases for this

Re: Device Interface selection for connect and disconnect

2010-03-23 Thread Marcel Holtmann
Hi Anil, In connection manager0.47 enable.device python script will enable the interface(eth0) and automatically connects and disable-device python script will disable the interface and disconnects.Hope my understanding is correct list-devices will list available interfaces .With help of

Re: [PATCH 1/2] Set network-device as NULL when the deivce is destructed

2010-03-22 Thread Marcel Holtmann
Hi Martin, From: Martin Xu martin...@intel.com So ofono plugin can decide whether the modem is removed during active PrimaryContext --- plugins/ofono.c |4 +++- src/device.c|2 ++ src/network.c |3 ++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/1] Use udev_device_get_devtype and __connman_inet_get_device_type

2010-03-22 Thread Marcel Holtmann
Hi Martin, We can not just use __connman_inet_get_device_type to acquire connman_device_type, becuase it can't decide the wwan device and it is because and use Wireless WAN. eth device. consequently, when inserting 3G card such as Dell 5530/5540 And here use Ethernet. It is a commit message

Re: [PATCH 1/2] Correct the modem properties key name

2010-03-19 Thread Marcel Holtmann
Hi Martin, --- plugins/ofono.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH 2/2] Handle the case that MobileNetworkCodeLength is not provided by oFono

2010-03-19 Thread Marcel Holtmann
Hi Martin, ConnMan will not provide MNC and MCC at this case, but the 3G service will still be created. --- plugins/ofono.c | 31 --- 1 files changed, 16 insertions(+), 15 deletions(-) patch has been applied. Thanks. Regards Marcel

Re: [PATCH] Fix convert_wifi_security for psk string

2010-03-17 Thread Marcel Holtmann
Hi Samuel, CONNMAN_SERVICE_SECURITY_PSK should map to psk, not wep. --- src/service.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/service.c b/src/service.c index c28afdb..1cabdaa 100644 --- a/src/service.c +++ b/src/service.c @@ -2281,7 +2281,7 @@

Re: [PATCH 1/1] export MCC and MNC

2010-03-08 Thread Marcel Holtmann
Hi Martin, --- plugins/ofono.c | 41 + 1 files changed, 33 insertions(+), 8 deletions(-) patch has been applied. + else if (g_str_equal(key, MobileNetworkCodeLength) == TRUE) + dbus_message_iter_get_basic(value, +

Re: Document configuration file format

2010-03-03 Thread Marcel Holtmann
Hi Samuel, Let's avoid having users digging the code to actually understand that format. patch has been applied. However you need to modify Makefile.am as well for these patches. Otherwise they get not included in the tarballs. Regards Marcel ___

Re: [PATCH 1/1] check ipconfig in __connman_ipconfig_clear_address

2010-03-03 Thread Marcel Holtmann
Hi Samuel, 3G service does not have ipconfig if the Primariy Context is not activated. So we need to check the ipconfig here. Looks good to me, thanks. thanks for the review. Patch has been applied. Regards Marcel ___ connman mailing list

Re: [PATCH] update test/list-networks to new properties hierarchy

2010-02-15 Thread Marcel Holtmann
Hi Gustavo, manager Devices property is gone, now need to walk Technologies and then their devices. patch has bee applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: PEAP configuration file

2010-02-08 Thread Marcel Holtmann
Hi Tang, I'm trying to get my wifi connected to my university network using peap. I have successfully connected by killing connman and setup wpa_supplicant manually, but it's very inconvenient. As 0.48 has started to support peap, I upgraded connman to 0.48, and the wifi type has been

Re: [PATCH] openplug submission

2010-02-08 Thread Marcel Holtmann
Hi James, so this is an open source mailing list and we don't do top posting here. I know that Outlook is not your friend on this, but please accept the rules here and make it work. Thanks for the comments Marcel. I did use linux.intel.com as -smtp-server linux.intel.com. I'm not sure how

Re: [PATCH] Fix start-scanning script

2010-02-05 Thread Marcel Holtmann
Hi Samuel, Devices are no longer part of the manager properties, we have to go through the technology list instead. Applying: Fix start-scanning script /data/devel/connman/.git/rebase-apply/patch:38: trailing whitespace. fatal: 1 line adds whitespace errors. Patch failed at

Re: [PATCH] Toggle wifi device powered field

2010-02-05 Thread Marcel Holtmann
Hi Samuel, When we receive an rtnl message for a wifi new link, we should toggle the powered device field accordingly. patch has been applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net

Re: [PATCH v2] Fix start-scanning script

2010-02-05 Thread Marcel Holtmann
Hi Samuel, Devices are no longer part of the manager properties, we have to go through the technology list instead. patch has been applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net

Re: [PATCH] Rename mac80211 routines and fields to cfg80211

2010-02-02 Thread Marcel Holtmann
Hi Samuel, The mac80211 boolean and inet routines names are a bit misleading since what we really want to check is if the underlying wifi driver is cfg80211 compliant. mac80211 drivers form a subset of that, as some full MAC cards also are fully cfg80211 compliant. patch has been applied.

Re: [PATCH] Fix use of uninitialized variables

2010-01-29 Thread Marcel Holtmann
Hi Gustavo, Errors reported by scan-build from clang. --- gatchat/gatchat.c |2 +- src/provider.c|9 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c index 5dbd283..acba4e1 100644 --- a/gatchat/gatchat.c +++

Re: [PATCH] Remove dead assignments at gatchat

2010-01-29 Thread Marcel Holtmann
Hi Gustavo, Errors reported by scan-build from clang. --- gatchat/gatchat.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c index acba4e1..cfa2aaf 100644 --- a/gatchat/gatchat.c +++ b/gatchat/gatchat.c @@ -312,7

RE: [PATCH 2/2] set APN before connect network in ofono plugin

2010-01-27 Thread Marcel Holtmann
Hi Martin, when calling test-connman apn service apn and then list-contexts in oFono, it should show there, too. You only set it at connect time. Hi Marcel: In order to achieve the target you mentioned above, I think we need to add setup() call back function in network-driver, and

<    2   3   4   5   6   7   8   9   >