On Wed, 5 Jun 2024 17:48:25 GMT, Naoto Sato wrote:
>> This test intends to verify the behavior of JdkConsole for the java.base
>> module, wrt restoring the echo. The test assumes the internal methods that
>> sets/gets the echo status of the platform.
>
> Naoto Sato has updated the pull request
On Wed, 5 Jun 2024 17:31:44 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Fri, 24 Feb 2023 22:15:18 GMT, Leonid Mesnik wrote:
> The solution proposed by Stefan K
>
> The startProcess() might wait forever for the expected line if the process
> exits (failed to start). It makes sense to just fail earlier in such cases.
>
> The fix also move
> 'output = new
On Tue, 4 Jun 2024 12:37:03 GMT, Alexey Semenyuk wrote:
> > I assume WiX5 will just work if installed instead of WiX4?
>
> Correct.
>
> > Do you think it will make sense to introduce Wix5 ToolsetType in case if we
> > need to do something different between 4 and 5?
>
> They claim WiX5 is
These 4 tests were failing due to an incompatibility with jcstress. They were
problemlisted in past (https://bugs.openjdk.org/browse/JDK-8326062).
Now that jcstress has been updated (https://github.com/openjdk/jdk/pull/19332)
with the relevant fix (https://github.com/openjdk/jcstress/pull/147),
On Wed, 5 Jun 2024 14:53:09 GMT, Alexey Semenyuk wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
>> line 44:
>>
>>> 42: resource.installdirnotemptydlg-wix-file=Not empty install directory
>>> dialog WiX project file
>>> 43:
> This test intends to verify the behavior of JdkConsole for the java.base
> module, wrt restoring the echo. The test assumes the internal methods that
> sets/gets the echo status of the platform.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
>
On Tue, 4 Jun 2024 09:04:30 GMT, Magnus Ihse Bursie wrote:
>>> Does that proposal sound good?
>>
>> That table is useful, I think it's right. No change to default behavior. If
>> someone configures with --enable-runtime-image then they get a JDK run-time
>> image that supports jlink (with
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory
On Wed, 5 Jun 2024 13:21:20 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 113 commits:
>>
>> - Mark some tests with requiring packaged modules
>> - Correctly set packaged modules
On Thu, 30 May 2024 13:50:33 GMT, Jan Lahoda wrote:
> Consider these two programs:
>
>
> public class SystemPrint {
> public static void main(String... args) {
> System.err.println("Hello!");
> }
> }
>
> and:
>
> public class IOPrint {
> public static void main(String...
On Wed, 5 Jun 2024 13:46:59 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 113 commits:
>>
>> - Mark some tests with requiring packaged modules
>> - Correctly set packaged modules
On Wed, 5 Jun 2024 12:36:33 GMT, Jan Lahoda wrote:
>> Consider these two programs:
>>
>>
>> public class SystemPrint {
>> public static void main(String... args) {
>> System.err.println("Hello!");
>> }
>> }
>>
>> and:
>>
>> public class IOPrint {
>> public static void
On Tue, 4 Jun 2024 20:43:09 GMT, Justin Lu wrote:
>> Please review this PR which handles incorrect CompactNumberFormat integer
>> only parsing when there is no suffix.
>>
>> See the following snippet,
>>
>>
>> var fmt = NumberFormat.getCompactNumberInstance(Locale.US,
>>
On Wed, 5 Jun 2024 13:54:07 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 113 commits:
>>
>> - Mark some tests with requiring packaged modules
>> - Correctly set packaged modules
On Wed, 5 Jun 2024 13:52:43 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 113 commits:
>>
>> - Mark some tests with requiring packaged modules
>> - Correctly set packaged modules
On Mon, 3 Jun 2024 05:06:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which updates the API specification
> of `java.util.zip.InflaterInputStream.skip()` method to match its current
> implementation?
>
> `InflaterInputStream.skip()`, just like
On Wed, 5 Jun 2024 12:14:07 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which updates the API specification
>> of `java.util.zip.InflaterInputStream.skip()` method to match its current
>> implementation?
>>
>> `InflaterInputStream.skip()`, just like
On Wed, 5 Jun 2024 03:54:46 GMT, Alexander Matveev wrote:
>> Alexey Semenyuk has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - WixSourceConverter#applyTo should do what
>> OverridableResource#saveToFile() does: create parent directory
On Wed, 5 Jun 2024 15:35:18 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 23 commits:
>
> - Update copyright.
> - Updated problem list after bug fix.
> - Merge
On Tue, 4 Jun 2024 01:20:15 GMT, Alexander Matveev wrote:
> Do we need to handle default case for unknown wix type? In same cases you
> have default -> throw new IllegalArgumentException(); and in some you do not
> have.
Good catch. I'll update the code to make `switch(wixVersion) ...`
On Wed, 5 Jun 2024 12:14:07 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which updates the API specification
>> of `java.util.zip.InflaterInputStream.skip()` method to match its current
>> implementation?
>>
>> `InflaterInputStream.skip()`, just like
On Mon, 27 May 2024 09:01:36 GMT, Adam Sotona wrote:
> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
> classfile API for reflection proxy-generation. Actual implementation of
> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
>
> Get JDK 24 underway.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 23 commits:
- Update copyright.
- Updated problem list after bug fix.
- Merge branch 'master' into JDK-8330188
- Merge branch 'master' into
On Tue, 4 Jun 2024 19:58:41 GMT, jengebr wrote:
>> Agreed. You might as well be consistent with this so that no one will need
>> to re-address if some application does zillions of clones of empty lists.
>
> Sorry, I crossed wires with @DougLea 's comment, will add `clone`.
`clone()` performs a
On Wed, 5 Jun 2024 04:20:17 GMT, Alexander Matveev wrote:
>> Alexey Semenyuk has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - WixSourceConverter#applyTo should do what
>> OverridableResource#saveToFile() does: create parent directory
On Sun, 28 Apr 2024 09:54:34 GMT, Viktor Klang wrote:
> Primarily offering this PR for discussion, as Throwables throwing exceptions
> on toString(), getLocalizedMessage(), or getMessage() seems like a rather
> unreasonable thing to do.
>
> Nevertheless, there is some things we can do, as
On Sun, 28 Apr 2024 09:54:34 GMT, Viktor Klang wrote:
> Primarily offering this PR for discussion, as Throwables throwing exceptions
> on toString(), getLocalizedMessage(), or getMessage() seems like a rather
> unreasonable thing to do.
>
> Nevertheless, there is some things we can do, as
On Tue, 4 Jun 2024 16:23:19 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Tue, 4 Jun 2024 16:23:19 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Wed, 5 Jun 2024 13:41:10 GMT, Per Minborg wrote:
>> In order to be eligible for constant folding, the benchmark must declare the
>> `Method hashCodeMethod;` as `static final`.
>>
>> It is hard for me to understand why a `@Stable` annotation should have a
>> detrimental performance impact
On Wed, 5 Jun 2024 13:37:15 GMT, Per Minborg wrote:
>> Interesting, don't know about hotspot internals so I can't diagnose the
>> exact cause of this regression.
>
> In order to be eligible for constant folding, the benchmark must declare the
> `Method hashCodeMethod;` as `static final`.
>
>
On Wed, 29 May 2024 15:20:15 GMT, Chen Liang wrote:
>> This was something that I tried and I observed a performance regression on
>> the ARM platform that I was testing. From my understanding, `@Stable` tells
>> the compiler to trust the contents of this field which is only given when
>> the
On Tue, 4 Jun 2024 16:23:19 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Tue, 4 Jun 2024 16:23:19 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Tue, 4 Jun 2024 16:23:19 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Sun, 28 Apr 2024 09:54:34 GMT, Viktor Klang wrote:
> Primarily offering this PR for discussion, as Throwables throwing exceptions
> on toString(), getLocalizedMessage(), or getMessage() seems like a rather
> unreasonable thing to do.
>
> Nevertheless, there is some things we can do, as
On Tue, 4 Jun 2024 14:39:23 GMT, Severin Gehwolf wrote:
> I've added a couple of `@requires jlink.packagedModules` (new with this
> patch) so that jlink tests don't start to fail with it.
Good, the `@requires jlink.packagedModules` make sense.
-
PR Comment:
On Tue, 4 Jun 2024 16:23:19 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Mon, 15 Apr 2024 18:25:02 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue
On Wed, 5 Jun 2024 12:50:25 GMT, Adam Sotona wrote:
>> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
>> classfile API for reflection proxy-generation. Actual implementation of
>> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
>>
On Fri, 31 May 2024 14:34:16 GMT, Sonia Zaldana Calles
wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Decreasing diff size addressing unnecessary changes
>
> Hi all,
>
> I think there's some consensus
On Tue, 7 May 2024 22:50:18 GMT, Doug Lea wrote:
> This set of changes address causes of poor utilization with small numbers of
> cores due to overly aggressive contention avoidance. A number of further
> adjustments were needed to still avoid most contention effects in deployments
> with
> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
> classfile API for reflection proxy-generation. Actual implementation of
> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
> regressions. `ProxyGenerator.TEMPLATE` class model is statically
On Wed, 5 Jun 2024 12:00:25 GMT, Adam Sotona wrote:
>> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
>> classfile API for reflection proxy-generation. Actual implementation of
>> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
>>
> Consider these two programs:
>
>
> public class SystemPrint {
> public static void main(String... args) {
> System.err.println("Hello!");
> }
> }
>
> and:
>
> public class IOPrint {
> public static void main(String... args) {
> java.io.IO.println("Hello!");
>
On Wed, 5 Jun 2024 11:45:10 GMT, Alan Bateman wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reconcile changes
>
> Viktor (mostly) and I have been testing and reviewing these changes at each
> iteration. I think we
On Wed, 5 Jun 2024 12:00:25 GMT, Adam Sotona wrote:
>> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
>> classfile API for reflection proxy-generation. Actual implementation of
>> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
>>
On Wed, 5 Jun 2024 12:00:25 GMT, Adam Sotona wrote:
>> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
>> classfile API for reflection proxy-generation. Actual implementation of
>> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
>>
On Wed, 5 Jun 2024 12:14:07 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which updates the API specification
>> of `java.util.zip.InflaterInputStream.skip()` method to match its current
>> implementation?
>>
>> `InflaterInputStream.skip()`, just like
> Can I please get a review of this change which updates the API specification
> of `java.util.zip.InflaterInputStream.skip()` method to match its current
> implementation?
>
> `InflaterInputStream.skip()`, just like `DeflaterInputStream.skip()`, takes a
> `long` value `n` representing the
On Wed, 5 Jun 2024 12:00:25 GMT, Adam Sotona wrote:
>> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
>> classfile API for reflection proxy-generation. Actual implementation of
>> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
>>
> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
> classfile API for reflection proxy-generation. Actual implementation of
> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
> regressions. `ProxyGenerator.TEMPLATE` class model is statically
On Fri, 31 May 2024 13:18:33 GMT, Doug Lea wrote:
>> This set of changes address causes of poor utilization with small numbers of
>> cores due to overly aggressive contention avoidance. A number of further
>> adjustments were needed to still avoid most contention effects in
>> deployments
> Can I please get a review of this change which updates the API specification
> of `java.util.zip.InflaterInputStream.skip()` method to match its current
> implementation?
>
> `InflaterInputStream.skip()`, just like `DeflaterInputStream.skip()`, takes a
> `long` value `n` representing the
On Wed, 22 May 2024 14:19:36 GMT, Volodymyr Paprotski wrote:
>> Volodymyr Paprotski has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 17
>>
> Consider these two programs:
>
>
> public class SystemPrint {
> public static void main(String... args) {
> System.err.println("Hello!");
> }
> }
>
> and:
>
> public class IOPrint {
> public static void main(String... args) {
> java.io.IO.println("Hello!");
>
58 matches
Mail list logo
