Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-11 Thread Benchao Li
erting 3154708 is here: > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>> https://github.com/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 > > >>>>>>>>

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-11 Thread Benchao Li
m/apache/calcite/commit/213c13776651f83f95dceb9645a15e940ec6dce1 > >>>>>>>>>>> > >>>>>>>>>>> Let me know if I can do anything else to help and thank y'all for > >>>>>>>>>> handling > >>>>>>>>>>> the release! > >>>>>>>>>>> >

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-11 Thread Francis Chuang
_ From: Benchao Li Sent: Tuesday, October 31, 2023 6:50 AM To: dev@calcite.apache.org Subject: Re: [DISCUSS] Towards Calcite 1.36.0 Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455, I think we can move it out of 1.36.0 for now. What do you

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-10 Thread Benchao Li
t;> > > >>>>>>>>> On Tue, Nov 7, 2023 at 6:34 PM Tanner Clary > > >>>>>>>>> > > >>>>>>>> wrote: > > >>>>>>>>> > > >>>>>>>>>> I can re

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-10 Thread Benchao Li
;>>>> francischu...@apache.org> > >>>>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> I believe the main branch should still be frozen as we're still > >>>>>>>> voting > >>

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-10 Thread Francis Chuang
___ From: Benchao Li Sent: Tuesday, October 31, 2023 6:50 AM To: dev@calcite.apache.org Subject: Re: [DISCUSS] Towards Calcite 1.36.0 Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455, I think we can move it out of 1.36.0 for now. What do you think? Othe

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-10 Thread Benchao Li
> Hi, Benchao > >>>>>>>>>> > >>>>>>>>>> Is the main branch still frozen? > >>>>>>>>>> > >>>>>>>>>> I found a new commit[1], but 1.36.0 has not been released. >

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-10 Thread Francis Chuang
1月1日周三 02:42写道: 5884 is mostly documentation fixes. I expected it would be easy to get it in. But we can leave it for later. Mihai From: Benchao Li Sent: Tuesday, October 31, 2023 6:50 AM To: dev@calcite.apache.org Subject: Re: [DISCUSS] Towards Calci

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-10 Thread Benchao Li
3505 > > >>>>>>>> > > >>>>>>>> Benchao Li 于2023年11月6日周一 12:46写道: > > >>>>>>>>> > > >>>>>>>>> Hi devs, > > >>>>>>>>> > > >>>>>>>&

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-07 Thread Tanner Clary
> >>>>>>>>>>>>>>> I performed an update on the list compiled by Jiajun. > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> #1.Last update (new comments or commits) within 2 days > >>>>>>>> (a

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-07 Thread Francis Chuang
we can leave it for later. Mihai From: Benchao Li Sent: Tuesday, October 31, 2023 6:50 AM To: dev@calcite.apache.org Subject: Re: [DISCUSS] Towards Calcite 1.36.0 Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455, I think we can move it out of 1

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-07 Thread Tanner Clary
>> >> > >> >>>> LakeShen 于2023年11月1日周三 12:13写道: >> > >> >>>>> >> > >> >>>>> Hi Itiel, >> > >> >>>>> >> > >> >>>>> I have revi

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-07 Thread Tanner Clary
三 12:13写道: > > >> >>>>> > > >> >>>>> Hi Itiel, > > >> >>>>> > > >> >>>>> I have reviewd the > https://github.com/apache/calcite/pull/3325,and > > >> >> left one > > >> >>>>> comments > > >> >>

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-07 Thread Benchao Li
t; >>>>>>>>>> Hi, all: > >> >>>>>>>>>> We're already very close to 1.36.0, all unresolved issues > >> >> has been > >> >>>>>> someone > >> >>>>>>>>>&g

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-07 Thread Tanner Clary
chao Li 于2023年11月1日周三 10:17写道: >> >>>>> >> >>>>>> Mihai, >> >>>>>> I've reviewed 5884, it looks good and I think we can have it in >> >> 1.36.0 >> >>>>>> >> >>>>>> Itiel, >> >>>>>> https://github.com/ap

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-07 Thread Benchao Li
gt;>>>> I've reviewed 5884, it looks good and I think we can have it in > > >> 1.36.0 > > >>>>>> > > >>>>>> Itiel, > > >>>>>> https://github.com/apache/calcite/pull/3325 has been reviewed and > > >

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-07 Thread Tanner Clary
>>> Itiel, > >>>>>> https://github.com/apache/calcite/pull/3325 has been reviewed and > >> even > >>>>>> with an approval, I'll try to ping in the PR to try to get it > >> merged > >>>>>> in

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-07 Thread Francis Chuang
it for later. Mihai From: Benchao Li Sent: Tuesday, October 31, 2023 6:50 AM To: dev@calcite.apache.org Subject: Re: [DISCUSS] Towards Calcite 1.36.0 Due to the inactivity of the review for CALCITE-5884 and CALCITE-4455, I think we can move it out of 1.36.0 for now

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-07 Thread Jiajun Xie
th an approval, I'll try to ping in the PR to try to get it > merged > > > > > in 1.36.0 > > > > > > > > > > Mihai Budiu 于2023年11月1日周三 02:42写道: > > > > > > > > > > > > 5884 is mostly documentation fixes. > &g

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-05 Thread Benchao Li
t; > > > > > > Mihai Budiu 于2023年11月1日周三 02:42写道: > > > > > > > > > > 5884 is mostly documentation fixes. > > > > > I expected it would be easy to get it in. > > > > > But we can leave it for later. > > > >

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-05 Thread Benchao Li
/jira/browse/CALCITE-6052 > > > > > >> > > > > > >> #3. Last update exceeded 7 days > > > > > >> https://issues.apache.org/jira/browse/CALCITE-5884 > > > > > >> https://issues.apache.org/jira/browse/CALCITE-6037 > > > > > >> > > &g

Re: [DISCUSS] Towards Calcite 1.36.0

2023-11-02 Thread Benchao Li
____________________ > > > From: Benchao Li > > > Sent: Tuesday, October 31, 2023 6:50 AM > > > To: dev@calcite.apache.org > > > Subject: Re: [DISCUSS] Towards Calcite 1.36.0 > > > > > > Due to the inactivity of the review for CALC

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-31 Thread LakeShen
; > But we can leave it for later. > > > > Mihai > > > > > > From: Benchao Li > > Sent: Tuesday, October 31, 2023 6:50 AM > > To: dev@calcite.apache.org > > Subject: Re: [DISCUSS] Towards Calcite 1.36.0 > > > > Due to the inactivity of th

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-31 Thread Benchao Li
mostly documentation fixes. > I expected it would be easy to get it in. > But we can leave it for later. > > Mihai > > > From: Benchao Li > Sent: Tuesday, October 31, 2023 6:50 AM > To: dev@calcite.apache.org > Subject: Re: [DIS

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-31 Thread Mihai Budiu
5884 is mostly documentation fixes. I expected it would be easy to get it in. But we can leave it for later. Mihai From: Benchao Li Sent: Tuesday, October 31, 2023 6:50 AM To: dev@calcite.apache.org Subject: Re: [DISCUSS] Towards Calcite 1.36.0 Due

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-31 Thread Itiel Sadeh
> >>> > > >>> Mihai Budiu 于2023年10月25日周三 05:02写道: > > >>>> > > >>>> For the blocker issues, I have filed two PRs which should > collectively > > >>> fix them. > > >>>> > > >>>> https://github.com/apache/calcite/pull/3481 fixes > >

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-31 Thread Benchao Li
se/CALCITE-5990, but does not include > >>> tests, because the test fixture needs to be fixed as well for the tests > >> to > >>> pass. There are tests in the next PR: > >>>> https://github.com/apache/calcite/pull/3471 fixes > >>> https://issue

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-30 Thread Julian Hyde
ITE-5990, but does not include >>> tests, because the test fixture needs to be fixed as well for the tests >> to >>> pass. There are tests in the next PR: >>>> https://github.com/apache/calcite/pull/3471 fixes >>> https://issues.apache.org/jira/browse/CALCITE-

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-30 Thread Ran Tao
e fixed as well for the tests > to > > pass. There are tests in the next PR: > > > https://github.com/apache/calcite/pull/3471 fixes > > https://issues.apache.org/jira/browse/CALCITE-5921, but should be > amended > > to reenable the disabled tests if we merge 3481 fir

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-27 Thread Jiajun Xie
> Mihai > > > > > > From: Benchao Li > > Sent: Tuesday, October 24, 2023 5:46 AM > > To: dev@calcite.apache.org > > Subject: Re: [DISCUSS] Towards Calcite 1.36.0 > > > > A quick update on the current status for i

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-24 Thread Benchao Li
ed to > reenable the disabled tests if we merge 3481 first. > > Mihai > > > From: Benchao Li > Sent: Tuesday, October 24, 2023 5:46 AM > To: dev@calcite.apache.org > Subject: Re: [DISCUSS] Towards Calcite 1.36.0 > > A quick update on

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-24 Thread Mihai Budiu
AM To: dev@calcite.apache.org Subject: Re: [DISCUSS] Towards Calcite 1.36.0 A quick update on the current status for issues targeted 1.36.0 We need more reviewers for #2 and #3 since the end of October is approaching. Please correct me if I'm mistaken, especially for issues in #1. #1. Issues

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-24 Thread Benchao Li
A quick update on the current status for issues targeted 1.36.0 We need more reviewers for #2 and #3 since the end of October is approaching. Please correct me if I'm mistaken, especially for issues in #1. #1. Issues already have reviewers, and seems promising to be merged shortly

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-18 Thread Ran Tao
Hi, community. Recently I reported an issue[1] which revealed that calcite's MAP SubQuery doesn't work, considering this is a feature regression or bug, maybe we can fix it in 1.36. The PR is ready. If someone has time, pls help to review it. many thanks. [1]

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-15 Thread Runkang He
Thanks Benchao for opening the discussion! I'd like to include CALCITE-5923/CALCITE-5825/CALCITE-5826 in 1.36, and they're all in good shape. The first one improves test converage for `SqlOperatorTest`, and can avoid later regressions, so it's valuable. The last two Jiras add two useful Spark/Hive

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-15 Thread LakeShen
According to the JIRA information to be fixed or supported in 1.36.0, I compiled the PR information that currently requires the committer review or secondary review, so that these PRs could be merged.If the committer has time,could help review these PRs. The PRs are: 1.

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-14 Thread Mihai Budiu
I have a fix for the regression 5990, but I have also filed an improved fix for 5921 [1] which is needed to implement the fix for 5990. Both are relatively small so we should be able to get them in for 1.36. Thank you for your patience. Mihai [1] https://github.com/apache/calcite/pull/3471

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-11 Thread Benchao Li
I've created the https://issues.apache.org/jira/browse/CALCITE-6047 to track the releasing staff. Julian Hyde 于2023年10月12日周四 04:32写道: > > Thanks for volunteering, Benchao. Could you log a jira case for 1.36? Then > people can cases to it. (As RM, you can remove unlink any cases you think >

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-11 Thread Julian Hyde
Thanks for volunteering, Benchao. Could you log a jira case for 1.36? Then people can cases to it. (As RM, you can remove unlink any cases you think will not be ready in time.) > On Oct 11, 2023, at 3:29 AM, Ran Tao wrote: > > Thanks Benchao for opening this discussion! > > Maybe we can add

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-11 Thread Ran Tao
Thanks Benchao for opening this discussion! Maybe we can add https://issues.apache.org/jira/browse/CALCITE-5918 in 1.36.0 ? Currently it needs additional +1 review from the committer. And I am willing to participate in the review of the remaining PRs of 1.36.0 (in familiar modules or sections)

RE: [DISCUSS] Towards Calcite 1.36.0

2023-10-08 Thread mbudiu
I will take care of https://issues.apache.org/jira/browse/CALCITE-5990 However, it is the first time I notice this issue, I wonder whether I missed some notification. Mihai -Original Message- From: Benchao Li Sent: Sunday, October 8, 2023 12:01 AM To: dev@calcite.apache.org Cc:

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-08 Thread LakeShen
+1,thanks,benchao. I am willing to participate in the review of the remaining PRs of 1.36.0. Best, LakeShen Benchao Li 于2023年10月8日周日 11:02写道: > It's been a bit more than 2 months since our last release [1] and > there are currently 90+ new commits in main branch. > > As usual, according to our