Re: Moving plugin JS files around

2013-02-01 Thread Andrew Grieve
Did anyone act on putting this on the wiki? We'd need to ask Andrew to re-license from MIT - Apache before we did so I think. On Wed, Jan 9, 2013 at 2:10 PM, Shazron shaz...@gmail.com wrote: +1 On Wed, Jan 9, 2013 at 10:57 AM, Filip Maj f...@adobe.com wrote:

Re: Moving plugin JS files around

2013-02-01 Thread Filip Maj
isn't mit compatible with apache license? On 2/1/13 11:41 AM, Andrew Grieve agri...@chromium.org wrote: Did anyone act on putting this on the wiki? We'd need to ask Andrew to re-license from MIT - Apache before we did so I think. On Wed, Jan 9, 2013 at 2:10 PM, Shazron shaz...@gmail.com

Re: Moving plugin JS files around

2013-02-01 Thread Brian LeRoux
Yup, you only need to update the NOTICE and only if we are distributing. On Fri, Feb 1, 2013 at 11:47 AM, Filip Maj f...@adobe.com wrote: isn't mit compatible with apache license? On 2/1/13 11:41 AM, Andrew Grieve agri...@chromium.org wrote: Did anyone act on putting this on the wiki? We'd

Re: Moving plugin JS files around

2013-02-01 Thread Filip Maj
Its just a document.. Ill move it / create a spot for it in the wiki ? On 2/1/13 11:56 AM, Brian LeRoux b...@brian.io wrote: Yup, you only need to update the NOTICE and only if we are distributing. On Fri, Feb 1, 2013 at 11:47 AM, Filip Maj f...@adobe.com wrote: isn't mit compatible with

Re: Moving plugin JS files around

2013-02-01 Thread Brian LeRoux
Seems like a wiki thing. On Fri, Feb 1, 2013 at 12:01 PM, Filip Maj f...@adobe.com wrote: Its just a document.. Ill move it / create a spot for it in the wiki ? On 2/1/13 11:56 AM, Brian LeRoux b...@brian.io wrote: Yup, you only need to update the NOTICE and only if we are distributing. On

Re: Moving plugin JS files around

2013-02-01 Thread Andrew Grieve
Great! thanks! On Fri, Feb 1, 2013 at 3:06 PM, Brian LeRoux b...@brian.io wrote: Seems like a wiki thing. On Fri, Feb 1, 2013 at 12:01 PM, Filip Maj f...@adobe.com wrote: Its just a document.. Ill move it / create a spot for it in the wiki ? On 2/1/13 11:56 AM, Brian LeRoux

Re: Moving plugin JS files around

2013-02-01 Thread Filip Maj
Updated: http://wiki.apache.org/cordova/PluginDesign Anis, can you do us a solid and review the document based on your latest experience authoring plug man? Like make sure the doc is not missing anything and is up to date? On 2/1/13 12:09 PM, Andrew Grieve agri...@chromium.org wrote: Great!

Re: Moving plugin JS files around

2013-01-15 Thread Filip Maj
Responses in-line below. On 1/15/13 1:35 PM, Andrew Grieve agri...@chromium.org wrote: Okay, I'm feeling the need to reboot a bit on this. I'd like to think this through in terms of cordova-cli commands. First thing I'd like to clarify is where things go when we run cordova platform add vs

Re: Moving plugin JS files around

2013-01-14 Thread Andrew Grieve
Jesse, thanks for the explanation. Certainly my experience is just with Android iOS, so it's good to get opinions from the other platforms. I took a look at WebOS, but pkg/cordova.webos.js does seem to pull in all of the shared plugin modules and hooks them up with the common bootstrap. Why do

Re: Moving plugin JS files around

2013-01-14 Thread Andrew Grieve
Created a bug for the file moving part (CB-2214), but we can continue discussing here. On Mon, Jan 14, 2013 at 2:39 PM, Andrew Grieve agri...@chromium.org wrote: Jesse, thanks for the explanation. Certainly my experience is just with Android iOS, so it's good to get opinions from the other

Re: Moving plugin JS files around

2013-01-14 Thread Gord Tanner
Yes, BlackBerry is really 3 platforms in one. We used to have them as 3 seperate platforms but was a headache for writing apps and ensuring that you had the right javascript file in the right place. Since I wrote most of the module stuff I agree I have abused it a little with some of the tricks

Re: Moving plugin JS files around

2013-01-14 Thread Andrew Grieve
On Mon, Jan 14, 2013 at 4:04 PM, Gord Tanner gtan...@gmail.com wrote: Yes, BlackBerry is really 3 platforms in one. We used to have them as 3 seperate platforms but was a headache for writing apps and ensuring that you had the right javascript file in the right place. Just so I understand

Re: Moving plugin JS files around

2013-01-14 Thread Gord Tanner
I was envisioning this working closer to the node_modules pattern. Ideally with a module loading framework you should be able to XHR these modules over at require time. Here is where the debate of commonJS vrs AMD will heat up. CommonJS will require sync XHR because of it's ties to node (which

Re: Moving plugin JS files around

2013-01-14 Thread Andrew Grieve
On Mon, Jan 14, 2013 at 3:41 PM, Jesse purplecabb...@gmail.com wrote: Comments inline below. On Mon, Jan 14, 2013 at 11:43 AM, Andrew Grieve agri...@chromium.org wrote: Created a bug for the file moving part (CB-2214), but we can continue discussing here. On Mon, Jan 14, 2013 at

Re: Moving plugin JS files around

2013-01-14 Thread Jesse
Where do you see it overwriting things? I see a few clobbers / merges ... Sorry, off topic ... Are you sure? I just tested this ... Yeah, I was wrong about cordova.plugin, I thought I saw it somewhere, but indeed, they are destroyed when bootstrapped. One thing I did notice is that our API

Re: Moving plugin JS files around

2013-01-10 Thread Andrew Grieve
On Wed, Jan 9, 2013 at 10:28 AM, Gord Tanner gtan...@gmail.com wrote: Ideally the require paths should stay true to the following rules (not that we follow them exactly now but we are close): 1. should always start with cordova (in case we ever share a require framework) 2. should follow as

Re: Moving plugin JS files around

2013-01-09 Thread Filip Maj
https://github.com/alunny/cordova-plugin-spec We should move this to our wiki asap On 1/9/13 7:28 AM, Gord Tanner gtan...@gmail.com wrote: Ideally the require paths should stay true to the following rules (not that we follow them exactly now but we are close): 1. should always start with

Re: Moving plugin JS files around

2013-01-09 Thread Shazron
+1 On Wed, Jan 9, 2013 at 10:57 AM, Filip Maj f...@adobe.com wrote: https://github.com/alunny/cordova-plugin-spec We should move this to our wiki asap On 1/9/13 7:28 AM, Gord Tanner gtan...@gmail.com wrote: Ideally the require paths should stay true to the following rules (not that we

Re: Moving plugin JS files around

2013-01-09 Thread Brian LeRoux
The building tool already is a requirement of every platform, no? Could you describe your solution Jesse? Saying you don't agree w/ something but failing to back it up is kinda passive aggressive. On Wed, Jan 9, 2013 at 11:23 AM, Jesse purplecabb...@gmail.com wrote: Andrew, The approach you

Re: Moving plugin JS files around

2013-01-09 Thread Jesse
Well, I kinda have to demonstrate it, I am in proof of concept mode now. I will at least elaborate on my disagreement ... The building tool already is a requirement of every platform, no? The build tool is currently only a requirement at 'package/release' time, so it is a requirement of ours,

Re: Moving plugin JS files around

2013-01-09 Thread Andrew Grieve
Coolio. Won't be moving any files until everyone agrees. The requirements (in my eyes) are: - Should be easy for plugins to write x-platform JS - Cordova packager eases this with it's directory structure - Should be easy to install / remove plugins - I don't think people should need to