[GitHub] [drill] github-code-scanning[bot] commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

github-code-scanning[bot] commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r913978697 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/utils/GoogleSheetsUtils.java: ## @@ -0,0 +1,534 @@ +/* + *

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2583: DRILL-8182: File scan nodes not differentiated by format config

vvysotskyi commented on code in PR #2583: URL: https://github.com/apache/drill/pull/2583#discussion_r913963349 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillTableSelection.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] cgivre opened a new pull request, #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre opened a new pull request, #2585: URL: https://github.com/apache/drill/pull/2585 # [DRILL-8235](https://issues.apache.org/jira/browse/DRILL-8235): Add Storage Plugin for Google Sheets ## Description Google Sheets is a very commonly used data source among business users.

[GitHub] [drill] jnturton commented on pull request #2582: [Minor Update] Try and reduce the vm crash on fork

jnturton commented on PR #2582: URL: https://github.com/apache/drill/pull/2582#issuecomment-1175030561 Hi @luocooong, please see if the changes in the following patch might allow keep the SNPEGO tests enabled. They correct copy-and-paste errors I found causing conflicting directory use.

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

kingswanwho commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174814533 tra > Okay, I did indeed not do a proper job of backporting DRILL-8227 / #2551. Please may you add a new commit to your PR with a commit message like > > ``` >

[GitHub] [drill] jnturton commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

jnturton commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174759621 Okay, I did indeed not do proper job of backporting DRILL-8227 / #2551. Please may you add a new commit to your PR with a commit message like ``` DRILL-8227: JConnect and jTDS

[GitHub] [drill] jnturton commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

jnturton commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174696968 > > #2516 > > Hi James, #2516 introduces the new Authmode, and TestJdbcPluginWithMSSQL.java uses this new feature, maybe we could backport this feature to branch 1.20, so the

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

kingswanwho commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174632667 > #2516 Hi James, #2516 introduces the new Authmode, and TestJdbcPluginWithMSSQL.java uses this new feature, maybe we could backport this feature to branch 1.20, so the compile

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

kingswanwho commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174612488 > > I found that [8c1f13c](https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b) also bases on #2516, so I will exclude this commit either. > > That

[GitHub] [drill] kingswanwho closed pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

kingswanwho closed pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 URL: https://github.com/apache/drill/pull/2584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

kingswanwho commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174602941 > > I found that [8c1f13c](https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b) also bases on #2516, so I will exclude this commit either. > > That

[GitHub] [drill] jnturton commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

jnturton commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174600134 > I found that [8c1f13c](https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b) also bases on #2516, so I will exclude this commit either. That commit has

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

kingswanwho commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174597327 I found that https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b also bases on https://github.com/apache/drill/pull/2516, so I will exclude this commit

[GitHub] [drill] kingswanwho opened a new pull request, #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

kingswanwho opened a new pull request, #2584: URL: https://github.com/apache/drill/pull/2584 # [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 ## Description Merged several backport-to-stable commits for new bugfix release 1.20.2, which includes: *

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2583: DRILL-8182: File scan nodes not differentiated by format config

vvysotskyi commented on code in PR #2583: URL: https://github.com/apache/drill/pull/2583#discussion_r913085410 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillTable.java: ## @@ -168,9 +170,19 @@ public Statistic getStatistic() { @Override

[GitHub] [drill] jnturton commented on pull request #2583: DRILL-8182: File scan nodes not differentiated by format config

jnturton commented on PR #2583: URL: https://github.com/apache/drill/pull/2583#issuecomment-1173596969 Hi @vvysotskyi, the CI run for this PR finally went through. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [drill] jnturton opened a new pull request, #2583: DRILL-8182: File scan nodes not differentiated by format config

jnturton opened a new pull request, #2583: URL: https://github.com/apache/drill/pull/2583 # [DRILL-8182](https://issues.apache.org/jira/browse/DRILL-8182): File scan nodes not differentiated by format config ## Description Two file scans that differ only by format config

[GitHub] [drill] cgivre merged pull request #2580: DRILL-8253: Support Limit Results in Kafka Scan

cgivre merged PR #2580: URL: https://github.com/apache/drill/pull/2580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] luocooong opened a new pull request, #2582: [Minor Update] Try and reduce the vm crash on fork

luocooong opened a new pull request, #2582: URL: https://github.com/apache/drill/pull/2582 # [Minor Update] Try and reduce the vm crash on fork ## Description To-do ## Documentation To-do ## Testing Pending CI. -- This is an automated message from the

[GitHub] [drill] luocooong commented on a diff in pull request #2580: DRILL-8253: Support Limit Results in Kafka Scan

luocooong commented on code in PR #2580: URL: https://github.com/apache/drill/pull/2580#discussion_r908637682 ## contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java: ## @@ -271,8 +292,11 @@ public void applyAssignments(List

[GitHub] [drill] cgivre commented on a diff in pull request #2580: DRILL-8253: Support the limit results in kafka scan

cgivre commented on code in PR #2580: URL: https://github.com/apache/drill/pull/2580#discussion_r908624673 ## contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java: ## @@ -271,8 +292,11 @@ public void applyAssignments(List incomingEndpoints)

[GitHub] [drill] luocooong commented on a diff in pull request #2580: DRILL-8253: Support the limit results in kafka scan

luocooong commented on code in PR #2580: URL: https://github.com/apache/drill/pull/2580#discussion_r908624939 ## contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java: ## @@ -262,6 +269,17 @@ public void applyAssignments(List

[GitHub] [drill] kingswanwho opened a new pull request, #2581: DRILL-8254: upgrade mysql-connectors-java to 8.0.28 due to CVE-2022-21363

kingswanwho opened a new pull request, #2581: URL: https://github.com/apache/drill/pull/2581 # [DRILL-8254](https://issues.apache.org/jira/browse/DRILL-8254): upgrade mysql-connectors-java to 8.0.28 due to CVE-2022-21363 ## Description Upgrade mysql-connectors-java to 8.0.28 due

[GitHub] [drill] cgivre commented on a diff in pull request #2580: DRILL-8253: Support the limit results in kafka scan

cgivre commented on code in PR #2580: URL: https://github.com/apache/drill/pull/2580#discussion_r908569894 ## contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java: ## @@ -262,6 +269,17 @@ public void applyAssignments(List incomingEndpoints)

[GitHub] [drill] luocooong commented on a diff in pull request #2580: DRILL-8253: Support the limit results in kafka scan

luocooong commented on code in PR #2580: URL: https://github.com/apache/drill/pull/2580#discussion_r908439009 ## contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java: ## @@ -359,7 +382,7 @@ public KafkaStoragePlugin getStoragePlugin() {

[GitHub] [drill] luocooong commented on a diff in pull request #2580: DRILL-8253: Support the limit results in kafka scan

luocooong commented on code in PR #2580: URL: https://github.com/apache/drill/pull/2580#discussion_r908438483 ## contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java: ## @@ -77,6 +77,7 @@ public class KafkaGroupScan extends AbstractGroupScan

[GitHub] [drill] luocooong commented on a diff in pull request #2580: DRILL-8253: Support the limit results in kafka scan

luocooong commented on code in PR #2580: URL: https://github.com/apache/drill/pull/2580#discussion_r908438074 ## contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java: ## @@ -262,6 +269,17 @@ public void applyAssignments(List

[GitHub] [drill] cgivre commented on a diff in pull request #2580: DRILL-8253: Support the limit results in kafka scan

cgivre commented on code in PR #2580: URL: https://github.com/apache/drill/pull/2580#discussion_r908416571 ## contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java: ## @@ -262,6 +269,17 @@ public void applyAssignments(List incomingEndpoints)

[GitHub] [drill] luocooong opened a new pull request, #2580: DRILL-8253: Support the limit results in kafka scan

luocooong opened a new pull request, #2580: URL: https://github.com/apache/drill/pull/2580 # [DRILL-8253](https://issues.apache.org/jira/browse/DRILL-8253): Support the limit results in kafka scan ## Description In the current implementation of the kafka storage, although we use

[GitHub] [drill] kingswanwho opened a new pull request, #2579: [Minor Update] Add port number in log file for maintenance convenience

kingswanwho opened a new pull request, #2579: URL: https://github.com/apache/drill/pull/2579 # [Minor Update] Add port number in log for maintenance convenience Add Drillbit http port in log file, for find the port number easily. -- This is an automated message from the Apache

[GitHub] [drill-site] pjfanning merged pull request #31: Add privacy policy link

pjfanning merged PR #31: URL: https://github.com/apache/drill-site/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill-site] jnturton commented on pull request #31: Add privacy policy link

jnturton commented on PR #31: URL: https://github.com/apache/drill-site/pull/31#issuecomment-1165269463 Let's do it! On 2022/06/24 01:38, PJ Fanning wrote: > > @jnturton any objection to me merging this? > > — > Reply to this email

[GitHub] [drill-site] pjfanning commented on pull request #31: Add privacy policy link

pjfanning commented on PR #31: URL: https://github.com/apache/drill-site/pull/31#issuecomment-1165013972 @jnturton any objection to me merging this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [drill] cgivre merged pull request #2577: DRILL-8251: Upgrade Hadoop 2 Due to CVE

cgivre merged PR #2577: URL: https://github.com/apache/drill/pull/2577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] pjfanning commented on pull request #2577: DRILL-8251: Upgrade hadoop 2 due to CVE

pjfanning commented on PR #2577: URL: https://github.com/apache/drill/pull/2577#issuecomment-1160127175 @cgivre thanks - marked as ready to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [drill] cgivre commented on pull request #2577: DRILL-8251: Upgrade hadoop 2 due to CVE

cgivre commented on PR #2577: URL: https://github.com/apache/drill/pull/2577#issuecomment-1159889030 @pjfanning It looks like you have two approvals. If you want to mark this as ready for review, we can merge. Thanks for this! -- This is an automated message from the Apache Git

[GitHub] [drill] jnturton commented on pull request #2577: DRILL-8251: Upgrade hadoop 2 due to CVE

jnturton commented on PR #2577: URL: https://github.com/apache/drill/pull/2577#issuecomment-1159757273 > LGTM +1 > > @jnturton Is there anything special we need to do for this before we merge? When we update our Hadoop 3 libs we must also update the winutils binaries we ship

[GitHub] [drill] pjfanning closed pull request #2578: issues-2260 shade newer version of guava due to cve

pjfanning closed pull request #2578: issues-2260 shade newer version of guava due to cve URL: https://github.com/apache/drill/pull/2578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [drill] pjfanning commented on pull request #2578: issues-2260 shade newer version of guava due to cve

pjfanning commented on PR #2578: URL: https://github.com/apache/drill/pull/2578#issuecomment-1159724953 the shade jar seems to be built independently - so this change needs to wait for that -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [drill] pjfanning opened a new pull request, #2578: issues-2260 shade newer version of guava due to cve

pjfanning opened a new pull request, #2578: URL: https://github.com/apache/drill/pull/2578 # [DRILL-](https://issues.apache.org/jira/browse/DRILL-): PR Title (Please replace `PR Title` with actual PR Title) ## Description (Please describe the change. If more than

[GitHub] [drill] cgivre merged pull request #2574: DRILL-8240: Remove Strings.java and Add Dependency on log4j-api Instead

cgivre merged PR #2574: URL: https://github.com/apache/drill/pull/2574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] pjfanning commented on pull request #2574: DRILL-8240: remove Strings.java and add dependency on log4j-api instead

pjfanning commented on PR #2574: URL: https://github.com/apache/drill/pull/2574#issuecomment-1159692572 @cgivre rebase done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [drill] pjfanning opened a new pull request, #2577: Upgrade hadoop 2 due to CVE

pjfanning opened a new pull request, #2577: URL: https://github.com/apache/drill/pull/2577 # [DRILL-](https://issues.apache.org/jira/browse/DRILL-): PR Title (Please replace `PR Title` with actual PR Title) ## Description (Please describe the change. If more than

[GitHub] [drill] cgivre commented on pull request #2574: DRILL-8240: remove Strings.java and add dependency on log4j-api instead

cgivre commented on PR #2574: URL: https://github.com/apache/drill/pull/2574#issuecomment-1159598393 @pjfanning Would you mind please rebasing on current master, then we'll merge? Thank you for fixing that unit test. -- This is an automated message from the Apache Git Service. To

[GitHub] [drill] cgivre merged pull request #2575: [MINOR UPDATE] Fix Port Clash Issue in HTTP Plugin Tests

cgivre merged PR #2575: URL: https://github.com/apache/drill/pull/2575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] pjfanning commented on issue #2260: CVE-2020-8908 in Guava v.28.2-jre, should upgrade to v.30.1.1

pjfanning commented on issue #2260: URL: https://github.com/apache/drill/issues/2260#issuecomment-1159509366 https://github.com/google/guava/issues/4011 affects a deprecated method and it only affects Drill if it Drill uses the deprecated method in the shaded

[GitHub] [drill] ssainz commented on issue #2260: CVE-2020-8908 in Guava v.28.2-jre, should upgrade to v.30.1.1

ssainz commented on issue #2260: URL: https://github.com/apache/drill/issues/2260#issuecomment-1159488084 Hi - the shared guava seems is still 28.2, then not fixed yet ~ https://github.com/apache/drill/blob/master/pom.xml#L52 ``` 28.2-jre ``` -- This is an

[GitHub] [drill] luocooong opened a new issue, #2576: An extra cancel button exists on the UI

luocooong opened a new issue, #2576: URL: https://github.com/apache/drill/issues/2576 **Describe the bug** When I finished a query and then review the ***profile***, I found the extra cancel button in the ***Query and Planning*** panel. **To Reproduce** Steps to reproduce the

[GitHub] [drill] luocooong commented on pull request #2569: DRILL-8199: Convert Excel EVF1 to EVF2

luocooong commented on PR #2569: URL: https://github.com/apache/drill/pull/2569#issuecomment-1159439511 @jnturton Sorry for the delay. It looks like the bug left over from the upstream code processing the unprojection, and I'll check it. -- This is an automated message from the Apache

[GitHub] [drill-site] pjfanning commented on pull request #31: Add privacy policy link

pjfanning commented on PR #31: URL: https://github.com/apache/drill-site/pull/31#issuecomment-1159431215 @jnturton @luocooong would either of you be able to have a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [drill-site] pjfanning opened a new pull request, #31: Add privacy policy link

pjfanning opened a new pull request, #31: URL: https://github.com/apache/drill-site/pull/31 The ASF recently asked that all sites have a link to the privacy policy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [drill] jnturton commented on issue #2439: Update the copyright year [for newcomers]

jnturton commented on issue #2439: URL: https://github.com/apache/drill/issues/2439#issuecomment-1159414601 If everything's working properly then you just need to wait ~3 minutes and then force your browser to fetch an uncached copy from http://drill.apache.org. On 2022/06/18

[GitHub] [drill] luocooong commented on issue #2439: Update the copyright year [for newcomers]

luocooong commented on issue #2439: URL: https://github.com/apache/drill/issues/2439#issuecomment-1159413914 @pjfanning Thank you for receiving this task. No more operation is actually required. Automatically published after the pull request has merged. -- This is an automated message

[GitHub] [drill] pjfanning commented on issue #2439: Update the copyright year [for newcomers]

pjfanning commented on issue #2439: URL: https://github.com/apache/drill/issues/2439#issuecomment-1159410356 @luocooong I updated the drill-site/_includes/footer.html - what is needed to get the site to republish with the change? -- This is an automated message from the Apache Git

[GitHub] [drill] cgivre merged pull request #2569: DRILL-8199: Convert Excel EVF1 to EVF2

cgivre merged PR #2569: URL: https://github.com/apache/drill/pull/2569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on issue #2260: CVE-2020-8908 in Guava v.28.2-jre, should upgrade to v.30.1.1

cgivre commented on issue #2260: URL: https://github.com/apache/drill/issues/2260#issuecomment-1159192882 > Can this be closed? I think this is still valid, but not sure. @vdiravka do you know the current status? -- This is an automated message from the Apache Git Service. To

[GitHub] [drill] pjfanning commented on issue #2260: CVE-2020-8908 in Guava v.28.2-jre, should upgrade to v.30.1.1

pjfanning commented on issue #2260: URL: https://github.com/apache/drill/issues/2260#issuecomment-1159177002 Can this be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [drill] pjfanning commented on issue #2439: Update the copyright year [for newcomers]

pjfanning commented on issue #2439: URL: https://github.com/apache/drill/issues/2439#issuecomment-1159175352 The codebase updates are done - site ones may still be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [drill] jnturton commented on pull request #2569: DRILL-8199: Convert Excel EVF1 to EVF2

jnturton commented on PR #2569: URL: https://github.com/apache/drill/pull/2569#issuecomment-1158822412 It looks like the unit test scheduling we've got at the moment sometimes produces errors in TestUserTranslationInHttpPlugin (not related to this PR) -- This is an automated message from

[GitHub] [drill] pjfanning opened a new pull request, #2574: DRILL-8240: remove Strings.java and add dependency on log4j-api instead

pjfanning opened a new pull request, #2574: URL: https://github.com/apache/drill/pull/2574 # [DRILL-8240](https://issues.apache.org/jira/browse/DRILL-8240): remove Strings.java and add dependency on log4j-api instead ## Description See DRILL-8240 for full description. Apache

[GitHub] [drill] hsuanyi closed pull request #489: DRILL-4642: Remove customized RexBuilder.ensureType()

hsuanyi closed pull request #489: DRILL-4642: Remove customized RexBuilder.ensureType() URL: https://github.com/apache/drill/pull/489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [drill] hsuanyi closed pull request #288: DRILL-4147: Change UnionPrel's DrillDistributionTrait to be ANY to al…

hsuanyi closed pull request #288: DRILL-4147: Change UnionPrel's DrillDistributionTrait to be ANY to al… URL: https://github.com/apache/drill/pull/288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [drill] hsuanyi closed pull request #248: DRILL-3751: Reduce zookeeper's retry time to 10

hsuanyi closed pull request #248: DRILL-3751: Reduce zookeeper's retry time to 10 URL: https://github.com/apache/drill/pull/248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [drill] hsuanyi closed pull request #237: DRILL-2139: Support distinct over star column

hsuanyi closed pull request #237: DRILL-2139: Support distinct over star column URL: https://github.com/apache/drill/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [drill] hsuanyi closed pull request #167: DRILL-1343: Drill should timeout after short time if a storage plugin…

hsuanyi closed pull request #167: DRILL-1343: Drill should timeout after short time if a storage plugin… URL: https://github.com/apache/drill/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [drill] hsuanyi closed pull request #271: DRILL-2915: After cartesian join is selected, Drill will apply the ne…

hsuanyi closed pull request #271: DRILL-2915: After cartesian join is selected, Drill will apply the ne… URL: https://github.com/apache/drill/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [drill] vdiravka merged pull request #2573: DRILL-8248: Fix http_request for several rows

vdiravka merged PR #2573: URL: https://github.com/apache/drill/pull/2573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] vdiravka commented on a diff in pull request #2573: DRILL-8248: Fix http_request for several rows

vdiravka commented on code in PR #2573: URL: https://github.com/apache/drill/pull/2573#discussion_r897074751 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/loader/SingleElementIterator.java: ## @@ -0,0 +1,28 @@ +package

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2573: DRILL-8248: Fix http_request for several rows

vvysotskyi commented on code in PR #2573: URL: https://github.com/apache/drill/pull/2573#discussion_r897117091 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/loader/SingleElementIterator.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] cgivre commented on a diff in pull request #2573: DRILL-8248: Fix http_request for several rows

cgivre commented on code in PR #2573: URL: https://github.com/apache/drill/pull/2573#discussion_r897061430 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/loader/SingleElementIterator.java: ## @@ -0,0 +1,28 @@ +package

[GitHub] [drill] vdiravka opened a new pull request, #2573: DRILL-8248: Fix http_request for several rows

vdiravka opened a new pull request, #2573: URL: https://github.com/apache/drill/pull/2573 # [DRILL-8248](https://issues.apache.org/jira/browse/DRILL-8248): Fix http_request for several rows ## Description Fixes the limiting of the `http_request` to 1 row. The main issue is in

[GitHub] [drill] vvysotskyi merged pull request #2572: DRILL-8245: Project pushdown depends on rules order and might not happen

vvysotskyi merged PR #2572: URL: https://github.com/apache/drill/pull/2572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] vvysotskyi opened a new pull request, #2572: DRILL-8245: Project pushdown depends on rules order and might not happen

vvysotskyi opened a new pull request, #2572: URL: https://github.com/apache/drill/pull/2572 # [DRILL-8245](https://issues.apache.org/jira/browse/DRILL-8245): Project pushdown depends on rules order and might not happen ## Description Fixed `DrillScanRel` cost to prefer scan with

[GitHub] [drill] vdiravka commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

vdiravka commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r894210913 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -153,10 +149,15 @@ public void setup() {

[GitHub] [drill] vdiravka commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

vdiravka commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r893211946 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -153,10 +149,15 @@ public void setup() {

[GitHub] [drill] Leon-WTF merged pull request #2464: DRILL-8132: Improvement of RPC

Leon-WTF merged PR #2464: URL: https://github.com/apache/drill/pull/2464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] Leon-WTF commented on pull request #2464: DRILL-8132: Improvement of RPC

Leon-WTF commented on PR #2464: URL: https://github.com/apache/drill/pull/2464#issuecomment-1151109198 > LGTM. +1 @Leon-WTF Could you please do a rebase on the master branch? done -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [drill] cgivre commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

cgivre commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r893386350 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -153,10 +149,15 @@ public void setup() {

[GitHub] [drill] vdiravka commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

vdiravka commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r893211946 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -153,10 +149,15 @@ public void setup() {

[GitHub] [drill] cgivre merged pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

cgivre merged PR #2571: URL: https://github.com/apache/drill/pull/2571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

cgivre commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r892763520 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -153,10 +149,15 @@ public void setup() {

[GitHub] [drill] cgivre commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

cgivre commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r892763105 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -153,10 +149,15 @@ public void setup() {

[GitHub] [drill] cgivre commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

cgivre commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r892762445 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpUdfUtils.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [drill] vdiravka commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

vdiravka commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r892701369 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpUdfUtils.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] jnturton commented on a diff in pull request #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

jnturton commented on code in PR #2571: URL: https://github.com/apache/drill/pull/2571#discussion_r892680201 ## contrib/storage-http/src/test/java/org/apache/drill/exec/store/http/TestHttpUDFFunctions.java: ## @@ -101,6 +123,30 @@ public static void setup() throws Exception {

[GitHub] [drill] cgivre opened a new pull request, #2571: DRILL-8244: HTTP_Request Not Passing Down Config Variables

cgivre opened a new pull request, #2571: URL: https://github.com/apache/drill/pull/2571 # [DRILL-8244](https://issues.apache.org/jira/browse/DRILL-8244): HTTP_Request Not Passing Down Config Variables ## Description The `http_request` UDF was not passing down the provided schema

[GitHub] [drill] vdiravka commented on a diff in pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

vdiravka commented on code in PR #2568: URL: https://github.com/apache/drill/pull/2568#discussion_r891397926 ## exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java: ## @@ -46,7 +51,9 @@ public class ProjectRecordBatch extends

[GitHub] [drill] cgivre commented on a diff in pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

cgivre commented on code in PR #2568: URL: https://github.com/apache/drill/pull/2568#discussion_r891397014 ## exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java: ## @@ -46,7 +51,9 @@ public class ProjectRecordBatch extends

[GitHub] [drill] jnturton commented on a diff in pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

jnturton commented on code in PR #2568: URL: https://github.com/apache/drill/pull/2568#discussion_r891124891 ## exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java: ## @@ -46,7 +51,9 @@ public class ProjectRecordBatch extends

[GitHub] [drill] cgivre merged pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

cgivre merged PR #2568: URL: https://github.com/apache/drill/pull/2568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on a diff in pull request #2567: [WIP] DRILL-8239: Convert JSON UDF to EVF

cgivre commented on code in PR #2567: URL: https://github.com/apache/drill/pull/2567#discussion_r891318837 ## exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java: ## @@ -32,37 +30,45 @@ import

[GitHub] [drill] cgivre commented on a diff in pull request #2567: [WIP] DRILL-8239: Convert JSON UDF to EVF

cgivre commented on code in PR #2567: URL: https://github.com/apache/drill/pull/2567#discussion_r891318837 ## exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java: ## @@ -32,37 +30,45 @@ import

[GitHub] [drill] vdiravka commented on a diff in pull request #2567: [WIP] DRILL-8239: Convert JSON UDF to EVF

vdiravka commented on code in PR #2567: URL: https://github.com/apache/drill/pull/2567#discussion_r891297158 ## exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java: ## @@ -32,37 +30,45 @@ import

[GitHub] [drill] vdiravka commented on pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

vdiravka commented on PR #2568: URL: https://github.com/apache/drill/pull/2568#issuecomment-1148729328 Added minor fix for `TestHttpPlugin.testSlowResponse` test. Looks like sometimes the `mockwebserver` can return `DATA_READ ERROR: Read timed out` instead of `DATA_READ ERROR: timeout`:

[GitHub] [drill] cgivre merged pull request #2570: DRILL-8243: Move JSON Config Options Out of HTTP Plugin

cgivre merged PR #2570: URL: https://github.com/apache/drill/pull/2570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] vdiravka commented on a diff in pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

vdiravka commented on code in PR #2568: URL: https://github.com/apache/drill/pull/2568#discussion_r891201812 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -75,9 +75,6 @@ public void eval() { // as an

[GitHub] [drill] vdiravka commented on a diff in pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

vdiravka commented on code in PR #2568: URL: https://github.com/apache/drill/pull/2568#discussion_r891201812 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -75,9 +75,6 @@ public void eval() { // as an

[GitHub] [drill] cgivre commented on a diff in pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

cgivre commented on code in PR #2568: URL: https://github.com/apache/drill/pull/2568#discussion_r891145801 ## contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java: ## @@ -75,9 +75,6 @@ public void eval() { // as an

[GitHub] [drill] jnturton commented on pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

jnturton commented on PR #2568: URL: https://github.com/apache/drill/pull/2568#issuecomment-1148560258 > I've checked the rebase onto latest master fixed `TestDrillSpnegoAuthenticator` locally. So it can be ignored for the review of this PR Yes `TestDrillSpnegoAuthenticator` does work

[GitHub] [drill] vdiravka commented on pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

vdiravka commented on PR #2568: URL: https://github.com/apache/drill/pull/2568#issuecomment-1148554376 > The JDK 8 test failure is the result of me not appreciating the flakiness of TestDrillSpnegoAuthenticator. I'll disable it again soon. I've checked the rebase onto latest master

<    5   6   7   8   9   10   11   12   13   14   >