a loop. This should
ideally be done once for a record batch otherwise the performance will be
poor.
abdelhakim deneche wrote:
when aggregated all peer rows we may need to process multiple batches,
setupEvaluatePeer() will be called once per batch in order for evaluatePeer()
to read
/window/lval.pby.oby.sql PRE-CREATION
exec/java-exec/src/test/resources/window/ntile.sql PRE-CREATION
Diff: https://reviews.apache.org/r/37482/diff/
Testing (updated)
---
unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
---
Thanks,
abdelhakim deneche
. To reply, visit:
https://reviews.apache.org/r/37482/#review95521
---
On Aug. 14, 2015, 6:40 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply
PRE-CREATION
exec/java-exec/src/test/resources/window/lval.pby.oby.sql PRE-CREATION
exec/java-exec/src/test/resources/window/ntile.sql PRE-CREATION
Diff: https://reviews.apache.org/r/37482/diff/
Testing
---
Thanks,
abdelhakim deneche
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37482/#review95533
---
On Aug. 17, 2015, 3:54 p.m., abdelhakim deneche wrote
/window/lval.alltypes.sql PRE-CREATION
exec/java-exec/src/test/resources/window/lval.pby.oby.sql PRE-CREATION
exec/java-exec/src/test/resources/window/ntile.sql PRE-CREATION
Diff: https://reviews.apache.org/r/37482/diff/
Testing
---
Thanks,
abdelhakim deneche
-CREATION
exec/java-exec/src/test/resources/window/lval.pby.oby.sql PRE-CREATION
exec/java-exec/src/test/resources/window/ntile.sql PRE-CREATION
Diff: https://reviews.apache.org/r/37482/diff/
Testing
---
Thanks,
abdelhakim deneche
3ca11f1
Diff: https://reviews.apache.org/r/34374/diff/
Testing
---
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36233/#review90961
---
LGTM +1 (non-binding)
- abdelhakim deneche
On July 7, 2015, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36222/#review90715
---
+1, there is one small comment about unit test name
- abdelhakim
/QueryManager.java
(line 534)
https://reviews.apache.org/r/36208/#comment143638
you should probably include your fix for DRILL-3448 as part of this patch,
it's 3 lines change
- abdelhakim deneche
On July 6, 2015, 5:10 p.m., Sudheesh Katkam wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36219/#review90577
---
+1 (non binding)
- abdelhakim deneche
On July 6, 2015, 9:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36208/#review90541
---
+1 (non-binding)
- abdelhakim deneche
On July 6, 2015, 6:47 p.m
://reviews.apache.org/r/36168/#review90514
---
On July 3, 2015, 4:13 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36168
/org/apache/drill/exec/planner/physical/WindowPrel.java
(line 131)
https://reviews.apache.org/r/36219/#comment143667
should we remove this block ?
- abdelhakim deneche
On July 6, 2015, 8:33 p.m., Sean Hsuan-Yi Chu wrote
/java/org/apache/drill/exec/memory/TestAllocators.java
74ce225
Diff: https://reviews.apache.org/r/36103/diff/
Testing (updated)
---
testing...
Thanks,
abdelhakim deneche
---
unit tests are passing, ongoing cluster testing...
Thanks,
abdelhakim deneche
., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36103/
---
(Updated July 3, 2015, 2:37 p.m.)
Review request
exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java
74ce225
Diff: https://reviews.apache.org/r/36103/diff/
Testing
---
testing...
Thanks,
abdelhakim deneche
at 10mb and just asked for a 50mb allocation.
abdelhakim deneche wrote:
I'm still not sure how to find which limit we did hit, at least with the
current allocator
abdelhakim deneche wrote:
@hanifi, when I renamed allocateNew - allocateNewSafe I noticed 2 places
where the code
at 10mb and just asked for a 50mb allocation.
abdelhakim deneche wrote:
I'm still not sure how to find which limit we did hit, at least with the
current allocator
@hanifi, when I renamed allocateNew - allocateNewSafe I noticed 2 places where
the code doesn't check if the allocation
://reviews.apache.org/r/36168/diff/
Testing (updated)
---
unit tests are passing along with customer and tpch100
Thanks,
abdelhakim deneche
-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java
74ce225
Diff: https://reviews.apache.org/r/36103/diff/
Testing (updated)
---
all unit tests are passing along with customer and tpch100
Thanks,
abdelhakim deneche
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34603/#review90193
---
On June 30, 2015, 10:37 p.m., abdelhakim deneche wrote
---
On June 25, 2015, 7:38 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35887
://reviews.apache.org/r/34603/#review90058
---
On June 30, 2015, 10:37 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
generated e-mail. To reply, visit:
https://reviews.apache.org/r/34603/#review90175
---
On June 30, 2015, 10:37 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail
://reviews.apache.org/r/36103/#review90137
---
On July 1, 2015, 9:21 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36103
Thanks,
abdelhakim deneche
/r/36103/#review90134
---
On July 1, 2015, 9:21 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36103
---
On July 1, 2015, 9:21 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36103
/QueryManager.java
(line 286)
https://reviews.apache.org/r/34603/#comment142841
when we fail to cancel a fragment we update it's status to FAILED. I guess
we could introduce a new fragment state but thought that would be just too much
for this specific use case
- abdelhakim deneche
On June
/exec/proto/beans/QueryResult.java
474e330
protocol/src/main/protobuf/UserBitShared.proto 0451fd2
Diff: https://reviews.apache.org/r/34603/diff/
Testing (updated)
---
unit tests are passing
Thanks,
abdelhakim deneche
---
On June 30, 2015, 6:37 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34603/
---
(Updated June 30
to test for ?
- abdelhakim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34603/#review89946
---
On June 30, 2015, 6:37 p.m., abdelhakim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34603/#review89946
---
On June 30, 2015, 6:37 p.m., abdelhakim deneche wrote
a fair
assumption for the fragment?
abdelhakim deneche wrote:
I didn't realize fragmentDone() also updates the fragment status. I will
update the patch to fix that.
I updated CancelMessageHandler.cancelFragment() to return OK if the fragment we
are trying to cancel already finished
/apache/drill/exec/store/text/TestNewTextReader.java
76674f9
Diff: https://reviews.apache.org/r/36070/diff/
Testing
---
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
a fair
assumption for the fragment?
abdelhakim deneche wrote:
I didn't realize fragmentDone() also updates the fragment status. I will
update the patch to fix that.
abdelhakim deneche wrote:
I updated CancelMessageHandler.cancelFragment() to return OK if the
fragment we
with functional and tpch100
Thanks,
abdelhakim deneche
---
unit tests are passing
Thanks,
abdelhakim deneche
: https://reviews.apache.org/r/35887/diff/
Testing
---
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
76674f9
Diff: https://reviews.apache.org/r/35609/diff/
Testing
---
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
/35881/diff/
Testing
---
unit tests are passing
Thanks,
abdelhakim deneche
,
abdelhakim deneche
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35413/#review88299
---
+1 (non binding)
- abdelhakim deneche
On June 17, 2015, 5:06 p.m
.* (DRILL-3241)
- abdelhakim deneche
On June 17, 2015, 5:06 p.m., Daniel Barclay wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35413
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35415/#review88303
---
+1 (non-binding)
- abdelhakim deneche
On June 17, 2015, 5:06 p.m
to the assertions, otherwise we'll get an empty
AssertionError message in the logs
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java (line 270)
https://reviews.apache.org/r/35417/#comment140750
same here
- abdelhakim deneche
On June 17, 2015, 5:06 p.m., Daniel Barclay wrote
- abdelhakim deneche
On June 17, 2015, 5:06 p.m., Daniel Barclay wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35417/
---
(Updated
/exceptions/ErrorHelper.java
5dd9b67
exec/java-exec/src/main/codegen/templates/TypeHelper.java ad818bd
Diff: https://reviews.apache.org/r/35573/diff/
Testing
---
all unit tests are passing along with functional/tpch100
Thanks,
abdelhakim deneche
indeed
- abdelhakim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35393/#review87899
---
On June 12, 2015, 5:40 p.m., abdelhakim deneche
: https://reviews.apache.org/r/35477/diff/
Testing (updated)
---
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
/diff/
Testing
---
all unit tests are passing...
Thanks,
abdelhakim deneche
.sql PRE-CREATION
exec/java-exec/src/test/resources/window/q3218.sql PRE-CREATION
exec/java-exec/src/test/resources/window/q3220.sql PRE-CREATION
Diff: https://reviews.apache.org/r/35393/diff/
Testing
---
Thanks,
abdelhakim deneche
with functional and tpch100
Thanks,
abdelhakim deneche
/oneKeyCountMultiBatch.json 09a405c
exec/java-exec/src/test/resources/window/twoKeys.json f3ef4a5
exec/java-exec/src/test/resources/window/twoKeysData.json fd09236
Diff: https://reviews.apache.org/r/34977/diff/
Testing
---
unit tests passing. customer/tpch100 passing
Thanks,
abdelhakim deneche
exec/java-exec/src/test/resources/window/twoKeysData.json fd09236
Diff: https://reviews.apache.org/r/34977/diff/
Testing
---
Thanks,
abdelhakim deneche
/resources/window/twoKeysData.json fd09236
Diff: https://reviews.apache.org/r/34977/diff/
Testing (updated)
---
unit tests passing. customer/tpch100 ongoing
Thanks,
abdelhakim deneche
/twoKeysData.json fd09236
Diff: https://reviews.apache.org/r/34977/diff/
Testing (updated)
---
unit tests passing. customer/tpch100 passing
Thanks,
abdelhakim deneche
/java-exec/src/test/resources/window/twoKeys.json f3ef4a5
exec/java-exec/src/test/resources/window/twoKeysData.json fd09236
Diff: https://reviews.apache.org/r/34977/diff/
Testing
---
Thanks,
abdelhakim deneche
/test/resources/window/oneKeyCountMultiBatch.json 09a405c
exec/java-exec/src/test/resources/window/twoKeys.json f3ef4a5
exec/java-exec/src/test/resources/window/twoKeysData.json fd09236
Diff: https://reviews.apache.org/r/34977/diff/
Testing
---
Thanks,
abdelhakim deneche
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34829/#review86032
---
Ship it!
Ship It!
- abdelhakim deneche
On June 1, 2015, 5:54
have
one less class to check involved
- abdelhakim deneche
On May 29, 2015, 8:44 p.m., Sudheesh Katkam wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34829
/
Testing (updated)
---
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
://reviews.apache.org/r/34541/diff/
Testing
---
still need to run the tests!
Thanks,
abdelhakim deneche
-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
https://reviews.apache.org/r/34690/#comment137077
ZookeeperHelper javadoc already explains what happens when we pass true
to it's constructor. We don't need to repeat the explanation here.
- abdelhakim deneche
On May
/
---
(Updated May 27, 2015, 12:52 a.m.)
Review request for drill, abdelhakim deneche, Chris Westin, and Venki
Korukanti.
Bugs: DRILL-2903
https://issues.apache.org/jira/browse/DRILL-2903
Repository: drill-git
Description
---
DRILL-2903: General improvements
/#review85005
---
On May 22, 2015, 5:42 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34603
PRE-CREATION
Diff: https://reviews.apache.org/r/34541/diff/
Testing
---
still need to run the tests!
Thanks,
abdelhakim deneche
protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryResult.java
474e330
protocol/src/main/protobuf/UserBitShared.proto 68c8612
Diff: https://reviews.apache.org/r/34603/diff/
Testing
---
unit tests are passing
Thanks,
abdelhakim deneche
21, 2015, 7:34 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34541/
---
(Updated May 21, 2015, 7:34
/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34541/diff/
Testing (updated)
---
still need to run the tests!
Thanks,
abdelhakim deneche
/#review84727
---
On May 21, 2015, 7:34 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34541
/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34541/diff/
Testing
---
unit tests and tpch100 are passing. Couldn't run functional yet
Thanks,
abdelhakim deneche
. This shouldn't hold off this patch though, as it's more likely a
separate problem
- abdelhakim deneche
On May 14, 2015, 5:25 a.m., Sudheesh Katkam wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/TestDrillbitResilience.java
https://reviews.apache.org/r/34184/#comment134939
Should this test be part of TestDrillbitResilience ?
- abdelhakim deneche
On May 14, 2015, 9:59 p.m., Sean Hsuan-Yi Chu wrote:
---
This is an automatically
/FragmentExecutor.java
https://reviews.apache.org/r/34245/#comment134955
if we return here, this fragment will never send it's final state to the
Foreman
- abdelhakim deneche
On May 15, 2015, 12:10 a.m., Chris Westin wrote
/TestDrillbitResilience.java
https://reviews.apache.org/r/34184/#comment134951
actually I got confused in my previous comment.
Why this unit test is inside TestDrillbitResilience ?
- abdelhakim deneche
On May 14, 2015, 11:14 p.m., Sean Hsuan-Yi Chu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34191/#review83870
---
+1 (non binding)
- abdelhakim deneche
On May 14, 2015, 11:17 p.m
/
Testing
---
not tested yet!!!
Thanks,
abdelhakim deneche
/drill/exec/server/TestDrillbitResilience.java
f95fbe1
Diff: https://reviews.apache.org/r/34253/diff/
Testing
---
not tested yet!!!
Thanks,
abdelhakim deneche
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34255/#review83889
---
+1 (non binding)
- abdelhakim deneche
On May 15, 2015, 2:46 a.m
:
https://reviews.apache.org/r/34173/#review83655
---
On May 13, 2015, 5:54 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
,
abdelhakim deneche
., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34173/
---
(Updated May 13, 2015, 9:07 p.m.)
Review
/drill/TestAllocationException.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34173/diff/
Testing
---
pending results from unit tests / cluster
Thanks,
abdelhakim deneche
/TestAllocationException.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34173/diff/
Testing (updated)
---
unit tests are passing...
Thanks,
abdelhakim deneche
exec/java-exec/src/test/java/org/apache/drill/TestAllocationException.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34173/diff/
Testing (updated)
---
testing...
Thanks,
abdelhakim deneche
?
- abdelhakim deneche
On May 14, 2015, 12:55 a.m., Sean Hsuan-Yi Chu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34184/
---
(Updated
-CREATION
Diff: https://reviews.apache.org/r/34173/diff/
Testing
---
pending results from unit tests / cluster
Thanks,
abdelhakim deneche
/ExecutionControlsInjector.java
387d300
exec/java-exec/src/test/java/org/apache/drill/TestAllocationException.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34173/diff/
Testing
---
pending results from unit tests / cluster
Thanks,
abdelhakim deneche
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34071/#review83446
---
+1 (non binding)
- abdelhakim deneche
On May 12, 2015, 5:49 p.m
this will alter the user exception's message. Sometimes this will clutter
the original error message making it less useful to the user
- abdelhakim deneche
On May 12, 2015, 5:59 a.m., Daniel Barclay wrote:
---
This is an automatically
/WorkManager.java
https://reviews.apache.org/r/34008/#comment134128
We should remove the fragment manager from the work bus if it's fragment
executor has already been cancelled. Otherwise, it will stay in the work bus
forever.
- abdelhakim deneche
On May 10, 2015, 7:13 p.m., Sudheesh Katkam wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33949/#review83284
---
+1 (non binding)
- abdelhakim deneche
On May 11, 2015, 8:36 p.m
the work event bus, so
you don't need to pass the WorkerBee
- abdelhakim deneche
On May 11, 2015, 11:16 p.m., Sudheesh Katkam wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34008
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34008/#review83330
---
Ship it!
Ship It!
- abdelhakim deneche
On May 12, 2015, 12:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34063/#review83314
---
LGTM, +1 (non binding)
- abdelhakim deneche
On May 11, 2015, 11
1 - 100 of 189 matches
Mail list logo
