[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156178698 --- Diff: common/src/main/java/org/apache/drill/common/config/DrillConfig.java --- @@ -45,13 +45,11 @@ private final ImmutableList

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156192043 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java --- @@ -17,483 +17,216 @@ */ package

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156180593 --- Diff: contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java --- @@ -91,9 +90,9 @@ public MongoRecordReader

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156181381 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/BaseOperatorContext.java --- @@ -39,27 +39,29 @@ * version of the operator

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156180661 --- Diff: contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java --- @@ -144,13 +143,12 @@ private void init

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156187558 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java --- @@ -17,483 +17,216 @@ */ package

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156191898 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java --- @@ -17,483 +17,216 @@ */ package

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156181112 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/BaseOperatorContext.java --- @@ -39,27 +39,29 @@ * version of the operator

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156179325 --- Diff: contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java --- @@ -117,7 +116,7 @@ public

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156186475 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/BaseOperatorContext.java --- @@ -161,16 +163,13 @@ public void close

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-11 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156177751 --- Diff: contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java --- @@ -117,7 +116,7 @@ public

Re: YARN & Drill

2017-12-11 Thread Paul Rogers
, at 7:58 AM, Dor Ben Dov mailto:dor.ben-...@amdocs.com>> wrote: Thanks Paul. It seems that it's already done, will it be in 1.12 ? -Original Message- From: Paul Rogers [mailto:prog...@mapr.com] Sent: יום ב 11 דצמבר 2017 02:28 To: dev@drill.apache.org<mailto:dev@drill.apach

Re: [ANNOUNCE] New Committer: Vitalii Diravka

2017-12-10 Thread Paul Rogers
Congrats! Well deserved. - Paul > On Dec 10, 2017, at 3:16 PM, AnilKumar B wrote: > > Congratulations Vitalii > > Thanks & Regards, > B Anil Kumar. > > On Sun, Dec 10, 2017 at 3:12 PM, rahul challapalli < > challapallira...@gmail.com> wrote: > >> Congratulations Vitalii! >> >> On Sun, Dec 1

Re: YARN & Drill

2017-12-10 Thread Paul Rogers
Hi Dor, There is a pull request for Drill-on-YARN support in Apache Drill and YARN. You can download that PR and do your own build. See [1]. - Paul [1] https://github.com/apache/drill/pull/1011 > On Dec 10, 2017, at 12:59 PM, Dor Ben Dov wrote: > > Hi > > Is there any support of Drill with

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939344 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -152,7 +152,10 @@ public void buildSchema

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939440 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java --- @@ -160,4 +166,75 @@ public void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155938557 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -535,4 +537,25 @@ public void close

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939428 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java --- @@ -160,4 +166,75 @@ public void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939350 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/NestedLoopJoinBatch.java --- @@ -418,4 +418,15 @@ protected void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939472 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java --- @@ -333,4 +342,96 @@ public void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939506 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestNullInputMiniPlan.java --- @@ -323,8 +323,6 @@ public void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939424 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java --- @@ -160,4 +166,75 @@ public void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939358 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractBinaryRecordBatch.java --- @@ -65,11 +65,20 @@ protected boolean

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939417 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java --- @@ -160,4 +166,75 @@ public void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939449 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java --- @@ -253,4 +259,75 @@ public void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939459 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java --- @@ -333,4 +342,96 @@ public void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155938551 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -535,4 +537,25 @@ public void close

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939394 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java --- @@ -228,4 +228,20 @@ public WritableBatch

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939354 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -97,6 +97,14 @@ protected void

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r155939311 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -535,4 +537,25 @@ public void close

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r155938262 --- Diff: common/src/test/java/org/apache/drill/test/DrillTest.java --- @@ -54,7 +54,7 @@ static MemWatcher memWatcher; static String

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r155938285 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -61,12 +63,14 @@ public class WorkManager implements

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-12-09 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r155938213 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -502,33 +438,82 @@ private void runFragment(List

Re: Parquet's new table format

2017-12-08 Thread Paul Rogers
Very cool indeed. Iceberg, if I understand the post, is a file container format: it identifies the set of files (in this case, Parquet files) that make up a “table.” Since Iceberg mentions Hive, it presumably would work for any file format (since it is just a file container.) This would be a g

[jira] [Created] (DRILL-6015) Unit tests fail in Eclipse because source is not on class path

2017-12-06 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-6015: -- Summary: Unit tests fail in Eclipse because source is not on class path Key: DRILL-6015 URL: https://issues.apache.org/jira/browse/DRILL-6015 Project: Apache Drill

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154478390 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/cache/TestBatchSerialization.java --- @@ -117,11 +117,12 @@ public void testNullableType

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154477971 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/BatchGroup.java --- @@ -280,17 +278,14 @@ private void

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154476694 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154475785 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154478770 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154475350 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154478289 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/BatchGroup.java --- @@ -249,7 +247,7 @@ public void close

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154477573 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java --- @@ -331,6 +337,43 @@ public long getReadBytes

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154477089 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154476440 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -40,20 +52,18 @@ */ public static

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154477815 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java --- @@ -419,6 +462,13 @@ public SpillSet(DrillConfig

Re: [VOTE] Release Apache Drill 1.12.0 - rc0

2017-12-01 Thread Paul Rogers
Downloaded built gz file. Ran Drill. Exercised the queue-based memory allocation options and ran a query. Functionality and UI passed basic sanity tests. (UI tests are not yet automated, so this verification has to be done by hand.) Krystal had done a full test earlier, which passed. So, +1 -

[GitHub] drill pull request #1057: DRILL-5993 Append Row Method For VectorContainer (...

2017-11-29 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1057#discussion_r153926390 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java --- @@ -353,6 +353,23 @@ public int getRecordCount

[GitHub] drill issue #1057: DRILL-5993 Append Row Method For VectorContainer (WIP)

2017-11-29 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1057 To answer the two questions: 1. The copier is used in multiple locations, some of which include selection vectors. Sort uses a copier to merge rows coming from multiple sorted batches

[GitHub] drill issue #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-28 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/921 My suggestion is to go ahead and commit this PR with Jyothsna's change to disable the "graceful" part of the graceful shutdown. The feature will be in the product and people ca

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153407376 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/ThrottledResourceManager.java --- @@ -314,13 +315,49 @@ public void exit

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153394006 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -426,48 +413,25 @@ private void runPhysicalPlan(final

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153406144 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153389793 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/QueryWorkUnit.java --- @@ -112,4 +115,46 @@ public void applyPlan(PhysicalPlanReader

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153403800 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153404245 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153406881 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/DefaultResourceManager.java --- @@ -73,13 +75,20 @@ public void setCost

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153403438 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -873,105 +791,133 @@ public void close() throws Exception

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153405107 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153405899 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153405303 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153402805 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -426,48 +413,25 @@ private void runPhysicalPlan(final

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153407221 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/QueryResourceManager.java --- @@ -38,22 +35,17 @@ * For some cases

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153404840 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153389627 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileUtil.java --- @@ -19,30 +19,35 @@ import

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153403903 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153389550 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileUtil.java --- @@ -19,30 +19,35 @@ import

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153406564 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java --- @@ -280,29 +280,29 @@ public void interrupted(final

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153407320 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/ThrottledResourceManager.java --- @@ -288,8 +287,10 @@ public void setCost

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153405696 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill issue #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/921 Interesting issue! Let's think about this a bit. In a production system, we do want the grace period; it is an essential part of the graceful shutdown procedure. However,

[GitHub] drill issue #914: DRILL-5657: Size-aware vector writer structure

2017-11-22 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/914 Addressed Karthik's comments, rebased on master, resolved conflicts, and squashed all but the conflict resolution commit. ---

[jira] [Created] (DRILL-5988) Revise operator status for OperatorFixture

2017-11-22 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-5988: -- Summary: Revise operator status for OperatorFixture Key: DRILL-5988 URL: https://issues.apache.org/jira/browse/DRILL-5988 Project: Apache Drill Issue Type

[GitHub] drill pull request #914: DRILL-5657: Size-aware vector writer structure

2017-11-22 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/914#discussion_r152664121 --- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java --- @@ -882,4 +882,71 @@ public void print(StringBuilder sb, int indent, Verbosity

[GitHub] drill issue #914: DRILL-5657: Size-aware vector writer structure

2017-11-21 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/914 Thanks, Parth! Will make another commit to address small issues that Karthik pointed out. Let's hold off the actual commit until Drill 1.12 ships. I'll then commit the changes when we o

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-21 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r152361270 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/RpcType.java --- @@ -25,28 +25,8 @@ HANDSHAKE(0), ACK(1

[jira] [Resolved] (DRILL-5974) Read JSON non-relational fields using text mode

2017-11-20 Thread Paul Rogers (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Rogers resolved DRILL-5974. Resolution: Won't Fix Discussion on the dev list suggested that we want to keep the cu

Re: JSON reader enhancement

2017-11-19 Thread Paul Rogers
ork. The values that Drill provides will have all fields > marked as present. > > (at least, this was true at one time). > > > > > > On Sun, Nov 19, 2017 at 4:33 AM, Paul Rogers wrote: > >> Hi Arina, >> >> The proposal is to represent 2D arra

Re: JSON reader enhancement

2017-11-18 Thread Paul Rogers
Right? Or > we need to come up with new function? > > Kind regards > Arina > > On Fri, Nov 17, 2017 at 10:39 PM, Paul Rogers wrote: > >> Hi All, >> >> I’d like to propose a minor enhancement to the JSON reader to better >> handle non-relationa

JSON reader enhancement

2017-11-17 Thread Paul Rogers
Hi All, I’d like to propose a minor enhancement to the JSON reader to better handle non-relational JSON structures. (See DRILL-5974 [1].) As background, Drill handles simple tuples: {a: 10, b: “fred”} Drill also handles arrays: {name: “fred”, hobbies: [“bowling”, “golf”]} Drill even handles

[jira] [Created] (DRILL-5974) Read JSON non-relational fields using text mode

2017-11-17 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-5974: -- Summary: Read JSON non-relational fields using text mode Key: DRILL-5974 URL: https://issues.apache.org/jira/browse/DRILL-5974 Project: Apache Drill Issue Type

[GitHub] drill issue #914: DRILL-5657: Size-aware vector writer structure

2017-11-17 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/914 There has been discussion recently on Drill's goal of integrating with Arrow. The work to use the `Drillbuf` highlights how we can integrate with Arrow. Simply replace the `Drillbuf` usage

[GitHub] drill issue #914: DRILL-5657: Size-aware vector writer structure

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/914 Regarding the use of memory addresses. The only reason to do so is performance. To show the benefit of using addresses, I reran the `PerformanceTool` class to test the original code, the code

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151585383 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java --- @@ -0,0 +1,176 @@ +/* + * Licensed to the

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151587965 --- Diff: contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/MessageIteratorTest.java --- @@ -0,0 +1,105 @@ +/* + * Licensed

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151585461 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java --- @@ -0,0 +1,176 @@ +/* + * Licensed to the

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151586477 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/MessageReaderFactory.java --- @@ -0,0 +1,56

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151582174 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java --- @@ -0,0 +1,176 @@ +/* + * Licensed to the

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151584935 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/JsonMessageReader.java --- @@ -0,0 +1,104

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151581827 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java --- @@ -0,0 +1,144 @@ +/* + * Licensed

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151585334 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java --- @@ -0,0 +1,176 @@ +/* + * Licensed to the

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151583591 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/MessageReaderFactory.java --- @@ -0,0 +1,56

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151587030 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151586853 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java --- @@ -0,0 +1,144 @@ +/* + * Licensed

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151584017 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/MessageReaderFactory.java --- @@ -0,0 +1,56

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151581968 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java --- @@ -0,0 +1,176 @@ +/* + * Licensed to the

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151581581 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaStoragePlugin.java --- @@ -0,0 +1,100 @@ +/* + * Licensed

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151585930 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaStoragePluginConfig.java --- @@ -0,0 +1,79

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151588038 --- Diff: contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/MessageIteratorTest.java --- @@ -0,0 +1,105 @@ +/* + * Licensed

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-16 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151584428 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/MessageReader.java --- @@ -0,0 +1,45

<    5   6   7   8   9   10   11   12   13   14   >