Re: Review Request 53414: GEODE-2065 Document defragmentationsInProgress statistic

2016-11-02 Thread Joey McAllister
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53414/#review154661 --- Ship it! Ship It! - Joey McAllister On Nov. 2, 2016, 11:52

Review Request 53414: GEODE-2065 Document defragmentationsInProgress statistic

2016-11-02 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53414/ --- Review request for geode, Dave Barnes, Darrel Schneider, and Joey McAllister.

Review Request 53410: GEODE-2064 Added check for system shutdown while handlling connect exception.

2016-11-02 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53410/ --- Review request for geode, Bruce Schuchardt, Darrel Schneider, Eric Shu, Scott

[GitHub] incubator-geode issue #276: GEODE-1993: postprocess region/key

2016-11-02 Thread kjduling
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/276 Don't accept this PR yet. This is just a checkin to preserve work. Addressed all of the issues listed above. Added test for adhoc queries. Still need a test for named queries.

Re: Review Request 53401: GEODE-1932: Protected use of global variables

2016-11-02 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53401/#review154645 ---

Re: Review Request 53401: GEODE-1932: Protected use of global variables

2016-11-02 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53401/#review154643 --- Ship it! Ship It! - xiaojian zhou On Nov. 2, 2016, 8:14

Re: Review Request 53402: GEODE-2013: throw IllegalStateException if resource type is missing

2016-11-02 Thread Kirk Lund
> On Nov. 2, 2016, 8:26 p.m., Kevin Duling wrote: > > What is the possibility of an ArrayIndexOutOfBoundsException on that > > assignment? The ArrayIndexOutOfBoundsException message already contains the resourceTypeId because the array position is the type id. Still, it's a good idea and I'll

Re: Review Request 53402: GEODE-2013: throw IllegalStateException if resource type is missing

2016-11-02 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53402/#review154635 --- Ship it! Ship It! - Darrel Schneider On Nov. 2, 2016, 1:07

Re: Apache policy on files types allowed in source code

2016-11-02 Thread Kirk Lund
I do have a particular case in mind involving stats files that geode creates and reads. The StatArchiveWriter.java class writes out statistic archive files for geode, while StatArchiveReader.java reads them in. There have been a few bugs causing the stats files to be corrupted in some way. My

Re: Review Request 53402: GEODE-2013: throw IllegalStateException if resource type is missing

2016-11-02 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53402/#review154629 --- Ship it! Ship It! - Jinmei Liao On Nov. 2, 2016, 8:07 p.m.,

Re: Review Request 53401: GEODE-1932: Protected use of global variables

2016-11-02 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53401/#review154627 --- Fix it, then Ship it!

Re: Apache policy on files types allowed in source code

2016-11-02 Thread Roman Shaposhnik
On Wed, Nov 2, 2016 at 1:16 PM, Kirk Lund wrote: > I'd like to read up on what's allowed and disallowed regarding file types > in Apache source code. Does anyone have any links to get me started? The only distinction that ASF makes is binaries vs. source files. The source code

Apache policy on files types allowed in source code

2016-11-02 Thread Kirk Lund
I'd like to read up on what's allowed and disallowed regarding file types in Apache source code. Does anyone have any links to get me started? Thanks, Kirk

Review Request 53401: GEODE-1932: Protected use of global variables

2016-11-02 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53401/ --- Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian

Review Request 53402: GEODE-2013: throw IllegalStateException if resource type is missing

2016-11-02 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53402/ --- Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Jared

Re: Review Request 53399: Removing some string comparisons in the AttributesDescriptor

2016-11-02 Thread Jason Huynh
> On Nov. 2, 2016, 7:58 p.m., Jason Huynh wrote: > > Ship It! Do you think a unit test should be written for this? Not sure how difficult or useful it would be... - Jason --- This is an automatically generated e-mail. To reply,

Re: Review Request 53399: Removing some string comparisons in the AttributesDescriptor

2016-11-02 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53399/#review154620 --- Ship it! Ship It! - Jason Huynh On Nov. 2, 2016, 7:29 p.m.,

Re: Review Request 53398: GEODE-1985: Updating the SAFE_QUERY_TIME after updating indexes

2016-11-02 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53398/#review154621 --- Ship it! Ship It! - Jason Huynh On Nov. 2, 2016, 7:26 p.m.,

Re: Review Request 53355: fix deadlock caused by how the GemFireCacheImpl class synchronization is done

2016-11-02 Thread Scott Jewell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53355/#review154618 --- Ship it! Ship It! - Scott Jewell On Nov. 1, 2016, 11:25

Review Request 53399: Removing some string comparisons in the AttributesDescriptor

2016-11-02 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53399/ --- Review request for geode, Jason Huynh and nabarun nag. Repository: geode

Review Request 53398: GEODE-1985: Updating the SAFE_QUERY_TIME after updating indexes

2016-11-02 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53398/ --- Review request for geode, Jason Huynh and nabarun nag. Repository: geode

Re: Review Request 53388: GEODE-2059 client SSL handshake attempts do not time out

2016-11-02 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53388/#review154616 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 2, 2016, 4:57

Re: Review Request 53355: fix deadlock caused by how the GemFireCacheImpl class synchronization is done

2016-11-02 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53355/#review154615 ---

Re: jmh benchmarks

2016-11-02 Thread William Markito Oliveira
+1 Sent from my iPhone > On Nov 2, 2016, at 11:35 AM, Udo Kohlmeyer wrote: > > +2 > > >> On 3/11/16 5:17 am, Dan Smith wrote: >> Hi all, >> >> I'd like to add some support for running benchmarks with jmh to geode. Is >> this something we're interested in having? JMH

Re: jmh benchmarks

2016-11-02 Thread Udo Kohlmeyer
+2 On 3/11/16 5:17 am, Dan Smith wrote: Hi all, I'd like to add some support for running benchmarks with jmh to geode. Is this something we're interested in having? JMH is a framework for easily writing microbenchmarks. It's probably not that useful for large scale multiple member benchmarks,

Re: PMC nomination

2016-11-02 Thread Bruce Schuchardt
Great - thanks Greg Le 11/2/2016 à 11:31 AM, Gregory Chase a écrit : I saw your post to @private. On Wed, Nov 2, 2016 at 11:27 AM, Bruce Schuchardt wrote: I've been trying to join the private email list all morning & self-nominate for the PMC if it's not too late

Re: PMC nomination

2016-11-02 Thread Gregory Chase
I saw your post to @private. On Wed, Nov 2, 2016 at 11:27 AM, Bruce Schuchardt wrote: > I've been trying to join the private email list all morning & > self-nominate for the PMC if it's not too late > -- Greg Chase Global Head, Big Data Communities

PMC nomination

2016-11-02 Thread Bruce Schuchardt
I've been trying to join the private email list all morning & self-nominate for the PMC if it's not too late

Re: jmh benchmarks

2016-11-02 Thread Jared Stewart
+1 Jmh is great On Nov 2, 2016 11:18 AM, "Dan Smith" wrote: > Hi all, > > I'd like to add some support for running benchmarks with jmh to geode. Is > this something we're interested in having? JMH is a framework for easily > writing microbenchmarks. It's probably not that

jmh benchmarks

2016-11-02 Thread Dan Smith
Hi all, I'd like to add some support for running benchmarks with jmh to geode. Is this something we're interested in having? JMH is a framework for easily writing microbenchmarks. It's probably not that useful for large scale multiple member benchmarks, but it can help us benchmark and optimize

Re: Review Request 53395: Adding a geode-benchmark project with support for running jmh benchmarks

2016-11-02 Thread William Markito
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53395/#review154604 --- Ship it! Thanks for doing this Dan! Would love to see a README

Review Request 53395: Adding a geode-benchmark project with support for running jmh benchmarks

2016-11-02 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53395/ --- Review request for geode. Repository: geode Description --- Adding a

Re: Backwards compatibility for 1.1

2016-11-02 Thread Dan Smith
+1 for getting Bruc'e's backwards compatibility testing framework in! -Dan On Wed, Nov 2, 2016 at 10:50 AM, Anilkumar Gingade wrote: > Right, to be enterprise class software product, it needs to be backward > compatible...We also need to consider rolling upgrade of the

Re: Backwards compatibility for 1.1

2016-11-02 Thread Anilkumar Gingade
Right, to be enterprise class software product, it needs to be backward compatible...We also need to consider rolling upgrade of the system Thanks, Dan, Bruce for the write-up and frame-work... -Anil. On Wed, Nov 2, 2016 at 10:37 AM, William Markito Oliveira < william.mark...@gmail.com>

Re: Backwards compatibility for 1.1

2016-11-02 Thread William Markito Oliveira
+1 On Wed, Nov 2, 2016 at 10:30 AM, Swapnil Bawaskar wrote: > +1 for maintaining backwards compatibility. > > On Wed, Nov 2, 2016 at 9:40 AM, Mark Bretl wrote: > > > +1 for backward compatibility with Geode releases. > > > > --Mark > > > > On Wed,

Re: Backwards compatibility for 1.1

2016-11-02 Thread Swapnil Bawaskar
+1 for maintaining backwards compatibility. On Wed, Nov 2, 2016 at 9:40 AM, Mark Bretl wrote: > +1 for backward compatibility with Geode releases. > > --Mark > > On Wed, Nov 2, 2016 at 8:11 AM, Kenneth Howe wrote: > > > +1 to Dan > > +1 to Bruce - the

Review Request 53388: GEODE-2059 client SSL handshake attempts do not time out

2016-11-02 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53388/ --- Review request for geode and Udo Kohlmeyer. Bugs: GEODE-2059

Re: Backwards compatibility for 1.1

2016-11-02 Thread Mark Bretl
+1 for backward compatibility with Geode releases. --Mark On Wed, Nov 2, 2016 at 8:11 AM, Kenneth Howe wrote: > +1 to Dan > +1 to Bruce - the distributedTest extensions for backward compatibility > would great > > > On Nov 1, 2016, at 4:11 PM, Bruce Schuchardt

Build failed in Jenkins: Geode-nightly #641

2016-11-02 Thread Apache Jenkins Server
See Changes: [kmiller] GEODE-2045 Improve docs of region shortcuts [klund] GEODE-2012: always write stat types to archive [kmiller] GEODE-2047 Document change to enable-network-partition-detection [upthewaterspout] Correcting javadocs

Re: Review Request 53360: GEODE-2050 Remove doc of statistics no longer present

2016-11-02 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53360/#review154565 --- Ship it! Ship It! - Bruce Schuchardt On Nov. 1, 2016, 11:55

Re: Backwards compatibility for 1.1

2016-11-02 Thread Kenneth Howe
+1 to Dan +1 to Bruce - the distributedTest extensions for backward compatibility would great > On Nov 1, 2016, at 4:11 PM, Bruce Schuchardt wrote: > > +1 > > I still have the backward-compatibility distributedTest extensions that I > could contribute. The extension